Skip to content
  • eric.carlson@apple.com's avatar
    Not all subtitle tracks are SDH · 7f3fdee9
    eric.carlson@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=117738
    
    Reviewed by Dean Jackson.
    
    Source/WebCore:
    
    No new tests, existing tests updated.
    
    * html/track/InbandTextTrack.cpp:
    (WebCore::InbandTextTrack::isSDH): New.
    
    * html/track/InbandTextTrack.h: Add isSDH override.
    * html/track/TextTrack.h:
    
    * page/CaptionUserPreferencesMac.mm:
    (WebCore::trackDisplayName): Only add "SDH" label if a track claims to be SDH.
    
    * platform/graphics/InbandTextTrackPrivate.h:
    (WebCore::InbandTextTrackPrivate::isSDH): New.
    
    * platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.h:
    * platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
    (WebCore::InbandTextTrackPrivateAVFObjC::isSDH): Return true if track has both "transcribes
        spoken dialog for accessibility" and "describes music and sound for accessibility"
        characteristics.
    
    LayoutTests:
    
    * media/video-controls-captions-trackmenu-localized.html:
    * media/video-controls-captions-trackmenu-sorted.html:
    * platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
    * platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt:
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    7f3fdee9