Skip to content
  • jer.noble@apple.com's avatar
    [Mac] .mp3 media document controls missing their background · c3e041a8
    jer.noble@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=126683
    
    Reviewed by Eric Carlson.
    
    Source/WebCore:
    
    Test: media/media-document-audio-controls-visible.html
    
    <video> elements in a media document are created with an intrinsic size of 300x1,
    with the expectation that either the size will be updated if the media has a video
    track, or the controls will visibly overflow if the media is audio-only. Since the
    shadow root is a flex-box, the panel was being collapsed to 1px high, so give the panel
    a minimum height to prevent that. Also, disable "fading out" the controls in a
    media document for an audio-only file by adding a "no-video" class to the panel
    and adding a media document-only rule to force the controls to always be visible.
    
    * Modules/mediacontrols/mediaControlsApple.css:
    (video:-webkit-full-page-media::-webkit-media-controls-panel.no-video):
    (audio::-webkit-media-controls-panel):
    * Modules/mediacontrols/mediaControlsApple.js:
    (Controller): Call updateHasVideo().
    (Controller.prototype.addVideoListeners): Add video track listeners.
    (Controller.prototype.removeVideoListeners): Remove same.
    (Controller.prototype.updateHasVideo): Add a 'no-video' class to the panel if
        the video element has no video tracks.
    
    LayoutTests:
    
    * media/media-document-audio-controls-visible-expected.txt: Added.
    * media/media-document-audio-controls-visible.html: Added.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    c3e041a8