Skip to content
  • vsevik@chromium.org's avatar
    Web Inspector: Decouple various file system project implementation parts for... · 03aa0d8f
    vsevik@chromium.org authored
    Web Inspector: Decouple various file system project implementation parts for better testability and cover with tests.
    https://bugs.webkit.org/show_bug.cgi?id=110204
    
    Reviewed by Pavel Feldman.
    
    Source/WebCore:
    
    Extracted FileSystemWorkspaceProvider from IsolatedFileSystemManager to take care of managing workspace projects and projectDelegates.
    Replaced FileMapping.urlForURI with urlForPath method that does not need any information about workspace structure anymore.
    
    Test: inspector/file-system-project.html
    
    * inspector/front-end/FileMapping.js:
    (WebInspector.FileMapping.prototype.urlForPath):
    * inspector/front-end/FileSystemProjectDelegate.js:
    (WebInspector.FileSystemProjectDelegate):
    (WebInspector.FileSystemProjectDelegate.prototype.populate.filesLoaded):
    (WebInspector.FileSystemProjectDelegate.prototype.populate):
    (WebInspector.FileSystemWorkspaceProvider):
    (WebInspector.FileSystemWorkspaceProvider.prototype._fileSystemAdded):
    (WebInspector.FileSystemWorkspaceProvider.prototype._fileSystemRemoved):
    * inspector/front-end/IsolatedFileSystem.js:
    (WebInspector.IsolatedFileSystem):
    (WebInspector.IsolatedFileSystem.prototype.name):
    (WebInspector.IsolatedFileSystem.prototype.rootURL):
    * inspector/front-end/IsolatedFileSystemManager.js:
    (WebInspector.IsolatedFileSystemManager):
    (WebInspector.IsolatedFileSystemManager.prototype._innerAddFileSystem):
    (WebInspector.IsolatedFileSystemManager.prototype._fileSystemRemoved):
    (WebInspector.IsolatedFileSystemManager.prototype._isolatedFileSystem):
    (WebInspector.IsolatedFileSystemManager.prototype.requestDOMFileSystem):
    * inspector/front-end/inspector.js:
    
    LayoutTests:
    
    * http/tests/inspector/inspector-test.js:
    (initialize_InspectorTest):
    (initialize_InspectorTest.):
    * http/tests/inspector/workspace-test.js:
    (initialize_WorkspaceTest.uiSourceCodeAdded):
    (initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent):
    (initialize_WorkspaceTest.InspectorTest._defaultUISourceCodeProviderEventHandler):
    * inspector/file-mapping-expected.txt:
    * inspector/file-mapping.html:
    * inspector/file-system-project-expected.txt: Added.
    * inspector/file-system-project.html: Added.
    * inspector/version-controller.html:
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@143327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    03aa0d8f