Skip to content
  • commit-queue@webkit.org's avatar
    Web Inspector: DataGrid refactoring: make cell editing more generic. · 289bb1a5
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=105849
    
    Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-01-10
    Reviewed by Pavel Feldman.
    
    Source/WebCore:
    
    Editing feature has been added to DataGrid to edit localStorage.
    Column numbers (0 and 1) are hardcoded.
    
    This patch makes column editing feature more generic: remove hardcoded
    colums, take "editable" column property into account.
    
    This patch is a prerequisite for cookie editing.
    
    * inspector/front-end/DOMStorageItemsView.js:
    Use meaningful column names.
    * inspector/front-end/DataGrid.js:
    (WebInspector.DataGrid.prototype._ondblclick): Check column editability.
    (WebInspector.DataGrid.prototype._contextMenuInDataTable): Ditto.
    (WebInspector.DataGridNode.prototype.createCell):
    Supply cell element with column id.
    (WebInspector.DataGrid.prototype.columnIdentifierFromNode):
    Added utility method.
    (WebInspector.DataGrid.prototype._nextEditableColumn): Ditto.
    (WebInspector.DataGrid.prototype._keyDown): Calculate editable column.
    (WebInspector.DataGrid.prototype._editingCommitted): Ditto.
    (WebInspector.DataGrid.prototype._startEditing): Ditto.
    (WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode):
    Refined parameter type / name.
    (WebInspector.DataGrid.prototype._resizerDragging):
    Fix resizer index property names.
    (WebInspector.DataGrid.prototype._startResizerDragging): Ditto.
    (WebInspector.DataGrid.prototype._positionResizers): Ditto.
    * inspector/front-end/NetworkPanel.js:
    (WebInspector.NetworkLogView.prototype._updateDividersIfNeeded): Ditto.
    
    LayoutTests:
    
    * inspector/storage-panel-dom-storage-update.html: Fix column names.
    * inspector/storage-panel-dom-storage.html: Ditto.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    289bb1a5