Skip to content
  • inferno@chromium.org's avatar
    No isChildAllowed checked when adding RenderFullScreen as the child.. · ad473f5c
    inferno@chromium.org authored
    https://bugs.webkit.org/show_bug.cgi?id=92995
    
    Reviewed by Eric Seidel.
    
    Source/WebCore:
    
    Test: fullscreen/fullscreen-child-not-allowed-crash.html
    
    * dom/Document.cpp:
    (WebCore::Document::webkitWillEnterFullScreenForElement): pass the object's parent
    pointer as an additional argument.
    * dom/NodeRenderingContext.cpp:
    (WebCore::NodeRendererFactory::createRendererIfNeeded): pass the to be parent |parentRenderer|
    as the argument.
    * rendering/RenderFullScreen.cpp:
    (RenderFullScreen::wrapRenderer): make sure that parent allows RenderFullScreen as the child.
    * rendering/RenderFullScreen.h:
    (RenderFullScreen): support the object's parent
    pointer as an additional argument.
    
    LayoutTests:
    
    * fullscreen/fullscreen-child-not-allowed-crash-expected.txt: Added.
    * fullscreen/fullscreen-child-not-allowed-crash.html: Added.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124491 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    ad473f5c