Skip to content
  • commit-queue@webkit.org's avatar
    Exiting fullscreen shouldn't crash if the element that was fullscreened · 9eea0335
    commit-queue@webkit.org authored
    had associated anonymous blocks.
    https://bugs.webkit.org/show_bug.cgi?id=68503
    
    Source/WebCore:
    
    Patch by Jeremy Apthorp <jeremya@chromium.org> on 2011-10-10
    Reviewed by Simon Fraser.
    
    Test: fullscreen/full-screen-render-inline.html
    Test: fullscreen/parent-flow-inline-with-block-child.html
    
    * rendering/RenderBlock.cpp:
    (WebCore::RenderBlock::moveChildTo):
    (WebCore::RenderBlock::moveChildrenTo):
    * rendering/RenderBlock.h:
    (WebCore::RenderBlock::moveChildTo):
    (WebCore::RenderBlock::moveAllChildrenTo):
    (WebCore::RenderBlock::moveChildrenTo):
    * rendering/RenderFullScreen.cpp:
    (RenderFullScreen::unwrapRenderer):
    Move all children back to the parent, not just the firstChild.
    
    LayoutTests:
    
    When exiting fullscreen, if the child of the RenderFullScreen is a
    block and the parent has inline flow elements, the parent's children
    should be made non-inline before adding the fullscreened element back
    to the parent.
    
    Patch by Jeremy Apthorp <jeremya@chromium.org> on 2011-10-10
    Reviewed by Simon Fraser.
    
    * fullscreen/full-screen-render-inline.html: Added.
    * fullscreen/full-screen-render-inline-expected.png: Added.
    * fullscreen/full-screen-render-inline-expected.txt: Added.
    * fullscreen/parent-flow-inline-with-block-child.html: Added.
    * fullscreen/parent-flow-inline-with-block-child-expected.png: Added.
    * fullscreen/parent-flow-inline-with-block-child-expected.txt: Added.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@97088 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    9eea0335