Skip to content
  • jochen@chromium.org's avatar
    A page should exit fullscreen mode if it opens a new popup · 6aaeed5d
    jochen@chromium.org authored
    https://bugs.webkit.org/show_bug.cgi?id=122865
    
    Reviewed by Jer Noble.
    
    Source/WebKit/blackberry:
    
    If a fullscreen page opens a popup, the popup would be hidden and
    therefore invisible to the user. To avoid this, exit fullscreen mode
    before opening a new window.
    
    * WebCoreSupport/ChromeClientBlackBerry.cpp:
    (WebCore::ChromeClientBlackBerry::createWindow):
    
    Source/WebKit/efl:
    
    If a fullscreen page opens a popup, the popup would be hidden and
    therefore invisible to the user. To avoid this, exit fullscreen mode
    before opening a new window.
    
    * WebCoreSupport/ChromeClientEfl.cpp:
    (WebCore::ChromeClientEfl::createWindow):
    
    Source/WebKit/gtk:
    
    If a fullscreen page opens a popup, the popup would be hidden and
    therefore invisible to the user. To avoid this, exit fullscreen mode
    before opening a new window.
    
    * WebCoreSupport/ChromeClientGtk.cpp:
    (WebKit::ChromeClient::createWindow):
    
    Source/WebKit/mac:
    
    If a fullscreen page opens a popup, the popup would be hidden and
    therefore invisible to the user. To avoid this, exit fullscreen mode
    before opening a new window.
    
    * WebCoreSupport/WebChromeClient.mm:
    (WebChromeClient::createWindow):
    
    Source/WebKit/win:
    
    If a fullscreen page opens a popup, the popup would be hidden and
    therefore invisible to the user. To avoid this, exit fullscreen mode
    before opening a new window.
    
    * WebCoreSupport/WebChromeClient.cpp:
    (WebChromeClient::createWindow):
    
    Source/WebKit2:
    
    If a fullscreen page opens a popup, the popup would be hidden and
    therefore invisible to the user. To avoid this, exit fullscreen mode
    before opening a new window.
    
    * WebProcess/WebCoreSupport/WebChromeClient.cpp:
    (WebKit::WebChromeClient::createWindow):
    
    LayoutTests:
    
    * fullscreen/full-screen-exit-when-popup-expected.txt: Added.
    * fullscreen/full-screen-exit-when-popup.html: Added.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157534 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    6aaeed5d