Skip to content
  • commit-queue@webkit.org's avatar
    [chromium] Ensure that animations continue to run when transform-style is changed · 0b83a6ba
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=83283
    
    Source/WebCore:
    
    Make sure that we transfer animations when changing layers due to a transform-style change.
    Unit tested in GraphicsLayerChromiumTest.updateLayerPreserves3DWithAnimations
    
    Patch by Ian Vollick <vollick@chromium.org> on 2012-05-11
    Reviewed by James Robinson.
    
    Test: animations/change-transform-style-during-animation.html
    
    * platform/graphics/chromium/GraphicsLayerChromium.cpp:
    (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
    * platform/graphics/chromium/LayerChromium.cpp:
    (WebCore::LayerChromium::setLayerAnimationController):
    (WebCore::LayerChromium::releaseLayerAnimationController):
    (WebCore):
    (WebCore::LayerChromium::notifyAnimationStarted):
    * platform/graphics/chromium/LayerChromium.h:
    (LayerChromium):
    * platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
    (WebCore::CCLayerAnimationController::CCLayerAnimationController):
    (WebCore::CCLayerAnimationController::pushAnimationUpdatesTo):
    (WebCore::CCLayerAnimationController::notifyAnimationStarted):
    (WebCore::CCLayerAnimationController::setClient):
    (WebCore):
    (WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
    (WebCore::CCLayerAnimationController::replaceImplThreadAnimations):
    * platform/graphics/chromium/cc/CCLayerAnimationController.h:
    (CCLayerAnimationController):
    (WebCore::CCLayerAnimationController::setForceSync):
    
    Source/WebKit/chromium:
    
    Patch by Ian Vollick <vollick@chromium.org> on 2012-05-11
    Reviewed by James Robinson.
    
    * WebKit.gypi:
    * tests/GraphicsLayerChromiumTest.cpp: Added.
    (WebKitTests):
    (MockGraphicsLayerClient):
    (WebKitTests::MockGraphicsLayerClient::notifyAnimationStarted):
    (WebKitTests::MockGraphicsLayerClient::notifySyncRequired):
    (WebKitTests::MockGraphicsLayerClient::paintContents):
    (WebKitTests::MockGraphicsLayerClient::showDebugBorders):
    (WebKitTests::MockGraphicsLayerClient::showRepaintCounter):
    (WebKitTests::TEST):
    
    LayoutTests:
    
    Patch by Ian Vollick <vollick@chromium.org> on 2012-05-11
    Reviewed by James Robinson.
    
    * animations/change-transform-style-during-animation-expected.png: Added.
    * animations/change-transform-style-during-animation-expected.txt: Added.
    * animations/change-transform-style-during-animation.html: Added.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    0b83a6ba