• simon.fraser@apple.com's avatar
    Source/WebCore: Appearance of compound transform animations under apps linked... · 9ef517df
    simon.fraser@apple.com authored
    Source/WebCore: Appearance of compound transform animations under apps linked on SnowLeopard is incorrect
    https://bugs.webkit.org/show_bug.cgi?id=72641
    and
    <rdar://problem/10314267>
    
    Reviewed by Dean Jackson.
    
    GraphicsLayerCA contains a "linked on or after" check to account for a bug in
    Core Animation on SnowLeopard and earlier, which is that CA would apply the list
    of animations in reverse order.
    
    Our previous fix was incorrect, because it only adjusted the 'additive' property
    of the animation list based on ordering, rather than flipping the entire list.
    This change reverses the list of animations before giving them to CA, which fixes
    the bug.
    
    Test: animations/additive-transform-animations.html
    
    * platform/graphics/ca/GraphicsLayerCA.cpp:
    (WebCore::GraphicsLayerCA::appendToUncommittedAnimations):
    (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
    * platform/graphics/ca/GraphicsLayerCA.h:
    
    LayoutTests: Appearance of compound transform animations under apps linked on SnowLeopard is incorrect
    https://bugs.webkit.org/show_bug.cgi?id=72641
    
    Reviewed by Dean Jackson.
    
    Pixel test for a hardware-animated tranform, where order of operations matters.
    
    * animations/additive-transform-animations-expected.png: Added.
    * animations/additive-transform-animations.html: Added.
    * platform/mac/animations/additive-transform-animations-expected.txt: Added.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100800 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    9ef517df
additive-transform-animations.html 1.02 KB