Skip to content
  • dmazzoni@google.com's avatar
    AX: Improve table-guessing heuristics · cdb4f678
    dmazzoni@google.com authored
    https://bugs.webkit.org/show_bug.cgi?id=107042
    
    Reviewed by Chris Fleizach.
    
    Source/WebCore:
    
    Adds some more rules so that tables with cell borders, empty-cells,
    col, colgroup, or >= 20 rows are all considered data tables, not
    layout tables.
    
    Test: accessibility/table-detection.html (modified)
    
    * accessibility/AccessibilityTable.cpp:
    (WebCore::AccessibilityTable::isDataTable):
    
    Tools:
    
    Implement parentElementCallback on Chromium to make testing easier.
    
    * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
    (WebTestRunner::AccessibilityUIElement::parentElementCallback):
    
    LayoutTests:
    
    Add tests for tables with cell borders, empty-cells,
    col, colgroup, and >= 20 rows. Refactor the test to make it
    easier to read the output and see whether it passed or not.
    
    * accessibility/table-detection.html: Modified.
    * platform/chromium/TestExpectations: Un-skip table-detection.html.
    * platform/chromium/accessibility/table-detection-expected.txt: Added.
    * platform/mac/accessibility/table-detection-expected.txt: Moved.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140181 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    cdb4f678