Skip to content
  • mario@webkit.org's avatar
    [GTK] Missing call to g_object_ref while retrieving accessible table cells · e184198d
    mario@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=106903
    
    Reviewed by Martin Robinson.
    
    Source/WebCore:
    
    Add missing extra ref to implementation of atk_table_ref_at().
    
    Test: accessibility/table-cell-for-column-and-row-crash.html
    
    * accessibility/atk/WebKitAccessibleInterfaceTable.cpp:
    (webkitAccessibleTableRefAt): This method transfers full ownership
    over the returned AtkObject, so an extra reference is needed here.
    
    Tools:
    
    Both DRT and WKTR need to call g_object_unref() now that an extra
    reference is added in the implementation of atk_table_ref_at().
    
    * DumpRenderTree/atk/AccessibilityUIElementGtk.cpp:
    (AccessibilityUIElement::cellForColumnAndRow): Call g_object_unref
    before returning the new instance of AccessibilityUIElement.
    * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
    (WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto.
    
    LayoutTests:
    
    Added new test. It should work fine at least in Mac and GTK ports,
    but will need specific results for chromium and windows.
    
    * accessibility/table-cell-for-column-and-row-crash.html: Added.
    * accessibility/table-cell-for-column-and-row-crash-expected.txt: Added.
    * platform/chromium/TestExpectations: Skipped test.
    * platform/win/TestExpectations: Ditto.
    * platform/wincairo/TestExpectations: Ditto.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142883 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    e184198d