Skip to content
  • commit-queue@webkit.org's avatar
    AX: fieldset should have GroupRole and legend should be description. · 5bf7e5fb
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=122534
    
    Patch by Samuel White <samuel_white@apple.com> on 2013-10-14
    Reviewed by Chris Fleizach.
    
    Source/WebCore:
    
    Changes fieldset to derive AXDescription from legend if one is available. Added
    convenience method to AccessibilityObject to fetch element if available.
    
    Test: accessibility/fieldset-element.html
    
    * accessibility/AccessibilityNodeObject.cpp:
    (WebCore::AccessibilityNodeObject::canHaveChildren):
    (WebCore::AccessibilityNodeObject::alternativeText):
    * accessibility/AccessibilityObject.cpp:
    (WebCore::AccessibilityObject::element):
    (WebCore::AccessibilityObject::isARIAHidden):
    (WebCore::AccessibilityObject::isDOMHidden):
    (WebCore::AccessibilityObject::defaultObjectInclusion):
    * accessibility/AccessibilityObject.h:
    (WebCore::AccessibilityObject::isHidden):
    * accessibility/AccessibilitySlider.cpp:
    (WebCore::AccessibilitySlider::getAttribute):
    (WebCore::AccessibilitySlider::valueForRange):
    (WebCore::AccessibilitySlider::maxValueForRange):
    (WebCore::AccessibilitySlider::minValueForRange):
    (WebCore::AccessibilitySlider::setValue):
    (WebCore::AccessibilitySlider::inputElement):
    * accessibility/AccessibilitySlider.h:
    * accessibility/mac/AccessibilityObjectMac.mm:
    (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
    * html/HTMLFieldSetElement.cpp:
    (WebCore::HTMLFieldSetElement::legend):
    * html/HTMLFieldSetElement.h:
    
    LayoutTests:
    
    legend no longer treated as titleUIElement so removing tests that check this functionality.
    Added test to check that legend is used as AXDescription of fieldset if present.
    
    * accessibility/fieldset-element.html: Added.
    * accessibility/hidden-legend-expected.txt: Removed.
    * accessibility/hidden-legend.html: Removed.
    * accessibility/legend.html: Removed.
    * platform/efl/accessibility/legend-expected.txt: Removed.
    * platform/gtk/accessibility/legend-expected.txt: Removed.
    * platform/mac/accessibility/fieldset-element-expected.txt: Added.
    * platform/mac/accessibility/legend-expected.txt: Removed.
    * platform/mac/accessibility/role-subrole-roledescription-expected.txt:
    * platform/mac/accessibility/role-subrole-roledescription.html:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157434 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    5bf7e5fb