1. 26 Nov, 2014 1 commit
  2. 24 Nov, 2014 7 commits
  3. 23 Nov, 2014 3 commits
    • conrad_shultz@apple.com's avatar
      Page previews should have titles · 302d3355
      conrad_shultz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=139020
      
      Reviewed by Tim Horton.
      
      * UIProcess/API/Cocoa/WKViewPrivate.h:
      Declare -_titleForPreviewOfURL:.
      
      * UIProcess/API/mac/WKView.mm:
      (-[WKView _titleForPreviewOfURL:]):
      Stub implementation.
      
      * UIProcess/mac/WKActionMenuController.mm:
      (+[WKPagePreviewViewController previewPadding]):
      Account for the title height.
      (-[WKPagePreviewViewController loadView]):
      Set correct autoresize masks on some views; create and configure a title view that is
      horizontally and vertically centered.
      (-[WKActionMenuController pagePreviewViewController:titleForPreviewOfURL:]):
      WKPagePreviewViewControllerDelegate method; wrap -[WKView _titleForPreviewOfURL:].
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@176511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      302d3355
    • antti@apple.com's avatar
      Use segment vector for FlowContents · e7fe76e1
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=139015
      
      Reviewed by Zalan Bujtas.
      
      And FlowContents::Segment struct and use it.
      
      * rendering/SimpleLineLayout.cpp:
      (WebCore::SimpleLineLayout::removeTrailingWhitespace):
      (WebCore::SimpleLineLayout::createLineRuns):
      (WebCore::SimpleLineLayout::splitRunsAtRendererBoundary):
      
          Use segments.
          If there is only one segment there is nothing to do. Bail out.
      
      * rendering/SimpleLineLayoutFlowContents.cpp:
      (WebCore::SimpleLineLayout::initializeSegments):
      
          Move initialization to a function so m_segments can be const.
          Don't add empty end segment, handle the end case in code.
      
      (WebCore::SimpleLineLayout::FlowContents::FlowContents):
      (WebCore::SimpleLineLayout::FlowContents::textWidth):
      
          Simplify and use segments.
      
      (WebCore::SimpleLineLayout::FlowContents::segmentForPositionSlow):
      
          Replace hand-rolled binary search with std::lower_bounds.
      
      (WebCore::SimpleLineLayout::FlowContents::segmentForRenderer):
      (WebCore::SimpleLineLayout::FlowContents::appendNextRendererContentIfNeeded):
      (WebCore::SimpleLineLayout::FlowContents::renderer): Deleted.
      (WebCore::SimpleLineLayout::FlowContents::resolveRendererPositions): Deleted.
      * rendering/SimpleLineLayoutFlowContents.h:
      (WebCore::SimpleLineLayout::FlowContents::hasOneSegment):
      (WebCore::SimpleLineLayout::FlowContents::length):
      (WebCore::SimpleLineLayout::FlowContents::isEnd):
      (WebCore::SimpleLineLayout::FlowContents::isEndOfContent): Deleted.
      
          Renamed.
      
      (WebCore::SimpleLineLayout::FlowContents::segmentForPosition):
      
          Inline the fast path.
      
      * rendering/SimpleLineLayoutResolver.cpp:
      (WebCore::SimpleLineLayout::RunResolver::Run::text):
      (WebCore::SimpleLineLayout::RunResolver::rangeForRenderer):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@176510 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7fe76e1
    • simon.fraser@apple.com's avatar
      Extend WKRenderObject and WKRenderLayer with some more useful data · 47e25546
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=139006
      
      Reviewed by Sam Weinig.
      Source/WebCore:
      
      Export WebCore::RenderLayerBacking::backingStoreMemoryEstimate() const.
      
      * WebCore.exp.in:
      
      Source/WebKit2:
      
      Implement WKRenderLayerGetBackingStoreMemoryEstimate,
      WKRenderObjectCopyTextSnippet and WKRenderObjectGetTextLength for improved
      RenderLayer and RenderTree display in clients of the C SPI.
      
      * Shared/API/c/WKRenderLayer.cpp:
      (WKRenderLayerGetBackingStoreMemoryEstimate):
      * Shared/API/c/WKRenderLayer.h:
      * Shared/API/c/WKRenderObject.cpp:
      (WKRenderObjectCopyTextSnippet):
      (WKRenderObjectGetTextLength):
      * Shared/API/c/WKRenderObject.h:
      * Shared/UserMessageCoders.h:
      (WebKit::UserMessageEncoder::baseEncode):
      (WebKit::UserMessageDecoder::baseDecode):
      * Shared/WebRenderLayer.cpp:
      (WebKit::WebRenderLayer::create):
      (WebKit::WebRenderLayer::WebRenderLayer):
      * Shared/WebRenderLayer.h:
      (WebKit::WebRenderLayer::backingStoreMemoryEstimate):
      * Shared/WebRenderObject.cpp:
      (WebKit::WebRenderObject::create):
      (WebKit::WebRenderObject::WebRenderObject):
      * Shared/WebRenderObject.h:
      (WebKit::WebRenderObject::textSnippet):
      (WebKit::WebRenderObject::textLength):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@176509 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47e25546
  4. 22 Nov, 2014 8 commits
  5. 21 Nov, 2014 21 commits
    • timothy_horton@apple.com's avatar
      Remove a file that r176499 presumably did not mean to add. · f555e92c
      timothy_horton@apple.com authored
      * WebCore.exp.in.orig: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@176500 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f555e92c
    • jer.noble@apple.com's avatar
      Support multiple signatures of diagnostic logging. · 9e0f060e
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=138690
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore:
      
      Pull logDiagnosticMessage() out of ChromeClient and make a new client interface,
      DiagnosticLoggingClient, which supports multiple kinds of diagnostic logging,
      namely: simple logging without a parameter, logging with a success parameter, and
      logging with a generic string value parameter.
      
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::parseAttribute): Use DiagnosticLoggingClient.
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto.
      * loader/SubframeLoader.cpp:
      (WebCore::logPluginRequest): Ditto.
      * page/ChromeClient.h:
      (WebCore::ChromeClient::logDiagnosticMessage): Deleted.
      * page/DiagnosticLoggingClient.h:
      (WebCore::DiagnosticLoggingClient::logDiagnosticMessage): Added.
      (WebCore::DiagnosticLoggingClient::logDiagnosticMessageWithResult): Added.
      (WebCore::DiagnosticLoggingClient::logDiagnosticMessageWithValue): Added.
      (WebCore::DiagnosticLoggingClient::~DiagnosticLoggingClient): Empty destructor.
      
      Rename Page::PageClient to PageConfiguration, and pass that configuration from
      Page into MainFrame upon construction.
      
      * inspector/InspectorOverlay.cpp:
      (WebCore::InspectorOverlay::overlayPage): Use PageConfiguration instead of PageClients.
      * loader/EmptyClients.cpp:
      (WebCore::fillWithEmptyClients): Ditto.
      * loader/EmptyClients.h:
      * page/MainFrame.cpp:
      (WebCore::MainFrame::MainFrame): Pass loaderClientForMainFrame through to the
          Frame constructor.
      (WebCore::MainFrame::create): Takes a PageConfiguration.
      * page/MainFrame.h:
      (WebCore::MainFrame::diagnosticLoggingClient): Simple accessor.
      * page/Page.cpp:
      (WebCore::Page::Page):
      (WebCore::Page::PageClients::PageClients): Deleted.
      (WebCore::Page::PageClients::~PageClients): Deleted.
      * page/Page.h:
      * page/PageConfiguration.cpp: Added.
      (WebCore::PageConfiguration::PageConfiguration): Renamed from PageClients().
      (WebCore::PageConfiguration::~PageConfiguration): Renamed from ~PageClients().
      * page/PageConfiguration.h: Added.
      * svg/graphics/SVGImage.cpp:
      (WebCore::SVGImage::dataChanged): Use PageConfiguration instead of PageClients.
      
      Add new files and symbols to the project.
      
      * CMakeLists.txt:
      * WebCore.exp.in:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.xcodeproj/project.pbxproj:
      
      Source/WebKit/mac:
      
      Page::PageClients has been renamed PageConfiguration.
      
      * WebView/WebView.mm:
      (-[WebView _commonInitializationWithFrameName:groupName:]):
      (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
      
      Source/WebKit/win:
      
      Page::PageClients has been renamed PageConfiguration.
      
      * WebView.cpp:
      (WebView::initWithFrame):
      
      Source/WebKit2:
      
      Extend the existing WKBundlePageDiagnosticLoggingClient interface by deprecating
      the original logDiagnosticMessage client method in V1 and adding three new,
      explicit client methods.
      
      * CMakeLists.txt:
      * WebKit2.xcodeproj/project.pbxproj:
      * WebProcess/InjectedBundle/API/c/WKBundlePageDiagnosticLoggingClient.h:
      * WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp:
      (WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessageDeprecated):
          Renamed from logDiagnosticMessage().
      (WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessage): Pass to the client.
      (WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessageWithResult): Ditto.
      (WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessageWithValue): Ditto.
      * WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.h:
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::logDiagnosticMessage): Deleted.
      * WebProcess/WebCoreSupport/WebDiagnosticLoggingClient.cpp: Added.
      (WebKit::WebDiagnosticLoggingClient::WebDiagnosticLoggingClient): Simple constructor.
      (WebKit::WebDiagnosticLoggingClient::~WebDiagnosticLoggingClient): Simple destructor.
      (WebKit::WebDiagnosticLoggingClient::logDiagnosticMessage): Pass to the injected bundle.
      (WebKit::WebDiagnosticLoggingClient::logDiagnosticMessageWithResult): Ditto.
      (WebKit::WebDiagnosticLoggingClient::logDiagnosticMessageWithValue): Ditto.
      * WebProcess/WebCoreSupport/WebDiagnosticLoggingClient.h: Added.
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::WebPage): Initialize the new client.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@176499 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e0f060e
    • rniwa@webkit.org's avatar
      Unreviewed. Fixed syntax errors. · ca9ee28c
      rniwa@webkit.org authored
      * init-database.sql:
      * public/api/commits.php:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@176498 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca9ee28c
    • rniwa@webkit.org's avatar
      The dashboard on new perf monitor should be configurable · 6f5d4200
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=138994
      
      Reviewed by Benjamin Poulain.
      
      For now, make it configurable via config.json. We should eventually make it configurable via
      an administrative page but this will do for now.
      
      * config.json: Added the empty dashboard configuration.
      
      * public/include/manifest.php: Include the dashboard configuration in the manifest file.
      
      * public/v2/app.js:
      (App.IndexController): Removed defaultTable since this is now dynamically obtained via App.Manifest.
      (App.IndexController.gridChanged): Use App.Dashboard to parse the dashboard configuration.
      Also obtain the default configuration from App.Manifest.
      (App.IndexController._normalizeTable): Moved to App.Dashboard.
      
      * public/v2/manifest.js:
      (App.Repository.urlForRevision): Fixed the position of the open curly bracket.
      (App.Repository.urlForRevisionRange): Ditto.
      (App.Dashboard): Added.
      (App.Dashboard.table): Extracted from App.IndexController.gridChanged.
      (App.Dashboard.rows): Ditto.
      (App.Dashboard.headerColumns): Ditto.
      (App.Dashboard._normalizeTable): Moved from App.IndexController._normalizeTable.
      (App.MetricSerializer.normalizePayload): Synthesize a dashboard record from the configuration.
      Since there is exactly one dashboard object per app, it's okay to hard code an id here.
      (App.Manifest._fetchedManifest): Set defaultDashboard to the one and only one dashboard we have.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@176497 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f5d4200
    • cdumez@apple.com's avatar
      Throttled DOMTimers can prevent their document from being garbage collected · 99b24c0f
      cdumez@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=138915
      
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      Throttled DOMTimers whose interval depend on viewport changes would
      keep a Vector of elements outside viewport causing them to be throttled
      so that we could check later on (upon scroll or layout) if those
      elements are still outside viewport. The issue is that these elements
      could potentially be removed from the document (and destroyed) after
      the timer has fired. To handle this, DOMTimer was ref'ing the
      elements. Unfortunately, this was causing us to leak the document
      as the elements in the Vector would keep the document alive.
      
      To handle this issue, this patch updates the DOMTimer Vector to use
      weak pointers. The WeakPtrFactory is stored in ElementRareData to
      avoid wasting memory for all kinds of Elements (it is a fair assumption
      that the number of elements whose style is animated via timers is low).
      
      Test: fast/dom/throttled-timer-running-on-document-destruction.html
      
      * dom/Element.cpp:
      (WebCore::Element::createWeakPtr):
      * dom/Element.h:
      * dom/ElementRareData.cpp:
      * dom/ElementRareData.h:
      (WebCore::ElementRareData::weakPtrFactory):
      * page/DOMTimer.cpp:
      (WebCore::DOMTimerFireState::elementsChangedOutsideViewport):
      (WebCore::DOMTimer::updateThrottlingStateAfterViewportChange):
      * page/DOMTimer.h:
      
      LayoutTests:
      
      Improve fast/dom/throttled-timer-running-on-document-destruction.html
      layout test to cover the case where the throttled timer is changing the
      style of an element on the *same* document when the document is
      destroyed.
      
      * fast/dom/resources/frame-with-throttled-timer-animating-element-other-document.html: Renamed from LayoutTests/fast/dom/resources/frame-with-throttled-timer.html.
      * fast/dom/resources/frame-with-throttled-timer-animating-element-same-document.html: Added.
      * fast/dom/throttled-timer-running-on-document-destruction.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@176496 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99b24c0f
    • gyuyoung.kim@samsung.com's avatar
      Unreviewed, EFL build fix since r176459. · afed0894
      gyuyoung.kim@samsung.com authored
      r176459 removed Timer parameter in timer callbacks only for Mac port.
      So this patch applies it to remaining classes for EFL port.
      
      Source/WebCore:
      
      No new tests, fix build break.
      
      * Modules/mediastream/RTCDTMFSender.cpp:
      (WebCore::RTCDTMFSender::RTCDTMFSender):
      * Modules/mediastream/RTCDataChannel.cpp:
      (WebCore::RTCDataChannel::RTCDataChannel):
      * Modules/mediastream/RTCPeerConnection.cpp:
      (WebCore::RTCPeerConnection::RTCPeerConnection):
      * Modules/vibration/Vibration.cpp:
      (WebCore::Vibration::Vibration):
      (WebCore::Vibration::timerFired):
      * Modules/vibration/Vibration.h:
      * bindings/js/GCController.cpp:
      (WebCore::GCController::GCController):
      * platform/efl/BatteryProviderEfl.cpp:
      (WebCore::BatteryProviderEfl::BatteryProviderEfl):
      (WebCore::BatteryProviderEfl::timerFired):
      * platform/efl/BatteryProviderEfl.h:
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
      (WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
      (WebCore::MediaPlayerPrivateGStreamer::fillTimerFired):
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
      * platform/graphics/texmap/TextureMapper.cpp:
      (WebCore::BitmapTexturePool::BitmapTexturePool):
      (WebCore::BitmapTexturePool::releaseUnusedTexturesTimerFired):
      * platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
      (WebCore::CompositingCoordinator::CompositingCoordinator):
      (WebCore::CompositingCoordinator::releaseInactiveAtlasesTimerFired):
      * platform/graphics/texmap/coordinated/CompositingCoordinator.h:
      * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
      (WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
      (WebCore::CoordinatedGraphicsLayer::animationStartedTimerFired):
      * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
      * platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:
      (WebCore::CoordinatedImageBacking::CoordinatedImageBacking):
      (WebCore::CoordinatedImageBacking::clearContentsTimerFired):
      * platform/graphics/texmap/coordinated/CoordinatedImageBacking.h:
      * platform/mock/DeviceMotionClientMock.cpp:
      (WebCore::DeviceMotionClientMock::DeviceMotionClientMock):
      (WebCore::DeviceMotionClientMock::timerFired):
      * platform/mock/DeviceMotionClientMock.h:
      * platform/mock/TimerEventBasedMock.h:
      (WebCore::TimerEvent::TimerEvent):
      (WebCore::TimerEvent::timerFired):
      
      Source/WebKit2:
      
      * UIProcess/API/efl/EwkView.cpp:
      (EwkView::EwkView):
      (EwkView::displayTimerFired):
      * UIProcess/API/efl/EwkView.h:
      * UIProcess/efl/TextCheckerClientEfl.cpp:
      (TextCheckerClientEfl::TextCheckerClientEfl):
      (TextCheckerClientEfl::languagesUpdateTimerFired):
      (TextCheckerClientEfl::spellCheckingSettingChangeTimerFired):
      * UIProcess/efl/TextCheckerClientEfl.h:
      * WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
      (WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
      (WebKit::CoordinatedLayerTreeHost::layerFlushTimerFired):
      * WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@176495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      afed0894
    • benjamin@webkit.org's avatar
      Start using the new :not() and :matches() in the Web Inspector · 4b79d2f5
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=138978
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-11-21
      Reviewed by Joseph Pecoraro.
      
      Source/WebCore:
      
      There are only minor pending issues on :not() and :matches(). The feedback
      has only been positive so far. It is time to move them out the experimental
      flag.
      
      * css/CSSGrammar.y.in:
      * css/CSSParser.cpp:
      (WebCore::CSSParser::detectFunctionTypeToken):
      * css/CSSSelector.cpp:
      (WebCore::simpleSelectorSpecificityInternal):
      (WebCore::simpleSelectorFunctionalPseudoClassStaticSpecificity):
      (WebCore::appendSelectorList):
      (WebCore::CSSSelector::selectorText):
      * css/CSSSelector.h:
      * css/SelectorChecker.cpp:
      (WebCore::SelectorChecker::checkOne):
      (WebCore::SelectorChecker::determineLinkMatchType):
      * css/SelectorPseudoClassAndCompatibilityElementMap.in:
      * cssjit/SelectorCompiler.cpp:
      (WebCore::SelectorCompiler::addPseudoClassType):
      
      Source/WebInspectorUI:
      
      Start simpifying some definitions by using modern CSS.
      
      * UserInterface/Views/CSSStyleDeclarationSection.css:
      (body.mac-platform.legacy .style-declaration-section.last-in-group + .style-declaration-section:matches(.last-in-group, :last-child)):
      (.style-declaration-section:matches(.locked, .selector-locked) > .header > .selector):
      (body.mac-platform.legacy .style-declaration-section.last-in-group + .style-declaration-section:last-child): Deleted.
      (.style-declaration-section.selector-locked > .header > .selector): Deleted.
      * UserInterface/Views/CSSStyleDeclarationTextEditor.css:
      (.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property:matches(.disabled, .invalid, .other-vendor, .not-inherited, .overridden)):
      (.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property:matches(.implicit, .not-inherited)):
      (.css-style-text-editor > .CodeMirror .CodeMirror-lines .editing-line .css-style-declaration-property:matches(.disabled, .other-vendor, .not-inherited, .overridden)):
      (.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property.overridden): Deleted.
      (.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property.not-inherited): Deleted.
      (.css-style-text-editor > .CodeMirror .CodeMirror-lines .editing-line .css-style-declaration-property.overridden): Deleted.
      * UserInterface/Views/ControlToolbarItem.css:
      (.toolbar:matches(.icon-and-label-horizontal, .toolbar.icon-only) .item.control):
      (.toolbar.icon-only .item.control): Deleted.
      * UserInterface/Views/DOMStorageContentView.css:
      * UserInterface/Views/DashboardContainerView.css:
      (.toolbar.icon-and-label-vertical:matches(.small-size, .normal-size) .dashboard-container):
      (.toolbar:matches(.label-only, .small-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal)) .dashboard-container):
      (.toolbar.normal-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard-container):
      (.toolbar.normal-size.icon-and-label-vertical .dashboard-container): Deleted.
      (.toolbar.small-size.icon-and-label-horizontal .dashboard-container): Deleted.
      (.toolbar.normal-size.icon-and-label-horizontal .dashboard-container): Deleted.
      * UserInterface/Views/DataGrid.css:
      (.data-grid :matches(th, td):not(:last-child)):
      (.data-grid th:matches(.sort-ascending, .sort-descending)):
      (.data-grid :matches(th, td) > div):
      (.data-grid th:matches(.sort-ascending, .sort-descending) > div:first-child):
      (.data-grid tr:matches(.selected, :hover) .go-to-arrow):
      (.data-grid :-webkit-any(th, td):not(:last-child)): Deleted.
      (.data-grid th:-webkit-any(.sort-ascending, .sort-descending)): Deleted.
      (.data-grid :-webkit-any(th, td) > div): Deleted.
      (.data-grid th:-webkit-any(.sort-ascending, .sort-descending) > div:first-child): Deleted.
      (.data-grid tr:-webkit-any(.selected, :hover) .go-to-arrow): Deleted.
      * UserInterface/Views/DebuggerDashboardView.css:
      (.toolbar.collapsed .dashboard.debugger > :not(.message, .navigation-bar )):
      (.toolbar.collapsed .dashboard.debugger > :not(.message):not(.navigation-bar )): Deleted.
      * UserInterface/Views/DefaultDashboardView.css:
      (body.web .toolbar.collapsed .dashboard.default > :matches(.time, .resourcesSize, .logs)):
      (body.javascript .toolbar .dashboard.default > :matches(.time, .resourcesSize, .resourcesCount)):
      (.toolbar:matches(.label-only, .small-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal)) .dashboard.default > .item):
      (.toolbar.normal-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard.default > .item):
      (body.web .toolbar.collapsed .dashboard.default > .logs): Deleted.
      (body.javascript .toolbar .dashboard.default > .resourcesCount): Deleted.
      (.toolbar.small-size.icon-and-label-horizontal .dashboard.default > .item): Deleted.
      (.toolbar.normal-size.icon-and-label-horizontal .dashboard.default > .item): Deleted.
      * UserInterface/Views/DetailsSection.css:
      (.details-section > .header > :matches(.node-link, .go-to-arrow)):
      (.details-section > .content > .group:nth-child(even) > .row:matches(.simple:first-child > *, :not(.simple):first-child)):
      (body.mac-platform.legacy .details-section > .content > .group:matches(:nth-child(even), :last-child) > .row.simple:last-child > *):
      (.details-section > .content > .group > .row:matches(.empty, .text)):
      (body.mac-platform.legacy .details-section > .content > .group > .row:matches(.empty, .text)):
      (.details-section > .header > .go-to-arrow): Deleted.
      (.details-section > .content > .group:nth-child(even) > .row.simple:first-child > *): Deleted.
      (body.mac-platform.legacy .details-section > .content > .group:last-child > .row.simple:last-child > *): Deleted.
      (.details-section > .content > .group > .row.text): Deleted.
      (body.mac-platform.legacy .details-section > .content > .group > .row.text): Deleted.
      * UserInterface/Views/FindBanner.css:
      (:matches(.find-banner, .supports-find-banner).no-find-banner-transition):
      (.supports-find-banner.no-find-banner-transition): Deleted.
      * UserInterface/Views/FlexibleSpaceNavigationItem.css:
      (:matches(.navigation-bar, .toolbar) .item.flexible-space):
      (.toolbar .item.flexible-space): Deleted.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@176494 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b79d2f5
    • rniwa@webkit.org's avatar
      There should be a way to associate bugs with analysis tasks · f0e68187
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=138977
      
      Reviewed by Benjamin Poulain.
      
      Updated associate-bug.php to match the new database schema.
      
      * public/include/json-header.php:
      (require_format): Removed the call to camel_case_words_separated_by_underscore since the name is
      already camel-cased in require_existence_of. This makes the function usable elsewhere.
      
      * public/privileged-api/associate-bug.php:
      (main): Changed the API to take run, bugTracker, and number to match the new database schema.
      Also verify that those values are integers using require_format.
      
      * public/v2/analysis.js:
      (App.AnalysisTask.label): Added. Concatenates the task's name with the bug numbers.
      (App.Bug.label): Added.
      (App.BugAdapter): Added.
      (App.BugAdapter.createRecord): Use PrivilegedAPI instead of the builtin ajax call.
      (App.BuildRequest): Inherit from newly added App.Model, which is set to DS.Model right now.
      
      * public/v2/app.css: Renamed .test-groups to .analysis-group. Also added new rules for the table
      containing the bug information.
      
      * public/v2/app.js:
      (App.InteractiveChartComponent._rangesChanged): Added label to range bar objects.
      (App.AnalysisTaskRoute):
      (App.AnalysisTaskController): Replaced the functionality of App.AnalysisTaskViewModel.
      (App.AnalysisTaskController._fetchedManifest): Added.
      (App.AnalysisTaskController.actions.associateBug): Added.
      
      * public/v2/chart-pane.css: Renamed .bugs-pane to .analysis-pane.
      
      * public/v2/data.js:
      (Measurement.prototype.associateBug): Deleted.
      
      * public/v2/index.html: Renamed .bugs-pane to .analysis-pane and .test-groups to .analysis-group.
      Added a table show the bug information. Also hide the chart until chartData is available.
      
      * public/v2/manifest.js:
      (App.Model): Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@176493 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0e68187
    • cdumez@apple.com's avatar
      Unreviewed, iOS build fix after r176462. · c62f1b4a
      cdumez@apple.com authored
      Source/WebCore:
      
      Export a few extra symbols.
      
      * WebCore.exp.in:
      
      Source/WebKit2:
      
      Fix include path to TextIndicator.h to include WebCore/
      as it was moved.
      
      * UIProcess/ios/PageClientImplIOS.mm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@176492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c62f1b4a
    • cdumez@apple.com's avatar
      Properties in CSSPropertyNames.in should use the new StyleBuilder by default · c51e8e80
      cdumez@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=138983
      
      Reviewed by Andreas Kling.
      
      This patch makes using the new StyleBuilder the default and drops the
      [NewStyleBuilder] option as a result. A new [LegacyStyleBuilder] option
      is introduced for CSS properties that are not generated in the new
      StyleBuilder yet.
      
      * css/CSSPropertyNames.in:
      * css/SVGCSSPropertyNames.in:
      * css/makeprop.pl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@176491 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c51e8e80
    • cdumez@apple.com's avatar
      [iOS] Regression(r176202): line-height is wrong on marco.org · cf32f094
      cdumez@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=138970
      
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      After r176202, on iOS with IOS_TEXT_AUTOSIZING enabled, we would
      multiply the lineHeight by RenderStyle::textSizeAdjust()::multiplier()
      unconditionally. However, we're only supposed to do so if
      RenderStyle::textSizeAdjust()::isPercentage() returns true. This
      patch reintroduces the textSizeAdjust().isPercentage() check that was
      inadvertently dropped when refactoring the code to be shared between
      iOS and OS X.
      
      Additionally, the multiplier is only supposed the be applied if the
      input CSSPrimitiveValue is a Length or a Number. However, after
      r176202, we would apply the multiplier if the CSSPrimitiveValue is
      a Percentage or a Number. This patch updates the code to match the
      behavior prior to r176202.
      
      Test: fast/css/line-height-text-autosizing.html
      
      * css/StyleBuilderCustom.h:
      (WebCore::StyleBuilderFunctions::convertLineHeight):
      (WebCore::StyleBuilderFunctions::applyValueLineHeight):
      
      LayoutTests:
      
      Add layout test to cover line-height CSS property and its interaction
      with -webkit-text-size-adjust.
      
      * fast/css/line-height-text-autosizing-expected.txt: Added.
      * fast/css/line-height-text-autosizing.html: Added.
      * platform/ios-simulator/fast/css/line-height-text-autosizing-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@176490 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf32f094
    • cdumez@apple.com's avatar
      Unreviewed, iOS build fix after r176452. · 14b75b32
      cdumez@apple.com authored
      dencodeFixedLengthData() now only takes 2 arguments instead of
      3.
      
      * Shared/ios/QuickLookDocumentData.cpp:
      (WebKit::QuickLookDocumentData::decode):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@176489 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14b75b32
    • zalan@apple.com's avatar
      Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser. · b1f545f0
      zalan@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=138981
      
      Reviewed by Simon Fraser.
      
      Source/WebKit/mac:
      
      * WebView/WebPreferenceKeysPrivate.h:
      * WebView/WebPreferences.mm:
      (+[WebPreferences initialize]):
      (-[WebPreferences simpleLineLayoutDebugBordersEnabled]):
      (-[WebPreferences setSimpleLineLayoutDebugBordersEnabled:]):
      * WebView/WebPreferencesPrivate.h:
      * WebView/WebView.mm:
      (-[WebView _preferencesChanged:]):
      
      Source/WebKit2:
      
      * UIProcess/API/Cocoa/WKPreferences.mm:
      (-[WKPreferences _simpleLineLayoutDebugBordersEnabled]):
      (-[WKPreferences _setSimpleLineLayoutDebugBordersEnabled:]):
      * UIProcess/API/Cocoa/WKPreferencesPrivate.h:
      
      Tools:
      
      * MiniBrowser/mac/SettingsController.h:
      * MiniBrowser/mac/SettingsController.m:
      (-[SettingsController _populateMenu]):
      (-[SettingsController validateMenuItem:]):
      (-[SettingsController toggleSimpleLineLayoutDebugBordersEnabled:]):
      (-[SettingsController simpleLineLayoutDebugBordersEnabled]):
      * MiniBrowser/mac/WK1BrowserWindowController.m:
      (-[WK1BrowserWindowController didChangeSettings]):
      * MiniBrowser/mac/WK2BrowserWindowController.m:
      (-[WK2BrowserWindowController didChangeSettings]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@176488 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1f545f0
    • eric.carlson@apple.com's avatar
      WebVideoFullscreenManagerProxy must clear pointers when invalidated · 408db6e0
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=138982
      
      Reviewed by Jer Noble.
      
      * UIProcess/ios/WebVideoFullscreenManagerProxy.mm:
      (WebKit::WebVideoFullscreenManagerProxy::~WebVideoFullscreenManagerProxy): Call invalidate.
      (WebKit::WebVideoFullscreenManagerProxy::invalidate): Set WebVideoFullscreenModel and
          WebVideoFullscreenChangeObserver to NULL.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@176487 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      408db6e0
    • timothy_horton@apple.com's avatar
      Fix the build. · 97695d14
      timothy_horton@apple.com authored
      * UIProcess/API/mac/WKView.mm:
      (-[WKView mouseDown:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@176486 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97695d14
    • bdakin@apple.com's avatar
      The preview action menu item should not have a title · e96273ea
      bdakin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=138989
      -and corresponding-
      rdar://problem/19061959
      
      Reviewed by Anders Carlsson.
      
      * UIProcess/mac/WKActionMenuController.mm:
      (-[WKActionMenuController _createActionMenuItemForTag:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@176485 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e96273ea
    • cfleizach@apple.com's avatar
      AX: com.apple.WebKit.WebContent crashed at WebCore:... · 6a1d9908
      cfleizach@apple.com authored
      AX: com.apple.WebKit.WebContent crashed at WebCore: WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored const
      https://bugs.webkit.org/show_bug.cgi?id=138905
      
      Reviewed by Mario Sanchez Prada.
      
      The crash log indicates that m_renderer is null at the time we ask ancestorsOfType().
      This is more of a speculative fix, since I am not entirely sure m_renderer is null when we enter the method.
      
      Unable to determine cause of crash or how to reproduce on demand.
      
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@176484 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a1d9908
    • conrad_shultz@apple.com's avatar
      Page previews should have a margin. · 2c8179c1
      conrad_shultz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=138990
      
      Reviewed by Beth Dakin.
      
      Enclose the WKWebView (or client-supplied preview view) in a container slightly larger
      than the preview view. Adjust sizing code to accommodate the margin.
      
      * UIProcess/mac/WKActionMenuController.mm:
      (+[WKPagePreviewViewController previewPadding]):
      Return the total amount of fixed padding surrounding the preview
      (-[WKPagePreviewViewController loadView]):
      Store the actual previewView in an ivar so that clients can distinguish it from the container
      view; wrap the preview in a container view; set frames appropriately.
      (-[WKActionMenuController _createPreviewPopover]):
      Update to reflect method rename; supplement the popover size with the fixed padding.
      (-[WKActionMenuController _preferredPopoverSizeWithPreviewPadding:]):
      Renamed from -_preferredPopoverSize; account for the fixed padding when computing the preferred size.
      (-[WKActionMenuController _clearPreviewPopover]):
      Use the previewView ivar instead of the view controller's view.
      (-[WKActionMenuController pagePreviewViewControllerWasClicked:]):
      Ditto.
      (-[WKActionMenuController _preferredPopoverSize]): Deleted.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@176483 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c8179c1
    • jer.noble@apple.com's avatar
      [EME][Mac] Check the underlying error if the one returned by AVFoundation is AVErrorUnknown. · 3ac391b2
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=138986
      
      Reviewed by Eric Carlson.
      
      When we recieve an error with the code AVErrorUnknown, look for an underlying error from CoreMedia (or another
      lower-level framework) with a (presumably) more informative error code, and return that code instead.
      
      * platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:
      (WebCore::systemCodeForError):
      (WebCore::CDMSessionMediaSourceAVFObjC::layerDidReceiveError):
      (WebCore::CDMSessionMediaSourceAVFObjC::rendererDidReceiveError):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@176482 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ac391b2
    • cfleizach@apple.com's avatar
      AX: Unclear that user and password are autofilled, no VoiceOver version of the yellow outline. · 9ef73c1b
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=138904
      
      Reviewed by Mario Sanchez Prada.
      
      Source/WebCore:
      
      Add an attribute that marks when a text field is auto-filled.
      
      Test: accessibility/auto-filled-value.html
      
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::isValueAutofilled):
      * accessibility/AccessibilityObject.h:
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      (-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
      (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
      
      LayoutTests:
      
      * accessibility/auto-filled-value.html: Added.
      * platform/mac/accessibility/auto-filled-value-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@176481 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ef73c1b
    • timothy_horton@apple.com's avatar
      REGRESSION (r176415): Can get stuck, unable to invoke any DataDetectors popovers · 2a9405b0
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=138955
      <rdar://problem/19056442>
      
      Reviewed by Anders Carlsson.
      
      * UIProcess/API/mac/WKView.mm:
      (-[WKView mouseDown:]):
      * UIProcess/mac/WKActionMenuController.h:
      * UIProcess/mac/WKActionMenuController.mm:
      (-[WKActionMenuController wkView:willHandleMouseDown:]):
      (-[WKActionMenuController didCloseMenu:withEvent:]):
      (-[WKActionMenuController menuNeedsUpdate:]):
      Keep track of whether we have called shouldUseActionsWithContext: on a
      DDActionContext; if we get a mouseDown without having seen didCloseMenu:
      (and thus don't properly pair the shouldUseActionsWithContext: with a didUseActions),
      tear down the old DDActionContext before proceeding.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@176480 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a9405b0