1. 15 Aug, 2013 1 commit
    • andersca@apple.com's avatar
      <https://webkit.org/b/119859> Frame::loader() should return a reference · df550b96
      andersca@apple.com authored
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      * Modules/websockets/WebSocketChannel.cpp:
      (WebCore::WebSocketChannel::willOpenSocketStream):
      * WebCore.xcodeproj/project.pbxproj:
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::press):
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      (-[WebAccessibilityObjectWrapper remoteAccessibilityParentObject]):
      * bindings/ScriptControllerBase.cpp:
      (WebCore::ScriptController::canExecuteScripts):
      * bindings/js/ScriptController.cpp:
      (WebCore::ScriptController::initScript):
      * css/CSSFontSelector.cpp:
      (WebCore::CSSFontSelector::beginLoadTimerFired):
      * dom/DOMImplementation.cpp:
      (WebCore::DOMImplementation::createDocument):
      * dom/Document.cpp:
      (WebCore::Document::Document):
      (WebCore::Document::setVisualUpdatesAllowed):
      (WebCore::Document::updateTitle):
      (WebCore::Document::open):
      (WebCore::Document::explicitClose):
      (WebCore::Document::implicitClose):
      (WebCore::Document::userAgent):
      (WebCore::Document::canNavigate):
      (WebCore::Document::processHttpEquiv):
      (WebCore::Document::referrer):
      (WebCore::Document::documentDidResumeFromPageCache):
      (WebCore::Document::openSearchDescriptionURL):
      (WebCore::Document::finishedParsing):
      (WebCore::Document::addIconURL):
      (WebCore::Document::initSecurityContext):
      (WebCore::Document::updateURLForPushOrReplaceState):
      (WebCore::Document::loadEventDelayTimerFired):
      (WebCore::Document::loader):
      (WebCore::Document::decrementActiveParserCount):
      * history/CachedFrame.cpp:
      (WebCore::CachedFrameBase::CachedFrameBase):
      (WebCore::CachedFrameBase::restore):
      (WebCore::CachedFrame::CachedFrame):
      (WebCore::CachedFrame::open):
      (WebCore::CachedFrame::destroy):
      * history/PageCache.cpp:
      (WebCore::logCanCacheFrameDecision):
      (WebCore::logCanCachePageDecision):
      (WebCore::PageCache::canCachePageContainingThisFrame):
      (WebCore::PageCache::canCache):
      * html/HTMLAnchorElement.cpp:
      (WebCore::HTMLAnchorElement::handleClick):
      * html/HTMLAppletElement.cpp:
      (WebCore::HTMLAppletElement::updateWidget):
      * html/HTMLElement.cpp:
      (WebCore::HTMLElement::rendererIsNeeded):
      * html/HTMLEmbedElement.cpp:
      (WebCore::HTMLEmbedElement::updateWidget):
      * html/HTMLFormElement.cpp:
      (WebCore::HTMLFormElement::prepareForSubmission):
      (WebCore::HTMLFormElement::submit):
      * html/HTMLFrameElementBase.cpp:
      (WebCore::HTMLFrameElementBase::openURL):
      * html/HTMLFrameOwnerElement.cpp:
      (WebCore::HTMLFrameOwnerElement::disconnectContentFrame):
      * html/HTMLFrameSetElement.cpp:
      (WebCore::HTMLFrameSetElement::insertedInto):
      (WebCore::HTMLFrameSetElement::removedFrom):
      * html/HTMLHtmlElement.cpp:
      (WebCore::HTMLHtmlElement::insertedByParser):
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::createRenderer):
      (WebCore::HTMLMediaElement::attach):
      (WebCore::HTMLMediaElement::loadResource):
      (WebCore::HTMLMediaElement::getPluginProxyParams):
      (WebCore::HTMLMediaElement::createMediaPlayerProxy):
      (WebCore::HTMLMediaElement::updateWidget):
      (WebCore::HTMLMediaElement::mediaPlayerReferrer):
      (WebCore::HTMLMediaElement::mediaPlayerUserAgent):
      * html/HTMLObjectElement.cpp:
      (WebCore::HTMLObjectElement::parametersForPlugin):
      (WebCore::HTMLObjectElement::updateWidget):
      * html/HTMLPlugInImageElement.cpp:
      (WebCore::HTMLPlugInImageElement::isImageType):
      (WebCore::HTMLPlugInImageElement::wouldLoadAsNetscapePlugin):
      (WebCore::HTMLPlugInImageElement::restartSimilarPlugIns):
      * html/HTMLVideoElement.cpp:
      (WebCore::HTMLVideoElement::setDisplayMode):
      * html/ImageDocument.cpp:
      (WebCore::ImageDocumentParser::appendBytes):
      (WebCore::ImageDocumentParser::finish):
      (WebCore::ImageDocument::createDocumentStructure):
      * html/MediaDocument.cpp:
      (WebCore::MediaDocumentParser::createDocumentStructure):
      * html/PluginDocument.cpp:
      (WebCore::PluginDocumentParser::createDocumentStructure):
      (WebCore::PluginDocumentParser::appendBytes):
      (WebCore::PluginDocument::detach):
      (WebCore::PluginDocument::cancelManualPluginLoad):
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore::WebGLRenderingContext::create):
      (WebCore::WebGLRenderingContext::loseContextImpl):
      (WebCore::WebGLRenderingContext::maybeRestoreContext):
      * html/parser/HTMLConstructionSite.cpp:
      (WebCore::HTMLConstructionSite::dispatchDocumentElementAvailableIfNeeded):
      (WebCore::HTMLConstructionSite::insertHTMLBodyElement):
      * html/parser/HTMLParserOptions.cpp:
      (WebCore::HTMLParserOptions::HTMLParserOptions):
      * html/parser/XSSAuditor.cpp:
      (WebCore::XSSAuditor::init):
      * html/parser/XSSAuditorDelegate.cpp:
      (WebCore::XSSAuditorDelegate::generateViolationReport):
      (WebCore::XSSAuditorDelegate::didBlockScript):
      * inspector/InspectorApplicationCacheAgent.cpp:
      (WebCore::InspectorApplicationCacheAgent::updateApplicationCacheStatus):
      (WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
      * inspector/InspectorFrontendClientLocal.cpp:
      (WebCore::InspectorFrontendClientLocal::openInNewTab):
      * inspector/InspectorFrontendHost.cpp:
      (WebCore::InspectorFrontendHost::loadResourceSynchronously):
      * inspector/InspectorOverlay.cpp:
      (WebCore::InspectorOverlay::overlayPage):
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::mainResourceContent):
      (WebCore::InspectorPageAgent::reload):
      (WebCore::InspectorPageAgent::navigate):
      (WebCore::allResourcesURLsForFrame):
      (WebCore::InspectorPageAgent::searchInResource):
      (WebCore::InspectorPageAgent::assertDocumentLoader):
      (WebCore::InspectorPageAgent::buildObjectForFrame):
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::InspectorResourceAgent::didFailLoading):
      * loader/CookieJar.cpp:
      (WebCore::networkingContext):
      * loader/DocumentLoader.cpp:
      (WebCore::DocumentLoader::frameLoader):
      (WebCore::DocumentLoader::document):
      (WebCore::DocumentLoader::stopLoading):
      (WebCore::DocumentLoader::removeSubresourceLoader):
      (WebCore::DocumentLoader::subresourceLoaderFinishedLoadingOnePart):
      (WebCore::DocumentLoader::iconLoadDecisionAvailable):
      (WebCore::DocumentLoader::continueIconLoadWithDecision):
      * loader/DocumentThreadableLoader.cpp:
      (WebCore::DocumentThreadableLoader::didReceiveResponse):
      (WebCore::DocumentThreadableLoader::didFinishLoading):
      (WebCore::DocumentThreadableLoader::didFail):
      (WebCore::DocumentThreadableLoader::preflightFailure):
      (WebCore::DocumentThreadableLoader::loadRequest):
      * loader/DocumentWriter.cpp:
      (WebCore::DocumentWriter::replaceDocument):
      (WebCore::DocumentWriter::createDocument):
      (WebCore::DocumentWriter::begin):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::~FrameLoader):
      (WebCore::FrameLoader::allChildrenAreComplete):
      (WebCore::FrameLoader::allAncestorsAreComplete):
      (WebCore::FrameLoader::loadURLIntoChildFrame):
      (WebCore::FrameLoader::outgoingReferrer):
      (WebCore::FrameLoader::setOpener):
      (WebCore::FrameLoader::completed):
      (WebCore::FrameLoader::started):
      (WebCore::FrameLoader::loadFrameRequest):
      (WebCore::FrameLoader::loadURL):
      (WebCore::FrameLoader::load):
      (WebCore::FrameLoader::loadWithDocumentLoader):
      (WebCore::FrameLoader::stopAllLoaders):
      (WebCore::FrameLoader::closeOldDataSources):
      (WebCore::FrameLoader::subframeIsLoading):
      (WebCore::FrameLoader::subresourceCachePolicy):
      (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
      (WebCore::FrameLoader::detachChildren):
      (WebCore::FrameLoader::checkLoadComplete):
      (WebCore::FrameLoader::detachFromParent):
      (WebCore::FrameLoader::loadPostRequest):
      (WebCore::FrameLoader::loadResourceSynchronously):
      (WebCore::FrameLoader::shouldClose):
      (WebCore::FrameLoader::handleBeforeUnloadEvent):
      (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
      (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
      (WebCore::createWindow):
      * loader/HistoryController.cpp:
      (WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
      (WebCore::HistoryController::restoreScrollPositionAndViewState):
      (WebCore::HistoryController::saveDocumentState):
      (WebCore::HistoryController::saveDocumentAndScrollState):
      (WebCore::isAssociatedToRequestedHistoryItem):
      (WebCore::HistoryController::restoreDocumentState):
      (WebCore::HistoryController::shouldStopLoadingForHistoryItem):
      (WebCore::HistoryController::goToItem):
      (WebCore::HistoryController::updateForBackForwardNavigation):
      (WebCore::HistoryController::updateForReload):
      (WebCore::HistoryController::updateForStandardLoad):
      (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
      (WebCore::HistoryController::updateForClientRedirect):
      (WebCore::HistoryController::updateForCommit):
      (WebCore::HistoryController::recursiveUpdateForCommit):
      (WebCore::HistoryController::updateForSameDocumentNavigation):
      (WebCore::HistoryController::recursiveUpdateForSameDocumentNavigation):
      (WebCore::HistoryController::initializeItem):
      (WebCore::HistoryController::createItemTree):
      (WebCore::HistoryController::recursiveSetProvisionalItem):
      (WebCore::HistoryController::recursiveGoToItem):
      (WebCore::HistoryController::updateBackForwardListClippedAtTarget):
      (WebCore::HistoryController::updateCurrentItem):
      (WebCore::HistoryController::pushState):
      (WebCore::HistoryController::replaceState):
      * loader/ImageLoader.cpp:
      (WebCore::pageIsBeingDismissed):
      * loader/MixedContentChecker.cpp:
      (WebCore::MixedContentChecker::client):
      * loader/NavigationScheduler.cpp:
      (WebCore::ScheduledURLNavigation::fire):
      (WebCore::ScheduledURLNavigation::didStartTimer):
      (WebCore::ScheduledURLNavigation::didStopTimer):
      (WebCore::ScheduledRedirect::shouldStartTimer):
      (WebCore::ScheduledRedirect::fire):
      (WebCore::ScheduledRefresh::fire):
      (WebCore::ScheduledHistoryNavigation::fire):
      (WebCore::ScheduledFormSubmission::fire):
      (WebCore::ScheduledFormSubmission::didStartTimer):
      (WebCore::ScheduledFormSubmission::didStopTimer):
      (WebCore::NavigationScheduler::mustLockBackForwardList):
      (WebCore::NavigationScheduler::scheduleLocationChange):
      (WebCore::NavigationScheduler::scheduleFormSubmission):
      (WebCore::NavigationScheduler::scheduleRefresh):
      (WebCore::NavigationScheduler::schedule):
      * loader/PingLoader.cpp:
      (WebCore::PingLoader::loadImage):
      (WebCore::PingLoader::sendPing):
      (WebCore::PingLoader::sendViolationReport):
      (WebCore::PingLoader::PingLoader):
      * loader/PolicyChecker.cpp:
      (WebCore::PolicyChecker::checkNavigationPolicy):
      (WebCore::PolicyChecker::checkNewWindowPolicy):
      (WebCore::PolicyChecker::checkContentPolicy):
      (WebCore::PolicyChecker::cancelCheck):
      (WebCore::PolicyChecker::stopCheck):
      (WebCore::PolicyChecker::cannotShowMIMEType):
      (WebCore::PolicyChecker::continueLoadAfterWillSubmitForm):
      (WebCore::PolicyChecker::continueAfterNavigationPolicy):
      (WebCore::PolicyChecker::continueAfterNewWindowPolicy):
      (WebCore::PolicyChecker::handleUnimplementablePolicy):
      * loader/ProgressTracker.cpp:
      (WebCore::ProgressTracker::progressStarted):
      (WebCore::ProgressTracker::progressCompleted):
      (WebCore::ProgressTracker::finalProgressComplete):
      (WebCore::ProgressTracker::incrementProgress):
      (WebCore::ProgressTracker::progressHeartbeatTimerFired):
      * loader/ResourceLoadNotifier.cpp:
      (WebCore::ResourceLoadNotifier::didReceiveAuthenticationChallenge):
      (WebCore::ResourceLoadNotifier::didCancelAuthenticationChallenge):
      (WebCore::ResourceLoadNotifier::willSendRequest):
      (WebCore::ResourceLoadNotifier::didFailToLoad):
      (WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest):
      (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
      (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
      (WebCore::ResourceLoadNotifier::dispatchDidReceiveData):
      (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
      (WebCore::ResourceLoadNotifier::dispatchDidFailLoading):
      * loader/ResourceLoader.cpp:
      (WebCore::ResourceLoader::ResourceLoader):
      (WebCore::ResourceLoader::start):
      (WebCore::ResourceLoader::frameLoader):
      (WebCore::ResourceLoader::willSendRequest):
      * loader/SubframeLoader.cpp:
      (WebCore::SubframeLoader::pluginIsLoadable):
      (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin):
      (WebCore::SubframeLoader::createJavaAppletWidget):
      (WebCore::SubframeLoader::loadOrRedirectSubframe):
      (WebCore::SubframeLoader::loadSubframe):
      (WebCore::SubframeLoader::allowPlugins):
      (WebCore::SubframeLoader::shouldUsePlugin):
      (WebCore::SubframeLoader::loadPlugin):
      * loader/appcache/ApplicationCacheGroup.cpp:
      (WebCore::ApplicationCacheGroup::selectCache):
      (WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL):
      (WebCore::ApplicationCacheGroup::update):
      (WebCore::ApplicationCacheGroup::createResourceHandle):
      (WebCore::ApplicationCacheGroup::didReceiveResponse):
      (WebCore::ApplicationCacheGroup::didFinishLoading):
      (WebCore::ApplicationCacheGroup::didFail):
      (WebCore::ApplicationCacheGroup::addEntry):
      (WebCore::CallCacheListenerTask::performTask):
      (WebCore::ApplicationCacheGroup::postListenerTask):
      * loader/appcache/DOMApplicationCache.cpp:
      (WebCore::DOMApplicationCache::applicationCacheHost):
      * loader/archive/cf/LegacyWebArchive.cpp:
      (WebCore::LegacyWebArchive::create):
      (WebCore::LegacyWebArchive::createFromSelection):
      * loader/cache/CachedResource.cpp:
      (WebCore::CachedResource::addAdditionalRequestHeaders):
      (WebCore::CachedResource::load):
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::requestImage):
      (WebCore::CachedResourceLoader::checkInsecureContent):
      (WebCore::CachedResourceLoader::canRequest):
      (WebCore::CachedResourceLoader::shouldContinueAfterNotifyingLoadedFromMemoryCache):
      (WebCore::CachedResourceLoader::requestResource):
      (WebCore::CachedResourceLoader::clientDefersImage):
      (WebCore::CachedResourceLoader::cachePolicy):
      (WebCore::CachedResourceLoader::loadDone):
      * loader/icon/IconController.cpp:
      (WebCore::IconController::commitToDatabase):
      (WebCore::IconController::startLoader):
      (WebCore::IconController::continueLoadWithDecision):
      * loader/icon/IconLoader.cpp:
      (WebCore::IconLoader::startLoading):
      (WebCore::IconLoader::notifyFinished):
      * page/Chrome.cpp:
      (WebCore::canRunModalIfDuringPageDismissal):
      * page/ContextMenuController.cpp:
      (WebCore::openNewWindow):
      (WebCore::ContextMenuController::contextMenuItemSelected):
      (WebCore::ContextMenuController::populate):
      (WebCore::ContextMenuController::checkOrEnableIfNeeded):
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::dispatchAllPendingBeforeUnloadEvents):
      (WebCore::DOMWindow::postMessageTimerFired):
      (WebCore::DOMWindow::close):
      (WebCore::DOMWindow::print):
      (WebCore::DOMWindow::stop):
      (WebCore::DOMWindow::setName):
      (WebCore::DOMWindow::opener):
      (WebCore::DOMWindow::dispatchLoadEvent):
      (WebCore::DOMWindow::setLocation):
      (WebCore::DOMWindow::createWindow):
      (WebCore::DOMWindow::open):
      * page/DOMWindowExtension.cpp:
      (WebCore::DOMWindowExtension::disconnectFrameForPageCache):
      (WebCore::DOMWindowExtension::reconnectFrameFromPageCache):
      (WebCore::DOMWindowExtension::willDestroyGlobalObjectInCachedFrame):
      (WebCore::DOMWindowExtension::willDestroyGlobalObjectInFrame):
      (WebCore::DOMWindowExtension::willDetachGlobalObjectFromFrame):
      * page/DragController.cpp:
      (WebCore::DragController::performDrag):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handleMousePressEvent):
      (WebCore::EventHandler::keyEvent):
      * page/Frame.cpp:
      (WebCore::Frame::~Frame):
      (WebCore::Frame::setView):
      (WebCore::Frame::injectUserScripts):
      (WebCore::Frame::willDetachPage):
      * page/Frame.h:
      (WebCore::Frame::loader):
      * page/FrameView.cpp:
      (WebCore::FrameView::mediaType):
      (WebCore::FrameView::setFixedVisibleContentRect):
      (WebCore::FrameView::shouldUseLoadTimeDeferredRepaintDelay):
      (WebCore::FrameView::performPostLayoutTasks):
      (WebCore::FrameView::autoSizeIfEnabled):
      (WebCore::FrameView::scrollTo):
      (WebCore::FrameView::shouldSuspendScrollAnimations):
      (WebCore::FrameView::qualifiesAsVisuallyNonEmpty):
      (WebCore::FrameView::wheelEvent):
      (WebCore::FrameView::firePaintRelatedMilestones):
      * page/History.cpp:
      (WebCore::History::stateInternal):
      (WebCore::History::stateObjectAdded):
      * page/Location.cpp:
      (WebCore::Location::setLocation):
      * page/Navigator.cpp:
      (WebCore::Navigator::userAgent):
      * page/Page.cpp:
      (WebCore::Page::goToItem):
      (WebCore::Page::refreshPlugins):
      (WebCore::Page::setDefersLoading):
      (WebCore::Page::setMemoryCacheClientCallsEnabled):
      (WebCore::Page::addRelevantRepaintedObject):
      * page/Performance.cpp:
      (WebCore::Performance::now):
      * page/PerformanceNavigation.cpp:
      (WebCore::PerformanceNavigation::type):
      (WebCore::PerformanceNavigation::redirectCount):
      * page/PerformanceResourceTiming.cpp:
      (WebCore::monotonicTimeToDocumentMilliseconds):
      * page/mac/PageMac.cpp:
      (WebCore::Page::addSchedulePair):
      (WebCore::Page::removeSchedulePair):
      * platform/ios/PasteboardIOS.mm:
      (WebCore::documentFragmentWithImageResource):
      (WebCore::documentFragmentWithRTF):
      (WebCore::Pasteboard::documentFragmentForPasteboardItemAtIndex):
      * platform/mac/HTMLConverter.mm:
      (-[WebHTMLConverter _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
      (-[WebHTMLConverter _loadFromDOMRange]):
      * platform/mac/PasteboardMac.mm:
      (WebCore::documentFragmentWithImageResource):
      (WebCore::documentFragmentWithRTF):
      (WebCore::fragmentFromWebArchive):
      * plugins/DOMMimeType.cpp:
      (WebCore::DOMMimeType::enabledPlugin):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::scrollTo):
      * svg/SVGAElement.cpp:
      (WebCore::SVGAElement::defaultEventHandler):
      * svg/graphics/SVGImage.cpp:
      (WebCore::SVGImage::~SVGImage):
      (WebCore::SVGImage::dataChanged):
      * testing/Internals.cpp:
      (WebCore::Internals::formControlStateOfPreviousHistoryItem):
      (WebCore::Internals::setFormControlStateOfPreviousHistoryItem):
      (WebCore::Internals::getReferencedFilePaths):
      (WebCore::Internals::forceReload):
      * xml/XSLTProcessorLibxslt.cpp:
      (WebCore::docLoaderFunc):
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      (WebCore::openFunc):
      (WebCore::XMLDocumentParser::startElementNs):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::load):
      (BlackBerry::WebKit::WebPagePrivate::loadString):
      (BlackBerry::WebKit::WebPagePrivate::stopCurrentLoad):
      (BlackBerry::WebKit::closeURLRecursively):
      (BlackBerry::WebKit::WebPage::dispatchBeforeUnloadEvent):
      (BlackBerry::WebKit::WebPagePrivate::shouldSendResizeEvent):
      (BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
      (BlackBerry::WebKit::WebPage::reload):
      (BlackBerry::WebKit::WebPage::reloadFromCache):
      (BlackBerry::WebKit::WebPage::textEncoding):
      (BlackBerry::WebKit::WebPage::forcedTextEncoding):
      (BlackBerry::WebKit::WebPage::setForcedTextEncoding):
      (BlackBerry::WebKit::WebPage::title):
      * WebCoreSupport/ChromeClientBlackBerry.cpp:
      (WebCore::ChromeClientBlackBerry::createWindow):
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidChangeLocationWithinPage):
      (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForResponse):
      (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
      (WebCore::FrameLoaderClientBlackBerry::delayPolicyCheckUntilFragmentExists):
      (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):
      (WebCore::FrameLoaderClientBlackBerry::createPlugin):
      (WebCore::FrameLoaderClientBlackBerry::receivedData):
      (WebCore::FrameLoaderClientBlackBerry::createDocumentLoader):
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidCommitLoad):
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
      (WebCore::FrameLoaderClientBlackBerry::dispatchWillSubmitForm):
      (WebCore::FrameLoaderClientBlackBerry::createFrame):
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidLayout):
      (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
      (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
      (WebCore::FrameLoaderClientBlackBerry::startDownload):
      (WebCore::FrameLoaderClientBlackBerry::canCachePage):
      (WebCore::FrameLoaderClientBlackBerry::didRestoreFromPageCache):
      * WebKitSupport/PagePopup.cpp:
      (BlackBerry::WebKit::PagePopup::initialize):
      
      Source/WebKit/efl:
      
      * WebCoreSupport/ChromeClientEfl.cpp:
      (kit):
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      (DumpRenderTreeSupportEfl::callShouldCloseOnWebView):
      (DumpRenderTreeSupportEfl::clearOpener):
      (DumpRenderTreeSupportEfl::frameChildren):
      (DumpRenderTreeSupportEfl::responseMimeType):
      (DumpRenderTreeSupportEfl::provisionalURL):
      * WebCoreSupport/FrameLoaderClientEfl.cpp:
      (WebCore::FrameLoaderClientEfl::callPolicyFunction):
      (WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNewWindowAction):
      (WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):
      (WebCore::FrameLoaderClientEfl::updateGlobalHistoryRedirectLinks):
      (WebCore::FrameLoaderClientEfl::updateGlobalHistory):
      * ewk/ewk_frame.cpp:
      (_ewk_frame_loader_efl_get):
      (_ewk_frame_smart_del):
      (_ewk_frame_contents_set_internal):
      (ewk_frame_stop):
      (ewk_frame_reload):
      (ewk_frame_reload_full):
      (ewk_frame_child_add):
      * ewk/ewk_view.cpp:
      (ewk_view_frame_focused_get):
      (ewk_view_setting_user_agent_set):
      (ewk_view_setting_encoding_custom_get):
      (ewk_view_setting_encoding_custom_set):
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
      (DumpRenderTreeSupportGtk::clearOpener):
      (DumpRenderTreeSupportGtk::shouldClose):
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      (WebKit::FrameLoaderClient::dispatchWillSubmitForm):
      (WebKit::FrameLoaderClient::committedLoad):
      (WebKit::FrameLoaderClient::dispatchDecidePolicyForResponse):
      (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
      (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
      (WebKit::FrameLoaderClient::createFrame):
      (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
      * webkit/webkitwebframe.cpp:
      (webkit_web_frame_finalize):
      (webkit_web_frame_load_uri):
      (webkit_web_frame_load_data):
      (webkit_web_frame_load_request):
      (webkit_web_frame_stop_loading):
      (webkit_web_frame_reload):
      (webkit_web_frame_get_data_source):
      (webkit_web_frame_get_provisional_data_source):
      (webkit_web_frame_get_response_mime_type):
      (webkit_web_frame_get_network_response):
      (WebKit::kit):
      * webkit/webkitwebpolicydecision.cpp:
      (webkit_web_policy_decision_use):
      (webkit_web_policy_decision_ignore):
      (webkit_web_policy_decision_download):
      * webkit/webkitwebview.cpp:
      (webkit_web_view_dispose):
      (webkit_web_view_reload):
      (webkit_web_view_reload_bypass_cache):
      (webkit_web_view_stop_loading):
      (webkit_web_view_can_show_mime_type):
      (webkit_web_view_set_custom_encoding):
      (webkit_web_view_get_custom_encoding):
      (webkit_web_view_get_subresources):
      
      Source/WebKit/mac:
      
      * Plugins/Hosted/HostedNetscapePluginStream.mm:
      (WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):
      * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
      (WebKit::NetscapePluginInstanceProxy::performRequest):
      (WebKit::NetscapePluginInstanceProxy::loadRequest):
      * Plugins/Hosted/WebHostedNetscapePluginView.mm:
      (-[WebHostedNetscapePluginView pluginView:receivedResponse:]):
      * Plugins/WebBaseNetscapePluginView.mm:
      (-[WebBaseNetscapePluginView requestWithURLCString:]):
      * Plugins/WebNetscapePluginStream.mm:
      (WebNetscapePluginStream::WebNetscapePluginStream):
      * Plugins/WebNetscapePluginView.mm:
      (-[WebNetscapePluginView loadStream]):
      (-[WebNetscapePluginView pluginView:receivedResponse:]):
      (-[WebNetscapePluginView loadPluginRequest:]):
      (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
      * Plugins/WebPluginController.mm:
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
      (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
      (WebFrameLoaderClient::dispatchWillSubmitForm):
      (WebFrameLoaderClient::updateGlobalHistory):
      (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
      (WebFrameLoaderClient::restoreViewState):
      (WebFrameLoaderClient::transitionToCommittedForNewPage):
      (WebFrameLoaderClient::createFrame):
      * WebCoreSupport/WebFrameNetworkingContext.mm:
      (WebFrameNetworkingContext::blockedError):
      * WebCoreSupport/WebPlatformStrategies.mm:
      (WebPlatformStrategies::getPluginInfo):
      * WebView/WebFrame.mm:
      (kit):
      (-[WebFrame _dataSource]):
      (-[WebFrame _canProvideDocumentSource]):
      (-[WebFrame _commitData:]):
      (-[WebFrame _firstLayoutDone]):
      (-[WebFrame _loadType]):
      (-[WebFrame _cacheabilityDictionary]):
      (-[WebFrame _clearOpener]):
      (-[WebFrame provisionalDataSource]):
      (-[WebFrame dataSource]):
      (-[WebFrame loadRequest:]):
      (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
      (-[WebFrame loadArchive:]):
      (-[WebFrame stopLoading]):
      (-[WebFrame reload]):
      (-[WebFrame reloadFromOrigin]):
      * WebView/WebHTMLRepresentation.mm:
      (-[WebHTMLRepresentation receivedData:withDataSource:]):
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
      * WebView/WebPDFView.mm:
      (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
      * WebView/WebRenderLayer.mm:
      (-[WebRenderLayer initWithWebFrame:]):
      * WebView/WebRenderNode.mm:
      (-[WebRenderNode _initWithCoreFrame:]):
      * WebView/WebView.mm:
      (-[WebView _close]):
      (-[WebView _loadBackForwardListFromOtherView:]):
      (-[WebView _cachedResponseForURL:]):
      (-[WebView setCustomTextEncodingName:]):
      (-[WebView shouldClose]):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::closeWindowSoon):
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::shouldClose):
      (DumpRenderTreeSupportQt::responseMimeType):
      (DumpRenderTreeSupportQt::clearOpener):
      (DumpRenderTreeSupportQt::thirdPartyCookiePolicyAllows):
      (DumpRenderTreeSupportQt::setAlternateHtml):
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::callPolicyFunction):
      (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad):
      (WebCore::FrameLoaderClientQt::updateGlobalHistory):
      (WebCore::FrameLoaderClientQt::updateGlobalHistoryRedirectLinks):
      (WebCore::FrameLoaderClientQt::callErrorPageExtension):
      (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNewWindowAction):
      (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
      (WebCore::FrameLoaderClientQt::startDownload):
      (WebCore::FrameLoaderClientQt::createFrame):
      (WebCore::FrameLoaderClientQt::objectContentType):
      * WebCoreSupport/QWebFrameAdapter.cpp:
      (QWebFrameAdapter::load):
      (QWebFrameAdapter::setContent):
      (QWebFrameAdapter::setHtml):
      (QWebFrameAdapter::kit):
      (QWebFrameAdapter::title):
      (QWebFrameAdapter::clearCoreFrame):
      * WebCoreSupport/QWebPageAdapter.cpp:
      (frameLoadRequest):
      (openNewWindow):
      (QWebPageAdapter::triggerAction):
      (QWebPageAdapter::currentFrame):
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebContextMenuClient.cpp:
      (WebContextMenuClient::searchWithGoogle):
      * WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebFrameLoaderClient::updateGlobalHistory):
      (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
      (WebFrameLoaderClient::savePlatformDataToCachedFrame):
      (WebFrameLoaderClient::createFrame):
      (WebFrameLoaderClient::dispatchDidFailToStartPlugin):
      * WebCoreSupport/WebFrameNetworkingContext.cpp:
      (WebFrameNetworkingContext::blockedError):
      (WebFrameNetworkingContext::referrer):
      * WebElementPropertyBag.cpp:
      (WebElementPropertyBag::Read):
      * WebFrame.cpp:
      (kit):
      (WebFrame::reloadFromOrigin):
      (WebFrame::loadRequest):
      (WebFrame::loadData):
      (WebFrame::dataSource):
      (WebFrame::provisionalDataSource):
      (WebFrame::stopLoading):
      (WebFrame::reload):
      (WebFrame::firstLayoutDone):
      (WebFrame::loadType):
      (WebFrame::clearOpener):
      (WebFrame::dispatchWillSubmitForm):
      (WebFrame::receivedPolicyDecision):
      (WebFrame::dispatchDecidePolicyForResponse):
      (WebFrame::dispatchDecidePolicyForNewWindowAction):
      (WebFrame::dispatchDecidePolicyForNavigationAction):
      (WebFrame::createJavaAppletWidget):
      * WebFramePolicyListener.cpp:
      (WebFramePolicyListener::receivedPolicyDecision):
      * WebView.cpp:
      (WebView::close):
      (WebView::canShowMIMEType):
      (WebView::setCustomTextEncodingName):
      (WebView::loadBackForwardListFromOtherView):
      (WebView::shouldClose):
      
      Source/WebKit/wince:
      
      * WebCoreSupport/FrameLoaderClientWinCE.cpp:
      (WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForResponse):
      (WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForNewWindowAction):
      (WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForNavigationAction):
      (WebKit::FrameLoaderClientWinCE::dispatchWillSubmitForm):
      * WebCoreSupport/FrameNetworkingContextWinCE.cpp:
      (WebKit::FrameNetworkingContextWinCE::referrer):
      * WebView.cpp:
      (WebView::createFrame):
      (WebView::load):
      (WebView::reload):
      (WebView::stop):
      
      Source/WebKit2:
      
      * Shared/WebRenderLayer.cpp:
      (WebKit::WebRenderLayer::create):
      * Shared/WebRenderObject.cpp:
      (WebKit::WebRenderObject::create):
      * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
      (WebKit::GeolocationPermissionRequestManager::startRequestForGeolocation):
      * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
      (WKBundleFrameGetFrameLoadState):
      (WKBundleFrameClearOpener):
      (WKBundleFrameCallShouldCloseOnWebView):
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      (WebKit::InjectedBundleNodeHandle::documentFrame):
      (WebKit::InjectedBundleNodeHandle::htmlFrameElementContentFrame):
      (WebKit::InjectedBundleNodeHandle::htmlIFrameElementContentFrame):
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
      * WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
      (WebKit::InjectedBundleDOMWindowExtension::frame):
      * WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
      (WebKit::InjectedBundleHitTestResult::frame):
      (WebKit::InjectedBundleHitTestResult::targetFrame):
      * WebProcess/Plugins/PDF/PDFPlugin.mm:
      (WebKit::PDFPlugin::clickedLink):
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::webPage):
      (WebKit::PluginView::didFailToInitializePlugin):
      (WebKit::PluginView::performFrameLoadURLRequest):
      (WebKit::PluginView::userAgent):
      (WebKit::PluginView::loadURL):
      (WebKit::PluginView::cancelManualStreamLoad):
      (WebKit::PluginView::proxiesForURL):
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::focusedElementChanged):
      (WebKit::WebChromeClient::focusedFrameChanged):
      (WebKit::WebChromeClient::runBeforeUnloadConfirmPanel):
      (WebKit::WebChromeClient::closeWindowSoon):
      (WebKit::WebChromeClient::runJavaScriptAlert):
      (WebKit::WebChromeClient::runJavaScriptConfirm):
      (WebKit::WebChromeClient::runJavaScriptPrompt):
      (WebKit::WebChromeClient::unavailablePluginButtonClicked):
      (WebKit::WebChromeClient::print):
      (WebKit::WebChromeClient::exceededDatabaseQuota):
      (WebKit::WebChromeClient::runOpenPanel):
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      (WebKit::WebContextMenuClient::searchWithGoogle):
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      (WebKit::WebEditorClient::textFieldDidBeginEditing):
      (WebKit::WebEditorClient::textFieldDidEndEditing):
      (WebKit::WebEditorClient::textDidChangeInTextField):
      (WebKit::WebEditorClient::textDidChangeInTextArea):
      (WebKit::WebEditorClient::doTextFieldCommandFromEvent):
      (WebKit::WebEditorClient::textWillBeDeletedInTextField):
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
      (WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
      (WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
      (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
      (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
      (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
      (WebKit::WebFrameLoaderClient::dispatchWillSendSubmitEvent):
      (WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
      (WebKit::WebFrameLoaderClient::updateGlobalHistory):
      (WebKit::WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
      (WebKit::WebFrameLoaderClient::restoreViewState):
      (WebKit::WebFrameLoaderClient::createFrame):
      (WebKit::WebFrameLoaderClient::createJavaAppletWidget):
      (WebKit::WebFrameLoaderClient::objectContentType):
      * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
      (WebKit::WebPlatformStrategies::getPluginInfo):
      * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
      (WebKit::WebFrameNetworkingContext::blockedError):
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::didReceivePolicyDecision):
      (WebKit::WebFrame::startDownload):
      (WebKit::WebFrame::source):
      (WebKit::WebFrame::contentsAsString):
      (WebKit::WebFrame::url):
      (WebKit::WebFrame::parentFrame):
      (WebKit::WebFrame::childFrames):
      (WebKit::WebFrame::stopLoading):
      (WebKit::WebFrame::frameForContext):
      (WebKit::WebFrame::provisionalURL):
      (WebKit::WebFrame::suggestedFilenameForResourceWithURL):
      (WebKit::WebFrame::mimeTypeForResourceWithURL):
      (WebKit::WebFrameFilter::shouldIncludeSubframe):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::createPlugin):
      (WebKit::WebPage::close):
      (WebKit::WebPage::tryClose):
      (WebKit::WebPage::loadURLRequest):
      (WebKit::WebPage::loadDataImpl):
      (WebKit::WebPage::linkClicked):
      (WebKit::WebPage::stopLoadingFrame):
      (WebKit::WebPage::stopLoading):
      (WebKit::WebPage::reload):
      (WebKit::WebPage::tryRestoreScrollPosition):
      (WebKit::WebPage::getMainResourceDataOfFrame):
      (WebKit::resourceDataForFrame):
      (WebKit::shouldReuseCommittedSandboxExtension):
      (WebKit::WebPage::SandboxExtensionTracker::didStartProvisionalLoad):
      (WebKit::WebPage::hasLocalDataForURL):
      (WebKit::WebPage::setCustomTextEncodingName):
      (WebKit::WebPage::canPluginHandleResponse):
      (WebKit::WebPage::canShowMIMEType):
      (WebKit::WebPage::didCommitLoad):
      * WebProcess/WebPage/mac/WebPageMac.mm:
      (WebKit::WebPage::platformHasLocalDataForURL):
      (WebKit::cachedResponseForURL):
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::downloadRequest):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154142 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df550b96
  2. 03 Mar, 2013 2 commits
    • abarth@webkit.org's avatar
      Unreviewed attempted build fix. Adds back some includes removed in · 401a3791
      abarth@webkit.org authored
      http://trac.webkit.org/changeset/144565.
      
      Source/WebCore: 
      
      * Modules/mediastream/RTCPeerConnection.cpp:
      * bindings/ScriptControllerBase.cpp:
      * bindings/objc/DOM.mm:
      * bindings/v8/ScriptController.cpp:
      * bindings/v8/V8DOMWindowShell.cpp:
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      * css/CSSFontSelector.cpp:
      * css/WebKitCSSSVGDocumentValue.cpp:
      * dom/DOMImplementation.cpp:
      * dom/PendingScript.h:
      * dom/ScriptElement.cpp:
      * dom/ScriptElement.h:
      * history/CachedFrame.cpp:
      * html/DOMURL.cpp:
      * html/HTMLAnchorElement.cpp:
      * html/HTMLAppletElement.cpp:
      * html/HTMLElement.cpp:
      * html/HTMLEmbedElement.cpp:
      * html/HTMLFrameSetElement.cpp:
      * html/HTMLHtmlElement.cpp:
      * html/HTMLImageElement.cpp:
      * html/HTMLObjectElement.cpp:
      * html/HTMLPlugInElement.cpp:
      * html/ImageDocument.cpp:
      * html/ImageInputType.cpp:
      * html/MediaDocument.cpp:
      * html/PluginDocument.cpp:
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore):
      * html/parser/HTMLConstructionSite.cpp:
      * html/parser/HTMLParserOptions.cpp:
      * html/parser/XSSAuditorDelegate.cpp:
      * inspector/InspectorDebuggerAgent.cpp:
      * inspector/InspectorFileSystemAgent.cpp:
      * inspector/InspectorFrontendHost.cpp:
      * inspector/InspectorInstrumentation.h:
      * inspector/InspectorPageAgent.cpp:
      * inspector/NetworkResourcesData.cpp:
      * inspector/NetworkResourcesData.h:
      (WebCore):
      * loader/CookieJar.cpp:
      * loader/CrossOriginAccessControl.cpp:
      * loader/FrameLoader.cpp:
      * loader/MainResourceLoader.cpp:
      * loader/MixedContentChecker.cpp:
      * loader/PingLoader.cpp:
      * loader/SubframeLoader.cpp:
      * loader/SubresourceLoader.cpp:
      * loader/appcache/ApplicationCacheGroup.cpp:
      * loader/appcache/ApplicationCacheHost.cpp:
      * loader/cache/CachedResource.cpp:
      * loader/icon/IconController.cpp:
      * page/DOMWindowExtension.cpp:
      * page/Frame.cpp:
      * page/PerformanceTiming.cpp:
      * page/PointerLockController.cpp:
      * page/animation/CSSPropertyAnimation.cpp:
      * platform/chromium/PasteboardChromium.cpp:
      * platform/efl/ErrorsEfl.cpp:
      * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
      * platform/gtk/ErrorsGtk.cpp:
      * platform/gtk/PasteboardGtk.cpp:
      * platform/gtk/PasteboardHelper.h:
      * platform/mac/ClipboardMac.mm:
      * platform/mac/HTMLConverter.mm:
      * platform/qt/PasteboardQt.cpp:
      * plugins/DOMMimeType.cpp:
      * plugins/PluginView.cpp:
      * rendering/HitTestResult.cpp:
      * rendering/RenderImage.cpp:
      * rendering/RenderImageResource.cpp:
      * rendering/RenderImageResourceStyleImage.cpp:
      * rendering/RenderLayer.cpp:
      * rendering/RenderLayerBacking.cpp:
      * svg/SVGImageLoader.cpp:
      * svg/SVGUseElement.cpp:
      * testing/MockPagePopupDriver.cpp:
      * xml/XSLStyleSheet.h:
      (WebCore):
      
      Source/WebKit/chromium: 
      
      * src/ApplicationCacheHost.cpp:
      * src/AssociatedURLLoader.cpp:
      * src/EditorClientImpl.cpp:
      * src/SharedWorkerRepository.cpp:
      * src/WebDataSourceImpl.cpp:
      * src/WebFrameImpl.h:
      (WebCore):
      * src/WebNode.cpp:
      * src/WebSharedWorkerImpl.cpp:
      * tests/FrameLoaderClientImplTest.cpp:
      
      Source/WebKit/efl: 
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      * ewk/ewk_frame.cpp:
      
      Source/WebKit/mac: 
      
      * DOM/WebDOMOperations.mm:
      * Misc/WebNSPasteboardExtras.mm:
      * WebCoreSupport/WebFrameNetworkingContext.mm:
      * WebView/WebRenderLayer.mm:
      * WebView/WebRenderNode.mm:
      
      Source/WebKit/qt: 
      
      * WebCoreSupport/NotificationPresenterClientQt.cpp:
      * WebCoreSupport/QWebPageAdapter.cpp:
      
      Source/WebKit2: 
      
      * Shared/WebRenderLayer.cpp:
      * Shared/WebRenderObject.cpp:
      * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
      * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      * WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
      * WebProcess/Plugins/PDF/PDFPlugin.mm:
      * WebProcess/Plugins/PluginView.cpp:
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
      * WebProcess/WebPage/mac/WebPageMac.mm:
      * WebProcess/WebProcess.cpp:
      * WebProcess/soup/WebProcessSoup.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144568 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      401a3791
    • abarth@webkit.org's avatar
      Unreviewed rollout of http://trac.webkit.org/r144530 · fa616dd3
      abarth@webkit.org authored
      As described in https://bugs.webkit.org/show_bug.cgi?id=111167 and
      https://bugs.webkit.org/show_bug.cgi?id=111035, this patch caused a
      large number of ASSERTs in chromium-win.
      
      Source/WebCore: 
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Modules/mediastream/RTCPeerConnection.cpp:
      * Modules/notifications/Notification.cpp:
      * Target.pri:
      * WebCore.exp.in:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/ScriptControllerBase.cpp:
      * bindings/js/JSNodeCustom.cpp:
      * bindings/js/ScriptController.cpp:
      * bindings/js/ScriptSourceCode.h:
      (WebCore):
      * bindings/objc/DOM.mm:
      * bindings/v8/ScriptController.cpp:
      * bindings/v8/V8DOMWindowShell.cpp:
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      * css/CSSCrossfadeValue.h:
      (WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
      (WebCore::CSSCrossfadeValue::CrossfadeSubimageObserverProxy::CrossfadeSubimageObserverProxy):
      * css/CSSFontFaceSource.h:
      * css/CSSFontSelector.cpp:
      * css/WebKitCSSSVGDocumentValue.cpp:
      * css/WebKitCSSSVGDocumentValue.h:
      (WebCore):
      * dom/Clipboard.cpp:
      (WebCore::Clipboard::Clipboard):
      * dom/ContainerNode.cpp:
      * dom/DOMImplementation.cpp:
      * dom/PendingScript.h:
      * dom/ScriptElement.cpp:
      * dom/ScriptElement.h:
      * history/CachedFrame.cpp:
      * html/DOMURL.cpp:
      * html/HTMLAnchorElement.cpp:
      * html/HTMLAppletElement.cpp:
      * html/HTMLElement.cpp:
      * html/HTMLEmbedElement.cpp:
      * html/HTMLFrameSetElement.cpp:
      * html/HTMLHtmlElement.cpp:
      * html/HTMLImageElement.cpp:
      * html/HTMLObjectElement.cpp:
      * html/HTMLPlugInElement.cpp:
      * html/ImageDocument.cpp:
      * html/ImageInputType.cpp:
      * html/MediaDocument.cpp:
      * html/PluginDocument.cpp:
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore):
      * html/parser/HTMLConstructionSite.cpp:
      * html/parser/HTMLParserOptions.cpp:
      * html/parser/HTMLScriptRunner.h:
      * html/parser/XSSAuditor.cpp:
      * html/parser/XSSAuditorDelegate.cpp:
      * inspector/InspectorDebuggerAgent.cpp:
      * inspector/InspectorFileSystemAgent.cpp:
      * inspector/InspectorFrontendHost.cpp:
      * inspector/InspectorInstrumentation.h:
      (WebCore):
      * inspector/InspectorPageAgent.cpp:
      * inspector/NetworkResourcesData.cpp:
      * inspector/NetworkResourcesData.h:
      (WebCore):
      * loader/CookieJar.cpp:
      * loader/CrossOriginAccessControl.cpp:
      * loader/CrossOriginAccessControl.h:
      (WebCore):
      * loader/CrossOriginPreflightResultCache.h:
      * loader/DocumentThreadableLoader.h:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::FrameLoader):
      * loader/FrameLoader.h:
      (WebCore):
      (WebCore::FrameLoader::policyChecker):
      * loader/ImageLoader.cpp:
      * loader/ImageLoader.h:
      * loader/LinkLoader.h:
      (WebCore):
      * loader/MainResourceLoader.cpp:
      * loader/MainResourceLoader.h:
      (WebCore):
      * loader/MixedContentChecker.cpp:
      * loader/PingLoader.cpp:
      * loader/PolicyChecker.h:
      (WebCore):
      * loader/ProgressTracker.cpp:
      * loader/SubframeLoader.cpp:
      * loader/SubresourceLoader.cpp:
      * loader/TextTrackLoader.cpp:
      * loader/TextTrackLoader.h:
      (WebCore):
      * loader/ThreadableLoader.h:
      * loader/appcache/ApplicationCacheGroup.cpp:
      * loader/appcache/ApplicationCacheGroup.h:
      (WebCore):
      * loader/appcache/ApplicationCacheHost.cpp:
      * loader/archive/cf/LegacyWebArchive.cpp:
      * loader/cache/CachedFont.cpp:
      * loader/cache/CachedFont.h:
      (CachedFontClient):
      (WebCore::CachedFontClient::~CachedFontClient):
      (WebCore::CachedFontClient::expectedType):
      (WebCore::CachedFontClient::resourceClientType):
      (WebCore::CachedFontClient::fontLoaded):
      (WebCore):
      * loader/cache/CachedFontClient.h: Removed.
      * loader/cache/CachedImage.cpp:
      * loader/cache/CachedRawResource.cpp:
      * loader/cache/CachedRawResource.h:
      (WebCore):
      (CachedRawResourceClient):
      (WebCore::CachedRawResourceClient::~CachedRawResourceClient):
      (WebCore::CachedRawResourceClient::expectedType):
      (WebCore::CachedRawResourceClient::resourceClientType):
      (WebCore::CachedRawResourceClient::dataSent):
      (WebCore::CachedRawResourceClient::responseReceived):
      (WebCore::CachedRawResourceClient::dataReceived):
      (WebCore::CachedRawResourceClient::redirectReceived):
      (WebCore::CachedRawResourceClient::dataDownloaded):
      * loader/cache/CachedRawResourceClient.h: Removed.
      * loader/cache/CachedResource.cpp:
      * loader/cache/CachedResourceHandle.cpp:
      (WebCore):
      * loader/cache/CachedResourceHandle.h:
      (WebCore):
      (WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
      (WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
      * loader/cache/CachedSVGDocument.h:
      (CachedSVGDocumentClient):
      (WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient):
      (WebCore::CachedSVGDocumentClient::expectedType):
      (WebCore::CachedSVGDocumentClient::resourceClientType):
      (WebCore):
      * loader/cache/CachedSVGDocumentClient.h: Removed.
      * loader/cache/CachedSVGDocumentReference.cpp: Removed.
      * loader/cache/CachedSVGDocumentReference.h:
      (WebCore):
      (WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
      (WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):
      * loader/cache/CachedStyleSheetClient.h:
      (WebCore):
      * loader/cache/MemoryCache.h:
      (WebCore):
      (MemoryCache):
      * loader/chromium/CachedRawResourceChromium.cpp:
      * loader/icon/IconController.cpp:
      * loader/icon/IconLoader.h:
      * loader/mac/ResourceLoaderMac.mm:
      * page/DOMWindowExtension.cpp:
      * page/Frame.cpp:
      (WebCore::Frame::Frame):
      (WebCore):
      (WebCore::Frame::reportMemoryUsage):
      * page/Frame.h:
      (WebCore):
      (Frame):
      (WebCore::Frame::init):
      (WebCore::Frame::loader):
      * page/PerformanceNavigation.cpp:
      * page/PerformanceTiming.cpp:
      * page/PointerLockController.cpp:
      * page/Settings.cpp:
      * page/animation/CSSPropertyAnimation.cpp:
      * platform/chromium/PasteboardChromium.cpp:
      * platform/efl/ErrorsEfl.cpp:
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
      * platform/graphics/filters/FilterOperation.cpp:
      (WebCore):
      * platform/graphics/filters/FilterOperation.h:
      (WebCore):
      (WebCore::FilterOperation::ReferenceFilterOperation::setCachedSVGDocumentReference):
      (WebCore::FilterOperation::ReferenceFilterOperation::ReferenceFilterOperation):
      * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
      * platform/gtk/ErrorsGtk.cpp:
      * platform/gtk/PasteboardGtk.cpp:
      * platform/gtk/PasteboardHelper.h:
      * platform/mac/ClipboardMac.h:
      * platform/mac/ClipboardMac.mm:
      * platform/mac/HTMLConverter.mm:
      * platform/mac/PasteboardMac.mm:
      * platform/network/AuthenticationChallengeBase.cpp:
      * platform/network/cf/CookieJarCFNet.cpp:
      * platform/network/cf/ResourceRequestCFNet.cpp:
      * platform/network/mac/CookieStorageMac.mm:
      * platform/qt/PasteboardQt.cpp:
      * plugins/DOMMimeType.cpp:
      * plugins/PluginRequest.h: Removed.
      * plugins/PluginStream.h:
      (PluginStreamClient):
      (WebCore::PluginStreamClient::~PluginStreamClient):
      (WebCore::PluginStreamClient::streamDidFinishLoading):
      (WebCore):
      * plugins/PluginStreamClient.h: Removed.
      * plugins/PluginView.cpp:
      * plugins/PluginView.h:
      (WebCore):
      (PluginRequest):
      (WebCore::PluginRequest::PluginRequest):
      (WebCore::PluginRequest::frameLoadRequest):
      (WebCore::PluginRequest::notifyData):
      (WebCore::PluginRequest::sendNotification):
      (WebCore::PluginRequest::shouldAllowPopups):
      * rendering/HitTestResult.cpp:
      * rendering/InlineFlowBox.cpp:
      * rendering/RenderBox.cpp:
      * rendering/RenderEmbeddedObject.cpp:
      * rendering/RenderImage.cpp:
      * rendering/RenderImageResource.cpp:
      (WebCore::RenderImageResource::RenderImageResource):
      (WebCore):
      * rendering/RenderImageResource.h:
      (WebCore::RenderImageResource::image):
      (WebCore::RenderImageResource::errorOccurred):
      (WebCore::RenderImageResource::usesImageContainerSize):
      (WebCore::RenderImageResource::imageHasRelativeWidth):
      (WebCore::RenderImageResource::imageHasRelativeHeight):
      (WebCore::RenderImageResource::imageSize):
      * rendering/RenderImageResourceStyleImage.cpp:
      * rendering/RenderLayer.cpp:
      * rendering/RenderLayerBacking.cpp:
      * rendering/RenderLayerFilterInfo.h:
      (WebCore):
      * rendering/RenderListItem.cpp:
      * rendering/RenderListMarker.cpp:
      * rendering/RenderSnapshottedPlugIn.cpp:
      * rendering/RenderTableCol.cpp:
      * rendering/RenderTableRow.cpp:
      * rendering/RenderTableSection.cpp:
      * rendering/style/StyleCachedShader.h:
      * rendering/style/StyleCustomFilterProgram.cpp: Removed.
      * rendering/style/StyleCustomFilterProgram.h:
      (WebCore):
      (WebCore::StyleCustomFilterProgram::vertexShaderString):
      (StyleCustomFilterProgram):
      (WebCore::StyleCustomFilterProgram::fragmentShaderString):
      (WebCore::StyleCustomFilterProgram::isLoaded):
      (WebCore::StyleCustomFilterProgram::willHaveClients):
      (WebCore::StyleCustomFilterProgram::didRemoveLastClient):
      (WebCore::StyleCustomFilterProgram::notifyFinished):
      * svg/SVGFEImageElement.h:
      * svg/SVGFontFaceUriElement.h:
      (SVGFontFaceUriElement):
      * svg/SVGImageLoader.cpp:
      * svg/SVGUseElement.cpp:
      * svg/SVGUseElement.h:
      * svg/graphics/SVGImageCache.cpp:
      * testing/MockPagePopupDriver.cpp:
      * xml/XSLStyleSheet.h:
      (WebCore):
      * xml/XSLTProcessorLibxslt.cpp:
      * xml/parser/XMLDocumentParser.cpp:
      * xml/parser/XMLDocumentParser.h:
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      
      Source/WebKit/chromium: 
      
      * src/ApplicationCacheHost.cpp:
      * src/AssociatedURLLoader.cpp:
      * src/EditorClientImpl.cpp:
      * src/SharedWorkerRepository.cpp:
      * src/WebDataSourceImpl.cpp:
      * src/WebFrameImpl.h:
      (WebCore):
      * src/WebNode.cpp:
      * src/WebSharedWorkerImpl.cpp:
      * tests/FrameLoaderClientImplTest.cpp:
      
      Source/WebKit/efl: 
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      * ewk/ewk_frame.cpp:
      
      Source/WebKit/gtk: 
      
      * webkit/webkitwebpolicydecision.cpp:
      
      Source/WebKit/mac: 
      
      * DOM/WebDOMOperations.mm:
      * Misc/WebNSPasteboardExtras.mm:
      * WebCoreSupport/WebFrameNetworkingContext.mm:
      * WebView/WebRenderLayer.mm:
      * WebView/WebRenderNode.mm:
      
      Source/WebKit/qt: 
      
      * WebCoreSupport/NotificationPresenterClientQt.cpp:
      * WebCoreSupport/QWebPageAdapter.cpp:
      
      Source/WebKit2: 
      
      * NetworkProcess/HostRecord.h:
      * NetworkProcess/NetworkResourceLoadScheduler.h:
      * NetworkProcess/NetworkResourceLoader.h:
      (WebCore):
      * Shared/WebRenderLayer.cpp:
      * Shared/WebRenderObject.cpp:
      * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
      * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      * WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
      * WebProcess/Plugins/PDF/PDFPlugin.mm:
      * WebProcess/Plugins/PluginView.cpp:
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
      * WebProcess/WebPage/mac/WebPageMac.mm:
      * WebProcess/WebProcess.cpp:
      * WebProcess/soup/WebProcessSoup.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa616dd3
  3. 02 Mar, 2013 1 commit
    • ap@apple.com's avatar
      Reduce amount of rebuilding when touching networking headers · fc363ce1
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=111035
      
              Reviewed by Eric Seidel.
      
              This uses a number of common unsurprising techniques. One interesting observation
              is that including CachedResource related headers is very expensive. We can usually
              get away with their Client counterparts, and with CachedResourceHandle.
      
              * page/Frame.cpp:
              * page/Frame.h:
              Don't include FrameLoader, greatly reducing include graph for most non-loader files.
              This required making Frame::init() non-inline - I'm not sure why it ever was.
      
              * loader/FrameLoader.cpp:
              * loader/FrameLoader.h:
              Even though FrameLoader is logically on loading side of WebCore, it's included in
              too many places. Not including PolicyChecker.h and ResourceHandle.h was among the
              largest wins. As a future improvement, we should probably convert other members
              to OwnPtrs.
      
              * css/CSSCrossfadeValue.h: Initializing CachedResourceHandle with 0 requires a
              definition of a class it holds, but default construction does not.
      
              * loader/CrossOriginAccessControl.h: This file among others only needs ResourceHandleTypes.h,
              not ResourceHandle.h. This header is semi-recent, so not all include sites were updated.
      
              * loader/cache/CachedFont.h:
              * loader/cache/CachedFontClient.h: Added.
              * loader/cache/CachedRawResource.h:
              * loader/cache/CachedRawResourceClient.h: Added.
              * loader/cache/CachedSVGDocument.h:
              * loader/cache/CachedSVGDocumentClient.h: Added.
              These types were defining client types in the same headers, making it impossible
              to avoid including networking headers through CachedResource. Moved clients into
              separate files.
      
              * plugins/PluginStream.h:
              * plugins/PluginStreamClient.h: Added.
              Similar situation here.
      
              * loader/cache/CachedResourceHandle.cpp:
              * loader/cache/CachedResourceHandle.h:
              Moved functions that need to know about CachedResource to .cpp file. This is another
              huge win. Added a destructor, so that CachedResource woudn't be needed in all files
              that include CachedResourceHandle.
      
              * loader/cache/CachedSVGDocumentReference.cpp: Added.
              * loader/cache/CachedSVGDocumentReference.h:
              Moved constructor and virtual function implementations to a .cpp file - they need
              not inlining, and this lets us avoid including CachedSVGDocument.h in the header.
      
              * platform/graphics/filters/FilterOperation.cpp:
              * platform/graphics/filters/FilterOperation.h:
              Avoid including CachedSVGDocumentReference.h. This is not such a big win now that
              CachedSVGDocumentReference.h itself is smaller, but FilterOperation is so clearly
              rendering code that it seems best to cut any ties with resources and loading.
              Added a virtual destrutor in .cpp file, because inline destructors in polymorphic
              classes are generally harmful (due to code bloat).
      
              * plugins/PluginRequest.h: Added.
              * plugins/PluginView.h:
              Moved PluginRequest into a separate file, it was out of place in a view hierarchy
              class file.
      
              * rendering/RenderImageResource.cpp:
              * rendering/RenderImageResource.h:
              Moved definitions of virtual functions to a .cpp file. Thre is no win from having
              them inline, and now we don't need CachedImage.h in the header.
      
              * rendering/style/StyleCustomFilterProgram.cpp: Added.
              * rendering/style/StyleCustomFilterProgram.h:
              Ditto.
      
              * CMakeLists.txt:
              * GNUmakefile.list.am:
              * Modules/mediastream/RTCPeerConnection.cpp:
              * Modules/notifications/Notification.cpp:
              * Target.pri:
              * WebCore.exp.in:
              * WebCore.gypi:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.vcxproj/WebCore.vcxproj:
              * WebCore.vcxproj/WebCore.vcxproj.filters:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/ScriptControllerBase.cpp:
              * bindings/js/JSNodeCustom.cpp:
              * bindings/js/ScriptController.cpp:
              * bindings/js/ScriptSourceCode.h:
              * bindings/objc/DOM.mm:
              * bindings/v8/ScriptController.cpp:
              * bindings/v8/V8DOMWindowShell.cpp:
              * bindings/v8/custom/V8DOMWindowCustom.cpp:
              * css/CSSFontFaceSource.h:
              * css/CSSFontSelector.cpp:
              * css/WebKitCSSSVGDocumentValue.cpp:
              * css/WebKitCSSSVGDocumentValue.h:
              * dom/Clipboard.cpp:
              * dom/ContainerNode.cpp:
              * dom/DOMImplementation.cpp:
              * dom/PendingScript.h:
              * dom/ScriptElement.cpp:
              * dom/ScriptElement.h:
              * history/CachedFrame.cpp:
              * html/DOMURL.cpp:
              * html/HTMLAnchorElement.cpp:
              * html/HTMLAppletElement.cpp:
              * html/HTMLElement.cpp:
              * html/HTMLEmbedElement.cpp:
              * html/HTMLFrameSetElement.cpp:
              * html/HTMLHtmlElement.cpp:
              * html/HTMLImageElement.cpp:
              * html/HTMLObjectElement.cpp:
              * html/HTMLPlugInElement.cpp:
              * html/ImageDocument.cpp:
              * html/ImageInputType.cpp:
              * html/MediaDocument.cpp:
              * html/PluginDocument.cpp:
              * html/canvas/WebGLRenderingContext.cpp:
              * html/parser/HTMLConstructionSite.cpp:
              * html/parser/HTMLParserOptions.cpp:
              * html/parser/HTMLScriptRunner.h:
              * html/parser/XSSAuditor.cpp:
              * html/parser/XSSAuditorDelegate.cpp:
              * inspector/InspectorDebuggerAgent.cpp:
              * inspector/InspectorFileSystemAgent.cpp:
              * inspector/InspectorFrontendHost.cpp:
              * inspector/InspectorInstrumentation.h:
              * inspector/InspectorPageAgent.cpp:
              * inspector/NetworkResourcesData.cpp:
              * inspector/NetworkResourcesData.h:
              * loader/CookieJar.cpp:
              * loader/CrossOriginAccessControl.cpp:
              * loader/CrossOriginPreflightResultCache.h:
              * loader/DocumentThreadableLoader.h:
              * loader/ImageLoader.cpp:
              * loader/ImageLoader.h:
              * loader/LinkLoader.h:
              * loader/MainResourceLoader.cpp:
              * loader/MainResourceLoader.h:
              * loader/MixedContentChecker.cpp:
              * loader/PingLoader.cpp:
              * loader/PolicyChecker.h:
              * loader/ProgressTracker.cpp:
              * loader/SubframeLoader.cpp:
              * loader/SubresourceLoader.cpp:
              * loader/TextTrackLoader.cpp:
              * loader/TextTrackLoader.h:
              * loader/ThreadableLoader.h:
              * loader/appcache/ApplicationCacheGroup.cpp:
              * loader/appcache/ApplicationCacheGroup.h:
              * loader/appcache/ApplicationCacheHost.cpp:
              * loader/archive/cf/LegacyWebArchive.cpp:
              * loader/cache/CachedFont.cpp:
              * loader/cache/CachedImage.cpp:
              * loader/cache/CachedRawResource.cpp:
              * loader/cache/CachedResource.cpp:
              * loader/cache/CachedStyleSheetClient.h:
              * loader/cache/MemoryCache.cpp:
              * loader/cache/MemoryCache.h:
              * loader/chromium/CachedRawResourceChromium.cpp:
              * loader/icon/IconController.cpp:
              * loader/icon/IconLoader.h:
              * loader/mac/ResourceLoaderMac.mm:
              * page/DOMWindowExtension.cpp:
              * page/DragController.cpp:
              * page/PerformanceNavigation.cpp:
              * page/PerformanceTiming.cpp:
              * page/PointerLockController.cpp:
              * page/Settings.cpp:
              * page/animation/CSSPropertyAnimation.cpp:
              * platform/chromium/PasteboardChromium.cpp:
              * platform/efl/ErrorsEfl.cpp:
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
              * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
              * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
              * platform/gtk/ErrorsGtk.cpp:
              * platform/gtk/PasteboardGtk.cpp:
              * platform/gtk/PasteboardHelper.h:
              * platform/mac/ClipboardMac.h:
              * platform/mac/ClipboardMac.mm:
              * platform/mac/HTMLConverter.mm:
              * platform/mac/PasteboardMac.mm:
              * platform/network/AuthenticationChallengeBase.cpp:
              * platform/network/cf/CookieJarCFNet.cpp:
              * platform/network/cf/ResourceRequestCFNet.cpp:
              * platform/network/mac/CookieStorageMac.mm:
              * platform/qt/PasteboardQt.cpp:
              * plugins/DOMMimeType.cpp:
              * plugins/PluginView.cpp:
              * rendering/HitTestResult.cpp:
              * rendering/InlineFlowBox.cpp:
              * rendering/RenderBox.cpp:
              * rendering/RenderEmbeddedObject.cpp:
              * rendering/RenderImage.cpp:
              * rendering/RenderImageResourceStyleImage.cpp:
              * rendering/RenderLayer.cpp:
              * rendering/RenderLayerBacking.cpp:
              * rendering/RenderLayerFilterInfo.h:
              * rendering/RenderListItem.cpp:
              * rendering/RenderListMarker.cpp:
              * rendering/RenderSnapshottedPlugIn.cpp:
              * rendering/RenderTableCol.cpp:
              * rendering/RenderTableRow.cpp:
              * rendering/RenderTableSection.cpp:
              * rendering/style/StyleCachedShader.h:
              * svg/SVGFEImageElement.h:
              * svg/SVGFontFaceUriElement.h:
              * svg/SVGImageLoader.cpp:
              * svg/SVGUseElement.cpp:
              * svg/SVGUseElement.h:
              * svg/graphics/SVGImageCache.cpp:
              * testing/MockPagePopupDriver.cpp:
              * xml/XSLStyleSheet.h:
              * xml/XSLTProcessorLibxslt.cpp:
              * xml/parser/XMLDocumentParser.cpp:
              * xml/parser/XMLDocumentParser.h:
              * xml/parser/XMLDocumentParserLibxml2.cpp:
              Many self-evident changes - removing unnecessary header includes, adding smaller
              more local ones that are now necessary.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144530 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc363ce1
  4. 01 Mar, 2013 2 commits
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r144422 and r144424. · 0b87a6c7
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/144422
      http://trac.webkit.org/changeset/144424
      https://bugs.webkit.org/show_bug.cgi?id=111167
      
      Caused over 20 tests to fail assertion on Chromium Win port as
      ASSERTION FAILED: m_platformRequestUpdated (Requested by
      toyoshim on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-01
      
      Source/WebCore:
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Modules/mediastream/RTCPeerConnection.cpp:
      * Modules/notifications/Notification.cpp:
      * Target.pri:
      * WebCore.exp.in:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/ScriptControllerBase.cpp:
      * bindings/js/JSNodeCustom.cpp:
      * bindings/js/ScriptController.cpp:
      * bindings/js/ScriptSourceCode.h:
      * bindings/objc/DOM.mm:
      * bindings/v8/ScriptController.cpp:
      * bindings/v8/V8DOMWindowShell.cpp:
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      * css/CSSCrossfadeValue.h:
      (WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
      (WebCore::CSSCrossfadeValue::CrossfadeSubimageObserverProxy::CrossfadeSubimageObserverProxy):
      * css/CSSFontFaceSource.h:
      * css/CSSFontSelector.cpp:
      * css/WebKitCSSSVGDocumentValue.cpp:
      * css/WebKitCSSSVGDocumentValue.h:
      (WebCore):
      * dom/Clipboard.cpp:
      (WebCore::Clipboard::Clipboard):
      * dom/ContainerNode.cpp:
      * dom/DOMImplementation.cpp:
      * dom/PendingScript.h:
      * dom/ScriptElement.cpp:
      * dom/ScriptElement.h:
      * history/CachedFrame.cpp:
      * html/DOMURL.cpp:
      * html/HTMLAnchorElement.cpp:
      * html/HTMLAppletElement.cpp:
      * html/HTMLElement.cpp:
      * html/HTMLEmbedElement.cpp:
      * html/HTMLFrameSetElement.cpp:
      * html/HTMLHtmlElement.cpp:
      * html/HTMLImageElement.cpp:
      * html/HTMLObjectElement.cpp:
      * html/HTMLPlugInElement.cpp:
      * html/ImageDocument.cpp:
      * html/ImageInputType.cpp:
      * html/MediaDocument.cpp:
      * html/PluginDocument.cpp:
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore):
      * html/parser/HTMLConstructionSite.cpp:
      * html/parser/HTMLParserOptions.cpp:
      * html/parser/HTMLScriptRunner.h:
      * html/parser/XSSAuditor.cpp:
      * html/parser/XSSAuditorDelegate.cpp:
      * inspector/InspectorDebuggerAgent.cpp:
      * inspector/InspectorFileSystemAgent.cpp:
      * inspector/InspectorFrontendHost.cpp:
      * inspector/InspectorInstrumentation.h:
      (WebCore):
      * inspector/InspectorPageAgent.cpp:
      * inspector/NetworkResourcesData.cpp:
      * inspector/NetworkResourcesData.h:
      (WebCore):
      * loader/CookieJar.cpp:
      * loader/CrossOriginAccessControl.cpp:
      * loader/CrossOriginAccessControl.h:
      (WebCore):
      * loader/CrossOriginPreflightResultCache.h:
      * loader/DocumentThreadableLoader.h:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::FrameLoader):
      * loader/FrameLoader.h:
      (WebCore):
      (WebCore::FrameLoader::policyChecker):
      * loader/ImageLoader.cpp:
      * loader/ImageLoader.h:
      * loader/LinkLoader.h:
      * loader/MainResourceLoader.cpp:
      * loader/MainResourceLoader.h:
      * loader/MixedContentChecker.cpp:
      * loader/PingLoader.cpp:
      * loader/PolicyChecker.h:
      (WebCore):
      * loader/ProgressTracker.cpp:
      * loader/SubframeLoader.cpp:
      * loader/SubresourceLoader.cpp:
      * loader/TextTrackLoader.cpp:
      * loader/TextTrackLoader.h:
      * loader/ThreadableLoader.h:
      * loader/appcache/ApplicationCacheGroup.cpp:
      * loader/appcache/ApplicationCacheGroup.h:
      (WebCore):
      * loader/appcache/ApplicationCacheHost.cpp:
      * loader/archive/cf/LegacyWebArchive.cpp:
      * loader/cache/CachedFont.cpp:
      * loader/cache/CachedFont.h:
      (CachedFontClient):
      (WebCore::CachedFontClient::~CachedFontClient):
      (WebCore::CachedFontClient::expectedType):
      (WebCore::CachedFontClient::resourceClientType):
      (WebCore::CachedFontClient::fontLoaded):
      (WebCore):
      * loader/cache/CachedFontClient.h: Removed.
      * loader/cache/CachedImage.cpp:
      * loader/cache/CachedRawResource.cpp:
      * loader/cache/CachedRawResource.h:
      (WebCore):
      (CachedRawResourceClient):
      (WebCore::CachedRawResourceClient::~CachedRawResourceClient):
      (WebCore::CachedRawResourceClient::expectedType):
      (WebCore::CachedRawResourceClient::resourceClientType):
      (WebCore::CachedRawResourceClient::dataSent):
      (WebCore::CachedRawResourceClient::responseReceived):
      (WebCore::CachedRawResourceClient::dataReceived):
      (WebCore::CachedRawResourceClient::redirectReceived):
      (WebCore::CachedRawResourceClient::dataDownloaded):
      * loader/cache/CachedRawResourceClient.h: Removed.
      * loader/cache/CachedResource.cpp:
      * loader/cache/CachedResourceHandle.cpp:
      * loader/cache/CachedResourceHandle.h:
      (WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
      (WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
      * loader/cache/CachedSVGDocument.h:
      (CachedSVGDocumentClient):
      (WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient):
      (WebCore::CachedSVGDocumentClient::expectedType):
      (WebCore::CachedSVGDocumentClient::resourceClientType):
      (WebCore):
      * loader/cache/CachedSVGDocumentClient.h: Removed.
      * loader/cache/CachedSVGDocumentReference.cpp: Removed.
      * loader/cache/CachedSVGDocumentReference.h:
      (WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
      (WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):
      * loader/cache/CachedStyleSheetClient.h:
      * loader/cache/MemoryCache.cpp:
      * loader/cache/MemoryCache.h:
      (WebCore):
      (MemoryCache):
      * loader/chromium/CachedRawResourceChromium.cpp:
      * loader/icon/IconController.cpp:
      * loader/icon/IconLoader.h:
      * loader/mac/ResourceLoaderMac.mm:
      * page/DOMWindowExtension.cpp:
      * page/DragController.cpp:
      * page/Frame.cpp:
      (WebCore::Frame::Frame):
      (WebCore::Frame::reportMemoryUsage):
      * page/Frame.h:
      (WebCore):
      (Frame):
      (WebCore::Frame::init):
      (WebCore::Frame::loader):
      * page/PerformanceNavigation.cpp:
      * page/PerformanceTiming.cpp:
      * page/PointerLockController.cpp:
      * page/Settings.cpp:
      * page/animation/CSSPropertyAnimation.cpp:
      * platform/chromium/PasteboardChromium.cpp:
      * platform/efl/ErrorsEfl.cpp:
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
      * platform/graphics/filters/FilterOperation.cpp:
      * platform/graphics/filters/FilterOperation.h:
      (WebCore::FilterOperation::ReferenceFilterOperation::setCachedSVGDocumentReference):
      (WebCore::FilterOperation::ReferenceFilterOperation::ReferenceFilterOperation):
      * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
      * platform/gtk/ErrorsGtk.cpp:
      * platform/gtk/PasteboardGtk.cpp:
      * platform/gtk/PasteboardHelper.h:
      * platform/mac/ClipboardMac.h:
      * platform/mac/ClipboardMac.mm:
      * platform/mac/HTMLConverter.mm:
      * platform/mac/PasteboardMac.mm:
      * platform/network/AuthenticationChallengeBase.cpp:
      * platform/network/cf/CookieJarCFNet.cpp:
      * platform/network/cf/ResourceRequestCFNet.cpp:
      * platform/network/mac/CookieStorageMac.mm:
      * platform/qt/PasteboardQt.cpp:
      * plugins/DOMMimeType.cpp:
      * plugins/PluginRequest.h: Removed.
      * plugins/PluginStream.h:
      (PluginStreamClient):
      (WebCore::PluginStreamClient::~PluginStreamClient):
      (WebCore::PluginStreamClient::streamDidFinishLoading):
      (WebCore):
      * plugins/PluginStreamClient.h: Removed.
      * plugins/PluginView.cpp:
      * plugins/PluginView.h:
      (WebCore):
      (PluginRequest):
      (WebCore::PluginRequest::PluginRequest):
      (WebCore::PluginRequest::frameLoadRequest):
      (WebCore::PluginRequest::notifyData):
      (WebCore::PluginRequest::sendNotification):
      (WebCore::PluginRequest::shouldAllowPopups):
      * rendering/HitTestResult.cpp:
      * rendering/InlineFlowBox.cpp:
      * rendering/RenderBox.cpp:
      * rendering/RenderEmbeddedObject.cpp:
      * rendering/RenderImage.cpp:
      * rendering/RenderImageResource.cpp:
      (WebCore::RenderImageResource::RenderImageResource):
      * rendering/RenderImageResource.h:
      (WebCore::RenderImageResource::image):
      (WebCore::RenderImageResource::errorOccurred):
      (WebCore::RenderImageResource::usesImageContainerSize):
      (WebCore::RenderImageResource::imageHasRelativeWidth):
      (WebCore::RenderImageResource::imageHasRelativeHeight):
      (WebCore::RenderImageResource::imageSize):
      * rendering/RenderImageResourceStyleImage.cpp:
      * rendering/RenderLayer.cpp:
      * rendering/RenderLayerBacking.cpp:
      * rendering/RenderLayerFilterInfo.h:
      * rendering/RenderListItem.cpp:
      * rendering/RenderListMarker.cpp:
      * rendering/RenderSnapshottedPlugIn.cpp:
      * rendering/RenderTableCol.cpp:
      * rendering/RenderTableRow.cpp:
      * rendering/RenderTableSection.cpp:
      * rendering/style/StyleCachedShader.h:
      * rendering/style/StyleCustomFilterProgram.cpp: Removed.
      * rendering/style/StyleCustomFilterProgram.h:
      (WebCore):
      (WebCore::StyleCustomFilterProgram::vertexShaderString):
      (StyleCustomFilterProgram):
      (WebCore::StyleCustomFilterProgram::fragmentShaderString):
      (WebCore::StyleCustomFilterProgram::isLoaded):
      (WebCore::StyleCustomFilterProgram::willHaveClients):
      (WebCore::StyleCustomFilterProgram::didRemoveLastClient):
      (WebCore::StyleCustomFilterProgram::notifyFinished):
      * svg/SVGFEImageElement.h:
      * svg/SVGFontFaceUriElement.h:
      (SVGFontFaceUriElement):
      * svg/SVGImageLoader.cpp:
      * svg/SVGUseElement.cpp:
      * svg/SVGUseElement.h:
      * svg/graphics/SVGImageCache.cpp:
      * testing/MockPagePopupDriver.cpp:
      * xml/XSLStyleSheet.h:
      * xml/XSLTProcessorLibxslt.cpp:
      * xml/parser/XMLDocumentParser.cpp:
      * xml/parser/XMLDocumentParser.h:
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      
      Source/WebKit/chromium:
      
      * src/ApplicationCacheHost.cpp:
      * src/AssociatedURLLoader.cpp:
      * src/EditorClientImpl.cpp:
      * src/SharedWorkerRepository.cpp:
      * src/WebDataSourceImpl.cpp:
      * src/WebFrameImpl.h:
      (WebCore):
      * src/WebNode.cpp:
      * src/WebSharedWorkerImpl.cpp:
      * tests/FrameLoaderClientImplTest.cpp:
      
      Source/WebKit/efl:
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      * ewk/ewk_frame.cpp:
      
      Source/WebKit/gtk:
      
      * webkit/webkitwebpolicydecision.cpp:
      
      Source/WebKit/mac:
      
      * DOM/WebDOMOperations.mm:
      * Misc/WebNSPasteboardExtras.mm:
      * WebCoreSupport/WebFrameNetworkingContext.mm:
      * WebView/WebRenderLayer.mm:
      * WebView/WebRenderNode.mm:
      
      Source/WebKit/qt:
      
      * WebCoreSupport/NotificationPresenterClientQt.cpp:
      * WebCoreSupport/QWebPageAdapter.cpp:
      
      Source/WebKit2:
      
      * NetworkProcess/HostRecord.h:
      * NetworkProcess/NetworkResourceLoadScheduler.h:
      * NetworkProcess/NetworkResourceLoader.h:
      (WebCore):
      * Shared/WebRenderLayer.cpp:
      * Shared/WebRenderObject.cpp:
      * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
      * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      * WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
      * WebProcess/Plugins/PDF/PDFPlugin.mm:
      * WebProcess/Plugins/PluginView.cpp:
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
      * WebProcess/WebPage/mac/WebPageMac.mm:
      * WebProcess/WebProcess.cpp:
      * WebProcess/soup/WebProcessSoup.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144446 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b87a6c7
    • ap@apple.com's avatar
      Reduce amount of rebuilding when touching networking headers · b2f13721
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=111035
      
      Reviewed by Eric Seidel.
      
      Source/WebCore:
      
      This uses a number of common unsurprising techniques. One interesting observation
      is that including CachedResource related headers is very expensive. We can usually
      get away with their Client counterparts, and with CachedResourceHandle.
      
      * page/Frame.cpp:
      * page/Frame.h:
      Don't include FrameLoader, greatly reducing include graph for most non-loader files.
      This required making Frame::init() non-inline - I'm not sure why it ever was.
      
      * loader/FrameLoader.cpp:
      * loader/FrameLoader.h:
      Even though FrameLoader is logically on loading side of WebCore, it's included in
      too many places. Not including PolicyChecker.h and ResourceHandle.h was among the
      largest wins. As a future improvement, we should probably convert other members
      to OwnPtrs.
      
      * css/CSSCrossfadeValue.h: Initializing CachedResourceHandle with 0 requires a
      definition of a class it holds, but default construction does not.
      
      * loader/CrossOriginAccessControl.h: This file among others only needs ResourceHandleTypes.h,
      not ResourceHandle.h. This header is semi-recent, so not all include sites were updated.
      
      * loader/cache/CachedFont.h:
      * loader/cache/CachedFontClient.h: Added.
      * loader/cache/CachedRawResource.h:
      * loader/cache/CachedRawResourceClient.h: Added.
      * loader/cache/CachedSVGDocument.h:
      * loader/cache/CachedSVGDocumentClient.h: Added.
      These types were defining client types in the same headers, making it impossible
      to avoid including networking headers through CachedResource. Moved clients into
      separate files.
      
      * plugins/PluginStream.h:
      * plugins/PluginStreamClient.h: Added.
      Similar situation here.
      
      * loader/cache/CachedResourceHandle.cpp:
      * loader/cache/CachedResourceHandle.h:
      Moved functions that need to know about CachedResource to .cpp file. This is another
      huge win. Added a destructor, so that CachedResource woudn't be needed in all files
      that include CachedResourceHandle.
      
      * loader/cache/CachedSVGDocumentReference.cpp: Added.
      * loader/cache/CachedSVGDocumentReference.h:
      Moved constructor and virtual function implementations to a .cpp file - they need
      not inlining, and this lets us avoid including CachedSVGDocument.h in the header.
      
      * platform/graphics/filters/FilterOperation.cpp:
      * platform/graphics/filters/FilterOperation.h:
      Avoid including CachedSVGDocumentReference.h. This is not such a big win now that
      CachedSVGDocumentReference.h itself is smaller, but FilterOperation is so clearly
      rendering code that it seems best to cut any ties with resources and loading.
      Added a virtual destrutor in .cpp file, because inline destructors in polymorphic
      classes are generally harmful (due to code bloat).
      
      * plugins/PluginRequest.h: Added.
      * plugins/PluginView.h:
      Moved PluginRequest into a separate file, it was out of place in a view hierarchy
      class file.
      
      * rendering/RenderImageResource.cpp:
      * rendering/RenderImageResource.h:
      Moved definitions of virtual functions to a .cpp file. Thre is no win from having
      them inline, and now we don't need CachedImage.h in the header.
      
      * rendering/style/StyleCustomFilterProgram.cpp: Added.
      * rendering/style/StyleCustomFilterProgram.h:
      Ditto.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Modules/mediastream/RTCPeerConnection.cpp:
      * Modules/notifications/Notification.cpp:
      * Target.pri:
      * WebCore.exp.in:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/ScriptControllerBase.cpp:
      * bindings/js/JSNodeCustom.cpp:
      * bindings/js/ScriptController.cpp:
      * bindings/js/ScriptSourceCode.h:
      * bindings/objc/DOM.mm:
      * bindings/v8/ScriptController.cpp:
      * bindings/v8/V8DOMWindowShell.cpp:
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      * css/CSSFontFaceSource.h:
      * css/CSSFontSelector.cpp:
      * css/WebKitCSSSVGDocumentValue.cpp:
      * css/WebKitCSSSVGDocumentValue.h:
      * dom/Clipboard.cpp:
      * dom/ContainerNode.cpp:
      * dom/DOMImplementation.cpp:
      * dom/PendingScript.h:
      * dom/ScriptElement.cpp:
      * dom/ScriptElement.h:
      * history/CachedFrame.cpp:
      * html/DOMURL.cpp:
      * html/HTMLAnchorElement.cpp:
      * html/HTMLAppletElement.cpp:
      * html/HTMLElement.cpp:
      * html/HTMLEmbedElement.cpp:
      * html/HTMLFrameSetElement.cpp:
      * html/HTMLHtmlElement.cpp:
      * html/HTMLImageElement.cpp:
      * html/HTMLObjectElement.cpp:
      * html/HTMLPlugInElement.cpp:
      * html/ImageDocument.cpp:
      * html/ImageInputType.cpp:
      * html/MediaDocument.cpp:
      * html/PluginDocument.cpp:
      * html/canvas/WebGLRenderingContext.cpp:
      * html/parser/HTMLConstructionSite.cpp:
      * html/parser/HTMLParserOptions.cpp:
      * html/parser/HTMLScriptRunner.h:
      * html/parser/XSSAuditor.cpp:
      * html/parser/XSSAuditorDelegate.cpp:
      * inspector/InspectorDebuggerAgent.cpp:
      * inspector/InspectorFileSystemAgent.cpp:
      * inspector/InspectorFrontendHost.cpp:
      * inspector/InspectorInstrumentation.h:
      * inspector/InspectorPageAgent.cpp:
      * inspector/NetworkResourcesData.cpp:
      * inspector/NetworkResourcesData.h:
      * loader/CookieJar.cpp:
      * loader/CrossOriginAccessControl.cpp:
      * loader/CrossOriginPreflightResultCache.h:
      * loader/DocumentThreadableLoader.h:
      * loader/ImageLoader.cpp:
      * loader/ImageLoader.h:
      * loader/LinkLoader.h:
      * loader/MainResourceLoader.cpp:
      * loader/MainResourceLoader.h:
      * loader/MixedContentChecker.cpp:
      * loader/PingLoader.cpp:
      * loader/PolicyChecker.h:
      * loader/ProgressTracker.cpp:
      * loader/SubframeLoader.cpp:
      * loader/SubresourceLoader.cpp:
      * loader/TextTrackLoader.cpp:
      * loader/TextTrackLoader.h:
      * loader/ThreadableLoader.h:
      * loader/appcache/ApplicationCacheGroup.cpp:
      * loader/appcache/ApplicationCacheGroup.h:
      * loader/appcache/ApplicationCacheHost.cpp:
      * loader/archive/cf/LegacyWebArchive.cpp:
      * loader/cache/CachedFont.cpp:
      * loader/cache/CachedImage.cpp:
      * loader/cache/CachedRawResource.cpp:
      * loader/cache/CachedResource.cpp:
      * loader/cache/CachedStyleSheetClient.h:
      * loader/cache/MemoryCache.cpp:
      * loader/cache/MemoryCache.h:
      * loader/chromium/CachedRawResourceChromium.cpp:
      * loader/icon/IconController.cpp:
      * loader/icon/IconLoader.h:
      * loader/mac/ResourceLoaderMac.mm:
      * page/DOMWindowExtension.cpp:
      * page/DragController.cpp:
      * page/PerformanceNavigation.cpp:
      * page/PerformanceTiming.cpp:
      * page/PointerLockController.cpp:
      * page/Settings.cpp:
      * page/animation/CSSPropertyAnimation.cpp:
      * platform/chromium/PasteboardChromium.cpp:
      * platform/efl/ErrorsEfl.cpp:
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
      * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
      * platform/gtk/ErrorsGtk.cpp:
      * platform/gtk/PasteboardGtk.cpp:
      * platform/gtk/PasteboardHelper.h:
      * platform/mac/ClipboardMac.h:
      * platform/mac/ClipboardMac.mm:
      * platform/mac/HTMLConverter.mm:
      * platform/mac/PasteboardMac.mm:
      * platform/network/AuthenticationChallengeBase.cpp:
      * platform/network/cf/CookieJarCFNet.cpp:
      * platform/network/cf/ResourceRequestCFNet.cpp:
      * platform/network/mac/CookieStorageMac.mm:
      * platform/qt/PasteboardQt.cpp:
      * plugins/DOMMimeType.cpp:
      * plugins/PluginView.cpp:
      * rendering/HitTestResult.cpp:
      * rendering/InlineFlowBox.cpp:
      * rendering/RenderBox.cpp:
      * rendering/RenderEmbeddedObject.cpp:
      * rendering/RenderImage.cpp:
      * rendering/RenderImageResourceStyleImage.cpp:
      * rendering/RenderLayer.cpp:
      * rendering/RenderLayerBacking.cpp:
      * rendering/RenderLayerFilterInfo.h:
      * rendering/RenderListItem.cpp:
      * rendering/RenderListMarker.cpp:
      * rendering/RenderSnapshottedPlugIn.cpp:
      * rendering/RenderTableCol.cpp:
      * rendering/RenderTableRow.cpp:
      * rendering/RenderTableSection.cpp:
      * rendering/style/StyleCachedShader.h:
      * svg/SVGFEImageElement.h:
      * svg/SVGFontFaceUriElement.h:
      * svg/SVGImageLoader.cpp:
      * svg/SVGUseElement.cpp:
      * svg/SVGUseElement.h:
      * svg/graphics/SVGImageCache.cpp:
      * testing/MockPagePopupDriver.cpp:
      * xml/XSLStyleSheet.h:
      * xml/XSLTProcessorLibxslt.cpp:
      * xml/parser/XMLDocumentParser.cpp:
      * xml/parser/XMLDocumentParser.h:
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      Many self-evident changes - removing unnecessary header includes, adding smaller
      more local ones that are now necessary.
      
      Source/WebKit/chromium:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * src/ApplicationCacheHost.cpp:
      * src/AssociatedURLLoader.cpp:
      * src/EditorClientImpl.cpp:
      * src/SharedWorkerRepository.cpp:
      * src/WebDataSourceImpl.cpp:
      * src/WebFrameImpl.h:
      * src/WebNode.cpp:
      * src/WebSharedWorkerImpl.cpp:
      * tests/FrameLoaderClientImplTest.cpp:
      
      Source/WebKit/efl:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      * ewk/ewk_frame.cpp:
      
      Source/WebKit/gtk:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * webkit/webkitwebpolicydecision.cpp:
      
      Source/WebKit/mac:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * DOM/WebDOMOperations.mm:
      * Misc/WebNSPasteboardExtras.mm:
      * WebCoreSupport/WebFrameNetworkingContext.mm:
      * WebView/WebRenderLayer.mm:
      * WebView/WebRenderNode.mm:
      
      Source/WebKit/qt:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * WebCoreSupport/NotificationPresenterClientQt.cpp:
      * WebCoreSupport/QWebPageAdapter.cpp:
      
      Source/WebKit2:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * NetworkProcess/HostRecord.h:
      * NetworkProcess/NetworkResourceLoadScheduler.h:
      * NetworkProcess/NetworkResourceLoader.h:
      * Shared/WebRenderLayer.cpp:
      * Shared/WebRenderObject.cpp:
      * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
      * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      * WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
      * WebProcess/Plugins/PDF/PDFPlugin.mm:
      * WebProcess/Plugins/PluginView.cpp:
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
      * WebProcess/WebPage/mac/WebPageMac.mm:
      * WebProcess/WebProcess.cpp:
      * WebProcess/soup/WebProcessSoup.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144422 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2f13721
  5. 11 Oct, 2012 1 commit
    • simonjam@chromium.org's avatar
      High res times should start at 0 · 9e180bf1
      simonjam@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84912
      
      Reviewed by Tony Gentilcore.
      
      Test: Existing Navigation Timing tests.
      
      * inspector/InspectorInstrumentation.cpp: Use legacy document time, pending 98223.
      (WebCore):
      (WebCore::InspectorInstrumentation::didFinishLoadingImpl):
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::buildObjectForTiming):
      * loader/DocumentLoadTiming.cpp:
      (WebCore::DocumentLoadTiming::convertMonotonicTimeToLegacyDocumentTime):
      (WebCore):
      (WebCore::DocumentLoadTiming::convertMonotonicTimeToZeroBasedDocumentTime):
      (WebCore::DocumentLoadTiming::markNavigationStart):
      * loader/DocumentLoadTiming.h:
      (DocumentLoadTiming):
      (WebCore::DocumentLoadTiming::navigationStart): These just report raw monotonic times now.
      (WebCore::DocumentLoadTiming::unloadEventStart):
      (WebCore::DocumentLoadTiming::unloadEventEnd):
      (WebCore::DocumentLoadTiming::redirectStart):
      (WebCore::DocumentLoadTiming::redirectEnd):
      (WebCore::DocumentLoadTiming::fetchStart):
      (WebCore::DocumentLoadTiming::responseEnd):
      (WebCore::DocumentLoadTiming::loadEventStart):
      (WebCore::DocumentLoadTiming::loadEventEnd):
      * page/PerformanceTiming.cpp:
      (WebCore::PerformanceTiming::navigationStart): Convert these back to legacy document times.
      (WebCore::PerformanceTiming::unloadEventStart):
      (WebCore::PerformanceTiming::unloadEventEnd):
      (WebCore::PerformanceTiming::redirectStart):
      (WebCore::PerformanceTiming::redirectEnd):
      (WebCore::PerformanceTiming::fetchStart):
      (WebCore::PerformanceTiming::responseEnd):
      (WebCore::PerformanceTiming::loadEventStart):
      (WebCore::PerformanceTiming::loadEventEnd):
      (WebCore::PerformanceTiming::resourceLoadTimeRelativeToAbsolute):
      (WebCore::PerformanceTiming::monotonicTimeToIntegerMilliseconds):
      * platform/network/ResourceLoadTiming.cpp:
      (WebCore::ResourceLoadTiming::convertResourceLoadTimeToMonotonicTime):
      * platform/network/ResourceLoadTiming.h:
      (ResourceLoadTiming):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@131001 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e180bf1
  6. 07 Jan, 2012 1 commit
    • abarth@webkit.org's avatar
      Disconnecting DOMWindow properties is fragile and overly complicated · 84fe60e1
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75699
      
      Reviewed by Alexey Proskuryakov.
      
      Previously, we had to carefully check every object tree hanging off of
      DOMWindow to make sure that every property correctly disconnected
      itself and all its subobjects from the Frame when the DOMWindow
      disconnected from the Frame.
      
      This patch introduces DOMWindowProperty, which is a base class that
      handles this work automagically, ensuring that we won't have any
      dangling Frame pointers and removing a bunch of boilerplate code.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * css/StyleMedia.cpp:
      (WebCore::StyleMedia::StyleMedia):
      * css/StyleMedia.h:
      (WebCore::StyleMedia::create):
      * loader/appcache/DOMApplicationCache.cpp:
      (WebCore::DOMApplicationCache::DOMApplicationCache):
      (WebCore::DOMApplicationCache::disconnectFrame):
      * loader/appcache/DOMApplicationCache.h:
      * page/BarInfo.cpp:
      (WebCore::BarInfo::BarInfo):
      * page/BarInfo.h:
      * page/Console.cpp:
      (WebCore::Console::Console):
      (WebCore::Console::memory):
      * page/Console.h:
      * page/DOMSelection.cpp:
      (WebCore::DOMSelection::DOMSelection):
      * page/DOMSelection.h:
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::registerProperty):
      (WebCore::DOMWindow::unregisterProperty):
      (WebCore::DOMWindow::clear):
      * page/DOMWindow.h:
      * page/Geolocation.cpp:
      (WebCore::Geolocation::Geolocation):
      (WebCore::Geolocation::disconnectFrame):
      * page/Geolocation.h:
      * page/History.cpp:
      (WebCore::History::History):
      * page/History.h:
      * page/Location.cpp:
      (WebCore::Location::Location):
      * page/Location.h:
      * page/Navigator.cpp:
      (WebCore::Navigator::Navigator):
      (WebCore::Navigator::~Navigator):
      * page/Navigator.h:
      * page/Performance.cpp:
      (WebCore::Performance::Performance):
      (WebCore::Performance::memory):
      * page/Performance.h:
      * page/PerformanceNavigation.cpp:
      (WebCore::PerformanceNavigation::PerformanceNavigation):
      * page/PerformanceNavigation.h:
      * page/PerformanceTiming.cpp:
      (WebCore::PerformanceTiming::PerformanceTiming):
      * page/PerformanceTiming.h:
      * page/Screen.cpp:
      (WebCore::Screen::Screen):
      * page/Screen.h:
      * plugins/DOMMimeTypeArray.cpp:
      (WebCore::DOMMimeTypeArray::DOMMimeTypeArray):
      * plugins/DOMMimeTypeArray.h:
      * plugins/DOMPluginArray.cpp:
      (WebCore::DOMPluginArray::DOMPluginArray):
      * plugins/DOMPluginArray.h:
      * storage/Storage.cpp:
      (WebCore::Storage::Storage):
      * storage/Storage.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104380 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84fe60e1
  7. 15 Dec, 2011 2 commits
    • simonjam@chromium.org's avatar
      [Navigation Timing] Use monotonicallyIncreasingTime() instead of currentTime() · dfab5cf9
      simonjam@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=58354
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      No new tests. Relies on existing webtiming-* tests.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * WebCore.gypi:
      * WebCore.pro:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * dom/Document.cpp: Use monotonic times.
      (WebCore::Document::setReadyState):
      (WebCore::Document::finishedParsing):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore::InspectorInstrumentation::didFinishLoadingImpl): Convert monotonicFinishTime to wall time if needed.
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::buildObjectForTiming): Convert monotonic requestTime to wall time.
      (WebCore::buildObjectForResourceResponse): Plumbing for above.
      (WebCore::buildObjectForCachedResource): Ditto.
      (WebCore::InspectorResourceAgent::willSendRequest): Ditto.
      (WebCore::InspectorResourceAgent::didReceiveResponse): Ditto.
      (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache): Ditto.
      * loader/DocumentLoadTiming.cpp: Added.
      (WebCore::DocumentLoadTiming::DocumentLoadTiming):
      (WebCore::DocumentLoadTiming::setNavigationStart): Determine reference time and root reference time.
      (WebCore::DocumentLoadTiming::addRedirect): Moved logic from MainResourceLoader.
      (WebCore::DocumentLoadTiming::convertMonotonicTimeToDocumentTime): Helper to compute wall time from monotonic time.
      * loader/DocumentLoadTiming.h: Turned into class. Made times monotonic.
      (WebCore::DocumentLoadTiming::setUnloadEventStart):
      (WebCore::DocumentLoadTiming::setUnloadEventEnd):
      (WebCore::DocumentLoadTiming::setRedirectStart):
      (WebCore::DocumentLoadTiming::setRedirectEnd):
      (WebCore::DocumentLoadTiming::setFetchStart):
      (WebCore::DocumentLoadTiming::setResponseEnd):
      (WebCore::DocumentLoadTiming::setLoadEventStart):
      (WebCore::DocumentLoadTiming::setLoadEventEnd):
      (WebCore::DocumentLoadTiming::setHasSameOriginAsPreviousDocument):
      (WebCore::DocumentLoadTiming::navigationStart):
      (WebCore::DocumentLoadTiming::unloadEventStart):
      (WebCore::DocumentLoadTiming::unloadEventEnd):
      (WebCore::DocumentLoadTiming::redirectStart):
      (WebCore::DocumentLoadTiming::redirectEnd):
      (WebCore::DocumentLoadTiming::redirectCount):
      (WebCore::DocumentLoadTiming::fetchStart):
      (WebCore::DocumentLoadTiming::responseEnd):
      (WebCore::DocumentLoadTiming::loadEventStart):
      (WebCore::DocumentLoadTiming::loadEventEnd):
      (WebCore::DocumentLoadTiming::hasCrossOriginRedirect):
      (WebCore::DocumentLoadTiming::hasSameOriginAsPreviousDocument):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::stopLoading):
      (WebCore::FrameLoader::commitProvisionalLoad):
      (WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
      (WebCore::FrameLoader::loadProvisionalItemFromCachedPage):
      * loader/MainResourceLoader.cpp:
      (WebCore::MainResourceLoader::continueAfterNavigationPolicy):
      (WebCore::MainResourceLoader::willSendRequest): Moved logic to DocumentLoadTiming.
      (WebCore::MainResourceLoader::didReceiveData): Use monotonic time.
      (WebCore::MainResourceLoader::didFinishLoading): Ditto.
      (WebCore::MainResourceLoader::load):
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::dispatchLoadEvent):
      * page/DOMWindow.h: Removed dispatchTimedEvent. It doesn't really help in the new model.
      * page/PerformanceNavigation.cpp:
      (WebCore::PerformanceNavigation::redirectCount):
      * page/PerformanceTiming.cpp: Removed skew correction code. This should never happen now.
      (WebCore::PerformanceTiming::navigationStart):
      (WebCore::PerformanceTiming::unloadEventStart):
      (WebCore::PerformanceTiming::unloadEventEnd):
      (WebCore::PerformanceTiming::redirectStart):
      (WebCore::PerformanceTiming::redirectEnd):
      (WebCore::PerformanceTiming::fetchStart):
      (WebCore::PerformanceTiming::responseEnd):
      (WebCore::PerformanceTiming::domLoading):
      (WebCore::PerformanceTiming::domInteractive):
      (WebCore::PerformanceTiming::domContentLoadedEventStart):
      (WebCore::PerformanceTiming::domContentLoadedEventEnd):
      (WebCore::PerformanceTiming::domComplete):
      (WebCore::PerformanceTiming::loadEventStart):
      (WebCore::PerformanceTiming::loadEventEnd):
      (WebCore::PerformanceTiming::resourceLoadTimeRelativeToAbsolute): Used for ResourceLoadTiming.
      (WebCore::PerformanceTiming::monotonicTimeToIntegerMilliseconds): Used for DocumentTiming and DocumentLoadTiming.
      * page/PerformanceTiming.h:
      * platform/network/ResourceLoadTiming.cpp:
      (WebCore::ResourceLoadTiming::convertResourceLoadTimeToDocumentTime):
      * platform/network/ResourceLoadTiming.h: Added helper function to convert to wall times. Added instructions for use.
      
      LayoutTests:
      
      * fast/dom/script-tests/webtiming.js: Current monotonic time is unknown until performance.now() is available. Use 0 until then.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102961 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dfab5cf9
    • vsevik@chromium.org's avatar
      Unreviewed revert of r102696 ([Navigation Timing] Use... · 9a1f4aad
      vsevik@chromium.org authored
      Unreviewed revert of r102696 ([Navigation Timing] Use monotonicallyIncreasingTime() instead of currentTime()).
      Breaks inspector's network panel timeline on chromium.
      
      Source/WebCore:
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * dom/Document.cpp:
      (WebCore::Document::setReadyState):
      (WebCore::Document::finishedParsing):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore::InspectorInstrumentation::didFinishLoadingImpl):
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::buildObjectForTiming):
      (WebCore::buildObjectForResourceResponse):
      (WebCore::buildObjectForCachedResource):
      (WebCore::InspectorResourceAgent::willSendRequest):
      (WebCore::InspectorResourceAgent::didReceiveResponse):
      (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
      * loader/DocumentLoadTiming.cpp: Removed.
      * loader/DocumentLoadTiming.h:
      (WebCore::DocumentLoadTiming::DocumentLoadTiming):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::stopLoading):
      (WebCore::FrameLoader::commitProvisionalLoad):
      (WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
      (WebCore::FrameLoader::loadProvisionalItemFromCachedPage):
      * loader/MainResourceLoader.cpp:
      (WebCore::MainResourceLoader::continueAfterNavigationPolicy):
      (WebCore::MainResourceLoader::willSendRequest):
      (WebCore::MainResourceLoader::didReceiveData):
      (WebCore::MainResourceLoader::didFinishLoading):
      (WebCore::MainResourceLoader::load):
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::dispatchLoadEvent):
      (WebCore::DOMWindow::dispatchTimedEvent):
      * page/DOMWindow.h:
      * page/PerformanceNavigation.cpp:
      (WebCore::PerformanceNavigation::redirectCount):
      * page/PerformanceTiming.cpp:
      (WebCore::getPossiblySkewedTimeInKnownRange):
      (WebCore::PerformanceTiming::navigationStart):
      (WebCore::PerformanceTiming::unloadEventStart):
      (WebCore::PerformanceTiming::unloadEventEnd):
      (WebCore::PerformanceTiming::redirectStart):
      (WebCore::PerformanceTiming::redirectEnd):
      (WebCore::PerformanceTiming::fetchStart):
      (WebCore::PerformanceTiming::responseEnd):
      (WebCore::PerformanceTiming::domLoading):
      (WebCore::PerformanceTiming::domInteractive):
      (WebCore::PerformanceTiming::domContentLoadedEventStart):
      (WebCore::PerformanceTiming::domContentLoadedEventEnd):
      (WebCore::PerformanceTiming::domComplete):
      (WebCore::PerformanceTiming::loadEventStart):
      (WebCore::PerformanceTiming::loadEventEnd):
      (WebCore::PerformanceTiming::resourceLoadTimeRelativeToAbsolute):
      * page/PerformanceTiming.h:
      * platform/network/ResourceLoadTiming.cpp: Removed.
      * platform/network/ResourceLoadTiming.h:
      
      LayoutTests:
      
      * fast/dom/script-tests/webtiming.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102908 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a1f4aad
  8. 13 Dec, 2011 1 commit
    • simonjam@chromium.org's avatar
      [Navigation Timing] Use monotonicallyIncreasingTime() instead of currentTime() · 59705c45
      simonjam@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=58354
      
      Reviewed by Pavel Feldman.
      
      No new tests. Relies on existing webtiming-* tests.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * WebCore.gypi:
      * WebCore.pro:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * dom/Document.cpp: Use monotonic times.
      (WebCore::Document::setReadyState):
      (WebCore::Document::finishedParsing):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore::InspectorInstrumentation::didFinishLoadingImpl): Convert monotonicFinishTime to wall time if needed.
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::buildObjectForTiming): Convert monotonic requestTime to wall time.
      (WebCore::buildObjectForResourceResponse): Plumbing for above.
      (WebCore::buildObjectForCachedResource): Ditto.
      (WebCore::InspectorResourceAgent::willSendRequest): Ditto.
      (WebCore::InspectorResourceAgent::didReceiveResponse): Ditto.
      (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache): Ditto.
      * loader/DocumentLoadTiming.cpp: Added.
      (WebCore::DocumentLoadTiming::DocumentLoadTiming):
      (WebCore::DocumentLoadTiming::setNavigationStart): Determine reference time and root reference time.
      (WebCore::DocumentLoadTiming::addRedirect): Moved logic from MainResourceLoader.
      (WebCore::DocumentLoadTiming::convertMonotonicTimeToDocumentTime): Helper to compute wall time from monotonic time.
      * loader/DocumentLoadTiming.h: Turned into class. Made times monotonic.
      (WebCore::DocumentLoadTiming::setUnloadEventStart):
      (WebCore::DocumentLoadTiming::setUnloadEventEnd):
      (WebCore::DocumentLoadTiming::setRedirectStart):
      (WebCore::DocumentLoadTiming::setRedirectEnd):
      (WebCore::DocumentLoadTiming::setFetchStart):
      (WebCore::DocumentLoadTiming::setResponseEnd):
      (WebCore::DocumentLoadTiming::setLoadEventStart):
      (WebCore::DocumentLoadTiming::setLoadEventEnd):
      (WebCore::DocumentLoadTiming::setHasSameOriginAsPreviousDocument):
      (WebCore::DocumentLoadTiming::navigationStart):
      (WebCore::DocumentLoadTiming::unloadEventStart):
      (WebCore::DocumentLoadTiming::unloadEventEnd):
      (WebCore::DocumentLoadTiming::redirectStart):
      (WebCore::DocumentLoadTiming::redirectEnd):
      (WebCore::DocumentLoadTiming::redirectCount):
      (WebCore::DocumentLoadTiming::fetchStart):
      (WebCore::DocumentLoadTiming::responseEnd):
      (WebCore::DocumentLoadTiming::loadEventStart):
      (WebCore::DocumentLoadTiming::loadEventEnd):
      (WebCore::DocumentLoadTiming::hasCrossOriginRedirect):
      (WebCore::DocumentLoadTiming::hasSameOriginAsPreviousDocument):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::stopLoading):
      (WebCore::FrameLoader::commitProvisionalLoad):
      (WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
      (WebCore::FrameLoader::loadProvisionalItemFromCachedPage):
      * loader/MainResourceLoader.cpp:
      (WebCore::MainResourceLoader::continueAfterNavigationPolicy):
      (WebCore::MainResourceLoader::willSendRequest): Moved logic to DocumentLoadTiming.
      (WebCore::MainResourceLoader::didReceiveData): Use monotonic time.
      (WebCore::MainResourceLoader::didFinishLoading): Ditto.
      (WebCore::MainResourceLoader::load):
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::dispatchLoadEvent):
      * page/DOMWindow.h: Removed dispatchTimedEvent. It doesn't really help in the new model.
      * page/PerformanceNavigation.cpp:
      (WebCore::PerformanceNavigation::redirectCount):
      * page/PerformanceTiming.cpp: Removed skew correction code. This should never happen now.
      (WebCore::PerformanceTiming::navigationStart):
      (WebCore::PerformanceTiming::unloadEventStart):
      (WebCore::PerformanceTiming::unloadEventEnd):
      (WebCore::PerformanceTiming::redirectStart):
      (WebCore::PerformanceTiming::redirectEnd):
      (WebCore::PerformanceTiming::fetchStart):
      (WebCore::PerformanceTiming::responseEnd):
      (WebCore::PerformanceTiming::domLoading):
      (WebCore::PerformanceTiming::domInteractive):
      (WebCore::PerformanceTiming::domContentLoadedEventStart):
      (WebCore::PerformanceTiming::domContentLoadedEventEnd):
      (WebCore::PerformanceTiming::domComplete):
      (WebCore::PerformanceTiming::loadEventStart):
      (WebCore::PerformanceTiming::loadEventEnd):
      (WebCore::PerformanceTiming::resourceLoadTimeRelativeToAbsolute): Used for ResourceLoadTiming.
      (WebCore::PerformanceTiming::monotonicTimeToIntegerMilliseconds): Used for DocumentTiming and DocumentLoadTiming.
      * page/PerformanceTiming.h:
      * platform/network/ResourceLoadTiming.cpp:
      (WebCore::ResourceLoadTiming::convertResourceLoadTimeToDocumentTime):
      * platform/network/ResourceLoadTiming.h: Added helper function to convert to wall times. Added instructions for use.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102696 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59705c45
  9. 05 May, 2011 1 commit
  10. 27 Apr, 2011 1 commit
    • mihaip@chromium.org's avatar
      2011-04-27 Mihai Parparita <mihaip@chromium.org> · 3c16b0c1
      mihaip@chromium.org authored
              Reviewed by Eric Seidel.
      
              Frame.h shouldn't include Document.h
              https://bugs.webkit.org/show_bug.cgi?id=59560
      
              Frame can use a forward-declared Document if we move
              Frame::displayStringModifiedByEncoding's implementation out of the
              header.
                                      Size  #includes  Size * #includes
              Before: page/Frame.h:   0.746       653           487.138
                      dom/Document.h: 0.220      1306           287.320
      
              After:  page/Frame.h:   0.646       653           421.838
                      dom/Document.h: 0.220      1189           261.580
      
              * WebCore.exp.in:
              * bindings/ScriptControllerBase.cpp:
              * bindings/generic/BindingSecurityBase.cpp:
              * bindings/v8/V8Proxy.cpp:
              * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
              * dom/CharacterData.cpp:
              * dom/UserTypingGestureIndicator.cpp:
              * editing/chromium/SelectionControllerChromium.cpp:
              * inspector/InspectorDOMStorageResource.cpp:
              * inspector/InspectorInstrumentation.h:
              * loader/PingLoader.cpp:
              * loader/SubresourceLoader.cpp:
              * loader/appcache/DOMApplicationCache.cpp:
              * loader/cache/CachedResourceRequest.cpp:
              * page/Frame.cpp:
              (WebCore::Frame::displayStringModifiedByEncoding):
              * page/Frame.h:
              * page/Geolocation.cpp:
              * page/Location.cpp:
              * page/Navigator.cpp:
              * page/PageGroupLoadDeferrer.cpp:
              * page/PerformanceTiming.cpp:
              * xml/XSLTProcessorLibxslt.cpp:
      2011-04-27  Mihai Parparita  <mihaip@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Frame.h shouldn't include Document.h
              https://bugs.webkit.org/show_bug.cgi?id=59560
      
              Add Document.h #includes for files that were relying on transitive
              #includes via Frame.h.
      
              * src/LocalFileSystemChromium.cpp:
              * src/StorageEventDispatcherImpl.cpp:
              * src/WebFrameImpl.h:
              * src/WebWorkerBase.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c16b0c1
  11. 11 Apr, 2011 1 commit
  12. 24 Feb, 2011 1 commit
    • simonjam@chromium.org's avatar
      2011-02-24 James Simonsen <simonjam@chromium.org> · efd425b5
      simonjam@chromium.org authored
              Reviewed by Tony Gentilcore.
      
              [Web Timing] Zero out navigationStart and unloadEvent on cross-origin redirect
              https://bugs.webkit.org/show_bug.cgi?id=55068
      
              * http/tests/misc/resources/webtiming-cross-origin-and-back2.html: Expect navStart and unload to be zero.
              * http/tests/misc/resources/webtiming-cross-origin-redirect.html: Expect navStart to be zero.
              * http/tests/misc/webtiming-origins-expected.txt:
      2011-02-24  James Simonsen  <simonjam@chromium.org>
      
              Reviewed by Tony Gentilcore.
      
              [Web Timing] Zero out navigationStart and unloadEvent on cross-origin redirect
              https://bugs.webkit.org/show_bug.cgi?id=55068
      
              Test: http/tests/misc/webtiming-origins.html
      
              * page/PerformanceTiming.cpp:
              (WebCore::PerformanceTiming::navigationStart): Zero out on cross origin redirect.
              (WebCore::PerformanceTiming::unloadEventStart): Ditto.
              (WebCore::PerformanceTiming::unloadEventEnd): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      efd425b5
  13. 11 Jan, 2011 1 commit
    • simonjam@chromium.org's avatar
      2011-01-11 James Simonsen <simonjam@chromium.org> · 4648b7c3
      simonjam@chromium.org authored
              Reviewed by Eric Seidel.
      
              [Web Timing] Rename sslHandshakeStart to secureConnectionStart
              https://bugs.webkit.org/show_bug.cgi?id=52239
      
              * fast/dom/Window/window-properties-performance-expected.txt:
              * fast/dom/script-tests/webtiming.js:
              (checkTimingBeforeLoad):
              (checkTimingWhileDeferred):
              (checkWebTimingOnDOMContentLoaded):
              (checkWebTimingWhileAsync):
              (checkWebTimingOnLoad):
              (checkWebTimingAfterLoad):
              * fast/dom/webtiming-document-open-expected.txt:
              * fast/dom/webtiming-expected.txt:
              * fast/dom/webtiming-navigate-within-document-expected.txt:
              * http/tests/misc/resources/webtiming-cross-origin-and-back2.html:
              * http/tests/misc/resources/webtiming-cross-origin-redirect.html:
              * http/tests/misc/resources/webtiming-no-origin.html:
              * http/tests/misc/resources/webtiming-ssl.html:
              * http/tests/misc/webtiming-origins-expected.txt:
              * http/tests/misc/webtiming-ssl-expected.txt:
      2011-01-11  James Simonsen  <simonjam@chromium.org>
      
              Reviewed by Eric Seidel.
      
              [Web Timing] Rename sslHandshakeStart to secureConnectionStart
              https://bugs.webkit.org/show_bug.cgi?id=52239
      
              * page/PerformanceTiming.cpp:
              (WebCore::PerformanceTiming::secureConnectionStart):
              * page/PerformanceTiming.h:
              * page/PerformanceTiming.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75560 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4648b7c3
  14. 08 Jan, 2011 1 commit
  15. 06 Jan, 2011 2 commits
    • simonjam@chromium.org's avatar
      2011-01-05 James Simonsen <simonjam@chromium.org> · 92bc9b02
      simonjam@chromium.org authored
              Reviewed by Adam Barth.
      
              [Web Timing] Zero out some values on cross-origin redirects
              https://bugs.webkit.org/show_bug.cgi?id=49294
      
              * fast/dom/script-tests/webtiming.js:
              (checkTimingBeforeLoad): Remove unload. Its behavior depends on prior navigation and is tested separately.
              (checkTimingWhileDeferred): Ditto.
              (checkWebTimingOnDOMContentLoaded): Ditto.
              (checkWebTimingWhileAsync): Ditto.
              (checkWebTimingOnLoad): Ditto.
              (checkWebTimingAfterLoad): Ditto.
              * fast/dom/webtiming-expected.txt:
              * http/tests/misc/resources/webtiming-cross-origin-and-back-redirect1.php: Added.
              * http/tests/misc/resources/webtiming-cross-origin-and-back-redirect2.php: Added.
              * http/tests/misc/resources/webtiming-cross-origin-and-back1.html: Added.
              * http/tests/misc/resources/webtiming-cross-origin-and-back2.html: Added.
              * http/tests/misc/resources/webtiming-cross-origin-redirect.html: Added.
              * http/tests/misc/resources/webtiming-cross-origin-redirect.php: Added.
              * http/tests/misc/resources/webtiming-no-origin.html: Added.
              * http/tests/misc/webtiming-origins-expected.txt: Added.
              * http/tests/misc/webtiming-origins.html: Added.
              * platform/gtk/Skipped: Skip new web timing test.
              * platform/mac/Skipped: Ditto.
              * platform/win/Skipped: Ditto.
      2011-01-05  James Simonsen  <simonjam@chromium.org>
      
              Reviewed by Adam Barth.
      
              [Web Timing] Zero out some values on cross-origin redirects
              https://bugs.webkit.org/show_bug.cgi?id=49294
      
              Tests: http/tests/misc/webtiming-cross-origin-redirect.php
                     http/tests/misc/webtiming-origins.html
      
              * loader/DocumentLoadTiming.h:
              (WebCore::DocumentLoadTiming::DocumentLoadTiming): Add flags for cross-origin redirects and same-origin navigation.
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::~FrameLoader):
              (WebCore::FrameLoader::stopLoading): Don't overwrite previous unload times.
              (WebCore::FrameLoader::completed):
              (WebCore::FrameLoader::loadWithDocumentLoader): Remember previous URL to see if navigation is same-origin.
              (WebCore::FrameLoader::commitProvisionalLoad): Set flag if navigation is same-origin.
              * loader/FrameLoader.h:
              * loader/MainResourceLoader.cpp:
              (WebCore::MainResourceLoader::willSendRequest): Set flag on cross-origin redirects.
              * page/PerformanceNavigation.cpp:
              (WebCore::PerformanceNavigation::redirectCount): Clear if cross-origin redirect flag is set.
              * page/PerformanceTiming.cpp:
              (WebCore::PerformanceTiming::redirectStart): Ditto.
              (WebCore::PerformanceTiming::redirectEnd): Ditto.
              (WebCore::PerformanceTiming::unloadEventStart): Clear if cross-origin navigation is set.
              (WebCore::PerformanceTiming::unloadEventEnd): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75129 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92bc9b02
    • simonjam@chromium.org's avatar
      2011-01-05 James Simonsen <simonjam@chromium.org> · f6fac390
      simonjam@chromium.org authored
              Reviewed by Darin Fisher.
      
              [Web Timing] requestStart and responseStart should be available even if the document is still loading
              https://bugs.webkit.org/show_bug.cgi?id=51368
      
              * http/tests/misc/webtiming-slow-load-expected.txt: Added.
              * http/tests/misc/webtiming-slow-load.php: Added.
      2011-01-05  James Simonsen  <simonjam@chromium.org>
      
              Reviewed by Darin Fisher.
      
              [Web Timing] requestStart and responseStart should be available even if the document is still loading
              https://bugs.webkit.org/show_bug.cgi?id=51368
      
              Test: http/tests/misc/webtiming-slow-load.php
      
              * page/PerformanceTiming.cpp:
              (WebCore::getPossiblySkewedTimeInKnownRange): Handle case where response is not yet complete.
              (WebCore::PerformanceTiming::resourceLoadTimeRelativeToAbsolute): Use full upper bound.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75120 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6fac390
  16. 18 Dec, 2010 1 commit
    • tonyg@chromium.org's avatar
      2010-12-18 Tony Gentilcore <tonyg@chromium.org> · 64d18d9b
      tonyg@chromium.org authored
              Reviewed by Laszlo Gombos.
      
              [Web Timing] Rename domContentLoaded{Start,End}->domContentLoadedEvent{Start,End}
              https://bugs.webkit.org/show_bug.cgi?id=50943
      
              * fast/dom/Window/window-properties-performance-expected.txt:
              * fast/dom/script-tests/webtiming.js:
              (checkTimingBeforeLoad):
              (checkTimingWhileDeferred):
              (checkWebTimingOnDOMContentLoaded):
              (checkWebTimingWhileAsync):
              (checkWebTimingOnLoad):
              (checkWebTimingAfterLoad):
              * fast/dom/webtiming-document-open-expected.txt:
              * fast/dom/webtiming-expected.txt:
              * fast/dom/webtiming-navigate-within-document-expected.txt:
      2010-12-18  Tony Gentilcore  <tonyg@chromium.org>
      
              Reviewed by Laszlo Gombos.
      
              [Web Timing] Rename domContentLoaded{Start,End}->domContentLoadedEvent{Start,End}
              https://bugs.webkit.org/show_bug.cgi?id=50943
      
              See: http://test.w3.org/webperf/specs/NavigationTiming/#nt-dom-content-event-start
      
              * dom/Document.cpp:
              (WebCore::Document::finishedParsing):
              * dom/DocumentTiming.h:
              (WebCore::DocumentTiming::DocumentTiming):
              * page/PerformanceTiming.cpp:
              (WebCore::PerformanceTiming::domContentLoadedEventStart):
              (WebCore::PerformanceTiming::domContentLoadedEventEnd):
              * page/PerformanceTiming.h:
              * page/PerformanceTiming.idl:
      2010-12-18  Tony Gentilcore  <tonyg@chromium.org>
      
              Reviewed by Laszlo Gombos.
      
              [Web Timing] Rename domContentLoaded{Start,End}->domContentLoadedEvent{Start,End}
              https://bugs.webkit.org/show_bug.cgi?id=50943
      
              Exposes all dom* times to the chromium port. I'm particularly interested in
              domContentLoadedEventEnd as it compares to the FinishDoc metric.
      
              * public/WebPerformance.h:
              * src/WebPerformance.cpp:
              (WebKit::WebPerformance::domLoading):
              (WebKit::WebPerformance::domInteractive):
              (WebKit::WebPerformance::domContentLoadedEventStart):
              (WebKit::WebPerformance::domContentLoadedEventEnd):
              (WebKit::WebPerformance::domComplete):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74315 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64d18d9b
  17. 17 Dec, 2010 1 commit
    • commit-queue@webkit.org's avatar
      2010-12-17 James Simonsen <simonjam@chromium.org> · 1eae3f25
      commit-queue@webkit.org authored
              Reviewed by Darin Fisher.
      
              [Web Timing] Add sslHandshakeStart to interface
      
              https://bugs.webkit.org/show_bug.cgi?id=50400
      
              * fast/dom/Window/window-properties-performance-expected.txt: Added sslHandshakeStart.
              * fast/dom/script-tests/webtiming.js: Ditto.
              (checkTimingBeforeLoad):
              (checkTimingWhileDeferred):
              (checkWebTimingOnDOMContentLoaded):
              (checkWebTimingWhileAsync):
              (checkWebTimingOnLoad):
              (checkWebTimingAfterLoad):
              * fast/dom/webtiming-document-open-expected.txt: Ditto.
              * fast/dom/webtiming-expected.txt: Ditto.
              * fast/dom/webtiming-navigate-within-document-expected.txt: Ditto.
              * http/tests/misc/resources/webtiming-ssl.html: Added.
              * http/tests/misc/webtiming-ssl-expected.txt: Added.
              * http/tests/misc/webtiming-ssl.php: Added.
              * platform/gtk/Skipped: WebTiming disabled here.
              * platform/mac/Skipped: Ditto.
              * platform/win/Skipped: Ditto.
      2010-12-17  James Simonsen  <simonjam@chromium.org>
      
              Reviewed by Darin Fisher.
      
              [Web Timing] Add sslHandshakeStart to interface
      
              https://bugs.webkit.org/show_bug.cgi?id=50400
      
              Test: http/tests/misc/webtiming-ssl.php
      
              * page/PerformanceTiming.cpp:
              (WebCore::PerformanceTiming::connectStart): Update comment.
              (WebCore::PerformanceTiming::connectEnd): Remove SSL time.
              (WebCore::PerformanceTiming::sslHandshakeStart): Added.
              * page/PerformanceTiming.h: Added sslHandshakeStart.
              * page/PerformanceTiming.idl: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74242 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1eae3f25
  18. 19 Nov, 2010 1 commit
    • commit-queue@webkit.org's avatar
      2010-11-19 James Simonsen <simonjam@chromium.org> · b0010969
      commit-queue@webkit.org authored
              Reviewed by Darin Fisher.
      
              [Web Timing] Add unloadEventStart
              https://bugs.webkit.org/show_bug.cgi?id=49101
      
              * fast/dom/Window/window-properties-performance-expected.txt:
              * fast/dom/script-tests/webtiming.js:
              (checkTimingBeforeLoad):
              (checkTimingWhileDeferred):
              (checkWebTimingWhileAsync):
              (checkWebTimingOnLoad):
              (checkWebTimingAfterLoad):
              * fast/dom/webtiming-document-open-expected.txt:
              * fast/dom/webtiming-expected.txt:
              * fast/dom/webtiming-navigate-within-document-expected.txt:
      2010-11-19  James Simonsen  <simonjam@chromium.org>
      
              Reviewed by Darin Fisher.
      
              [Web Timing] Add unloadEventStart
              https://bugs.webkit.org/show_bug.cgi?id=49101
      
              * loader/DocumentLoadTiming.h:
              (WebCore::DocumentLoadTiming::DocumentLoadTiming):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::stopLoading): Use dispatchTimedEvent().
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::dispatchLoadEvent): Use dispatchTimedEvent().
              (WebCore::DOMWindow::dispatchTimedEvent): Added.
              * page/DOMWindow.h:
              * page/Timing.cpp:
              (WebCore::Timing::unloadEventStart):
              * page/Timing.h:
              * page/Timing.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72415 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0010969
  19. 12 Nov, 2010 1 commit
    • commit-queue@webkit.org's avatar
      2010-11-12 James Simonsen <simonjam@chromium.org> · 6000d4c1
      commit-queue@webkit.org authored
              Reviewed by Darin Fisher.
      
              [Web Timing] Rename interfaces:
              - Navigation -> PerformanceNavigation
              - Timing -> PerformanceTiming
              https://bugs.webkit.org/show_bug.cgi?id=48919
      
              * fast/dom/Window/window-properties-performance-expected.txt: Class names changed.
      2010-11-12  James Simonsen  <simonjam@chromium.org>
      
              Reviewed by Darin Fisher.
      
              [Web Timing] Rename interfaces:
              - Navigation -> PerformanceNavigation
              - Timing -> PerformanceTiming
              https://bugs.webkit.org/show_bug.cgi?id=48919
      
              * DerivedSources.cpp:
              * DerivedSources.make:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * page/Performance.cpp:
              (WebCore::Performance::navigation):
              (WebCore::Performance::timing):
              * page/Performance.h:
              * page/Performance.idl:
              * page/PerformanceNavigation.cpp: Renamed from WebCore/page/Navigation.cpp.
              (WebCore::PerformanceNavigation::PerformanceNavigation):
              (WebCore::PerformanceNavigation::frame):
              (WebCore::PerformanceNavigation::disconnectFrame):
              (WebCore::PerformanceNavigation::type):
              (WebCore::PerformanceNavigation::redirectCount):
              * page/PerformanceNavigation.h: Renamed from WebCore/page/Navigation.h.
              (WebCore::PerformanceNavigation::create):
              * page/PerformanceNavigation.idl: Renamed from WebCore/page/Navigation.idl.
              * page/PerformanceTiming.cpp: Renamed from WebCore/page/Timing.cpp.
              (WebCore::toIntegerMilliseconds):
              (WebCore::getPossiblySkewedTimeInKnownRange):
              (WebCore::PerformanceTiming::PerformanceTiming):
              (WebCore::PerformanceTiming::frame):
              (WebCore::PerformanceTiming::disconnectFrame):
              (WebCore::PerformanceTiming::navigationStart):
              (WebCore::PerformanceTiming::unloadEventEnd):
              (WebCore::PerformanceTiming::redirectStart):
              (WebCore::PerformanceTiming::redirectEnd):
              (WebCore::PerformanceTiming::fetchStart):
              (WebCore::PerformanceTiming::domainLookupStart):
              (WebCore::PerformanceTiming::domainLookupEnd):
              (WebCore::PerformanceTiming::connectStart):
              (WebCore::PerformanceTiming::connectEnd):
              (WebCore::PerformanceTiming::requestStart):
              (WebCore::PerformanceTiming::requestEnd):
              (WebCore::PerformanceTiming::responseStart):
              (WebCore::PerformanceTiming::responseEnd):
              (WebCore::PerformanceTiming::domLoading):
              (WebCore::PerformanceTiming::domInteractive):
              (WebCore::PerformanceTiming::domContentLoaded):
              (WebCore::PerformanceTiming::domComplete):
              (WebCore::PerformanceTiming::loadEventStart):
              (WebCore::PerformanceTiming::loadEventEnd):
              (WebCore::PerformanceTiming::documentLoader):
              (WebCore::PerformanceTiming::documentTiming):
              (WebCore::PerformanceTiming::documentLoadTiming):
              (WebCore::PerformanceTiming::resourceLoadTiming):
              (WebCore::PerformanceTiming::resourceLoadTimeRelativeToAbsolute):
              * page/PerformanceTiming.h: Renamed from WebCore/page/Timing.h.
              (WebCore::PerformanceTiming::create):
              * page/PerformanceTiming.idl: Renamed from WebCore/page/Timing.idl.
      2010-11-12  James Simonsen  <simonjam@chromium.org>
      
              Reviewed by Darin Fisher.
      
              [Web Timing] Rename interfaces:
              - Navigation -> PerformanceNavigation
              - Timing -> PerformanceTiming
              https://bugs.webkit.org/show_bug.cgi?id=48919
      
              * src/WebPerformance.cpp:
              (WebKit::WebPerformance::navigationType):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71951 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6000d4c1
  20. 09 Nov, 2010 2 commits
  21. 04 Nov, 2010 1 commit
    • commit-queue@webkit.org's avatar
      2010-11-04 James Simonsen <simonjam@chromium.org> · d63bb0a9
      commit-queue@webkit.org authored
              Reviewed by Darin Fisher.
      
              [Web Timing] Implement dom* timing marks
              https://bugs.webkit.org/show_bug.cgi?id=46301
      
              * fast/dom/Window/window-properties-performance-expected.txt:
              * fast/dom/script-tests/webtiming-async.js: Added.
              * fast/dom/script-tests/webtiming-defer.js: Added.
              * fast/dom/script-tests/webtiming-document-open.js: Added.
              (testTimingWithDocumentOpen):
              * fast/dom/script-tests/webtiming-navigate-within-document.js:
              (checkTimingNotChanged): Added dom timing.
              * fast/dom/script-tests/webtiming.js:
              (checkTimingBeforeLoad): Added dom timing.
              (checkTimingWhileDeferred): Added.
              (checkWebTimingWhileAsync): Added.
              (checkWebTimingOnLoad): Added dom timing.
              (checkWebTimingAfterLoad): Added dom timing.
              * fast/dom/webtiming-document-open-expected.txt: Added.
              * fast/dom/webtiming-document-open.html: Added.
              * fast/dom/webtiming-expected.txt:
              * fast/dom/webtiming-navigate-within-document-expected.txt:
              * fast/dom/webtiming.html: Added async and defer tests.
              * platform/mac/Skipped: Skip new webtiming test.
      2010-11-04  James Simonsen  <simonjam@chromium.org>
      
              Reviewed by Darin Fisher.
      
              [Web Timing] Implement dom* timing marks
              https://bugs.webkit.org/show_bug.cgi?id=46301
      
              Test: fast/dom/webtiming-document-open.html
      
              * GNUmakefile.am: Added DocumentTiming.h
              * WebCore.gypi: Ditto.
              * WebCore.vcproj/WebCore.vcproj: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * dom/Document.cpp:
              (WebCore::Document::setReadyState): Set DOM WebTiming marks.
              (WebCore::Document::finishedParsing): Set DOM WebTiming marks.
              * dom/Document.h:
              (WebCore::Document::timing): Added.
              * dom/DocumentTiming.h: Added.
              (WebCore::DocumentTiming::DocumentTiming):
              * page/Timing.cpp: Added DOM timing.
              (WebCore::Timing::domLoading): Ditto.
              (WebCore::Timing::domInteractive): Ditto.
              (WebCore::Timing::domContentLoaded): Ditto.
              (WebCore::Timing::domComplete): Ditto.
              (WebCore::Timing::documentTiming): Ditto.
              * page/Timing.h: Ditto.
              * page/Timing.idl: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71313 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d63bb0a9
  22. 30 Sep, 2010 1 commit
  23. 28 Jul, 2010 1 commit
  24. 26 Jul, 2010 1 commit
  25. 22 Jul, 2010 1 commit
    • tonyg@chromium.org's avatar
      2010-07-22 Tony Gentilcore <tonyg@chromium.org> · 8ba8bd5e
      tonyg@chromium.org authored
              Reviewed by Darin Fisher.
      
              webkitPerformance.timing.responseEnd should not include document parse time
              https://bugs.webkit.org/show_bug.cgi?id=42797
      
              No new tests because timing based test would be flaky.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::finishedLoading): finishedLoading() is called by the platform at the right time, but didReceiveData() synchronously invokes parsing without returning to the event loop prior to this. So by the time the didFinishLoading() method is executed, parsing is finished. The solution is to move this time to didReceiveData() prior to parsing.
              * loader/MainResourceLoader.cpp:
              (WebCore::MainResourceLoader::didReceiveData): Update the time each time didReceiveData() is called.
              (WebCore::MainResourceLoader::didFinishLoading): When finished, and after parsing, set responseEnd appropriately.
              * loader/MainResourceLoader.h:
              * page/Timing.cpp:
              (WebCore::Timing::resourceLoadTimeRelativeToAbsolute): Now that responseEnd is set correctly, it can be much shorter for very fast loads (like local files). This exposed the fact that this skew check was not tight enough. We need to make sure that the whole range of values from the ResourceLoadTiming API fit within fetchStart-responseEnd, not just that requestTime fits in this range.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ba8bd5e
  26. 19 Jul, 2010 1 commit
    • tonyg@chromium.org's avatar
      2010-07-17 Tony Gentilcore <tonyg@chromium.org> · 83c94c4c
      tonyg@chromium.org authored
              Reviewed by Darin Fisher.
      
              [Web Timing] Move times to DocumentLoader and fix bugs in mark points
              https://bugs.webkit.org/show_bug.cgi?id=42512
      
              * fast/dom/script-tests/webtiming-navigate-within-document.js: Added. Previously, navigating within a document via a fragment would reset navigationStart. This test verifies that no times are changed after navigating within a document.
              (checkTimingNotChanged):
              ():
              (loadHandler):
              * fast/dom/webtiming-expected.txt: Test now passes because when correcting for clock skew, requestTime is set to fetchStart when it is less than fetchStart. Previously it was 0, now it is fetchStart. This, unfortunately, hides the fact that test_shell isn't populating the ResourceLoadTiming API. I'll think of a way to test that when I make the change to cause test_shell to fill the ResourceLoadTiming.
              * fast/dom/webtiming-navigate-within-document-expected.txt: Added.
              * fast/dom/webtiming-navigate-within-document.html: Added.
              * platform/gtk/Skipped: Skip new test on platform where Web Timing is not enabled.
              * platform/mac/Skipped: Skip new test on platform where Web Timing is not enabled.
              * platform/qt/Skipped: Skip new test on platform where Web Timing is not enabled.
              * platform/win/Skipped: Skip new test on platform where Web Timing is not enabled.
      2010-07-17  Tony Gentilcore  <tonyg@chromium.org>
      
              Reviewed by Darin Fisher.
      
              [Web Timing] Move times to DocumentLoader and fix bugs in mark points
              https://bugs.webkit.org/show_bug.cgi?id=42512
      
              Test: fast/dom/webtiming-navigate-within-document.html
      
              * loader/DocumentLoader.h: Move the FrameLoadTimeline (now call DocumentLoadTiming) to the DocumentLoader.
              (WebCore::DocumentLoader::documentLoadTiming):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::stopLoading): Set unloadEventEnd on the provisional DocumentLoader. Add some ASSERTs to tighten things up.
              (WebCore::FrameLoader::loadWithDocumentLoader): This was not the right place to set navigationStart. Setting it here caused it to be set before the unload form prompt and caused it to be reset when navigating within the document.
              (WebCore::FrameLoader::finishedLoading): Set responseEnd on the active DocumentLoader.
              (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): This is the right place for navigationStart as defined by the spec.
              * loader/FrameLoader.h: Get rid of FrameLoadTimeline.
              * loader/FrameLoaderTypes.h: Rename FrameLoadTimeline to DocumentLoadTiming. It is even more apparent this doesn't belong in this file now. I am planning to submit a patch moving it out ASAP, but didn't want to muddy this patch with all those build files.
              (WebCore::DocumentLoadTiming::DocumentLoadTiming):
              * loader/MainResourceLoader.cpp:
              (WebCore::MainResourceLoader::willSendRequest): Move fetchStart out of this method to load(), and rewrite setting of redirectStart, redirectEnd, and redirectCount to be more readable.
              (WebCore::MainResourceLoader::load): Set fetchStart slightly earlier here and tighten it up with some ASSERTs.
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::dispatchLoadEvent): Set loadEventStart and loadEventEnd on the DocumentLoader.
              * page/Navigation.cpp:
              (WebCore::Navigation::redirectCount): Retrieve redirectCount from the DocumentLoader.
              * page/Timing.cpp:
              (WebCore::getPossiblySkewedTimeInKnownRange): The skew problem turned out to be due to the fact that chromium's currentTime() implementation only syncs to the system time every 60 seconds. So absolute times across threads may be skewed slightly. I resolved this temporarily by clipping the time from another thread into a known bound. A better long term solution is probably to add a currentTimeFromSystemTime() method and call that for web timing marks.
              (WebCore::Timing::navigationStart):
              (WebCore::Timing::unloadEventEnd):
              (WebCore::Timing::redirectStart):
              (WebCore::Timing::redirectEnd):
              (WebCore::Timing::fetchStart):
              (WebCore::Timing::domainLookupStart):
              (WebCore::Timing::domainLookupEnd):
              (WebCore::Timing::connectStart):
              (WebCore::Timing::connectEnd):
              (WebCore::Timing::requestStart):
              (WebCore::Timing::requestEnd):
              (WebCore::Timing::responseStart):
              (WebCore::Timing::responseEnd):
              (WebCore::Timing::loadEventStart):
              (WebCore::Timing::loadEventEnd):
              (WebCore::Timing::documentLoader):
              (WebCore::Timing::documentLoadTiming):
              (WebCore::Timing::resourceLoadTiming):
              (WebCore::Timing::resourceLoadTimeRelativeToAbsolute): Ensure requestTime is in the range of fetchStart to responseEnd.
              * page/Timing.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83c94c4c
  27. 16 Jul, 2010 1 commit
    • tonyg@chromium.org's avatar
      2010-07-16 Tony Gentilcore <tonyg@chromium.org> · 78612faa
      tonyg@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Fix unit error in calculating timings from ResourceLoadTiming API
              https://bugs.webkit.org/show_bug.cgi?id=42473
      
              The start and end offsets are already in milliseconds so they should not be multiplied by 1000.0 like requestTime.
      
              No new tests because, for a yet unknown reason, the ResourceLoadTiming API is not populated in the chromium test shell like it is in full chromium. This means the test that would have caught this bug (fast/dom/webtiming.html) currently has its expectation set to FAIL.
      
              * page/Timing.cpp:
              (WebCore::Timing::domainLookupStart):
              (WebCore::Timing::domainLookupEnd):
              (WebCore::Timing::connectStart):
              (WebCore::Timing::connectEnd):
              (WebCore::Timing::requestStart):
              (WebCore::Timing::requestEnd):
              (WebCore::Timing::responseStart):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63569 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78612faa
  28. 15 Jul, 2010 1 commit
    • tonyg@chromium.org's avatar
      2010-07-14 Tony Gentilcore <tonyg@chromium.org> · d0b42ee7
      tonyg@chromium.org authored
              Reviewed by Darin Fisher.
      
              Backfill DNS and connect times rather than exposing hard zeros
              https://bugs.webkit.org/show_bug.cgi?id=42303
      
              There are several cases where domain lookup is not performed and/or a new connection is not established. Previously in these cases, we exposed a "0" to the API. Now, we instead "backfill" with the most recent mark's time.
      
              Also, previously, I was using the ResourceLoadTiming API incorrectly. Each mark is an integer representing offset in milliseconds from requestTime. So all values need to be added to requestTime.
      
              No new test because existing test expectations are set to FAIL because disable disabled by default. The expected results of existings tests change as expected when enabled.
      
              * page/Timing.cpp:
              (WebCore::toIntegerMilliseconds): Move to file static instead of class static because it might generate more optimal code. Also, instead of converting negative doubles to zero, ASSERT that they are >= 0. This is because we no longer expose hard zeros for DNS and connect, so we want to be sure that the -1s returned by the API are properly handled.
              (WebCore::Timing::domainLookupStart):
              (WebCore::Timing::domainLookupEnd):
              (WebCore::Timing::connectStart):
              (WebCore::Timing::connectEnd):
              (WebCore::Timing::requestStart):
              (WebCore::Timing::requestEnd):
              (WebCore::Timing::responseStart):
              * page/Timing.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63426 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0b42ee7
  29. 14 Jul, 2010 1 commit
    • tonyg@chromium.org's avatar
      2010-07-14 Tony Gentilcore <tonyg@chromium.org> · bafab901
      tonyg@chromium.org authored
              Reviewed by Darin Fisher.
      
              Implement Web Timing redirectStart, redirectEnd, redirectCount
              https://bugs.webkit.org/show_bug.cgi?id=42018
      
              Tests pass with --web-timing. Expectations set to FAIL because disabled by default.
      
              * fast/dom/script-tests/webtiming.js: Since this is not a redirect, redirect times and count should be zero.
              (checkTimingBeforeLoad):
              (checkWebTimingOnLoad):
              (checkWebTimingAfterLoad):
              * fast/dom/webtiming-expected.txt:
              * fast/js/resources/js-test-pre.js:
              (shouldBeGreaterThanOrEqual): Factored out so that other tests can share this method.
              * http/tests/misc/resources/webtiming-one-redirect.html: Added.
              * http/tests/misc/resources/webtiming-two-redirects.html: Added.
              * http/tests/misc/webtiming-one-redirect-expected.txt: Added.
              * http/tests/misc/webtiming-one-redirect.php: Added.
              * http/tests/misc/webtiming-two-redirects-expected.txt: Added.
              * http/tests/misc/webtiming-two-redirects.php: Added.
      2010-07-14  Tony Gentilcore  <tonyg@chromium.org>
      
              Reviewed by Darin Fisher.
      
              Implement Web Timing redirectStart, redirectEnd, redirectCount
              https://bugs.webkit.org/show_bug.cgi?id=42018
      
              Tests: http/tests/misc/webtiming-one-redirect.php
                     http/tests/misc/webtiming-two-redirects.php
      
              * loader/FrameLoaderTypes.h:
              (WebCore::FrameLoadTimeline::FrameLoadTimeline):
              * loader/MainResourceLoader.cpp:
              (WebCore::MainResourceLoader::willSendRequest): This method is called for each request (including server redirects). fetchStart is updated to the current time on each invocation so that it represents fetching of the final document and doesn't include redirect time. For each redirect, redirectCount is incremented and redirectStart to redirectEnd measures the cumulative fetch time for all redirects.
              * page/Navigation.cpp:
              (WebCore::Navigation::redirectCount): http://dev.w3.org/2006/webapi/WebTiming/#nt-redirect-count
              * page/Timing.cpp:
              (WebCore::Timing::redirectStart): http://dev.w3.org/2006/webapi/WebTiming/#nt-redirect-start
              (WebCore::Timing::redirectEnd): http://dev.w3.org/2006/webapi/WebTiming/#nt-redirect-end
              * page/Timing.h:
              * page/Timing.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bafab901
  30. 13 Jul, 2010 3 commits
  31. 09 Jul, 2010 2 commits
  32. 02 Jul, 2010 1 commit
    • tonyg@chromium.org's avatar
      2010-07-01 Tony Gentilcore <tonyg@chromium.org> · 5f1072b8
      tonyg@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              Add window.performance.navigation namespace
              https://bugs.webkit.org/show_bug.cgi?id=41442
      
              Adds window.performance.navigation namespace consisting of ".type"
              and ".redirectCount". As part of this change, I renmaed "NavigationTiming"
              to just "Timing" to avoid confusion.
      
              No new tests because tests will be added in a subsequent patch when
              functionality is added.
      
              * Android.mk:
              * CMakeLists.txt:
              * DerivedSources.cpp:
              * DerivedSources.make:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pri:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * page/Navigation.cpp: Added.
              (WebCore::Navigation::Navigation):
              (WebCore::Navigation::frame):
              (WebCore::Navigation::disconnectFrame):
              (WebCore::Navigation::type):
              (WebCore::Navigation::redirectCount):
              * page/Navigation.h: Added.
              (WebCore::Navigation::create):
              * page/Navigation.idl: Added.
              * page/NavigationTiming.cpp: Removed.
              * page/NavigationTiming.h: Removed.
              * page/NavigationTiming.idl: Removed.
              * page/Performance.cpp:
              (WebCore::Performance::navigation):
              (WebCore::Performance::timing):
              * page/Performance.h:
              * page/Performance.idl:
              * page/Timing.cpp: Added.
              (WebCore::Timing::Timing):
              (WebCore::Timing::frame):
              (WebCore::Timing::disconnectFrame):
              (WebCore::Timing::navigationStart):
              * page/Timing.h: Added.
              (WebCore::Timing::create):
              * page/Timing.idl: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62357 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f1072b8