1. 10 Jan, 2014 1 commit
  2. 10 Dec, 2013 1 commit
    • commit-queue@webkit.org's avatar
      PageConsole::addMessage should automatically determine column number alongside line number · ec979f8f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114319
      
      Patch by László Langó <lango@inf.u-szeged.hu> on 2013-12-10
      Reviewed by Joseph Pecoraro.
      
      Source/WebCore:
      
      * dom/InlineStyleSheetOwner.cpp:
      (WebCore::InlineStyleSheetOwner::InlineStyleSheetOwner):
      * dom/ScriptElement.cpp:
      (WebCore::ScriptElement::ScriptElement):
      * dom/ScriptableDocumentParser.h:
      * dom/StyledElement.cpp:
      (WebCore::StyledElement::styleAttributeChanged):
      * html/parser/HTMLDocumentParser.cpp:
      (WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser):
      (WebCore::HTMLDocumentParser::pumpPendingSpeculations):
      * html/parser/HTMLDocumentParser.h:
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::InspectorResourceAgent::buildInitiatorObject):
      * page/Console.cpp:
      (WebCore::internalAddMessage):
      * page/PageConsole.cpp:
      (WebCore::PageConsole::printSourceURLAndPosition):
      (WebCore::PageConsole::addMessage):
      * page/PageConsole.h:
      * xml/parser/XMLDocumentParser.h:
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      (WebCore::XMLDocumentParser::error):
      
      LayoutTests:
      
      * inspector-protocol/page/deny-X-FrameOption-expected.txt: Added.
      * inspector-protocol/page/deny-X-FrameOption.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160374 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec979f8f
  3. 30 Sep, 2013 1 commit
    • weinig@apple.com's avatar
      Cleanup PageThrottler and PageConsole a bit · f2ead0f7
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122085
      
      Reviewed by Anders Carlsson.
      
      * html/HTMLMediaElement.h:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::completed):
      * loader/FrameLoader.h:
      * loader/SubresourceLoader.cpp:
      (WebCore::SubresourceLoader::checkForHTTPStatusCodeError):
      (WebCore::SubresourceLoader::didFinishLoading):
      (WebCore::SubresourceLoader::didFail):
      (WebCore::SubresourceLoader::willCancel):
      * loader/SubresourceLoader.h:
      Store the PageActivityAssertionToken as a std::unique_ptr.
      
      * page/Page.cpp:
      (WebCore::Page::Page):
      Use createOwned and pass this by reference for the PageThrottler and PageConsole.
      (WebCore::Page::~Page):
      Remove unnecessary clearing of an OwnPtr that is about to be destroyed.
      * page/Page.h:
      Make m_pageThrottler const and return it as a reference.
      
      * page/PageActivityAssertionToken.cpp:
      (WebCore::PageActivityAssertionToken::PageActivityAssertionToken):
      (WebCore::PageActivityAssertionToken::~PageActivityAssertionToken):
      * page/PageActivityAssertionToken.h:
      Take the PageThrottler by reference in the constructor. It is never null.
      
      * page/PageConsole.cpp:
      (WebCore::PageConsole::PageConsole):
      (WebCore::PageConsole::~PageConsole):
      (WebCore::PageConsole::addMessage):
      * page/PageConsole.h:
      Pass and store the Page as a reference and remove an extraneous null check. Remove
      the create function.
      
      * page/PageThrottler.cpp:
      (WebCore::PageThrottler::PageThrottler):
      (WebCore::PageThrottler::~PageThrottler):
      (WebCore::PageThrottler::createActivityToken):
      (WebCore::PageThrottler::throttlePage):
      (WebCore::PageThrottler::unthrottlePage):
      (WebCore::PageThrottler::addActivityToken):
      (WebCore::PageThrottler::removeActivityToken):
      * page/PageThrottler.h:
      Pass and store the Page as a reference. Move the creation of PageActivityAssertionToken here
      to aid encapsulation.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156625 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2ead0f7
  4. 14 Sep, 2013 1 commit
    • weinig@apple.com's avatar
      Replace ScriptState with JSC::ExecState · 4da3e8de
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121336
      
      Reviewed by Darin Adler.
      
      * Modules/indexeddb/IDBCursor.h:
      * Modules/indexeddb/IDBObjectStore.h:
      * bindings/js/JSInjectedScriptHostCustom.cpp:
      * bindings/js/JSInjectedScriptManager.cpp:
      * bindings/js/JSNodeCustom.cpp:
      * bindings/js/JSNodeFilterCondition.h:
      * bindings/js/ScriptController.cpp:
      * bindings/js/ScriptDebugServer.cpp:
      * bindings/js/ScriptDebugServer.h:
      * bindings/js/ScriptEventListener.cpp:
      * bindings/js/ScriptEventListener.h:
      * bindings/js/ScriptFunctionCall.cpp:
      * bindings/js/ScriptFunctionCall.h:
      * bindings/js/ScriptObject.cpp:
      * bindings/js/ScriptObject.h:
      * bindings/js/ScriptProfiler.cpp:
      * bindings/js/ScriptProfiler.h:
      * bindings/js/ScriptState.cpp:
      * bindings/js/ScriptState.h:
      * bindings/js/ScriptValue.cpp:
      * bindings/js/ScriptValue.h:
      * bindings/js/SerializedScriptValue.cpp:
      * bindings/js/SerializedScriptValue.h:
      * dom/Document.cpp:
      * dom/Document.h:
      * dom/NodeFilter.cpp:
      * dom/NodeFilter.h:
      * dom/NodeFilterCondition.cpp:
      * dom/NodeFilterCondition.h:
      * dom/NodeIterator.cpp:
      * dom/NodeIterator.h:
      * dom/ScriptExecutionContext.cpp:
      * dom/ScriptExecutionContext.h:
      * dom/Traversal.cpp:
      * dom/Traversal.h:
      * dom/TreeWalker.cpp:
      * dom/TreeWalker.h:
      * inspector/ConsoleMessage.cpp:
      * inspector/ConsoleMessage.h:
      * inspector/InjectedScript.h:
      * inspector/InjectedScriptBase.cpp:
      * inspector/InjectedScriptBase.h:
      * inspector/InjectedScriptCanvasModule.cpp:
      * inspector/InjectedScriptCanvasModule.h:
      * inspector/InjectedScriptHost.cpp:
      * inspector/InjectedScriptHost.h:
      * inspector/InjectedScriptManager.cpp:
      * inspector/InjectedScriptManager.h:
      * inspector/InjectedScriptModule.cpp:
      * inspector/InjectedScriptModule.h:
      * inspector/InspectorAgent.cpp:
      * inspector/InspectorCanvasAgent.cpp:
      * inspector/InspectorCanvasAgent.h:
      * inspector/InspectorConsoleAgent.cpp:
      * inspector/InspectorConsoleAgent.h:
      * inspector/InspectorConsoleInstrumentation.h:
      * inspector/InspectorDOMAgent.cpp:
      * inspector/InspectorDebuggerAgent.cpp:
      * inspector/InspectorDebuggerAgent.h:
      * inspector/InspectorFrontendClientLocal.cpp:
      * inspector/InspectorFrontendHost.cpp:
      * inspector/InspectorIndexedDBAgent.cpp:
      * inspector/InspectorInstrumentation.cpp:
      * inspector/InspectorInstrumentation.h:
      * inspector/PageConsoleAgent.cpp:
      * inspector/PageDebuggerAgent.cpp:
      * inspector/PageRuntimeAgent.cpp:
      * inspector/PageRuntimeAgent.h:
      * inspector/ScriptArguments.cpp:
      * inspector/ScriptArguments.h:
      * inspector/ScriptDebugListener.h:
      * inspector/WorkerDebuggerAgent.cpp:
      * inspector/WorkerRuntimeAgent.cpp:
      * page/Console.cpp:
      * page/Console.h:
      * page/ContentSecurityPolicy.cpp:
      * page/ContentSecurityPolicy.h:
      * page/PageConsole.cpp:
      * page/PageConsole.h:
      * workers/WorkerGlobalScope.cpp:
      * workers/WorkerGlobalScope.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155736 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4da3e8de
  5. 25 Apr, 2013 1 commit
    • joepeck@webkit.org's avatar
      Web Inspector: ConsoleMessage should include line and column number where possible · 379c8a1f
      joepeck@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114929
      
      Source/WebCore:
      
        - adds "m_column" to WebCore::ConsoleMessage
        - adds "column" to Console.ConsoleMessage in the inspector protocol
        - set the column number for console.* functions (Console.cpp)
        - set the column number for XSLT errors (XSLTProcessor)
        - plumb columnNumber everywhere else it is needed, set it to 0 and file
          bugs for all cases missing columnNumber that could provide it.
      
      Reviewed by Timothy Hatcher.
      
      Test: inspector/console/console-url-line-column.html
            inspector/console/console-messages-stack-traces.html
      
      * inspector/ConsoleMessage.h:
      * inspector/ConsoleMessage.cpp:
      (WebCore::ConsoleMessage::ConsoleMessage):
      (WebCore::ConsoleMessage::autogenerateMetadata):
      (WebCore::ConsoleMessage::addToFrontend):
      (WebCore::ConsoleMessage::isEqual):
      Add m_column and set it where appropriate.
      
      * inspector/Inspector.json:
      Add column property to Console.ConsoleMessage.
      
      * page/Console.cpp:
      (WebCore::internalAddMessage):
      (WebCore::Console::profile):
      Set columnNumber like lineNumber from the last stack frame.
      (WebCore::Console::groupEnd):
      Line and column are unused in this message type, set both to 0.
      
      * xml/XSLTProcessorLibxslt.cpp:
      (WebCore::XSLTProcessor::parseErrorFunc):
      * xml/XSLTProcessorQt.cpp:
      (WebCore::XSLTMessageHandler::handleMessage):
      Add real column numbers, the XSLT handlers already had it available.
      
      * bindings/js/JSCustomXPathNSResolver.cpp:
      (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
      * css/CSSParser.cpp:
      (WebCore::CSSParser::logError):
      * dom/ScriptExecutionContext.h:
      * dom/ScriptExecutionContext.cpp:
      (WebCore::ScriptExecutionContext::addConsoleMessage):
      * dom/Document.cpp:
      (WebCore::Document::logExceptionToConsole):
      (WebCore::Document::addMessage):
      * dom/Document.h:
      * inspector/InspectorConsoleAgent.cpp:
      (WebCore::InspectorConsoleAgent::addMessageToConsole):
      (WebCore::InspectorConsoleAgent::stopTiming):
      (WebCore::InspectorConsoleAgent::didFinishXHRLoading):
      (WebCore::InspectorConsoleAgent::didReceiveResponse):
      (WebCore::InspectorConsoleAgent::didFailLoading):
      * inspector/InspectorConsoleAgent.h:
      * inspector/InspectorConsoleInstrumentation.h:
      (WebCore::InspectorInstrumentation::addMessageToConsole):
      (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
      (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl):
      (WebCore::InspectorInstrumentation::addProfileImpl):
      * inspector/InspectorInstrumentation.h:
      (InspectorInstrumentation):
      * inspector/InspectorProfilerAgent.cpp:
      (WebCore::InspectorProfilerAgent::addProfile):
      (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
      (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
      (WebCore::InspectorProfilerAgent::start):
      (WebCore::InspectorProfilerAgent::stop):
      * inspector/InspectorProfilerAgent.h:
      (InspectorProfilerAgent):
      * loader/EmptyClients.h:
      (WebCore::EmptyChromeClient::addMessageToConsole):
      * page/ChromeClient.h:
      (WebCore::ChromeClient::addMessageToConsole):
      * page/ContentSecurityPolicy.cpp:
      (WebCore::ContentSecurityPolicy::logToConsole):
      * page/PageConsole.cpp:
      (WebCore::PageConsole::addMessage):
      * page/PageConsole.h:
      * workers/DefaultSharedWorkerRepository.cpp:
      (SharedWorkerProxy):
      (WebCore::postExceptionTask):
      (WebCore::SharedWorkerProxy::postExceptionToWorkerObject):
      (WebCore::postConsoleMessageTask):
      (WebCore::SharedWorkerProxy::postConsoleMessageToWorkerObject):
      * workers/SharedWorkerContext.cpp:
      (WebCore::SharedWorkerContext::logExceptionToConsole):
      * workers/WorkerContext.cpp:
      (WebCore::WorkerContext::logExceptionToConsole):
      (WebCore::WorkerContext::addConsoleMessage):
      (WebCore::WorkerContext::addMessage):
      (WebCore::WorkerContext::addMessageToWorkerConsole):
      * workers/WorkerContext.h:
      * workers/WorkerMessagingProxy.cpp:
      (WebCore::WorkerExceptionTask::create):
      (WebCore::WorkerExceptionTask::WorkerExceptionTask):
      (WebCore::WorkerExceptionTask::performTask):
      (WorkerExceptionTask):
      (WebCore::WorkerMessagingProxy::postExceptionToWorkerObject):
      (WebCore::postConsoleMessageTask):
      (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
      * workers/WorkerMessagingProxy.h:
      (WorkerMessagingProxy):
      * workers/WorkerReportingProxy.h:
      (WorkerReportingProxy):
      Plumb columnNumber through where appropriate. File bugs where missing.
      
      Source/WebKit/blackberry:
      
      Reviewed by Timothy Hatcher.
      
      * Api/DumpRenderTreeClient.h:
      * Api/WebPageClient.h:
      * WebCoreSupport/ChromeClientBlackBerry.cpp:
      (WebCore::ChromeClientBlackBerry::addMessageToConsole):
      * WebCoreSupport/ChromeClientBlackBerry.h:
      (ChromeClientBlackBerry):
      
      Source/WebKit/efl:
      
      Reviewed by Timothy Hatcher.
      
      * WebCoreSupport/ChromeClientEfl.cpp:
      (WebCore::ChromeClientEfl::addMessageToConsole):
      * WebCoreSupport/ChromeClientEfl.h:
      (ChromeClientEfl):
      
      Source/WebKit/gtk:
      
      Reviewed by Timothy Hatcher.
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::addMessageToConsole):
      * WebCoreSupport/ChromeClientGtk.h:
      (ChromeClient):
      
      Source/WebKit/mac:
      
      Reviewed by Timothy Hatcher.
      
      * WebCoreSupport/WebChromeClient.h:
      * WebCoreSupport/WebChromeClient.mm:
      (WebChromeClient::addMessageToConsole):
      
      Source/WebKit/qt:
      
      Reviewed by Timothy Hatcher.
      
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::addMessageToConsole):
      * WebCoreSupport/ChromeClientQt.h:
      
      Source/WebKit/win:
      
      Reviewed by Timothy Hatcher.
      
      * WebCoreSupport/WebChromeClient.cpp:
      (WebChromeClient::addMessageToConsole):
      * WebCoreSupport/WebChromeClient.h:
      
      Source/WebKit/wince:
      
      Reviewed by Timothy Hatcher.
      
      * WebCoreSupport/ChromeClientWinCE.cpp:
      (WebKit::ChromeClientWinCE::addMessageToConsole):
      * WebCoreSupport/ChromeClientWinCE.h:
      
      Source/WebKit2:
      
      Reviewed by Timothy Hatcher.
      
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::addMessageToConsole):
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      
      LayoutTests:
      
      Update a test that was outputting the url and line number of console
      method calls, to output the column number as well. Added a test that
      verifies that console API messages have stack traces if appropriate.
      
      Reviewed by Timothy Hatcher.
      
      * inspector/console/console-url-and-line-expected.txt: Removed.
      * inspector/console/console-url-line-column-expected.txt: Added.
      * inspector/console/console-url-line-column.html: Renamed from LayoutTests/inspector/console/console-url-and-line.html.
      * inspector/console/console-messages-stack-traces-expected.txt: Added.
      * inspector/console/console-messages-stack-traces.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149125 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      379c8a1f
  6. 19 Mar, 2013 1 commit
    • commit-queue@webkit.org's avatar
      Web Inspector: split Console into two entities, a web-facing bound object and page console. · 7195ba53
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=111578
      
      Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-19
      Reviewed by Vsevolod Vlasov.
      
      Otherwise, a lot of logging in WebCore needs to go through the DOMWindow which is unnecessary.
      
      Source/WebCore:
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.exp.in:
      * WebCore.gypi:
      * WebCore.order:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/js/JSCustomXPathNSResolver.cpp:
      (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
      * bindings/v8/custom/V8CustomXPathNSResolver.cpp:
      (WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
      * dom/Document.cpp:
      (WebCore::Document::addConsoleMessage):
      (WebCore::Document::addMessage):
      * inspector/PageDebuggerAgent.cpp:
      (WebCore::PageDebuggerAgent::muteConsole):
      (WebCore::PageDebuggerAgent::unmuteConsole):
      * inspector/PageRuntimeAgent.cpp:
      (WebCore::PageRuntimeAgent::muteConsole):
      (WebCore::PageRuntimeAgent::unmuteConsole):
      * page/Console.cpp:
      (WebCore::internalAddMessage):
      * page/Console.h:
      (WebCore):
      (Console):
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::pageConsole):
      (WebCore):
      (WebCore::DOMWindow::dispatchMessageEventWithOriginCheck):
      (WebCore::DOMWindow::printErrorMessage):
      * page/DOMWindow.h:
      (WebCore):
      (DOMWindow):
      * page/Page.cpp:
      (WebCore::Page::Page):
      * page/Page.h:
      (WebCore):
      (WebCore::Page::console):
      (Page):
      * page/PageConsole.cpp: Added.
      (WebCore::PageConsole::PageConsole):
      (WebCore):
      (WebCore::PageConsole::~PageConsole):
      (WebCore::PageConsole::printSourceURLAndLine):
      (WebCore::PageConsole::printMessageSourceAndLevelPrefix):
      (WebCore::PageConsole::addMessage):
      (WebCore::PageConsole::mute):
      (WebCore::PageConsole::unmute):
      (WebCore::PageConsole::shouldPrintExceptions):
      (WebCore::PageConsole::setShouldPrintExceptions):
      * page/PageConsole.h: Copied from Source/WebCore/page/Console.h.
      (WebCore):
      (PageConsole):
      (WebCore::PageConsole::create):
      (WebCore::PageConsole::page):
      * xml/XSLStyleSheetLibxslt.cpp:
      (WebCore::XSLStyleSheet::parseString):
      * xml/XSLTProcessorLibxslt.cpp:
      (WebCore::XSLTProcessor::parseErrorFunc):
      (WebCore::docLoaderFunc):
      
      Source/WebKit/mac:
      
      * Misc/WebCoreStatistics.mm:
      (+[WebCoreStatistics shouldPrintExceptions]):
      (+[WebCoreStatistics setShouldPrintExceptions:]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146208 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7195ba53
  7. 18 Feb, 2013 1 commit
    • pfeldman@chromium.org's avatar
      Web Inspector: provide basic console.table implementation (no [,columns] support) · c226870f
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109453
      
      Reviewed by Vsevolod Vlasov.
      
      Source/WebCore:
      
      Test: inspector/console/console-format-table.html
      
      Using console preview infrastructure to support console.table.
      
      * English.lproj/localizedStrings.js:
      * inspector/ConsoleAPITypes.h:
      * inspector/ConsoleMessage.cpp:
      (WebCore::messageTypeValue):
      (WebCore::ConsoleMessage::addToFrontend):
      * inspector/InjectedScript.cpp:
      (WebCore::InjectedScript::wrapObject):
      (WebCore):
      (WebCore::InjectedScript::wrapTable):
      * inspector/InjectedScript.h:
      (InjectedScript):
      * inspector/InjectedScriptSource.js:
      (.):
      * inspector/Inspector.json:
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::buildObjectForEventListener):
      * inspector/front-end/ConsoleMessage.js:
      (WebInspector.ConsoleMessageImpl):
      (WebInspector.ConsoleMessageImpl.prototype.willHide):
      (WebInspector.ConsoleMessageImpl.prototype._format):
      (WebInspector.ConsoleMessageImpl.prototype._appendObjectPreview):
      (WebInspector.ConsoleMessageImpl.prototype._renderPropertyPreview):
      (WebInspector.ConsoleMessageImpl.prototype._formatParameterAsTable):
      * inspector/front-end/ConsoleModel.js:
      * inspector/front-end/ConsoleView.js:
      (WebInspector.ConsoleView.prototype._appendConsoleMessage):
      (WebInspector.ConsoleView.prototype._consoleCleared):
      (WebInspector.ConsoleView.prototype._updateMessageList):
      (WebInspector.ConsoleCommand.prototype.wasShown):
      (WebInspector.ConsoleCommand.prototype.willHide):
      (WebInspector.ConsoleGroup.prototype.addMessage):
      * inspector/front-end/DataGrid.js:
      (.sortDataGrid.comparator):
      (.sortDataGrid):
      (WebInspector.DataGrid.createSortableDataGrid):
      (WebInspector.DataGrid.prototype.renderInline):
      * inspector/front-end/DatabaseQueryView.js:
      (WebInspector.DatabaseQueryView.prototype._queryFinished):
      * inspector/front-end/dataGrid.css:
      (.data-grid.inline):
      (.data-grid.inline td.corner):
      * inspector/front-end/resourcesPanel.css:
      (.storage-view > .data-grid):
      * page/Console.cpp:
      (WebCore::Console::table):
      (WebCore):
      * page/Console.h:
      (Console):
      * page/Console.idl:
      
      LayoutTests:
      
      * inspector/console/command-line-api-expected.txt:
      * inspector/console/console-format-table-expected.txt: Added.
      * inspector/console/console-format-table.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@143186 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c226870f
  8. 11 Dec, 2012 1 commit
    • mkwst@chromium.org's avatar
      Web Inspector: ConsoleTypes should not expose MessageType - it should be private to inspector. · 236e8984
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66371
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      We can simplify console message generation a bit, as nothing outside the
      Console object itself will generate messages of any type other than
      LogMessageType. This patch refactors the externally-facing API endpoints
      on ScriptExecutionContext and Console to drop the MessageType parameter,
      moves the MessageType enum into a new InspectorConsoleTypes.h header,
      and updates all the call sites (and ChromeClients) to drop the parameter
      from their interfaces.
      
      As a temporary bandage for ports using this interface, this patch
      includes aliases for the new methods that retain the old interface.
      I'll remove them in a future patch.
      
      Here, we only refactor an internal interface. No tests should break.
      
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
          We added a new file! OMG!
      * Modules/webaudio/AudioBufferSourceNode.cpp:
      (WebCore::AudioBufferSourceNode::looping):
      (WebCore::AudioBufferSourceNode::setLooping):
      * Modules/webdatabase/AbstractDatabase.cpp:
      (WebCore::AbstractDatabase::logErrorMessage):
      * Modules/websockets/WebSocket.cpp:
      (WebCore::WebSocket::connect):
      (WebCore::WebSocket::send):
      (WebCore::WebSocket::close):
      (WebCore::WebSocket::setBinaryType):
      * Modules/websockets/WebSocketChannel.cpp:
      (WebCore::WebSocketChannel::fail):
      (WebCore::WebSocketChannel::didFailSocketStream):
      * bindings/js/JSCustomXPathNSResolver.cpp:
      (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
      * bindings/v8/custom/V8CustomXPathNSResolver.cpp:
      (WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
      * css/MediaList.cpp:
      (WebCore::addResolutionWarningMessageToConsole):
      * dom/Document.cpp:
      (WebCore::Document::logExceptionToConsole):
      (WebCore::Document::processHttpEquiv):
      (WebCore::Document::addMessage):
      * dom/Document.h:
      (Document):
      * dom/ScriptElement.cpp:
      (WebCore::ScriptElement::notifyFinished):
      * dom/ScriptExecutionContext.cpp:
      (WebCore::ScriptExecutionContext::AddConsoleMessageTask::performTask):
      (WebCore::ScriptExecutionContext::addConsoleMessage):
      * dom/ScriptExecutionContext.h:
      (ScriptExecutionContext):
      (WebCore::ScriptExecutionContext::AddConsoleMessageTask::create):
      (WebCore::ScriptExecutionContext::AddConsoleMessageTask::AddConsoleMessageTask):
      * dom/ViewportArguments.cpp:
      (WebCore::reportViewportWarning):
      * fileapi/WebKitBlobBuilder.cpp:
      (WebCore::BlobBuilder::append):
      * html/HTMLFormControlElement.cpp:
      (WebCore::shouldAutofocus):
      * html/HTMLFormElement.cpp:
      (WebCore::HTMLFormElement::validateInteractively):
      * html/HTMLIFrameElement.cpp:
      (WebCore::HTMLIFrameElement::parseAttribute):
      * html/HTMLTrackElement.cpp:
      (WebCore::HTMLTrackElement::canLoadUrl):
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore::CanvasRenderingContext2D::getImageData):
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore):
      (WebCore::WebGLRenderingContext::printWarningToConsole):
      * html/parser/XSSAuditor.cpp:
      (WebCore::XSSAuditor::init):
      (WebCore::XSSAuditor::filterToken):
      * inspector/ConsoleAPITypes.h: Added.
      (WebCore):
      * inspector/ConsoleMessage.h:
      * inspector/InspectorConsoleAgent.h:
      * inspector/InspectorDebuggerAgent.h:
      * inspector/InspectorInstrumentation.cpp:
      (WebCore):
      * inspector/InspectorInstrumentation.h:
      * inspector/InspectorProfilerAgent.cpp:
      * loader/EmptyClients.h:
      (WebCore::EmptyChromeClient::addMessageToConsole):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::reportLocalLoadFailed):
      (WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):
      * loader/ImageLoader.cpp:
      (WebCore::ImageLoader::notifyFinished):
      * loader/MainResourceLoader.cpp:
      (WebCore::MainResourceLoader::didReceiveResponse):
      * loader/MixedContentChecker.cpp:
      (WebCore::MixedContentChecker::logWarning):
      * loader/TextTrackLoader.cpp:
      (WebCore::TextTrackLoader::corsPolicyPreventedLoad):
      * loader/appcache/ApplicationCacheGroup.cpp:
      (WebCore::ApplicationCacheGroup::abort):
      (WebCore::ApplicationCacheGroup::didReceiveResponse):
      (WebCore::ApplicationCacheGroup::didFinishLoading):
      (WebCore::ApplicationCacheGroup::didFail):
      (WebCore::ApplicationCacheGroup::didReceiveManifestResponse):
      (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
      (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::printAccessDeniedMessage):
      * page/ChromeClient.h:
      (ChromeClient):
          Drop LogMessageType from everywhere.
      * page/Console.cpp:
      (WebCore::Console::addMessage):
      (WebCore::internalAddMessage):
      (WebCore::Console::error):
      (WebCore::Console::log):
      (WebCore::Console::warn):
      (WebCore::Console::dir):
      (WebCore::Console::dirxml):
      (WebCore::Console::clear):
      (WebCore::Console::trace):
      (WebCore::Console::assertCondition):
      * page/Console.h:
      (Console):
          Create a new internalAddMessage that's used for the various
          Console message types. Everything else routes through
          ::addMessage.
      * page/ConsoleTypes.h:
          Drop MessageTypes from this file, add it to ConsoleAPIType.h
      * page/ContentSecurityPolicy.cpp:
      (WebCore::ContentSecurityPolicy::logToConsole):
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::dispatchMessageEventWithOriginCheck):
      (WebCore::DOMWindow::printErrorMessage):
      * page/EventSource.cpp:
      (WebCore::EventSource::didReceiveResponse):
      * svg/SVGDocumentExtensions.cpp:
      (WebCore::reportMessage):
      * workers/DefaultSharedWorkerRepository.cpp:
      (SharedWorkerProxy):
      (WebCore::postConsoleMessageTask):
      (WebCore::SharedWorkerProxy::postConsoleMessageToWorkerObject):
      * workers/SharedWorkerContext.cpp:
      (WebCore::SharedWorkerContext::logExceptionToConsole):
      * workers/WorkerContext.cpp:
      (WebCore::WorkerContext::addMessage):
      (WebCore::WorkerContext::addMessageToWorkerConsole):
      * workers/WorkerContext.h:
      (WorkerContext):
      * workers/WorkerMessagingProxy.cpp:
      (WebCore::postConsoleMessageTask):
      (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
      * workers/WorkerMessagingProxy.h:
      (WorkerMessagingProxy):
      * workers/WorkerReportingProxy.h:
      (WorkerReportingProxy):
      * xml/XMLHttpRequest.cpp:
      (WebCore::logConsoleError):
      (WebCore::XMLHttpRequest::send):
      * xml/XSLTProcessorLibxslt.cpp:
      (WebCore::XSLTProcessor::parseErrorFunc):
      * xml/XSLTProcessorQt.cpp:
      (WebCore::XSLTMessageHandler::handleMessage):
          Drop LogMessageType from everywhere.
      
      Source/WebKit/blackberry:
      
      Drops WebCore::MessageType from the addMessageToConsole method.
      
      * WebCoreSupport/ChromeClientBlackBerry.cpp:
      (WebCore::ChromeClientBlackBerry::addMessageToConsole):
      * WebCoreSupport/ChromeClientBlackBerry.h:
      (ChromeClientBlackBerry):
      
      Source/WebKit/chromium:
      
      Drops WebCore::MessageType from the addMessageToConsole method, and all
      the ancilliary places it touches.
      
      Aliases postConsoleMessageToWorkerObject with the old interface in
      order to maintain back-compat. Will remove it in a future patch once
      Chromium is updated.
      
      * public/WebSharedWorkerClient.h:
      (WebSharedWorkerClient):
      (WebKit::WebSharedWorkerClient::postConsoleMessageToWorkerObject):
      * src/ChromeClientImpl.cpp:
      * src/ChromeClientImpl.h:
      (ChromeClientImpl):
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::addMessageToConsole):
      * src/WebPagePopupImpl.cpp:
      * src/WebSharedWorkerImpl.cpp:
      (WebKit::WebSharedWorkerImpl::postConsoleMessageToWorkerObject):
      (WebKit::WebSharedWorkerImpl::postConsoleMessageTask):
      * src/WebSharedWorkerImpl.h:
      (WebSharedWorkerImpl):
      * src/WebWorkerClientImpl.cpp:
      (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObject):
      * src/WebWorkerClientImpl.h:
      (WebWorkerClientImpl):
      
      Source/WebKit/efl:
      
      Drops WebCore::MessageType from the addMessageToConsole method.
      
      * WebCoreSupport/ChromeClientEfl.cpp:
      (WebCore::ChromeClientEfl::addMessageToConsole):
      * WebCoreSupport/ChromeClientEfl.h:
      (ChromeClientEfl):
      
      Source/WebKit/gtk:
      
      Drops WebCore::MessageType from the addMessageToConsole method.
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::addMessageToConsole):
      * WebCoreSupport/ChromeClientGtk.h:
      (ChromeClient):
      
      Source/WebKit/mac:
      
      Drops WebCore::MessageType from the addMessageToConsole method.
      
      * WebCoreSupport/WebChromeClient.h:
      (WebChromeClient):
      * WebCoreSupport/WebChromeClient.mm:
      (WebChromeClient::addMessageToConsole):
      
      Source/WebKit/qt:
      
      Drops WebCore::MessageType from the addMessageToConsole method.
      
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::addMessageToConsole):
      * WebCoreSupport/ChromeClientQt.h:
      (ChromeClientQt):
      
      Source/WebKit/win:
      
      Drops WebCore::MessageType from the addMessageToConsole method.
      
      * WebCoreSupport/WebChromeClient.cpp:
      (WebChromeClient::addMessageToConsole):
      * WebCoreSupport/WebChromeClient.h:
      (WebChromeClient):
      
      Source/WebKit/wince:
      
      Drops WebCore::MessageType from the addMessageToConsole method.
      
      * WebCoreSupport/ChromeClientWinCE.cpp:
      (WebKit::ChromeClientWinCE::addMessageToConsole):
      * WebCoreSupport/ChromeClientWinCE.h:
      (ChromeClientWinCE):
      
      Source/WebKit2:
      
      Drops WebCore::MessageLevel from the addMessageToConsole method.
      
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::addMessageToConsole):
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      (WebChromeClient):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137318 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      236e8984
  9. 05 Dec, 2012 2 commits
    • mkwst@chromium.org's avatar
      Stop generating call stacks inside ContentSecurityPolicy · 315bce6e
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104126
      
      Reviewed by Yury Semikhatsky.
      
      Now that bug 100650 has made it possible for ConsoleMessage to generate
      call stacks, we can remove the stack being generated in
      ContentSecurityPolicy::logToConsole. We need the ScriptState*, however,
      so this patch makes it possible to pipe it through addConsoleMessage
      down into the guts of the inspector.
      
      This patch also removes an unused addConsoleMessage variant from
      ScriptExecutionContext, which should have been removed from the patch to
      100650 before landing it. My bad.
      
      * dom/Document.cpp:
      (WebCore::Document::addMessage):
      * dom/Document.h:
      (Document):
          Accept a ScriptState* parameter in Document::addMessage, and pass it
          through to Console::addMessage.
      * dom/ScriptExecutionContext.cpp:
      (WebCore::ScriptExecutionContext::addConsoleMessage):
      * dom/ScriptExecutionContext.h:
      (ScriptExecutionContext):
          Accept a ScriptState* parameter in Document::addMessage, and pass it
          through to ScriptExecutionContext::addMessage. Also, remove an unused
          variant of ScriptExecutionContext::addConsoleMessage that accepted
          only a call stack in addition to the basics.
      * inspector/ConsoleMessage.cpp:
      (WebCore::ConsoleMessage::ConsoleMessage):
      * inspector/ConsoleMessage.h:
      (ConsoleMessage):
          Accept a ScriptState* and pass it into autogenerateMetadata for
          call stack generational goodness.
      * inspector/InspectorConsoleAgent.cpp:
      (WebCore::InspectorConsoleAgent::addMessageToConsole):
          Accept a ScriptState* and pass it into addConsoleMessage.
      (WebCore::InspectorConsoleAgent::didFinishXHRLoading):
      (WebCore::InspectorConsoleAgent::didReceiveResponse):
      (WebCore::InspectorConsoleAgent::didFailLoading):
          Add an empty ScriptState parameter to the addConsoleMessage call.
      * inspector/InspectorConsoleAgent.h:
      (InspectorConsoleAgent):
      * inspector/InspectorConsoleInstrumentation.h:
      (WebCore::InspectorInstrumentation::addMessageToConsole):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore):
      (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
      * inspector/InspectorInstrumentation.h:
      (InspectorInstrumentation):
      * page/Console.cpp:
      (WebCore::Console::addMessage):
      * page/Console.h:
      (Console):
          Pipe ScriptState through the intermediate classes.
      * page/ContentSecurityPolicy.cpp:
      (WebCore::ContentSecurityPolicy::logToConsole):
          Drop call stack generation, and pass ScriptState* into addConsoleMessage.
      * workers/WorkerContext.cpp:
      (WebCore::WorkerContext::addConsoleMessage):
      (WebCore::WorkerContext::addMessage):
      (WebCore::WorkerContext::addMessageToWorkerConsole):
      * workers/WorkerContext.h:
      (WorkerContext):
          Accept ScriptState* and pass it into addMessageToConsole.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136719 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      315bce6e
    • mkwst@chromium.org's avatar
      Web Inspector: Autogenerate stack traces and line numbers when possible. · d2e0adcc
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100650
      
      Reviewed by Yury Semikhatsky.
      
      Source/WebCore:
      
      Console messages generated in WebCore generally are asked to do a bit of
      work in order to provide a developer with a detailed report. We ask the
      caller to either generate stack traces, or pass in a url/line number
      pair, which can be a bit of work. Predictably, most callers don't pass
      in what we'd like to see.
      
      This patch creates a new, simpler console message generation API that we
      expect most call sites to use. Source, type, level, and message are
      required, and an optional request ID can be passed in. Everything else
      will be autogenerated inside ConsoleMessage when appropriate.
      
      In a subsequent patch, we expect to be able to trim down more of the
      external call sites (ContentSecurityPolicy springs to mind) in order to
      further consolidate the external interface. Simple is good.
      
      * Modules/websockets/WebSocket.cpp:
      (WebCore::WebSocket::connect):
      * Modules/websockets/WebSocketChannel.cpp:
      (WebCore::WebSocketChannel::didFailSocketStream):
          Drop the now-redundant URL parameter from various WebSocket errors.
      * css/MediaList.cpp:
      (WebCore::addResolutionWarningMessageToConsole):
          Switch to Document::addConsoleMessage, which means that we can move
          line-number generation out of MediaList.
      * dom/Document.cpp:
      (WebCore::Document::logExceptionToConsole):
          Use the long-form 'addMessage()' rather than the public interface.
      (WebCore::Document::processHttpEquiv):
          Drop the URL parameter, as it's now autogenerated.
      (WebCore::Document::addConsoleMessage):
      (WebCore):
      * dom/Document.h:
      (Document):
          Override the pure virtual method on ScriptExecutionContext, and pass
          the call through to the new Console::addMessage, which accepts a
          pointer to the Document in order to do line-number generation.
      * dom/ScriptExecutionContext.h:
      (ScriptExecutionContext):
          Add a pure virtual variant of addConsoleMessage which accepts only
          bare minimum data, and expects autogeneration of the rest.
          Additionally, ensure that the other variants always have either a
          URL/line number, or a stack trace.
      * dom/ViewportArguments.cpp:
      (WebCore::reportViewportWarning):
          Drop line numbers and URLs from Viewport warnings. We can generate
          these now.
      * html/HTMLFormElement.cpp:
      (WebCore::HTMLFormElement::validateInteractively):
          Drop the URL from form autofocus warnings
      * html/HTMLIFrameElement.cpp:
      (WebCore::HTMLIFrameElement::parseAttribute):
          Drop the URL and line from sandbox attribute warnings.
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore):
      (WebCore::WebGLRenderingContext::printWarningToConsole):
          Drop the URL from WebGL warnings.
      * inspector/ConsoleMessage.cpp:
      (WebCore::ConsoleMessage::ConsoleMessage):
          Call 'autogenerateMetadata' to ensure that a stack trace is
          generated if one isn't provided. Create a new constructor that
          accepts a ScriptState/ScriptArguments pair, and use it for console
          API calls.
      (WebCore):
      (WebCore::ConsoleMessage::autogenerateMetadata):
          Generate a stack trace given whatever information we've got.
      * inspector/ConsoleMessage.h:
      (ConsoleMessage):
          Create a new constructor that accepts a ScriptState/ScriptArguments
          pair, and use it for console API calls.
      * inspector/InspectorConsoleAgent.cpp:
      (WebCore::InspectorConsoleAgent::enable):
          Use the short-form ConsoleMessage constructor.
      (WebCore::InspectorConsoleAgent::addMessageToConsole):
          Use the stack-only constructor, or the ScriptState
          constructor, as appropriate.
      (WebCore::InspectorConsoleAgent::count):
          We generated a stack, pass it in.
      * inspector/InspectorConsoleAgent.cpp:
      (WebCore::InspectorConsoleAgent::isWorkerAgent):
      * inspector/PageConsoleAgent.h:
      (WebCore::PageConsoleAgent::isWorkerAgent):
      * inspector/PageConsoleAgent.h:
      (WebCore::PageConsoleAgent::isWorkerAgent):
          We only want to generate call stacks for non-Workers (because
          createScriptCallStack explodes in JSC if we're not on the main
          thread). This method will allow us to distinguish between those
          messages generated from Workers, and those from Pages.
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):
      * loader/MainResourceLoader.cpp:
      (WebCore::MainResourceLoader::didReceiveResponse):
          Drop the URL parameter from the console message for X-Frame-Options
          parsing errors.
      * page/Console.cpp:
      (WebCore::Console::addMessage):
          When given a Document*, generate a line number if: 1) the document
          is still being parsed, 2) the document is not in document.write(),
          3) the parser isn't waiting for script, and 4) the parser isn't
          executing script. Many callsites didn't check all of these, which
          is why the SVG rebaseline (for example) drops lots and lots of line
          numbers which point at a closing '</script>' tag.
      (WebCore):
      * page/Console.h:
      (WebCore):
      (Console):
          Update the public API to accept a Document* and little else.
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::printErrorMessage):
          Don't generate a stack here. We can do it later.
      * svg/SVGDocumentExtensions.cpp:
      (WebCore::reportMessage):
          Drop the URL and line number. We'll generate them. It'll be sweet.
      * workers/WorkerContext.cpp:
      (WebCore::WorkerContext::addConsoleMessage):
      (WebCore):
      * workers/WorkerContext.h:
      (WorkerContext):
          Implement the new addConsoleMessage variant.
      
      LayoutTests:
      
      New line numbers! Huzzah! (Also, removing some that shouldn't be there).
      
      * http/tests/inspector/console-xhr-logging-expected.txt:
      * platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt:
          One new stack trace! OMG!
      * fast/frames/sandboxed-iframe-autofocus-denied-expected.txt:
      * fast/frames/sandboxed-iframe-parsing-space-characters-expected.txt:
      * fast/frames/xss-auditor-handles-file-urls-expected.txt:
      * html5lib/run-test11-expected.txt:
      * http/tests/misc/bubble-drag-events-expected.txt:
      * http/tests/misc/drag-over-iframe-invalid-source-crash-expected.txt:
      * http/tests/misc/iframe-invalid-source-crash-expected.txt:
      * http/tests/misc/image-blocked-src-change-expected.txt:
      * http/tests/misc/image-blocked-src-no-change-expected.txt:
      * http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
      * http/tests/security/frame-loading-via-document-write-expected.txt:
      * http/tests/security/mixedContent/insecure-css-in-iframe-expected.txt:
      * http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt:
      * http/tests/security/mixedContent/insecure-image-in-main-frame-expected.txt:
      * http/tests/security/xss-DENIED-xml-external-entity-expected.txt:
      * http/tests/security/xssAuditor/base-href-control-char-expected.txt:
      * http/tests/security/xssAuditor/base-href-expected.txt:
      * http/tests/security/xssAuditor/base-href-null-char-expected.txt:
      * http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt:
      * http/tests/security/xssAuditor/cookie-injection-expected.txt:
      * http/tests/security/xssAuditor/embed-tag-code-attribute-2-expected.txt:
      * http/tests/security/xssAuditor/embed-tag-code-attribute-expected.txt:
      * http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
      * http/tests/security/xssAuditor/embed-tag-expected.txt:
      * http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt:
      * http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
      * http/tests/security/xssAuditor/form-action-expected.txt:
      * http/tests/security/xssAuditor/full-block-base-href-expected.txt:
      * http/tests/security/xssAuditor/full-block-get-from-iframe-expected.txt:
      * http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt:
      * http/tests/security/xssAuditor/full-block-iframe-no-inherit-expected.txt:
      * http/tests/security/xssAuditor/full-block-javascript-link-expected.txt:
      * http/tests/security/xssAuditor/full-block-link-onclick-expected.txt:
      * http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
      * http/tests/security/xssAuditor/full-block-post-from-iframe-expected.txt:
      * http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
      * http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt:
      * http/tests/security/xssAuditor/get-from-iframe-expected.txt:
      * http/tests/security/xssAuditor/iframe-injection-expected.txt:
      * http/tests/security/xssAuditor/iframe-javascript-url-expected.txt:
      * http/tests/security/xssAuditor/iframe-javascript-url-more-encoding-expected.txt:
      * http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode-expected.txt:
      * http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2-expected.txt:
      * http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3-expected.txt:
      * http/tests/security/xssAuditor/iframe-javascript-url-url-encoded-expected.txt:
      * http/tests/security/xssAuditor/iframe-onload-GBK-char-expected.txt:
      * http/tests/security/xssAuditor/iframe-onload-in-svg-tag-expected.txt:
      * http/tests/security/xssAuditor/iframe-srcdoc-expected.txt:
      * http/tests/security/xssAuditor/img-onerror-GBK-char-expected.txt:
      * http/tests/security/xssAuditor/img-onerror-accented-char-expected.txt:
      * http/tests/security/xssAuditor/img-onerror-non-ASCII-char-default-encoding-expected.txt:
      * http/tests/security/xssAuditor/img-onerror-non-ASCII-char-expected.txt:
      * http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-default-encoding-expected.txt:
      * http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-expected.txt:
      * http/tests/security/xssAuditor/inline-event-HTML-entities-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-HTML-entities-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-HTML-entities-named-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-ampersand-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-control-char-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-null-char-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-one-plus-one-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-url-encoded-expected.txt:
      * http/tests/security/xssAuditor/link-onclick-ampersand-expected.txt:
      * http/tests/security/xssAuditor/link-onclick-control-char-expected.txt:
      * http/tests/security/xssAuditor/link-onclick-entities-expected.txt:
      * http/tests/security/xssAuditor/link-onclick-expected.txt:
      * http/tests/security/xssAuditor/link-onclick-null-char-expected.txt:
      * http/tests/security/xssAuditor/link-opens-new-window-expected.txt:
      * http/tests/security/xssAuditor/malformed-HTML-expected.txt:
      * http/tests/security/xssAuditor/malformed-xss-protection-header-1-expected.txt:
      * http/tests/security/xssAuditor/malformed-xss-protection-header-2-expected.txt:
      * http/tests/security/xssAuditor/malformed-xss-protection-header-3-expected.txt:
      * http/tests/security/xssAuditor/malformed-xss-protection-header-4-expected.txt:
      * http/tests/security/xssAuditor/malformed-xss-protection-header-5-expected.txt:
      * http/tests/security/xssAuditor/malformed-xss-protection-header-6-expected.txt:
      * http/tests/security/xssAuditor/malformed-xss-protection-header-7-expected.txt:
      * http/tests/security/xssAuditor/malformed-xss-protection-header-8-expected.txt:
      * http/tests/security/xssAuditor/malformed-xss-protection-header-9-expected.txt:
      * http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url-expected.txt:
      * http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
      * http/tests/security/xssAuditor/object-embed-tag-expected.txt:
      * http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
      * http/tests/security/xssAuditor/object-tag-expected.txt:
      * http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt:
      * http/tests/security/xssAuditor/open-attribute-body-expected.txt:
      * http/tests/security/xssAuditor/open-event-handler-iframe-expected.txt:
      * http/tests/security/xssAuditor/open-iframe-src-expected.txt:
      * http/tests/security/xssAuditor/open-script-src-expected.txt:
      * http/tests/security/xssAuditor/post-from-iframe-expected.txt:
      * http/tests/security/xssAuditor/property-escape-comment-expected.txt:
      * http/tests/security/xssAuditor/property-escape-entity-expected.txt:
      * http/tests/security/xssAuditor/property-escape-expected.txt:
      * http/tests/security/xssAuditor/property-escape-long-expected.txt:
      * http/tests/security/xssAuditor/property-escape-quote-expected.txt:
      * http/tests/security/xssAuditor/report-script-tag-expected.txt:
      * http/tests/security/xssAuditor/script-tag-Big5-char-expected.txt:
      * http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-16bit-unicode-expected.txt:
      * http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-expected.txt:
      * http/tests/security/xssAuditor/script-tag-Big5-char2-expected.txt:
      * http/tests/security/xssAuditor/script-tag-addslashes-backslash-expected.txt:
      * http/tests/security/xssAuditor/script-tag-addslashes-double-quote-expected.txt:
      * http/tests/security/xssAuditor/script-tag-addslashes-null-char-expected.txt:
      * http/tests/security/xssAuditor/script-tag-addslashes-single-quote-expected.txt:
      * http/tests/security/xssAuditor/script-tag-control-char-expected.txt:
      * http/tests/security/xssAuditor/script-tag-convoluted-expected.txt:
      * http/tests/security/xssAuditor/script-tag-entities-expected.txt:
      * http/tests/security/xssAuditor/script-tag-expected.txt:
      * http/tests/security/xssAuditor/script-tag-inside-svg-tag-expected.txt:
      * http/tests/security/xssAuditor/script-tag-inside-svg-tag2-expected.txt:
      * http/tests/security/xssAuditor/script-tag-inside-svg-tag3-expected.txt:
      * http/tests/security/xssAuditor/script-tag-null-char-expected.txt:
      * http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt:
      * http/tests/security/xssAuditor/script-tag-post-control-char-expected.txt:
      * http/tests/security/xssAuditor/script-tag-post-expected.txt:
      * http/tests/security/xssAuditor/script-tag-post-null-char-expected.txt:
      * http/tests/security/xssAuditor/script-tag-redirect-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode-surrogate-pair-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode2-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode3-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode4-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode5-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-actual-comma-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-callbacks-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-comma-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-fancy-unicode-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-invalid-url-encoding-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-control-char-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-data-url-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-data-url2-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-data-url3-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-double-quote-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-no-quote-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-null-char-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-relative-scheme-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-unterminated-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-three-times-url-encoded-16bit-unicode-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-trailing-comment-U2028-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-trailing-comment-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-trailing-comment2-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-trailing-comment3-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-trailing-comment4-expected.txt:
      * http/tests/security/xssAuditor/xss-filter-bypass-big5-expected.txt:
      * http/tests/security/xssAuditor/xss-filter-bypass-long-string-expected.txt:
      * http/tests/security/xssAuditor/xss-filter-bypass-sjis-expected.txt:
      * http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txt:
      * http/tests/security/xssAuditor/xss-protection-parsing-02-expected.txt:
      * http/tests/security/xssAuditor/xss-protection-parsing-03-expected.txt:
      * http/tests/security/xssAuditor/xss-protection-parsing-04-expected.txt:
      * platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
      * platform/chromium/http/tests/misc/bubble-drag-events-expected.txt:
      * platform/chromium/http/tests/misc/drag-over-iframe-invalid-source-crash-expected.txt:
      * platform/chromium/http/tests/misc/iframe-invalid-source-crash-expected.txt:
      * platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed-expected.txt:
      * platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-blocked-expected.txt:
      * platform/chromium/http/tests/security/xssAuditor/javascript-link-control-char2-expected.txt:
      * platform/chromium/svg/custom/polyline-setattribute-points-null-expected.txt:
      * platform/mac/svg/custom/clip-path-referencing-use2-expected.txt:
      * platform/mac/svg/custom/polyline-setattribute-points-null-expected.txt:
      * svg/custom/invalid-length-units-expected.txt:
      * svg/custom/poly-parsing-error-expected.txt:
      * svg/dom/SVGScriptElement/script-onerror-bubbling-expected.txt:
      * svg/dom/fuzz-path-parser-expected.txt:
      * svg/dom/path-parser-expected.txt:
      * svg/dom/points-parser-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136657 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2e0adcc
  10. 03 Dec, 2012 2 commits
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r136377. · 9c2ae3a0
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/136377
      https://bugs.webkit.org/show_bug.cgi?id=103881
      
      Causes crashes on debug builds that use JSC. (Requested by
      mkwst on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-03
      
      Source/WebCore:
      
      * Modules/websockets/WebSocket.cpp:
      (WebCore::WebSocket::connect):
      * Modules/websockets/WebSocketChannel.cpp:
      (WebCore::WebSocketChannel::didFailSocketStream):
      * css/MediaList.cpp:
      (WebCore::addResolutionWarningMessageToConsole):
      * dom/Document.cpp:
      (WebCore::Document::logExceptionToConsole):
      (WebCore::Document::processHttpEquiv):
      * dom/Document.h:
      (Document):
      * dom/ScriptExecutionContext.h:
      (ScriptExecutionContext):
      * dom/ViewportArguments.cpp:
      (WebCore):
      (WebCore::parserLineNumber):
      (WebCore::reportViewportWarning):
      * html/HTMLFormElement.cpp:
      (WebCore::HTMLFormElement::validateInteractively):
      * html/HTMLIFrameElement.cpp:
      (WebCore::HTMLIFrameElement::parseAttribute):
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore):
      (WebCore::WebGLRenderingContext::printWarningToConsole):
      * inspector/ConsoleMessage.cpp:
      (WebCore::ConsoleMessage::ConsoleMessage):
      * inspector/ConsoleMessage.h:
      (ConsoleMessage):
      * inspector/InspectorConsoleAgent.cpp:
      (WebCore::InspectorConsoleAgent::enable):
      (WebCore::InspectorConsoleAgent::addMessageToConsole):
      (WebCore::InspectorConsoleAgent::count):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):
      * loader/MainResourceLoader.cpp:
      (WebCore::MainResourceLoader::didReceiveResponse):
      * page/Console.cpp:
      * page/Console.h:
      (Console):
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::printErrorMessage):
      * svg/SVGDocumentExtensions.cpp:
      (WebCore):
      (WebCore::parserLineNumber):
      (WebCore::reportMessage):
      * workers/WorkerContext.cpp:
      * workers/WorkerContext.h:
      (WorkerContext):
      
      LayoutTests:
      
      * fast/frames/sandboxed-iframe-autofocus-denied-expected.txt:
      * fast/frames/sandboxed-iframe-parsing-space-characters-expected.txt:
      * fast/frames/xss-auditor-handles-file-urls-expected.txt:
      * html5lib/run-test11-expected.txt:
      * http/tests/inspector/console-xhr-logging-expected.txt:
      * http/tests/misc/bubble-drag-events-expected.txt:
      * http/tests/misc/drag-over-iframe-invalid-source-crash-expected.txt:
      * http/tests/misc/iframe-invalid-source-crash-expected.txt:
      * http/tests/misc/image-blocked-src-change-expected.txt:
      * http/tests/misc/image-blocked-src-no-change-expected.txt:
      * http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
      * http/tests/security/frame-loading-via-document-write-expected.txt:
      * http/tests/security/mixedContent/insecure-css-in-iframe-expected.txt:
      * http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt:
      * http/tests/security/mixedContent/insecure-image-in-main-frame-expected.txt:
      * http/tests/security/xss-DENIED-xml-external-entity-expected.txt:
      * http/tests/security/xssAuditor/base-href-control-char-expected.txt:
      * http/tests/security/xssAuditor/base-href-expected.txt:
      * http/tests/security/xssAuditor/base-href-null-char-expected.txt:
      * http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt:
      * http/tests/security/xssAuditor/cookie-injection-expected.txt:
      * http/tests/security/xssAuditor/embed-tag-code-attribute-2-expected.txt:
      * http/tests/security/xssAuditor/embed-tag-code-attribute-expected.txt:
      * http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
      * http/tests/security/xssAuditor/embed-tag-expected.txt:
      * http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt:
      * http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
      * http/tests/security/xssAuditor/form-action-expected.txt:
      * http/tests/security/xssAuditor/full-block-base-href-expected.txt:
      * http/tests/security/xssAuditor/full-block-get-from-iframe-expected.txt:
      * http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt:
      * http/tests/security/xssAuditor/full-block-iframe-no-inherit-expected.txt:
      * http/tests/security/xssAuditor/full-block-javascript-link-expected.txt:
      * http/tests/security/xssAuditor/full-block-link-onclick-expected.txt:
      * http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
      * http/tests/security/xssAuditor/full-block-post-from-iframe-expected.txt:
      * http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
      * http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt:
      * http/tests/security/xssAuditor/get-from-iframe-expected.txt:
      * http/tests/security/xssAuditor/iframe-injection-expected.txt:
      * http/tests/security/xssAuditor/iframe-javascript-url-expected.txt:
      * http/tests/security/xssAuditor/iframe-javascript-url-more-encoding-expected.txt:
      * http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode-expected.txt:
      * http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2-expected.txt:
      * http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3-expected.txt:
      * http/tests/security/xssAuditor/iframe-javascript-url-url-encoded-expected.txt:
      * http/tests/security/xssAuditor/iframe-onload-GBK-char-expected.txt:
      * http/tests/security/xssAuditor/iframe-onload-in-svg-tag-expected.txt:
      * http/tests/security/xssAuditor/iframe-srcdoc-expected.txt:
      * http/tests/security/xssAuditor/img-onerror-GBK-char-expected.txt:
      * http/tests/security/xssAuditor/img-onerror-accented-char-expected.txt:
      * http/tests/security/xssAuditor/img-onerror-non-ASCII-char-default-encoding-expected.txt:
      * http/tests/security/xssAuditor/img-onerror-non-ASCII-char-expected.txt:
      * http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-default-encoding-expected.txt:
      * http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-expected.txt:
      * http/tests/security/xssAuditor/inline-event-HTML-entities-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-HTML-entities-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-HTML-entities-named-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-ampersand-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-control-char-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-null-char-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-one-plus-one-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-url-encoded-expected.txt:
      * http/tests/security/xssAuditor/link-onclick-ampersand-expected.txt:
      * http/tests/security/xssAuditor/link-onclick-control-char-expected.txt:
      * http/tests/security/xssAuditor/link-onclick-entities-expected.txt:
      * http/tests/security/xssAuditor/link-onclick-expected.txt:
      * http/tests/security/xssAuditor/link-onclick-null-char-expected.txt:
      * http/tests/security/xssAuditor/link-opens-new-window-expected.txt:
      * http/tests/security/xssAuditor/malformed-HTML-expected.txt:
      * http/tests/security/xssAuditor/malformed-xss-protection-header-1-expected.txt:
      * http/tests/security/xssAuditor/malformed-xss-protection-header-2-expected.txt:
      * http/tests/security/xssAuditor/malformed-xss-protection-header-3-expected.txt:
      * http/tests/security/xssAuditor/malformed-xss-protection-header-4-expected.txt:
      * http/tests/security/xssAuditor/malformed-xss-protection-header-5-expected.txt:
      * http/tests/security/xssAuditor/malformed-xss-protection-header-6-expected.txt:
      * http/tests/security/xssAuditor/malformed-xss-protection-header-7-expected.txt:
      * http/tests/security/xssAuditor/malformed-xss-protection-header-8-expected.txt:
      * http/tests/security/xssAuditor/malformed-xss-protection-header-9-expected.txt:
      * http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url-expected.txt:
      * http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
      * http/tests/security/xssAuditor/object-embed-tag-expected.txt:
      * http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
      * http/tests/security/xssAuditor/object-tag-expected.txt:
      * http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt:
      * http/tests/security/xssAuditor/open-attribute-body-expected.txt:
      * http/tests/security/xssAuditor/open-event-handler-iframe-expected.txt:
      * http/tests/security/xssAuditor/open-iframe-src-expected.txt:
      * http/tests/security/xssAuditor/open-script-src-expected.txt:
      * http/tests/security/xssAuditor/post-from-iframe-expected.txt:
      * http/tests/security/xssAuditor/property-escape-comment-expected.txt:
      * http/tests/security/xssAuditor/property-escape-entity-expected.txt:
      * http/tests/security/xssAuditor/property-escape-expected.txt:
      * http/tests/security/xssAuditor/property-escape-long-expected.txt:
      * http/tests/security/xssAuditor/property-escape-quote-expected.txt:
      * http/tests/security/xssAuditor/report-script-tag-expected.txt:
      * http/tests/security/xssAuditor/script-tag-Big5-char-expected.txt:
      * http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-16bit-unicode-expected.txt:
      * http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-expected.txt:
      * http/tests/security/xssAuditor/script-tag-Big5-char2-expected.txt:
      * http/tests/security/xssAuditor/script-tag-addslashes-backslash-expected.txt:
      * http/tests/security/xssAuditor/script-tag-addslashes-double-quote-expected.txt:
      * http/tests/security/xssAuditor/script-tag-addslashes-null-char-expected.txt:
      * http/tests/security/xssAuditor/script-tag-addslashes-single-quote-expected.txt:
      * http/tests/security/xssAuditor/script-tag-control-char-expected.txt:
      * http/tests/security/xssAuditor/script-tag-convoluted-expected.txt:
      * http/tests/security/xssAuditor/script-tag-entities-expected.txt:
      * http/tests/security/xssAuditor/script-tag-expected.txt:
      * http/tests/security/xssAuditor/script-tag-inside-svg-tag-expected.txt:
      * http/tests/security/xssAuditor/script-tag-inside-svg-tag2-expected.txt:
      * http/tests/security/xssAuditor/script-tag-inside-svg-tag3-expected.txt:
      * http/tests/security/xssAuditor/script-tag-null-char-expected.txt:
      * http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt:
      * http/tests/security/xssAuditor/script-tag-post-control-char-expected.txt:
      * http/tests/security/xssAuditor/script-tag-post-expected.txt:
      * http/tests/security/xssAuditor/script-tag-post-null-char-expected.txt:
      * http/tests/security/xssAuditor/script-tag-redirect-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode-surrogate-pair-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode2-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode3-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode4-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode5-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-actual-comma-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-callbacks-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-comma-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-fancy-unicode-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-invalid-url-encoding-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-control-char-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-data-url-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-data-url2-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-data-url3-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-double-quote-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-no-quote-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-null-char-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-relative-scheme-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-unterminated-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-three-times-url-encoded-16bit-unicode-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-trailing-comment-U2028-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-trailing-comment-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-trailing-comment2-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-trailing-comment3-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-trailing-comment4-expected.txt:
      * http/tests/security/xssAuditor/xss-filter-bypass-big5-expected.txt:
      * http/tests/security/xssAuditor/xss-filter-bypass-long-string-expected.txt:
      * http/tests/security/xssAuditor/xss-filter-bypass-sjis-expected.txt:
      * http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txt:
      * http/tests/security/xssAuditor/xss-protection-parsing-02-expected.txt:
      * http/tests/security/xssAuditor/xss-protection-parsing-03-expected.txt:
      * http/tests/security/xssAuditor/xss-protection-parsing-04-expected.txt:
      * platform/chromium-linux/http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
      * platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
      * platform/chromium-win/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
      * platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt:
      * platform/chromium/http/tests/misc/bubble-drag-events-expected.txt:
      * platform/chromium/http/tests/misc/drag-over-iframe-invalid-source-crash-expected.txt:
      * platform/chromium/http/tests/misc/iframe-invalid-source-crash-expected.txt:
      * platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed-expected.txt:
      * platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-blocked-expected.txt:
      * platform/chromium/http/tests/security/xssAuditor/javascript-link-control-char2-expected.txt:
      * platform/chromium/svg/custom/polyline-setattribute-points-null-expected.txt:
      * platform/mac/svg/custom/clip-path-referencing-use2-expected.txt:
      * platform/mac/svg/custom/polyline-setattribute-points-null-expected.txt:
      * svg/custom/invalid-length-units-expected.txt:
      * svg/custom/poly-parsing-error-expected.txt:
      * svg/dom/fuzz-path-parser-expected.txt:
      * svg/dom/path-parser-expected.txt:
      * svg/dom/points-parser-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136386 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c2ae3a0
    • mkwst@chromium.org's avatar
      Web Inspector: Autogenerate stack traces and line numbers when possible. · 8579b0b8
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100650
      
      Reviewed by Yury Semikhatsky.
      
      Source/WebCore:
      
      Console messages generated in WebCore generally are asked to do a bit of
      work in order to provide a developer with a detailed report. We ask the
      caller to either generate stack traces, or pass in a url/line number
      pair, which can be a bit of work. Predictably, most callers don't pass
      in what we'd like to see.
      
      This patch creates a new, simpler console message generation API that we
      expect most call sites to use. Source, type, level, and message are
      required, and an optional request ID can be passed in. Everything else
      will be autogenerated inside ConsoleMessage when appropriate.
      
      In a subsequent patch, we expect to be able to trim down more of the
      external call sites (ContentSecurityPolicy springs to mind) in order to
      further consolidate the external interface. Simple is good.
      
      * Modules/websockets/WebSocket.cpp:
      (WebCore::WebSocket::connect):
      * Modules/websockets/WebSocketChannel.cpp:
      (WebCore::WebSocketChannel::didFailSocketStream):
          Drop the now-redundant URL parameter from various WebSocket errors.
      * css/MediaList.cpp:
      (WebCore::addResolutionWarningMessageToConsole):
          Switch to Document::addConsoleMessage, which means that we can move
          line-number generation out of MediaList.
      * dom/Document.cpp:
      (WebCore::Document::logExceptionToConsole):
          Use the long-form 'addMessage()' rather than the public interface.
      (WebCore::Document::processHttpEquiv):
          Drop the URL parameter, as it's now autogenerated.
      (WebCore::Document::addConsoleMessage):
      (WebCore):
      * dom/Document.h:
      (Document):
          Override the pure virtual method on ScriptExecutionContext, and pass
          the call through to the new Console::addMessage, which accepts a
          pointer to the Document in order to do line-number generation.
      * dom/ScriptExecutionContext.h:
      (ScriptExecutionContext):
          Add a pure virtual variant of addConsoleMessage which accepts only
          bare minimum data, and expects autogeneration of the rest.
          Additionally, ensure that the other variants always have either a
          URL/line number, or a stack trace.
      * dom/ViewportArguments.cpp:
      (WebCore::reportViewportWarning):
          Drop line numbers and URLs from Viewport warnings. We can generate
          these now.
      * html/HTMLFormElement.cpp:
      (WebCore::HTMLFormElement::validateInteractively):
          Drop the URL from form autofocus warnings
      * html/HTMLIFrameElement.cpp:
      (WebCore::HTMLIFrameElement::parseAttribute):
          Drop the URL and line from sandbox attribute warnings.
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore):
      (WebCore::WebGLRenderingContext::printWarningToConsole):
          Drop the URL from WebGL warnings.
      * inspector/ConsoleMessage.cpp:
      (WebCore::ConsoleMessage::ConsoleMessage):
          Call 'autogenerateMetadata' to ensure that a stack trace is
          generated if one isn't provided. Create a new constructor that
          accepts a ScriptState/ScriptArguments pair, and use it for console
          API calls.
      (WebCore):
      (WebCore::ConsoleMessage::autogenerateMetadata):
          Generate a stack trace given whatever information we've got.
      * inspector/ConsoleMessage.h:
      (ConsoleMessage):
          Create a new constructor that accepts a ScriptState/ScriptArguments
          pair, and use it for console API calls.
      * inspector/InspectorConsoleAgent.cpp:
      (WebCore::InspectorConsoleAgent::enable):
          Use the short-form ConsoleMessage constructor.
      (WebCore::InspectorConsoleAgent::addMessageToConsole):
          Use the stack-only constructor, or the ScriptState
          constructor, as appropriate.
      (WebCore::InspectorConsoleAgent::count):
          We generated a stack, pass it in.
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):
      * loader/MainResourceLoader.cpp:
      (WebCore::MainResourceLoader::didReceiveResponse):
          Drop the URL parameter from the console message for X-Frame-Options
          parsing errors.
      * page/Console.cpp:
      (WebCore::Console::addMessage):
          When given a Document*, generate a line number if: 1) the document
          is still being parsed, 2) the document is not in document.write(),
          3) the parser isn't waiting for script, and 4) the parser isn't
          executing script. Many callsites didn't check all of these, which
          is why the SVG rebaseline (for example) drops lots and lots of line
          numbers which point at a closing '</script>' tag.
      (WebCore):
      * page/Console.h:
      (WebCore):
      (Console):
          Update the public API to accept a Document* and little else.
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::printErrorMessage):
          Don't generate a stack here. We can do it later.
      * svg/SVGDocumentExtensions.cpp:
      (WebCore::reportMessage):
          Drop the URL and line number. We'll generate them. It'll be sweet.
      * workers/WorkerContext.cpp:
      (WebCore::WorkerContext::addConsoleMessage):
          Generate a stack here, as we likely won't have the context to do
          so later. Pass it through.
      (WebCore):
      * workers/WorkerContext.h:
      (WorkerContext):
          Implement the new addConsoleMessage variant.
      
      LayoutTests:
      
      New line numbers! Huzzah! (Also, removing some that shouldn't be there).
      
      * http/tests/inspector/console-xhr-logging-expected.txt:
      * platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt:
          One new stack trace! OMG!
      * fast/frames/sandboxed-iframe-autofocus-denied-expected.txt:
      * fast/frames/sandboxed-iframe-parsing-space-characters-expected.txt:
      * fast/frames/xss-auditor-handles-file-urls-expected.txt:
      * html5lib/run-test11-expected.txt:
      * http/tests/misc/bubble-drag-events-expected.txt:
      * http/tests/misc/drag-over-iframe-invalid-source-crash-expected.txt:
      * http/tests/misc/iframe-invalid-source-crash-expected.txt:
      * http/tests/misc/image-blocked-src-change-expected.txt:
      * http/tests/misc/image-blocked-src-no-change-expected.txt:
      * http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
      * http/tests/security/frame-loading-via-document-write-expected.txt:
      * http/tests/security/mixedContent/insecure-css-in-iframe-expected.txt:
      * http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt:
      * http/tests/security/mixedContent/insecure-image-in-main-frame-expected.txt:
      * http/tests/security/xss-DENIED-xml-external-entity-expected.txt:
      * http/tests/security/xssAuditor/base-href-control-char-expected.txt:
      * http/tests/security/xssAuditor/base-href-expected.txt:
      * http/tests/security/xssAuditor/base-href-null-char-expected.txt:
      * http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt:
      * http/tests/security/xssAuditor/cookie-injection-expected.txt:
      * http/tests/security/xssAuditor/embed-tag-code-attribute-2-expected.txt:
      * http/tests/security/xssAuditor/embed-tag-code-attribute-expected.txt:
      * http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
      * http/tests/security/xssAuditor/embed-tag-expected.txt:
      * http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt:
      * http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
      * http/tests/security/xssAuditor/form-action-expected.txt:
      * http/tests/security/xssAuditor/full-block-base-href-expected.txt:
      * http/tests/security/xssAuditor/full-block-get-from-iframe-expected.txt:
      * http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt:
      * http/tests/security/xssAuditor/full-block-iframe-no-inherit-expected.txt:
      * http/tests/security/xssAuditor/full-block-javascript-link-expected.txt:
      * http/tests/security/xssAuditor/full-block-link-onclick-expected.txt:
      * http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
      * http/tests/security/xssAuditor/full-block-post-from-iframe-expected.txt:
      * http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
      * http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt:
      * http/tests/security/xssAuditor/get-from-iframe-expected.txt:
      * http/tests/security/xssAuditor/iframe-injection-expected.txt:
      * http/tests/security/xssAuditor/iframe-javascript-url-expected.txt:
      * http/tests/security/xssAuditor/iframe-javascript-url-more-encoding-expected.txt:
      * http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode-expected.txt:
      * http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2-expected.txt:
      * http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3-expected.txt:
      * http/tests/security/xssAuditor/iframe-javascript-url-url-encoded-expected.txt:
      * http/tests/security/xssAuditor/iframe-onload-GBK-char-expected.txt:
      * http/tests/security/xssAuditor/iframe-onload-in-svg-tag-expected.txt:
      * http/tests/security/xssAuditor/iframe-srcdoc-expected.txt:
      * http/tests/security/xssAuditor/img-onerror-GBK-char-expected.txt:
      * http/tests/security/xssAuditor/img-onerror-accented-char-expected.txt:
      * http/tests/security/xssAuditor/img-onerror-non-ASCII-char-default-encoding-expected.txt:
      * http/tests/security/xssAuditor/img-onerror-non-ASCII-char-expected.txt:
      * http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-default-encoding-expected.txt:
      * http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-expected.txt:
      * http/tests/security/xssAuditor/inline-event-HTML-entities-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-HTML-entities-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-HTML-entities-named-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-ampersand-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-control-char-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-null-char-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-one-plus-one-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-url-encoded-expected.txt:
      * http/tests/security/xssAuditor/link-onclick-ampersand-expected.txt:
      * http/tests/security/xssAuditor/link-onclick-control-char-expected.txt:
      * http/tests/security/xssAuditor/link-onclick-entities-expected.txt:
      * http/tests/security/xssAuditor/link-onclick-expected.txt:
      * http/tests/security/xssAuditor/link-onclick-null-char-expected.txt:
      * http/tests/security/xssAuditor/link-opens-new-window-expected.txt:
      * http/tests/security/xssAuditor/malformed-HTML-expected.txt:
      * http/tests/security/xssAuditor/malformed-xss-protection-header-1-expected.txt:
      * http/tests/security/xssAuditor/malformed-xss-protection-header-2-expected.txt:
      * http/tests/security/xssAuditor/malformed-xss-protection-header-3-expected.txt:
      * http/tests/security/xssAuditor/malformed-xss-protection-header-4-expected.txt:
      * http/tests/security/xssAuditor/malformed-xss-protection-header-5-expected.txt:
      * http/tests/security/xssAuditor/malformed-xss-protection-header-6-expected.txt:
      * http/tests/security/xssAuditor/malformed-xss-protection-header-7-expected.txt:
      * http/tests/security/xssAuditor/malformed-xss-protection-header-8-expected.txt:
      * http/tests/security/xssAuditor/malformed-xss-protection-header-9-expected.txt:
      * http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url-expected.txt:
      * http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
      * http/tests/security/xssAuditor/object-embed-tag-expected.txt:
      * http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
      * http/tests/security/xssAuditor/object-tag-expected.txt:
      * http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt:
      * http/tests/security/xssAuditor/open-attribute-body-expected.txt:
      * http/tests/security/xssAuditor/open-event-handler-iframe-expected.txt:
      * http/tests/security/xssAuditor/open-iframe-src-expected.txt:
      * http/tests/security/xssAuditor/open-script-src-expected.txt:
      * http/tests/security/xssAuditor/post-from-iframe-expected.txt:
      * http/tests/security/xssAuditor/property-escape-comment-expected.txt:
      * http/tests/security/xssAuditor/property-escape-entity-expected.txt:
      * http/tests/security/xssAuditor/property-escape-expected.txt:
      * http/tests/security/xssAuditor/property-escape-long-expected.txt:
      * http/tests/security/xssAuditor/property-escape-quote-expected.txt:
      * http/tests/security/xssAuditor/report-script-tag-expected.txt:
      * http/tests/security/xssAuditor/script-tag-Big5-char-expected.txt:
      * http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-16bit-unicode-expected.txt:
      * http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-expected.txt:
      * http/tests/security/xssAuditor/script-tag-Big5-char2-expected.txt:
      * http/tests/security/xssAuditor/script-tag-addslashes-backslash-expected.txt:
      * http/tests/security/xssAuditor/script-tag-addslashes-double-quote-expected.txt:
      * http/tests/security/xssAuditor/script-tag-addslashes-null-char-expected.txt:
      * http/tests/security/xssAuditor/script-tag-addslashes-single-quote-expected.txt:
      * http/tests/security/xssAuditor/script-tag-control-char-expected.txt:
      * http/tests/security/xssAuditor/script-tag-convoluted-expected.txt:
      * http/tests/security/xssAuditor/script-tag-entities-expected.txt:
      * http/tests/security/xssAuditor/script-tag-expected.txt:
      * http/tests/security/xssAuditor/script-tag-inside-svg-tag-expected.txt:
      * http/tests/security/xssAuditor/script-tag-inside-svg-tag2-expected.txt:
      * http/tests/security/xssAuditor/script-tag-inside-svg-tag3-expected.txt:
      * http/tests/security/xssAuditor/script-tag-null-char-expected.txt:
      * http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt:
      * http/tests/security/xssAuditor/script-tag-post-control-char-expected.txt:
      * http/tests/security/xssAuditor/script-tag-post-expected.txt:
      * http/tests/security/xssAuditor/script-tag-post-null-char-expected.txt:
      * http/tests/security/xssAuditor/script-tag-redirect-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode-surrogate-pair-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode2-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode3-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode4-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode5-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-actual-comma-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-callbacks-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-comma-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-fancy-unicode-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-invalid-url-encoding-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-control-char-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-data-url-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-data-url2-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-data-url3-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-double-quote-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-no-quote-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-null-char-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-relative-scheme-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-unterminated-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-three-times-url-encoded-16bit-unicode-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-trailing-comment-U2028-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-trailing-comment-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-trailing-comment2-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-trailing-comment3-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-trailing-comment4-expected.txt:
      * http/tests/security/xssAuditor/xss-filter-bypass-big5-expected.txt:
      * http/tests/security/xssAuditor/xss-filter-bypass-long-string-expected.txt:
      * http/tests/security/xssAuditor/xss-filter-bypass-sjis-expected.txt:
      * http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txt:
      * http/tests/security/xssAuditor/xss-protection-parsing-02-expected.txt:
      * http/tests/security/xssAuditor/xss-protection-parsing-03-expected.txt:
      * http/tests/security/xssAuditor/xss-protection-parsing-04-expected.txt:
      * platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
      * platform/chromium/http/tests/misc/bubble-drag-events-expected.txt:
      * platform/chromium/http/tests/misc/drag-over-iframe-invalid-source-crash-expected.txt:
      * platform/chromium/http/tests/misc/iframe-invalid-source-crash-expected.txt:
      * platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed-expected.txt:
      * platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-blocked-expected.txt:
      * platform/chromium/http/tests/security/xssAuditor/javascript-link-control-char2-expected.txt:
      * platform/chromium/svg/custom/polyline-setattribute-points-null-expected.txt:
      * platform/mac/svg/custom/clip-path-referencing-use2-expected.txt:
      * platform/mac/svg/custom/polyline-setattribute-points-null-expected.txt:
      * svg/custom/invalid-length-units-expected.txt:
      * svg/custom/poly-parsing-error-expected.txt:
      * svg/dom/SVGScriptElement/script-onerror-bubbling-expected.txt:
      * svg/dom/fuzz-path-parser-expected.txt:
      * svg/dom/path-parser-expected.txt:
      * svg/dom/points-parser-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136377 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8579b0b8
  11. 16 Nov, 2012 1 commit
    • mkwst@chromium.org's avatar
      Web Inspector: Move call stack generation out of bindings. · d643a8e1
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=101331
      
      Reviewed by Yury Semikhatsky.
      
      Currently, we generate stack traces for console messages at each call
      site. Bug 100650 has the end goal of moving all stack trace generation
      inside of the Inspector in order to ensure that we never send a console
      message without a stack trace if it's possible to generate one. This
      also ensures that we never generate unused call stacks.
      
      This patch is the first step in that direction, moving stack trace
      generation out of the Console bindings, and into either Console or
      InspectorConsoleAgent.
      
      No visible change in behavior should result; this refactoring should
      continue to pass all existing inspector tests.
      
      * bindings/js/JSConsoleCustom.cpp:
      (WebCore::JSConsole::profile):
      (WebCore::JSConsole::profileEnd):
          Adjust custom JSC Console bindings to drop call stack generation.
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateCallWith):
      * bindings/scripts/CodeGeneratorV8.pm:
      (GenerateCallWith):
          Drop call stack generation from JSC and V8 bindings.
      * bindings/scripts/CodeGeneratorGObject.pm:
          Skip timeEnd explicitly in these bindings; it used to include
          ScriptArguments, which autoskipped it. Now it doesn't, so it needs
          to be called out on its own.
      * bindings/v8/ScriptCallStackFactory.cpp:
      (WebCore::createScriptCallStackForConsole):
      (WebCore::createScriptCallStack):
      (WebCore):
      * bindings/v8/ScriptCallStackFactory.h:
      (WebCore):
          Add 'createScriptCallStack(ScriptState*, size_t)' to V8's
          ScriptCallStackFactory in order to match JCS' implementation.
          It simply delegates to 'createScriptCallStackForConsole', which
          now also accepts a 'maxStackSize' parameter.
      * bindings/v8/custom/V8ConsoleCustom.cpp:
      (WebCore::V8Console::traceCallback):
      (WebCore::V8Console::assertCallback):
      (WebCore::V8Console::profileCallback):
      (WebCore::V8Console::profileEndCallback):
          Adjust custom V8 bindings to drop call stack generation.
      * inspector/InspectorConsoleAgent.cpp:
      (WebCore::InspectorConsoleAgent::addMessageToConsole):
          With the eventual goal of getting rid of the call stack parameter
          entirely, this patch drops it from one version of
          'addMessageToConsole' (replacing it with ScriptState*), and creates
          a new version that only accepts a call stack. We should be able to
          migrate most (all?) external call sites over to the arguments
          version in future patches.
      (WebCore):
      (WebCore::InspectorConsoleAgent::count):
          Count takes 'ScriptState*' instead of a call stack, and generates
          the stack as needed.
      * inspector/InspectorConsoleAgent.h:
      (InspectorConsoleAgent):
      * inspector/InspectorConsoleInstrumentation.h:
      (WebCore::InspectorInstrumentation::addMessageToConsole):
      (WebCore):
      (WebCore::InspectorInstrumentation::consoleCount):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore):
      (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
      (WebCore::InspectorInstrumentation::consoleCountImpl):
      * inspector/InspectorInstrumentation.h:
      (InspectorInstrumentation):
          Changes the InspectorInstrumentation pipeline to match the
          InspectorConsoleAgent changes.
      * page/Console.cpp:
      (WebCore::Console::addMessage):
          We now (always) generate one frame of a stack trace in order to
          populate line numbers and caller URLs. If we need to print the whole
          trace here, we generate a full stack.
      (WebCore::Console::debug):
      (WebCore::Console::error):
      (WebCore::Console::info):
      (WebCore::Console::log):
      (WebCore::Console::warn):
      (WebCore::Console::dir):
      (WebCore::Console::dirxml):
      (WebCore::Console::clear):
      (WebCore::Console::trace):
      (WebCore::Console::assertCondition):
      (WebCore::Console::count):
      (WebCore::Console::markTimeline):
      (WebCore::Console::timeEnd):
      (WebCore::Console::timeStamp):
      (WebCore::Console::group):
      (WebCore::Console::groupCollapsed):
      (WebCore::Console::profile):
      (WebCore::Console::profileEnd):
          s/ScriptCallStack/ScriptState*/g. Also, printing the stack trace
          has been moved out of 'trace' and into 'addMessage'.
      * page/Console.h:
      (Console):
      * page/Console.idl:
          Drop the call stack, add the script state.
      * workers/WorkerContext.cpp:
      (WebCore::WorkerContext::addMessageToWorkerConsole):
          Use the new, explicitly call stacked addMessageToConsole. We'll kill
          this in a future patch.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134931 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d643a8e1
  12. 12 Nov, 2012 1 commit
  13. 06 Nov, 2012 1 commit
    • commit-queue@webkit.org's avatar
      Added console.clear() method · 8e628316
      commit-queue@webkit.org authored
      Web Inspector: add console.clear()
      https://bugs.webkit.org/show_bug.cgi?id=101021
      
      Patch by Andrey Lushnikov <lushnikov@google.com> on 2012-11-06
      Reviewed by Vsevolod Vlasov.
      
      Source/WebCore:
      
      Adds native implementation of console.clear
      
      Test: inspector/console/console-clear-function.html
      
      * English.lproj/localizedStrings.js: Adds 'Console was cleared' string
      * inspector/ConsoleMessage.cpp:
      (WebCore::messageTypeValue): Adds ClearMessageType
      * inspector/Inspector.json:
      * inspector/InspectorConsoleAgent.cpp:
      (WebCore::InspectorConsoleAgent::addMessageToConsole):
      * inspector/front-end/ConsoleMessage.js:
      (WebInspector.ConsoleMessageImpl.prototype._formatMessage): Display strategy for "clear" message
      * inspector/front-end/ConsoleModel.js:
      * inspector/front-end/inspector.css:
      (.console-info): Adds style for the 'console was cleared' message
      * page/Console.cpp: backend binging for console.clear()
      (WebCore::Console::clear):
      (WebCore):
      * page/Console.h:
      (Console):
      * page/Console.idl: Adds 'clear' message to protocol
      * page/ConsoleTypes.h:
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebChromeClient.mm:
      (stringForMessageType): Added ClearMessageType case to switch
      
      LayoutTests:
      
      * inspector/console/console-clear-function-expected.txt: Added.
      * inspector/console/console-clear-function.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133614 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e628316
  14. 30 Oct, 2012 1 commit
    • mkwst@chromium.org's avatar
      Web Inspector: Associate console messages with the requests that caused them. · d4c34b0e
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=99941
      
      Reviewed by Pavel Feldman.
      
      The inspector currently supports the concept of a request's "initiator"
      in order to add context to console messages that are generated in
      response to a specific request. The initiator is used as the message's
      anchor link iff a requestID is present, and no stack trace is present.
      
      Currently, this functionality is only exposed to three specific
      callsites: 'InspectorConsoleAgent::didFinishXHRLoading',
      'InspectorConsoleAgent::didReceiveResponse', and
      'InspectorConsoleAgent::didFailLoading'. This patch adds a generic
      mechanism to associate requests with console messages by passing the
      request's identifier through 'ScriptExecutionContext::addConsoleMessage'
      or 'Console::addMessage' when relevant.
      
      This patch should have no visible changes. It just installs some new
      piping, and adjusts the three methods mentioned above to use it.
      Existing tests shouldn't break.
      
      * dom/Document.cpp:
      (WebCore::Document::addMessage):
      * dom/Document.h:
      (Document):
          Add a 'requestIdentifier' parameter (defaulting to 0), and pipe it
          through to Console::addMessage.
      * dom/ScriptExecutionContext.cpp:
      (WebCore::ScriptExecutionContext::addConsoleMessage):
      * dom/ScriptExecutionContext.h:
      (ScriptExecutionContext):
          Add a 'requestIdentifier' parameter (defaulting to 0), and pipe it
          through to the subclass' addMessage method.
      * inspector/ConsoleMessage.cpp:
      (WebCore::ConsoleMessage::ConsoleMessage):
          Accept an unsigned long instead of a string, and move the conversion
          from WebCore request identifiers to Inspector request identifiers
          into ConsoleMessage.
      * inspector/ConsoleMessage.h:
      (ConsoleMessage):
          Add 'requestIdentifier' (defaulting to 0) to the
          ConsoleMessage constructor that accepts a ScriptCallStack (it was
          already part of the constructor that accepted a line number).
      * inspector/IdentifiersFactory.cpp:
      (WebCore::IdentifiersFactory::requestId):
          If the provided request identifier is 0, return an empty string.
          This simplifies the logic at the callsite.
      * inspector/InspectorConsoleAgent.cpp:
      (WebCore::InspectorConsoleAgent::addMessageToConsole):
          Add a 'requestIdentifier' parameter (defaulting to 0), and pipe it
          through to the 'ConsoleMessage' constructor after converting it to
          an internal identifier via 'IdentifiersFactor::requestId'.
      (WebCore::InspectorConsoleAgent::didFinishXHRLoading):
      (WebCore::InspectorConsoleAgent::didReceiveResponse):
      (WebCore::InspectorConsoleAgent::didFailLoading):
          Use the new 'requestIdentifier' parameter on addMessageToConsole
          rather than replicating the behavior in each of these three methods.
      * inspector/InspectorConsoleAgent.h:
      (InspectorConsoleAgent):
          Add a 'requestIdentifier' parameter (defaulting to 0).
      * inspector/InspectorConsoleInstrumentation.h:
      (WebCore::InspectorInstrumentation::addMessageToConsole):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore):
      (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
      * inspector/InspectorInstrumentation.h:
      (InspectorInstrumentation):
          Add a 'requestIdentifier' parameter (defaulting to 0), and pipe it
          through to lower levels of the stack.
      * page/Console.cpp:
      (WebCore::Console::addMessage):
      * page/Console.h:
      (Console):
          Add a 'requestIdentifier' parameter (defaulting to 0), and pipe it
          through to 'InspectorInstrumentation::addMessageToConsole'.
      * workers/WorkerContext.cpp:
      (WebCore::WorkerContext::addMessage):
      (WebCore::WorkerContext::addMessageToWorkerConsole):
      * workers/WorkerContext.h:
      (WorkerContext):
          Add a 'requestIdentifier' parameter (defaulting to 0), and pipe it
          through to 'InspectorInstrumentation::addMessageToConsole'.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132918 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4c34b0e
  15. 19 Apr, 2012 3 commits
    • vsevik@chromium.org's avatar
      Web Inspector: x-frame security errors logged when typing in the console are annoying. · 9cd1b015
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=81970
      
      Reviewed by Pavel Feldman.
      
      Parameter DoNotPauseOnExceptions in Runtime.evaluate() renamed to DoNotPauseOnExceptionsAndMuteConsole.
      Added this parameter to Runtime.callFunctionOn() and passed true in all call sites.
      Added this parameter to Debugger.evaluateOnCallFrame().
      Added a flag to console that mutes all messages unless they have ConsoleAPI message source.
      This flag is now temporarily set from InspectorRuntimeAgent and InspectorDebuggerAgent for certain injected source calls.
      
      * inspector/Inspector.json:
      * inspector/InspectorDebuggerAgent.cpp:
      (WebCore::asBool):
      (WebCore):
      (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
      * inspector/InspectorDebuggerAgent.h:
      (InspectorDebuggerAgent):
      * inspector/InspectorRuntimeAgent.cpp:
      (WebCore):
      (WebCore::setPauseOnExceptionsState):
      (WebCore::InspectorRuntimeAgent::evaluate):
      (WebCore::InspectorRuntimeAgent::callFunctionOn):
      (WebCore::InspectorRuntimeAgent::getProperties):
      * inspector/InspectorRuntimeAgent.h:
      (InspectorRuntimeAgent):
      * inspector/PageDebuggerAgent.cpp:
      (WebCore::PageDebuggerAgent::muteConsole):
      (WebCore):
      (WebCore::PageDebuggerAgent::unmuteConsole):
      * inspector/PageDebuggerAgent.h:
      (PageDebuggerAgent):
      * inspector/PageRuntimeAgent.cpp:
      (WebCore::PageRuntimeAgent::muteConsole):
      (WebCore):
      (WebCore::PageRuntimeAgent::unmuteConsole):
      * inspector/PageRuntimeAgent.h:
      (PageRuntimeAgent):
      * inspector/WorkerDebuggerAgent.cpp:
      (WebCore::WorkerDebuggerAgent::muteConsole):
      (WebCore):
      (WebCore::WorkerDebuggerAgent::unmuteConsole):
      * inspector/WorkerDebuggerAgent.h:
      (WorkerDebuggerAgent):
      * inspector/WorkerRuntimeAgent.cpp:
      (WebCore::WorkerRuntimeAgent::muteConsole):
      (WebCore):
      (WebCore::WorkerRuntimeAgent::unmuteConsole):
      * inspector/WorkerRuntimeAgent.h:
      (WorkerRuntimeAgent):
      * inspector/front-end/ConsoleView.js:
      (WebInspector.ConsoleView.prototype.evalInInspectedWindow):
      * inspector/front-end/DebuggerPresentationModel.js:
      (WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
      (WebInspector.PresentationCallFrame.prototype.evaluate):
      * inspector/front-end/RemoteObject.js:
      (WebInspector.RemoteObject.prototype.setPropertyValue):
      (WebInspector.RemoteObject.prototype.callFunction):
      (WebInspector.RemoteObject.prototype.callFunctionJSON):
      * inspector/front-end/WorkerManager.js:
      * page/Console.cpp:
      (WebCore::Console::addMessage):
      (WebCore::Console::warn):
      (WebCore):
      (WebCore::Console::mute):
      (WebCore::Console::unmute):
      * page/Console.h:
      (Console):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9cd1b015
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r114628. · e9bc8398
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/114628
      https://bugs.webkit.org/show_bug.cgi?id=84341
      
      Breaks EFL and GTK builds (Requested by pfeldman on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-19
      
      * inspector/Inspector.json:
      * inspector/InspectorDebuggerAgent.cpp:
      (WebCore):
      (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
      * inspector/InspectorDebuggerAgent.h:
      (InspectorDebuggerAgent):
      * inspector/InspectorRuntimeAgent.cpp:
      (WebCore::InspectorRuntimeAgent::evaluate):
      (WebCore::InspectorRuntimeAgent::callFunctionOn):
      (WebCore::InspectorRuntimeAgent::getProperties):
      * inspector/InspectorRuntimeAgent.h:
      (InspectorRuntimeAgent):
      * inspector/PageDebuggerAgent.cpp:
      * inspector/PageDebuggerAgent.h:
      (PageDebuggerAgent):
      * inspector/PageRuntimeAgent.cpp:
      * inspector/PageRuntimeAgent.h:
      (PageRuntimeAgent):
      * inspector/WorkerDebuggerAgent.cpp:
      * inspector/WorkerDebuggerAgent.h:
      (WorkerDebuggerAgent):
      * inspector/WorkerRuntimeAgent.cpp:
      * inspector/WorkerRuntimeAgent.h:
      (WorkerRuntimeAgent):
      * inspector/front-end/ConsoleView.js:
      (WebInspector.ConsoleView.prototype.evalInInspectedWindow):
      * inspector/front-end/DebuggerPresentationModel.js:
      (WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
      (WebInspector.PresentationCallFrame.prototype.evaluate):
      * inspector/front-end/RemoteObject.js:
      (WebInspector.RemoteObject.prototype.setPropertyValue):
      (WebInspector.RemoteObject.prototype.callFunction):
      (WebInspector.RemoteObject.prototype.callFunctionJSON):
      * inspector/front-end/WorkerManager.js:
      * page/Console.cpp:
      (WebCore):
      (WebCore::Console::addMessage):
      (WebCore::Console::warn):
      * page/Console.h:
      (Console):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9bc8398
    • vsevik@chromium.org's avatar
      Web Inspector: x-frame security errors logged when typing in the console are annoying. · e611e036
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=81970
      
      Reviewed by Pavel Feldman.
      
      Parameter DoNotPauseOnExceptions in Runtime.evaluate() renamed to DoNotPauseOnExceptionsAndMuteConsole.
      Added this parameter to Runtime.callFunctionOn() and passed true in all call sites.
      Added this parameter to Debugger.evaluateOnCallFrame().
      Added a flag to console that mutes all messages unless they have ConsoleAPI message source.
      This flag is now temporarily set from InspectorRuntimeAgent and InspectorDebuggerAgent for certain injected source calls.
      
      * inspector/Inspector.json:
      * inspector/InspectorDebuggerAgent.cpp:
      (WebCore::asBool):
      (WebCore):
      (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
      * inspector/InspectorDebuggerAgent.h:
      (InspectorDebuggerAgent):
      * inspector/InspectorRuntimeAgent.cpp:
      (WebCore):
      (WebCore::setPauseOnExceptionsState):
      (WebCore::InspectorRuntimeAgent::evaluate):
      (WebCore::InspectorRuntimeAgent::callFunctionOn):
      (WebCore::InspectorRuntimeAgent::getProperties):
      * inspector/InspectorRuntimeAgent.h:
      (InspectorRuntimeAgent):
      * inspector/PageDebuggerAgent.cpp:
      (WebCore::PageDebuggerAgent::muteConsole):
      (WebCore):
      (WebCore::PageDebuggerAgent::unmuteConsole):
      * inspector/PageDebuggerAgent.h:
      (PageDebuggerAgent):
      * inspector/PageRuntimeAgent.cpp:
      (WebCore::PageRuntimeAgent::muteConsole):
      (WebCore):
      (WebCore::PageRuntimeAgent::unmuteConsole):
      * inspector/PageRuntimeAgent.h:
      (PageRuntimeAgent):
      * inspector/WorkerDebuggerAgent.cpp:
      (WebCore::WorkerDebuggerAgent::muteConsole):
      (WebCore):
      (WebCore::WorkerDebuggerAgent::unmuteConsole):
      * inspector/WorkerDebuggerAgent.h:
      (WorkerDebuggerAgent):
      * inspector/WorkerRuntimeAgent.cpp:
      (WebCore::WorkerRuntimeAgent::muteConsole):
      (WebCore):
      (WebCore::WorkerRuntimeAgent::unmuteConsole):
      * inspector/WorkerRuntimeAgent.h:
      (WorkerRuntimeAgent):
      * inspector/front-end/ConsoleView.js:
      (WebInspector.ConsoleView.prototype.evalInInspectedWindow):
      * inspector/front-end/DebuggerPresentationModel.js:
      (WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
      (WebInspector.PresentationCallFrame.prototype.evaluate):
      * inspector/front-end/RemoteObject.js:
      (WebInspector.RemoteObject.prototype.setPropertyValue):
      (WebInspector.RemoteObject.prototype.callFunction):
      (WebInspector.RemoteObject.prototype.callFunctionJSON):
      * inspector/front-end/WorkerManager.js:
      * page/Console.cpp:
      (WebCore::Console::addMessage):
      (WebCore::Console::warn):
      (WebCore):
      (WebCore::Console::mute):
      (WebCore::Console::unmute):
      * page/Console.h:
      (Console):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e611e036
  16. 10 Feb, 2012 3 commits
    • haraken@chromium.org's avatar
      Replace [CustomArgumentHandling] with [CallWith=ScriptArguments|CallStack] · 98fd2b5b
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=78327
      
      Reviewed by Adam Barth.
      
      This patch replaces [CustomArgumentHandling] with [CallWith=ScriptArguments|CallStack],
      and removes [CustomArgumentHandling].
      
      Test: bindings/scripts/test/TestObj.idl
      
      * bindings/scripts/CodeGeneratorJS.pm: Modified to replace
      [CustomArgumentHandling] with [CallWith=ScriptArguments|CallStack].
      (GenerateCallWith):
      (GenerateParametersCheck):
      * bindings/scripts/CodeGeneratorV8.pm: Ditto.
      (GenerateCallWith):
      * bindings/scripts/CodeGeneratorGObject.pm: Ditto.
      (SkipFunction):
      (GenerateFunction):
      * bindings/scripts/CodeGeneratorCPP.pm: Simply removed [CustomArgumentHandling]
      from the skipped list. By this fix, CodeGeneratorCPP.pm will generate
      meaningless code for attributes or methods which was previously marked as
      [CustomArgumentHandling], but this change will be harmless.
      (ShouldSkipType):
      
      * bindings/v8/custom/V8ConsoleCustom.cpp: Changed the argument order.
      (WebCore::V8Console::assertCallback):
      * page/Console.cpp: Ditto.
      (WebCore::Console::assertCondition):
      (WebCore::Console::timeEnd):
      * page/Console.h: Ditto.
      (Console):
      
      * bindings/scripts/test/TestObj.idl: Added test cases for [CallWith=ScriptArguments|CallStack].
      
      * bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.
      (WebDOMTestObj::withScriptArgumentsAndCallStackAttribute):
      (WebDOMTestObj::setWithScriptArgumentsAndCallStackAttribute):
      (WebDOMTestObj::withScriptArgumentsAndCallStack):
      * bindings/scripts/test/CPP/WebDOMTestObj.h:
      * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
      (webkit_dom_test_obj_with_script_arguments_and_call_stack):
      (webkit_dom_test_obj_get_with_script_arguments_and_call_stack_attribute):
      (webkit_dom_test_obj_set_with_script_arguments_and_call_stack_attribute):
      (webkit_dom_test_obj_get_property):
      (webkit_dom_test_obj_class_init):
      * bindings/scripts/test/GObject/WebKitDOMTestObj.h:
      * bindings/scripts/test/JS/JSTestObj.cpp:
      (WebCore):
      (WebCore::jsTestObjWithScriptArgumentsAndCallStackAttribute):
      (WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute):
      (WebCore::jsTestObjPrototypeFunctionWithScriptArgumentsAndCallStack):
      * bindings/scripts/test/JS/JSTestObj.h:
      (WebCore):
      * bindings/scripts/test/ObjC/DOMTestObj.h:
      * bindings/scripts/test/ObjC/DOMTestObj.mm:
      (-[DOMTestObj withScriptArgumentsAndCallStackAttribute]):
      (-[DOMTestObj setWithScriptArgumentsAndCallStackAttribute:]):
      (-[DOMTestObj withScriptArgumentsAndCallStack]):
      * bindings/scripts/test/V8/V8TestObj.cpp:
      (WebCore::TestObjInternal::withScriptArgumentsAndCallStackAttributeAttrGetter):
      (TestObjInternal):
      (WebCore::TestObjInternal::withScriptArgumentsAndCallStackAttributeAttrSetter):
      (WebCore::TestObjInternal::withScriptArgumentsAndCallStackCallback):
      (WebCore):
      (WebCore::ConfigureV8TestObjTemplate):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107396 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98fd2b5b
    • haraken@chromium.org's avatar
      Unreviewed, rolling out r107368. · 94c28f0f
      haraken@chromium.org authored
      http://trac.webkit.org/changeset/107368
      https://bugs.webkit.org/show_bug.cgi?id=78327
      
      break GTK build
      
      * bindings/scripts/CodeGeneratorCPP.pm:
      (ShouldSkipType):
      * bindings/scripts/CodeGeneratorGObject.pm:
      (SkipFunction):
      (GenerateFunction):
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateCallWith):
      (GenerateParametersCheck):
      * bindings/scripts/CodeGeneratorV8.pm:
      (GenerateFunctionCallback):
      (GenerateCallWith):
      (GenerateFunctionCallString):
      * bindings/scripts/test/CPP/WebDOMTestObj.cpp:
      * bindings/scripts/test/CPP/WebDOMTestObj.h:
      * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
      (webkit_dom_test_obj_get_property):
      (webkit_dom_test_obj_class_init):
      * bindings/scripts/test/GObject/WebKitDOMTestObj.h:
      * bindings/scripts/test/JS/JSTestObj.cpp:
      (WebCore):
      (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
      * bindings/scripts/test/JS/JSTestObj.h:
      (WebCore):
      * bindings/scripts/test/ObjC/DOMTestObj.h:
      * bindings/scripts/test/ObjC/DOMTestObj.mm:
      (-[DOMTestObj customArgsAndException:]):
      * bindings/scripts/test/TestObj.idl:
      * bindings/scripts/test/V8/V8TestObj.cpp:
      (WebCore::TestObjInternal::customArgsAndExceptionCallback):
      (TestObjInternal):
      (WebCore):
      (WebCore::ConfigureV8TestObjTemplate):
      * bindings/v8/custom/V8ConsoleCustom.cpp:
      (WebCore::V8Console::assertCallback):
      * page/Console.cpp:
      (WebCore::Console::assertCondition):
      (WebCore::Console::timeEnd):
      * page/Console.h:
      (Console):
      * page/Console.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94c28f0f
    • haraken@chromium.org's avatar
      Replace [CustomArgumentHandling] with [CallWith=ScriptArguments|CallStack] · 88957f12
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=78327
      
      Reviewed by Adam Barth.
      
      This patch replaces [CustomArgumentHandling] with [CallWith=ScriptArguments|CallStack],
      and removes [CustomArgumentHandling].
      
      Test: bindings/scripts/test/TestObj.idl
      
      * bindings/scripts/CodeGeneratorJS.pm: Modified to replace
      [CustomArgumentHandling] with [CallWith=ScriptArguments|CallStack].
      (GenerateCallWith):
      (GenerateParametersCheck):
      * bindings/scripts/CodeGeneratorV8.pm: Ditto.
      (GenerateCallWith):
      * bindings/scripts/CodeGeneratorCPP.pm: Simply removed [CustomArgumentHandling]
      from the skipped list. By this fix, CodeGeneratorCPP.pm will generate
      meaningless code for attributes or methods which was previously marked as
      [CustomArgumentHandling], but this change will be harmless.
      (ShouldSkipType):
      * bindings/scripts/CodeGeneratorGObject.pm: Ditto.
      (SkipFunction):
      (GenerateFunction):
      
      * bindings/v8/custom/V8ConsoleCustom.cpp: Changed the argument order.
      (WebCore::V8Console::assertCallback):
      * page/Console.cpp: Ditto.
      (WebCore::Console::assertCondition):
      (WebCore::Console::timeEnd):
      * page/Console.h: Ditto.
      (Console):
      
      * bindings/scripts/test/TestObj.idl: Added test cases for [CallWith=ScriptArguments|CallStack].
      
      * bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.
      (WebDOMTestObj::withScriptArgumentsAndCallStackAttribute):
      (WebDOMTestObj::setWithScriptArgumentsAndCallStackAttribute):
      (WebDOMTestObj::withScriptArgumentsAndCallStack):
      * bindings/scripts/test/CPP/WebDOMTestObj.h:
      * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
      (webkit_dom_test_obj_with_script_arguments_and_call_stack):
      (webkit_dom_test_obj_get_with_script_arguments_and_call_stack_attribute):
      (webkit_dom_test_obj_set_with_script_arguments_and_call_stack_attribute):
      (webkit_dom_test_obj_get_property):
      (webkit_dom_test_obj_class_init):
      * bindings/scripts/test/GObject/WebKitDOMTestObj.h:
      * bindings/scripts/test/JS/JSTestObj.cpp:
      (WebCore):
      (WebCore::jsTestObjWithScriptArgumentsAndCallStackAttribute):
      (WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute):
      (WebCore::jsTestObjPrototypeFunctionWithScriptArgumentsAndCallStack):
      * bindings/scripts/test/JS/JSTestObj.h:
      (WebCore):
      * bindings/scripts/test/ObjC/DOMTestObj.h:
      * bindings/scripts/test/ObjC/DOMTestObj.mm:
      (-[DOMTestObj withScriptArgumentsAndCallStackAttribute]):
      (-[DOMTestObj setWithScriptArgumentsAndCallStackAttribute:]):
      (-[DOMTestObj withScriptArgumentsAndCallStack]):
      * bindings/scripts/test/V8/V8TestObj.cpp:
      (WebCore::TestObjInternal::withScriptArgumentsAndCallStackAttributeAttrGetter):
      (TestObjInternal):
      (WebCore::TestObjInternal::withScriptArgumentsAndCallStackAttributeAttrSetter):
      (WebCore::TestObjInternal::withScriptArgumentsAndCallStackCallback):
      (WebCore):
      (WebCore::ConfigureV8TestObjTemplate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107368 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88957f12
  17. 18 Jan, 2012 1 commit
    • vsevik@chromium.org's avatar
      Web Inspector: Unsafe cross origin access errors should show stack trace in console. · 53bb069e
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=73099
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      Test: http/tests/inspector/console-cross-origin-iframe-logging.html
      
      * bindings/v8/V8Proxy.cpp:
      (WebCore::V8Proxy::reportUnsafeAccessTo):
      * dom/ScriptExecutionContext.cpp:
      (WebCore::ScriptExecutionContext::addConsoleMessage):
      * dom/ScriptExecutionContext.h:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::shouldAllowNavigation):
      * page/Console.cpp:
      (WebCore::Console::addMessage):
      * page/Console.h:
      * page/DOMWindow.cpp:
      (WebCore::PostMessageTimer::PostMessageTimer):
      (WebCore::PostMessageTimer::stackTrace):
      (WebCore::DOMWindow::postMessage):
      (WebCore::DOMWindow::postMessageTimerFired):
      (WebCore::DOMWindow::printErrorMessage):
      
      LayoutTests:
      
      * http/tests/inspector/console-cross-origin-iframe-logging-expected.txt: Added.
      * http/tests/inspector/console-cross-origin-iframe-logging.html: Added.
      * http/tests/inspector/resources/cross-origin-iframe.html: Added.
      * platform/chromium/http/tests/inspector/console-cross-origin-iframe-logging-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105310 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      53bb069e
  18. 12 Jan, 2012 1 commit
    • vsevik@chromium.org's avatar
      Make default console messages line numbers consistent. · 0c3bdd92
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=74075
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      Added default values for Console::addMessage sourceURL, lineNumber and
      callStack parameters, moved lineNumber after sourceURL.
      Made virtual method ScriptExecutionContext::addMessage private
      Added default values to ScriptExecutionContext::AddConsoleMessage sourceURL, lineNumber and
      callStack parameters, moved lineNumber after sourceURL.
      Reorder ScriptExecutionContext::logExceptionToConsole parameters, move lineNumber after sourceURL.
      Reordered sourceURL and lineNumber parameters in inspector methods.
      Made all calls to Console::addMessage() pass 0 as lineNumber by default (i.e. when line number is unknown / irrelevant).
      Unset line numbers are not printed to console in QT now.
      
      * bindings/js/JSCustomXPathNSResolver.cpp:
      (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
      * bindings/v8/custom/V8CustomXPathNSResolver.cpp:
      (WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
      * dom/Document.cpp:
      (WebCore::Document::logExceptionToConsole):
      (WebCore::Document::addMessage):
      * dom/Document.h:
      * dom/ScriptExecutionContext.cpp:
      (WebCore::ScriptExecutionContext::AddConsoleMessageTask::performTask):
      (WebCore::ScriptExecutionContext::reportException):
      (WebCore::ScriptExecutionContext::addConsoleMessage):
      * dom/ScriptExecutionContext.h:
      * dom/UIEvent.cpp:
      (WebCore::UIEvent::warnDeprecatedLayerXYUsage):
      * dom/ViewportArguments.cpp:
      (WebCore::reportViewportWarning):
      * html/HTMLFormElement.cpp:
      (WebCore::HTMLFormElement::validateInteractively):
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore::WebGLRenderingContext::printWarningToConsole):
      * inspector/ConsoleMessage.cpp:
      (WebCore::ConsoleMessage::ConsoleMessage):
      * inspector/ConsoleMessage.h:
      * inspector/InspectorConsoleAgent.cpp:
      (WebCore::InspectorConsoleAgent::enable):
      (WebCore::InspectorConsoleAgent::addMessageToConsole):
      (WebCore::InspectorConsoleAgent::stopTiming):
      (WebCore::InspectorConsoleAgent::count):
      (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):
      * inspector/InspectorConsoleAgent.h:
      * inspector/InspectorConsoleInstrumentation.h:
      (WebCore::InspectorInstrumentation::addMessageToConsole):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
      * inspector/InspectorInstrumentation.h:
      * inspector/InspectorProfilerAgent.cpp:
      (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
      (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::checkIfDisplayInsecureContent):
      (WebCore::FrameLoader::checkIfRunInsecureContent):
      (WebCore::FrameLoader::reportLocalLoadFailed):
      (WebCore::FrameLoader::shouldAllowNavigation):
      * loader/MainResourceLoader.cpp:
      (WebCore::MainResourceLoader::didReceiveResponse):
      * loader/appcache/ApplicationCacheGroup.cpp:
      (WebCore::ApplicationCacheGroup::didReceiveResponse):
      (WebCore::ApplicationCacheGroup::didFinishLoading):
      (WebCore::ApplicationCacheGroup::didFail):
      (WebCore::ApplicationCacheGroup::didReceiveManifestResponse):
      (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
      (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::printAccessDeniedMessage):
      * page/Console.cpp:
      (WebCore::Console::addMessage):
      (WebCore::Console::groupEnd):
      * page/Console.h:
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::postMessageTimerFired):
      (WebCore::DOMWindow::printErrorMessage):
      * storage/AbstractDatabase.cpp:
      (WebCore::AbstractDatabase::logErrorMessage):
      * svg/SVGDocumentExtensions.cpp:
      (WebCore::reportMessage):
      * websockets/WebSocket.cpp:
      (WebCore::WebSocket::connect):
      * websockets/WebSocketChannel.cpp:
      (WebCore::WebSocketChannel::fail):
      (WebCore::WebSocketChannel::didFailSocketStream):
      * workers/DefaultSharedWorkerRepository.cpp:
      (WebCore::postConsoleMessageTask):
      (WebCore::SharedWorkerProxy::postConsoleMessageToWorkerObject):
      * workers/SharedWorkerContext.cpp:
      (WebCore::SharedWorkerContext::logExceptionToConsole):
      * workers/SharedWorkerContext.h:
      * workers/WorkerContext.cpp:
      (WebCore::WorkerContext::logExceptionToConsole):
      (WebCore::WorkerContext::addMessage):
      (WebCore::WorkerContext::addMessageToWorkerConsole):
      * workers/WorkerContext.h:
      * workers/WorkerMessagingProxy.cpp:
      (WebCore::postConsoleMessageTask):
      * xml/XSLTProcessorLibxslt.cpp:
      (WebCore::XSLTProcessor::parseErrorFunc):
      * xml/XSLTProcessorQt.cpp:
      (WebCore::XSLTMessageHandler::handleMessage):
      
      Source/WebKit/chromium:
      
      Unset line numbers are not printed to console now.
      
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::addMessageToConsole):
      
      Source/WebKit/qt:
      
      Unset line numbers are not printed to console now.
      
      * Api/qwebpage.cpp:
      (QWebPage::javaScriptConsoleMessage):
      
      Tools:
      
      Unset line numbers are not printed to console now.
      Added Source/WebCore/inspector to efl DumpRenderTree include path.
      
      * DumpRenderTree/chromium/WebViewHost.cpp:
      (WebViewHost::didAddMessageToConsole):
      * DumpRenderTree/efl/CMakeLists.txt:
      * DumpRenderTree/efl/DumpRenderTreeView.cpp:
      (onConsoleMessage):
      * DumpRenderTree/gtk/DumpRenderTree.cpp:
      (webViewConsoleMessage):
      * DumpRenderTree/mac/UIDelegate.mm:
      (-[UIDelegate webView:addMessageToConsole:withSource:]):
      * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
      (WebCore::WebPage::javaScriptConsoleMessage):
      * DumpRenderTree/win/UIDelegate.cpp:
      (UIDelegate::webViewAddMessageToConsole):
      * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
      (LayoutWebViewEventHandler::OnConsoleMessageEvent):
      
      LayoutTests:
      
      Removed unset line numbers in console messages from test expectations.
      
      * fast/canvas/svg-taint-expected.txt:
      * fast/dom/Window/window-xy-properties-expected.txt:
      * fast/events/init-events-expected.txt:
      * fast/events/mouse-relative-position-expected.txt:
      * fast/events/mouseclick-target-and-positioning-expected.txt:
      * fast/events/simulated-click-coords-expected.txt:
      * fast/forms/interactive-validation-prevented-expected.txt:
      * fast/workers/storage/open-database-creation-callback-sync-expected.txt:
      * fast/workers/storage/open-database-set-empty-version-sync-expected.txt:
      * fast/xmlhttprequest/xmlhttprequest-no-file-access-expected.txt:
      * fast/xmlhttprequest/xmlhttprequest-responsetype-before-open-sync-request-expected.txt:
      * fast/xmlhttprequest/xmlhttprequest-responsetype-sync-request-expected.txt:
      * fast/xpath/nsresolver-bad-object-expected.txt:
      * http/tests/appcache/local-content-expected.txt:
      * http/tests/canvas/philip/tests/security.drawImage.canvas-expected.txt:
      * http/tests/canvas/philip/tests/security.drawImage.image-expected.txt:
      * http/tests/canvas/philip/tests/security.pattern.canvas.fillStyle-expected.txt:
      * http/tests/canvas/philip/tests/security.pattern.canvas.strokeStyle-expected.txt:
      * http/tests/canvas/philip/tests/security.pattern.cross-expected.txt:
      * http/tests/canvas/philip/tests/security.pattern.image.fillStyle-expected.txt:
      * http/tests/canvas/philip/tests/security.pattern.image.strokeStyle-expected.txt:
      * http/tests/eventsource/eventsource-bad-mime-type-expected.txt:
      * http/tests/eventsource/eventsource-content-type-charset-expected.txt:
      * http/tests/history/cross-origin-replace-history-object-expected.txt:
      * http/tests/inspector/console-xhr-logging-expected.txt:
      * http/tests/inspector/network-preflight-options-expected.txt:
      * http/tests/inspector/network/x-frame-options-deny-expected.txt:
      * http/tests/misc/bubble-drag-events-expected.txt:
      * http/tests/misc/drag-over-iframe-invalid-source-crash-expected.txt:
      * http/tests/misc/iframe-invalid-source-crash-expected.txt:
      * http/tests/misc/image-blocked-src-change-expected.txt:
      * http/tests/misc/image-blocked-src-no-change-expected.txt:
      * http/tests/misc/unloadable-script-expected.txt:
      * http/tests/plugins/cross-frame-object-access-expected.txt:
      * http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
      * http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
      * http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
      * http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
      * http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
      * http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
      * http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
      * http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
      * http/tests/security/canvas-remote-read-data-url-svg-image-expected.txt:
      * http/tests/security/canvas-remote-read-redirect-to-remote-image-expected.txt:
      * http/tests/security/canvas-remote-read-remote-image-blocked-no-crossorigin-expected.txt:
      * http/tests/security/canvas-remote-read-remote-image-blocked-then-allowed-expected.txt:
      * http/tests/security/canvas-remote-read-remote-image-expected.txt:
      * http/tests/security/canvas-remote-read-remote-image-redirect-expected.txt:
      * http/tests/security/canvas-remote-read-svg-image-expected.txt:
      * http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning-expected.txt:
      * http/tests/security/contentSecurityPolicy/connect-src-eventsource-blocked-expected.txt:
      * http/tests/security/contentSecurityPolicy/connect-src-websocket-blocked-expected.txt:
      * http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-blocked-expected.txt:
      * http/tests/security/contentSecurityPolicy/default-src-inline-blocked-expected.txt:
      * http/tests/security/contentSecurityPolicy/directive-parsing-01-expected.txt:
      * http/tests/security/contentSecurityPolicy/directive-parsing-02-expected.txt:
      * http/tests/security/contentSecurityPolicy/directive-parsing-03-expected.txt:
      * http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked-expected.txt:
      * http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked-expected.txt:
      * http/tests/security/contentSecurityPolicy/frame-src-blocked-expected.txt:
      * http/tests/security/contentSecurityPolicy/image-blocked-expected.txt:
      * http/tests/security/contentSecurityPolicy/inline-script-blocked-expected.txt:
      * http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy-expected.txt:
      * http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt:
      * http/tests/security/contentSecurityPolicy/inline-style-attribute-blocked-expected.txt:
      * http/tests/security/contentSecurityPolicy/inline-style-blocked-expected.txt:
      * http/tests/security/contentSecurityPolicy/javascript-url-allowed-expected.txt:
      * http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt:
      * http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:
      * http/tests/security/contentSecurityPolicy/object-src-no-url-blocked-expected.txt:
      * http/tests/security/contentSecurityPolicy/object-src-none-blocked-expected.txt:
      * http/tests/security/contentSecurityPolicy/report-only-expected.txt:
      * http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt:
      * http/tests/security/contentSecurityPolicy/report-uri-expected.txt:
      * http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt:
      * http/tests/security/contentSecurityPolicy/script-loads-with-img-src-expected.txt:
      * http/tests/security/contentSecurityPolicy/script-src-in-iframe-expected.txt:
      * http/tests/security/contentSecurityPolicy/script-src-none-expected.txt:
      * http/tests/security/contentSecurityPolicy/script-src-none-inline-event-expected.txt:
      * http/tests/security/contentSecurityPolicy/script-src-redirect-expected.txt:
      * http/tests/security/contentSecurityPolicy/script-src-self-blocked-01-expected.txt:
      * http/tests/security/contentSecurityPolicy/script-src-self-blocked-02-expected.txt:
      * http/tests/security/contentSecurityPolicy/script-src-self-blocked-03-expected.txt:
      * http/tests/security/contentSecurityPolicy/source-list-parsing-expected.txt:
      * http/tests/security/contentSecurityPolicy/style-blocked-expected.txt:
      * http/tests/security/contentSecurityPolicy/worker-connect-src-blocked-expected.txt:
      * http/tests/security/contentSecurityPolicy/worker-script-src-expected.txt:
      * http/tests/security/contentSecurityPolicy/xsl-blocked-expected.txt:
      * http/tests/security/contentSecurityPolicy/xsl-img-blocked-expected.txt:
      * http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1-expected.txt:
      * http/tests/security/cross-frame-access-call-expected.txt:
      * http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt:
      * http/tests/security/cross-frame-access-child-explicit-domain-expected.txt:
      * http/tests/security/cross-frame-access-custom-expected.txt:
      * http/tests/security/cross-frame-access-delete-expected.txt:
      * http/tests/security/cross-frame-access-enumeration-expected.txt:
      * http/tests/security/cross-frame-access-first-time-expected.txt:
      * http/tests/security/cross-frame-access-get-custom-property-cached-expected.txt:
      * http/tests/security/cross-frame-access-get-expected.txt:
      * http/tests/security/cross-frame-access-history-get-expected.txt:
      * http/tests/security/cross-frame-access-history-put-expected.txt:
      * http/tests/security/cross-frame-access-location-get-expected.txt:
      * http/tests/security/cross-frame-access-location-put-expected.txt:
      * http/tests/security/cross-frame-access-name-getter-expected.txt:
      * http/tests/security/cross-frame-access-object-getPrototypeOf-expected.txt:
      * http/tests/security/cross-frame-access-object-prototype-expected.txt:
      * http/tests/security/cross-frame-access-parent-explicit-domain-expected.txt:
      * http/tests/security/cross-frame-access-port-expected.txt:
      * http/tests/security/cross-frame-access-protocol-expected.txt:
      * http/tests/security/cross-frame-access-protocol-explicit-domain-expected.txt:
      * http/tests/security/cross-frame-access-selection-expected.txt:
      * http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
      * http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
      * http/tests/security/filesystem-iframe-from-remote-expected.txt:
      * http/tests/security/frame-loading-via-document-write-expected.txt:
      * http/tests/security/frameNavigation/not-opener-expected.txt:
      * http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt:
      * http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation-expected.txt:
      * http/tests/security/img-with-failed-cors-check-fails-to-load-expected.txt:
      * http/tests/security/isolatedWorld/cross-origin-xhr-expected.txt:
      * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt:
      * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
      * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
      * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
      * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
      * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
      * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
      * http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
      * http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
      * http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt:
      * http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
      * http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
      * http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt:
      * http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-subframe-expected.txt:
      * http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-window-open-expected.txt:
      * http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-subframe-expected.txt:
      * http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-window-open-expected.txt:
      * http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt:
      * http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt:
      * http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt:
      * http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt:
      * http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt:
      * http/tests/security/listener/xss-window-onclick-shortcut-expected.txt:
      * http/tests/security/local-CSS-from-remote-expected.txt:
      * http/tests/security/local-JavaScript-from-remote-expected.txt:
      * http/tests/security/local-iFrame-from-remote-expected.txt:
      * http/tests/security/local-image-from-remote-expected.txt:
      * http/tests/security/local-video-poster-from-remote-expected.txt:
      * http/tests/security/local-video-source-from-remote-expected.txt:
      * http/tests/security/local-video-src-from-remote-expected.txt:
      * http/tests/security/mixedContent/insecure-css-in-iframe-expected.txt:
      * http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt:
      * http/tests/security/mixedContent/insecure-iframe-in-main-frame-expected.txt:
      * http/tests/security/mixedContent/insecure-image-in-main-frame-expected.txt:
      * http/tests/security/mixedContent/insecure-script-in-iframe-expected.txt:
      * http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame-expected.txt:
      * http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe-expected.txt:
      * http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame-expected.txt:
      * http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe-expected.txt:
      * http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt:
      * http/tests/security/postMessage/target-origin-expected.txt:
      * http/tests/security/redirect-BLOCKED-to-localURL-expected.txt:
      * http/tests/security/sandboxed-iframe-modify-self-expected.txt:
      * http/tests/security/sandboxed-iframe-origin-add-expected.txt:
      * http/tests/security/sandboxed-iframe-origin-remove-expected.txt:
      * http/tests/security/text-track-crossorigin-expected.txt:
      * http/tests/security/view-source-no-javascript-url-expected.txt:
      * http/tests/security/xss-DENIED-assign-location-hash-expected.txt:
      * http/tests/security/xss-DENIED-assign-location-host-expected.txt:
      * http/tests/security/xss-DENIED-assign-location-hostname-expected.txt:
      * http/tests/security/xss-DENIED-assign-location-href-javascript-expected.txt:
      * http/tests/security/xss-DENIED-assign-location-nonstandardProperty-expected.txt:
      * http/tests/security/xss-DENIED-assign-location-pathname-expected.txt:
      * http/tests/security/xss-DENIED-assign-location-protocol-expected.txt:
      * http/tests/security/xss-DENIED-assign-location-reload-expected.txt:
      * http/tests/security/xss-DENIED-assign-location-search-expected.txt:
      * http/tests/security/xss-DENIED-document-baseURI-javascript-expected.txt:
      * http/tests/security/xss-DENIED-document-baseURI-javascript-with-spaces-expected.txt:
      * http/tests/security/xss-DENIED-frame-name-expected.txt:
      * http/tests/security/xss-DENIED-getSVGDocument-iframe-expected.txt:
      * http/tests/security/xss-DENIED-getSVGDocument-object-expected.txt:
      * http/tests/security/xss-DENIED-htmlelelment-with-iframe-proto-expected.txt:
      * http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
      * http/tests/security/xss-DENIED-invalid-domain-change-expected.txt:
      * http/tests/security/xss-DENIED-javascript-with-spaces-expected.txt:
      * http/tests/security/xss-DENIED-method-with-iframe-proto-expected.txt:
      * http/tests/security/xss-DENIED-sandboxed-iframe-expected.txt:
      * http/tests/security/xss-DENIED-synchronous-form-expected.txt:
      * http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url-expected.txt:
      * http/tests/security/xss-DENIED-window-open-javascript-url-expected.txt:
      * http/tests/security/xss-DENIED-window-open-javascript-url-with-spaces-expected.txt:
      * http/tests/security/xss-DENIED-window-open-parent-expected.txt:
      * http/tests/security/xss-DENIED-xml-external-entity-expected.txt:
      * http/tests/security/xss-DENIED-xsl-document-expected.txt:
      * http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt:
      * http/tests/security/xss-DENIED-xsl-external-entity-expected.txt:
      * http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt:
      * http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-expected.txt:
      * http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char-expected.txt:
      * http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL-expected.txt:
      * http/tests/security/xssAuditor/anchor-url-dom-write-location2-expected.txt:
      * http/tests/security/xssAuditor/base-href-control-char-expected.txt:
      * http/tests/security/xssAuditor/base-href-expected.txt:
      * http/tests/security/xssAuditor/base-href-null-char-expected.txt:
      * http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt:
      * http/tests/security/xssAuditor/cookie-injection-expected.txt:
      * http/tests/security/xssAuditor/dom-write-URL-expected.txt:
      * http/tests/security/xssAuditor/dom-write-location-expected.txt:
      * http/tests/security/xssAuditor/dom-write-location-inline-event-expected.txt:
      * http/tests/security/xssAuditor/dom-write-location-javascript-URL-expected.txt:
      * http/tests/security/xssAuditor/embed-tag-code-attribute-2-expected.txt:
      * http/tests/security/xssAuditor/embed-tag-code-attribute-expected.txt:
      * http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
      * http/tests/security/xssAuditor/embed-tag-expected.txt:
      * http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt:
      * http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
      * http/tests/security/xssAuditor/form-action-expected.txt:
      * http/tests/security/xssAuditor/full-block-base-href-expected.txt:
      * http/tests/security/xssAuditor/full-block-get-from-iframe-expected.txt:
      * http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt:
      * http/tests/security/xssAuditor/full-block-iframe-no-inherit-expected.txt:
      * http/tests/security/xssAuditor/full-block-javascript-link-expected.txt:
      * http/tests/security/xssAuditor/full-block-link-onclick-expected.txt:
      * http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
      * http/tests/security/xssAuditor/full-block-post-from-iframe-expected.txt:
      * http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
      * http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt:
      * http/tests/security/xssAuditor/get-from-iframe-expected.txt:
      * http/tests/security/xssAuditor/iframe-injection-expected.txt:
      * http/tests/security/xssAuditor/iframe-javascript-url-expected.txt:
      * http/tests/security/xssAuditor/iframe-javascript-url-more-encoding-expected.txt:
      * http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode-expected.txt:
      * http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2-expected.txt:
      * http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3-expected.txt:
      * http/tests/security/xssAuditor/iframe-javascript-url-url-encoded-expected.txt:
      * http/tests/security/xssAuditor/img-onerror-accented-char-expected.txt:
      * http/tests/security/xssAuditor/img-onerror-non-ASCII-char-default-encoding-expected.txt:
      * http/tests/security/xssAuditor/img-onerror-non-ASCII-char-expected.txt:
      * http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-default-encoding-expected.txt:
      * http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-expected.txt:
      * http/tests/security/xssAuditor/inline-event-HTML-entities-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-HTML-entities-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-HTML-entities-named-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-ampersand-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-control-char-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-null-char-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-one-plus-one-expected.txt:
      * http/tests/security/xssAuditor/javascript-link-url-encoded-expected.txt:
      * http/tests/security/xssAuditor/link-onclick-ampersand-expected.txt:
      * http/tests/security/xssAuditor/link-onclick-control-char-expected.txt:
      * http/tests/security/xssAuditor/link-onclick-entities-expected.txt:
      * http/tests/security/xssAuditor/link-onclick-expected.txt:
      * http/tests/security/xssAuditor/link-onclick-null-char-expected.txt:
      * http/tests/security/xssAuditor/link-opens-new-window-expected.txt:
      * http/tests/security/xssAuditor/malformed-HTML-expected.txt:
      * http/tests/security/xssAuditor/malformed-xss-protection-header-expected.txt:
      * http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url-expected.txt:
      * http/tests/security/xssAuditor/meta-tag-http-refresh-x-frame-options-expected.txt:
      * http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
      * http/tests/security/xssAuditor/object-embed-tag-expected.txt:
      * http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
      * http/tests/security/xssAuditor/object-tag-expected.txt:
      * http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt:
      * http/tests/security/xssAuditor/open-attribute-body-expected.txt:
      * http/tests/security/xssAuditor/open-event-handler-iframe-expected.txt:
      * http/tests/security/xssAuditor/post-from-iframe-expected.txt:
      * http/tests/security/xssAuditor/property-escape-comment-expected.txt:
      * http/tests/security/xssAuditor/property-escape-entity-expected.txt:
      * http/tests/security/xssAuditor/property-escape-expected.txt:
      * http/tests/security/xssAuditor/property-escape-long-expected.txt:
      * http/tests/security/xssAuditor/property-escape-quote-expected.txt:
      * http/tests/security/xssAuditor/script-tag-addslashes-backslash-expected.txt:
      * http/tests/security/xssAuditor/script-tag-addslashes-double-quote-expected.txt:
      * http/tests/security/xssAuditor/script-tag-addslashes-null-char-expected.txt:
      * http/tests/security/xssAuditor/script-tag-addslashes-single-quote-expected.txt:
      * http/tests/security/xssAuditor/script-tag-control-char-expected.txt:
      * http/tests/security/xssAuditor/script-tag-convoluted-expected.txt:
      * http/tests/security/xssAuditor/script-tag-entities-expected.txt:
      * http/tests/security/xssAuditor/script-tag-expected.txt:
      * http/tests/security/xssAuditor/script-tag-null-char-expected.txt:
      * http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt:
      * http/tests/security/xssAuditor/script-tag-post-control-char-expected.txt:
      * http/tests/security/xssAuditor/script-tag-post-expected.txt:
      * http/tests/security/xssAuditor/script-tag-post-null-char-expected.txt:
      * http/tests/security/xssAuditor/script-tag-redirect-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode-surrogate-pair-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode2-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode3-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode4-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-16bit-unicode5-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-callbacks-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-fancy-unicode-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-invalid-url-encoding-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-control-char-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-data-url-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-double-quote-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-no-quote-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-null-char-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-relative-scheme-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-source-unterminated-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-three-times-url-encoded-16bit-unicode-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-trailing-comment-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-trailing-comment2-expected.txt:
      * http/tests/security/xssAuditor/script-tag-with-trailing-comment3-expected.txt:
      * http/tests/security/xssAuditor/xss-filter-bypass-big5-expected.txt:
      * http/tests/security/xssAuditor/xss-filter-bypass-long-string-expected.txt:
      * http/tests/security/xssAuditor/xss-filter-bypass-sjis-expected.txt:
      * http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txt:
      * http/tests/websocket/tests/hixie76/bad-handshake-crash-expected.txt:
      * http/tests/websocket/tests/hixie76/bad-sub-protocol-control-chars-expected.txt:
      * http/tests/websocket/tests/hixie76/bad-sub-protocol-empty-expected.txt:
      * http/tests/websocket/tests/hixie76/bad-sub-protocol-non-ascii-expected.txt:
      * http/tests/websocket/tests/hixie76/close-before-open-expected.txt:
      * http/tests/websocket/tests/hixie76/frame-length-overflow-expected.txt:
      * http/tests/websocket/tests/hixie76/handshake-error-expected.txt:
      * http/tests/websocket/tests/hixie76/handshake-fail-by-cross-origin-expected.txt:
      * http/tests/websocket/tests/hixie76/handshake-fail-by-maxlength-expected.txt:
      * http/tests/websocket/tests/hixie76/handshake-fail-by-no-connection-header-expected.txt:
      * http/tests/websocket/tests/hixie76/handshake-fail-by-no-cr-expected.txt:
      * http/tests/websocket/tests/hixie76/handshake-fail-by-no-upgrade-header-expected.txt:
      * http/tests/websocket/tests/hixie76/handshake-fail-by-prepended-null-expected.txt:
      * http/tests/websocket/tests/hixie76/handshake-fail-by-sub-protocol-mismatch-expected.txt:
      * http/tests/websocket/tests/hixie76/long-invalid-header-expected.txt:
      * http/tests/websocket/tests/hixie76/url-parsing-expected.txt:
      * http/tests/websocket/tests/hixie76/url-with-query-for-no-query-expected.txt:
      * http/tests/websocket/tests/hixie76/websocket-event-target-expected.txt:
      * http/tests/websocket/tests/hybi/bad-handshake-crash-expected.txt:
      * http/tests/websocket/tests/hybi/bad-sub-protocol-control-chars-expected.txt:
      * http/tests/websocket/tests/hybi/bad-sub-protocol-empty-expected.txt:
      * http/tests/websocket/tests/hybi/bad-sub-protocol-non-ascii-expected.txt:
      * http/tests/websocket/tests/hybi/broken-utf8-expected.txt:
      * http/tests/websocket/tests/hybi/close-before-open-expected.txt:
      * http/tests/websocket/tests/hybi/close-code-and-reason-expected.txt:
      * http/tests/websocket/tests/hybi/close-expected.txt:
      * http/tests/websocket/tests/hybi/fragmented-control-frame-expected.txt:
      * http/tests/websocket/tests/hybi/handshake-error-expected.txt:
      * http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt:
      * http/tests/websocket/tests/hybi/handshake-fail-by-maxlength-expected.txt:
      * http/tests/websocket/tests/hybi/handshake-fail-by-no-accept-header-expected.txt:
      * http/tests/websocket/tests/hybi/handshake-fail-by-no-connection-header-expected.txt:
      * http/tests/websocket/tests/hybi/handshake-fail-by-no-cr-expected.txt:
      * http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header-expected.txt:
      * http/tests/websocket/tests/hybi/handshake-fail-by-prepended-null-expected.txt:
      * http/tests/websocket/tests/hybi/handshake-fail-by-wrong-accept-header-expected.txt:
      * http/tests/websocket/tests/hybi/interleaved-fragments-expected.txt:
      * http/tests/websocket/tests/hybi/invalid-continuation-expected.txt:
      * http/tests/websocket/tests/hybi/invalid-subprotocol-characters-expected.txt:
      * http/tests/websocket/tests/hybi/invalid-subprotocols-expected.txt:
      * http/tests/websocket/tests/hybi/long-control-frame-expected.txt:
      * http/tests/websocket/tests/hybi/long-invalid-header-expected.txt:
      * http/tests/websocket/tests/hybi/reserved-bits-expected.txt:
      * http/tests/websocket/tests/hybi/reserved-opcodes-expected.txt:
      * http/tests/websocket/tests/hybi/send-file-blob-fail-expected.txt:
      * http/tests/websocket/tests/hybi/too-long-payload-expected.txt:
      * http/tests/websocket/tests/hybi/url-parsing-expected.txt:
      * http/tests/websocket/tests/hybi/websocket-event-target-expected.txt:
      * http/tests/websocket/tests/hybi/workers/close-code-and-reason-expected.txt:
      * http/tests/websocket/tests/hybi/workers/close-expected.txt:
      * http/tests/xmlhttprequest/access-control-basic-denied-expected.txt:
      * http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache-expected.txt:
      * http/tests/xmlhttprequest/access-control-basic-get-fail-non-simple-expected.txt:
      * http/tests/xmlhttprequest/access-control-basic-non-simple-deny-cached-expected.txt:
      * http/tests/xmlhttprequest/access-control-basic-post-fail-non-simple-content-type-expected.txt:
      * http/tests/xmlhttprequest/access-control-basic-whitelist-response-headers-expected.txt:
      * http/tests/xmlhttprequest/access-control-preflight-async-header-denied-expected.txt:
      * http/tests/xmlhttprequest/access-control-preflight-async-method-denied-expected.txt:
      * http/tests/xmlhttprequest/access-control-preflight-async-not-supported-expected.txt:
      * http/tests/xmlhttprequest/access-control-preflight-sync-header-denied-expected.txt:
      * http/tests/xmlhttprequest/access-control-preflight-sync-method-denied-expected.txt:
      * http/tests/xmlhttprequest/access-control-preflight-sync-not-supported-expected.txt:
      * http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-expected.txt:
      * http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard-expected.txt:
      * http/tests/xmlhttprequest/cross-origin-no-authorization-expected.txt:
      * http/tests/xmlhttprequest/cross-origin-no-credential-prompt-expected.txt:
      * http/tests/xmlhttprequest/cross-site-denied-response-expected.txt:
      * http/tests/xmlhttprequest/cross-site-denied-response-sync-2-expected.txt:
      * http/tests/xmlhttprequest/cross-site-denied-response-sync-expected.txt:
      * http/tests/xmlhttprequest/get-dangerous-headers-expected.txt:
      * http/tests/xmlhttprequest/getResponseHeader-expected.txt:
      * http/tests/xmlhttprequest/onerror-event-expected.txt:
      * http/tests/xmlhttprequest/origin-whitelisting-https-expected.txt:
      * http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with-subdomains-expected.txt:
      * http/tests/xmlhttprequest/origin-whitelisting-removal-expected.txt:
      * http/tests/xmlhttprequest/set-dangerous-headers-expected.txt:
      * http/tests/xmlhttprequest/simple-cross-origin-denied-events-expected.txt:
      * http/tests/xmlhttprequest/simple-cross-origin-denied-events-post-expected.txt:
      * http/tests/xmlhttprequest/simple-cross-origin-denied-events-post-sync-expected.txt:
      * http/tests/xmlhttprequest/simple-cross-origin-denied-events-sync-expected.txt:
      * http/tests/xmlhttprequest/simple-cross-origin-progress-events-expected.txt:
      * http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple-expected.txt:
      * http/tests/xmlhttprequest/xmlhttprequest-sync-no-progress-events-expected.txt:
      * jquery/event-expected.txt:
      * media/csp-blocks-video-expected.txt:
      * platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt:
      * platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
      * platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
      * platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
      * platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
      * platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
      * platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
      * platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
      * platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
      * platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt:
      * platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
      * platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
      * platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt:
      * platform/chromium-linux/http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
      * platform/chromium-linux/http/tests/websocket/tests/hixie76/bad-sub-protocol-control-chars-expected.txt:
      * platform/chromium-linux/http/tests/websocket/tests/hixie76/url-parsing-expected.txt:
      * platform/chromium-mac/fast/history/timed-refresh-in-cached-frame-expected.txt:
      * platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
      * platform/chromium-mac/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
      * platform/chromium-mac/http/tests/websocket/tests/hixie76/bad-sub-protocol-control-chars-expected.txt:
      * platform/chromium-mac/http/tests/websocket/tests/hixie76/url-parsing-expected.txt:
      * platform/chromium-win/fast/history/timed-refresh-in-cached-frame-expected.txt:
      * platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-no-file-access-expected.txt:
      * platform/chromium-win/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
      * platform/chromium-win/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
      * platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt:
      * platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
      * platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
      * platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
      * platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
      * platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
      * platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
      * platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
      * platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
      * platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt:
      * platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
      * platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
      * platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt:
      * platform/chromium-win/http/tests/websocket/tests/hixie76/bad-sub-protocol-control-chars-expected.txt:
      * platform/chromium-win/http/tests/websocket/tests/hixie76/url-parsing-expected.txt:
      * platform/chromium-win/websocket/tests/bad-sub-protocol-control-chars-expected.txt:
      * platform/chromium-win/websocket/tests/bad-sub-protocol-expected.txt:
      * platform/chromium-win/websocket/tests/bad-sub-protocol-non-ascii-expected.txt:
      * platform/chromium-win/websocket/tests/url-parsing-expected.txt:
      * platform/chromium/fast/dom/Geolocation/notimer-after-unload-expected.txt:
      * platform/chromium/fast/events/onbeforeunload-focused-iframe-expected.txt:
      * platform/chromium/fast/events/onunload-clears-onbeforeunload-expected.txt:
      * platform/chromium/fast/events/onunload-expected.txt:
      * platform/chromium/fast/events/onunload-not-on-body-expected.txt:
      * platform/chromium/fast/events/onunload-window-property-expected.txt:
      * platform/chromium/fast/events/pageshow-pagehide-on-back-uncached-expected.txt:
      * platform/chromium/fast/history/timed-refresh-in-cached-frame-expected.txt:
      * platform/chromium/fast/loader/frames-with-unload-handlers-in-page-cache-expected.txt:
      * platform/chromium/fast/loader/page-dismissal-modal-dialogs-expected.txt:
      * platform/chromium/fast/loader/recursive-before-unload-crash-expected.txt:
      * platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt:
      * platform/chromium/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
      * platform/chromium/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
      * platform/chromium/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
      * platform/chromium/http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:
      * platform/chromium/http/tests/security/cross-frame-access-call-expected.txt:
      * platform/chromium/http/tests/security/cross-frame-access-document-direct-expected.txt:
      * platform/chromium/http/tests/security/cross-frame-access-enumeration-expected.txt:
      * platform/chromium/http/tests/security/cross-frame-access-history-get-expected.txt:
      * platform/chromium/http/tests/security/cross-frame-access-history-put-expected.txt:
      * platform/chromium/http/tests/security/cross-frame-access-location-put-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
      * platform/chromium/http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt:
      * platform/chromium/http/tests/security/inactive-document-with-empty-security-origin-expected.txt:
      * platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt:
      * platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
      * platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
      * platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
      * platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
      * platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
      * platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
      * platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
      * platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
      * platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt:
      * platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
      * platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
      * platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt:
      * platform/chromium/http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt:
      * platform/chromium/http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt:
      * platform/chromium/http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt:
      * platform/chromium/http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt:
      * platform/chromium/http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt:
      * platform/chromium/http/tests/security/listener/xss-window-onclick-shortcut-expected.txt:
      * platform/chromium/http/tests/security/mixedContent/insecure-iframe-in-main-frame-allowed-expected.txt:
      * platform/chromium/http/tests/security/mixedContent/insecure-iframe-in-main-frame-blocked-expected.txt:
      * platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed-expected.txt:
      * platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-blocked-expected.txt:
      * platform/chromium/http/tests/security/mixedContent/insecure-script-in-main-frame-allowed-expected.txt:
      * platform/chromium/http/tests/security/mixedContent/insecure-script-in-main-frame-blocked-expected.txt:
      * platform/chromium/http/tests/security/redirect-BLOCKED-to-localURL-expected.txt:
      * platform/chromium/http/tests/security/window-named-proto-expected.txt:
      * platform/chromium/http/tests/security/xss-DENIED-assign-location-href-javascript-expected.txt:
      * platform/chromium/http/tests/security/xss-DENIED-frame-name-expected.txt:
      * platform/chromium/http/tests/websocket/tests/hybi/bad-sub-protocol-control-chars-expected.txt:
      * platform/chromium/http/tests/websocket/tests/hybi/url-parsing-expected.txt:
      * platform/chromium/media/csp-blocks-video-expected.txt:
      * platform/chromium/plugins/document-open-expected.txt:
      * platform/mac-leopard/http/tests/inspector/console-websocket-error-expected.txt:
      * platform/mac/http/tests/inspector/console-websocket-error-expected.txt:
      * platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
      * platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
      * platform/qt/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
      * platform/qt/http/tests/websocket/tests/hixie76/bad-sub-protocol-non-ascii-expected.txt:
      * platform/qt/http/tests/websocket/tests/hybi/bad-sub-protocol-non-ascii-expected.txt:
      * plugins/document-open-expected.txt:
      * plugins/get-user-agent-with-null-npp-from-npp-new-expected.txt:
      * plugins/geturlnotify-during-document-teardown-expected.txt:
      * plugins/netscape-plugin-map-data-to-src-expected.txt:
      * plugins/netscape-plugin-setwindow-size-2-expected.txt:
      * plugins/netscape-plugin-setwindow-size-expected.txt:
      * plugins/no-mime-with-valid-extension-expected.txt:
      * plugins/open-and-close-window-with-plugin-expected.txt:
      * plugins/pass-different-npp-struct-expected.txt:
      * plugins/window-open-expected.txt:
      * storage/open-database-creation-callback-expected.txt:
      * storage/open-database-set-empty-version-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104803 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c3bdd92
  19. 07 Jan, 2012 1 commit
    • abarth@webkit.org's avatar
      Disconnecting DOMWindow properties is fragile and overly complicated · 84fe60e1
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75699
      
      Reviewed by Alexey Proskuryakov.
      
      Previously, we had to carefully check every object tree hanging off of
      DOMWindow to make sure that every property correctly disconnected
      itself and all its subobjects from the Frame when the DOMWindow
      disconnected from the Frame.
      
      This patch introduces DOMWindowProperty, which is a base class that
      handles this work automagically, ensuring that we won't have any
      dangling Frame pointers and removing a bunch of boilerplate code.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * css/StyleMedia.cpp:
      (WebCore::StyleMedia::StyleMedia):
      * css/StyleMedia.h:
      (WebCore::StyleMedia::create):
      * loader/appcache/DOMApplicationCache.cpp:
      (WebCore::DOMApplicationCache::DOMApplicationCache):
      (WebCore::DOMApplicationCache::disconnectFrame):
      * loader/appcache/DOMApplicationCache.h:
      * page/BarInfo.cpp:
      (WebCore::BarInfo::BarInfo):
      * page/BarInfo.h:
      * page/Console.cpp:
      (WebCore::Console::Console):
      (WebCore::Console::memory):
      * page/Console.h:
      * page/DOMSelection.cpp:
      (WebCore::DOMSelection::DOMSelection):
      * page/DOMSelection.h:
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::registerProperty):
      (WebCore::DOMWindow::unregisterProperty):
      (WebCore::DOMWindow::clear):
      * page/DOMWindow.h:
      * page/Geolocation.cpp:
      (WebCore::Geolocation::Geolocation):
      (WebCore::Geolocation::disconnectFrame):
      * page/Geolocation.h:
      * page/History.cpp:
      (WebCore::History::History):
      * page/History.h:
      * page/Location.cpp:
      (WebCore::Location::Location):
      * page/Location.h:
      * page/Navigator.cpp:
      (WebCore::Navigator::Navigator):
      (WebCore::Navigator::~Navigator):
      * page/Navigator.h:
      * page/Performance.cpp:
      (WebCore::Performance::Performance):
      (WebCore::Performance::memory):
      * page/Performance.h:
      * page/PerformanceNavigation.cpp:
      (WebCore::PerformanceNavigation::PerformanceNavigation):
      * page/PerformanceNavigation.h:
      * page/PerformanceTiming.cpp:
      (WebCore::PerformanceTiming::PerformanceTiming):
      * page/PerformanceTiming.h:
      * page/Screen.cpp:
      (WebCore::Screen::Screen):
      * page/Screen.h:
      * plugins/DOMMimeTypeArray.cpp:
      (WebCore::DOMMimeTypeArray::DOMMimeTypeArray):
      * plugins/DOMMimeTypeArray.h:
      * plugins/DOMPluginArray.cpp:
      (WebCore::DOMPluginArray::DOMPluginArray):
      * plugins/DOMPluginArray.h:
      * storage/Storage.cpp:
      (WebCore::Storage::Storage):
      * storage/Storage.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104380 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84fe60e1
  20. 07 Dec, 2011 1 commit
    • vsevik@chromium.org's avatar
      Web Inspector: Extract default call stack creation and check for front-end from console. · dcf57087
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=73566
      
      Reviewed by Yury Semikhatsky.
      
      * bindings/js/ScriptCallStackFactory.cpp:
      (WebCore::createScriptCallStack):
      * bindings/js/ScriptCallStackFactory.h:
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateParametersCheck):
      * bindings/scripts/CodeGeneratorV8.pm:
      (GenerateFunctionCallback):
      * bindings/scripts/test/JS/JSTestObj.cpp:
      (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
      * bindings/scripts/test/V8/V8TestObj.cpp:
      (WebCore::TestObjInternal::customArgsAndExceptionCallback):
      * bindings/v8/ScriptCallStackFactory.cpp:
      (WebCore::createScriptCallStack):
      * bindings/v8/ScriptCallStackFactory.h:
      * inspector/InspectorInstrumentation.cpp:
      (WebCore::InspectorInstrumentation::hasFrontendForScriptContext):
      * inspector/InspectorInstrumentation.h:
      (WebCore::InspectorInstrumentation::hasFrontendForScriptContext):
      * inspector/WorkerInspectorController.h:
      (WebCore::WorkerInspectorController::hasFrontend):
      * page/Console.cpp:
      * page/Console.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102233 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dcf57087
  21. 02 Dec, 2011 2 commits
    • vsevik@chromium.org's avatar
      Unreviewed, rolling out r101794. · 112ea9c2
      vsevik@chromium.org authored
      http://trac.webkit.org/changeset/101794
      https://bugs.webkit.org/show_bug.cgi?id=73656
      
      Broke win build (Requested by vsevik on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-02
      
      * bindings/js/ScriptCallStackFactory.cpp:
      * bindings/js/ScriptCallStackFactory.h:
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateParametersCheck):
      * bindings/scripts/CodeGeneratorV8.pm:
      (GenerateFunctionCallback):
      * bindings/scripts/test/JS/JSTestObj.cpp:
      (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
      * bindings/scripts/test/V8/V8TestObj.cpp:
      (WebCore::TestObjInternal::customArgsAndExceptionCallback):
      * bindings/v8/ScriptCallStackFactory.cpp:
      * bindings/v8/ScriptCallStackFactory.h:
      * inspector/InspectorInstrumentation.cpp:
      * inspector/InspectorInstrumentation.h:
      * inspector/WorkerInspectorController.h:
      * page/Console.cpp:
      (WebCore::Console::shouldCaptureFullStackTrace):
      * page/Console.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      112ea9c2
    • vsevik@chromium.org's avatar
      Web Inspector: Extract default call stack creation and check for front-end from console. · 272a0767
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=73566
      
      Reviewed by Yury Semikhatsky.
      
      * bindings/js/ScriptCallStackFactory.cpp:
      (WebCore::createScriptCallStack):
      * bindings/js/ScriptCallStackFactory.h:
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateParametersCheck):
      * bindings/scripts/CodeGeneratorV8.pm:
      (GenerateFunctionCallback):
      * bindings/scripts/test/JS/JSTestObj.cpp:
      (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
      * bindings/scripts/test/V8/V8TestObj.cpp:
      (WebCore::TestObjInternal::customArgsAndExceptionCallback):
      * bindings/v8/ScriptCallStackFactory.cpp:
      (WebCore::createScriptCallStack):
      * bindings/v8/ScriptCallStackFactory.h:
      * inspector/InspectorInstrumentation.cpp:
      (WebCore::InspectorInstrumentation::hasFrontendForScriptContext):
      * inspector/InspectorInstrumentation.h:
      (WebCore::InspectorInstrumentation::hasFrontendForScriptContext):
      * inspector/WorkerInspectorController.h:
      (WebCore::WorkerInspectorController::hasFrontend):
      * page/Console.cpp:
      * page/Console.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101794 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      272a0767
  22. 15 Jul, 2011 1 commit
    • commit-queue@webkit.org's avatar
      Web Inspector: Rename console.markTimeline() to console.timeStamp() for Firebug compatibility. · 058fb454
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=63317
      
      Patch by Mike West <mkwst@chromium.org> on 2011-07-15
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      Test: inspector/timeline/timeline-time-stamp.html
      
      * inspector/InspectorConsoleInstrumentation.h:
      (WebCore::InspectorInstrumentation::consoleTimeStamp):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore::InspectorInstrumentation::consoleTimeStampImpl):
      * inspector/InspectorInstrumentation.h:
      * inspector/InspectorTimelineAgent.cpp:
      (WebCore::InspectorTimelineAgent::didTimeStamp):
      * inspector/InspectorTimelineAgent.h:
      * inspector/TimelineRecordFactory.cpp:
      (WebCore::TimelineRecordFactory::createTimeStampData):
      * inspector/TimelineRecordFactory.h:
      * inspector/front-end/TimelineAgent.js:
      * inspector/front-end/TimelineOverviewPane.js:
      (WebInspector.TimelineOverviewPane.prototype.update.markPercentagesForRecord):
      (WebInspector.TimelineOverviewPane.prototype.update):
      * inspector/front-end/TimelinePanel.js:
      (WebInspector.TimelinePanel):
      (WebInspector.TimelinePanel.prototype.get _recordStyles):
      (WebInspector.TimelinePanel.prototype._updateEventDividers):
      (WebInspector.TimelinePanel.prototype._createEventDivider):
      (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
      (WebInspector.TimelinePanel.prototype._clearPanel):
      (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
      * page/Console.cpp:
      (WebCore::Console::markTimeline):
      (WebCore::Console::timeStamp):
      * page/Console.h:
      * page/Console.idl:
      
      LayoutTests:
      
      * inspector/timeline/resources/timeline-iframe-data.html:
      * inspector/timeline/timeline-enum-stability-expected.txt:
      * inspector/timeline/timeline-event-dispatch.html:
      * inspector/timeline/timeline-mark-timeline-expected.txt:
      * inspector/timeline/timeline-mark-timeline.html:
      * inspector/timeline/timeline-script-tag-1-expected.txt:
      * inspector/timeline/timeline-test.js:
      (initialize_Timeline.InspectorTest.dumpTimelineRecord):
      * inspector/timeline/timeline-time-stamp-expected.txt: Added.
      * inspector/timeline/timeline-time-stamp.html: Copied from LayoutTests/inspector/timeline/timeline-mark-timeline.html.
      * platform/chromium/inspector/timeline/timeline-mark-timeline-expected.txt:
      * platform/chromium/inspector/timeline/timeline-time-stamp-expected.txt: Copied from LayoutTests/platform/chromium/inspector/timeline/timeline-mark-timeline-expected.txt.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91061 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      058fb454
  23. 11 May, 2011 1 commit
    • weinig@apple.com's avatar
      2011-05-11 Sam Weinig <sam@webkit.org> · f25e6ff1
      weinig@apple.com authored
              Reviewed by Eric Seidel.
      
              Stop including Console.h just to get Console enum types
              https://bugs.webkit.org/show_bug.cgi?id=60607
      
              Move MessageSource, MessageType and MessageLevel into its own
              header and cleanup surrounding classes.
      
              * Api/qwebelement.cpp:
      2011-05-11  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Stop including Console.h just to get Console enum types
              https://bugs.webkit.org/show_bug.cgi?id=60607
      
              Move MessageSource, MessageType and MessageLevel into its own
              header and cleanup surrounding classes.
      
              * GNUmakefile.list.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSCustomXPathNSResolver.cpp:
              * bindings/scripts/CodeGeneratorJS.pm:
              * bindings/v8/V8Proxy.cpp:
              * dom/ScriptExecutionContext.h:
              * html/HTMLFormElement.cpp:
              * html/parser/XSSFilter.cpp:
              * inspector/ConsoleMessage.h:
              * inspector/InjectedScriptHost.h:
              * inspector/InspectorAgent.h:
              * inspector/InspectorConsoleAgent.h:
              * inspector/InspectorFrontendHost.h:
              * inspector/InspectorInstrumentation.cpp:
              * inspector/InspectorInstrumentation.h:
              * loader/EmptyClients.h:
              * loader/FrameLoader.cpp:
              * loader/MainResourceLoader.cpp:
              * loader/appcache/ApplicationCacheGroup.cpp:
              * page/ChromeClient.h:
              * page/Console.cpp:
              (WebCore::Console::~Console):
              * page/Console.h:
              * page/ConsoleTypes.h: Added.
              * page/ContentSecurityPolicy.cpp:
              * page/Geolocation.h:
              * workers/WorkerReportingProxy.h:
              * xml/XMLHttpRequest.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86251 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f25e6ff1
  24. 28 Apr, 2011 1 commit
    • abarth@webkit.org's avatar
      2011-04-28 Adam Barth <abarth@webkit.org> · d29d2063
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Remove WML
              https://bugs.webkit.org/show_bug.cgi?id=59678
      
              Remove WML configuration option from the CMake build system.
      
              * Source/cmake/OptionsEfl.cmake:
              * Source/cmake/OptionsWinCE.cmake:
              * Source/cmakeconfig.h.cmake:
      2011-04-28  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Remove WML
              https://bugs.webkit.org/show_bug.cgi?id=59678
      
              Remove build system integration and test harness integration for WML.
      
              * Scripts/build-webkit:
              * Scripts/old-run-webkit-tests:
              * Scripts/webkitperl/features.pm:
              * Scripts/webkitpy/layout_tests/port/webkit.py:
              * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
      2011-04-28  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Remove WML
              https://bugs.webkit.org/show_bug.cgi?id=59678
      
              Remove WML tests.  These tests do not appear to be run on
              build.webkit.org because none of the bots on build.webkit.org enable
              WML.
      
              * fast/wml: Removed.
              * fast/wml/br-element-in-table.wml: Removed.
              * fast/wml/br-element-in-text.wml: Removed.
              * fast/wml/card-element.wml: Removed.
              * fast/wml/case-sensitivity.wml: Removed.
              * fast/wml/cdata-section.wml: Removed.
              * fast/wml/comment.wml: Removed.
              * fast/wml/do-element-optional-attr.wml: Removed.
              * fast/wml/do-shadow.wml: Removed.
              * fast/wml/do-template.wml: Removed.
              * fast/wml/entity.wml: Removed.
              * fast/wml/err-event-binding-conflict.wml: Removed.
              * fast/wml/err-invalid-location-for-varref.wml: Removed.
              * fast/wml/err-invalid-tablecolumn-number.wml: Removed.
              * fast/wml/err-invalid-variable-name.wml: Removed.
              * fast/wml/err-multi-access.wml: Removed.
              * fast/wml/err-multi-http-equiv-in-meta.wml: Removed.
              * fast/wml/err-multi-name-in-meta.wml: Removed.
              * fast/wml/err-multi-timer.wml: Removed.
              * fast/wml/err-samename-do.wml: Removed.
              * fast/wml/err-unallowed-task-in-anchor.wml: Removed.
              * fast/wml/fieldset.wml: Removed.
              * fast/wml/html-fieldset-crash.html: Removed.
              * fast/wml/img-localsrc.wml: Removed.
              * fast/wml/img-src-localsrc-alt.wml: Removed.
              * fast/wml/img-src.wml: Removed.
              * fast/wml/input.wml: Removed.
              * fast/wml/p-align.wml: Removed.
              * fast/wml/p-mode.wml: Removed.
              * fast/wml/resources: Removed.
              * fast/wml/resources/fail.png: Removed.
              * fast/wml/resources/pass.png: Removed.
              * fast/wml/select.wml: Removed.
              * fast/wml/show-first-card.wml: Removed.
              * fast/wml/table-element-align-attribute-invalid.wml: Removed.
              * fast/wml/table-element-columns-attribute-invalid-number.wml: Removed.
              * fast/wml/table-element-columns-attribute-invalid.wml: Removed.
              * fast/wml/table-element-columns-attribute-missing.wml: Removed.
              * fast/wml/table-element-columns-attribute.wml: Removed.
              * fast/wml/table-element.wml: Removed.
              * fast/wml/task-noop-in-do.wml: Removed.
              * fast/wml/test.wml: Removed.
              * fast/wml/text-emphasis.wml: Removed.
              * fast/wml/validate-dtd.wml: Removed.
              * http/tests/wml: Removed.
              * http/tests/wml/access-target-domain-deny-expected.txt: Removed.
              * http/tests/wml/access-target-domain-deny.html: Removed.
              * http/tests/wml/access-target-expected.txt: Removed.
              * http/tests/wml/access-target-path-deny-expected.txt: Removed.
              * http/tests/wml/access-target-path-deny.html: Removed.
              * http/tests/wml/access-target.html: Removed.
              * http/tests/wml/go-task-get-method-accept-charset-expected.txt: Removed.
              * http/tests/wml/go-task-get-method-accept-charset.html: Removed.
              * http/tests/wml/go-task-get-method-expected.txt: Removed.
              * http/tests/wml/go-task-get-method.html: Removed.
              * http/tests/wml/go-task-post-method-accept-charset-expected.txt: Removed.
              * http/tests/wml/go-task-post-method-accept-charset.html: Removed.
              * http/tests/wml/go-task-post-method-expected.txt: Removed.
              * http/tests/wml/go-task-post-method.html: Removed.
              * http/tests/wml/post-data-to-server-expected.txt: Removed.
              * http/tests/wml/post-data-to-server.html: Removed.
              * http/tests/wml/resources: Removed.
              * http/tests/wml/resources/access-target-domain-deny.wml: Removed.
              * http/tests/wml/resources/access-target-path-deny.wml: Removed.
              * http/tests/wml/resources/access-target.wml: Removed.
              * http/tests/wml/resources/answer-utf8.cgi: Removed.
              * http/tests/wml/resources/answer.cgi: Removed.
              * http/tests/wml/resources/dumpVariables.cgi: Removed.
              * http/tests/wml/resources/locked-deck.wml: Removed.
              * http/tests/wml/resources/unreachable-domain.wml: Removed.
              * http/tests/wml/resources/unreachable-path.wml: Removed.
              * http/tests/wml/script-tests: Removed.
              * http/tests/wml/script-tests/TEMPLATE.html: Removed.
              * http/tests/wml/script-tests/access-target-domain-deny.js: Removed.
              * http/tests/wml/script-tests/access-target-path-deny.js: Removed.
              * http/tests/wml/script-tests/access-target.js: Removed.
              * http/tests/wml/script-tests/go-task-get-method-accept-charset.js: Removed.
              * http/tests/wml/script-tests/go-task-get-method.js: Removed.
              * http/tests/wml/script-tests/go-task-post-method-accept-charset.js: Removed.
              * http/tests/wml/script-tests/go-task-post-method.js: Removed.
              * http/tests/wml/script-tests/post-data-to-server.js: Removed.
              * http/tests/xmlviewer/dumpAsText/wml-expected.txt: Removed.
              * http/tests/xmlviewer/dumpAsText/wml.xml: Removed.
              * platform/mac-leopard/fast/wml: Removed.
              * platform/mac-leopard/fast/wml/html-fieldset-crash-expected.png: Removed.
              * platform/mac/fast/wml: Removed.
              * platform/mac/fast/wml/br-element-in-table-expected.png: Removed.
              * platform/mac/fast/wml/br-element-in-table-expected.txt: Removed.
              * platform/mac/fast/wml/br-element-in-text-expected.png: Removed.
              * platform/mac/fast/wml/br-element-in-text-expected.txt: Removed.
              * platform/mac/fast/wml/card-element-expected.png: Removed.
              * platform/mac/fast/wml/card-element-expected.txt: Removed.
              * platform/mac/fast/wml/case-sensitivity-expected.png: Removed.
              * platform/mac/fast/wml/case-sensitivity-expected.txt: Removed.
              * platform/mac/fast/wml/cdata-section-expected.png: Removed.
              * platform/mac/fast/wml/cdata-section-expected.txt: Removed.
              * platform/mac/fast/wml/comment-expected.png: Removed.
              * platform/mac/fast/wml/comment-expected.txt: Removed.
              * platform/mac/fast/wml/do-element-optional-attr-expected.png: Removed.
              * platform/mac/fast/wml/do-element-optional-attr-expected.txt: Removed.
              * platform/mac/fast/wml/do-shadow-expected.png: Removed.
              * platform/mac/fast/wml/do-shadow-expected.txt: Removed.
              * platform/mac/fast/wml/do-template-expected.png: Removed.
              * platform/mac/fast/wml/do-template-expected.txt: Removed.
              * platform/mac/fast/wml/entity-expected.png: Removed.
              * platform/mac/fast/wml/entity-expected.txt: Removed.
              * platform/mac/fast/wml/err-event-binding-conflict-expected.png: Removed.
              * platform/mac/fast/wml/err-event-binding-conflict-expected.txt: Removed.
              * platform/mac/fast/wml/err-invalid-location-for-varref-expected.png: Removed.
              * platform/mac/fast/wml/err-invalid-location-for-varref-expected.txt: Removed.
              * platform/mac/fast/wml/err-invalid-tablecolumn-number-expected.png: Removed.
              * platform/mac/fast/wml/err-invalid-tablecolumn-number-expected.txt: Removed.
              * platform/mac/fast/wml/err-invalid-variable-name-expected.png: Removed.
              * platform/mac/fast/wml/err-invalid-variable-name-expected.txt: Removed.
              * platform/mac/fast/wml/err-multi-access-expected.png: Removed.
              * platform/mac/fast/wml/err-multi-access-expected.txt: Removed.
              * platform/mac/fast/wml/err-multi-http-equiv-in-meta-expected.png: Removed.
              * platform/mac/fast/wml/err-multi-http-equiv-in-meta-expected.txt: Removed.
              * platform/mac/fast/wml/err-multi-name-in-meta-expected.png: Removed.
              * platform/mac/fast/wml/err-multi-name-in-meta-expected.txt: Removed.
              * platform/mac/fast/wml/err-multi-timer-expected.png: Removed.
              * platform/mac/fast/wml/err-multi-timer-expected.txt: Removed.
              * platform/mac/fast/wml/err-samename-do-expected.png: Removed.
              * platform/mac/fast/wml/err-samename-do-expected.txt: Removed.
              * platform/mac/fast/wml/err-unallowed-task-in-anchor-expected.png: Removed.
              * platform/mac/fast/wml/err-unallowed-task-in-anchor-expected.txt: Removed.
              * platform/mac/fast/wml/fieldset-expected.png: Removed.
              * platform/mac/fast/wml/fieldset-expected.txt: Removed.
              * platform/mac/fast/wml/html-fieldset-crash-expected.png: Removed.
              * platform/mac/fast/wml/html-fieldset-crash-expected.txt: Removed.
              * platform/mac/fast/wml/img-localsrc-expected.png: Removed.
              * platform/mac/fast/wml/img-localsrc-expected.txt: Removed.
              * platform/mac/fast/wml/img-src-expected.png: Removed.
              * platform/mac/fast/wml/img-src-expected.txt: Removed.
              * platform/mac/fast/wml/img-src-localsrc-alt-expected.png: Removed.
              * platform/mac/fast/wml/img-src-localsrc-alt-expected.txt: Removed.
              * platform/mac/fast/wml/input-expected.png: Removed.
              * platform/mac/fast/wml/input-expected.txt: Removed.
              * platform/mac/fast/wml/p-align-expected.png: Removed.
              * platform/mac/fast/wml/p-align-expected.txt: Removed.
              * platform/mac/fast/wml/p-mode-expected.png: Removed.
              * platform/mac/fast/wml/p-mode-expected.txt: Removed.
              * platform/mac/fast/wml/select-expected.png: Removed.
              * platform/mac/fast/wml/select-expected.txt: Removed.
              * platform/mac/fast/wml/show-first-card-expected.png: Removed.
              * platform/mac/fast/wml/show-first-card-expected.txt: Removed.
              * platform/mac/fast/wml/table-element-align-attribute-invalid-expected.png: Removed.
              * platform/mac/fast/wml/table-element-align-attribute-invalid-expected.txt: Removed.
              * platform/mac/fast/wml/table-element-columns-attribute-expected.png: Removed.
              * platform/mac/fast/wml/table-element-columns-attribute-expected.txt: Removed.
              * platform/mac/fast/wml/table-element-columns-attribute-invalid-expected.png: Removed.
              * platform/mac/fast/wml/table-element-columns-attribute-invalid-expected.txt: Removed.
              * platform/mac/fast/wml/table-element-columns-attribute-invalid-number-expected.png: Removed.
              * platform/mac/fast/wml/table-element-columns-attribute-invalid-number-expected.txt: Removed.
              * platform/mac/fast/wml/table-element-columns-attribute-missing-expected.png: Removed.
              * platform/mac/fast/wml/table-element-columns-attribute-missing-expected.txt: Removed.
              * platform/mac/fast/wml/table-element-expected.png: Removed.
              * platform/mac/fast/wml/table-element-expected.txt: Removed.
              * platform/mac/fast/wml/task-noop-in-do-expected.png: Removed.
              * platform/mac/fast/wml/task-noop-in-do-expected.txt: Removed.
              * platform/mac/fast/wml/test-expected.png: Removed.
              * platform/mac/fast/wml/test-expected.txt: Removed.
              * platform/mac/fast/wml/text-emphasis-expected.png: Removed.
              * platform/mac/fast/wml/text-emphasis-expected.txt: Removed.
              * platform/mac/fast/wml/validate-dtd-expected.png: Removed.
              * platform/mac/fast/wml/validate-dtd-expected.txt: Removed.
              * wml: Removed.
              * wml/access-target-deny-expected.txt: Removed.
              * wml/access-target-deny.html: Removed.
              * wml/access-target-expected.txt: Removed.
              * wml/access-target.html: Removed.
              * wml/enter-card-with-events-expected.txt: Removed.
              * wml/enter-card-with-events.html: Removed.
              * wml/enter-first-card-with-events-expected.txt: Removed.
              * wml/enter-first-card-with-events.html: Removed.
              * wml/go-task-get-method-external-deck-expected.txt: Removed.
              * wml/go-task-get-method-external-deck-with-href-expected.txt: Removed.
              * wml/go-task-get-method-external-deck-with-href.html: Removed.
              * wml/go-task-get-method-external-deck.html: Removed.
              * wml/go-task-get-method-same-deck-expected.txt: Removed.
              * wml/go-task-get-method-same-deck.html: Removed.
              * wml/input-format-expected.txt: Removed.
              * wml/input-format.html: Removed.
              * wml/newcontext-same-deck-expected.txt: Removed.
              * wml/newcontext-same-deck.html: Removed.
              * wml/onenterforward-event-expected.txt: Removed.
              * wml/onenterforward-event.html: Removed.
              * wml/onenterforward-inline-event-expected.txt: Removed.
              * wml/onenterforward-inline-event.html: Removed.
              * wml/ontimer-event-expected.txt: Removed.
              * wml/ontimer-event.html: Removed.
              * wml/ontimer-inline-event-expected.txt: Removed.
              * wml/ontimer-inline-event.html: Removed.
              * wml/option-element-onpick-expected.txt: Removed.
              * wml/option-element-onpick-recursion-expected.txt: Removed.
              * wml/option-element-onpick-recursion.html: Removed.
              * wml/option-element-onpick.html: Removed.
              * wml/resources: Removed.
              * wml/resources/WMLTestCase.js: Removed.
              * wml/resources/access-target-deny.wml: Removed.
              * wml/resources/access-target.wml: Removed.
              * wml/resources/enter-card-with-events.wml: Removed.
              * wml/resources/enter-first-card-with-events.wml: Removed.
              * wml/resources/external-deck.wml: Removed.
              * wml/resources/locked-deck.wml: Removed.
              * wml/resources/newcontext-same-deck.wml: Removed.
              * wml/resources/onenterforward-event.wml: Removed.
              * wml/resources/onenterforward-inline-event.wml: Removed.
              * wml/resources/ontimer-event.wml: Removed.
              * wml/resources/ontimer-inline-event.wml: Removed.
              * wml/resources/option-element-onpick-recursion.wml: Removed.
              * wml/resources/test-document.wml: Removed.
              * wml/script-tests: Removed.
              * wml/script-tests/TEMPLATE.html: Removed.
              * wml/script-tests/access-target-deny.js: Removed.
              * wml/script-tests/access-target.js: Removed.
              * wml/script-tests/enter-card-with-events.js: Removed.
              * wml/script-tests/enter-first-card-with-events.js: Removed.
              * wml/script-tests/go-task-get-method-external-deck-with-href.js: Removed.
              * wml/script-tests/go-task-get-method-external-deck.js: Removed.
              * wml/script-tests/go-task-get-method-same-deck.js: Removed.
              * wml/script-tests/input-format.js: Removed.
              * wml/script-tests/newcontext-same-deck.js: Removed.
              * wml/script-tests/onenterforward-event.js: Removed.
              * wml/script-tests/onenterforward-inline-event.js: Removed.
              * wml/script-tests/ontimer-event.js: Removed.
              * wml/script-tests/ontimer-inline-event.js: Removed.
              * wml/script-tests/option-element-onpick-recursion.js: Removed.
              * wml/script-tests/option-element-onpick.js: Removed.
              * wml/script-tests/select-element-variables.js: Removed.
              * wml/script-tests/variable-reference-invalid-character.js: Removed.
              * wml/script-tests/variable-reference-valid.js: Removed.
              * wml/select-element-variables-expected.txt: Removed.
              * wml/select-element-variables.html: Removed.
              * wml/variable-reference-invalid-character-expected.txt: Removed.
              * wml/variable-reference-invalid-character.html: Removed.
              * wml/variable-reference-valid-expected.txt: Removed.
              * wml/variable-reference-valid.html: Removed.
      2011-04-28  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Remove WML
              https://bugs.webkit.org/show_bug.cgi?id=59678
      
              Remove the WML configuration option from the Mac build system.
      
              * Configurations/FeatureDefines.xcconfig:
      2011-04-28  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Remove WML
              https://bugs.webkit.org/show_bug.cgi?id=59678
      
              Remove WML-related enumeration.
      
              * Interfaces/IWebFramePrivate.idl:
      2011-04-28  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Remove WML
              https://bugs.webkit.org/show_bug.cgi?id=59678
      
              Remove WML-related configuration options and private APIs.
      
              * Configurations/FeatureDefines.xcconfig:
              * WebCoreSupport/WebChromeClient.mm:
              (stringForMessageSource):
              * WebView/WebFramePrivate.h:
              * WebView/WebUIDelegatePrivate.h:
      2011-04-28  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Remove WML
              https://bugs.webkit.org/show_bug.cgi?id=59678
      
              This patch removes WML from WebCore.  After removing WML, there's a
              bunch of twisted code that could be untwisted, but this patch contains
              only the purely mechanical part of removing the feature.
      
              There's been a lot of discussion on webkit-dev about whether we should
              remove WML.  In addition to those threads, we've had an informal poll
              of the reviewers as well as an in-person discussion at the WebKit
              contributor's meeting.  Removing any feature is likely to make some
              folks unhappy, but, on balance, removing WML appears to be the right
              thing for the project to do at this time.
      
              * CMakeLists.txt:
              * CodeGenerators.pri:
              * Configurations/FeatureDefines.xcconfig:
              * DerivedSources.cpp:
              * DerivedSources.make:
              * GNUmakefile.am:
              * GNUmakefile.list.am:
              * WebCore.gyp/WebCore.gyp:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * css/CSSStyleSelector.cpp:
              (WebCore::linkAttribute):
              (WebCore::CSSStyleSelector::styleForElement):
              (WebCore::CSSStyleSelector::adjustRenderStyle):
              * css/wml.css: Removed.
              * dom/DOMImplementation.cpp:
              (WebCore::DOMImplementation::createDocument):
              * dom/Document.cpp:
              (WebCore::Document::Document):
              (WebCore::Document::createElement):
              * dom/Document.h:
              (WebCore::Document::isMediaDocument):
              * dom/Document.idl:
              * dom/InputElement.h:
              * dom/Node.cpp:
              (WebCore::Node::toInputElement):
              * dom/Node.h:
              * dom/OptionElement.cpp:
              (WebCore::toOptionElement):
              (WebCore::isOptionElement):
              * dom/OptionElement.h:
              * dom/OptionGroupElement.cpp:
              (WebCore::toOptionGroupElement):
              (WebCore::isOptionGroupElement):
              * dom/SelectElement.cpp:
              (WebCore::toSelectElement):
              * dom/SelectElement.h:
              * dom/Text.cpp:
              (WebCore::Text::attach):
              * dom/XMLDocumentParser.cpp:
              (WebCore::XMLDocumentParser::insertErrorMessageBlock):
              * dom/XMLDocumentParser.h:
              * dom/XMLDocumentParserLibxml2.cpp:
              (WebCore::XMLDocumentParser::internalSubset):
              (WebCore::getEntityHandler):
              * dom/XMLDocumentParserQt.cpp:
              (WebCore::XMLDocumentParser::parse):
              (WebCore::XMLDocumentParser::parseDtd):
              * editing/htmlediting.cpp:
              (WebCore::canHaveChildrenForEditing):
              * features.pri:
              * history/BackForwardList.h:
              * history/BackForwardListImpl.cpp:
              * history/BackForwardListImpl.h:
              * history/PageCache.cpp:
              (WebCore::PageCache::canCachePageContainingThisFrame):
              * html/HTMLAnchorElement.h:
              * inspector/ConsoleMessage.cpp:
              (WebCore::messageSourceValue):
              * inspector/front-end/ConsoleView.js:
              (WebInspector.ConsoleMessage.prototype.toString):
              * loader/FrameLoader.cpp:
              (WebCore::isBackForwardLoadType):
              (WebCore::FrameLoader::transitionToCommitted):
              (WebCore::FrameLoader::shouldReload):
              (WebCore::FrameLoader::loadDifferentDocumentItem):
              (WebCore::FrameLoader::loadItem):
              * loader/FrameLoaderTypes.h:
              * loader/HistoryController.cpp:
              (WebCore::HistoryController::restoreDocumentState):
              * manual-tests/wml: Removed.
              * manual-tests/wml/StartTests.wml: Removed.
              * manual-tests/wml/a-br-element.wml: Removed.
              * manual-tests/wml/a-element.wml: Removed.
              * manual-tests/wml/a-img-element.wml: Removed.
              * manual-tests/wml/access-target.wml: Removed.
              * manual-tests/wml/anchor-br-element.wml: Removed.
              * manual-tests/wml/anchor-element.wml: Removed.
              * manual-tests/wml/anchor-img-element.wml: Removed.
              * manual-tests/wml/card-newcontext-attr.wml: Removed.
              * manual-tests/wml/card-onenterbackward.wml: Removed.
              * manual-tests/wml/card-onenterforward.wml: Removed.
              * manual-tests/wml/card-ontimer.wml: Removed.
              * manual-tests/wml/deck-access-control.wml: Removed.
              * manual-tests/wml/input-format.wml: Removed.
              * manual-tests/wml/onevent-go.wml: Removed.
              * manual-tests/wml/onevent-noop.wml: Removed.
              * manual-tests/wml/onevent-prev.wml: Removed.
              * manual-tests/wml/onevent-refresh.wml: Removed.
              * manual-tests/wml/onevent-shadow.wml: Removed.
              * manual-tests/wml/resources: Removed.
              * manual-tests/wml/resources/smiley.png: Removed.
              * manual-tests/wml/select-element.wml: Removed.
              * manual-tests/wml/select-onpick-event-crash.wml: Removed.
              * manual-tests/wml/select-onpick-event.wml: Removed.
              * manual-tests/wml/setvar-element.wml: Removed.
              * manual-tests/wml/targetdeck.wml: Removed.
              * manual-tests/wml/task-go-in-anchor.wml: Removed.
              * manual-tests/wml/task-prev-in-anchor.wml: Removed.
              * manual-tests/wml/task-refresh-in-anchor.wml: Removed.
              * manual-tests/wml/template-go.wml: Removed.
              * manual-tests/wml/template-ontimer.wml: Removed.
              * manual-tests/wml/timer.wml: Removed.
              * manual-tests/wml/variable-substitution.wml: Removed.
              * page/Console.cpp:
              (WebCore::printMessageSourceAndLevelPrefix):
              * page/Console.h:
              * page/Frame.cpp:
              (WebCore::Frame::Frame):
              * page/Page.cpp:
              * page/Page.h:
              * platform/MIMETypeRegistry.cpp:
              (WebCore::initializeSupportedNonImageMimeTypes):
              * platform/network/FormDataBuilder.h:
              * platform/network/mac/ResourceHandleMac.mm:
              (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
              * platform/wince/MIMETypeRegistryWinCE.cpp:
              (WebCore::initMIMETypeEntensionMap):
              * rendering/HitTestResult.cpp:
              (WebCore::HitTestResult::altDisplayString):
              (WebCore::HitTestResult::absoluteImageURL):
              (WebCore::HitTestResult::absoluteLinkURL):
              (WebCore::HitTestResult::isLiveLink):
              * rendering/RenderBox.cpp:
              * rendering/RenderButton.cpp:
              (WebCore::RenderButton::updateFromElement):
              * rendering/RenderFieldset.cpp:
              (WebCore::RenderFieldset::findLegend):
              * rendering/RenderImage.cpp:
              (WebCore::RenderImage::updateAltText):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::isLegend):
              (WebCore::RenderObject::offsetParent):
              * wml: Removed.
              * wml/WMLAElement.cpp: Removed.
              * wml/WMLAElement.h: Removed.
              * wml/WMLAccessElement.cpp: Removed.
              * wml/WMLAccessElement.h: Removed.
              * wml/WMLAnchorElement.cpp: Removed.
              * wml/WMLAnchorElement.h: Removed.
              * wml/WMLAttributeNames.in: Removed.
              * wml/WMLBRElement.cpp: Removed.
              * wml/WMLBRElement.h: Removed.
              * wml/WMLCardElement.cpp: Removed.
              * wml/WMLCardElement.h: Removed.
              * wml/WMLDoElement.cpp: Removed.
              * wml/WMLDoElement.h: Removed.
              * wml/WMLDocument.cpp: Removed.
              * wml/WMLDocument.h: Removed.
              * wml/WMLElement.cpp: Removed.
              * wml/WMLElement.h: Removed.
              * wml/WMLErrorHandling.cpp: Removed.
              * wml/WMLErrorHandling.h: Removed.
              * wml/WMLEventHandlingElement.cpp: Removed.
              * wml/WMLEventHandlingElement.h: Removed.
              * wml/WMLFieldSetElement.cpp: Removed.
              * wml/WMLFieldSetElement.h: Removed.
              * wml/WMLFormControlElement.cpp: Removed.
              * wml/WMLFormControlElement.h: Removed.
              * wml/WMLGoElement.cpp: Removed.
              * wml/WMLGoElement.h: Removed.
              * wml/WMLImageElement.cpp: Removed.
              * wml/WMLImageElement.h: Removed.
              * wml/WMLImageLoader.cpp: Removed.
              * wml/WMLImageLoader.h: Removed.
              * wml/WMLInputElement.cpp: Removed.
              * wml/WMLInputElement.h: Removed.
              * wml/WMLInsertedLegendElement.cpp: Removed.
              * wml/WMLInsertedLegendElement.h: Removed.
              * wml/WMLIntrinsicEvent.cpp: Removed.
              * wml/WMLIntrinsicEvent.h: Removed.
              * wml/WMLIntrinsicEventHandler.cpp: Removed.
              * wml/WMLIntrinsicEventHandler.h: Removed.
              * wml/WMLMetaElement.cpp: Removed.
              * wml/WMLMetaElement.h: Removed.
              * wml/WMLNoopElement.cpp: Removed.
              * wml/WMLNoopElement.h: Removed.
              * wml/WMLOnEventElement.cpp: Removed.
              * wml/WMLOnEventElement.h: Removed.
              * wml/WMLOptGroupElement.cpp: Removed.
              * wml/WMLOptGroupElement.h: Removed.
              * wml/WMLOptionElement.cpp: Removed.
              * wml/WMLOptionElement.h: Removed.
              * wml/WMLPElement.cpp: Removed.
              * wml/WMLPElement.h: Removed.
              * wml/WMLPageState.cpp: Removed.
              * wml/WMLPageState.h: Removed.
              * wml/WMLPostfieldElement.cpp: Removed.
              * wml/WMLPostfieldElement.h: Removed.
              * wml/WMLPrevElement.cpp: Removed.
              * wml/WMLPrevElement.h: Removed.
              * wml/WMLRefreshElement.cpp: Removed.
              * wml/WMLRefreshElement.h: Removed.
              * wml/WMLSelectElement.cpp: Removed.
              * wml/WMLSelectElement.h: Removed.
              * wml/WMLSetvarElement.cpp: Removed.
              * wml/WMLSetvarElement.h: Removed.
              * wml/WMLTableElement.cpp: Removed.
              * wml/WMLTableElement.h: Removed.
              * wml/WMLTagNames.in: Removed.
              * wml/WMLTaskElement.cpp: Removed.
              * wml/WMLTaskElement.h: Removed.
              * wml/WMLTemplateElement.cpp: Removed.
              * wml/WMLTemplateElement.h: Removed.
              * wml/WMLTimerElement.cpp: Removed.
              * wml/WMLTimerElement.h: Removed.
              * wml/WMLVariables.cpp: Removed.
              * wml/WMLVariables.h: Removed.
      2011-04-28  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Remove WML
              https://bugs.webkit.org/show_bug.cgi?id=59678
      
              Remove WML-related code in WebKit2.
      
              * Configurations/FeatureDefines.xcconfig:
              * WebProcess/WebPage/WebBackForwardListProxy.cpp:
              * WebProcess/WebPage/WebBackForwardListProxy.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85256 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d29d2063
  25. 12 Apr, 2011 1 commit
    • pfeldman@chromium.org's avatar
      2011-04-12 Pavel Feldman <pfeldman@google.com> · aefe496a
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: document console domain, support cross-domain type references.
              https://bugs.webkit.org/show_bug.cgi?id=58240
      
              * inspector/protocol/console-agent-expected.txt:
      2011-04-12  Pavel Feldman  <pfeldman@google.com>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: document console domain, support cross-domain type references.
              https://bugs.webkit.org/show_bug.cgi?id=58240
      
              * inspector/ConsoleMessage.cpp:
              (WebCore::messageSourceValue):
              (WebCore::messageTypeValue):
              (WebCore::messageLevelValue):
              (WebCore::ConsoleMessage::addToFrontend):
              * inspector/Inspector.json:
              * inspector/ScriptCallFrame.cpp:
              (WebCore::ScriptCallFrame::buildInspectorObject):
              * inspector/front-end/ConsoleView.js:
              (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageAdded):
              (WebInspector.ConsoleMessage):
              (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
              (WebInspector.ConsoleMessage.prototype.isEqual):
              * inspector/front-end/NetworkManager.js:
              (WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
              * inspector/generate-inspector-idl:
              * page/Console.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aefe496a
  26. 14 Jan, 2011 1 commit
    • yurys@chromium.org's avatar
      2011-01-13 Yury Semikhatsky <yurys@chromium.org> · 7382e72a
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: extract console related functionality into InspectorConsoleAgent
              https://bugs.webkit.org/show_bug.cgi?id=52282
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * inspector/CodeGeneratorInspector.pm:
              * inspector/ConsoleMessage.cpp:
              (WebCore::ConsoleMessage::~ConsoleMessage):
              * inspector/ConsoleMessage.h:
              * inspector/Inspector.idl:
              * inspector/InspectorConsoleAgent.cpp: Added.
              (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
              (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
              (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
              (WebCore::InspectorConsoleAgent::clearConsoleMessages):
              (WebCore::InspectorConsoleAgent::reset):
              (WebCore::InspectorConsoleAgent::setFrontend):
              (WebCore::InspectorConsoleAgent::addMessageToConsole):
              (WebCore::InspectorConsoleAgent::startTiming):
              (WebCore::InspectorConsoleAgent::stopTiming):
              (WebCore::InspectorConsoleAgent::count):
              (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):
              (WebCore::InspectorConsoleAgent::didReceiveResponse):
              (WebCore::InspectorConsoleAgent::didFailLoading):
              (WebCore::InspectorConsoleAgent::addConsoleMessage):
              * inspector/InspectorConsoleAgent.h: Added.
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::InspectorController):
              (WebCore::InspectorController::clearConsoleMessages):
              (WebCore::InspectorController::connectFrontend):
              (WebCore::InspectorController::disconnectFrontend):
              (WebCore::InspectorController::didCommitLoad):
              * inspector/InspectorController.h:
              (WebCore::InspectorController::consoleAgent):
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
              (WebCore::InspectorInstrumentation::didFailLoadingImpl):
              (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
              (WebCore::InspectorInstrumentation::addMessageToConsole):
              (WebCore::InspectorInstrumentation::count):
              (WebCore::InspectorInstrumentation::startTiming):
              (WebCore::InspectorInstrumentation::stopTiming):
              (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):
              * inspector/InspectorInstrumentation.h:
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
              (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
              * inspector/front-end/ConsoleView.js:
              (WebInspector.ConsoleView):
              (WebInspector.ConsoleView.prototype.addConsoleMessage):
              (WebInspector.ConsoleView.prototype.updateConsoleMessageExpiredCount):
              (WebInspector.ConsoleView.prototype.consoleMessagesCleared):
              * inspector/front-end/inspector.js:
              * page/Console.cpp:
              (WebCore::Console::addMessage):
              (WebCore::Console::count):
              (WebCore::Console::profile):
              (WebCore::Console::time):
              (WebCore::Console::timeEnd):
              (WebCore::Console::group):
              (WebCore::Console::groupCollapsed):
              (WebCore::Console::groupEnd):
              * page/Console.h:
              * page/Console.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7382e72a
  27. 08 Jan, 2011 1 commit
  28. 09 Dec, 2010 1 commit
    • yurys@chromium.org's avatar
      2010-12-09 Yury Semikhatsky <yurys@chromium.org> · bb594650
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: Console records for failed XHRs should contain call stack and request method
              https://bugs.webkit.org/show_bug.cgi?id=50390
      
              The expectations needed update ue to log format changes.
      
              * http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt:
              * http/tests/inspector/console-resource-errors-expected.txt:
              * http/tests/inspector/console-xhr-logging-expected.txt:
              * platform/chromium/http/tests/inspector/console-resource-errors-expected.txt: Added.
              * platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt: Copied from LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt.
      2010-12-09  Yury Semikhatsky  <yurys@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: Console records for failed XHRs should contain call stack and request method
              https://bugs.webkit.org/show_bug.cgi?id=50390
      
              When inspector front-end is open we capture call stack at the place where request is sent and
              pass the stack along with other request data. There is a new type of console messages which
              is NetworkErrorMessageType, all messages of that type will have requestId field initialized
              with the corresponding network request identifier so that later on when we need to display
              that message in the front-end we could pull request data from the Network panel using
              this identifier. If there are no data for given requestId message formatting falls back to
              the old implementation which lacks such things as call stack, request method and exact
              source location.
      
              * inspector/ConsoleMessage.cpp:
              (WebCore::ConsoleMessage::ConsoleMessage):
              (WebCore::ConsoleMessage::addToFrontend):
              (WebCore::ConsoleMessage::isEqual):
              * inspector/ConsoleMessage.h:
              * inspector/Inspector.idl:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::didReceiveResponse):
              (WebCore::InspectorController::didFailLoading):
              * inspector/InspectorResourceAgent.cpp:
              (WebCore::InspectorResourceAgent::identifierForInitialRequest):
              * inspector/front-end/ConsoleView.js:
              (WebInspector.ConsoleView.prototype.updateMessageRepeatCount):
              (WebInspector.ConsoleMessage):
              (WebInspector.ConsoleMessage.prototype._formatMessage):
              (WebInspector.ConsoleMessage.prototype.toMessageElement):
              (WebInspector.ConsoleMessage.prototype.toString):
              (WebInspector.ConsoleMessage.prototype.isEqual):
              * inspector/front-end/ResourceManager.js:
              (WebInspector.ResourceManager.prototype.identifierForInitialRequest):
              * inspector/front-end/inspector.js:
              (WebInspector.addConsoleMessage):
              * page/Console.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb594650
  29. 30 Nov, 2010 1 commit
    • yurys@chromium.org's avatar
      2010-11-30 Yury Semikhatsky <yurys@chromium.org> · ec8a30f3
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: make ScriptCallStack and ScriptArguments reference counted
              https://bugs.webkit.org/show_bug.cgi?id=50156
      
              No new tests. This refactoring is covered with existing inspector tests.
      
              * bindings/js/JSConsoleCustom.cpp:
              (WebCore::JSConsole::profile):
              (WebCore::JSConsole::profileEnd):
              * bindings/js/ScriptCallStackFactory.cpp:
              (WebCore::createScriptCallStack):
              (WebCore::createScriptArguments):
              * bindings/js/ScriptCallStackFactory.h:
              * bindings/scripts/CodeGeneratorJS.pm:
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/scripts/test/JS/JSTestObj.cpp:
              (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
              * bindings/scripts/test/V8/V8TestObj.cpp:
              (WebCore::TestObjInternal::customArgsAndExceptionCallback):
              * bindings/v8/ScriptCallStackFactory.cpp:
              (WebCore::createScriptCallStack):
              (WebCore::createScriptArguments):
              * bindings/v8/ScriptCallStackFactory.h:
              * bindings/v8/V8ConsoleMessage.cpp:
              (WebCore::V8ConsoleMessage::handler):
              (WebCore::V8ConsoleMessage::dispatchNow):
              * bindings/v8/V8ConsoleMessage.h:
              * bindings/v8/custom/V8ConsoleCustom.cpp:
              (WebCore::V8Console::traceCallback):
              (WebCore::V8Console::assertCallback):
              (WebCore::V8Console::profileCallback):
              (WebCore::V8Console::profileEndCallback):
              * inspector/ConsoleMessage.cpp:
              (WebCore::ConsoleMessage::ConsoleMessage):
              * inspector/ConsoleMessage.h:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::addMessageToConsole):
              (WebCore::InspectorController::startGroup):
              * inspector/InspectorController.h:
              * inspector/ScriptArguments.cpp:
              (WebCore::ScriptArguments::create):
              * inspector/ScriptArguments.h:
              * inspector/ScriptCallFrame.h:
              * inspector/ScriptCallStack.cpp:
              (WebCore::ScriptCallStack::create):
              (WebCore::ScriptCallStack::at):
              (WebCore::ScriptCallStack::size):
              * inspector/ScriptCallStack.h:
              * page/Console.cpp:
              (WebCore::Console::addMessage):
              (WebCore::Console::debug):
              (WebCore::Console::error):
              (WebCore::Console::info):
              (WebCore::Console::log):
              (WebCore::Console::dir):
              (WebCore::Console::dirxml):
              (WebCore::Console::trace):
              (WebCore::Console::assertCondition):
              (WebCore::Console::count):
              (WebCore::Console::markTimeline):
              (WebCore::Console::profile):
              (WebCore::Console::profileEnd):
              (WebCore::Console::timeEnd):
              (WebCore::Console::group):
              (WebCore::Console::groupCollapsed):
              (WebCore::Console::warn):
              * page/Console.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72895 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec8a30f3
  30. 08 Nov, 2010 1 commit
    • yurys@chromium.org's avatar
      2010-11-08 Yury Semikhatsky <yurys@chromium.org> · 02ff0d6c
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: decouple ScriptArguments from ScriptCallStack
              https://bugs.webkit.org/show_bug.cgi?id=48058
      
              ScriptCallFrame and ScriptCallStack are now the same for both JSC and V8.
              The factory functions that allow to create ScriptCallStack from VM-specific
              objects are defined in ScriptCallStackFactory.cpp.
      
              ScriptArguments class is used for passing arguments from JS code to the native
              part.
      
              No new tests. This refactoring is covered with existing Console tests.
      
              * Android.jscbindings.mk:
              * Android.v8bindings.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSBindingsAllInOne.cpp:
              * bindings/js/JSConsoleCustom.cpp:
              (WebCore::JSConsole::profile):
              (WebCore::JSConsole::profileEnd):
              * bindings/js/ScriptCallStackFactory.cpp: Renamed from WebCore/bindings/js/ScriptCallStack.cpp.
              (WebCore::createScriptCallStack):
              (WebCore::createScriptArguments):
              (WebCore::ScriptCallStack::stackTrace):
              * bindings/js/ScriptCallStackFactory.h: Copied from WebCore/bindings/js/ScriptCallFrame.cpp.
              * bindings/js/ScriptState.cpp:
              (WebCore::ScriptStateProtectedPtr::~ScriptStateProtectedPtr):
              (WebCore::ScriptStateProtectedPtr::ScriptStateProtectedPtr):
              (WebCore::ScriptStateProtectedPtr::get):
              * bindings/js/ScriptState.h:
              * bindings/scripts/CodeGeneratorJS.pm:
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/scripts/test/JS/JSTestObj.cpp:
              (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
              * bindings/scripts/test/V8/V8TestObj.cpp:
              (WebCore::TestObjInternal::customArgsAndExceptionCallback):
              * bindings/v8/ScriptCallFrame.h: Removed.
              * bindings/v8/ScriptCallStack.h: Removed.
              * bindings/v8/ScriptCallStackFactory.cpp: Renamed from WebCore/bindings/v8/ScriptCallStack.cpp.
              (WebCore::toScriptCallFrame):
              (WebCore::toScriptCallFramesVector):
              (WebCore::createScriptCallStack):
              (WebCore::createScriptArguments):
              (WebCore::ScriptCallStack::stackTrace):
              * bindings/v8/ScriptCallStackFactory.h: Copied from WebCore/bindings/js/ScriptCallFrame.cpp.
              * bindings/v8/ScriptController.cpp:
              (WebCore::ScriptController::setCaptureCallStackForUncaughtExceptions):
              * bindings/v8/ScriptState.h:
              (WebCore::ScriptStateProtectedPtr::get):
              * bindings/v8/V8ConsoleMessage.cpp:
              (WebCore::V8ConsoleMessage::handler):
              (WebCore::V8ConsoleMessage::dispatchNow):
              * bindings/v8/V8ConsoleMessage.h:
              * bindings/v8/custom/V8ConsoleCustom.cpp:
              (WebCore::V8Console::traceCallback):
              (WebCore::V8Console::assertCallback):
              (WebCore::V8Console::profileCallback):
              (WebCore::V8Console::profileEndCallback):
              * dom/NodeFilter.h:
              * inspector/ConsoleMessage.cpp:
              (WebCore::ConsoleMessage::ConsoleMessage):
              (WebCore::ConsoleMessage::addToFrontend):
              (WebCore::ConsoleMessage::updateRepeatCountInConsole):
              (WebCore::ConsoleMessage::isEqual):
              * inspector/ConsoleMessage.h:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::addMessageToConsole):
              (WebCore::InspectorController::startGroup):
              * inspector/InspectorController.h:
              * inspector/ScriptArguments.cpp: Copied from WebCore/bindings/v8/ScriptCallFrame.cpp.
              (WebCore::ScriptArguments::ScriptArguments):
              (WebCore::ScriptArguments::~ScriptArguments):
              (WebCore::ScriptArguments::argumentAt):
              (WebCore::ScriptArguments::globalState):
              (WebCore::ScriptArguments::getFirstArgumentAsString):
              (WebCore::ScriptArguments::isEqual):
              * inspector/ScriptArguments.h: Copied from WebCore/bindings/js/ScriptCallFrame.h.
              (WebCore::ScriptArguments::argumentCount):
              * inspector/ScriptCallFrame.cpp: Renamed from WebCore/bindings/v8/ScriptCallFrame.cpp.
              (WebCore::ScriptCallFrame::ScriptCallFrame):
              (WebCore::ScriptCallFrame::~ScriptCallFrame):
              (WebCore::ScriptCallFrame::isEqual):
              (WebCore::ScriptCallFrame::buildInspectorObject):
              * inspector/ScriptCallFrame.h: Renamed from WebCore/bindings/js/ScriptCallFrame.h.
              (WebCore::ScriptCallFrame::functionName):
              (WebCore::ScriptCallFrame::sourceURL):
              (WebCore::ScriptCallFrame::lineNumber):
              * inspector/ScriptCallStack.cpp: Renamed from WebCore/bindings/js/ScriptCallFrame.cpp.
              (WebCore::ScriptCallStack::ScriptCallStack):
              (WebCore::ScriptCallStack::~ScriptCallStack):
              (WebCore::ScriptCallStack::at):
              (WebCore::ScriptCallStack::size):
              (WebCore::ScriptCallStack::isEqual):
              (WebCore::ScriptCallStack::buildInspectorObject):
              * inspector/ScriptCallStack.h: Renamed from WebCore/bindings/js/ScriptCallStack.h.
              * page/Console.cpp:
              (WebCore::Console::addMessage):
              (WebCore::Console::debug):
              (WebCore::Console::error):
              (WebCore::Console::info):
              (WebCore::Console::log):
              (WebCore::Console::dir):
              (WebCore::Console::dirxml):
              (WebCore::Console::trace):
              (WebCore::Console::assertCondition):
              (WebCore::Console::count):
              (WebCore::Console::markTimeline):
              (WebCore::Console::profile):
              (WebCore::Console::profileEnd):
              (WebCore::Console::timeEnd):
              (WebCore::Console::group):
              (WebCore::Console::groupCollapsed):
              (WebCore::Console::shouldCaptureFullStackTrace):
              (WebCore::Console::warn):
              * page/Console.h:
              (WebCore::Console::profiles):
              * page/Console.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02ff0d6c
  31. 22 Oct, 2010 2 commits
    • yurys@chromium.org's avatar
      2010-10-21 Yury Semikhatsky <yurys@chromium.org> · 95859ed4
      yurys@chromium.org authored
              Unreviewed, rolling out r70298.WebKit win compilation failure.
              http://trac.webkit.org/changeset/70298
              https://bugs.webkit.org/show_bug.cgi?id=48122
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70300 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95859ed4
    • yurys@chromium.org's avatar
      2010-10-21 Yury Semikhatsky <yurys@chromium.org> · f1e6db40
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: decouple ScriptArguments from ScriptCallStack
              https://bugs.webkit.org/show_bug.cgi?id=48058
      
              ScriptCallFrame and ScriptCallStack are now the same for both JSC and V8.
              The factory functions that allow to create ScriptCallStack from VM-specific
              objects are defined in ScriptCallStackFactory.cpp.
      
              ScriptArguments class is used for passing arguments from JS code to the native
              part.
      
              No new tests. This refactoring is covered with existing Console tests.
      
              * WebCore.gypi:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/ScriptCallFrame.cpp: Removed.
              * bindings/js/ScriptCallFrame.h: Removed.
              * bindings/js/ScriptCallStack.cpp: Removed.
              * bindings/js/ScriptCallStack.h: Removed.
              * bindings/js/ScriptCallStackFactory.cpp: Added.
              (WebCore::createScriptCallStack):
              (WebCore::createScriptArguments):
              (WebCore::ScriptCallStack::stackTrace):
              * bindings/js/ScriptCallStackFactory.h: Added.
              * bindings/js/ScriptState.h:
              (WebCore::ScriptStateProtectedPtr::get):
              * bindings/scripts/CodeGeneratorJS.pm:
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/v8/ScriptCallFrame.cpp: Removed.
              * bindings/v8/ScriptCallFrame.h: Removed.
              * bindings/v8/ScriptCallStack.cpp: Removed.
              * bindings/v8/ScriptCallStack.h: Removed.
              * bindings/v8/ScriptCallStackFactory.cpp: Added.
              (WebCore::toScriptCallFrame):
              (WebCore::toScriptCallFramesVector):
              (WebCore::createScriptCallStack):
              (WebCore::createScriptArguments):
              (WebCore::ScriptCallStack::stackTrace):
              * bindings/v8/ScriptCallStackFactory.h: Added.
              * bindings/v8/ScriptController.cpp:
              (WebCore::ScriptController::setCaptureCallStackForUncaughtExceptions):
              * bindings/v8/ScriptState.h:
              (WebCore::ScriptStateProtectedPtr::get):
              * bindings/v8/V8ConsoleMessage.cpp:
              (WebCore::V8ConsoleMessage::handler):
              (WebCore::V8ConsoleMessage::dispatchNow):
              * bindings/v8/V8ConsoleMessage.h:
              * bindings/v8/custom/V8ConsoleCustom.cpp:
              (WebCore::V8Console::traceCallback):
              (WebCore::V8Console::assertCallback):
              * inspector/ConsoleMessage.cpp:
              (WebCore::ConsoleMessage::ConsoleMessage):
              (WebCore::ConsoleMessage::addToFrontend):
              (WebCore::ConsoleMessage::updateRepeatCountInConsole):
              (WebCore::ConsoleMessage::isEqual):
              * inspector/ConsoleMessage.h:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::addMessageToConsole):
              (WebCore::InspectorController::startGroup):
              * inspector/InspectorController.h:
              * inspector/ScriptArguments.cpp: Added.
              (WebCore::ScriptArguments::ScriptArguments):
              (WebCore::ScriptArguments::~ScriptArguments):
              (WebCore::ScriptArguments::argumentAt):
              (WebCore::ScriptArguments::globalState):
              (WebCore::ScriptArguments::getFirstArgumentAsString):
              (WebCore::ScriptArguments::isEqual):
              * inspector/ScriptArguments.h: Added.
              (WebCore::ScriptArguments::argumentCount):
              * inspector/ScriptCallFrame.cpp: Added.
              (WebCore::ScriptCallFrame::ScriptCallFrame):
              (WebCore::ScriptCallFrame::~ScriptCallFrame):
              (WebCore::ScriptCallFrame::isEqual):
              (WebCore::ScriptCallFrame::buildInspectorObject):
              * inspector/ScriptCallFrame.h: Added.
              (WebCore::ScriptCallFrame::functionName):
              (WebCore::ScriptCallFrame::sourceURL):
              (WebCore::ScriptCallFrame::lineNumber):
              * inspector/ScriptCallStack.cpp: Added.
              (WebCore::ScriptCallStack::ScriptCallStack):
              (WebCore::ScriptCallStack::~ScriptCallStack):
              (WebCore::ScriptCallStack::at):
              (WebCore::ScriptCallStack::size):
              (WebCore::ScriptCallStack::isEqual):
              (WebCore::ScriptCallStack::buildInspectorObject):
              * inspector/ScriptCallStack.h: Added.
              * page/Console.cpp:
              (WebCore::Console::addMessage):
              (WebCore::Console::debug):
              (WebCore::Console::error):
              (WebCore::Console::info):
              (WebCore::Console::log):
              (WebCore::Console::dir):
              (WebCore::Console::dirxml):
              (WebCore::Console::trace):
              (WebCore::Console::assertCondition):
              (WebCore::Console::count):
              (WebCore::Console::markTimeline):
              (WebCore::Console::profile):
              (WebCore::Console::profileEnd):
              (WebCore::Console::timeEnd):
              (WebCore::Console::group):
              (WebCore::Console::groupCollapsed):
              (WebCore::Console::shouldCaptureFullStackTrace):
              (WebCore::Console::warn):
              * page/Console.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70298 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1e6db40
  32. 21 Oct, 2010 1 commit