1. 22 Feb, 2012 1 commit
    • abarth@webkit.org's avatar
      Frame and Navigator shouldn't need to worry about Geolocation · 047b877c
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=78860
      
      Reviewed by Eric Seidel.
      
      This patch removes some Geolocation-specific code from Frame and
      Navigator in favor of our new supplemental module mechanism.  We're
      still refining the module system, but we seem to be converging on a
      simple Observer/Supplement design.
      
      In a future patch, I'll move the remaining Geolocation-related files in
      WebCore into Modules/geolocation.  This patch appears to be the first
      patch that introduces a module used by all the various build systems,
      which is why there's a bit more build system overhead than usual.
      
      * Modules/geolocation: Added.
      * Modules/geolocation/NavigatorGeolocation.cpp: Added.
      (WebCore):
      (WebCore::NavigatorGeolocation::NavigatorGeolocation):
      (WebCore::NavigatorGeolocation::~NavigatorGeolocation):
      (WebCore::NavigatorGeolocation::pageDestroyed):
      (WebCore::NavigatorGeolocation::from):
      (WebCore::NavigatorGeolocation::geolocation):
      * Modules/geolocation/NavigatorGeolocation.h: Added.
      (WebCore):
      (NavigatorGeolocation):
      * Modules/geolocation/NavigatorGeolocation.idl: Added.
          - I've temporarily disabled this API for GObject because it generates
            a strange compile error.  Once I land this patch, I'll spend some
            more time fixing the compile error.
      * page/DOMWindow.cpp:
      (WebCore):
      * page/DOMWindow.h:
      (DOMWindow):
      * page/Frame.cpp:
      (WebCore::Frame::pageDestroyed):
      (WebCore::Frame::transferChildFrameToNewDocument):
      * page/FrameDestructionObserver.cpp:
      (WebCore::FrameDestructionObserver::pageDestroyed):
      (WebCore):
      * page/FrameDestructionObserver.h:
      (FrameDestructionObserver):
      * page/Navigator.cpp:
      (WebCore):
      * page/Navigator.h:
      (WebCore):
      (Navigator):
      * page/Navigator.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108428 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      047b877c
  2. 18 Jan, 2012 1 commit
    • commit-queue@webkit.org's avatar
      [Internals] Should be able to access corresponding Document object. · 7c2e4e38
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76425
      
      .:
      
      Added exported symbols.
      
      Patch by Hajime Morrita <morrita@chromium.org> on 2012-01-17
      Reviewed by Adam Barth.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      Patch by Hajime Morrita <morrita@chromium.org> on 2012-01-17
      Reviewed by Adam Barth.
      
      - Allow FrameDestructionObserver to re-setting the Frame reference.
      - Make Internals a subclass of FrameDestructionObserver.
      
      Since Internals::reset() is called for each test, we can access
      the acive Frame object during the test. The frame reference will be
      used by coming changes.
      
      No new tests. Covered by existing tests.
      
      * WebCore.exp.in:
      * page/FrameDestructionObserver.cpp:
      (WebCore::FrameDestructionObserver::FrameDestructionObserver):
      (WebCore::FrameDestructionObserver::~FrameDestructionObserver):
      (WebCore::FrameDestructionObserver::observe):
      * page/FrameDestructionObserver.h:
      * testing/Internals.cpp:
      (WebCore::Internals::Internals):
      (WebCore::Internals::reset):
      * testing/Internals.h:
      
      Source/WebKit2:
      
      Patch by Hajime Morrita <morrita@chromium.org> on 2012-01-17
      Reviewed by Adam Barth.
      
      * win/WebKit2.def: Added exporting symbols.
      * win/WebKit2CFLite.def: Added exporting symbols.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105245 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c2e4e38
  3. 06 Jan, 2012 1 commit
    • abarth@webkit.org's avatar
      Move FrameDestructionObserver to its own file · e45e18f7
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75693
      
      Reviewed by Eric Seidel.
      
      We should have one class per file, on general principles.  Also, this
      make it possible to use this class in DOMWindow without introducing a
      circular include dependency.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * page/Frame.cpp:
      * page/Frame.h:
      * page/FrameDestructionObserver.cpp: Added.
      (WebCore::FrameDestructionObserver::FrameDestructionObserver):
      (WebCore::FrameDestructionObserver::~FrameDestructionObserver):
      (WebCore::FrameDestructionObserver::frameDestroyed):
      * page/FrameDestructionObserver.h: Added.
      (WebCore::FrameDestructionObserver::frame):
      * plugins/DOMMimeType.h:
      * plugins/DOMPlugin.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104344 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e45e18f7