1. 27 Dec, 2013 1 commit
    • dbates@webkit.org's avatar
      [iOS] Upstream WebCore/page changes · 4da1af80
      dbates@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=126180
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      * WebCore.xcodeproj/project.pbxproj:
      * dom/EventNames.h:
      (WebCore::EventNames::isGestureEventType): Added.
      * page/AlternativeTextClient.h: Do not define WTF_USE_DICTATION_ALTERNATIVES when building for iOS.
      * page/Chrome.cpp:
      (WebCore::Chrome::Chrome):
      (WebCore::Chrome::dispatchViewportPropertiesDidChange): Added; guarded by PLATFORM(IOS).
      (WebCore::Chrome::setCursor): Make this an empty function when building for iOS.
      (WebCore::Chrome::setCursorHiddenUntilMouseMoves): Ditto.
      (WebCore::Chrome::didReceiveDocType): Added; iOS-specific.
      * page/Chrome.h:
      (WebCore::Chrome::setDispatchViewportDataDidChangeSuppressed): Added; guarded by PLATFORM(IOS).
      * page/ChromeClient.h:
      (WebCore::ChromeClient::didFlushCompositingLayers): Added; guarded by PLATFORM(IOS).
      (WebCore::ChromeClient::fetchCustomFixedPositionLayoutRect): Added; guarded by PLATFORM(IOS).
      (WebCore::ChromeClient::updateViewportConstrainedLayers): Added; guarded by PLATFORM(IOS).
      * page/DOMTimer.cpp:
      (WebCore::DOMTimer::install): Added iOS-specific code.
      (WebCore::DOMTimer::fired): Ditto.
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::DOMWindow): Ditto.
      (WebCore::DOMWindow::innerHeight): Ditto.
      (WebCore::DOMWindow::innerWidth): Ditto.
      (WebCore::DOMWindow::scrollX): Ditto.
      (WebCore::DOMWindow::scrollY): Ditto.
      (WebCore::DOMWindow::scrollBy): Ditto.
      (WebCore::DOMWindow::scrollTo): Ditto.
      (WebCore::DOMWindow::clearTimeout): Ditto.
      (WebCore::DOMWindow::addEventListener): Ditto.
      (WebCore::DOMWindow::incrementScrollEventListenersCount): Added; guarded by PLATFORM(IOS).
      (WebCore::DOMWindow::decrementScrollEventListenersCount): Added; guarded by PLATFORM(IOS).
      (WebCore::DOMWindow::resetAllGeolocationPermission): Added; Also added FIXME comment.
      (WebCore::DOMWindow::removeEventListener): Added iOS-specific code.
      (WebCore::DOMWindow::dispatchEvent): Modified to prevent dispatching duplicate pageshow and pagehide
      events per <http://www.whatwg.org/specs/web-apps/current-work/multipage/history.html#event-pageshow>.
      (WebCore::DOMWindow::removeAllEventListeners): Added iOS-specific code.
      * page/DOMWindow.h:
      * page/DOMWindow.idl: Added IOS_GESTURE_EVENTS-guarded attributes: ongesture{change, end, start}. Also
      added IOS_TOUCH_EVENTS-guarded attributes: {Touch, TouchList}Constructor.
      * page/EditorClient.h:
      * page/EventHandler.cpp:
      (WebCore::EventHandler::EventHandler): Added iOS-specific code.
      (WebCore::EventHandler::clear): Ditto.
      (WebCore::EventHandler::startPanScrolling): Make this an empty function when building for iOS.
      (WebCore::EventHandler::handleMousePressEvent): Modified to invalidate a click when the clicked node is
      null. Also, opt out of code for updating the scrollbars as UIKit manages scrollbars on iOS.
      (WebCore::EventHandler::handleMouseMoveEvent): Opt of code for updating the scrollbars and cursor when building on iOS.
      (WebCore::hitTestResultInFrame): Made this a file-local static function since it's only used in EventHandler.cpp.
      (WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled): Added iOS-specific code.
      * page/EventHandler.h:
      * page/FocusController.h:
      * page/Frame.cpp:
      (WebCore::Frame::Frame): Added iOS-specific code.
      (WebCore::Frame::scrollOverflowLayer): Added; iOS-specific.
      (WebCore::Frame::overflowAutoScrollTimerFired): Added; iOS-specific.
      (WebCore::Frame::startOverflowAutoScroll): Added; iOS-specific.
      (WebCore::Frame::checkOverflowScroll): Added; iOS-specific.
      (WebCore::Frame::willDetachPage): Added iOS-specific code.
      (WebCore::Frame::createView): Ditto.
      (WebCore::Frame::setSelectionChangeCallbacksDisabled): Added; iOS-specific.
      (WebCore::Frame::selectionChangeCallbacksDisabled): Added; iOS-specific.
      * page/Frame.h:
      (WebCore::Frame::timersPaused): Added; guarded by PLATFORM(IOS).
      * page/FrameView.cpp:
      (WebCore::FrameView::FrameView): Added iOS-specific code.
      (WebCore::FrameView::clear): Ditto.
      (WebCore::FrameView::flushCompositingStateForThisFrame): Ditto.
      (WebCore::FrameView::graphicsLayerForPlatformWidget): Added.
      (WebCore::FrameView::scheduleLayerFlushAllowingThrottling): Added.
      (WebCore::FrameView::layout): Added iOS-specific code.
      (WebCore::countRenderedCharactersInRenderObjectWithThreshold): Added; helper function used by FrameView::renderedCharactersExceed().
      Also added FIXME comment.
      (WebCore::FrameView::renderedCharactersExceed): Added.
      (WebCore::FrameView::visibleContentsResized): Added iOS-specific code.
      (WebCore::FrameView::adjustTiledBackingCoverage): Ditto.
      (WebCore::FrameView::performPostLayoutTasks): Ditto.
      (WebCore::FrameView::sendResizeEventIfNeeded): Ditto.
      (WebCore::FrameView::paintContents): Added iOS-specific code. Also added FIXME comments.
      (WebCore::FrameView::setUseCustomFixedPositionLayoutRect): Added; iOS-specific.
      (WebCore::FrameView::setCustomFixedPositionLayoutRect): Added; iOS-specific.
      (WebCore::FrameView::updateFixedPositionLayoutRect): Added; iOS-specific.
      * page/FrameView.h:
      * page/Navigator.cpp:
      (WebCore::Navigator::standalone): Added; iOS-specific.
      * page/Navigator.h:
      * page/Navigator.idl: Added WTF_PLATFORM_IOS-guarded attribute: standalone. Also added FIXME comment.
      * page/NavigatorBase.cpp:
      (WebCore::NavigatorBase::platform): Added iOS-specific code.
      * page/Page.h:
      (WebCore::Page::hasCustomHTMLTokenizerTimeDelay): Added; guarded by PLATFORM(IOS). Also added FIXME comment
      to remove this method.
      (WebCore::Page::customHTMLTokenizerTimeDelay): Added; guarded by PLATFORM(IOS). Also added FIXME comment
      to remove this method.
      * page/PageGroup.cpp:
      (WebCore::PageGroup::removeVisitedLink): Added.
      * page/PageGroup.h:
      * page/Settings.cpp:
      (WebCore::Settings::Settings):
      (WebCore::Settings::setScriptEnabled): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::setStandalone): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::setAudioSessionCategoryOverride): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::audioSessionCategoryOverride): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::setNetworkDataUsageTrackingEnabled): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::networkDataUsageTrackingEnabled): Added; guarded by PLATFORM(IOS).
      (WebCore::sharedNetworkInterfaceNameGlobal): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::setNetworkInterfaceName): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::networkInterfaceName): Added; guarded by PLATFORM(IOS).
      * page/Settings.h:
      (WebCore::Settings::setMaxParseDuration): Added; guarded by PLATFORM(IOS). Also added FIXME comment.
      (WebCore::Settings::maxParseDuration): Added; guarded by PLATFORM(IOS). Also added FIXME comment.
      (WebCore::Settings::standalone): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::setTelephoneNumberParsingEnabled): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::telephoneNumberParsingEnabled): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::setMediaDataLoadsAutomatically): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::mediaDataLoadsAutomatically): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::setShouldTransformsAffectOverflow): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::shouldTransformsAffectOverflow): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::setShouldDispatchJavaScriptWindowOnErrorEvents): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::shouldDispatchJavaScriptWindowOnErrorEvents): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::setAlwaysUseBaselineOfPrimaryFont): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::alwaysUseBaselineOfPrimaryFont): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::setAlwaysUseAcceleratedOverflowScroll): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::alwaysUseAcceleratedOverflowScroll): Added; guarded by PLATFORM(IOS).
      * page/Settings.in: Added IOS_AIRPLAY-guarded setting: mediaPlaybackAllowsAirPlay.
      * page/animation/CSSPropertyAnimation.cpp:
      (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): Added iOS-specific code and FIXME comment.
      * page/ios/EventHandlerIOS.mm: Added.
      * page/ios/FrameIOS.mm: Added.
      * page/mac/ChromeMac.mm:
      * page/mac/PageMac.cpp:
      (WebCore::Page::addSchedulePair): Opt out of code when building for iOS.
      (WebCore::Page::removeSchedulePair): Ditto.
      * page/mac/SettingsMac.mm:
      (WebCore::Settings::shouldEnableScreenFontSubstitutionByDefault): Added iOS-specific code.
      * page/mac/WebCoreFrameView.h:
      
      Source/WebKit/ios:
      
      * WebCoreSupport/WebChromeClientIOS.mm: Substitute ENABLE(IOS_TOUCH_EVENTS) for ENABLE(TOUCH_EVENTS).
      
      Source/WebKit2:
      
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      * WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm: Added.
      * WebProcess/WebPage/WebPage.cpp: Include header <WebCore/HitTestResult.h>.
      
      Source/WTF:
      
      * wtf/FeatureDefines.h: Define ENABLE_IOS_TOUCH_EVENTS to be enabled by default
      when building iOS with ENABLE(TOUCH_EVENTS).
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4da1af80
  2. 28 Nov, 2013 1 commit
  3. 18 Oct, 2013 1 commit
    • andersca@apple.com's avatar
      Remove spaces between template angle brackets · c3523f8d
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123040
      
      Reviewed by Andreas Kling.
      
      Source/JavaScriptCore:
      
      * API/JSCallbackObject.cpp:
      (JSC::::create):
      * API/JSObjectRef.cpp:
      * bytecode/CodeBlock.h:
      (JSC::CodeBlock::constants):
      (JSC::CodeBlock::setConstantRegisters):
      * bytecode/DFGExitProfile.h:
      * bytecode/EvalCodeCache.h:
      * bytecode/Operands.h:
      * bytecode/UnlinkedCodeBlock.h:
      (JSC::UnlinkedCodeBlock::constantRegisters):
      * bytecode/Watchpoint.h:
      * bytecompiler/BytecodeGenerator.h:
      * bytecompiler/StaticPropertyAnalysis.h:
      * bytecompiler/StaticPropertyAnalyzer.h:
      * dfg/DFGArgumentsSimplificationPhase.cpp:
      * dfg/DFGBlockInsertionSet.h:
      * dfg/DFGCSEPhase.cpp:
      (JSC::DFG::performCSE):
      (JSC::DFG::performStoreElimination):
      * dfg/DFGCommonData.h:
      * dfg/DFGDesiredStructureChains.h:
      * dfg/DFGDesiredWatchpoints.h:
      * dfg/DFGJITCompiler.h:
      * dfg/DFGOSRExitCompiler32_64.cpp:
      (JSC::DFG::OSRExitCompiler::compileExit):
      * dfg/DFGOSRExitCompiler64.cpp:
      (JSC::DFG::OSRExitCompiler::compileExit):
      * dfg/DFGWorklist.h:
      * heap/BlockAllocator.h:
      (JSC::CopiedBlock):
      (JSC::MarkedBlock):
      (JSC::WeakBlock):
      (JSC::MarkStackSegment):
      (JSC::CopyWorkListSegment):
      (JSC::HandleBlock):
      * heap/Heap.h:
      * heap/Local.h:
      * heap/MarkedBlock.h:
      * heap/Strong.h:
      * jit/AssemblyHelpers.cpp:
      (JSC::AssemblyHelpers::decodedCodeMapFor):
      * jit/AssemblyHelpers.h:
      * jit/SpecializedThunkJIT.h:
      * parser/Nodes.h:
      * parser/Parser.cpp:
      (JSC::::parseIfStatement):
      * parser/Parser.h:
      (JSC::Scope::copyCapturedVariablesToVector):
      (JSC::parse):
      * parser/ParserArena.h:
      * parser/SourceProviderCacheItem.h:
      * profiler/LegacyProfiler.cpp:
      (JSC::dispatchFunctionToProfiles):
      * profiler/LegacyProfiler.h:
      (JSC::LegacyProfiler::currentProfiles):
      * profiler/ProfileNode.h:
      (JSC::ProfileNode::children):
      * profiler/ProfilerDatabase.h:
      * runtime/Butterfly.h:
      (JSC::Butterfly::contiguousInt32):
      (JSC::Butterfly::contiguous):
      * runtime/GenericTypedArrayViewInlines.h:
      (JSC::::create):
      * runtime/Identifier.h:
      (JSC::Identifier::add):
      * runtime/JSPromise.h:
      * runtime/PropertyMapHashTable.h:
      * runtime/PropertyNameArray.h:
      * runtime/RegExpCache.h:
      * runtime/SparseArrayValueMap.h:
      * runtime/SymbolTable.h:
      * runtime/VM.h:
      * tools/CodeProfile.cpp:
      (JSC::truncateTrace):
      * tools/CodeProfile.h:
      * yarr/YarrInterpreter.cpp:
      * yarr/YarrInterpreter.h:
      (JSC::Yarr::BytecodePattern::BytecodePattern):
      * yarr/YarrJIT.cpp:
      (JSC::Yarr::YarrGenerator::opCompileParenthesesSubpattern):
      (JSC::Yarr::YarrGenerator::opCompileParentheticalAssertion):
      (JSC::Yarr::YarrGenerator::opCompileBody):
      * yarr/YarrPattern.cpp:
      (JSC::Yarr::YarrPatternConstructor::checkForTerminalParentheses):
      (JSC::Yarr::YarrPatternConstructor::optimizeDotStarWrappedExpressions):
      * yarr/YarrPattern.h:
      
      Source/WebCore:
      
      * Modules/encryptedmedia/MediaKeySession.h:
      * Modules/encryptedmedia/MediaKeys.h:
      * Modules/geolocation/Geolocation.h:
      * Modules/geolocation/GeolocationController.cpp:
      (WebCore::GeolocationController::positionChanged):
      (WebCore::GeolocationController::errorOccurred):
      * Modules/geolocation/GeolocationController.h:
      * Modules/indexeddb/IDBCallbacks.h:
      * Modules/indexeddb/IDBDatabase.h:
      * Modules/indexeddb/IDBDatabaseBackendInterface.h:
      * Modules/indexeddb/IDBEventDispatcher.cpp:
      (WebCore::IDBEventDispatcher::dispatch):
      * Modules/indexeddb/IDBEventDispatcher.h:
      * Modules/indexeddb/IDBKey.h:
      * Modules/indexeddb/IDBObjectStore.h:
      * Modules/indexeddb/IDBPendingTransactionMonitor.cpp:
      * Modules/indexeddb/IDBRequest.cpp:
      (WebCore::IDBRequest::dispatchEvent):
      * Modules/indexeddb/IDBRequest.h:
      (WebCore::IDBRequest::onSuccessWithPrefetch):
      * Modules/indexeddb/IDBTransaction.cpp:
      (WebCore::IDBTransaction::dispatchEvent):
      * Modules/indexeddb/IDBTransaction.h:
      * Modules/mediacontrols/MediaControlsHost.cpp:
      (WebCore::MediaControlsHost::sortedTrackListForMenu):
      * Modules/mediacontrols/MediaControlsHost.h:
      * Modules/mediasource/MediaSource.cpp:
      (WebCore::MediaSource::activeRanges):
      * Modules/mediasource/MediaSource.h:
      * Modules/mediasource/MediaSourceBase.cpp:
      (WebCore::MediaSourceBase::buffered):
      * Modules/mediasource/MediaSourceBase.h:
      * Modules/mediasource/MediaSourceRegistry.cpp:
      (WebCore::MediaSourceRegistry::unregisterURL):
      * Modules/mediasource/MediaSourceRegistry.h:
      * Modules/mediasource/SourceBufferList.h:
      * Modules/mediasource/WebKitMediaSource.cpp:
      (WebCore::WebKitMediaSource::activeRanges):
      * Modules/mediasource/WebKitMediaSource.h:
      * Modules/mediasource/WebKitSourceBufferList.h:
      * Modules/mediastream/MediaStream.cpp:
      (WebCore::MediaStream::scheduledEventTimerFired):
      * Modules/mediastream/MediaStream.h:
      * Modules/mediastream/MediaStreamRegistry.h:
      * Modules/mediastream/MediaStreamTrack.h:
      * Modules/mediastream/RTCDTMFSender.cpp:
      (WebCore::RTCDTMFSender::scheduledEventTimerFired):
      * Modules/mediastream/RTCDTMFSender.h:
      * Modules/mediastream/RTCDataChannel.cpp:
      (WebCore::RTCDataChannel::scheduledEventTimerFired):
      * Modules/mediastream/RTCDataChannel.h:
      * Modules/mediastream/RTCPeerConnection.cpp:
      (WebCore::RTCPeerConnection::stop):
      (WebCore::RTCPeerConnection::scheduledEventTimerFired):
      * Modules/mediastream/RTCPeerConnection.h:
      * Modules/mediastream/RTCStatsResponse.h:
      (WebCore::RTCStatsResponse::result):
      * Modules/notifications/Notification.h:
      * Modules/notifications/NotificationCenter.h:
      * Modules/speech/SpeechSynthesis.cpp:
      (WebCore::SpeechSynthesis::getVoices):
      * Modules/speech/SpeechSynthesis.h:
      * Modules/webaudio/AudioBuffer.h:
      * Modules/webaudio/AudioNode.h:
      * Modules/webaudio/AudioNodeOutput.h:
      * Modules/webaudio/MediaStreamAudioSource.cpp:
      (WebCore::MediaStreamAudioSource::setAudioFormat):
      (WebCore::MediaStreamAudioSource::consumeAudio):
      * Modules/webaudio/PeriodicWave.h:
      * Modules/webaudio/ScriptProcessorNode.h:
      * Modules/webdatabase/AbstractDatabaseServer.h:
      * Modules/webdatabase/DatabaseBackend.h:
      * Modules/webdatabase/DatabaseManager.cpp:
      (WebCore::DatabaseManager::origins):
      * Modules/webdatabase/DatabaseManager.h:
      * Modules/webdatabase/DatabaseServer.cpp:
      (WebCore::DatabaseServer::origins):
      * Modules/webdatabase/DatabaseServer.h:
      * Modules/webdatabase/DatabaseThread.h:
      * Modules/webdatabase/DatabaseTracker.cpp:
      (WebCore::DatabaseTracker::interruptAllDatabasesForContext):
      (WebCore::DatabaseTracker::origins):
      (WebCore::DatabaseTracker::getOpenDatabases):
      (WebCore::DatabaseTracker::deleteAllDatabases):
      (WebCore::DatabaseTracker::deleteDatabaseFile):
      * Modules/webdatabase/DatabaseTracker.h:
      * Modules/webdatabase/SQLStatementBackend.cpp:
      * Modules/webdatabase/SQLTransactionBackend.cpp:
      * Modules/webdatabase/SQLTransactionBackend.h:
      * Modules/webdatabase/SQLTransactionCoordinator.cpp:
      (WebCore::SQLTransactionCoordinator::shutdown):
      * Modules/webdatabase/SQLTransactionCoordinator.h:
      * Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
      (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveBinaryData):
      (WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):
      (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveBinaryDataCallback):
      * Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
      * Modules/websockets/WebSocket.cpp:
      (WebCore::WebSocket::didReceiveBinaryData):
      * Modules/websockets/WebSocket.h:
      * Modules/websockets/WebSocketChannel.cpp:
      (WebCore::WebSocketChannel::processFrame):
      * Modules/websockets/WebSocketChannel.h:
      * Modules/websockets/WebSocketChannelClient.h:
      (WebCore::WebSocketChannelClient::didReceiveBinaryData):
      * Modules/websockets/WebSocketExtensionDispatcher.h:
      * Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
      (WebCore::workerGlobalScopeDidReceiveBinaryData):
      (WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveBinaryData):
      (WebCore::WorkerThreadableWebSocketChannel::mainThreadSendArrayBuffer):
      (WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
      * Modules/websockets/WorkerThreadableWebSocketChannel.h:
      * accessibility/AXObjectCache.cpp:
      (WebCore::AXObjectCache::~AXObjectCache):
      * accessibility/AXObjectCache.h:
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::ariaLabeledByText):
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityText::AccessibilityText):
      * bindings/js/DOMWrapperWorld.h:
      * bindings/js/JSDOMBinding.h:
      (WebCore::toRefPtrNativeArray):
      * bindings/js/JSDOMGlobalObject.h:
      * bindings/js/JSMutationCallback.cpp:
      (WebCore::JSMutationCallback::call):
      * bindings/js/JSMutationCallback.h:
      * bindings/js/JSWebGLRenderingContextCustom.cpp:
      (WebCore::JSWebGLRenderingContext::getAttachedShaders):
      * bindings/js/PageScriptDebugServer.h:
      * bindings/js/ScheduledAction.h:
      * bindings/js/ScriptController.cpp:
      (WebCore::ScriptController::collectIsolatedContexts):
      * bindings/js/ScriptController.h:
      * bindings/js/ScriptDebugServer.h:
      * bindings/js/ScriptProfile.cpp:
      (WebCore::buildInspectorObjectFor):
      * bindings/objc/ObjCNodeFilterCondition.h:
      * bridge/objc/objc_class.h:
      * bridge/runtime_root.cpp:
      (JSC::Bindings::RootObject::invalidate):
      * bridge/runtime_root.h:
      * css/BasicShapeFunctions.cpp:
      (WebCore::basicShapeForValue):
      * css/CSSBasicShapes.h:
      (WebCore::CSSBasicShapePolygon::values):
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::ComputedStyleExtractor::valueForFilter):
      * css/CSSFontFace.h:
      * css/CSSFontFaceSource.h:
      * css/CSSFontSelector.cpp:
      (WebCore::CSSFontSelector::addFontFaceRule):
      (WebCore::CSSFontSelector::getFontFace):
      (WebCore::CSSFontSelector::beginLoadTimerFired):
      * css/CSSFontSelector.h:
      * css/CSSGroupingRule.h:
      * css/CSSImageGeneratorValue.h:
      * css/CSSParserValues.cpp:
      (WebCore::CSSParserSelector::adoptSelectorVector):
      * css/CSSParserValues.h:
      * css/CSSPropertySourceData.h:
      * css/CSSRuleList.h:
      (WebCore::StaticCSSRuleList::rules):
      * css/CSSSegmentedFontFace.cpp:
      (WebCore::CSSSegmentedFontFace::fontLoaded):
      * css/CSSSegmentedFontFace.h:
      * css/CSSSelectorList.cpp:
      (WebCore::CSSSelectorList::adoptSelectorVector):
      * css/CSSSelectorList.h:
      * css/CSSStyleSheet.h:
      * css/CSSValue.h:
      (WebCore::compareCSSValueVector):
      * css/CSSValuePool.h:
      * css/DocumentRuleSets.cpp:
      (WebCore::DocumentRuleSets::collectRulesFromUserStyleSheets):
      (WebCore::DocumentRuleSets::appendAuthorStyleSheets):
      * css/DocumentRuleSets.h:
      * css/ElementRuleCollector.cpp:
      (WebCore::ElementRuleCollector::matchedRuleList):
      * css/ElementRuleCollector.h:
      * css/FontLoader.h:
      * css/InspectorCSSOMWrappers.cpp:
      (WebCore::InspectorCSSOMWrappers::collectFromStyleSheetContents):
      (WebCore::InspectorCSSOMWrappers::collectFromStyleSheets):
      * css/InspectorCSSOMWrappers.h:
      * css/MediaList.cpp:
      (WebCore::MediaQuerySet::parse):
      (WebCore::MediaList::item):
      (WebCore::reportMediaQueryWarningIfNeeded):
      * css/MediaList.h:
      (WebCore::MediaQuerySet::queryVector):
      * css/MediaQueryEvaluator.cpp:
      (WebCore::MediaQueryEvaluator::eval):
      * css/MediaQueryMatcher.h:
      * css/PropertySetCSSStyleDeclaration.cpp:
      (WebCore::PropertySetCSSStyleDeclaration::cloneAndCacheForCSSOM):
      * css/PropertySetCSSStyleDeclaration.h:
      * css/RuleSet.cpp:
      (WebCore::RuleSet::addToRuleSet):
      (WebCore::RuleSet::addRegionRule):
      (WebCore::RuleSet::addChildRules):
      (WebCore::RuleSet::addRulesFromSheet):
      * css/RuleSet.h:
      * css/SelectorFilter.h:
      * css/StyleInvalidationAnalysis.cpp:
      (WebCore::StyleInvalidationAnalysis::analyzeStyleSheet):
      * css/StylePropertySet.cpp:
      (WebCore::StylePropertySet::getLayeredShorthandValue):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::appendAuthorStyleSheets):
      (WebCore::StyleResolver::keyframeStylesForAnimation):
      (WebCore::StyleResolver::styleRulesForElement):
      (WebCore::StyleResolver::pseudoStyleRulesForElement):
      (WebCore::StyleResolver::resolveVariables):
      (WebCore::StyleResolver::applyProperty):
      (WebCore::StyleResolver::loadPendingSVGDocuments):
      (WebCore::StyleResolver::loadPendingShaders):
      * css/StyleResolver.h:
      * css/StyleRule.cpp:
      (WebCore::StyleRule::splitIntoMultipleRulesWithMaximumSelectorComponentCount):
      (WebCore::StyleRuleGroup::StyleRuleGroup):
      (WebCore::StyleRuleMedia::StyleRuleMedia):
      (WebCore::StyleRuleSupports::StyleRuleSupports):
      (WebCore::StyleRuleRegion::StyleRuleRegion):
      * css/StyleRule.h:
      (WebCore::StyleRule::parserAdoptSelectorVector):
      (WebCore::StyleRulePage::parserAdoptSelectorVector):
      (WebCore::StyleRuleGroup::childRules):
      (WebCore::StyleRuleMedia::create):
      (WebCore::StyleRuleSupports::create):
      (WebCore::StyleRuleRegion::create):
      (WebCore::StyleRuleHost::create):
      (WebCore::StyleRuleHost::StyleRuleHost):
      * css/StyleScopeResolver.h:
      * css/StyleSheetContents.cpp:
      (WebCore::StyleSheetContents::parserAppendRule):
      (WebCore::childRulesHaveFailedOrCanceledSubresources):
      * css/StyleSheetContents.h:
      (WebCore::StyleSheetContents::childRules):
      (WebCore::StyleSheetContents::importRules):
      * css/StyleSheetList.cpp:
      (WebCore::StyleSheetList::styleSheets):
      (WebCore::StyleSheetList::item):
      * css/StyleSheetList.h:
      * css/WebKitCSSKeyframesRule.h:
      (WebCore::StyleRuleKeyframes::keyframes):
      * dom/CheckedRadioButtons.h:
      * dom/ClientRectList.h:
      * dom/ContainerNode.h:
      (WebCore::ChildNodesLazySnapshot::nextNode):
      (WebCore::ChildNodesLazySnapshot::takeSnapshot):
      * dom/CrossThreadTask.h:
      * dom/Document.cpp:
      (WebCore::Document::webkitCancelFullScreen):
      (WebCore::Document::webkitExitFullscreen):
      (WebCore::Document::fullScreenChangeDelayTimerFired):
      (WebCore::Document::didAssociateFormControlsTimerFired):
      * dom/Document.h:
      * dom/DocumentMarkerController.cpp:
      (WebCore::DocumentMarkerController::removeMarkers):
      * dom/DocumentMarkerController.h:
      * dom/DocumentStyleSheetCollection.cpp:
      (WebCore::DocumentStyleSheetCollection::injectedUserStyleSheets):
      (WebCore::DocumentStyleSheetCollection::injectedAuthorStyleSheets):
      (WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
      (WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):
      (WebCore::styleSheetsUseRemUnits):
      (WebCore::filterEnabledNonemptyCSSStyleSheets):
      (WebCore::collectActiveCSSStyleSheetsFromSeamlessParents):
      (WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
      * dom/DocumentStyleSheetCollection.h:
      * dom/Element.cpp:
      (WebCore::Element::attrNodeList):
      (WebCore::Element::webkitGetRegionFlowRanges):
      * dom/Element.h:
      * dom/EventListenerMap.h:
      * dom/EventSender.h:
      (WebCore::EventSender::timerFired):
      * dom/IdTargetObserverRegistry.h:
      * dom/MutationCallback.h:
      * dom/MutationObserver.cpp:
      (WebCore::MutationObserver::takeRecords):
      (WebCore::MutationObserver::deliver):
      (WebCore::MutationObserver::deliverAllMutations):
      * dom/MutationObserver.h:
      * dom/MutationObserverRegistration.h:
      * dom/NamedFlowCollection.cpp:
      (WebCore::NamedFlowCollection::namedFlows):
      * dom/NamedFlowCollection.h:
      * dom/Node.cpp:
      (WebCore::Node::didMoveToNewDocument):
      (WebCore::Node::mutationObserverRegistry):
      (WebCore::Node::registerMutationObserver):
      (WebCore::Node::unregisterMutationObserver):
      (WebCore::Node::notifyMutationObserversNodeWillDetach):
      * dom/Node.h:
      * dom/NodeRareData.h:
      * dom/Range.cpp:
      (WebCore::Range::processContents):
      (WebCore::Range::processNodes):
      (WebCore::Range::processAncestorsAndTheirSiblings):
      * dom/Range.h:
      * dom/ScopedEventQueue.h:
      * dom/ScriptExecutionContext.cpp:
      (WebCore::ScriptExecutionContext::reportException):
      * dom/ScriptExecutionContext.h:
      * dom/ScriptedAnimationController.h:
      * editing/ApplyStyleCommand.cpp:
      (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
      * editing/BreakBlockquoteCommand.cpp:
      (WebCore::BreakBlockquoteCommand::doApply):
      * editing/CompositeEditCommand.cpp:
      (WebCore::CompositeEditCommand::removeChildrenInRange):
      (WebCore::CompositeEditCommand::deleteInsignificantText):
      (WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
      * editing/CompositeEditCommand.h:
      * editing/EditingStyle.cpp:
      (WebCore::htmlElementEquivalents):
      (WebCore::EditingStyle::conflictsWithImplicitStyleOfElement):
      (WebCore::htmlAttributeEquivalents):
      (WebCore::EditingStyle::conflictsWithImplicitStyleOfAttributes):
      (WebCore::EditingStyle::extractConflictingImplicitStyleOfAttributes):
      (WebCore::EditingStyle::elementIsStyledSpanOrHTMLEquivalent):
      (WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement):
      (WebCore::styleFromMatchedRulesForElement):
      * editing/Editor.cpp:
      (WebCore::Editor::countMatchesForText):
      * editing/Editor.h:
      * editing/InsertParagraphSeparatorCommand.cpp:
      (WebCore::InsertParagraphSeparatorCommand::getAncestorsInsideBlock):
      (WebCore::InsertParagraphSeparatorCommand::cloneHierarchyUnderNewBlock):
      (WebCore::InsertParagraphSeparatorCommand::doApply):
      * editing/InsertParagraphSeparatorCommand.h:
      * editing/MergeIdenticalElementsCommand.cpp:
      (WebCore::MergeIdenticalElementsCommand::doApply):
      (WebCore::MergeIdenticalElementsCommand::doUnapply):
      * editing/RemoveNodePreservingChildrenCommand.cpp:
      (WebCore::RemoveNodePreservingChildrenCommand::doApply):
      * editing/ReplaceSelectionCommand.cpp:
      (WebCore::ReplacementFragment::removeUnrenderedNodes):
      * editing/SimplifyMarkupCommand.cpp:
      (WebCore::SimplifyMarkupCommand::doApply):
      (WebCore::SimplifyMarkupCommand::pruneSubsequentAncestorsToRemove):
      * editing/SimplifyMarkupCommand.h:
      * editing/SpellChecker.h:
      * editing/SplitElementCommand.cpp:
      (WebCore::SplitElementCommand::executeApply):
      (WebCore::SplitElementCommand::doUnapply):
      * editing/WrapContentsInDummySpanCommand.cpp:
      (WebCore::WrapContentsInDummySpanCommand::executeApply):
      (WebCore::WrapContentsInDummySpanCommand::doUnapply):
      * editing/mac/AlternativeTextUIController.h:
      * fileapi/FileList.h:
      * history/BackForwardList.h:
      * history/HistoryItem.cpp:
      (WebCore::HistoryItem::setRedirectURLs):
      * history/HistoryItem.h:
      * history/mac/HistoryItemMac.mm:
      (WebCore::HistoryItem::setTransientProperty):
      * html/FormController.h:
      * html/HTMLAnchorElement.cpp:
      * html/HTMLCollection.cpp:
      (WebCore::HTMLCollection::append):
      * html/HTMLCollection.h:
      * html/HTMLFormControlElement.cpp:
      (WebCore::HTMLFormControlElement::checkValidity):
      * html/HTMLFormControlElement.h:
      * html/HTMLFormElement.cpp:
      (WebCore::HTMLFormElement::validateInteractively):
      (WebCore::HTMLFormElement::checkValidity):
      (WebCore::HTMLFormElement::checkInvalidControlsAndCollectUnhandled):
      * html/HTMLFormElement.h:
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::updateActiveTextTrackCues):
      (WebCore::HTMLMediaElement::platformTextTracks):
      (WebCore::HTMLMediaElement::configureTextTrackGroup):
      * html/HTMLMediaElement.h:
      * html/HTMLPlugInImageElement.cpp:
      * html/HTMLSelectElement.cpp:
      (WebCore::HTMLSelectElement::setLength):
      * html/MediaController.cpp:
      (MediaController::asyncEventTimerFired):
      * html/MediaController.h:
      * html/MediaFragmentURIParser.h:
      * html/ValidationMessage.h:
      * html/canvas/WebGLFramebuffer.h:
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore::WebGLRenderingContext::getAttachedShaders):
      * html/canvas/WebGLRenderingContext.h:
      * html/canvas/WebGLTexture.h:
      * html/parser/BackgroundHTMLParser.cpp:
      (WebCore::BackgroundHTMLParser::BackgroundHTMLParser):
      * html/parser/BackgroundHTMLParser.h:
      (WebCore::BackgroundHTMLParser::create):
      * html/parser/HTMLDocumentParser.cpp:
      (WebCore::HTMLDocumentParser::startBackgroundParser):
      * html/parser/HTMLDocumentParser.h:
      * html/parser/HTMLMetaCharsetParser.h:
      * html/parser/HTMLPreloadScanner.cpp:
      (WebCore::TokenPreloadScanner::scan):
      (WebCore::TokenPreloadScanner::scanCommon):
      * html/parser/HTMLResourcePreloader.h:
      * html/parser/XSSAuditor.h:
      * html/shadow/ContentDistributor.cpp:
      (WebCore::ContentDistributor::ensureInsertionPointList):
      (WebCore::ContentDistributor::distribute):
      (WebCore::ContentDistributor::invalidate):
      * html/shadow/ContentDistributor.h:
      * html/shadow/MediaControlElements.cpp:
      (WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu):
      (WebCore::MediaControlTextTrackContainerElement::updateDisplay):
      * html/shadow/MediaControlElements.h:
      * html/track/InbandGenericTextTrack.h:
      * html/track/InbandWebVTTTextTrack.cpp:
      (WebCore::InbandWebVTTTextTrack::newCuesParsed):
      * html/track/LoadableTextTrack.cpp:
      (WebCore::LoadableTextTrack::newCuesAvailable):
      (WebCore::LoadableTextTrack::newRegionsAvailable):
      * html/track/TextTrackCueList.h:
      * html/track/TextTrackList.cpp:
      (TextTrackList::invalidateTrackIndexesAfterTrack):
      (TextTrackList::remove):
      (TextTrackList::contains):
      * html/track/TextTrackList.h:
      * html/track/TrackListBase.cpp:
      (TrackListBase::asyncEventTimerFired):
      * html/track/TrackListBase.h:
      * html/track/WebVTTParser.cpp:
      (WebCore::WebVTTParser::getNewCues):
      (WebCore::WebVTTParser::getNewRegions):
      * html/track/WebVTTParser.h:
      * inspector/ConsoleMessage.cpp:
      (WebCore::ConsoleMessage::addToFrontend):
      * inspector/ContentSearchUtils.cpp:
      (WebCore::ContentSearchUtils::getRegularExpressionMatchesByLines):
      (WebCore::ContentSearchUtils::lineEndings):
      (WebCore::ContentSearchUtils::searchInTextByLines):
      * inspector/ContentSearchUtils.h:
      * inspector/DOMPatchSupport.cpp:
      (WebCore::DOMPatchSupport::patchNode):
      (WebCore::DOMPatchSupport::diff):
      (WebCore::DOMPatchSupport::innerPatchChildren):
      * inspector/DOMPatchSupport.h:
      * inspector/InjectedScript.cpp:
      (WebCore::InjectedScript::getProperties):
      (WebCore::InjectedScript::getInternalProperties):
      (WebCore::InjectedScript::wrapCallFrames):
      * inspector/InjectedScript.h:
      * inspector/InjectedScriptHost.h:
      * inspector/InspectorAgent.cpp:
      (WebCore::InspectorAgent::enable):
      * inspector/InspectorApplicationCacheAgent.cpp:
      (WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
      (WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources):
      * inspector/InspectorApplicationCacheAgent.h:
      * inspector/InspectorBaseAgent.h:
      * inspector/InspectorCSSAgent.cpp:
      (WebCore::SelectorProfile::toInspectorObject):
      (WebCore::UpdateRegionLayoutTask::onTimer):
      (WebCore::InspectorCSSAgent::getMatchedStylesForNode):
      (WebCore::InspectorCSSAgent::getComputedStyleForNode):
      (WebCore::InspectorCSSAgent::getAllStyleSheets):
      (WebCore::InspectorCSSAgent::getSupportedCSSProperties):
      (WebCore::InspectorCSSAgent::getNamedFlowCollection):
      (WebCore::InspectorCSSAgent::buildArrayForRuleList):
      (WebCore::InspectorCSSAgent::buildArrayForMatchedRuleList):
      (WebCore::InspectorCSSAgent::buildArrayForRegions):
      (WebCore::InspectorCSSAgent::buildObjectForNamedFlow):
      * inspector/InspectorCSSAgent.h:
      * inspector/InspectorConsoleAgent.h:
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::RevalidateStyleAttributeTask::onTimer):
      (WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
      (WebCore::InspectorDOMAgent::pushNodePathToFrontend):
      (WebCore::InspectorDOMAgent::getEventListenersForNode):
      (WebCore::InspectorDOMAgent::performSearch):
      (WebCore::InspectorDOMAgent::getSearchResults):
      (WebCore::InspectorDOMAgent::getAttributes):
      (WebCore::InspectorDOMAgent::buildObjectForNode):
      (WebCore::InspectorDOMAgent::buildArrayForElementAttributes):
      (WebCore::InspectorDOMAgent::buildArrayForContainerChildren):
      (WebCore::InspectorDOMAgent::styleAttributeInvalidated):
      * inspector/InspectorDOMAgent.h:
      * inspector/InspectorDOMStorageAgent.cpp:
      (WebCore::InspectorDOMStorageAgent::getDOMStorageItems):
      * inspector/InspectorDOMStorageAgent.h:
      * inspector/InspectorDatabaseAgent.cpp:
      (WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
      * inspector/InspectorDatabaseAgent.h:
      * inspector/InspectorDebuggerAgent.cpp:
      (WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
      (WebCore::InspectorDebuggerAgent::searchInContent):
      (WebCore::InspectorDebuggerAgent::setScriptSource):
      (WebCore::InspectorDebuggerAgent::currentCallFrames):
      * inspector/InspectorDebuggerAgent.h:
      * inspector/InspectorHeapProfilerAgent.cpp:
      (WebCore::InspectorHeapProfilerAgent::getProfileHeaders):
      * inspector/InspectorHeapProfilerAgent.h:
      * inspector/InspectorHistory.h:
      * inspector/InspectorIndexedDBAgent.cpp:
      * inspector/InspectorLayerTreeAgent.cpp:
      (WebCore::InspectorLayerTreeAgent::layersForNode):
      (WebCore::InspectorLayerTreeAgent::gatherLayersUsingRenderObjectHierarchy):
      (WebCore::InspectorLayerTreeAgent::gatherLayersUsingRenderLayerHierarchy):
      * inspector/InspectorLayerTreeAgent.h:
      * inspector/InspectorMemoryAgent.h:
      * inspector/InspectorPageAgent.cpp:
      (WebCore::buildArrayForCookies):
      (WebCore::InspectorPageAgent::getCookies):
      (WebCore::InspectorPageAgent::searchInResource):
      (WebCore::InspectorPageAgent::searchInResources):
      (WebCore::InspectorPageAgent::buildObjectForFrameTree):
      * inspector/InspectorPageAgent.h:
      * inspector/InspectorProfilerAgent.cpp:
      (WebCore::InspectorProfilerAgent::getProfileHeaders):
      * inspector/InspectorProfilerAgent.h:
      * inspector/InspectorResourceAgent.h:
      * inspector/InspectorRuntimeAgent.cpp:
      (WebCore::InspectorRuntimeAgent::getProperties):
      * inspector/InspectorRuntimeAgent.h:
      * inspector/InspectorState.h:
      * inspector/InspectorStyleSheet.cpp:
      (WebCore::asCSSRuleList):
      (WebCore::InspectorStyle::buildArrayForComputedStyle):
      (WebCore::InspectorStyle::styleWithProperties):
      (WebCore::selectorsFromSource):
      (WebCore::InspectorStyleSheet::buildObjectForSelectorList):
      (WebCore::InspectorStyleSheet::buildObjectForRule):
      (WebCore::InspectorStyleSheet::lineEndings):
      (WebCore::InspectorStyleSheet::buildArrayForRuleList):
      (WebCore::InspectorStyleSheetForInlineStyle::lineEndings):
      * inspector/InspectorStyleSheet.h:
      * inspector/InspectorValues.cpp:
      (WebCore::InspectorArrayBase::writeJSON):
      * inspector/InspectorValues.h:
      * inspector/PageRuntimeAgent.cpp:
      (WebCore::PageRuntimeAgent::reportExecutionContextCreation):
      * inspector/ScriptCallStack.cpp:
      (WebCore::ScriptCallStack::buildInspectorArray):
      * inspector/ScriptCallStack.h:
      * loader/CrossOriginPreflightResultCache.h:
      * loader/DocumentLoader.cpp:
      (WebCore::cancelAll):
      (WebCore::setAllDefersLoading):
      (WebCore::DocumentLoader::getSubresources):
      * loader/DocumentLoader.h:
      * loader/FormState.h:
      * loader/FormSubmission.cpp:
      (WebCore::FormSubmission::create):
      * loader/ProgressTracker.h:
      * loader/ResourceLoadScheduler.h:
      * loader/TextTrackLoader.cpp:
      (WebCore::TextTrackLoader::getNewCues):
      (WebCore::TextTrackLoader::getNewRegions):
      * loader/TextTrackLoader.h:
      * loader/WorkerThreadableLoader.cpp:
      (WebCore::workerGlobalScopeDidReceiveData):
      (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
      * loader/appcache/ApplicationCache.cpp:
      (WebCore::ApplicationCache::removeResource):
      (WebCore::ApplicationCache::dump):
      * loader/appcache/ApplicationCache.h:
      * loader/appcache/ApplicationCacheStorage.cpp:
      (WebCore::ApplicationCacheStorage::getOriginsWithCache):
      * loader/archive/Archive.cpp:
      (WebCore::Archive::clearAllSubframeArchives):
      (WebCore::Archive::clearAllSubframeArchivesImpl):
      * loader/archive/Archive.h:
      (WebCore::Archive::subresources):
      (WebCore::Archive::subframeArchives):
      * loader/archive/ArchiveResourceCollection.cpp:
      (WebCore::ArchiveResourceCollection::addAllResources):
      * loader/archive/ArchiveResourceCollection.h:
      * loader/archive/cf/LegacyWebArchive.cpp:
      (WebCore::LegacyWebArchive::createPropertyListRepresentation):
      (WebCore::LegacyWebArchive::create):
      (WebCore::LegacyWebArchive::createFromSelection):
      * loader/archive/cf/LegacyWebArchive.h:
      * loader/archive/mhtml/MHTMLParser.h:
      * loader/cache/CachedResource.h:
      * loader/cache/CachedResourceLoader.h:
      * loader/cache/MemoryCache.h:
      * loader/icon/IconDatabase.cpp:
      (WebCore::IconDatabase::notifyPendingLoadDecisions):
      * loader/icon/IconDatabase.h:
      * page/CaptionUserPreferencesMediaAF.cpp:
      (WebCore::CaptionUserPreferencesMediaAF::sortedTrackListForMenu):
      * page/CaptionUserPreferencesMediaAF.h:
      * page/ChromeClient.h:
      (WebCore::ChromeClient::didAssociateFormControls):
      * page/Console.h:
      * page/ContentSecurityPolicy.h:
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::getMatchedCSSRules):
      * page/DeviceController.cpp:
      (WebCore::DeviceController::dispatchDeviceEvent):
      (WebCore::DeviceController::fireDeviceEvent):
      * page/DeviceController.h:
      * page/EditorClient.h:
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handleTouchEvent):
      * page/EventHandler.h:
      * page/FrameView.cpp:
      (WebCore::FrameView::serviceScriptedAnimations):
      * page/Page.cpp:
      (WebCore::Page::findStringMatchingRanges):
      * page/Page.h:
      * page/PageGroup.h:
      * page/Performance.cpp:
      (WebCore::Performance::webkitGetEntriesByType):
      (WebCore::Performance::webkitGetEntriesByName):
      * page/Performance.h:
      * page/PerformanceEntryList.cpp:
      (WebCore::PerformanceEntryList::appendAll):
      * page/PerformanceEntryList.h:
      * page/SecurityOriginHash.h:
      * page/SecurityPolicy.cpp:
      * page/SpeechInputResult.h:
      * page/animation/AnimationController.cpp:
      (WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle):
      * page/animation/AnimationControllerPrivate.h:
      * page/animation/CSSPropertyAnimation.cpp:
      (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
      * page/animation/CompositeAnimation.h:
      * page/scrolling/ScrollingStateNode.cpp:
      (WebCore::ScrollingStateNode::appendChild):
      * page/scrolling/ScrollingStateNode.h:
      (WebCore::ScrollingStateNode::children):
      * page/scrolling/ScrollingThread.cpp:
      (WebCore::ScrollingThread::dispatchFunctionsFromScrollingThread):
      * page/scrolling/ScrollingThread.h:
      * page/scrolling/ScrollingTree.cpp:
      (WebCore::ScrollingTree::updateTreeFromStateNode):
      * page/scrolling/ScrollingTreeNode.cpp:
      (WebCore::ScrollingTreeNode::appendChild):
      * page/scrolling/ScrollingTreeNode.h:
      * page/scrolling/mac/ScrollingCoordinatorMac.mm:
      (WebCore::ScrollingCoordinatorMac::syncChildPositions):
      * platform/CrossThreadCopier.cpp:
      * platform/CrossThreadCopier.h:
      * platform/DragData.h:
      * platform/MainThreadTask.h:
      * platform/PODFreeListArena.h:
      (WebCore::PODFreeListArena::freeObject):
      (WebCore::PODFreeListArena::allocate):
      * platform/PODIntervalTree.h:
      * platform/PODRedBlackTree.h:
      (WebCore::PODRedBlackTree::PODRedBlackTree):
      * platform/PlatformSpeechSynthesizer.cpp:
      (WebCore::PlatformSpeechSynthesizer::voiceList):
      * platform/PlatformSpeechSynthesizer.h:
      * platform/RunLoop.h:
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::frameRectsChanged):
      (WebCore::ScrollView::clipRectChanged):
      (WebCore::ScrollView::setParentVisible):
      (WebCore::ScrollView::show):
      (WebCore::ScrollView::hide):
      * platform/ScrollView.h:
      * platform/SharedBuffer.h:
      * platform/Supplementable.h:
      (WebCore::Supplement::provideTo):
      (WebCore::Supplementable::provideSupplement):
      * platform/URL.cpp:
      (WebCore::findHostnamesInMailToURL):
      (WebCore::encodeHostnames):
      * platform/audio/AudioBus.h:
      * platform/audio/AudioDSPKernelProcessor.h:
      * platform/audio/AudioResampler.h:
      * platform/audio/DynamicsCompressor.h:
      * platform/audio/DynamicsCompressorKernel.h:
      * platform/audio/HRTFDatabase.h:
      * platform/audio/HRTFKernel.h:
      * platform/audio/MultiChannelResampler.h:
      * platform/audio/Reverb.h:
      * platform/audio/ReverbConvolver.h:
      * platform/cf/SharedBufferCF.cpp:
      (WebCore::SharedBuffer::copyBufferAndClear):
      (WebCore::SharedBuffer::copySomeDataFromDataArray):
      * platform/graphics/FloatPolygon.cpp:
      (WebCore::FloatPolygon::FloatPolygon):
      * platform/graphics/FloatPolygon.h:
      * platform/graphics/FontCache.cpp:
      (WebCore::FontCache::getCachedFontData):
      (WebCore::FontCache::purgeInactiveFontData):
      * platform/graphics/GlyphMetricsMap.h:
      (WebCore::::locatePageSlowCase):
      * platform/graphics/GlyphPageTreeNode.h:
      * platform/graphics/GraphicsContext3D.h:
      * platform/graphics/GraphicsLayer.cpp:
      * platform/graphics/GraphicsLayer.h:
      * platform/graphics/PlatformTextTrackMenu.h:
      * platform/graphics/SimpleFontData.h:
      * platform/graphics/WidthCache.h:
      * platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
      (WebCore::MediaPlayerPrivateAVFoundation::processNewAndRemovedTextTracks):
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
      (WebCore::MediaPlayerPrivateAVFoundationObjC::processLegacyClosedCaptionsTracks):
      (WebCore::MediaPlayerPrivateAVFoundationObjC::processMediaSelectionOptions):
      * platform/graphics/ca/GraphicsLayerCA.cpp:
      (WebCore::GraphicsLayerCA::setFilterAnimationKeyframes):
      (WebCore::GraphicsLayerCA::fetchCloneLayers):
      * platform/graphics/ca/GraphicsLayerCA.h:
      * platform/graphics/ca/PlatformCAAnimation.h:
      * platform/graphics/ca/PlatformCALayer.h:
      * platform/graphics/ca/mac/LayerPool.h:
      * platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
      (PlatformCAAnimation::setValues):
      * platform/graphics/ca/mac/TileController.h:
      * platform/graphics/cg/SubimageCacheWithTimer.h:
      * platform/graphics/filters/CustomFilterParameterList.h:
      * platform/graphics/filters/FilterEffect.h:
      * platform/graphics/filters/FilterOperations.h:
      (WebCore::FilterOperations::operations):
      * platform/graphics/gpu/Texture.cpp:
      (WebCore::Texture::Texture):
      (WebCore::Texture::create):
      * platform/graphics/gpu/Texture.h:
      * platform/graphics/mac/ComplexTextController.h:
      * platform/graphics/mac/SimpleFontDataCoreText.cpp:
      (WebCore::SimpleFontData::getCFStringAttributes):
      * platform/graphics/transforms/TransformOperations.h:
      (WebCore::TransformOperations::operations):
      * platform/ios/PasteboardIOS.mm:
      (WebCore::documentFragmentWithRTF):
      * platform/mac/PlatformSpeechSynthesizerMac.mm:
      (-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):
      * platform/mediastream/MediaStreamDescriptor.h:
      * platform/mediastream/MediaStreamSource.h:
      * platform/mediastream/RTCConfiguration.h:
      * platform/network/BlobRegistryImpl.h:
      * platform/network/HTTPHeaderMap.h:
      * platform/network/ResourceResponseBase.cpp:
      (WebCore::ResourceResponseBase::parseCacheControlDirectives):
      (WebCore::parseCacheHeader):
      * platform/network/cf/ResourceHandleCFNet.cpp:
      (WebCore::clientCerts):
      (WebCore::ResourceHandle::createCFURLConnection):
      * platform/text/cf/HyphenationCF.cpp:
      (WebCore::::createValueForNullKey):
      (WebCore::::createValueForKey):
      (WebCore::cfLocaleCache):
      * plugins/PluginMainThreadScheduler.h:
      * rendering/HitTestResult.h:
      * rendering/InlineFlowBox.h:
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::paintContinuationOutlines):
      (WebCore::RenderBlock::removeFromTrackedRendererMaps):
      * rendering/RenderBlock.h:
      * rendering/RenderButton.h:
      * rendering/RenderCounter.cpp:
      * rendering/RenderGrid.cpp:
      (WebCore::RenderGrid::GridIterator::GridIterator):
      * rendering/RenderGrid.h:
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::updateDescendantsAreContiguousInStackingOrder):
      (WebCore::RenderLayer::rebuildZOrderLists):
      (WebCore::RenderLayer::collectLayers):
      * rendering/RenderLayer.h:
      * rendering/RenderNamedFlowThread.cpp:
      (WebCore::RenderNamedFlowThread::getRanges):
      * rendering/RenderNamedFlowThread.h:
      * rendering/RenderRegion.cpp:
      (WebCore::RenderRegion::getRanges):
      * rendering/RenderRegion.h:
      * rendering/RenderView.cpp:
      (WebCore::RenderView::selectionBounds):
      (WebCore::RenderView::setSelection):
      * rendering/RootInlineBox.h:
      * rendering/shapes/PolygonShape.cpp:
      (WebCore::computeShapePaddingBounds):
      (WebCore::computeShapeMarginBounds):
      * rendering/shapes/PolygonShape.h:
      (WebCore::PolygonShape::PolygonShape):
      * rendering/shapes/Shape.cpp:
      (WebCore::createPolygonShape):
      (WebCore::Shape::createShape):
      * rendering/shapes/ShapeInfo.h:
      * rendering/shapes/ShapeInterval.h:
      * rendering/style/QuotesData.cpp:
      (WebCore::QuotesData::create):
      (WebCore::QuotesData::QuotesData):
      * rendering/style/QuotesData.h:
      * rendering/style/RenderStyle.cpp:
      (WebCore::requireTransformOrigin):
      (WebCore::RenderStyle::applyTransform):
      * rendering/style/StyleGridData.h:
      * rendering/svg/RenderSVGResourceGradient.h:
      * rendering/svg/RenderSVGResourcePattern.h:
      * rendering/svg/SVGResourcesCache.h:
      * storage/StorageEventDispatcher.cpp:
      (WebCore::StorageEventDispatcher::dispatchSessionStorageEvents):
      (WebCore::StorageEventDispatcher::dispatchLocalStorageEvents):
      (WebCore::StorageEventDispatcher::dispatchSessionStorageEventsToFrames):
      (WebCore::StorageEventDispatcher::dispatchLocalStorageEventsToFrames):
      * storage/StorageEventDispatcher.h:
      * storage/StorageNamespaceImpl.h:
      * storage/StorageThread.h:
      * storage/StorageTracker.cpp:
      (WebCore::StorageTracker::origins):
      * storage/StorageTracker.h:
      * svg/SVGAnimatedPath.cpp:
      (WebCore::SVGAnimatedPathAnimator::startAnimValAnimation):
      * svg/SVGAnimatedTypeAnimator.cpp:
      (WebCore::SVGElementAnimatedProperties::SVGElementAnimatedProperties):
      (WebCore::SVGAnimatedTypeAnimator::findAnimatedPropertiesForAttributeName):
      * svg/SVGAnimatedTypeAnimator.h:
      * svg/SVGDocumentExtensions.cpp:
      (WebCore::SVGDocumentExtensions::startAnimations):
      (WebCore::SVGDocumentExtensions::dispatchSVGLoadEventToOutermostSVGElements):
      (WebCore::SVGDocumentExtensions::addPendingResource):
      (WebCore::SVGDocumentExtensions::isElementPendingResources):
      (WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
      (WebCore::SVGDocumentExtensions::setOfElementsReferencingTarget):
      (WebCore::SVGDocumentExtensions::addElementReferencingTarget):
      (WebCore::SVGDocumentExtensions::rebuildAllElementReferencesForTarget):
      * svg/SVGDocumentExtensions.h:
      * svg/SVGFontElement.h:
      * svg/SVGGlyphMap.h:
      * svg/SVGMarkerElement.cpp:
      (WebCore::SVGMarkerElement::orientTypeAnimated):
      * svg/SVGMarkerElement.h:
      * svg/SVGPathSegList.h:
      * svg/animation/SMILTimeContainer.h:
      * svg/graphics/SVGImageCache.h:
      * svg/graphics/filters/SVGFilterBuilder.h:
      (WebCore::SVGFilterBuilder::addBuiltinEffects):
      * svg/properties/SVGAnimatedEnumerationPropertyTearOff.h:
      (WebCore::SVGAnimatedEnumerationPropertyTearOff::create):
      * svg/properties/SVGAnimatedListPropertyTearOff.h:
      (WebCore::SVGAnimatedListPropertyTearOff::create):
      * svg/properties/SVGAnimatedPropertyTearOff.h:
      (WebCore::SVGAnimatedPropertyTearOff::create):
      * svg/properties/SVGAnimatedStaticPropertyTearOff.h:
      (WebCore::SVGAnimatedStaticPropertyTearOff::create):
      * svg/properties/SVGAttributeToPropertyMap.cpp:
      (WebCore::SVGAttributeToPropertyMap::animatedPropertiesForAttribute):
      * svg/properties/SVGAttributeToPropertyMap.h:
      * svg/properties/SVGStaticListPropertyTearOff.h:
      (WebCore::SVGStaticListPropertyTearOff::create):
      * svg/properties/SVGTransformListPropertyTearOff.h:
      (WebCore::SVGTransformListPropertyTearOff::create):
      (WebCore::SVGTransformListPropertyTearOff::createSVGTransformFromMatrix):
      (WebCore::SVGTransformListPropertyTearOff::consolidate):
      * workers/DefaultSharedWorkerRepository.h:
      * workers/WorkerMessagingProxy.h:
      * xml/XMLHttpRequestProgressEventThrottle.cpp:
      (WebCore::XMLHttpRequestProgressEventThrottle::dispatchDeferredEvents):
      * xml/XMLHttpRequestProgressEventThrottle.h:
      * xml/XPathNodeSet.cpp:
      (WebCore::XPath::NodeSet::sort):
      (WebCore::XPath::NodeSet::traversalSort):
      * xml/XSLStyleSheet.h:
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      
      Source/WebKit/mac:
      
      * History/WebHistory.mm:
      (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
      * History/WebHistoryItem.mm:
      (-[WebHistoryItem initFromDictionaryRepresentation:]):
      * Plugins/Hosted/NetscapePluginHostProxy.h:
      * Plugins/Hosted/NetscapePluginInstanceProxy.h:
      * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
      (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
      (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::retain):
      (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::release):
      (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
      (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
      * Plugins/WebNetscapePluginView.h:
      * Plugins/WebNetscapePluginView.mm:
      (-[WebNetscapePluginView destroyPlugin]):
      * Storage/WebDatabaseManager.mm:
      (-[WebDatabaseManager origins]):
      * Storage/WebStorageManager.mm:
      (-[WebStorageManager origins]):
      * WebCoreSupport/WebApplicationCache.mm:
      (+[WebApplicationCache originsWithCache]):
      * WebCoreSupport/WebEditorClient.h:
      * WebCoreSupport/WebEditorClient.mm:
      (WebEditorClient::getClientPasteboardDataForRange):
      (WebEditorClient::documentFragmentFromAttributedString):
      * WebCoreSupport/WebFrameLoaderClient.h:
      * WebCoreSupport/WebNotificationClient.h:
      * WebCoreSupport/WebNotificationClient.mm:
      (WebNotificationClient::show):
      (WebNotificationClient::clearNotifications):
      * WebView/WebArchive.mm:
      (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
      (-[WebArchive subresources]):
      (-[WebArchive subframeArchives]):
      * WebView/WebDataSource.mm:
      (-[WebDataSource subresources]):
      * WebView/WebViewData.h:
      
      Source/WebKit2:
      
      * UIProcess/mac/WebColorPickerMac.h:
      * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::setProcessSuppressionEnabled):
      
      Source/WTF:
      
      * wtf/AVLTree.h:
      * wtf/CheckedArithmetic.h:
      * wtf/Compression.h:
      * wtf/Functional.h:
      (WTF::R):
      * wtf/HashFunctions.h:
      * wtf/HashIterators.h:
      * wtf/HashSet.h:
      (WTF::::contains):
      * wtf/ListHashSet.h:
      (WTF::::contains):
      * wtf/RefCountedLeakCounter.cpp:
      * wtf/RetainPtr.h:
      * wtf/SentinelLinkedList.h:
      (WTF::::remove):
      * wtf/SizeLimits.cpp:
      * wtf/StreamBuffer.h:
      * wtf/Vector.h:
      * wtf/VectorTraits.h:
      * wtf/WeakPtr.h:
      (WTF::WeakReference::create):
      (WTF::WeakReference::createUnbound):
      (WTF::WeakPtr::WeakPtr):
      (WTF::WeakPtrFactory::WeakPtrFactory):
      * wtf/text/AtomicString.cpp:
      (WTF::AtomicString::add):
      (WTF::findString):
      * wtf/text/StringConcatenate.h:
      * wtf/text/StringImpl.h:
      * wtf/text/StringOperators.h:
      (WTF::operator+):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3523f8d
  4. 17 Sep, 2013 1 commit
    • enrica@apple.com's avatar
      Remove unused function didSetSelectionTypesForPasteboard from EditorClient. · 70fbd1e2
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121464
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      This method was only implemented in WebEditorClient.mm for Mac where it was
      calling a private delegate that is no longer in use.
      This patch removes it for all the platforms.
      I've also removed setTypes and writeAfterSettingTypes from the implementation
      of the Pasteboard class for Mac.
      
      * editing/mac/EditorMac.mm:
      (WebCore::Editor::writeSelectionToPasteboard): Now calls write instead of
      setTypes and writeAfterSettingTypes.
      * loader/EmptyClients.h: Removed didSetSelectionTypesForPasteboard.
      * page/EditorClient.h: Ditto.
      * platform/Pasteboard.h: Removed setTypes and writeAfterSettingTypes.
      * platform/ios/PasteboardIOS.mm:
      (WebCore::Pasteboard::writeSelection): Removed call to didSetSelectionTypesForPasteboard.
      * platform/mac/PasteboardMac.mm:
      (WebCore::Pasteboard::write): Added to replace setTypes and writeAfterSettingTypes.
      
      Source/WebKit/efl: 
      
      * WebCoreSupport/EditorClientEfl.cpp:
      * WebCoreSupport/EditorClientEfl.h:
      
      Source/WebKit/gtk: 
      
      * WebCoreSupport/EditorClientGtk.cpp:
      * WebCoreSupport/EditorClientGtk.h:
      
      Source/WebKit/mac: 
      
      This method was only implemented in WebEditorClient.mm for Mac where it was
      calling a private delegate that is no longer in use.
      
      * DefaultDelegates/WebDefaultEditingDelegate.m:
      * WebCoreSupport/WebEditorClient.h:
      * WebCoreSupport/WebEditorClient.mm:
      * WebView/WebEditingDelegatePrivate.h:
      
      Source/WebKit/qt: 
      
      * WebCoreSupport/EditorClientQt.cpp:
      * WebCoreSupport/EditorClientQt.h:
      
      Source/WebKit/win: 
      
      * WebCoreSupport/WebEditorClient.cpp:
      * WebCoreSupport/WebEditorClient.h:
      
      Source/WebKit/wince: 
      
      * WebCoreSupport/EditorClientWinCE.cpp:
      * WebCoreSupport/EditorClientWinCE.h:
      
      Source/WebKit2: 
      
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      * WebProcess/WebCoreSupport/WebEditorClient.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155971 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70fbd1e2
  5. 26 Aug, 2013 1 commit
  6. 17 Aug, 2013 1 commit
  7. 12 Feb, 2013 1 commit
    • rniwa@webkit.org's avatar
      Disable delete button controller on non-Mac ports and delete... · 4098b4ed
      rniwa@webkit.org authored
      Disable delete button controller on non-Mac ports and delete EditorClient::shouldShowDeleteInterface
      https://bugs.webkit.org/show_bug.cgi?id=109534
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore: 
      
      * editing/DeleteButtonController.cpp:
      (WebCore::DeleteButtonController::show):
      * editing/Editor.cpp:
      (WebCore):
      * editing/Editor.h:
      (Editor):
      * loader/EmptyClients.h:
      (WebCore::EmptyEditorClient::shouldDeleteRange):
      (EmptyEditorClient):
      (WebCore::EmptyEditorClient::shouldShowDeleteInterface):
      * page/EditorClient.h:
      (EditorClient):
      
      Source/WebKit/blackberry: 
      
      * WebCoreSupport/EditorClientBlackBerry.cpp:
      (WebCore):
      * WebCoreSupport/EditorClientBlackBerry.h:
      (EditorClientBlackBerry):
      
      Source/WebKit/chromium: 
      
      * src/EditorClientImpl.cpp:
      (WebKit):
      * src/EditorClientImpl.h:
      (EditorClientImpl):
      
      Source/WebKit/efl: 
      
      * WebCoreSupport/EditorClientEfl.cpp:
      (WebCore):
      * WebCoreSupport/EditorClientEfl.h:
      (EditorClientEfl):
      
      Source/WebKit/gtk: 
      
      * WebCoreSupport/EditorClientGtk.cpp:
      (WebKit):
      * WebCoreSupport/EditorClientGtk.h:
      (EditorClient):
      * webkit/webkitwebview.cpp:
      (webkit_web_view_class_init):
      
      Source/WebKit/mac: 
      
      * WebCoreSupport/WebEditorClient.h:
      
      Source/WebKit/qt: 
      
      * WebCoreSupport/EditorClientQt.cpp:
      (WebCore):
      * WebCoreSupport/EditorClientQt.h:
      (EditorClientQt):
      
      Source/WebKit/win: 
      
      * WebCoreSupport/WebEditorClient.cpp:
      * WebCoreSupport/WebEditorClient.h:
      (WebEditorClient):
      
      Source/WebKit/wince: 
      
      * WebCoreSupport/EditorClientWinCE.cpp:
      (WebKit):
      * WebCoreSupport/EditorClientWinCE.h:
      (EditorClientWinCE):
      
      Source/WebKit/wx: 
      
      * WebKitSupport/EditorClientWx.cpp:
      (WebCore):
      * WebKitSupport/EditorClientWx.h:
      (EditorClientWx):
      
      Source/WebKit2: 
      
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      (WebKit):
      * WebProcess/WebCoreSupport/WebEditorClient.h:
      
      Source/WTF: 
      
      * wtf/Platform.h:
      
      Tools: 
      
      * DumpRenderTree/gtk/EditingCallbacks.cpp:
      (shouldShowDeleteInterfaceForElement):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142576 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4098b4ed
  8. 31 Jan, 2013 1 commit
    • enrica@apple.com's avatar
      WebKit2: provide new bundle APIs to allow bundle clients to be notified of pasteboard access. · 7eb1d5bc
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=108396.
      <rdar://problem/12920461>
      
      Source/WebCore: 
      
      Reviewed by Alexey Proskuryakov.
      
      Adds support in WebCore to new EditorClient methods to support the modified
      client bundle API in WebKit2.
      
      * WebCore.exp.in:
      * editing/Editor.cpp:
      (WebCore::Editor::cut): Added call to willWriteSelectionToPasteboard.
      (WebCore::Editor::copy): Ditto.
      (WebCore::Editor::willWriteSelectionToPasteboard): Added.
      * editing/Editor.h:
      * loader/EmptyClients.h: Added empty client implementation
      for the new methods.
      (WebCore::EmptyEditorClient::willWriteSelectionToPasteboard):
      (WebCore::EmptyEditorClient::getClientPasteboardDataForRange):
      * page/EditorClient.h:
      * platform/mac/PasteboardMac.mm:
      (WebCore::Pasteboard::writeSelectionForTypes): Added call to getClientPasteboardDataForRange.
      
      Source/WebKit/blackberry: 
      
      Reviewed by Alexey Proskuryakov.
      
      Adds stub implementation for WebKit of the new EditorClient methods.
      
      * WebCoreSupport/EditorClientBlackBerry.cpp:
      (WebCore::EditorClientBlackBerry::willWriteSelectionToPasteboard):
      (WebCore::EditorClientBlackBerry::getClientPasteboardDataForRange):
      * WebCoreSupport/EditorClientBlackBerry.h:
      
      Source/WebKit/chromium: 
      
      Reviewed by Alexey Proskuryakov.
      
      Adds stub implementation for WebKit of the new EditorClient methods.
      
      * src/EditorClientImpl.cpp:
      (WebKit::EditorClientImpl::willWriteSelectionToPasteboard):
      (WebKit::EditorClientImpl::getClientPasteboardDataForRange):
      * src/EditorClientImpl.h:
      
      Source/WebKit/efl: 
      
      Reviewed by Alexey Proskuryakov.
      
      Adds stub implementation for WebKit of the new EditorClient methods.
      
      * WebCoreSupport/EditorClientEfl.cpp:
      (WebCore::EditorClientEfl::willWriteSelectionToPasteboard):
      (WebCore::EditorClientEfl::getClientPasteboardDataForRange):
      * WebCoreSupport/EditorClientEfl.h:
      
      Source/WebKit/gtk: 
      
      Reviewed by Alexey Proskuryakov.
      
      Adds stub implementation for WebKit of the new EditorClient methods.
      
      * WebCoreSupport/EditorClientGtk.cpp:
      (WebKit::EditorClient::willWriteSelectionToPasteboard):
      (WebKit::EditorClient::getClientPasteboardDataForRange):
      * WebCoreSupport/EditorClientGtk.h:
      
      Source/WebKit/mac: 
      
      Reviewed by Alexey Proskuryakov.
      
      Adds stub implementation for WebKit of the new EditorClient methods.
      
      * WebCoreSupport/WebEditorClient.h:
      * WebCoreSupport/WebEditorClient.mm:
      (WebEditorClient::willWriteSelectionToPasteboard):
      (WebEditorClient::getClientPasteboardDataForRange):
      
      Source/WebKit/qt: 
      
      Reviewed by Alexey Proskuryakov.
      
      Adds stub implementation for WebKit of the new EditorClient methods.
      
      * WebCoreSupport/EditorClientQt.cpp:
      (WebCore::EditorClientQt::willWriteSelectionToPasteboard):
      (WebCore::EditorClientQt::getClientPasteboardDataForRange):
      * WebCoreSupport/EditorClientQt.h:
      
      Source/WebKit/win: 
      
      Reviewed by Alexey Proskuryakov.
      
      Adds stub implementation for WebKit of the new EditorClient methods.
      
      * WebCoreSupport/WebEditorClient.cpp:
      (WebEditorClient::willWriteSelectionToPasteboard):
      (WebEditorClient::getClientPasteboardDataForRange):
      * WebCoreSupport/WebEditorClient.h:
      
      Source/WebKit/wince: 
      
      Reviewed by Alexey Proskuryakov.
      
      Adds stub implementation for WebKit of the new EditorClient methods.
      
      * WebCoreSupport/EditorClientWinCE.cpp:
      (WebKit::EditorClientWinCE::willWriteSelectionToPasteboard):
      (WebKit::EditorClientWinCE::getClientPasteboardDataForRange):
      * WebCoreSupport/EditorClientWinCE.h:
      
      Source/WebKit/wx: 
      
      Reviewed by Alexey Proskuryakov.
      
      Adds stub implementation for WebKit of the new EditorClient methods.
      
      * WebKitSupport/EditorClientWx.cpp:
      (WebCore::EditorClientWx::willWriteSelectionToPasteboard):
      (WebCore::EditorClientWx::getClientPasteboardDataForRange):
      * WebKitSupport/EditorClientWx.h:
      
      Source/WebKit2: 
      
      Reviewed by Alexey Proskuryakov.
      
      This patch adds new bundle client API to receive notifications
      relative the pasteboard activity. There are 2 new API added to
      InjectedBundleEditorClient, to receive notification before and
      after the pasteboard content is added and one API to provide
      additional content to add to the pasteboard.
      In order to create content to add to the pasteboard, WKWebArchiveRef
      and WKWebArchiveResourcesRef have been added to the set of API level
      object.
      This work is a joint effort with Sam Weinig who contributed the
      support for WKWebArchiveRef, WKWebArchiveResourcesRef and related
      files. Sam is the author of the first chunk of changes listed below.
              
      * Shared/API/c/WKBase.h:
      * Shared/API/c/WKSharedAPICast.h:
      * Shared/API/c/mac/WKWebArchive.cpp: Added.
      (WKWebArchiveGetTypeID):
      (WKWebArchiveCreate):
      (WKWebArchiveCreateWithData):
      (WKWebArchiveCreateFromRange):
      (WKWebArchiveCopyMainResource):
      (WKWebArchiveCopySubresources):
      (WKWebArchiveCopySubframeArchives):
      (WKWebArchiveCopyData):
      * Shared/API/c/mac/WKWebArchive.h: Added.
      * Shared/API/c/mac/WKWebArchiveResource.cpp: Added.
      (WKWebArchiveResourceGetTypeID):
      (WKWebArchiveResourceCreate):
      (WKWebArchiveResourceCopyData):
      (WKWebArchiveResourceCopyURL):
      (WKWebArchiveResourceCopyMIMEType):
      (WKWebArchiveResourceCopyTextEncoding):
      * Shared/API/c/mac/WKWebArchiveResource.h: Added.
      * Shared/APIObject.h:
      * Shared/WebArchive.cpp: Added.
      (WebKit::WebArchive::create):
      (WebKit::WebArchive::WebArchive):
      (WebKit::WebArchive::~WebArchive):
      (WebKit::WebArchive::mainResource):
      (WebKit::WebArchive::subresources):
      (WebKit::WebArchive::subframeArchives):
      (WebKit::releaseCFData):
      (WebKit::WebArchive::data):
      (WebKit::WebArchive::coreLegacyWebArchive):
      * Shared/WebArchive.h: Added.
      (WebKit::WebArchive::type):
      * Shared/WebArchiveResource.cpp: Added.
      (WebKit::WebArchiveResource::create):
      (WebKit::WebArchiveResource::WebArchiveResource):
      (WebKit::WebArchiveResource::~WebArchiveResource):
      (WebKit::releaseCFData):
      (WebKit::WebArchiveResource::data):
      (WebKit::WebArchiveResource::URL):
      (WebKit::WebArchiveResource::MIMEType):
      (WebKit::WebArchiveResource::textEncoding):
      (WebKit::WebArchiveResource::coreArchiveResource):
      * Shared/WebArchiveResource.h: Added.
      (WebKit::WebArchiveResource::type):
      * WebKit2.xcodeproj/project.pbxproj:
              
      * Shared/APIClientTraits.cpp: Added versioning to InjectedBundlePageEditorClient.
      * Shared/APIClientTraits.h:
      * WebProcess/InjectedBundle/API/c/WKBundlePage.h:
      * WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:
      (WebKit::InjectedBundlePageEditorClient::willWriteToPasteboard): Added.
      (WebKit::InjectedBundlePageEditorClient::getPasteboardDataForRange): Added.
      (WebKit::InjectedBundlePageEditorClient::didWriteToPasteboard): Added.
      * WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      (WebKit::WebEditorClient::didWriteSelectionToPasteboard):
      (WebKit::WebEditorClient::willWriteSelectionToPasteboard):
      (WebKit::WebEditorClient::getClientPasteboardDataForRange):
      * WebProcess/WebCoreSupport/WebEditorClient.h:
      
      Tools: 
      
      Reviewed by Alexey Proskuryakov.
              
      Adding new WebKit2 test with relevant bundle, to test the new APIs.
      
      * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
      * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm: Added.
      (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
      (TestWebKitAPI::setInjectedBundleClient):
      * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp: Added.
      (PasteboardNotificationsTest):
      (TestWebKitAPI::willWriteToPasteboard):
      (TestWebKitAPI::getPasteboardDataForRange):
      (TestWebKitAPI::didWriteToPasteboard):
      (TestWebKitAPI::PasteboardNotificationsTest::PasteboardNotificationsTest):
      (TestWebKitAPI::PasteboardNotificationsTest::didCreatePage):
      * TestWebKitAPI/Tests/WebKit2/execCopy.html: Added.
      * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Updated to reflect
      changes in InjectedBundleEditorClient.
      (WTR::InjectedBundlePage::InjectedBundlePage):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141473 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7eb1d5bc
  9. 07 Sep, 2012 1 commit
    • allan.jensen@nokia.com's avatar
      X11 Global Selection · fc0f6afa
      allan.jensen@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=88238
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      In X11 global selection is the ability to share the active selection
      between applications and pasting with middle mouse-button.
      
      This patch moves the implementations of global selection from the
      separate implementations in Qt WebKit, Chromium and GTK to WebCore,
      by implementing a new EditorCommand for pasting the global selection.
      
      Test: editing/pasteboard/paste-global-selection.html
      
      * editing/EditorCommand.cpp:
      (WebCore::executePasteGlobalSelection):
      (WebCore::createCommandMap):
      * page/EditorClient.h:
      (EditorClient):
      (WebCore::EditorClient::supportsGlobalSelection):
      * platform/Pasteboard.h:
      (WebCore::Pasteboard::isSelectionMode):
      (WebCore::Pasteboard::setSelectionMode):
      * platform/gtk/PasteboardGtk.cpp:
      (WebCore::Pasteboard::writeSelection):
      (WebCore::Pasteboard::writeURL):
      (WebCore::Pasteboard::isSelectionMode):
      (WebCore::Pasteboard::setSelectionMode):
      
      Source/WebKit/chromium:
      
      Use new editor command for pasting global selection.
      
      * src/EditorClientImpl.cpp:
      (WebKit::EditorClientImpl::supportsGlobalSelection):
      * src/EditorClientImpl.h:
      (EditorClientImpl):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::handleMouseUp):
      
      Source/WebKit/qt:
      
      Use new editor command for pasting global selection, and update it using
      the respondToChangedSelection callback.
      
      * Api/qwebpage.cpp:
      (QWebPagePrivate::handleClipboard):
      * WebCoreSupport/EditorClientQt.cpp:
      (WebCore::EditorClientQt::respondToChangedSelection):
      (WebCore::EditorClientQt::supportsGlobalSelection):
      * WebCoreSupport/EditorClientQt.h:
      (EditorClientQt):
      
      Source/WebKit2:
      
      Implements the hooks for supporting global selections in Qt WebKit2.
      
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      (WebKit::WebEditorClient::respondToChangedSelection):
      (WebKit::WebEditorClient::updateGlobalSelection):
      (WebKit::WebEditorClient::supportsGlobalSelection):
      * WebProcess/WebCoreSupport/WebEditorClient.h:
      * WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:
      (WebKit::WebEditorClient::updateGlobalSelection):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::handleMouseEvent):
      * WebProcess/WebPage/WebPage.h:
      (WebPage):
      * WebProcess/WebPage/qt/WebPageQt.cpp:
      (WebKit::WebPage::handleMouseReleaseEvent):
      
      LayoutTests:
      
      Adds a test for the new editor-command, and disables it an all platforms where it is not supported.
      
      * editing/pasteboard/paste-global-selection-expected.txt: Added.
      * editing/pasteboard/paste-global-selection.html: Added.
      * platform/chromium/TestExpectations:
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/mac/Skipped:
      * platform/qt-mac/Skipped:
      * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127862 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc0f6afa
  10. 07 Jun, 2012 1 commit
    • aestes@apple.com's avatar
      Wrap uppercaseWord, lowercaseWord, and capitalizeWord with USE(APPKIT) · 57b5000c
      aestes@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=88504
      
      Reviewed by Dan Bernstein.
      
      uppercaseWord, lowercaseWord, and capitalizeWord are methods declared
      by NSResponder that subclasses are expected to implement. WebKit should
      only support these implementations on platforms that use AppKit.
      
      Source/WebCore:
      
      * WebCore.exp.in:
      * editing/Editor.cpp:
      * editing/Editor.h:
      * loader/EmptyClients.h:
      * page/ContextMenuController.cpp:
      * page/EditorClient.h:
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebEditorClient.h:
      * WebCoreSupport/WebEditorClient.mm:
      
      Source/WebKit2:
      
      * UIProcess/WebPageProxy.h:
      * WebProcess/WebCoreSupport/WebEditorClient.h:
      * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
      * WebProcess/WebPage/WebPage.cpp:
      * WebProcess/WebPage/WebPage.h:
      * WebProcess/WebPage/WebPage.messages.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      57b5000c
  11. 31 May, 2012 1 commit
  12. 18 May, 2012 1 commit
    • morrita@google.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=85515 · 9da7b7cc
      morrita@google.com authored
      Stale frame in WebCore::SpellChecker::didCheckSucceeded
      
      Source/WebCore:
      
      Reviewed by Ryosuke Niwa.
      
      Added EditorClient::frameWillDetachPage() notification to give a
      change to invalidate pending spellcheck requests on the client.
      
      Test: editing/spelling/spellcheck-async-remove-frame.html
      
      * editing/Editor.cpp:
      (WebCore::Editor::Editor):
      * editing/Editor.h:
      (Editor):
      * loader/EmptyClients.h:
      (WebCore::EmptyEditorClient::frameWillDetachPage):
      * page/EditorClient.h:
      (EditorClient):
      
      Source/WebKit/blackberry:
      
      Reviewed by Ryosuke Niwa.
      
      * WebCoreSupport/EditorClientBlackBerry.h:
      (WebCore::EditorClientBlackBerry::frameWillDetachPage):
      
      Source/WebKit/chromium:
      
      Added WebTextCheckingCompletionImpl::invalidate() to mark
      pending spellcheck request as invalid, and added frameWillDetachPage()
      to fire it.
      
      Reviewed by Ryosuke Niwa.
      
      * src/EditorClientImpl.cpp:
      (WebKit::EditorClientImpl::frameWillDetachPage):
      (WebKit):
      (WebKit::EditorClientImpl::requestCheckingOfString):
      (WebKit::EditorClientImpl::didCheckString):
      * src/EditorClientImpl.h:
      (WebKit):
      (EditorClientImpl):
      * src/WebTextCheckingCompletionImpl.cpp:
      (WebKit::WebTextCheckingCompletionImpl::didFinishCheckingText):
      (WebKit::WebTextCheckingCompletionImpl::didCancelCheckingText):
      (WebKit::WebTextCheckingCompletionImpl::invalidate):
      (WebKit):
      * src/WebTextCheckingCompletionImpl.h:
      (WebKit):
      (WebKit::WebTextCheckingCompletionImpl::WebTextCheckingCompletionImpl):
      (WebTextCheckingCompletionImpl):
      (WebKit::WebTextCheckingCompletionImpl::spellChecker):
      
      Source/WebKit/efl:
      
      Reviewed by Ryosuke Niwa.
      
      * WebCoreSupport/EditorClientEfl.h:
      (WebCore::EditorClientEfl::frameWillDetachPage):
      
      Source/WebKit/gtk:
      
      Reviewed by Ryosuke Niwa.
      
      * WebCoreSupport/EditorClientGtk.h:
      (WebKit::EditorClient::frameWillDetachPage):
      
      Source/WebKit/mac:
      
      Reviewed by Ryosuke Niwa.
      
      * WebCoreSupport/WebEditorClient.h:
      
      Source/WebKit/qt:
      
      Reviewed by Ryosuke Niwa.
      
      * WebCoreSupport/EditorClientQt.h:
      (WebCore::EditorClientQt::frameWillDetachPage):
      
      Source/WebKit/win:
      
      Reviewed by Ryosuke Niwa.
      
      * WebCoreSupport/WebEditorClient.h:
      (WebEditorClient::frameWillDetachPage):
      
      Source/WebKit/wince:
      
      Reviewed by Ryosuke Niwa.
      
      * WebCoreSupport/EditorClientWinCE.h:
      (WebKit::EditorClientWinCE::frameWillDetachPage):
      
      Source/WebKit/wx:
      
      Reviewed by Ryosuke Niwa.
      
      * WebKitSupport/EditorClientWx.h:
      (WebCore::EditorClientWx::frameWillDetachPage):
      
      LayoutTests:
      
      Reviewed by Ryosuke Niwa.
      
      * editing/spelling/spellcheck-async-remove-frame-expected.txt: Added.
      * editing/spelling/spellcheck-async-remove-frame.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117572 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9da7b7cc
  13. 05 Apr, 2012 1 commit
    • jpu@apple.com's avatar
      2012-04-05 Jia Pu <jpu@apple.com> · 8d2f68b0
      jpu@apple.com authored
              Move correction panel related functions from EditorClient into separated AlternativeTextClient class.
              https://bugs.webkit.org/show_bug.cgi?id=82970
      
              Reviewed by Enrica Casucci.
      
              Move correction panel related functions from WebEditorClient to the new WebAlternativeTextClient.
              See WebCore/ChangeLog for details.
      
              * UIProcess/API/gtk/PageClientImpl.cpp:
              * UIProcess/API/mac/PageClientImpl.h:
              (PageClientImpl):
              * UIProcess/API/mac/PageClientImpl.mm:
              (WebKit::PageClientImpl::recordAutocorrectionResponse):
              * UIProcess/API/qt/qquickwebview.cpp:
              * UIProcess/PageClient.h:
              (PageClient):
              * UIProcess/WebPageProxy.cpp:
              (WebKit::WebPageProxy::recordAutocorrectionResponse):
              * UIProcess/mac/CorrectionPanel.h:
              * UIProcess/mac/CorrectionPanel.mm:
              * WebKit2.xcodeproj/project.pbxproj:
              * WebProcess/WebCoreSupport/mac/WebAlternativeTextClient.cpp: Added.
              (WebKit):
              (WebKit::WebAlternativeTextClient::WebAlternativeTextClient):
              (WebKit::WebAlternativeTextClient::~WebAlternativeTextClient):
              (WebKit::WebAlternativeTextClient::showCorrectionAlternative):
              (WebKit::WebAlternativeTextClient::dismissAlternative):
              (WebKit::WebAlternativeTextClient::dismissAlternativeSoon):
              (WebKit::WebAlternativeTextClient::recordAutocorrectionResponse):
              * WebProcess/WebCoreSupport/WebAlternativeTextClient.h: Added.
              (WebKit):
              (WebAlternativeTextClient):
              * WebProcess/WebCoreSupport/WebEditorClient.h:
              * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
              (WebKit):
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::WebPage):
      
      2012-04-05  Jia Pu  <jpu@apple.com>
      
              Move correction panel related functions from EditorClient into separated AlternativeTextClient class.
              https://bugs.webkit.org/show_bug.cgi?id=82970
      
              Reviewed by Enrica Casucci.
      
              Move correction panel related functions from WebEditorClient to the new WebAlternativeTextClient.
              See WebCore/ChangeLog for details.
      
              * WebCoreSupport/CorrectionPanel.h:
              * WebCoreSupport/CorrectionPanel.mm:
              * WebCoreSupport/WebAlternativeTextClient.h: Added.
              (WebAlternativeTextClient):
              * WebCoreSupport/WebAlternativeTextClient.mm: Added.
              (WebAlternativeTextClient::WebAlternativeTextClient):
              (WebAlternativeTextClient::~WebAlternativeTextClient):
              (WebAlternativeTextClient::showCorrectionAlternative):
              (WebAlternativeTextClient::dismissAlternative):
              (WebAlternativeTextClient::dismissAlternativeSoon):
              (WebAlternativeTextClient::recordAutocorrectionResponse):
              * WebCoreSupport/WebEditorClient.h:
              * WebCoreSupport/WebEditorClient.mm:
              (WebEditorClient::~WebEditorClient):
              * WebView/WebView.mm:
              (-[WebView _commonInitializationWithFrameName:groupName:]):
      
      2012-04-05  Jia Pu  <jpu@apple.com>
      
              Move correction panel related functions from EditorClient into separated AlternativeTextClient class.
              https://bugs.webkit.org/show_bug.cgi?id=82970
      
              Reviewed by Enrica Casucci.
      
              See WebCore/ChangeLog for details.
      
              * WebKit.xcodeproj/project.pbxproj:
      
      2012-04-05  Jia Pu  <jpu@apple.com>
      
              Move correction panel related functions from EditorClient into separated AlternativeTextClient class.
              https://bugs.webkit.org/show_bug.cgi?id=82970
      
              Reviewed by Enrica Casucci.
      
              No new tests, since there's no change of functionality.
      
              The existing correction panel related functions in EditorClient are currently used only by OS X.
              We'd like to move them into separate AlternativeTextClient class to avoid using #ifdef's. This
              new client class will also hold dictation alternative related interface that we will add soon for
              bug 82503.
      
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * editing/AlternativeTextController.cpp: Changes in this file are all for calling functions in
                AlternativeTextClient instead of those in EditoClient.
              (WebCore::AlternativeTextController::show):
              (WebCore::AlternativeTextController::dismiss):
              (WebCore::AlternativeTextController::dismissSoon):
              (WebCore::AlternativeTextController::respondToUnappliedSpellCorrection):
              (WebCore::AlternativeTextController::timerFired):
              (WebCore::AlternativeTextController::isAutomaticSpellingCorrectionEnabled):
              (WebCore::AlternativeTextController::alternativeTextClient):
              (WebCore):
              (WebCore::AlternativeTextController::editorClient):
              (WebCore::AlternativeTextController::textChecker):
              (WebCore::AlternativeTextController::recordAutocorrectionResponseReversed):
              (WebCore::AlternativeTextController::recordSpellcheckerResponseForModifiedCorrection):
              * editing/AlternativeTextController.h:
              (WebCore):
              (AlternativeTextController):
              * editing/TextCheckingHelper.h:
              (WebCore):
              * loader/EmptyClients.h:
              (EmptyEditorClient):
              * page/AlternativeTextClient.h: Added.
              (WebCore):
              (AlternativeTextClient):
              (WebCore::AlternativeTextClient::~AlternativeTextClient):
              * page/EditorClient.h:
              (EditorClient):
              * page/Page.cpp:
              (WebCore::Page::Page):
              (WebCore::Page::PageClients::PageClients):
              * page/Page.h:
              (WebCore):
              (PageClients):
              (Page):
              (WebCore::Page::alternativeTextClient):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113340 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d2f68b0
  14. 03 Apr, 2012 1 commit
  15. 15 Mar, 2012 1 commit
    • carlosgc@webkit.org's avatar
      [GTK] Implement unicode submenu items · d45765cb
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=81117
      
      Reviewed by Martin Robinson.
      
      Source/WebCore:
      
      * loader/EmptyClients.h:
      (WebCore::EmptyEditorClient::shouldShowUnicodeMenu): Just return
      false.
      * page/ContextMenuController.cpp:
      (WebCore::insertUnicodeCharacter): Helper function to insert a
      unicode character.
      (WebCore::ContextMenuController::contextMenuItemSelected):
      Implement unicode menu items using insertUnicodeCharacter() to
      insert the apropriate unicode character.
      (WebCore::ContextMenuController::createAndAppendUnicodeSubMenu):
      Create the unicode submenu.
      (WebCore::ContextMenuController::populate): Add unicode submenu
      item for editable content.
      (WebCore::ContextMenuController::checkOrEnableIfNeeded): Add
      unicode submenu items to the switch.
      * page/ContextMenuController.h:
      * page/EditorClient.h:
      (EditorClient): Add shouldShowUnicodeMenu() for GTK platform.
      * platform/ContextMenuItem.h:
      * platform/LocalizedStrings.h:
      * platform/gtk/LocalizedStringsGtk.cpp:
      (WebCore::contextMenuItemTagUnicodeInsertLRMMark): Add localized
      string for the unicode menu item.
      (WebCore::contextMenuItemTagUnicodeInsertRLMMark): Ditto.
      (WebCore::contextMenuItemTagUnicodeInsertLREMark): Ditto.
      (WebCore::contextMenuItemTagUnicodeInsertRLEMark): Ditto.
      (WebCore::contextMenuItemTagUnicodeInsertLROMark): Ditto.
      (WebCore::contextMenuItemTagUnicodeInsertRLOMark): Ditto.
      (WebCore::contextMenuItemTagUnicodeInsertPDFMark): Ditto.
      (WebCore::contextMenuItemTagUnicodeInsertZWSMark): Ditto.
      (WebCore::contextMenuItemTagUnicodeInsertZWJMark): Ditto.
      (WebCore::contextMenuItemTagUnicodeInsertZWNJMark): Ditto.
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/ContextMenuClientGtk.cpp:
      (WebKit::getUnicodeMenuItemPosition): Helper function to get the
      position of the unicode menu item in the default context menu.
      (WebKit::ContextMenuClient::getCustomMenuFromDefaultItems): Remove
      code to build the unicode menu, since it's now built by WebCore.
      * WebCoreSupport/EditorClientGtk.cpp:
      (WebKit::EditorClient::shouldShowUnicodeMenu): Check whether
      unicode menu should be shown based on gtk-show-unicode-menu GtkSetting.
      * WebCoreSupport/EditorClientGtk.h:
      
      Source/WebKit2:
      
      * WebProcess/WebCoreSupport/WebEditorClient.h:
      * WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:
      (WebKit::WebEditorClient::shouldShowUnicodeMenu): Implement
      shouldShowUnicodeMenu() returning always true. When ContextMenu
      API is implemented for GTK+ the UI process will decide whether to
      show the unicode menu or not.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110865 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d45765cb
  16. 28 Feb, 2012 1 commit
    • enrica@apple.com's avatar
      More Pasteboard code cleanup. · 3728b400
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=79816
      
      Source/WebCore: 
      
      Removing the last references to NSPasteboard.
      
      Reviewed by Alexey Proskuryakov.
      
      No new tests. No change in functionality.
      
      * WebCore.xcodeproj/project.pbxproj:
      * editing/mac/EditorMac.mm:
      (WebCore::Editor::pasteWithPasteboard):
      (WebCore::Editor::takeFindStringFromSelection):
      * loader/EmptyClients.h:
      (WebCore::EmptyEditorClient::setInsertionPasteboard):
      * page/DragClient.h:
      * page/EditorClient.h:
      * platform/DragData.h:
      * platform/Pasteboard.h:
      * platform/mac/ClipboardMac.h:
      * platform/mac/PasteboardHelper.h: Removed.
      
      Source/WebKit/mac: 
      
      Removing the last references to NSPasteboard.
      
      Reviewed by Alexey Proskuryakov.
      
      * WebCoreSupport/WebEditorClient.h:
      * WebCoreSupport/WebEditorClient.mm:
      (WebEditorClient::setInsertionPasteboard):
      
      Source/WebKit2: 
      
      Removing the last references to NSPasteboard.
              
      Reviewed by Alexey Proskuryakov.
      
      * WebProcess/WebCoreSupport/WebEditorClient.h:
      * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
      (WebKit::WebEditorClient::setInsertionPasteboard):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@109147 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3728b400
  17. 22 Feb, 2012 1 commit
    • rniwa@webkit.org's avatar
      Remove the remaining uses of CSSStyleDeclaration in Editor · 9a9656e8
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=78939
      
      Reviewed by Enrica Casucci.
      
      Source/WebCore:
      
      Changed the argument types of shouldApplyStyle, applyParagraphStyle, applyStyleToSelection,
      applyParagraphStyleToSelection, and computeAndSetTypingStyle in Editor from CSSStyleDeclaration
      to StylePropertySet.
      
      * WebCore.exp.in:
      * WebCore.xcodeproj/project.pbxproj:
      * editing/Editor.cpp:
      (WebCore::Editor::applyStyle):
      (WebCore::Editor::shouldApplyStyle):
      (WebCore::Editor::applyParagraphStyle):
      (WebCore::Editor::applyStyleToSelection):
      (WebCore::Editor::applyParagraphStyleToSelection):
      (WebCore::Editor::setBaseWritingDirection):
      (WebCore::Editor::computeAndSetTypingStyle):
      * editing/Editor.h:
      (WebCore):
      (Editor):
      * editing/EditorCommand.cpp:
      (WebCore::applyCommandToFrame):
      (WebCore::executeApplyParagraphStyle):
      (WebCore::executeMakeTextWritingDirectionLeftToRight):
      (WebCore::executeMakeTextWritingDirectionNatural):
      (WebCore::executeMakeTextWritingDirectionRightToLeft):
      * loader/EmptyClients.h:
      (WebCore::EmptyEditorClient::shouldApplyStyle):
      * page/DragController.cpp:
      (WebCore::DragController::concludeEditDrag):
      * page/EditorClient.h:
      (WebCore):
      (EditorClient):
      
      Source/WebKit/blackberry:
      
      * WebCoreSupport/EditorClientBlackBerry.cpp:
      (WebCore::EditorClientBlackBerry::shouldApplyStyle):
      * WebCoreSupport/EditorClientBlackBerry.h:
      (EditorClientBlackBerry):
      
      Source/WebKit/chromium:
      
      * src/EditorClientImpl.cpp:
      (WebKit::EditorClientImpl::shouldApplyStyle):
      * src/EditorClientImpl.h:
      (EditorClientImpl):
      
      Source/WebKit/efl:
      
      * WebCoreSupport/EditorClientEfl.cpp:
      (WebCore::EditorClientEfl::shouldApplyStyle):
      * WebCoreSupport/EditorClientEfl.h:
      (EditorClientEfl):
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/EditorClientGtk.cpp:
      (WebKit::EditorClient::shouldApplyStyle):
      * WebCoreSupport/EditorClientGtk.h:
      (EditorClient):
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebEditorClient.h:
      (WebEditorClient):
      * WebCoreSupport/WebEditorClient.mm:
      (WebEditorClient::shouldApplyStyle):
      * WebView/WebFrame.mm:
      (-[WebFrame _setTypingStyle:withUndoAction:]):
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
      (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
      * WebView/WebView.mm:
      (-[WebView applyStyle:]):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/EditorClientQt.cpp:
      (WebCore::EditorClientQt::shouldApplyStyle):
      * WebCoreSupport/EditorClientQt.h:
      (EditorClientQt):
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebEditorClient.cpp:
      (WebEditorClient::shouldApplyStyle):
      * WebCoreSupport/WebEditorClient.h:
      (WebEditorClient):
      
      Source/WebKit/wince:
      
      * WebCoreSupport/EditorClientWinCE.cpp:
      (WebKit::EditorClientWinCE::shouldApplyStyle):
      
      Source/WebKit/wx:
      
      * WebKitSupport/EditorClientWx.cpp:
      (WebCore::EditorClientWx::shouldApplyStyle):
      * WebKitSupport/EditorClientWx.h:
      (EditorClientWx):
      
      Source/WebKit2:
      
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      (WebKit::WebEditorClient::shouldApplyStyle):
      * WebProcess/WebCoreSupport/WebEditorClient.h:
      (WebEditorClient):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108462 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a9656e8
  18. 17 Jan, 2012 1 commit
    • weinig@apple.com's avatar
      Add helper macro for forward declaring objective-c classes · c122cb2f
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=76485
      
      Reviewed by Anders Carlsson.
      
      Source/JavaScriptCore:
      
      * wtf/Compiler.h:
      Add OBJC_CLASS macro which helps reduce code when forward declaring an
      objective-c class in a header which can be included from both Objective-C
      and non-Objective-C files.
      
      Source/WebCore:
      
      * accessibility/AccessibilityObject.h:
      * bindings/js/ScriptController.h:
      * bridge/objc/objc_utility.h:
      * page/DragClient.h:
      * page/EditorClient.h:
      * platform/AutodrainedPool.h:
      * platform/ContextMenuItem.h:
      * platform/Cursor.h:
      * platform/DragData.h:
      * platform/DragImage.h:
      * platform/KURL.h:
      * platform/Pasteboard.h:
      * platform/PlatformKeyboardEvent.h:
      * platform/PlatformMenuDescription.h:
      * platform/PlatformScreen.h:
      * platform/SharedBuffer.h:
      * platform/Widget.h:
      * platform/cf/SchedulePair.h:
      * platform/graphics/BitmapImage.h:
      * platform/graphics/FontPlatformData.h:
      * platform/graphics/GraphicsContext3D.h:
      * platform/graphics/GraphicsLayer.h:
      * platform/graphics/Icon.h:
      * platform/graphics/Image.h:
      * platform/graphics/MediaPlayer.h:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
      * platform/graphics/ca/PlatformCAAnimation.h:
      * platform/graphics/ca/mac/TileCache.h:
      * platform/graphics/mac/ColorMac.h:
      * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
      * platform/graphics/mac/MediaPlayerProxy.h:
      * platform/mac/ClipboardMac.h:
      * platform/mac/LocalCurrentGraphicsContext.h:
      * platform/mac/PasteboardHelper.h:
      * platform/mac/PopupMenuMac.h:
      * platform/mac/ScrollAnimatorMac.h:
      * platform/mac/WebCoreSystemInterface.h:
      * platform/network/ResourceHandle.h:
      * platform/network/ResourceHandleClient.h:
      * platform/network/ResourceHandleInternal.h:
      * platform/network/cf/AuthenticationChallenge.h:
      * platform/network/cf/ResourceError.h:
      * platform/network/cf/ResourceRequest.h:
      * platform/network/cf/ResourceResponse.h:
      * rendering/RenderThemeMac.h:
      Deploy OBJC_CLASS for a little code reduction.
      
      Source/WebKit2:
      
      * WebProcess/WebCoreSupport/WebDragClient.h:
      Deploy OBJC_CLASS for a little code reduction.
      
      * config.h:
      Remove duplicate copy of OBJC_CLASS.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105203 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c122cb2f
  19. 16 Dec, 2011 2 commits
    • rniwa@webkit.org's avatar
      Rename registerCommandFor(Undo|Redo) to register(Undo|Redo)Step · 5119ee9f
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=74748
      
      Reviewed by Eric Seidel.
      
      Source/WebCore: 
      
      Renamed registerCommandForUndo and registerCommandForRedo to
      registerUndoStep and registerRedoStep respectively.
      
      * editing/Editor.cpp:
      (WebCore::Editor::appliedEditing):
      (WebCore::Editor::unappliedEditing):
      (WebCore::Editor::reappliedEditing):
      * loader/EmptyClients.h:
      (WebCore::EmptyEditorClient::registerUndoStep):
      (WebCore::EmptyEditorClient::registerRedoStep):
      * page/EditorClient.h:
      
      Source/WebKit/chromium: 
      
      * src/EditorClientImpl.cpp:
      (WebKit::EditorClientImpl::registerUndoStep):
      (WebKit::EditorClientImpl::registerRedoStep):
      * src/EditorClientImpl.h:
      
      Source/WebKit/efl: 
      
      * WebCoreSupport/EditorClientEfl.cpp:
      (WebCore::EditorClientEfl::registerUndoStep):
      (WebCore::EditorClientEfl::registerRedoStep):
      * WebCoreSupport/EditorClientEfl.h:
      
      Source/WebKit/gtk: 
      
      * WebCoreSupport/EditorClientGtk.cpp:
      (WebKit::EditorClient::registerUndoStep):
      (WebKit::EditorClient::registerRedoStep):
      * WebCoreSupport/EditorClientGtk.h:
      
      Source/WebKit/mac: 
      
      * WebCoreSupport/WebEditorClient.h:
      * WebCoreSupport/WebEditorClient.mm:
      (WebEditorClient::registerUndoOrRedoStep):
      (WebEditorClient::registerUndoStep):
      (WebEditorClient::registerRedoStep):
      
      Source/WebKit/qt: 
      
      * WebCoreSupport/EditorClientQt.cpp:
      (WebCore::EditorClientQt::registerUndoStep):
      (WebCore::EditorClientQt::registerRedoStep):
      * WebCoreSupport/EditorClientQt.h:
      
      Source/WebKit/win: 
      
      * WebCoreSupport/WebEditorClient.cpp:
      (WebEditorClient::registerUndoStep):
      (WebEditorClient::registerRedoStep):
      * WebCoreSupport/WebEditorClient.h:
      
      Source/WebKit/wince: 
      
      * WebCoreSupport/EditorClientWinCE.cpp:
      (WebKit::EditorClientWinCE::registerUndoStep):
      (WebKit::EditorClientWinCE::registerRedoStep):
      * WebCoreSupport/EditorClientWinCE.h:
      
      Source/WebKit/wx: 
      
      * WebKitSupport/EditorClientWx.cpp:
      (WebCore::EditorClientWx::registerUndoStep):
      (WebCore::EditorClientWx::registerRedoStep):
      * WebKitSupport/EditorClientWx.h:
      
      Source/WebKit2: 
      
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      (WebKit::WebEditorClient::registerUndoStep):
      (WebKit::WebEditorClient::registerRedoStep):
      * WebProcess/WebCoreSupport/WebEditorClient.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103119 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5119ee9f
    • rniwa@webkit.org's avatar
      Only EditCommandComposition should implement unapply and reapply · 12e984a8
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=74490
      
      Reviewed by Eric Seidel.
      
      Source/WebCore: 
      
      Introduce new abstract class UndoStep to replace EditCommand for EditorClient, and make EditCommand
      private to WebCore.
      
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.exp.in:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * editing/CompositeEditCommand.cpp:
      (WebCore::EditCommandComposition::create): Takes EditAction instead of boolean for CreateLinkCommand.
      (WebCore::EditCommandComposition::EditCommandComposition): Ditto.
      (WebCore::EditCommandComposition::unapply): Moved from EditCommand; we don't have to call isTopLevelCommand
      anymore because EditCommandComposition is always top-level. In fact, the only thing unapply/reapply do
      in addition to what doUnapply/doReapply do for sub-level commands is disabling and enabling delete button
      and defining an event queue scope. However, these can be done at top-level command anyway, so we now only call
      doApply for sub-level commands.
      (WebCore::EditCommandComposition::reapply): Ditto.
      (WebCore::EditCommandComposition::setStartingSelection): Added.
      (WebCore::EditCommandComposition::setEndingSelection): Added.
      (WebCore::applyCommand): Moved from EditCommand.
      (WebCore::CompositeEditCommand::apply): Moved from EditCommand; doesn't call isTopLevelCommand for the same reason.
      (WebCore::CompositeEditCommand::ensureComposition):
      (WebCore::CompositeEditCommand::applyCommandToComposite): Call doApply instead of apply for the same reason.
      * editing/CompositeEditCommand.h:
      (WebCore::EditCommandComposition::wasCreateLinkCommand):
      (WebCore::EditCommandComposition::startingSelection): Added.
      (WebCore::EditCommandComposition::endingSelection): Added.
      * editing/EditCommand.cpp:
      (WebCore::EditCommand::setStartingSelection):
      (WebCore::EditCommand::setEndingSelection):
      (WebCore::SimpleEditCommand::doReapply): Moved from EditCommand.
      * editing/EditCommand.h:
      * editing/UndoStep.h: Added.
      (WebCore::UndoStep::~UndoStep):
      * loader/EmptyClients.h:
      (WebCore::EmptyEditorClient::shouldInsertNode):
      (WebCore::EmptyEditorClient::didSetSelectionTypesForPasteboard):
      (WebCore::EmptyEditorClient::registerCommandForUndo): Takes UndoStep instead of EditCommand.
      (WebCore::EmptyEditorClient::registerCommandForRedo): Ditto.
      * page/EditorClient.h:
      
      Source/WebKit/chromium: 
      
      * src/EditorClientImpl.cpp:
      (WebKit::EditorClientImpl::registerCommandForUndo):
      (WebKit::EditorClientImpl::registerCommandForRedo):
      (WebKit::EditorClientImpl::undo):
      (WebKit::EditorClientImpl::redo):
      * src/EditorClientImpl.h:
      
      Source/WebKit/efl: 
      
      * WebCoreSupport/EditorClientEfl.cpp:
      (WebCore::EditorClientEfl::registerCommandForUndo):
      (WebCore::EditorClientEfl::registerCommandForRedo):
      (WebCore::EditorClientEfl::undo):
      (WebCore::EditorClientEfl::redo):
      * WebCoreSupport/EditorClientEfl.h:
      
      Source/WebKit/gtk: 
      
      * WebCoreSupport/EditorClientGtk.cpp:
      (WebKit::EditorClient::registerCommandForUndo):
      (WebKit::EditorClient::registerCommandForRedo):
      (WebKit::EditorClient::undo):
      (WebKit::EditorClient::redo):
      * WebCoreSupport/EditorClientGtk.h:
      
      Source/WebKit/mac: 
      
      * WebCoreSupport/WebEditorClient.h:
      * WebCoreSupport/WebEditorClient.mm:
      (-[WebUndoStep initWithUndoStep:]):
      (-[WebUndoStep dealloc]):
      (+[WebUndoStep stepWithUndoStep:]):
      (-[WebUndoStep step]):
      (-[WebEditorUndoTarget undoEditing:]):
      (-[WebEditorUndoTarget redoEditing:]):
      (WebEditorClient::registerCommandForUndoOrRedo):
      (WebEditorClient::registerCommandForUndo):
      (WebEditorClient::registerCommandForRedo):
      
      Source/WebKit/qt: 
      
      EditCommandQt is to be renamed to UndoStepQt in a follow up patch.
      
      * WebCoreSupport/EditCommandQt.cpp:
      (EditCommandQt::EditCommandQt):
      * WebCoreSupport/EditCommandQt.h:
      * WebCoreSupport/EditorClientQt.cpp:
      (WebCore::EditorClientQt::registerCommandForUndo):
      (WebCore::EditorClientQt::registerCommandForRedo):
      
      Source/WebKit/win: 
      
      * WebCoreSupport/WebEditorClient.cpp:
      (WebEditorUndoCommand::WebEditorUndoCommand):
      (WebEditorUndoCommand::execute):
      (WebEditorClient::registerCommandForUndo):
      (WebEditorClient::registerCommandForRedo):
      * WebCoreSupport/WebEditorClient.h:
      
      Source/WebKit/wince: 
      
      * WebCoreSupport/EditorClientWinCE.cpp:
      (WebKit::EditorClientWinCE::registerCommandForUndo):
      (WebKit::EditorClientWinCE::registerCommandForRedo):
      * WebCoreSupport/EditorClientWinCE.h:
      
      Source/WebKit2: 
      
      Renamed WebEditCommand to WebUndoStep and made necessary changes.
      Everything on WebProcess side should have the correct name now.
      
      Names in the proxy and UIProcess are to be updated in a follow up.
      
      * CMakeLists.txt:
      * GNUmakefile.am:
      * Target.pri:
      * WebKit2.xcodeproj/project.pbxproj:
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      (WebKit::WebEditorClient::registerCommandForUndo):
      (WebKit::WebEditorClient::registerCommandForRedo):
      * WebProcess/WebCoreSupport/WebEditorClient.h:
      * WebProcess/WebPage/WebEditCommand.cpp: Removed.
      * WebProcess/WebPage/WebEditCommand.h: Removed.
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::webUndoStep):
      (WebKit::WebPage::addWebUndoStep):
      (WebKit::WebPage::removeWebEditCommand):
      (WebKit::WebPage::unapplyEditCommand):
      (WebKit::WebPage::reapplyEditCommand):
      * WebProcess/WebPage/WebPage.h:
      * WebProcess/WebPage/WebUndoStep.cpp: Copied from Source/WebKit2/WebProcess/WebPage/WebEditCommand.cpp.
      (WebKit::generateUndoStep):
      (WebKit::WebUndoStep::create):
      * WebProcess/WebPage/WebUndoStep.h: Copied from Source/WebKit2/WebProcess/WebPage/WebEditCommand.h.
      (WebKit::WebUndoStep::entry):
      (WebKit::WebUndoStep::entryID):
      (WebKit::WebUndoStep::WebUndoStep):
      * win/WebKit2.vcproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103104 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      12e984a8
  20. 20 Nov, 2011 1 commit
    • tonikitoo@webkit.org's avatar
      2011-10-17 Antonio Gomes <agomes@rim.com> · 73c1c052
      tonikitoo@webkit.org authored
              Pass a Frame* parameter in EditorClient::respondToChangedSelection
              https://bugs.webkit.org/show_bug.cgi?id=70248
      
              Reviewed by Ryosuke Niwa.
      
              Most of the port specific implementations of EditorClient::respondToChangedSelection
              (like EditorClient{Qt,Gtk,etc}) are wrongly relying on FocusController::focusedOrMainFrame
              method to get the Frame where the selection is happening on.
      
              It is not right, since a selection can be easily triggered in an inner
              frame that is not focused.
      
              No new tests since it is a hard thing to test without
              to hook into editor client in layout tests. We could
              change the "Dumped Delegate" messages, but it would
              require a rebasile of +1200 for a minor change.
      
              No new tests since it is a hard thing to test without
              to hook into editor client in layout tests. We could
              change the "Dumped Delegate" messages, but it would
              require a rebasile of +1200 for a minor change.
      
              Source/WebCore:
              * editing/Editor.cpp: Pass the Frame on where the selection is changing to the client.
              (WebCore::Editor::respondToChangedSelection): Ditto.
              (WebCore::Editor::changeSelectionAfterCommand): Ditto.
              (WebCore::EmptyEditorClient::respondToChangedSelection):
              * page/EditorClient.h:  Pass Frame* to indicate where the selection is happening.
              * loader/EmptyClients.h: Changed signature as per base class change.
      
              Source/WebKit/chromium:
              * src/EditorClientImpl.cpp: Make use of the newly added Frame* parameter.
              (WebKit::EditorClientImpl::respondToChangedSelection):
              * src/EditorClientImpl.h:
      
              Source/WebKit/efl:
              * WebCoreSupport/EditorClientEfl.cpp: Make use of the newly added Frame* parameter.
              (WebCore::EditorClientEfl::respondToChangedSelection):
              * WebCoreSupport/EditorClientEfl.h:
      
              Source/WebKit/gtk:
              * WebCoreSupport/EditorClientGtk.cpp: Make use of the newly added Frame* parameter.
              (WebKit::EditorClient::respondToChangedSelection):
              * WebCoreSupport/EditorClientGtk.h:
      
              Source/WebKit/mac:
              * WebCoreSupport/WebEditorClient.h: Make use of the newly added Frame* parameter.
              * WebCoreSupport/WebEditorClient.mm:
              (WebEditorClient::respondToChangedSelection):
      
              Source/WebKit/qt:
              * WebCoreSupport/EditorClientQt.cpp: Make use of the newly added Frame* parameter.
              (WebCore::EditorClientQt::respondToChangedSelection):
              * WebCoreSupport/EditorClientQt.h:
      
              Source/WebKit/win:
              * WebCoreSupport/WebEditorClient.cpp: Make use of the newly added Frame* parameter.
              (WebEditorClient::respondToChangedSelection):
              * WebCoreSupport/WebEditorClient.h:
      
              Source/WebKit/wx:
              * WebKitSupport/EditorClientWx.cpp: Make use of the newly added Frame* parameter.
              (WebCore::EditorClientWx::respondToChangedSelection):
              * WebKitSupport/EditorClientWx.h:
      
              Source/WebKit2:
              * WebProcess/WebCoreSupport/WebEditorClient.cpp: Make use of the newly added Frame* parameter.
              (WebKit::WebEditorClient::respondToChangedSelection):
              * WebProcess/WebCoreSupport/WebEditorClient.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73c1c052
  21. 24 May, 2011 1 commit
    • morrita@google.com's avatar
      2011-05-22 MORITA Hajime <morrita@google.com> · b99ad684
      morrita@google.com authored
              Reviewed by Ryosuke Niwa.
      
              SUPPORT_AUTOCORRECTION_PANEL should be USE(AUTOCORRECTION_PANEL)
              https://bugs.webkit.org/show_bug.cgi?id=61181
      
              - Removed SUPPORT_AUTOCORRECTION_PANEL and REMOVE_MARKERS_UPON_EDITING from SpellingCorrectionController.h
              - Define WTF_USE_UNIFIED_TEXT_CHECKING and WTF_USE_AUTOMATIC_TEXT_REPLACEMENT at TextChecking.h
      
              No new tests. Just renaming a compilation conditional.
      
              * editing/Editor.cpp:
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
              * editing/SpellingCorrectionCommand.cpp:
              (WebCore::SpellingCorrectionCommand::doApply):
              * editing/SpellingCorrectionController.cpp:
              * editing/SpellingCorrectionController.h:
              (WebCore::SpellingCorrectionController::shouldRemoveMarkersUponEditing):
              * loader/EmptyClients.h:
              * page/EditorClient.h:
              * platform/text/TextChecking.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87117 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b99ad684
  22. 13 May, 2011 1 commit
    • weinig@apple.com's avatar
      2011-05-13 Sam Weinig <sam@webkit.org> · c5b2001d
      weinig@apple.com authored
              Reviewed by Anders Carlsson.
      
              Prune #includes from FrameView.h (Part 2)
              https://bugs.webkit.org/show_bug.cgi?id=60748
      
              - Update files that were depending on FrameView.h #including Frame.h or
                Page.h.
      
              * src/AutoFillPopupMenuClient.cpp:
              * src/PlatformBridge.cpp:
              * src/WebPopupMenuImpl.cpp:
      2011-05-13  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              Prune #includes from FrameView.h (Part 2)
              https://bugs.webkit.org/show_bug.cgi?id=60748
      
              - Update files that were depending on FrameView.h #including Frame.h or
                Page.h.
      
              * Api/qgraphicswebview.cpp:
              * WebCoreSupport/ChromeClientQt.cpp:
      2011-05-13  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              Prune #includes from FrameView.h (Part 2)
              https://bugs.webkit.org/show_bug.cgi?id=60748
      
              - Update files that were depending on FrameView.h #including Frame.h or
                Page.h.
      
              * WebCoreSupport/GtkAdjustmentWatcher.cpp:
      2011-05-13  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              Prune #includes from FrameView.h (Part 2)
              https://bugs.webkit.org/show_bug.cgi?id=60748
      
              - Update files that were depending on FrameView.h #including Frame.h or
                Page.h.
      
              * WebCoreSupport/WebChromeClient.cpp:
              * WebCoreSupport/WebDragClient.cpp:
              * WebCoreSupport/WebFrameLoaderClient.cpp:
              * WebFrame.cpp:
              (WebFrame::setPrinting):
              * WebView.cpp:
      2011-05-13  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              Prune #includes from FrameView.h (Part 2)
              https://bugs.webkit.org/show_bug.cgi?id=60748
      
              - Update files that were depending on FrameView.h #including Frame.h or
                Page.h.
      
              * WebView/WebClipView.mm:
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
      2011-05-13  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              Prune #includes from FrameView.h (Part 2)
              https://bugs.webkit.org/show_bug.cgi?id=60748
      
              - Replace #includes in FrameView.h of Frame.h and Page.h
                with Color.h, wtf/text/WTFString.h, and the new AdjustViewSizeOrNot.h
      
              - Update files that were depending on FrameView.h #including Frame.h or
                Page.h.
      
              * GNUmakefile.list.am:
              * WebCore.exp.in:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * accessibility/AccessibilityRenderObject.cpp:
              * accessibility/AccessibilityScrollView.cpp:
              * accessibility/chromium/AXObjectCacheChromium.cpp:
              * accessibility/mac/AccessibilityObjectWrapper.mm:
              * css/MediaQueryMatcher.cpp:
              * dom/Range.cpp:
              * editing/SpellingCorrectionController.cpp:
              * history/CachedFrame.cpp:
              * html/HTMLBodyElement.cpp:
              * html/canvas/WebGLRenderingContext.cpp:
              * html/parser/HTMLParserScheduler.cpp:
              * page/AdjustViewSizeOrNot.h: Added.
              * page/EditorClient.h:
              * page/Frame.h:
              * page/FrameView.cpp:
              (WebCore::FrameView::forceLayoutForPagination):
              * page/FrameView.h:
              * page/PrintContext.cpp:
              (WebCore::PrintContext::begin):
              (WebCore::PrintContext::end):
              * page/chromium/FrameChromium.cpp:
              * page/win/FrameCGWin.cpp:
              * page/win/FrameWin.cpp:
              * platform/efl/PopupMenuEfl.cpp:
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
              * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
              * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
              * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
              * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
              * platform/gtk/WidgetGtk.cpp:
              * plugins/IFrameShimSupport.cpp:
              * rendering/RenderBlock.cpp:
              * rendering/RenderBoxModelObject.cpp:
              * rendering/RenderFrameBase.cpp:
              * rendering/RenderIFrame.cpp:
              * rendering/RenderMenuList.cpp:
              * rendering/RenderTextControlSingleLine.cpp:
              * rendering/RenderWidget.cpp:
              * svg/SVGSVGElement.cpp:
      2011-05-13  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              Prune #includes from FrameView.h (Part 2)
              https://bugs.webkit.org/show_bug.cgi?id=60748
      
              - Update files that were depending on FrameView.h #including Frame.h or
                Page.h.
      
              * WebProcess/Plugins/PluginView.cpp:
              * WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
              * WebProcess/WebPage/WebContextMenu.cpp:
              * WebProcess/WebPage/mac/AccessibilityWebPageObject.mm:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5b2001d
  23. 27 Apr, 2011 1 commit
  24. 22 Apr, 2011 1 commit
    • rniwa@webkit.org's avatar
      2011-04-21 Ryosuke Niwa <rniwa@webkit.org> · f5a84a01
      rniwa@webkit.org authored
              Reviewed by Sam Weinig.
      
              Add Frame* to the argument lists of canCopyCut and canPaste
              https://bugs.webkit.org/show_bug.cgi?id=59153
      
              * src/EditorClientImpl.cpp:
              (WebKit::EditorClientImpl::canCopyCut):
              (WebKit::EditorClientImpl::canPaste):
              * src/EditorClientImpl.h:
      2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Sam Weinig.
      
              Add Frame* to the argument lists of canCopyCut and canPaste
              https://bugs.webkit.org/show_bug.cgi?id=59153
      
              * WebCoreSupport/EditorClientQt.cpp:
              (WebCore::EditorClientQt::canCopyCut):
              (WebCore::EditorClientQt::canPaste):
              * WebCoreSupport/EditorClientQt.h:
      2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Sam Weinig.
      
              Add Frame* to the argument lists of canCopyCut and canPaste
              https://bugs.webkit.org/show_bug.cgi?id=59153
      
              * WebCoreSupport/EditorClientGtk.cpp:
              (WebKit::EditorClient::canCopyCut):
              (WebKit::EditorClient::canPaste):
              * WebCoreSupport/EditorClientGtk.h:
      2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Sam Weinig.
      
              Add Frame* to the argument lists of canCopyCut and canPaste
              https://bugs.webkit.org/show_bug.cgi?id=59153
      
              * WebCoreSupport/WebEditorClient.cpp:
              (WebEditorClient::canCopyCut):
              (WebEditorClient::canPaste):
              * WebCoreSupport/WebEditorClient.h:
      2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Sam Weinig.
      
              Add Frame* to the argument lists of canCopyCut and canPaste
              https://bugs.webkit.org/show_bug.cgi?id=59153
      
              * WebKitSupport/EditorClientWx.cpp:
              (WebCore::EditorClientWx::canCopyCut):
              (WebCore::EditorClientWx::canPaste):
              * WebKitSupport/EditorClientWx.h:
      2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Sam Weinig.
      
              Add Frame* to the argument lists of canCopyCut and canPaste
              https://bugs.webkit.org/show_bug.cgi?id=59153
      
              * WebCoreSupport/WebEditorClient.h:
              * WebCoreSupport/WebEditorClient.mm:
              (WebEditorClient::canCopyCut):
              (WebEditorClient::canPaste):
      2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Sam Weinig.
      
              Add Frame* to the argument lists of canCopyCut and canPaste
              https://bugs.webkit.org/show_bug.cgi?id=59153
      
              * WebCoreSupport/EditorClientHaiku.cpp:
              (WebCore::EditorClientHaiku::canCopyCut):
              (WebCore::EditorClientHaiku::canPaste):
              * WebCoreSupport/EditorClientHaiku.h:
      2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Sam Weinig.
      
              Add Frame* to the argument lists of canCopyCut and canPaste
              https://bugs.webkit.org/show_bug.cgi?id=59153
      
              * WebCoreSupport/EditorClientEfl.cpp:
              (WebCore::EditorClientEfl::canCopyCut):
              (WebCore::EditorClientEfl::canPaste):
              * WebCoreSupport/EditorClientEfl.h:
      2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Sam Weinig.
      
              Add Frame* to the argument lists of canCopyCut and canPaste
              https://bugs.webkit.org/show_bug.cgi?id=59153
      
              canCopyCut and canPaste now takes Frame* for which supportedCopyCut and supportedPaste are called.
              This allows editor client to grant copy/cut and paste permissions per origin.
      
              * editing/EditorCommand.cpp:
              (WebCore::supportedCopyCut):
              (WebCore::supportedPaste):
              * loader/EmptyClients.h:
              (WebCore::EmptyEditorClient::canCopyCut):
              (WebCore::EmptyEditorClient::canPaste):
              * page/EditorClient.h:
      2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Sam Weinig.
      
              Add Frame* to the argument lists of canCopyCut and canPaste
              https://bugs.webkit.org/show_bug.cgi?id=59153
      
              * WebProcess/WebCoreSupport/WebEditorClient.cpp:
              (WebKit::WebEditorClient::canCopyCut):
              (WebKit::WebEditorClient::canPaste):
              * WebProcess/WebCoreSupport/WebEditorClient.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84574 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5a84a01
  25. 08 Apr, 2011 1 commit
    • morrita@google.com's avatar
      2011-04-06 MORITA Hajime <morrita@google.com> · 4e40c8bf
      morrita@google.com authored
              Reviewed by Darin Adler.
      
              [Refactoring] Auto correction panel should be handled by its own class.
              https://bugs.webkit.org/show_bug.cgi?id=55571
      
              Extracted code inside SUPPORT_AUTOCORRECTION_PANEL into
              SpellingCorrectionController class.
              This change also remove some SUPPORT_AUTOCORRECTION_PANEL guard if
              code paths inside the never reached without autocorrection support.
              Removing guards reduces unintentional build breakage.
      
              No new tests, no behavior chagne.
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * editing/CorrectionPanelInfo.h: Removed.
              * editing/EditingAllInOne.cpp:
              * editing/Editor.cpp:
              (WebCore::Editor::respondToChangedSelection):
              (WebCore::Editor::respondToChangedContents):
              (WebCore::Editor::appliedEditing):
              (WebCore::Editor::Editor):
              (WebCore::Editor::~Editor):
              (WebCore::Editor::insertTextWithoutSendingTextEvent):
              (WebCore::Editor::insertLineBreak):
              (WebCore::Editor::insertParagraphSeparator):
              (WebCore::Editor::cut):
              (WebCore::Editor::paste):
              (WebCore::Editor::pasteAsPlainText):
              (WebCore::Editor::isAutomaticSpellingCorrectionEnabled):
              (WebCore::Editor::markMisspellingsAfterTypingToWord):
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
              (WebCore::Editor::changeBackToReplacedString):
              (WebCore::Editor::unappliedSpellCorrection):
              (WebCore::Editor::updateMarkersForWordsAffectedByEditing):
              (WebCore::Editor::startCorrectionPanelTimer):
              (WebCore::Editor::handleCorrectionPanelResult):
              (WebCore::Editor::dismissCorrectionPanelAsIgnored):
              * editing/Editor.h:
              * editing/SpellingCorrectionCommand.cpp:
              * editing/SpellingCorrectionController.cpp: Added.
              (WebCore::markerTypesForAutocorrection):
              (WebCore::markerTypesForReplacement):
              (WebCore::markersHaveIdenticalDescription):
              (WebCore::SpellingCorrectionController::SpellingCorrectionController):
              (WebCore::SpellingCorrectionController::~SpellingCorrectionController):
              (WebCore::SpellingCorrectionController::startCorrectionPanelTimer):
              (WebCore::SpellingCorrectionController::stopCorrectionPanelTimer):
              (WebCore::SpellingCorrectionController::stopPendingCorrection):
              (WebCore::SpellingCorrectionController::applyPendingCorrection):
              (WebCore::SpellingCorrectionController::hasPendingCorrection):
              (WebCore::SpellingCorrectionController::isSpellingMarkerAllowed):
              (WebCore::SpellingCorrectionController::show):
              (WebCore::SpellingCorrectionController::handleCancelOperation):
              (WebCore::SpellingCorrectionController::dismiss):
              (WebCore::SpellingCorrectionController::dismissSoon):
              (WebCore::SpellingCorrectionController::applyCorrectionPanelInfo):
              (WebCore::SpellingCorrectionController::applyAutocorrectionBeforeTypingIfAppropriate):
              (WebCore::SpellingCorrectionController::respondToUnappliedSpellCorrection):
              (WebCore::SpellingCorrectionController::correctionPanelTimerFired):
              (WebCore::SpellingCorrectionController::handleCorrectionPanelResult):
              (WebCore::SpellingCorrectionController::isAutomaticSpellingCorrectionEnabled):
              (WebCore::SpellingCorrectionController::windowRectForRange):
              (WebCore::SpellingCorrectionController::respondToChangedSelection):
              (WebCore::SpellingCorrectionController::respondToAppliedEditing):
              (WebCore::SpellingCorrectionController::client):
              (WebCore::SpellingCorrectionController::textChecker):
              (WebCore::SpellingCorrectionController::recordAutocorrectionResponseReversed):
              (WebCore::SpellingCorrectionController::markReversed):
              (WebCore::SpellingCorrectionController::markCorrection):
              (WebCore::SpellingCorrectionController::recordSpellcheckerResponseForModifiedCorrection):
              * editing/SpellingCorrectionController.h: Added.
              (WebCore::SpellingCorrectionController::UNLESS_ENABLED):
              (WebCore::SpellingCorrectionController::shouldStartTimeFor):
              (WebCore::SpellingCorrectionController::shouldRemoveMarkersUponEditing):
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::insertText):
              (WebCore::TypingCommand::markMisspellingsAfterTyping):
              (WebCore::TypingCommand::deleteKeyPressed):
              (WebCore::TypingCommand::forwardDeleteKeyPressed):
              * editing/htmlediting.h:
              (WebCore::isAmbiguousBoundaryCharacter):
              * page/EditorClient.h:
              * page/Frame.cpp:
              (WebCore::Frame::setPageAndTextZoomFactors):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83344 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e40c8bf
  26. 24 Mar, 2011 1 commit
    • commit-queue@webkit.org's avatar
      2011-03-23 Jia Pu <jpu@apple.com> · b5484ecd
      commit-queue@webkit.org authored
              Reviewed by Darin Adler.
      
              Hook up new AppKit autocorrection UI with WK2.
              https://bugs.webkit.org/show_bug.cgi?id=56055
              <rdar://problem/8947463>
      
              Please see WebCore/ChangeLog for detail.
      
              * platform/mac-wk2/Skipped: Enable autocorrection tests for WK2.
      2011-03-23  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Hook up new AppKit autocorrection UI with WK2.
              https://bugs.webkit.org/show_bug.cgi?id=56055
              <rdar://problem/8947463>
      
              This patch is to enable WK2 to utilize autocorrection UI on Mac OS X. It contains following
              major changes:
      
              1. All but one autocorrection related message is synchronous. Since dismissing autocorrection
              panel can potentially cause editing to occur, a synchronous dismissCorrectionPanelSoon() function
              is introduced to ensure all editing commands occur in correct order.
      
              2. Additional condition variable is needed to implement dismissCorrectionPanelSoon().
              To improve maintainability, CorrectionPanel class is introduced to manage the
              internal state related to correction panel. This change is applied to both WK1 and WK2.
      
              3. EditorClient::isShowingCorrectionPanel() has been removed. The original purpose is to allow
              editor to know when to handle ESC key event. Now this is handled internally in AppKit, so
              EditorClient::isShowingCorrectionPanel() isn't necessary anymore.
      
              4. The Editor* argument in EditorClient::showCorrectionPanel() has been removed, since we can
              access object via WebView or WKView.
      
              * editing/Editor.cpp:
              (WebCore::Editor::markMisspellingsAfterTypingToWord):
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
              (WebCore::Editor::correctionPanelTimerFired):
              (WebCore::Editor::dismissCorrectionPanel):
              (WebCore::Editor::dismissCorrectionPanelSoon):
              (WebCore::Editor::applyAutocorrectionBeforeTypingIfAppropriate):
              * editing/Editor.h:
              * editing/EditorCommand.cpp:
              (WebCore::createCommandMap):
              * loader/EmptyClients.h:
              (WebCore::EmptyEditorClient::showCorrectionPanel):
              (WebCore::EmptyEditorClient::dismissCorrectionPanelSoon):
              * manual-tests/autocorrection/close-window-when-correction-is-shown.html: Added.
              * page/EditorClient.h:
      2011-03-23  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Hook up new AppKit autocorrection UI with WK2.
              https://bugs.webkit.org/show_bug.cgi?id=56055
              <rdar://problem/8947463>
      
              Please see WebCore/ChangeLog for detail.
      
              * WebKit.xcodeproj/project.pbxproj:
      2011-03-23  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Hook up new AppKit autocorrection UI with WK2.
              https://bugs.webkit.org/show_bug.cgi?id=56055
              <rdar://problem/8947463>
      
              Please see WebCore/ChangeLog for detail.
      
              * WebCoreSupport/CorrectionPanel.h: Added.
              (CorrectionPanel::isShowing):
              * WebCoreSupport/CorrectionPanel.mm: Added.
              (correctionBubbleType):
              (CorrectionPanel::CorrectionPanel):
              (CorrectionPanel::~CorrectionPanel):
              (CorrectionPanel::show):
              (CorrectionPanel::dismiss):
              (CorrectionPanel::dismissSoon):
              (CorrectionPanel::dismissInternal):
              (CorrectionPanel::recordAutocorrectionResponse):
              * WebCoreSupport/WebEditorClient.h:
              * WebCoreSupport/WebEditorClient.mm:
              (WebEditorClient::WebEditorClient):
              (WebEditorClient::showCorrectionPanel):
              (WebEditorClient::dismissCorrectionPanel):
              (WebEditorClient::dismissCorrectionPanelSoon):
              (WebEditorClient::recordAutocorrectionResponse):
              * WebView/WebView.mm:
              (-[WebView handleCorrectionPanelResult:]):
              * WebView/WebViewPrivate.h:
      2011-03-23  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Hook up new AppKit autocorrection UI with WK2.
              https://bugs.webkit.org/show_bug.cgi?id=56055
              <rdar://problem/8947463>
      
              Please see WebCore/ChangeLog for detail.
      
              The calls to AppKit are implemented in PageClientImpl. Other changes are necessary for the
              plumbing work.
      
              * UIProcess/API/mac/PageClientImpl.h:
              * UIProcess/API/mac/PageClientImpl.mm:
              (WebKit::PageClientImpl::showCorrectionPanel):
              (WebKit::PageClientImpl::dismissCorrectionPanel):
              (WebKit::PageClientImpl::dismissCorrectionPanelSoon):
              (WebKit::PageClientImpl::recordAutocorrectionResponse):
              * UIProcess/API/mac/WKView.mm:
              (-[WKView spellCheckerDocumentTag]):
              (-[WKView handleCorrectionPanelResult:]):
              * UIProcess/API/mac/WKViewPrivate.h:
              * UIProcess/PageClient.h:
              * UIProcess/WebPageProxy.cpp:
              (WebKit::WebPageProxy::didCommitLoadForFrame):
              (WebKit::WebPageProxy::showCorrectionPanel):
              (WebKit::WebPageProxy::dismissCorrectionPanel):
              (WebKit::WebPageProxy::dismissCorrectionPanelSoon):
              (WebKit::WebPageProxy::recordAutocorrectionResponse):
              (WebKit::WebPageProxy::handleCorrectionPanelResult):
              * UIProcess/WebPageProxy.h:
              * UIProcess/WebPageProxy.messages.in:
              * UIProcess/mac/CorrectionPanel.h: Added.
              (WebKit::CorrectionPanel::isShowing):
              * UIProcess/mac/CorrectionPanel.mm: Added.
              (correctionBubbleType):
              (WebKit::CorrectionPanel::CorrectionPanel):
              (WebKit::CorrectionPanel::~CorrectionPanel):
              (WebKit::CorrectionPanel::show):
              (WebKit::CorrectionPanel::dismiss):
              (WebKit::CorrectionPanel::dismissSoon):
              (WebKit::CorrectionPanel::dismissInternal):
              (WebKit::CorrectionPanel::recordAutocorrectionResponse):
              * WebKit2.xcodeproj/project.pbxproj:
              * WebProcess/WebCoreSupport/WebEditorClient.h:
              * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
              (WebKit::WebEditorClient::showCorrectionPanel):
              (WebKit::WebEditorClient::dismissCorrectionPanel):
              (WebKit::WebEditorClient::dismissCorrectionPanelSoon):
              (WebKit::WebEditorClient::recordAutocorrectionResponse):
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::handleCorrectionPanelResult):
              * WebProcess/WebPage/WebPage.h:
              * WebProcess/WebPage/WebPage.messages.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81847 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5484ecd
  27. 01 Mar, 2011 1 commit
    • commit-queue@webkit.org's avatar
      2011-02-28 Chang Shu <cshu@webkit.org> · 83c267fc
      commit-queue@webkit.org authored
              Reviewed by Ryosuke Niwa.
      
              Remove the support of Frame::isContentEditable and its dependencies.
              https://bugs.webkit.org/show_bug.cgi?id=54292
      
              Updated expected results after the change that syncs the WebKit isEditable
              and WebCore isContentEditable.
      
              * platform/mac/editing/selection/designmode-no-caret-expected.txt:
      2011-02-28  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Ryosuke Niwa.
      
              Remove the support of Frame::isContentEditable and its dependencies.
              https://bugs.webkit.org/show_bug.cgi?id=54292
      
              Frame::isContentEditable is currently based on two things: Editor::clientIsEditable and
              Document::inDesignMode. In fact, it should only rely on Document::inDesignMode. As a result,
              Editor::clientIsEditable and its client-side implementation can be removed.
      
              * WebCore.exp.in:
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::isReadOnly):
              * editing/Editor.cpp:
              * editing/Editor.h:
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::setSelectionFromNone):
              * html/HTMLElement.cpp:
              (WebCore::HTMLElement::isContentEditable):
              (WebCore::HTMLElement::isContentRichlyEditable):
              * page/DragController.cpp:
              (WebCore::DragController::operationForLoad):
              * page/EditorClient.h:
              * page/Frame.cpp:
              * page/Frame.h:
      2011-02-28  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Ryosuke Niwa.
      
              Remove the support of Frame::isContentEditable and its dependencies.
              https://bugs.webkit.org/show_bug.cgi?id=54292
      
              Remove the WebKit side implementation.
      
              * src/EditorClientImpl.cpp:
              * src/EditorClientImpl.h:
      2011-02-28  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Ryosuke Niwa.
      
              Remove the support of Frame::isContentEditable and its dependencies.
              https://bugs.webkit.org/show_bug.cgi?id=54292
      
              Remove the WebKit side implementation.
      
              * WebCoreSupport/EditorClientEfl.cpp:
              * WebCoreSupport/EditorClientEfl.h:
      2011-02-28  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Ryosuke Niwa.
      
              Remove the support of Frame::isContentEditable and its dependencies.
              https://bugs.webkit.org/show_bug.cgi?id=54292
      
              Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
      
              * WebCoreSupport/EditorClientGtk.cpp:
              * WebCoreSupport/EditorClientGtk.h:
              * webkit/webkitwebview.cpp:
              (webkit_web_view_init):
              (webkit_web_view_get_editable):
              (webkit_web_view_set_editable):
              * webkit/webkitwebviewprivate.h:
      2011-02-28  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Ryosuke Niwa.
      
              Remove the support of Frame::isContentEditable and its dependencies.
              https://bugs.webkit.org/show_bug.cgi?id=54292
      
              Remove the WebKit side implementation.
      
              * WebCoreSupport/EditorClientHaiku.cpp:
              * WebCoreSupport/EditorClientHaiku.h:
      2011-02-28  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Ryosuke Niwa.
      
              Remove the support of Frame::isContentEditable and its dependencies.
              https://bugs.webkit.org/show_bug.cgi?id=54292
      
              Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
      
              * WebCoreSupport/WebEditorClient.h:
              * WebCoreSupport/WebEditorClient.mm:
              * WebView/WebView.mm:
              (-[WebView setEditable:]):
              (-[WebView isEditable]):
              * WebView/WebViewData.h:
      2011-02-28  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Ryosuke Niwa.
      
              Remove the support of Frame::isContentEditable and its dependencies.
              https://bugs.webkit.org/show_bug.cgi?id=54292
      
              Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
      
              * Api/qwebpage.cpp:
              (QWebPagePrivate::QWebPagePrivate):
              (QWebPage::setContentEditable):
              (QWebPage::isContentEditable):
              * Api/qwebpage_p.h:
              * WebCoreSupport/EditorClientQt.cpp:
              * WebCoreSupport/EditorClientQt.h:
      2011-02-28  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Ryosuke Niwa.
      
              Remove the support of Frame::isContentEditable and its dependencies.
              https://bugs.webkit.org/show_bug.cgi?id=54292
      
              Remove the WebKit side implementation.
      
              * WebCoreSupport/WebEditorClient.cpp:
              * WebCoreSupport/WebEditorClient.h:
      2011-02-28  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Ryosuke Niwa.
      
              Remove the support of Frame::isContentEditable and its dependencies.
              https://bugs.webkit.org/show_bug.cgi?id=54292
      
              Remove the WebKit side implementation.
      
              * WebCoreSupport/EditorClientWinCE.cpp:
              * WebCoreSupport/EditorClientWinCE.h:
      2011-02-28  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Ryosuke Niwa.
      
              Remove the support of Frame::isContentEditable and its dependencies.
              https://bugs.webkit.org/show_bug.cgi?id=54292
      
              Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
      
              * WebFrame.cpp:
              (wxWebFrame::wxWebFrame):
              (wxWebFrame::MakeEditable):
              (wxWebFrame::IsEditable):
              * WebFrame.h:
              * WebKitSupport/EditorClientWx.cpp:
              * WebKitSupport/EditorClientWx.h:
              * WebView.cpp:
              (wxWebView::wxWebView):
              * WebView.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79953 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83c267fc
  28. 15 Feb, 2011 4 commits
    • darin@apple.com's avatar
      2011-02-15 Jia Pu <jpu@apple.com> · 060d7a1a
      darin@apple.com authored
              Reviewed by Darin Adler.
      
              Autocorrection should respect undo.
              https://bugs.webkit.org/show_bug.cgi?id=52221
              <rdar://problem/8663399>
      
              Please see WebCore/ChangeLog for detailed description.
      
              * WebCoreSupport/WebEditorClient.cpp:
              (WebFrameImpl::replaceSelection): Adopted new signature of ReplaceSelectionCommand::create().
      2011-02-15  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Autocorrection should respect undo.
              https://bugs.webkit.org/show_bug.cgi?id=52221
              <rdar://problem/8663399>
      
              Please see WebCore/ChangeLog for detailed description.
      
              * WebCoreSupport/WebEditorClient.h: Updated for the new function declared in EditorClient.
      
              * WebCoreSupport/WebEditorClient.mm:
              (WebEditorClient::recordAutocorrectionResponse): Ditto.
      
              * WebView/WebFrame.mm:
              (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
                   Adopted new signature of ReplaceSelectionCommand::create().
      2011-02-15  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Autocorrection should respect undo.
              https://bugs.webkit.org/show_bug.cgi?id=52221
              <rdar://problem/8663399>
      
              Manual test: manual-tests/autocorrection/undo-autocorrection.html
      
              When user undoes an autocorrection, we need to do four things:
              1. Revert the change in text that has been made by correction.
              2. Revert the selection to pre-correction state so that user can immediately continue typing.
              3. Add appropriate markers to reverted text so that it won't be corrected again and/or shown
                 as misspelled.
              4. If applicable, notify spell checking service to record this reversion.
      
              To achieve these, this patch introduces following changes:
              1. Created SpellingCorrectionCommand so that correction can be undone in similar way as any
                 other editing command. SpellingCorrectionCommand is a composition of SetSelectionCommand,
                 SpellingCorrectionRecordUndoCommand and ReplaceSelectionCommand.
              2. Created SetSelectionCommand so that undo command can restore selection state.
              3. Added member function recordAutocorrectionResponse() to editor client.
      
              To improve readability, this patch also consolidates various boolean arguments in SelectionController::setSelection()
              and ReplaceSelectionCommand::ReplaceSelectionCommand(). These boolean arguments have been
              replaced by enum variable.
      
              * WebCore.exp.in: Updated for changes in Editor and ReplaceSelectionCommand.
      
              * WebCore.xcodeproj/project.pbxproj: Updated for new source files.
      
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::moveParagraphs): Adopted new signature of ReplaceSelectionCommand::create().
      
              * editing/Editor.cpp:
              (WebCore::Editor::replaceSelectionWithFragment): Ditto.
              (WebCore::Editor::unappliedEditing): Cleaned up trailing whitespace.
              (WebCore::Editor::reappliedEditing): Ditto.
              (WebCore::Editor::selectComposition): Adopted new signature of SelectionController::setSelection().
              (WebCore::Editor::confirmComposition): Ditto.
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Rearranged code to reduce the
                  level of deeply nested if statement. Adopted SpellingCorrectionCommand.
              (WebCore::Editor::applyCorrectionPanelInfo): Adopted SpellingCorrectionCommand.
              (WebCore::Editor::unappliedSpellCorrection): Function for adding markers to reverted text and
                  for notifiying editor client about undone correction.
              (WebCore::Editor::changeSelectionAfterCommand): Adopted new signature of SelectionController::setSelection().
              (WebCore::Editor::respondToChangedSelection): Use SelectionController::SetSelectionOptions
                  instead of boolean variables.
      
              * editing/Editor.h: Added Editor::unappliedSpellCorrection().
      
              * editing/EditorCommand.cpp:
              (WebCore::executeInsertFragment): Adopted new signature of ReplaceSelectionCommand::create().
      
              * editing/MoveSelectionCommand.cpp:
              (WebCore::MoveSelectionCommand::doApply): Ditto.
      
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): Replaced all boolean arguments
                  with an enum value.
      
              * editing/ReplaceSelectionCommand.h:
              (WebCore::ReplaceSelectionCommand::create): Ditto.
      
              * editing/SelectionController.cpp: Adopted new signature of SelectionController::setSelection().
              (WebCore::SelectionController::moveTo):
              (WebCore::SelectionController::setSelection):
              (WebCore::SelectionController::respondToNodeModification):
              (WebCore::SelectionController::setBase):
              (WebCore::SelectionController::setExtent):
              (WebCore::SelectionController::setSelectedRange):
      
              * editing/SelectionController.h:
              (WebCore::SelectionController::setSelection): Replaced all boolean arguments with an enum value.
      
              * editing/SetSelectionCommand.cpp: Added.
              (WebCore::SetSelectionCommand::SetSelectionCommand):
              (WebCore::SetSelectionCommand::doApply):
              (WebCore::SetSelectionCommand::doUnapply):
      
              * editing/SetSelectionCommand.h: Added.
              (WebCore::SetSelectionCommand::create):
      
              * editing/mac/SpellingCorrectionCommand.cpp: Added.
              (WebCore::SpellingCorrectionRecordUndoCommand::create):
              (WebCore::SpellingCorrectionRecordUndoCommand::SpellingCorrectionRecordUndoCommand):
              (WebCore::SpellingCorrectionRecordUndoCommand::doApply):
              (WebCore::SpellingCorrectionRecordUndoCommand::doUnapply):
              (WebCore::SpellingCorrectionCommand::SpellingCorrectionCommand):
              (WebCore::SpellingCorrectionCommand::doApply):
      
              * editing/mac/SpellingCorrectionCommand.h: Added.
              (WebCore::SpellingCorrectionCommand::create):
      
              * loader/EmptyClients.h: Updated for the new function declared in EditorClient.
              (WebCore::EmptyEditorClient::recordAutocorrectionResponse):
      
              * manual-tests/autocorrection/undo-autocorrection.html: Added.
      
              * page/ContextMenuController.cpp:
              (WebCore::ContextMenuController::contextMenuItemSelected): Adopted new signature of ReplaceSelectionCommand::create().
      
              * page/DragController.cpp:
              (WebCore::DragController::concludeEditDrag): Ditto.
      
              * page/EditorClient.h: Added EditorClient::recordAutocorrectionResponse().
      2011-02-15  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Autocorrection should respect undo.
              https://bugs.webkit.org/show_bug.cgi?id=52221
              <rdar://problem/8663399>
      
              Please see WebCore/ChangeLog for detailed description.
      
              * WebProcess/WebCoreSupport/WebEditorClient.h: Updated for the new function declared in EditorClient.
      
              * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
              (WebKit::WebEditorClient::recordAutocorrectionResponse): Ditto.
      
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::replaceSelectionWithText): Adopted new signature of ReplaceSelectionCommand::create().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      060d7a1a
    • morrita@google.com's avatar
      2011-02-15 MORITA Hajime <morrita@google.com> · 9b3829f1
      morrita@google.com authored
              Unreviewed build fix.
      
              * page/EditorClient.h: Changed GrammarDetail forward declaration from class to struct.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78534 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b3829f1
    • morrita@google.com's avatar
      2011-01-26 MORITA Hajime <morrita@google.com> · 7692b428
      morrita@google.com authored
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              Created new abstract class TextCheckerClient. The class has
              spellcheck related API which is split.
              This is the first step for sharing spell-checking codebase
              between ports. A standalone TextCheckerClient implementation
              should be done in future changes.
      
              No new tests. No behavioral change.
      
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * accessibility/mac/AccessibilityObjectWrapper.mm:
              (AXAttributeStringSetSpelling):
              * editing/Editor.cpp: Replacing some client() call with textChecker().
              (WebCore::Editor::textChecker): Added.
              (WebCore::Editor::ignoreSpelling):
              (WebCore::Editor::learnSpelling):
              (WebCore::Editor::isSelectionMisspelled):
              (WebCore::Editor::guessesForMisspelledSelection):
              (WebCore::Editor::markMisspellingsAfterTypingToWord):
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
              (WebCore::Editor::correctionPanelTimerFired):
              * editing/Editor.h:
              * editing/SpellChecker.cpp:
              (WebCore::SpellChecker::SpellChecker):
              * editing/TextCheckingHelper.cpp: Replacing some client() call with textChecker().
              (WebCore::TextCheckingHelper::findFirstMisspelling):
              (WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):
              (WebCore::TextCheckingHelper::findFirstBadGrammar):
              (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange):
              * loader/EmptyClients.h: Added EmptyTextCheckerClient.
              (WebCore::EmptyTextCheckerClient::ignoreWordInSpellDocument):
              (WebCore::EmptyTextCheckerClient::learnWord):
              (WebCore::EmptyTextCheckerClient::checkSpellingOfString):
              (WebCore::EmptyTextCheckerClient::getAutoCorrectSuggestionForMisspelledWord):
              (WebCore::EmptyTextCheckerClient::checkGrammarOfString):
              (WebCore::EmptyTextCheckerClient::checkTextOfParagraph):
              (WebCore::EmptyTextCheckerClient::getGuessesForWord):
              (WebCore::EmptyTextCheckerClient::requestCheckingOfString):
              (WebCore::EmptyEditorClient::textChecker):
              * page/EditorClient.h: Extracted TextCheckerClient.
              * page/Page.h:
              * platform/text/TextCheckerClient.h: Added.
              (WebCore::TextCheckerClient::~TextCheckerClient):
      2011-01-26  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              * src/EditorClientImpl.h:
              (WebKit::EditorClientImpl::textChecker):
      2011-01-26  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              * WebCoreSupport/EditorClientEfl.h:
              (WebCore::EditorClientEfl::textChecker):
      2011-01-26  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              * WebCoreSupport/EditorClientGtk.h:
              (WebKit::EditorClient::textChecker):
      2011-01-26  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              * WebCoreSupport/EditorClientHaiku.h:
              (WebCore::EditorClientHaiku::textChecker):
      2011-01-26  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              * WebCoreSupport/WebEditorClient.h:
              (WebEditorClient::textChecker):
      2011-01-26  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              * WebCoreSupport/EditorClientQt.h:
              (WebCore::EditorClientQt::textChecker):
      2011-01-26  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              * WebCoreSupport/WebEditorClient.h:
              (WebEditorClient::textChecker):
      2011-01-26  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              * WebCoreSupport/EditorClientWinCE.h:
              (WebKit::EditorClientWinCE::textChecker):
      2011-01-26  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              * WebKitSupport/EditorClientWx.h:
              (WebCore::EditorClientWx::textChecker):
      2011-01-26  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              Refactoring: Extract TextCheckerClient from EditorClient
              https://bugs.webkit.org/show_bug.cgi?id=53213
      
              * Shared/WebCoreArgumentCoders.h:
              * UIProcess/TextChecker.h:
              * WebProcess/WebCoreSupport/WebEditorClient.h:
              (WebKit::WebEditorClient::textChecker):
              * Scripts/webkit2/messages.py: Re-arranged the include file
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7692b428
    • rniwa@webkit.org's avatar
      2011-02-07 Ryosuke Niwa <rniwa@webkit.org> · 545c070f
      rniwa@webkit.org authored
              Reviewed by Adam Barth.
      
              Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
              https://bugs.webkit.org/show_bug.cgi?id=52417
      
              Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
              not implemented.
      
              * src/EditorClientImpl.cpp:
              (WebKit::EditorClientImpl::canCopyCut): Added.
              (WebKit::EditorClientImpl::canPaste): Added.
              * src/EditorClientImpl.h:
      2011-02-07  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Adam Barth.
      
              Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
              https://bugs.webkit.org/show_bug.cgi?id=52417
      
              Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
              not implemented.
      
              * WebCoreSupport/EditorClientQt.cpp:
              (WebCore::EditorClientQt::canCopyCut): Added.
              (WebCore::EditorClientQt::canPaste): Added.
              * WebCoreSupport/EditorClientQt.h:
      2011-02-07  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Adam Barth.
      
              Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
              https://bugs.webkit.org/show_bug.cgi?id=52417
      
              Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
              not implemented.
      
              * WebCoreSupport/EditorClientGtk.cpp:
              (WebKit::EditorClient::canCopyCut): Added.
              (WebKit::EditorClient::canPaste): Added.
              * WebCoreSupport/EditorClientGtk.h:
      2011-02-07  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Adam Barth.
      
              Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
              https://bugs.webkit.org/show_bug.cgi?id=52417
      
              Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
              not implemented.
      
              * WebCoreSupport/WebEditorClient.cpp:
              (WebEditorClient::canCopyCut): Added.
              (WebEditorClient::canPaste): Added.
              * WebCoreSupport/WebEditorClient.h:
      2011-02-07  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Adam Barth.
      
              Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
              https://bugs.webkit.org/show_bug.cgi?id=52417
      
              Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
              not implemented.
      
              * WebKitSupport/EditorClientWx.cpp:
              (WebCore::EditorClientWx::canCopyCut): Added.
              (WebCore::EditorClientWx::canPaste): Added.
              * WebKitSupport/EditorClientWx.h:
      2011-02-07  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Adam Barth.
      
              Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
              https://bugs.webkit.org/show_bug.cgi?id=52417
      
              Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
              not implemented.
      
              * WebCoreSupport/WebEditorClient.h:
              * WebCoreSupport/WebEditorClient.mm:
              (WebEditorClient::canCopyCut): Added.
              (WebEditorClient::canPaste): Added.
      2011-02-07  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Adam Barth.
      
              Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
              https://bugs.webkit.org/show_bug.cgi?id=52417
      
              Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
              not implemented.
      
              * WebCoreSupport/EditorClientHaiku.cpp:
              (WebCore::EditorClientHaiku::canCopyCut): Added.
              (WebCore::EditorClientHaiku::canPaste): Added.
              * WebCoreSupport/EditorClientHaiku.h:
      2011-02-07  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Adam Barth.
      
              Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
              https://bugs.webkit.org/show_bug.cgi?id=52417
      
              Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
              not implemented.
      
              * WebCoreSupport/EditorClientWinCE.cpp:
              (WebKit::EditorClientWinCE::canCopyCut): Added.
              (WebKit::EditorClientWinCE::canPaste): Added.
              * WebCoreSupport/EditorClientWinCE.h:
      2011-02-07  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Adam Barth.
      
              Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
              https://bugs.webkit.org/show_bug.cgi?id=52417
      
              Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
              not implemented.
      
              * WebCoreSupport/EditorClientEfl.cpp:
              (WebCore::EditorClientEfl::canCopyCut): Added.
              (WebCore::EditorClientEfl::canPaste): Added.
              * WebCoreSupport/EditorClientEfl.h:
      2011-02-07  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Adam Barth.
      
              Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
              https://bugs.webkit.org/show_bug.cgi?id=52417
      
              Added two callback functions, canCopyCut and canPaste to EditorClient. These functions
              returns true iff the current frame should be able to copy/cut and paste respectively.
              They take the default value determined by isDOMPasteAllowed and javaScriptCanAccessClipboard.
      
              These callbacks allows embedders to decide whether or not copy/cut/paste should be enabled
              per frame and thus per origin rather than per page.
      
              No new tests are added since this is a WebKit/WebCore interface change.
      
              * editing/EditorCommand.cpp:
              (WebCore::supportedCopyCut): Calls canCopyCut.
              (WebCore::supportedPaste): Calls canPaste.
              * loader/EmptyClients.h:
              (WebCore::EmptyEditorClient::canCopyCut): Added.
              (WebCore::EmptyEditorClient::canPaste): Added.
              * page/EditorClient.h:
      2011-02-07  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Adam Barth.
      
              Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
              https://bugs.webkit.org/show_bug.cgi?id=52417
      
              Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
              not implemented.
      
              * WebProcess/WebCoreSupport/WebEditorClient.cpp:
              (WebKit::WebEditorClient::canCopyCut): Added.
              (WebKit::WebEditorClient::canPaste): Added.
              * WebProcess/WebCoreSupport/WebEditorClient.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78532 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      545c070f
  29. 04 Feb, 2011 1 commit
  30. 11 Jan, 2011 1 commit
    • enrica@apple.com's avatar
      Source/WebCore: Paste and drag and drop use different code paths to interact with the pasteboard. · 964ea218
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=52093
      The change consists in a refactoring of the code to have only one class that
      deals with the pasteboard on Mac.
      
      Reviewed by Alexey Proskuryakov.
      
      No new tests. A test is already available for this
      (editing/pasteboard/drag-image-to-contenteditable-in-iframe.html) but had incorrect results.
      
      * WebCore.exp.in:
      * loader/EmptyClients.h: Added two Mac only methods to call into WebKit to use functionality
      that is in NSURLExtras.
      (WebCore::EmptyEditorClient::canonicalizeURL):
      (WebCore::EmptyEditorClient::canonicalizeURLString):
      * page/DragController.cpp:
      The following methods have been changed to pass a pointer to the Frame object
      to the DragData class.
      (WebCore::documentFragmentFromDragData):
      (WebCore::DragController::performDrag):
      (WebCore::DragController::dispatchTextInputEventFor):
      (WebCore::DragController::concludeEditDrag):
      * page/EditorClient.h: Added two Mac only methods to call into WebKit to use functionality
      that is in NSURLExtras.
      The following files have been modified to pass the Frame object to the DragData method calls.
      * page/chromium/DragControllerChromium.cpp:
      (WebCore::DragController::dragOperation):
      * page/gtk/DragControllerGtk.cpp:
      (WebCore::DragController::dragOperation):
      * page/mac/DragControllerMac.mm:
      (WebCore::DragController::dragOperation):
      * page/qt/DragControllerQt.cpp:
      (WebCore::DragController::dragOperation):
      * page/win/DragControllerWin.cpp:
      (WebCore::DragController::dragOperation):
      * platform/DragData.h: Removed Mac specific constructor and reference to PasteboardHelper class.
      * platform/Pasteboard.h: Added public constructor to create a Pasteboard object from an NSPasteboard.
      The following files were all modified to match the new parameters of the methods listed.
      * platform/android/DragDataAndroid.cpp:
      (WebCore::DragData::asPlainText):
      (WebCore::DragData::containsURL):
      (WebCore::DragData::asURL):
      (WebCore::DragData::asFragment):
      * platform/chromium/DragDataChromium.cpp:
      (WebCore::DragData::containsURL):
      (WebCore::DragData::asURL):
      (WebCore::DragData::asPlainText):
      (WebCore::DragData::containsCompatibleContent):
      (WebCore::DragData::asFragment):
      * platform/gtk/DragDataGtk.cpp:
      (WebCore::DragData::asPlainText):
      (WebCore::DragData::containsCompatibleContent):
      (WebCore::DragData::containsURL):
      (WebCore::DragData::asURL):
      (WebCore::DragData::asFragment):
      * platform/haiku/DragDataHaiku.cpp:
      (WebCore::DragData::asPlainText):
      (WebCore::DragData::containsURL):
      (WebCore::DragData::asURL):
      (WebCore::DragData::asFragment):
      * platform/mac/DragDataMac.mm:
      (WebCore::DragData::DragData):
      (WebCore::DragData::asPlainText):
      (WebCore::insertablePasteboardTypes):
      (WebCore::DragData::containsCompatibleContent):
      (WebCore::DragData::containsURL):
      (WebCore::DragData::asURL):
      (WebCore::DragData::asFragment):
      * platform/mac/PasteboardMac.mm:
      (WebCore::Pasteboard::getBestURL):
      (WebCore::Pasteboard::asURL):
      * platform/qt/DragDataQt.cpp:
      (WebCore::DragData::asPlainText):
      (WebCore::DragData::containsCompatibleContent):
      (WebCore::DragData::containsURL):
      (WebCore::DragData::asURL):
      (WebCore::DragData::asFragment):
      * platform/win/DragDataWin.cpp:
      (WebCore::DragData::containsURL):
      (WebCore::DragData::asURL):
      (WebCore::DragData::asPlainText):
      (WebCore::DragData::containsCompatibleContent):
      (WebCore::DragData::asFragment):
      * platform/wince/DragDataWinCE.cpp:
      (WebCore::DragData::containsURL):
      (WebCore::DragData::asURL):
      (WebCore::DragData::asPlainText):
      (WebCore::DragData::asFragment):
      * platform/wx/DragDataWx.cpp:
      (WebCore::DragData::asPlainText):
      (WebCore::DragData::containsURL):
      (WebCore::DragData::asURL):
      (WebCore::DragData::asFragment):
      
      WebKit: Paste and drag and drop use different code paths to interact with the pasteboard.
      https://bugs.webkit.org/show_bug.cgi?id=52093
      The change consists in a refactoring of the code to have only one class that
      deals with the pasteboard on Mac.
      
      Reviewed by Alexey Proskuryakov.
      
      * WebKit.xcodeproj/project.pbxproj: Removed WebPasteboardHelper.mm and WebPasteboardHelper.h.
      
      WebKit/mac: Paste and drag and drop use different code paths to interact with the pasteboard.
      https://bugs.webkit.org/show_bug.cgi?id=52093
      The change consists in a refactoring of the code to have only one class that
      deals with the pasteboard on Mac.
      
      Reviewed by Alexey Proskuryakov.
      
      * WebCoreSupport/WebEditorClient.h:
      * WebCoreSupport/WebEditorClient.mm: Added two methods to provide to WebCore functionality
      exposed by NSURLExtras.
      (WebEditorClient::canonicalizeURL):
      (WebEditorClient::canonicalizeURLString):
      * WebCoreSupport/WebPasteboardHelper.h: Removed.
      * WebCoreSupport/WebPasteboardHelper.mm: Removed.
      * WebView/WebHTMLView.mm: Removed comment.
      * WebView/WebView.mm: The following methods have been changed to use the new DragData
      constructor that doesn't use the WebPasteboardHelper reference.
      (-[WebView draggingEntered:]):
      (-[WebView draggingUpdated:]):
      (-[WebView draggingExited:]):
      (-[WebView performDragOperation:]):
      
      WebKit2: Paste and drag and drop use different code paths to interact with the pasteboard.
      https://bugs.webkit.org/show_bug.cgi?id=52093
      The change consists in a refactoring of the code to have only one class that
      deals with the pasteboard on Mac.
      
      Reviewed by Alexey Proskuryakov.
      
      * WebProcess/WebCoreSupport/WebEditorClient.h:
      * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: Added two methods to provide to WebCore functionality
      exposed by NSURLExtras.
      (WebKit::WebEditorClient::canonicalizeURL):
      (WebKit::WebEditorClient::canonicalizeURLString):
      
      LayoutTests: Paste and drag and drop use different code paths to interact with the pasteboard.
      https://bugs.webkit.org/show_bug.cgi?id=52093
      
      Reviewed by Alexey Proskuryakov.
      
      New test results added to match the correct behavior.
              
      * platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum:
      * platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png:
      * platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75523 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      964ea218
  31. 08 Jan, 2011 1 commit
  32. 13 Dec, 2010 1 commit
    • morrita@google.com's avatar
      2010-10-28 MORITA Hajime <morrita@google.com> · 7a18feed
      morrita@google.com authored
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              * editing/spelling/script-tests/spellcheck-paste.js: Added.
              * editing/spelling/spellcheck-paste.html: Added.
              * editing/spelling/spellcheck-paste-expected.txt: Added.
              * platform/chromium/test_expectations.txt:
              * platform/gtk/Skipped:
              * platform/mac-leopard/Skipped:
              * platform/mac-tiger/Skipped:
              * platform/mac-wk2/Skipped:
              * platform/qt/Skipped:
              * platform/win/Skipped:
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              - Introduced SpellChecker class to encapsulate asynchronous spell
                checker state: sequence id, requesting text and target node.
                This is also the first step to decompose spell-check related
                code to a separate class.
              - Added EditorClient::isAsynchronousSpellCheckingEnabled()
                to use async spellcheck API on the platform.
                These APIs are touched by SpellChecker.
              - Used SpellChecker to check a pasted test. Text to check is
                collected from the subtree under the editingRoot.
              - Added Setting::m_asynchronousSpellCheckingEnabled to control
                async spell checking.
      
              Test: editing/spelling/spellcheck-paste.html
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.exp.in:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * dom/DocumentMarkerController.cpp:
              (WebCore::DocumentMarkerController::showMarkers):
              (showDocumentMarkers):
              * dom/DocumentMarkerController.h:
              * dom/PositionIterator.cpp:
              (WebCore::PositionIterator::setOffsetInLeafNode):
              * dom/PositionIterator.h:
              * editing/Editor.cpp:
              (WebCore::Editor::replaceSelectionWithFragment):
              (WebCore::Editor::Editor):
              (WebCore::findFirstMarkable):
              (WebCore::Editor::selectionStartHasSpellingMarkerFor):
              * editing/Editor.h:
              (WebCore::Editor::spellChecker):
              * editing/SpellChecker.cpp: Added.
              (WebCore::SpellChecker::SpellChecker):
              (WebCore::SpellChecker::~SpellChecker):
              (WebCore::SpellChecker::initRequest):
              (WebCore::SpellChecker::clearRequest):
              (WebCore::SpellChecker::isAsynchronousEnabled):
              (WebCore::SpellChecker::canCheckAsynchronously):
              (WebCore::SpellChecker::isBusy):
              (WebCore::SpellChecker::isValid):
              (WebCore::SpellChecker::isCheckable):
              (WebCore::SpellChecker::requestCheckingFor):
              (WebCore::forwardIterator):
              (WebCore::SpellChecker::didCheck):
              * editing/SpellChecker.h: Added.
              (WebCore::SpellCheckingResult::SpellCheckingResult):
              (WebCore::SpellCheckingResult::type):
              (WebCore::SpellCheckingResult::location):
              (WebCore::SpellCheckingResult::length):
              * loader/EmptyClients.h:
              (WebCore::EmptyEditorClient::requestCheckingOfString):
              * page/EditorClient.h:
              * page/Settings.cpp:
              (WebCore::Settings::Settings):
              * page/Settings.h:
              (WebCore::Settings::setAsynchronousSpellCheckingEnabled):
              (WebCore::Settings::asynchronousSpellCheckingEnabled):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * src/EditorClientImpl.h:
              (WebKit::EditorClientImpl::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebCoreSupport/EditorClientEfl.h:
              (WebCore::EditorClientEfl::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebCoreSupport/EditorClientGtk.h:
              (WebKit::EditorClient::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebCoreSupport/EditorClientHaiku.h:
              (WebCore::EditorClientHaiku::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added asynchronous spell checking API to WebEditorClient using
              -[NSSpellChecker requestCheckingOfString].
              Note that WebEditorSpellCheckResponder is a small class to receive
              requested spell-checking result. Note that this feature is
              disabled at default.
      
              Also added [WebPreferences setAsynchronousSpellCheckingEnabled:] to
              enable the feature from LayoutTestController.
      
              * WebCoreSupport/WebEditorClient.h:
              * WebCoreSupport/WebEditorClient.mm:
              (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]):
              (-[WebEditorSpellCheckResponder perform]):
              (toCoreSpellingResult):
              (-[WebEditorSpellCheckResponder WTF::WebCore::]):
              (WebEditorClient::requestCheckingOfString):
              * WebView/WebPreferenceKeysPrivate.h:
              * WebView/WebPreferences.mm:
              (+[WebPreferences initialize]):
              (-[WebPreferences setAsynchronousSpellCheckingEnabled:]):
              (-[WebPreferences asynchronousSpellCheckingEnabled]):
              * WebView/WebPreferencesPrivate.h:
              * WebView/WebView.mm:
              (-[WebView _preferencesChangedNotification:]):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebCoreSupport/EditorClientQt.h:
              (WebCore::EditorClientQt::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebCoreSupport/WebEditorClient.h:
              (WebEditorClient::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebCoreSupport/EditorClientWinCE.h:
              (WebKit::EditorClient::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebKitSupport/EditorClientWx.h:
              (WebCore::EditorClientWx::requestCheckingOfString):
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added a stub implememntation.
      
              * WebProcess/WebCoreSupport/WebEditorClient.cpp:
              (WebKit::WebEditorClient::requestCheckingOfString):
              * WebProcess/WebCoreSupport/WebEditorClient.h:
      2010-10-28  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ojan Vafai.
      
              spellcheck does not check pasted text
              https://bugs.webkit.org/show_bug.cgi?id=40092
      
              Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
              to control the setting.
      
              * DumpRenderTree/LayoutTestController.cpp:
              (setAsynchronousSpellCheckingEnabledCallback):
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/chromium/LayoutTestController.h:
              * DumpRenderTree/chromium/LayoutTestController.cpp:
              (LayoutTestController::LayoutTestController):
              (LayoutTestController::setAsynchronousSpellCheckingEnabled):
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::setAsynchronousSpellCheckingEnabled):
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (resetDefaultsToConsistentValues):
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              (LayoutTestController::setAsynchronousSpellCheckingEnabled):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::setAsynchronousSpellCheckingEnabled):
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              (LayoutTestController::setAsynchronousSpellCheckingEnabled):
              * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
              (LayoutTestController::setAsynchronousSpellCheckingEnabled):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a18feed
  33. 03 Dec, 2010 1 commit
    • commit-queue@webkit.org's avatar
      2010-12-03 Jia Pu <jpu@apple.com> · 7ae7c0a1
      commit-queue@webkit.org authored
              Reviewed by Darin Adler.
      
              Need to move all code that applies correction into correction panel callback.
              https://bugs.webkit.org/show_bug.cgi?id=50426
              <rdar://problem/8720832>
      
              Added expected png file.
      
              * platform/mac/editing/spelling/delete-autocorrected-word-1-expected.checksum: Added.
              * platform/mac/editing/spelling/delete-autocorrected-word-1-expected.png: Added.
      2010-12-03  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Need to move all code that applies correction into correction panel callback.
              https://bugs.webkit.org/show_bug.cgi?id=50426
              <rdar://problem/8720832>
      
              No new test, since there's no behavioral change.
      
              This patch is to prepare WebKit to work with upcoming AppKit changes. The main changes are:
              1. Moved all calls to applyCorrectionPanelInfo() into handleCorrectionPanelResult().
              2. Added more user dictionary learning code.
              3. Removed m_ prefix in all member variables of CorrectionPanelInfo.
      
              * editing/CorrectionPanelInfo.h: Remove m_ prefix on member variables. Added ReasonForDismissingCorrectionPanel enum type.
      
              * editing/Editor.cpp: Moved all calls to applyCorrectionPanelInfo() into handleCorrectionPanelResult().
                Adopted new member variable naming in class CorrectionPanelInfo.
              (WebCore::Editor::respondToChangedSelection):
              (WebCore::Editor::~Editor):
              (WebCore::Editor::markMisspellingsAfterTypingToWord):
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
              (WebCore::Editor::correctionPanelTimerFired):
              (WebCore::Editor::handleCorrectionPanelResult):
              (WebCore::Editor::startCorrectionPanelTimer):
              (WebCore::Editor::stopCorrectionPanelTimer):
              (WebCore::Editor::handleCancelOperation):
              (WebCore::Editor::dismissCorrectionPanel):
              (WebCore::Editor::applyCorrectionPanelInfo):
      
              * editing/Editor.h: Changed signature of dismissCorrectionPanel to use ReasonForDismissingCorrectionPanel.
      
              * loader/EmptyClients.h: Ditto.
              (WebCore::EmptyEditorClient::dismissCorrectionPanel):
      
              * page/EditorClient.h: Ditto.
      2010-12-03  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Need to move all code that applies correction into correction panel callback.
              https://bugs.webkit.org/show_bug.cgi?id=50426
              <rdar://problem/8720832>
      
              * WebCoreSupport/WebEditorClient.h: Adopted new signature of dismissCorrectionPanel.
      
              * WebCoreSupport/WebEditorClient.mm:
              (WebEditorClient::~WebEditorClient): Adopted new signature of dismissCorrectionPanel.
              (WebEditorClient::showCorrectionPanel): Added more user dictionary learning code.
              (WebEditorClient::dismissCorrectionPanel): Adopted new signature of dismissCorrectionPanel.
      2010-12-03  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Need to move all code that applies correction into correction panel callback.
              https://bugs.webkit.org/show_bug.cgi?id=50426
              <rdar://problem/8720832>
      
              Adopted new signature of dismissCorrectionPanel.
      
              * WebProcess/WebCoreSupport/WebEditorClient.h:
              * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
              (WebKit::WebEditorClient::dismissCorrectionPanel):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73287 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ae7c0a1
  34. 02 Dec, 2010 1 commit
    • darin@apple.com's avatar
      2010-12-01 Jia Pu <jpu@apple.com> · a5f05c0a
      darin@apple.com authored
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * src/EditorClientImpl.cpp:
              (WebKit::EditorClientImpl::getGuessesForWord):
              * src/EditorClientImpl.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebCoreSupport/EditorClientQt.cpp:
              (WebCore::EditorClientQt::getGuessesForWord):
              * WebCoreSupport/EditorClientQt.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebCoreSupport/EditorClientGtk.cpp:
              (WebKit::EditorClient::getGuessesForWord):
              * WebCoreSupport/EditorClientGtk.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebCoreSupport/WebEditorClient.cpp:
              (WebEditorClient::getGuessesForWord):
              * WebCoreSupport/WebEditorClient.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebKitSupport/EditorClientWx.cpp:
              (WebCore::EditorClientWx::getGuessesForWord):
              * WebKitSupport/EditorClientWx.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              This patch is for supporting multiple correction suggestion panel on Mac OS X.
              The behavior and implementation is similar to that of reversion candiate panel.
      
              * WebCoreSupport/WebEditorClient.h: Adopted new signatures defined in base class.
      
              * WebCoreSupport/WebEditorClient.mm:  Adopted new signatures defined in base class.
                Added code to handle new multiple suggestion canidate panel type.
              (WebEditorClient::showCorrectionPanel):
              (WebEditorClient::getGuessesForWord):
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebCoreSupport/EditorClientHaiku.cpp:
              (WebCore::EditorClientHaiku::getGuessesForWord):
              * WebCoreSupport/EditorClientHaiku.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebCoreSupport/EditorClientWinCE.cpp:
              (WebKit::EditorClientWinCE::getGuessesForWord):
              * WebCoreSupport/EditorClientWinCE.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebCoreSupport/EditorClientEfl.cpp:
              (WebCore::EditorClientEfl::getGuessesForWord):
              * WebCoreSupport/EditorClientEfl.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Test: platform/mac/editing/spelling/delete-autocorrected-word-1.html
              Manual test: WebCore/manual-tests/autocorrection/dismiss-multiple-guesses.html
                           WebCore/manual-tests/autocorrection/select-from-multiple-guesses.html
      
              This patch is for supporting multiple correction suggestion panel on Mac OS X.
              The behavior and implementation is similar to that of reversion candiate panel.
      
              * WebCore.exp.in: Added and removed symbols.
      
              * editing/CorrectionPanelInfo.h: Added new correction panel type, PanelTypeSpellingSuggestions.
      
              * editing/Editor.cpp:
              (WebCore::markerTypesForAutocorrection): Convenient function for getting marker types to
                be added to autocorrected word.
              (WebCore::boundingBoxForRange): Convenient function for calculating the bounding box of a range.
              (WebCore::markerTypesForReplacement): Convenient function for getting marker types to
                be added to word that has been replaced by various correction panel.
              (WebCore::Editor::respondToChangedSelection): Added code to trigger timer for multiple
                suggestion panel.
              (WebCore::Editor::guessesForMisspelledSelection): Adopted new signature of EditorClient::getGuessesForWord().
              (WebCore::Editor::markMisspellingsAfterTypingToWord): Adopted new signature of applyCorrectionPanelInfo().
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Ditto.
              (WebCore::Editor::correctionPanelTimerFired): Added code to handle new multiple suggestion panel.
              (WebCore::Editor::handleCorrectionPanelResult): Replaced handleRejectedCorrection(), since
                with new AppKit correction panel API, not only rejection, but also confirmation can be
                handled in callback.
              (WebCore::Editor::stopCorrectionPanelTimer): Moved the code that clears correction panel info
                from dismissCorrectionPanel() to this function to fix a bug that would occur when deleting
                autocorrected word.
              (WebCore::Editor::dismissCorrectionPanel): Ditto.
              (WebCore::Editor::applyCorrectionPanelInfo): Added code to handle new multiple suggestion panel.
      
              * editing/Editor.h: Replaced handleRejectedCorrection() with handleCorrectionPanelResult().
                Changed the signature of applyCorrectionPanelInfo() to hanlde new correction panel type.
      
              * editing/TextCheckingHelper.cpp:
              (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): Adopted new EditorClient::getGuessesForWord().
      
              * editing/TextCheckingHelper.h: Made paragraphRange() public.
      
              * loader/EmptyClients.h:
              (WebCore::EmptyEditorClient::showCorrectionPanel): Adopted new signature defined in base class.
              (WebCore::EmptyEditorClient::getGuessesForWord): Ditto.
      
              * manual-tests/autocorrection/dismiss-multiple-guesses.html: Added.
      
              * manual-tests/autocorrection/select-from-multiple-guesses.html: Added.
      
              * page/EditorClient.h:  Changed showCorrectionPanel() to allow passing multiple correction
                candidates. Changed getGuessesForWord() to allow passing in contextual text for better
                correction suggestions (for those spellcheckers that utilizes such contextual information).
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              * platform/mac-leopard/Skipped:
              * platform/mac-snowleopard/Skipped:
              * platform/mac-tiger/Skipped:
              * platform/mac-wk2/Skipped:
              * platform/mac/editing/spelling/delete-autocorrected-word-1-expected.txt: Added.
              * platform/mac/editing/spelling/delete-autocorrected-word-1.html: Added.
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signatures defined in base class.
      
              * WebProcess/WebCoreSupport/WebEditorClient.cpp:
              (WebKit::WebEditorClient::getGuessesForWord):
              * WebProcess/WebCoreSupport/WebEditorClient.h:
              * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
              (WebKit::WebEditorClient::showCorrectionPanel):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73088 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5f05c0a
  35. 05 Nov, 2010 1 commit
    • mitz@apple.com's avatar
      reversion bubble in WebViews · f82f4ad6
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=47630
      <rdar://problem/8530960>
      
      Patch by Jia Pu <jpu@apple.com> on 2010-11-04
      Reviewed by Dan Bernstein.
      
      WebCore: 
      
      Added manual test:
      manual-tests/autocorrection/continue-typing-to-dismiss-reversion.html
      manual-tests/autocorrection/delete-to-dismiss-reversion.html
      manual-tests/autocorrection/delete-to-end-of-word-to-show-reversion.html
      manual-tests/autocorrection/move-to-end-of-word-to-show-reversion.html
      manual-tests/autocorrection/type-whitespace-to-dismiss-reversion.html
      
      We can only manully test this feature for two reasons:
      1. On Mac OS X, the result of spell checking is partly determined by past user usage. We can't
         realiably generating test cases until we can disable user custom data during spell checking.
      2. To exerciese this feature, we need a minimum of 0.3 second delay using WebCore timer.
      
      This patch is to add reversion to correction panel. It consists of following major code changes:
      1. Collected all autocorrection related member variables in Editor into a CorrectionPanelInfo
         class to improve readability.
      2. Changed signature of Editor::startCorrectionPanelTimer() to allow caller to specify the
         type of correction panel--regular correction or reversion.
      3. Made necessary changes to adopt reversion API in AppKit.
      4. Use SUPPORT_CORRECTION_PANEL macro to improve readability.
      
      * GNUmakefile.am: Added CorrectionPanelInfo.h.
      * WebCore.gypi: Ditto.
      * WebCore.pro: Ditto.
      * WebCore.vcproj/WebCore.vcproj: Ditto.
      * WebCore.xcodeproj/project.pbxproj:
      * editing/CorrectionPanelInfo.h: Added.
      * editing/Editor.cpp:
      (WebCore::Editor::respondToChangedSelection): Start correction panel timer for reversion when
        the new selection is a caret selection at end of a previously corrected word.
      (WebCore::Editor::appliedEditing): Stop timer at the beginning of the method instead of at the end.
      (WebCore::Editor::~Editor): Adopted new method dismissCorrectionPanel().
      (WebCore::Editor::markMisspellingsAfterTypingToPosition): Adopted new method applyCorrectionPanelInfo().
      (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Code change for new m_correctionPanelInfo
        member variable.
      (WebCore::Editor::correctionPanelTimerFired): Change to handle reversion panel type.
      (WebCore::Editor::handleRejectedCorrection): Ditto.
      (WebCore::Editor::startCorrectionPanelTimer): Changed signature to allow passing in panel type.
      (WebCore::Editor::stopCorrectionPanelTimer): Adopted macro SUPPORT_CORRECTION_PANEL.
      (WebCore::Editor::handleCancelOperation): Ditto.
      (WebCore::Editor::isShowingCorrectionPanel): Ditto.
      (WebCore::Editor::dismissCorrectionPanel): Update m_correctionPanelInfo when correction panel
        is dismissed.
      (WebCore::Editor::applyCorrectionPanelInfo): Factored out code that applies autocorrection.
      (WebCore::Editor::changeSelectionAfterCommand): Adopt macro SUPPORT_CORRECTION_PANEL.
      * editing/Editor.h: Adopted CorrectionPanelInfo and add new member methods.
      * editing/EditorCommand.cpp: Adopted macro SUPPORT_CORRECTION_PANEL
      (WebCore::createCommandMap):
      * editing/TypingCommand.cpp: Adopted macro SUPPORT_CORRECTION_PANEL and new signature of
        startCorrectionPanelTimer().
      (WebCore::TypingCommand::markMisspellingsAfterTyping):
      * loader/EmptyClients.h:
      (WebCore::EmptyEditorClient::showCorrectionPanel): Adopted new signature of base class method.
      (WebCore::EmptyEditorClient::dismissCorrectionPanel):  Ditto.
      * manual-tests/autocorrection/continue-typing-to-dismiss-reversion.html: Added.
      * manual-tests/autocorrection/delete-to-dismiss-reversion.html: Added.
      * manual-tests/autocorrection/delete-to-end-of-word-to-show-reversion.html: Added.
      * manual-tests/autocorrection/move-to-end-of-word-to-show-reversion.html: Added.
      * manual-tests/autocorrection/type-whitespace-to-dismiss-reversion.html: Added.
      * page/EditorClient.h: Changed signature of showCorrectionPanel() and dismissCorrectionPanel().
      * platform/graphics/mac/GraphicsContextMac.mm: Added comment to improve readability.
      (WebCore::GraphicsContext::drawLineForTextChecking):
      
      WebKit/mac: 
      
      This patch is to add reversion to correction panel. Please see WebCore/ChangeLog for detail.
      
      * WebCoreSupport/WebEditorClient.h: Adopted new signature of base class method.
      * WebCoreSupport/WebEditorClient.mm: Adopted new signature of base class method. And code
        change to use new reversion API in AppKit.
      (WebEditorClient::WebEditorClient):
      (WebEditorClient::~WebEditorClient):
      (WebEditorClient::respondToChangedSelection):
      (WebEditorClient::showCorrectionPanel):
      (WebEditorClient::dismissCorrectionPanel):
      (WebEditorClient::isShowingCorrectionPanel):
      
      WebKit2: 
      
      This patch is to add reversion to correction panel. Please see WebCore/ChangeLog for detail.
      
      * WebProcess/WebCoreSupport/WebEditorClient.h: Adopted new signature of base class method.
      * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: Ditto.
      (WebKit::WebEditorClient::showCorrectionPanel):
      (WebKit::WebEditorClient::dismissCorrectionPanel):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71385 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f82f4ad6
  36. 20 Sep, 2010 1 commit
    • enrica@apple.com's avatar
      Pasteboard doesn't work in WebKit2. · 1e404e08
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=42317
      <rdar://problem/7660537>
      
      Reviewed by Sam Weinig.
      
      WebCore: 
      
      * loader/EmptyClients.h:
      (WebCore::EmptyEditorClient::documentFragmentFromAttributedString): Changed parameter to
      be a Vector of RefPtr.
      * page/EditorClient.h:
      * platform/mac/PasteboardMac.mm:
      (WebCore::Pasteboard::documentFragmentWithRtf): Stylistic changes.
      
      WebKit/mac: 
      
      Some changes to fix style inconsistencies.
      Added OBJC 2.0 style enumeration.
              
      * WebCoreSupport/WebEditorClient.h:
      * WebCoreSupport/WebEditorClient.mm:
      (WebEditorClient::userVisibleString):
      (createExcludedElementsForAttributedStringConversion):
      (WebEditorClient::documentFragmentFromAttributedString): Changed parameter to be
      a Vector of RefPtr.
      (WebEditorClient::setInsertionPasteboard):
      (WebEditorClient::pasteboardTypesForSelection):
      
      WebKit2: 
      
      Adding support for RTF, RTFD and NSUrl formats on the Mac.
      Still missing the selective enabling of the menu entries.
      
      * WebKit2.xcodeproj/project.pbxproj: Added WebEditorClientMac.mm.
      * WebProcess/WebCoreSupport/WebEditorClient.cpp: Removed Mac only methods
      that are now in WebEditorClientMac.mm
      * WebProcess/WebCoreSupport/WebEditorClient.h: Fixed style and changed parameter
      type in documentFragmentFromAttributedString to be a Vector of RefPtr.
      * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: Added.
      All the following methods have been moved from WebEditorClient.cpp.
      (WebKit::WebEditorClient::userVisibleString): Added implementation.
      (WebKit::createExcludedElementsForAttributedStringConversion): Added.
      (WebKit::WebEditorClient::documentFragmentFromAttributedString): Added implementation.
      (WebKit::WebEditorClient::setInsertionPasteboard):
      (WebKit::WebEditorClient::pasteboardTypesForSelection):
      (WebKit::WebEditorClient::uppercaseWord):
      (WebKit::WebEditorClient::lowercaseWord):
      (WebKit::WebEditorClient::capitalizeWord):
      (WebKit::WebEditorClient::showSubstitutionsPanel):
      (WebKit::WebEditorClient::substitutionsPanelIsShowing):
      (WebKit::WebEditorClient::toggleSmartInsertDelete):
      (WebKit::WebEditorClient::isAutomaticQuoteSubstitutionEnabled):
      (WebKit::WebEditorClient::toggleAutomaticQuoteSubstitution):
      (WebKit::WebEditorClient::isAutomaticLinkDetectionEnabled):
      (WebKit::WebEditorClient::toggleAutomaticLinkDetection):
      (WebKit::WebEditorClient::isAutomaticDashSubstitutionEnabled):
      (WebKit::WebEditorClient::toggleAutomaticDashSubstitution):
      (WebKit::WebEditorClient::isAutomaticTextReplacementEnabled):
      (WebKit::WebEditorClient::toggleAutomaticTextReplacement):
      (WebKit::WebEditorClient::isAutomaticSpellingCorrectionEnabled):
      (WebKit::WebEditorClient::toggleAutomaticSpellingCorrection):
      (WebKit::WebEditorClient::checkTextOfParagraph):
      (WebKit::WebEditorClient::showCorrectionPanel):
      (WebKit::WebEditorClient::dismissCorrectionPanel):
      (WebKit::WebEditorClient::isShowingCorrectionPanel):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67864 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e404e08