1. 23 Jan, 2014 1 commit
    • carlosgc@webkit.org's avatar
      [GLIB] Use GUniquePtr instead of GOwnPtr · f2ece55f
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=127431
      
      Reviewed by Martin Robinson.
      
      GUniquePtr is a template alias of std::unique_ptr with a custom
      deleter that replaces GOwnPtr. GOwnPtr is still used for the cases
      where the output pointer is needed, but it will also be replaced soon.
      
      Source/WebCore:
      
      * GNUmakefile.list.am:
      * PlatformGTK.cmake:
      * accessibility/atk/AXObjectCacheAtk.cpp:
      * accessibility/atk/WebKitAccessibleInterfaceText.cpp:
      (getAttributeSetForAccessibilityObject):
      (accessibilityObjectLength):
      (textExtents):
      (webkitAccessibleTextGetChar):
      (numberOfReplacedElementsBeforeOffset):
      * page/ContextMenuController.cpp:
      * platform/SharedBuffer.h:
      * platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
      (webKitWebAudioSrcConstructed):
      (webKitWebAudioSrcLoop):
      * platform/audio/gtk/AudioBusGtk.cpp:
      (WebCore::AudioBus::loadPlatformResource):
      * platform/geoclue/GeolocationProviderGeoclue.cpp:
      * platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
      (WebCore::MediaPlayerPrivateGStreamer::setAudioStreamProperties):
      (WebCore::MediaPlayerPrivateGStreamer::handleMessage):
      * platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:
      (webKitMediaSrcAddSrc):
      * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
      (webKitWebSrcStart):
      (ResourceHandleStreamingClient::wasBlocked):
      (ResourceHandleStreamingClient::cannotShowURL):
      * platform/graphics/gtk/ImageBufferGtk.cpp:
      (WebCore::encodeImage):
      (WebCore::ImageBuffer::toDataURL):
      * platform/graphics/gtk/ImageGtk.cpp:
      (WebCore::getThemeIconFileName):
      (WebCore::Image::loadPlatformResource):
      * platform/gtk/ContextMenuGtk.cpp:
      (WebCore::ContextMenu::itemCount):
      (WebCore::contextMenuItemVector):
      * platform/gtk/ContextMenuItemGtk.cpp:
      (WebCore::createPlatformMenuItemDescription):
      * platform/gtk/DataObjectGtk.cpp:
      (WebCore::DataObjectGtk::setURIList):
      (WebCore::DataObjectGtk::setURL):
      * platform/gtk/FileSystemGtk.cpp:
      (WebCore::filenameToString):
      (WebCore::fileSystemRepresentation):
      (WebCore::filenameForDisplay):
      (WebCore::pathGetFileName):
      (WebCore::applicationDirectoryPath):
      (WebCore::sharedResourcesPath):
      (WebCore::directoryName):
      (WebCore::listDirectory):
      (WebCore::openTemporaryFile):
      * platform/gtk/GOwnPtrGtk.cpp: Removed.
      * platform/gtk/GOwnPtrGtk.h: Removed.
      * platform/gtk/GUniquePtrGtk.h: Added.
      * platform/gtk/GamepadsGtk.cpp:
      (WebCore::GamepadsGtk::GamepadsGtk):
      * platform/gtk/GtkClickCounter.cpp:
      (WebCore::GtkClickCounter::shouldProcessButtonEvent):
      * platform/gtk/GtkInputMethodFilter.cpp:
      (WebCore::GtkInputMethodFilter::sendCompositionAndPreeditWithFakeKeyEvents):
      * platform/gtk/GtkPopupMenu.cpp:
      (WebCore::GtkPopupMenu::popUp):
      (WebCore::GtkPopupMenu::typeAheadFind):
      * platform/gtk/LanguageGtk.cpp:
      (WebCore::platformLanguage):
      * platform/gtk/LocalizedStringsGtk.cpp:
      (WebCore::imageTitle):
      (WebCore::localizedMediaTimeDescription):
      * platform/gtk/PasteboardHelper.cpp:
      (WebCore::selectionDataToUTF8String):
      (WebCore::PasteboardHelper::getClipboardContents):
      (WebCore::PasteboardHelper::fillSelectionData):
      * platform/gtk/PopupMenuGtk.cpp:
      (WebCore::PopupMenuGtk::createGtkActionForMenuItem):
      (WebCore::PopupMenuGtk::show):
      * platform/gtk/WebKitAuthenticationWidget.cpp:
      (webkitAuthenticationWidgetInitialize):
      * platform/network/ResourceHandleInternal.h:
      * platform/network/gtk/CredentialBackingStore.cpp:
      (WebCore::credentialForChallengeAsyncReadyCallback):
      * platform/network/soup/CookieJarSoup.cpp:
      (WebCore::setCookiesFromDOM):
      (WebCore::cookiesForSession):
      (WebCore::getRawCookies):
      (WebCore::deleteCookie):
      (WebCore::getHostnamesWithCookies):
      (WebCore::deleteCookiesForHostname):
      (WebCore::deleteAllCookies):
      * platform/network/soup/DNSSoup.cpp:
      * platform/network/soup/GUniquePtrSoup.h: Added.
      * platform/network/soup/ResourceErrorSoup.cpp:
      (WebCore::failingURI):
      * platform/network/soup/ResourceHandleSoup.cpp:
      (WebCore::ResourceHandle::ensureReadBuffer):
      (WebCore::cleanupSoupRequestOperation):
      (WebCore::createSoupRequestAndMessageForHandle):
      * platform/network/soup/ResourceRequestSoup.cpp:
      (WebCore::ResourceRequest::updateSoupMessageMembers):
      (WebCore::ResourceRequest::updateSoupMessage):
      * platform/network/soup/ResourceResponseSoup.cpp:
      * platform/network/soup/SoupURIUtils.cpp:
      (WebCore::soupURIToKURL):
      * platform/soup/SharedBufferSoup.cpp:
      (WebCore::SharedBuffer::SharedBuffer):
      (WebCore::SharedBuffer::clearPlatformData):
      (WebCore::SharedBuffer::maybeTransferPlatformData):
      (WebCore::SharedBuffer::hasPlatformData):
      * plugins/gtk/PluginPackageGtk.cpp:
      (WebCore::PluginPackage::fetchInfo):
      (WebCore::PluginPackage::load):
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/ContextMenuClientGtk.cpp:
      (WebKit::getUnicodeMenuItemPosition):
      * WebCoreSupport/DragClientGtk.cpp:
      (WebKit::DragClient::startDrag):
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
      (DumpRenderTreeSupportGtk::setValueForUser):
      * WebCoreSupport/EditorClientGtk.h:
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      (WebKit::FrameLoaderClient::userAgent):
      (WebKit::FrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
      (WebKit::FrameLoaderClient::dispatchWillSendRequest):
      (WebKit::FrameLoaderClient::assignIdentifierToInitialRequest):
      (WebKit::FrameLoaderClient::dispatchDidReceiveResponse):
      (WebKit::FrameLoaderClient::dispatchDidReceiveContentLength):
      (WebKit::FrameLoaderClient::dispatchDidFinishLoading):
      (WebKit::FrameLoaderClient::dispatchDidFailLoading):
      (WebKit::FrameLoaderClient::dispatchDidFailLoad):
      * WebCoreSupport/InspectorClientGtk.h:
      * webkit/webkitfavicondatabase.cpp:
      (webkit_favicon_database_set_path):
      * webkit/webkitfilechooserrequest.cpp:
      * webkit/webkitglobals.cpp:
      (webkitInit):
      * webkit/webkithittestresult.cpp:
      (WebKit::kit):
      * webkit/webkiticondatabase.cpp:
      (webkit_icon_database_set_path):
      * webkit/webkitspellcheckerenchant.cpp:
      * webkit/webkitwebplugin.cpp:
      (webkit_web_plugin_get_path):
      * webkit/webkitwebpluginprivate.h:
      * webkit/webkitwebsettings.cpp:
      (webkit_web_settings_class_init):
      (webkit_web_settings_copy):
      * webkit/webkitwebview.cpp:
      (webkit_web_view_forward_context_menu_event):
      (fileChooserDialogResponseCallback):
      (webkit_web_view_drag_end):
      * webkit/webkitwebviewprivate.h:
      
      Source/WebKit2:
      
      * Shared/Downloads/soup/DownloadSoup.cpp:
      (WebKit::DownloadClient::didReceiveResponse):
      * Shared/NativeWebKeyboardEvent.h:
      * Shared/NativeWebMouseEvent.h:
      * Shared/NativeWebWheelEvent.h:
      * Shared/gtk/ArgumentCodersGtk.cpp:
      (IPC::encodeGKeyFile):
      (IPC::decodeGKeyFile):
      (IPC::encode):
      (IPC::decode):
      * UIProcess/API/gtk/WebKitContextMenuItem.cpp:
      (webkitContextMenuItemSetSubMenuFromGtkMenu):
      * UIProcess/API/gtk/WebKitDownload.cpp:
      (webkitDownloadDecideDestination):
      (webkitDownloadNotifyProgress):
      (webkitDownloadFailed):
      * UIProcess/API/gtk/WebKitFileChooserRequest.cpp:
      (webkit_file_chooser_request_select_files):
      * UIProcess/API/gtk/WebKitInjectedBundleClient.cpp:
      (didReceiveWebViewMessageFromInjectedBundle):
      (getInjectedBundleInitializationUserData):
      * UIProcess/API/gtk/WebKitLoaderClient.cpp:
      (didFailProvisionalLoadWithErrorForFrame):
      (didFailLoadWithErrorForFrame):
      * UIProcess/API/gtk/WebKitPrintOperation.cpp:
      (drawPagesForPrintingCompleted):
      * UIProcess/API/gtk/WebKitURIRequest.cpp:
      (webkit_uri_request_get_http_headers):
      * UIProcess/API/gtk/WebKitURISchemeRequest.cpp:
      (webkit_uri_scheme_request_get_scheme):
      (webkit_uri_scheme_request_get_path):
      * UIProcess/API/gtk/WebKitWebContext.cpp:
      (injectedBundleFilename):
      (webkit_web_context_set_favicon_database_directory):
      * UIProcess/API/gtk/WebKitWebView.cpp:
      (webkitWebViewLoadFail):
      (webkitWebViewCreateJavaScriptDialog):
      (fileChooserDialogResponseCallback):
      (webkitWebViewLoadChanged):
      (webkitWebViewLoadFailedWithTLSErrors):
      (webkitWebViewPopulateContextMenu):
      * UIProcess/API/gtk/WebKitWebViewBase.cpp:
      (webkitWebViewBaseButtonPressEvent):
      (webkitWebViewBaseStartDrag):
      * UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:
      (WebKit::WebInspectorServer::platformResourceForPath):
      * UIProcess/InspectorServer/soup/WebSocketServerSoup.cpp:
      (WebKit::connectionCallback):
      * UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
      (WebKit::ProcessLauncher::launchProcess):
      * UIProcess/gtk/WebContextGtk.cpp:
      (WebKit::WebContext::platformDefaultApplicationCacheDirectory):
      (WebKit::WebContext::platformDefaultDatabaseDirectory):
      (WebKit::WebContext::platformDefaultIconDatabasePath):
      (WebKit::WebContext::platformDefaultLocalStorageDirectory):
      (WebKit::WebContext::platformDefaultDiskCacheDirectory):
      * UIProcess/gtk/WebContextMenuProxyGtk.cpp:
      (WebKit::contextMenuItemVisibilityChanged):
      * UIProcess/gtk/WebInspectorProxyGtk.cpp:
      (WebKit::WebInspectorProxy::platformInspectedURLChanged):
      * UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
      (WebKit::WebPopupMenuProxyGtk::createGtkActionForMenuItem):
      * WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
      * WebProcess/WebPage/gtk/WebPageGtk.cpp:
      (WebKit::WebPage::platformInitialize):
      * WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
      * WebProcess/gtk/WebProcessMainGtk.cpp:
      * WebProcess/soup/WebSoupRequestManager.cpp:
      (WebKit::WebSoupRequestManager::send):
      
      Tools:
      
      * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
      (printAccessibilityEvent):
      (axObjectEventListener):
      * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
      (indexRangeInTable):
      (AccessibilityUIElement::role):
      (AccessibilityUIElement::title):
      (AccessibilityUIElement::description):
      (AccessibilityUIElement::stringValue):
      (AccessibilityUIElement::language):
      (AccessibilityUIElement::lineForIndex):
      (AccessibilityUIElement::selectedTextRange):
      (AccessibilityUIElement::url):
      * DumpRenderTree/efl/AccessibilityControllerEfl.cpp:
      (AccessibilityController::accessibleElementById):
      * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
      (AccessibilityController::accessibleElementById):
      * DumpRenderTree/gtk/DumpRenderTree.cpp:
      (getOutputDir):
      (getFontsPath):
      (initializeFonts):
      (dumpFramesAsText):
      (compareHistoryItems):
      (dumpHistoryItem):
      (soupURIToStringPreservingPassword):
      (resetDefaultsToConsistentValues):
      (temporaryDatabaseDirectory):
      (webViewTitleChanged):
      (webFrameLoadStatusNotified):
      (pathFromSoupURI):
      (convertWebResourceToURLPath):
      (urlSuitableForTestResult):
      (descriptionSuitableForTestResult):
      (willSendRequestCallback):
      (frameLoadEventCallback):
      * DumpRenderTree/gtk/EditingCallbacks.cpp:
      (dumpNodePath):
      (dumpRange):
      (shouldApplyStyle):
      * DumpRenderTree/gtk/EventSender.cpp:
      (contextClickCallback):
      (beginDragWithFilesCallback):
      * DumpRenderTree/gtk/TestRunnerGtk.cpp:
      (TestRunner::pathToLocalResource):
      (TestRunner::queueLoad):
      (TestRunner::removeOriginAccessWhitelistEntry):
      (TestRunner::setMockGeolocationPositionUnavailableError):
      (TestRunner::setIconDatabaseEnabled):
      (TestRunner::findString):
      (TestRunner::setDomainRelaxationForbiddenForURLScheme):
      (TestRunner::overridePreference):
      (TestRunner::addUserScript):
      (TestRunner::addUserStyleSheet):
      (TestRunner::setTextDirection):
      * DumpRenderTree/gtk/TextInputController.cpp:
      (setMarkedTextCallback):
      (insertTextCallback):
      (doCommandCallback):
      * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
      (LoadHTMLStringItem::invoke):
      * TestWebKitAPI/PlatformGTK.cmake:
      * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
      (WebKitDOMNodeTest::testTagNames):
      * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
      (testBackForwardListLimitAndCache):
      * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
      (testContextMenuSmartSeparators):
      * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
      * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
      (testDownloadLocalFile):
      (testDownloadLocalFileError):
      (addContentDispositionHTTPHeaderToResponse):
      (serverCallback):
      (testDownloadRemoteFileError):
      * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
      (startTestServer):
      (testInspectorServerPageList):
      (openRemoteDebuggingSession):
      * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
      (testPrintOperationPrint):
      * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
      (addCacheHTTPHeadersToResponse):
      (serverCallback):
      * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
      (httpsServerCallback):
      (httpServerCallback):
      * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
      (testWebViewJavaScriptDialogs):
      (testWebViewWindowProperties):
      (testWebViewFileChooserRequest):
      * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
      (testWebExtensionWindowObjectCleared):
      (testWebExtensionIsolatedWorld):
      * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
      (startTestServer):
      (checkAtspiAccessible):
      * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
      (serverCallback):
      (testClearDatabase):
      (testGetFaviconURI):
      (webkitFaviconDatabaseFinalizedCallback):
      * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
      (testWebContextGetPlugins):
      (testWebContextURIScheme):
      * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
      (testWebViewRunJavaScript):
      (testWebViewMode):
      (testWebViewPageVisibility):
      * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:
      (isStyleSheetInjectedForURLAtPath):
      * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
      (testWebViewEditorCutCopyPasteNonEditable):
      (testWebViewEditorCutCopyPasteEditable):
      (testWebViewEditorSelectAllNonEditable):
      (testWebViewEditorSelectAllEditable):
      * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
      (sendRequestCallback):
      (methodCallCallback):
      * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
      (TestWebKitAPI::Util::createInjectedBundlePath):
      (TestWebKitAPI::Util::createURLForResource):
      * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
      (TestWebKitAPI::doKeyStroke):
      (TestWebKitAPI::doMouseButtonEvent):
      (TestWebKitAPI::PlatformWebView::simulateMouseMove):
      * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
      (loadFailedCallback):
      (LoadTrackingTest::loadURI):
      (LoadTrackingTest::loadHtml):
      (LoadTrackingTest::loadPlainText):
      (LoadTrackingTest::loadRequest):
      (LoadTrackingTest::reload):
      (LoadTrackingTest::goBack):
      (LoadTrackingTest::goForward):
      * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
      * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
      (registerGResource):
      (removeNonEmptyDirectory):
      (main):
      * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
      (Test::getWebKit1TestResoucesDir):
      (Test::getResourcesDir):
      * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
      (WebKitTestBus::run):
      * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
      (WebKitTestServer::WebKitTestServer):
      (WebKitTestServer::getURIForPath):
      * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
      (WebProcessTestRunner::runTest):
      * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
      (resourceGetDataCallback):
      (WebViewTest::mainResourceData):
      (WebViewTest::mouseMoveTo):
      (WebViewTest::keyStroke):
      (WebViewTest::doMouseButtonEvent):
      * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
      * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
      (WTR::AccessibilityController::accessibleElementById):
      * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
      * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
      (WTR::AccessibilityUIElement::role):
      (WTR::AccessibilityUIElement::title):
      (WTR::AccessibilityUIElement::description):
      (WTR::AccessibilityUIElement::stringValue):
      (WTR::AccessibilityUIElement::language):
      (WTR::AccessibilityUIElement::lineForIndex):
      (WTR::AccessibilityUIElement::selectedTextRange):
      (WTR::AccessibilityUIElement::url):
      * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
      (WTR::getOutputDir):
      (WTR::getFontsPath):
      (WTR::initializeFontConfigSetting):
      * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
      (WTR::topLevelPath):
      * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
      (WTR::TestRunner::pathToLocalResource):
      * WebKitTestRunner/gtk/TestControllerGtk.cpp:
      (WTR::TestController::initializeInjectedBundlePath):
      (WTR::TestController::initializeTestPluginDirectory):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2ece55f
  2. 18 Jan, 2014 1 commit
    • bburg@apple.com's avatar
      Web Inspector: Page should use std::unique_ptr for InspectorController · 9efd2cdf
      bburg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127068
      
      Reviewed by Joseph Pecoraro.
      
      Source/WebCore:
      
      Make Page and WorkerGlobalScope keep a std::unique_ptr to InspectorController
      and WorkerInspectorController. Store page references and return controller
      references where possible.
      
      Convert call sites to use an InspectorController reference.
      Convert instantiations of InspectorFrontendClient to use std::unique_ptr.
      Convert InspectorOverlay to keep Page references.
      
      * WebCore.exp.in:
      * bindings/js/JSDOMWindowBase.cpp:
      (WebCore::JSDOMWindowBase::supportsProfiling):
      (WebCore::JSDOMWindowBase::supportsRichSourceInfo):
      * dom/Node.cpp:
      (WebCore::Node::inspect):
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::InspectorController):
      (WebCore::InspectorController::inspectedPageDestroyed):
      (WebCore::InspectorController::setInspectorFrontendClient):
      (WebCore::InspectorController::hasInspectorFrontendClient):
      (WebCore::InspectorController::connectFrontend):
      (WebCore::InspectorController::disconnectFrontend):
      (WebCore::InspectorController::inspectedPage):
      (WebCore::InspectorController::developerExtrasEnabled):
      * inspector/InspectorController.h:
      * inspector/InspectorFrontendClientLocal.cpp:
      (WebCore::InspectorFrontendClientLocal::canAttachWindow):
      (WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight):
      (WebCore::InspectorFrontendClientLocal::changeAttachedWindowWidth):
      (WebCore::InspectorFrontendClientLocal::openInNewTab):
      (WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):
      * inspector/InspectorOverlay.cpp:
      (WebCore::InspectorOverlay::InspectorOverlay):
      (WebCore::InspectorOverlay::getHighlight):
      (WebCore::InspectorOverlay::highlightQuad):
      (WebCore::InspectorOverlay::update):
      (WebCore::InspectorOverlay::buildObjectForHighlightedNode):
      (WebCore::InspectorOverlay::drawQuadHighlight):
      (WebCore::InspectorOverlay::overlayPage):
      (WebCore::InspectorOverlay::reset):
      * inspector/InspectorOverlay.h:
      * inspector/InstrumentingAgents.cpp:
      (WebCore::instrumentationForPage): remove null checks.
      (WebCore::instrumentationForWorkerGlobalScope): remove null checks.
      * inspector/WorkerInspectorController.cpp:
      (WebCore::WorkerInspectorController::WorkerInspectorController):
      (WebCore::WorkerInspectorController::connectFrontend):
      (WebCore::WorkerInspectorController::disconnectFrontend):
      * inspector/WorkerInspectorController.h:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
      (WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::showContextMenu):
      (WebCore::ContextMenuController::contextMenuItemSelected):
      (WebCore::ContextMenuController::populate):
      (WebCore::ContextMenuController::addInspectElementItem):
      * page/FrameView.cpp:
      (WebCore::FrameView::sendResizeEventIfNeeded):
      * page/Page.cpp:
      (WebCore::Page::Page):
      * page/Page.h:
      (WebCore::Page::inspectorController):
      * page/PageDebuggable.cpp:
      (WebCore::PageDebuggable::hasLocalDebugger):
      (WebCore::PageDebuggable::parentProcessIdentifier):
      (WebCore::PageDebuggable::connect):
      (WebCore::PageDebuggable::disconnect):
      (WebCore::PageDebuggable::dispatchMessageFromRemoteFrontend):
      (WebCore::PageDebuggable::setIndicating):
      * platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
      (WebCore::CompositingCoordinator::syncDisplayState):
      * testing/Internals.cpp:
      (WebCore::Internals::resetToConsistentState):
      (WebCore::Internals::inspectorHighlightRects):
      (WebCore::Internals::inspectorHighlightObject):
      (WebCore::Internals::emitInspectorDidBeginFrame):
      (WebCore::Internals::emitInspectorDidCancelFrame):
      (WebCore::Internals::openDummyInspectorFrontend):
      (WebCore::Internals::closeDummyInspectorFrontend):
      (WebCore::Internals::setInspectorResourcesDataSizeLimits):
      (WebCore::Internals::setJavaScriptProfilingEnabled):
      * workers/WorkerGlobalScope.cpp:
      (WebCore::WorkerGlobalScope::WorkerGlobalScope):
      * workers/WorkerGlobalScope.h: remove clearInspector().
      (WebCore::WorkerGlobalScope::workerInspectorController):
      * workers/WorkerMessagingProxy.cpp:
      (WebCore::connectToWorkerGlobalScopeInspectorTask):
      (WebCore::disconnectFromWorkerGlobalScopeInspectorTask):
      (WebCore::dispatchOnInspectorBackendTask):
      * workers/WorkerThread.cpp:
      (WebCore::WorkerThreadShutdownFinishTask::performTask):
      
      Source/WebKit/efl:
      
      Convert call sites to use a InspectorController reference.
      Convert instantiations of InspectorFrontendClient to use std::unique_ptr.
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      (DumpRenderTreeSupportEfl::evaluateInWebInspector):
      * WebCoreSupport/InspectorClientEfl.cpp:
      (WebCore::InspectorClientEfl::openInspectorFrontend):
      * ewk/ewk_view.cpp:
      (ewk_view_inspector_show):
      (ewk_view_inspector_close):
      
      Source/WebKit/gtk:
      
      Convert call sites to use a InspectorController reference.
      Convert instantiations of InspectorFrontendClient to use std::unique_ptr.
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::paintWebView):
      * WebCoreSupport/InspectorClientGtk.cpp:
      (WebKit::InspectorClient::openInspectorFrontend):
      * webkit/webkitwebinspector.cpp:
      (webkit_web_inspector_set_property):
      (webkit_web_inspector_get_property):
      (webkit_web_inspector_show):
      (webkit_web_inspector_inspect_node):
      (webkit_web_inspector_inspect_coordinates):
      (webkit_web_inspector_close):
      (webkit_web_inspector_execute_script):
      
      Source/WebKit/mac:
      
      Convert call sites to use a InspectorController reference.
      Convert instantiations of InspectorFrontendClient to use std::unique_ptr.
      
      * WebCoreSupport/WebInspectorClient.mm:
      (WebInspectorClient::openInspectorFrontend):
      (-[WebInspectorWindowController destroyInspectorView:]):
      * WebInspector/WebInspector.mm:
      (-[WebInspector showWindow]):
      (-[WebInspector isJavaScriptProfilingEnabled]):
      (-[WebInspector setJavaScriptProfilingEnabled:]):
      (-[WebInspector close:]):
      (-[WebInspector evaluateInFrontend:callId:script:]):
      * WebInspector/WebNodeHighlighter.mm:
      (-[WebNodeHighlighter highlight]):
      
      Source/WebKit/win:
      
      Convert call sites to use a InspectorController reference.
      
      * WebCoreSupport/WebInspectorClient.cpp:
      (WebInspectorClient::openInspectorFrontend):
      (WebInspectorFrontendClient::destroyInspectorView):
      (WebInspectorFrontendClient::onClose):
      * WebInspector.cpp:
      (WebInspector::show):
      (WebInspector::close):
      (WebInspector::isJavaScriptProfilingEnabled):
      (WebInspector::setJavaScriptProfilingEnabled):
      (WebInspector::evaluateInFrontend):
      * WebNodeHighlight.cpp:
      (WebNodeHighlight::update):
      
      Source/WebKit2:
      
      Convert call sites to use a InspectorController reference.
      
      * WebProcess/WebCoreSupport/WebInspectorClient.cpp:
      (WebKit::WebInspectorClient::drawRect):
      * WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
      (WebKit::WebInspectorFrontendClient::WebInspectorFrontendClient):
      (WebKit::WebInspectorFrontendClient::closeWindow):
      * WebProcess/WebPage/WebInspector.cpp:
      (WebKit::WebInspector::createInspectorPage):
      (WebKit::WebInspector::show):
      (WebKit::WebInspector::close):
      (WebKit::WebInspector::evaluateScriptForTest):
      (WebKit::WebInspector::showConsole):
      (WebKit::WebInspector::showResources):
      (WebKit::WebInspector::showMainResourceForFrame):
      (WebKit::WebInspector::startJavaScriptDebugging):
      (WebKit::WebInspector::stopJavaScriptDebugging):
      (WebKit::WebInspector::setJavaScriptProfilingEnabled):
      (WebKit::WebInspector::startJavaScriptProfiling):
      (WebKit::WebInspector::stopJavaScriptProfiling):
      (WebKit::WebInspector::startPageProfiling):
      (WebKit::WebInspector::stopPageProfiling):
      (WebKit::WebInspector::dispatchMessageFromRemoteFrontend):
      (WebKit::WebInspector::remoteFrontendConnected):
      (WebKit::WebInspector::remoteFrontendDisconnected):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162264 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9efd2cdf
  3. 10 Jan, 2014 1 commit
    • andersca@apple.com's avatar
      Remove supportMultipleWindows setting · fefbc4d0
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=126772
      
      Reviewed by Beth Dakin.
      
      Source/WebCore:
      
      This setting was added in https://bugs.webkit.org/show_bug.cgi?id=99716 for the Chromium port
      and is unused by everyone else so get rid of it.
      
      * loader/FrameLoader.cpp:
      (WebCore::createWindow):
      * page/ContextMenuController.cpp:
      (WebCore::openNewWindow):
      * page/Settings.in:
      
      LayoutTests:
      
      * fast/dom/HTMLAnchorElement/anchor-no-multiple-windows-expected.txt: Removed.
      * fast/dom/HTMLAnchorElement/anchor-no-multiple-windows.html: Removed.
      * fast/dom/Window/window-open-no-multiple-windows-expected.txt: Removed.
      * fast/dom/Window/window-open-no-multiple-windows.html: Removed.
      * fast/forms/post-popup-no-multiple-windows-expected.txt: Removed.
      * fast/forms/post-popup-no-multiple-windows.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fefbc4d0
  4. 04 Dec, 2013 1 commit
    • joepeck@webkit.org's avatar
      Web Inspector: Push Remote Inspector debugging connection management into JavaScriptCore · d2ecf37f
      joepeck@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124613
      
      Reviewed by Timothy Hatcher.
      
      Source/JavaScriptCore:
      
      Move the ENABLE(REMOTE_INSPECTOR) remote debugger connection management
      into JavaScriptCore (originally from WebKit/mac). Include enhancements:
      
        * allow for different types of remote debuggable targets,
          eventually at least a JSContext, WebView, WKView.
        * allow debuggables to be registered and debugged on any thread. Unlike
          WebViews, JSContexts may be run entirely off of the main thread.
        * move the remote connection (XPC connection) itself off of the main thread,
          it doesn't need to be on the main thread.
      
      Make JSContext @class and JavaScriptCore::JSContextRef
      "JavaScript" Remote Debuggables.
      
      * inspector/remote/RemoteInspectorDebuggable.h: Added.
      * inspector/remote/RemoteInspectorDebuggable.cpp: Added.
      (Inspector::RemoteInspectorDebuggable::RemoteInspectorDebuggable):
      (Inspector::RemoteInspectorDebuggable::~RemoteInspectorDebuggable):
      (Inspector::RemoteInspectorDebuggable::init):
      (Inspector::RemoteInspectorDebuggable::update):
      (Inspector::RemoteInspectorDebuggable::setRemoteDebuggingAllowed):
      (Inspector::RemoteInspectorDebuggable::info):
      RemoteInspectorDebuggable defines a debuggable target. As long as
      something creates a debuggable and is set to allow remote inspection
      it will be listed in remote debuggers. For the different types of
      debuggables (JavaScript and Web) there is different basic information
      that may be listed.
      
      * inspector/InspectorFrontendChannel.h: Added.
      (Inspector::InspectorFrontendChannel::~InspectorFrontendChannel):
      The only thing a debuggable needs for remote debugging is an
      InspectorFrontendChannel a way to send messages to a remote frontend.
      This class provides that method, and is vended to the
      RemoteInspectorDebuggable when a remote connection is setup.
      
      * inspector/remote/RemoteInspector.h: Added.
      * inspector/remote/RemoteInspector.mm: Added.
      Singleton, created at least when the first Debuggable is created.
      This class manages the list of debuggables, any connection to a
      remote debugger proxy (XPC service "com.apple.webinspector").
      
      (Inspector::dispatchAsyncOnQueueSafeForAnyDebuggable):
      (Inspector::RemoteInspector::shared):
      (Inspector::RemoteInspector::RemoteInspector):
      (Inspector::RemoteInspector::nextAvailableIdentifier):
      (Inspector::RemoteInspector::registerDebuggable):
      (Inspector::RemoteInspector::unregisterDebuggable):
      (Inspector::RemoteInspector::updateDebuggable):
      Debuggable management. When debuggables are added, removed, or updated
      we stash a copy of the debuggable information and push an update to
      debuggers. Stashing a copy of the information in the RemoteInspector
      is a thread safe way to avoid walking over all debuggables to gather
      the information when it is needed.
      
      (Inspector::RemoteInspector::start):
      (Inspector::RemoteInspector::stop):
      Runtime API to enable / disable the feature.
      
      (Inspector::RemoteInspector::listingForDebuggable):
      (Inspector::RemoteInspector::pushListingNow):
      (Inspector::RemoteInspector::pushListingSoon):
      Pushing a listing to remote debuggers.
      
      (Inspector::RemoteInspector::sendMessageToRemoteFrontend):
      (Inspector::RemoteInspector::setupXPCConnectionIfNeeded):
      (Inspector::RemoteInspector::xpcConnectionReceivedMessage):
      (Inspector::RemoteInspector::xpcConnectionFailed):
      (Inspector::RemoteInspector::xpcConnectionUnhandledMessage):
      XPC setup, send, and receive handling.
      
      (Inspector::RemoteInspector::updateHasActiveDebugSession):
      Applications being debugged may want to know when a debug
      session is active. This provides that notification.
      
      (Inspector::RemoteInspector::receivedSetupMessage):
      (Inspector::RemoteInspector::receivedDataMessage):
      (Inspector::RemoteInspector::receivedDidCloseMessage):
      (Inspector::RemoteInspector::receivedGetListingMessage):
      (Inspector::RemoteInspector::receivedIndicateMessage):
      (Inspector::RemoteInspector::receivedConnectionDiedMessage):
      Dispatching incoming remote debugging protocol messages.
      These are wrapping above the inspector protocol messages.
      
      * inspector/remote/RemoteInspectorConstants.h: Added.
      Protocol messages and dictionary keys inside the messages.
      
      (Inspector::RemoteInspectorDebuggableInfo::RemoteInspectorDebuggableInfo):
      * inspector/remote/RemoteInspectorDebuggableConnection.h: Added.
      * inspector/remote/RemoteInspectorDebuggableConnection.mm: Added.
      This is a connection between the RemoteInspector singleton and a RemoteInspectorDebuggable.
      
      (Inspector::RemoteInspectorDebuggableConnection::RemoteInspectorDebuggableConnection):
      (Inspector::RemoteInspectorDebuggableConnection::~RemoteInspectorDebuggableConnection):
      Allow for dispatching messages on JavaScript debuggables on a dispatch_queue
      instead of the main queue.
      
      (Inspector::RemoteInspectorDebuggableConnection::destination):
      (Inspector::RemoteInspectorDebuggableConnection::connectionIdentifier):
      Needed in the remote debugging protocol to identify the remote debugger.
      
      (Inspector::RemoteInspectorDebuggableConnection::dispatchSyncOnDebuggable):
      (Inspector::RemoteInspectorDebuggableConnection::dispatchAsyncOnDebuggable):
      (Inspector::RemoteInspectorDebuggableConnection::setup):
      (Inspector::RemoteInspectorDebuggableConnection::closeFromDebuggable):
      (Inspector::RemoteInspectorDebuggableConnection::close):
      (Inspector::RemoteInspectorDebuggableConnection::sendMessageToBackend):
      (Inspector::RemoteInspectorDebuggableConnection::sendMessageToFrontend):
      The connection is a thin channel between the two sides that can be closed
      from either side, so there is some logic around multi-threaded access.
      
      * inspector/remote/RemoteInspectorXPCConnection.h: Added.
      (Inspector::RemoteInspectorXPCConnection::Client::~Client):
      * inspector/remote/RemoteInspectorXPCConnection.mm: Added.
      (Inspector::RemoteInspectorXPCConnection::RemoteInspectorXPCConnection):
      (Inspector::RemoteInspectorXPCConnection::~RemoteInspectorXPCConnection):
      (Inspector::RemoteInspectorXPCConnection::close):
      (Inspector::RemoteInspectorXPCConnection::deserializeMessage):
      (Inspector::RemoteInspectorXPCConnection::handleEvent):
      (Inspector::RemoteInspectorXPCConnection::sendMessage):
      This is a connection between the RemoteInspector singleton and an XPC service
      named "com.apple.webinspector". This handles serialization of the dictionary
      messages to and from the service. The receiving is done on a non-main queue.
      
      * API/JSContext.h:
      * API/JSContext.mm:
      (-[JSContext name]):
      (-[JSContext setName:]):
      ObjC API to enable/disable JSContext remote inspection and give a name.
      
      * API/JSContextRef.h:
      * API/JSContextRef.cpp:
      (JSGlobalContextGetName):
      (JSGlobalContextSetName):
      C API to give a JSContext a name.
      
      * runtime/JSGlobalObject.cpp:
      (JSC::JSGlobalObject::setName):
      * runtime/JSGlobalObject.h:
      (JSC::JSGlobalObject::name):
      Shared handling of the APIs above.
      
      * runtime/JSGlobalObjectDebuggable.cpp: Added.
      (JSC::JSGlobalObjectDebuggable::JSGlobalObjectDebuggable):
      (JSC::JSGlobalObjectDebuggable::name):
      (JSC::JSGlobalObjectDebuggable::connect):
      (JSC::JSGlobalObjectDebuggable::disconnect):
      (JSC::JSGlobalObjectDebuggable::dispatchMessageFromRemoteFrontend):
      * runtime/JSGlobalObjectDebuggable.h: Added.
      Stub for the actual remote debugging implementation. We will push
      down the appropriate WebCore/inspector peices suitable for debugging
      just a JavaScript context.
      
      * CMakeLists.txt:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * GNUmakefile.am:
      * GNUmakefile.list.am:
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
      Update build files.
      
      Source/WebCore:
      
      Make a WebCore::Page a "Web" Remote Debuggable.
      
      * bindings/js/JSDOMGlobalObject.cpp:
      Disable JavaScript context inspection on JSGlobalObjects inside WebCore::Page's.
      
      * page/Page.cpp:
      (WebCore::Page::Page):
      (WebCore::Page::remoteInspectionAllowed):
      (WebCore::Page::setRemoteInspectionAllowed):
      (WebCore::Page::remoteInspectorInformationDidChange):
      * page/Page.h:
      * page/PageDebuggable.h:
      * page/PageDebuggable.cpp: Added.
      (WebCore::PageDebuggable::PageDebuggable):
      (WebCore::PageDebuggable::name):
      (WebCore::PageDebuggable::url):
      (WebCore::PageDebuggable::hasLocalDebugger):
      (WebCore::PageDebuggable::connect):
      (WebCore::PageDebuggable::disconnect):
      (WebCore::PageDebuggable::dispatchMessageFromRemoteFrontend):
      (WebCore::PageDebuggable::setIndicating):
      Make a page a "Web" debuggable.
      
      * GNUmakefile.list.am:
      * WebCore.exp.in:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      Misc.
      
      * inspector/InspectorClient.h:
      (WebCore::InspectorClient::indicate):
      (WebCore::InspectorClient::hideIndicate):
      Forward indicate methods to WebKit clients.
      
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::didChangeTitle):
      (WebCore::FrameLoader::dispatchDidCommitLoad):
      Push updates when remote debuggable information like the Page's
      URL or title change.
      
      * ForwardingHeaders/inspector/InspectorFrontendChannel.h:
      * inspector/InspectorForwarding.h:
      Re-export Inspector::InspectorFrontendChannel as WebCore::InspectorFrontendChannel
      to avoid needlessly updating code all over the place.
      
      * inspector/CodeGeneratorInspectorStrings.py:
      * inspector/InspectorWorkerAgent.cpp:
      * inspector/WorkerInspectorController.cpp:
      * testing/Internals.cpp:
      Update include names.
      
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::populate):
      Make the "Inspect Element" context menu work correctly when there is a
      remote inspector instead of a local inspector.
      
      Source/WebKit:
      
      * WebKit.xcodeproj/project.pbxproj:
      
      Source/WebKit/blackberry:
      
      * WebCoreSupport/InspectorClientBlackBerry.h:
      
      Source/WebKit/cf:
      
      * WebCoreSupport/WebInspectorClientCF.cpp:
      (WebInspectorClient::sendMessageToFrontend):
      
      Source/WebKit/efl:
      
      * WebCoreSupport/InspectorClientEfl.h:
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/InspectorClientGtk.h:
      
      Source/WebKit/ios:
      
      * WebCoreSupport/WebInspectorClientIOS.mm:
      (WebInspectorClient::WebInspectorClient):
      (WebInspectorClient::inspectorDestroyed):
      
      Source/WebKit/mac:
      
      Remove the old ENABLE(REMOTE_INSPECTOR) connection management implementation.
      
      * WebCoreSupport/WebInspectorClient.h:
      * WebCoreSupport/WebInspectorClient.mm:
      (WebInspectorClient::indicate):
      (WebInspectorClient::hideIndicate):
      Hook up WebView indication through this new path.
      
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (WebFrameLoaderClient::dispatchDidReceiveTitle):
      * WebCoreSupport/WebInspectorClient.h:
      * WebCoreSupport/WebInspectorClient.mm:
      (WebInspectorClient::WebInspectorClient):
      (WebInspectorClient::inspectorDestroyed):
      * WebInspector/remote/WebInspectorClientRegistry.h: Removed.
      * WebInspector/remote/WebInspectorClientRegistry.mm: Removed.
      * WebInspector/remote/WebInspectorRelayDefinitions.h: Removed.
      * WebInspector/remote/WebInspectorRemoteChannel.h: Removed.
      * WebInspector/remote/WebInspectorRemoteChannel.mm: Removed.
      * WebInspector/remote/WebInspectorServer.h: Removed.
      * WebInspector/remote/WebInspectorServer.mm: Removed.
      * WebInspector/remote/WebInspectorServerWebViewConnection.h: Removed.
      * WebInspector/remote/WebInspectorServerWebViewConnection.mm: Removed.
      * WebInspector/remote/WebInspectorServerWebViewConnectionController.h: Removed.
      * WebInspector/remote/WebInspectorServerWebViewConnectionController.mm: Removed.
      * WebInspector/remote/WebInspectorXPCWrapper.h: Removed.
      * WebInspector/remote/WebInspectorXPCWrapper.m: Removed.
      * WebKit.exp:
      * WebView/WebView.mm:
      (-[WebView _commonInitializationWithFrameName:groupName:]):
      (+[WebView _enableRemoteInspector]):
      (+[WebView _disableRemoteInspector]):
      (+[WebView _disableAutoStartRemoteInspector]):
      (+[WebView _isRemoteInspectorEnabled]):
      (+[WebView _hasRemoteInspectorSession]):
      (-[WebView allowsRemoteInspection]):
      (-[WebView setAllowsRemoteInspection:]):
      (-[WebView setIndicatingForRemoteInspector:]):
      (-[WebView setHostApplicationBundleId:name:]):
      (-[WebView _didCommitLoadForFrame:]):
      * WebView/WebViewData.h:
      * WebView/WebViewData.mm:
      (-[WebViewPrivate init]):
      (-[WebViewPrivate dealloc]):
      * WebView/WebViewInternal.h:
      * WebView/WebViewPrivate.h:
      Remove old REMOTE_INSPECTOR.
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebInspectorClient.h:
      
      Source/WebKit/wince:
      
      * WebCoreSupport/InspectorClientWinCE.h:
      
      Source/WebKit2:
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::WebPage):
      * WebProcess/com.apple.WebProcess.sb.in:
      Allow the WebProcess to access the "com.apple.webinspector" named
      XPC service to expose its WebCore::Page's to remote debuggers.
      
      Source/WTF:
      
      * wtf/ios/WebCoreThread.cpp:
      * wtf/ios/WebCoreThread.h:
      Expose WebThreadRun/WebThreadRunSync iOS methods defined in WebCore through
      WTF so that JavaScriptCore can use it. Another such method already existed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160099 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2ecf37f
  5. 05 Nov, 2013 1 commit
    • samuel_white@apple.com's avatar
      AX: AXShowMenu doesn't always work. · 40d7d133
      samuel_white@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123649
      
      Reviewed by Chris Fleizach.
      
      No new tests, the change occurs in a code path that forces the context menu to show which
      locks up DRT if we try to test it (platform menu is shown). The change itself gives the mouse
      event handler a chance to handle our platform mouse event BEFORE the event ends up in the show
      context menu machinery. This is necessary because without it, the element will not become
      focused. Without focus, accessibility shows different/less menu items than a mouse click. The
      end result is that context menus shown via accessibility are consistent with menus shown via click.
      
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::showContextMenuAt):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40d7d133
  6. 12 Oct, 2013 1 commit
    • darin@apple.com's avatar
      Change most call sites to call ICU directly instead of through WTF::Unicode · 2eb5f4de
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122635
      
      Reviewed by Alexey Proskuryakov.
      
      Source/JavaScriptCore:
      
      * parser/Lexer.cpp:
      (JSC::isNonLatin1IdentStart): Take a UChar since that's what the only caller wants to pass.
      Use U_GET_GC_MASK instead of WTF::Unicode::category.
      (JSC::isNonLatin1IdentPart): Ditto.
      
      * parser/Lexer.h:
      (JSC::Lexer::isWhiteSpace): Use u_charType instead of WTF::Unicode::isSeparatorSpace.
      
      * runtime/JSFunction.cpp: Removed "using namespace" for WTF::Unicode, this will no longer
      compile since this doesn't include anything that defines that namespace.
      
      * runtime/JSGlobalObjectFunctions.cpp:
      (JSC::isStrWhiteSpace): Use u_charType instead of WTF::Unicode::isSeparatorSpace.
      
      * yarr/YarrInterpreter.cpp:
      (JSC::Yarr::ByteCompiler::atomPatternCharacter): Use u_tolower and u_toupper instead of
      Unicode::toLower and Unicode::toUpper. Also added some assertions since this code assumes
      it can convert any UChar to lowercase or uppercase in another UChar, with no risk of needing
      a UChar32 for the result. I guess that's probably true, but it would be good to know in a
      debug build if not.
      
      Source/WebCore:
      
      * Modules/indexeddb/IDBKeyPath.cpp:
      (isIdentifierStartCharacter): Use U_GET_GC_MASK instead of WTF::Unicode::category.
      (isIdentifierCharacter): Ditto.
      
      * css/CSSParser.cpp:
      (WebCore::makeLower): Use u_tolower instead of WTF::Unicode::toLower.
      Also assert the character fits in a UChar.
      
      * dom/Document.cpp:
      (WebCore::isValidNameStart): Use U_GET_GC_MASK instead of WTF::Unicode::category,
      and u_getIntPropertyValue instead of WTF::Unicode::decompositionType.
      (WebCore::isValidNamePart): Ditto.
      (WebCore::canonicalizedTitle): Ditto.
      
      * editing/Editor.cpp:
      (WebCore::Editor::insertTextWithoutSendingTextEvent): Use u_isPunct instead of
      WTF::Unicode::isPunct.
      
      * editing/TextIterator.cpp:
      (WebCore::SearchBuffer::append): Use u_strFoldCase instead of WTF::Unicode::foldCase.
      
      * html/HTMLElement.cpp:
      (WebCore::HTMLElement::directionality): Use UCharDirection instead of
      WTF::Unicode::Direction.
      
      * html/HTMLSelectElement.cpp:
      (WebCore::HTMLSelectElement::defaultEventHandler): Use u_isprint instead of
      WTF::Unicode::isPrintableChar.
      
      * html/TypeAhead.cpp:
      (WebCore::stripLeadingWhiteSpace): Use u_charDirection instead of
      WTF::Unicode::direction.
      
      * html/track/TextTrackCue.cpp:
      (WebCore::isCueParagraphSeparator): Use u_charType instead of
      WTF::Unicode::category.
      (WebCore::TextTrackCue::determineTextDirection): Use u_charDirection instead of
      WTF::Unicode::direction.
      
      * page/ContextMenuController.cpp:
      (WebCore::selectionContainsPossibleWord): Use U_GET_GC_MASK instead of
      WTF::Unicode::category.
      * platform/graphics/Font.cpp:
      (WebCore::Font::canReceiveTextEmphasis): Ditto.
      
      * platform/graphics/FontGlyphs.cpp:
      (WebCore::FontGlyphs::glyphDataAndPageForCharacter): Use u_toupper instead of
      WTF::Unicode::toUpper. Use u_charMirror instead of WTF::Unicode::mirroredChar.
      
      * platform/graphics/GraphicsContext.cpp:
      (WebCore::TextRunIterator::direction): Use u_charDirection instead of
      WTF::Unicode::direction.
      
      * platform/graphics/SVGGlyph.cpp:
      (WebCore::charactersWithArabicForm): Use ublock_getCode instead of
      WTF::Unicode::isArabicChar.
      
      * platform/graphics/SurrogatePairAwareTextIterator.cpp:
      (WebCore::SurrogatePairAwareTextIterator::normalizeVoicingMarks): Use
      u_getCombiningClass instead of WTF::Unicode::combiningClass.
      
      * platform/graphics/WidthIterator.cpp:
      (WebCore::WidthIterator::advanceInternal): Use u_toupper instead of
      WTF::Unicode::toUpper.
      
      * platform/graphics/mac/ComplexTextController.cpp:
      (WebCore::ComplexTextController::collectComplexTextRuns): Added some
      assertions about the user of u_toupper and tweaked coding style a bit.
      
      * platform/text/BidiContext.cpp:
      (WebCore::BidiContext::createUncached): Use UCharDirection instead of
      WTF::Unicode::Direction.
      (WebCore::BidiContext::create): Ditto.
      (WebCore::copyContextAndRebaselineLevel): Ditto.
      * platform/text/BidiContext.h:
      (WebCore::BidiContext::dir): Ditto.
      (WebCore::BidiContext::BidiContext): Ditto.
      * platform/text/BidiResolver.h:
      (WebCore::BidiStatus::BidiStatus): Ditto.
      (WebCore::BidiEmbedding::BidiEmbedding): Ditto.
      (WebCore::BidiEmbedding::direction): Ditto.
      (WebCore::BidiCharacterRun::BidiCharacterRun): Ditto.
      (WebCore::BidiResolver::BidiResolver): Ditto.
      (WebCore::BidiResolver::setLastDir): Ditto.
      (WebCore::BidiResolver::setLastStrongDir): Ditto.
      (WebCore::BidiResolver::setEorDir): Ditto.
      (WebCore::BidiResolver::dir): Ditto.
      (WebCore::BidiResolver::setDir): Ditto.
      (WebCore::BidiResolver::appendRun): Ditto.
      (WebCore::BidiResolver::embed): Ditto.
      (WebCore::BidiResolver::checkDirectionInLowerRaiseEmbeddingLevel): Ditto.
      (WebCore::BidiResolver::lowerExplicitEmbeddingLevel): Ditto.
      (WebCore::BidiResolver::raiseExplicitEmbeddingLevel): Ditto.
      (WebCore::BidiResolver::commitExplicitEmbedding): Ditto.
      (WebCore::BidiResolver::updateStatusLastFromCurrentDirection): Ditto.
      (WebCore::BidiResolver::createBidiRunsForLine): Ditto.
      
      * platform/text/SegmentedString.h:
      (WebCore::SegmentedString::advanceAndASSERTIgnoringCase): Use u_foldCase
      instead of WTF::Unicode::foldCase.
      
      * platform/text/TextBoundaries.cpp:
      (WebCore::findNextWordFromIndex): Use u_isalnum instead of
      WTF::Unicode::isAlphanumeric.
      
      * platform/text/TextBoundaries.h:
      (WebCore::requiresContextForWordBoundary): Use u_getIntPropertyValue directly
      instead of WTF::Unicode::requiresComplexContextForWordBreaking.
      
      * platform/text/mac/TextBoundaries.mm: Removed explicit use of WTF::Unicode,
      which was unneeded and also will no longer compile.
      
      * rendering/BidiRun.h:
      (WebCore::BidiRun::BidiRun): Use UCharDirection instead of WTF::Unicode::Direction.
      * rendering/InlineFlowBox.h: Ditto.
      * rendering/InlineIterator.h:
      (WebCore::embedCharFromDirection): Ditto.
      (WebCore::notifyObserverWillExitObject): Ditto.
      (WebCore::InlineIterator::direction): Ditto.
      (WebCore::IsolateTracker::embed): Ditto.
      (WebCore::InlineBidiResolver::appendRun): Ditto.
      
      * rendering/RenderBlock.cpp:
      (WebCore::isPunctuationForFirstLetter): Use U_GET_GC_MASK instead of
      WTF::Unicode::category.
      
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::determineDirectionality): Use u_charDirection instead of
      WTF::Unicode::direction.
      (WebCore::RenderBlockFlow::handleTrailingSpaces): Ditto.
      (WebCore::statusWithDirection): Ditto.
      (WebCore::LineBreaker::nextSegmentBreak): Use U_GET_GC_MASK instead of
      WTF::Unicode::category.
      
      * rendering/RenderListMarker.cpp:
      (WebCore::RenderListMarker::paint): Use u_charDirection instead of
      WTF::Unicode::direction.
      
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::adjustInnerStyle): Use UCharDirection instead of
      WTF::Unicode::Direction.
      
      * rendering/RenderText.cpp:
      (WebCore::makeCapitalized): Use u_totile instead of WTF::Unicode::toTitleCase.
      Also added a comment about the fact that we need to use u_strToTitle instead.
      
      * rendering/RootInlineBox.cpp:
      (WebCore::RootInlineBox::lineBreakBidiStatus): Use UCharDirection instead of
      WTF::Unicode::Direction.
      
      * svg/SVGFontData.cpp:
      (WebCore::SVGFontData::createStringWithMirroredCharacters): Use u_charMirror
      instead of WTF::Unicode::mirroredChar.
      
      * xml/XPathParser.cpp:
      (WebCore::XPath::charCat): Use U_GET_GC_MASK instead of WTF::Unicode::category.
      
      * platform/graphics/win/UniscribeController.cpp:
      (WebCore::UniscribeController::advance):
      * platform/win/PopupMenuWin.cpp:
      (WebCore::PopupMenuWin::paint):
      * platform/win/WebCoreTextRenderer.cpp:
      (WebCore::isOneLeftToRightRun):
      More of the same for Windows.
      
      Source/WTF:
      
      * wtf/text/StringHash.h:
      (WTF::CaseFoldingHash::foldCase): Use u_foldCase instead of WTF::Unicode::foldCase.
      (WTF::CaseFoldingHash::hash): Added an overload for a StringImpl& because why not.
      
      * wtf/text/StringImpl.cpp:
      (WTF::StringImpl::lower): Use u_tolower rather than WTF::Unicode::toLower. Also added
      an assertion to check that the lowercase version is also part of Latin-1. If this
      is not guaranteed it would be good to know in a debug build at least. Use u_strToLower
      rather than WTF::Unicode::toLower. Also removed #if USE(ICU_UNICODE) around the
      locale-specific version.
      (WTF::StringImpl::upper): Use u_toupper and u_strToUpper, as above.
      (WTF::StringImpl::foldCase): Use u_tolower and u_strFoldCase, as above.
      (WTF::equalIgnoringCase): Use u_foldCase instead of WTF::Unicode::foldCase.
      (WTF::StringImpl::defaultWritingDirection): Use u_charDirection and UCharDirection
      instead of WTF::Unicode::direction and WTF::Unicode::Direction.
      
      * wtf/text/StringImpl.h:
      (WTF::equalIgnoringCase): Use u_memcasecmp instead of WTF::Unicode::umemcasecmp.
      (WTF::isSpaceOrNewline): Use u_charDirection instead of WTF::Unicode::direction.
      
      * wtf/text/WTFString.h:
      (WTF::String::defaultWritingDirection): Use UCharDirection instead of WTF::Unicode::Direction.
      
      * wtf/unicode/icu/UnicodeIcu.h: Removed almost everything.
      
      * wtf/unicode/wchar/UnicodeWchar.cpp: Tried to do the right thing in this file, but
      I did not actually compile it. Also, the implementations here aren't really sufficient
      to make WebKit work broadly. There are many things that just aren't working with this
      implementation, such as parsing that uses u_charType to figure out which characters are valid.
      (unorm_normalize): Added.
      (u_charDirection): Added.
      (u_charMirror): Added.
      (u_charType): Added.
      (u_getCombiningClass): Added.
      (u_getIntPropertyValue): Added.
      (u_memcasecmp): Added.
      (convertWithFunction): Changed to work with ICU-style status code instead of error bool.
      (u_strFoldCase): Added.
      (u_strToLower): Added.
      (u_strToUpper): Added.
      * wtf/unicode/wchar/UnicodeWchar.h: Ditto. Later this file should just be named like the
      real ICU headers so the code can include it the same way it would ICU. But that will be
      in a future patch.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157330 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2eb5f4de
  7. 06 Oct, 2013 1 commit
  8. 05 Oct, 2013 1 commit
  9. 02 Oct, 2013 1 commit
  10. 30 Sep, 2013 1 commit
    • darin@apple.com's avatar
      Use RenderElement instead of RenderObject in many places · 8cdf7124
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122078
      
      Reviewed by Andreas Kling.
      
      Source/ThirdParty/ANGLE:
      
      * ANGLE.xcodeproj/project.pbxproj: Let Xcode do its thing to this file.
      
      Source/WebCore:
      
      * WebCore.exp.in: Updated for name changes.
      
      * dom/ContainerNode.h: Moved renderer() here from Element.
      * dom/Element.h: Moved renderer() from here to ContainerNode.
      * render/RenderElement.h: Moved renderer() from Element to ContainerNode.
      
      * accessibility/AccessibilityImageMapLink.cpp:
      (WebCore::AccessibilityImageMapLink::imageMapLinkRenderer):
      (WebCore::AccessibilityImageMapLink::detachFromParent):
      (WebCore::AccessibilityImageMapLink::elementPath):
      (WebCore::AccessibilityImageMapLink::elementRect):
      * accessibility/AccessibilityImageMapLink.h:
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
      * bindings/objc/DOM.mm:
      (-[DOMElement image]):
      (-[DOMElement _font]):
      (-[DOMElement _imageTIFFRepresentation]):
      * css/CSSCanvasValue.cpp:
      (WebCore::CSSCanvasValue::canvasChanged):
      (WebCore::CSSCanvasValue::canvasResized):
      (WebCore::CSSCanvasValue::canvasDestroyed):
      (WebCore::CSSCanvasValue::fixedSize):
      (WebCore::CSSCanvasValue::image):
      * css/CSSCanvasValue.h:
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::computeRenderStyleForProperty):
      * css/CSSCrossfadeValue.cpp:
      (WebCore::subimageKnownToBeOpaque):
      (WebCore::CSSCrossfadeValue::fixedSize):
      (WebCore::CSSCrossfadeValue::knownToBeOpaque):
      (WebCore::CSSCrossfadeValue::image):
      (WebCore::CSSCrossfadeValue::crossfadeChanged):
      * css/CSSCrossfadeValue.h:
      * css/CSSFilterImageValue.cpp:
      (WebCore::CSSFilterImageValue::fixedSize):
      (WebCore::CSSFilterImageValue::knownToBeOpaque):
      (WebCore::CSSFilterImageValue::image):
      (WebCore::CSSFilterImageValue::filterImageChanged):
      * css/CSSFilterImageValue.h:
      * css/CSSFontSelector.cpp:
      * css/CSSGradientValue.cpp:
      (WebCore::CSSGradientValue::image):
      (WebCore::CSSGradientValue::addStops):
      (WebCore::CSSGradientValue::knownToBeOpaque):
      (WebCore::CSSLinearGradientValue::createGradient):
      (WebCore::CSSRadialGradientValue::createGradient):
      * css/CSSGradientValue.h:
      (WebCore::CSSGradientValue::fixedSize):
      * css/CSSImageGeneratorValue.cpp:
      (WebCore::CSSImageGeneratorValue::addClient):
      (WebCore::CSSImageGeneratorValue::removeClient):
      (WebCore::CSSImageGeneratorValue::image):
      (WebCore::CSSImageGeneratorValue::fixedSize):
      (WebCore::CSSImageGeneratorValue::knownToBeOpaque):
      * css/CSSImageGeneratorValue.h:
      (WebCore::CSSImageGeneratorValue::clients):
      * css/CSSImageValue.cpp:
      (WebCore::CSSImageValue::knownToBeOpaque):
      * css/CSSImageValue.h:
      * css/DeprecatedStyleBuilder.cpp:
      * dom/DocumentMarkerController.cpp:
      (WebCore::DocumentMarkerController::removeMarkersFromList):
      (WebCore::DocumentMarkerController::repaintMarkers):
      * dom/Element.cpp:
      (WebCore::localZoomForRenderer):
      (WebCore::adjustForLocalZoom):
      (WebCore::Element::offsetParent):
      (WebCore::Element::updateExistingPseudoElement):
      * dom/ElementRareData.h:
      (WebCore::ElementRareData::create):
      (WebCore::ElementRareData::ElementRareData):
      * dom/Node.cpp:
      (WebCore::Node::ensureRareData):
      * editing/DeleteButtonController.cpp:
      (WebCore::isDeletableElement):
      * editing/Editor.cpp:
      (WebCore::Editor::hasBidiSelection):
      (WebCore::Editor::baseWritingDirectionForSelectionStart):
      * editing/EditorCommand.cpp:
      (WebCore::verticalScrollDistance):
      * editing/htmlediting.cpp:
      (WebCore::directionOfEnclosingBlock):
      * editing/ios/EditorIOS.mm:
      (WebCore::Editor::fontForSelection):
      (WebCore::getImage):
      * editing/mac/EditorMac.mm:
      (WebCore::Editor::fontForSelection):
      (WebCore::getImage):
      * editing/markup.cpp:
      * html/HTMLAreaElement.cpp:
      (WebCore::HTMLAreaElement::computePath):
      (WebCore::HTMLAreaElement::computeRect):
      (WebCore::HTMLAreaElement::setFocus):
      * html/HTMLAreaElement.h:
      * html/HTMLCanvasElement.cpp:
      (WebCore::HTMLCanvasElement::reset):
      * html/HTMLElement.cpp:
      (WebCore::HTMLElement::setInnerText):
      * html/HTMLFormControlElement.cpp:
      (WebCore::updateFromElementCallback):
      * html/HTMLFormElement.cpp:
      (WebCore::HTMLFormElement::rendererIsNeeded):
      * html/HTMLFrameOwnerElement.h:
      * html/HTMLImageElement.cpp:
      (WebCore::HTMLImageElement::x):
      (WebCore::HTMLImageElement::y):
      (WebCore::HTMLImageElement::willRespondToMouseClickEvents):
      * html/HTMLMapElement.cpp:
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::defaultEventHandler):
      * html/HTMLMeterElement.cpp:
      (WebCore::HTMLMeterElement::renderMeter):
      * html/HTMLOptionElement.cpp:
      (WebCore::HTMLOptionElement::didRecalcStyle):
      * html/HTMLPlugInElement.cpp:
      (WebCore::HTMLPlugInElement::willRespondToMouseClickEvents):
      (WebCore::HTMLPlugInElement::defaultEventHandler):
      (WebCore::HTMLPlugInElement::isKeyboardFocusable):
      * html/HTMLPlugInImageElement.cpp:
      (WebCore::HTMLPlugInImageElement::defaultEventHandler):
      * html/HTMLProgressElement.cpp:
      (WebCore::HTMLProgressElement::renderProgress):
      * html/HTMLSelectElement.cpp:
      (WebCore::HTMLSelectElement::scrollToSelection):
      (WebCore::HTMLSelectElement::setOptionsChangedOnRenderer):
      (WebCore::HTMLSelectElement::selectOption):
      * html/HTMLTableCellElement.cpp:
      (WebCore::HTMLTableCellElement::cellAbove):
      * html/HTMLTextFormControlElement.cpp:
      (WebCore::hasVisibleTextArea):
      (WebCore::HTMLTextFormControlElement::setSelectionRange):
      * html/InputType.h:
      * html/parser/HTMLResourcePreloader.cpp:
      * html/shadow/MediaControlElementTypes.cpp:
      (WebCore::MediaControlElement::setDisplayType):
      * html/shadow/MediaControlElements.cpp:
      (WebCore::MediaControlPanelElement::startDrag):
      (WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):
      * html/shadow/MeterShadowElement.cpp:
      (WebCore::MeterShadowElement::rendererIsNeeded):
      (WebCore::MeterInnerElement::rendererIsNeeded):
      * inspector/InspectorOverlay.cpp:
      * inspector/InspectorTimelineAgent.cpp:
      * inspector/InspectorTimelineAgent.h:
      * loader/ImageLoader.cpp:
      (WebCore::ImageLoader::renderImageResource):
      * loader/cache/CachedImage.cpp:
      (WebCore::CachedImage::currentFrameKnownToBeOpaque):
      * loader/cache/CachedImage.h:
      * mathml/MathMLElement.cpp:
      * page/ContextMenuController.cpp:
      * page/DragController.cpp:
      (WebCore::DragController::draggableElement):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::EventHandler):
      (WebCore::EventHandler::clear):
      (WebCore::EventHandler::startPanScrolling):
      (WebCore::EventHandler::autoscrollRenderer):
      (WebCore::EventHandler::scrollOverflow):
      (WebCore::EventHandler::logicalScrollOverflow):
      (WebCore::EventHandler::subframeForTargetNode):
      (WebCore::EventHandler::selectCursor):
      (WebCore::layerForNode):
      (WebCore::EventHandler::handleWheelEvent):
      (WebCore::EventHandler::clearGestureScrollNodes):
      * page/EventHandler.h:
      * page/FocusController.cpp:
      * page/Frame.cpp:
      (WebCore::Frame::ownerRenderer):
      (WebCore::Frame::visiblePositionForPoint):
      (WebCore::Frame::nodeImage):
      * page/FrameView.cpp:
      (WebCore::FrameView::applyOverflowToViewport):
      (WebCore::FrameView::applyPaginationToViewport):
      (WebCore::FrameView::calculateScrollbarModesForLayout):
      (WebCore::FrameView::isEnclosedInCompositingLayer):
      (WebCore::FrameView::embeddedContentBox):
      (WebCore::FrameView::addSlowRepaintObject):
      (WebCore::FrameView::removeSlowRepaintObject):
      (WebCore::FrameView::addViewportConstrainedObject):
      (WebCore::FrameView::removeViewportConstrainedObject):
      (WebCore::FrameView::scrollContentsFastPath):
      (WebCore::FrameView::repaintSlowRepaintObjects):
      (WebCore::FrameView::setViewportConstrainedObjectsNeedLayout):
      (WebCore::FrameView::updateOverflowStatus):
      (WebCore::FrameView::updateScrollCorner):
      (WebCore::FrameView::paintContents):
      (WebCore::FrameView::convertFromRenderer):
      (WebCore::FrameView::convertToRenderer):
      * page/FrameView.h:
      * page/PageSerializer.cpp:
      (WebCore::PageSerializer::addImageToResources):
      * page/PageSerializer.h:
      * page/animation/AnimationBase.cpp:
      (WebCore::AnimationBase::AnimationBase):
      (WebCore::AnimationBase::updateStateMachine):
      * page/animation/AnimationBase.h:
      (WebCore::AnimationBase::renderer):
      * page/animation/AnimationController.cpp:
      (WebCore::AnimationControllerPrivate::ensureCompositeAnimation):
      (WebCore::AnimationControllerPrivate::clear):
      (WebCore::AnimationControllerPrivate::updateAnimations):
      (WebCore::AnimationControllerPrivate::updateAnimationTimerForRenderer):
      (WebCore::AnimationControllerPrivate::isRunningAnimationOnRenderer):
      (WebCore::AnimationControllerPrivate::isRunningAcceleratedAnimationOnRenderer):
      (WebCore::AnimationControllerPrivate::suspendAnimationsForDocument):
      (WebCore::AnimationControllerPrivate::resumeAnimationsForDocument):
      (WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
      (WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
      (WebCore::AnimationControllerPrivate::getAnimatedStyleForRenderer):
      (WebCore::AnimationControllerPrivate::numberOfActiveAnimations):
      (WebCore::AnimationController::cancelAnimations):
      (WebCore::AnimationController::updateAnimations):
      (WebCore::AnimationController::getAnimatedStyleForRenderer):
      (WebCore::AnimationController::notifyAnimationStarted):
      (WebCore::AnimationController::pauseAnimationAtTime):
      (WebCore::AnimationController::pauseTransitionAtTime):
      (WebCore::AnimationController::isRunningAnimationOnRenderer):
      (WebCore::AnimationController::isRunningAcceleratedAnimationOnRenderer):
      * page/animation/AnimationController.h:
      * page/animation/AnimationControllerPrivate.h:
      * page/animation/CSSPropertyAnimation.cpp:
      (WebCore::crossfadeBlend):
      * page/animation/CompositeAnimation.cpp:
      (WebCore::CompositeAnimation::updateTransitions):
      (WebCore::CompositeAnimation::updateKeyframeAnimations):
      (WebCore::CompositeAnimation::animate):
      * page/animation/CompositeAnimation.h:
      * page/animation/ImplicitAnimation.cpp:
      (WebCore::ImplicitAnimation::ImplicitAnimation):
      (WebCore::ImplicitAnimation::animate):
      (WebCore::ImplicitAnimation::pauseAnimation):
      (WebCore::ImplicitAnimation::sendTransitionEvent):
      * page/animation/ImplicitAnimation.h:
      (WebCore::ImplicitAnimation::create):
      * page/animation/KeyframeAnimation.cpp:
      (WebCore::KeyframeAnimation::KeyframeAnimation):
      (WebCore::KeyframeAnimation::animate):
      (WebCore::KeyframeAnimation::pauseAnimation):
      (WebCore::KeyframeAnimation::endAnimation):
      (WebCore::KeyframeAnimation::sendAnimationEvent):
      * page/animation/KeyframeAnimation.h:
      * page/mac/EventHandlerMac.mm:
      (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
      (WebCore::EventHandler::passSubframeEventToSubframe):
      * page/mac/FrameSnapshottingMac.mm:
      (WebCore::snapshotDragImage):
      * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
      (WebCore::MediaPlayerPrivateQTKit::paint):
      * rendering/CounterNode.cpp:
      (WebCore::CounterNode::CounterNode):
      (WebCore::CounterNode::create):
      * rendering/CounterNode.h:
      (WebCore::CounterNode::owner):
      * rendering/FilterEffectRenderer.cpp:
      (WebCore::FilterEffectRenderer::buildReferenceFilter):
      (WebCore::FilterEffectRenderer::build):
      * rendering/FilterEffectRenderer.h:
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestResult::spellingToolTip):
      (WebCore::HitTestResult::title):
      (WebCore::HitTestResult::innerTextIfTruncated):
      (WebCore::HitTestResult::image):
      * rendering/LayoutRepainter.cpp:
      (WebCore::LayoutRepainter::LayoutRepainter):
      * rendering/LayoutRepainter.h:
      * rendering/LayoutState.h:
      (WebCore::LayoutState::LayoutState):
      * rendering/LineWidth.h:
      * rendering/LogicalSelectionOffsetCaches.h:
      (WebCore::isContainingBlockCandidateForAbsolutelyPositionedObject):
      (WebCore::isNonRenderBlockInline):
      (WebCore::containingBlockForFixedPosition):
      (WebCore::containingBlockForAbsolutePosition):
      (WebCore::containingBlockForObjectInFlow):
      (WebCore::LogicalSelectionOffsetCaches::LogicalSelectionOffsetCaches):
      * rendering/PaintInfo.h:
      (WebCore::PaintInfo::PaintInfo):
      (WebCore::PaintInfo::updateSubtreePaintRootForChildren):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::paintFillLayers):
      (WebCore::RenderBox::paintFillLayer):
      * rendering/RenderBox.h:
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::paintFillLayerExtended):
      (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
      * rendering/RenderBoxModelObject.h:
      * rendering/RenderCounter.cpp:
      (WebCore::nextInPreOrder):
      (WebCore::planCounter):
      (WebCore::makeCounterNode):
      (WebCore::RenderCounter::originalText):
      * rendering/RenderElement.cpp:
      (WebCore::RenderElement::~RenderElement):
      (WebCore::RenderElement::insertChildInternal):
      (WebCore::RenderElement::removeChildInternal):
      (WebCore::RenderElement::willBeDestroyed):
      (WebCore::RenderElement::rendererForRootBackground):
      * rendering/RenderImageResource.cpp:
      (WebCore::RenderImageResource::initialize):
      * rendering/RenderImageResource.h:
      * rendering/RenderImageResourceStyleImage.cpp:
      (WebCore::RenderImageResourceStyleImage::initialize):
      * rendering/RenderImageResourceStyleImage.h:
      (WebCore::RenderImageResourceStyleImage::create):
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame):
      (WebCore::RenderLayerCompositor::requiresCompositingLayer):
      (WebCore::RenderLayerCompositor::canBeComposited):
      (WebCore::RenderLayerCompositor::requiresOwnBackingStore):
      (WebCore::RenderLayerCompositor::reasonsForCompositing):
      (WebCore::RenderLayerCompositor::requiresCompositingForTransform):
      (WebCore::RenderLayerCompositor::requiresCompositingForVideo):
      (WebCore::RenderLayerCompositor::requiresCompositingForCanvas):
      (WebCore::RenderLayerCompositor::requiresCompositingForPlugin):
      (WebCore::RenderLayerCompositor::requiresCompositingForFrame):
      (WebCore::RenderLayerCompositor::requiresCompositingForAnimation):
      (WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason):
      (WebCore::RenderLayerCompositor::requiresCompositingForFilters):
      (WebCore::RenderLayerCompositor::requiresCompositingForBlending):
      (WebCore::RenderLayerCompositor::requiresCompositingForPosition):
      (WebCore::RenderLayerCompositor::isRunningAcceleratedTransformAnimation):
      * rendering/RenderLayerCompositor.h:
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::containingBlock):
      (WebCore::mustRepaintFillLayers):
      (WebCore::RenderObject::borderImageIsLoadedAndCanBeRendered):
      (WebCore::RenderObject::willBeDestroyed):
      * rendering/RenderScrollbarPart.cpp:
      (WebCore::RenderScrollbarPart::rendererOwningScrollbar):
      * rendering/RenderScrollbarPart.h:
      * rendering/RenderTableCell.cpp:
      (WebCore::RenderTableCell::paintBackgroundsBehindCell):
      * rendering/RenderTableCell.h:
      * rendering/RenderView.cpp:
      (WebCore::RenderView::RenderView):
      * rendering/style/FillLayer.cpp:
      (WebCore::FillLayer::hasOpaqueImage):
      * rendering/style/FillLayer.h:
      * rendering/style/KeyframeList.h:
      (WebCore::KeyframeList::KeyframeList):
      * rendering/style/StyleCachedImage.cpp:
      (WebCore::StyleCachedImage::imageSize):
      (WebCore::StyleCachedImage::computeIntrinsicDimensions):
      (WebCore::StyleCachedImage::setContainerSizeForRenderer):
      (WebCore::StyleCachedImage::addClient):
      (WebCore::StyleCachedImage::removeClient):
      (WebCore::StyleCachedImage::image):
      (WebCore::StyleCachedImage::knownToBeOpaque):
      * rendering/style/StyleCachedImage.h:
      * rendering/style/StyleCachedImageSet.cpp:
      (WebCore::StyleCachedImageSet::imageSize):
      (WebCore::StyleCachedImageSet::computeIntrinsicDimensions):
      (WebCore::StyleCachedImageSet::setContainerSizeForRenderer):
      (WebCore::StyleCachedImageSet::addClient):
      (WebCore::StyleCachedImageSet::removeClient):
      (WebCore::StyleCachedImageSet::image):
      (WebCore::StyleCachedImageSet::knownToBeOpaque):
      * rendering/style/StyleCachedImageSet.h:
      * rendering/style/StyleGeneratedImage.cpp:
      (WebCore::StyleGeneratedImage::imageSize):
      (WebCore::StyleGeneratedImage::computeIntrinsicDimensions):
      (WebCore::StyleGeneratedImage::addClient):
      (WebCore::StyleGeneratedImage::removeClient):
      (WebCore::StyleGeneratedImage::image):
      (WebCore::StyleGeneratedImage::knownToBeOpaque):
      * rendering/style/StyleGeneratedImage.h:
      * rendering/style/StyleImage.h:
      (WebCore::StyleImage::imagesEquivalent):
      * rendering/style/StylePendingImage.h:
      (WebCore::StylePendingImage::cssImageValue):
      (WebCore::StylePendingImage::cssImageGeneratorValue):
      (WebCore::StylePendingImage::cssCursorImageValue):
      (WebCore::StylePendingImage::cssImageSetValue):
      (WebCore::StylePendingImage::computeIntrinsicDimensions):
      * testing/Internals.cpp:
      (WebCore::Internals::boundingBox):
      (WebCore::Internals::isSelectPopupVisible):
      (WebCore::Internals::isPluginUnavailabilityIndicatorObscured):
      Use RenderElement instead of RenderObject where it was easy to do so.
      For local variables holding the return value of renderer() functions,
      use auto instead, so the most-specific possible type will be used,
      without having to figure out what that is in each case. Also use some
      more OVERRIDE and FINAL and use nullptr instead of 0. And replace some
      cryptic short local variable names with words.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8cdf7124
  11. 28 Sep, 2013 1 commit
    • darin@apple.com's avatar
      Add Frame::mainFrame and Frame::isMainFrame · 0e83ab12
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122064
      
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      * WebCore.exp.in: Removed exports of FrameView::isMainFrameView and
      Page::frameIsMainFrame. Since the new isMainFrame function is inline, it
      does not need to be exported.
      
      * history/PageCache.cpp:
      (WebCore::PageCache::markPagesForFullStyleRecalc):
      (WebCore::PageCache::markPagesForDeviceScaleChanged):
      These two were the only functions I found that really wanted the equivalent
      of Page::frameIsMainFrame, so wrote it out here instead of using a function
      call.
      
      * inspector/InspectorAgent.cpp: Removed the unused isMainResourceLoader function.
      * inspector/InspectorAgent.h: Removed declarations of a few nonexistent or
      unused private member functions. Also removed the InjectedScriptForOriginMap
      typedef: It's mor readable to use the type directly
      
      * loader/FrameLoader.h: Removed isLoadingMainFrame. It's not better than
      calling frame().isMainFrame() directly.
      
      * page/Frame.cpp:
      (WebCore::Frame::Frame): Initialize m_mainFrame and call selfOnlyRef, keeping
      the MainFrame alive as long as any of its subframes is alive.
      (WebCore::Frame::~Frame): Call selfOnlyDeref.
      (WebCore::Frame::createView): Use isMainFrame.
      (WebCore::Frame::setPageAndTextZoomFactors): Ditto.
      
      * page/Frame.h: Added Frame::mainFrame, Frame::isMainFrame, and Frame::m_mainFrame.
      
      * page/FrameView.h: Removed the isMainFrameView function. It's not better than
      calling frame().isMainFrame() directly.
      
      * page/MainFrame.cpp:
      (WebCore::MainFrame::MainFrame): Initialize m_selfOnlyRefCount to 0.
      (WebCore::MainFrame::selfOnlyRef): Added.
      (WebCore::MainFrame::selfOnlyDeref): Added.
      (WebCore::MainFrame::dropChildren): Added. Called when the self-only reference
      count reaches 0 to avoid a reference cycle with subframes.
      
      * page/MainFrame.h: Added new data members as mentioned above. Also, the
      definition of the Frame::isMainFrame inline function goes here, since it can't
      compile without the MainFrame class definition. This means that callers of
      isMainFrame need to include MainFrame.h, which seems reasonable and is easy
      to do.
      
      * page/Page.cpp:
      * page/Page.h: Added assertion to Page::mainFrame since it returns a reference.
      Removed Page::frameIsMainFrame since it's not better than calling isMainFrame
      on the frame.
      
      * dom/Document.cpp:
      (WebCore::Document::setVisualUpdatesAllowed):
      (WebCore::Document::didBecomeCurrentDocumentInFrame):
      (WebCore::Document::updateViewportArguments):
      (WebCore::Document::setInPageCache):
      (WebCore::Document::ensurePlugInsInjectedScript):
      * history/CachedFrame.cpp:
      (WebCore::CachedFrame::CachedFrame):
      * history/CachedPage.cpp:
      (WebCore::CachedPage::restore):
      * html/HTMLPlugInImageElement.cpp:
      (WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn):
      * html/ImageDocument.cpp:
      (WebCore::ImageDocument::shouldShrinkToFit):
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::didClearWindowObjectInWorld):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore::InspectorInstrumentation::didCommitLoadImpl):
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
      (WebCore::InspectorPageAgent::frameNavigated):
      * loader/DocumentLoader.cpp:
      (WebCore::DocumentLoader::willSendRequest):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::transitionToCommitted):
      (WebCore::FrameLoader::prepareForCachedPageRestore):
      (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
      (WebCore::FrameLoader::didLayout):
      (WebCore::FrameLoader::checkLoadComplete):
      (WebCore::FrameLoader::addExtraFieldsToRequest):
      (WebCore::FrameLoader::loadResourceSynchronously):
      (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
      (WebCore::FrameLoader::dispatchDidCommitLoad):
      (WebCore::FrameLoader::loadProgressingStatusChanged):
      * loader/HistoryController.cpp:
      (WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
      (WebCore::HistoryController::restoreScrollPositionAndViewState):
      (WebCore::HistoryController::updateForCommit):
      (WebCore::HistoryController::updateForSameDocumentNavigation):
      (WebCore::HistoryController::updateBackForwardListClippedAtTarget):
      (WebCore::HistoryController::pushState):
      * loader/icon/IconController.cpp:
      (WebCore::IconController::startLoader):
      * page/AutoscrollController.cpp:
      (WebCore::AutoscrollController::stopAutoscrollTimer):
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::populate):
      * page/DOMWindow.cpp:
      (WebCore::allowsBeforeUnloadListeners):
      (WebCore::DOMWindow::focus):
      (WebCore::DOMWindow::blur):
      (WebCore::DOMWindow::close):
      (WebCore::DOMWindow::allowedToChangeWindowGeometry):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::hitTestResultAtPoint):
      (WebCore::EventHandler::selectCursor):
      (WebCore::EventHandler::handleMousePressEvent):
      (WebCore::EventHandler::keyEvent):
      * page/FrameTree.cpp:
      (WebCore::FrameTree::find):
      (WebCore::FrameTree::traverseNextWithWrap):
      * page/FrameView.cpp:
      (WebCore::FrameView::FrameView):
      (WebCore::FrameView::setFrameRect):
      (WebCore::FrameView::createScrollbar):
      (WebCore::FrameView::applyOverflowToViewport):
      (WebCore::FrameView::setHeaderHeight):
      (WebCore::FrameView::setFooterHeight):
      (WebCore::FrameView::minimumScrollPosition):
      (WebCore::FrameView::maximumScrollPosition):
      (WebCore::FrameView::shouldUpdateFixedElementsAfterScrolling):
      (WebCore::FrameView::beginDeferredRepaints):
      (WebCore::FrameView::endDeferredRepaints):
      (WebCore::FrameView::performPostLayoutTasks):
      (WebCore::FrameView::sendResizeEventIfNeeded):
      (WebCore::FrameView::pagination):
      (WebCore::FrameView::visibleContentScaleFactor):
      (WebCore::FrameView::setVisibleScrollerThumbRect):
      (WebCore::FrameView::scrollbarStyleChanged):
      (WebCore::FrameView::paintScrollCorner):
      (WebCore::FrameView::paintScrollbar):
      (WebCore::FrameView::paintOverhangAreas):
      * page/scrolling/ScrollingCoordinator.cpp:
      (WebCore::ScrollingCoordinator::coordinatesScrollingForFrameView):
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::RenderLayerBacking):
      Use the new functions where possible instead of Page::frameIsMainFrame,
      Page::mainFrame, FrameLoader::isLoadingMainFrame, and FrameView::isMainFrameView.
      
      Source/WebKit/blackberry:
      
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
      Call isMainFrame.
      
      Source/WebKit/efl:
      
      * WebCoreSupport/FrameLoaderClientEfl.cpp:
      (WebCore::FrameLoaderClientEfl::dispatchWillSendRequest):
      (WebCore::FrameLoaderClientEfl::assignIdentifierToInitialRequest):
      (WebCore::FrameLoaderClientEfl::updateGlobalHistory):
      Call isMainFrame.
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      (WebKit::FrameLoaderClient::assignIdentifierToInitialRequest):
      Call isMainFrame.
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (WebFrameLoaderClient::canHandleRequest):
      (WebFrameLoaderClient::transitionToCommittedForNewPage):
      * WebView/WebFrameView.mm:
      (-[WebFrameView _install]):
      Call isMainFrame.
      
      Source/WebKit2:
      
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
      (WebKit::TiledCoreAnimationDrawingArea::shouldUseTiledBackingForFrameView):
      Call isMainFrame.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e83ab12
  12. 27 Sep, 2013 2 commits
    • darin@apple.com's avatar
      rename KURL to URL · 5ffbb5c7
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=16214
      
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      * many files: Renamed, using script.
      
      Source/WebKit:
      
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
      Let the script to try to rename here.
      
      Source/WebKit/blackberry:
      
      * many files: Renamed, using script.
      
      Source/WebKit/efl:
      
      * many files: Renamed, using script.
      
      Source/WebKit/gtk:
      
      * many files: Renamed, using script.
      
      Source/WebKit/mac:
      
      * many files: Renamed, using script.
      
      Source/WebKit/qt:
      
      * many files: Renamed, using script.
      
      Source/WebKit/win:
      
      * many files: Renamed, using script.
      
      Source/WebKit/wince:
      
      * many files: Renamed, using script.
      
      Source/WebKit2:
      
      * many files: Renamed, using script.
      
      Tools:
      
      * many files: Renamed, using script.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ffbb5c7
    • darin@apple.com's avatar
      Add empty MainFrame class · ade301ac
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121770
      
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      For now, MainFrame simply derives from Frame and adds nothing.
      Next, we will make each Frame point back to its MainFrame.
      
      * CMakeLists.txt: Added MainFrame.cpp/h.
      * GNUmakefile.list.am: Ditto.
      * Target.pri: Ditto.
      * WebCore.exp.in: Ditto.
      * WebCore.vcxproj/WebCore.vcxproj: Ditto.
      * WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
      * WebCore.xcodeproj/project.pbxproj: Ditto.
      
      * page/Frame.cpp:
      (WebCore::Frame::Frame): Use references instead of pointers for constructor.
      (WebCore::Frame::create): Pass references instead of pointers to constructor.
      * page/Frame.h: Made constructor protected instead of private, and marked
      destructor virtual explicitly. Also marked virtual functions OVERRIDE and FINAL.
      
      * page/MainFrame.cpp: Added.
      * page/MainFrame.h: Added.
      
      * page/Page.cpp:
      (WebCore::Page::Page): Use MainFrame::create instead of Frame::create.
      (WebCore::Page::frameIsMainFrame): Moved here, no longer inline.
      (WebCore::Page::renderTreeSize): Use const Frame* instead of Frame*.
      (WebCore::Page::checkSubframeCountConsistency): Ditto.
      * page/Page.h: Changed mainFrame() to return MainFrame& and m_mainFrame to
      be a RefPtr<MainFrame>.
      
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      * bindings/js/PageScriptDebugServer.cpp:
      * bindings/js/ScriptProfiler.cpp:
      * bindings/js/ScriptState.cpp:
      * css/MediaQueryEvaluator.cpp:
      * dom/Document.cpp:
      * history/CachedFrame.cpp:
      * history/CachedPage.cpp:
      * history/PageCache.cpp:
      * html/HTMLPlugInImageElement.cpp:
      * inspector/InspectorAgent.cpp:
      * inspector/InspectorCanvasAgent.cpp:
      * inspector/InspectorClient.cpp:
      * inspector/InspectorDOMAgent.cpp:
      * inspector/InspectorFrontendClientLocal.cpp:
      * inspector/InspectorFrontendHost.cpp:
      * inspector/InspectorInputAgent.cpp:
      * inspector/InspectorInstrumentation.cpp:
      * inspector/InspectorOverlay.cpp:
      * inspector/InspectorPageAgent.cpp:
      * inspector/PageRuntimeAgent.cpp:
      * loader/FrameLoader.cpp:
      * loader/HistoryController.cpp:
      * loader/archive/mhtml/MHTMLArchive.cpp:
      * page/AutoscrollController.cpp:
      * page/Chrome.cpp:
      * page/ContextMenuController.cpp:
      * page/DOMWindow.cpp:
      * page/DragController.cpp:
      * page/EventHandler.cpp:
      * page/FocusController.cpp:
      * page/FrameTree.cpp:
      * page/FrameView.cpp:
      * page/GestureTapHighlighter.cpp:
      * page/PageGroup.cpp:
      * page/PageGroupLoadDeferrer.cpp:
      * page/PageSerializer.cpp:
      * page/PageThrottler.cpp:
      * page/Settings.cpp:
      * page/SpatialNavigation.cpp:
      * page/mac/DragControllerMac.mm:
      * page/mac/PageMac.cpp:
      * page/scrolling/ScrollingCoordinator.cpp:
      * page/scrolling/mac/ScrollingCoordinatorMac.mm:
      * platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
      * plugins/DOMMimeType.cpp:
      * storage/StorageEventDispatcher.cpp:
      * svg/graphics/SVGImage.cpp:
      * testing/InternalSettings.cpp:
      * testing/Internals.cpp:
      Include MainFrame.h instead of Frame.h as needed.
      
      Source/WebKit/efl:
      
      * WebCoreSupport/AcceleratedCompositingContextEfl.cpp:
      * WebCoreSupport/InspectorClientEfl.cpp:
      * ewk/ewk_view.cpp:
      Include MainFrame.h instead of Frame.h as needed.
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/AcceleratedCompositingContextGL.cpp:
      * WebCoreSupport/ChromeClientGtk.cpp:
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      * WebCoreSupport/GtkAdjustmentWatcher.cpp:
      * webkit/webkitwebframe.cpp:
      * webkit/webkitwebview.cpp:
      * webkit/webkitviewportattributes.cpp:
      Include MainFrame.h instead of Frame.h as needed.
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebDragClient.mm:
      * WebCoreSupport/WebInspectorClient.mm:
      * WebCoreSupport/WebPlatformStrategies.mm:
      * WebView/WebFrame.mm:
      * WebView/WebHTMLView.mm:
      * WebView/WebView.mm:
      Include MainFrame.h instead of Frame.h as needed.
      
      Source/WebKit/qt:
      
      * Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:
      * Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:
      * Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp:
      * Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      * Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:
      * Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp:
      Include MainFrame.h instead of Frame.h as needed.
      
      Source/WebKit/win:
      
      * win/WebCoreSupport/WebDragClient.cpp:
      * win/WebCoreSupport/WebContextMenuClient.cpp:
      * win/WebDropSource.cpp:
      * win/WebFrame.cpp:
      * win/WebView.cpp:
      Include MainFrame.h instead of Frame.h as needed.
      
      Source/WebKit2:
      
      * WebProcess/FullScreen/WebFullScreenManager.cpp:
      * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      * WebProcess/Plugins/PluginView.cpp:
      * WebProcess/Storage/StorageAreaMap.cpp:
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
      * WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
      * WebProcess/WebPage/FindController.cpp:
      * WebProcess/WebPage/PageOverlay.cpp:
      * WebProcess/WebPage/WebInspector.cpp:
      * WebProcess/WebPage/WebPage.cpp:
      * WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp:
      * WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
      * WebProcess/WebPage/mac/LayerTreeHostMac.mm:
      * WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
      * WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:
      * WebProcess/WebPage/mac/WebPageMac.mm:
      Include MainFrame.h instead of Frame.h as needed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156543 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ade301ac
  13. 13 Sep, 2013 1 commit
    • weinig@apple.com's avatar
      ContextMenuController should hold onto a Page& · d376cafe
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121320
      
      Reviewed by Anders Carlsson.
      
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::ContextMenuController):
      (WebCore::ContextMenuController::~ContextMenuController):
      (WebCore::ContextMenuController::showContextMenu):
      (WebCore::ContextMenuController::contextMenuItemSelected):
      (WebCore::ContextMenuController::checkOrEnableIfNeeded):
      (WebCore::ContextMenuController::showContextMenuAt):
      * page/ContextMenuController.h:
      Store the Page and ContextMenuClient as references.
      
      * page/Page.cpp:
      (WebCore::Page::Page):
      Pass the Page and ContextMenuClient as references and switch to using createOwned<>().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155723 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d376cafe
  14. 11 Sep, 2013 1 commit
  15. 01 Sep, 2013 1 commit
  16. 30 Aug, 2013 1 commit
  17. 27 Aug, 2013 1 commit
  18. 22 Aug, 2013 1 commit
  19. 20 Aug, 2013 1 commit
    • rniwa@webkit.org's avatar
      <https://webkit.org/b/120049> Delete code for Snow Leopard · 3feac41c
      rniwa@webkit.org authored
      Reviewed by Benjamin Poulain.
      
      Source/WebCore:
      
      Delete all the code for Mac OS 10.6. Nobody builds on Snow Leopard at this point.
      
      * WebCore.exp.in:
      * WebCore.xcodeproj/project.pbxproj:
      * editing/mac/EditorMac.mm:
      (WebCore::Editor::pasteWithPasteboard):
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::populate):
      * platform/LocalizedStrings.cpp:
      (WebCore::truncatedStringForLookupMenuItem):
      (WebCore::contextMenuItemTagSearchWeb):
      (WebCore::contextMenuItemTagLookUpInDictionary):
      * platform/MemoryPressureHandler.cpp:
      * platform/audio/mac/AudioBusMac.mm:
      (WebCore::AudioBus::loadPlatformResource):
      * platform/graphics/ca/GraphicsLayerCA.cpp:
      (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
      * platform/graphics/ca/PlatformCALayer.h:
      * platform/graphics/ca/mac/PlatformCALayerMac.mm:
      (PlatformCALayer::acceleratesDrawing):
      (PlatformCALayer::setAcceleratesDrawing):
      (PlatformCALayer::contentsScale):
      (PlatformCALayer::setContentsScale):
      (PlatformCALayer::synchronouslyDisplayTilesInRect):
      * platform/graphics/ca/mac/TileController.mm:
      (WebCore::TileController::setScale):
      (WebCore::TileController::setAcceleratesDrawing):
      (WebCore::TileController::createTileLayer):
      * platform/graphics/cg/ImageBufferDataCG.cpp:
      (WebCore::ImageBufferData::getData):
      (WebCore::ImageBufferData::putData):
      * platform/graphics/cg/ImageBufferDataCG.h:
      * platform/graphics/cg/PathCG.cpp:
      (WebCore::Path::platformAddPathForRoundedRect):
      * platform/graphics/cocoa/FontPlatformDataCocoa.mm:
      (WebCore::FontPlatformData::FontPlatformData):
      (WebCore::FontPlatformData::setFont):
      * platform/graphics/mac/FontMac.mm:
      (WebCore::showGlyphsWithAdvances):
      * platform/graphics/mac/GraphicsContextMac.mm:
      (WebCore::GraphicsContext::drawLineForDocumentMarker):
      * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
      (WebCore::MediaPlayerPrivateQTKit::createQTMovie):
      (WebCore::MediaPlayerPrivateQTKit::layerHostChanged):
      * platform/graphics/mac/WebLayer.mm:
      (drawLayerContents):
      * platform/mac/CursorMac.mm:
      (WebCore::Cursor::ensurePlatformCursor):
      * platform/mac/EmptyProtocolDefinitions.h: Removed.
      * platform/mac/MemoryPressureHandlerMac.mm:
      (WebCore::MemoryPressureHandler::releaseMemory):
      * platform/mac/NSScrollerImpDetails.h:
      * platform/mac/PlatformEventFactoryMac.mm:
      (WebCore::momentumPhaseForEvent):
      (WebCore::phaseForEvent):
      * platform/mac/ScrollAnimatorMac.mm:
      * platform/mac/SharedTimerMac.mm:
      * platform/mac/WebCoreSystemInterface.h:
      * platform/mac/WebCoreSystemInterface.mm:
      * platform/network/mac/ResourceHandleMac.mm:
      * platform/network/mac/ResourceRequestMac.mm:
      (WebCore::ResourceRequest::doUpdateResourceRequest):
      (WebCore::ResourceRequest::doUpdatePlatformRequest):
      * platform/text/cf/HyphenationCF.cpp:
      * platform/text/mac/HyphenationMac.mm: Removed.
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::containsPaintedContent):
      * rendering/RenderThemeMac.mm:
      (WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused):
      
      Source/WebKit/mac:
      
      * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
      (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
      (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
      * Misc/WebNSControlExtras.m:
      (-[NSControl sizeToFitAndAdjustWindowHeight]):
      * Misc/WebNSFileManagerExtras.mm:
      * WebCoreSupport/WebEditorClient.mm:
      (WebEditorClient::shouldEraseMarkersAfterChangeSelection):
      (WebEditorClient::getGuessesForWord):
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (WebFrameLoaderClient::dispatchDidLayout):
      (WebFrameLoaderClient::provisionalLoadStarted):
      * WebCoreSupport/WebSystemInterface.mm:
      (InitWebCoreSystemInterface):
      * WebKitPrefix.h:
      * WebView/WebDynamicScrollBarsView.mm:
      (-[WebDynamicScrollBarsView scrollWheel:]):
      * WebView/WebFullScreenController.mm:
      (convertRectToScreen):
      (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
      (-[WebFullScreenController exitFullScreen]):
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
      (-[WebHTMLView removeMouseMovedObserver]):
      (-[WebHTMLView windowDidBecomeKey:]):
      (-[WebHTMLView windowDidResignKey:]):
      * WebView/WebView.mm:
      (-[WebView _deviceScaleFactor]):
      
      Source/WebKit2:
      
      * NetworkProcess/mac/NetworkProcessMac.mm:
      (WebKit::overrideSystemProxies):
      (WebKit::NetworkProcess::platformInitializeNetworkProcess):
      * WebKit2Prefix.h:
      
      Source/WTF:
      
      * wtf/FastMalloc.cpp:
      (WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
      * wtf/FeatureDefines.h:
      * wtf/Platform.h:
      
      Tools:
      
      * DumpRenderTree/mac/CheckedMalloc.cpp:
      (protectionOfRegion):
      (makeLargeMallocFailSilently):
      * DumpRenderTree/mac/DumpRenderTree.mm:
      (resetDefaultsToConsistentValues):
      * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
      (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
      * DumpRenderTree/mac/FrameLoadDelegate.mm:
      (testPathFromURL):
      (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
      * DumpRenderTree/mac/LayoutTestHelper.m:
      * DumpRenderTree/mac/TestRunnerMac.mm:
      * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
      (WTR::InjectedBundle::platformInitialize):
      * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
      (WTR::testPathFromURL):
      (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154314 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3feac41c
  20. 19 Aug, 2013 1 commit
    • psolanki@apple.com's avatar
      <https://webkit.org/b/119918> Frame::selection() should return a reference · 87ae63d7
      psolanki@apple.com authored
      Reviewed by Darin Adler.
      
      m_selection is never NULL so return a reference from Frame::selection(). Also removed some
      unnecessary null checks and assert diff ts exposed as a result.
      
      Source/WebCore:
      
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::selection):
      (WebCore::AccessibilityRenderObject::setSelectedTextRange):
      (WebCore::AccessibilityRenderObject::isFocused):
      (WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange):
      (WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
      * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
      (-[WebAccessibilityObjectWrapper accessibilityModifySelection:increase:]):
      (-[WebAccessibilityObjectWrapper accessibilityMoveSelectionToMarker:]):
      (-[WebAccessibilityObjectWrapper _convertToNSRange:]):
      (-[WebAccessibilityObjectWrapper _convertToDOMRange:]):
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      (-[WebAccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
      * css/SelectorChecker.cpp:
      (WebCore::SelectorChecker::isFrameFocused):
      * dom/CharacterData.cpp:
      (WebCore::CharacterData::setDataAndUpdate):
      * dom/Document.cpp:
      (WebCore::Document::nodeChildrenWillBeRemoved):
      (WebCore::Document::nodeWillBeRemoved):
      * dom/Element.cpp:
      (WebCore::Element::updateFocusAppearance):
      * editing/AlternativeTextController.cpp:
      (WebCore::AlternativeTextController::stopPendingCorrection):
      (WebCore::AlternativeTextController::applyAlternativeTextToRange):
      (WebCore::AlternativeTextController::applyAutocorrectionBeforeTypingIfAppropriate):
      (WebCore::AlternativeTextController::respondToUnappliedSpellCorrection):
      (WebCore::AlternativeTextController::timerFired):
      (WebCore::AlternativeTextController::respondToChangedSelection):
      * editing/DeleteButtonController.cpp:
      (WebCore::DeleteButtonController::respondToChangedSelection):
      (WebCore::DeleteButtonController::enable):
      (WebCore::DeleteButtonController::deleteTarget):
      * editing/DeleteSelectionCommand.cpp:
      (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete):
      * editing/DictationCommand.cpp:
      (WebCore::DictationCommand::insertText):
      * editing/EditCommand.cpp:
      (WebCore::EditCommand::EditCommand):
      * editing/EditingStyle.cpp:
      (WebCore::EditingStyle::mergeTypingStyle):
      * editing/Editor.cpp:
      (WebCore::Editor::selectionForCommand):
      (WebCore::Editor::canEdit):
      (WebCore::Editor::canEditRichly):
      (WebCore::Editor::canDHTMLCut):
      (WebCore::Editor::canDHTMLCopy):
      (WebCore::Editor::canCopy):
      (WebCore::Editor::canDelete):
      (WebCore::Editor::canSmartCopyOrDelete):
      (WebCore::Editor::deleteWithDirection):
      (WebCore::Editor::deleteSelectionWithSmartDelete):
      (WebCore::Editor::replaceSelectionWithFragment):
      (WebCore::Editor::selectedRange):
      (WebCore::Editor::tryDHTMLCopy):
      (WebCore::Editor::tryDHTMLCut):
      (WebCore::Editor::hasBidiSelection):
      (WebCore::Editor::selectionUnorderedListState):
      (WebCore::Editor::selectionOrderedListState):
      (WebCore::Editor::increaseSelectionListLevel):
      (WebCore::Editor::increaseSelectionListLevelOrdered):
      (WebCore::Editor::increaseSelectionListLevelUnordered):
      (WebCore::Editor::decreaseSelectionListLevel):
      (WebCore::Editor::findEventTargetFromSelection):
      (WebCore::Editor::applyStyle):
      (WebCore::Editor::applyParagraphStyle):
      (WebCore::Editor::applyStyleToSelection):
      (WebCore::Editor::applyParagraphStyleToSelection):
      (WebCore::Editor::selectionStartHasStyle):
      (WebCore::Editor::selectionHasStyle):
      (WebCore::Editor::selectionStartCSSPropertyValue):
      (WebCore::Editor::appliedEditing):
      (WebCore::Editor::insertTextWithoutSendingTextEvent):
      (WebCore::Editor::insertLineBreak):
      (WebCore::Editor::insertParagraphSeparator):
      (WebCore::Editor::cut):
      (WebCore::Editor::copy):
      (WebCore::Editor::paste):
      (WebCore::Editor::baseWritingDirectionForSelectionStart):
      (WebCore::Editor::selectComposition):
      (WebCore::Editor::setComposition):
      (WebCore::Editor::ignoreSpelling):
      (WebCore::Editor::learnSpelling):
      (WebCore::Editor::advanceToNextMisspelling):
      (WebCore::Editor::misspelledWordAtCaretOrRange):
      (WebCore::Editor::isSelectionUngrammatical):
      (WebCore::Editor::guessesForMisspelledOrUngrammatical):
      (WebCore::Editor::markMisspellingsAfterTypingToWord):
      (WebCore::Editor::isSpellCheckingEnabledInFocusedNode):
      (WebCore::Editor::markAndReplaceFor):
      (WebCore::Editor::updateMarkersForWordsAffectedByEditing):
      (WebCore::Editor::revealSelectionAfterEditingOperation):
      (WebCore::Editor::getCompositionSelection):
      (WebCore::Editor::transpose):
      (WebCore::Editor::changeSelectionAfterCommand):
      (WebCore::Editor::selectedText):
      (WebCore::Editor::computeAndSetTypingStyle):
      (WebCore::Editor::findString):
      (WebCore::Editor::respondToChangedSelection):
      (WebCore::Editor::selectionStartHasMarkerFor):
      (WebCore::Editor::toggleOverwriteModeEnabled):
      * editing/EditorCommand.cpp:
      (WebCore::executeToggleStyleInList):
      (WebCore::expandSelectionToGranularity):
      (WebCore::stateTextWritingDirection):
      (WebCore::executeDelete):
      (WebCore::executeDeleteToMark):
      (WebCore::executeMoveBackward):
      (WebCore::executeMoveBackwardAndModifySelection):
      (WebCore::executeMoveDown):
      (WebCore::executeMoveDownAndModifySelection):
      (WebCore::executeMoveForward):
      (WebCore::executeMoveForwardAndModifySelection):
      (WebCore::executeMoveLeft):
      (WebCore::executeMoveLeftAndModifySelection):
      (WebCore::executeMovePageDown):
      (WebCore::executeMovePageDownAndModifySelection):
      (WebCore::executeMovePageUp):
      (WebCore::executeMovePageUpAndModifySelection):
      (WebCore::executeMoveRight):
      (WebCore::executeMoveRightAndModifySelection):
      (WebCore::executeMoveToBeginningOfDocument):
      (WebCore::executeMoveToBeginningOfDocumentAndModifySelection):
      (WebCore::executeMoveToBeginningOfLine):
      (WebCore::executeMoveToBeginningOfLineAndModifySelection):
      (WebCore::executeMoveToBeginningOfParagraph):
      (WebCore::executeMoveToBeginningOfParagraphAndModifySelection):
      (WebCore::executeMoveToBeginningOfSentence):
      (WebCore::executeMoveToBeginningOfSentenceAndModifySelection):
      (WebCore::executeMoveToEndOfDocument):
      (WebCore::executeMoveToEndOfDocumentAndModifySelection):
      (WebCore::executeMoveToEndOfSentence):
      (WebCore::executeMoveToEndOfSentenceAndModifySelection):
      (WebCore::executeMoveToEndOfLine):
      (WebCore::executeMoveToEndOfLineAndModifySelection):
      (WebCore::executeMoveToEndOfParagraph):
      (WebCore::executeMoveToEndOfParagraphAndModifySelection):
      (WebCore::executeMoveParagraphBackwardAndModifySelection):
      (WebCore::executeMoveParagraphForwardAndModifySelection):
      (WebCore::executeMoveUp):
      (WebCore::executeMoveUpAndModifySelection):
      (WebCore::executeMoveWordBackward):
      (WebCore::executeMoveWordBackwardAndModifySelection):
      (WebCore::executeMoveWordForward):
      (WebCore::executeMoveWordForwardAndModifySelection):
      (WebCore::executeMoveWordLeft):
      (WebCore::executeMoveWordLeftAndModifySelection):
      (WebCore::executeMoveWordRight):
      (WebCore::executeMoveWordRightAndModifySelection):
      (WebCore::executeMoveToLeftEndOfLine):
      (WebCore::executeMoveToLeftEndOfLineAndModifySelection):
      (WebCore::executeMoveToRightEndOfLine):
      (WebCore::executeMoveToRightEndOfLineAndModifySelection):
      (WebCore::executeSelectAll):
      (WebCore::executeSelectToMark):
      (WebCore::executeSetMark):
      (WebCore::executeSwapWithMark):
      (WebCore::executeUnselect):
      (WebCore::enabledInRichlyEditableText):
      (WebCore::enabledRangeInEditableText):
      (WebCore::enabledRangeInRichlyEditableText):
      (WebCore::valueFormatBlock):
      * editing/FrameSelection.cpp:
      (WebCore::FrameSelection::setSelection):
      (WebCore::FrameSelection::selectFrameElementInParentIfFullySelected):
      * editing/InsertLineBreakCommand.cpp:
      (WebCore::InsertLineBreakCommand::doApply):
      * editing/InsertTextCommand.cpp:
      (WebCore::InsertTextCommand::doApply):
      * editing/ModifySelectionListLevel.cpp:
      (WebCore::IncreaseSelectionListLevelCommand::canIncreaseSelectionListLevel):
      (WebCore::DecreaseSelectionListLevelCommand::canDecreaseSelectionListLevel):
      * editing/RemoveFormatCommand.cpp:
      (WebCore::RemoveFormatCommand::doApply):
      * editing/ReplaceSelectionCommand.cpp:
      (WebCore::ReplaceSelectionCommand::doApply):
      * editing/SetSelectionCommand.cpp:
      (WebCore::SetSelectionCommand::doApply):
      (WebCore::SetSelectionCommand::doUnapply):
      * editing/SpellingCorrectionCommand.cpp:
      (WebCore::SpellingCorrectionCommand::doApply):
      * editing/TextInsertionBaseCommand.cpp:
      (WebCore::TextInsertionBaseCommand::applyTextInsertionCommand):
      * editing/TypingCommand.cpp:
      (WebCore::TypingCommand::deleteSelection):
      (WebCore::TypingCommand::updateSelectionIfDifferentFromCurrentSelection):
      (WebCore::TypingCommand::insertText):
      (WebCore::TypingCommand::deleteKeyPressed):
      (WebCore::TypingCommand::forwardDeleteKeyPressed):
      * editing/ios/EditorIOS.mm:
      (WebCore::Editor::setTextAlignmentForChangedBaseWritingDirection):
      (WebCore::styleForSelectionStart):
      (WebCore::Editor::fontForSelection):
      * editing/mac/EditorMac.mm:
      (WebCore::styleForSelectionStart):
      (WebCore::Editor::fontForSelection):
      (WebCore::Editor::canCopyExcludingStandaloneImages):
      (WebCore::Editor::readSelectionFromPasteboard):
      * html/HTMLAnchorElement.cpp:
      (WebCore::HTMLAnchorElement::defaultEventHandler):
      (WebCore::HTMLAnchorElement::setActive):
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::updateFocusAppearance):
      * html/HTMLTextAreaElement.cpp:
      (WebCore::HTMLTextAreaElement::updateFocusAppearance):
      (WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent):
      * html/HTMLTextFormControlElement.cpp:
      (WebCore::HTMLTextFormControlElement::setSelectionRange):
      (WebCore::HTMLTextFormControlElement::computeSelectionStart):
      (WebCore::HTMLTextFormControlElement::computeSelectionEnd):
      (WebCore::HTMLTextFormControlElement::computeSelectionDirection):
      (WebCore::HTMLTextFormControlElement::selectionChanged):
      * html/TextFieldInputType.cpp:
      (WebCore::TextFieldInputType::handleBeforeTextInsertedEvent):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::clear):
      * loader/archive/cf/LegacyWebArchive.cpp:
      (WebCore::LegacyWebArchive::createFromSelection):
      * page/ContextMenuController.cpp:
      (WebCore::insertUnicodeCharacter):
      (WebCore::ContextMenuController::contextMenuItemSelected):
      (WebCore::selectionContainsPossibleWord):
      (WebCore::ContextMenuController::populate):
      (WebCore::ContextMenuController::checkOrEnableIfNeeded):
      * page/DOMSelection.cpp:
      (WebCore::selectionShadowAncestor):
      (WebCore::DOMSelection::visibleSelection):
      (WebCore::DOMSelection::isCollapsed):
      (WebCore::DOMSelection::type):
      (WebCore::DOMSelection::rangeCount):
      (WebCore::DOMSelection::collapse):
      (WebCore::DOMSelection::collapseToEnd):
      (WebCore::DOMSelection::collapseToStart):
      (WebCore::DOMSelection::empty):
      (WebCore::DOMSelection::setBaseAndExtent):
      (WebCore::DOMSelection::setPosition):
      (WebCore::DOMSelection::modify):
      (WebCore::DOMSelection::extend):
      (WebCore::DOMSelection::getRangeAt):
      (WebCore::DOMSelection::removeAllRanges):
      (WebCore::DOMSelection::addRange):
      (WebCore::DOMSelection::deleteFromDocument):
      (WebCore::DOMSelection::containsNode):
      (WebCore::DOMSelection::toString):
      * page/DragController.cpp:
      (WebCore::DragController::dragIsMove):
      (WebCore::setSelectionToDragCaret):
      (WebCore::DragController::concludeEditDrag):
      (WebCore::DragController::draggableElement):
      (WebCore::selectElement):
      (WebCore::dragLocForSelectionDrag):
      (WebCore::DragController::startDrag):
      * page/DragController.h:
      * page/EventHandler.cpp:
      (WebCore::setSelectionIfNeeded):
      (WebCore::EventHandler::updateSelectionForMouseDownDispatchingSelectStart):
      (WebCore::EventHandler::handleMousePressEventDoubleClick):
      (WebCore::EventHandler::handleMousePressEventSingleClick):
      (WebCore::EventHandler::updateSelectionForMouseDrag):
      (WebCore::EventHandler::lostMouseCapture):
      (WebCore::EventHandler::handleMouseReleaseEvent):
      (WebCore::nodeIsNotBeingEdited):
      (WebCore::EventHandler::selectCursor):
      (WebCore::EventHandler::handleMousePressEvent):
      (WebCore::EventHandler::handleMouseDoubleClickEvent):
      (WebCore::EventHandler::dispatchMouseEvent):
      (WebCore::EventHandler::sendContextMenuEvent):
      (WebCore::EventHandler::sendContextMenuEventForKey):
      (WebCore::handleKeyboardSelectionMovement):
      (WebCore::EventHandler::handleDrag):
      * page/FocusController.cpp:
      (WebCore::FocusController::setFocusedFrame):
      (WebCore::FocusController::setFocused):
      (WebCore::FocusController::advanceFocusInDocumentOrder):
      (WebCore::clearSelectionIfNeeded):
      (WebCore::FocusController::setActive):
      * page/Frame.cpp:
      (WebCore::Frame::dragImageForSelection):
      * page/Frame.h:
      (WebCore::Frame::selection):
      * page/FrameView.cpp:
      (WebCore::FrameView::performPostLayoutTasks):
      (WebCore::FrameView::paintContentsForSnapshot):
      * page/Page.cpp:
      (WebCore::Page::findString):
      (WebCore::Page::findStringMatchingRanges):
      (WebCore::Page::selection):
      * page/mac/FrameMac.mm:
      (WebCore::Frame::dragImageForSelection):
      * page/mac/FrameSnapshottingMac.mm:
      (WebCore::selectionImage):
      * page/win/FrameWin.cpp:
      (WebCore::imageFromSelection):
      (WebCore::Frame::dragImageForSelection):
      * platform/ios/PasteboardIOS.mm:
      (WebCore::Pasteboard::documentFragmentForPasteboardItemAtIndex):
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestResult::isSelected):
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::paintCaret):
      * rendering/RenderImage.cpp:
      (WebCore::RenderImage::paintAreaElementFocusRing):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::scrollTo):
      * rendering/RenderListBox.cpp:
      (WebCore::RenderListBox::paintItemForeground):
      (WebCore::RenderListBox::paintItemBackground):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::selectionBackgroundColor):
      (WebCore::RenderObject::selectionColor):
      * rendering/RenderTextControlSingleLine.cpp:
      (WebCore::RenderTextControlSingleLine::capsLockStateMayHaveChanged):
      * rendering/RenderTheme.cpp:
      (WebCore::RenderTheme::isFocused):
      * rendering/RenderThemeWin.cpp:
      (WebCore::RenderThemeWin::adjustSearchFieldStyle):
      * rendering/RenderTreeAsText.cpp:
      (WebCore::writeSelection):
      * rendering/RenderView.cpp:
      (WebCore::RenderView::setSelection):
      * svg/SVGSVGElement.cpp:
      (WebCore::SVGSVGElement::deselectAll):
      * svg/SVGTextContentElement.cpp:
      (WebCore::SVGTextContentElement::selectSubString):
      * testing/Internals.cpp:
      (WebCore::Internals::absoluteCaretBounds):
      (WebCore::Internals::selectionBounds):
      
      Source/WebKit/blackberry:
      
      * Api/InRegionScroller.cpp:
      (BlackBerry::WebKit::InRegionScrollerPrivate::setLayerScrollPosition):
      * WebKitSupport/DatePickerClient.cpp:
      (BlackBerry::WebKit::DatePickerClient::setValueAndClosePopup):
      * WebKitSupport/InPageSearchManager.cpp:
      (BlackBerry::WebKit::InPageSearchManager::findNextString):
      (BlackBerry::WebKit::InPageSearchManager::clearTextMatches):
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::focusedNodeChanged):
      (BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
      (BlackBerry::WebKit::InputHandler::setElementUnfocused):
      (BlackBerry::WebKit::InputHandler::setInputModeEnabled):
      (BlackBerry::WebKit::InputHandler::setElementFocused):
      (BlackBerry::WebKit::InputHandler::openDatePopup):
      (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
      (BlackBerry::WebKit::InputHandler::selectionPosition):
      (BlackBerry::WebKit::InputHandler::setSelection):
      (BlackBerry::WebKit::InputHandler::deleteSelection):
      (BlackBerry::WebKit::InputHandler::setRelativeCursorPosition):
      * WebKitSupport/SelectionHandler.cpp:
      (BlackBerry::WebKit::SelectionHandler::cancelSelection):
      (BlackBerry::WebKit::SelectionHandler::shouldUpdateSelectionOrCaretForPoint):
      (BlackBerry::WebKit::SelectionHandler::setCaretPosition):
      (BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
      (BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
      (BlackBerry::WebKit::SelectionHandler::setSelection):
      (BlackBerry::WebKit::SelectionHandler::startCaretViewportRect):
      (BlackBerry::WebKit::SelectionHandler::selectNextParagraph):
      (BlackBerry::WebKit::SelectionHandler::expandSelectionToGranularity):
      (BlackBerry::WebKit::SelectionHandler::selectObject):
      (BlackBerry::WebKit::directionOfEnclosingBlock):
      (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
      (BlackBerry::WebKit::SelectionHandler::notifyCaretPositionChangedIfNeeded):
      (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
      (BlackBerry::WebKit::SelectionHandler::selectionContains):
      * WebKitSupport/SpellingHandler.cpp:
      (BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
      
      Source/WebKit/efl:
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      (DumpRenderTreeSupportEfl::selectionRectangle):
      (DumpRenderTreeSupportEfl::firstRectForCharacterRange):
      (DumpRenderTreeSupportEfl::selectedRange):
      * WebCoreSupport/EditorClientEfl.cpp:
      (WebCore::EditorClientEfl::handleEditingKeyboardEvent):
      * ewk/ewk_frame.cpp:
      (ewk_frame_text_selection_type_get):
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::paint):
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
      (DumpRenderTreeSupportGtk::firstRectForCharacterRange):
      (DumpRenderTreeSupportGtk::selectedRange):
      (DumpRenderTreeSupportGtk::rectangleForSelection):
      * WebCoreSupport/EditorClientGtk.cpp:
      (WebKit::collapseSelection):
      (WebKit::setSelectionPrimaryClipboardIfNeeded):
      * webkit/webkitwebframe.cpp:
      (webkit_web_frame_get_range_for_word_around_caret):
      * webkit/webkitwebview.cpp:
      (getLocationForKeyboardGeneratedContextMenu):
      
      Source/WebKit/mac:
      
      * Plugins/WebPluginController.mm:
      * WebView/WebFrame.mm:
      (-[WebFrame _hasSelection]):
      (-[WebFrame _rangeByAlteringCurrentSelection:FrameSelection::direction:granularity:]):
      (-[WebFrame _selectionGranularity]):
      (-[WebFrame _convertToNSRange:]):
      (-[WebFrame _convertToDOMRange:]):
      (-[WebFrame _insertParagraphSeparatorInQuotedContent]):
      (-[WebFrame _typingStyle]):
      (-[WebFrame _selectedNSRange]):
      (-[WebFrame _selectNSRange:]):
      (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
      (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]):
      * WebView/WebHTMLRepresentation.mm:
      (-[WebHTMLRepresentation currentForm]):
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView readSelectionFromPasteboard:]):
      (-[WebHTMLView _selectedRange]):
      (-[WebHTMLView _hasSelection]):
      (-[WebHTMLView _hasSelectionOrInsertionPoint]):
      (-[WebHTMLView _hasInsertionPoint]):
      (-[WebHTMLView _isEditable]):
      (-[WebHTMLView jumpToSelection:]):
      (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
      (-[WebHTMLView maintainsInactiveSelection]):
      (isTextInput):
      (isInPasswordField):
      (-[WebHTMLView centerSelectionInVisibleArea:]):
      (-[WebHTMLView _canSmartCopyOrDelete]):
      (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
      (-[WebHTMLView _updateSelectionForInputManager]):
      (-[WebHTMLView selectionRect]):
      (-[WebHTMLView selectionTextRects]):
      (-[WebHTMLView selectionImageRect]):
      (-[WebHTMLView selectAll]):
      (-[WebHTMLView deselectAll]):
      (-[WebHTMLView selectedAttributedString]):
      * WebView/WebTextCompletionController.mm:
      (-[WebTextCompletionController doCompletion]):
      * WebView/WebView.mm:
      (-[WebView setSelectedDOMRange:affinity:]):
      (-[WebView selectedDOMRange]):
      (-[WebView selectionAffinity]):
      (-[WebView setEditable:]):
      (-[WebView _selectionIsCaret]):
      (-[WebView _selectionIsAll]):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::selectedRange):
      (DumpRenderTreeSupportQt::firstRectForCharacterRange):
      * WebCoreSupport/EditorClientQt.cpp:
      (WebCore::EditorClientQt::respondToChangedSelection):
      (WebCore::EditorClientQt::handleKeyboardEvent):
      * WebCoreSupport/QWebPageAdapter.cpp:
      (QWebPageAdapter::hasSelection):
      (QWebPageAdapter::selectedText):
      (QWebPageAdapter::findText):
      (QWebPageAdapter::inputMethodEvent):
      (QWebPageAdapter::inputMethodQuery):
      
      Source/WebKit/win:
      
      * WebFrame.cpp:
      (WebFrame::currentForm):
      * WebView.cpp:
      (WebView::updateFocusedAndActiveState):
      (WebView::selectionRect):
      (WebView::centerSelectionInVisibleArea):
      (WebView::hasSelectedRange):
      (WebView::replaceSelectionWithText):
      (WebView::clearSelection):
      (WebView::prepareCandidateWindow):
      (WebView::onIMERequestCharPosition):
      (WebView::onIMERequestReconvertString):
      (WebView::firstRectForCharacterRangeForTesting):
      (WebView::selectedRangeForTesting):
      
      Source/WebKit/wince:
      
      * WebCoreSupport/EditorClientWinCE.cpp:
      (WebKit::EditorClientWinCE::handleEditingKeyboardEvent):
      
      Source/WebKit2:
      
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      (WebKit::WebEditorClient::updateGlobalSelection):
      * WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:
      (WebKit::collapseSelection):
      (WebKit::WebEditorClient::updateGlobalSelection):
      * WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
      (WebKit::WebContextMenuClient::lookUpInDictionary):
      (WebKit::WebContextMenuClient::searchWithSpotlight):
      * WebProcess/WebPage/FindController.cpp:
      (WebKit::frameWithSelection):
      (WebKit::FindController::updateFindUIAfterPageScroll):
      (WebKit::FindController::getFindIndicatorBitmapAndRect):
      (WebKit::FindController::getImageForFindMatch):
      (WebKit::FindController::selectFindMatch):
      (WebKit::FindController::updateFindIndicator):
      (WebKit::FindController::drawRect):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::editorState):
      (WebKit::WebPage::scaledSnapshotWithOptions):
      (WebKit::WebPage::centerSelectionInVisibleArea):
      (WebKit::frameWithSelection):
      (WebKit::WebPage::clearSelection):
      (WebKit::WebPage::confirmComposition):
      (WebKit::WebPage::setComposition):
      (WebKit::WebPage::currentSelectionAsRange):
      * WebProcess/WebPage/mac/WebPageMac.mm:
      (WebKit::WebPage::setComposition):
      (WebKit::WebPage::insertText):
      (WebKit::WebPage::insertDictatedText):
      (WebKit::WebPage::getMarkedRange):
      (WebKit::WebPage::getSelectedRange):
      (WebKit::WebPage::getAttributedSubstringFromRange):
      (WebKit::WebPage::characterIndexForPoint):
      (WebKit::convertToRange):
      (WebKit::WebPage::performDictionaryLookupAtLocation):
      (WebKit::WebPage::readSelectionFromPasteboard):
      (WebKit::WebPage::getStringSelectionForPasteboard):
      (WebKit::WebPage::getDataSelectionForPasteboard):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87ae63d7
  21. 17 Aug, 2013 1 commit
  22. 16 Aug, 2013 1 commit
  23. 15 Aug, 2013 1 commit
    • andersca@apple.com's avatar
      <https://webkit.org/b/119859> Frame::loader() should return a reference · df550b96
      andersca@apple.com authored
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      * Modules/websockets/WebSocketChannel.cpp:
      (WebCore::WebSocketChannel::willOpenSocketStream):
      * WebCore.xcodeproj/project.pbxproj:
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::press):
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      (-[WebAccessibilityObjectWrapper remoteAccessibilityParentObject]):
      * bindings/ScriptControllerBase.cpp:
      (WebCore::ScriptController::canExecuteScripts):
      * bindings/js/ScriptController.cpp:
      (WebCore::ScriptController::initScript):
      * css/CSSFontSelector.cpp:
      (WebCore::CSSFontSelector::beginLoadTimerFired):
      * dom/DOMImplementation.cpp:
      (WebCore::DOMImplementation::createDocument):
      * dom/Document.cpp:
      (WebCore::Document::Document):
      (WebCore::Document::setVisualUpdatesAllowed):
      (WebCore::Document::updateTitle):
      (WebCore::Document::open):
      (WebCore::Document::explicitClose):
      (WebCore::Document::implicitClose):
      (WebCore::Document::userAgent):
      (WebCore::Document::canNavigate):
      (WebCore::Document::processHttpEquiv):
      (WebCore::Document::referrer):
      (WebCore::Document::documentDidResumeFromPageCache):
      (WebCore::Document::openSearchDescriptionURL):
      (WebCore::Document::finishedParsing):
      (WebCore::Document::addIconURL):
      (WebCore::Document::initSecurityContext):
      (WebCore::Document::updateURLForPushOrReplaceState):
      (WebCore::Document::loadEventDelayTimerFired):
      (WebCore::Document::loader):
      (WebCore::Document::decrementActiveParserCount):
      * history/CachedFrame.cpp:
      (WebCore::CachedFrameBase::CachedFrameBase):
      (WebCore::CachedFrameBase::restore):
      (WebCore::CachedFrame::CachedFrame):
      (WebCore::CachedFrame::open):
      (WebCore::CachedFrame::destroy):
      * history/PageCache.cpp:
      (WebCore::logCanCacheFrameDecision):
      (WebCore::logCanCachePageDecision):
      (WebCore::PageCache::canCachePageContainingThisFrame):
      (WebCore::PageCache::canCache):
      * html/HTMLAnchorElement.cpp:
      (WebCore::HTMLAnchorElement::handleClick):
      * html/HTMLAppletElement.cpp:
      (WebCore::HTMLAppletElement::updateWidget):
      * html/HTMLElement.cpp:
      (WebCore::HTMLElement::rendererIsNeeded):
      * html/HTMLEmbedElement.cpp:
      (WebCore::HTMLEmbedElement::updateWidget):
      * html/HTMLFormElement.cpp:
      (WebCore::HTMLFormElement::prepareForSubmission):
      (WebCore::HTMLFormElement::submit):
      * html/HTMLFrameElementBase.cpp:
      (WebCore::HTMLFrameElementBase::openURL):
      * html/HTMLFrameOwnerElement.cpp:
      (WebCore::HTMLFrameOwnerElement::disconnectContentFrame):
      * html/HTMLFrameSetElement.cpp:
      (WebCore::HTMLFrameSetElement::insertedInto):
      (WebCore::HTMLFrameSetElement::removedFrom):
      * html/HTMLHtmlElement.cpp:
      (WebCore::HTMLHtmlElement::insertedByParser):
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::createRenderer):
      (WebCore::HTMLMediaElement::attach):
      (WebCore::HTMLMediaElement::loadResource):
      (WebCore::HTMLMediaElement::getPluginProxyParams):
      (WebCore::HTMLMediaElement::createMediaPlayerProxy):
      (WebCore::HTMLMediaElement::updateWidget):
      (WebCore::HTMLMediaElement::mediaPlayerReferrer):
      (WebCore::HTMLMediaElement::mediaPlayerUserAgent):
      * html/HTMLObjectElement.cpp:
      (WebCore::HTMLObjectElement::parametersForPlugin):
      (WebCore::HTMLObjectElement::updateWidget):
      * html/HTMLPlugInImageElement.cpp:
      (WebCore::HTMLPlugInImageElement::isImageType):
      (WebCore::HTMLPlugInImageElement::wouldLoadAsNetscapePlugin):
      (WebCore::HTMLPlugInImageElement::restartSimilarPlugIns):
      * html/HTMLVideoElement.cpp:
      (WebCore::HTMLVideoElement::setDisplayMode):
      * html/ImageDocument.cpp:
      (WebCore::ImageDocumentParser::appendBytes):
      (WebCore::ImageDocumentParser::finish):
      (WebCore::ImageDocument::createDocumentStructure):
      * html/MediaDocument.cpp:
      (WebCore::MediaDocumentParser::createDocumentStructure):
      * html/PluginDocument.cpp:
      (WebCore::PluginDocumentParser::createDocumentStructure):
      (WebCore::PluginDocumentParser::appendBytes):
      (WebCore::PluginDocument::detach):
      (WebCore::PluginDocument::cancelManualPluginLoad):
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore::WebGLRenderingContext::create):
      (WebCore::WebGLRenderingContext::loseContextImpl):
      (WebCore::WebGLRenderingContext::maybeRestoreContext):
      * html/parser/HTMLConstructionSite.cpp:
      (WebCore::HTMLConstructionSite::dispatchDocumentElementAvailableIfNeeded):
      (WebCore::HTMLConstructionSite::insertHTMLBodyElement):
      * html/parser/HTMLParserOptions.cpp:
      (WebCore::HTMLParserOptions::HTMLParserOptions):
      * html/parser/XSSAuditor.cpp:
      (WebCore::XSSAuditor::init):
      * html/parser/XSSAuditorDelegate.cpp:
      (WebCore::XSSAuditorDelegate::generateViolationReport):
      (WebCore::XSSAuditorDelegate::didBlockScript):
      * inspector/InspectorApplicationCacheAgent.cpp:
      (WebCore::InspectorApplicationCacheAgent::updateApplicationCacheStatus):
      (WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
      * inspector/InspectorFrontendClientLocal.cpp:
      (WebCore::InspectorFrontendClientLocal::openInNewTab):
      * inspector/InspectorFrontendHost.cpp:
      (WebCore::InspectorFrontendHost::loadResourceSynchronously):
      * inspector/InspectorOverlay.cpp:
      (WebCore::InspectorOverlay::overlayPage):
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::mainResourceContent):
      (WebCore::InspectorPageAgent::reload):
      (WebCore::InspectorPageAgent::navigate):
      (WebCore::allResourcesURLsForFrame):
      (WebCore::InspectorPageAgent::searchInResource):
      (WebCore::InspectorPageAgent::assertDocumentLoader):
      (WebCore::InspectorPageAgent::buildObjectForFrame):
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::InspectorResourceAgent::didFailLoading):
      * loader/CookieJar.cpp:
      (WebCore::networkingContext):
      * loader/DocumentLoader.cpp:
      (WebCore::DocumentLoader::frameLoader):
      (WebCore::DocumentLoader::document):
      (WebCore::DocumentLoader::stopLoading):
      (WebCore::DocumentLoader::removeSubresourceLoader):
      (WebCore::DocumentLoader::subresourceLoaderFinishedLoadingOnePart):
      (WebCore::DocumentLoader::iconLoadDecisionAvailable):
      (WebCore::DocumentLoader::continueIconLoadWithDecision):
      * loader/DocumentThreadableLoader.cpp:
      (WebCore::DocumentThreadableLoader::didReceiveResponse):
      (WebCore::DocumentThreadableLoader::didFinishLoading):
      (WebCore::DocumentThreadableLoader::didFail):
      (WebCore::DocumentThreadableLoader::preflightFailure):
      (WebCore::DocumentThreadableLoader::loadRequest):
      * loader/DocumentWriter.cpp:
      (WebCore::DocumentWriter::replaceDocument):
      (WebCore::DocumentWriter::createDocument):
      (WebCore::DocumentWriter::begin):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::~FrameLoader):
      (WebCore::FrameLoader::allChildrenAreComplete):
      (WebCore::FrameLoader::allAncestorsAreComplete):
      (WebCore::FrameLoader::loadURLIntoChildFrame):
      (WebCore::FrameLoader::outgoingReferrer):
      (WebCore::FrameLoader::setOpener):
      (WebCore::FrameLoader::completed):
      (WebCore::FrameLoader::started):
      (WebCore::FrameLoader::loadFrameRequest):
      (WebCore::FrameLoader::loadURL):
      (WebCore::FrameLoader::load):
      (WebCore::FrameLoader::loadWithDocumentLoader):
      (WebCore::FrameLoader::stopAllLoaders):
      (WebCore::FrameLoader::closeOldDataSources):
      (WebCore::FrameLoader::subframeIsLoading):
      (WebCore::FrameLoader::subresourceCachePolicy):
      (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
      (WebCore::FrameLoader::detachChildren):
      (WebCore::FrameLoader::checkLoadComplete):
      (WebCore::FrameLoader::detachFromParent):
      (WebCore::FrameLoader::loadPostRequest):
      (WebCore::FrameLoader::loadResourceSynchronously):
      (WebCore::FrameLoader::shouldClose):
      (WebCore::FrameLoader::handleBeforeUnloadEvent):
      (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
      (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
      (WebCore::createWindow):
      * loader/HistoryController.cpp:
      (WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
      (WebCore::HistoryController::restoreScrollPositionAndViewState):
      (WebCore::HistoryController::saveDocumentState):
      (WebCore::HistoryController::saveDocumentAndScrollState):
      (WebCore::isAssociatedToRequestedHistoryItem):
      (WebCore::HistoryController::restoreDocumentState):
      (WebCore::HistoryController::shouldStopLoadingForHistoryItem):
      (WebCore::HistoryController::goToItem):
      (WebCore::HistoryController::updateForBackForwardNavigation):
      (WebCore::HistoryController::updateForReload):
      (WebCore::HistoryController::updateForStandardLoad):
      (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
      (WebCore::HistoryController::updateForClientRedirect):
      (WebCore::HistoryController::updateForCommit):
      (WebCore::HistoryController::recursiveUpdateForCommit):
      (WebCore::HistoryController::updateForSameDocumentNavigation):
      (WebCore::HistoryController::recursiveUpdateForSameDocumentNavigation):
      (WebCore::HistoryController::initializeItem):
      (WebCore::HistoryController::createItemTree):
      (WebCore::HistoryController::recursiveSetProvisionalItem):
      (WebCore::HistoryController::recursiveGoToItem):
      (WebCore::HistoryController::updateBackForwardListClippedAtTarget):
      (WebCore::HistoryController::updateCurrentItem):
      (WebCore::HistoryController::pushState):
      (WebCore::HistoryController::replaceState):
      * loader/ImageLoader.cpp:
      (WebCore::pageIsBeingDismissed):
      * loader/MixedContentChecker.cpp:
      (WebCore::MixedContentChecker::client):
      * loader/NavigationScheduler.cpp:
      (WebCore::ScheduledURLNavigation::fire):
      (WebCore::ScheduledURLNavigation::didStartTimer):
      (WebCore::ScheduledURLNavigation::didStopTimer):
      (WebCore::ScheduledRedirect::shouldStartTimer):
      (WebCore::ScheduledRedirect::fire):
      (WebCore::ScheduledRefresh::fire):
      (WebCore::ScheduledHistoryNavigation::fire):
      (WebCore::ScheduledFormSubmission::fire):
      (WebCore::ScheduledFormSubmission::didStartTimer):
      (WebCore::ScheduledFormSubmission::didStopTimer):
      (WebCore::NavigationScheduler::mustLockBackForwardList):
      (WebCore::NavigationScheduler::scheduleLocationChange):
      (WebCore::NavigationScheduler::scheduleFormSubmission):
      (WebCore::NavigationScheduler::scheduleRefresh):
      (WebCore::NavigationScheduler::schedule):
      * loader/PingLoader.cpp:
      (WebCore::PingLoader::loadImage):
      (WebCore::PingLoader::sendPing):
      (WebCore::PingLoader::sendViolationReport):
      (WebCore::PingLoader::PingLoader):
      * loader/PolicyChecker.cpp:
      (WebCore::PolicyChecker::checkNavigationPolicy):
      (WebCore::PolicyChecker::checkNewWindowPolicy):
      (WebCore::PolicyChecker::checkContentPolicy):
      (WebCore::PolicyChecker::cancelCheck):
      (WebCore::PolicyChecker::stopCheck):
      (WebCore::PolicyChecker::cannotShowMIMEType):
      (WebCore::PolicyChecker::continueLoadAfterWillSubmitForm):
      (WebCore::PolicyChecker::continueAfterNavigationPolicy):
      (WebCore::PolicyChecker::continueAfterNewWindowPolicy):
      (WebCore::PolicyChecker::handleUnimplementablePolicy):
      * loader/ProgressTracker.cpp:
      (WebCore::ProgressTracker::progressStarted):
      (WebCore::ProgressTracker::progressCompleted):
      (WebCore::ProgressTracker::finalProgressComplete):
      (WebCore::ProgressTracker::incrementProgress):
      (WebCore::ProgressTracker::progressHeartbeatTimerFired):
      * loader/ResourceLoadNotifier.cpp:
      (WebCore::ResourceLoadNotifier::didReceiveAuthenticationChallenge):
      (WebCore::ResourceLoadNotifier::didCancelAuthenticationChallenge):
      (WebCore::ResourceLoadNotifier::willSendRequest):
      (WebCore::ResourceLoadNotifier::didFailToLoad):
      (WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest):
      (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
      (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
      (WebCore::ResourceLoadNotifier::dispatchDidReceiveData):
      (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
      (WebCore::ResourceLoadNotifier::dispatchDidFailLoading):
      * loader/ResourceLoader.cpp:
      (WebCore::ResourceLoader::ResourceLoader):
      (WebCore::ResourceLoader::start):
      (WebCore::ResourceLoader::frameLoader):
      (WebCore::ResourceLoader::willSendRequest):
      * loader/SubframeLoader.cpp:
      (WebCore::SubframeLoader::pluginIsLoadable):
      (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin):
      (WebCore::SubframeLoader::createJavaAppletWidget):
      (WebCore::SubframeLoader::loadOrRedirectSubframe):
      (WebCore::SubframeLoader::loadSubframe):
      (WebCore::SubframeLoader::allowPlugins):
      (WebCore::SubframeLoader::shouldUsePlugin):
      (WebCore::SubframeLoader::loadPlugin):
      * loader/appcache/ApplicationCacheGroup.cpp:
      (WebCore::ApplicationCacheGroup::selectCache):
      (WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL):
      (WebCore::ApplicationCacheGroup::update):
      (WebCore::ApplicationCacheGroup::createResourceHandle):
      (WebCore::ApplicationCacheGroup::didReceiveResponse):
      (WebCore::ApplicationCacheGroup::didFinishLoading):
      (WebCore::ApplicationCacheGroup::didFail):
      (WebCore::ApplicationCacheGroup::addEntry):
      (WebCore::CallCacheListenerTask::performTask):
      (WebCore::ApplicationCacheGroup::postListenerTask):
      * loader/appcache/DOMApplicationCache.cpp:
      (WebCore::DOMApplicationCache::applicationCacheHost):
      * loader/archive/cf/LegacyWebArchive.cpp:
      (WebCore::LegacyWebArchive::create):
      (WebCore::LegacyWebArchive::createFromSelection):
      * loader/cache/CachedResource.cpp:
      (WebCore::CachedResource::addAdditionalRequestHeaders):
      (WebCore::CachedResource::load):
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::requestImage):
      (WebCore::CachedResourceLoader::checkInsecureContent):
      (WebCore::CachedResourceLoader::canRequest):
      (WebCore::CachedResourceLoader::shouldContinueAfterNotifyingLoadedFromMemoryCache):
      (WebCore::CachedResourceLoader::requestResource):
      (WebCore::CachedResourceLoader::clientDefersImage):
      (WebCore::CachedResourceLoader::cachePolicy):
      (WebCore::CachedResourceLoader::loadDone):
      * loader/icon/IconController.cpp:
      (WebCore::IconController::commitToDatabase):
      (WebCore::IconController::startLoader):
      (WebCore::IconController::continueLoadWithDecision):
      * loader/icon/IconLoader.cpp:
      (WebCore::IconLoader::startLoading):
      (WebCore::IconLoader::notifyFinished):
      * page/Chrome.cpp:
      (WebCore::canRunModalIfDuringPageDismissal):
      * page/ContextMenuController.cpp:
      (WebCore::openNewWindow):
      (WebCore::ContextMenuController::contextMenuItemSelected):
      (WebCore::ContextMenuController::populate):
      (WebCore::ContextMenuController::checkOrEnableIfNeeded):
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::dispatchAllPendingBeforeUnloadEvents):
      (WebCore::DOMWindow::postMessageTimerFired):
      (WebCore::DOMWindow::close):
      (WebCore::DOMWindow::print):
      (WebCore::DOMWindow::stop):
      (WebCore::DOMWindow::setName):
      (WebCore::DOMWindow::opener):
      (WebCore::DOMWindow::dispatchLoadEvent):
      (WebCore::DOMWindow::setLocation):
      (WebCore::DOMWindow::createWindow):
      (WebCore::DOMWindow::open):
      * page/DOMWindowExtension.cpp:
      (WebCore::DOMWindowExtension::disconnectFrameForPageCache):
      (WebCore::DOMWindowExtension::reconnectFrameFromPageCache):
      (WebCore::DOMWindowExtension::willDestroyGlobalObjectInCachedFrame):
      (WebCore::DOMWindowExtension::willDestroyGlobalObjectInFrame):
      (WebCore::DOMWindowExtension::willDetachGlobalObjectFromFrame):
      * page/DragController.cpp:
      (WebCore::DragController::performDrag):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handleMousePressEvent):
      (WebCore::EventHandler::keyEvent):
      * page/Frame.cpp:
      (WebCore::Frame::~Frame):
      (WebCore::Frame::setView):
      (WebCore::Frame::injectUserScripts):
      (WebCore::Frame::willDetachPage):
      * page/Frame.h:
      (WebCore::Frame::loader):
      * page/FrameView.cpp:
      (WebCore::FrameView::mediaType):
      (WebCore::FrameView::setFixedVisibleContentRect):
      (WebCore::FrameView::shouldUseLoadTimeDeferredRepaintDelay):
      (WebCore::FrameView::performPostLayoutTasks):
      (WebCore::FrameView::autoSizeIfEnabled):
      (WebCore::FrameView::scrollTo):
      (WebCore::FrameView::shouldSuspendScrollAnimations):
      (WebCore::FrameView::qualifiesAsVisuallyNonEmpty):
      (WebCore::FrameView::wheelEvent):
      (WebCore::FrameView::firePaintRelatedMilestones):
      * page/History.cpp:
      (WebCore::History::stateInternal):
      (WebCore::History::stateObjectAdded):
      * page/Location.cpp:
      (WebCore::Location::setLocation):
      * page/Navigator.cpp:
      (WebCore::Navigator::userAgent):
      * page/Page.cpp:
      (WebCore::Page::goToItem):
      (WebCore::Page::refreshPlugins):
      (WebCore::Page::setDefersLoading):
      (WebCore::Page::setMemoryCacheClientCallsEnabled):
      (WebCore::Page::addRelevantRepaintedObject):
      * page/Performance.cpp:
      (WebCore::Performance::now):
      * page/PerformanceNavigation.cpp:
      (WebCore::PerformanceNavigation::type):
      (WebCore::PerformanceNavigation::redirectCount):
      * page/PerformanceResourceTiming.cpp:
      (WebCore::monotonicTimeToDocumentMilliseconds):
      * page/mac/PageMac.cpp:
      (WebCore::Page::addSchedulePair):
      (WebCore::Page::removeSchedulePair):
      * platform/ios/PasteboardIOS.mm:
      (WebCore::documentFragmentWithImageResource):
      (WebCore::documentFragmentWithRTF):
      (WebCore::Pasteboard::documentFragmentForPasteboardItemAtIndex):
      * platform/mac/HTMLConverter.mm:
      (-[WebHTMLConverter _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
      (-[WebHTMLConverter _loadFromDOMRange]):
      * platform/mac/PasteboardMac.mm:
      (WebCore::documentFragmentWithImageResource):
      (WebCore::documentFragmentWithRTF):
      (WebCore::fragmentFromWebArchive):
      * plugins/DOMMimeType.cpp:
      (WebCore::DOMMimeType::enabledPlugin):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::scrollTo):
      * svg/SVGAElement.cpp:
      (WebCore::SVGAElement::defaultEventHandler):
      * svg/graphics/SVGImage.cpp:
      (WebCore::SVGImage::~SVGImage):
      (WebCore::SVGImage::dataChanged):
      * testing/Internals.cpp:
      (WebCore::Internals::formControlStateOfPreviousHistoryItem):
      (WebCore::Internals::setFormControlStateOfPreviousHistoryItem):
      (WebCore::Internals::getReferencedFilePaths):
      (WebCore::Internals::forceReload):
      * xml/XSLTProcessorLibxslt.cpp:
      (WebCore::docLoaderFunc):
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      (WebCore::openFunc):
      (WebCore::XMLDocumentParser::startElementNs):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::load):
      (BlackBerry::WebKit::WebPagePrivate::loadString):
      (BlackBerry::WebKit::WebPagePrivate::stopCurrentLoad):
      (BlackBerry::WebKit::closeURLRecursively):
      (BlackBerry::WebKit::WebPage::dispatchBeforeUnloadEvent):
      (BlackBerry::WebKit::WebPagePrivate::shouldSendResizeEvent):
      (BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
      (BlackBerry::WebKit::WebPage::reload):
      (BlackBerry::WebKit::WebPage::reloadFromCache):
      (BlackBerry::WebKit::WebPage::textEncoding):
      (BlackBerry::WebKit::WebPage::forcedTextEncoding):
      (BlackBerry::WebKit::WebPage::setForcedTextEncoding):
      (BlackBerry::WebKit::WebPage::title):
      * WebCoreSupport/ChromeClientBlackBerry.cpp:
      (WebCore::ChromeClientBlackBerry::createWindow):
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidChangeLocationWithinPage):
      (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForResponse):
      (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
      (WebCore::FrameLoaderClientBlackBerry::delayPolicyCheckUntilFragmentExists):
      (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):
      (WebCore::FrameLoaderClientBlackBerry::createPlugin):
      (WebCore::FrameLoaderClientBlackBerry::receivedData):
      (WebCore::FrameLoaderClientBlackBerry::createDocumentLoader):
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidCommitLoad):
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
      (WebCore::FrameLoaderClientBlackBerry::dispatchWillSubmitForm):
      (WebCore::FrameLoaderClientBlackBerry::createFrame):
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidLayout):
      (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
      (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
      (WebCore::FrameLoaderClientBlackBerry::startDownload):
      (WebCore::FrameLoaderClientBlackBerry::canCachePage):
      (WebCore::FrameLoaderClientBlackBerry::didRestoreFromPageCache):
      * WebKitSupport/PagePopup.cpp:
      (BlackBerry::WebKit::PagePopup::initialize):
      
      Source/WebKit/efl:
      
      * WebCoreSupport/ChromeClientEfl.cpp:
      (kit):
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      (DumpRenderTreeSupportEfl::callShouldCloseOnWebView):
      (DumpRenderTreeSupportEfl::clearOpener):
      (DumpRenderTreeSupportEfl::frameChildren):
      (DumpRenderTreeSupportEfl::responseMimeType):
      (DumpRenderTreeSupportEfl::provisionalURL):
      * WebCoreSupport/FrameLoaderClientEfl.cpp:
      (WebCore::FrameLoaderClientEfl::callPolicyFunction):
      (WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNewWindowAction):
      (WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):
      (WebCore::FrameLoaderClientEfl::updateGlobalHistoryRedirectLinks):
      (WebCore::FrameLoaderClientEfl::updateGlobalHistory):
      * ewk/ewk_frame.cpp:
      (_ewk_frame_loader_efl_get):
      (_ewk_frame_smart_del):
      (_ewk_frame_contents_set_internal):
      (ewk_frame_stop):
      (ewk_frame_reload):
      (ewk_frame_reload_full):
      (ewk_frame_child_add):
      * ewk/ewk_view.cpp:
      (ewk_view_frame_focused_get):
      (ewk_view_setting_user_agent_set):
      (ewk_view_setting_encoding_custom_get):
      (ewk_view_setting_encoding_custom_set):
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
      (DumpRenderTreeSupportGtk::clearOpener):
      (DumpRenderTreeSupportGtk::shouldClose):
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      (WebKit::FrameLoaderClient::dispatchWillSubmitForm):
      (WebKit::FrameLoaderClient::committedLoad):
      (WebKit::FrameLoaderClient::dispatchDecidePolicyForResponse):
      (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
      (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
      (WebKit::FrameLoaderClient::createFrame):
      (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
      * webkit/webkitwebframe.cpp:
      (webkit_web_frame_finalize):
      (webkit_web_frame_load_uri):
      (webkit_web_frame_load_data):
      (webkit_web_frame_load_request):
      (webkit_web_frame_stop_loading):
      (webkit_web_frame_reload):
      (webkit_web_frame_get_data_source):
      (webkit_web_frame_get_provisional_data_source):
      (webkit_web_frame_get_response_mime_type):
      (webkit_web_frame_get_network_response):
      (WebKit::kit):
      * webkit/webkitwebpolicydecision.cpp:
      (webkit_web_policy_decision_use):
      (webkit_web_policy_decision_ignore):
      (webkit_web_policy_decision_download):
      * webkit/webkitwebview.cpp:
      (webkit_web_view_dispose):
      (webkit_web_view_reload):
      (webkit_web_view_reload_bypass_cache):
      (webkit_web_view_stop_loading):
      (webkit_web_view_can_show_mime_type):
      (webkit_web_view_set_custom_encoding):
      (webkit_web_view_get_custom_encoding):
      (webkit_web_view_get_subresources):
      
      Source/WebKit/mac:
      
      * Plugins/Hosted/HostedNetscapePluginStream.mm:
      (WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):
      * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
      (WebKit::NetscapePluginInstanceProxy::performRequest):
      (WebKit::NetscapePluginInstanceProxy::loadRequest):
      * Plugins/Hosted/WebHostedNetscapePluginView.mm:
      (-[WebHostedNetscapePluginView pluginView:receivedResponse:]):
      * Plugins/WebBaseNetscapePluginView.mm:
      (-[WebBaseNetscapePluginView requestWithURLCString:]):
      * Plugins/WebNetscapePluginStream.mm:
      (WebNetscapePluginStream::WebNetscapePluginStream):
      * Plugins/WebNetscapePluginView.mm:
      (-[WebNetscapePluginView loadStream]):
      (-[WebNetscapePluginView pluginView:receivedResponse:]):
      (-[WebNetscapePluginView loadPluginRequest:]):
      (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
      * Plugins/WebPluginController.mm:
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
      (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
      (WebFrameLoaderClient::dispatchWillSubmitForm):
      (WebFrameLoaderClient::updateGlobalHistory):
      (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
      (WebFrameLoaderClient::restoreViewState):
      (WebFrameLoaderClient::transitionToCommittedForNewPage):
      (WebFrameLoaderClient::createFrame):
      * WebCoreSupport/WebFrameNetworkingContext.mm:
      (WebFrameNetworkingContext::blockedError):
      * WebCoreSupport/WebPlatformStrategies.mm:
      (WebPlatformStrategies::getPluginInfo):
      * WebView/WebFrame.mm:
      (kit):
      (-[WebFrame _dataSource]):
      (-[WebFrame _canProvideDocumentSource]):
      (-[WebFrame _commitData:]):
      (-[WebFrame _firstLayoutDone]):
      (-[WebFrame _loadType]):
      (-[WebFrame _cacheabilityDictionary]):
      (-[WebFrame _clearOpener]):
      (-[WebFrame provisionalDataSource]):
      (-[WebFrame dataSource]):
      (-[WebFrame loadRequest:]):
      (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
      (-[WebFrame loadArchive:]):
      (-[WebFrame stopLoading]):
      (-[WebFrame reload]):
      (-[WebFrame reloadFromOrigin]):
      * WebView/WebHTMLRepresentation.mm:
      (-[WebHTMLRepresentation receivedData:withDataSource:]):
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
      * WebView/WebPDFView.mm:
      (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
      * WebView/WebRenderLayer.mm:
      (-[WebRenderLayer initWithWebFrame:]):
      * WebView/WebRenderNode.mm:
      (-[WebRenderNode _initWithCoreFrame:]):
      * WebView/WebView.mm:
      (-[WebView _close]):
      (-[WebView _loadBackForwardListFromOtherView:]):
      (-[WebView _cachedResponseForURL:]):
      (-[WebView setCustomTextEncodingName:]):
      (-[WebView shouldClose]):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::closeWindowSoon):
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::shouldClose):
      (DumpRenderTreeSupportQt::responseMimeType):
      (DumpRenderTreeSupportQt::clearOpener):
      (DumpRenderTreeSupportQt::thirdPartyCookiePolicyAllows):
      (DumpRenderTreeSupportQt::setAlternateHtml):
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::callPolicyFunction):
      (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad):
      (WebCore::FrameLoaderClientQt::updateGlobalHistory):
      (WebCore::FrameLoaderClientQt::updateGlobalHistoryRedirectLinks):
      (WebCore::FrameLoaderClientQt::callErrorPageExtension):
      (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNewWindowAction):
      (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
      (WebCore::FrameLoaderClientQt::startDownload):
      (WebCore::FrameLoaderClientQt::createFrame):
      (WebCore::FrameLoaderClientQt::objectContentType):
      * WebCoreSupport/QWebFrameAdapter.cpp:
      (QWebFrameAdapter::load):
      (QWebFrameAdapter::setContent):
      (QWebFrameAdapter::setHtml):
      (QWebFrameAdapter::kit):
      (QWebFrameAdapter::title):
      (QWebFrameAdapter::clearCoreFrame):
      * WebCoreSupport/QWebPageAdapter.cpp:
      (frameLoadRequest):
      (openNewWindow):
      (QWebPageAdapter::triggerAction):
      (QWebPageAdapter::currentFrame):
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebContextMenuClient.cpp:
      (WebContextMenuClient::searchWithGoogle):
      * WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebFrameLoaderClient::updateGlobalHistory):
      (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
      (WebFrameLoaderClient::savePlatformDataToCachedFrame):
      (WebFrameLoaderClient::createFrame):
      (WebFrameLoaderClient::dispatchDidFailToStartPlugin):
      * WebCoreSupport/WebFrameNetworkingContext.cpp:
      (WebFrameNetworkingContext::blockedError):
      (WebFrameNetworkingContext::referrer):
      * WebElementPropertyBag.cpp:
      (WebElementPropertyBag::Read):
      * WebFrame.cpp:
      (kit):
      (WebFrame::reloadFromOrigin):
      (WebFrame::loadRequest):
      (WebFrame::loadData):
      (WebFrame::dataSource):
      (WebFrame::provisionalDataSource):
      (WebFrame::stopLoading):
      (WebFrame::reload):
      (WebFrame::firstLayoutDone):
      (WebFrame::loadType):
      (WebFrame::clearOpener):
      (WebFrame::dispatchWillSubmitForm):
      (WebFrame::receivedPolicyDecision):
      (WebFrame::dispatchDecidePolicyForResponse):
      (WebFrame::dispatchDecidePolicyForNewWindowAction):
      (WebFrame::dispatchDecidePolicyForNavigationAction):
      (WebFrame::createJavaAppletWidget):
      * WebFramePolicyListener.cpp:
      (WebFramePolicyListener::receivedPolicyDecision):
      * WebView.cpp:
      (WebView::close):
      (WebView::canShowMIMEType):
      (WebView::setCustomTextEncodingName):
      (WebView::loadBackForwardListFromOtherView):
      (WebView::shouldClose):
      
      Source/WebKit/wince:
      
      * WebCoreSupport/FrameLoaderClientWinCE.cpp:
      (WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForResponse):
      (WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForNewWindowAction):
      (WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForNavigationAction):
      (WebKit::FrameLoaderClientWinCE::dispatchWillSubmitForm):
      * WebCoreSupport/FrameNetworkingContextWinCE.cpp:
      (WebKit::FrameNetworkingContextWinCE::referrer):
      * WebView.cpp:
      (WebView::createFrame):
      (WebView::load):
      (WebView::reload):
      (WebView::stop):
      
      Source/WebKit2:
      
      * Shared/WebRenderLayer.cpp:
      (WebKit::WebRenderLayer::create):
      * Shared/WebRenderObject.cpp:
      (WebKit::WebRenderObject::create):
      * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
      (WebKit::GeolocationPermissionRequestManager::startRequestForGeolocation):
      * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
      (WKBundleFrameGetFrameLoadState):
      (WKBundleFrameClearOpener):
      (WKBundleFrameCallShouldCloseOnWebView):
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      (WebKit::InjectedBundleNodeHandle::documentFrame):
      (WebKit::InjectedBundleNodeHandle::htmlFrameElementContentFrame):
      (WebKit::InjectedBundleNodeHandle::htmlIFrameElementContentFrame):
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
      * WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
      (WebKit::InjectedBundleDOMWindowExtension::frame):
      * WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
      (WebKit::InjectedBundleHitTestResult::frame):
      (WebKit::InjectedBundleHitTestResult::targetFrame):
      * WebProcess/Plugins/PDF/PDFPlugin.mm:
      (WebKit::PDFPlugin::clickedLink):
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::webPage):
      (WebKit::PluginView::didFailToInitializePlugin):
      (WebKit::PluginView::performFrameLoadURLRequest):
      (WebKit::PluginView::userAgent):
      (WebKit::PluginView::loadURL):
      (WebKit::PluginView::cancelManualStreamLoad):
      (WebKit::PluginView::proxiesForURL):
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::focusedElementChanged):
      (WebKit::WebChromeClient::focusedFrameChanged):
      (WebKit::WebChromeClient::runBeforeUnloadConfirmPanel):
      (WebKit::WebChromeClient::closeWindowSoon):
      (WebKit::WebChromeClient::runJavaScriptAlert):
      (WebKit::WebChromeClient::runJavaScriptConfirm):
      (WebKit::WebChromeClient::runJavaScriptPrompt):
      (WebKit::WebChromeClient::unavailablePluginButtonClicked):
      (WebKit::WebChromeClient::print):
      (WebKit::WebChromeClient::exceededDatabaseQuota):
      (WebKit::WebChromeClient::runOpenPanel):
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      (WebKit::WebContextMenuClient::searchWithGoogle):
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      (WebKit::WebEditorClient::textFieldDidBeginEditing):
      (WebKit::WebEditorClient::textFieldDidEndEditing):
      (WebKit::WebEditorClient::textDidChangeInTextField):
      (WebKit::WebEditorClient::textDidChangeInTextArea):
      (WebKit::WebEditorClient::doTextFieldCommandFromEvent):
      (WebKit::WebEditorClient::textWillBeDeletedInTextField):
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
      (WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
      (WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
      (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
      (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
      (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
      (WebKit::WebFrameLoaderClient::dispatchWillSendSubmitEvent):
      (WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
      (WebKit::WebFrameLoaderClient::updateGlobalHistory):
      (WebKit::WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
      (WebKit::WebFrameLoaderClient::restoreViewState):
      (WebKit::WebFrameLoaderClient::createFrame):
      (WebKit::WebFrameLoaderClient::createJavaAppletWidget):
      (WebKit::WebFrameLoaderClient::objectContentType):
      * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
      (WebKit::WebPlatformStrategies::getPluginInfo):
      * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
      (WebKit::WebFrameNetworkingContext::blockedError):
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::didReceivePolicyDecision):
      (WebKit::WebFrame::startDownload):
      (WebKit::WebFrame::source):
      (WebKit::WebFrame::contentsAsString):
      (WebKit::WebFrame::url):
      (WebKit::WebFrame::parentFrame):
      (WebKit::WebFrame::childFrames):
      (WebKit::WebFrame::stopLoading):
      (WebKit::WebFrame::frameForContext):
      (WebKit::WebFrame::provisionalURL):
      (WebKit::WebFrame::suggestedFilenameForResourceWithURL):
      (WebKit::WebFrame::mimeTypeForResourceWithURL):
      (WebKit::WebFrameFilter::shouldIncludeSubframe):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::createPlugin):
      (WebKit::WebPage::close):
      (WebKit::WebPage::tryClose):
      (WebKit::WebPage::loadURLRequest):
      (WebKit::WebPage::loadDataImpl):
      (WebKit::WebPage::linkClicked):
      (WebKit::WebPage::stopLoadingFrame):
      (WebKit::WebPage::stopLoading):
      (WebKit::WebPage::reload):
      (WebKit::WebPage::tryRestoreScrollPosition):
      (WebKit::WebPage::getMainResourceDataOfFrame):
      (WebKit::resourceDataForFrame):
      (WebKit::shouldReuseCommittedSandboxExtension):
      (WebKit::WebPage::SandboxExtensionTracker::didStartProvisionalLoad):
      (WebKit::WebPage::hasLocalDataForURL):
      (WebKit::WebPage::setCustomTextEncodingName):
      (WebKit::WebPage::canPluginHandleResponse):
      (WebKit::WebPage::canShowMIMEType):
      (WebKit::WebPage::didCommitLoad):
      * WebProcess/WebPage/mac/WebPageMac.mm:
      (WebKit::WebPage::platformHasLocalDataForURL):
      (WebKit::cachedResponseForURL):
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::downloadRequest):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154142 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df550b96
  24. 11 Aug, 2013 1 commit
  25. 27 Jun, 2013 1 commit
    • commit-queue@webkit.org's avatar
      Polish context menus for media elements · fe125904
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118078
      <rdar://problem/14278960>
      
      Patch by Ruth Fong <ruth_fong@apple.com> on 2013-06-27
      Reviewed by Eric Carlson.
      
      No new tests: media/context-menu-action.html,
      which has been disabled by bug 116651, is used to test context menus.
      
      * English.lproj/Localizable.strings: Changed "Fullscreen" to "Full Screen"
      and added strings "Show Controls" and "Hide Controls".
      
      * page/ContextMenuController.cpp: Updated to include a new context menu item
      that toggles betweeen "Show Controls" and "Hide Controls".
      
      * platform/ContextMenuItem.h:
      
      * platform/LocalizedStrings.cpp:
      * platform/LocalizedStrings.h:
      * platform/efl/LocalizedStringsEfl.cpp:
      * platform/gtk/LocalizedStringsGtk.cpp:
      * platform/qt/LocalizedStringsQt.cpp:
      Added equivalents of localized strings "Show Controls" and "Hide Controls".
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152117 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe125904
  26. 17 Jun, 2013 3 commits
    • commit-queue@webkit.org's avatar
      REGRESSION: Important controls are missing from <video> element UI, when compared to QuickTime · bfadee5c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=20599
      
      Add a "Download Video"/"Download Audio" context menu item to download media
      elements.
      
      Patch by Ruth Fong <ruth_fong@apple.com> on 2013-06-17
      Reviewed by Beth Dakin.
      
      Source/WebCore:
      
      No new tests. media/context-menu-action.html,
      which has been disabled by bug 116651, is used to test context menus.
      
      * English.lproj/Localizable.strings: Updated to
      include localizable strings for "Download Video" and "Download Audio".
      
      * page/ContextMenuController.cpp: Updated to
      include and handle a "Download Video/Audio" context menu item.
      
      * platform/ContextMenuItem.h:
      
      * platform/LocalizedStrings.cpp:
      * platform/LocalizedStrings.h:
      * platform/efl/LocalizedStringsEfl.cpp:
      * platform/gtk/LocalizedStringsGtk.cpp:
      * platform/qt/LocalizedStringsQt.cpp:
      Updated to include localizable strings for "Download Video" and "Download Audio".
      
      Source/WebKit/efl:
      
      * WebCoreSupport/AssertMatchingEnums.cpp:
      * ewk/ewk_contextmenu.h:
      Updated to include new EWK enum type for "Download Video/Audio" context menu item.
      
      Source/WebKit2:
      
      * Shared/API/c/WKContextMenuItemTypes.h: Updated to include
      an enum type for the "Download Video/Audio" context menu item.
      
      * Shared/API/c/WKSharedAPICast.h: Updated to associate
      the enums in WebKit and WebCore that handle the "Download Video/Audio"
      context menu item.
      
      * UIProcess/API/efl/ewk_context_menu.cpp:
      * UIProcess/API/efl/ewk_context_menu_item.cpp:
      * UIProcess/API/efl/ewk_context_menu_item.h:
      Updated to include new EWK enum type for "Download Video/Audio" context menu item.
      
      * UIProcess/WebPageProxy.cpp: Updated to
      handle the "Download Video/Audio" context menu item mouse click
      and download the media item in the UI process.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151656 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bfadee5c
    • g.czajkowski@samsung.com's avatar
      Unreviewed, rolling out r151632. · 7e0d38d7
      g.czajkowski@samsung.com authored
      http://trac.webkit.org/changeset/151632
      https://bugs.webkit.org/show_bug.cgi?id=117585
      
      Debug build error ASSERT(WTF_USE_GRAMMAR_CHECKING) for non MAC
      platforms
      
      Source/WebCore:
      
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::contextMenuItemSelected):
      (WebCore::ContextMenuController::createAndAppendSpellingAndGrammarSubMenu):
      (WebCore::ContextMenuController::populate):
      (WebCore::ContextMenuController::checkOrEnableIfNeeded):
      * platform/LocalizedStrings.cpp:
      (WebCore::contextMenuItemTagSpellingMenu):
      (WebCore::contextMenuItemTagShowSpellingPanel):
      (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
      * platform/LocalizedStrings.h:
      * platform/efl/LocalizedStringsEfl.cpp:
      (WebCore::contextMenuItemTagSpellingMenu):
      (WebCore::contextMenuItemTagShowSpellingPanel):
      (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
      * platform/gtk/LocalizedStringsGtk.cpp:
      (WebCore::contextMenuItemTagSpellingMenu):
      (WebCore::contextMenuItemTagShowSpellingPanel):
      (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
      * platform/qt/LocalizedStringsQt.cpp:
      (WebCore::contextMenuItemTagSpellingMenu):
      (WebCore::contextMenuItemTagShowSpellingPanel):
      (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
      
      Source/WebKit/gtk:
      
      * webkit/webkitglobals.cpp:
      (webkit_context_menu_item_get_action):
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebContextMenuClient.mm:
      (fixMenusReceivedFromOldClients):
      
      Source/WebKit2:
      
      * Shared/API/c/WKSharedAPICast.h:
      (WebKit::toAPI):
      (WebKit::toImpl):
      * UIProcess/API/efl/ewk_context_menu_item.cpp:
      (getEwkActionFromWKTag):
      * UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
      (onContextMenuShow):
      (TEST_F):
      * UIProcess/API/gtk/WebKitContextMenuActions.cpp:
      (webkitContextMenuActionGetActionTag):
      (webkitContextMenuActionGetForContextMenuItem):
      (webkitContextMenuActionGetLabel):
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::contextMenuItemSelected):
      
      Source/WTF:
      
      * wtf/Platform.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e0d38d7
    • g.czajkowski@samsung.com's avatar
      Context menu grammar checking items are available when GRAMMAR_CHECKING macro is off · 9facbdb9
      g.czajkowski@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=117585
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore:
      
      Do not add "Check Grammar With Spelling" and "Ignore Grammar" to the context menu
      when GRAMMAR_CHECKING is off.
      Replace "Spelling and Grammar" with "Spelling" as the sub menu title and "Show/Hide Spelling
      and Grammar" with "Show/Hide Spelling" when GRAMMAR_CHECKING is off.
      
      Additionally, guard grammar checking in context menu code to not necessarily
      compile it.
      
      No new layout tests because every port has a different way of showing
      spelling/grammar context menu items.
      
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::contextMenuItemSelected):
      (WebCore::ContextMenuController::createAndAppendSpellingAndGrammarSubMenu):
      (WebCore::ContextMenuController::populate):
      (WebCore::ContextMenuController::checkOrEnableIfNeeded):
      * platform/LocalizedStrings.cpp:
      (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
      (WebCore::contextMenuItemTagSpellingMenu):
      (WebCore::contextMenuItemTagShowSpellingPanel):
      * platform/LocalizedStrings.h:
      * platform/efl/LocalizedStringsEfl.cpp:
      (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
      (WebCore::contextMenuItemTagSpellingMenu):
      (WebCore::contextMenuItemTagShowSpellingPanel):
      * platform/gtk/LocalizedStringsGtk.cpp:
      (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
      (WebCore::contextMenuItemTagSpellingMenu):
      (WebCore::contextMenuItemTagShowSpellingPanel):
      * platform/qt/LocalizedStringsQt.cpp:
      (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
      (WebCore::contextMenuItemTagSpellingMenu):
      (WebCore::contextMenuItemTagShowSpellingPanel):
      
      Source/WebKit/gtk:
      
      Add GRAMMAR_CHECKING guard to the context menu grammar items.
      
      * webkit/webkitglobals.cpp:
      (webkit_context_menu_item_get_action):
      
      Source/WebKit/mac:
      
      Add GRAMMAR_CHECKING guard to the context menu grammar items.
      
      * WebCoreSupport/WebContextMenuClient.mm:
      (fixMenusReceivedFromOldClients):
      
      Source/WebKit2:
      
      Add GRAMMAR_CHECKING guard to the context menu grammar items.
      
      * Shared/API/c/WKSharedAPICast.h:
      (WebKit::toAPI):
      (WebKit::toImpl):
      * UIProcess/API/efl/ewk_context_menu_item.cpp:
      (getEwkActionFromWKTag):
      * UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
      (checkSpellingItemsAvailability):
      Change callback name, to be consistent with a newly added.
      
      (checkSpellingAndGrammarSubmenuAvailability):
      (checkGrammarWithSpellingItemAvailability):
      Add two unit tests for EFL to check whether context menu grammar items are
      available only when GRAMMAR_CHECKING macro is enabled.
      
      * UIProcess/API/gtk/WebKitContextMenuActions.cpp:
      (webkitContextMenuActionGetActionTag):
      (webkitContextMenuActionGetForContextMenuItem):
      (webkitContextMenuActionGetLabel):
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::contextMenuItemSelected):
      
      Source/WTF:
      
      Enable GRAMMAR_CHECKING for WebKit ports that use/implement it.
      
      * wtf/Platform.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9facbdb9
  27. 12 Jun, 2013 1 commit
    • commit-queue@webkit.org's avatar
      Allow for toggling fullscreen on <video> elements · 0f4ee83b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=117220
      
      Patch by Ruth Fong <ruth_fong@apple.com> on 2013-06-12
      Reviewed by Dean Jackson.
      
      Source/WebCore:
      
      This patch adds the ability for fullscreen
      context menu item on <video> elements to switch between "Enter Fullscreen"
      and "Exit Fullscreen" and behave appropriately.
      
      No new tests. media/context-menu-action.html,
      which has been disabled by bug 116651, is used to test context menus.
      
      * English.lproj/Localizable.strings: Add "Exit Fullscreen" string.
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::toggleFullscreenState): Added to appropriately enter/exit fullscreen.
      * html/HTMLMediaElement.h:
      * page/ContextMenuController.cpp:
      * platform/ContextMenuItem.h:
      * platform/LocalizedStrings.cpp:
      * platform/LocalizedStrings.h:
      Updated to rename variables more appropriately to reflect the toggle-ability of video fullscreen.
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestResult::mediaIsInFullscreen): Added to check if an element
      was a media element in fullscreen.
      (WebCore::HitTestResult::toggleMediaFullscreenState): Added to hook into
      HTMLMediaElement::toggleFullscreenState.
      * rendering/HitTestResult.h:
      
      Source/WebKit2:
      
      * Shared/API/c/WKContextMenuItemTypes.h:
      * Shared/API/c/WKSharedAPICast.h:
      Added variables to support the toggle-ability of the fullscreen
      video context menu item.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f4ee83b
  28. 23 May, 2013 1 commit
  29. 17 May, 2013 1 commit
    • akling@apple.com's avatar
      Page::chrome() should return a reference. · bd774814
      akling@apple.com authored
      <http://webkit.org/b/116185>
      
      Source/WebCore:
      
      Reviewed by Anders Carlsson.
      
      A Page's chrome() can never be null. Change Page::chrome() to return a reference to reflect this.
      Also, make Page::m_chrome a const member variable so nobody will accidentally set it to null.
      
      Source/WebKit/blackberry:
      
      Reviewed by Anders Carlsson.
      
      Source/WebKit/efl:
      
      Reviewed by Anders Carlsson.
      
      Source/WebKit/gtk:
      
      Reviewed by Anders Carlsson.
      
      Source/WebKit/mac:
      
      Reviewed by Anders Carlsson.
      
      Source/WebKit/qt:
      
      Reviewed by Anders Carlsson.
      
      Source/WebKit/win:
      
      Reviewed by Anders Carlsson.
      
      Source/WebKit2:
      
      Reviewed by Anders Carlsson.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150214 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd774814
  30. 15 May, 2013 1 commit
    • andersca@apple.com's avatar
      Frame::editor() should return a reference · b4170928
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116037
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      A frame's editor can never be null. Change Frame::editor() to return a reference to reflect this.
      Also, make Frame::m_editor a const member variable so nobody will accidentally set it to null.
      
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::hasMisspelling):
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      (AXAttributeStringSetSpelling):
      * dom/ContainerNode.cpp:
      (WebCore::ContainerNode::cloneChildNodes):
      * dom/Document.cpp:
      (WebCore::acceptsEditingFocus):
      (WebCore::Document::setFocusedNode):
      (WebCore::command):
      * editing/AlternativeTextController.cpp:
      (WebCore::AlternativeTextController::timerFired):
      (WebCore::AlternativeTextController::applyDictationAlternative):
      * editing/CompositeEditCommand.cpp:
      (WebCore::EditCommandComposition::unapply):
      (WebCore::EditCommandComposition::reapply):
      (WebCore::CompositeEditCommand::apply):
      (WebCore::CompositeEditCommand::moveParagraphs):
      * editing/DeleteButton.cpp:
      (WebCore::DeleteButton::defaultEventHandler):
      * editing/DeleteButtonController.cpp:
      (WebCore::DeleteButtonController::show):
      * editing/DeleteButtonController.h:
      (WebCore::DeleteButtonControllerDisableScope::DeleteButtonControllerDisableScope):
      (WebCore::DeleteButtonControllerDisableScope::~DeleteButtonControllerDisableScope):
      * editing/DeleteSelectionCommand.cpp:
      (WebCore::DeleteSelectionCommand::mergeParagraphs):
      (WebCore::DeleteSelectionCommand::doApply):
      * editing/EditCommand.cpp:
      (WebCore::EditCommand::EditCommand):
      * editing/EditingStyle.cpp:
      (WebCore::StyleChange::StyleChange):
      * editing/Editor.cpp:
      (WebCore::Editor::markMisspellingsAfterTypingToWord):
      * editing/EditorCommand.cpp:
      (WebCore::applyCommandToFrame):
      (WebCore::executeToggleStyle):
      (WebCore::executeApplyParagraphStyle):
      (WebCore::expandSelectionToGranularity):
      (WebCore::stateStyle):
      (WebCore::valueStyle):
      (WebCore::executeCopy):
      (WebCore::executeCut):
      (WebCore::executeDefaultParagraphSeparator):
      (WebCore::executeDelete):
      (WebCore::executeDeleteBackward):
      (WebCore::executeDeleteBackwardByDecomposingPreviousCharacter):
      (WebCore::executeDeleteForward):
      (WebCore::executeDeleteToBeginningOfLine):
      (WebCore::executeDeleteToBeginningOfParagraph):
      (WebCore::executeDeleteToEndOfLine):
      (WebCore::executeDeleteToEndOfParagraph):
      (WebCore::executeDeleteToMark):
      (WebCore::executeDeleteWordBackward):
      (WebCore::executeDeleteWordForward):
      (WebCore::executeFindString):
      (WebCore::executeForwardDelete):
      (WebCore::executeIgnoreSpelling):
      (WebCore::executeInsertNewline):
      (WebCore::executeMakeTextWritingDirectionLeftToRight):
      (WebCore::executeMakeTextWritingDirectionNatural):
      (WebCore::executeMakeTextWritingDirectionRightToLeft):
      (WebCore::executeToggleOverwrite):
      (WebCore::executePaste):
      (WebCore::executePasteGlobalSelection):
      (WebCore::executePasteAndMatchStyle):
      (WebCore::executePasteAsPlainText):
      (WebCore::executeRedo):
      (WebCore::executeRemoveFormat):
      (WebCore::executeSelectToMark):
      (WebCore::executeSetMark):
      (WebCore::executeStyleWithCSS):
      (WebCore::executeUseCSS):
      (WebCore::executeSwapWithMark):
      (WebCore::executeTakeFindStringFromSelection):
      (WebCore::executeTranspose):
      (WebCore::executeUndo):
      (WebCore::executeYank):
      (WebCore::executeYankAndSelect):
      (WebCore::supportedCopyCut):
      (WebCore::supportedPaste):
      (WebCore::enabledVisibleSelection):
      (WebCore::enabledVisibleSelectionAndMark):
      (WebCore::enableCaretInEditableText):
      (WebCore::enabledCopy):
      (WebCore::enabledCut):
      (WebCore::enabledInEditableText):
      (WebCore::enabledDelete):
      (WebCore::enabledPaste):
      (WebCore::enabledRedo):
      (WebCore::enabledTakeFindStringFromSelection):
      (WebCore::enabledUndo):
      (WebCore::stateOrderedList):
      (WebCore::stateStyleWithCSS):
      (WebCore::stateUnorderedList):
      (WebCore::valueDefaultParagraphSeparator):
      * editing/FrameSelection.cpp:
      (WebCore::shouldAlwaysUseDirectionalSelection):
      (WebCore::FrameSelection::setSelection):
      (WebCore::FrameSelection::nextWordPositionForPlatform):
      (WebCore::FrameSelection::modifyMovingRight):
      (WebCore::FrameSelection::modifyMovingLeft):
      (WebCore::FrameSelection::modify):
      (WebCore::shouldStopBlinkingDueToTypingCommand):
      (WebCore::FrameSelection::shouldDeleteSelection):
      (WebCore::FrameSelection::shouldChangeSelection):
      * editing/InsertTextCommand.cpp:
      (WebCore::InsertTextCommand::doApply):
      * editing/SpellChecker.cpp:
      (WebCore::SpellChecker::didCheck):
      * editing/SpellingCorrectionCommand.cpp:
      * editing/TypingCommand.cpp:
      (WebCore::TypingCommand::insertText):
      (WebCore::TypingCommand::lastTypingCommandIfStillOpenForTyping):
      (WebCore::TypingCommand::markMisspellingsAfterTyping):
      (WebCore::TypingCommand::typingAddedToOpenCommand):
      (WebCore::TypingCommand::deleteKeyPressed):
      (WebCore::TypingCommand::forwardDeleteKeyPressed):
      * editing/htmlediting.cpp:
      (WebCore::createDefaultParagraphElement):
      * editing/mac/EditorMac.mm:
      (WebCore::Editor::pasteWithPasteboard):
      * editing/markup.cpp:
      (WebCore::createMarkup):
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::endEditing):
      * html/HTMLTextAreaElement.cpp:
      (WebCore::HTMLTextAreaElement::subtreeHasChanged):
      * html/TextFieldInputType.cpp:
      (WebCore::TextFieldInputType::handleKeydownEvent):
      (WebCore::TextFieldInputType::didSetValueByUserEdit):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::closeURL):
      (WebCore::FrameLoader::didOpenURL):
      (WebCore::FrameLoader::clear):
      * page/ContextMenuController.cpp:
      (WebCore::insertUnicodeCharacter):
      (WebCore::ContextMenuController::contextMenuItemSelected):
      (WebCore::ContextMenuController::populate):
      (WebCore::ContextMenuController::checkOrEnableIfNeeded):
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::find):
      * page/DragController.cpp:
      (WebCore::DragController::dispatchTextInputEventFor):
      (WebCore::DragController::concludeEditDrag):
      (WebCore::DragController::startDrag):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::selectClosestWordFromMouseEvent):
      (WebCore::EventHandler::handleMousePressEventSingleClick):
      (WebCore::EventHandler::handlePasteGlobalSelection):
      (WebCore::EventHandler::sendContextMenuEvent):
      (WebCore::EventHandler::sendContextMenuEventForKey):
      (WebCore::EventHandler::keyEvent):
      (WebCore::EventHandler::defaultKeyboardEventHandler):
      (WebCore::EventHandler::defaultTextInputEventHandler):
      (WebCore::EventHandler::defaultBackspaceEventHandler):
      * page/FocusController.cpp:
      (WebCore::relinquishesEditingFocus):
      * page/Frame.cpp:
      (WebCore::Frame::rangeForPoint):
      * page/Frame.h:
      (Frame):
      (WebCore::Frame::editor):
      * page/Page.cpp:
      (WebCore::Page::findString):
      (WebCore::Page::findStringMatchingRanges):
      (WebCore::Page::rangeOfString):
      (WebCore::Page::markAllMatchesForText):
      (WebCore::Page::setDeviceScaleFactor):
      * platform/mac/ClipboardMac.mm:
      (WebCore::ClipboardMac::writeRange):
      * platform/mac/DragDataMac.mm:
      (WebCore::DragData::asURL):
      * platform/mac/PasteboardMac.mm:
      (WebCore::Pasteboard::getStringSelection):
      (WebCore::Pasteboard::getDataSelection):
      (WebCore::Pasteboard::writeSelectionForTypes):
      (WebCore::writeURLForTypes):
      (WebCore::Pasteboard::plainText):
      (WebCore::documentFragmentWithRTF):
      (WebCore::Pasteboard::documentFragment):
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestResult::dictationAlternatives):
      * rendering/InlineTextBox.cpp:
      (WebCore::InlineTextBox::paint):
      (WebCore::InlineTextBox::paintTextMatchMarker):
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::positionForPointWithInlineChildren):
      * testing/Internals.cpp:
      (WebCore::spellchecker):
      (WebCore::Internals::resetToConsistentState):
      (WebCore::Internals::hasSpellingMarker):
      (WebCore::Internals::hasAutocorrectedMarker):
      (WebCore::Internals::setContinuousSpellCheckingEnabled):
      (WebCore::Internals::setAutomaticQuoteSubstitutionEnabled):
      (WebCore::Internals::setAutomaticLinkDetectionEnabled):
      (WebCore::Internals::setAutomaticDashSubstitutionEnabled):
      (WebCore::Internals::setAutomaticTextReplacementEnabled):
      (WebCore::Internals::setAutomaticSpellingCorrectionEnabled):
      (WebCore::Internals::isOverwriteModeEnabled):
      (WebCore::Internals::toggleOverwriteModeEnabled):
      (WebCore::Internals::hasGrammarMarker):
      
      Source/WebKit/blackberry:
      
      * WebCoreSupport/EditorClientBlackBerry.cpp:
      (WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
      (WebCore::EditorClientBlackBerry::handleKeyboardEvent):
      * WebKitSupport/DOMSupport.cpp:
      (BlackBerry::WebKit::DOMSupport::elementHasContinuousSpellCheckingEnabled):
      * WebKitSupport/InPageSearchManager.cpp:
      (BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
      (BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
      * WebKitSupport/SelectionHandler.cpp:
      (BlackBerry::WebKit::SelectionHandler::selectedText):
      
      Source/WebKit/efl:
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      (DumpRenderTreeSupportEfl::executeCoreCommandByName):
      (DumpRenderTreeSupportEfl::isCommandEnabled):
      * WebCoreSupport/EditorClientEfl.cpp:
      (WebCore::EditorClientEfl::respondToChangedSelection):
      (WebCore::EditorClientEfl::handleEditingKeyboardEvent):
      * ewk/ewk_frame.cpp:
      (ewk_frame_editable_set):
      (ewk_frame_selection_get):
      (ewk_frame_text_search):
      (ewk_frame_text_matches_mark):
      (ewk_frame_text_matches_highlight_set):
      (ewk_frame_text_matches_highlight_get):
      * ewk/ewk_view.cpp:
      (ewk_view_selection_get):
      (ewk_view_editor_command_execute):
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::paint):
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
      (DumpRenderTreeSupportGtk::executeCoreCommandByName):
      (DumpRenderTreeSupportGtk::isCommandEnabled):
      * WebCoreSupport/EditorClientGtk.cpp:
      (WebKit::EditorClient::respondToChangedSelection):
      (WebKit::EditorClient::executePendingEditorCommands):
      (WebKit::EditorClient::handleKeyboardEvent):
      * WebCoreSupport/WebViewInputMethodFilter.cpp:
      (WebKit::WebViewInputMethodFilter::canEdit):
      (WebKit::WebViewInputMethodFilter::confirmCompositionText):
      (WebKit::WebViewInputMethodFilter::confirmCurrentComposition):
      (WebKit::WebViewInputMethodFilter::cancelCurrentComposition):
      (WebKit::WebViewInputMethodFilter::setPreedit):
      * webkit/webkitwebframe.cpp:
      (webkit_web_frame_replace_selection):
      * webkit/webkitwebview.cpp:
      (getLocationForKeyboardGeneratedContextMenu):
      (webkit_web_view_focus_in_event):
      (webkit_web_view_real_select_all):
      (webkit_web_view_real_cut_clipboard):
      (webkit_web_view_real_copy_clipboard):
      (webkit_web_view_real_undo):
      (webkit_web_view_real_redo):
      (webkit_web_view_real_paste_clipboard):
      (webkit_web_view_set_highlight_text_matches):
      (webkit_web_view_can_cut_clipboard):
      (webkit_web_view_can_copy_clipboard):
      (webkit_web_view_can_paste_clipboard):
      (webkit_web_view_delete_selection):
      (webkit_web_view_set_editable):
      (webkit_web_view_can_undo):
      (webkit_web_view_can_redo):
      
      Source/WebKit/mac:
      
      * WebView/WebFrame.mm:
      (-[WebFrame _selectedString]):
      (-[WebFrame _firstRectForDOMRange:]):
      (-[WebFrame _markDOMRange]):
      (-[WebFrame _insertParagraphSeparatorInQuotedContent]):
      (-[WebFrame _setTypingStyle:withUndoAction:]):
      (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
      * WebView/WebHTMLRepresentation.mm:
      (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
      (-[WebHTMLView _shouldDeleteRange:]):
      (-[WebHTMLView _canEdit]):
      (-[WebHTMLView _canEditRichly]):
      (-[WebHTMLView _insertOrderedList]):
      (-[WebHTMLView _insertUnorderedList]):
      (-[WebHTMLView _canIncreaseSelectionListLevel]):
      (-[WebHTMLView _canDecreaseSelectionListLevel]):
      (-[WebHTMLView _increaseSelectionListLevel]):
      (-[WebHTMLView _increaseSelectionListLevelOrdered]):
      (-[WebHTMLView _increaseSelectionListLevelUnordered]):
      (-[WebHTMLView _decreaseSelectionListLevel]):
      (-[WebHTMLView Editor::coreCommandBySelector:]):
      (-[WebHTMLView Editor::coreCommandByName:]):
      (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
      (-[WebHTMLView becomeFirstResponder]):
      (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
      (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
      (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
      (-[WebHTMLView checkSpelling:]):
      (-[WebHTMLView showGuessPanel:]):
      (-[WebHTMLView toggleBaseWritingDirection:]):
      (-[WebHTMLView changeBaseWritingDirection:]):
      (-[WebHTMLView _changeBaseWritingDirectionTo:]):
      (-[WebHTMLView _updateFontPanel]):
      (-[WebHTMLView markedRange]):
      (-[WebHTMLView hasMarkedText]):
      (-[WebHTMLView unmarkText]):
      (-[WebHTMLView setMarkedText:selectedRange:]):
      (-[WebHTMLView doCommandBySelector:]):
      (-[WebHTMLView insertText:]):
      (-[WebHTMLView _updateSelectionForInputManager]):
      (-[WebHTMLView countMatchesForText:inDOMRange:options:limit:markMatches:]):
      (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]):
      (-[WebHTMLView markedTextMatchesAreHighlighted]):
      (-[WebHTMLView _findString:options:]):
      * WebView/WebView.mm:
      (-[WebView _executeCoreCommandByName:value:]):
      (-[WebView editableDOMRangeForPoint:]):
      (-[WebView setEditable:]):
      (-[WebView deleteSelection]):
      (-[WebView applyStyle:]):
      (-[WebView typingAttributes]):
      (-[WebView _simplifyMarkup:endNode:]):
      (-[WebView handleAcceptedAlternativeText:]):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::executeCoreCommandByName):
      (DumpRenderTreeSupportQt::isCommandEnabled):
      (DumpRenderTreeSupportQt::firstRectForCharacterRange):
      * WebCoreSupport/EditorClientQt.cpp:
      (WebCore::EditorClientQt::respondToChangedSelection):
      (WebCore::EditorClientQt::registerUndoStep):
      (WebCore::EditorClientQt::handleKeyboardEvent):
      * WebCoreSupport/QWebPageAdapter.cpp:
      (QWebPageAdapter::selectedText):
      (QWebPageAdapter::selectedHtml):
      (QWebPageAdapter::setContentEditable):
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebContextMenuClient.cpp:
      (WebContextMenuClient::searchWithGoogle):
      * WebFrame.cpp:
      (WebFrame::hasSpellingMarker):
      (WebFrame::setTextDirection):
      (WebFrame::selectedString):
      (WebFrame::selectAll):
      * WebView.cpp:
      (WebView::execCommand):
      (WebView::handleEditingKeyboardEvent):
      (WebView::executeCoreCommandByName):
      (WebView::selectedText):
      (WebView::deleteEnabled):
      (WebView::editingEnabled):
      (WebView::replaceSelectionWithText):
      (WebView::copy):
      (WebView::cut):
      (WebView::paste):
      (WebView::copyURL):
      (WebView::delete_):
      (WebView::checkSpelling):
      (WebView::showGuessPanel):
      (WebView::clearUndoRedoOperations):
      (WebView::prepareCandidateWindow):
      (WebView::resetIME):
      (WebView::updateSelectionForIME):
      (WebView::onIMEComposition):
      (WebView::onIMEEndComposition):
      (WebView::onIMERequestCharPosition):
      (WebView::onIMERequest):
      (WebView::setCompositionForTesting):
      (WebView::hasCompositionForTesting):
      (WebView::confirmCompositionForTesting):
      (WebView::compositionRangeForTesting):
      (WebView::firstRectForCharacterRangeForTesting):
      (WebView::selectedRangeForTesting):
      
      Source/WebKit/wince:
      
      * WebCoreSupport/EditorClientWinCE.cpp:
      (WebKit::EditorClientWinCE::handleEditingKeyboardEvent):
      
      Source/WebKit2:
      
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      (WebKit::WebContextMenuClient::searchWithGoogle):
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      (WebKit::WebEditorClient::updateGlobalSelection):
      * WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:
      (WebKit::WebEditorClient::handleInputMethodKeydown):
      * WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:
      (WebKit::WebEditorClient::executePendingEditorCommands):
      (WebKit::WebEditorClient::handleKeyboardEvent):
      * WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
      (WebKit::WebContextMenuClient::searchWithGoogle):
      (WebKit::WebContextMenuClient::searchWithSpotlight):
      * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
      (WebKit::changeWordCase):
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::selectionAsString):
      (WebKit::WebFrame::setTextDirection):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::editorState):
      (WebKit::WebPage::executeEditingCommand):
      (WebKit::WebPage::isEditingCommandEnabled):
      (WebKit::WebPage::validateCommand):
      (WebKit::WebPage::handleEditingKeyboardEvent):
      (WebKit::WebPage::advanceToNextMisspelling):
      (WebKit::WebPage::uppercaseWord):
      (WebKit::WebPage::lowercaseWord):
      (WebKit::WebPage::capitalizeWord):
      (WebKit::WebPage::replaceSelectionWithText):
      (WebKit::WebPage::handleAlternativeTextUIResult):
      (WebKit::WebPage::setCompositionForTesting):
      (WebKit::WebPage::hasCompositionForTesting):
      (WebKit::WebPage::confirmCompositionForTesting):
      (WebKit::WebPage::setComposition):
      (WebKit::WebPage::cancelComposition):
      * WebProcess/WebPage/efl/WebPageEfl.cpp:
      (WebKit::WebPage::confirmComposition):
      (WebKit::WebPage::setComposition):
      (WebKit::WebPage::cancelComposition):
      * WebProcess/WebPage/mac/WebPageMac.mm:
      (WebKit::WebPage::executeKeypressCommandsInternal):
      (WebKit::WebPage::handleEditingKeyboardEvent):
      (WebKit::WebPage::setComposition):
      (WebKit::WebPage::confirmComposition):
      (WebKit::WebPage::cancelComposition):
      (WebKit::WebPage::insertText):
      (WebKit::WebPage::insertDictatedText):
      (WebKit::WebPage::getMarkedRange):
      (WebKit::WebPage::firstRectForCharacterRange):
      (WebKit::WebPage::readSelectionFromPasteboard):
      (WebKit::WebPage::getStringSelectionForPasteboard):
      (WebKit::WebPage::getDataSelectionForPasteboard):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150140 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4170928
  31. 05 Apr, 2013 1 commit
    • rniwa@webkit.org's avatar
      Remove code for 10.5 and earlier from Source/WebCore · 6690896b
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113754
      
      Reviewed by Benjamin Poulain.
      
      Removed the code for 10.5 and removed if-def for 10.6.
      
      * WebCore.xcodeproj/project.pbxproj:
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::populate):
      * platform/LocalizedStrings.cpp:
      (WebCore::imageTitle):
      * platform/graphics/cg/GraphicsContextCG.cpp:
      (WebCore::GraphicsContext::setAllowsFontSmoothing):
      * platform/graphics/cg/ImageCG.cpp:
      (WebCore::Image::drawPattern):
      * platform/graphics/cg/ImageSourceCG.cpp:
      (WebCore::ImageSource::clear):
      * platform/graphics/cg/PathCG.cpp:
      (WebCore::Path::boundingRect):
      * platform/graphics/cocoa/FontPlatformDataCocoa.mm:
      (WebCore):
      (WebCore::FontPlatformData::ctFont):
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
      (WebCore::MediaPlayerPrivateGStreamerBase::supportsFullscreen):
      * platform/graphics/mac/ComplexTextControllerCoreText.mm:
      * platform/graphics/mac/FontCacheMac.mm:
      (WebCore):
      (WebCore::fontCacheRegisteredFontsChangedNotificationCallback):
      (WebCore::FontCache::platformInit):
      * platform/graphics/mac/FontCustomPlatformData.cpp:
      (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
      (WebCore::createFontCustomPlatformData):
      * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
      (WebCore::MediaPlayerPrivateQTKit::createQTMovie):
      (WebCore::MediaPlayerPrivateQTKit::supportsFullscreen):
      (WebCore::MediaPlayerPrivateQTKit::setClosedCaptionsVisible):
      (WebCore::MediaPlayerPrivateQTKit::cacheMovieScale):
      * platform/graphics/mac/SimpleFontDataMac.mm:
      (WebCore::SimpleFontData::platformInit):
      * platform/graphics/mac/WebLayer.h:
      * platform/mac/CursorMac.mm:
      (WebCore::Cursor::ensurePlatformCursor):
      * platform/mac/DisplaySleepDisabler.cpp:
      (WebCore::DisplaySleepDisabler::DisplaySleepDisabler):
      (WebCore):
      * platform/mac/DisplaySleepDisabler.h:
      (DisplaySleepDisabler):
      * platform/mac/EmptyProtocolDefinitions.h:
      * platform/mac/HTMLConverter.h:
      * platform/mac/HTMLConverter.mm:
      * platform/mac/PopupMenuMac.mm:
      (WebCore::PopupMenuMac::populate):
      * platform/mac/ScrollElasticityController.mm:
      (systemUptime):
      * platform/mac/SharedTimerMac.mm:
      (PowerObserver):
      (WebCore::PowerObserver::PowerObserver):
      (WebCore::PowerObserver::~PowerObserver):
      (WebCore::PowerObserver::didReceiveSystemPowerNotification):
      * platform/mac/SuddenTermination.mm:
      * platform/mac/WebCoreFullScreenWindow.mm:
      (-[WebCoreFullScreenWindow initWithContentRect:styleMask:backing:defer:]):
      * platform/mac/WebFontCache.mm:
      (+[WebFontCache getTraits:inFamily:]):
      (+[WebFontCache internalFontWithFamily:traits:weight:size:]):
      * platform/mac/WebVideoFullscreenController.mm:
      (SOFT_LINK_POINTER):
      (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
      * platform/mac/WebVideoFullscreenHUDWindowController.mm:
      (createControlWithMediaUIControlType):
      (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
      * platform/network/Credential.h:
      * platform/network/cf/DNSCFNet.cpp:
      (WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
      * platform/network/cf/ProxyServerCFNet.cpp:
      (WebCore):
      (WebCore::proxyServersForURL):
      * platform/network/cf/SocketStreamHandleCFNet.cpp:
      (WebCore::SocketStreamHandle::chooseProxy):
      * platform/network/mac/AuthenticationMac.mm:
      (WebCore):
      * platform/network/mac/WebCoreURLResponse.mm:
      (WebCore::adjustMIMETypeIfNecessary):
      * platform/text/TextChecking.h:
      (WebCore):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6690896b
  32. 14 Mar, 2013 1 commit
    • inferno@chromium.org's avatar
      Replace static_casts with to* helper functions. · 9aa9e8d7
      inferno@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112296
      
      Reviewed by Kentaro Hara.
      
      to* helper functions are preferred over static_cast calls since they
      help to catch bad casts easily on the testing infrastructure.
      
      Source/WebCore:
      
      * accessibility/AXObjectCache.cpp:
      (WebCore::nodeHasRole):
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::hasAttribute):
      (WebCore::AccessibilityObject::getAttribute):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::anchorElement):
      (WebCore::AccessibilityRenderObject::helpText):
      (WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
      (WebCore::AccessibilityRenderObject::titleUIElement):
      (WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
      (WebCore::AccessibilityRenderObject::accessKey):
      (WebCore::AccessibilityRenderObject::setElementAttributeValue):
      (WebCore::AccessibilityRenderObject::setValue):
      (WebCore::AccessibilityRenderObject::activeDescendant):
      (WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
      (WebCore::AccessibilityRenderObject::correspondingLabelForControlElement):
      (WebCore::AccessibilityRenderObject::inheritsPresentationalRole):
      (WebCore::AccessibilityRenderObject::setAccessibleName):
      (WebCore::AccessibilityRenderObject::stringRoleForMSAA):
      * bindings/gobject/WebKitDOMBinding.cpp:
      (WebKit::createWrapper):
      * bindings/js/JSClipboardCustom.cpp:
      (WebCore::JSClipboard::setDragImage):
      * bindings/js/JSElementCustom.cpp:
      (WebCore::toJSNewlyCreated):
      * bindings/js/JSNodeCustom.cpp:
      (WebCore::createWrapperInline):
      * bindings/v8/custom/V8ClipboardCustom.cpp:
      (WebCore::V8Clipboard::setDragImageMethodCustom):
      * bindings/v8/custom/V8ElementCustom.cpp:
      (WebCore::wrap):
      * bindings/v8/custom/V8NodeCustom.cpp:
      (WebCore::wrap):
      * dom/Document.cpp:
      (WebCore::Document::importNode):
      (WebCore::Document::recalcStyle):
      (WebCore::Document::setFocusedNode):
      (WebCore::Document::updateFocusAppearanceTimerFired):
      * dom/DocumentStyleSheetCollection.cpp:
      (WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
      * dom/Element.cpp:
      (WebCore::Element::offsetParent):
      (WebCore::Element::boundsInRootViewSpace):
      (WebCore::Element::getBoundingClientRect):
      (WebCore::Element::recalcStyle):
      (WebCore::Element::computeInheritedLanguage):
      (WebCore::Element::lastElementChild):
      * dom/LiveNodeList.cpp:
      (WebCore::LiveNodeList::namedItem):
      * dom/Node.cpp:
      (WebCore::Node::dumpStatistics):
      (WebCore::Node::normalize):
      (WebCore::Node::rootEditableElement):
      (WebCore::Node::isDefaultNamespace):
      (WebCore::Node::ancestorElement):
      (WebCore::appendAttributeDesc):
      * dom/Position.cpp:
      (WebCore::Position::element):
      * dom/Range.cpp:
      (WebCore::Range::getBorderAndTextQuads):
      * dom/SelectorQuery.cpp:
      (WebCore::SelectorDataList::queryFirst):
      (WebCore::SelectorDataList::execute):
      * dom/ShadowRoot.cpp:
      (WebCore::ShadowRoot::recalcStyle):
      * dom/StaticHashSetNodeList.cpp:
      (WebCore::StaticHashSetNodeList::namedItem):
      * editing/ApplyStyleCommand.cpp:
      (WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi):
      (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):
      (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
      (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):
      * editing/Editor.cpp:
      (WebCore::Editor::applyEditingStyleToBodyElement):
      * editing/FrameSelection.cpp:
      (WebCore::removingNodeRemovesPosition):
      * editing/IndentOutdentCommand.cpp:
      (WebCore::IndentOutdentCommand::outdentParagraph):
      * editing/MarkupAccumulator.cpp:
      (WebCore::MarkupAccumulator::entityMaskForText):
      (WebCore::MarkupAccumulator::appendStartMarkup):
      (WebCore::MarkupAccumulator::appendEndMarkup):
      * editing/ModifySelectionListLevel.cpp:
      (WebCore::IncreaseSelectionListLevelCommand::doApply):
      * editing/ReplaceSelectionCommand.cpp:
      (WebCore::haveSameTagName):
      (WebCore::handleStyleSpansBeforeInsertion):
      (WebCore::ReplaceSelectionCommand::doApply):
      * editing/SplitTextNodeContainingElementCommand.cpp:
      (WebCore::SplitTextNodeContainingElementCommand::doApply):
      * editing/TextIterator.cpp:
      (WebCore::TextIterator::advance):
      * editing/htmlediting.cpp:
      (WebCore::unsplittableElementForPosition):
      (WebCore::enclosingTableCell):
      * editing/markup.cpp:
      (WebCore::StyledMarkupAccumulator::wrapWithNode):
      (WebCore::createMarkupInternal):
      (WebCore::createFragmentFromMarkupWithContext):
      (WebCore::isPlainTextMarkup):
      (WebCore::createFragmentFromText):
      * html/HTMLElement.cpp:
      (WebCore::HTMLElement::insertAdjacentElement):
      (WebCore::contextElementForInsertion):
      * html/HTMLFormControlElement.cpp:
      (WebCore::focusPostAttach):
      (WebCore::updateFromElementCallback):
      * html/HTMLFormElement.cpp:
      (WebCore::submitElementFromEvent):
      * html/HTMLObjectElement.cpp:
      (WebCore::HTMLObjectElement::updateDocNamedItem):
      * html/HTMLPlugInImageElement.cpp:
      (WebCore::HTMLPlugInImageElement::updateSnapshotInfo):
      * html/HTMLViewSourceDocument.cpp:
      (WebCore::HTMLViewSourceDocument::addRange):
      * html/parser/HTMLTreeBuilder.cpp:
      (WebCore::closestFormAncestor):
      * html/shadow/MediaControlElementTypes.cpp:
      (WebCore::toParentMediaElement):
      * html/shadow/TextFieldDecorationElement.h:
      (WebCore::toTextFieldDecorationElement):
      * inspector/DOMPatchSupport.cpp:
      (WebCore::DOMPatchSupport::createDigest):
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::buildObjectForNode):
      (WebCore::InspectorDOMAgent::didInvalidateStyleAttr):
      * inspector/InspectorStyleSheet.cpp:
      (WebCore::InspectorStyleSheet::inlineStyleSheetText):
      * mathml/MathMLElement.h:
      (WebCore::toMathMLElement):
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::populate):
      * page/DragController.cpp:
      (WebCore::elementUnderMouse):
      (WebCore::DragController::startDrag):
      * page/FocusController.cpp:
      (WebCore::FocusController::advanceFocusInDocumentOrder):
      * page/Frame.cpp:
      (WebCore::Frame::searchForLabelsBeforeElement):
      * page/FrameView.cpp:
      (WebCore::FrameView::updateWidget):
      * page/SpatialNavigation.cpp:
      (WebCore::rectToAbsoluteCoordinates):
      * page/animation/ImplicitAnimation.cpp:
      (WebCore::ImplicitAnimation::sendTransitionEvent):
      * page/animation/KeyframeAnimation.cpp:
      (WebCore::KeyframeAnimation::KeyframeAnimation):
      (WebCore::KeyframeAnimation::sendAnimationEvent):
      * platform/efl/RenderThemeEfl.cpp:
      (WebCore::RenderThemeEfl::paintMediaFullscreenButton):
      (WebCore::RenderThemeEfl::paintMediaMuteButton):
      * rendering/FilterEffectRenderer.cpp:
      (WebCore::FilterEffectRenderer::buildReferenceFilter):
      * rendering/svg/RenderSVGViewportContainer.cpp:
      (WebCore::RenderSVGViewportContainer::calcViewport):
      * svg/SVGSVGElement.cpp:
      (WebCore::SVGSVGElement::getElementById):
      * svg/SVGUseElement.cpp:
      (WebCore::isDisallowedElement):
      * svg/animation/SVGSMILElement.cpp:
      (WebCore::SVGSMILElement::buildPendingResource):
      * xml/XPathStep.cpp:
      (WebCore::XPath::nodeMatchesBasicTest):
      * xml/parser/XMLDocumentParserQt.cpp:
      (WebCore::XMLDocumentParser::XMLDocumentParser):
      (WebCore::XMLDocumentParser::parseEndElement):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::webContext):
      (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
      (BlackBerry::WebKit::WebPage::setNodeFocus):
      (BlackBerry::WebKit::WebPagePrivate::adjustFullScreenElementDimensionsIfNeeded):
      * WebCoreSupport/EditorClientBlackBerry.cpp:
      (WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
      (WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
      * WebKitSupport/BackingStoreClient.cpp:
      (BlackBerry::WebKit::BackingStoreClient::absoluteRect):
      * WebKitSupport/DOMSupport.cpp:
      (BlackBerry::WebKit::DOMSupport::toTextControlElement):
      (BlackBerry::WebKit::DOMSupport::selectionContainerElement):
      * WebKitSupport/FatFingers.cpp:
      (BlackBerry::WebKit::FatFingers::getRelevantInfoFromCachedHitTest):
      (BlackBerry::WebKit::FatFingers::setSuccessfulFatFingersResult):
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::focusedNodeChanged):
      (BlackBerry::WebKit::InputHandler::willOpenPopupForNode):
      * WebKitSupport/SelectionHandler.cpp:
      (BlackBerry::WebKit::SelectionHandler::inputNodeOverridesTouch):
      * WebKitSupport/TouchEventHandler.cpp:
      (BlackBerry::WebKit::elementForTapHighlight):
      
      Source/WebKit/chromium:
      
      * src/WebDocument.cpp:
      (WebKit::WebDocument::images):
      * src/WebElement.cpp:
      (WebKit::WebElement::operator PassRefPtr<Element>):
      * src/WebPageSerializer.cpp:
      (WebCore::retrieveResourcesForFrame):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::setFocus):
      (WebKit::WebViewImpl::clearFocusedNode):
      (WebKit::WebViewImpl::scrollFocusedNodeIntoView):
      (WebKit::WebViewImpl::scrollFocusedNodeIntoRect):
      
      Source/WebKit/gtk:
      
      * webkit/webkitwebview.cpp:
      (webkit_web_view_query_tooltip):
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (applyAppleDictionaryApplicationQuirkNonInlinePart):
      * WebView/WebHTMLRepresentation.mm:
      (searchForLabelsBeforeElement):
      
      Source/WebKit/qt:
      
      * Api/qwebelement.cpp:
      (QWebElement::firstChild):
      (QWebElement::lastChild):
      (QWebElement::nextSibling):
      (QWebElement::previousSibling):
      (QWebElementCollection::at):
      (QWebElementCollection::toList):
      * WebCoreSupport/QWebFrameAdapter.cpp:
      (QWebHitTestResultPrivate::elementForInnerNode):
      
      Source/WebKit/win:
      
      * WebView.cpp:
      (WebView::enterFullscreenForNode):
      
      Source/WebKit2:
      
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      (WebKit::InjectedBundleNodeHandle::elementBounds):
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::containsAnyFormElements):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9aa9e8d7
  33. 15 Feb, 2013 1 commit
    • allan.jensen@digia.com's avatar
      Simplify hitTestResultAtPoint and nodesFromRect APIs · eb0e1f9f
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95720
      
      .:
      
      Reviewed by Julien Chaffraix.
      
      Update exported symbols.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      Reviewed by Julien Chaffraix.
      
      The existing API was overloaded and could be simplified by passing all the bool arguments in
      a HitTestRequest argument. This should also help clarify the call as the enum values explicitely
      state what they do.
      
      * WebCore.exp.in:
      * WebCore.order:
      * dom/Document.cpp:
      (WebCore::Document::nodesFromRect):
      * dom/Document.h:
      (Document):
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::createContextMenu):
      * page/DragController.cpp:
      (WebCore::DragController::canProcessDrag):
      (WebCore::DragController::startDrag):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::hitTestResultAtPoint):
      (WebCore::EventHandler::handleMousePressEvent):
      (WebCore::EventHandler::handleGestureEvent):
      (WebCore::EventHandler::handleGestureForTextSelectionOrContextMenu):
      (WebCore::EventHandler::bestClickableNodeForTouchPoint):
      (WebCore::EventHandler::bestContextMenuNodeForTouchPoint):
      (WebCore::EventHandler::bestZoomableAreaForTouchPoint):
      (WebCore::EventHandler::handleTouchEvent):
      * page/EventHandler.h:
      (WebCore):
      (EventHandler):
      * page/FocusController.cpp:
      (WebCore::updateFocusCandidateIfNeeded):
      * page/Frame.cpp:
      (WebCore::Frame::visiblePositionForPoint):
      (WebCore::Frame::documentAtPoint):
      * page/TouchDisambiguation.cpp:
      (WebCore::findGoodTouchTargets):
      * rendering/HitTestRequest.h:
      (WebCore::HitTestRequest::allowsFrameScrollbars):
      * testing/Internals.cpp:
      (WebCore::Internals::nodesFromRect):
      
      Source/WebKit/blackberry:
      
      Reviewed by Julien Chaffraix.
      
      Update calls to new API.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::contextNode):
      (BlackBerry::WebKit::WebPagePrivate::nodeForZoomUnderPoint):
      (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
      (BlackBerry::WebKit::WebPage::nodeAtDocumentPoint):
      (BlackBerry::WebKit::WebPagePrivate::hitTestResult):
      * WebKitSupport/SelectionHandler.cpp:
      (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
      
      Source/WebKit/chromium:
      
      Reviewed by Julien Chaffraix.
      
      Update calls to new API.
      
      * src/ContextMenuClientImpl.cpp:
      (WebKit::selectMisspelledWord):
      * src/FrameLoaderClientImpl.cpp:
      (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::characterIndexForPoint):
      * src/WebPluginContainerImpl.cpp:
      (WebKit::WebPluginContainerImpl::isRectTopmost):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::handleMouseDown):
      (WebKit::WebViewImpl::computeBlockBounds):
      (WebKit::WebViewImpl::bestTouchLinkNode):
      (WebKit::WebViewImpl::hitTestResultForWindowPos):
      
      Source/WebKit/efl:
      
      Reviewed by Julien Chaffraix.
      
      Update calls to new API.
      
      * ewk/ewk_frame.cpp:
      (ewk_frame_hit_test_new):
      
      Source/WebKit/mac:
      
      Reviewed by Julien Chaffraix.
      
      Update calls to new API.
      
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (WebFrameLoaderClient::actionDictionary):
      * WebView/WebFrame.mm:
      (-[WebFrame elementAtPoint:]):
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView elementAtPoint:allowShadowContent:]):
      
      Source/WebKit/qt:
      
      Reviewed by Julien Chaffraix.
      
      Update calls to new API.
      
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
      * WebCoreSupport/QWebFrameAdapter.cpp:
      (QWebFrameAdapter::hitTestContent):
      * WebCoreSupport/QWebPageAdapter.cpp:
      (QWebPageAdapter::TouchAdjuster::findCandidatePointForTouch):
      (QWebPageAdapter::handleSoftwareInputPanel):
      (QWebPageAdapter::updatePositionDependentMenuActions):
      
      Source/WebKit/win:
      
      Reviewed by Julien Chaffraix.
      
      Update calls to new API.
      
      * WebActionPropertyBag.cpp:
      (WebActionPropertyBag::Read):
      * WebKit.vcproj/WebKitExports.def.in:
      * WebView.cpp:
      (WebView::handleContextMenuEvent):
      (WebView::elementAtPoint):
      
      Source/WebKit/wx:
      
      Reviewed by Julien Chaffraix.
      
      Update calls to new API.
      
      * WebFrame.cpp:
      (WebKit::WebFrame::HitTest):
      
      Source/WebKit2:
      
      Reviewed by Julien Chaffraix and Maciej Stachowiak.
      
      Update calls to new API and update exported symbols.
      
      * WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp:
      (WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction):
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::hitTest):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::handleContextMenuEvent):
      (WebKit::WebPage::highlightPotentialActivation):
      (WebKit::WebPage::findZoomableAreaForPoint):
      * WebProcess/WebPage/mac/WebPageMac.mm:
      (WebKit::WebPage::characterIndexForPoint):
      (WebKit::WebPage::performDictionaryLookupAtLocation):
      (WebKit::WebPage::shouldDelayWindowOrderingEvent):
      (WebKit::WebPage::acceptsFirstMouse):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142977 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb0e1f9f
  34. 08 Feb, 2013 1 commit
    • mkwst@chromium.org's avatar
      Add a new IGNORE_EXCEPTION helper to ignore ExceptionCodes when they are expected but uninteresting · 33cdf43a
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=108771
      
      Reviewed by Eric Seidel.
      
      In cases where the ExceptionCode passed into a function is completely
      ignored, this patch replaces it with a new IGNORE_EXCEPTION macro. This
      makes our expectations about possible exceptions (or lack thereof)
      explicit, rather than relying on implicit assumptions about whether a
      variable is intentionally uninitialized or not. It also removes
      knowledge about the internals of ExceptionCodes (that they're currently
      ints, for instance) from code that shouldn't care, which will help with
      future refactorings.
      
      The implementation is entirely based upon ASSERT_NO_EXCEPTION, and
      shouldn't have any visible effect on the web. As long as all the
      current tests pass, we're good.
      
      * Modules/indexeddb/IDBRequest.cpp:
      (WebCore::IDBRequest::dispatchEvent):
      (WebCore::IDBRequest::uncaughtExceptionInEventHandler):
      * Modules/indexeddb/IDBTransaction.cpp:
      (WebCore::IDBTransaction::stop):
      * Modules/websockets/WebSocketChannel.cpp:
      (WebCore::WebSocketChannel::processBuffer):
      * dom/Document.cpp:
      (WebCore::Document::processHttpEquiv):
      * dom/ExceptionCodePlaceholder.h:
      (WebCore):
      * dom/Node.cpp:
      (WebCore::Node::normalize):
      * dom/Text.cpp:
      (WebCore::Text::replaceWholeText):
      * editing/AlternativeTextController.cpp:
      (WebCore::AlternativeTextController::insertDictatedText):
      * editing/AppendNodeCommand.cpp:
      (WebCore::AppendNodeCommand::doApply):
      (WebCore::AppendNodeCommand::doUnapply):
      * editing/CompositeEditCommand.cpp:
      (WebCore::CompositeEditCommand::insertNewDefaultParagraphElementAt):
      * editing/DeleteFromTextNodeCommand.cpp:
      (WebCore::DeleteFromTextNodeCommand::doUnapply):
      * editing/Editor.cpp:
      (WebCore::dispatchEditableContentChangedEvents):
      (WebCore::Editor::applyEditingStyleToElement):
      * editing/EditorCommand.cpp:
      (WebCore::executeFormatBlock):
      * editing/FormatBlockCommand.cpp:
      (WebCore::FormatBlockCommand::elementForFormatBlockCommand):
      * editing/InsertIntoTextNodeCommand.cpp:
      (WebCore::InsertIntoTextNodeCommand::doApply):
      (WebCore::InsertIntoTextNodeCommand::doUnapply):
      * editing/InsertListCommand.cpp:
      (WebCore::InsertListCommand::doApplyForSingleParagraph):
      * editing/InsertNodeBeforeCommand.cpp:
      (WebCore::InsertNodeBeforeCommand::doApply):
      (WebCore::InsertNodeBeforeCommand::doUnapply):
      * editing/RemoveCSSPropertyCommand.cpp:
      (WebCore::RemoveCSSPropertyCommand::doApply):
      (WebCore::RemoveCSSPropertyCommand::doUnapply):
      * editing/RemoveNodeCommand.cpp:
      (WebCore::RemoveNodeCommand::doApply):
      (WebCore::RemoveNodeCommand::doUnapply):
      * editing/ReplaceSelectionCommand.cpp:
      (WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
      * editing/TextIterator.cpp:
      (WebCore::TextIterator::getLocationAndLengthFromRange):
      * editing/WrapContentsInDummySpanCommand.cpp:
      (WebCore::WrapContentsInDummySpanCommand::executeApply):
      (WebCore::WrapContentsInDummySpanCommand::doUnapply):
      * editing/htmlediting.cpp:
      (WebCore::comparePositions):
      * editing/markup.cpp:
      (WebCore::highestAncestorToWrapMarkup):
      * html/FTPDirectoryDocument.cpp:
      (WebCore::FTPDirectoryDocumentParser::appendEntry):
      (WebCore::FTPDirectoryDocumentParser::createTDForFilename):
      (WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):
      (WebCore::FTPDirectoryDocumentParser::createBasicDocument):
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::rewind):
      (WebCore::HTMLMediaElement::returnToRealtime):
      (WebCore::HTMLMediaElement::playInternal):
      (WebCore::HTMLMediaElement::percentLoaded):
      (WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
      (WebCore::HTMLMediaElement::mediaPlayerDurationChanged):
      (WebCore::HTMLMediaElement::applyMediaFragmentURI):
      * html/HTMLOutputElement.cpp:
      (WebCore::HTMLOutputElement::setTextContentInternal):
      * html/HTMLSelectElement.cpp:
      (WebCore::HTMLSelectElement::remove):
      * html/HTMLTableElement.cpp:
      (WebCore::HTMLTableElement::createTHead):
      (WebCore::HTMLTableElement::deleteTHead):
      (WebCore::HTMLTableElement::createTFoot):
      (WebCore::HTMLTableElement::deleteTFoot):
      (WebCore::HTMLTableElement::createCaption):
      (WebCore::HTMLTableElement::deleteCaption):
      * html/HTMLTextAreaElement.cpp:
      (WebCore::HTMLTextAreaElement::setDefaultValue):
      * html/ImageDocument.cpp:
      (WebCore::ImageDocument::createDocumentStructure):
      * html/InputType.cpp:
      (WebCore::InputType::stepUpFromRenderer):
      * html/MediaController.cpp:
      (MediaController::bringElementUpToSpeed):
      (MediaController::asyncEventTimerFired):
      * html/MediaDocument.cpp:
      (WebCore::MediaDocumentParser::createDocumentStructure):
      (WebCore::MediaDocument::replaceMediaElementTimerFired):
      * html/PluginDocument.cpp:
      (WebCore::PluginDocumentParser::createDocumentStructure):
      * html/RangeInputType.cpp:
      (WebCore::RangeInputType::handleKeydownEvent):
      * html/TimeRanges.cpp:
      (TimeRanges::contain):
      (TimeRanges::nearest):
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore::CanvasRenderingContext2D::drawImageFromRect):
      * html/shadow/MediaControlElementTypes.cpp:
      (WebCore::MediaControlSeekButtonElement::seekTimerFired):
      * html/shadow/MediaControlElements.cpp:
      (WebCore::MediaControlPanelElement::setPosition):
      (WebCore::MediaControlPanelElement::resetPosition):
      (WebCore::MediaControlStatusDisplayElement::update):
      (WebCore::MediaControlRewindButtonElement::defaultEventHandler):
      (WebCore::MediaControlTimelineElement::defaultEventHandler):
      * html/shadow/MediaControls.cpp:
      (WebCore::MediaControls::updateCurrentTimeDisplay):
      (WebCore::MediaControls::createTextTrackDisplay):
      * html/shadow/MediaControlsApple.cpp:
      (WebCore::MediaControlsApple::updateCurrentTimeDisplay):
      * html/shadow/MediaControlsBlackBerry.cpp:
      (WebCore::MediaControlEmbeddedPanelElement::setPosition):
      (WebCore::MediaControlEmbeddedPanelElement::resetPosition):
      (WebCore::MediaControlFullscreenTimelineElement::defaultEventHandler):
      (WebCore::MediaControlsBlackBerry::updateCurrentTimeDisplay):
      * html/shadow/MediaControlsChromium.cpp:
      (WebCore::MediaControlsChromium::updateCurrentTimeDisplay):
      * html/track/InbandTextTrack.cpp:
      (WebCore::InbandTextTrack::addGenericCue):
      * inspector/InspectorCSSAgent.cpp:
      (WebCore::InspectorCSSAgent::buildArrayForMatchedRuleList):
      * inspector/InspectorHistory.cpp:
      (WebCore::InspectorHistory::markUndoableState):
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::InspectorResourceAgent::replayXHR):
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::contextMenuItemSelected):
      * page/DOMWindow.cpp:
      (WebCore::didAddStorageEventListener):
      * page/DragController.cpp:
      (WebCore::documentFragmentFromDragData):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::dispatchDragEvent):
      (WebCore::EventHandler::keyEvent):
      (WebCore::EventHandler::handleTextInputEvent):
      * page/Page.cpp:
      (WebCore::Page::findStringMatchingRanges):
      * platform/efl/RenderThemeEfl.cpp:
      (WebCore::RenderThemeEfl::paintMediaSliderTrack):
      * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
      (WebCore::MediaPlayerPrivate::percentLoaded):
      * platform/gtk/RenderThemeGtk.cpp:
      (WebCore::RenderThemeGtk::paintMediaSliderTrack):
      * platform/mac/PasteboardMac.mm:
      (WebCore::Pasteboard::getDataSelection):
      (WebCore::documentFragmentWithImageResource):
      (WebCore::Pasteboard::documentFragment):
      * platform/mac/WebVideoFullscreenHUDWindowController.mm:
      (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
      (-[WebVideoFullscreenHUDWindowController setVolume:]):
      * platform/qt/RenderThemeQt.cpp:
      (WebCore::RenderThemeQt::paintMediaSliderTrack):
      * rendering/RenderNamedFlowThread.cpp:
      (WebCore::RenderNamedFlowThread::getRanges):
      * rendering/RenderThemeMac.mm:
      (WebCore::RenderThemeMac::paintMediaSliderTrack):
      * svg/SVGTRefElement.cpp:
      (WebCore::SVGTRefElement::detachTarget):
      * xml/XMLTreeViewer.cpp:
      (WebCore::XMLTreeViewer::transformDocumentToTreeView):
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      (WebCore::XMLDocumentParser::endElementNs):
      * xml/parser/XMLDocumentParserQt.cpp:
      (WebCore::XMLDocumentParser::parseEndElement):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142271 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33cdf43a
  35. 02 Feb, 2013 1 commit
  36. 11 Jan, 2013 1 commit
    • g.czajkowski@samsung.com's avatar
      On Linux, should be able to get spelling suggestions without selecting the misspelled word · 0303b043
      g.czajkowski@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=103520
      
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      Allow to get/insert spelling suggestions without selecting the misspelled word for
      Linux WebKit ports. WebCore assumes that the misspelled word has to be selected
      to get its suggestions.
      
      In compliance with native application behaviour a new editing policy is introduced,
      to do not highlight the misspelled word to just get its guesses.
      
      No new tests, covered by context-menu-suggestions.html.
      
      * WebCore.exp.in:
      Remove _ZN7WebCore6Editor21isSelectionMisspelledEv symbol as Mac port doesn't
      need it any longer.
      
      * editing/EditingBehavior.h:
      (EditingBehavior):
      (WebCore::EditingBehavior::shouldAllowSpellingSuggestionsWithoutSelection):
      Add a new behavior for Linux, to allow spelling suggestions without selecting
      the misspelled word.
      
      * editing/Editor.cpp:
      (WebCore::Editor::isContinuousSpellCheckingEnabled):
      Add missing const modifier, to use this method in 'misspelledWordAtCaretOrRange() const'.
      
      (WebCore::Editor::misspelledWordAtCaretOrRange):
      Allow to check spelling under the caret or selected word.
      Does nothing for selection made on the multiple words.
      
      (WebCore::Editor::misspelledSelectionString):
      Return the misspelled selection.
      
      (WebCore::Editor::guessesForMisspelledWord):
      Remove 'Selection' from method name as it may return guesses without selection.
      
      (WebCore::Editor::guessesForMisspelledOrUngrammatical):
      Ditto.
      
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::contextMenuItemSelected):
      Select the word under caret to meet the conditions from misspelledWordAtCaretOrRange.
      
      (WebCore::ContextMenuController::populate):
      Update guessesForMisspelledOrUngrammatical call.
      
      LayoutTests:
      
      * platform/efl/TestExpectations:
      Unskip context-menu-suggestions.html for WebKit-EFL as it passes now.
      
      * platform/gtk/TestExpectations:
      Update failing reason.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139412 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0303b043
  37. 28 Nov, 2012 1 commit
    • msaboff@apple.com's avatar
      TextIterator unnecessarily converts 8 bit strings to 16 bits · 5a772533
      msaboff@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=103295
      
      Reviewed by Brent Fulgham.
      
      Source/WebCore:
      
      Changed TextIterator to use the contained string instead of calling characters() on that string.
      Other sources of text, like emitCharacter() still use the contained UChar* buffer.
      Added appendTextToStringBuilder() to append the text contents of the current iterator to a string builder
      irrespective of the source of the text.
      
      No new tests as functionality covered by existing tests.
      
      * WebCore.exp.in: Updated plainText export and eliminated plainTextToMallocAllocatedBuffer export
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::stringForVisiblePositionRange): Updated to use TextIterator::appendTextToStringBuilder()
      * editing/TextIterator.cpp:
      (WebCore::TextIterator::characterAt): New function to return the indexed character of the current TextIterator
      (WebCore::TextIterator::appendTextToStringBuilder): Added method to append whatever the current text to a StringBuilder
      (WebCore::TextIterator::emitText): Eliminated accessing the character data via characters().
      (WebCore::TextIterator::rangeFromLocationAndLength): Changed to use characterAt().
      (WebCore::plainText): Combined with plainTextToMallocAllocatedBuffer().
      * editing/TextIterator.h:
      (WebCore::TextIterator::startOffset): New getter.
      (WebCore::TextIterator::string): New getter.
      (WebCore::TextIterator::characters): Updated to use correct test source.
      * page/ContextMenuController.cpp:
      (WebCore::selectionContainsPossibleWord): Changed to use characterAt().
      
      Source/WebKit/mac:
      
      Updated _stringForRange to use plainText() instead of removed plainTextToMallocAllocatedBuffer().
      
      * WebView/WebFrame.mm:
      (-[WebFrame _stringForRange:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135972 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5a772533