1. 27 Dec, 2013 1 commit
    • dbates@webkit.org's avatar
      [iOS] Upstream WebCore/page changes · 4da1af80
      dbates@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=126180
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      * WebCore.xcodeproj/project.pbxproj:
      * dom/EventNames.h:
      (WebCore::EventNames::isGestureEventType): Added.
      * page/AlternativeTextClient.h: Do not define WTF_USE_DICTATION_ALTERNATIVES when building for iOS.
      * page/Chrome.cpp:
      (WebCore::Chrome::Chrome):
      (WebCore::Chrome::dispatchViewportPropertiesDidChange): Added; guarded by PLATFORM(IOS).
      (WebCore::Chrome::setCursor): Make this an empty function when building for iOS.
      (WebCore::Chrome::setCursorHiddenUntilMouseMoves): Ditto.
      (WebCore::Chrome::didReceiveDocType): Added; iOS-specific.
      * page/Chrome.h:
      (WebCore::Chrome::setDispatchViewportDataDidChangeSuppressed): Added; guarded by PLATFORM(IOS).
      * page/ChromeClient.h:
      (WebCore::ChromeClient::didFlushCompositingLayers): Added; guarded by PLATFORM(IOS).
      (WebCore::ChromeClient::fetchCustomFixedPositionLayoutRect): Added; guarded by PLATFORM(IOS).
      (WebCore::ChromeClient::updateViewportConstrainedLayers): Added; guarded by PLATFORM(IOS).
      * page/DOMTimer.cpp:
      (WebCore::DOMTimer::install): Added iOS-specific code.
      (WebCore::DOMTimer::fired): Ditto.
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::DOMWindow): Ditto.
      (WebCore::DOMWindow::innerHeight): Ditto.
      (WebCore::DOMWindow::innerWidth): Ditto.
      (WebCore::DOMWindow::scrollX): Ditto.
      (WebCore::DOMWindow::scrollY): Ditto.
      (WebCore::DOMWindow::scrollBy): Ditto.
      (WebCore::DOMWindow::scrollTo): Ditto.
      (WebCore::DOMWindow::clearTimeout): Ditto.
      (WebCore::DOMWindow::addEventListener): Ditto.
      (WebCore::DOMWindow::incrementScrollEventListenersCount): Added; guarded by PLATFORM(IOS).
      (WebCore::DOMWindow::decrementScrollEventListenersCount): Added; guarded by PLATFORM(IOS).
      (WebCore::DOMWindow::resetAllGeolocationPermission): Added; Also added FIXME comment.
      (WebCore::DOMWindow::removeEventListener): Added iOS-specific code.
      (WebCore::DOMWindow::dispatchEvent): Modified to prevent dispatching duplicate pageshow and pagehide
      events per <http://www.whatwg.org/specs/web-apps/current-work/multipage/history.html#event-pageshow>.
      (WebCore::DOMWindow::removeAllEventListeners): Added iOS-specific code.
      * page/DOMWindow.h:
      * page/DOMWindow.idl: Added IOS_GESTURE_EVENTS-guarded attributes: ongesture{change, end, start}. Also
      added IOS_TOUCH_EVENTS-guarded attributes: {Touch, TouchList}Constructor.
      * page/EditorClient.h:
      * page/EventHandler.cpp:
      (WebCore::EventHandler::EventHandler): Added iOS-specific code.
      (WebCore::EventHandler::clear): Ditto.
      (WebCore::EventHandler::startPanScrolling): Make this an empty function when building for iOS.
      (WebCore::EventHandler::handleMousePressEvent): Modified to invalidate a click when the clicked node is
      null. Also, opt out of code for updating the scrollbars as UIKit manages scrollbars on iOS.
      (WebCore::EventHandler::handleMouseMoveEvent): Opt of code for updating the scrollbars and cursor when building on iOS.
      (WebCore::hitTestResultInFrame): Made this a file-local static function since it's only used in EventHandler.cpp.
      (WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled): Added iOS-specific code.
      * page/EventHandler.h:
      * page/FocusController.h:
      * page/Frame.cpp:
      (WebCore::Frame::Frame): Added iOS-specific code.
      (WebCore::Frame::scrollOverflowLayer): Added; iOS-specific.
      (WebCore::Frame::overflowAutoScrollTimerFired): Added; iOS-specific.
      (WebCore::Frame::startOverflowAutoScroll): Added; iOS-specific.
      (WebCore::Frame::checkOverflowScroll): Added; iOS-specific.
      (WebCore::Frame::willDetachPage): Added iOS-specific code.
      (WebCore::Frame::createView): Ditto.
      (WebCore::Frame::setSelectionChangeCallbacksDisabled): Added; iOS-specific.
      (WebCore::Frame::selectionChangeCallbacksDisabled): Added; iOS-specific.
      * page/Frame.h:
      (WebCore::Frame::timersPaused): Added; guarded by PLATFORM(IOS).
      * page/FrameView.cpp:
      (WebCore::FrameView::FrameView): Added iOS-specific code.
      (WebCore::FrameView::clear): Ditto.
      (WebCore::FrameView::flushCompositingStateForThisFrame): Ditto.
      (WebCore::FrameView::graphicsLayerForPlatformWidget): Added.
      (WebCore::FrameView::scheduleLayerFlushAllowingThrottling): Added.
      (WebCore::FrameView::layout): Added iOS-specific code.
      (WebCore::countRenderedCharactersInRenderObjectWithThreshold): Added; helper function used by FrameView::renderedCharactersExceed().
      Also added FIXME comment.
      (WebCore::FrameView::renderedCharactersExceed): Added.
      (WebCore::FrameView::visibleContentsResized): Added iOS-specific code.
      (WebCore::FrameView::adjustTiledBackingCoverage): Ditto.
      (WebCore::FrameView::performPostLayoutTasks): Ditto.
      (WebCore::FrameView::sendResizeEventIfNeeded): Ditto.
      (WebCore::FrameView::paintContents): Added iOS-specific code. Also added FIXME comments.
      (WebCore::FrameView::setUseCustomFixedPositionLayoutRect): Added; iOS-specific.
      (WebCore::FrameView::setCustomFixedPositionLayoutRect): Added; iOS-specific.
      (WebCore::FrameView::updateFixedPositionLayoutRect): Added; iOS-specific.
      * page/FrameView.h:
      * page/Navigator.cpp:
      (WebCore::Navigator::standalone): Added; iOS-specific.
      * page/Navigator.h:
      * page/Navigator.idl: Added WTF_PLATFORM_IOS-guarded attribute: standalone. Also added FIXME comment.
      * page/NavigatorBase.cpp:
      (WebCore::NavigatorBase::platform): Added iOS-specific code.
      * page/Page.h:
      (WebCore::Page::hasCustomHTMLTokenizerTimeDelay): Added; guarded by PLATFORM(IOS). Also added FIXME comment
      to remove this method.
      (WebCore::Page::customHTMLTokenizerTimeDelay): Added; guarded by PLATFORM(IOS). Also added FIXME comment
      to remove this method.
      * page/PageGroup.cpp:
      (WebCore::PageGroup::removeVisitedLink): Added.
      * page/PageGroup.h:
      * page/Settings.cpp:
      (WebCore::Settings::Settings):
      (WebCore::Settings::setScriptEnabled): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::setStandalone): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::setAudioSessionCategoryOverride): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::audioSessionCategoryOverride): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::setNetworkDataUsageTrackingEnabled): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::networkDataUsageTrackingEnabled): Added; guarded by PLATFORM(IOS).
      (WebCore::sharedNetworkInterfaceNameGlobal): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::setNetworkInterfaceName): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::networkInterfaceName): Added; guarded by PLATFORM(IOS).
      * page/Settings.h:
      (WebCore::Settings::setMaxParseDuration): Added; guarded by PLATFORM(IOS). Also added FIXME comment.
      (WebCore::Settings::maxParseDuration): Added; guarded by PLATFORM(IOS). Also added FIXME comment.
      (WebCore::Settings::standalone): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::setTelephoneNumberParsingEnabled): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::telephoneNumberParsingEnabled): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::setMediaDataLoadsAutomatically): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::mediaDataLoadsAutomatically): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::setShouldTransformsAffectOverflow): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::shouldTransformsAffectOverflow): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::setShouldDispatchJavaScriptWindowOnErrorEvents): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::shouldDispatchJavaScriptWindowOnErrorEvents): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::setAlwaysUseBaselineOfPrimaryFont): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::alwaysUseBaselineOfPrimaryFont): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::setAlwaysUseAcceleratedOverflowScroll): Added; guarded by PLATFORM(IOS).
      (WebCore::Settings::alwaysUseAcceleratedOverflowScroll): Added; guarded by PLATFORM(IOS).
      * page/Settings.in: Added IOS_AIRPLAY-guarded setting: mediaPlaybackAllowsAirPlay.
      * page/animation/CSSPropertyAnimation.cpp:
      (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): Added iOS-specific code and FIXME comment.
      * page/ios/EventHandlerIOS.mm: Added.
      * page/ios/FrameIOS.mm: Added.
      * page/mac/ChromeMac.mm:
      * page/mac/PageMac.cpp:
      (WebCore::Page::addSchedulePair): Opt out of code when building for iOS.
      (WebCore::Page::removeSchedulePair): Ditto.
      * page/mac/SettingsMac.mm:
      (WebCore::Settings::shouldEnableScreenFontSubstitutionByDefault): Added iOS-specific code.
      * page/mac/WebCoreFrameView.h:
      
      Source/WebKit/ios:
      
      * WebCoreSupport/WebChromeClientIOS.mm: Substitute ENABLE(IOS_TOUCH_EVENTS) for ENABLE(TOUCH_EVENTS).
      
      Source/WebKit2:
      
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      * WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm: Added.
      * WebProcess/WebPage/WebPage.cpp: Include header <WebCore/HitTestResult.h>.
      
      Source/WTF:
      
      * wtf/FeatureDefines.h: Define ENABLE_IOS_TOUCH_EVENTS to be enabled by default
      when building iOS with ENABLE(TOUCH_EVENTS).
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4da1af80
  2. 13 Nov, 2013 1 commit
  3. 10 Nov, 2013 1 commit
    • andersca@apple.com's avatar
      Remove all 'std' using directives from WebCore · 8629863f
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124125
      
      Reviewed by Sam Weinig.
      
      As per the coding style guidelines.
      
      * loader/CrossOriginPreflightResultCache.cpp:
      (WebCore::CrossOriginPreflightResultCache::appendEntry):
      (WebCore::CrossOriginPreflightResultCache::canSkipPreflight):
      * loader/WorkerThreadableLoader.cpp:
      * loader/appcache/ApplicationCacheStorage.cpp:
      (WebCore::ApplicationCacheStorage::loadCache):
      * loader/appcache/ManifestParser.cpp:
      (WebCore::parseManifest):
      * loader/cache/MemoryCache.cpp:
      (WebCore::MemoryCache::deadCapacity):
      (WebCore::MemoryCache::lruListFor):
      * page/CaptionUserPreferencesMediaAF.cpp:
      * page/Chrome.cpp:
      * page/DOMTimer.cpp:
      (WebCore::DOMTimer::intervalClampedToMinimum):
      * page/FocusController.cpp:
      * page/Frame.cpp:
      (WebCore::Frame::resizePageRectsKeepingRatio):
      * page/PageGroupLoadDeferrer.cpp:
      * page/Settings.cpp:
      * page/animation/AnimationBase.cpp:
      (WebCore::solveStepsFunction):
      (WebCore::AnimationBase::fireAnimationEventsIfNeeded):
      (WebCore::AnimationBase::timeToNextService):
      (WebCore::AnimationBase::fractionalTime):
      (WebCore::AnimationBase::getTimeToNextEvent):
      * page/animation/KeyframeAnimation.cpp:
      (WebCore::KeyframeAnimation::fetchIntervalEndpointsForProperty):
      * platform/DateComponents.cpp:
      * platform/ScrollAnimator.cpp:
      (WebCore::ScrollAnimator::handleWheelEvent):
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::unscaledVisibleContentSize):
      (WebCore::ScrollView::setScrollOffset):
      (WebCore::ScrollView::updateScrollbars):
      (WebCore::ScrollView::scrollContents):
      * platform/Scrollbar.cpp:
      (WebCore::Scrollbar::moveThumb):
      * platform/ScrollbarThemeComposite.cpp:
      (WebCore::usedTotalSize):
      (WebCore::ScrollbarThemeComposite::thumbPosition):
      (WebCore::ScrollbarThemeComposite::thumbLength):
      * platform/SharedBuffer.cpp:
      (WebCore::SharedBuffer::append):
      (WebCore::SharedBuffer::copyBufferAndClear):
      (WebCore::SharedBuffer::getSomeData):
      * platform/ThreadTimers.cpp:
      (WebCore::ThreadTimers::updateSharedTimer):
      * platform/Timer.cpp:
      (WebCore::TimerHeapLessThanFunction::operator()):
      (WebCore::TimerBase::heapPop):
      (WebCore::TimerBase::nextUnalignedFireInterval):
      * platform/URL.cpp:
      (WebCore::findHostnamesInMailToURL):
      (WebCore::portAllowed):
      * platform/audio/AudioResampler.cpp:
      (WebCore::AudioResampler::setRate):
      * platform/audio/AudioResamplerKernel.cpp:
      (WebCore::AudioResamplerKernel::process):
      * platform/audio/Distance.cpp:
      (WebCore::DistanceEffect::gain):
      * platform/audio/DynamicsCompressorKernel.cpp:
      (WebCore::DynamicsCompressorKernel::process):
      * platform/audio/EqualPowerPanner.cpp:
      (WebCore::EqualPowerPanner::pan):
      * platform/audio/HRTFDatabase.cpp:
      (WebCore::HRTFDatabase::indexFromElevationAngle):
      * platform/audio/HRTFElevation.cpp:
      (WebCore::HRTFElevation::createForSubject):
      * platform/audio/HRTFKernel.cpp:
      (WebCore::HRTFKernel::HRTFKernel):
      (WebCore::HRTFKernel::createInterpolatedKernel):
      * platform/audio/HRTFPanner.cpp:
      (WebCore::HRTFPanner::calculateDesiredAzimuthIndexAndBlend):
      * platform/audio/Reverb.cpp:
      * platform/audio/SincResampler.cpp:
      (WebCore::SincResampler::process):
      * platform/cf/URLCF.cpp:
      * platform/graphics/Color.cpp:
      (WebCore::makeRGB):
      (WebCore::makeRGBA):
      (WebCore::colorFloatToRGBAByte):
      (WebCore::Color::light):
      (WebCore::Color::dark):
      * platform/graphics/CrossfadeGeneratedImage.cpp:
      * platform/graphics/FloatQuad.cpp:
      (WebCore::min4):
      (WebCore::max4):
      (WebCore::withinEpsilon):
      * platform/graphics/FloatSize.cpp:
      (WebCore::FloatSize::isZero):
      * platform/graphics/FontFastPath.cpp:
      (WebCore::Font::floatWidthForSimpleText):
      * platform/graphics/FontPlatformData.cpp:
      * platform/graphics/GraphicsContext.cpp:
      * platform/graphics/RoundedRect.cpp:
      (WebCore::RoundedRect::Radii::expand):
      * platform/graphics/ShadowBlur.cpp:
      (WebCore::calculateLobes):
      (WebCore::computeSliceSizesFromRadii):
      * platform/graphics/SimpleFontData.cpp:
      (WebCore::SimpleFontData::initCharWidths):
      * platform/graphics/WidthIterator.cpp:
      (WebCore::WidthIterator::WidthIterator):
      (WebCore::WidthIterator::advanceInternal):
      * platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
      (WebCore::InbandTextTrackPrivateAVF::processCue):
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
      * platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
      * platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
      (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration):
      (WebCore::MediaPlayerPrivateAVFoundationObjC::currentTime):
      * platform/graphics/ca/GraphicsLayerCA.cpp:
      (WebCore::GraphicsLayerCA::setOpacity):
      (WebCore::GraphicsLayerCA::setNeedsDisplay):
      (WebCore::GraphicsLayerCA::setupAnimation):
      (WebCore::clampedContentsScaleForScale):
      * platform/graphics/ca/mac/TileController.mm:
      (WebCore::TileController::getTileIndexRangeForRect):
      (WebCore::TileController::computeTileCoverageRect):
      * platform/graphics/cg/GraphicsContextCG.cpp:
      (WebCore::GraphicsContext::setPlatformShadow):
      (WebCore::computeLineBoundsAndAntialiasingModeForText):
      * platform/graphics/cg/ImageBufferCG.cpp:
      * platform/graphics/cg/ImageBufferDataCG.cpp:
      (WebCore::ImageBufferData::getData):
      * platform/graphics/cg/ImageSourceCG.cpp:
      * platform/graphics/filters/FEDropShadow.cpp:
      * platform/graphics/filters/FEGaussianBlur.cpp:
      (WebCore::boxBlur):
      (WebCore::FEGaussianBlur::platformApplyGeneric):
      (WebCore::FEGaussianBlur::calculateUnscaledKernelSize):
      (WebCore::FEGaussianBlur::calculateStdDeviation):
      * platform/graphics/gpu/Texture.cpp:
      (WebCore::Texture::updateSubRect):
      * platform/graphics/gpu/TilingData.cpp:
      (WebCore::computeNumTiles):
      (WebCore::TilingData::tileXIndexFromSrcCoord):
      (WebCore::TilingData::tileYIndexFromSrcCoord):
      * platform/graphics/mac/ComplexTextController.cpp:
      (WebCore::ComplexTextController::ComplexTextController):
      (WebCore::ComplexTextController::offsetForPosition):
      (WebCore::ComplexTextController::advance):
      (WebCore::ComplexTextController::adjustGlyphsAndAdvances):
      * platform/graphics/mac/FontComplexTextMac.cpp:
      (WebCore::Font::floatWidthForComplexText):
      * platform/graphics/mac/FontMac.mm:
      * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
      (WebCore::MediaPlayerPrivateQTKit::duration):
      * platform/graphics/mac/SimpleFontDataMac.mm:
      * platform/graphics/transforms/Matrix3DTransformOperation.cpp:
      * platform/graphics/transforms/MatrixTransformOperation.cpp:
      * platform/graphics/transforms/PerspectiveTransformOperation.cpp:
      * platform/graphics/transforms/RotateTransformOperation.cpp:
      * platform/graphics/transforms/TransformOperations.cpp:
      (WebCore::TransformOperations::blendByMatchingOperations):
      * platform/graphics/transforms/TransformationMatrix.cpp:
      (WebCore::clampEdgeValue):
      * platform/mac/ScrollAnimatorMac.mm:
      (WebCore::ScrollAnimatorMac::adjustScrollPositionIfNecessary):
      * platform/mac/ScrollViewMac.mm:
      (WebCore::ScrollView::platformSetContentsSize):
      (WebCore::ScrollView::platformSetScrollPosition):
      * platform/mac/ScrollbarThemeMac.mm:
      * platform/mac/ThemeMac.mm:
      * platform/mac/WebVideoFullscreenHUDWindowController.mm:
      (-[WebVideoFullscreenHUDWindowController incrementVolume]):
      (timeToString):
      * platform/network/HTTPHeaderMap.cpp:
      (WebCore::HTTPHeaderMap::copyData):
      * platform/network/ResourceRequestBase.cpp:
      * platform/network/ResourceResponseBase.cpp:
      (WebCore::ResourceResponseBase::parseCacheControlDirectives):
      * platform/network/cf/ResourceResponseCFNet.cpp:
      * platform/network/mac/ResourceResponseMac.mm:
      (WebCore::ResourceResponse::initNSURLResponse):
      * platform/text/TextBreakIteratorICU.cpp:
      (WebCore::textClone):
      (WebCore::textLatin1MoveInPrimaryContext):
      (WebCore::textLatin1MoveInPriorContext):
      (WebCore::textInChunkOrOutOfRange):
      (WebCore::textOpenLatin1):
      (WebCore::textUTF16MoveInPrimaryContext):
      (WebCore::textUTF16MoveInPriorContext):
      (WebCore::textOpenUTF16):
      * platform/text/TextCodecUTF16.cpp:
      (WebCore::TextCodecUTF16::encode):
      * platform/text/TextCodecUTF8.cpp:
      (WebCore::TextCodecUTF8::encode):
      * platform/text/TextStream.cpp:
      * platform/text/mac/LocaleMac.mm:
      * platform/text/mac/TextCodecMac.cpp:
      (WebCore::TextCodecMac::decode):
      * rendering/AutoTableLayout.cpp:
      (WebCore::AutoTableLayout::recalcColumn):
      (WebCore::AutoTableLayout::computeIntrinsicLogicalWidths):
      (WebCore::AutoTableLayout::applyPreferredLogicalWidthQuirks):
      (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
      (WebCore::AutoTableLayout::layout):
      * rendering/FixedTableLayout.cpp:
      (WebCore::FixedTableLayout::applyPreferredLogicalWidthQuirks):
      * rendering/FloatingObjects.cpp:
      (WebCore::FindNextFloatLogicalBottomAdapter::collectIfNeeded):
      (WebCore::FloatingObjects::logicalRightOffsetForPositioningFloat):
      (WebCore::FloatingObjects::logicalRightOffset):
      * rendering/InlineBox.cpp:
      * rendering/InlineFlowBox.cpp:
      (WebCore::InlineFlowBox::placeBoxRangeInInlineDirection):
      (WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
      (WebCore::InlineFlowBox::placeBoxesInBlockDirection):
      (WebCore::InlineFlowBox::computeMaxLogicalTop):
      (WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
      (WebCore::InlineFlowBox::addBorderOutsetVisualOverflow):
      (WebCore::InlineFlowBox::addTextBoxVisualOverflow):
      (WebCore::InlineFlowBox::nodeAtPoint):
      (WebCore::InlineFlowBox::constrainToLineTopAndBottomIfNeeded):
      (WebCore::InlineFlowBox::computeOverAnnotationAdjustment):
      (WebCore::InlineFlowBox::computeUnderAnnotationAdjustment):
      (WebCore::InlineFlowBox::collectLeafBoxesInLogicalOrder):
      * rendering/InlineTextBox.cpp:
      (WebCore::InlineTextBox::isSelected):
      (WebCore::InlineTextBox::localSelectionRect):
      (WebCore::InlineTextBox::placeEllipsisBox):
      (WebCore::InlineTextBox::applyShadowToGraphicsContext):
      (WebCore::InlineTextBox::paint):
      (WebCore::InlineTextBox::selectionStartEnd):
      (WebCore::InlineTextBox::paintSelection):
      (WebCore::InlineTextBox::paintCompositionBackground):
      (WebCore::computeUnderlineOffset):
      (WebCore::InlineTextBox::paintDecoration):
      (WebCore::InlineTextBox::paintDocumentMarker):
      (WebCore::InlineTextBox::paintTextMatchMarker):
      (WebCore::InlineTextBox::computeRectForReplacementMarker):
      (WebCore::InlineTextBox::paintCompositionUnderline):
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::computeOverflow):
      (WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):
      (WebCore::RenderBlock::paintChild):
      (WebCore::RenderBlock::blockSelectionGap):
      (WebCore::RenderBlock::logicalLeftSelectionGap):
      (WebCore::RenderBlock::logicalRightSelectionGap):
      (WebCore::RenderBlock::calcColumnWidth):
      (WebCore::RenderBlock::adjustRectForColumns):
      (WebCore::RenderBlock::computeIntrinsicLogicalWidths):
      (WebCore::RenderBlock::computePreferredLogicalWidths):
      (WebCore::RenderBlock::adjustIntrinsicLogicalWidthsForColumns):
      (WebCore::updatePreferredWidth):
      (WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
      (WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
      * rendering/RenderBlockFlow.cpp:
      (WebCore::RenderBlockFlow::clearFloats):
      (WebCore::RenderBlockFlow::layoutBlock):
      (WebCore::RenderBlockFlow::layoutBlockChild):
      (WebCore::RenderBlockFlow::collapseMargins):
      (WebCore::RenderBlockFlow::clearFloatsIfNeeded):
      (WebCore::RenderBlockFlow::marginBeforeEstimateForChild):
      (WebCore::RenderBlockFlow::estimateLogicalTopPosition):
      (WebCore::RenderBlockFlow::setCollapsedBottomMargin):
      (WebCore::RenderBlockFlow::handleAfterSideOfBlock):
      (WebCore::calculateMinimumPageHeight):
      (WebCore::RenderBlockFlow::adjustLinePositionForPagination):
      (WebCore::RenderBlockFlow::removeFloatingObject):
      (WebCore::RenderBlockFlow::computeLogicalLocationForFloat):
      (WebCore::RenderBlockFlow::positionNewFloats):
      (WebCore::RenderBlockFlow::lowestFloatLogicalBottom):
      (WebCore::RenderBlockFlow::addOverhangingFloats):
      (WebCore::RenderBlockFlow::getClearDelta):
      (WebCore::RenderBlockFlow::adjustForBorderFit):
      (WebCore::RenderBlockFlow::fitBorderToLinesIfNeeded):
      (WebCore::RenderBlockFlow::updateLogicalHeight):
      (WebCore::RenderBlockFlow::positionForPointWithInlineChildren):
      (WebCore::RenderBlockFlow::addFocusRingRectsForInlineChildren):
      (WebCore::RenderBlockFlow::relayoutForPagination):
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::updateLogicalWidthForLeftAlignedBlock):
      (WebCore::updateLogicalWidthForRightAlignedBlock):
      (WebCore::updateLogicalWidthForCenterAlignedBlock):
      (WebCore::setLogicalWidthForTextRun):
      (WebCore::RenderBlockFlow::computeInlineDirectionPositionsForLine):
      (WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
      (WebCore::RenderBlockFlow::layoutLineBoxes):
      (WebCore::RenderBlockFlow::checkFloatsInCleanLine):
      (WebCore::RenderBlockFlow::checkPaginationAndFloatsAtEndLine):
      (WebCore::tryHyphenating):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::scrollWidth):
      (WebCore::RenderBox::scrollHeight):
      (WebCore::RenderBox::constrainLogicalWidthInRegionByMinMax):
      (WebCore::RenderBox::constrainLogicalHeightByMinMax):
      (WebCore::RenderBox::constrainContentBoxLogicalHeightByMinMax):
      (WebCore::RenderBox::adjustBorderBoxLogicalWidthForBoxSizing):
      (WebCore::RenderBox::adjustBorderBoxLogicalHeightForBoxSizing):
      (WebCore::RenderBox::adjustContentBoxLogicalWidthForBoxSizing):
      (WebCore::RenderBox::adjustContentBoxLogicalHeightForBoxSizing):
      (WebCore::RenderBox::repaintLayerRectsForImage):
      (WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats):
      (WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion):
      (WebCore::RenderBox::containingBlockAvailableLineWidthInRegion):
      (WebCore::RenderBox::perpendicularContainingBlockLogicalHeight):
      (WebCore::RenderBox::computeLogicalWidthInRegion):
      (WebCore::RenderBox::computeIntrinsicLogicalWidthUsing):
      (WebCore::RenderBox::computeLogicalWidthInRegionUsing):
      (WebCore::RenderBox::computeInlineDirectionMargins):
      (WebCore::RenderBox::computeLogicalHeight):
      (WebCore::RenderBox::computePercentageLogicalHeight):
      (WebCore::RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth):
      (WebCore::RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight):
      (WebCore::RenderBox::computeReplacedLogicalHeightUsing):
      (WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
      (WebCore::RenderBox::computePositionedLogicalWidthUsing):
      (WebCore::RenderBox::computePositionedLogicalHeightUsing):
      (WebCore::RenderBox::applyVisualEffectOverflow):
      (WebCore::RenderBox::addLayoutOverflow):
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::calculateFillTileSize):
      (WebCore::RenderBoxModelObject::BackgroundImageGeometry::setNoRepeatX):
      (WebCore::RenderBoxModelObject::BackgroundImageGeometry::setNoRepeatY):
      (WebCore::RenderBoxModelObject::BackgroundImageGeometry::useFixedAttachment):
      (WebCore::RenderBoxModelObject::paintNinePieceImage):
      (WebCore::RenderBoxModelObject::paintOneBorderSide):
      (WebCore::calculateAdjustedInnerBorder):
      (WebCore::RenderBoxModelObject::paintBoxShadow):
      (WebCore::RenderBoxModelObject::localCaretRectForEmptyElement):
      * rendering/RenderDeprecatedFlexibleBox.cpp:
      (WebCore::FlexBoxIterator::next):
      (WebCore::RenderDeprecatedFlexibleBox::computeIntrinsicLogicalWidths):
      (WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):
      (WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
      (WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
      (WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
      (WebCore::RenderDeprecatedFlexibleBox::allowedChildFlex):
      * rendering/RenderFileUploadControl.cpp:
      (WebCore::RenderFileUploadControl::maxFilenameWidth):
      (WebCore::RenderFileUploadControl::computeIntrinsicLogicalWidths):
      (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
      * rendering/RenderImage.cpp:
      (WebCore::RenderImage::setImageSizeForAltText):
      * rendering/RenderInline.cpp:
      (WebCore::computeMargin):
      (WebCore::RenderInline::linesVisualOverflowBoundingBox):
      (WebCore::RenderInline::paintOutline):
      (WebCore::RenderInline::paintOutlineForLine):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::clampScrollOffset):
      (WebCore::RenderLayer::scrollRectToVisible):
      (WebCore::RenderLayer::visibleContentRect):
      (WebCore::RenderLayer::updateScrollbarsAfterLayout):
      (WebCore::RenderLayer::hitTestOverflowControls):
      (WebCore::RenderLayer::hitTestLayer):
      (WebCore::RenderLayer::calculateLayerBounds):
      * rendering/RenderLayerBacking.cpp:
      * rendering/RenderLayerModelObject.cpp:
      * rendering/RenderLineBoxList.cpp:
      (WebCore::RenderLineBoxList::rangeIntersectsRect):
      (WebCore::RenderLineBoxList::anyLineIntersectsRect):
      (WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
      (WebCore::RenderLineBoxList::paint):
      * rendering/RenderListBox.cpp:
      (WebCore::RenderListBox::updateFromElement):
      (WebCore::RenderListBox::layout):
      (WebCore::RenderListBox::computePreferredLogicalWidths):
      (WebCore::RenderListBox::size):
      (WebCore::RenderListBox::numVisibleItems):
      (WebCore::RenderListBox::panScroll):
      (WebCore::RenderListBox::scrollHeight):
      * rendering/RenderListItem.cpp:
      * rendering/RenderListMarker.cpp:
      * rendering/RenderMarquee.cpp:
      (WebCore::RenderMarquee::marqueeSpeed):
      (WebCore::RenderMarquee::computePosition):
      (WebCore::RenderMarquee::timerFired):
      * rendering/RenderMediaControls.cpp:
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::updateOptionsWidth):
      (WebCore::RenderMenuList::computeIntrinsicLogicalWidths):
      (WebCore::RenderMenuList::computePreferredLogicalWidths):
      * rendering/RenderMeter.cpp:
      * rendering/RenderMultiColumnBlock.cpp:
      * rendering/RenderMultiColumnSet.cpp:
      (WebCore::RenderMultiColumnSet::heightAdjustedForSetOffset):
      (WebCore::RenderMultiColumnSet::calculateBalancedHeight):
      (WebCore::RenderMultiColumnSet::updateLogicalWidth):
      * rendering/RenderNamedFlowFragment.cpp:
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::drawLineForBoxSide):
      (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
      (WebCore::RenderObject::caretMaxOffset):
      * rendering/RenderProgress.cpp:
      * rendering/RenderRegion.cpp:
      (WebCore::RenderRegion::overflowRectForFlowThreadPortion):
      * rendering/RenderReplaced.cpp:
      (WebCore::RenderReplaced::shouldPaint):
      (WebCore::RenderReplaced::computeReplacedLogicalWidth):
      (WebCore::RenderReplaced::computePreferredLogicalWidths):
      * rendering/RenderRubyBase.cpp:
      * rendering/RenderRubyRun.cpp:
      (WebCore::RenderRubyRun::getOverhang):
      * rendering/RenderRubyText.cpp:
      (WebCore::RenderRubyText::adjustInlineDirectionLineBounds):
      * rendering/RenderScrollbarPart.cpp:
      (WebCore::RenderScrollbarPart::computeScrollbarWidth):
      (WebCore::RenderScrollbarPart::computeScrollbarHeight):
      * rendering/RenderSearchField.cpp:
      (WebCore::RenderSearchField::computeControlLogicalHeight):
      * rendering/RenderTable.cpp:
      (WebCore::RenderTable::updateLogicalWidth):
      (WebCore::RenderTable::convertStyleLogicalHeightToComputedHeight):
      (WebCore::RenderTable::layout):
      (WebCore::RenderTable::computePreferredLogicalWidths):
      (WebCore::RenderTable::calcBorderStart):
      (WebCore::RenderTable::calcBorderEnd):
      (WebCore::RenderTable::outerBorderBefore):
      (WebCore::RenderTable::outerBorderAfter):
      (WebCore::RenderTable::outerBorderStart):
      (WebCore::RenderTable::outerBorderEnd):
      * rendering/RenderTableCell.cpp:
      (WebCore::RenderTableCell::parseColSpanFromDOM):
      (WebCore::RenderTableCell::parseRowSpanFromDOM):
      (WebCore::RenderTableCell::logicalWidthFromColumns):
      (WebCore::RenderTableCell::computePreferredLogicalWidths):
      (WebCore::RenderTableCell::layout):
      (WebCore::RenderTableCell::setOverrideLogicalContentHeightFromRowHeight):
      (WebCore::RenderTableCell::clippedOverflowRectForRepaint):
      (WebCore::RenderTableCell::alignLeftRightBorderPaintRect):
      (WebCore::RenderTableCell::alignTopBottomBorderPaintRect):
      * rendering/RenderTableSection.cpp:
      (WebCore::RenderTableSection::ensureRows):
      (WebCore::RenderTableSection::calcRowLogicalHeight):
      (WebCore::RenderTableSection::distributeExtraLogicalHeightToPercentRows):
      (WebCore::RenderTableSection::layoutRows):
      (WebCore::RenderTableSection::firstLineBaseline):
      (WebCore::RenderTableSection::removeCachedCollapsedBorders):
      (WebCore::RenderTableSection::setCachedCollapsedBorder):
      (WebCore::RenderTableSection::cachedCollapsedBorder):
      * rendering/RenderText.cpp:
      (WebCore::makeCapitalized):
      (WebCore::RenderText::absoluteRectsForRange):
      (WebCore::RenderText::absoluteQuadsForRange):
      (WebCore::maxWordFragmentWidth):
      (WebCore::RenderText::computePreferredLogicalWidths):
      * rendering/RenderTextControl.cpp:
      (WebCore::RenderTextControl::computePreferredLogicalWidths):
      * rendering/RenderTextControlSingleLine.cpp:
      * rendering/RenderThemeMac.mm:
      (WebCore::RenderThemeMac::paintProgressBar):
      (WebCore::RenderThemeMac::paintMenuListButton):
      * rendering/RenderWidget.cpp:
      * rendering/RootInlineBox.cpp:
      (WebCore::RootInlineBox::alignBoxesInBlockDirection):
      (WebCore::RootInlineBox::beforeAnnotationsAdjustment):
      (WebCore::RootInlineBox::selectionTopAdjustedForPrecedingBlock):
      (WebCore::RootInlineBox::blockDirectionPointInLine):
      (WebCore::RootInlineBox::paddedLayoutOverflowRect):
      (WebCore::setAscentAndDescent):
      (WebCore::RootInlineBox::ascentAndDescentForBox):
      * rendering/mathml/RenderMathMLRoot.cpp:
      (WebCore::RenderMathMLRoot::layout):
      * rendering/style/RenderStyle.cpp:
      (WebCore::calcConstraintScaleFor):
      (WebCore::RenderStyle::setFontSize):
      (WebCore::RenderStyle::getShadowExtent):
      (WebCore::RenderStyle::getShadowInsetExtent):
      (WebCore::RenderStyle::getShadowHorizontalExtent):
      (WebCore::RenderStyle::getShadowVerticalExtent):
      * rendering/style/SVGRenderStyle.cpp:
      * rendering/style/ShadowData.cpp:
      (WebCore::calculateShadowExtent):
      * rendering/svg/RenderSVGResourceFilter.cpp:
      * rendering/svg/RenderSVGRoot.cpp:
      * rendering/svg/SVGInlineFlowBox.cpp:
      (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
      * rendering/svg/SVGInlineTextBox.cpp:
      (WebCore::SVGInlineTextBox::localSelectionRect):
      * svg/SVGAnimatedNumber.cpp:
      * svg/SVGAnimatedNumberOptionalNumber.cpp:
      * svg/animation/SMILTimeContainer.cpp:
      (WebCore::SMILTimeContainer::startTimer):
      (WebCore::SMILTimeContainer::updateAnimations):
      * svg/animation/SVGSMILElement.cpp:
      (WebCore::SVGSMILElement::simpleDuration):
      (WebCore::SVGSMILElement::repeatingDuration):
      (WebCore::SVGSMILElement::resolveActiveEnd):
      (WebCore::SVGSMILElement::resolveInterval):
      (WebCore::SVGSMILElement::resolveFirstInterval):
      (WebCore::SVGSMILElement::resolveNextInterval):
      (WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):
      * xml/XMLTreeViewer.cpp:
      * xml/parser/XMLDocumentParser.cpp:
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      (WebCore::OffsetBuffer::readOutBytes):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159027 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8629863f
  4. 29 Oct, 2013 1 commit
  5. 27 Sep, 2013 1 commit
    • darin@apple.com's avatar
      Add empty MainFrame class · ade301ac
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121770
      
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      For now, MainFrame simply derives from Frame and adds nothing.
      Next, we will make each Frame point back to its MainFrame.
      
      * CMakeLists.txt: Added MainFrame.cpp/h.
      * GNUmakefile.list.am: Ditto.
      * Target.pri: Ditto.
      * WebCore.exp.in: Ditto.
      * WebCore.vcxproj/WebCore.vcxproj: Ditto.
      * WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
      * WebCore.xcodeproj/project.pbxproj: Ditto.
      
      * page/Frame.cpp:
      (WebCore::Frame::Frame): Use references instead of pointers for constructor.
      (WebCore::Frame::create): Pass references instead of pointers to constructor.
      * page/Frame.h: Made constructor protected instead of private, and marked
      destructor virtual explicitly. Also marked virtual functions OVERRIDE and FINAL.
      
      * page/MainFrame.cpp: Added.
      * page/MainFrame.h: Added.
      
      * page/Page.cpp:
      (WebCore::Page::Page): Use MainFrame::create instead of Frame::create.
      (WebCore::Page::frameIsMainFrame): Moved here, no longer inline.
      (WebCore::Page::renderTreeSize): Use const Frame* instead of Frame*.
      (WebCore::Page::checkSubframeCountConsistency): Ditto.
      * page/Page.h: Changed mainFrame() to return MainFrame& and m_mainFrame to
      be a RefPtr<MainFrame>.
      
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      * bindings/js/PageScriptDebugServer.cpp:
      * bindings/js/ScriptProfiler.cpp:
      * bindings/js/ScriptState.cpp:
      * css/MediaQueryEvaluator.cpp:
      * dom/Document.cpp:
      * history/CachedFrame.cpp:
      * history/CachedPage.cpp:
      * history/PageCache.cpp:
      * html/HTMLPlugInImageElement.cpp:
      * inspector/InspectorAgent.cpp:
      * inspector/InspectorCanvasAgent.cpp:
      * inspector/InspectorClient.cpp:
      * inspector/InspectorDOMAgent.cpp:
      * inspector/InspectorFrontendClientLocal.cpp:
      * inspector/InspectorFrontendHost.cpp:
      * inspector/InspectorInputAgent.cpp:
      * inspector/InspectorInstrumentation.cpp:
      * inspector/InspectorOverlay.cpp:
      * inspector/InspectorPageAgent.cpp:
      * inspector/PageRuntimeAgent.cpp:
      * loader/FrameLoader.cpp:
      * loader/HistoryController.cpp:
      * loader/archive/mhtml/MHTMLArchive.cpp:
      * page/AutoscrollController.cpp:
      * page/Chrome.cpp:
      * page/ContextMenuController.cpp:
      * page/DOMWindow.cpp:
      * page/DragController.cpp:
      * page/EventHandler.cpp:
      * page/FocusController.cpp:
      * page/FrameTree.cpp:
      * page/FrameView.cpp:
      * page/GestureTapHighlighter.cpp:
      * page/PageGroup.cpp:
      * page/PageGroupLoadDeferrer.cpp:
      * page/PageSerializer.cpp:
      * page/PageThrottler.cpp:
      * page/Settings.cpp:
      * page/SpatialNavigation.cpp:
      * page/mac/DragControllerMac.mm:
      * page/mac/PageMac.cpp:
      * page/scrolling/ScrollingCoordinator.cpp:
      * page/scrolling/mac/ScrollingCoordinatorMac.mm:
      * platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
      * plugins/DOMMimeType.cpp:
      * storage/StorageEventDispatcher.cpp:
      * svg/graphics/SVGImage.cpp:
      * testing/InternalSettings.cpp:
      * testing/Internals.cpp:
      Include MainFrame.h instead of Frame.h as needed.
      
      Source/WebKit/efl:
      
      * WebCoreSupport/AcceleratedCompositingContextEfl.cpp:
      * WebCoreSupport/InspectorClientEfl.cpp:
      * ewk/ewk_view.cpp:
      Include MainFrame.h instead of Frame.h as needed.
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/AcceleratedCompositingContextGL.cpp:
      * WebCoreSupport/ChromeClientGtk.cpp:
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      * WebCoreSupport/GtkAdjustmentWatcher.cpp:
      * webkit/webkitwebframe.cpp:
      * webkit/webkitwebview.cpp:
      * webkit/webkitviewportattributes.cpp:
      Include MainFrame.h instead of Frame.h as needed.
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebDragClient.mm:
      * WebCoreSupport/WebInspectorClient.mm:
      * WebCoreSupport/WebPlatformStrategies.mm:
      * WebView/WebFrame.mm:
      * WebView/WebHTMLView.mm:
      * WebView/WebView.mm:
      Include MainFrame.h instead of Frame.h as needed.
      
      Source/WebKit/qt:
      
      * Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:
      * Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:
      * Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp:
      * Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      * Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:
      * Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp:
      Include MainFrame.h instead of Frame.h as needed.
      
      Source/WebKit/win:
      
      * win/WebCoreSupport/WebDragClient.cpp:
      * win/WebCoreSupport/WebContextMenuClient.cpp:
      * win/WebDropSource.cpp:
      * win/WebFrame.cpp:
      * win/WebView.cpp:
      Include MainFrame.h instead of Frame.h as needed.
      
      Source/WebKit2:
      
      * WebProcess/FullScreen/WebFullScreenManager.cpp:
      * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      * WebProcess/Plugins/PluginView.cpp:
      * WebProcess/Storage/StorageAreaMap.cpp:
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
      * WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
      * WebProcess/WebPage/FindController.cpp:
      * WebProcess/WebPage/PageOverlay.cpp:
      * WebProcess/WebPage/WebInspector.cpp:
      * WebProcess/WebPage/WebPage.cpp:
      * WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp:
      * WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
      * WebProcess/WebPage/mac/LayerTreeHostMac.mm:
      * WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
      * WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:
      * WebProcess/WebPage/mac/WebPageMac.mm:
      Include MainFrame.h instead of Frame.h as needed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156543 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ade301ac
  6. 13 Sep, 2013 1 commit
    • weinig@apple.com's avatar
      Chrome, DragController and FocusController should hold onto a Page& · fede3e50
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121325
      
      Reviewed by Anders Carlsson.
      
      * editing/FrameSelection.cpp:
      * editing/FrameSelection.h:
      * page/Chrome.cpp:
      (WebCore::Chrome::Chrome):
      (WebCore::Chrome::scroll):
      (WebCore::Chrome::createWindow):
      (WebCore::canRunModalIfDuringPageDismissal):
      (WebCore::Chrome::runBeforeUnloadConfirmPanel):
      (WebCore::Chrome::runJavaScriptAlert):
      (WebCore::Chrome::runJavaScriptConfirm):
      (WebCore::Chrome::runJavaScriptPrompt):
      (WebCore::Chrome::mouseDidMoveOverElement):
      (WebCore::Chrome::setToolTip):
      (WebCore::Chrome::windowScreenDidChange):
      * page/Chrome.h:
      * page/DragController.cpp:
      * page/DragController.h:
      * page/mac/DragControllerMac.mm:
      * page/FocusController.cpp:
      * page/FocusController.h:
      * page/Page.cpp:
      (WebCore::Page::Page):
      * page/PageGroupLoadDeferrer.cpp:
      * page/PageGroupLoadDeferrer.h:
      Take references where possible.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155731 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fede3e50
  7. 01 Sep, 2013 1 commit
    • darin@apple.com's avatar
      HitTestResult should have innerNonSharedElement · 9013318e
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120579
      
      Reviewed by Andreas Kling.
      
      * editing/Editor.cpp:
      (WebCore::Editor::copyImage): Call HitTestResult member function version of
      innerNonSharedElement instead of a local function that does it.
      
      * page/Chrome.cpp:
      (WebCore::Chrome::setToolTip): Use innerNonSharedElement instead of getting
      the node and checking if it's an input element. Also added some missing braces.
      
      * page/EventHandler.cpp:
      (WebCore::EventHandler::selectClosestWordFromHitTestResult): Use targetNode for
      local variables instead of innerNode to match the HitTestResult function name.
      (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent): Ditto.
      (WebCore::EventHandler::handleMousePressEventTripleClick): Ditto.
      (WebCore::EventHandler::handleMousePressEventSingleClick): Ditto.
      (WebCore::EventHandler::handleMousePressEvent): Ditto.
      
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestResult::innerElement): Rewrote so there there is no loop.
      (WebCore::HitTestResult::innerNonSharedElement): Ditto.
      
      * rendering/HitTestResult.h: Added innerNonSharedElement. Generally speaking,
      we'd like to avoid using Node unless there is some real need.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154945 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9013318e
  8. 30 Aug, 2013 1 commit
  9. 27 Aug, 2013 1 commit
  10. 25 Aug, 2013 1 commit
    • darin@apple.com's avatar
      Frame::tree should return a reference instead of a pointer · fed4d16e
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120259
      
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      * page/Frame.h:
      (WebCore::Frame::tree): Return a reference instead of a pointer.
      
      * bindings/js/JSDOMWindowCustom.cpp:
      (WebCore::childFrameGetter):
      (WebCore::indexGetter):
      (WebCore::JSDOMWindow::getOwnPropertySlot):
      (WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
      (WebCore::JSDOMWindow::setLocation):
      * bindings/js/PageScriptDebugServer.cpp:
      (WebCore::PageScriptDebugServer::setJavaScriptPaused):
      * dom/Document.cpp:
      (WebCore::canAccessAncestor):
      (WebCore::Document::adoptNode):
      (WebCore::Document::canNavigate):
      (WebCore::Document::findUnsafeParentScrollPropagationBoundary):
      (WebCore::Document::notifySeamlessChildDocumentsOfStylesheetUpdate):
      (WebCore::Document::openSearchDescriptionURL):
      (WebCore::Document::setDesignMode):
      (WebCore::Document::parentDocument):
      (WebCore::Document::initSecurityContext):
      (WebCore::Document::initContentSecurityPolicy):
      (WebCore::Document::requestFullScreenForElement):
      (WebCore::Document::webkitExitFullscreen):
      (WebCore::Document::didRemoveTouchEventHandler):
      * dom/TreeScope.cpp:
      (WebCore::focusedFrameOwnerElement):
      * editing/FrameSelection.cpp:
      (WebCore::FrameSelection::selectFrameElementInParentIfFullySelected):
      * history/CachedFrame.cpp:
      (WebCore::CachedFrameBase::CachedFrameBase):
      (WebCore::CachedFrameBase::restore):
      (WebCore::CachedFrame::CachedFrame):
      * history/CachedPage.cpp:
      (WebCore::CachedPage::restore):
      * history/PageCache.cpp:
      (WebCore::logCanCacheFrameDecision):
      (WebCore::PageCache::canCachePageContainingThisFrame):
      * html/HTMLDocument.cpp:
      (WebCore::HTMLDocument::hasFocus):
      * html/HTMLPlugInImageElement.cpp:
      (WebCore::HTMLPlugInImageElement::restartSimilarPlugIns):
      * inspector/InspectorApplicationCacheAgent.cpp:
      (WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
      * inspector/InspectorCanvasAgent.cpp:
      (WebCore::InspectorCanvasAgent::findFramesWithUninstrumentedCanvases):
      (WebCore::InspectorCanvasAgent::frameNavigated):
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::documents):
      * inspector/InspectorFileSystemAgent.cpp:
      (WebCore::InspectorFileSystemAgent::assertScriptExecutionContextForOrigin):
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::getCookies):
      (WebCore::InspectorPageAgent::deleteCookie):
      (WebCore::InspectorPageAgent::searchInResources):
      (WebCore::InspectorPageAgent::findFrameWithSecurityOrigin):
      (WebCore::InspectorPageAgent::buildObjectForFrame):
      (WebCore::InspectorPageAgent::buildObjectForFrameTree):
      * inspector/PageRuntimeAgent.cpp:
      (WebCore::PageRuntimeAgent::reportExecutionContextCreation):
      * loader/DocumentLoader.cpp:
      (WebCore::DocumentLoader::willSendRequest):
      (WebCore::DocumentLoader::mainResource):
      * loader/DocumentWriter.cpp:
      (WebCore::DocumentWriter::createDecoderIfNeeded):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::submitForm):
      (WebCore::FrameLoader::allChildrenAreComplete):
      (WebCore::FrameLoader::allAncestorsAreComplete):
      (WebCore::FrameLoader::loadURLIntoChildFrame):
      (WebCore::FrameLoader::outgoingReferrer):
      (WebCore::FrameLoader::updateFirstPartyForCookies):
      (WebCore::FrameLoader::setFirstPartyForCookies):
      (WebCore::FrameLoader::completed):
      (WebCore::FrameLoader::started):
      (WebCore::FrameLoader::loadURL):
      (WebCore::FrameLoader::loadWithDocumentLoader):
      (WebCore::FrameLoader::stopAllLoaders):
      (WebCore::FrameLoader::commitProvisionalLoad):
      (WebCore::FrameLoader::closeOldDataSources):
      (WebCore::FrameLoader::prepareForCachedPageRestore):
      (WebCore::FrameLoader::subframeIsLoading):
      (WebCore::FrameLoader::subresourceCachePolicy):
      (WebCore::FrameLoader::detachChildren):
      (WebCore::FrameLoader::closeAndRemoveChild):
      (WebCore::FrameLoader::checkLoadComplete):
      (WebCore::FrameLoader::numPendingOrLoadingRequests):
      (WebCore::FrameLoader::detachFromParent):
      (WebCore::FrameLoader::shouldClose):
      (WebCore::FrameLoader::handleBeforeUnloadEvent):
      (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
      (WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):
      (WebCore::FrameLoader::findFrameForNavigation):
      (WebCore::FrameLoader::effectiveSandboxFlags):
      (WebCore::createWindow):
      * loader/HistoryController.cpp:
      (WebCore::HistoryController::saveDocumentState):
      (WebCore::HistoryController::saveDocumentAndScrollState):
      (WebCore::HistoryController::restoreDocumentState):
      (WebCore::HistoryController::goToItem):
      (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
      (WebCore::HistoryController::recursiveUpdateForCommit):
      (WebCore::HistoryController::recursiveUpdateForSameDocumentNavigation):
      (WebCore::HistoryController::initializeItem):
      (WebCore::HistoryController::createItemTree):
      (WebCore::HistoryController::recursiveSetProvisionalItem):
      (WebCore::HistoryController::recursiveGoToItem):
      (WebCore::HistoryController::currentFramesMatchItem):
      * loader/NavigationScheduler.cpp:
      (WebCore::NavigationScheduler::mustLockBackForwardList):
      (WebCore::NavigationScheduler::scheduleFormSubmission):
      * loader/ProgressTracker.cpp:
      (WebCore::ProgressTracker::progressStarted):
      (WebCore::ProgressTracker::progressCompleted):
      (WebCore::ProgressTracker::isMainLoadProgressing):
      * loader/appcache/ApplicationCacheGroup.cpp:
      (WebCore::ApplicationCacheGroup::selectCache):
      (WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL):
      * loader/archive/cf/LegacyWebArchive.cpp:
      (WebCore::LegacyWebArchive::create):
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::checkInsecureContent):
      * loader/icon/IconController.cpp:
      (WebCore::IconController::urlsForTypes):
      (WebCore::IconController::startLoader):
      * page/Chrome.cpp:
      (WebCore::canRunModalIfDuringPageDismissal):
      (WebCore::Chrome::windowScreenDidChange):
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::length):
      (WebCore::DOMWindow::name):
      (WebCore::DOMWindow::setName):
      (WebCore::DOMWindow::parent):
      (WebCore::DOMWindow::top):
      (WebCore::DOMWindow::open):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::scrollRecursively):
      (WebCore::EventHandler::logicalScrollRecursively):
      (WebCore::EventHandler::handleMouseMoveEvent):
      * page/FocusController.cpp:
      (WebCore::FocusController::setContainingWindowIsVisible):
      * page/Frame.cpp:
      (WebCore::parentPageZoomFactor):
      (WebCore::parentTextZoomFactor):
      (WebCore::Frame::setPrinting):
      (WebCore::Frame::shouldUsePrintingLayout):
      (WebCore::Frame::dispatchVisibilityStateChangeEvent):
      (WebCore::Frame::willDetachPage):
      (WebCore::Frame::setPageAndTextZoomFactors):
      (WebCore::Frame::deviceOrPageScaleFactorChanged):
      (WebCore::Frame::notifyChromeClientWheelEventHandlerCountChanged):
      (WebCore::Frame::isURLAllowed):
      * page/FrameTree.cpp:
      (WebCore::FrameTree::~FrameTree):
      (WebCore::FrameTree::setName):
      (WebCore::FrameTree::transferChild):
      (WebCore::FrameTree::appendChild):
      (WebCore::FrameTree::actuallyAppendChild):
      (WebCore::FrameTree::removeChild):
      (WebCore::FrameTree::uniqueChildName):
      (WebCore::FrameTree::scopedChild):
      (WebCore::FrameTree::scopedChildCount):
      (WebCore::FrameTree::childCount):
      (WebCore::FrameTree::child):
      (WebCore::FrameTree::find):
      (WebCore::FrameTree::isDescendantOf):
      (WebCore::FrameTree::traverseNext):
      (WebCore::FrameTree::traversePreviousWithWrap):
      (WebCore::FrameTree::deepLastChild):
      (WebCore::FrameTree::top):
      (printFrames):
      (showFrameTree):
      * page/FrameView.cpp:
      (WebCore::FrameView::setFrameRect):
      (WebCore::FrameView::hasCompositedContentIncludingDescendants):
      (WebCore::FrameView::hasCompositingAncestor):
      (WebCore::FrameView::flushCompositingStateIncludingSubframes):
      (WebCore::FrameView::updateCanBlitOnScrollRecursively):
      (WebCore::FrameView::setIsOverlapped):
      (WebCore::FrameView::shouldUseLoadTimeDeferredRepaintDelay):
      (WebCore::FrameView::updateLayerFlushThrottlingInAllFrames):
      (WebCore::FrameView::serviceScriptedAnimations):
      (WebCore::FrameView::updateBackgroundRecursively):
      (WebCore::FrameView::parentFrameView):
      (WebCore::FrameView::paintContentsForSnapshot):
      (WebCore::FrameView::setTracksRepaints):
      (WebCore::FrameView::notifyWidgetsInAllFrames):
      * page/Location.cpp:
      (WebCore::Location::ancestorOrigins):
      * page/Page.cpp:
      (WebCore::networkStateChanged):
      (WebCore::Page::~Page):
      (WebCore::Page::renderTreeSize):
      (WebCore::Page::updateStyleForAllPagesAfterGlobalChangeInEnvironment):
      (WebCore::Page::setNeedsRecalcStyleInAllFrames):
      (WebCore::Page::refreshPlugins):
      (WebCore::Page::takeAnyMediaCanStartListener):
      (WebCore::incrementFrame):
      (WebCore::Page::setDefersLoading):
      (WebCore::Page::setMediaVolume):
      (WebCore::Page::setDeviceScaleFactor):
      (WebCore::Page::setShouldSuppressScrollbarAnimations):
      (WebCore::Page::didMoveOnscreen):
      (WebCore::Page::willMoveOffscreen):
      (WebCore::Page::setIsInWindow):
      (WebCore::Page::suspendScriptedAnimations):
      (WebCore::Page::resumeScriptedAnimations):
      (WebCore::Page::userStyleSheetLocationChanged):
      (WebCore::Page::allVisitedStateChanged):
      (WebCore::Page::visitedStateChanged):
      (WebCore::Page::setDebugger):
      (WebCore::Page::setMemoryCacheClientCallsEnabled):
      (WebCore::Page::setMinimumTimerInterval):
      (WebCore::Page::setTimerAlignmentInterval):
      (WebCore::Page::dnsPrefetchingStateChanged):
      (WebCore::Page::collectPluginViews):
      (WebCore::Page::storageBlockingStateChanged):
      (WebCore::Page::privateBrowsingStateChanged):
      (WebCore::Page::checkSubframeCountConsistency):
      (WebCore::Page::suspendActiveDOMObjectsAndAnimations):
      (WebCore::Page::resumeActiveDOMObjectsAndAnimations):
      (WebCore::Page::captionPreferencesChanged):
      * page/PageGroup.cpp:
      (WebCore::PageGroup::invalidateInjectedStyleSheetCacheInAllFrames):
      * page/PageGroupLoadDeferrer.cpp:
      (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
      (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
      * page/PageSerializer.cpp:
      (WebCore::PageSerializer::serializeFrame):
      * page/PageThrottler.cpp:
      (WebCore::PageThrottler::throttlePage):
      (WebCore::PageThrottler::unthrottlePage):
      * page/Settings.cpp:
      (WebCore::setImageLoadingSettings):
      (WebCore::Settings::setTextAutosizingFontScaleFactor):
      * page/SpatialNavigation.cpp:
      (WebCore::rectToAbsoluteCoordinates):
      * page/animation/AnimationController.cpp:
      (WebCore::AnimationControllerPrivate::suspendAnimations):
      (WebCore::AnimationControllerPrivate::resumeAnimations):
      * page/mac/PageMac.cpp:
      (WebCore::Page::addSchedulePair):
      (WebCore::Page::removeSchedulePair):
      * page/scrolling/ScrollingCoordinator.cpp:
      (WebCore::ScrollingCoordinator::computeNonFastScrollableRegion):
      (WebCore::ScrollingCoordinator::computeCurrentWheelEventHandlerCount):
      * plugins/PluginView.cpp:
      (WebCore::PluginView::performRequest):
      (WebCore::PluginView::load):
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestResult::targetFrame):
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::enclosingCompositorFlushingLayers):
      (WebCore::RenderLayerCompositor::updateCompositingLayers):
      (WebCore::RenderLayerCompositor::notifyIFramesOfCompositingChange):
      * rendering/TextAutosizer.cpp:
      (WebCore::TextAutosizer::processSubtree):
      * storage/StorageEventDispatcher.cpp:
      (WebCore::StorageEventDispatcher::dispatchSessionStorageEvents):
      (WebCore::StorageEventDispatcher::dispatchLocalStorageEvents):
      * svg/SVGSVGElement.cpp:
      (WebCore::SVGSVGElement::currentScale):
      (WebCore::SVGSVGElement::setCurrentScale):
      * testing/Internals.cpp:
      (WebCore::Internals::formControlStateOfPreviousHistoryItem):
      (WebCore::Internals::setFormControlStateOfPreviousHistoryItem):
      (WebCore::Internals::numberOfScrollableAreas):
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      (WebCore::hasNoStyleInformation):
      Use tree(). instead of tree()->.
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::closeURLRecursively):
      (BlackBerry::WebKit::enableCrossSiteXHRRecursively):
      (BlackBerry::WebKit::WebPagePrivate::setScreenOrientation):
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      (WebCore::FrameLoaderClientBlackBerry::createFrame):
      * WebKitSupport/DOMSupport.cpp:
      (BlackBerry::WebKit::DOMSupport::convertPointToFrame):
      (BlackBerry::WebKit::DOMSupport::incrementFrame):
      Use tree(). instead of tree()->.
      
      Source/WebKit/efl:
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      (DumpRenderTreeSupportEfl::clearFrameName):
      (DumpRenderTreeSupportEfl::frameChildren):
      (DumpRenderTreeSupportEfl::frameParent):
      * ewk/ewk_frame.cpp:
      (_ewk_frame_children_iterator_next):
      (ewk_frame_child_find):
      (ewk_frame_name_get):
      (ewk_frame_child_add):
      * ewk/ewk_view.cpp:
      (ewk_view_frame_create):
      Use tree(). instead of tree()->.
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
      (DumpRenderTreeSupportGtk::getFrameChildren):
      (DumpRenderTreeSupportGtk::clearMainFrameName):
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      (WebKit::FrameLoaderClient::createFrame):
      * webkit/webkitwebframe.cpp:
      (webkit_web_frame_get_name):
      (webkit_web_frame_get_parent):
      (webkit_web_frame_find_frame):
      * webkit/webkitwebview.cpp:
      (webkit_web_view_set_highlight_text_matches):
      Use tree(). instead of tree()->.
      
      Source/WebKit/mac:
      
      * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
      (WebKit::NetscapePluginInstanceProxy::performRequest):
      * Plugins/WebBaseNetscapePluginView.mm:
      (-[WebBaseNetscapePluginView resolvedURLStringForURL:target:]):
      * Plugins/WebNetscapePluginView.mm:
      (-[WebNetscapePluginView loadPluginRequest:]):
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (applyAppleDictionaryApplicationQuirkNonInlinePart):
      (WebFrameLoaderClient::prepareForDataSourceReplacement):
      (WebFrameLoaderClient::createFrame):
      * WebView/WebFrame.mm:
      (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
      (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
      (-[WebFrame _unmarkAllBadGrammar]):
      (-[WebFrame _unmarkAllMisspellings]):
      (-[WebFrame _atMostOneFrameHasSelection]):
      (-[WebFrame _findFrameWithSelection]):
      (-[WebFrame _drawRect:contentsOnly:]):
      (-[WebFrame _isDescendantOfFrame:]):
      (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
      (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
      (-[WebFrame name]):
      (-[WebFrame findFrameNamed:]):
      (-[WebFrame parentFrame]):
      (-[WebFrame childFrames]):
      * WebView/WebView.mm:
      (-[WebView _attachScriptDebuggerToAllFrames]):
      (-[WebView _detachScriptDebuggerFromAllFrames]):
      (-[WebView _clearMainFrameName]):
      (-[WebView _isUsingAcceleratedCompositing]):
      (-[WebView _isSoftwareRenderable]):
      (-[WebView setHostWindow:]):
      (incrementFrame):
      Use tree(). instead of tree()->.
      
      Source/WebKit/qt:
      
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::clearFrameName):
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (drtDescriptionSuitableForTestResult):
      (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
      (WebCore::FrameLoaderClientQt::dispatchDidFinishDocumentLoad):
      (WebCore::FrameLoaderClientQt::postProgressStartedNotification):
      (WebCore::FrameLoaderClientQt::didPerformFirstNavigation):
      (WebCore::FrameLoaderClientQt::createFrame):
      * WebCoreSupport/QWebFrameAdapter.cpp:
      (QWebFrameData::QWebFrameData):
      (QWebFrameAdapter::load):
      (QWebFrameAdapter::uniqueName):
      (QWebFrameAdapter::childFrames):
      * WebCoreSupport/QWebPageAdapter.cpp:
      (QWebPageAdapter::findText):
      Use tree(). instead of tree()->.
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebFrameLoaderClient::createFrame):
      * WebFrame.cpp:
      (WebFrame::name):
      (WebFrame::findFrameNamed):
      (WebFrame::parentFrame):
      (EnumChildFrames::EnumChildFrames):
      (EnumChildFrames::Next):
      (EnumChildFrames::Skip):
      (EnumChildFrames::Reset):
      (WebFrame::isDescendantOfFrame):
      (WebFrame::unmarkAllMisspellings):
      (WebFrame::unmarkAllBadGrammar):
      * WebView.cpp:
      (WebView::initWithFrame):
      (incrementFrame):
      (WebView::clearMainFrameName):
      Use tree(). instead of tree()->.
      
      Source/WebKit/wince:
      
      * WebView.cpp:
      (WebView::createFrame):
      Use tree(). instead of tree()->.
      
      Source/WebKit2:
      
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::performJavaScriptURLRequest):
      * WebProcess/Storage/StorageAreaMap.cpp:
      (WebKit::StorageAreaMap::dispatchSessionStorageEvent):
      (WebKit::StorageAreaMap::dispatchLocalStorageEvent):
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::createFrame):
      * WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
      (WebKit::WebContextMenuClient::searchWithSpotlight):
      * WebProcess/WebPage/FindController.cpp:
      (WebKit::frameWithSelection):
      (WebKit::FindController::rectsForTextMatches):
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::init):
      (WebKit::WebFrame::contentsAsString):
      (WebKit::WebFrame::name):
      (WebKit::WebFrame::childFrames):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::clearMainFrameName):
      (WebKit::WebPage::setDrawsBackground):
      (WebKit::WebPage::setDrawsTransparentBackground):
      (WebKit::WebPage::setWindowResizerSize):
      (WebKit::frameWithSelection):
      (WebKit::WebPage::unmarkAllMisspellings):
      (WebKit::WebPage::unmarkAllBadGrammar):
      (WebKit::pageContainsAnyHorizontalScrollbars):
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
      (WebKit::TiledCoreAnimationDrawingArea::forceRepaint):
      Use tree(). instead of tree()->.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154558 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fed4d16e
  11. 19 Aug, 2013 1 commit
  12. 15 Aug, 2013 1 commit
    • andersca@apple.com's avatar
      <https://webkit.org/b/119859> Frame::loader() should return a reference · df550b96
      andersca@apple.com authored
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      * Modules/websockets/WebSocketChannel.cpp:
      (WebCore::WebSocketChannel::willOpenSocketStream):
      * WebCore.xcodeproj/project.pbxproj:
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::press):
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      (-[WebAccessibilityObjectWrapper remoteAccessibilityParentObject]):
      * bindings/ScriptControllerBase.cpp:
      (WebCore::ScriptController::canExecuteScripts):
      * bindings/js/ScriptController.cpp:
      (WebCore::ScriptController::initScript):
      * css/CSSFontSelector.cpp:
      (WebCore::CSSFontSelector::beginLoadTimerFired):
      * dom/DOMImplementation.cpp:
      (WebCore::DOMImplementation::createDocument):
      * dom/Document.cpp:
      (WebCore::Document::Document):
      (WebCore::Document::setVisualUpdatesAllowed):
      (WebCore::Document::updateTitle):
      (WebCore::Document::open):
      (WebCore::Document::explicitClose):
      (WebCore::Document::implicitClose):
      (WebCore::Document::userAgent):
      (WebCore::Document::canNavigate):
      (WebCore::Document::processHttpEquiv):
      (WebCore::Document::referrer):
      (WebCore::Document::documentDidResumeFromPageCache):
      (WebCore::Document::openSearchDescriptionURL):
      (WebCore::Document::finishedParsing):
      (WebCore::Document::addIconURL):
      (WebCore::Document::initSecurityContext):
      (WebCore::Document::updateURLForPushOrReplaceState):
      (WebCore::Document::loadEventDelayTimerFired):
      (WebCore::Document::loader):
      (WebCore::Document::decrementActiveParserCount):
      * history/CachedFrame.cpp:
      (WebCore::CachedFrameBase::CachedFrameBase):
      (WebCore::CachedFrameBase::restore):
      (WebCore::CachedFrame::CachedFrame):
      (WebCore::CachedFrame::open):
      (WebCore::CachedFrame::destroy):
      * history/PageCache.cpp:
      (WebCore::logCanCacheFrameDecision):
      (WebCore::logCanCachePageDecision):
      (WebCore::PageCache::canCachePageContainingThisFrame):
      (WebCore::PageCache::canCache):
      * html/HTMLAnchorElement.cpp:
      (WebCore::HTMLAnchorElement::handleClick):
      * html/HTMLAppletElement.cpp:
      (WebCore::HTMLAppletElement::updateWidget):
      * html/HTMLElement.cpp:
      (WebCore::HTMLElement::rendererIsNeeded):
      * html/HTMLEmbedElement.cpp:
      (WebCore::HTMLEmbedElement::updateWidget):
      * html/HTMLFormElement.cpp:
      (WebCore::HTMLFormElement::prepareForSubmission):
      (WebCore::HTMLFormElement::submit):
      * html/HTMLFrameElementBase.cpp:
      (WebCore::HTMLFrameElementBase::openURL):
      * html/HTMLFrameOwnerElement.cpp:
      (WebCore::HTMLFrameOwnerElement::disconnectContentFrame):
      * html/HTMLFrameSetElement.cpp:
      (WebCore::HTMLFrameSetElement::insertedInto):
      (WebCore::HTMLFrameSetElement::removedFrom):
      * html/HTMLHtmlElement.cpp:
      (WebCore::HTMLHtmlElement::insertedByParser):
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::createRenderer):
      (WebCore::HTMLMediaElement::attach):
      (WebCore::HTMLMediaElement::loadResource):
      (WebCore::HTMLMediaElement::getPluginProxyParams):
      (WebCore::HTMLMediaElement::createMediaPlayerProxy):
      (WebCore::HTMLMediaElement::updateWidget):
      (WebCore::HTMLMediaElement::mediaPlayerReferrer):
      (WebCore::HTMLMediaElement::mediaPlayerUserAgent):
      * html/HTMLObjectElement.cpp:
      (WebCore::HTMLObjectElement::parametersForPlugin):
      (WebCore::HTMLObjectElement::updateWidget):
      * html/HTMLPlugInImageElement.cpp:
      (WebCore::HTMLPlugInImageElement::isImageType):
      (WebCore::HTMLPlugInImageElement::wouldLoadAsNetscapePlugin):
      (WebCore::HTMLPlugInImageElement::restartSimilarPlugIns):
      * html/HTMLVideoElement.cpp:
      (WebCore::HTMLVideoElement::setDisplayMode):
      * html/ImageDocument.cpp:
      (WebCore::ImageDocumentParser::appendBytes):
      (WebCore::ImageDocumentParser::finish):
      (WebCore::ImageDocument::createDocumentStructure):
      * html/MediaDocument.cpp:
      (WebCore::MediaDocumentParser::createDocumentStructure):
      * html/PluginDocument.cpp:
      (WebCore::PluginDocumentParser::createDocumentStructure):
      (WebCore::PluginDocumentParser::appendBytes):
      (WebCore::PluginDocument::detach):
      (WebCore::PluginDocument::cancelManualPluginLoad):
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore::WebGLRenderingContext::create):
      (WebCore::WebGLRenderingContext::loseContextImpl):
      (WebCore::WebGLRenderingContext::maybeRestoreContext):
      * html/parser/HTMLConstructionSite.cpp:
      (WebCore::HTMLConstructionSite::dispatchDocumentElementAvailableIfNeeded):
      (WebCore::HTMLConstructionSite::insertHTMLBodyElement):
      * html/parser/HTMLParserOptions.cpp:
      (WebCore::HTMLParserOptions::HTMLParserOptions):
      * html/parser/XSSAuditor.cpp:
      (WebCore::XSSAuditor::init):
      * html/parser/XSSAuditorDelegate.cpp:
      (WebCore::XSSAuditorDelegate::generateViolationReport):
      (WebCore::XSSAuditorDelegate::didBlockScript):
      * inspector/InspectorApplicationCacheAgent.cpp:
      (WebCore::InspectorApplicationCacheAgent::updateApplicationCacheStatus):
      (WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
      * inspector/InspectorFrontendClientLocal.cpp:
      (WebCore::InspectorFrontendClientLocal::openInNewTab):
      * inspector/InspectorFrontendHost.cpp:
      (WebCore::InspectorFrontendHost::loadResourceSynchronously):
      * inspector/InspectorOverlay.cpp:
      (WebCore::InspectorOverlay::overlayPage):
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::mainResourceContent):
      (WebCore::InspectorPageAgent::reload):
      (WebCore::InspectorPageAgent::navigate):
      (WebCore::allResourcesURLsForFrame):
      (WebCore::InspectorPageAgent::searchInResource):
      (WebCore::InspectorPageAgent::assertDocumentLoader):
      (WebCore::InspectorPageAgent::buildObjectForFrame):
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::InspectorResourceAgent::didFailLoading):
      * loader/CookieJar.cpp:
      (WebCore::networkingContext):
      * loader/DocumentLoader.cpp:
      (WebCore::DocumentLoader::frameLoader):
      (WebCore::DocumentLoader::document):
      (WebCore::DocumentLoader::stopLoading):
      (WebCore::DocumentLoader::removeSubresourceLoader):
      (WebCore::DocumentLoader::subresourceLoaderFinishedLoadingOnePart):
      (WebCore::DocumentLoader::iconLoadDecisionAvailable):
      (WebCore::DocumentLoader::continueIconLoadWithDecision):
      * loader/DocumentThreadableLoader.cpp:
      (WebCore::DocumentThreadableLoader::didReceiveResponse):
      (WebCore::DocumentThreadableLoader::didFinishLoading):
      (WebCore::DocumentThreadableLoader::didFail):
      (WebCore::DocumentThreadableLoader::preflightFailure):
      (WebCore::DocumentThreadableLoader::loadRequest):
      * loader/DocumentWriter.cpp:
      (WebCore::DocumentWriter::replaceDocument):
      (WebCore::DocumentWriter::createDocument):
      (WebCore::DocumentWriter::begin):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::~FrameLoader):
      (WebCore::FrameLoader::allChildrenAreComplete):
      (WebCore::FrameLoader::allAncestorsAreComplete):
      (WebCore::FrameLoader::loadURLIntoChildFrame):
      (WebCore::FrameLoader::outgoingReferrer):
      (WebCore::FrameLoader::setOpener):
      (WebCore::FrameLoader::completed):
      (WebCore::FrameLoader::started):
      (WebCore::FrameLoader::loadFrameRequest):
      (WebCore::FrameLoader::loadURL):
      (WebCore::FrameLoader::load):
      (WebCore::FrameLoader::loadWithDocumentLoader):
      (WebCore::FrameLoader::stopAllLoaders):
      (WebCore::FrameLoader::closeOldDataSources):
      (WebCore::FrameLoader::subframeIsLoading):
      (WebCore::FrameLoader::subresourceCachePolicy):
      (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
      (WebCore::FrameLoader::detachChildren):
      (WebCore::FrameLoader::checkLoadComplete):
      (WebCore::FrameLoader::detachFromParent):
      (WebCore::FrameLoader::loadPostRequest):
      (WebCore::FrameLoader::loadResourceSynchronously):
      (WebCore::FrameLoader::shouldClose):
      (WebCore::FrameLoader::handleBeforeUnloadEvent):
      (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
      (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
      (WebCore::createWindow):
      * loader/HistoryController.cpp:
      (WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
      (WebCore::HistoryController::restoreScrollPositionAndViewState):
      (WebCore::HistoryController::saveDocumentState):
      (WebCore::HistoryController::saveDocumentAndScrollState):
      (WebCore::isAssociatedToRequestedHistoryItem):
      (WebCore::HistoryController::restoreDocumentState):
      (WebCore::HistoryController::shouldStopLoadingForHistoryItem):
      (WebCore::HistoryController::goToItem):
      (WebCore::HistoryController::updateForBackForwardNavigation):
      (WebCore::HistoryController::updateForReload):
      (WebCore::HistoryController::updateForStandardLoad):
      (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
      (WebCore::HistoryController::updateForClientRedirect):
      (WebCore::HistoryController::updateForCommit):
      (WebCore::HistoryController::recursiveUpdateForCommit):
      (WebCore::HistoryController::updateForSameDocumentNavigation):
      (WebCore::HistoryController::recursiveUpdateForSameDocumentNavigation):
      (WebCore::HistoryController::initializeItem):
      (WebCore::HistoryController::createItemTree):
      (WebCore::HistoryController::recursiveSetProvisionalItem):
      (WebCore::HistoryController::recursiveGoToItem):
      (WebCore::HistoryController::updateBackForwardListClippedAtTarget):
      (WebCore::HistoryController::updateCurrentItem):
      (WebCore::HistoryController::pushState):
      (WebCore::HistoryController::replaceState):
      * loader/ImageLoader.cpp:
      (WebCore::pageIsBeingDismissed):
      * loader/MixedContentChecker.cpp:
      (WebCore::MixedContentChecker::client):
      * loader/NavigationScheduler.cpp:
      (WebCore::ScheduledURLNavigation::fire):
      (WebCore::ScheduledURLNavigation::didStartTimer):
      (WebCore::ScheduledURLNavigation::didStopTimer):
      (WebCore::ScheduledRedirect::shouldStartTimer):
      (WebCore::ScheduledRedirect::fire):
      (WebCore::ScheduledRefresh::fire):
      (WebCore::ScheduledHistoryNavigation::fire):
      (WebCore::ScheduledFormSubmission::fire):
      (WebCore::ScheduledFormSubmission::didStartTimer):
      (WebCore::ScheduledFormSubmission::didStopTimer):
      (WebCore::NavigationScheduler::mustLockBackForwardList):
      (WebCore::NavigationScheduler::scheduleLocationChange):
      (WebCore::NavigationScheduler::scheduleFormSubmission):
      (WebCore::NavigationScheduler::scheduleRefresh):
      (WebCore::NavigationScheduler::schedule):
      * loader/PingLoader.cpp:
      (WebCore::PingLoader::loadImage):
      (WebCore::PingLoader::sendPing):
      (WebCore::PingLoader::sendViolationReport):
      (WebCore::PingLoader::PingLoader):
      * loader/PolicyChecker.cpp:
      (WebCore::PolicyChecker::checkNavigationPolicy):
      (WebCore::PolicyChecker::checkNewWindowPolicy):
      (WebCore::PolicyChecker::checkContentPolicy):
      (WebCore::PolicyChecker::cancelCheck):
      (WebCore::PolicyChecker::stopCheck):
      (WebCore::PolicyChecker::cannotShowMIMEType):
      (WebCore::PolicyChecker::continueLoadAfterWillSubmitForm):
      (WebCore::PolicyChecker::continueAfterNavigationPolicy):
      (WebCore::PolicyChecker::continueAfterNewWindowPolicy):
      (WebCore::PolicyChecker::handleUnimplementablePolicy):
      * loader/ProgressTracker.cpp:
      (WebCore::ProgressTracker::progressStarted):
      (WebCore::ProgressTracker::progressCompleted):
      (WebCore::ProgressTracker::finalProgressComplete):
      (WebCore::ProgressTracker::incrementProgress):
      (WebCore::ProgressTracker::progressHeartbeatTimerFired):
      * loader/ResourceLoadNotifier.cpp:
      (WebCore::ResourceLoadNotifier::didReceiveAuthenticationChallenge):
      (WebCore::ResourceLoadNotifier::didCancelAuthenticationChallenge):
      (WebCore::ResourceLoadNotifier::willSendRequest):
      (WebCore::ResourceLoadNotifier::didFailToLoad):
      (WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest):
      (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
      (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
      (WebCore::ResourceLoadNotifier::dispatchDidReceiveData):
      (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
      (WebCore::ResourceLoadNotifier::dispatchDidFailLoading):
      * loader/ResourceLoader.cpp:
      (WebCore::ResourceLoader::ResourceLoader):
      (WebCore::ResourceLoader::start):
      (WebCore::ResourceLoader::frameLoader):
      (WebCore::ResourceLoader::willSendRequest):
      * loader/SubframeLoader.cpp:
      (WebCore::SubframeLoader::pluginIsLoadable):
      (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin):
      (WebCore::SubframeLoader::createJavaAppletWidget):
      (WebCore::SubframeLoader::loadOrRedirectSubframe):
      (WebCore::SubframeLoader::loadSubframe):
      (WebCore::SubframeLoader::allowPlugins):
      (WebCore::SubframeLoader::shouldUsePlugin):
      (WebCore::SubframeLoader::loadPlugin):
      * loader/appcache/ApplicationCacheGroup.cpp:
      (WebCore::ApplicationCacheGroup::selectCache):
      (WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL):
      (WebCore::ApplicationCacheGroup::update):
      (WebCore::ApplicationCacheGroup::createResourceHandle):
      (WebCore::ApplicationCacheGroup::didReceiveResponse):
      (WebCore::ApplicationCacheGroup::didFinishLoading):
      (WebCore::ApplicationCacheGroup::didFail):
      (WebCore::ApplicationCacheGroup::addEntry):
      (WebCore::CallCacheListenerTask::performTask):
      (WebCore::ApplicationCacheGroup::postListenerTask):
      * loader/appcache/DOMApplicationCache.cpp:
      (WebCore::DOMApplicationCache::applicationCacheHost):
      * loader/archive/cf/LegacyWebArchive.cpp:
      (WebCore::LegacyWebArchive::create):
      (WebCore::LegacyWebArchive::createFromSelection):
      * loader/cache/CachedResource.cpp:
      (WebCore::CachedResource::addAdditionalRequestHeaders):
      (WebCore::CachedResource::load):
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::requestImage):
      (WebCore::CachedResourceLoader::checkInsecureContent):
      (WebCore::CachedResourceLoader::canRequest):
      (WebCore::CachedResourceLoader::shouldContinueAfterNotifyingLoadedFromMemoryCache):
      (WebCore::CachedResourceLoader::requestResource):
      (WebCore::CachedResourceLoader::clientDefersImage):
      (WebCore::CachedResourceLoader::cachePolicy):
      (WebCore::CachedResourceLoader::loadDone):
      * loader/icon/IconController.cpp:
      (WebCore::IconController::commitToDatabase):
      (WebCore::IconController::startLoader):
      (WebCore::IconController::continueLoadWithDecision):
      * loader/icon/IconLoader.cpp:
      (WebCore::IconLoader::startLoading):
      (WebCore::IconLoader::notifyFinished):
      * page/Chrome.cpp:
      (WebCore::canRunModalIfDuringPageDismissal):
      * page/ContextMenuController.cpp:
      (WebCore::openNewWindow):
      (WebCore::ContextMenuController::contextMenuItemSelected):
      (WebCore::ContextMenuController::populate):
      (WebCore::ContextMenuController::checkOrEnableIfNeeded):
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::dispatchAllPendingBeforeUnloadEvents):
      (WebCore::DOMWindow::postMessageTimerFired):
      (WebCore::DOMWindow::close):
      (WebCore::DOMWindow::print):
      (WebCore::DOMWindow::stop):
      (WebCore::DOMWindow::setName):
      (WebCore::DOMWindow::opener):
      (WebCore::DOMWindow::dispatchLoadEvent):
      (WebCore::DOMWindow::setLocation):
      (WebCore::DOMWindow::createWindow):
      (WebCore::DOMWindow::open):
      * page/DOMWindowExtension.cpp:
      (WebCore::DOMWindowExtension::disconnectFrameForPageCache):
      (WebCore::DOMWindowExtension::reconnectFrameFromPageCache):
      (WebCore::DOMWindowExtension::willDestroyGlobalObjectInCachedFrame):
      (WebCore::DOMWindowExtension::willDestroyGlobalObjectInFrame):
      (WebCore::DOMWindowExtension::willDetachGlobalObjectFromFrame):
      * page/DragController.cpp:
      (WebCore::DragController::performDrag):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handleMousePressEvent):
      (WebCore::EventHandler::keyEvent):
      * page/Frame.cpp:
      (WebCore::Frame::~Frame):
      (WebCore::Frame::setView):
      (WebCore::Frame::injectUserScripts):
      (WebCore::Frame::willDetachPage):
      * page/Frame.h:
      (WebCore::Frame::loader):
      * page/FrameView.cpp:
      (WebCore::FrameView::mediaType):
      (WebCore::FrameView::setFixedVisibleContentRect):
      (WebCore::FrameView::shouldUseLoadTimeDeferredRepaintDelay):
      (WebCore::FrameView::performPostLayoutTasks):
      (WebCore::FrameView::autoSizeIfEnabled):
      (WebCore::FrameView::scrollTo):
      (WebCore::FrameView::shouldSuspendScrollAnimations):
      (WebCore::FrameView::qualifiesAsVisuallyNonEmpty):
      (WebCore::FrameView::wheelEvent):
      (WebCore::FrameView::firePaintRelatedMilestones):
      * page/History.cpp:
      (WebCore::History::stateInternal):
      (WebCore::History::stateObjectAdded):
      * page/Location.cpp:
      (WebCore::Location::setLocation):
      * page/Navigator.cpp:
      (WebCore::Navigator::userAgent):
      * page/Page.cpp:
      (WebCore::Page::goToItem):
      (WebCore::Page::refreshPlugins):
      (WebCore::Page::setDefersLoading):
      (WebCore::Page::setMemoryCacheClientCallsEnabled):
      (WebCore::Page::addRelevantRepaintedObject):
      * page/Performance.cpp:
      (WebCore::Performance::now):
      * page/PerformanceNavigation.cpp:
      (WebCore::PerformanceNavigation::type):
      (WebCore::PerformanceNavigation::redirectCount):
      * page/PerformanceResourceTiming.cpp:
      (WebCore::monotonicTimeToDocumentMilliseconds):
      * page/mac/PageMac.cpp:
      (WebCore::Page::addSchedulePair):
      (WebCore::Page::removeSchedulePair):
      * platform/ios/PasteboardIOS.mm:
      (WebCore::documentFragmentWithImageResource):
      (WebCore::documentFragmentWithRTF):
      (WebCore::Pasteboard::documentFragmentForPasteboardItemAtIndex):
      * platform/mac/HTMLConverter.mm:
      (-[WebHTMLConverter _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
      (-[WebHTMLConverter _loadFromDOMRange]):
      * platform/mac/PasteboardMac.mm:
      (WebCore::documentFragmentWithImageResource):
      (WebCore::documentFragmentWithRTF):
      (WebCore::fragmentFromWebArchive):
      * plugins/DOMMimeType.cpp:
      (WebCore::DOMMimeType::enabledPlugin):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::scrollTo):
      * svg/SVGAElement.cpp:
      (WebCore::SVGAElement::defaultEventHandler):
      * svg/graphics/SVGImage.cpp:
      (WebCore::SVGImage::~SVGImage):
      (WebCore::SVGImage::dataChanged):
      * testing/Internals.cpp:
      (WebCore::Internals::formControlStateOfPreviousHistoryItem):
      (WebCore::Internals::setFormControlStateOfPreviousHistoryItem):
      (WebCore::Internals::getReferencedFilePaths):
      (WebCore::Internals::forceReload):
      * xml/XSLTProcessorLibxslt.cpp:
      (WebCore::docLoaderFunc):
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      (WebCore::openFunc):
      (WebCore::XMLDocumentParser::startElementNs):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::load):
      (BlackBerry::WebKit::WebPagePrivate::loadString):
      (BlackBerry::WebKit::WebPagePrivate::stopCurrentLoad):
      (BlackBerry::WebKit::closeURLRecursively):
      (BlackBerry::WebKit::WebPage::dispatchBeforeUnloadEvent):
      (BlackBerry::WebKit::WebPagePrivate::shouldSendResizeEvent):
      (BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
      (BlackBerry::WebKit::WebPage::reload):
      (BlackBerry::WebKit::WebPage::reloadFromCache):
      (BlackBerry::WebKit::WebPage::textEncoding):
      (BlackBerry::WebKit::WebPage::forcedTextEncoding):
      (BlackBerry::WebKit::WebPage::setForcedTextEncoding):
      (BlackBerry::WebKit::WebPage::title):
      * WebCoreSupport/ChromeClientBlackBerry.cpp:
      (WebCore::ChromeClientBlackBerry::createWindow):
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidChangeLocationWithinPage):
      (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForResponse):
      (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
      (WebCore::FrameLoaderClientBlackBerry::delayPolicyCheckUntilFragmentExists):
      (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):
      (WebCore::FrameLoaderClientBlackBerry::createPlugin):
      (WebCore::FrameLoaderClientBlackBerry::receivedData):
      (WebCore::FrameLoaderClientBlackBerry::createDocumentLoader):
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidCommitLoad):
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
      (WebCore::FrameLoaderClientBlackBerry::dispatchWillSubmitForm):
      (WebCore::FrameLoaderClientBlackBerry::createFrame):
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidLayout):
      (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
      (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
      (WebCore::FrameLoaderClientBlackBerry::startDownload):
      (WebCore::FrameLoaderClientBlackBerry::canCachePage):
      (WebCore::FrameLoaderClientBlackBerry::didRestoreFromPageCache):
      * WebKitSupport/PagePopup.cpp:
      (BlackBerry::WebKit::PagePopup::initialize):
      
      Source/WebKit/efl:
      
      * WebCoreSupport/ChromeClientEfl.cpp:
      (kit):
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      (DumpRenderTreeSupportEfl::callShouldCloseOnWebView):
      (DumpRenderTreeSupportEfl::clearOpener):
      (DumpRenderTreeSupportEfl::frameChildren):
      (DumpRenderTreeSupportEfl::responseMimeType):
      (DumpRenderTreeSupportEfl::provisionalURL):
      * WebCoreSupport/FrameLoaderClientEfl.cpp:
      (WebCore::FrameLoaderClientEfl::callPolicyFunction):
      (WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNewWindowAction):
      (WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):
      (WebCore::FrameLoaderClientEfl::updateGlobalHistoryRedirectLinks):
      (WebCore::FrameLoaderClientEfl::updateGlobalHistory):
      * ewk/ewk_frame.cpp:
      (_ewk_frame_loader_efl_get):
      (_ewk_frame_smart_del):
      (_ewk_frame_contents_set_internal):
      (ewk_frame_stop):
      (ewk_frame_reload):
      (ewk_frame_reload_full):
      (ewk_frame_child_add):
      * ewk/ewk_view.cpp:
      (ewk_view_frame_focused_get):
      (ewk_view_setting_user_agent_set):
      (ewk_view_setting_encoding_custom_get):
      (ewk_view_setting_encoding_custom_set):
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
      (DumpRenderTreeSupportGtk::clearOpener):
      (DumpRenderTreeSupportGtk::shouldClose):
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      (WebKit::FrameLoaderClient::dispatchWillSubmitForm):
      (WebKit::FrameLoaderClient::committedLoad):
      (WebKit::FrameLoaderClient::dispatchDecidePolicyForResponse):
      (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
      (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
      (WebKit::FrameLoaderClient::createFrame):
      (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
      * webkit/webkitwebframe.cpp:
      (webkit_web_frame_finalize):
      (webkit_web_frame_load_uri):
      (webkit_web_frame_load_data):
      (webkit_web_frame_load_request):
      (webkit_web_frame_stop_loading):
      (webkit_web_frame_reload):
      (webkit_web_frame_get_data_source):
      (webkit_web_frame_get_provisional_data_source):
      (webkit_web_frame_get_response_mime_type):
      (webkit_web_frame_get_network_response):
      (WebKit::kit):
      * webkit/webkitwebpolicydecision.cpp:
      (webkit_web_policy_decision_use):
      (webkit_web_policy_decision_ignore):
      (webkit_web_policy_decision_download):
      * webkit/webkitwebview.cpp:
      (webkit_web_view_dispose):
      (webkit_web_view_reload):
      (webkit_web_view_reload_bypass_cache):
      (webkit_web_view_stop_loading):
      (webkit_web_view_can_show_mime_type):
      (webkit_web_view_set_custom_encoding):
      (webkit_web_view_get_custom_encoding):
      (webkit_web_view_get_subresources):
      
      Source/WebKit/mac:
      
      * Plugins/Hosted/HostedNetscapePluginStream.mm:
      (WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):
      * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
      (WebKit::NetscapePluginInstanceProxy::performRequest):
      (WebKit::NetscapePluginInstanceProxy::loadRequest):
      * Plugins/Hosted/WebHostedNetscapePluginView.mm:
      (-[WebHostedNetscapePluginView pluginView:receivedResponse:]):
      * Plugins/WebBaseNetscapePluginView.mm:
      (-[WebBaseNetscapePluginView requestWithURLCString:]):
      * Plugins/WebNetscapePluginStream.mm:
      (WebNetscapePluginStream::WebNetscapePluginStream):
      * Plugins/WebNetscapePluginView.mm:
      (-[WebNetscapePluginView loadStream]):
      (-[WebNetscapePluginView pluginView:receivedResponse:]):
      (-[WebNetscapePluginView loadPluginRequest:]):
      (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
      * Plugins/WebPluginController.mm:
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
      (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
      (WebFrameLoaderClient::dispatchWillSubmitForm):
      (WebFrameLoaderClient::updateGlobalHistory):
      (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
      (WebFrameLoaderClient::restoreViewState):
      (WebFrameLoaderClient::transitionToCommittedForNewPage):
      (WebFrameLoaderClient::createFrame):
      * WebCoreSupport/WebFrameNetworkingContext.mm:
      (WebFrameNetworkingContext::blockedError):
      * WebCoreSupport/WebPlatformStrategies.mm:
      (WebPlatformStrategies::getPluginInfo):
      * WebView/WebFrame.mm:
      (kit):
      (-[WebFrame _dataSource]):
      (-[WebFrame _canProvideDocumentSource]):
      (-[WebFrame _commitData:]):
      (-[WebFrame _firstLayoutDone]):
      (-[WebFrame _loadType]):
      (-[WebFrame _cacheabilityDictionary]):
      (-[WebFrame _clearOpener]):
      (-[WebFrame provisionalDataSource]):
      (-[WebFrame dataSource]):
      (-[WebFrame loadRequest:]):
      (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
      (-[WebFrame loadArchive:]):
      (-[WebFrame stopLoading]):
      (-[WebFrame reload]):
      (-[WebFrame reloadFromOrigin]):
      * WebView/WebHTMLRepresentation.mm:
      (-[WebHTMLRepresentation receivedData:withDataSource:]):
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
      * WebView/WebPDFView.mm:
      (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
      * WebView/WebRenderLayer.mm:
      (-[WebRenderLayer initWithWebFrame:]):
      * WebView/WebRenderNode.mm:
      (-[WebRenderNode _initWithCoreFrame:]):
      * WebView/WebView.mm:
      (-[WebView _close]):
      (-[WebView _loadBackForwardListFromOtherView:]):
      (-[WebView _cachedResponseForURL:]):
      (-[WebView setCustomTextEncodingName:]):
      (-[WebView shouldClose]):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::closeWindowSoon):
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::shouldClose):
      (DumpRenderTreeSupportQt::responseMimeType):
      (DumpRenderTreeSupportQt::clearOpener):
      (DumpRenderTreeSupportQt::thirdPartyCookiePolicyAllows):
      (DumpRenderTreeSupportQt::setAlternateHtml):
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::callPolicyFunction):
      (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad):
      (WebCore::FrameLoaderClientQt::updateGlobalHistory):
      (WebCore::FrameLoaderClientQt::updateGlobalHistoryRedirectLinks):
      (WebCore::FrameLoaderClientQt::callErrorPageExtension):
      (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNewWindowAction):
      (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
      (WebCore::FrameLoaderClientQt::startDownload):
      (WebCore::FrameLoaderClientQt::createFrame):
      (WebCore::FrameLoaderClientQt::objectContentType):
      * WebCoreSupport/QWebFrameAdapter.cpp:
      (QWebFrameAdapter::load):
      (QWebFrameAdapter::setContent):
      (QWebFrameAdapter::setHtml):
      (QWebFrameAdapter::kit):
      (QWebFrameAdapter::title):
      (QWebFrameAdapter::clearCoreFrame):
      * WebCoreSupport/QWebPageAdapter.cpp:
      (frameLoadRequest):
      (openNewWindow):
      (QWebPageAdapter::triggerAction):
      (QWebPageAdapter::currentFrame):
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebContextMenuClient.cpp:
      (WebContextMenuClient::searchWithGoogle):
      * WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebFrameLoaderClient::updateGlobalHistory):
      (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
      (WebFrameLoaderClient::savePlatformDataToCachedFrame):
      (WebFrameLoaderClient::createFrame):
      (WebFrameLoaderClient::dispatchDidFailToStartPlugin):
      * WebCoreSupport/WebFrameNetworkingContext.cpp:
      (WebFrameNetworkingContext::blockedError):
      (WebFrameNetworkingContext::referrer):
      * WebElementPropertyBag.cpp:
      (WebElementPropertyBag::Read):
      * WebFrame.cpp:
      (kit):
      (WebFrame::reloadFromOrigin):
      (WebFrame::loadRequest):
      (WebFrame::loadData):
      (WebFrame::dataSource):
      (WebFrame::provisionalDataSource):
      (WebFrame::stopLoading):
      (WebFrame::reload):
      (WebFrame::firstLayoutDone):
      (WebFrame::loadType):
      (WebFrame::clearOpener):
      (WebFrame::dispatchWillSubmitForm):
      (WebFrame::receivedPolicyDecision):
      (WebFrame::dispatchDecidePolicyForResponse):
      (WebFrame::dispatchDecidePolicyForNewWindowAction):
      (WebFrame::dispatchDecidePolicyForNavigationAction):
      (WebFrame::createJavaAppletWidget):
      * WebFramePolicyListener.cpp:
      (WebFramePolicyListener::receivedPolicyDecision):
      * WebView.cpp:
      (WebView::close):
      (WebView::canShowMIMEType):
      (WebView::setCustomTextEncodingName):
      (WebView::loadBackForwardListFromOtherView):
      (WebView::shouldClose):
      
      Source/WebKit/wince:
      
      * WebCoreSupport/FrameLoaderClientWinCE.cpp:
      (WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForResponse):
      (WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForNewWindowAction):
      (WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForNavigationAction):
      (WebKit::FrameLoaderClientWinCE::dispatchWillSubmitForm):
      * WebCoreSupport/FrameNetworkingContextWinCE.cpp:
      (WebKit::FrameNetworkingContextWinCE::referrer):
      * WebView.cpp:
      (WebView::createFrame):
      (WebView::load):
      (WebView::reload):
      (WebView::stop):
      
      Source/WebKit2:
      
      * Shared/WebRenderLayer.cpp:
      (WebKit::WebRenderLayer::create):
      * Shared/WebRenderObject.cpp:
      (WebKit::WebRenderObject::create):
      * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
      (WebKit::GeolocationPermissionRequestManager::startRequestForGeolocation):
      * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
      (WKBundleFrameGetFrameLoadState):
      (WKBundleFrameClearOpener):
      (WKBundleFrameCallShouldCloseOnWebView):
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      (WebKit::InjectedBundleNodeHandle::documentFrame):
      (WebKit::InjectedBundleNodeHandle::htmlFrameElementContentFrame):
      (WebKit::InjectedBundleNodeHandle::htmlIFrameElementContentFrame):
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
      * WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
      (WebKit::InjectedBundleDOMWindowExtension::frame):
      * WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
      (WebKit::InjectedBundleHitTestResult::frame):
      (WebKit::InjectedBundleHitTestResult::targetFrame):
      * WebProcess/Plugins/PDF/PDFPlugin.mm:
      (WebKit::PDFPlugin::clickedLink):
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::webPage):
      (WebKit::PluginView::didFailToInitializePlugin):
      (WebKit::PluginView::performFrameLoadURLRequest):
      (WebKit::PluginView::userAgent):
      (WebKit::PluginView::loadURL):
      (WebKit::PluginView::cancelManualStreamLoad):
      (WebKit::PluginView::proxiesForURL):
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::focusedElementChanged):
      (WebKit::WebChromeClient::focusedFrameChanged):
      (WebKit::WebChromeClient::runBeforeUnloadConfirmPanel):
      (WebKit::WebChromeClient::closeWindowSoon):
      (WebKit::WebChromeClient::runJavaScriptAlert):
      (WebKit::WebChromeClient::runJavaScriptConfirm):
      (WebKit::WebChromeClient::runJavaScriptPrompt):
      (WebKit::WebChromeClient::unavailablePluginButtonClicked):
      (WebKit::WebChromeClient::print):
      (WebKit::WebChromeClient::exceededDatabaseQuota):
      (WebKit::WebChromeClient::runOpenPanel):
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      (WebKit::WebContextMenuClient::searchWithGoogle):
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      (WebKit::WebEditorClient::textFieldDidBeginEditing):
      (WebKit::WebEditorClient::textFieldDidEndEditing):
      (WebKit::WebEditorClient::textDidChangeInTextField):
      (WebKit::WebEditorClient::textDidChangeInTextArea):
      (WebKit::WebEditorClient::doTextFieldCommandFromEvent):
      (WebKit::WebEditorClient::textWillBeDeletedInTextField):
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
      (WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
      (WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
      (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
      (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
      (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
      (WebKit::WebFrameLoaderClient::dispatchWillSendSubmitEvent):
      (WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
      (WebKit::WebFrameLoaderClient::updateGlobalHistory):
      (WebKit::WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
      (WebKit::WebFrameLoaderClient::restoreViewState):
      (WebKit::WebFrameLoaderClient::createFrame):
      (WebKit::WebFrameLoaderClient::createJavaAppletWidget):
      (WebKit::WebFrameLoaderClient::objectContentType):
      * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
      (WebKit::WebPlatformStrategies::getPluginInfo):
      * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
      (WebKit::WebFrameNetworkingContext::blockedError):
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::didReceivePolicyDecision):
      (WebKit::WebFrame::startDownload):
      (WebKit::WebFrame::source):
      (WebKit::WebFrame::contentsAsString):
      (WebKit::WebFrame::url):
      (WebKit::WebFrame::parentFrame):
      (WebKit::WebFrame::childFrames):
      (WebKit::WebFrame::stopLoading):
      (WebKit::WebFrame::frameForContext):
      (WebKit::WebFrame::provisionalURL):
      (WebKit::WebFrame::suggestedFilenameForResourceWithURL):
      (WebKit::WebFrame::mimeTypeForResourceWithURL):
      (WebKit::WebFrameFilter::shouldIncludeSubframe):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::createPlugin):
      (WebKit::WebPage::close):
      (WebKit::WebPage::tryClose):
      (WebKit::WebPage::loadURLRequest):
      (WebKit::WebPage::loadDataImpl):
      (WebKit::WebPage::linkClicked):
      (WebKit::WebPage::stopLoadingFrame):
      (WebKit::WebPage::stopLoading):
      (WebKit::WebPage::reload):
      (WebKit::WebPage::tryRestoreScrollPosition):
      (WebKit::WebPage::getMainResourceDataOfFrame):
      (WebKit::resourceDataForFrame):
      (WebKit::shouldReuseCommittedSandboxExtension):
      (WebKit::WebPage::SandboxExtensionTracker::didStartProvisionalLoad):
      (WebKit::WebPage::hasLocalDataForURL):
      (WebKit::WebPage::setCustomTextEncodingName):
      (WebKit::WebPage::canPluginHandleResponse):
      (WebKit::WebPage::canShowMIMEType):
      (WebKit::WebPage::didCommitLoad):
      * WebProcess/WebPage/mac/WebPageMac.mm:
      (WebKit::WebPage::platformHasLocalDataForURL):
      (WebKit::cachedResponseForURL):
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::downloadRequest):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154142 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df550b96
  13. 11 Aug, 2013 1 commit
  14. 25 Jul, 2013 1 commit
    • akling@apple.com's avatar
      ChromeClient::focusedNodeChanged() should be focusedElementChanged(). · 96b365f0
      akling@apple.com authored
      <http://webkit.org/b/119110>
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore:
      
      Because only Elements can be focused.
      
      * dom/Document.cpp:
      (WebCore::Document::setFocusedElement):
      * loader/EmptyClients.h:
      (WebCore::EmptyChromeClient::focusedElementChanged):
      * page/Chrome.cpp:
      (WebCore::Chrome::focusedElementChanged):
      * page/Chrome.h:
      * page/ChromeClient.h:
      
      Source/WebKit/blackberry:
      
      * WebCoreSupport/ChromeClientBlackBerry.cpp:
      (WebCore::ChromeClientBlackBerry::focusedElementChanged):
      * WebCoreSupport/ChromeClientBlackBerry.h:
      
      Source/WebKit/efl:
      
      * WebCoreSupport/ChromeClientEfl.cpp:
      (WebCore::ChromeClientEfl::focusedElementChanged):
      * WebCoreSupport/ChromeClientEfl.h:
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::focusedElementChanged):
      * WebCoreSupport/ChromeClientGtk.h:
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebChromeClient.h:
      * WebCoreSupport/WebChromeClient.mm:
      (WebChromeClient::focusedElementChanged):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::focusedElementChanged):
      * WebCoreSupport/ChromeClientQt.h:
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebChromeClient.cpp:
      (WebChromeClient::focusedElementChanged):
      * WebCoreSupport/WebChromeClient.h:
      
      Source/WebKit/wince:
      
      * WebCoreSupport/ChromeClientWinCE.cpp:
      (WebKit::ChromeClientWinCE::focusedElementChanged):
      * WebCoreSupport/ChromeClientWinCE.h:
      
      Source/WebKit2:
      
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::focusedElementChanged):
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153356 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96b365f0
  15. 28 Jun, 2013 1 commit
    • kangil.han@samsung.com's avatar
      Adopt is/toHTMLInputElement for code cleanup · c559372b
      kangil.han@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118130
      
      Reviewed by Antti Koivisto.
      
      To enhance readability, this patch adopts is/toHTMLInputElement.
      This also helps out to reduce duplicated use of static_cast.
      
      Source/WebCore:
      
      * accessibility/AccessibilityMediaControls.cpp:
      (WebCore::AccessibilityMediaTimeline::valueDescription):
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::determineAccessibilityRole):
      (WebCore::AccessibilityNodeObject::isNativeTextControl):
      (WebCore::AccessibilityNodeObject::isNativeImage):
      (WebCore::AccessibilityNodeObject::isInputImage):
      (WebCore::AccessibilityNodeObject::isReadOnly):
      (WebCore::AccessibilityNodeObject::valueForRange):
      (WebCore::AccessibilityNodeObject::maxValueForRange):
      (WebCore::AccessibilityNodeObject::minValueForRange):
      (WebCore::AccessibilityNodeObject::actionElement):
      (WebCore::AccessibilityNodeObject::titleElementText):
      (WebCore::AccessibilityNodeObject::visibleText):
      (WebCore::AccessibilityNodeObject::title):
      (WebCore::AccessibilityNodeObject::text):
      (WebCore::AccessibilityNodeObject::colorValue):
      (WebCore::accessibleNameForNode):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::isFileUploadButton):
      (WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
      (WebCore::AccessibilityRenderObject::url):
      (WebCore::AccessibilityRenderObject::setValue):
      (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
      (WebCore::AccessibilityRenderObject::addTextFieldChildren):
      * accessibility/AccessibilitySlider.cpp:
      (WebCore::AccessibilitySlider::element):
      * accessibility/ios/AccessibilityObjectIOS.mm:
      (WebCore::AccessibilityObject::accessibilityPasswordFieldLength):
      * bindings/js/JSHTMLInputElementCustom.cpp:
      (WebCore::JSHTMLInputElement::selectionStart):
      (WebCore::JSHTMLInputElement::setSelectionStart):
      (WebCore::JSHTMLInputElement::selectionEnd):
      (WebCore::JSHTMLInputElement::setSelectionEnd):
      (WebCore::JSHTMLInputElement::selectionDirection):
      (WebCore::JSHTMLInputElement::setSelectionDirection):
      (WebCore::JSHTMLInputElement::setSelectionRange):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::adjustRenderStyle):
      * editing/FrameSelection.cpp:
      (WebCore::FrameSelection::isInPasswordField):
      * editing/ReplaceSelectionCommand.cpp:
      (WebCore::ReplaceSelectionCommand::shouldPerformSmartReplace):
      * html/HTMLFormControlElement.cpp:
      (WebCore::shouldAutofocus):
      * html/HTMLFormElement.cpp:
      (WebCore::HTMLFormElement::getTextFieldValues):
      * html/HTMLInputElement.h:
      (WebCore::isHTMLInputElement):
      (WebCore::toHTMLInputElement):
      * html/RadioInputType.cpp:
      (WebCore::RadioInputType::handleKeydownEvent):
      (WebCore::RadioInputType::isKeyboardFocusable):
      * html/shadow/MediaControlElementTypes.cpp:
      (WebCore::mediaControlElementType):
      * html/shadow/TextControlInnerElements.cpp:
      (WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
      (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
      (WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents):
      (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
      (WebCore::InputFieldSpeechButtonElement::willRespondToMouseClickEvents):
      (WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
      (WebCore::InputFieldSpeechButtonElement::startSpeechInput):
      * loader/FormSubmission.cpp:
      (WebCore::FormSubmission::create):
      * page/Chrome.cpp:
      (WebCore::Chrome::setToolTip):
      * page/EventHandler.cpp:
      (WebCore::isSubmitImage):
      (WebCore::EventHandler::handleMousePressEvent):
      * page/FocusController.cpp:
      (WebCore::clearSelectionIfNeeded):
      * platform/gtk/PasteboardGtk.cpp:
      (WebCore::getURLForImageNode):
      * platform/qt/RenderThemeQt.cpp:
      (WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
      * platform/qt/RenderThemeQtMobile.cpp:
      (WebCore::RenderThemeQtMobile::paintSliderTrack):
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestResult::altDisplayString):
      (WebCore::HitTestResult::absoluteImageURL):
      (WebCore::HitTestResult::isContentEditable):
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::hasLineIfEmpty):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::sizesLogicalWidthToFitContent):
      * rendering/RenderButton.cpp:
      (WebCore::RenderButton::updateFromElement):
      (WebCore::RenderButton::canHaveGeneratedChildren):
      * rendering/RenderDetailsMarker.cpp:
      (WebCore::RenderDetailsMarker::isOpen):
      * rendering/RenderFileUploadControl.cpp:
      (WebCore::RenderFileUploadControl::updateFromElement):
      (WebCore::RenderFileUploadControl::maxFilenameWidth):
      (WebCore::RenderFileUploadControl::paintObject):
      (WebCore::RenderFileUploadControl::uploadButton):
      (WebCore::RenderFileUploadControl::fileTextValue):
      * rendering/RenderImage.cpp:
      (WebCore::RenderImage::updateAltText):
      * testing/Internals.cpp:
      (WebCore::Internals::selectColorInColorChooser):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::webContext):
      (BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
      * WebCoreSupport/CredentialTransformData.cpp:
      (WebCore::CredentialTransformData::findPasswordFormFields):
      * WebCoreSupport/EditorClientBlackBerry.cpp:
      (WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
      * WebKitSupport/DOMSupport.cpp:
      (BlackBerry::WebKit::DOMSupport::isPasswordElement):
      (BlackBerry::WebKit::DOMSupport::inputElementText):
      (BlackBerry::WebKit::DOMSupport::isDateTimeInputField):
      (BlackBerry::WebKit::DOMSupport::isColorInputField):
      (BlackBerry::WebKit::DOMSupport::elementIdOrNameIndicatesNoAutocomplete):
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::elementType):
      (BlackBerry::WebKit::InputHandler::setInputValue):
      (BlackBerry::WebKit::InputHandler::extractedTextRequest):
      (BlackBerry::WebKit::InputHandler::showTextInputTypeSuggestionBox):
      
      Source/WebKit/efl:
      
      * ewk/ewk_view.cpp:
      (ewk_view_input_method_state_set):
      
      Source/WebKit/mac:
      
      * DOM/WebDOMOperations.mm:
      (-[DOMHTMLInputElement _setAutofilled:]):
      * WebCoreSupport/WebChromeClient.mm:
      (WebChromeClient::focusedNodeChanged):
      * WebCoreSupport/WebEditorClient.mm:
      (WebEditorClient::textFieldDidBeginEditing):
      (WebEditorClient::textFieldDidEndEditing):
      (WebEditorClient::textDidChangeInTextField):
      (WebEditorClient::doTextFieldCommandFromEvent):
      (WebEditorClient::textWillBeDeletedInTextField):
      * WebView/WebHTMLRepresentation.mm:
      (inputElementFromDOMElement):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/EditorClientQt.cpp:
      (WebCore::EditorClientQt::setInputMethodState):
      * WebCoreSupport/QWebPageAdapter.cpp:
      (QWebPageAdapter::inputMethodQuery):
      
      Source/WebKit/win:
      
      * DOMCoreClasses.cpp:
      (DOMElement::createInstance):
      * DOMHTMLClasses.cpp:
      (DOMHTMLInputElement::form):
      (DOMHTMLInputElement::disabled):
      (DOMHTMLInputElement::readOnly):
      (DOMHTMLInputElement::setType):
      (DOMHTMLInputElement::value):
      (DOMHTMLInputElement::setValue):
      (DOMHTMLInputElement::setValueForUser):
      (DOMHTMLInputElement::select):
      (DOMHTMLInputElement::setSelectionStart):
      (DOMHTMLInputElement::selectionStart):
      (DOMHTMLInputElement::setSelectionEnd):
      (DOMHTMLInputElement::selectionEnd):
      (DOMHTMLInputElement::isTextField):
      (DOMHTMLInputElement::rectOnScreen):
      (DOMHTMLInputElement::replaceCharactersInRange):
      (DOMHTMLInputElement::selectedRange):
      (DOMHTMLInputElement::setAutofilled):
      (DOMHTMLInputElement::isAutofilled):
      (DOMHTMLInputElement::isUserEdited):
      * WebFrame.cpp:
      (inputElementFromDOMElement):
      
      Source/WebKit2:
      
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      (WebKit::InjectedBundleNodeHandle::setHTMLInputElementValueForUser):
      (WebKit::InjectedBundleNodeHandle::isHTMLInputElementAutofilled):
      (WebKit::InjectedBundleNodeHandle::setHTMLInputElementAutofilled):
      (WebKit::InjectedBundleNodeHandle::htmlInputElementLastChangeWasUserEdit):
      * WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
      (WebKit::PDFPluginTextAnnotation::createAnnotationElement):
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::focusedNodeChanged):
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      (WebKit::WebEditorClient::textFieldDidBeginEditing):
      (WebKit::WebEditorClient::textFieldDidEndEditing):
      (WebKit::WebEditorClient::textDidChangeInTextField):
      (WebKit::WebEditorClient::doTextFieldCommandFromEvent):
      (WebKit::WebEditorClient::textWillBeDeletedInTextField):
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::containsAnyFormControls):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::editorState):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152149 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c559372b
  16. 24 Jun, 2013 1 commit
    • simon.fraser@apple.com's avatar
      Move displayID stuff from Widget to Chrome · 711a579a
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=117944
      
      Reviewed by Anders Carlsson.
      
      In r151877 I polluted Widget with displayID-related stuff. This would
      be better on HostWindow, so move it there. This is a net code reduction,
      and eliminates PlatformScreenMac.h, and the NSScreen category.
      
      Source/WebCore:
      
      * WebCore.exp.in: Remove some functions from the exports list.
      * WebCore.xcodeproj/project.pbxproj: PlatformScreenMac.h is gone!
      * dom/Document.cpp:
      (WebCore::Document::requestAnimationFrame): Get the displayID from page->chrome()
      * page/Chrome.cpp:
      (WebCore::Chrome::Chrome): Initialize m_displayID.
      (WebCore::Chrome::displayID):
      (WebCore::Chrome::windowScreenDidChange): Code moved from Page; save the
      displayID, and tell all subframes that the displayID changed.
      * page/Chrome.h: Add displayID-related functions.
      * page/FrameView.cpp: Removed windowDisplayID().
      * page/FrameView.h: Ditto.
      * page/Page.cpp: Removed code.
      (WebCore::Page::Page):
      * page/Page.h:
      * platform/HostWindow.h: Added virtual displayID-related functions.
      * platform/Widget.cpp: Removed code.
      * platform/Widget.h: Ditto.
      * platform/mac/PlatformScreenMac.h: Removed.
      * platform/mac/PlatformScreenMac.mm: Removed the NSScreen category.
      (WebCore::displayIDFromScreen):
      (WebCore::screenForDisplayID):
      (WebCore::displayFromWidget):
      (WebCore::screenForWidget):
      * platform/mac/WidgetMac.mm: Removed windowDisplayID().
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::notifyFlushBeforeDisplayRefresh): Get
      the displayID via chrome().
      
      Source/WebKit/mac:
      
      * WebView/WebView.mm:
      (-[WebView doWindowDidChangeScreen]): Go via chrome().
      
      Source/WebKit2:
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::windowScreenDidChange): Go via chrome().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151926 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      711a579a
  17. 17 May, 2013 1 commit
    • akling@apple.com's avatar
      Page::chrome() should return a reference. · bd774814
      akling@apple.com authored
      <http://webkit.org/b/116185>
      
      Source/WebCore:
      
      Reviewed by Anders Carlsson.
      
      A Page's chrome() can never be null. Change Page::chrome() to return a reference to reflect this.
      Also, make Page::m_chrome a const member variable so nobody will accidentally set it to null.
      
      Source/WebKit/blackberry:
      
      Reviewed by Anders Carlsson.
      
      Source/WebKit/efl:
      
      Reviewed by Anders Carlsson.
      
      Source/WebKit/gtk:
      
      Reviewed by Anders Carlsson.
      
      Source/WebKit/mac:
      
      Reviewed by Anders Carlsson.
      
      Source/WebKit/qt:
      
      Reviewed by Anders Carlsson.
      
      Source/WebKit/win:
      
      Reviewed by Anders Carlsson.
      
      Source/WebKit2:
      
      Reviewed by Anders Carlsson.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150214 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd774814
  18. 12 May, 2013 1 commit
    • akling@apple.com's avatar
      Unload event listeners should prevent Safari from insta-killing the web process on last tab close. · d40ce33a
      akling@apple.com authored
      <http://webkit.org/b/115988>
      <rdar://problem/13870943>
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore:
      
      Add two methods to Chrome (and ChromeClient):
      
          - enableSuddenTermination()
          - disableSuddenTermination()
      
      ..and call these from DOMWindow instead of the free global functions.
      
      For WebKit1, it just calls the NSProcessInfo methods to keep behavior the same.
      For WebKit2, the new methods plumb through the information to the UI process.
      
      Also updated the DOMWindow logic to think in terms of per-DOMWindow sudden termination counters
      instead of a process-global one, since that gets confusing in a WK2 world.
      When a DOMWindow transitions between having/not having unload/beforeunload event listeners,
      we send a notification to the Chrome.
      
      * WebCore.exp.in:
      * WebCore.xcodeproj/project.pbxproj:
      * page/Chrome.h:
      (WebCore::Chrome::enableSuddenTermination):
      (WebCore::Chrome::disableSuddenTermination):
      * page/ChromeClient.h:
      (WebCore::ChromeClient::enableSuddenTermination):
      (WebCore::ChromeClient::disableSuddenTermination):
      * page/DOMWindow.cpp:
      (WebCore::addUnloadEventListener):
      (WebCore::removeUnloadEventListener):
      (WebCore::removeAllUnloadEventListeners):
      (WebCore::addBeforeUnloadEventListener):
      (WebCore::removeBeforeUnloadEventListener):
      (WebCore::removeAllBeforeUnloadEventListeners):
      (WebCore::DOMWindow::dispatchAllPendingBeforeUnloadEvents):
      (WebCore::DOMWindow::dispatchAllPendingUnloadEvents):
      (WebCore::DOMWindow::enableSuddenTermination):
      (WebCore::DOMWindow::disableSuddenTermination):
      * page/DOMWindow.h:
      (DOMWindow):
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebChromeClient.h:
      * WebCoreSupport/WebChromeClient.mm:
      (WebChromeClient::enableSuddenTermination):
      (WebChromeClient::disableSuddenTermination):
      
      Source/WebKit2:
      
      Let WebCore control the UI process's suppression of the sudden termination mechanism.
      This is implemented by having WebChromeClient push Enable/DisableSuddenTermination messages
      over to the UI process where the appropriate NSProcessInfo calls are made.
      
      We also use this information when deciding whether to insta-kill a web process when its last
      page is closed. This mechanism is re-usable in WebCore to protect against sudden termination
      by the UI process.
      
      * UIProcess/WebProcessProxy.cpp:
      (WebKit::WebProcessProxy::WebProcessProxy):
      (WebKit::WebProcessProxy::removeWebPage):
      (WebKit::WebProcessProxy::enableSuddenTermination):
      (WebKit::WebProcessProxy::disableSuddenTermination):
      * UIProcess/WebProcessProxy.h:
      (WebProcessProxy):
      * UIProcess/WebProcessProxy.messages.in:
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::enableSuddenTermination):
      (WebKit::WebChromeClient::disableSuddenTermination):
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      (WebChromeClient):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149971 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d40ce33a
  19. 17 Apr, 2013 1 commit
    • andersca@apple.com's avatar
      Clone storage namespaces for window.open · 55fda687
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114703
      
      Reviewed by Sam Weinig.
      
      Source/WebCore:
      
      Pass the new page to StorageNamespace::copy.
      
      * page/Chrome.cpp:
      (WebCore::Chrome::createWindow):
      * storage/StorageNamespace.h:
      (StorageNamespace):
      * storage/StorageNamespaceImpl.cpp:
      (WebCore::StorageNamespaceImpl::copy):
      * storage/StorageNamespaceImpl.h:
      (WebCore):
      (StorageNamespaceImpl):
      
      Source/WebKit2:
      
      * UIProcess/Storage/StorageManager.cpp:
      (WebKit::StorageManager::StorageArea::clone):
      New helper function for cloning a storage area.
      
      (WebKit::StorageManager::StorageArea::setItem):
      Correctly handle the copy-on-write feature of StorageMap if it has multiple storage areas pointing to it.
      
      (WebKit::StorageManager::StorageArea::removeItem):
      Ditto.
      
      (WebKit::StorageManager::SessionStorageNamespace::cloneTo):
      Add cloned storage areas.
      
      * WebProcess/Storage/StorageNamespaceImpl.cpp:
      (WebKit::StorageNamespaceImpl::copy):
      Create a new session storage namespace for the new page.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148585 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55fda687
  20. 01 Feb, 2013 1 commit
    • commit-queue@webkit.org's avatar
      Web Inspector: Add support for handling modal dialogs · 417bc8fc
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107883
      
      Patch by Ken Kania <kkania@chromium.org> on 2013-02-01
      Reviewed by Pavel Feldman.
      
      Introduce support for being notified when a JavaScript modal dialog
      is opening and closing, as well as a new command for accepting or
      dismissing the dialog.
      
      Source/WebCore:
      
      Test: inspector-protocol/page/willRunJavaScriptDialog.html
      
      * inspector/Inspector.json:
      * inspector/InspectorClient.h:
      (WebCore::InspectorClient::handleJavaScriptDialog):
      (InspectorClient):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore):
      (WebCore::InspectorInstrumentation::willRunJavaScriptDialogImpl):
      (WebCore::InspectorInstrumentation::didRunJavaScriptDialogImpl):
      * inspector/InspectorInstrumentation.h:
      (InspectorInstrumentation):
      (WebCore::InspectorInstrumentation::willRunJavaScriptDialog):
      (WebCore):
      (WebCore::InspectorInstrumentation::didRunJavaScriptDialog):
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::willRunJavaScriptDialog):
      (WebCore):
      (WebCore::InspectorPageAgent::didRunJavaScriptDialog):
      (WebCore::InspectorPageAgent::handleJavaScriptDialog):
      * inspector/InspectorPageAgent.h:
      * inspector/front-end/ResourceTreeModel.js:
      (WebInspector.PageDispatcher.prototype.frameStartedLoading):
      (WebInspector.PageDispatcher.prototype.frameStoppedLoading):
      (WebInspector.PageDispatcher.prototype.frameScheduledNavigation):
      (WebInspector.PageDispatcher.prototype.frameClearedScheduledNavigation):
      (WebInspector.PageDispatcher.prototype.javascriptDialogOpening):
      (WebInspector.PageDispatcher.prototype.javascriptDialogClosed):
      * page/Chrome.cpp:
      (WebCore::Chrome::runBeforeUnloadConfirmPanel):
      (WebCore::Chrome::runJavaScriptAlert):
      (WebCore::Chrome::runJavaScriptConfirm):
      (WebCore::Chrome::runJavaScriptPrompt):
      
      Source/WebKit/chromium:
      
      * public/WebDevToolsAgent.h:
      * src/InspectorClientImpl.cpp:
      (WebKit::InspectorClientImpl::handleJavaScriptDialog):
      (WebKit):
      * src/InspectorClientImpl.h:
      (InspectorClientImpl):
      * src/WebDevToolsAgentImpl.cpp:
      (BrowserDataHintStringValues):
      (WebKit::WebDevToolsAgentImpl::captureScreenshot):
      (WebKit::WebDevToolsAgentImpl::handleJavaScriptDialog):
      (WebKit):
      (WebKit::browserHintToString):
      (WebKit::browserHintFromString):
      (WebKit::WebDevToolsAgent::patchWithBrowserData):
      * src/WebDevToolsAgentImpl.h:
      (WebDevToolsAgentImpl):
      
      LayoutTests:
      
      * inspector-protocol/page/javascriptDialogEvents-expected.txt: Added.
      * inspector-protocol/page/javascriptDialogEvents.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141555 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      417bc8fc
  21. 16 Nov, 2012 1 commit
    • tkent@chromium.org's avatar
      A Spin button should release mouse event capturing when a modal dialog opens · 05417697
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98007
      
      Reviewed by Hajime Morita.
      
      Description of bug:
      If the mouse left button is pressed on a spin button in
      input[type=number] and a 'change' event handler opens a modal dialog
      such as alert(), a repeating timer doesn't stop and mouse event
      capturing isn't released even though the mouse pointer isn't on the spin
      button.
      A user will see repeating alert dialogs for a document like <input
      type=number value=1 onchange="if (this.value==1) {alert(...);
      this.value=1;}"> by clicking the up button.
      
      How to solve:
      We should notify modal dialog or popup open to a spin button.
      This patch introduce PopupOpeningObserver. Chrome notifies it when
      any dialogs / popups is opening. SpinButtonElement implements
      PopupOpeningObserver and registers/unregisters itself to/from
      Chrome.
      
      No new tests. This is a behavior change, but it's very hard to make an
      automated test for timer-related behavior.
      
      * page/PopupOpeningObserver.h: Added.
      * GNUmakefile.list.am: Add PopupOpeningObserver.h
      * Target.pri: Ditto.
      * WebCore.gypi: Ditto.
      * WebCore.vcproj/WebCore.vcproj: Ditto.
      * WebCore.xcodeproj/project.pbxproj: Ditto.
      
      * page/Chrome.cpp:
      (WebCore::Chrome::runJavaScriptAlert): Calls notifyPopupOpeningObservers.
      (WebCore::Chrome::runJavaScriptConfirm): Ditto.
      (WebCore::Chrome::runJavaScriptPrompt): Ditto.
      (WebCore::Chrome::createColorChooser): Ditto.
      (WebCore::Chrome::openDateTimeChooser):
      Added. Calls notifyPopupOpeningObservers before calling
      ChromeClient::openDateTimeChooser.
      (WebCore::Chrome::runOpenPanel): Calls notifyPopupOpeningObservers.
      (WebCore::Chrome::createPopupMenu): Ditto.
      (WebCore::Chrome::createSearchPopupMenu): Ditto.
      (WebCore::Chrome::registerPopupOpeningObserver): Added.
      (WebCore::Chrome::unregisterPopupOpeningObserver): Added.
      (WebCore::Chrome::notifyPopupOpeningObservers): Added.
      * page/Chrome.h: Added new members and required class/struct declarations.
      
      * html/BaseChooserOnlyDateAndTimeInputType.cpp:
      (WebCore::BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent):
      Use Chrome::openDateTimeChooser instead of ChromeClient::openDateTimeChooser.
      * html/shadow/PickerIndicatorElement.cpp:
      (WebCore::PickerIndicatorElement::openPopup): Ditto.
      
      * html/shadow/SpinButtonElement.h:
      (SpinButtonElement): Declare willOpenPopup.
      * html/shadow/SpinButtonElement.cpp:
      (WebCore::SpinButtonElement::defaultEventHandler):
      Change the order of timer start and changing the value so that we
      can cancel the timer correctly.
      Calls Chrome::registerPopupOpeningObserver on starting mouse capturing.
      (WebCore::SpinButtonElement::willOpenPopup):
      Release mouse event capturing before opening a modal dialog.
      (WebCore::SpinButtonElement::releaseCapture):
      Calls Chrome::unregisterPopupOpeningObserver.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05417697
  22. 17 Oct, 2012 1 commit
    • jianli@chromium.org's avatar
      Rename feature define ENABLE_WIDGET_REGION to ENABLE_DRAGGBALE_REGION · 9acde016
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98975
      
      Reviewed by Adam Barth.
      
      Source/JavaScriptCore:
      
      Renaming is needed to better match with the draggable region code.
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebCore:
      
      Renaming is needed to better match with the draggable region code.
      
      No new tests (OOPS!).
      
      * Configurations/FeatureDefines.xcconfig:
      * DerivedSources.make:
      * WebCore.exp.in:
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore):
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseValue):
      * css/CSSProperty.cpp:
      (WebCore::CSSProperty::isInheritedProperty):
      * css/CSSPropertyNames.in:
      * css/CSSValueKeywords.in:
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::applyProperty):
      * dom/Document.cpp:
      (WebCore::Document::Document):
      (WebCore):
      (WebCore::Document::reportMemoryUsage):
      * dom/Document.h:
      (WebCore):
      (Document):
      * page/Chrome.cpp:
      (WebCore):
      * page/ChromeClient.h:
      (ChromeClient):
      * page/FrameView.cpp:
      (WebCore::FrameView::layout):
      (WebCore):
      (WebCore::FrameView::paintContents):
      * page/FrameView.h:
      (FrameView):
      * rendering/RenderInline.cpp:
      (WebCore):
      (WebCore::RenderInline::addAnnotatedRegions):
      * rendering/RenderInline.h:
      (RenderInline):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::scrollTo):
      (WebCore::RenderLayer::setHasHorizontalScrollbar):
      (WebCore::RenderLayer::setHasVerticalScrollbar):
      (WebCore::RenderLayer::updateScrollbarsAfterLayout):
      * rendering/RenderListBox.cpp:
      (WebCore::RenderListBox::setHasVerticalScrollbar):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::styleWillChange):
      (WebCore):
      (WebCore::RenderObject::addAnnotatedRegions):
      * rendering/RenderObject.h:
      (WebCore::AnnotatedRegionValue::operator==):
      (AnnotatedRegionValue):
      (RenderObject):
      * rendering/style/RenderStyle.h:
      * rendering/style/RenderStyleConstants.h:
      * rendering/style/StyleRareNonInheritedData.cpp:
      (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
      (WebCore::StyleRareNonInheritedData::operator==):
      * rendering/style/StyleRareNonInheritedData.h:
      (StyleRareNonInheritedData):
      
      Source/WebKit/chromium:
      
      Renaming is needed to better match with the draggable region code.
      
      * features.gypi:
      * src/ChromeClientImpl.cpp:
      (WebKit):
      * src/ChromeClientImpl.h:
      (ChromeClientImpl):
      * src/WebDocument.cpp:
      (WebKit::WebDocument::draggableRegions):
      
      Source/WebKit/mac:
      
      Renaming is needed to better match with the draggable region code.
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebKit2:
      
      Renaming is needed to better match with the draggable region code.
      
      * Configurations/FeatureDefines.xcconfig:
      
      LayoutTests:
      
      Renaming is needed to better match with the draggable region code.
      
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/mac/TestExpectations:
      * platform/qt/TestExpectations:
      * platform/win/TestExpectations:
      * platform/wincairo/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@131532 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9acde016
  23. 10 Oct, 2012 1 commit
    • jianli@chromium.org's avatar
      Update the CSS property used to support draggable regions. · bd81dfe9
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97156
      
      Reviewed by Adam Barth.
      
      Source/JavaScriptCore:
      
      The CSS property to support draggable regions, guarded under
      WIDGET_REGION is now disabled from Mac WebKit, in order not to cause
      confusion with DASHBOARD_SUPPORT feature.
      
      * Configurations/FeatureDefines.xcconfig: Disable WIDGET_REGION feature.
      
      Source/WebCore:
      
      The CSS property to support draggable regions has been changed from
      "-webkit-widget-region" to "-webkit-app-region" in the following syntax:
         -webkit-app-region: drag|no-drag
      
      The CSS parsing code for draggable regions is now different from the CSS
      parsing code for dashboard regions since we have quite different syntax.
      
      We still try to share as much rendering update code as possible for
      these two features. To make the shared code easier to understand for
      both features, the name "DashboardRegions" in the shared code is changed
      to "AnnotatedRegions" to work for both dashboard regions and draggable
      regions.
      
      Note that we still using WIDGET_REGION as feature name in order not to
      add more changes to this patch. It will be renamed to a more appropriate
      name in next patch. WIDGET_REGION is now only turned on for the chromium
      port.
      
      Test: fast/css/draggable-region-parser.html
      
      * Configurations/FeatureDefines.xcconfig: Disable WIDGET_REGION feature.
      * WebCore.exp.in: Update the exported symbol due to renaming.
      * css/CSSComputedStyleDeclaration.cpp: Update the CSS parsing.
      (WebCore):
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      * css/CSSParser.cpp: Update the CSS parsing.
      (WebCore::CSSParser::parseValue):
      (WebCore):
      (WebCore::CSSParser::parseDashboardRegions):
      * css/CSSParserValues.cpp: Update the CSS parsing.
      (WebCore::CSSParserValue::createCSSValue):
      * css/CSSPrimitiveValue.cpp: Update the CSS parsing.
      (WebCore::isValidCSSUnitTypeForDoubleConversion):
      (WebCore):
      (WebCore::CSSPrimitiveValue::cleanup):
      (WebCore::CSSPrimitiveValue::customCssText):
      (WebCore::CSSPrimitiveValue::cloneForCSSOM):
      (WebCore::CSSPrimitiveValue::reportDescendantMemoryUsage):
      * css/CSSPrimitiveValue.h: Update the CSS parsing.
      (CSSPrimitiveValue):
      * css/CSSProperty.cpp:
      (WebCore::CSSProperty::isInheritedProperty):
      * css/CSSPropertyNames.in: Rename the CSS property for draggable region.
      * css/CSSValueKeywords.in: Add the keywords supported for the draggable region.
      * css/DashboardRegion.h: Remove WIDGET_REGION guard.
      (DashboardRegion):
      * css/StyleResolver.cpp: Update the CSS parsing.
      (WebCore::StyleResolver::collectMatchingRulesForList):
      * dom/Document.cpp: Rename dashboardRegions to annotatedRegions.
      (WebCore::Document::Document):
      (WebCore::Document::annotatedRegions):
      (WebCore::Document::setAnnotatedRegions):
      (WebCore::Document::reportMemoryUsage):
      * dom/Document.h: Rename dashboardRegions to annotatedRegions.
      (WebCore):
      (WebCore::Document::setAnnotatedRegionsDirty):
      (WebCore::Document::annotatedRegionsDirty):
      (WebCore::Document::hasAnnotatedRegions):
      (WebCore::Document::setHasAnnotatedRegions):
      (Document):
      * page/Chrome.cpp: Rename dashboardRegions to annotatedRegions.
      (WebCore::ChromeClient::annotatedRegionsChanged):
      * page/ChromeClient.h: Rename dashboardRegions to annotatedRegions.
      (ChromeClient):
      * page/FrameView.cpp: Rename dashboardRegions to annotatedRegions.
      (WebCore::FrameView::layout):
      (WebCore::FrameView::updateAnnotatedRegions):
      (WebCore::FrameView::paintContents):
      * page/FrameView.h: Rename dashboardRegions to annotatedRegions.
      (FrameView):
      * rendering/RenderInline.cpp:
      (WebCore::RenderInline::addAnnotatedRegions):
      * rendering/RenderInline.h: Rename dashboardRegions to annotatedRegions.
      (RenderInline):
      * rendering/RenderLayer.cpp: Rename dashboardRegions to annotatedRegions.
      (WebCore::RenderLayer::scrollTo):
      (WebCore::RenderLayer::setHasHorizontalScrollbar):
      (WebCore::RenderLayer::setHasVerticalScrollbar):
      (WebCore::RenderLayer::updateScrollbarsAfterLayout):
      * rendering/RenderListBox.cpp: Rename dashboardRegions to annotatedRegions.
      (WebCore::RenderListBox::setHasVerticalScrollbar):
      * rendering/RenderObject.cpp: Rename dashboardRegions to annotatedRegions.
      (WebCore::RenderObject::styleWillChange):
      (WebCore::RenderObject::addAnnotatedRegions):
      (WebCore::RenderObject::collectAnnotatedRegions):
      * rendering/RenderObject.h: Rename dashboardRegions to annotatedRegions.
      (WebCore::AnnotatedRegionValue::operator==):
      (WebCore::AnnotatedRegionValue::operator!=):
      (AnnotatedRegionValue):
      (RenderObject):
      * rendering/style/RenderStyle.cpp: Update the CSS parsing.
      (WebCore::RenderStyle::diff):
      (WebCore):
      * rendering/style/RenderStyle.h: Update the CSS parsing.
      * rendering/style/RenderStyleConstants.h: Update the CSS parsing.
      * rendering/style/StyleDashboardRegion.h: Update the CSS parsing.
      * rendering/style/StyleRareNonInheritedData.cpp: Update the CSS parsing.
      (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
      (WebCore::StyleRareNonInheritedData::operator==):
      * rendering/style/StyleRareNonInheritedData.h: Update the CSS parsing.
      (WebCore):
      (StyleRareNonInheritedData):
      
      Source/WebKit/chromium:
      
      Update the code to use the new name annotatedRegions to work for
      both features.
      
      * public/WebDraggableRegion.h: Rename dashboardRegions to annotatedRegions.
      (WebDraggableRegion):
      * src/ChromeClientImpl.cpp: Rename dashboardRegions to annotatedRegions.
      (WebKit::ChromeClientImpl::annotatedRegionsChanged):
      * src/ChromeClientImpl.h: Rename dashboardRegions to annotatedRegions.
      (ChromeClientImpl):
      * src/WebDocument.cpp: Rename dashboardRegions to annotatedRegions.
      (WebKit::WebDocument::draggableRegions):
      
      Source/WebKit/mac:
      
      The CSS property to support draggable regions, guarded under
      WIDGET_REGION is now disabled from Mac WebKit, in order not to cause
      confusion with DASHBOARD_SUPPORT feature.
      
      Also update the code to use the new name annotatedRegions to work for
      both features.
      
      * Configurations/FeatureDefines.xcconfig: Disable WIDGET_REGION feature.
      * WebCoreSupport/WebChromeClient.h: Rename dashboardRegions to annotatedRegions.
      * WebCoreSupport/WebChromeClient.mm: Rename dashboardRegions to annotatedRegions.
      (WebChromeClient::annotatedRegionsChanged):
      * WebView/WebView.mm: Rename dashboardRegions to annotatedRegions.
      (-[WebView _dashboardRegions]):
      
      Source/WebKit2:
      
      The CSS property to support draggable regions, guarded under
      WIDGET_REGION is now disabled from Mac WebKit, in order not to cause
      confusion with DASHBOARD_SUPPORT feature.
      
      Also update the code to use the new name annotatedRegions to work for
      both features.
      
      * Configurations/FeatureDefines.xcconfig: Disable WIDGET_REGION feature.
      * WebProcess/WebCoreSupport/WebChromeClient.cpp: Rename dashboardRegions to annotatedRegions.
      (WebKit::WebChromeClient::annotatedRegionsChanged):
      * WebProcess/WebCoreSupport/WebChromeClient.h: Rename dashboardRegions to annotatedRegions.
      (WebChromeClient):
      
      LayoutTests:
      
      Update the test and rename the files due to CSS property name and
      syntax changes.
      
      * fast/css/draggable-region-parser-expected.txt: Added.
      * fast/css/draggable-region-parser.html: Added.
      * fast/css/widget-region-parser-expected.txt: Removed.
      * fast/css/widget-region-parser.html: Removed.
      * platform/efl/TestExpectations: Rename the skipped test.
      * platform/gtk/TestExpectations: Rename the skipped test.
      * platform/mac/TestExpectations: Skip the renamed test since WIDGET_REGION is off.
      * platform/qt/TestExpectations: Rename the skipped test.
      * platform/win/TestExpectations: Rename the skipped test.
      * platform/wincairo/TestExpectations: Rename the skipped test.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130829 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd81dfe9
  24. 31 Aug, 2012 1 commit
    • pfeldman@chromium.org's avatar
      Web Inspector: render box model elements and grid on inspector overlay · b9ada395
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95456
      
      Reviewed by Vsevolod Vlasov.
      
      This change migrates native rendering for box model to the InspectorOverlay.
      
      * inspector/InspectorInstrumentation.cpp:
      (WebCore):
      (WebCore::InspectorInstrumentation::didScrollImpl):
      * inspector/InspectorInstrumentation.h:
      (InspectorInstrumentation):
      (WebCore::InspectorInstrumentation::didScroll):
      (WebCore):
      * inspector/InspectorOverlay.cpp:
      (WebCore::InspectorOverlay::drawNodeHighlight):
      (WebCore::InspectorOverlay::drawRectHighlight):
      (WebCore::InspectorOverlay::overlayPage):
      (WebCore::InspectorOverlay::evaluateInOverlay):
      * inspector/InspectorOverlay.h:
      (WebCore::Highlight::setColors):
      (Highlight):
      (InspectorOverlay):
      * inspector/InspectorOverlayPage.html:
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::didLayout):
      (WebCore):
      (WebCore::InspectorPageAgent::didScroll):
      * inspector/InspectorPageAgent.h:
      * page/Chrome.cpp:
      (WebCore::Chrome::scroll):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9ada395
  25. 02 Aug, 2012 1 commit
    • jianli@chromium.org's avatar
      Add new CSS property "-webkit-widget-region" to expose dashboard region support for other port · f66b5811
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=90298
      
      Reviewed by Adam Barth.
      
      .:
      
      * configure.ac: Add ENABLE_WIDGET_REGION define.
      
      Source/JavaScriptCore:
      
      * Configurations/FeatureDefines.xcconfig: Add ENABLE_WIDGET_REGION define.
      
      Source/WebCore:
      
      The css property "-webkit-widget-region" is essentially a synonym of
      "-webkit-dashboard-region" that allows us to expose dashboard region
      support for other port. This patch also adds a new feature define
      ENABLE(WIDGET_REGION) such that "-webkit-dashboard-region" is only
      provided under ENABLE(DASHBOARD_SUPPORT) as it is now and
      "-webkit-widget-region" is only exposed under ENABLE(WIDGET_REGION).
      
      Change almost all the code pieces guarded by ENABLE(DASHBOARD_SUPPORT)
      to make them also guarded by ENABLE(WIDGET_REGION), except those
      that are specific to Apple/WebKit.
      
      Currently ENABLE(WIDGET_REGION) has been turned on by default for
      Mac/WebKit and chromium ports.
      
      Test: fast/css/widget-region-parser.html
      
      * Configurations/FeatureDefines.xcconfig: Add ENABLE_WIDGET_REGION define.
      * DerivedSources.make:
      * GNUmakefile.am: Add ENABLE_WIDGET_REGION define.
      * WebCore.exp.in:
      * css/CSSComputedStyleDeclaration.cpp: Handle CSSPropertyWebkitWidgetRegion.
      (WebCore):
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      * css/CSSParser.cpp: Parse "-webkit-widget-region".
      (WebCore::CSSParser::parseValue):
      (WebCore):
      (WebCore::CSSParser::parseDashboardRegions):
      * css/CSSProperty.cpp: Handle CSSPropertyWebkitWidgetRegion.
      (WebCore::CSSProperty::isInheritedProperty):
      * css/CSSPrimitiveValue.cpp:
      (WebCore):
      (WebCore::CSSPrimitiveValue::customCssText):
      (WebCore::CSSPrimitiveValue::cloneForCSSOM):
      * css/CSSPropertyNames.in: Add "-webkit-widget-region" property.
      * css/DashboardRegion.h:
      (DashboardRegion):
      * css/StyleResolver.cpp: Handle CSSPropertyWebkitWidgetRegion.
      * dom/Document.cpp:
      (WebCore::Document::Document):
      (WebCore):
      * dom/Document.h:
      (WebCore):
      (Document):
      * page/Chrome.cpp:
      (WebCore):
      * page/ChromeClient.h:
      (ChromeClient):
      * page/FrameView.cpp:
      (WebCore::FrameView::layout):
      (WebCore):
      (WebCore::FrameView::paintContents):
      * page/FrameView.h:
      (FrameView):
      * rendering/RenderInline.cpp:
      (WebCore):
      * rendering/RenderInline.h:
      (RenderInline):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::scrollTo):
      (WebCore::RenderLayer::setHasHorizontalScrollbar):
      (WebCore::RenderLayer::setHasVerticalScrollbar):
      (WebCore::RenderLayer::updateScrollbarsAfterLayout):
      * rendering/RenderListBox.cpp:
      (WebCore::RenderListBox::setHasVerticalScrollbar):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::styleWillChange):
      (WebCore):
      * rendering/RenderObject.h:
      (RenderObject):
      * rendering/style/RenderStyle.cpp:
      (WebCore::RenderStyle::diff):
      (WebCore):
      * rendering/style/RenderStyle.h:
      * rendering/style/StyleDashboardRegion.h:
      * rendering/style/StyleRareNonInheritedData.cpp:
      (WebCore::StyleRareNonInheritedData::operator==):
      * rendering/style/StyleRareNonInheritedData.h:
      (WebCore):
      (StyleRareNonInheritedData):
      
      Source/WebKit/chromium:
      
      * features.gypi: Add ENABLE_WIDGET_REGION define.
      
      Source/WebKit/mac:
      
      * Configurations/FeatureDefines.xcconfig: Add ENABLE_WIDGET_REGION define.
      
      Source/WebKit2:
      
      * Configurations/FeatureDefines.xcconfig: Add ENABLE_WIDGET_REGION define.
      
      LayoutTests:
      
      Added a new test to test the new CSS property.
      
      * fast/css/widget-region-parser-expected.txt: Added.
      * fast/css/widget-region-parser.html: Added.
      * platform/efl/Skipped: Skip the new test.
      * platform/gtk/TestExpectations: Skip the new test.
      * platform/qt/Skipped: Skip the new test.
      * platform/win/Skipped: Skip the new test.
      * platform/wincario/Skipped: Skip the new test.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f66b5811
  26. 09 May, 2012 1 commit
  27. 21 Apr, 2012 1 commit
    • beidson@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=84512 Repurpose... · 48fb048e
      beidson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=84512 Repurpose ActiveDOMObject::WillShowDialog to WillDeferLoading
      
      Reviewed by Eric Carlson.
      
      Source/WebCore:
      
      No new tests. (Refactor, no behavior change)
      
      Rename WillShowDialog to WillDeferLoading:
      * dom/ActiveDOMObject.h:
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::suspend):
      
      Don't take a ReasonForSuspension argument anymore, just use WillDeferLoading:
      * page/PageGroupLoadDeferrer.cpp:
      (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
      * page/PageGroupLoadDeferrer.h:
      
      Don't pass a Reason anymore as WillDeferLoading is used by default:
      * page/Chrome.cpp:
      (WebCore::Chrome::runModal):
      (WebCore::Chrome::runBeforeUnloadConfirmPanel):
      (WebCore::Chrome::runJavaScriptAlert):
      (WebCore::Chrome::runJavaScriptConfirm):
      (WebCore::Chrome::runJavaScriptPrompt):
      (WebCore::Chrome::shouldInterruptJavaScript):
      
      Source/WebKit/blackberry:
      
      PageGroupLoadDeferrer's don't take a ReasonForSuspension argument anymore;
      They just use WillDeferLoading by default.
      
      * Api/WebPageGroupLoadDeferrer.cpp:
      (BlackBerry::WebKit::WebPageGroupLoadDeferrer::WebPageGroupLoadDeferrer):
      
      * WebCoreSupport/ChromeClientBlackBerry.cpp:
      (WebCore::ChromeClientBlackBerry::createWindow):
      (WebCore::ChromeClientBlackBerry::runOpenPanel):
      
      Source/WebKit/chromium:
      
      PageGroupLoadDeferrer's don't take a ReasonForSuspension argument anymore;
      They just use WillDeferLoading by default.
      
      * src/WebViewImpl.cpp:
      (WebKit::WebView::willEnterModalLoop):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114802 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48fb048e
  28. 20 Apr, 2012 1 commit
    • beidson@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=84490 · b1bc1b72
      beidson@apple.com authored
      PageGroupLoadDeferrer needs to take a ReasonForSuspension argument
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore:
      
      No new tests. (Refactor, no change in behavior)
      
      - Make PageGroupLoadDeferrer take a ReasonForSuspension argument so it can pass it along.
      * page/PageGroupLoadDeferrer.cpp:
      (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
      * page/PageGroupLoadDeferrer.h:
      
      - Change suspendScheduledTasks to take a ReasonForSuspension.
      - As long as we're changing Document.h, add a m_suspendedScheduledTasks flag and some
        ASSERTs to catch what would be epically wrong behavior in the future.
      * dom/Document.cpp:
      (WebCore::Document::Document):
      (WebCore::Document::suspendScheduledTasks):
      (WebCore::Document::resumeScheduledTasks):
      * dom/Document.h:
      
      - Pass ActiveDOMObject::WillShowDialog along to all PageGroupLoadDeferrers, as it used
        to be the default behavior
      * page/Chrome.cpp:
      (WebCore::Chrome::runModal):
      (WebCore::Chrome::runBeforeUnloadConfirmPanel):
      (WebCore::Chrome::runJavaScriptAlert):
      (WebCore::Chrome::runJavaScriptConfirm):
      (WebCore::Chrome::runJavaScriptPrompt):
      (WebCore::Chrome::shouldInterruptJavaScript):
      
      Source/WebKit/blackberry:
      
      * Api/WebPageGroupLoadDeferrer.cpp:
      (BlackBerry::WebKit::WebPageGroupLoadDeferrer::WebPageGroupLoadDeferrer): Pass along ActiveDOMObject::WillShowDialog,
        which used to be the default
      
      * WebCoreSupport/ChromeClientBlackBerry.cpp:
      (WebCore::ChromeClientBlackBerry::createWindow): Pass along ActiveDOMObject::WillShowDialog, which used to be the default.
      (WebCore::ChromeClientBlackBerry::runOpenPanel): Ditto.
      
      Source/WebKit/chromium:
      
      * src/WebViewImpl.cpp:
      (WebKit::WebView::willEnterModalLoop): Pass along ActiveDOMObject::WillShowDialog, which used
        to be the default.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1bc1b72
  29. 30 Mar, 2012 1 commit
    • keishi@webkit.org's avatar
      Change ENABLE_INPUT_COLOR to ENABLE_INPUT_TYPE_COLOR and enable it for chromium · 1a2b07cc
      keishi@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=80972
      
      Reviewed by Kent Tamura.
      
      .:
      
      * Source/cmake/OptionsBlackBerry.cmake:
      * configure.ac:
      
      Source/JavaScriptCore:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebCore:
      
      * CMakeLists.txt:
      * Configurations/FeatureDefines.xcconfig:
      * GNUmakefile.am:
      * WebCore.exp.in:
      * css/html.css:
      * html/ColorInputType.cpp:
      * html/ColorInputType.h:
      * html/HTMLInputElement.cpp:
      (WebCore):
      * html/HTMLInputElement.h:
      (HTMLInputElement):
      * html/InputType.cpp:
      (WebCore::createInputTypeFactoryMap):
      (WebCore):
      (InputTypeNames):
      * html/InputType.h:
      (InputType):
      (InputTypeNames):
      * loader/EmptyClients.h:
      (EmptyChromeClient):
      * page/Chrome.cpp:
      (WebCore):
      * page/Chrome.h:
      (WebCore):
      (Chrome):
      * page/ChromeClient.h:
      (WebCore):
      (ChromeClient):
      * platform/ColorChooser.h:
      * platform/ColorChooserClient.h:
      * testing/InternalSettings.cpp:
      * testing/Internals.cpp:
      (WebCore):
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      
      Source/WebKit/blackberry:
      
      * WebCoreSupport/AboutDataEnableFeatures.in:
      * WebCoreSupport/ChromeClientBlackBerry.h:
      (ChromeClientBlackBerry):
      * WebKitSupport/DOMSupport.cpp:
      (BlackBerry::WebKit::DOMSupport::isColorInputField):
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::convertInputType):
      
      Source/WebKit/chromium:
      
      * features.gypi:
      * src/ChromeClientImpl.cpp:
      (WebKit):
      * src/ChromeClientImpl.h:
      (WebCore):
      (ChromeClientImpl):
      * src/ColorChooserProxy.cpp:
      * src/ColorChooserProxy.h:
      * src/WebColorChooserClientImpl.cpp:
      * src/WebColorChooserClientImpl.h:
      
      Source/WebKit/mac:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebKit2:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Tools:
      
      * Scripts/build-webkit:
      * qmake/mkspecs/features/features.prf:
      
      WebKitLibraries:
      
      * win/tools/vsprops/FeatureDefines.vsprops:
      * win/tools/vsprops/FeatureDefinesCairo.vsprops:
      
      LayoutTests:
      
      * platform/efl/Skipped:
      * platform/qt/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112658 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a2b07cc
  30. 14 Mar, 2012 1 commit
    • sergio@webkit.org's avatar
      [GTK] Use the same DNS prefetching path than the other ports. · c27fa057
      sergio@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=80997
      
      Reviewed by Martin Robinson.
      
      This patch basically reverts r56128. There is no need to add an
      special code path for GTK+ DNS pre-fetching because the main
      reason to do that (some potential changes in libsoup) is not
      going to happen. It also reduces the amount of DNS queries by
      adding a NULL hostname check.
      
      No need for new tests as this just moves code around.
      
      * GNUmakefile.list.am:
      * html/HTMLAnchorElement.cpp:
      (WebCore::HTMLAnchorElement::parseAttribute):
      * html/HTMLLinkElement.cpp:
      * loader/LinkLoader.cpp:
      (WebCore::LinkLoader::loadLink):
      * page/Chrome.cpp:
      (WebCore::Chrome::mouseDidMoveOverElement):
      * platform/network/DNS.h:
      (WebCore):
      * platform/network/ResourceHandle.cpp:
      * platform/network/ResourceHandle.h:
      (ResourceHandle):
      * platform/network/chromium/DNSChromium.cpp:
      * platform/network/soup/DNSSoup.cpp: restored.
      (WebCore):
      (WebCore::prefetchDNS):
      * platform/network/soup/ResourceHandleSoup.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c27fa057
  31. 27 Feb, 2012 1 commit
    • commit-queue@webkit.org's avatar
      Move ChromeClient::showContextMenu() to ContextMenuClient · 9b5aba45
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=79427
      
      Patch by Hajime Morrita <morrita@chromium.org> on 2012-02-26
      Reviewed by Adam Barth.
      
      Source/JavaScriptCore:
      
      Added ACCESSIBILITY_CONTEXT_MENUS.
      
      * wtf/Platform.h:
      
      Source/WebCore:
      
      - Removed ChromeClient::showContextMenu(), Chrome::showContextMenu()
      - Added ContextMenuController::showContextMenuAt(), ContextMenuClient::showContextMenu()
      - Hided showContextMenu() behind ACCESSIBILITY_CONTEXT_MENUS
      
      This change localizes context menu related code and will make it easy to
      modularize CONTEXT_MENUS code.
      
      Refactoring. No new tests.
      
      * WebCore.exp.in:
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (-[WebAccessibilityObjectWrapper accessibilityShowContextMenu]):
      * loader/EmptyClients.h:
      (EmptyContextMenuClient):
      (WebCore::EmptyContextMenuClient::showContextMenu):
      * page/ContextMenuClient.h:
      (ContextMenuClient):
      * page/ContextMenuController.cpp:
      (WebCore):
      (WebCore::ContextMenuController::showContextMenuAt):
      * page/ContextMenuController.h:
      (ContextMenuController):
      * page/Chrome.cpp:
      * page/Chrome.h:
      (Chrome):
      * page/ChromeClient.h:
      (ChromeClient):
      
      Source/WebKit/blackberry:
      
      * WebCoreSupport/ChromeClientBlackBerry.h:
      (ChromeClientBlackBerry):
      
      Source/WebKit/chromium:
      
      * src/ChromeClientImpl.h:
      (ChromeClientImpl):
      
      Source/WebKit/efl:
      
      * WebCoreSupport/ChromeClientEfl.h:
      (ChromeClientEfl):
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/ChromeClientGtk.h:
      (ChromeClient):
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebContextMenuClient.h:
      (WebContextMenuClient):
      * WebCoreSupport/WebContextMenuClient.mm:
      (WebContextMenuClient::showContextMenu): Moved from WebChromeClient
      * WebCoreSupport/WebChromeClient.h:
      * WebCoreSupport/WebChromeClient.mm:
      
      Source/WebKit/qt:
      
      * WebCoreSupport/ChromeClientQt.h:
      (ChromeClientQt):
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebChromeClient.h:
      (WebChromeClient):
      
      Source/WebKit/wince:
      
      * WebCoreSupport/ChromeClientWinCE.h:
      (ChromeClientWinCE):
      
      Source/WebKit/wx:
      
      * WebKitSupport/ChromeClientWx.h:
      (ChromeClientWx):
      
      Source/WebKit2:
      
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      (WebChromeClient):
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      (WebKit):
      (WebKit::WebContextMenuClient::showContextMenu): Moved from WebChromeClient
      * WebProcess/WebCoreSupport/WebContextMenuClient.h:
      (WebContextMenuClient):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::handleContextMenuEvent):
      (WebKit::handleMouseEvent):
      (WebKit::WebPage::mouseEvent):
      (WebKit::WebPage::mouseEventSyncForTesting):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108957 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b5aba45
  32. 16 Feb, 2012 1 commit
  33. 21 Dec, 2011 1 commit
    • commit-queue@webkit.org's avatar
      Change adoptPtr(new ...) to ...::create in Page.cpp · 5b13798b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=74457
      
      Patch by Greg Billock <gbillock@google.com> on 2011-12-20
      Reviewed by Darin Adler.
      
      * dom/DeviceMotionController.cpp:
      (WebCore::DeviceMotionController::create):
      * dom/DeviceMotionController.h:
      * dom/DeviceOrientationController.cpp:
      (WebCore::DeviceOrientationController::create):
      * dom/DeviceOrientationController.h:
      * editing/FrameSelection.cpp:
      (WebCore::DragCaretController::create):
      * editing/FrameSelection.h:
      * history/BackForwardController.cpp:
      (WebCore::BackForwardController::create):
      * history/BackForwardController.h:
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::create):
      * inspector/InspectorController.h:
      * loader/ProgressTracker.cpp:
      (WebCore::ProgressTracker::create):
      * loader/ProgressTracker.h:
      * notifications/NotificationController.cpp:
      (WebCore::NotificationController::create):
      * notifications/NotificationController.h:
      * page/Chrome.cpp:
      (WebCore::Chrome::create):
      * page/Chrome.h:
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::create):
      * page/ContextMenuController.h:
      * page/DragController.cpp:
      (WebCore::DragController::create):
      * page/DragController.h:
      * page/FocusController.cpp:
      (WebCore::FocusController::create):
      * page/FocusController.h:
      * page/GeolocationController.cpp:
      (WebCore::GeolocationController::create):
      * page/GeolocationController.h:
      * page/Page.cpp:
      (WebCore::Page::Page):
      (WebCore::Page::initGroup):
      (WebCore::Page::speechInput):
      * page/PageGroup.cpp:
      (WebCore::PageGroup::create):
      * page/PageGroup.h:
      * page/Settings.cpp:
      (WebCore::Settings::create):
      * page/Settings.h:
      * page/SpeechInput.cpp:
      (WebCore::SpeechInput::create):
      * page/SpeechInput.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103365 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b13798b
  34. 18 Dec, 2011 1 commit
    • keishi@webkit.org's avatar
      Refactor input type color WebCore part · e6f711f7
      keishi@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=74591
      
      Reviewed by Kent Tamura.
      
      Changing ColorChooser to address issues raised in Bug 65897.
      Chrome::createColorChooser will return a WebCore::ColorChooser instance
      so the WebCore side (ColorInputType) and call the WebKit side. We pass the ColorChooserClient as an argument
      to Chrome::createColorChooser so the WebKit side can call callbacks, didEndChooser and didChooseColor.
      
      * html/ColorInputType.cpp:
      (WebCore::ColorInputType::~ColorInputType):
      (WebCore::ColorInputType::setValue):
      (WebCore::ColorInputType::handleDOMActivateEvent): Calls createColorChooser to open the color chooser.
      (WebCore::ColorInputType::detach):
      (WebCore::ColorInputType::didEndChooser): Release the ColorChooser object.
      (WebCore::ColorInputType::endColorChooser):
      (WebCore::ColorInputType::updateColorSwatch): Added argument so it will compile again.
      * html/ColorInputType.h:
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::selectColorInColorChooser):
      * loader/EmptyClients.h:
      (WebCore::EmptyChromeClient::createColorChooser):
      * loader/FrameLoader.cpp:
      * page/Chrome.cpp:
      (WebCore::Chrome::createColorChooser): Opens the color chooser. Returns a ColorChooser PassOwnPtr.
      * page/Chrome.h:
      * page/ChromeClient.h:
      * platform/ColorChooser.h:
      (WebCore::ColorChooser::~ColorChooser):
      (WebCore::ColorChooser::setSelectedColor):
      (WebCore::ColorChooser::endChooser):
      * platform/ColorChooserClient.h: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103168 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6f711f7
  35. 15 Dec, 2011 1 commit
    • commit-queue@webkit.org's avatar
      Opening two popup menus by dispatchEvent() makes problems. · f3ed1003
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=73304
      
      Patch by Jing Zhao <jingzhao@chromium.org> on 2011-12-14
      Reviewed by Kent Tamura.
      
      Source/WebCore:
      
      By using element.dispatchEvent(), a user written script can open two
      popup menus, which causes various problems in different platforms.
      
      Add a hasOpenedPopup() method in ChromeClient and a wrapper in Chrome.
      In RenderMenuList::showPopup(), check if there is an opened popup menu
      before opening a new popup menu.
      
      Test: fast/forms/select-popup-crash.html
      
      * loader/EmptyClients.h: Overrides hasOpenedPopup().
      (WebCore::EmptyChromeClient::hasOpenedPopup): Returns false as a default case.
      * page/Chrome.cpp:
      (WebCore::Chrome::hasOpenedPopup): Calls ChromeClient::hasOpenedPopup().
      * page/Chrome.h: Declares hasOpenedPopup().
      * page/ChromeClient.h: Declares hasOpenedPopup() as a pure virtual function.
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::showPopup): Calls Chrome::hasOpenedPopup() before opening a new popup menu.
      
      Source/WebKit/chromium:
      
      By using element.dispatchEvent(), a user written script can open two
      popup menus, which causes the assertion in WebViewImpl::popupOpened()
      fail.
      
      ChromeClientImpl::hasOpenedPopup() is called by Chrome::hasOpenedPopup()
      in RenderMenuList::showPopup(), to check if there is an opened popup
      menu before opening a new popup menu.
      
      * src/ChromeClientImpl.cpp:
      (WebKit::ChromeClientImpl::hasOpenedPopup): Checks the popup in WebViewImpl.
      * src/ChromeClientImpl.h: Overrides hasOpenedPopup().
      
      Source/WebKit/efl:
      
      * WebCoreSupport/ChromeClientEfl.cpp:
      (WebCore::ChromeClientEfl::hasOpenedPopup): Not implemented.
      * WebCoreSupport/ChromeClientEfl.h: Overrides hasOpenedPopup().
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::hasOpenedPopup): Not implemented.
      * WebCoreSupport/ChromeClientGtk.h: Overrides hasOpenedPopup().
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebChromeClient.h: Overrides hasOpenedPopup().
      * WebCoreSupport/WebChromeClient.mm:
      (WebChromeClient::hasOpenedPopup): Not implemented.
      
      Source/WebKit/qt:
      
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::hasOpenedPopup): Not implemented.
      * WebCoreSupport/ChromeClientQt.h: Overrides hasOpenedPopup().
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebChromeClient.cpp:
      (WebChromeClient::hasOpenedPopup): Not implemented.
      * WebCoreSupport/WebChromeClient.h: Overrides hasOpenedPopup().
      
      Source/WebKit2:
      
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::hasOpenedPopup): Not implemented.
      * WebProcess/WebCoreSupport/WebChromeClient.h: Overrides hasOpenedPopup().
      
      LayoutTests:
      
      * fast/forms/select/menulist-popup-crash-expected.txt: Added.
      * fast/forms/select/menulist-popup-crash.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3ed1003
  36. 29 Nov, 2011 1 commit
    • jonlee@apple.com's avatar
      Create skeleton framework for notifications support in WK2 · 6c095456
      jonlee@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=73253
      <rdar://problem/10356943>
      
      Source/JavaScriptCore:
      
      * Configurations/FeatureDefines.xcconfig: Split out ENABLE_NOTIFICATIONS based on platform.
      
      Source/WebCore:
      
      Reviewed by Sam Weinig.
      
      Some refactoring was done to make notifications follow a similar pattern to our other clients, like
      geolocation and context menu.
      
      * Configurations/FeatureDefines.xcconfig: Split out ENABLE_NOTIFICATIONS based on platform.
      * WebCore.xcodeproj/project.pbxproj: Adding new NotificationController class, and exposing
      Notification and NotificationController as private headers.
      * Target.pri: Ditto.
      * WebCore.gypi: Ditto.
      
      * notifications/NotificationContents.h: Converted class to struct. Members need to be accessible
      in order to do WK2 argument encoding.
      (WebCore::NotificationContents::NotificationContents):
      
      * notifications/Notification.cpp: Update style of entire file.
      (WebCore::Notification::Notification): Added default constructor (for WK2), and minor refactoring
      with NotificationContents.
      * notifications/Notification.h: Added set methods for WK2 serialization. Also, update indenting.
      (WebCore::Notification::setHTML): Added.
      (WebCore::Notification::setURL): Added.
      (WebCore::Notification::contents): Added const version for WK2.
      * notifications/NotificationCenter.h: Update style.
      
      * notifications/NotificationController.cpp: Added.
      (WebCore::NotificationController::NotificationController):
      (WebCore::NotificationController::~NotificationController):
      * notifications/NotificationController.h: Added.
      (WebCore::NotificationController::client):
      * notifications/NotificationPresenter.h: This acts like a client, and should probably be renamed as such.
      Removed ifdef for exposure to WK2.
      (WebCore::NotificationPresenter::~NotificationPresenter): Moved as protected instead of public.
      
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::webkitNotifications):  We move the request for the notification client from the chrome
      to the controller.
      * page/Page.cpp:
      (WebCore::Page::Page): The page now owns a notification controller.
      (WebCore::Page::PageClients::PageClients): Add notification client as a page client.
      * page/Page.h:
      (WebCore::Page::notificationController): Retrieve the notification controller.
      
      * page/ChromeClient.h: We move the request for the notification client from the chrome to the controller.
      Remove notificationPresenter().
      * page/Chrome.cpp: Remove notificationPresenter().
      * page/Chrome.h: Remove notificationPresenter().
      * loader/EmptyClients.h: Remove notificationPresenter().
      
      Source/WebKit:
      
      Reviewed by Sam Weinig.
      
      * WebKit.xcodeproj/project.pbxproj: Add WebNotificationClient class.
      
      Source/WebKit/chromium:
      
      Reviewed by Sam Weinig.
      
      Remove notificationPresenter() from the chrome client, since it is now managed by
      the notification controller.
      
      * src/ChromeClientImpl.cpp:
      * src/ChromeClientImpl.h:
      * src/WebNotification.cpp:
      (WebKit::WebNotification::title): Refactoring with NotificationContents conversion to struct.
      (WebKit::WebNotification::body): Ditto.
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::WebViewImpl): Set notification client in web view's page clients.
      
      Source/WebKit/mac:
      
      Reviewed by Sam Weinig.
      
      * Configurations/FeatureDefines.xcconfig: Split out ENABLE_NOTIFICATIONS based on platform.
      
      * WebCoreSupport/WebNotificationClient.h: Added.
      (WebNotificationClient::webView):
      * WebCoreSupport/WebNotificationClient.mm: Added. Implemented as stubs for now.
      (WebNotificationClient::WebNotificationClient):
      (WebNotificationClient::show):
      (WebNotificationClient::cancel):
      (WebNotificationClient::notificationObjectDestroyed):
      (WebNotificationClient::requestPermission):
      (WebNotificationClient::cancelRequestsForPermission):
      (WebNotificationClient::checkPermission):
      * WebView/WebView.mm: Set PageClient's notification client to an instance of this stubbed class.
      
      Source/WebKit/qt:
      
      Reviewed by Sam Weinig.
      
      * Api/qwebpage.cpp: Add notification client to pageClients.
      (QWebPagePrivate::QWebPagePrivate):
      * WebCoreSupport/ChromeClientQt.cpp: Remove notification client from ChromeClient implementation.
      * WebCoreSupport/ChromeClientQt.h:
      * WebCoreSupport/NotificationPresenterClientQt.cpp: Refactor with change of NotificationContents to struct
      (WebCore::NotificationWrapper::title):
      (WebCore::NotificationWrapper::message):
      (WebCore::NotificationPresenterClientQt::displayNotification):
      (WebCore::NotificationPresenterClientQt::cancel):
      (WebCore::NotificationPresenterClientQt::notificationClicked):
      (WebCore::NotificationPresenterClientQt::dumpReplacedIdText):
      (WebCore::NotificationPresenterClientQt::dumpShowText):
      
      Source/WebKit2:
      
      Reviewed by Sam Weinig.
      
      * WebKit2.xcodeproj/project.pbxproj: Added classes for notification support.
      * win/WebKit2.vcproj: Ditto.
      * Target.pri: Ditto.
      * Configurations/FeatureDefines.xcconfig: Split out ENABLE_NOTIFICATIONS based on platform.
      * DerivedSources.make: Add Notifications to VPATH.
      * Platform/CoreIPC/MessageID.h: List WebNotificationManagerProxy as a class with messages.
      * Scripts/webkit2/messages.py: Mark WebCore::NotificationContents as a struct.
      
      * Shared/API/c/WKBase.h: Map opaque types to NotificationProvider, NotificationManager, and Notification.
      * UIProcess/API/C/WKAPICast.h: Map WK types toNotificationProvider, NotificationManager, and Notification.
      * Shared/APIObject.h: Add Notification and NotificationManager as APIObjects.
      * Shared/WebCoreArgumentCoders.cpp: Added coders for KURL.
      (CoreIPC::::encode):
      (CoreIPC::::decode):
      * Shared/WebCoreArgumentCoders.h:
      
      * UIProcess/WebNotification.cpp: Added.
      (WebKit::WebNotification::WebNotification):
      (WebKit::WebNotification::~WebNotification):
      (WebKit::WebNotification::encode):
      (WebKit::WebNotification::decode):
      * UIProcess/WebNotification.h: Added.
      (WebKit::WebNotification::create):
      (WebKit::WebNotification::title):
      (WebKit::WebNotification::body):
      (WebKit::WebNotification::type):
      * UIProcess/API/C/WKNotification.cpp: Added as API.
      (WKNotificationGetTypeID):
      (WKNotificationCopyTitle):
      (WKNotificationCopyBody):
      * UIProcess/API/C/WKNotification.h: Added as API.
      
      * WebProcess/Notifications/WebNotificationManager.h: Added. Contains for now show() and cancel().
      The rest of the notification client methods will be added later. These two functions send messages
      to the manager proxy.
      * WebProcess/Notifications/WebNotificationManager.cpp: Added.
      (WebKit::WebNotificationManager::WebNotificationManager):
      (WebKit::WebNotificationManager::~WebNotificationManager):
      (WebKit::WebNotificationManager::show):
      (WebKit::WebNotificationManager::cancel):
      
      * UIProcess/WebNotificationManagerProxy.cpp: Added.
      (WebKit::WebNotificationManagerProxy::create):
      (WebKit::WebNotificationManagerProxy::WebNotificationManagerProxy):
      (WebKit::WebNotificationManagerProxy::~WebNotificationManagerProxy):
      (WebKit::WebNotificationManagerProxy::invalidate):
      (WebKit::WebNotificationManagerProxy::initializeProvider):
      (WebKit::WebNotificationManagerProxy::didReceiveMessage):
      (WebKit::WebNotificationManagerProxy::show):
      (WebKit::WebNotificationManagerProxy::cancel):
      * UIProcess/WebNotificationManagerProxy.h: Added.
      (WebKit::WebNotificationManagerProxy::clearContext):
      (WebKit::WebNotificationManagerProxy::type):
      * UIProcess/WebNotificationManagerProxy.messages.in: Added.
      * UIProcess/API/C/WKNotificationManager.cpp: Added.
      (WKNotificationManagerGetTypeID):
      (WKNotificationManagerSetProvider):
      * UIProcess/API/C/WKNotificationManager.h: Added.
      
      * UIProcess/WebContext.h: Add the notification manager to the web context.
      (WebKit::WebContext::notificationManagerProxy): Access the manager.
      * UIProcess/WebContext.cpp:
      (WebKit::WebContext::WebContext): Boilerplate for managers.
      (WebKit::WebContext::~WebContext): Boilerplate for managers.
      (WebKit::WebContext::disconnectProcess): Boilerplate for managers.
      (WebKit::WebContext::didReceiveMessage): Forward messages to the notification manager.
      * UIProcess/API/C/WKContext.cpp: Expose as API.
      (WKContextGetNotificationManager):
      * UIProcess/API/C/WKContext.h: Expose as API.
      
      * UIProcess/API/C/WKNotificationProvider.h: Added.
      * UIProcess/WebNotificationProvider.h: Added as APIClient.
      * UIProcess/WebNotificationProvider.cpp: Added.
      (WebKit::WebNotificationProvider::show): Forward call to the client.
      (WebKit::WebNotificationProvider::cancel): Forward call to the client.
      * UIProcess/WebProcessProxy.cpp:
      (WebKit::WebProcessProxy::didReceiveMessage): Forward messages for notification manager to the context.
      
      * WebProcess/WebCoreSupport/WebChromeClient.cpp: Remove notificationPresenter().
      * WebProcess/WebCoreSupport/WebChromeClient.h: Remove notificationPresenter().
      
      * WebProcess/WebCoreSupport/WebNotificationClient.h: Added. Forwards client methods to manager.
      * WebProcess/WebCoreSupport/WebNotificationClient.cpp: Added. Mostly stub implementation for now.
      (WebKit::WebNotificationClient::WebNotificationClient):
      (WebKit::WebNotificationClient::~WebNotificationClient):
      (WebKit::WebNotificationClient::show):
      (WebKit::WebNotificationClient::cancel):
      (WebKit::WebNotificationClient::notificationObjectDestroyed):
      (WebKit::WebNotificationClient::requestPermission):
      (WebKit::WebNotificationClient::cancelRequestsForPermission):
      (WebKit::WebNotificationClient::checkPermission):
      
      * WebProcess/WebPage/WebPage.h: Added WebNotificationClient as one of its page clients.
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::WebPage): Set the notification client to WebNotificationClient.
      * WebProcess/WebProcess.h: Added WebNotificationManager.
      (WebKit::WebProcess::notificationManager):
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::WebProcess): Initialize notificaton manager.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@101307 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c095456
  37. 15 Nov, 2011 2 commits
    • andersca@apple.com's avatar
      HostWindow screenToWindow/windowToScreen should be screenToRootView/rootViewToScreen · e8d18173
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=72397
      
      Reviewed by Dan Bernstein.
      
      Source/WebCore:
      
      screenToWindow and windowToScreen already use root view coordinates everywhere, with the
      exception of Mac WebKit1 which doesn't even implement the functions.
      
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (-[WebAccessibilityObjectWrapper position]):
      * loader/EmptyClients.h:
      * page/Chrome.cpp:
      (WebCore::Chrome::screenToRootView):
      (WebCore::Chrome::rootViewToScreen):
      * page/Chrome.h:
      * page/ChromeClient.h:
      * platform/HostWindow.h:
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::contentsToScreen):
      (WebCore::ScrollView::screenToContents):
      * platform/chromium/PopupContainer.cpp:
      (WebCore::PopupContainer::layoutAndCalculateWidgetRect):
      (WebCore::PopupContainer::refresh):
      
      Source/WebKit/chromium:
      
      * src/ChromeClientImpl.cpp:
      (WebKit::ChromeClientImpl::screenToRootView):
      (WebKit::ChromeClientImpl::rootViewToScreen):
      * src/ChromeClientImpl.h:
      * src/WebPopupMenuImpl.cpp:
      (WebKit::WebPopupMenuImpl::screenToRootView):
      (WebKit::WebPopupMenuImpl::rootViewToScreen):
      * src/WebPopupMenuImpl.h:
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::refreshAutofillPopup):
      
      Source/WebKit/efl:
      
      * WebCoreSupport/ChromeClientEfl.cpp:
      (WebCore::ChromeClientEfl::rootViewToScreen):
      (WebCore::ChromeClientEfl::screenToRootView):
      * WebCoreSupport/ChromeClientEfl.h:
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::rootViewToScreen):
      (WebKit::ChromeClient::screenToRootView):
      * WebCoreSupport/ChromeClientGtk.h:
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebChromeClient.h:
      * WebCoreSupport/WebChromeClient.mm:
      (WebChromeClient::screenToRootView):
      (WebChromeClient::rootViewToScreen):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::rootViewToScreen):
      (WebCore::ChromeClientQt::screenToRootView):
      * WebCoreSupport/ChromeClientQt.h:
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebChromeClient.cpp:
      (WebChromeClient::rootViewToScreen):
      (WebChromeClient::screenToRootView):
      * WebCoreSupport/WebChromeClient.h:
      
      Source/WebKit/wince:
      
      * WebCoreSupport/ChromeClientWinCE.cpp:
      (WebKit::ChromeClientWinCE::rootViewToScreen):
      (WebKit::ChromeClientWinCE::screenToRootView):
      * WebCoreSupport/ChromeClientWinCE.h:
      
      Source/WebKit/wx:
      
      * WebKitSupport/ChromeClientWx.cpp:
      (WebCore::ChromeClientWx::rootViewToScreen):
      (WebCore::ChromeClientWx::screenToRootView):
      * WebKitSupport/ChromeClientWx.h:
      
      Source/WebKit2:
      
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::screenToRootView):
      (WebKit::WebChromeClient::rootViewToScreen):
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100309 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8d18173
    • andersca@apple.com's avatar
      HostWindow invalidation functions should use root view coordinates · fdd25eb3
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=72338
      
      Reviewed by Dan Bernstein.
      
      Source/WebCore:
      
      Rename invalidateWindow to invalidateRootView, and invalidateContentsAndWindow
      to invalidateContentsAndRootView. Make sure that the rects passed to the renamed functions
      are in root view coordinates by changing contentsToWindow calls to contentsToRootView.
      
      In practice this doesn't matter because for all platforms except Mac WebKit1, root view coordinates
      and window coordinates are equivalent, and Mac WebKit1 doesn't use these invalidation functions.
      
      * loader/EmptyClients.h:
      * page/Chrome.cpp:
      (WebCore::Chrome::invalidateRootView):
      (WebCore::Chrome::invalidateContentsAndRootView):
      * page/Chrome.h:
      * page/ChromeClient.h:
      * page/Frame.cpp:
      (WebCore::Frame::tiledBackingStorePaintEnd):
      * page/FrameView.cpp:
      (WebCore::FrameView::invalidateRect):
      (WebCore::FrameView::scrollContentsFastPath):
      * platform/HostWindow.h:
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::rectToCopyOnScroll):
      (WebCore::ScrollView::scrollContents):
      (WebCore::ScrollView::wheelEvent):
      * platform/chromium/FramelessScrollView.cpp:
      (WebCore::FramelessScrollView::invalidateRect):
      * svg/graphics/SVGImage.cpp:
      (WebCore::SVGImageChromeClient::invalidateContentsAndRootView):
      
      Source/WebKit/chromium:
      
      * src/ChromeClientImpl.cpp:
      (WebKit::ChromeClientImpl::invalidateRootView):
      (WebKit::ChromeClientImpl::invalidateContentsAndRootView):
      (WebKit::ChromeClientImpl::invalidateContentsForSlowScroll):
      * src/ChromeClientImpl.h:
      * src/WebPopupMenuImpl.cpp:
      (WebKit::WebPopupMenuImpl::invalidateRootView):
      (WebKit::WebPopupMenuImpl::invalidateContentsAndRootView):
      (WebKit::WebPopupMenuImpl::invalidateContentsForSlowScroll):
      * src/WebPopupMenuImpl.h:
      
      Source/WebKit/efl:
      
      * WebCoreSupport/ChromeClientEfl.cpp:
      (WebCore::ChromeClientEfl::invalidateRootView):
      (WebCore::ChromeClientEfl::invalidateContentsAndRootView):
      (WebCore::ChromeClientEfl::invalidateContentsForSlowScroll):
      * WebCoreSupport/ChromeClientEfl.h:
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::invalidateRootView):
      (WebKit::ChromeClient::invalidateContentsAndRootView):
      (WebKit::ChromeClient::invalidateContentsForSlowScroll):
      * WebCoreSupport/ChromeClientGtk.h:
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebChromeClient.h:
      * WebCoreSupport/WebChromeClient.mm:
      (WebChromeClient::invalidateRootView):
      (WebChromeClient::invalidateContentsAndRootView):
      (WebChromeClient::invalidateContentsForSlowScroll):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::invalidateRootView):
      (WebCore::ChromeClientQt::invalidateContentsAndRootView):
      (WebCore::ChromeClientQt::invalidateContentsForSlowScroll):
      * WebCoreSupport/ChromeClientQt.h:
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebChromeClient.cpp:
      (WebChromeClient::invalidateRootView):
      (WebChromeClient::invalidateContentsAndRootView):
      * WebCoreSupport/WebChromeClient.h:
      
      Source/WebKit/wince:
      
      * WebCoreSupport/ChromeClientWinCE.cpp:
      (WebKit::ChromeClientWinCE::invalidateRootView):
      (WebKit::ChromeClientWinCE::invalidateContentsAndRootView):
      (WebKit::ChromeClientWinCE::invalidateContentsForSlowScroll):
      (WebKit::ChromeClientWinCE::scroll):
      * WebCoreSupport/ChromeClientWinCE.h:
      
      Source/WebKit/wx:
      
      * WebKitSupport/ChromeClientWx.cpp:
      (WebCore::ChromeClientWx::invalidateRootView):
      (WebCore::ChromeClientWx::invalidateContentsForSlowScroll):
      (WebCore::ChromeClientWx::invalidateContentsAndRootView):
      * WebKitSupport/ChromeClientWx.h:
      
      Source/WebKit2:
      
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::invalidateRootView):
      (WebKit::WebChromeClient::invalidateContentsAndRootView):
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fdd25eb3
  38. 07 Nov, 2011 1 commit
    • keishi@webkit.org's avatar
      Change ColorChooser from singleton to ordinary object · 27f13639
      keishi@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=71644
      
      Reviewed by Kent Tamura.
      
      Source/WebCore:
      
      Changing WebCore::ColorChooser from a singleton to an ordinary object can broaden how browsers implement the color chooser interface.
      
      * WebCore.exp.in:
      * html/ColorInputType.cpp:
      (WebCore::ColorInputType::~ColorInputType):
      (WebCore::ColorInputType::setValue): If a chooser exists, calls Chrome::setSelectedColorInColorChooser
      (WebCore::ColorInputType::handleDOMActivateEvent):
      (WebCore::ColorInputType::detach):
      (WebCore::ColorInputType::didCleanup): Called after cleanup is complete.
      (WebCore::ColorInputType::cleanupColorChooser): Renamed from cleanupColorChooserIfCurrentClient.
      * html/ColorInputType.h:
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::selectColorInColorChooser):
      * html/HTMLInputElement.h:
      * loader/EmptyClients.h:
      (WebCore::EmptyChromeClient::cleanupColorChooser): Added colorChooser argument because there are many WebCore::ColorChoosers now.
      (WebCore::EmptyChromeClient::setSelectedColorInColorChooser): Ditto.
      * page/Chrome.cpp:
      (WebCore::Chrome::cleanupColorChooser): Added colorChooser argument because there are many WebCore::ColorChoosers now.
      (WebCore::Chrome::setSelectedColorInColorChooser): Ditto.
      * page/Chrome.h:
      * page/ChromeClient.h:
      * platform/ColorChooser.cpp:
      (WebCore::ColorChooserClient::~ColorChooserClient):
      (WebCore::ColorChooserClient::newColorChooser): Creates a new color chooser that is connected to itself.
      (WebCore::ColorChooserClient::discardChooser): Discards the connected color chooser.
      (WebCore::ColorChooser::ColorChooser): ColorChooser is RefCounted.
      (WebCore::ColorChooser::create): Creates a ColorChooser that is connected to the given ColorChooserClient.
      (WebCore::ColorChooser::~ColorChooser):
      (WebCore::ColorChooser::didChooseColor): Called from WebKit side when user chose a color. Calls ColorChooserClient::didChooseColor
      (WebCore::ColorChooser::didCleanup): Called from WebKit side when user color chooser was cleaned up. Calls ColorChooserClient::didCleanup
      * platform/ColorChooser.h:
      (WebCore::ColorChooserClient::chooser): Returns the current ColorChooser.
      (WebCore::ColorChooser::disconnectClient): Disconnects the ColorChooserClient.
      * testing/Internals.cpp:
      (WebCore::Internals::selectColorInColorChooser): Added element argument. This calls didChooseColor on the ColorChooser of that element.
      * testing/Internals.h:
      * testing/Internals.idl: Removed connectColorChooserClient and updated selectColorInColorChooser.
      
      LayoutTests:
      
      * fast/forms/color/input-color-onchange-event.html: Changed to match the changes to window.internals object
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99403 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27f13639
  39. 26 Oct, 2011 1 commit
    • hausmann@webkit.org's avatar
      Name viewport change event consistently. · 69d44f08
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=70901
      
      Patch by Zalan Bujtas <zbujtas@gmail.com> on 2011-10-26
      Reviewed by Kenneth Rohde Christiansen.
      
      Source/WebCore:
      
      Use ViewportPropertiesDidChange term consistently throughout WebKit.
      
      No tests needed as the change is only method renaming.
      
      * page/Chrome.cpp:
      (WebCore::Chrome::dispatchViewportPropertiesDidChange):
      * page/Chrome.h:
      * page/ChromeClient.h:
      (WebCore::ChromeClient::dispatchViewportPropertiesDidChange):
      * page/Page.cpp:
      (WebCore::Page::updateViewportArguments):
      
      Source/WebKit/efl:
      
      Use ViewportPropertiesDidChange term consistently throughout WebKit.
      
      * WebCoreSupport/ChromeClientEfl.cpp:
      (WebCore::ChromeClientEfl::dispatchViewportPropertiesDidChange):
      * WebCoreSupport/ChromeClientEfl.h:
      
      Source/WebKit/gtk:
      
      Use ViewportPropertiesDidChange term consistently throughout WebKit.
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::dispatchViewportPropertiesDidChange):
      * WebCoreSupport/ChromeClientGtk.h:
      
      Source/WebKit/qt:
      
      Use ViewportPropertiesDidChange term consistently throughout WebKit.
      
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::dispatchViewportPropertiesDidChange):
      * WebCoreSupport/ChromeClientQt.h:
      
      Source/WebKit2:
      
      Use ViewportPropertiesDidChange term consistently throughout WebKit.
      
      * UIProcess/API/efl/PageClientImpl.cpp:
      (WebKit::PageClientImpl::didChangeViewportProperties):
      * UIProcess/API/efl/PageClientImpl.h:
      * UIProcess/API/gtk/PageClientImpl.cpp:
      (WebKit::PageClientImpl::didChangeViewportProperties):
      * UIProcess/API/gtk/PageClientImpl.h:
      * UIProcess/API/mac/PageClientImpl.h:
      * UIProcess/API/mac/PageClientImpl.mm:
      (WebKit::PageClientImpl::didChangeViewportProperties):
      * UIProcess/API/qt/qdesktopwebview.cpp:
      (QDesktopWebViewPrivate::didChangeViewportProperties):
      * UIProcess/API/qt/qdesktopwebview_p.h:
      * UIProcess/API/qt/qtouchwebview.cpp:
      (QTouchWebViewPrivate::didChangeViewportProperties):
      * UIProcess/API/qt/qtouchwebview_p.h:
      * UIProcess/PageClient.h:
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::didChangeViewportProperties):
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebPageProxy.messages.in:
      * UIProcess/qt/QtDesktopWebPageProxy.cpp:
      (QtDesktopWebPageProxy::didChangeViewportProperties):
      * UIProcess/qt/QtDesktopWebPageProxy.h:
      * UIProcess/qt/QtTouchViewInterface.cpp:
      (WebKit::QtTouchViewInterface::didChangeViewportProperties):
      * UIProcess/qt/QtTouchViewInterface.h:
      * UIProcess/qt/QtViewInterface.h:
      * UIProcess/qt/QtWebPageProxy.cpp:
      (QtWebPageProxy::didChangeViewportProperties):
      * UIProcess/qt/QtWebPageProxy.h:
      * UIProcess/win/WebView.cpp:
      (WebKit::WebView::didChangeViewportProperties):
      * UIProcess/win/WebView.h:
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::dispatchViewportPropertiesDidChange):
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98472 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69d44f08