1. 08 Jan, 2011 1 commit
  2. 01 Nov, 2003 1 commit
  3. 25 Oct, 2003 1 commit
  4. 24 Oct, 2003 3 commits
    • rjw's avatar
      WebKit: · 6c9e308a
      rjw authored
      	Fixed 3425358.  Don't try to create page cache for pages that
      	have a nil view().
      
              Reviewed by Hyatt.
      
              * WebView.subproj/WebFrame.m:
              (-[WebFrame _createPageCacheForItem:]):
              (-[WebFrame _setState:]):
      
      WebCore:
      	Fixed 3425358.  Don't try to create page cache for pages that
      	have a nil view().
      
              Reviewed by Hyatt.
      
              * kwq/WebCoreBridge.mm:
              (-[WebCoreBridge saveDocumentToPageCache]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5258 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c9e308a
    • hyatt's avatar
      Fix for 3133375, the minwidth computation for pres is wrong. There were a couple of bugs here. · 9a78b274
      hyatt authored
      	One is that pres only should have a breakable character if they contain a newline.  Otherwise they're
      	treated essentially like nowrap.  The other was that m_beginMinWidth and m_endMinWidth needed to be
      	set to the maxwidth of the first line and the maxwidth of the last line respectively for pres instead of
      	being only the first and last words.
      
              Reviewed by mjs
      
              * khtml/rendering/render_text.cpp:
              (RenderText::calcMinMaxWidth):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5257 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a78b274
    • hyatt's avatar
      Two fixes to the computation of min/max width for text runs. · 1673bee7
      hyatt authored
      	(1) Make sure that pre runs don't add in word-spacing to the last word on a line (e.g., when a newline explicitly
      	breaks a pre).
      	(2) Fix a bug where breakable characters weren't getting factored into minwidth properly.  When a word got broken
      	because of a breakable character, we were treating the breakable character like a space, and not including its
      	width as part of the minimum width of the text run.
      
              Reviewed by john
      
              * khtml/rendering/render_text.cpp:
              (RenderText::calcMinMaxWidth):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5254 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1673bee7
  5. 23 Oct, 2003 6 commits
    • hyatt's avatar
      This patch fixes the pseudo-elements ::first-line and ::first-letter to... · d1a5a09d
      hyatt authored
      	This patch fixes the pseudo-elements ::first-line and ::first-letter to inherit styles properly.  More
      	specifically it does the following:
      
      	(1) Implements caching of pseudo-styles once computed off the style() which originated the pseudo-style.
      	The old code did this, and this was a regression from my previous patch.
      
      	(2) Fixes first-letter checking so that it happens at layout time rather than during render object
      	construction time, since that makes first-letter more dynamic and causes it to be discovered in cases
      	where it was being missed before.  This fixes the front page of meyerweb.com.
      
      	(3) Make first-letter inherit from first-line like it's supposed to, and also make first-line styles
      	cross blocks and inherit properly from enclosing containers.
      
      	(4) Make first-letter changes cause a detach/attach to fire just as when the display changes.  I generalized
      	the notion of needing to detach on a style change by making it a new kind of hint in dom_nodeimpl's style
      	diff function.
      
      	(5) Fixed isBlockFlow to return true for inline-blocks.
      
              Reviewed by john
      
              * khtml/rendering/render_block.cpp:
              (khtml::RenderBlock::addChildToFlow):
              (khtml::RenderBlock::layoutBlock):
              (khtml::RenderBlock::getFirstLineBox):
              (khtml::RenderBlock::firstLineBlock):
              (khtml::RenderBlock::updateFirstLetter):
              * khtml/rendering/render_block.h:
              (khtml::RenderBlock::isBlockFlow):
              * khtml/rendering/render_line.cpp:
              (InlineFlowBox::paintBackgroundAndBorder):
              * khtml/rendering/render_list.cpp:
              (RenderListItem::setStyle):
              * khtml/rendering/render_object.cpp:
              (RenderObject::RenderObject):
              (RenderObject::firstLineBlock):
              (RenderObject::updateFirstLetter):
              (RenderObject::dump):
              (RenderObject::setStyle):
              (RenderObject::recalcMinMaxWidths):
              (RenderObject::style):
              (RenderObject::getPseudoStyle):
              * khtml/rendering/render_object.h:
              (khtml::RenderObject::overhangingContents):
              * khtml/rendering/render_style.cpp:
              (pseudoBit):
              * khtml/rendering/render_style.h:
              (khtml::RenderStyle::):
              * khtml/rendering/render_table.cpp:
              (RenderTable::firstLineBlock):
              (RenderTable::updateFirstLetter):
              * khtml/rendering/render_table.h:
              * khtml/rendering/render_text.cpp:
              (RenderText::paintObject):
              (RenderText::htmlFont):
              * khtml/xml/dom_elementimpl.cpp:
              (ElementImpl::recalcStyle):
              * khtml/xml/dom_nodeimpl.cpp:
              (NodeImpl::diff):
              * khtml/xml/dom_nodeimpl.h:
              (DOM::NodeImpl::):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5249 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1a5a09d
    • kocienda's avatar
      Reviewed by David · 087b7da6
      kocienda authored
      	Fix for these bugs:
      
      	<rdar://problem/3171929>: Safari picks a different button in a
      	form when you hit return if the first button has no name
      	<rdar://problem/3200386>: investigate which button is activated
      	when hitting return in form text input fields
      
      	HTML spec says that buttons must have names to be considered
      	successful. However, other browsers do not impose this constraint.
      	Therefore, we behave differently, and can use different buttons than
      	the author intended.
      
              * khtml/html/html_formimpl.cpp:
              (HTMLButtonElementImpl::isSuccessfulSubmitButton)
              (HTMLInputElementImpl::isSuccessfulSubmitButton)
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5247 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      087b7da6
    • hyatt's avatar
      Fix for 3460726, the user agent string was returning nil. · b27b6d4a
      hyatt authored
      	Fix for 3386544, empty documents did not get a layout, and so they looked white.  Also fixed the positioning
      	of widgets to account for border/padding in updateWidgetPositions.
      
      	Fix for espn.com crasher, 3458143, caused by layout object not being properly cleared when layouts were
      	unscheduled.
      
              Reviewed by darin
      
              * khtml/khtmlview.cpp:
              * khtml/rendering/render_canvas.cpp:
              (RenderCanvas::RenderCanvas):
              * khtml/rendering/render_replaced.cpp:
              (RenderWidget::updateWidgetPositions):
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::userAgent):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5246 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b27b6d4a
    • mjs's avatar
      Reviewed by · 05242733
      mjs authored
      	- fixed 3460664 - Exception handlers not properly removed
      
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::mouseMoved): Don't return from exception block
              (KWQKHTMLPart::khtmlMouseReleaseEvent): Add exception blocking (whoops)
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5245 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05242733
    • sullivan's avatar
      - fixed 3460652 -- REGRESSION (100-110+): Can't tab out of a · 724f886e
      sullivan authored
      	frameset page
      
              Reviewed by Darin (actually he made the change on my machine)
      
              * khtml/html/html_baseimpl.cpp:
              (HTMLFrameSetElementImpl::defaultEventHandler):
      	only set defaultHandled for the one event that we actually
      	handle (mouse event to resize frame borders); this was always
      	being set, hence preventing key events from being used elsewhere.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5244 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      724f886e
    • rjw's avatar
      WebKit: · 9b3532d3
      rjw authored
      	Match WebCore's notion of distributing linegap between top and bottom of
      	line.  WebKit used to put it all at the bottom of the line.
      
              Reviewed by Hyatt.
      
              * WebCoreSupport.subproj/WebTextRenderer.h:
              * WebCoreSupport.subproj/WebTextRenderer.m:
              (-[WebTextRenderer initWithFont:usingPrinterFont:]):
              (-[WebTextRenderer _CG_drawHighlightForRun:style:atPoint:]):
      
      WebCore:
      	Fixed 3454067.  RenderText's repaint wasn't called because of recent changes to de-virtualize repaint.  Modified getAbsoluteRepaintRect() to return containing block's getAbsoluteRepaintRect().
      
      	Also removed the long standing +1 from QFontMetrics::height().
      
              Reviewed by Hyatt.
      
              * khtml/rendering/render_text.cpp:
              (RenderText::getAbsoluteRepaintRect):
              * khtml/rendering/render_text.h:
              * kwq/KWQFontMetrics.mm:
              (QFontMetrics::height):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5242 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b3532d3
  6. 22 Oct, 2003 3 commits
    • hyatt's avatar
      Fix visibility to be done when widgets are added or when styles are set... · 17968821
      hyatt authored
      	Fix visibility to be done when widgets are added or when styles are set rather than at paint time.  Fixes
      	the ads painting on top of content at tvguide.com.
      
              Reviewed by cblu
      
              * khtml/rendering/render_replaced.cpp:
              (RenderWidget::setQWidget):
              (RenderWidget::setStyle):
              (RenderWidget::paintObject):
              * kwq/KWQWidget.h:
              * kwq/KWQWidget.mm:
              (QWidget::QWidget):
              (QWidget::show):
              (QWidget::hide):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17968821
    • mjs's avatar
      WebCore: · 84725290
      mjs authored
              Reviewed by Dave.
      
      	Finished exception blocking changes, so now I can finally say:
      
      	- fixed 3137084 - Many non-reproducible crashers in ContextImp::mark / ScopeChain::mark
      	- fixed 3308848 - nil-deref in KHTMLView::topLevelWidget
      	- fixed 3311511 - nil deref inside KJS::Screen
      	- fixed 3397422 - 7B51: Safari crashed in KJS::ObjectImp::mark()
      	- fixed 3408373 - Panther7B58 : Safari Crashed in KJS::ObjectImp::mark
      	- fixed 3409307 - 7B55: safari crashed in KJS::Interpreter::globalExec() (idle, nothing particular going on)
      	- fixed 3410160 - 7B60 Safari crashed in KHTMLPart::parentPart called from JS while in the background
      	- fixed 3413224 - unrepro crash in KJS::Window::mark
      	- fixed 3419940 - unrepro crash in KJS::Collector::allocate trying to access http://www.lindyinthepalms.com
      	- fixed 3420123 - Panther7B66: Safari crashed while going to http://www.tangents.co.uk/index2.html
      	- fixed 3423225 - Safari crash in vtable for KWQMapImpl (vtable for KWQMapImpl + 8).
      	- fixed 3437190 - nil-deref on quit in calling marked() from ScopeChain::mark()
      
              * WebCore.pbproj/project.pbxproj:
              * kwq/KWQFontMetrics.mm:
              * kwq/KWQPainter.mm:
              (QPainter::drawPixmap):
              (QPainter::drawTiledPixmap):
              (QPainter::_updateRenderer):
              * kwq/WebCoreTextRenderer.h:
      
      WebKit:
      
              Reviewed by Dave.
      
      	Finished exception blocking changes, so now I can finally say:
      
      	- fixed 3137084 - Many non-reproducible crashers in ContextImp::mark / ScopeChain::mark
      	- fixed 3308848 - nil-deref in KHTMLView::topLevelWidget
      	- fixed 3311511 - nil deref inside KJS::Screen
      	- fixed 3397422 - 7B51: Safari crashed in KJS::ObjectImp::mark()
      	- fixed 3408373 - Panther7B58 : Safari Crashed in KJS::ObjectImp::mark
      	- fixed 3409307 - 7B55: safari crashed in KJS::Interpreter::globalExec() (idle, nothing particular going on)
      	- fixed 3410160 - 7B60 Safari crashed in KHTMLPart::parentPart called from JS while in the background
      	- fixed 3413224 - unrepro crash in KJS::Window::mark
      	- fixed 3419940 - unrepro crash in KJS::Collector::allocate trying to access http://www.lindyinthepalms.com
      	- fixed 3420123 - Panther7B66: Safari crashed while going to http://www.tangents.co.uk/index2.html
      	- fixed 3423225 - Safari crash in vtable for KWQMapImpl (vtable for KWQMapImpl + 8).
      	- fixed 3437190 - nil-deref on quit in calling marked() from ScopeChain::mark()
      
              * WebCoreSupport.subproj/WebTextRenderer.m:
              (-[WebTextRenderer ascent]):
              (-[WebTextRenderer descent]):
              (-[WebTextRenderer lineSpacing]):
              (-[WebTextRenderer xHeight]):
              (-[WebTextRenderer drawLineForCharacters:yOffset:withWidth:withColor:]):
              (-[WebTextRenderer _smallCapsRenderer]):
              (-[WebTextRenderer _initializeATSUStyle]):
              (-[WebTextRenderer _createATSUTextLayoutForRun:]):
              (-[WebTextRenderer _trapezoidForRun:style:atPoint:]):
              (-[WebTextRenderer _ATSU_drawHighlightForRun:style:atPoint:]):
              (-[WebTextRenderer _ATSU_drawRun:style:atPoint:]):
              (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84725290
    • hyatt's avatar
      http://placenamehere.com/safari/fixedbgtest.html is now fixed with a patch from the KHTML trunk. · 84d840bc
      hyatt authored
      	Fixed backgrounds repeated when they weren't supposed to.
      
              * khtml/rendering/render_box.cpp:
              (RenderBox::paintBackgroundExtended):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84d840bc
  7. 21 Oct, 2003 3 commits
    • hyatt's avatar
      Change pseudo-element style resolution to be lazy and to not occur until the... · 9055e44f
      hyatt authored
      	Change pseudo-element style resolution to be lazy and to not occur until the style is actually asked
      	for by the front end render objects.  Also fix first-letter to inherit properly from first-line styles.
      
              Reviewed by mjs
      
              * khtml/css/cssstyleselector.cpp:
              (khtml::CSSStyleSelector::initForStyleResolve):
              (khtml::CSSStyleSelector::styleForElement):
              (khtml::CSSStyleSelector::pseudoStyleForElement):
              (khtml::CSSStyleSelector::checkSelector):
              (khtml::CSSStyleSelector::checkOneSelector):
              * khtml/css/cssstyleselector.h:
              * khtml/rendering/render_block.cpp:
              (khtml::RenderBlock::addChildToFlow):
              * khtml/rendering/render_container.cpp:
              (RenderContainer::updatePseudoChild):
              * khtml/rendering/render_object.cpp:
              (RenderObject::setStyle):
              (RenderObject::createInlineBox):
              (RenderObject::style):
              (RenderObject::getPseudoStyle):
              * khtml/rendering/render_object.h:
              * khtml/rendering/render_style.cpp:
              (pseudoBit):
              (RenderStyle::hasPseudoStyle):
              (RenderStyle::setHasPseudoStyle):
              (RenderStyle::getPseudoStyle):
              (RenderStyle::addPseudoStyle):
              * khtml/rendering/render_style.h:
              (khtml::RenderStyle::NonInheritedFlags::operator==):
              (khtml::RenderStyle::setBitDefaults):
              * khtml/rendering/render_text.cpp:
              (InlineTextBox::paintSelection):
              (RenderText::paintObject):
              (RenderText::htmlFont):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5234 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9055e44f
    • mjs's avatar
      Reviewed by Dave. · f4a19099
      mjs authored
      	More exception blocking.
      
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::~KWQKHTMLPart):
              (KWQKHTMLPart::generateFrameName):
              (KWQKHTMLPart::openURL):
              (KWQKHTMLPart::openURLRequest):
              (regExpForLabels):
              (KWQKHTMLPart::clearRecordedFormValues):
              (KWQKHTMLPart::recordFormValue):
              (KWQKHTMLPart::submitForm):
              (KHTMLPart::frameDetached):
              (KWQKHTMLPart::urlSelected):
              (KWQKHTMLPart::createPart):
              (KWQKHTMLPart::setTitle):
              (KWQKHTMLPart::setStatusBarText):
              (KWQKHTMLPart::scheduleClose):
              (KWQKHTMLPart::unfocusWindow):
              (KWQKHTMLPart::jumpToSelection):
              (KWQKHTMLPart::redirectionTimerStartedOrStopped):
              (KWQKHTMLPart::userAgent):
              (KWQKHTMLPart::mimeTypeForFileName):
              (KWQKHTMLPart::nextKeyView):
              (KWQKHTMLPart::currentEventIsMouseDownInWidget):
              (KWQKHTMLPart::openURLFromPageCache):
              (KWQKHTMLPart::saveDocumentState):
              (KWQKHTMLPart::restoreDocumentState):
              (KWQKHTMLPart::requestedURLString):
              (KWQKHTMLPart::incomingReferrer):
              (KWQKHTMLPart::runJavaScriptAlert):
              (KWQKHTMLPart::runJavaScriptConfirm):
              (KWQKHTMLPart::runJavaScriptPrompt):
              (KWQKHTMLPart::createEmptyDocument):
              (KWQKHTMLPart::keyEvent):
              (KWQKHTMLPart::khtmlMousePressEvent):
              (KWQKHTMLPart::passWidgetMouseDownEventToWidget):
              (KWQKHTMLPart::lastEventIsMouseUp):
              (findViewInSubviews):
              (KWQKHTMLPart::khtmlMouseMoveEvent):
              (KWQKHTMLPart::passSubframeEventToSubframe):
              (KWQKHTMLPart::buttonForCurrentEvent):
              (KWQKHTMLPart::stateForCurrentEvent):
              (KWQKHTMLPart::mouseDown):
              (KWQKHTMLPart::mouseDragged):
              (KWQKHTMLPart::mouseUp):
              (KWQKHTMLPart::sendFakeEventsAfterWidgetTracking):
              (KWQKHTMLPart::mouseMoved):
              (KWQKHTMLPart::sendContextMenuEvent):
              (fileWrapperForElement):
              (KWQKHTMLPart::attributedString):
              (KWQKHTMLPart::keyboardUIMode):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5233 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f4a19099
    • cblu's avatar
      WebCore: · 9c6e4c4b
      cblu authored
      	Fixed: <rdar://problem/3176170>: OBJECT tag with no or empty TYPE is mishandled
      
              Reviewed by rjw.
      
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::createPart): call renamed frameRequiredForMIMEType:URL:
              * kwq/WebCoreBridge.h: renamed frameRequiredForMIMEType: to frameRequiredForMIMEType:URL:
      
      WebKit:
      
      	Fixed: <rdar://problem/3176170>: OBJECT tag with no or empty TYPE is mishandled
      
              Reviewed by rjw.
      
              * Plugins.subproj/WebPluginDatabase.m:
              (-[WebPluginDatabase pluginForExtension:]): If no plug-in is found from the extension, attempt to map from the extension to a MIME type using our mappings and find a plug-in from the MIME type. This improves our chances of finding a plug-in when no MIME type is specified.
              * WebCoreSupport.subproj/WebBridge.m:
      	(-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]): If the passed MIME is empty, nil it out so that clients only need to check for nil. This avoids error sheets complaining about "" MIME types.
              (-[WebBridge frameRequiredForMIMEType:URL:]): Renamed to include URL. If no MIME is specified, only create a plug-in view if we can map from the extension.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c6e4c4b
  8. 20 Oct, 2003 7 commits
    • hyatt's avatar
      Fix generated content (before/after) so that it no longer has any... · 52fa1ca7
      hyatt authored
      	Fix generated content (before/after) so that it no longer has any restrictions on it.   CSS2.1 lifted
      	restrictions preventing the floating/positioning of generated content.
      
              Reviewed by rjw
      
              * khtml/css/cssstyleselector.cpp:
              (khtml::CSSStyleSelector::adjustRenderStyle):
              * khtml/rendering/render_container.cpp:
              (RenderContainer::updatePseudoChild):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5228 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52fa1ca7
    • kocienda's avatar
      Reviewed by David · 31d51f98
      kocienda authored
              * khtml/dom/dom2_events.cpp:
              (UIEvent::keyCode): Change over to use ascii value for key code.
              (UIEvent::which): Ditto.
              (KeyboardEvent::KeyboardEvent): New key event class which
      	tracks the DOM Level 3 spec more closely.
              (KeyboardEvent::operator = ): New function.
              (KeyboardEvent::~KeyboardEvent): New function.
              (KeyboardEvent::ctrlKey): New function.
              (KeyboardEvent::shiftKey): New function.
              (KeyboardEvent::altKey): New function.
              (KeyboardEvent::metaKey): New function.
              (KeyboardEvent::altGraphKey): New function.
              (KeyboardEvent::initKeyboardEvent): New function.
              * khtml/dom/dom2_events.h: Ditto.
              * khtml/html/html_formimpl.cpp:
              (HTMLGenericFormElementImpl::defaultEventHandler): Use key
      	identifiers to test which key was pressed, instead of removed keyVal().
              (HTMLInputElementImpl::defaultEventHandler): Ditto.
              (HTMLSelectElementImpl::defaultEventHandler): Ditto.
              * khtml/html/html_inlineimpl.cpp:
              (HTMLAnchorElementImpl::defaultEventHandler): Change casts to match new
      	class name. Use key identifiers to test which key was pressed,
      	instead of removed keyVal(). Use new modifier accessors.
              * khtml/xml/dom2_eventsimpl.cpp:
              (EventImpl::typeToId): Some reorganization of the constants in the
      	switch statements. Name change for these to remove the KHTML_ prefix
      	from the key up and key down events will happen soon.
              (EventImpl::idToType): Ditto.
              (KeyboardEventImpl::KeyboardEventImpl): New key event class which
              tracks the DOM Level 3 spec more closely.
              (KeyboardEventImpl::~KeyboardEventImpl): Ditto.
              (KeyboardEventImpl::initKeyboardEvent): Ditto.
              * khtml/xml/dom2_eventsimpl.h:
              (DOM::EventImpl::): Some reorganization of the constants in the
              switch statements. Name change for these to remove the KHTML_ prefix
              from the key up and key down events will happen soon.
              (DOM::KeyboardEventImpl::keyIdentifier): New function.
              (DOM::KeyboardEventImpl::keyLocation): New function.
              (DOM::KeyboardEventImpl::ctrlKey): New function.
              (DOM::KeyboardEventImpl::shiftKey): New function.
              (DOM::KeyboardEventImpl::altKey): New function.
              (DOM::KeyboardEventImpl::metaKey): New function.
              (DOM::KeyboardEventImpl::altGraphKey): New function.
              (DOM::KeyboardEventImpl::qKeyEvent): New function.
              * khtml/xml/dom_docimpl.cpp:
              (DocumentImpl::createEvent): Now can create keyboard events.
              * khtml/xml/dom_nodeimpl.cpp:
              (NodeImpl::dispatchKeyEvent): Class name changes.
              * kwq/KWQEvent.h: Added QString identifier member.
              * kwq/KWQEvent.mm:
              (hexDigit): Added helper.
              (identifierForKeyText): Added new function to map keys to DOM
      	key identifiers as listed in the DOM spec.
              (QKeyEvent::identifier): Added accessor.
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::stateForCurrentEvent): Added check to see if
      	a key press is on one of the numeric keypad keys.
              * kwq/KWQLogging.h: Added log constant for DOM events.
              * kwq/KWQLogging.m: Ditto
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5226 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31d51f98
    • hyatt's avatar
      Make first-letter and before/after work with text transforms. · 5271ab1e
      hyatt authored
              Reviewed by mjs
      
              * khtml/rendering/render_block.cpp:
              (khtml::RenderBlock::addChildToFlow):
              * khtml/rendering/render_container.cpp:
              (RenderContainer::updatePseudoChild):
              * khtml/rendering/render_text.cpp:
              (RenderText::setStyle):
              (RenderText::isTextFragment):
              (RenderText::originalString):
              (RenderText::setText):
              (m_generatedContentStr):
              (m_start):
              (RenderTextFragment::~RenderTextFragment):
              (RenderTextFragment::isTextFragment):
              (RenderTextFragment::originalString):
              * khtml/rendering/render_text.h:
              (khtml::RenderTextFragment::start):
              (khtml::RenderTextFragment::end):
              (khtml::RenderTextFragment::contentString):
              * khtml/xml/dom_nodeimpl.h:
              (DOM::NodeImpl::setRenderer):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5222 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5271ab1e
    • hyatt's avatar
      Remove the "flow-around-floats" hack for lists. Other browsers don't do this. · 3ec35f18
      hyatt authored
              Reviewed by darin
      
              * khtml/css/quirks.css:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5220 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ec35f18
    • hyatt's avatar
      Fix for a regression/crash on tivocommunity.com caused by faulty... · 89358fc4
      hyatt authored
      	Fix for a regression/crash on tivocommunity.com caused by faulty border-collapse code in the collapsedRightBorder
      	case.  I forgot to deal with colspans.
      
              Reviewed by darin
      
              * khtml/rendering/render_table.cpp:
              (RenderTable::cellRight):
              (RenderTableCell::collapsedRightBorder):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5219 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89358fc4
    • hyatt's avatar
      Patch from KHTML trunk that makes textareas work properly even when they have no render objects. · 49b9a275
      hyatt authored
              * khtml/html/html_formimpl.cpp:
              (HTMLTextAreaElementImpl::encoding):
              (HTMLTextAreaElementImpl::value):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5218 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49b9a275
    • darin's avatar
      Reviewed by Maciej. · 674d2c4f
      darin authored
              - fixed 3454444 -- contents of mailto form shows up in Mail title instead of body (IE sends mail directly)
      
              * kwq/KWQKURL.mm: (KURL::parse): Changed non-hierarchical code to consider everything
              after a question mark as a query, just the way the hierarchical code does. This makes
              the code that constructs the mailto URL work properly.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5217 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      674d2c4f
  9. 19 Oct, 2003 1 commit
  10. 18 Oct, 2003 4 commits
  11. 17 Oct, 2003 3 commits
    • darin's avatar
      Reviewed by Maciej. · 5c443f8d
      darin authored
              - make text areas set the base writing direction based on the direction in the CSS style
      
              * kwq/KWQTextArea.h: Added setBaseWritingDirection method.
              * kwq/KWQTextArea.mm:
              (-[KWQTextArea _createTextView]): Use _KWQ_setTypingParagraphStyle.
              (-[KWQTextArea setWordWrap:]): Use _KWQ_setTypingParagraphStyle.
              (-[KWQTextArea setBaseWritingDirection:]): Added. New method that sets the base writing
              direction in both the style of the text and the typing attributes.
              (-[NSTextView _KWQ_typingParagraphStyle]): Added. Helper method to make setBaseWritingDirection:
              a little less gigantic.
              (-[NSTextView _KWQ_setTypingParagraphStyle:]): Ditto.
              (-[NSTextStorage _KWQ_setBaseWritingDirection:]): Ditto.
      
              * kwq/KWQTextEdit.mm: (QTextEdit::setAlignment): Set both alignment and base writing direction.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5203 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c443f8d
    • hyatt's avatar
      Implement horizontal and vertical border-spacing. Allow them to be specified individually. · fba5dc1b
      hyatt authored
              Reviewed by mjs
      
      	------
      
      	Fix the calcWidth method of tables to account for horizontal margins properly.
      
      	Reviewed by john
      
      	------
      
      	Implement border collapsing in tables.
      
      	Reviewed by kocienda
      
              * khtml/css/cssparser.cpp:
              (CSSParser::parseValue):
              * khtml/css/cssproperties.c:
              (hash_prop):
              (findProp):
              * khtml/css/cssproperties.h:
              * khtml/css/cssproperties.in:
              * khtml/css/cssstyleselector.cpp:
              (khtml::CSSStyleSelector::applyRule):
              * khtml/css/cssvalues.c:
              * khtml/css/cssvalues.h:
              * khtml/css/cssvalues.in:
              * khtml/rendering/bidi.cpp:
              (khtml::RenderBlock::layoutInlineChildren):
              * khtml/rendering/render_box.cpp:
              (RenderBox::paintBoxDecorations):
              * khtml/rendering/render_form.cpp:
              (RenderFieldset::paintBorderMinusLegend):
              * khtml/rendering/render_object.cpp:
              (RenderObject::paintBorder):
              (RenderObject::collectBorders):
              * khtml/rendering/render_object.h:
              * khtml/rendering/render_style.cpp:
              (StyleInheritedData::StyleInheritedData):
              (StyleInheritedData::operator==):
              (RenderStyle::diff):
              * khtml/rendering/render_style.h:
              (khtml::):
              (khtml::CollapsedBorderValue::precedence):
              (khtml::CollapsedBorderValue::width):
              (khtml::CollapsedBorderValue::style):
              (khtml::CollapsedBorderValue::exists):
              (khtml::CollapsedBorderValue::color):
              (khtml::CollapsedBorderValue::isTransparent):
              (khtml::CollapsedBorderValue::operator==):
              (khtml::RenderStyle::borderLeft):
              (khtml::RenderStyle::borderRight):
              (khtml::RenderStyle::borderTop):
              (khtml::RenderStyle::borderBottom):
              (khtml::RenderStyle::horizontalBorderSpacing):
              (khtml::RenderStyle::verticalBorderSpacing):
              (khtml::RenderStyle::setHorizontalBorderSpacing):
              (khtml::RenderStyle::setVerticalBorderSpacing):
              * khtml/rendering/render_table.cpp:
              (RenderTable::RenderTable):
              (RenderTable::setStyle):
              (RenderTable::calcWidth):
              (RenderTable::paint):
              (RenderTable::borderLeft):
              (RenderTable::borderRight):
              (RenderTable::borderTop):
              (RenderTable::borderBottom):
              (RenderTable::cellAbove):
              (RenderTable::cellBelow):
              (RenderTable::cellLeft):
              (RenderTable::cellRight):
              (RenderTableSection::setCellWidths):
              (RenderTableSection::calcRowHeight):
              (RenderTableSection::layoutRows):
              (compareBorders):
              (RenderTableCell::collapsedLeftBorder):
              (RenderTableCell::collapsedRightBorder):
              (RenderTableCell::collapsedTopBorder):
              (RenderTableCell::collapsedBottomBorder):
              (RenderTableCell::borderLeft):
              (RenderTableCell::borderRight):
              (RenderTableCell::borderTop):
              (RenderTableCell::borderBottom):
              (collapsedBorderStyle):
              (CollapsedBorder::CollapsedBorder):
              (CollapsedBorders:::count):
              (CollapsedBorders::addBorder):
              (CollapsedBorders::nextBorder):
              (addBorderStyle):
              (RenderTableCell::collectBorders):
              (RenderTableCell::paintCollapsedBorder):
              (RenderTableCell::paintObject):
              (RenderTableCell::paintBoxDecorations):
              * khtml/rendering/render_table.h:
              (khtml::RenderTable::hBorderSpacing):
              (khtml::RenderTable::vBorderSpacing):
              (khtml::RenderTable::bordersPaddingAndSpacing):
              (khtml::RenderTable::currentBorderStyle):
              * khtml/rendering/table_layout.cpp:
              (FixedTableLayout::layout):
              (AutoTableLayout::calcEffectiveWidth):
              (AutoTableLayout::layout):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fba5dc1b
    • mjs's avatar
      Reviewed by John. · d4a85535
      mjs authored
      	More exception blocking.
      
              * kwq/KWQFont.mm:
              (QFont::isFixedPitch):
              (QFont::getNSFont):
              * kwq/KWQKJobClasses.mm:
              (KIO::TransferJob::~TransferJob):
              * kwq/KWQLoader.mm:
              (KWQServeRequest):
              (KWQCheckIfReloading):
              (KWQCheckCacheObjectStatus):
              (KWQRetainResponse):
              (KWQReleaseResponse):
              (KWQResponseMIMEType):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5199 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4a85535
  12. 16 Oct, 2003 5 commits
  13. 15 Oct, 2003 2 commits
    • darin's avatar
      Reviewed by Ken. · 405f9894
      darin authored
              - change "volatile X * volatile" to "X * volatile" in cases where the
                pointer needs to be volatile but the object pointed to do does not
      
              * kwq/KWQKConfigBase.mm: (KConfig::readEntry):
              * kwq/KWQKCursor.mm: (+[NSCursor _WebCore_cursorWithName:hotSpot:]):
              * kwq/KWQKLocale.mm:
              (inputElementAltText):
              (resetButtonDefaultLabel):
              (searchableIndexIntroduction):
              (submitButtonDefaultLabel):
              (KLocale::language):
              * kwq/KWQLineEdit.mm: (QLineEdit::text):
              * kwq/KWQScrollView.mm:
              (QScrollView::setContentsPos):
              (QScrollView::addChild):
              (QScrollView::updateContents):
              (QScrollView::contentsToViewport):
              (QScrollView::viewportToContents):
              (QScrollView::getDocumentView):
              * kwq/KWQTextEdit.mm:
              (QTextEdit::text):
              (QTextEdit::textWithHardLineBreaks):
              * kwq/KWQWidget.mm: (QWidget::getOuterView):
              Removed the excess volatiles and excess casts that go with them.
      
              * kwq/KWQKCookieJar.mm: (KWQKCookieJar::cookie): Do the same, but also
              remove an unnecessary nil check that is the same as QString::fromNSString's
              default behavior.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5186 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      405f9894
    • mjs's avatar
      Reviewed by Dave. · 6f8cdd6f
      mjs authored
      	More objc-exception-blocking excitement.
      
              * kwq/KWQKConfigBase.mm:
              (KConfig::readEntry):
              (KConfig::readNumEntry):
              (RefreshPlugins):
              * kwq/KWQKCursor.mm:
              (+[NSCursor _WebCore_cursorWithName:hotSpot:]):
              * kwq/KWQKJavaAppletWidget.mm:
              (KJavaAppletWidget::showApplet):
              * kwq/KWQKLocale.mm:
              (inputElementAltText):
              (resetButtonDefaultLabel):
              (searchableIndexIntroduction):
              (submitButtonDefaultLabel):
              (KLocale::language):
              * kwq/KWQRegion.mm:
              (QRegion::QRegion):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@5185 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f8cdd6f