1. 11 Jun, 2012 1 commit
    • rniwa@webkit.org's avatar
      Use testRunner instead of layoutTestController in animations tests · ad35b686
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88757
      
      Reviewed by Tony Chang.
      
      * animations/3d/change-transform-in-end-event.html:
      * animations/3d/replace-filling-transform.html:
      * animations/3d/state-at-end-event-transform.html:
      * animations/3d/transform-origin-vs-functions.html:
      * animations/animation-add-events-in-handler.html:
      * animations/animation-border-overflow.html:
      * animations/animation-controller-drt-api.html:
      * animations/animation-direction-reverse-fill-mode-hardware.html:
      * animations/animation-direction-reverse-fill-mode.html:
      * animations/animation-drt-api-multiple-keyframes.html:
      * animations/animation-drt-api.html:
      * animations/animation-end-event-destroy-renderer.html:
      * animations/animation-end-event-short-iterations.html:
      * animations/animation-hit-test-transform.html:
      * animations/animation-hit-test.html:
      * animations/animation-iteration-event-destroy-renderer.html:
      * animations/animation-matrix-negative-scale-unmatrix.html:
      * animations/animation-on-inline-crash.html:
      * animations/animation-shorthand-overriding.html:
      * animations/animation-shorthand-removed.html:
      * animations/animation-shorthand.html:
      * animations/animation-start-event-destroy-renderer.html:
      * animations/animation-welcome-safari.html:
      * animations/body-removal-crash.html:
      * animations/change-keyframes-name.html:
      * animations/change-transform-style-during-animation.html:
      * animations/combo-transform-translate+scale.html:
      * animations/empty-keyframes.html:
      * animations/fill-mode-forwards.html:
      * animations/fill-mode-iteration-count-non-integer.html:
      * animations/fill-mode-missing-from-to-keyframes.html:
      * animations/fill-mode-multiple-keyframes.html:
      * animations/fill-mode-removed.html:
      * animations/fill-mode-reverse.html:
      * animations/fill-mode-transform.html:
      * animations/fill-mode.html:
      * animations/fill-unset-properties.html:
      * animations/font-size-using-ems.html-disabled:
      * animations/import-crash.html:
      * animations/keyframe-timing-functions-transform.html:
      * animations/keyframe-timing-functions2.html:
      * animations/keyframes-iteration-count-non-integer.html:
      * animations/longhand-timing-function.html:
      * animations/missing-from-to-transforms.html:
      * animations/missing-from-to.html:
      * animations/pause-crash.html:
      * animations/resources/animation-test-helpers.js:
      (checkExpectedValue):
      (endTest):
      * animations/state-at-end-event.html:
      * animations/suspend-resume-animation-events.html:
      * animations/suspend-transform-animation.html:
      * animations/transition-and-animation-3.html:
      * animations/unanimated-style.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119985 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad35b686
  2. 05 Dec, 2008 1 commit
    • cmarrin@apple.com's avatar
      2008-12-05 Chris Marrin <cmarrin@apple.com> · e625a40e
      cmarrin@apple.com authored
              Reviewed by Dave Hyatt.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=22635
              For iteration and end events, previous fixes to prevent the deletion of
              Animation objects (ref counting and hanging onto a ref during event callbacks)
              was sufficient to prevent dangling pointers. But start events are sent in
              the styleAvailable() call, which iterates over CompositeAnimation objects,
              which are not ref counted. So that object can get destroyed in the event
              handler while still active. So I added refcounting for CompositeAnimations.
      
              Additionally, when am iterating over the CompositingAnimation list, it can
              be deleted, which mutates the list. So I now make one pass over the list
              building a vector of CompositeAnimation objects that need to be called and
              then iterate over that vector to make the actual calls.
      
              Finally, to make sure the lifetime of the CompositeAnimation exceeds that of
              the Animation objects it owns, I now keep a ref to the CompositeAnimation
              in the timer callback for the iteration and end events. That means I no
              longer need to keep a ref to the Animation objects themselves in that timer
              callback, since the CompositeAnimation already has one.
      
              Tests: animations/animation-iteration-event-destroy-renderer.html
                     animations/animation-start-event-destroy-renderer.html
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39059 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e625a40e
  3. 03 Dec, 2008 1 commit
    • simon.fraser@apple.com's avatar
      2008-12-03 Simon Fraser <simon.fraser@apple.com> · 3f5c5b76
      simon.fraser@apple.com authored
              Reviewed by Dave Hyatt
      
              Clean up and unify transition and animation test cases that destroy
              the renderer in the 'ended' event callback, either through setting display:none,
              or removing the element.
      
              * animations/animation-end-event-destroy-renderer-expected.txt: Added.
              * animations/animation-end-event-destroy-renderer.html: Added.
              * animations/transform-animation-event-destroy-element-expected.txt: Removed.
              * animations/transform-animation-event-destroy-element.html: Removed.
              * transitions/transform-transition-event-destroy-element-expected.txt: Removed.
              * transitions/transform-transition-event-destroy-element.html: Removed.
              * transitions/transition-end-event-destroy-renderer-expected.txt: Added.
              * transitions/transition-end-event-destroy-renderer.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38969 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f5c5b76