1. 08 Dec, 2010 40 commits
    • bweinstein@apple.com's avatar
      Layering Violation in ContextMenu - member variable of type HitTestResult · ff7b94c4
      bweinstein@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=50586
              
      Reviewed by John Sullivan.
      
      WebCore: 
      
      ContextMenu had a layering violation by having a member variable of type HitTestResult, because
      classes in WebCore/platform can't know about classes in WebCore.
              
      This patch moves the HitTestResult and all functions that use it out of ContextMenu into ContextMenuController.
      All of the functions that dealt with populating the ContextMenu are now in ContextMenuController, and this
      allowed us to delete the ContextMenu file, putting all of the cross-platform code that used to be it
      in ContextMenuController, and the rest of the code is in the platform-specific files.
      
      No change in behavior, no new tests.
      
      * Android.mk: Removed ContextMenu.cpp.
      * CMakeLists.txt: Ditto.
      * GNUmakefile.am: Ditto.
      * WebCore.gypi: Ditto.
      * WebCore.pro: Ditto.
      * WebCore.vcproj/WebCore.vcproj: Ditto.
      * WebCore.xcodeproj/project.pbxproj: Ditto.
      
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::ContextMenuController): Initialized m_hitTestResult to an empty HitTestResult.
      (WebCore::ContextMenuController::handleContextMenuEvent): Call populate on the ContextMenuController instead
          of the ContextMenu.
      (WebCore::ContextMenuController::createContextMenu): Fix some indination, and store the HitTestResult in a member
          variable.
      (WebCore::ContextMenuController::showContextMenu): Call addInspectElementItem on the ContextMenuController.
      (WebCore::ContextMenuController::contextMenuItemSelected): Use m_hitTestResult whenever we need a HitTestResult.
      (WebCore::ContextMenuController::appendItem): Validates the item for its state, and then appends it to the parent menu.
          This allowed us to move checkOrEnableIfNeeded from ContextMenu.
      
      These functions were all moved from ContextMenu, and changed slightly to fit in ContextMenuController.
      All calls to ContextMenu::appendItem were changed to ContextMenuController::appendItem, which takes care
      of validating the menu.
      (WebCore::separatorItem): Moved from ContextMenu.
      (WebCore::ContextMenuController::createAndAppendFontSubMenu): Ditto.
      (WebCore::ContextMenuController::createAndAppendSpellingAndGrammarSubMenu): Ditto.
      (WebCore::ContextMenuController::createAndAppendSpeechSubMenu): Ditto.
      (WebCore::ContextMenuController::createAndAppendWritingDirectionSubMenu): Ditto.
      (WebCore::ContextMenuController::createAndAppendTextDirectionSubMenu): Ditto.
      (WebCore::ContextMenuController::createAndAppendSubstitutionsSubMenu): Ditto.
      (WebCore::ContextMenuController::createAndAppendTransformationsSubMenu): Ditto.
      (WebCore::selectionContainsPossibleWord): Ditto.
      (WebCore::ContextMenuController::populate): Ditto.
      (WebCore::ContextMenuController::addInspectElementItem): Ditto.
      (WebCore::ContextMenuController::checkOrEnableIfNeeded): Ditto.
              
      * page/ContextMenuController.h:
      (WebCore::ContextMenuController::hitTestResult): Returns the HitTestResult of the current ContextMenu.
      
      * platform/ContextMenu.cpp: Removed.
      * platform/ContextMenu.h:
      * platform/efl/ContextMenuEfl.cpp:
      (WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
      (WebCore::ContextMenu::appendItem): Removed the call to checkOrEnableIfNeeded.
      * platform/gtk/ContextMenuGtk.cpp:
      (WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
      (WebCore::ContextMenu::appendItem): Ditto.
      * platform/haiku/ContextMenuHaiku.cpp:
      (WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
      (WebCore::ContextMenu::appendItem): Ditto.
      (WebCore::ContextMenu::insertItem): Ditto.
      * platform/mac/ContextMenuMac.mm:
      (-[WebCoreMenuTarget validateMenuItem:]): Calls checkOrEnableIfNeeded on the controller instead of
          the context menu.
      (WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
      (WebCore::ContextMenu::appendItem): Removed the call to checkOrEnableIfNeeded.
      (WebCore::ContextMenu::insertItem): Ditto.
      * platform/win/ContextMenuWin.cpp:
      (WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
      (WebCore::ContextMenu::insertItem): Removed the call to checkOrEnableIfNeeded.
      * platform/wx/ContextMenuWx.cpp:
      (WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
      (ContextMenu::appendItem): Ditto.
      
      WebKit/chromium: 
      
      Update users of ContextMenu and ContextMenuController to match where the new functions 
      are located.
      
      * src/ContextMenuClientImpl.cpp:
      (WebKit::selectMisspelledWord):
      (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
      
      WebKit/gtk: 
      
      Update users of ContextMenu and ContextMenuController to match where the new functions 
      are located.
      
      * WebCoreSupport/ContextMenuClientGtk.cpp:
      (WebKit::ContextMenuClient::getCustomMenuFromDefaultItems):
      
      WebKit/mac: 
      
      Update users of ContextMenu and ContextMenuController to match where the new functions 
      are located.
      
      * WebCoreSupport/WebContextMenuClient.mm:
      (WebContextMenuClient::getCustomMenuFromDefaultItems):
      (WebContextMenuClient::contextMenuItemSelected):
      * WebView/WebHTMLView.mm:
      (-[WebMenuTarget validateMenuItem:]):
      
      WebKit/qt: 
      
      Update users of ContextMenu and ContextMenuController to match where the new functions 
      are located.
      
      * Api/qwebpage.cpp:
      (QWebPagePrivate::createContextMenu):
      (QWebPage::updatePositionDependentActions):
      
      WebKit/win: 
      
      Update users of ContextMenu and ContextMenuController to match where the new functions 
      are located.
      
      * WebCoreSupport/WebContextMenuClient.cpp:
      (WebContextMenuClient::getCustomMenuFromDefaultItems): Get the HitTestResult and ContextMenu from the 
          ContextMenuController (from the page).
      (WebContextMenuClient::contextMenuItemSelected): Get the HitTestResult from the ContextMenuController.
      * WebView.cpp:
      (WebView::handleContextMenuEvent): Ditto.
      
      WebKit2: 
      
      Update users of ContextMenu and ContextMenuController to match where the new functions 
      are located.
      
      * Shared/WebContextMenuItemData.cpp:
      (WebKit::WebContextMenuItemData::WebContextMenuItemData): Remove the call to checkOrEnableItem, that call will be made when
          the ContextMenuItem is added to the ContextMenu through the ContextMenuController.
      * WebProcess/WebPage/WebContextMenu.cpp:
      (WebKit::WebContextMenu::show):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff7b94c4
    • mrobinson@webkit.org's avatar
      2010-12-08 Martin Robinson <mrobinson@igalia.com> · b0ecf4f8
      mrobinson@webkit.org authored
              Reviewed by John Sullivan.
      
              [GTK] Layering violation in ContextMenuGtk.cpp
              https://bugs.webkit.org/show_bug.cgi?id=50676
      
              ContextMenuGtk accesses the page's ContextMenuController, which is a layering
              violation. This was fixed for Mac with change r73469. We make a similar fix here
              by moving the "activated" signal connection to the WebKit layer.
      
              * platform/gtk/ContextMenuGtk.cpp:
              (WebCore::ContextMenu::appendItem): Remove access of ContextMenuController. This
              is a layering violation.
      2010-12-08  Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by John Sullivan.
      
              [GTK] Layering violation in ContextMenuGtk.cpp
              https://bugs.webkit.org/show_bug.cgi?id=50676
      
              ContextMenuGtk accesses the page's ContextMenuController, which is a layering
              violation. This was fixed for Mac with change r73469. We make a similar fix here
              by moving the "activated" signal connection to the WebKit layer.
      
              * webkit/webkitwebview.cpp:
              (popupMenuItemActivated): Have ContextMenuController handle this signal.
              (webkit_web_view_forward_context_menu_event): For all items in the untouched
              context menu, connect their "activated" signal to the new popupMenuItemActivated
              handler.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73534 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0ecf4f8
    • jberlin@webkit.org's avatar
      WebKit2: Implement WebChromeClient::exceededDatabaseQuota · b646cd5e
      jberlin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=50656
      
      Reviewed by Adam Roben.
      
      WebCore: 
      
      * WebCore.exp.in:
      Export the symbol for SecurityOrigin::databaseIdentifier.
      
      WebKit2: 
      
      The exceededDatabaseQuota call from the WebProcess to the UIProcess needs to be synchronous
      because the new quota is checked directly after exceededDatabaseQuota returns in order to
      determine if the new Database can be created.
      
      Pass all of the details from the WebProcess to the UIProcess in order to inform the
      decision in the UIProcess about the new quota. In WebKit1, these details were
      fetched through an additional call to the API detailsForDatabase (which is infeasible in
      WebKit2 since exceededDatabaseQuota is a synchronous call).
      
      * Platform/CoreIPC/HandleMessage.h:
      (CoreIPC::callMemberFunction):
      Add a version that takes 7 parameters.
      
      * UIProcess/API/C/WKPage.h:
      
      * UIProcess/API/qt/qwkpage.cpp:
      (QWKPage::QWKPage):
      Indicate that exceededDatabaseQuota is not implemented.
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::exceededDatabaseQuota):
      Call the UIClient's exceededDatabaseQuota
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebPageProxy.messages.in:
      
      * UIProcess/WebUIClient.cpp:
      (WebKit::WebUIClient::exceededDatabaseQuota):
      If the client does not implement exceededDatabaseQuota, return a the current quota.
      * UIProcess/WebUIClient.h:
      
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::exceededDatabaseQuota):
      Send a synchronous message to the UIProcess to ask for the new quota for the origin for the
      given frame.
      
      WebKitTools: 
      
      * MiniBrowser/mac/BrowserWindowController.m:
      (-[BrowserWindowController awakeFromNib]):
      Indicate that exceededDatabaseQuota is not implemented.
      * MiniBrowser/win/BrowserView.cpp:
      (BrowserView::create):
      Ditto.
      * WebKitTestRunner/TestController.cpp:
      (WTR::createOtherPage):
      Ditto.
      (WTR::TestController::initialize):
      Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b646cd5e
    • ossy@webkit.org's avatar
      2010-12-08 Csaba Osztrogonác <ossy@webkit.org> · 8212c7dd
      ossy@webkit.org authored
              Unreviewed, rolling out r73521.
              http://trac.webkit.org/changeset/73521
              https://bugs.webkit.org/show_bug.cgi?id=50640
      
              It broke 90 layout tests
      
              * bindings/js/JSDOMBinding.cpp:
              (WebCore::printErrorMessageForFrame):
              * bindings/js/JSDOMWindowBase.cpp:
              (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage):
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::setLocation):
              * page/DOMWindow.cpp:
              * page/DOMWindow.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73532 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8212c7dd
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=50576 · 945782ff
      hyatt@apple.com authored
      Reviewed by Anders Carlsson.
      
      REGRESSION in position of autocomplete popup on RTL page.
      
      RTL static position computation did not subtract out the width of the enclosing box if the
      immediate parent was a RenderInline.  This bug was exposed by properly changing the RenderView
      to be RTL when the document was RTL.
      
      Added three new tests in fast/block/positioning.
      
      WebCore: 
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::computePositionedLogicalWidth):
      
      LayoutTests: 
      
      * fast/block/positioning/rtl-static-positioning-inline-block.html: Added.
      * fast/block/positioning/rtl-static-positioning.html: Added.
      * fast/block/positioning/table-cell-static-position.html: Added.
      * platform/mac/fast/block/positioning/rtl-static-positioning-expected.checksum: Added.
      * platform/mac/fast/block/positioning/rtl-static-positioning-expected.png: Added.
      * platform/mac/fast/block/positioning/rtl-static-positioning-expected.txt: Added.
      * platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.checksum: Added.
      * platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.png: Added.
      * platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.txt: Added.
      * platform/mac/fast/block/positioning/table-cell-static-position-expected.checksum: Added.
      * platform/mac/fast/block/positioning/table-cell-static-position-expected.png: Added.
      * platform/mac/fast/block/positioning/table-cell-static-position-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73531 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      945782ff
    • xji@chromium.org's avatar
      2010-12-08 Xiaomei Ji <xji@chromium.org> · bebfbc9b
      xji@chromium.org authored
              Reviewed by David Hyatt.
      
              Fix backward mouse wheeling not working when scroll position is below 0.
              https://bugs.webkit.org/show_bug.cgi?id=50370
      
              Tests: fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html
                     fast/events/wheelevent-in-vertical-scrollbar-in-rtl.html
      
              * platform/ScrollView.cpp:
              (WebCore::ScrollView::wheelEvent):
      2010-12-08  Xiaomei Ji  <xji@chromium.org>
      
              Reviewed by David Hyatt.
      
              Fix backward mouse wheeling not working when scroll position is below 0.
              https://bugs.webkit.org/show_bug.cgi?id=50370
      
              * fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
              * fast/dom/horizontal-scrollbar-in-rtl.html:
              * fast/dom/vertical-scrollbar-in-rtl-expected.txt:
              * fast/dom/vertical-scrollbar-in-rtl.html:
              * fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
              * fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html: Added.
              * fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
              * fast/events/wheelevent-in-vertical-scrollbar-in-rtl.html: Added.
              * platform/chromium/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
              * platform/chromium/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
              * platform/chromium/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
              * platform/chromium/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
              * platform/gtk/Skipped:
              * platform/mac-tiger/Skipped:
              * platform/mac-wk2/Skipped:
              * platform/qt-wk2/Skipped:
              * platform/qt/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
              * platform/qt/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
              * platform/win/Skipped:
              * platform/win/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
              * platform/win/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73529 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bebfbc9b
    • antonm@chromium.org's avatar
      Unreviewed, cleaning up test expectations after r7349. · 8188da9f
      antonm@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73528 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8188da9f
    • tonikitoo@webkit.org's avatar
      2010-12-08 Antonio Gomes <agomes@rim.com> · 09c23cc2
      tonikitoo@webkit.org authored
              Reviewed by Martin Robinson.
      
              [Gtk] Populate DumpRenderTreeSupportGtk (part III)
              https://bugs.webkit.org/show_bug.cgi?id=48429
      
              WebKit/gtk:
      
              Adjusted some call sites of previously internal API declared
              webkitprivate.h that have moved to DumpRenderTreeSupportGtk.
      
              * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
              (DumpRenderTreeSupportGtk::gcCollectJavascriptObjects):
              (DumpRenderTreeSupportGtk::gcCollectJavascriptObjectsOnAlternateThread):
              (DumpRenderTreeSupportGtk::gcCountJavascriptObjects):
              (DumpRenderTreeSupportGtk::layoutFrame):
              * WebCoreSupport/DumpRenderTreeSupportGtk.h:
              * webkit/webkitprivate.h:
              * webkit/webkitwebframe.cpp:
      
              WebKitTools:
      
              Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
              * webkit_gc_collect_javascript_objects;
              * webkit_gc_collect_javascript_objects_on_alternate_thread;
              * webkit_gc_count_javascript_objects;
              * webkit_web_frame_layout.
      
              These were all only used by GTK+ DRT.
      
              * DumpRenderTree/gtk/EventSender.cpp:
              (dispatchEvent):
              * DumpRenderTree/gtk/GCControllerGtk.cpp:
              (GCController::collect):
              (GCController::collectOnAlternateThread):
              (GCController::getJSObjectCount):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73527 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      09c23cc2
    • simon.fraser@apple.com's avatar
      2010-12-08 Simon Fraser <simon.fraser@apple.com> · cc078e89
      simon.fraser@apple.com authored
              Reviewed by Dan Bernstein.
      
              Fix pauseAnimation API to work with shorthand properties
              https://bugs.webkit.org/show_bug.cgi?id=50639
      
              The pause API is always called with a long-hand property, but that
              property may be animating via a shorthand. Detect this, and pause
              such shorthand animations.
      
              * page/animation/AnimationBase.cpp:
              (WebCore::ShorthandPropertyWrapper::propertyWrappers): Expose the vector
              of wrappers used by a shorthand wrapper.
      
              (WebCore::gatherEnclosingShorthandProperties): Utility function that walks
              through the shorthand wrappers, keeping track of which can affect the given
              property.
              (WebCore::AnimationBase::animatableShorthandsAffectingProperty): Return a set
              of shorthand properties that can affect the given property.
      
              * page/animation/AnimationBase.h: New method.
              * page/animation/CompositeAnimation.cpp:
              (WebCore::CompositeAnimation::pauseTransitionAtTime): If we don't find the
              property itself, check whether it's being animated via shorthands.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73526 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc078e89
    • hyatt@apple.com's avatar
      <rdar://problem/8740920> Gestures: Frame::scalePage() broken by r73885 · 0b979db1
      hyatt@apple.com authored
      Reviewed by Beth Dakin.
      
      Make sure the transform applied to the RenderView for page scaling is incorporated into the
      docTop/Bottom/Left/Right accessors.
      
      * rendering/RenderView.cpp:
      (WebCore::RenderView::docTop):
      (WebCore::RenderView::docBottom):
      (WebCore::RenderView::docLeft):
      (WebCore::RenderView::docRight):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b979db1
    • loislo@chromium.org's avatar
      2010-12-08 Ilya Tikhonovsky <loislo@chromium.org> · ff102636
      loislo@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: Protocol cleanup task. Remove WebInspector wrappers
              for TimelineAgent functions.
      
              https://bugs.webkit.org/show_bug.cgi?id=50690
      
              * inspector/Inspector.idl:
              * inspector/front-end/TimelineAgent.js:
              * inspector/front-end/TimelinePanel.js:
              (WebInspector.TimelinePanel):
              (WebInspector.TimelinePanel.prototype.timelineProfilerWasStarted):
              (WebInspector.TimelinePanel.prototype.timelineProfilerWasStopped):
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73524 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff102636
    • philn@webkit.org's avatar
      2010-12-08 Philippe Normand <pnormand@igalia.com> · 5ad13296
      philn@webkit.org authored
              Reviewed by Gustavo Noronha Silva.
      
              [GTK] media/fullscreen* failing on 64-bits Debug
              https://bugs.webkit.org/show_bug.cgi?id=50394
      
              Avoid emiting durationchanged in the case where the previous
              duration was 0 because that case is already handled by the
              HTMLMediaElement.
      
              Test: media/media-fullscreen*.html
      
              * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
              (WebCore::MediaPlayerPrivateGStreamer::durationChanged):
      
      LayoutTests:
      
              Reviewed by Gustavo Noronha Silva.
      
              [GTK] media/fullscreen* failing on 64-bits Debug
              https://bugs.webkit.org/show_bug.cgi?id=50394
      
              * platform/gtk/Skipped: Unskip now passing tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73523 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ad13296
    • loislo@chromium.org's avatar
      2010-12-08 Ilya Tikhonovsky <loislo@chromium.org> · e5324133
      loislo@chromium.org authored
              Unreviewed. Remove WIN prefix for inspector's tests expectations.
              DumpRenderTree related patch.
      
              * platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73522 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5324133
    • darin@apple.com's avatar
      2010-12-07 Darin Adler <darin@apple.com> · 10386762
      darin@apple.com authored
              Reviewed by Geoffrey Garen.
      
              Move DOMWindow::setLocation logic into DOMWindow class and out of JavaScript binding
              https://bugs.webkit.org/show_bug.cgi?id=50640
      
              * bindings/js/JSDOMBinding.cpp:
              (WebCore::printErrorMessageForFrame): Removed body; just call through to
              DOMWindow::printErrorMessage.
      
              * bindings/js/JSDOMWindowBase.cpp:
              (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage): Removed body;
              just call through to DOMWindow::crossDomainAccessErrorMessage.
      
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::setLocation): Changed terminology to use activeFrame and
              firstFrame, rather than the older lexicalFrame and dynamicFrame. Removed most
              of the body and moved it into DOMWindow::setLocation.
      
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::setLocation): Added. Does all the same work that
              JSDOMWindow::setLocation used to do, but in a way that's not specific
              to JavaScript.
              (WebCore::DOMWindow::printErrorMessage): Added.
              (WebCore::DOMWindow::crossDomainAccessErrorMessage): Added.
      
              * page/DOMWindow.h: Added setLocation, printErrorMessage, and
              crossDomainAccessErrorMessage.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73521 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10386762
    • aroben@apple.com's avatar
      Skip svg/custom/clip-path-referencing-use.svg on Windows · efb323d2
      aroben@apple.com authored
      The test fails when run under Aero. It seems that one of our Windows 7
      bots has this turned on while the other doesn't.
      
      * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73520 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      efb323d2
    • alex@webkit.org's avatar
      2010-12-08 Alejandro G. Castro <alex@igalia.com> · 4b623f21
      alex@webkit.org authored
              Unreviewed, rolling out r73494.
              http://trac.webkit.org/changeset/73494
              https://bugs.webkit.org/show_bug.cgi?id=50380
      
              The tests added are crashing in the debug bots (macn and gtk)
      
              * html/HTMLSelectElement.cpp:
              (WebCore::HTMLSelectElement::deselectItems):
              (WebCore::HTMLSelectElement::setSelectedIndex):
              (WebCore::HTMLSelectElement::setSelectedIndexByUser):
              (WebCore::HTMLSelectElement::listBoxSelectItem):
              (WebCore::HTMLSelectElement::add):
              (WebCore::HTMLSelectElement::remove):
              (WebCore::HTMLSelectElement::restoreFormControlState):
              (WebCore::HTMLSelectElement::parseMappedAttribute):
              (WebCore::HTMLSelectElement::selectAll):
              (WebCore::HTMLSelectElement::reset):
              (WebCore::HTMLSelectElement::updateListBoxSelection):
              (WebCore::HTMLSelectElement::setLength):
              * html/HTMLSelectElement.h:
              (WebCore::HTMLSelectElement::isOptionalFormControl):
              * html/HTMLSelectElement.idl:
              * html/ValidityState.cpp:
              (WebCore::ValidityState::valueMissing):
      
      2010-12-08  Alejandro G. Castro  <alex@igalia.com>
      
              Unreviewed, rolling out r73494.
              http://trac.webkit.org/changeset/73494
              https://bugs.webkit.org/show_bug.cgi?id=50380
      
              The tests added are crashing in the debug bots (macn and gtk)
      
              * fast/forms/ValidityState-valueMissing-001-expected.txt:
              * fast/forms/ValidityState-valueMissing-001.html:
              * fast/forms/ValidityState-valueMissing-002-expected.txt:
              * fast/forms/ValidityState-valueMissing-002.html:
              * fast/forms/ValidityState-valueMissing-003-expected.txt:
              * fast/forms/ValidityState-valueMissing-003.html:
              * fast/forms/checkValidity-002-expected.txt:
              * fast/forms/checkValidity-002.html:
              * fast/forms/required-attribute-001-expected.txt:
              * fast/forms/required-attribute-001.html:
              * fast/forms/required-attribute-002-expected.txt:
              * fast/forms/required-attribute-002.html:
              * fast/forms/resources/select-live-pseudo-selectors.js: Removed.
              * fast/forms/script-tests/validationMessage.js:
              * fast/forms/select-live-pseudo-selectors-expected.txt: Removed.
              * fast/forms/select-live-pseudo-selectors.html: Removed.
              * fast/forms/validationMessage-expected.txt:
              * platform/mac/fast/objc/dom-html-select-live-pseudo-selectors-expected.txt: Removed.
              * platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73519 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b623f21
    • loislo@chromium.org's avatar
      2010-12-08 Ilya Tikhonovsky <loislo@chromium.org> · ac58d19b
      loislo@chromium.org authored
              Unreviewed. Just enable inspector's tests for chromium linux.
              This change is related to switching to DumpRenderTree.
      
              * platform/chromium/test_expectations.txt:
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73518 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac58d19b
    • aroben@apple.com's avatar
      Land Windows results for test added in 73423 · 8e2d5be7
      aroben@apple.com authored
      * platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Added.
      * platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Added.
      * platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73517 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e2d5be7
    • aroben@apple.com's avatar
      Update Windows results after r73488 · 4fb8c49e
      aroben@apple.com authored
      * platform/win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
      * platform/win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
      * platform/win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
      * platform/win/fast/dom/HTMLMeterElement/meter-element-expected.txt:
      * platform/win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
      * platform/win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
      * platform/win/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73516 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4fb8c49e
    • philn@webkit.org's avatar
      2010-12-08 Philippe Normand <pnormand@igalia.com> · bcf2c421
      philn@webkit.org authored
              Unreviewed, skipping failing test.
      
              [GTK] r73488 broke fast/dom/HTMLProgressElement/progress-element.html
              https://bugs.webkit.org/show_bug.cgi?id=50687
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bcf2c421
    • yutak@chromium.org's avatar
      2010-12-08 Yuta Kitamura <yutak@chromium.org> · f429a910
      yutak@chromium.org authored
              Unreviewed.
      
              Update Chromium test expectations. Remove some tests that are now consistently
              passing, assign bug numbers, and add one new expectation.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73514 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f429a910
    • philn@webkit.org's avatar
      2010-12-08 Philippe Normand <pnormand@igalia.com> · cdb8d9ca
      philn@webkit.org authored
              Unreviewed, unskipping media/video-buffered.html on GTK because
              the bots are now running with latest GStreamer.
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cdb8d9ca
    • philn@webkit.org's avatar
      2010-12-08 Philippe Normand <pnormand@igalia.com> · b6550fb1
      philn@webkit.org authored
              Unreviewed, unskipped some more media tests.
      
              They are not crashing anymore, they also needed a rebaseline since
              the font tiling changes that happened while they were skipped.
      
              * platform/gtk/Skipped:
              * platform/gtk/media/controls-styling-expected.txt:
              * platform/gtk/media/video-layer-crash-expected.txt:
              * platform/gtk/media/video-transformed-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6550fb1
    • loislo@chromium.org's avatar
      2010-12-07 Ilya Tikhonovsky <loislo@chromium.org> · 5178a389
      loislo@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: Inspector protocol cleanup task. Remove
              WebInspector wrappers for DOMAgent functions.
      
              There were a lot of wrappers in WebInspector namespace
              for different WebInspector agents functions. As far as we have a
              generic mechanic for such functions we can remove these
              wrappers and register domAgent instance as a handler for
              DOM domain notifications.
      
              https://bugs.webkit.org/show_bug.cgi?id=50626
      
              * inspector/Inspector.idl:
              * inspector/front-end/DOMAgent.js:
              (WebInspector.DOMNode):
              (WebInspector.DOMAgent):
              (WebInspector.DOMAgent.prototype.attributesUpdated):
              (WebInspector.DOMAgent.prototype.characterDataModified):
              (WebInspector.DOMAgent.prototype.setDocument):
              (WebInspector.DOMAgent.prototype.setDetachedRoot):
              (WebInspector.DOMAgent.prototype.setChildNodes):
              (WebInspector.DOMAgent.prototype.childNodeCountUpdated):
              (WebInspector.DOMAgent.prototype.childNodeInserted):
              (WebInspector.DOMAgent.prototype.childNodeRemoved):
              (WebInspector.EventListeners.getEventListenersForNodeAsync):
              * inspector/front-end/inspector.js:
              (WebInspector.didCommitLoad):
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5178a389
    • yurys@chromium.org's avatar
      2010-12-08 Yury Semikhatsky <yurys@chromium.org> · 1bdf728f
      yurys@chromium.org authored
              Unreviewed. Update test expectations after r73504.
      
              * http/tests/inspector/console-resource-errors-expected.txt:
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73510 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bdf728f
    • yutak@chromium.org's avatar
      2010-12-08 Yuta Kitamura <yutak@chromium.org> · 8b629518
      yutak@chromium.org authored
              Unreviewed.
      
              Update Chromium test expectations. Add two test flakinesses which was
              introduced at r73504.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73509 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b629518
    • yutak@chromium.org's avatar
      2010-12-08 Yuta Kitamura <yutak@chromium.org> · 112e947f
      yutak@chromium.org authored
              Unreviewed.
      
              Update Chromium test expectations. Added a few failures which was found
              in Chromium main waterfall.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      112e947f
    • kov@webkit.org's avatar
      2010-12-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · e96c7eeb
      kov@webkit.org authored
              Reviewed by Xan Lopez.
      
              The storage for the subresources is a GHashTable which does not
              guarantee order, so we need to make our checking more resilient.
      
              * tests/testwebresource.c:
              (test_web_resource_sub_resource_loading):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73507 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e96c7eeb
    • kov@webkit.org's avatar
      2010-12-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · bfadf79e
      kov@webkit.org authored
              [GTK] Fails back to POST tests
              https://bugs.webkit.org/show_bug.cgi?id=50678
      
              Skip new tests that we are failing.
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73506 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bfadf79e
    • kov@webkit.org's avatar
      2010-12-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · 2ff8a2b8
      kov@webkit.org authored
              Fix name of the Korean translation file.
      
              * kr.po -> ko.po: renamed to correct name.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73505 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2ff8a2b8
    • yurys@chromium.org's avatar
      2010-12-08 Yury Semikhatsky <yurys@chromium.org> · f2690f43
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: remove groupLevel counter from console messages
              https://bugs.webkit.org/show_bug.cgi?id=50672
      
              * inspector/console-tests-expected.txt:
      2010-12-08  Yury Semikhatsky  <yurys@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: remove groupLevel counter from console messages
              https://bugs.webkit.org/show_bug.cgi?id=50672
      
              * inspector/ConsoleMessage.cpp:
              (WebCore::ConsoleMessage::ConsoleMessage):
              (WebCore::ConsoleMessage::addToFrontend):
              (WebCore::ConsoleMessage::isEqual):
              * inspector/ConsoleMessage.h:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::InspectorController):
              (WebCore::InspectorController::addMessageToConsole):
              (WebCore::InspectorController::clearConsoleMessages):
              (WebCore::InspectorController::startGroup):
              (WebCore::InspectorController::endGroup):
              * inspector/InspectorController.h:
              * inspector/front-end/ConsoleView.js:
              (WebInspector.ConsoleView.createFilterElement):
              (WebInspector.ConsoleView):
              (WebInspector.ConsoleView.prototype.filter):
              (WebInspector.ConsoleView.prototype.afterShow):
              (WebInspector.ConsoleView.prototype.addMessage):
              (WebInspector.ConsoleView.prototype.updateMessageRepeatCount):
              (WebInspector.ConsoleView.prototype.clearMessages):
              (WebInspector.ConsoleMessage):
              (WebInspector.ConsoleMessage.createTextMessage):
              (WebInspector.ConsoleMessage.prototype.toMessageElement):
              (WebInspector.ConsoleMessage.prototype._addMessageHeader):
              (WebInspector.ConsoleMessage.prototype._updateRepeatCount):
              (WebInspector.ConsoleMessage.prototype.toString):
              (WebInspector.ConsoleMessage.prototype.isEqual):
              (WebInspector.ConsoleGroup):
              * inspector/front-end/Resource.js:
              (WebInspector.Resource.prototype._checkWarning):
              * inspector/front-end/SourceFrame.js:
              (WebInspector.SourceFrame.prototype._addMessageToSource):
              * inspector/front-end/inspector.js:
              (WebInspector.addConsoleMessage):
              (WebInspector.log.logMessage):
              (WebInspector.log):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73504 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2690f43
    • ossy@webkit.org's avatar
      Unreviewed. Add new tests introduced in r73484 to the Skipped list, · 4032abd7
      ossy@webkit.org authored
      because layoutTestController.testRepaint() is unimplemented in Qt DRT.
      
      * platform/qt/Skipped:
       - fast/repaint/table-writing-modes-h.html added
       - fast/repaint/table-writing-modes-v.html added
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4032abd7
    • ossy@webkit.org's avatar
      Unreviewed. Update Qt specific expected results after r73488. · 692183f4
      ossy@webkit.org authored
      Compared to Mac png files and Mac expected files.
      
      * platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum:
      * platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
      * platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
      * platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
      * platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
      * platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
      * platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum:
      * platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
      * platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
      * platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
      * platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.png:
      * platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73502 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      692183f4
    • podivilov@chromium.org's avatar
      2010-12-07 Pavel Podivilov <podivilov@chromium.org> · 239a4197
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: introduce DebuggerModel class representing InspectorDebuggerAgent state.
              https://bugs.webkit.org/show_bug.cgi?id=50567
      
              Moved debugging-related code from BreakpointManager to DebuggerModel. Moved Breakpoint class to a separate file.
      
              * English.lproj/localizedStrings.js:
              * WebCore.gypi:
              * WebCore.vcproj/WebCore.vcproj:
              * inspector/front-end/Breakpoint.js: Added.
              (WebInspector.Breakpoint): Moved from BreakpointManager.js.
              * inspector/front-end/BreakpointManager.js:
              (WebInspector.BreakpointManager): Remove debugger-related methods.
              * inspector/front-end/CallStackSidebarPane.js:
              (WebInspector.CallStackSidebarPane):
              (WebInspector.CallStackSidebarPane.prototype._nativeBreakpointHit):
              (WebInspector.CallStackSidebarPane.prototype._scriptBreakpointHit):
              * inspector/front-end/DebuggerModel.js: Added.
              (WebInspector.DebuggerModel): Moved debugger-related methods from BreakpointManager.
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel):
              (WebInspector.ScriptsPanel.prototype.continueToLine):
              (WebInspector.ScriptsPanel.prototype.editScriptSource.mycallback):
              (WebInspector.ScriptsPanel.prototype.editScriptSource):
              (WebInspector.ScriptsPanel.prototype._debuggerPaused):
              (WebInspector.ScriptsPanel.prototype._debuggerResumed):
              (WebInspector.ScriptsPanel.prototype.reset):
              * inspector/front-end/SourceFrame.js:
              (WebInspector.SourceFrame.prototype._createViewerIfNeeded):
              (WebInspector.SourceFrameDelegate.prototype.addBreakpoint):
              (WebInspector.SourceFrameDelegate.prototype.breakpoints):
              (WebInspector.SourceFrameDelegate.prototype.findBreakpoint):
              * inspector/front-end/WebKit.qrc:
              * inspector/front-end/inspector.html:
              * inspector/front-end/inspector.js:
              (WebInspector.createJSBreakpointsSidebarPane):
              (WebInspector.restoredBreakpoint):
              (WebInspector.pausedScript):
              (WebInspector.resumedScript):
              (WebInspector.reset):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73501 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      239a4197
    • philn@webkit.org's avatar
      2010-12-08 Philippe Normand <pnormand@igalia.com> · 62c7cabb
      philn@webkit.org authored
              Unreviewed, updated baselines of
              media/video-controls-rendering.html.
      
              * platform/gtk/media/video-controls-rendering-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73500 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62c7cabb
    • podivilov@chromium.org's avatar
      2010-12-08 Pavel Podivilov <podivilov@chromium.org> · 19ede04b
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: SourceFrame refactoring.
              https://bugs.webkit.org/show_bug.cgi?id=50223
      
              * inspector/debugger-breakpoints-not-activated-on-reload.html:
              * inspector/debugger-pause-on-breakpoint.html:
      2010-12-08  Pavel Podivilov  <podivilov@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: SourceFrame refactoring.
              https://bugs.webkit.org/show_bug.cgi?id=50223
      
              SourceFrame should ask BreakpointManager about existing breakpoints instead of maintaining
              it's own storages. Move common code from ScriptView and SourceView to SourceFrame.
      
              * inspector/front-end/BreakpointManager.js:
              (WebInspector.BreakpointManager.prototype.findBreakpoints):
              (WebInspector.BreakpointManager.prototype.findBreakpoint):
              * inspector/front-end/Script.js:
              (WebInspector.Script):
              (WebInspector.Script.prototype.get linesCount):
              (WebInspector.Script.prototype.get source):
              (WebInspector.Script.prototype.set source):
              * inspector/front-end/ScriptView.js:
              (WebInspector.ScriptView):
              (WebInspector.ScriptView.prototype._scriptSourceChanged):
              (WebInspector.ScriptFrameDelegateImpl):
              (WebInspector.ScriptFrameDelegateImpl.prototype.canEditScripts):
              (WebInspector.ScriptFrameDelegateImpl.prototype.editLineComplete):
              (WebInspector.ScriptFrameDelegateImpl.prototype.scripts):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel):
              * inspector/front-end/SourceFrame.js:
              (WebInspector.SourceFrame): Add common methods of ScriptView and SourceView.
              (WebInspector.SourceFrameDelegate):
              (WebInspector.SourceFrameDelegate.prototype.canEditScripts):
              (WebInspector.SourceFrameDelegate.prototype.editLineComplete):
              (WebInspector.SourceFrameDelegate.prototype.scripts):
              * inspector/front-end/SourceView.js:
              (WebInspector.SourceView):
              (WebInspector.SourceView.prototype._contentLoaded):
              (WebInspector.ResourceFrameDelegateImpl):
              (WebInspector.ResourceFrameDelegateImpl.prototype.canEditScripts):
              (WebInspector.ResourceFrameDelegateImpl.prototype.editLineComplete):
              (WebInspector.ResourceFrameDelegateImpl.prototype.scripts):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73499 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19ede04b
    • philn@webkit.org's avatar
      2010-12-08 Philippe Normand <pnormand@igalia.com> · 513a6a09
      philn@webkit.org authored
              Unreviewed, unskipping media/video-controls-rendering.html on GTK.
      
              It should now not crash anymore because the GTK bots have been
              upgraded to latest GStreamer releases.
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73498 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      513a6a09
    • alex@webkit.org's avatar
      2010-12-08 Alejandro G. Castro <alex@igalia.com> · 6eb3f662
      alex@webkit.org authored
              Reviewed by Gustavo Noronha Silva.
      
              Fix assertion in the API test, we are requesting the favicon and
              the subresource so we have to make sure we are assigning just the
              first subresource.
      
              * tests/testwebresource.c:
              (resource_request_starting_sub_cb):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73497 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6eb3f662
    • yutak@chromium.org's avatar
      2010-12-08 Yuta Kitamura <yutak@chromium.org> · a046e9c6
      yutak@chromium.org authored
              Unreviewed, rolling out r73492.
              http://trac.webkit.org/changeset/73492
              https://bugs.webkit.org/show_bug.cgi?id=49914
      
              Caused a lot of pixel test failures and broke Windows build.
      
              * WebCore.xcodeproj/project.pbxproj:
              * platform/graphics/GraphicsContext.cpp:
              (WebCore::GraphicsContext::createGraphicsContextPrivate):
              (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
              (WebCore::GraphicsContext::save):
              (WebCore::GraphicsContext::restore):
              (WebCore::GraphicsContext::setStrokeThickness):
              (WebCore::GraphicsContext::setStrokeStyle):
              (WebCore::GraphicsContext::setStrokeColor):
              (WebCore::GraphicsContext::setShadow):
              (WebCore::GraphicsContext::clearShadow):
              (WebCore::GraphicsContext::getShadow):
              (WebCore::GraphicsContext::strokeThickness):
              (WebCore::GraphicsContext::strokeStyle):
              (WebCore::GraphicsContext::strokeColor):
              (WebCore::GraphicsContext::strokeColorSpace):
              (WebCore::GraphicsContext::fillRule):
              (WebCore::GraphicsContext::setFillRule):
              (WebCore::GraphicsContext::setFillColor):
              (WebCore::GraphicsContext::fillColor):
              (WebCore::GraphicsContext::fillColorSpace):
              (WebCore::GraphicsContext::setShouldAntialias):
              (WebCore::GraphicsContext::shouldAntialias):
              (WebCore::GraphicsContext::setStrokePattern):
              (WebCore::GraphicsContext::setFillPattern):
              (WebCore::GraphicsContext::setStrokeGradient):
              (WebCore::GraphicsContext::setFillGradient):
              (WebCore::GraphicsContext::fillGradient):
              (WebCore::GraphicsContext::strokeGradient):
              (WebCore::GraphicsContext::fillPattern):
              (WebCore::GraphicsContext::strokePattern):
              (WebCore::GraphicsContext::setShadowsIgnoreTransforms):
              (WebCore::GraphicsContext::updatingControlTints):
              (WebCore::GraphicsContext::setUpdatingControlTints):
              (WebCore::GraphicsContext::setPaintingDisabled):
              (WebCore::GraphicsContext::paintingDisabled):
              (WebCore::GraphicsContext::textDrawingMode):
              (WebCore::GraphicsContext::setTextDrawingMode):
              * platform/graphics/GraphicsContext.h:
              * platform/graphics/GraphicsContextPrivate.h: Added.
              (WebCore::GraphicsContextState::GraphicsContextState):
              (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
              * platform/graphics/cairo/GraphicsContextCairo.cpp:
              (WebCore::setPlatformFill):
              (WebCore::setPlatformStroke):
              (WebCore::drawPathShadow):
              (WebCore::fillCurrentCairoPath):
              (WebCore::strokeCurrentCairoPath):
              (WebCore::GraphicsContext::GraphicsContext):
              (WebCore::GraphicsContext::~GraphicsContext):
              (WebCore::GraphicsContext::fillPath):
              (WebCore::GraphicsContext::strokePath):
              (WebCore::GraphicsContext::fillRect):
              (WebCore::GraphicsContext::setPlatformShadow):
              (WebCore::GraphicsContext::strokeRect):
              (WebCore::GraphicsContext::setAlpha):
              (WebCore::GraphicsContext::getAlpha):
              * platform/graphics/cg/GraphicsContextCG.cpp:
              (WebCore::GraphicsContext::GraphicsContext):
              (WebCore::GraphicsContext::~GraphicsContext):
              (WebCore::GraphicsContext::applyStrokePattern):
              (WebCore::GraphicsContext::applyFillPattern):
              (WebCore::GraphicsContext::drawPath):
              (WebCore::GraphicsContext::fillPath):
              (WebCore::GraphicsContext::strokePath):
              (WebCore::GraphicsContext::fillRect):
              (WebCore::GraphicsContext::setPlatformShadow):
              (WebCore::GraphicsContext::strokeRect):
              * platform/graphics/haiku/GraphicsContextHaiku.cpp:
              (WebCore::GraphicsContext::GraphicsContext):
              (WebCore::GraphicsContext::~GraphicsContext):
              * platform/graphics/openvg/GraphicsContextOpenVG.cpp:
              (WebCore::GraphicsContext::GraphicsContext):
              (WebCore::GraphicsContext::~GraphicsContext):
              (WebCore::GraphicsContext::fillPath):
              (WebCore::GraphicsContext::strokePath):
              (WebCore::GraphicsContext::clip):
              (WebCore::GraphicsContext::clipOut):
              (WebCore::GraphicsContext::addInnerRoundedRectClip):
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::GraphicsContext::GraphicsContext):
              (WebCore::GraphicsContext::~GraphicsContext):
              (WebCore::GraphicsContext::fillPath):
              (WebCore::GraphicsContext::strokePath):
              (WebCore::GraphicsContext::fillRect):
              (WebCore::GraphicsContext::setPlatformShadow):
              * platform/graphics/skia/GraphicsContextSkia.cpp:
              (WebCore::GraphicsContext::GraphicsContext):
              (WebCore::GraphicsContext::~GraphicsContext):
              (WebCore::GraphicsContext::fillPath):
              (WebCore::GraphicsContext::setPlatformShadow):
              * platform/graphics/win/GraphicsContextCGWin.cpp:
              (WebCore::GraphicsContext::GraphicsContext):
              * platform/graphics/win/GraphicsContextCairoWin.cpp:
              (WebCore::GraphicsContext::GraphicsContext):
              * platform/graphics/wince/GraphicsContextWinCE.cpp:
              (WebCore::GraphicsContext::GraphicsContext):
              (WebCore::GraphicsContext::~GraphicsContext):
              (WebCore::GraphicsContext::fillPath):
              (WebCore::GraphicsContext::fillRect):
              * platform/graphics/wx/GraphicsContextWx.cpp:
              (WebCore::GraphicsContext::GraphicsContext):
              (WebCore::GraphicsContext::~GraphicsContext):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73496 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a046e9c6
    • commit-queue@webkit.org's avatar
      2010-12-08 Dai Mikurube <dmikurube@google.com> · d7016a87
      commit-queue@webkit.org authored
              Reviewed by Kent Tamura.
      
              Implement "required" attribute for select tags
              https://bugs.webkit.org/show_bug.cgi?id=50380
      
              Added tests for require attributes, valueMissing and vadility check for select elements.
      
              * fast/forms/ValidityState-valueMissing-001-expected.txt:
              * fast/forms/ValidityState-valueMissing-001.html:
              * fast/forms/ValidityState-valueMissing-002-expected.txt:
              * fast/forms/ValidityState-valueMissing-002.html:
              * fast/forms/ValidityState-valueMissing-003-expected.txt:
              * fast/forms/ValidityState-valueMissing-003.html:
              * fast/forms/checkValidity-002-expected.txt:
              * fast/forms/checkValidity-002.html:
              * fast/forms/required-attribute-001-expected.txt:
              * fast/forms/required-attribute-001.html:
              * fast/forms/required-attribute-002-expected.txt:
              * fast/forms/required-attribute-002.html:
              * fast/forms/resources/select-live-pseudo-selectors.js: Added.
              (makeInvalid):
              (appendOption):
              (backgroundOf):
              * fast/forms/script-tests/validationMessage.js:
              * fast/forms/select-live-pseudo-selectors-expected.txt: Added.
              * fast/forms/select-live-pseudo-selectors.html: Added.
              * fast/forms/validationMessage-expected.txt:
              * platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html: Added.
              * platform/mac/fast/objc/dom-html-select-live-pseudo-selectors-expected.txt: Added.
      2010-12-08  Dai Mikurube  <dmikurube@google.com>
      
              Reviewed by Kent Tamura.
      
              Implement "required" attribute for select tags
              https://bugs.webkit.org/show_bug.cgi?id=50380
      
              Test: fast/forms/select-live-pseudo-selectors.html
                    platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html
      
              * html/HTMLSelectElement.cpp:
              (WebCore::HTMLSelectElement::deselectItems): Added calling setNeedsValidityCheck() to enable validity check after changing. No tests for this change since this function is not exposed to JavaScript or any web interface.
              (WebCore::HTMLSelectElement::setSelectedIndex): Added calling setNeedsValidityCheck().
              (WebCore::HTMLSelectElement::setSelectedIndexByUser): Added calling setNeedsValidityCheck().
              (WebCore::HTMLSelectElement::valueMissing): Added valueMissing() to check if selecting an invalid or placeholder label option when a valid required attribute is specified.
              (WebCore::HTMLSelectElement::listBoxSelectItem): Added calling setNeedsValidityCheck(). No tests for this change since it is not called yet. Look at the bug 36177 and the changeset 56180.
              (WebCore::HTMLSelectElement::add): Added calling setNeedsValidityCheck().
              (WebCore::HTMLSelectElement::remove): Added calling setNeedsValidityCheck().
              (WebCore::HTMLSelectElement::restoreFormControlState): Added calling setNeedsValidityCheck().
              (WebCore::HTMLSelectElement::parseMappedAttribute): Added calling setNeedsValidityCheck().
              (WebCore::HTMLSelectElement::selectAll): Added calling setNeedsValidityCheck().
              (WebCore::HTMLSelectElement::reset): Added calling setNeedsValidityCheck().
              (WebCore::HTMLSelectElement::updateListBoxSelection): Added calling setNeedsValidityCheck(). Skipped adding tests for this change as too complicated..
              (WebCore::HTMLSelectElement::setLength): Added calling setNeedsValidityCheck().
              (WebCore::HTMLSelectElement::isRequiredFormControl): Check if required or not.
              (WebCore::HTMLSelectElement::hasPlaceholderLabelOption): Added.
              * html/HTMLSelectElement.h:
              (WebCore::HTMLSelectElement::isOptionalFormControl): Check if not required.
              * html/HTMLSelectElement.idl: Added a required attribute to select elements..
              * html/ValidityState.cpp:
              (WebCore::ValidityState::valueMissing): Added valueMissing check for select elements into the global checker, ValidityState::valueMissing().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73494 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7016a87