1. 12 Jun, 2009 4 commits
    • kevino@webkit.org's avatar
      wx build fix. Adding JSONObject.cpp to the build. · ff20d137
      kevino@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44625 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff20d137
    • jberlin@apple.com's avatar
      Index: WebCore/ChangeLog · 50b7aa71
      jberlin@apple.com authored
      ===================================================================
      --- WebCore/ChangeLog	(revision 44622)
      +++ WebCore/ChangeLog	(working copy)
      @@ -1,3 +1,23 @@
      +2009-06-12  Jessie Berlin  <jberlin@apple.com>
      +
      +        Reviewed by Mark Rowe.
      +
      +        https://bugs.webkit.org/show_bug.cgi?id=24792
      +        rdar://problem/6933055
      +
      +        Changes the radius in which cursor movement around the 4 arrow icon
      +        while pan-scrolling does not cause scrolling from around 10 pixels to
      +        15 pixels, similar to what is found in IE and Firefox.
      +
      +        * page/EventHandler.cpp:
      +        (WebCore::EventHandler::setPanScrollCursor):
      +        Factor out the no-pan-scroll radius.
      +        * platform/ScrollView.h:
      +        Create a constant for the no-pan-scroll radius.
      +        * rendering/RenderLayer.cpp:
      +        (WebCore::RenderLayer::panScrollFromPoint):
      +        Factor out the no-pan-scroll radius.
      +
       2009-06-12  Xan Lopez  <xlopez@igalia.com>
       
               Reviewed by Gustavo Noronha.
      Index: WebCore/page/EventHandler.cpp
      ===================================================================
      --- WebCore/page/EventHandler.cpp	(revision 44622)
      +++ WebCore/page/EventHandler.cpp	(working copy)
      @@ -661,11 +661,10 @@ void EventHandler::setPanScrollCursor()
       
           // At the original click location we draw a 4 arrowed icon. Over this icon there won't be any scroll
           // So we don't want to change the cursor over this area
      -    const int noScrollRadius = 9;
      -    bool east = m_panScrollStartPos.x() < (m_currentMousePosition.x() - noScrollRadius);
      -    bool west = m_panScrollStartPos.x() > (m_currentMousePosition.x() + noScrollRadius);
      -    bool north = m_panScrollStartPos.y() > (m_currentMousePosition.y() + noScrollRadius);
      -    bool south = m_panScrollStartPos.y() < (m_currentMousePosition.y() - noScrollRadius);
      +    bool east = m_panScrollStartPos.x() < (m_currentMousePosition.x() - ScrollView::noPanScrollRadius);
      +    bool west = m_panScrollStartPos.x() > (m_currentMousePosition.x() + ScrollView::noPanScrollRadius);
      +    bool north = m_panScrollStartPos.y() > (m_currentMousePosition.y() + ScrollView::noPanScrollRadius);
      +    bool south = m_panScrollStartPos.y() < (m_currentMousePosition.y() - ScrollView::noPanScrollRadius);
                
           if (north) {
               if (east)
      Index: WebCore/platform/ScrollView.h
      ===================================================================
      --- WebCore/platform/ScrollView.h	(revision 44622)
      +++ WebCore/platform/ScrollView.h	(working copy)
      @@ -214,7 +214,8 @@ public:
           virtual void hide();
           virtual void setParentVisible(bool);
           
      -    // Pan scrolling methods.
      +    // Pan scrolling.
      +    static const int noPanScrollRadius = 15;
           void addPanScrollIcon(const IntPoint&);
           void removePanScrollIcon();
       
      Index: WebCore/rendering/RenderLayer.cpp
      ===================================================================
      --- WebCore/rendering/RenderLayer.cpp	(revision 44622)
      +++ WebCore/rendering/RenderLayer.cpp	(working copy)
      @@ -948,7 +948,6 @@ void RenderLayer::panScrollFromPoint(con
           const int shortDistanceLimit = 100;  // We delimit a 200 pixels long square enclosing the original point
           const int speedReducer = 2;          // Within this square we divide the scrolling speed by 2
           
      -    const int iconRadius = 10;
           Frame* frame = renderer()->document()->frame();
           if (!frame)
               return;
      @@ -965,9 +964,9 @@ void RenderLayer::panScrollFromPoint(con
           int xDelta = currentMousePosition.x() - sourcePoint.x();
           int yDelta = currentMousePosition.y() - sourcePoint.y();
       
      -    if (abs(xDelta) < iconRadius) // at the center we let the space for the icon
      +    if (abs(xDelta) < ScrollView::noPanScrollRadius) // at the center we let the space for the icon
               xDelta = 0;
      -    if (abs(yDelta) < iconRadius)
      +    if (abs(yDelta) < ScrollView::noPanScrollRadius)
               yDelta = 0;
       
           // Let's attenuate the speed for the short distances
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50b7aa71
    • ariya@webkit.org's avatar
      2009-06-12 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 55dcf7ed
      ariya@webkit.org authored
              Reviewed by Jan Michael Alonzo.
      
              [Qt] Fix build break
              https://bugs.webkit.org/show_bug.cgi?id=26340
      
              * JavaScriptCore.pri: Add JSONObject.cpp to LUT files.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55dcf7ed
    • xan@webkit.org's avatar
      2009-06-12 Xan Lopez <xlopez@igalia.com> · f5b9f7d1
      xan@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              https://bugs.webkit.org/show_bug.cgi?id=25609
              [GTK] Implement support for get_selection and get_n_selections
      
              Only use the VisibleSelection object if it actually belongs to the
              object we are using.
      
              This is pretty hacky-ish, but I can't seem to find a direct API to
              get the VisibleSelection for a given object, only the global one.
      
              * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
              (selectionBelongsToObject):
              (webkit_accessible_text_get_n_selections):
              (webkit_accessible_text_get_selection):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5b9f7d1
  2. 11 Jun, 2009 13 commits
  3. 10 Jun, 2009 23 commits