- 24 Jan, 2011 38 commits
-
-
kbalazs@webkit.org authored
Rubber-stamped by Csaba Osztrogonác. * UIProcess/Launcher/qt/ProcessLauncherQt.cpp: (WebKit::ProcessLauncher::launchProcess): Move the bracket to the right place. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76520 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: extract dispatch API from network manager. https://bugs.webkit.org/show_bug.cgi?id=53009 * WebCore.xcodeproj/project.pbxproj: * inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager): (WebInspector.NetworkManager.prototype.reset): (WebInspector.NetworkManager.prototype.requestContent): (WebInspector.NetworkManager.prototype._processCachedResources): (WebInspector.NetworkDispatcher): (WebInspector.NetworkDispatcher.prototype._updateResourceWithRequest): (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse): (WebInspector.NetworkDispatcher.prototype._updateResourceWithCachedResource): (WebInspector.NetworkDispatcher.prototype.identifierForInitialRequest): (WebInspector.NetworkDispatcher.prototype.willSendRequest): (WebInspector.NetworkDispatcher.prototype.didReceiveResponse): (WebInspector.NetworkDispatcher.prototype.didLoadResourceFromMemoryCache): (WebInspector.NetworkDispatcher.prototype.didCommitLoadForFrame): (WebInspector.NetworkDispatcher.prototype.didCreateWebSocket): (WebInspector.NetworkDispatcher.prototype._appendRedirect): (WebInspector.NetworkDispatcher.prototype._startResource): (WebInspector.NetworkDispatcher.prototype._updateResource): (WebInspector.NetworkDispatcher.prototype._finishResource): (WebInspector.NetworkDispatcher.prototype._addFramesRecursively): (WebInspector.NetworkDispatcher.prototype._dispatchEventToListeners): (WebInspector.NetworkDispatcher.prototype._createResource): * inspector/front-end/Resource.js: (WebInspector.Resource.prototype._innerRequestContent): * inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel): (WebInspector.ResourceTreeModel.prototype.reset): (WebInspector.ResourceTreeModel.prototype.unbindResourceURL): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76519 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yurys@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: [JSC] remove ScriptDebugServer::pageCreated https://bugs.webkit.org/show_bug.cgi?id=53007 It's impossible to create "provisional" inspector for pages which are not yet created so there is no need to listen for page creation in ScriptDebugServer. * bindings/js/ScriptDebugServer.cpp: * bindings/js/ScriptDebugServer.h: * page/Page.cpp: (WebCore::Page::Page): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76518 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
podivilov@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: [REGRESSION] AppCache view on resources panel is broken. https://bugs.webkit.org/show_bug.cgi?id=53002 * inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView.prototype._update): * inspector/front-end/DOMAgent.js: (WebInspector.ApplicationCacheDispatcher.getApplicationCachesAsync): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76517 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
reni@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=49915 Reviewed by Andreas Kling. In the first loop of renderRelativeCoords() the call of QPainter::save/restore is useless, because the context is saved/stored within the loop. In the second loop the calls are also avoidable by using inverse translation on context. * Api/qwebframe.cpp: (QWebFramePrivate::renderRelativeCoords): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76516 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andreas.kling@nokia.com authored
Reviewed by Kenneth Rohde Christiansen. [Qt] Fix warnings about unregistering an invalid timer https://bugs.webkit.org/show_bug.cgi?id=53006 The ShadowBuffer's purge timer ID was initialized with 0 which lead to us calling QObject::killTimer(0), causing some qWarnings. * platform/graphics/qt/ContextShadowQt.cpp: (WebCore::ShadowBuffer::ShadowBuffer): (WebCore::ShadowBuffer::schedulePurge): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mnaganov@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: [Chromium] Fix heap snapshot table sorting. Fix table sorting to avoid qsort instability artefacts. https://bugs.webkit.org/show_bug.cgi?id=52914 * inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotView.prototype._sortData): (WebInspector.HeapSnapshotDataGridList.propertyComparator.comparator): (WebInspector.HeapSnapshotDataGridList.propertyComparator): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76514 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
RTL: selection.modify("move", "forward", "line") when cursor is at start of a line does not move down a line https://bugs.webkit.org/show_bug.cgi?id=51517 * platform/qt-linux/editing: Removed. * platform/qt-linux/editing/selection: Removed. * platform/qt-linux/editing/selection/extend-to-line-boundary-expected.txt: Removed. * platform/qt/Skipped: Add editing/selection/extend-to-line-boundary.html until fix. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
podivilov@chromium.org authored
Unreviewed, build fix for r76509. * inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setBreakpoint): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mnaganov@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: Find duplicate strings in localizedStrings.js, update it. https://bugs.webkit.org/show_bug.cgi?id=53005 * English.lproj/localizedStrings.js: * Scripts/check-inspector-strings: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
podivilov@chromium.org authored
Unreviewed, build fix for r76509. * bindings/js/ScriptDebugServer.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76510 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
podivilov@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: set breakpoints by line:column. https://bugs.webkit.org/show_bug.cgi?id=52615 * CMakeLists.txt: * GNUmakefile.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::removeBreakpoint): (WebCore::ScriptDebugServer::hasBreakpoint): (WebCore::ScriptDebugServer::clearBreakpoints): * bindings/js/ScriptDebugServer.h: * bindings/v8/DebuggerScript.js: (): * bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint): * bindings/v8/ScriptDebugServer.h: * inspector/Inspector.idl: * inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint): * inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setStickyBreakpoint): (WebCore::InspectorDebuggerAgent::setBreakpoint): (WebCore::InspectorDebuggerAgent::restoreBreakpoint): (WebCore::InspectorDebuggerAgent::didParseSource): * inspector/InspectorDebuggerAgent.h: * inspector/ScriptBreakpoint.cpp: Removed. * inspector/ScriptBreakpoint.h: (WebCore::ScriptBreakpoint::ScriptBreakpoint): * inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint): (WebInspector.Breakpoint.prototype.get url): * inspector/front-end/BreakpointManager.js: (WebInspector.JavaScriptBreakpoint.prototype._serializeToJSON): * inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.continueToLine): (WebInspector.DebuggerModel.prototype.setBreakpoint): (WebInspector.DebuggerModel.prototype._breakpointSetOnBackend): (WebInspector.DebuggerDispatcher.prototype.breakpointResolved): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76509 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
Rubber-stamped by Csaba Osztrogonác. Patch by Peter Gal <galpater@inf.u-szeged.hu> on 2011-01-24 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [Qt] Remove CleanupHandler by passing file descriptors. Deleting files in signal handler of UI process is not a good idea, because the memory where filenames are stored might not be valid after a crash. To avoid the need of using signal handlers for cleanup, change following: 1) Avoid passing filenames between processes, pass fds 2) When mmap'ing files, delete them immediately after opening and mmap'ing them. 3) Pass sockets with fds during fork+exec instead of passing them via the filesystem. 4) Use mmap'ed files for implementation of SharedMemory. QSharedMemory does not support cleanup correctly. Consquences: - Move MappedMemory to SharedMemory, make UpdateChunk use this. - Implement CoreIPC::Attachment using mmaped files. - Send messages using datagram socket. This solution works similiarly to Mach ports on Mac. - Send big messages out-of-line and thus avoid increasing the receive buffer. - Remove MemoryMappedPool and rely on libc/kernel caching of mmapped areas. - Unmap memory areas after use. - When UI process crashes, kill the web process using SIGKILL. This is possible again because cleanup handler is not needed. [WK2][Qt] Multiple problems with MemoryMappedPool https://bugs.webkit.org/show_bug.cgi?id=51984 * Platform/CoreIPC/Attachment.cpp: (CoreIPC::Attachment::Attachment): * Platform/CoreIPC/Attachment.h: (CoreIPC::Attachment::size): (CoreIPC::Attachment::releaseFileDescriptor): (CoreIPC::Attachment::fileDescriptor): * Platform/CoreIPC/Connection.h: * Platform/CoreIPC/qt/ConnectionQt.cpp: (CoreIPC::MessageInfo::MessageInfo): (CoreIPC::MessageInfo::setMessageBodyOOL): (CoreIPC::MessageInfo::isMessageBodyOOL): (CoreIPC::MessageInfo::bodySize): (CoreIPC::MessageInfo::messageID): (CoreIPC::MessageInfo::attachmentCount): (CoreIPC::Connection::platformInitialize): (CoreIPC::Connection::platformInvalidate): (CoreIPC::SocketNotifierDisableGuard::SocketNotifierDisableGuard): (CoreIPC::SocketNotifierDisableGuard::~SocketNotifierDisableGuard): (CoreIPC::Connection::readyReadHandler): (CoreIPC::Connection::open): (CoreIPC::Connection::platformCanSendOutgoingMessages): (CoreIPC::Connection::sendOutgoingMessage): * Platform/SharedMemory.h: * Platform/WorkQueue.h: * Platform/qt/MappedMemoryPool.cpp: Removed. * Platform/qt/MappedMemoryPool.h: Removed. * Platform/qt/SharedMemoryQt.cpp: (WebKit::SharedMemory::Handle::Handle): (WebKit::SharedMemory::Handle::~Handle): (WebKit::SharedMemory::Handle::isNull): (WebKit::SharedMemory::Handle::encode): (WebKit::SharedMemory::Handle::decode): (WebKit::SharedMemory::Handle::releaseToAttachment): (WebKit::SharedMemory::Handle::adoptFromAttachment): (WebKit::SharedMemory::create): (WebKit::accessModeMMap): (WebKit::SharedMemory::~SharedMemory): (WebKit::accessModeFile): (WebKit::SharedMemory::createHandle): * Platform/qt/WorkQueueQt.cpp: (WorkQueue::registerSocketEventHandler): * Shared/qt/UpdateChunk.cpp: (WebKit::UpdateChunk::UpdateChunk): (WebKit::UpdateChunk::~UpdateChunk): (WebKit::UpdateChunk::encode): (WebKit::UpdateChunk::decode): (WebKit::UpdateChunk::createImage): * Shared/qt/UpdateChunk.h: * UIProcess/Launcher/ProcessLauncher.h: * UIProcess/Launcher/qt/ProcessLauncherQt.cpp: (WebKit::QtWebProcess::QtWebProcess): (WebKit::QtWebProcess::setupChildProcess): (WebKit::ProcessLauncher::launchProcess): (WebKit::ProcessLauncher::platformInvalidate): * UIProcess/Launcher/qt/ThreadLauncherQt.cpp: (WebKit::webThreadBody): (WebKit::ThreadLauncher::createWebThread): * WebKit2.pro: * WebProcess/qt/WebProcessMainQt.cpp: (WebKit::WebProcessMainQt): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76507 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yurys@chromium.org authored
Unreviewed. Update Chromium test expectations. * platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: * platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt: * platform/chromium-mac/http/tests/security/xss-DENIED-frame-name-expected.txt: * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76506 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Pavel Feldman. Web Inspector: recognize application/x-font-woff as a valid mime-type. https://bugs.webkit.org/show_bug.cgi?id=52977 No new tests. * inspector/front-end/inspector.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76505 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
podivilov@chromium.org authored
Unreviewed, fix for r76497. * inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.show): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76504 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zoltan@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=53000 Reviewed by Andreas Kling. Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu. * MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): (BrowserWindow::openFile): (BrowserWindow::~BrowserWindow): * MiniBrowser/qt/BrowserWindow.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pvarga@webkit.org authored
Reviewed by Oliver Hunt. Optimize regex patterns which contain empty alternatives https://bugs.webkit.org/show_bug.cgi?id=51395 Eliminate the empty alternatives from the regex pattern and convert it to do the matching in an easier way. * fast/regex/script-tests/slow.js: * fast/regex/slow-expected.txt: 2011-01-24 Peter Varga <pvarga@webkit.org> Reviewed by Oliver Hunt. Optimize regex patterns which contain empty alternatives https://bugs.webkit.org/show_bug.cgi?id=51395 Eliminate the empty alternatives from the regex pattern and convert it to do the matching in an easier way. * yarr/YarrPattern.cpp: (JSC::Yarr::YarrPatternConstructor::atomParenthesesEnd): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76502 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andreas.kling@nokia.com authored
Reviewed by Tor Arne Vestbø. [Qt] Use rad2deg() from WTF instead of rolling our own. https://bugs.webkit.org/show_bug.cgi?id=52993 * platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::rotate): * platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArc): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76501 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
podivilov@chromium.org authored
Unreviewed, test fix for r76497. * http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.setBreakpointInVisibleView): (initialize_DebuggerTest.InspectorTest._showScriptSource): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76500 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
[Qt] Move project files into Source https://bugs.webkit.org/show_bug.cgi?id=52891 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path. * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path. * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76499 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
sergio@webkit.org authored
Reviewed by Martin Robinson. [Gtk] ResourceHandleSoup: do not wait for streams to close to issue didFinishLoading https://bugs.webkit.org/show_bug.cgi?id=52885 No new tests as it does not change functionality. We will not wait for the the input stream to close to issue didFinishLoading to WebCore. We expect a subtle performance improvement with this patch when loading complex web pages, as we wouldn't have to wait for the stream to close (which involves creating a thread among other things). * platform/network/soup/ResourceHandleSoup.cpp: (WebCore::closeCallback): (WebCore::readCallback): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76498 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
podivilov@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: eliminate SourceView and ScriptView classes. https://bugs.webkit.org/show_bug.cgi?id=52896 SourceView and ScriptView delegate everything to SourceFrame and should be eliminated. * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * inspector/front-end/GoToLineDialog.js: (WebInspector.GoToLineDialog.prototype._highlightSelectedLine): * inspector/front-end/ResourceView.js: (WebInspector.ResourceView.createResourceView): (WebInspector.ResourceView.resourceViewTypeMatchesResource): (WebInspector.SourceFrameContentProviderForResource): Moved from SourceView. * inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.show): (WebInspector.ResourcesPanel.prototype._applyDiffMarkup): (WebInspector.FrameResourceTreeElement.prototype._errorsWarningsUpdated): * inspector/front-end/ScriptView.js: Removed. * inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._scriptSourceChanged): (WebInspector.ScriptsPanel.prototype._sourceFrameForScriptOrResource): (WebInspector.ScriptsPanel.prototype._showScriptOrResource): (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions): (WebInspector.ScriptsPanel.prototype._formatScript): (WebInspector.SourceFrameContentProviderForScript): Moved from ScriptView. * inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype.show): (WebInspector.SourceFrame.prototype.hide): (WebInspector.SourceFrame.prototype.hasContent): (WebInspector.SourceFrame.prototype._createTextViewer): (WebInspector.SourceFrame.prototype.performSearch.doFindSearchMatches): (WebInspector.SourceFrame.prototype.performSearch): * inspector/front-end/SourceView.js: Removed. * inspector/front-end/WebKit.qrc: * inspector/front-end/inspector.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76497 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abecsi@webkit.org authored
Reviewed by Csaba Osztrogonác. [Qt] Move project files into Source https://bugs.webkit.org/show_bug.cgi?id=52891 * Source/DerivedSources.pro: Copied from DerivedSources.pro. * Source/WebKit.pri: Renamed from WebKit.pri. * Source/WebKit.pro: Added. * Source/common.pri: Renamed from common.pri. * WebKit.pro: Removed. 2011-01-24 Andras Becsi <abecsi@webkit.org> Reviewed by Csaba Osztrogonác. [Qt] Move project files into Source https://bugs.webkit.org/show_bug.cgi?id=52891 * JavaScriptCore.pri: * JavaScriptCore.pro: * jsc.pro: 2011-01-24 Andras Becsi <abecsi@webkit.org> Reviewed by Csaba Osztrogonác. [Qt] Move project files into Source https://bugs.webkit.org/show_bug.cgi?id=52891 No new tests needed. * WebCore.pri: * WebCore.pro: 2011-01-24 Andras Becsi <abecsi@webkit.org> Reviewed by Csaba Osztrogonác. [Qt] Move project files into Source https://bugs.webkit.org/show_bug.cgi?id=52891 * declarative/declarative.pro: * docs/docs.pri: * tests/tests.pri: 2011-01-24 Andras Becsi <abecsi@webkit.org> Reviewed by Csaba Osztrogonác. [Qt] Move project files into Source https://bugs.webkit.org/show_bug.cgi?id=52891 * DerivedSources.pro: * WebKit2.pro: * WebProcess.pro: 2011-01-24 Andras Becsi <abecsi@webkit.org> Reviewed by Csaba Osztrogonác. [Qt] Move project files into Source https://bugs.webkit.org/show_bug.cgi?id=52891 * DerivedSources.pro: Renamed from DerivedSources.pro. * DumpRenderTree/qt/DumpRenderTree.pro: * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: * MiniBrowser/DerivedSources.pro: * MiniBrowser/qt/MiniBrowser.pro: * QtTestBrowser/QtTestBrowser.pro: * Scripts/webkitdirs.pm: * Tools.pro: Added. * WebKitTestRunner/DerivedSources.pro: * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: * WebKitTestRunner/qt/WebKitTestRunner.pro: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76496 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tkent@chromium.org authored
Fix a Chromium-only assertion failure by r76491. https://bugs.webkit.org/show_bug.cgi?id=38982 Separate icon loading from the FileChooser constructor in order to avoid ref() before adoptRef(). * platform/FileChooser.cpp: (WebCore::FileChooser::FileChooser): (WebCore::FileChooser::initialize): (WebCore::FileChooser::create): * platform/FileChooser.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
morrita@google.com authored
Reviewed by Kent Tamura. TextControlInnerElement::m_shadowParent should be removed. https://bugs.webkit.org/show_bug.cgi?id=52998 No new tests. No behavioral change. * rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::TextControlInnerElement): * rendering/TextControlInnerElements.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76494 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yurys@chromium.org authored
Reviewed by Pavel Feldman. REGRESSION (r72895): console.trace crashes https://bugs.webkit.org/show_bug.cgi?id=52981 - Use local RefPtr variable for accessing PassRefPtr arguments to make sure the PassRefPtr has non-null value. - Use PassRefPtr for objects whos ownership is passed to the inspector. * GNUmakefile.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * inspector/InspectorConsoleInstrumentation.h: Added. Extract inline methods called from the console into their own header to reduce compilation time of other classes that depend on the inspector instrumentation. (WebCore::InspectorInstrumentation::addMessageToConsole): (WebCore::InspectorInstrumentation::consoleCount): (WebCore::InspectorInstrumentation::startConsoleTiming): (WebCore::InspectorInstrumentation::stopConsoleTiming): (WebCore::InspectorInstrumentation::consoleMarkTimeline): (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole): (WebCore::InspectorInstrumentation::addProfile): (WebCore::InspectorInstrumentation::profilerEnabled): (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName): * inspector/InspectorDatabaseInstrumentation.h: Added. Extract inline methods called from the datanase code into their own header to reduce compilation time of other classes that depend on the inspector instrumentation. (WebCore::InspectorInstrumentation::didOpenDatabase): * inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::addMessageToConsoleImpl): (WebCore::InspectorInstrumentation::consoleCountImpl): (WebCore::InspectorInstrumentation::stopConsoleTimingImpl): (WebCore::InspectorInstrumentation::consoleMarkTimelineImpl): (WebCore::InspectorInstrumentation::addProfileImpl): (WebCore::InspectorInstrumentation::didOpenDatabaseImpl): * inspector/InspectorInstrumentation.h: * page/Console.cpp: use RefPtr local variable instead of accessing PassRefPtr argument directly. (WebCore::Console::addMessage): (WebCore::Console::trace): (WebCore::Console::count): (WebCore::Console::markTimeline): (WebCore::Console::profileEnd): (WebCore::Console::timeEnd): (WebCore::Console::group): (WebCore::Console::groupCollapsed): * storage/Database.cpp: (WebCore::Database::openDatabase): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76493 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yuzo@google.com authored
Unreviewed Chromium test expectation change. Update Chromim test expectations (LINUX/SVG) in response to r76442, again. * platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Added. * platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.txt: Added. * platform/chromium-linux/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Added. * platform/chromium-linux/svg/text/text-hkern-expected.txt: Added. * platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.checksum: Added. * platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.png: Added. * platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.txt: Added. * platform/chromium-linux/svg/text/text-text-04-t-expected.txt: Added. * platform/chromium-linux/svg/text/text-vkern-expected.checksum: Added. * platform/chromium-linux/svg/text/text-vkern-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tkent@chromium.org authored
Reviewed by Darin Fisher. [Chromium] Support icon loading for <input type=file> https://bugs.webkit.org/show_bug.cgi?id=38982 An icon data in Chromium port is represented as WebCore::Image. We don't need OS-specific code anymore. * WebCore.gypi: * platform/graphics/Icon.h: (WebCore::Icon::create): Add Chromium-specific factory. * platform/graphics/chromium/IconChromium.cpp: Added. * platform/graphics/chromium/IconChromiumLinux.cpp: Removed. * platform/graphics/chromium/IconChromiumMac.cpp: Removed. * platform/graphics/chromium/IconChromiumWin.cpp: Removed. * platform/graphics/chromium/PlatformIcon.h: 2010-01-24 Kent Tamura <tkent@chromium.org> Reviewed by Darin Fisher. [Chromium] Support icon loading for <input type=file> https://bugs.webkit.org/show_bug.cgi?id=38982 Implement ChromeClientImpl::chooseIconForFiles(). It delegates loading to WebViewClient::queryIconForFiles(), and an implementation of WebViewClient::queryIconForFiles() loads an icon and passes it to a FileChooser through WebIconLoadingCompletion. * WebKit.gyp: * public/WebIconLoadingCompletion.h: Added. (WebKit::WebIconLoadingCompletion::~WebIconLoadingCompletion): * public/WebViewClient.h: (WebKit::WebViewClient::queryIconForFiles): * src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::chooseIconForFiles): * src/WebIconLoadingCompletionImpl.cpp: Added. (WebKit::WebIconLoadingCompletionImpl::WebIconLoadingCompletionImpl): (WebKit::WebIconLoadingCompletionImpl::~WebIconLoadingCompletionImpl): (WebKit::WebIconLoadingCompletionImpl::didLoadIcon): * src/WebIconLoadingCompletionImpl.h: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76491 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
alex@webkit.org authored
Unreviewed, GTK still does not have TestInputController support. Opened a bug to follow the issue: https://bugs.webkit.org/show_bug.cgi?id=52997 * platform/gtk/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76490 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
morrita@google.com authored
Unreviewed, skipped insert-composition-whitespace.html due to missing DRT feature. * platform/gtk/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76489 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
podivilov@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: move search functions from SourceView to SourceFrame. https://bugs.webkit.org/show_bug.cgi?id=52895 This is the last step before eliminating SourceView and ScriptView since this classes just delegate everything to SourceFrame. * inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.set visible): (WebInspector.SourceFrame.prototype._clearLineHighlight): (WebInspector.SourceFrame.prototype._createTextViewer): (WebInspector.SourceFrame.prototype.performSearch.doFindSearchMatches): (WebInspector.SourceFrame.prototype.performSearch): (WebInspector.SourceFrame.prototype.searchCanceled): (WebInspector.SourceFrame.prototype.jumpToFirstSearchResult): (WebInspector.SourceFrame.prototype.jumpToLastSearchResult): (WebInspector.SourceFrame.prototype.jumpToNextSearchResult): (WebInspector.SourceFrame.prototype.jumpToPreviousSearchResult): (WebInspector.SourceFrame.prototype.showingFirstSearchResult): (WebInspector.SourceFrame.prototype.showingLastSearchResult): (WebInspector.SourceFrame.prototype._jumpToSearchResult): * inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.hide): (WebInspector.SourceView.prototype.searchCanceled): (WebInspector.SourceView.prototype.performSearch): (WebInspector.SourceView.prototype.jumpToFirstSearchResult): (WebInspector.SourceView.prototype.jumpToLastSearchResult): (WebInspector.SourceView.prototype.jumpToNextSearchResult): (WebInspector.SourceView.prototype.jumpToPreviousSearchResult): (WebInspector.SourceView.prototype.showingFirstSearchResult): (WebInspector.SourceView.prototype.showingLastSearchResult): (WebInspector.SourceView.prototype.clearMessages): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76488 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Unreviewed, rolling out r76463. http://trac.webkit.org/changeset/76463 https://bugs.webkit.org/show_bug.cgi?id=52993 It broke canvas/philip/tests/2d.path.stroke.skew.html (Requested by Ossy on #webkit). * platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::rotate): * platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArc): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76487 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
alex@webkit.org authored
Unreviewed, skipped tests failing the 64bits bot and passing in the 32bits bots. Bug following the issue: https://bugs.webkit.org/show_bug.cgi?id=52996 * platform/gtk/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76486 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yuzo@google.com authored
Unreviewed Chromium test expectation change. Update Chromim test expectations (LINUX/SVG) in response to r76442. * platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added. * platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added. * platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt: Added. * platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt: Added. * platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Added. * platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Added. * platform/chromium-linux/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt: Added. * platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt: Added. * platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt: Added. * platform/chromium-linux/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt: Added. * platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: Added. * platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Added. * platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Added. * platform/chromium-linux/svg/W3C-SVG-1.1/text-text-04-t-expected.txt: Added. * platform/chromium-linux/svg/text/text-vkern-on-horizontal-text-expected.txt: Added. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76485 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yuzo@google.com authored
Unreviewed Chromium test expectation change. Update Chromim test expectations (WIN/SVG) in response to r76442. * platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: * platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum: * platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png: * platform/chromium-win/svg/custom/svg-fonts-in-html-expected.txt: * platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.checksum: * platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.png: * platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Added. * platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.checksum: * platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.png: * platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.txt: Added. * platform/chromium-win/svg/text/text-text-04-t-expected.checksum: * platform/chromium-win/svg/text/text-text-04-t-expected.png: * platform/chromium-win/svg/text/text-text-04-t-expected.txt: * platform/chromium-win/svg/text/text-vkern-expected.checksum: * platform/chromium-win/svg/text/text-vkern-expected.png: * platform/chromium-win/svg/text/text-vkern-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76484 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
caseq@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: summary bar is not resized properly with the rest of net https://bugs.webkit.org/show_bug.cgi?id=52881 * inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.updateSidebarWidth): (WebInspector.NetworkPanel.prototype._positionSummaryBar): (WebInspector.NetworkPanel.prototype._toggleGridMode): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76483 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 23 Jan, 2011 2 commits
-
-
morrita@google.com authored
Reviewed by Ryosuke Niwa. Space and tab characters "sent" by an input method give totally different results than typing them directly. https://bugs.webkit.org/show_bug.cgi?id=5241 Added a test that exercises continous whitespace characters and tabs inserted by IME. * editing/inserting/insert-composition-whitespace-expected.txt: Added. * editing/inserting/insert-composition-whitespace.html: Added. 2011-01-19 MORITA Hajime <morrita@google.com> Reviewed by Ryosuke Niwa. Space and tab characters "sent" by an input method give totally different results than typing them directly https://bugs.webkit.org/show_bug.cgi?id=5241 * Introduced TextEvent::InputTypeComposition and TypingCommand::TextCompositionType to distinguish text input which is originated by composition. * Generalized rebalanceWhitespaceAt() to rebalanceWhitespaceOnTextSubstring() to rebalancing range of string on text node, instead of surrounding part of that. Test: editing/inserting/insert-composition-whitespace.html * dom/TextEvent.h: (WebCore::TextEvent::isComposition): * dom/TextEventInputType.h: Added TextEventInputComposition as a member of TextEvent::InputType * editing/CompositeEditCommand.cpp: (WebCore::containsOnlyWhitespace): (WebCore::CompositeEditCommand::shouldRebalanceLeadingWhitespaceFor): (WebCore::CompositeEditCommand::canRebalance): (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring): Added: A generalized version of rebalanceWhitespaceAt(), which takes a range inside Text string. * editing/CompositeEditCommand.h: * editing/Editor.cpp: (WebCore::Editor::insertTextForConfirmedComposition): Added. (WebCore::Editor::insertTextWithoutSendingTextEvent): (WebCore::Editor::confirmComposition): Now uses insertTextForConfirmedComposition(). (WebCore::Editor::setComposition): * editing/Editor.h: * editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): * editing/InsertTextCommand.h: * editing/TypingCommand.cpp: (WebCore::TypingCommand::TypingCommand): (WebCore::TypingCommand::insertText): (WebCore::TypingCommand::insertTextRunWithoutNewlines): * editing/TypingCommand.h: Added TypingCommand::m_compositionType and TypingCommand::TextCompositionType (WebCore::TypingCommand::setCompositionType): Added. (WebCore::TypingCommand::create): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76482 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yuzo@google.com authored
Unreviewed Chromium test expectation change. Update Chromim test expectations (WIN) in response to r76442. * platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added. * platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added. * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt: * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt: * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: * platform/chromium-win/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt: * platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt: * platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt: * platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt: * platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: * platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: * platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: * platform/chromium-win/svg/W3C-SVG-1.1/text-text-04-t-expected.txt: * platform/chromium-win/svg/batik/text/xmlSpace-expected.txt: * platform/chromium-win/svg/text/text-hkern-expected.txt: Added. * platform/chromium-win/svg/text/text-vkern-on-horizontal-text-expected.txt: Added. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76481 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-