1. 12 Jun, 2007 1 commit
  2. 11 Jun, 2007 7 commits
  3. 10 Jun, 2007 5 commits
  4. 09 Jun, 2007 1 commit
    • weinig's avatar
      LayoutTests: · 0d78994a
      weinig authored
              Reviewed by Oliver.
      
              Update test for http://bugs.webkit.org/show_bug.cgi?id=14044
              Autogenerate the JS bindings for HTMLCollection.
      
              * tables/mozilla/bugs/bug53690-1-expected.txt: Now throws Undefined Error instead of Null Error
      
      WebCore:
      
              Reviewed by Oliver.
      
              Patch for http://bugs.webkit.org/show_bug.cgi?id=14044
              Autogenerate the JS bindings for HTMLCollection
      
              - also moves JSHTMLAllCollection into it's own file.
      
              * DerivedSources.make:
              * WebCore.pro:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSHTMLAllCollection.h: Added.
              (WebCore::JSHTMLAllCollection::JSHTMLAllCollection):
              (WebCore::JSHTMLAllCollection::toBoolean):
              (WebCore::JSHTMLAllCollection::masqueradeAsUndefined):
              * bindings/js/JSHTMLCollectionCustom.cpp: Added.
              (WebCore::getNamedItems):
              (WebCore::JSHTMLCollection::callAsFunction):
              (WebCore::JSHTMLCollection::implementsCall):
              (WebCore::JSHTMLCollection::canGetItemsForName):
              (WebCore::JSHTMLCollection::nameGetter):
              (WebCore::JSHTMLCollection::item):
              (WebCore::JSHTMLCollection::namedItem):
              (WebCore::toJS):
              * bindings/js/JSHTMLDocumentCustom.cpp:
              (WebCore::JSHTMLDocument::nameGetter):
              (WebCore::JSHTMLDocument::all):
              * bindings/js/JSXMLHttpRequest.cpp:
              * bindings/js/kjs_html.cpp:
              (WebCore::ImageConstructorImp::ImageConstructorImp):
              (WebCore::ImageConstructorImp::construct):
              * bindings/js/kjs_html.h:
              (WebCore::ImageConstructorImp::implementsConstruct):
              * bindings/js/kjs_window.cpp:
              (KJS::Window::namedItemGetter):
              * bindings/objc/DOMUtility.mm:
              (KJS::createDOMWrapper):
              * bindings/scripts/CodeGeneratorJS.pm:
              * html/HTMLCollection.cpp:
              (WebCore::HTMLCollection::tags):
              * html/HTMLCollection.h:
              (WebCore::HTMLCollection::collectionType):
              * html/HTMLCollection.idl:
              * html/HTMLOptionsCollection.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22080 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d78994a
  5. 08 Jun, 2007 10 commits
  6. 07 Jun, 2007 9 commits
    • hyatt's avatar
      Fix crash. Null check layer. Bug 13984. · 42ffef16
      hyatt authored
              Reviewed by andersca
      
              * WebCore.xcodeproj/project.pbxproj:
              * page/FrameView.cpp:
              (WebCore::FrameView::windowClipRectForLayer):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22062 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42ffef16
    • oliver's avatar
      WebCore: · ac7f5658
      oliver authored
              Reviewed by Justin.
      
              Remove incorrect assertions.
              
              These assertions were made on the assumption that 
              TSM would always call with a range that was contained 
              by an editable region.
              
              TSM may call -[WebHTMLView characterIndexForPoint:] on a mouse
              event that is otherwise unrelated to editing, which may
              be outside the current editing region, triggering these 
              assertions.
      
              * page/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge convertToNSRange:]):
      
      WebKit:
      
              Reviewed by Justin.
              
              Add checks to make sure we don't try to create, use
              or return invalid ranges to TSM when it calls us despite
              not currently being in an editable region.
      
              * WebView/WebHTMLView.mm:
              (isTextInput):
              (-[WebHTMLView textStorage]):
              (-[WebHTMLView firstRectForCharacterRange:]):
              (-[WebHTMLView selectedRange]):
              (-[WebHTMLView attributedSubstringFromRange:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac7f5658
    • justing's avatar
      LayoutTests: · 47d836d7
      justing authored
              Reviewed by John.
      
              <rdar://problem/5237074> REGRESSION: editing/unsupported-content/table-delete-003 is failing (13931)
              
              Corrected the description and added a FIXME:
              * editing/unsupported-content/table-delete-003-expected.checksum:
              * editing/unsupported-content/table-delete-003-expected.png:
              * editing/unsupported-content/table-delete-003-expected.txt:
              * editing/unsupported-content/table-delete-003.html:
      
      WebCore:
      
              Reviewed by John.
              
              <rdar://problem/5237074> REGRESSION: editing/unsupported-content/table-delete-003 is failing (13931)
              
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::initializeStartEnd):
              We wouldn't expand the selection to include a special element 
              at the start of the selection unless the end of the selection 
              was at the end of a special element. Avoid a special 
              element at the start as long as it's fully selected. Ditto for 
              the end.
              * editing/htmlediting.cpp:
              (WebCore::positionBeforeContainingSpecialElement):
              (WebCore::positionAfterContainingSpecialElement):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22057 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47d836d7
    • andersca's avatar
      Reviewed by Geoff. · 9f2c3782
      andersca authored
              Get rid of Instance::setRootObject and pass the root object to the instance constructor instead.
              
              * bindings/c/c_instance.cpp:
              (KJS::Bindings::CInstance::CInstance):
              * bindings/c/c_instance.h:
              * bindings/jni/jni_instance.cpp:
              (JavaInstance::JavaInstance):
              * bindings/jni/jni_instance.h:
              * bindings/jni/jni_jsobject.cpp:
              (JavaJSObject::convertJObjectToValue):
              * bindings/objc/objc_instance.h:
              * bindings/objc/objc_instance.mm:
              (ObjcInstance::ObjcInstance):
              * bindings/runtime.cpp:
              (KJS::Bindings::Instance::Instance):
              (KJS::Bindings::Instance::createBindingForLanguageInstance):
              * bindings/runtime.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22056 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f2c3782
    • andersca's avatar
      Reviewed by Adam. · ab66911c
      andersca authored
              Don't use a JavaInstance to store the field when all we want to do is to keep the field
              from being garbage collected. Instead, use a JObjectWrapper.
              
              * bindings/jni/jni_instance.h:
              * bindings/jni/jni_runtime.cpp:
              (JavaField::JavaField):
              (JavaField::dispatchValueFromInstance):
              (JavaField::dispatchSetValueToInstance):
              * bindings/jni/jni_runtime.h:
              (KJS::Bindings::JavaField::JavaField):
              (KJS::Bindings::JavaField::operator=):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab66911c
    • weinig's avatar
      LayoutTests: · c0e8e2e6
      weinig authored
              Reviewed by Anders.
      
              Update test for http://bugs.webkit.org/show_bug.cgi?id=14028
              Finish autogenerating the JS bindings for Node
      
              * fast/dom/prototype-chain-expected.txt: DOMNodePrototype is no longer in the prototype chain.
      
      WebCore:
      
              Reviewed by Anders.
      
              Patch for  http://bugs.webkit.org/show_bug.cgi?id=14028
              Finish autogenerating the JS bindings for Node
      
              * DerivedSources.make:
              * WebCore.pro:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSHTMLElementWrapperFactory.cpp:
              (WebCore::createJSHTMLWrapper):
              * bindings/js/JSHTMLElementWrapperFactory.h:
              * bindings/js/JSHTMLOptionElementConstructor.cpp:
              * bindings/js/JSNamedNodeMapCustom.cpp:
              * bindings/js/JSNodeCustom.cpp:
              (WebCore::JSNode::insertBefore):
              (WebCore::JSNode::replaceChild):
              (WebCore::JSNode::removeChild):
              (WebCore::JSNode::appendChild):
              (WebCore::JSNode::mark):
              (WebCore::toJS):
              * bindings/js/JSSVGElementWrapperFactory.cpp:
              (WebCore::createJSSVGWrapper):
              * bindings/js/JSSVGElementWrapperFactory.h:
              * bindings/js/JSXSLTProcessor.cpp:
              (KJS::XSLTProcessorPrototypeFunction::callAsFunction):
              * bindings/js/kjs_binding.cpp:
              (KJS::ScriptInterpreter::getDOMNodeForDocument):
              (KJS::ScriptInterpreter::putDOMNodeForDocument):
              (KJS::ScriptInterpreter::markDOMNodesForDocument):
              (KJS::ScriptInterpreter::updateDOMNodeDocument):
              * bindings/js/kjs_binding.h:
              * bindings/js/kjs_dom.cpp:
              (WebCore::toAttr):
              * bindings/js/kjs_dom.h:
              * bindings/js/kjs_domnode.h: Removed.
              * bindings/objc/DOMUtility.mm:
              (KJS::createDOMWrapper):
              * bindings/scripts/CodeGeneratorJS.pm:
              * dom/Node.h:
              (WebCore::Node::parentElement):
              * dom/Node.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22048 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0e8e2e6
    • adele's avatar
      · 04970ea0
      adele authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04970ea0
    • weinig's avatar
      Another Gdk and Qt build fix. · bf8546f6
      weinig authored
              * WebCore.pro:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22043 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf8546f6
    • weinig's avatar
      Gdk and Qt build fix. · 1ce48569
      weinig authored
              * WebCore.pro:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22042 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ce48569
  7. 06 Jun, 2007 7 commits
    • weinig's avatar
      LayoutTests: · 3843e438
      weinig authored
              Reviewed by Hyatt.
      
              Update tests for http://bugs.webkit.org/show_bug.cgi?id=13973
              Autogenerate most of the rest of kjs_dom.h/cpp
      
              * fast/dom/Window/window-properties-expected.txt:
              * fast/dom/prototype-chain-expected.txt:
      
      WebCore:
      
              Reviewed by Hyatt.
      
              Patch for http://bugs.webkit.org/show_bug.cgi?id=13973
              Autogenerate most of the rest of kjs_dom.h/cpp
      
              - Autogenerate JSNodeList and JSNamedNodeMap.
              - Move JSEventTargetNode, JSNamedNodesCollection, and JSDOMExceptionConstructor 
                into their own files.
              - Rename KJS::DOMEventTargeNode to WebCore::JSEventTargetNode to adhere
                to convention and allow easier code generation.
              - Add JS constructors for JSNodeList and JSNamedNodeMap.
              - Moved more toJS methods into the correct (corresponding) header files.
              - Cleaned up code in order for changes to work.
      
              * DerivedSources.make:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSDOMExceptionConstructor.cpp: Added.
              (WebCore::):
              (WebCore::JSDOMExceptionConstructor::JSDOMExceptionConstructor):
              (WebCore::JSDOMExceptionConstructor::getOwnPropertySlot):
              (WebCore::JSDOMExceptionConstructor::getValueProperty):
              (WebCore::getDOMExceptionConstructor):
              * bindings/js/JSDOMExceptionConstructor.h: Added.
              (WebCore::JSDOMExceptionConstructor::classInfo):
              * bindings/js/JSDOMWindowCustom.cpp: Added.
              (WebCore::JSDOMWindow::customGetOwnPropertySlot):
              * bindings/js/JSDocumentCustom.cpp:
              (WebCore::JSDocument::mark):
              (WebCore::toJS):
              * bindings/js/JSEventTargetNode.cpp: Added.
              (WebCore::JSEventTargetNode::JSEventTargetNode):
              (WebCore::JSEventTargetNode::getOwnPropertySlot):
              (WebCore::JSEventTargetNode::getValueProperty):
              (WebCore::JSEventTargetNode::put):
              (WebCore::JSEventTargetNode::putValueProperty):
              (WebCore::JSEventTargetNode::setListener):
              (WebCore::JSEventTargetNode::getListener):
              (WebCore::JSEventTargetNode::pushEventHandlerScope):
              (WebCore::JSEventTargetNodePrototypeFunction::callAsFunction):
              (WebCore::toEventTargetNode):
              * bindings/js/JSEventTargetNode.h: Added.
              (WebCore::JSEventTargetNode::):
              * bindings/js/JSHTMLElementCustom.cpp:
              * bindings/js/JSHTMLFormElementCustom.cpp:
              (WebCore::JSHTMLFormElement::nameGetter):
              * bindings/js/JSHTMLOptionElementConstructor.cpp:
              * bindings/js/JSNamedNodeMapCustom.cpp: Added.
              (WebCore::JSNamedNodeMap::canGetItemsForName):
              (WebCore::JSNamedNodeMap::nameGetter):
              * bindings/js/JSNamedNodesCollection.cpp: Added.
              (WebCore::):
              (WebCore::JSNamedNodesCollection::JSNamedNodesCollection):
              (WebCore::JSNamedNodesCollection::lengthGetter):
              (WebCore::JSNamedNodesCollection::indexGetter):
              (WebCore::JSNamedNodesCollection::getOwnPropertySlot):
              * bindings/js/JSNamedNodesCollection.h: Added.
              (WebCore::JSNamedNodesCollection::classInfo):
              * bindings/js/JSNodeCustom.cpp: Added.
              (WebCore::toJS):
              * bindings/js/JSNodeListCustom.cpp: Added.
              (WebCore::JSNodeList::callAsFunction):
              (WebCore::JSNodeList::implementsCall):
              (WebCore::JSNodeList::canGetItemsForName):
              (WebCore::JSNodeList::nameGetter):
              * bindings/js/kjs_dom.cpp:
              * bindings/js/kjs_dom.h:
              * bindings/js/kjs_domnode.h:
              * bindings/js/kjs_events.cpp:
              (KJS::JSLazyEventListener::parseCode):
              * bindings/js/kjs_html.cpp:
              (KJS::JSHTMLCollection::getNamedItems):
              * bindings/js/kjs_html.h:
              * bindings/js/kjs_window.cpp:
              (WebCore::toJS):
              * bindings/js/kjs_window.h:
              * bindings/objc/DOMInternal.mm:
              (-[WebScriptObject _initializeScriptDOMNodeImp]):
              * bindings/objc/DOMUtility.mm:
              (KJS::createDOMWrapper):
              * bindings/scripts/CodeGeneratorJS.pm:
              * bridge/mac/WebCoreAXObject.mm:
              * dom/Attr.idl:
              * dom/CharacterData.idl:
              * dom/Document.idl:
              * dom/DocumentFragment.idl:
              * dom/DocumentType.idl:
              * dom/Element.idl:
              * dom/NamedNodeMap.idl:
              * dom/Node.idl:
              * dom/NodeList.idl:
              * page/DOMWindow.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3843e438
    • justing's avatar
      LayoutTests: · c0ada391
      justing authored
              Reviewed by Oliver.
      
              * editing/pasteboard/5245519-expected.checksum: Added.
              * editing/pasteboard/5245519-expected.png: Added.
              * editing/pasteboard/5245519-expected.txt: Added.
              * editing/pasteboard/5245519.html: Added.
      
      WebCore:
      
              Reviewed by Oliver.
              
              <rdar://problem/5245519> CrashTracer: [USER] 457 crashes in Mail at WebCore::CSSComputedStyleDeclaration::copyInheritableProperties()
              
              If the user pastes something into a region that ends up being
              invisible, or if the pasted content contains style spans 
              that are render-less, we'll crash when we try to remove
              redundant styles from style spans.
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::CSSComputedStyleDeclaration::copyInheritableProperties):
              Add null checks.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22038 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0ada391
    • justing's avatar
      LayoutTests: · 735d3b21
      justing authored
              Reviewed by Harrison.
      
              <rdar://problem/4889598> Problems with moveDown: and moveUp: in Notes with ToDos
      
              * editing/selection/4889598-expected.checksum: Added.
              * editing/selection/4889598-expected.png: Added.
              * editing/selection/4889598-expected.txt: Added.
              * editing/selection/4889598.html: Added.
      
      WebCore:
      
              Reviewed by Harrison.
      
              <rdar://problem/4889598> Problems with moveDown: and moveUp: in Notes with ToDos
              
              The caret would disappear when moving from content above or below
              a ToDo if that ToDo doesn't have any content in it with the same
              x position as the caret. That's because closestLeafChildForXPos
              would return non-editable leaves, and which turn into non-editable
              VisiblePositions, which are invisible.
      
              * editing/visible_units.cpp:
              (WebCore::previousLinePosition): Ask closestLeafForXPos to only
              return editable leaves.
              (WebCore::nextLinePosition): Ditto.
              * rendering/RootInlineBox.cpp:
              (WebCore::isEditableLeaf): Added.
              (WebCore::RootInlineBox::closestLeafChildForXPos): If requested,
              return the closest editable leaf. Removed an early return if the
              position is before the first leaf, it's not really much of an
              optimization.
              * rendering/RootInlineBox.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      735d3b21
    • weinig's avatar
      Reviewed by Anders. · e6e4a469
      weinig authored
              Fix release build.
      
              * bindings/objc/DOM.mm:
              (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]): Add missing null initialization.
              (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]): Add missing null initialization.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22036 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6e4a469
    • weinig's avatar
      LayoutTests: · 79190704
      weinig authored
              Reviewed by Hyatt.
      
              Update results for http://bugs.webkit.org/show_bug.cgi?id=13947
              Finish autogenerating the JS DOM traversal code
      
              * fast/dom/Window/window-properties-expected.txt:
      
      WebCore:
      
              Reviewed by Hyatt.
      
              Patch for http://bugs.webkit.org/show_bug.cgi?id=13947
              Finish autogenerating the JS DOM traversal code
      
              - Completely generate JSNodeFilter.
              - Move JSNodeFilterCondition into its own file
      
              * DerivedSources.make:
              * WebCore.pro:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSNodeFilterCondition.cpp: Copied from WebCore/bindings/js/kjs_traversal.cpp.
              (WebCore::JSNodeFilterCondition::JSNodeFilterCondition):
              (WebCore::JSNodeFilterCondition::mark):
              (WebCore::JSNodeFilterCondition::acceptNode):
              * bindings/js/JSNodeFilterCondition.h: Copied from WebCore/bindings/js/kjs_traversal.h.
              * bindings/js/JSNodeFilterCustom.cpp: Added.
              (WebCore::JSNodeFilter::mark):
              (WebCore::toNodeFilter):
              * bindings/js/kjs_dom.cpp:
              * bindings/js/kjs_traversal.cpp: Removed.
              * bindings/js/kjs_traversal.h: Removed.
              * bindings/js/kjs_window.cpp:
              * bindings/objc/DOM.mm:
              (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
              (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
              * bindings/scripts/CodeGeneratorJS.pm:
              * dom/Document.cpp:
              (WebCore::Document::createNodeIterator):
              (WebCore::Document::createTreeWalker):
              * dom/Document.h:
              * dom/NodeFilter.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      79190704
    • hyatt's avatar
      Make sure to hand back a script object for webkit plugins (the container · c8c6c6d6
      hyatt authored
              view forwards to its plugin child).
      
              Reviewed by sullivan
      
              * Plugins/WebKitPluginContainerView.h:
              * Plugins/WebKitPluginContainerView.mm:
              (-[WebKitPluginContainerView objectForWebScript]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8c6c6d6
    • weinig's avatar
      Reviewed by Mark Rowe. · 46a95b6b
      weinig authored
              Fixes Bug 13996: http://bugs.webkit.org/show_bug.cgi?id=13996
              [Drosera] Items in the file list don't get un-highlighted when 
              files are selected from the file drop-down
      
              * Drosera/debugger.js: currentFile was getting modified before file in the file
              browser got un-highlighted. Changed the order in which the functions execute. 
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46a95b6b