1. 30 Jun, 2006 13 commits
    • darin's avatar
      Reviewed by Darin. · fed93534
      darin authored
              Compilation fixes for Linux/Gdk.
      
              * JavaScriptCore/kjs/interpreter.cpp: added include of signal.h
              * JavaScriptCore/kjs/ExecState.h: added missing class declaration 
              * JavaScriptCore/kjs/ExecState.cpp: case wrong on include of context.h 
              * JavaScriptCore/JavaScriptCoreSources.bkl: added Context.cpp and ExecState.cpp
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15118 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fed93534
    • lweintraub's avatar
      LayoutTests: · f43cbdba
      lweintraub authored
              Reviewed by justin
      
              * editing/execCommand/format-block-with-trailing-br-expected.checksum: Added.
              * editing/execCommand/format-block-with-trailing-br-expected.png: Added.
              * editing/execCommand/format-block-with-trailing-br-expected.txt: Added.
              * editing/execCommand/format-block-with-trailing-br.html: Added.
      
      WebCore:
      
              Reviewed by justin
      
              * editing/VisiblePosition.cpp: Removed is[Not]EqualIgnoringAffinity and made operator== use the logic that ignores affinity.
              * editing/VisiblePosition.h: Ditto.
              (WebCore::operator==):
              * editing/visible_units.cpp:
              (WebCore::isStartOfParagraph): Changed to compare VisiblePositions using ==.
              (WebCore::isEndOfParagraph): Ditto.
              (WebCore::isStartOfBlock): Ditto.
              (WebCore::isEndOfBlock): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15117 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f43cbdba
    • thatcher's avatar
      Versioning · b81e613e
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15115 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b81e613e
    • justing's avatar
      Fixed the test case that I just checked in. · fb47409a
      justing authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15114 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb47409a
    • justing's avatar
      LayoutTests: · 1c4d466c
      justing authored
              Reviewed by levi
      
              * editing/pasteboard/pasting-object-expected.checksum: Added.
              * editing/pasteboard/pasting-object-expected.png: Added.
              * editing/pasteboard/pasting-object-expected.txt: Added.
              * editing/pasteboard/pasting-object.html: Added.
      
      WebCore:
      
              Reviewed by levi
      
              * editing/htmlediting.cpp:
              (WebCore::canHaveChildrenForEditing): Don't insert children into
              object tags while editing.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15113 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c4d466c
    • justing's avatar
      LayoutTests: · 6b8bc83f
      justing authored
              Reviewed by harrison
              
              Added:
              * editing/selection/skip-non-editable-1-expected.txt: Added.
              * editing/selection/skip-non-editable-1.html: Added.
              * editing/selection/skip-non-editable-2-expected.txt: Added.
              * editing/selection/skip-non-editable-2.html: Added.
      
              Equivalent render tree:
              * editing/execCommand/format-block-with-braces-expected.txt:
              
              Fixes:
              * editing/selection/iframe-expected.checksum:
              * editing/selection/iframe-expected.png:
              * editing/selection/iframe-expected.txt:
              * editing/selection/inline-table-expected.checksum:
              * editing/selection/inline-table-expected.png:
              * editing/selection/inline-table-expected.txt:
              * editing/selection/move-between-blocks-no-001-expected.checksum:
              * editing/selection/move-between-blocks-no-001-expected.png:
              * editing/selection/move-between-blocks-no-001-expected.txt:
              * editing/selection/select-box-expected.checksum:
              * editing/selection/select-box-expected.png:
              * editing/selection/select-box-expected.txt:
      
      WebCore:
      
              Reviewed by harrison
              
              <rdar://problem/4598309
              Caret gets stuck when it hits non editable content within an editable body
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=9510>
              Caret will jump out of an editable region
              
              * dom/Position.cpp:
              (WebCore::Position::upstream): Don't move into a new editable region so that 
              candidates that that straddle an editable/non-editable boundary will 
              correspond to different VisiblePositions.
              (WebCore::Position::downstream): Ditto.
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::modifyMovingRightForward): Use VisiblePosition::next(true)
              (WebCore::SelectionController::modifyMovingLeftBackward): Use VisiblePosition::previous(true)
              * editing/VisiblePosition.cpp:
              (WebCore::VisiblePosition::next): Added code to jump to the next editable region as long
              as it has the same highest editable root.
              (WebCore::VisiblePosition::previous): Ditto.
              * editing/VisiblePosition.h:
              * editing/htmlediting.cpp:
              (WebCore::highestEditableRoot): Added, returns the highest editable root of a node if that
              node is in editable content, otherwise 0.
              * editing/htmlediting.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15112 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b8bc83f
    • ddkilzer's avatar
      WebCore: · 50333216
      ddkilzer authored
              Reviewed by Darin.
      
              - Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9358
                REGRESSION: Assertion failure in HTMLInputElement::setValueFromRenderer
                (value == constrainValue(value)) when deleting all text
      
              Test: editing/deleting/delete-all-text-in-text-field-assertion.html
      
              Bug 9661 filed to fix the follow-up issue:
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9661
              textContent returns "\n" for a <br> even if it is collapsed
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::setValueFromRenderer): Work around "\n" value
              when all characters are deleted from a text field.
      
      LayoutTests:
      
              Reviewed by Darin.
      
              - Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9358
                REGRESSION: Assertion failure in HTMLInputElement::setValueFromRenderer
                (value == constrainValue(value)) when deleting all text
      
              * editing/deleting/delete-all-text-in-text-field-assertion-expected.txt: Added.
              * editing/deleting/delete-all-text-in-text-field-assertion.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15111 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50333216
    • thatcher's avatar
      Reviewed by Darin. · 2d77ea36
      thatcher authored
              Only enable shouldCloseWithWindow when ObjC GC is enabled.
              This maintains backwards compatibility with applications
              that expect a WebView to be usable after the window closes.
      
              * WebView/WebView.m:
              (-[WebViewPrivate init]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d77ea36
    • harrison's avatar
      Reviewed by Tim Omernick · 86ef7315
      harrison authored
              <rdar://problem/4609481> Crash calling -[WebScriptObject valueForKey:] when JS disabled
              
              * bridge/mac/FrameMac.mm:
              (WebCore::FrameMac::executionContextForDOM):
              Early return if JS is not enabled.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15109 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86ef7315
    • thatcher's avatar
      Reviewed by Anders. · 186210ba
      thatcher authored
              Call _close in dealloc to ensure we cleanup for backwards
              compatibility. This will safeguard and cleanup even if the
              application doesn't use the new close API yet, like Mail.
      
              * WebView/WebView.m:
              (-[WebView dealloc]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15108 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      186210ba
    • thatcher's avatar
      Reviewed by Tim H. · 3b86bc07
      thatcher authored
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9664
                REGRESSION (r15106): Crash in fast/events/mouseover-mouseout2.html
      
              * page/FrameView.cpp:
              (WebCore::FrameView::handleMouseMoveEvent): Added a check that oldSubframe is
              still a subframe of the view's frame before passing the event to it.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15107 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b86bc07
    • thatcher's avatar
      WebCore: · a6df3ece
      thatcher authored
              Reviewed by Darin.
      
              <rdar://problem/3694163> -[KWQPageState finalize] is incorrect; design change needed
              <rdar://problem/3694165> -[WebCoreFrameBridge finalize] is incorrect; design change needed
      
              Added close methods that need to be called before these
              objects can be released. This ensures proper tear-down under GC.
      
              * WebCore.xcodeproj/project.pbxproj:
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge dealloc]):
              (-[WebCoreFrameBridge finalize]):
              (-[WebCoreFrameBridge close]):
              * bridge/mac/WebCorePageBridge.h:
              * bridge/mac/WebCorePageBridge.mm:
              (-[WebCorePageBridge setMainFrame:]):
              (-[WebCorePageBridge dealloc]):
              (-[WebCorePageBridge finalize]):
              (-[WebCorePageBridge close]):
              (-[WebCorePageBridge mainFrame]):
              (-[WebCorePageBridge setGroupName:]):
              (-[WebCorePageBridge groupName]):
              * kwq/KWQPageState.h:
              * kwq/KWQPageState.mm:
              (-[KWQPageState dealloc]):
              (-[KWQPageState finalize]):
              (-[KWQPageState close]):
      
      WebKit:
      
              Reviewed by Darin.
      
              <rdar://problem/4484405> WebKit leaks, improper tear-down
              <rdar://problem/3694059> -[WebBackForwardList finalize] is incorrect; design change needed
              <rdar://problem/3694103> -[WebFrame finalize] is incorrect; design change needed
              <rdar://problem/3694104> -[WebHTMLView finalize] is incorrect; design change needed
      
              Adds a close method to WebView, this needs to be called when the 
              WebView is no longer needed. To make this easier for the common cases
              there is now an "auto close" on WebView that listens to the view's
              parent window. If the parent window closes and the WebView has no
              hostWindow then the WebView is automatically closed if autoClose is YES.
              To manage WebView closing yourself call setAutoClose: and pass NO.
      
              When a WebView closes it will tear-down and not be usable anymore.
              Close will will called on various other internal objects as a part
              of this, to ensure proper tear-down in GC without relying on finalize.
      
              * History/WebBackForwardList.m:
              (-[WebBackForwardList dealloc]):
              (-[WebBackForwardList finalize]):
              (-[WebBackForwardList _close]):
              * History/WebHistoryItem.m:
              (+[WebHistoryItem _closeObjectsInPendingPageCaches]):
              (+[WebHistoryItem _releaseAllPendingPageCaches]):
              * History/WebHistoryItemPrivate.h:
              * WebCoreSupport/WebFrameBridge.m:
              (-[WebFrameBridge close]):
              (-[WebFrameBridge saveDocumentToPageCache:]):
              (-[WebFrameBridge canGoBackOrForward:]):
              * WebView/WebFrame.m:
              (-[WebFrame _detachFromParent]):
              (-[WebFrame dealloc]):
              (-[WebFrame finalize]):
              * WebView/WebFrameView.m:
              (-[WebFrameView _setWebFrame:]):
              (-[WebFrameView finalize]):
              * WebView/WebHTMLView.m:
              (-[WebHTMLView close]):
              (-[NSArray dealloc]):
              (-[NSArray finalize]):
              * WebView/WebHTMLViewInternal.h:
              * WebView/WebHTMLViewPrivate.h:
              * WebView/WebScriptDebugDelegate.m:
              (-[WebScriptCallFrame _initWithFrame:initWithWebFrame:]):
              (-[WebScriptCallFrame parsedSource:fromURL:sourceId:startLine:errorLine:errorMessage:]):
              (-[WebScriptCallFrame enteredFrame:sourceId:line:]):
              (-[WebScriptCallFrame hitStatement:sourceId:line:]):
              (-[WebScriptCallFrame leavingFrame:sourceId:line:]):
              * WebView/WebScriptDebugDelegatePrivate.h:
              * WebView/WebView.m:
              (-[WebViewPrivate init]):
              (-[WebView _close]):
              (-[WebView dealloc]):
              (-[WebView finalize]):
              (-[WebView viewWillMoveToWindow:]):
              (-[WebView _windowWillClose:]):
              (-[WebView setPreferencesIdentifier:]):
              (-[WebView mainFrame]):
              (-[WebView setHostWindow:]):
              (-[WebView searchFor:direction:caseSensitive:wrap:]):
              (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]):
              (-[WebView close]):
              (-[WebView setAutoClose:]):
              (-[WebView autoClose]):
              (-[WebView _frameViewAtWindowPoint:]):
              * WebView/WebViewPrivate.h:
      
      WebKitTools:
      
              Reviewed by Darin.
      
              Need to call window close so WebView tears-down completly.
      
              * DumpRenderTree/DumpRenderTree.m:
              (main): call [window close]
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a6df3ece
    • ddkilzer's avatar
      WebCore: · 763a68d0
      ddkilzer authored
              Reviewed by Hyatt.
      
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=4874
              Table with absolute bottom positioning is positioned incorrectly
      
              Note: patch originally from Mitz, spruced up by Weinig.
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::calcAbsoluteVerticalValues):
              * rendering/RenderTable.cpp:
              (WebCore::RenderTable::layout):
      
      LayoutTests:
      
              Reviewed by Hyatt.
      
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=4874
              Table with absolute bottom positioning is positioned incorrectly
      
              Note: test case originally from Mitz.
      
              * fast/table/absolute-table-at-bottom-expected.checksum: Added.
              * fast/table/absolute-table-at-bottom-expected.png: Added.
              * fast/table/absolute-table-at-bottom-expected.txt: Added.
              * fast/table/absolute-table-at-bottom.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15105 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      763a68d0
  2. 29 Jun, 2006 14 commits
    • kdecker's avatar
      Reviewed by mjs and timo. · 0717d842
      kdecker authored
              
              Fixed: <rdar://problem/4609119> handleAuthenticationFromResource was removed; needed by the Dashboard
      
              * WebView/WebViewPrivate.h: Added handleAuthenticationFromResource back into the header. Needed by the
              Dashboard, but was removed in r.14028 on 2006-04-23. 
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15104 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0717d842
    • ddkilzer's avatar
      WebCore: · 4645fa8f
      ddkilzer authored
              Reviewed by Justin.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9505
                moveParagraphContentsToNewBlockIfNecessary creates a new block outside the current position
      
              * editing/CompositeEditCommand.cpp:
              Added sanity checking to prevent modifying nodes outside of 
              where we should be
              (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
      
      LayoutTests:
      
              Reviewed by Justin.
      
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9505
               moveParagraphContentsToNewBlockIfNecessary creates a new block outside the current position
      
              * editing/pasteboard/paste-table-002.html: Added.
              * editing/pasteboard/paste-table-002-expected.checksum: Added.
              * editing/pasteboard/paste-table-002-expected.png: Added.
              * editing/pasteboard/paste-table-002-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15103 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4645fa8f
    • beidson's avatar
      Reviewed by Levi. · 980e0e7b
      beidson authored
              In addition to a few small details, logging changes, and style cleanups, this is a stop-gap hack
              for a problem in SQLite's blob handling.  Querying for a blob in a void* form is reproducibly
              returning a corrupt buffer.  The temporary solution is to query for the blob as "quoted text" and
              manually convert the return string into a character buffer.
      
              * icon/IconDatabase.cpp:
              (WebCore::IconDatabase::recreateDatabase):
              (WebCore::IconDatabase::createPrivateTables):
      
              (WebCore::hexToUnsignedChar): These two functions are the text-to-character-data converters for the time being
              (WebCore::hexStringToVector):
      
              (WebCore::IconDatabase::imageDataForIconID):
              (WebCore::IconDatabase::imageDataForIconURL):
              (WebCore::IconDatabase::imageDataForPageURL):
              (WebCore::IconDatabase::iconForPageURL):
              (WebCore::IconDatabase::hasIconForIconURL):
              * icon/IconDatabase.h:  changes the icon data accessors to return a Vector<unsigned char> instead of void*
      
              * icon/SQLStatement.cpp:
              (WebCore::SQLStatement::columnCount):
              (WebCore::SQLStatement::getColumnBlob):
              * icon/SiteIcon.cpp:
              (SiteIcon::getImage):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15102 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      980e0e7b
    • ddkilzer's avatar
      WebCore: · 93a840c0
      ddkilzer authored
              Reviewed by Darin.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9652
                Assertion failure when changing an RTL table cell to display:none
      
              Test: fast/table/rtl-cell-display-none-assert.html
      
              * rendering/RenderTableSection.cpp:
              (WebCore::RenderTableSection::layoutRows): Corrected the index used as
              the last index in the columnPos vector.
      
      LayoutTests:
      
              Reviewed by Darin.
      
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9652
                Assertion failure when changing an RTL table cell to display:none
      
              * fast/table/rtl-cell-display-none-assert-expected.checksum: Added.
              * fast/table/rtl-cell-display-none-assert-expected.png: Added.
              * fast/table/rtl-cell-display-none-assert-expected.txt: Added.
              * fast/table/rtl-cell-display-none-assert.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15101 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93a840c0
    • tomernic's avatar
      Reviewed by Kevin Decker. · 238930bf
      tomernic authored
              <rdar://problem/4608487> REGRESSION: reproducible crash in +[WebCoreFrameBridge supportedImageMIMETypes]
      
              * Plugins/WebPluginDatabase.m:
              (+[WebPluginDatabase setAdditionalWebPlugInPaths:]):
              One might be tempted to add additionalWebPlugInPaths to the global WebPluginDatabase here.
              For backward compatibility with earlier versions of the +setAdditionalWebPlugInPaths: SPI,
              we need to save a copy of the additional paths and not cause a refresh of the plugin DB
              at this time.
              (-[WebPluginDatabase _plugInPaths]):
              Include additionalWebPlugInPaths if this is the global DB.
              (-[WebPluginDatabase refresh]):
              Call -_plugInPaths to get the modified array of paths.  This is similar to what the old code
              (before we had per-WebView plugin search paths).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15100 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      238930bf
    • ddkilzer's avatar
      WebKitTools: · 759e3b6f
      ddkilzer authored
              Reviewed by Darin.
      
              Bug 9615: Buildbot configuration should be in SVN repository
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9615
      
              Import BuildBot configuration files as used by build.webkit.org.
              auth.py has been stubbed out so that slave passwords are not disclosed.
      
              * BuildSlaveSupport/build.webkit.org-config/Makefile: Added.
              * BuildSlaveSupport/build.webkit.org-config/buildbot.css: Added.
              * BuildSlaveSupport/build.webkit.org-config/buildbot.tac: Added.
              * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added.
              * BuildSlaveSupport/build.webkit.org-config/webkit/__init__.py: Added.
              * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py: Added.
              * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py: Added.
              * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py: Added.
              * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py: Added.
              * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py: Added.
              * BuildSlaveSupport/build.webkit.org-config/webkit/status.py: Added.
              * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15099 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      759e3b6f
    • ddkilzer's avatar
      WebKitTools: · 3f45cfc2
      ddkilzer authored
              Reviewed by Darin.
      
              Bug 9614: Nightly builds should notify user if a newer build is available
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9614
      
              * BuildSlaveSupport/build-launcher-app: Write revision number to WebKit.app's VERSION file.
              * BuildSlaveSupport/build-launcher-dmg: Pass revision number to server-side nightly maintenance
              script so it can keep track of the latest revision.
              * Scripts/run-webkit-tests: Pass build-dumprendertree's exit status through correctly.
              * WebKitLauncher/VERSION: Added.  Placeholder for SVN revision number
              * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
              * WebKitLauncher/start.html: Retrieve revision number from VERSION file, and pass it through to
              the nightly start page.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15098 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f45cfc2
    • darin's avatar
      Reviewed by Anders. · 7a4828e0
      darin authored
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9622
                showModalDialog returnValue ignored, function result is always "undefined"
      
              * manual-tests/modal-dialog.html: Added.
              * manual-tests/show-modal-dialog-test.html: Added.
      
              * page/Frame.cpp: (WebCore::Frame::clear): Call KJSProxy::clear with the
              clearWindowProperties parameter instead of not calling it at all when
              clearWindowProperties is false.
      
              * bindings/js/kjs_proxy.h: Add boolean clearWindowProperties parameter.
              * bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::clear): Pass clearWindowProperties
              variable through to Window::clear instead of not calling it at all.
      
              * bindings/js/kjs_window.h: Add boolean clearWindowProperties parameter.
              * bindings/js/kjs_window.cpp: (KJS::Window::clear): If clearWindowProperties
              is false, do only the returnValue work, not the rest of the work.
      
              * manual-tests/modal-dialog.html: Added.
              * manual-tests/show-modal-dialog-test.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15097 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a4828e0
    • mjs's avatar
      Reviewed by Geoff. · 1cf94d1a
      mjs authored
              
              - add headerdoc comments to some of the new JS API headers
      
              * API/JSBase.h:
              * API/JSValueRef.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15096 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1cf94d1a
    • bdakin's avatar
      Reviewed by Hyatt. · 07be7ece
      bdakin authored
              Fix for <rdar://problem/4450615> Add composite mode to background 
              styles
      
              -webkit-background-composite will set a composite mode on a 
              background image.
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::):
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
              * css/CSSPropertyNames.in: Add -webkit-background-composite
              * css/CSSValueKeywords.in: Add all possible values (clear, copy, 
              source-over, source-in, source-out, source-atop, destination-over, 
              destination-in, destination-out, destination-atop, xor, plus-
              darker, highlight, and plus-lighter)
              * css/cssparser.cpp:
              (WebCore::CSSParser::parseValue):
              (WebCore::CSSParser::parseBackgroundProperty):
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
              (WebCore::CSSStyleSelector::mapBackgroundComposite):
              * css/cssstyleselector.h:
              * platform/GraphicsContext.cpp:
              (WebCore::GraphicsContext::drawTiledImage):
              * platform/GraphicsContext.h: drawTiledImage() now takes a 
              composite operator.
              * platform/Image.h: drawTiled() now takes a composite operator.
              * platform/cairo/ImageCairo.cpp:
              (WebCore::Image::drawTiled): Set the composite operator.
              * platform/mac/ImageMac.mm:
              (WebCore::Image::drawTiled): Set the composite operator.
              * platform/win/TemporaryLinkStubs.cpp:
              (Image::drawTiled):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::paintBackgroundExtended): Send the composite 
              operator in the render style over to the graphics context.
              * rendering/render_style.cpp:
              (WebCore::BackgroundLayer::BackgroundLayer):
              (WebCore::BackgroundLayer::operator=):
              (WebCore::BackgroundLayer::operator==):
              (WebCore::BackgroundLayer::fillUnsetProperties):
              (WebCore::BackgroundLayer::cullEmptyLayers):
              * rendering/render_style.h:
              (WebCore::BackgroundLayer::backgroundComposite):
              (WebCore::BackgroundLayer::isBackgroundCompositeSet):
              (WebCore::BackgroundLayer::setBackgroundComposite):
              (WebCore::BackgroundLayer::clearBackgroundComposite):
              (WebCore::RenderStyle::backgroundComposite):
              (WebCore::RenderStyle::initialBackgroundComposite):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15095 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07be7ece
    • tomernic's avatar
      Reviewed by John Sullivan. · 248b1cfb
      tomernic authored
              WebHistoryItem now supports getting and setting arbitrary properties via _transientPropertyForKey: and
              -_setTransientProperty:forKey:.
              For now, these properties do not persist with the rest of the history data.  They are intended to hold transient
              per-history-item state, which is something that was until now difficult for a WebKit client app to do.
              
              * History/WebHistoryItemPrivate.h:
              * History/WebHistoryItem.m:
              (-[WebHistoryItemPrivate dealloc]):
              (-[WebHistoryItem _transientPropertyForKey:]):
              (-[WebHistoryItem _setTransientProperty:forKey:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15094 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      248b1cfb
    • thatcher's avatar
      Reviewed by Harrison. · eb1db16a
      thatcher authored
              Smart insert and delete, continuous spell checking and autoscroll
              can now be used for any WebView, not just editable ones. All of
              these make sense for documents that might contain content editable 
              areas or our new text fields. Autoscroll is usefull for dragging
              for file input controls also.
      
              Added a SPI to toggle WebViews tab key behavior, tabKeyCyclesThroughElements.
              WebHTMLView's _interceptEditingKeyEvent now uses WebView's
              tabKeyCyclesThroughElements state to determine whether or not
              to process tab key events. The idea here is that tabKeyCyclesThroughElements
              will be YES when this WebView is being used in a browser, and we
              desire the behavior where tab moves to the next element in tab order.
              If tabKeyCyclesThroughElements is NO, it is likely that the WebView
              is being embedded as the whole view, as in Mail, and tabs should input
              tabs as expected in a text editor. Using Option-Tab always cycles
              through elements.
      
              * WebView/WebHTMLRepresentation.m:
              (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
              * WebView/WebHTMLView.m:
              (-[NSArray _interceptEditingKeyEvent:]):
              * WebView/WebView.m:
              (-[WebViewPrivate init]):
              (-[WebView _autoscrollForDraggingInfo:timeDelta:]):
              (-[WebView _shouldAutoscrollForDraggingInfo:]):
              (-[WebView validateUserInterfaceItem:]):
              (-[WebView toggleSmartInsertDelete:]):
              (-[WebView toggleContinuousSpellChecking:]):
              (-[WebView setTabKeyCyclesThroughElements:]):
              (-[WebView tabKeyCyclesThroughElements]):
              * WebView/WebViewPrivate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15093 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb1db16a
    • ddkilzer's avatar
      WebCore: · f769e308
      ddkilzer authored
              Reviewed by Darin.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9649
              The no-svg build broke after r15091
      
              * bindings/objc/DOMInternal.h: Added #if XPATH_SUPPORT/#endif.
              * bindings/objc/DOMInternal.mm: Ditto.
              (raiseDOMException):
              * bindings/objc/DOMXPath.h: Ditto.
              * bindings/objc/DOMXPath.mm: Ditto.
              * bindings/objc/DOMXPathInternal.h: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15092 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f769e308
    • andersca's avatar
      WebCore: · e5ae0240
      andersca authored
      2006-06-29  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Tim O.
      
              <rdar://problem/4599760> Objective-C XPath support
              
              * WebCore.xcodeproj/project.pbxproj:
              Add files.
              
              * bindings/objc/DOMInternal.h:
              * bindings/objc/DOMInternal.mm:
              (raiseDOMException):
              Handle XPath exceptions
              
              * bindings/objc/DOMXPath.h: Added.
              (-[DOMXPathNSResolver lookupNamespaceURI:]):
              * bindings/objc/DOMXPath.mm: Added.
              (-[DOMNativeXPathNSResolver dealloc]):
              (-[DOMNativeXPathNSResolver finalize]):
              (-[DOMNativeXPathNSResolver _xpathNSResolver]):
              (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:]):
              (+[DOMNativeXPathNSResolver _xpathNSResolverWith:]):
              (-[DOMNativeXPathNSResolver lookupNamespaceURI:]):
              (-[DOMXPathResult dealloc]):
              (-[DOMXPathResult finalize]):
              (-[DOMXPathResult resultType]):
              (-[DOMXPathResult numberValue]):
              (-[DOMXPathResult stringValue]):
              (-[DOMXPathResult booleanValue]):
              (-[DOMXPathResult singleNodeValue]):
              (-[DOMXPathResult invalidIteratorState]):
              (-[DOMXPathResult snapshotLength]):
              (-[DOMXPathResult iterateNext]):
              (-[DOMXPathResult snapshotItem:]):
              (-[DOMXPathResult _xpathResult]):
              (-[DOMXPathResult _initWithXPathResult:]):
              (+[DOMXPathResult _xpathResultWith:]):
              (-[DOMXPathExpression evaluate:::]):
              (-[DOMXPathExpression _xpathExpression]):
              (-[DOMXPathExpression _initWithXPathExpression:]):
              (+[DOMXPathExpression _xpathExpressionWith:]):
              (-[DOMDocument createExpression::]):
              (-[DOMDocument createNSResolver:]):
              (-[DOMDocument evaluate:::::]):
              * bindings/objc/DOMXPathInternal.h: Added.
              Add Objective-C XPath API.
      
      WebKit:
      
      2006-06-29  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Tim O.
      
              * WebKit.xcodeproj/project.pbxproj:
              Add DOMXPath.h header.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15091 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5ae0240
  3. 28 Jun, 2006 13 commits
    • hyatt's avatar
      WebCore: · 06186597
      hyatt authored
              Add support for custom highlighting to paint at the root line box level
              (and to inflate the box it uses so that it can go outside the bounds of
              the line if necessary).
      
              Reviewed by harrison
      
              * bridge/mac/FrameMac.h:
              * bridge/mac/FrameMac.mm:
              (WebCore::FrameMac::customHighlightLineRect):
              (WebCore::FrameMac::paintCustomHighlight):
              * bridge/mac/WebCoreFrameBridge.h:
              * rendering/InlineTextBox.cpp:
              (WebCore::InlineTextBox::paintCustomHighlight):
              * rendering/RootInlineBox.cpp:
              (WebCore::RootInlineBox::paintCustomHighlight):
              (WebCore::RootInlineBox::paint):
              * rendering/RootInlineBox.h:
      
      WebKit:
      
              Fix custom highlighting so that you can paint the entire line (and go
              outside the bounds of the line).
      
              Reviewed by harrison
      
              * WebCoreSupport/WebFrameBridge.m:
              (-[WebFrameBridge customHighlightRect:forLine:]):
              (-[WebFrameBridge paintCustomHighlight:forBox:onLine:behindText:entireLine:]):
              * WebKit.xcodeproj/project.pbxproj:
              * WebView/WebHTMLViewPrivate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15090 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06186597
    • mjs's avatar
      Reviewed by Anders. · 4ab60f4f
      mjs authored
              
              - fix Frame leak on layout tests
      
              * WebCoreSupport/WebPageBridge.m:
              (-[WebPageBridge outerView]): Return WebFrameView for main frame instead
              of WebView to avoid reference cycle between WebView and Page.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15089 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ab60f4f
    • lweintraub's avatar
      LayoutTests: · 44c00582
      lweintraub authored
              Reviewed by justin
      
              <rdar://problem/4592005> FormatBlock inserts in the wrong place, disregarding editable content
              <rdar://problem/4590763> FormatBlock for paragraph style doesn't work
      
              * editing/execCommand/format-block-with-braces-expected.checksum: Added.
              * editing/execCommand/format-block-with-braces-expected.png: Added.
              * editing/execCommand/format-block-with-braces-expected.txt: Added.
              * editing/execCommand/format-block-with-braces.html: Added.
              * editing/execCommand/indent-list-item-expected.checksum: Added.
              * editing/execCommand/indent-list-item-expected.png: Added.
              * editing/execCommand/indent-list-item-expected.txt: Added.
              * editing/execCommand/indent-list-item.html: Added.
              * editing/execCommand/indent-selection-expected.checksum: Added.
              * editing/execCommand/indent-selection-expected.png: Added.
              * editing/execCommand/indent-selection-expected.txt: Added.
              * editing/execCommand/indent-selection.html: Added.
              * editing/execCommand/outdent-selection-expected.checksum: Added.
              * editing/execCommand/outdent-selection-expected.png: Added.
              * editing/execCommand/outdent-selection-expected.txt: Added.
              * editing/execCommand/outdent-selection.html: Added.
      
      WebCore:
      
              Reviewed by justin
      
              <rdar://problem/4592005> FormatBlock inserts in the wrong place, disregarding editable content
              <rdar://problem/4590763> FormatBlock for paragraph style doesn't work
      
              * dom/Node.cpp:
              (WebCore::Node::rootEditableElement): Return inline nodes
              * editing/FormatBlockCommand.cpp:
              (WebCore::FormatBlockCommand::doApply): Keep from inserting before editable content
              * editing/JSEditor.cpp: Support html braces (<>) around tag names
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15088 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44c00582
    • justing's avatar
      Reviewed by levi · 9b1c7761
      justing authored
              
              svg/custom/text-hit-test.svg was failing
      
              * rendering/RenderContainer.cpp:
              (WebCore::RenderContainer::positionForCoordinates): Don't skip child
              renderers that have a height of 0 when looking for the closest child
              renderer, they may contain content that overflows.
              * rendering/RenderText.cpp:
              (WebCore::RenderText::positionForCoordinates): Fixed typos.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15087 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b1c7761
    • hyatt's avatar
      Make the view source document properly handle <script>. We don't syntax · 884a874e
      hyatt authored
              highlight the JS yet, but it shows up properly now.
      
              Reviewed by john
      
              * WebCore.xcodeproj/project.pbxproj:
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::scriptHandler):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15086 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      884a874e
    • thatcher's avatar
      JavaScriptCore: · d420935a
      thatcher authored
              Prefer the Stabs debugging symbols format until DWARF bugs are fixed.
      
              * JavaScriptCore.xcodeproj/project.pbxproj:
      
      JavaScriptGlue:
      
              Prefer the Stabs debugging symbols format until DWARF bugs are fixed.
      
              * JavaScriptGlue.xcodeproj/project.pbxproj:
      
      WebCore:
      
              Prefer the Stabs debugging symbols format until DWARF bugs are fixed.
      
              * WebCore.xcodeproj/project.pbxproj:
      
      WebKit:
      
              Prefer the Stabs debugging symbols format until DWARF bugs are fixed.
      
              * WebKit.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15085 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d420935a
    • justing's avatar
      Reviewed by levi · c38fed25
      justing authored
              
              Fixed EditActions for InsertHorizontalRule and RemoveFormat.
              
              * editing/JSEditor.cpp:
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand):
              (WebCore::ReplaceSelectionCommand::editingAction):
              * editing/ReplaceSelectionCommand.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15084 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c38fed25
    • aliceli1's avatar
      added google spreadsheets and yahoo mail beta, moved google calendar and yahoo... · c7655e15
      aliceli1 authored
      added google spreadsheets and yahoo mail beta, moved google calendar and yahoo preview to alumni list.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15083 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7655e15
    • lweintraub's avatar
      Build Fix · 5cca1427
      lweintraub authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15082 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5cca1427
    • lweintraub's avatar
      Build Fix. Reviewed by NOBODY · 87392b31
      lweintraub authored
              * editing/IndentOutdentCommand.cpp:
              (WebCore::IndentOutdentCommand::indentRegion):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15081 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87392b31
    • lweintraub's avatar
      LayoutTests: · 613b7e24
      lweintraub authored
              Reviewed by justin
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7568
              Bug 7568: Implement Indent/Outdent
      
              * editing/execCommand/indent-list-item-expected.checksum: Added.
              * editing/execCommand/indent-list-item-expected.png: Added.
              * editing/execCommand/indent-list-item-expected.txt: Added.
              * editing/execCommand/indent-list-item.html: Added.
              * editing/execCommand/indent-selection-expected.checksum: Added.
              * editing/execCommand/indent-selection-expected.png: Added.
              * editing/execCommand/indent-selection-expected.txt: Added.
              * editing/execCommand/indent-selection.html: Added.
              * editing/execCommand/outdent-selection.html: Added.
      
      WebCore:
      
              Reviewed by justin
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7568
              Bug 7568: Implement Indent/Outdent
      
              * WebCore.vcproj/WebCore/WebCore.vcproj: Added IndentOutdentCommand.h/cpp
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * editing/IndentOutdentCommand.cpp: Added.
              (WebCore::IndentOutdentCommand::IndentOutdentCommand):
              (WebCore::enclosingListOrBlockquote):
              (WebCore::IndentOutdentCommand::splitTreeToNode): Splits the DOM tree from a
              descendent node to an ending ancestor, duplicating nodes when necessary. Returns
              the last node split. Used to insert blockquotes at the topmost level.
              (WebCore::IndentOutdentCommand::indentRegion):
              (WebCore::IndentOutdentCommand::outdentParagraph):
              (WebCore::IndentOutdentCommand::outdentRegion):
              (WebCore::IndentOutdentCommand::doApply):
              * editing/IndentOutdentCommand.h: Added.
              (WebCore::IndentOutdentCommand::):
              * editing/JSEditor.cpp: Added the execCommands Indent and Outdent
              * editing/htmlediting.cpp:
              (WebCore::enclosingNodeWithTag): Finds the enclosing node with any specified tag.
              (WebCore::enclosingListChild): Added checks for nill and editable boundaries.
              (WebCore::outermostEnclosingListChild): Returns the highest ancestor list child.
              (WebCore::highestAncestor): Added.
              (WebCore::createElement): Changed the passed in string to a const reference.
              * editing/htmlediting.h:
      
      WebKit:
      
              Reviewed by justin
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7568
              Bug 7568: Implement Indent/Outdent
              Added undo action strings and enum values
      
              * English.lproj/Localizable.strings:
              * WebCoreSupport/WebFrameBridge.m: 
              (-[WebFrameBridge nameForUndoAction:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15080 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      613b7e24
    • darin's avatar
      LayoutTests: · fcd2c934
      darin authored
              Reviewed by Darin and Hyatt.
      
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9561
                REGRESSION: Content property on :before of button causes hang on click or hover
      
              * fast/forms/button-generated-content-expected.checksum: Added.
              * fast/forms/button-generated-content-expected.png: Added.
              * fast/forms/button-generated-content-expected.txt: Added.
              * fast/forms/button-generated-content.html: Added.
      
      WebCore:
      
              Reviewed by Darin and Hyatt.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9561
                REGRESSION: Content property on :before of button causes hang on click or hover
      
              Test: fast/forms/button-generated-content.html
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::setStyle):
              * rendering/RenderButton.cpp:
              (WebCore::RenderButton::updatePseudoChild): Added. Calls updatePseudoChildForObject()
              on the button itself or on its inner div, if it has one.
              * rendering/RenderButton.h:
              (WebCore::RenderButton::createsAnonymousWrapper): Added. Returns true.
              * rendering/RenderContainer.cpp:
              (WebCore::RenderContainer::pseudoChild): Added. Returns the child containing
              generated content of the requested type if there is one, or otherwise the
              child before/after which such generated content should come.
              (WebCore::RenderContainer::updatePseudoChild): Removed the child parameter and moved the guts
              of this method into updatePseudoChildForObject, which this method calls unless the object
              is an anonymous wrapper.
              (WebCore::RenderContainer::updatePseudoChildForObject): Added. Does the what
              updatePseudoChildForObject did previously, but fetches the pseudo style from
              the styledObject parameter.
              * rendering/RenderContainer.h:
              * rendering/RenderInline.cpp:
              (WebCore::RenderInline::setStyle):
              (WebCore::RenderInline::addChildToFlow):
              (WebCore::RenderInline::splitInlines):
              (WebCore::RenderInline::splitFlow):
              * rendering/RenderObject.h:
              (WebCore::RenderObject::createsAnonymousWrapper): Added. This method replaces
              allowsReusingAnonymousChild and returns the opposite of what that method used to
              return. Returns true if the object creates an anonymous child to contain all its
              other children.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15079 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fcd2c934
    • darin's avatar
      Reviewed by Darin. · 35f007a7
      darin authored
              Improved test to check offsetX/Y after dispatching instead of before.
      
              * fast/dom/window-xy-properties.html:
              * fast/dom/window-xy-properties-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15078 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35f007a7