1. 19 Feb, 2011 9 commits
    • commit-queue@webkit.org's avatar
      2011-02-19 Marc-Antoine Ruel <maruel@chromium.org> · fd5c1c74
      commit-queue@webkit.org authored
              Reviewed by James Robinson.
      
              Split webcore_rendering off webcore_remaining to reduce its size for WPO builds
              https://bugs.webkit.org/show_bug.cgi?id=54789
      
              * WebCore.gyp/WebCore.gyp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79112 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd5c1c74
    • atwilson@chromium.org's avatar
      Updated test expectations (more fallout from r78846). · d444b8f6
      atwilson@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79111 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d444b8f6
    • commit-queue@webkit.org's avatar
      2011-02-19 Bill Budge <bbudge@chromium.org> · 9651de5e
      commit-queue@webkit.org authored
              Reviewed by David Levin.
      
              ThreadableLoaderClient needs willSendRequest method
              https://bugs.webkit.org/show_bug.cgi?id=54688
      
              No new tests. Exposes no new functionality
      
              * WebCore.gypi:
              * loader/DocumentThreadableLoader.cpp:
              (WebCore::DocumentThreadableLoader::willSendRequest):
              (WebCore::DocumentThreadableLoader::didReceiveData):
              (WebCore::DocumentThreadableLoader::didReceiveCachedMetadata):
              * loader/DocumentThreadableLoaderClient.h: Added.
              (WebCore::DocumentThreadableLoaderClient::isDocumentThreadableLoaderClient):
              (WebCore::DocumentThreadableLoaderClient::willSendRequest):
              * loader/ThreadableLoaderClient.h:
              (WebCore::ThreadableLoaderClient::isDocumentThreadableLoaderClient):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9651de5e
    • commit-queue@webkit.org's avatar
      2011-02-19 Lukasz Slachciak <l.slachciak@samsung.com> · 437ae416
      commit-queue@webkit.org authored
              Reviewed by Andreas Kling.
      
              [EFL] Use standard WebCore::homeDirectoryPath method instead of reimplementing it
              https://webkit.org/b/54781
      
              * ewk/ewk_main.cpp:
              (_ewk_init_body):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79108 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      437ae416
    • commit-queue@webkit.org's avatar
      2011-02-19 Charlie Reis <creis@chromium.org> · bdaa062c
      commit-queue@webkit.org authored
              Reviewed by Mihai Parparita.
      
              Ensure loading has stopped in HistoryController::goToItem
              https://bugs.webkit.org/show_bug.cgi?id=54517
      
              Tests that going forward within the same document does not stop loading.
      
              * http/tests/navigation/forward-to-fragment-fires-onload.html: Added.
              * http/tests/navigation/forward-to-fragment-fires-onload-expected.txt: Added.
              * http/tests/navigation/resources/forward-to-fragment-fires-onload-2.html: Added.
      2011-02-19  Charlie Reis  <creis@chromium.org>
      
              Reviewed by Mihai Parparita.
      
              Ensure loading has stopped in HistoryController::goToItem
              https://bugs.webkit.org/show_bug.cgi?id=54517
      
              Avoid stopping all loaders in goToItem for same document navigations
              or pseudo-back-forward URLs.  Make HistoryController::goToItem private
              to force callers to go through Page::goToItem.  Also add a callback to
              FrameLoaderClient to let clients decide whether to stop loading first.
      
              Test: http/tests/navigation/forward-to-fragment-fires-onload.html
      
              * loader/EmptyClients.h:
              * loader/FrameLoader.h:
              * loader/FrameLoaderClient.h:
              * loader/HistoryController.cpp:
              * loader/HistoryController.h:
              * page/Page.cpp:
      2011-02-19  Charlie Reis  <creis@chromium.org>
      
              Reviewed by Mihai Parparita.
      
              Ensure loading has stopped in HistoryController::goToItem
              https://bugs.webkit.org/show_bug.cgi?id=54517
      
              Call Page::goToItem instead of HistoryController::goToItem, so that
              FrameLoader::stopAllLoaders is called first.  Also adds a callback in
              FrameLoaderClient for checking for pseudo-back-forward URLs.
      
              Test: http/tests/navigation/forward-to-fragment-fires-onload.html
      
              * src/FrameLoaderClientImpl.cpp:
              (WebKit::FrameLoaderClientImpl::shouldStopLoadingForHistoryItem): Added.
              * src/FrameLoaderClientImpl.h:
              * src/WebFrameImpl.cpp:
      2011-02-19  Charlie Reis  <creis@chromium.org>
      
              Reviewed by Mihai Parparita.
      
              Ensure loading has stopped in HistoryController::goToItem
              https://bugs.webkit.org/show_bug.cgi?id=54517
      
              Add a FrameLoaderClient callback for whether to stop loading before goToItem.
      
              Test: http/tests/navigation/forward-to-fragment-fires-onload.html
      
              * WebCoreSupport/FrameLoaderClientEfl.cpp:
              (WebCore::FrameLoaderClientEfl::shouldStopLoadingForHistoryItem): Added.
              * WebCoreSupport/FrameLoaderClientEfl.h:
      2011-02-19  Charlie Reis  <creis@chromium.org>
      
              Reviewed by Mihai Parparita.
      
              Ensure loading has stopped in HistoryController::goToItem
              https://bugs.webkit.org/show_bug.cgi?id=54517
      
              Add a FrameLoaderClient callback for whether to stop loading before goToItem.
      
              Test: http/tests/navigation/forward-to-fragment-fires-onload.html
      
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              (WebKit::FrameLoaderClientGtk::shouldStopLoadingForHistoryItem): Added.
              * WebCoreSupport/FrameLoaderClientGtk.h:
      2011-02-19  Charlie Reis  <creis@chromium.org>
      
              Reviewed by Mihai Parparita.
      
              Ensure loading has stopped in HistoryController::goToItem
              https://bugs.webkit.org/show_bug.cgi?id=54517
      
              Add a FrameLoaderClient callback for whether to stop loading before goToItem.
      
              Test: http/tests/navigation/forward-to-fragment-fires-onload.html
      
              * WebCoreSupport/FrameLoaderClientHaiku.cpp:
              (WebCore::FrameLoaderClientHaiku::shouldStopLoadingForHistoryItem): Added.
              * WebCoreSupport/FrameLoaderClientHaiku.h:
      2011-02-19  Charlie Reis  <creis@chromium.org>
      
              Reviewed by Mihai Parparita.
      
              Ensure loading has stopped in HistoryController::goToItem
              https://bugs.webkit.org/show_bug.cgi?id=54517
      
              Add a FrameLoaderClient callback for whether to stop loading before goToItem.
      
              Test: http/tests/navigation/forward-to-fragment-fires-onload.html
      
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
              * WebCoreSupport/WebFrameLoaderClient.h:
      2011-02-19  Charlie Reis  <creis@chromium.org>
      
              Reviewed by Mihai Parparita.
      
              Ensure loading has stopped in HistoryController::goToItem
              https://bugs.webkit.org/show_bug.cgi?id=54517
      
              Add a FrameLoaderClient callback for whether to stop loading before goToItem.
      
              Test: http/tests/navigation/forward-to-fragment-fires-onload.html
      
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem): Added.
              * WebCoreSupport/FrameLoaderClientQt.h:
      2011-02-19  Charlie Reis  <creis@chromium.org>
      
              Reviewed by Mihai Parparita.
      
              Ensure loading has stopped in HistoryController::goToItem
              https://bugs.webkit.org/show_bug.cgi?id=54517
      
              Add a FrameLoaderClient callback for whether to stop loading before goToItem.
      
              Test: http/tests/navigation/forward-to-fragment-fires-onload.html
      
              * WebCoreSupport/WebFrameLoaderClient.cpp:
              (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
              * WebCoreSupport/WebFrameLoaderClient.h:
      2011-02-19  Charlie Reis  <creis@chromium.org>
      
              Reviewed by Mihai Parparita.
      
              Ensure loading has stopped in HistoryController::goToItem
              https://bugs.webkit.org/show_bug.cgi?id=54517
      
              Add a FrameLoaderClient callback for whether to stop loading before goToItem.
      
              Test: http/tests/navigation/forward-to-fragment-fires-onload.html
      
              * WebCoreSupport/FrameLoaderClientWinCE.cpp:
              (WebKit::FrameLoaderClientWinCE::shouldStopLoadingForHistoryItem): Added.
              * WebCoreSupport/FrameLoaderClientWinCE.h:
      2011-02-19  Charlie Reis  <creis@chromium.org>
      
              Reviewed by Mihai Parparita.
      
              Ensure loading has stopped in HistoryController::goToItem
              https://bugs.webkit.org/show_bug.cgi?id=54517
      
              Add a FrameLoaderClient callback for whether to stop loading before goToItem.
      
              Test: http/tests/navigation/forward-to-fragment-fires-onload.html
      
              * WebKitSupport/FrameLoaderClientWx.cpp:
              (WebCore::FrameLoaderClientWx::shouldStopLoadingForHistoryItem): Added.
              * WebKitSupport/FrameLoaderClientWx.h:
      2011-02-19  Charlie Reis  <creis@chromium.org>
      
              Reviewed by Mihai Parparita.
      
              Ensure loading has stopped in HistoryController::goToItem
              https://bugs.webkit.org/show_bug.cgi?id=54517
      
              Add a FrameLoaderClient callback for whether to stop loading before goToItem.
      
              Test: http/tests/navigation/forward-to-fragment-fires-onload.html
      
              * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
              (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
              * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79107 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bdaa062c
    • abarth@webkit.org's avatar
      2011-02-19 Adam Barth <abarth@webkit.org> · cc988496
      abarth@webkit.org authored
              Reviewed by Daniel Bates.
      
              Fix xssAuditor/iframe-injection.html
              https://bugs.webkit.org/show_bug.cgi?id=54591
      
              Update expected results to show that we pass.
      
              * http/tests/security/xssAuditor/iframe-injection-expected.txt:
      2011-02-19  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Daniel Bates.
      
              Fix xssAuditor/iframe-injection.html
              https://bugs.webkit.org/show_bug.cgi?id=54591
      
              We should block the iframe src attribute.  Although this technically
              can't be used to run script, it's a pretty easy vector for stealing
              passwords.
      
              * html/parser/XSSFilter.cpp:
              (WebCore::XSSFilter::filterTokenInitial):
              (WebCore::XSSFilter::filterIframeToken):
              * html/parser/XSSFilter.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc988496
    • commit-queue@webkit.org's avatar
      2011-02-19 Lukasz Slachciak <l.slachciak@samsung.com> · c2d86fcc
      commit-queue@webkit.org authored
              Reviewed by Andreas Kling.
      
              Fixed problem with launching EWebLauncher with "run-launcher --efl". Incorrect path referring to non-existing .libs directory ws set.
              https://webkit.org/b/54778
      
              * Scripts/webkitdirs.pm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79105 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2d86fcc
    • tonyg@chromium.org's avatar
      2011-02-18 Tony Gentilcore <tonyg@chromium.org> · 835dd901
      tonyg@chromium.org authored
              Reviewed by Eric Seidel.
      
              Let the parser yield for layout before running scripts
              https://bugs.webkit.org/show_bug.cgi?id=54355
      
              Prior to this patch, the parser would yield to perform a layout/paint before running a
              script only if the script or a stylesheet blocking the script is not loaded yet. Since we
              don't preload scan into the body while parsing the head, typically we'll block on a script
              early in the body that causes us to yield to do the first paint within a reasonable time.
      
              However, I'm planning to change the PreloadScanner to scan into the body from the head.
              That significantly improves overall load time, but would hurt first paint time because
              fewer scripts would be blocked during parsing and thus wouldn't yield.
      
              This change causes us to yield before running scripts if we haven't painted yet (regardless
              of whether or not the script is loaded). In addition to allowing the above mentioned
              PreloadScanner change to be implemented without regressing first paint time, this also
              improves first paint time by itself.
      
              I tested Alexa's top 45 websites using Web Page Replay to control the content and simulate
              bandwidth. This patch improved average first paint time by 1% over an unlimited connection,
              6% over a 1Mbps connection and 11% over a 5Mbps connection. There was no statistically
              signifcant change in page load time.
      
              Within the pages tested, 33 had no statistically significant change in time to first paint,
              12 improved, and none regressed. Of the improved, some of the standouts from the 1Mbps set
              are: 20% on youtube, 37% on wiki, 27% on ebay, 13% on cnn, 16% on espn, 74% on sohu.
      
              * html/parser/HTMLDocumentParser.cpp:
              (WebCore::HTMLDocumentParser::canTakeNextToken): This is the new yield point.
              (WebCore::HTMLDocumentParser::pumpTokenizer): Remove ASSERT that we are not paused. isPaused
              means that we are waiting for a script. Bug 54574 changed pumpTokenizer() so that it does
              the right thing whether we are just before a token or waiting for a script. Now that we may
              yield before a token or before a script, this may be called while paused.
              * html/parser/HTMLParserScheduler.cpp:
              (WebCore::isLayoutTimerActive): Added a FIXME because r52919 changed minimumLayoutDelay()
              to return m_extraLayoutDelay instead of 0 as a minimum. So checking !minimumLayoutDelay()
              no longer works. The fix is to change it to check minimumLayoutDelay() ==
              m_extraLayoutDelay. But this is all the more reason to move this method onto Document. I'll
              do this in a follow up.
              (WebCore::HTMLParserScheduler::checkForYieldBeforeScript): Added.
              * page/FrameView.h:
              (WebCore::FrameView::hasEverPainted): Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79104 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      835dd901
    • commit-queue@webkit.org's avatar
      2011-02-18 Dawit Alemayehu <adawit@kde.org> · 2f3a352e
      commit-queue@webkit.org authored
              Reviewed by Andreas Kling.
      
              [Qt]  Button Element is rendered w/ text off-center.
              https://bugs.webkit.org/show_bug.cgi?id=53373
      
              Test: LayoutTests/fast/forms/button-white-space.html
      
              * platform/qt/RenderThemeQt.cpp:
              (WebCore::RenderThemeQt::adjustButtonStyle):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79103 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f3a352e
  2. 18 Feb, 2011 31 commits