1. 01 Jan, 2013 4 commits
    • barraclough@apple.com's avatar
      Objective-C API for JavaScriptCore · fc381887
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=105889
      
      Reviewed by Filip Pizlo.
      
      ../JavaScriptCore: 
      
      For a detailed description of the API implemented here, see:
          JSContext.h
          APIJSValue.h
          JSVirtualMachine.h
          JSExport.h
      Still to do -
          (1) Shoud rename APIJSValue.h -> JSValue.h (but we'll have to rename JSValue.h first).
          (2) Numerous FIXMEs, all with separate bugs filed.
      
      * API/APIJSValue.h: Added.
          - this Objective-C class is used to reference a JavaScript object.
      * API/JSBase.h:
          - added JS_OBJC_API_ENABLED macro to control ObjC API support.
      * API/JSBlockAdaptor.h: Added.
          - this Objective-C class is used in creating a special NSBlock proxying a JavaScript function.
      * API/JSBlockAdaptor.mm: Added.
      (BlockArgument):
      (BlockArgument::~BlockArgument):
      (BlockArgumentBoolean):
      (BlockArgumentBoolean::get):
      (BlockArgumentNumeric):
      (BlockArgumentNumeric::get):
      (BlockArgumentId):
      (BlockArgumentId::get):
      (BlockArgumentStruct):
      (BlockArgumentStruct::BlockArgumentStruct):
      (BlockArgumentStruct::~BlockArgumentStruct):
      (BlockArgumentStruct::get):
          - decoded arguent type information of a JSBlockAdaptor.
      (BlockArgumentTypeDelegate):
      (BlockArgumentTypeDelegate::typeInteger):
      (BlockArgumentTypeDelegate::typeDouble):
      (BlockArgumentTypeDelegate::typeBool):
      (BlockArgumentTypeDelegate::typeVoid):
      (BlockArgumentTypeDelegate::typeId):
      (BlockArgumentTypeDelegate::typeOfClass):
      (BlockArgumentTypeDelegate::typeBlock):
      (BlockArgumentTypeDelegate::typeStruct):
          - delegate for use in conjunction with parseObjCType.
      (BlockResult):
      (BlockResult::~BlockResult):
      (BlockResultVoid):
      (BlockResultVoid::set):
      (BlockResultInteger):
      (BlockResultInteger::set):
      (BlockResultDouble):
      (BlockResultDouble::set):
      (BlockResultBoolean):
      (BlockResultBoolean::set):
      (BlockResultStruct):
      (BlockResultStruct::BlockResultStruct):
      (BlockResultStruct::~BlockResultStruct):
      (BlockResultStruct::set):
          - decoded result type information of a JSBlockAdaptor.
      (buildBlockSignature):
          - partial step in constructing a signature with stack offset information from one without.
      (-[JSBlockAdaptor initWithBlockSignatureFromProtocol:]):
          - constructor.
      (-[JSBlockAdaptor blockMatchesSignature:]):
          - check whether signature strings match, where only one contains stack frame offsets.
      (-[JSBlockAdaptor blockFromValue:inContext:withException:]):
          - use the adaptor to create a special forwarding block.
      * API/JSCallbackObjectFunctions.h:
      (JSC::::inherits):
          - add missing braces to multiline for statement.
      * API/JSContext.h: Added.
          - this Objective-C class is used to reference a JavaScript context.
      * API/JSContext.mm: Added.
      (-[JSContext init]):
          - constructor.
      (-[JSContext initWithVirtualMachine:]):
          - construct in a given VM (JSGlobalData).
      (-[JSContext evaluateScript:]):
      (-[JSContext globalObject]):
          - evaluate a script, global object accessor.
      (+[JSContext currentContext]):
      (+[JSContext currentThis]):
      (+[JSContext currentArguments]):
          - These methods obtain context, this, arguments from within a callback.
      (-[JSContext virtualMachine]):
          - implementation for .virtualMachine property.
      (-[JSContext objectForKeyedSubscript:]):
      (-[JSContext setObject:forKeyedSubscript:]):
          - support for subscript property access.
      (contextInternalContext):
          - internal accessor to m_context.
      (-[JSContext dealloc]):
          - desctructor.
      (-[JSContext notifyException:]):
      (-[JSContext valueFromNotifyException:]):
      (-[JSContext boolFromNotifyException:]):
          - internal method to record an exception was thrown.
      (-[JSContext beginCallbackWithData:thisValue:argumentCount:arguments:]):
      (-[JSContext endCallbackWithData:]):
          - internal methods to push/pop a callback record.
      (-[JSContext protect:]):
      (-[JSContext unprotect:]):
          - internal methods to add a value to a protect set (used to protect the internal property of JSValue).
      (-[JSContext wrapperForObject:]):
          - internal method to create a wrapper object.
      (WeakContextRef::WeakContextRef):
      (WeakContextRef::~WeakContextRef):
      (WeakContextRef::get):
      (WeakContextRef::set):
          - Helper class to implement a weak reference to a JSContext.
      * API/JSContextInternal.h: Added.
      (CallbackData):
      (WeakContextRef):
          - see API/JSContext.mm for description of internal methods.
      * API/JSExport.h: Added.
          - Provides JSExport protocol & JSExportAs macro.
      * API/JSValue.mm: Added.
      (+[JSValue valueWithObject:inContext:]):
      (+[JSValue valueWithBool:inContext:]):
      (+[JSValue valueWithDouble:inContext:]):
      (+[JSValue valueWithInt32:inContext:]):
      (+[JSValue valueWithUInt32:inContext:]):
      (+[JSValue valueWithNewObjectInContext:]):
      (+[JSValue valueWithNewArrayInContext:]):
      (+[JSValue valueWithNewRegularExpressionFromPattern:flags:inContext:]):
      (+[JSValue valueWithNewErrorFromMessage:inContext:]):
      (+[JSValue valueWithNullInContext:]):
      (+[JSValue valueWithUndefinedInContext:]):
          - Constructors.
      (-[JSValue toObject]):
      (-[JSValue toObjectOfClass:]):
      (-[JSValue toBool]):
      (-[JSValue toDouble]):
      (-[JSValue toInt32]):
      (-[JSValue toUInt32]):
      (-[JSValue toNumber]):
      (-[JSValue toString]):
      (-[JSValue toDate]):
      (-[JSValue toArray]):
      (-[JSValue toDictionary]):
          - Conversion to Objective-C types.
      (-[JSValue valueForProperty:]):
      (-[JSValue setValue:forProperty:]):
      (-[JSValue deleteProperty:]):
      (-[JSValue hasProperty:]):
      (-[JSValue defineProperty:descriptor:]):
          - Property access by property name.
      (-[JSValue valueAtIndex:]):
      (-[JSValue setValue:atIndex:]):
          - Property access by index.
      (-[JSValue isUndefined]):
      (-[JSValue isNull]):
      (-[JSValue isBoolean]):
      (-[JSValue isNumber]):
      (-[JSValue isString]):
      (-[JSValue isObject]):
          - Test JavaScript type.
      (-[JSValue isEqualToObject:]):
      (-[JSValue isEqualWithTypeCoercionToObject:]):
      (-[JSValue isInstanceOf:]):
          - ===, ==, instanceof operators.
      (-[JSValue callWithArguments:]):
      (-[JSValue constructWithArguments:]):
      (-[JSValue invokeMethod:withArguments:]):
          - Call & construct.
      (-[JSValue context]):
          - implementation for .context property.
      (-[JSValue toPoint]):
      (-[JSValue toRange]):
      (-[JSValue toRect]):
      (-[JSValue toSize]):
      (+[JSValue valueWithPoint:inContext:]):
      (+[JSValue valueWithRange:inContext:]):
      (+[JSValue valueWithRect:inContext:]):
      (+[JSValue valueWithSize:inContext:]):
          - Support for NS struct types.
      (-[JSValue objectForKeyedSubscript:]):
      (-[JSValue objectAtIndexedSubscript:]):
      (-[JSValue setObject:forKeyedSubscript:]):
      (-[JSValue setObject:atIndexedSubscript:]):
          - support for subscript property access.
      (isDate):
      (isArray):
          - internal helper functions to check for instances of JS Date, Array types.
      (JSContainerConvertor):
      (Task):
      (JSContainerConvertor::JSContainerConvertor):
      (JSContainerConvertor::isWorkListEmpty):
      (JSContainerConvertor::convert):
      (JSContainerConvertor::add):
      (JSContainerConvertor::take):
          - helper class for tracking state while converting to Array/Dictionary objects.
      (valueToObjectWithoutCopy):
      (containerValueToObject):
      (valueToObject):
      (valueToNumber):
      (valueToString):
      (valueToDate):
      (valueToArray):
      (valueToDictionary):
          - function for converting JavaScript values to Objective-C objects.
      (ObjcContainerConvertor):
      (ObjcContainerConvertor::ObjcContainerConvertor):
      (ObjcContainerConvertor::isWorkListEmpty):
      (ObjcContainerConvertor::convert):
      (ObjcContainerConvertor::add):
      (ObjcContainerConvertor::take):
          - helper class for tracking state while converting to Array/Dictionary values.
      (objectToValueWithoutCopy):
      (objectToValue):
      (valueInternalValue):
          - function for converting Objective-C objects to JavaScript values.
      (+[JSValue valueWithValue:inContext:]):
      (-[JSValue initWithValue:inContext:]):
          - internal constructors.
      (StructTagHandler):
      (getStructTagHandler):
      (+[JSValue selectorForStructToValue:]):
      (+[JSValue selectorForValueToStruct:]):
          - methods to tracking struct types that support conversion to/from JSValue.
      (-[JSValue dealloc]):
          - destructor.
      (-[JSValue description]):
          - Objective-C to-NSString conversion.
      (typeToValueInvocationFor):
      (valueToTypeInvocationFor):
          - create invocation objects for conversion to/from JSValue.
      * API/JSValueInternal.h: Added.
          - see API/JSValue.mm for description of internal methods.
      * API/JSVirtualMachine.h: Added.
          - this Objective-C class is used to reference a JavaScript virtual machine (JSGlobalData).
      * API/JSVirtualMachine.mm: Added.
      (-[JSVirtualMachine init]):
      (-[JSVirtualMachine dealloc]):
          - constructor & destructor.
      (getGroupFromVirtualMachine):
          - internal accessor for m_group property.
      * API/JSVirtualMachineInternal.h: Added.
          - see API/JSVirtualMachine.mm for description of internal methods.
      * API/JSWrapperMap.h: Added.
      * API/JSWrapperMap.mm: Added.
      (wrapperClass):
          - singleton root for detction (& unwrapping) of wrapper objects.
      (selectorToPropertyName):
          - default selector to property name conversion.
      (createObjectWithCustomBrand):
          - creates a JSObject with a custom NativeBrand (class name).
      (createRenameMap):
          - parse @optional properties of a JSExport protocol.
      (putNonEnumerable):
          - property put with enumerable=false.
      (copyMethodsToObject):
          - iterate methods in a protocol; add functions to a JSObject.
      (parsePropertyAttributes):
          - examine protocol property metadata.
      (makeSetterName):
          - "foo" -> "setFoo"
      (copyPrototypeProperties):
          - create properties on a Protocol object reflecting the instance methods & properties of a protocol.
      (-[JSObjCClassInfo initWithContext:forClass:superClassInfo:]):
      (-[JSObjCClassInfo dealloc]):
      (-[JSObjCClassInfo wrapperForObject:]):
      (-[JSObjCClassInfo constructor]):
          - cache the Protocol/Constructor objects for an Objective-C type.
      (-[JSWrapperMap initWithContext:]):
      (-[JSWrapperMap dealloc]):
          - constructor & desctructor.
      (-[JSWrapperMap classInfoForClass:]):
          - maps Class -> JSObjCClassInfo.
      (-[JSWrapperMap wrapperForObject:]):
          - cretae or retrieve a cached wrapper value for an object.
      (tryUnwrapObjcObject):
          - check whether a value is a wrapper object; unwrap if so.
      * API/JavaScriptCore.h:
          - Added includes for new API headers.
      * API/ObjCCallbackFunction.h: Added.
          - this class is used to wrap Objective-C instance methods, class methods & blocks as JSFunction objects.
      * API/ObjCCallbackFunction.mm: Added.
      (CallbackArgument):
      (CallbackArgument::~CallbackArgument):
      (CallbackArgumentBoolean):
      (CallbackArgumentBoolean::set):
      (CallbackArgumentInteger):
      (CallbackArgumentInteger::set):
      (CallbackArgumentDouble):
      (CallbackArgumentDouble::set):
      (CallbackArgumentJSValue):
      (CallbackArgumentJSValue::set):
      (CallbackArgumentId):
      (CallbackArgumentId::set):
      (CallbackArgumentOfClass):
      (CallbackArgumentOfClass::CallbackArgumentOfClass):
      (CallbackArgumentOfClass::~CallbackArgumentOfClass):
      (CallbackArgumentOfClass::set):
      (CallbackArgumentNSNumber):
      (CallbackArgumentNSNumber::set):
      (CallbackArgumentNSString):
      (CallbackArgumentNSString::set):
      (CallbackArgumentNSDate):
      (CallbackArgumentNSDate::set):
      (CallbackArgumentNSArray):
      (CallbackArgumentNSArray::set):
      (CallbackArgumentNSDictionary):
      (CallbackArgumentNSDictionary::set):
      (CallbackArgumentStruct):
      (CallbackArgumentStruct::CallbackArgumentStruct):
      (CallbackArgumentStruct::~CallbackArgumentStruct):
      (CallbackArgumentStruct::set):
      (CallbackArgumentBlockCallback):
      (CallbackArgumentBlockCallback::CallbackArgumentBlockCallback):
      (CallbackArgumentBlockCallback::~CallbackArgumentBlockCallback):
      (CallbackArgumentBlockCallback::set):
          - decoded arguent type information of a ObjCCallbackFunction.
      (ArgumentTypeDelegate):
      (ArgumentTypeDelegate::typeInteger):
      (ArgumentTypeDelegate::typeDouble):
      (ArgumentTypeDelegate::typeBool):
      (ArgumentTypeDelegate::typeVoid):
      (ArgumentTypeDelegate::typeId):
      (ArgumentTypeDelegate::typeOfClass):
      (ArgumentTypeDelegate::typeBlock):
      (ArgumentTypeDelegate::typeStruct):
          - delegate for use in conjunction with parseObjCType.
      (CallbackResult):
      (CallbackResult::~CallbackResult):
      (CallbackResultVoid):
      (CallbackResultVoid::get):
      (CallbackResultId):
      (CallbackResultId::get):
      (CallbackResultNumeric):
      (CallbackResultNumeric::get):
      (CallbackResultBoolean):
      (CallbackResultBoolean::get):
      (CallbackResultStruct):
      (CallbackResultStruct::CallbackResultStruct):
      (CallbackResultStruct::~CallbackResultStruct):
      (CallbackResultStruct::get):
          - decoded result type information of a ObjCCallbackFunction.
      (ResultTypeDelegate):
      (ResultTypeDelegate::typeInteger):
      (ResultTypeDelegate::typeDouble):
      (ResultTypeDelegate::typeBool):
      (ResultTypeDelegate::typeVoid):
      (ResultTypeDelegate::typeId):
      (ResultTypeDelegate::typeOfClass):
      (ResultTypeDelegate::typeBlock):
      (ResultTypeDelegate::typeStruct):
          - delegate for use in conjunction with parseObjCType.
      (ObjCCallbackFunction):
      (ObjCCallbackFunction::ObjCCallbackFunction):
      (ObjCCallbackFunction::~ObjCCallbackFunction):
          - constructor & destructor.
      (ObjCCallbackFunction::context):
          - accessor.
      (ObjCCallbackFunction::wrappedBlock):
          - attemmpt to unwrap a block object.
      (objCCallbackFunctionFinalize):
      (objCCallbackFunctionCallAsFunction):
      (objCCallbackFunctionClass):
          - JSClassRef used to represent ObjCCallbackFunction objects.
      (ObjCCallbackFunction::call):
      (blockSignatureContainsClass):
          - helper function to determine if we're running on a recent Clang.
      (skipNumber):
          - helper used in parsing signature strings.
      (objCCallbackFunctionForInvocation):
      (objCCallbackFunctionForMethod):
      (objCCallbackFunctionForBlock):
          - functions to try to create ObjCCallbackFunction instances for methods/blocks.
      (tryUnwrapBlock):
          - attemmpt to unwrap a block object.
      * API/ObjcRuntimeExtras.h: Added.
      (protocolImplementsProtocol):
      (forEachProtocolImplementingProtocol):
      (forEachMethodInClass):
      (forEachMethodInProtocol):
      (forEachPropertyInProtocol):
          - functions used in reflecting on Objective-C types.
      (skipPair):
          - parsing helper used by parseObjCType, scans for matching parentheses.
      (StringRange):
      (StringRange::StringRange):
      (StringRange::~StringRange):
      (StringRange::operator const char*):
      (StringRange::get):
          - Helper class - create a c string copy of a range of an existing string.
      (parseObjCType):
          - function to parse Objective-C type strings, makes callbacks to a deleagte.
      * API/tests/testapi.c:
      (main):
          - added call to testObjectiveCAPI (in testapi.m).
      * API/tests/testapi.m: Added.
      (+[ParentObject parentTest]):
      (+[TestObject testObject]):
      (+[TestObject classTest]):
      (-[TestObject getString]):
      (-[TestObject testArgumentTypesWithInt:double:boolean:string:number:array:dictionary:]):
      (-[TestObject callback:]):
      (-[TextXYZ test:]):
          - test object, used in various test vases.
      (checkResult):
          - helper function.
      (blockSignatureContainsClass):
          - helper function to determine if we're running on a recent Clang.
      (testObjectiveCAPI):
          - new test cases.
      * JavaScriptCore.xcodeproj/project.pbxproj:
          - added new files.
      * runtime/JSGlobalData.cpp:
      (JSC::JSGlobalData::JSGlobalData):
      * runtime/JSGlobalData.h:
      (JSGlobalData):
          - added m_apiData - provide convenient storage for use by the API.
      * runtime/JSGlobalObject.cpp:
      (JSC::JSGlobalObject::JSGlobalObject):
      * runtime/JSGlobalObject.h:
      (JSGlobalObject):
          - added m_apiData - provide convenient storage for use by the API.
      
      ../WTF: 
      
      * wtf/WTFThreadData.cpp:
      (WTF::WTFThreadData::WTFThreadData):
      * wtf/WTFThreadData.h:
      (WTFThreadData):
          - Added m_apiData - provide convenient storage for use by the API.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc381887
    • commit-queue@webkit.org's avatar
      sheriff-bot should know who the gardeners/sheriffs are · 3e7471ac
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105698
      
      Patch by Alan Cutter <alancutter@chromium.org> on 2013-01-01
      Reviewed by Eric Seidel.
      
      Added a "sheriffs" command to sheriffbot to fetch the current Chromium Webkit sheriffs.
      
      * Scripts/webkitpy/tool/bot/irc_command.py:
      (Current):
      (Current._retrieve_webkit_sheriffs):
      (Current.execute):
      * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
      (IRCCommandTest.test_current):
      * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_0.js: Added.
      * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_1.js: Added.
      * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_2.js: Added.
      * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_malformed.js: Added.
      * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_zero.js: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138603 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e7471ac
    • commit-queue@webkit.org's avatar
      [EFL][WK1] Skip some webaudio test cases due to lack of implementation · acace98f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105882
      
      Unreviewed, EFL gardening.
      
      Bunch of webaudio test cases need setAudioData implementation and DRT has not it.
      So, skips those cases.
      
      Patch by Kangil Han <kangil.han@samsung.com> on 2013-01-01
      
      * platform/efl-wk1/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138602 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      acace98f
    • mkwst@chromium.org's avatar
      seamless iframes don't inherit styles when srcdoc is used · ba68e971
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=103539
      
      Reviewed by Eric Seidel.
      
      Source/WebCore:
      
      Seamless iframes populated via a 'srcdoc' attribute should always
      inherit styles from their parent documents. At the moment, this is
      only the case when they contain a stylesheet or some other markup
      that forces a style recalculation on the document. Simple 'srcdoc'
      attributes (e.g. "srcdoc='<p>This is a comment.</p>'") bail out of
      recalculating style early, resulting in unstyled appearance.
      
      This patch instructs WebCore to treat seamless documents as having an
      updated StyleResolver regardless of what actions the parser takes,
      which in turn ensures that the document's style is recalculated
      correctly.
      
      Test: fast/frames/seamless/seamless-srcdoc.html
      
      * dom/Document.cpp:
      (WebCore::Document::finishedParsing):
          If it's a seamless document, notify it that its StyleResolver isn't
          what it might have expected.
      
      LayoutTests:
      
      * fast/frames/seamless/resources/span.html: Added.
      * fast/frames/seamless/seamless-contenteditable-not-inherited-expected.txt:
          Updating the previously FAILing expectation.
      * fast/frames/seamless/seamless-srcdoc-expected.txt: Added.
      * fast/frames/seamless/seamless-srcdoc.html: Added.
          Exciting new test to ensure that this doesn't regress, neither
          for totally simple srcdoc attriubtes, nor for slightly more
          complex variations.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba68e971
  2. 31 Dec, 2012 14 commits
    • commit-queue@webkit.org's avatar
      [BlackBerry] Fullscreen Media Time Indicators Background Incorrect · 50a30af9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105888
      
      Patch by Jeff Rogers <jrogers@rim.com> on 2012-12-31
      Reviewed by George Staikos.
      
      Internal PR 272699.
      Update fullscreen media controls CSS to fix time container background
      color. Also fix transparency to be 80% opaque to and the time
      remaining text color to match the system player.
      
      No new tests as there is no functionality change.
      
      * css/mediaControlsBlackBerryFullscreen.css:
      (video:-webkit-full-screen::-webkit-media-controls-panel):
      (video:-webkit-full-screen::-webkit-media-controls-fullscreen-time-display-container):
      (video:-webkit-full-screen::-webkit-media-controls-fullscreen-timeline-container):
      (video:-webkit-full-screen::-webkit-media-controls-fullscreen-current-time-display):
      (video:-webkit-full-screen::-webkit-media-controls-fullscreen-time-remaining-display):
      (video:-webkit-full-screen::-webkit-media-controls-fullscreen-button-container, video:-webkit-full-screen::-webkit-media-controls-play-button-container):
      (video:-webkit-full-screen::-webkit-media-controls-placeholder):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50a30af9
    • weinig@apple.com's avatar
      Add supplementability for WebContext · 15f97af4
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=105878
      
      Reviewed by Dan Bernstein.
      
      Add WebContextSupplement and convert WebApplicationCacheManagerProxy to it.
      
      * UIProcess/API/C/WKContext.cpp:
      (WKContextGetApplicationCacheManager):
      * UIProcess/WebApplicationCacheManagerProxy.cpp:
      (WebKit::WebApplicationCacheManagerProxy::supplementName):
      (WebKit::WebApplicationCacheManagerProxy::WebApplicationCacheManagerProxy):
      (WebKit::WebApplicationCacheManagerProxy::contextDestroyed):
      (WebKit::WebApplicationCacheManagerProxy::processDidClose):
      (WebKit::WebApplicationCacheManagerProxy::refWebContextSupplement):
      (WebKit::WebApplicationCacheManagerProxy::derefWebContextSupplement):
      (WebKit::WebApplicationCacheManagerProxy::getApplicationCacheOrigins):
      (WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin):
      (WebKit::WebApplicationCacheManagerProxy::deleteAllEntries):
      * UIProcess/WebApplicationCacheManagerProxy.h:
      (WebApplicationCacheManagerProxy):
      * UIProcess/WebContext.cpp:
      (WebKit::WebContext::WebContext):
      (WebKit::WebContext::~WebContext):
      (WebKit::WebContext::shouldTerminate):
      (WebKit::WebContext::disconnectProcess):
      * UIProcess/WebContext.h:
      (WebKit::WebContext::supplement):
      (WebKit::WebContext::addSupplement):
      * UIProcess/WebContextSupplement.h: Added.
      (WebKit::WebContextSupplement::WebContextSupplement):
      (WebKit::WebContextSupplement::~WebContextSupplement):
      (WebKit::WebContextSupplement::ref):
      (WebKit::WebContextSupplement::deref):
      (WebKit::WebContextSupplement::context):
      (WebKit::WebContextSupplement::clearContext):
      * WebKit2.xcodeproj/project.pbxproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15f97af4
    • commit-queue@webkit.org's avatar
      [EFL][WebGL] Add compile time support for GLES2. · 07db8010
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105816
      
      Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-31
      Reviewed by Kenneth Rohde Christiansen.
      
      .:
      
      This patch adds build support for GLES2.
      GLES2 support can be enabled during compile time by passing -DENABLE_GLES2=ON as
      cmake config parameter. GLES2 options is not enabled by default. This patch doesn't
      address all the build issues related to GLES2 but only adds the needed support in
      OptionsEfl.cmake.
      
      * Source/cmake/OptionsEfl.cmake:
      
      Source/WebCore:
      
      This patch adds build support for GLES2.
      GLES2 support can be enabled during compile time by passing -DENABLE_GLES2=ON as
      cmake config parameter. GLES2 options is not enabled by default. This patch doesn't
      address all the build issues related to GLES2 but only adds the needed support in
      PlatformEfl.cmake.
      
      * PlatformEfl.cmake:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138598 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07db8010
    • christophe.dumez@intel.com's avatar
      [EFL[WK2] Regression(r138574): Should not allocate memory in the fork · 6ef404f4
      christophe.dumez@intel.com authored
      https://bugs.webkit.org/show_bug.cgi?id=105868
      
      Reviewed by Kenneth Rohde Christiansen.
      
      Store prefixed executable path in a CString before the fork to
      avoid allocating memory in the fork by calling String::utf8().
      Allocating memory in the fork may lead to deadlocks due to
      FastMalloc and the fork not inheriting the threads.
      
      * UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
      (WebKit::ProcessLauncher::launchProcess):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ef404f4
    • commit-queue@webkit.org's avatar
      [BlackBerry] The HTML5 video fullscreen time indicator on the right cuts... · 8d9149dd
      commit-queue@webkit.org authored
      [BlackBerry] The HTML5 video fullscreen time indicator on the right cuts clipped when the video is longer than 1 hour
      https://bugs.webkit.org/show_bug.cgi?id=105887
      
      Patch by Andy Chen <andchen@rim.com> on 2012-12-31
      Reviewed by George Staikos.
      
      The width of the time part was fixed. Remove it.
      
      No new test is required because no functionality change.
      
      * platform/blackberry/RenderThemeBlackBerry.cpp:
      (WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138596 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d9149dd
    • commit-queue@webkit.org's avatar
      [GTK] Move ImageDiff to the Tools directory root · f6e9a821
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105421
      
      Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2012-12-31
      Reviewed by Kenneth Rohde Christiansen.
      
      .:
      
      * GNUmakefile.am: Remove the old ImageDiff makefile include.
      
      Tools:
      
      * DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Removed.
      * GNUmakefile.am:
      * ImageDiff/gtk/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/gtk/ImageDiff.cpp.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6e9a821
    • commit-queue@webkit.org's avatar
      [EFL] css3/masking/clip-path-circle-relative-overflow.html needs expected... · 8112f420
      commit-queue@webkit.org authored
      [EFL] css3/masking/clip-path-circle-relative-overflow.html needs expected results update after 97217
      https://bugs.webkit.org/show_bug.cgi?id=105883
      
      Unreviewed, EFL gardening.
      
      Rebaseline css3/masking/clip-path-circle-relative-overflow.html because BUG 97217 has been resolved.
      
      Patch by Kangil Han <kangil.han@samsung.com> on 2012-12-31
      
      * platform/efl/TestExpectations:
      * platform/efl/css3/masking/clip-path-circle-relative-overflow-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8112f420
    • carlosgc@webkit.org's avatar
      [GTK] Add API to set a WebKitWebView in view source mode to WebKit2 · 0b348409
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=99315
      
      Reviewed by Martin Robinson.
      
      Add a generic API to set/get a view mode. For now there are only
      two modes, Web and Source, but the API can be extended if we
      eventually support other view modes like Printing for example.
      
      * UIProcess/API/gtk/WebKitWebView.cpp:
      (webkitWebViewSetProperty): Implement setter for view-mode
      property.
      (webkitWebViewGetProperty): Implement getter for view-mode
      property.
      (webkit_web_view_class_init): Add view-source property.
      (webkit_web_view_set_view_mode): Public method to set the view
      mode.
      (webkit_web_view_get_view_mode): Public method to get the view
      mode.
      * UIProcess/API/gtk/WebKitWebView.h: Add WebKitViewMode enum.
      * UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
      * UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
      (testWebViewMode):
      (beforeAll):
      * UIProcess/WebFrameProxy.cpp:
      (WebKit::WebFrameProxy::WebFrameProxy): Initialize
      m_inViewSourceMode.
      (WebKit::WebFrameProxy::setInViewSourceMode): Set
      m_inViewSourceMode if it has changed and call
      WebPageProxy::setFrameInViewSourceMode() to notify the WebProcess.
      * UIProcess/WebFrameProxy.h:
      (WebKit::WebFrameProxy::inViewSourceMode): Return whether the
      frame is currently in view source mode.
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::setFrameInViewSourceMode): Send a message
      to the WebProcess to set the given frame in view source mode or not.
      * UIProcess/WebPageProxy.h:
      (WebPageProxy): Add setFrameInViewSourceMode().
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::setFrameInViewSourceMode): Call
      setInViewSourceMode for the main frame.
      * WebProcess/WebPage/WebPage.h:
      (WebPage): Add setFrameInViewSourceMode().
      * WebProcess/WebPage/WebPage.messages.in: Add new message
      SetFrameInViewSourceMode.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b348409
    • christophe.dumez@intel.com's avatar
      Unreviewed EFL gardening. · 7c93853f
      christophe.dumez@intel.com authored
      Mark editing/spelling/spelling-insert-html.html as flaky
      since it sometimes hits an assertion in RenderObject
      destructor.
      
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138592 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c93853f
    • christophe.dumez@intel.com's avatar
      Unreviewed EFL gardening. · 2a1ba205
      christophe.dumez@intel.com authored
      Mark fast/dom/Range/range-extract-contents.html as flaky
      since it sometimes hits an assertion in
      WebCore::endOfContinuations().
      
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a1ba205
    • christophe.dumez@intel.com's avatar
      Unreviewed EFL gardening. · 4a8f5471
      christophe.dumez@intel.com authored
      Mark editing/pasteboard/4806874.html as flaky since
      it sometimes hits an assertion in RenderObject
      destructor.
      
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138590 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a8f5471
    • christophe.dumez@intel.com's avatar
      Unreviewed EFL gardening. · 63e6ae16
      christophe.dumez@intel.com authored
      Rebaseline fast/js/global-constructors.html after
      TEMPLATE_ELEMENT was enabled for EFL port in r138586.
      
      * platform/efl/fast/js/global-constructors-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63e6ae16
    • commit-queue@webkit.org's avatar
      [EFL] [WebGL] Rename EGLConfigHelper as EGLConfigSelector. · 2597de4f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105876
      
      Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-30
      Reviewed by Kenneth Rohde Christiansen.
      
      This is to sync the naming conventions of our classes in both EGL and GLX implementations.
      In our GLX implementation, class responsible for the same functionality is named as GLXConfigSelector.
      This patch renames EGLConfigHelper as EGLConfigSelector.
      
      .:
      
      * Source/cmake/OptionsEfl.cmake:
      
      Source/WebCore:
      
      * PlatformEfl.cmake:
      * platform/graphics/surfaces/egl/EGLConfigSelector.cpp: Renamed from Source/WebCore/platform/graphics/surfaces/egl/EGLConfigHelper.cpp.
      (WebCore):
      (WebCore::SharedEGLDisplay::deref):
      (WebCore::SharedEGLDisplay::sharedEGLDisplay):
      (WebCore::SharedEGLDisplay::SharedEGLDisplay):
      (WebCore::SharedEGLDisplay::cleanup):
      (WebCore::SharedEGLDisplay::~SharedEGLDisplay):
      (WebCore::EGLConfigSelector::EGLConfigSelector):
      (WebCore::EGLConfigSelector::~EGLConfigSelector):
      (WebCore::EGLConfigSelector::display):
      (WebCore::EGLConfigSelector::pBufferContextConfig):
      (WebCore::EGLConfigSelector::surfaceContextConfig):
      (WebCore::EGLConfigSelector::nativeVisualId):
      (WebCore::EGLConfigSelector::reset):
      (WebCore::EGLConfigSelector::createConfig):
      * platform/graphics/surfaces/egl/EGLConfigSelector.h: Renamed from Source/WebCore/platform/graphics/surfaces/egl/EGLConfigHelper.h.
      (WebCore):
      (SharedEGLDisplay):
      (WebCore::SharedEGLDisplay::create):
      (EGLConfigSelector):
      * platform/graphics/surfaces/egl/EGLSurface.cpp:
      (WebCore::EGLWindowTransportSurface::EGLWindowTransportSurface):
      (WebCore::EGLWindowTransportSurface::configuration):
      (WebCore::EGLWindowTransportSurface::destroy):
      * platform/graphics/surfaces/egl/EGLSurface.h:
      (EGLWindowTransportSurface):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138588 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2597de4f
    • mkwst@chromium.org's avatar
      Add myself to watchlists for CSP and console logs. · 6a3eb73c
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105874
      
      Reviewed by Dirk Pranke.
      
      Because I really, really, really need more email.
      
      * Scripts/webkitpy/common/config/committers.py:
          Add mkwst+watchlist@chromium.org as a contributor.
      * Scripts/webkitpy/common/config/watchlist:
          Create watchlist categories for 1) the various mechanisms used to
          generate console messages, and 2) CSP usage and files.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138587 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a3eb73c
  3. 30 Dec, 2012 14 commits
  4. 29 Dec, 2012 8 commits
    • dglazkov@chromium.org's avatar
      Rename StyleResolver's member variable that holds SelectorChecker to a proper name. · 2c4c7ee2
      dglazkov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105864
      
      In https://bugs.webkit.org/show_bug.cgi?id=105660#c11, Antti suggested renaming m_checker to
      m_selectorChecker. I've forgotten about that, but now I remembered it.
      
      Reviewed by Eric Seidel.
      
      No change in functionality, covered by existing tests.
      
      * css/StyleResolver.cpp/h: Renamed all instances of m_checker to m_selectorChecker.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138572 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c4c7ee2
    • dglazkov@chromium.org's avatar
      Move pointer to Document up from SelectorChecker to StyleResolver. · 4160a422
      dglazkov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105863
      
      Now that SelectorChecker is mostly stateless, it no longer needs to keep a pointer to Document, which
      makes all the code in StyleResolver that reaches for it sort of weird.
      
      Reviewed by Eric Seidel.
      
      No change in functionality, covered by existing tests.
      
      * css/SelectorChecker.cpp:
      (WebCore::SelectorChecker::SelectorChecker): Changed to take document as argument (only used to set bit fields).
      (WebCore::SelectorChecker::checkOneSelector): Changed to use element document.
      (WebCore::SelectorChecker::checkScrollbarPseudoClass): Ditto.
      * css/SelectorChecker.h:
      (WebCore): Removed unnecessary Document forward declaration.
      (SelectorChecker): Changed constructor declaration, and removed m_document member.
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::StyleResolver): Adjusted SelectorChecker initializer accordingly.
      (WebCore::StyleResolver::initElement): Changed to use own document accessor.
      (WebCore::StyleResolver::initForStyleResolve): Ditto.
      (WebCore::StyleResolver::matchUARules): Ditto.
      (WebCore::StyleResolver::styleForPage): Ditto.
      (WebCore::StyleResolver::applyProperty): Ditto.
      (WebCore::StyleResolver::checkForGenericFamilyChange): Ditto.
      (WebCore::StyleResolver::initializeFontStyle): Ditto.
      (WebCore::StyleResolver::setFontSize): Ditto.
      * css/StyleResolver.h:
      (WebCore::StyleResolver::document): Changed to use own member.
      (WebCore::StyleResolver::documentSettings): Ditto.
      (StyleResolver): Added m_document member.
      * dom/SelectorQuery.cpp:
      (WebCore::SelectorQuery::matches): Changed callsite to reflect new constructor signature.
      (WebCore::SelectorQuery::queryAll): Ditto.
      (WebCore::SelectorQuery::queryFirst): Ditto.
      * html/shadow/ContentSelectorQuery.cpp:
      (WebCore::ContentSelectorChecker::ContentSelectorChecker): Ditto.
      (WebCore::ContentSelectorQuery::ContentSelectorQuery): Ditto.
      * html/shadow/ContentSelectorQuery.h:
      (ContentSelectorChecker): Removed unnecessary argument.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4160a422
    • weinig@apple.com's avatar
      Windows build fix. · ff231745
      weinig@apple.com authored
      * win/WebKit2Common.vsprops:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138570 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff231745
    • weinig@apple.com's avatar
      Add supplementability to the NetworkProcess · 4851b1af
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=105838
      
      Reviewed by Dan Bernstein.
      
      This patch adds a NetworkProcessSupplement, which is almost identical to
      WebProcessSupplement, but has a different initialization override. It also
      stops WebProcessSupplement from inheriting from MessageReceiver (and makes
      everything that is a WebProcessSupplement also a MessageReceiver) as keeping
      that would cause classes that need to be both WebProcessSupplements and
      NetworkProcessSupplements inherit from MessageReceiver twice.
      
      * GNUmakefile.list.am:
      * NetworkProcess/NetworkProcess.cpp:
      (WebKit::NetworkProcess::NetworkProcess):
      (WebKit::NetworkProcess::downloadsAuthenticationManager):
      (WebKit::NetworkProcess::initializeNetworkProcess):
      * NetworkProcess/NetworkProcess.h:
      (WebKit):
      (NetworkProcess):
      (WebKit::NetworkProcess::supplement):
      (WebKit::NetworkProcess::addSupplement):
      * Shared/Network/CustomProtocols/CustomProtocolManager.h:
      (CustomProtocolManager):
      * Shared/Network/NetworkProcessSupplement.h: Added.
      (WebKit):
      (NetworkProcessSupplement):
      (WebKit::NetworkProcessSupplement::~NetworkProcessSupplement):
      (WebKit::NetworkProcessSupplement::initialize):
      * Target.pri:
      * WebKit2.xcodeproj/project.pbxproj:
      * WebProcess/ApplicationCache/WebApplicationCacheManager.h:
      * WebProcess/Authentication/AuthenticationManager.h:
      * WebProcess/Cookies/WebCookieManager.h:
      * WebProcess/Geolocation/WebGeolocationManager.h:
      * WebProcess/KeyValueStorage/WebKeyValueStorageManager.h:
      * WebProcess/MediaCache/WebMediaCacheManager.h:
      * WebProcess/Notifications/WebNotificationManager.h:
      * WebProcess/ResourceCache/WebResourceCacheManager.h:
      * WebProcess/WebCoreSupport/WebDatabaseManager.h:
      * WebProcess/WebProcessSupplement.h:
      * win/WebKit2.vcproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138569 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4851b1af
    • commit-queue@webkit.org's avatar
      [BlackBerry] Cookies with an IP domain are not being loaded properly into memory · fd412526
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105859
      
      PR 271597
      
      Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-12-29
      Reviewed by George Staikos.
      
      The isIP flag isn't persistented in the database. We need to check it
      again when we load it into memory.
      
      * platform/blackberry/CookieManager.cpp:
      (WebCore::CookieManager::getBackingStoreCookies):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138568 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd412526
    • commit-queue@webkit.org's avatar
      [EFL][WebGL] Refactor GLXImplementation. · f5366d87
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105825
      
      Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-29
      Reviewed by Kenneth Rohde Christiansen.
      
      This patch decouples native window management and logic to find surface configuration in GLX implementation.
      
      * platform/graphics/opengl/GLDefs.h:
      * platform/graphics/surfaces/glx/GLXConfigSelector.h: Renamed from Source/WebCore/platform/graphics/surfaces/glx/GLXWindowResources.h.
      (WebCore):
      (GLXConfigSelector):
      (WebCore::GLXConfigSelector::GLXConfigSelector):
      (WebCore::GLXConfigSelector::~GLXConfigSelector):
      (WebCore::GLXConfigSelector::visualInfo):
      (WebCore::GLXConfigSelector::pBufferContextConfig):
      (WebCore::GLXConfigSelector::surfaceContextConfig):
      (WebCore::GLXConfigSelector::reset):
      (WebCore::GLXConfigSelector::createConfig):
      
      Helper class to find surface configuration.
      
      * platform/graphics/surfaces/glx/GLXContext.h:
      (GLXOffScreenContext):
      * platform/graphics/surfaces/glx/GLXSurface.cpp:
      (WebCore::GLXTransportSurface::GLXTransportSurface):
      (WebCore::GLXTransportSurface::configuration):
      (WebCore::GLXTransportSurface::setGeometry):
      (WebCore::GLXTransportSurface::destroy):
      (WebCore::GLXPBuffer::GLXPBuffer):
      (WebCore::GLXPBuffer::initialize):
      (WebCore::GLXPBuffer::configuration):
      * platform/graphics/surfaces/glx/GLXSurface.h:
      (GLXTransportSurface):
      (GLXPBuffer):
      
      Inheritance changed from X11OffScreenWindow to GLPlatformSurface.
      
      * platform/graphics/surfaces/glx/X11WindowResources.cpp:
      (WebCore):
      (WebCore::X11OffScreenWindow::X11OffScreenWindow):
      (WebCore::X11OffScreenWindow::reSizeWindow):
      (WebCore::X11OffScreenWindow::createOffscreenWindow):
      (WebCore::X11OffScreenWindow::destroyWindow):
      (WebCore::X11OffScreenWindow::nativeSharedDisplay):
      (WebCore::X11OffScreenWindow::setVisualInfo):
      (WebCore::X11OffScreenWindow::isXRenderExtensionSupported):
      * platform/graphics/surfaces/glx/X11WindowResources.h:
      (WebCore::SharedX11Resources::create):
      (SharedX11Resources):
      (X11OffScreenWindow):
      
       Removed code related to surface configiration.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138567 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5366d87
    • commit-queue@webkit.org's avatar
      [GTK] Change bug for some inspector tests · 82837d46
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105842
      
      Unreviewed gardening.
      
      Bug 43332 was landed. But these tests still fail on GTK port.
      And change bug to track the failures.
      
      Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2012-12-29
      
      * platform/gtk/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138566 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82837d46
    • aroben@webkit.org's avatar
      Web Inspector: Mac WK1 Inspector can't save/load timeline data · 519ba09d
      aroben@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105547
      
      Reviewed by Pavel Feldman.
      
      * WebCoreSupport/WebInspectorClient.h: Declared new overrides and
      member variables necessary for save support.
      
      * WebCoreSupport/WebInspectorClient.mm:
      (WebInspectorFrontendClient::save):
      (WebInspectorFrontendClient::append):
      Implemented these to make saving timeline data work. (It seems to me
      the InspectorFrontendClient API could be cleaned up a bit. I had to
      look at Chromium source code to determine that I needed to call back
      into the InspectorFrontendAPI JS object after saving/appending, and
      that I needed to keep a map of passed URLs -> chosen URLs.)
      
      (-[WebInspectorWindowController window:willPositionSheet:usingRect:]):
      Tweaked the position of the sheet so that open/save sheets look a
      little bette.r
      
      (-[WebInspectorWindowController webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
      Implemented to make loading timeline data work.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      519ba09d