1. 22 Jan, 2014 12 commits
  2. 21 Jan, 2014 28 commits
    • commit-queue@webkit.org's avatar
      Compile fix for using libsoup on Windows. · 91281424
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=127377
      
      Patch by Alex Christensen <achristensen@webkit.org> on 2014-01-21
      Reviewed by Daniel Bates.
      
      * platform/network/soup/ProxyResolverSoup.cpp:
      (soupProxyResolverWkSetProperty):
      (soupProxyResolverWkGetProperty):
      (soupProxyResolverWkGetProxyURISync):
      Replaced uint with unsigned.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162506 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      91281424
    • dbates@webkit.org's avatar
      Break up single assertion into two assertions in HTMLMediaElement::returnPlatformLayer() · 7d412f8d
      dbates@webkit.org authored
      Following up after <http://trac.webkit.org/changeset/162473>, we should break up
      the assertion into two assertions as suggested by Darin Adler. Separating the single
      assertion into two assertions makes it straightforward to determine the conjunct that
      failed among other benefits.
      
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::parseAttribute):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d412f8d
    • beidson@apple.com's avatar
      The IDB backing store put() method shouldn't call IDB callbacks directly · 2fd9bcf6
      beidson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127399
      
      Reviewed by Beth Dakin.
      
      Source/WebCore:
      
      Refactor the put() callback to take a resulting key or an error.
      * Modules/indexeddb/IDBServerConnection.h:
      
      * Modules/indexeddb/IDBTransactionBackendOperations.cpp:
      (WebCore::PutOperation::perform): Call to the backing store, then perform the
        appropriate IDB callback whether a key or an error was returned.
      * Modules/indexeddb/IDBTransactionBackendOperations.h:
      
      * Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:
      (WebCore::IDBServerConnectionLevelDB::put): Don’t call IDB callbacks directly.
        Instead, pass the resulting key/error back to the PutOperation.
      * Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h:
      
      Source/WebKit2:
      
      * WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
      (WebKit::WebIDBServerConnection::put):
      * WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162501 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2fd9bcf6
    • mrowe@apple.com's avatar
      Roll out r162483. It removes SPI that is currently in use. · 08316f74
      mrowe@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08316f74
    • jae.park@company100.net's avatar
      Use nullptr in HTMLCanvasElement · b68aec1f
      jae.park@company100.net authored
      https://bugs.webkit.org/show_bug.cgi?id=127388
      
      Reviewed by Gyuyoung Kim.
      
      * html/HTMLCanvasElement.cpp:
      (WebCore::HTMLCanvasElement::getContext):
      (WebCore::HTMLCanvasElement::drawingContext):
      (WebCore::HTMLCanvasElement::existingDrawingContext):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162493 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b68aec1f
    • commit-queue@webkit.org's avatar
      Assertion failure in Range::nodeWillBeRemoved · 31ea78fd
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121694
      
      Patch by László Langó <llango.u-szeged@partner.samsung.com> on 2014-01-21
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      Based on Blink a change: https://chromium.googlesource.com/chromium/blink/+/407c1d7b2c45974aa614b3f847ffe9e8fce205fa
      
      This patch fix an assertion failure. Range::nodeWillBeRemoved() might
      be called with removed node in ContainerNode, when DOMNodeRemovedFromDocument
      event handler calls removeChild(), for node being removed.
      
      Test: fast/dom/Range/remove-twice-crash.html
      
      * dom/ContainerNode.cpp:
      (WebCore::ContainerNode::willRemoveChild):
      * dom/ContainerNode.h:
      
      LayoutTests:
      
      * fast/dom/Range/remove-twice-crash-expected.txt: Added.
      * fast/dom/Range/remove-twice-crash.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31ea78fd
    • timothy_horton@apple.com's avatar
      REGRESSION (r161580): Some PDFs render outside their <img> · 6cdf1d0f
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127381
      <rdar://problem/15872168>
      
      Reviewed by Simon Fraser.
      
      * platform/graphics/cg/PDFDocumentImage.cpp:
      (WebCore::transformContextForPainting):
      Only try to make the scale uniform if it isn't already, and use the minimum
      of the two original scales when doing so, so that it is absolutely certain
      to fit inside space allocated for the image during layout.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162486 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6cdf1d0f
    • roger_fong@apple.com's avatar
      Unreviewed. WebGLLoadPolicy::WebGLAsk is an unnecessary value. · 7ccea399
      roger_fong@apple.com authored
      * html/HTMLCanvasElement.cpp:
      (WebCore::HTMLCanvasElement::getContext):
      * loader/FrameLoaderTypes.h:
      * UIProcess/API/C/WKAPICast.h:
      (WebKit::toWebGLLoadPolicy):
      * UIProcess/API/C/WKPageLoaderClient.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162483 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ccea399
    • simon.fraser@apple.com's avatar
      Remove #if PLATFORM(IOS) in various places around customFixedPositionLayoutRect() code · e8882df6
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127373
      
      Reviewed by Beth Dakin.
      
      Instead of PLATFORM(IOS) #idefs at every call site for viewportConstrainedVisibleContentRect(),
      move the #ifdef inside viewportConstrainedVisibleContentRect().
      
      The one call site that needs special handling is RenderLayerBacking::updateCompositedBounds(),
      which needs to avoid clipping fixed layers to the custom fixed position rect, but instead to
      visibleContentRect() (which is really the document bounds on iOS). This ensures that the
      fixed layers aren't clipped when zooming out.
      
      * page/FrameView.cpp:
      (WebCore::FrameView::viewportConstrainedVisibleContentRect):
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::stickyPositionOffset):
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::updateCompositedBounds):
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::requiresCompositingForPosition):
      (WebCore::RenderLayerCompositor::computeFixedViewportConstraints):
      (WebCore::RenderLayerCompositor::computeStickyViewportConstraints):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162480 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8882df6
    • aestes@apple.com's avatar
      [iOS] Allow all clients to link against WebCore · d6196146
      aestes@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127372
      
      Reviewed by Dan Bernstein.
      
      * Configurations/WebCore.xcconfig:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162477 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6196146
    • betravis@adobe.com's avatar
      [CSS Shapes] Preserve box-shape order when serializing shape values · 230241c5
      betravis@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127200
      
      Reviewed by Dirk Schulze.
      
      Source/WebCore:
      
      Convert the parsed shape-box pair to a CSSValueList rather than directly
      adding the box value to BasicShape. The CSSValueList preserves the
      shape-box ordering, and cleans up a little bit of the code shared between
      clip and shape values.
      
      Modifying existing parsing tests.
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::shapePropertyValue): Factor out code common to generating shape
      values.
      (WebCore::ComputedStyleExtractor::propertyValue): Generate a CSSValueList when
      you have both a shape and a box.
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseBasicShapeAndOrBox): Factor out code common to clip
      paths and shape properties that parses the [basic-shape || box] syntax from
      the CSS Shapes spec.
      (WebCore::CSSParser::parseShapeProperty): Parse shape-box pairs as a CSSValueList.
      * css/DeprecatedStyleBuilder.cpp:
      (WebCore::ApplyPropertyShape::applyValue): Use the CSSValueList for shape-box pairs.
      * css/CSSValueList.h:
      (WebCore::CSSValueList::itemWithoutBoundsCheck): Add a const version.
      * page/animation/CSSPropertyAnimation.cpp:
      (WebCore::blendFunc): Specify a box when blending.
      * rendering/style/ShapeValue.h:
      (WebCore::ShapeValue::createShapeValue): Add a box parameter.
      (WebCore::ShapeValue::ShapeValue): Ditto.
      
      LayoutTests:
      
      Modify the expectations for box shape pairs, preserving the order of
      the arguments in non-computed values. Computed values are still a
      shape followed by a box.
      
      * fast/shapes/parsing/parsing-shape-inside-expected.txt:
      * fast/shapes/parsing/parsing-shape-outside-expected.txt:
      * fast/shapes/parsing/parsing-test-utils.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162475 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      230241c5
    • dbates@webkit.org's avatar
      Fix the iOS Simulator release build · 4263b14c
      dbates@webkit.org authored
      Substitute ASSERT_UNUSED() for ASSERT() to resolve a compiler warning
      that the argument platformLayer is unused. The argument platformLayer
      is only used in the asserted condition, which isn't compiled in a
      release build; => the argument is unused in a release build.
      
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::parseAttribute):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162473 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4263b14c
    • zoltan@webkit.org's avatar
      Since MidpointState is a class, it should behave like a class · 7585ad5d
      zoltan@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=127154
      
      Reviewed by David Hyatt.
      
      I modified MidpointState to behave like a class, updated the call sites also.
      
      No new tests, no behavior change.
      
      * platform/text/BidiResolver.h:
      (WebCore::MidpointState::reset):
      (WebCore::MidpointState::startIgnoringSpaces):
      (WebCore::MidpointState::stopIgnoringSpaces):
      (WebCore::MidpointState::midpoints):
      (WebCore::MidpointState::numMidpoints):
      (WebCore::MidpointState::currentMidpoint):
      (WebCore::MidpointState::incrementCurrentMidpoint):
      (WebCore::MidpointState::decreaseNumMidpoints):
      (WebCore::MidpointState::betweenMidpoints):
      (WebCore::MidpointState::setBetweenMidpoints):
      (WebCore::MidpointState::addMidpoint): Renamed from deprecatedAddMidpoint, since now
      its private, we no longer need to discourage callers from using it.
      * rendering/InlineIterator.h:
      (WebCore::IsolateTracker::addFakeRunIfNecessary):
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlockFlow::appendRunsForObject):
      (WebCore::constructBidiRunsForLine):
      * rendering/line/BreakingContextInlineHeaders.h:
      (WebCore::checkMidpoints):
      * rendering/line/TrailingObjects.cpp:
      (WebCore::TrailingObjects::updateMidpointsForTrailingBoxes):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162472 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7585ad5d
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r162452. · 4acc4a4b
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/162452
      https://bugs.webkit.org/show_bug.cgi?id=127366
      
      broke a few tests on all Mac WebKit1 bots (Requested by
      thorton on #webkit).
      
      Source/WebCore:
      
      * WebCore.exp.in:
      * page/FocusController.cpp:
      (WebCore::FocusController::FocusController):
      (WebCore::FocusController::setFocused):
      (WebCore::FocusController::setActive):
      (WebCore::FocusController::setContentIsVisible):
      * page/FocusController.h:
      (WebCore::FocusController::isActive):
      (WebCore::FocusController::isFocused):
      * page/Page.cpp:
      (WebCore::Page::Page):
      (WebCore::Page::setIsInWindow):
      (WebCore::Page::setIsVisuallyIdle):
      (WebCore::Page::setIsVisible):
      (WebCore::Page::visibilityState):
      (WebCore::Page::hiddenPageCSSAnimationSuspensionStateChanged):
      * page/Page.h:
      (WebCore::Page::isVisible):
      (WebCore::Page::isInWindow):
      
      Source/WebKit/mac:
      
      * WebView/WebView.mm:
      (-[WebView _windowWillOrderOnScreen:]):
      (-[WebView _windowWillOrderOffScreen:]):
      
      Source/WebKit2:
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::WebPage):
      (WebKit::WebPage::setActive):
      (WebKit::WebPage::setViewIsVisible):
      (WebKit::WebPage::setFocused):
      (WebKit::WebPage::setIsInWindow):
      (WebKit::WebPage::setViewStateInternal):
      (WebKit::WebPage::setIsVisuallyIdle):
      * WebProcess/WebPage/WebPage.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162467 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4acc4a4b
    • cfleizach@apple.com's avatar
      AX: Mac: Expose the visible text of a password field to AX · 8b2c964a
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127353
      
      Reviewed by Brent Fulgham.
      
      Source/WebCore:
      
      The Mac platform should now expose the rendered value of password fields through AX.
      
      Test: accessibility/password-field-value.html
      
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::textLength):
      (WebCore::AccessibilityRenderObject::passwordFieldValue):
      
      LayoutTests:
      
      * accessibility/password-field-value-expected.txt: Added.
      * accessibility/password-field-value.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162466 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b2c964a
    • commit-queue@webkit.org's avatar
      Support SSL error handling in case of synchronous job. · 7167313c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125301
      
      Patch by Robert Sipka <sipka@inf.u-szeged.hu> on 2014-01-21
      Reviewed by Brent Fulgham.
      
      Set ssl error informations for the users.
      
      * platform/network/curl/ResourceHandleManager.cpp:
      (WebCore::ResourceHandleManager::dispatchSynchronousJob):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162464 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7167313c
    • simon.fraser@apple.com's avatar
      Export systemTotalMemory() and systemMemoryLevel() for MobileSafari · 3d5532ad
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127360
      
      Reviewed by Andy Estes.
      
      MobileSafari inappropriately calls these WebCore functions directly,
      so export them.
      
      * WebCore.exp.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162463 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d5532ad
    • simon.fraser@apple.com's avatar
      Clean up PLATFORM(IOS) code related to the custom fixed position layout rect · 037f67dc
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127362
      
      Reviewed by Dave Hyatt.
      
      Various platforms customize the rect used to layout position:fixed elements,
      and each modified RenderBox::availableLogicalHeight/WidthUsing() in different
      ways.
      
      Clean this up by adding RenderView::clientLogicalWidth/HeightForFixedPosition(),
      and moving the platform hacks into it.
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::availableLogicalHeightUsing):
      (WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
      (WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
      * rendering/RenderView.cpp:
      (WebCore::RenderView::clientLogicalWidthForFixedPosition):
      (WebCore::RenderView::clientLogicalHeightForFixedPosition):
      * rendering/RenderView.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162462 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      037f67dc
    • commit-queue@webkit.org's avatar
      ASSERT(time.isFinite()) in SVGSMILElement::createInstanceTimesFromSyncbase · 909a2e9a
      commit-queue@webkit.org authored
      <https://webkit.org/b/108184>
      
      Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2014-01-21
      Reviewed by Philip Rogers.
      
      Source/WebCore:
      
      In the case a SMILElement timing had a syncbase dependency on an indefinite value
      the assert were raised. The assert has been removed and a check has been added
      instead that prevents the addition of indefinite times to the time list.
      
      Test: svg/animations/smil-syncbase-self-dependency.svg
      
      * svg/animation/SVGSMILElement.cpp:
      (WebCore::SVGSMILElement::createInstanceTimesFromSyncbase):
        ASSERT removed.
      
      LayoutTests:
      
      Test checks whether valid self-dependency is accidentally broken.
      
      * svg/animations/smil-syncbase-self-dependency-expected.txt: Added.
      * svg/animations/smil-syncbase-self-dependency.svg: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162459 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      909a2e9a
    • timothy_horton@apple.com's avatar
      Address late review naming comments after r162453. · 8736f0e1
      timothy_horton@apple.com authored
      * UIProcess/API/mac/WKView.mm:
      And, fix the build by adding an include I accidentally missed.
      
      * UIProcess/mac/RemoteLayerTreeHost.mm:
      * WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:
      
      * WebCore.xcodeproj/project.pbxproj:
      * platform/graphics/ca/mac/PlatformCALayerMac.mm:
      * platform/graphics/mac/CALayerWebAdditions.h: Removed.
      * platform/graphics/mac/CALayerWebAdditions.mm: Removed.
      * platform/graphics/mac/WebCoreCALayerExtras.h: Added.
      * platform/graphics/mac/WebCoreCALayerExtras.mm: Added.
      Rename.
      
      (-[CALayer web_disableAllActions]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162454 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8736f0e1
    • timothy_horton@apple.com's avatar
      Keep CALayer implicit animation disabling code in a single place · fdfc3bb9
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127355
      
      Reviewed by Simon Fraser.
      
      * WebCore.xcodeproj/project.pbxproj:
      Add CALayerWebAdditions.{h,mm}.
      
      * platform/graphics/ca/mac/PlatformCALayerMac.mm:
      (PlatformCALayerMac::commonInit):
      Remove nullActionsDictionary() and use [CALayer(WebAdditions) web_disableAllActions] instead.
      
      * platform/graphics/mac/CALayerWebAdditions.h: Added.
      * platform/graphics/mac/CALayerWebAdditions.mm: Added.
      (-[CALayer web_disableAllActions]):
      Added. Disable all implicit actions on the layer.
      
      * Shared/mac/RemoteLayerTreePropertyApplier.h:
      * Shared/mac/RemoteLayerTreePropertyApplier.mm:
      Remove disableActionsForLayer.
      
      * UIProcess/API/mac/WKView.mm:
      (-[WKView _rootLayer]):
      Disable actions on the root layer. It doesn't need them, and currently
      isn't affected by implicit animations, but future patches which animate
      the root layer will benefit from this.
      
      * UIProcess/mac/RemoteLayerTreeHost.mm:
      (WebKit::RemoteLayerTreeHost::createLayer):
      Use web_disableAllActions instead of disableActionsForLayer.
      
      * WebKit2.xcodeproj/project.pbxproj:
      * WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm: Renamed from Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.cpp.
      (PlatformCALayerRemoteCustom::PlatformCALayerRemoteCustom):
      (PlatformCALayerRemoteCustom::~PlatformCALayerRemoteCustom):
      (PlatformCALayerRemoteCustom::hostingContextID):
      Use web_disableAllActions instead of disableActionsForLayer.
      This requires making this file Obj-C++ but that's OK since it's Mac/iOS only.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162453 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fdfc3bb9
    • barraclough@apple.com's avatar
      Change Page, FocusController to use ViewState · 3ffc4f37
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=126533
      
      Reviewed by Tim Horton.
      
      These classes currently maintain a set of separate fields to represent the view state;
      combine these into a single field, and allow WebPage to send the combined update rather
      than individual changes.
      
      Maintain existing interface for WebKit1 clients.
      
      Source/WebCore: 
      
      * WebCore.exp.in:
          - Added WebCore::setViewState, removed WebCore::setIsVisuallyIdle.
      * page/FocusController.cpp:
      (WebCore::FocusController::FocusController):
          - Initialize combined m_viewState.
      (WebCore::FocusController::setFocused):
          - Calls setViewState.
      (WebCore::FocusController::setFocusedInternal):
          - setFocused -> setFocusedInternal.
      (WebCore::FocusController::setViewState):
          - Added, update all ViewState flags.
      (WebCore::FocusController::setActive):
          - Calls setViewState.
      (WebCore::FocusController::setActiveInternal):
          - setActive -> setActiveInternal.
      (WebCore::FocusController::setContentIsVisible):
          - Calls setViewState.
      (WebCore::FocusController::setContentIsVisibleInternal):
          - setContentIsVisible -> setContentIsVisibleInternal.
      * page/FocusController.h:
      (WebCore::FocusController::isActive):
      (WebCore::FocusController::isFocused):
      (WebCore::FocusController::contentIsVisible):
          - Implemented in terms of ViewState.
      * page/Page.cpp:
      (WebCore::Page::Page):
          - Initialize using PageInitialViewState.
      (WebCore::Page::setIsInWindow):
          - Calls setViewState.
      (WebCore::Page::setIsInWindowInternal):
          - setIsInWindow -> setIsInWindowInternal.
      (WebCore::Page::setIsVisuallyIdleInternal):
          - setIsVisuallyIdle -> setIsVisuallyIdleInternal.
      (WebCore::Page::setViewState):
          - Added, update all ViewState flags, including FocusController.
      (WebCore::Page::setIsVisible):
          - Calls setViewState.
      (WebCore::Page::setIsVisibleInternal):
          - setIsVisible -> setIsVisibleInternal.
      (WebCore::Page::visibilityState):
          - m_isVisible -> isVisible()
      (WebCore::Page::hiddenPageCSSAnimationSuspensionStateChanged):
          - m_isVisible -> isVisible()
      * page/Page.h:
      (WebCore::Page::isVisible):
      (WebCore::Page::isInWindow):
          - Implemented in terms of ViewState.
      (WebCore::Page::scriptedAnimationsSuspended):
          - Combined member fields into ViewState::Flags.
      
      Source/WebKit/mac: 
      
      * WebView/WebView.mm:
      (-[WebView _windowWillOrderOnScreen:]):
      (-[WebView _windowWillOrderOffScreen:]):
          - remove calls to FocusController::setContentIsVisible, these are redundant
            (this is handled when page visibility is set).
      
      Source/WebKit2: 
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::WebPage):
          - Combined separate calls to Page::setViewState.
      (WebKit::WebPage::updateIsInWindow):
          - Simplied from setIsInWindow.
      (WebKit::WebPage::setViewState):
          - Combined separate calls to Page::setViewState.
      * WebProcess/WebPage/WebPage.h:
          - Declare updateIsInWindow.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162452 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ffc4f37
    • lauro.neto@openbossa.org's avatar
      Remove PLATFORM(NIX) from WebCore · ee418384
      lauro.neto@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=127299
      
      Reviewed by Anders Carlsson.
      
      * editing/Editor.cpp:
      (WebCore::Editor::cut):
      (WebCore::Editor::copy):
      (WebCore::Editor::copyImage):
      * editing/Editor.h:
      * html/HTMLCanvasElement.h:
      * loader/EmptyClients.h:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::defaultObjectContentType):
      * page/ChromeClient.h:
      * page/DragController.cpp:
      (WebCore::DragController::startDrag):
      * platform/Cursor.h:
      * platform/DragData.h:
      * platform/DragImage.h:
      * platform/FileSystem.h:
      * platform/LocalizedStrings.h:
      * platform/Widget.h:
      * platform/audio/FFTFrame.h:
      * platform/audio/HRTFElevation.cpp:
      * platform/cairo/WidgetBackingStore.h:
      * platform/graphics/ANGLEWebKitBridge.h:
      * platform/graphics/FontPlatformData.h:
      * platform/graphics/GLContext.cpp:
      (WebCore::GLContext::createContextForWindow):
      * platform/graphics/GLContext.h:
      * platform/graphics/GraphicsContext3D.h:
      * platform/graphics/GraphicsContext3DPrivate.cpp:
      (WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
      * platform/graphics/OpenGLESShims.h:
      * platform/graphics/OpenGLShims.cpp:
      (WebCore::getProcAddress):
      * platform/graphics/OpenGLShims.h:
      * platform/graphics/PlatformLayer.h:
      * platform/graphics/freetype/FontPlatformDataFreeType.cpp:
      * platform/graphics/opengl/Extensions3DOpenGL.cpp:
      (WebCore::Extensions3DOpenGL::createVertexArrayOES):
      (WebCore::Extensions3DOpenGL::deleteVertexArrayOES):
      (WebCore::Extensions3DOpenGL::isVertexArrayOES):
      (WebCore::Extensions3DOpenGL::bindVertexArrayOES):
      (WebCore::Extensions3DOpenGL::supportsExtension):
      * platform/graphics/opengl/Extensions3DOpenGL.h:
      * platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
      * platform/graphics/opengl/Extensions3DOpenGLES.h:
      * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
      * platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
      (WebCore::GraphicsContext3D::reshape):
      * platform/graphics/opengl/TemporaryOpenGLSetting.cpp:
      * platform/graphics/texmap/TextureMapper.h:
      * platform/network/ResourceHandle.h:
      * plugins/PluginPackage.cpp:
      * plugins/PluginView.cpp:
      (WebCore::PluginView::PluginView):
      * plugins/PluginView.h:
      * plugins/PluginViewNone.cpp:
      * rendering/SimpleLineLayout.cpp:
      (WebCore::SimpleLineLayout::canUseFor):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee418384
    • eric.carlson@apple.com's avatar
      Add &lrm; &rlm; and &nbsp; to WebVTT parser · dbc58ddb
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=85112
      
      Reviewed by Jer Noble.
      
      Source/WebCore:
      
      No new tests, track-webvtt-tc022-entities.html was updated to test this.
      
      * html/track/WebVTTTokenizer.cpp:
      (WebCore::WebVTTTokenizer::nextToken): Support RLM, LRM, and NBSP entities.
      
      LayoutTests:
      
      * media/track/captions-webvtt/tc022-entities.vtt:
      * media/track/track-webvtt-tc022-entities-expected.txt:
      * media/track/track-webvtt-tc022-entities.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dbc58ddb
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r162354. · a059000f
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/162354
      https://bugs.webkit.org/show_bug.cgi?id=127354
      
      Appears to have broken accessibility in a non-trivial way
      (Requested by ap on #webkit).
      
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::updateScrollbars):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162447 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a059000f
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r162445. · 73f71181
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/162445
      https://bugs.webkit.org/show_bug.cgi?id=127351
      
      It broke the 32 bit GTK build (Requested by Ossy on #webkit).
      
      * rendering/style/StyleRareInheritedData.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162446 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73f71181
    • commit-queue@webkit.org's avatar
      Wrong struct size when CSS_IMAGE_ORIENTATION and CSS3_TEXT_DECORATION are enabled. · 2f7f766f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=127346
      
      Efl build fix.
      
      Patch by László Langó <llango.u-szeged@partner.samsung.com> on 2014-01-21
      Reviewed by Csaba Osztrogonác.
      
      * rendering/style/StyleRareInheritedData.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162445 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f7f766f
    • antti@apple.com's avatar
      Delay initial layer flush during loading on all platforms · 5fb12d3f
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127347
      
      Reviewed by Andreas Kling.
      
      To reduce unnecessary repaints enable the same behaviour as iOS already has.
      
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::RenderLayerCompositor):
              
          Set the initial state of m_layerFlushThrottlingEnabled correctly.
      
      (WebCore::RenderLayerCompositor::scheduleLayerFlush):
      (WebCore::RenderLayerCompositor::startInitialLayerFlushTimerIfNeeded):
      * rendering/RenderLayerCompositor.h:
              
          Enable initial layer flush delay on all platforms.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162443 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fb12d3f