Skip to content

GitLab

W
webkit
Switch branch/tag
  1. 06 May, 2008 4 commits
  3. 05 May, 2008 25 commits
    • mrowe@apple.com's avatar
      Fix 60 crashes seen on the buildbots that were misreported as hangs. · 054c1d9b
      mrowe@apple.com authored 
      Reviewed by Dan Bernstein.

* dom/Document.cpp:
(WebCore::Document::detachNodeIterator): Null-check page() before dereferencing it.
(WebCore::Document::nodeWillBeRemoved): Ditto.
(WebCore::Document::textInserted): Ditto.
(WebCore::Document::textNodesMerged): Ditto.
(WebCore::Document::textRemoved): Ditto.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      054c1d9b
    • beidson@apple.com's avatar
      2008-05-05 Brady Eidson <beidson@apple.com> · fa23f6e5
      beidson@apple.com authored 
              Reviewed by Mitz Pettel RTL

        Preparation for upcoming work making LocalStorage persistent.

        The other half of the StorageMap::importItem() addition.

        * storage/StorageArea.cpp:
        (WebCore::StorageArea::importItem):
        * storage/StorageArea.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32900 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa23f6e5
    • beidson@apple.com's avatar
      2008-05-05 Brady Eidson <beidson@apple.com> · 06c8e74b
      beidson@apple.com authored 
              Reviewed by Mitz Pettel RTL

        Preparation for upcoming work making LocalStorage persistent.

        - Create the LocalStorage object for a PageGroup the moment the first Page is added to it
          The Settings of the first Page define what persistent path the LocalStorage will use
        - Add a Frame argument for the LocalStorageArea request - this will allow a client object
          to be queried before the LocalStorageArea is established

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::localStorage):

        * page/PageGroup.cpp:
        (WebCore::PageGroup::addPage):
        (WebCore::PageGroup::localStorage):

        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::LocalStorage): Take the path as a constructor argument.  Deep copy
          the path as it will be used from another thread.
        (WebCore::LocalStorage::storageArea):
        * storage/LocalStorage.h:
        (WebCore::LocalStorage::create):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32899 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06c8e74b
    • beidson@apple.com's avatar
      2008-05-05 Brady Eidson <beidson@apple.com> · 2cfbe4c4
      beidson@apple.com authored 
              Reviewed by Mitz Pettel RTL

        Preparation for upcoming work making LocalStorage persistent.

        StorageMaps normally have copy-on-write semantics to help support SessionStorage.
        For LocalStorage, we never want this behavior.  When we forcefully import items into 
        a StorageMap from the LocalStorage background thread, this new import method will be used.

        * storage/StorageMap.cpp:
        (WebCore::StorageMap::importItem): Add a deep-copy of the item to the map without worrying
          about copy-on-write.
        * storage/StorageMap.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32897 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2cfbe4c4
    • sfalken@apple.com's avatar
      Copy dependencies of ImageDiff, DumpRenderTree in post-build step. · eb9e605a
      sfalken@apple.com authored 
              * DumpRenderTree/win/DumpRenderTree.vcproj:
        * DumpRenderTree/win/ImageDiff.vcproj:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32895 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb9e605a
    • kmccullough@apple.com's avatar
      2008-05-05 Kevin McCullough <kmccullough@apple.com> · 0b5c08ff
      kmccullough@apple.com authored 
              Reviewed by Tim.

        -<rdar://problem/5770054> JavaScript profiler (10928)
        -Begininings of a UI for the Profiler in the WebInspector.

        * English.lproj/InspectorLocalizedStrings.js: Add new strings to be
        localized.
        * page/inspector/DatabasesPanel.js: Changed the name of the Databae's
        results table to be more generic as it is now also used by the profiler.
        * page/inspector/Images/glossySelected.png: Added.
        * page/inspector/Images/profilesIcon.png: Added.
        * page/inspector/Images/treeUpTriangleBlack.png: Added.
        * page/inspector/Images/treeUpTriangleWhite.png: Added.
        * page/inspector/ProfileView.js: Added. Sets up the header of the table.
        * page/inspector/ProfilesPanel.js: Added.
        * page/inspector/ProfilesPanel.js: Added. Sets up the containers of the
        profiler's content.
        * page/inspector/inspector.css: Change database-result-table to be more
        generic as well as add the styles needed by the profiler.
        * page/inspector/inspector.html: Add profiler support.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32890 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b5c08ff
    • beidson@apple.com's avatar
      2008-05-05 Brady Eidson <beidson@apple.com> · 489c4171
      beidson@apple.com authored 
              Change by Darin, reviewed by Brady

        Small efficiency improvement Darin just spotted

        * storage/StorageMap.cpp:
        (WebCore::StorageMap::setItem):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32889 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      489c4171
    • antti@apple.com's avatar
      2008-05-05 Antti Koivisto <antti@apple.com> · 98d2d18a
      antti@apple.com authored 
              Reviewed by Anders.

        Fix https://bugs.webkit.org/show_bug.cgi?id=18899
        Bug 18899: REGRESSION (r32871): Non-Safari crash in WTF::HashTable on startup

        * loader/loader.cpp:
        (WebCore::Loader::Loader):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32887 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98d2d18a
    • weinig@apple.com's avatar
      2008-05-05 Sam Weinig <sam@webkit.org> · e9f13c97
      weinig@apple.com authored 
              Reviewed by Darin Adler.

        Fix for <rdar://problem/5884383>
        Escape look-a-like characters from the the entire url.

        * Misc/WebNSURLExtras.mm:
        (escapeUnsafeCharacters):
        (-[NSURL _web_userVisibleString]):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9f13c97
    • beidson@apple.com's avatar
      2008-05-05 Brady Eidson <beidson@apple.com> · ddfe27a8
      beidson@apple.com authored 
              Reviewed by Sam Weinig

        Fix a bug in StorageMap iterator tracking where the iterator was not successfully
        invalidated at an appropriate time.

        * storage/StorageMap.cpp:
        (WebCore::StorageMap::setItem): ALWAYS invalidate it here



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32884 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ddfe27a8
    • justin.garcia@apple.com's avatar
      WebCore: · 692743d4
      justin.garcia@apple.com authored 
      2008-05-05  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin.

        <rdar://problem/5865171> REGRESSION: Creating a new quote places caret at beginning of quote instead of the end
        
        Disable Range mutation on document modifications in Tiger and Leopard Mail,
        since they do their own mutation which interferes with ours.

        * WebCore.base.exp:
        * dom/Document.cpp:
        (WebCore::Document::nodeChildrenChanged):
        (WebCore::Document::nodeWillBeRemoved):
        (WebCore::Document::textInserted):
        (WebCore::Document::textRemoved):
        (WebCore::Document::textNodesMerged):
        (WebCore::Document::textNodeSplit):
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        (WebCore::Settings::disableRangeMutationForOldAppleMail):
        * page/Settings.h:
        (WebCore::Settings::rangeMutationDisabledForOldAppleMail):

WebKit/mac:

2008-05-05  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin.
        
        <rdar://problem/5865171> REGRESSION: Creating a new quote places caret at beginning of quote instead of the end

        * WebView/WebView.mm:
        (-[WebView _updateSettingsFromPreferences:]): Disable Range mutation on changes to
        the document for Tiger and Leopard Mail.  There is code in Mail that does it, and
        the two interfere.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32883 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      692743d4
    • weinig@apple.com's avatar
      WebCore: · 9d3827a7
      weinig@apple.com authored 
      2008-05-05  Sam Weinig  <sam@webkit.org>

        Reviewed by Tim Hatcher.

        Make the Inspector's localizable strings file match the format used by Dashboard widgets.

        * English.lproj/InspectorLocalizedStrings.js: Removed.
        * English.lproj/localizedStrings.js: Added.
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * page/inspector/inspector.js:

WebKit/mac:

2008-05-05  Sam Weinig  <sam@webkit.org>

        Reviewed by Tim Hatcher.

        Make the Inspector's localizable strings file match the format used by Dashboard widgets.

        * WebCoreSupport/WebInspectorClient.mm:
        (WebInspectorClient::localizedStringsURL):

WebKit/win:

2008-05-05  Sam Weinig  <sam@webkit.org>

        Reviewed by Tim Hatcher.

        Make the Inspector's localizable strings file match the format used by Dashboard widgets.

        * WebCoreSupport/WebInspectorClient.cpp:
        (WebInspectorClient::localizedStringsURL):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32882 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d3827a7
    • sfalken@apple.com's avatar
      2008-05-05 Steve Falkenburg <sfalken@apple.com> · 14e9c0b4
      sfalken@apple.com authored 
              Add WebPreference for application chrome mode.
        
        Reviewed by Dave Hyatt.

        * Interfaces/IWebPreferencesPrivate.idl:
        * WebPreferenceKeysPrivate.h:
        * WebPreferences.cpp:
        (WebPreferences::initializeDefaultSettings):
        (WebPreferences::inApplicationChromeMode):
        (WebPreferences::setApplicationChromeMode):
        * WebPreferences.h:
        * WebView.cpp:
        (WebView::notifyPreferencesChanged):

2008-05-05  Steve Falkenburg  <sfalken@apple.com>

        Add support for default button appearance.
        Add WebCore setting for app chrome mode.
        
        Reviewed by Dave Hyatt.

        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        * css/CSSValueKeywords.in: Added default-button value keyword.
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        (WebCore::Settings::setApplicationChromeMode):
        * page/Settings.h:
        (WebCore::Settings::inApplicationChromeMode):
        * rendering/RenderButton.cpp:
        (WebCore::RenderButton::RenderButton):
        (WebCore::RenderButton::setStyle):
        (WebCore::RenderButton::timerFired):
        * rendering/RenderButton.h:
        * rendering/RenderStyle.h:
        (WebCore::):
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::adjustStyle):
        (WebCore::RenderTheme::paint):
        (WebCore::RenderTheme::paintBorderOnly):
        (WebCore::RenderTheme::paintDecorations):
        (WebCore::RenderTheme::isControlStyled):
        (WebCore::RenderTheme::isDefault):
        * rendering/RenderTheme.h:
        (WebCore::):
        * rendering/RenderThemeSafari.cpp:
        (WebCore::RenderThemeSafari::determineState):
        (WebCore::RenderThemeSafari::adjustRepaintRect):
        (WebCore::RenderThemeSafari::adjustButtonStyle):
        * rendering/RenderThemeWin.cpp:
        (WebCore::RenderThemeWin::supportsFocus):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32881 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14e9c0b4
    • adele@apple.com's avatar
      2008-05-05 Adele Peterson <adele@apple.com> · 0188433f
      adele@apple.com authored 
              Reviewed by Adam.

        Look for the right ImageDiff executable for debug builds.

        * Scripts/run-webkit-tests:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32880 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0188433f
    • ap@webkit.org's avatar
      Reviewed by Darin. · 095e1f6b
      ap@webkit.org authored 
              https://bugs.webkit.org/show_bug.cgi?id=11947
        nbsps should be converted to entities in innerHTML

        https://bugs.webkit.org/show_bug.cgi?id=18769
        replacing &nbsp; with spaces using regexp creates inconsistent result

        Tests: fast/dom/innerHTML-nbsp.html
               fast/dom/innerHTML-escaping-attribute.html

        * editing/markup.cpp:
        (WebCore::appendAttributeValue):
        (WebCore::escapeContentText):
        (WebCore::appendEscapedContent):
        Added U+00a0/nbsp to the list of characters to escape.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32879 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      095e1f6b
    • hyatt@apple.com's avatar
      WebCore: · 3cb88e1a
      hyatt@apple.com authored 
      2008-05-05  David Hyatt  <hyatt@apple.com>

        Fix for https://bugs.webkit.org/show_bug.cgi?id=18821.  Fix some bugs in both get/PutImageData of <canvas>.

        Reviewed by Eric

        New tests added in fast/canvas/

        * platform/graphics/cg/ImageBufferCG.cpp:
        (WebCore::ImageBuffer::getImageData):
        (WebCore::ImageBuffer::putImageData):

LayoutTests:

2008-05-05  David Hyatt  <hyatt@apple.com>

        Fix for https://bugs.webkit.org/show_bug.cgi?id=18821, putImageData incorrect when data has alpha.

        Reviewed by Eric

        * fast/canvas/canvas-alphaImageData-behavior-expected.txt: Added.
        * fast/canvas/canvas-alphaImageData-behavior.html: Added.
        * fast/canvas/canvas-alphaImageData-behavior.js: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3cb88e1a
    • darin@apple.com's avatar
      2008-05-05 Darin Adler <darin@apple.com> · 0fa4ee57
      darin@apple.com authored 
              Reviewed by John Sullivan.

        - fix debug-only leak seen on buildbot

        * wtf/HashTable.h:
        (WTF::HashTable::checkKey): After writing an empty value in, but before constructing a
        deleted value on top of it, call the destructor so the empty value doesn't leak.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32877 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0fa4ee57
    • andersca@apple.com's avatar
      2008-05-05 Anders Carlsson <andersca@apple.com> · 2980bb5a
      andersca@apple.com authored 
              Reviewed by Jess.

        Apparently preflighting can cause hangs for some reason. Revert this for now.
        
        * Plugins/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage _initWithPath:]):
        * Plugins/WebPluginPackage.m:
        (-[WebPluginPackage initWithPath:]):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32876 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2980bb5a
    • darin@apple.com's avatar
      2008-05-05 Darin Adler <darin@apple.com> · 8454f02d
      darin@apple.com authored 
              * Scripts/run-webkit-tests: Ignore a Java leak showing up in the WebKit
        leak tests.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32875 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8454f02d
    • darin@apple.com's avatar
      2008-05-05 Darin Adler <darin@apple.com> · eb1d25fa
      darin@apple.com authored 
              Reviewed by Mitz.

        - https://bugs.webkit.org/show_bug.cgi?id=18789
          fix some shouldCloseWithWindow edge cases

        * WebView/WebView.mm:
        (-[WebView viewWillMoveToWindow:]): Fix bug where we would stop observing the
        NSWindowWillCloseNotification if the view was moved out of the window but still
        had that window set as the host window. Also make sure this function doesn't do
        anything if the WebView is already closed.
        (-[WebView setHostWindow:]): Ditto.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb1d25fa
    • mitz@apple.com's avatar
      Rubber-stamped by Adam Roben. · fcc46237
      mitz@apple.com authored 
              - fix test failure due to Windows' preference for Mac results over
          generic results

        * platform/win/editing/selection/move-left-right-expected.txt: Copied from LayoutTests/editing/selection/move-left-right-expected.txt.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32873 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fcc46237
    • mitz@apple.com's avatar
      WebCore: · cd6deb7d
      mitz@apple.com authored 
              Reviewed by Dave Hyatt.

        - fix https://bugs.webkit.org/show_bug.cgi?id=18809
          Forms with block level generated content and absolutely positioned labels break inline layout (fixed on reflow)

        Test: fast/block/basic/adding-near-anonymous-block.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::addChildToFlow): When adding a floating or
        positioned object, if it follows an anonymous block, put it
        inside the anonymous block. When adding an inline, check if it comes
        after an anonymous block and put it in the anonymous block.

LayoutTests:

        Reviewed by Dave Hyatt.

        - test, updated test and updated results for https://bugs.webkit.org/show_bug.cgi?id=18809
          Forms with block level generated content and absolutely positioned labels break inline layout (fixed on reflow)

        * fast/block/basic/adding-near-anonymous-block.html: Added.
        * media/video-controls-rendering.html: Changed to work around
        https://bugs.webkit.org/show_bug.cgi?id=18857 which now affects this
        test in its original form.
        * platform/mac/css1/box_properties/clear-expected.txt:
        * platform/mac/fast/block/basic/adding-near-anonymous-block-expected.checksum: Added.
        * platform/mac/fast/block/basic/adding-near-anonymous-block-expected.png: Added.
        * platform/mac/fast/block/basic/adding-near-anonymous-block-expected.txt: Added.
        * platform/mac/fast/forms/input-align-image-expected.txt:
        * platform/mac/media/audio-controls-rendering-expected.txt:
        * platform/mac/media/video-controls-rendering-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug51140-expected.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd6deb7d
    • antti@apple.com's avatar
      2008-05-05 Antti Koivisto <antti@apple.com> · f0dc5ade
      antti@apple.com authored 
              Reviewed by Darin.

        Speculative fix for <rdar://problem/5906790> 
        Crash in Loader::servePendingRequests() due to hash table being modified during iteration
        
        I don't know how to reproduce this. It would require the load to fail (or succeed)
        synchronously, something that should not usually happen.

        * loader/loader.cpp:
        (WebCore::Loader::Loader):
        (WebCore::Loader::load):
        (WebCore::Loader::servePendingRequests):
        (WebCore::Loader::cancelRequests):
        (WebCore::Loader::Host::Host):
        * loader/loader.h:
        (WebCore::Loader::Host::name):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32871 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0dc5ade
    • hausmann@webkit.org's avatar
      Ariya Hidayat <ariya.hidayat@trolltech.com> · ed762a03
      hausmann@webkit.org authored 
      In the Qt's DumpRenderTree, adjust the web view properly (because W3C SVG
tests expect to be 480x360)


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32869 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed762a03
    • hausmann@webkit.org's avatar
      Ariya Hidayat <ariya.hidayat@trolltech.com> · 1ce02397
      hausmann@webkit.org authored 
      Disable SVG As Image support in the Qt port again, as it
requires more work. Right now the chrome client is
assumed to be a ChromeClientQt, which the SVG Image support
changes.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32868 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ce02397
  5. 04 May, 2008 9 commits
  7. 03 May, 2008 2 commits