1. 01 Apr, 2013 1 commit
  2. 29 Mar, 2013 2 commits
  3. 28 Mar, 2013 3 commits
    • commit-queue@webkit.org's avatar
      [BlackBerry] Don't cross editing boundary when touch hold selection expands · 73737236
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113537
      
      Patch by Iris Wu <shuwu@blackberry.com> on 2013-03-28
      Reviewed by Rob Buis.
      
      Set editing boundary crossing rule to make sure it won't cross
      editing boundary when selection expands.
      
      Reviewed Internally By Genevieve Mak and Mike Fenton.
      
      * WebKitSupport/SelectionHandler.cpp:
      (BlackBerry::WebKit::SelectionHandler::selectNextParagraph):
      (BlackBerry::WebKit::SelectionHandler::findNextAnimationOverlayRegion):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147189 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73737236
    • commit-queue@webkit.org's avatar
      [BlackBerry] Don't use WebKit thread scale information in WebPageCompositor. · d503b051
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113447
      Internal PR 313452
      
      Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-03-28
      Reviewed by Rob Buis.
      
      Potential threading problems are avoided by moving from
      WebPage members and mapToTransformed() to the web page
      client's userInterfaceViewportAccessor().
      
      As part of this cleaning effort, the WebPageCompositor's
      render() method is changed to now take document instead of
      pixel coordinates.
      
      * Api/BackingStore.cpp:
      (BlackBerry::WebKit::BackingStorePrivate::compositeContents):
      * Api/WebPageCompositor.cpp:
      (BlackBerry::WebKit::WebPageCompositorPrivate::render):
      (BlackBerry::WebKit::WebPageCompositor::render):
      * Api/WebPageCompositor.h:
      * Api/WebPageCompositor_p.h:
      (WebPageCompositorPrivate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147136 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d503b051
    • falken@chromium.org's avatar
      Refactoring: Replace Element::disabled and isEnabledFormControl with isDisabledFormControl · 2113254c
      falken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113273
      
      Reviewed by Kent Tamura.
      
      Element::disabled is about form controls and Element::isEnabledFormControl
      is redundant with it, so replace them with a single function
      Element::isDisabledFormControl.
      
      Source/WebCore:
      
      No new tests, there should be no behavior change.
      
      * accessibility/AccessibilityListBox.cpp:
      (WebCore::AccessibilityListBox::canSetSelectedChildrenAttribute):
      * accessibility/AccessibilityListBoxOption.cpp:
      (WebCore::AccessibilityListBoxOption::canSetSelectedAttribute):
      * accessibility/AccessibilityMenuList.cpp:
      (WebCore::AccessibilityMenuList::canSetFocusAttribute):
      * accessibility/AccessibilityMenuListOption.cpp:
      (WebCore::AccessibilityMenuListOption::isEnabled):
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::isEnabled):
      (WebCore::AccessibilityNodeObject::actionElement):
      (WebCore::AccessibilityNodeObject::canSetFocusAttribute):
      * css/SelectorChecker.cpp:
      (WebCore::SelectorChecker::checkOne):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::canShareStyleWithControl):
      * dom/Element.cpp:
      (WebCore::Element::isDisabledFormControl):
      * dom/Element.h:
      (Element):
      (WebCore::isDisabledFormControl): Add helper function for convenience.
      (WebCore):
      * dom/EventDispatcher.cpp:
      (WebCore::EventDispatcher::dispatchSimulatedClick):
      * dom/GestureEvent.cpp:
      (WebCore::GestureEventDispatchMediator::dispatchEvent):
      * dom/MouseEvent.cpp:
      (WebCore::MouseEventDispatchMediator::dispatchEvent):
      * dom/Node.cpp:
      (WebCore::Node::handleLocalEvents):
      (WebCore::Node::willRespondToMouseMoveEvents):
      (WebCore::Node::willRespondToMouseClickEvents):
      (WebCore::Node::willRespondToTouchEvents):
      * html/BaseMultipleFieldsDateAndTimeInputType.cpp:
      (WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerDisabled):
      * html/DOMFormData.cpp:
      (WebCore::DOMFormData::DOMFormData):
      * html/FileInputType.cpp:
      (WebCore::FileInputType::handleDOMActivateEvent):
      (WebCore::FileInputType::disabledAttributeChanged):
      * html/HTMLButtonElement.cpp:
      (WebCore::HTMLButtonElement::defaultEventHandler):
      (WebCore::HTMLButtonElement::willRespondToMouseClickEvents):
      (WebCore::HTMLButtonElement::isSuccessfulSubmitButton):
      * html/HTMLCollection.cpp:
      (WebCore::isMatchingElement):
      * html/HTMLFormControlElement.cpp:
      (WebCore::HTMLFormControlElement::updateAncestorDisabledState):
      (WebCore::HTMLFormControlElement::isDisabledFormControl):
      (WebCore::HTMLFormControlElement::supportsFocus):
      * html/HTMLFormControlElement.h:
      (HTMLFormControlElement):
      (WebCore::HTMLFormControlElement::isDisabledOrReadOnly):
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::isSuccessfulSubmitButton):
      (WebCore::HTMLInputElement::willRespondToMouseClickEvents):
      * html/HTMLOptGroupElement.cpp:
      (WebCore::HTMLOptGroupElement::isDisabledFormControl):
      * html/HTMLOptGroupElement.h:
      (HTMLOptGroupElement):
      * html/HTMLOptionElement.cpp:
      (WebCore::HTMLOptionElement::isDisabledFormControl):
      * html/HTMLOptionElement.h:
      (HTMLOptionElement):
      * html/HTMLPlugInElement.cpp:
      (WebCore::HTMLPlugInElement::willRespondToMouseClickEvents):
      * html/HTMLSelectElement.cpp:
      (WebCore::HTMLSelectElement::nextValidIndex):
      (WebCore::HTMLSelectElement::updateListBoxSelection):
      (WebCore::HTMLSelectElement::recalcListItems):
      (WebCore::HTMLSelectElement::appendFormData):
      (WebCore::HTMLSelectElement::updateSelectedState):
      (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
      (WebCore::HTMLSelectElement::defaultEventHandler):
      (WebCore::HTMLSelectElement::optionAtIndex):
      * html/ImageInputType.cpp:
      (WebCore::ImageInputType::handleDOMActivateEvent):
      * html/ResetInputType.cpp:
      (WebCore::ResetInputType::handleDOMActivateEvent):
      * html/SubmitInputType.cpp:
      (WebCore::SubmitInputType::handleDOMActivateEvent):
      * html/shadow/SliderThumbElement.cpp:
      (WebCore::SliderThumbElement::isDisabledFormControl):
      (WebCore::SliderThumbElement::defaultEventHandler):
      (WebCore::SliderThumbElement::willRespondToMouseMoveEvents):
      (WebCore::SliderThumbElement::willRespondToMouseClickEvents):
      * html/shadow/SliderThumbElement.h:
      (SliderThumbElement):
      * html/shadow/SpinButtonElement.h:
      * html/shadow/TextFieldDecorationElement.cpp:
      (WebCore::TextFieldDecorationElement::updateImage):
      * loader/FormSubmission.cpp:
      (WebCore::FormSubmission::create):
      * page/DragController.cpp:
      (WebCore::DragController::tryDocumentDrag):
      (WebCore::DragController::concludeEditDrag):
      * rendering/RenderListBox.cpp:
      (WebCore::RenderListBox::addFocusRingRects):
      (WebCore::RenderListBox::paintItemForeground):
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::itemIsEnabled):
      * rendering/RenderTextControl.cpp:
      (WebCore::updateUserModifyProperty):
      * rendering/RenderTheme.cpp:
      (WebCore::RenderTheme::isEnabled):
      * rendering/RenderThemeMac.mm:
      (WebCore::getMediaUIPartStateFlags):
      * rendering/RenderThemeMacShared.mm:
      (WebCore::RenderThemeMacShared::adjustMenuListStyle):
      (WebCore::RenderThemeMacShared::paintSearchFieldCancelButton):
      * rendering/RenderThemeSafari.cpp:
      (WebCore::RenderThemeSafari::adjustMenuListStyle):
      
      Source/WebKit/blackberry:
      
      * WebCoreSupport/CredentialTransformData.cpp:
      (WebCore::CredentialTransformData::findPasswordFormFields):
      * WebKitSupport/DOMSupport.cpp:
      (BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement):
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::openSelectPopup):
      
      Source/WebKit/chromium:
      
      * src/WebFormControlElement.cpp:
      (WebKit::WebFormControlElement::isEnabled):
      * src/WebOptionElement.cpp:
      (WebKit::WebOptionElement::isEnabled):
      * src/WebPasswordFormUtils.cpp:
      (WebKit::findPasswordFormFields):
      * src/WebSearchableFormData.cpp:
      (HTMLNames::findSuitableSearchInputElement):
      (HTMLNames::buildSearchString):
      
      Source/WebKit/win:
      
      * DOMHTMLClasses.cpp:
      (DOMHTMLInputElement::disabled):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147135 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2113254c
  4. 27 Mar, 2013 2 commits
  5. 26 Mar, 2013 7 commits
    • hayato@chromium.org's avatar
      Allow ShadowContents in HitTests by default. · af1544e8
      hayato@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113171
      
      Reviewed by Dimitri Glazkov.
      
      Source/WebCore:
      
      HitTestRequest is widely used in WebCore, but AllowShadowContents
      flag is not turned on by default.  In most places, we can set the
      flag on.
      
      This change makes HitTests allow shadow contents by default.
      
      To track all existing HitTests which do not allow shadow contents,
      and discourage such a HitTest in the future, I've introduced
      disallowShadowContenet flag so that callers must turn on this flag
      explicitly if they want to disallow shadow contents in their HitTests.
      
      This change should be refactoring and should not include any
      behavior changes.  After this change, we'll investigate each place
      where disallowShadowContents is used step by step and get rid of
      the flag if it is okay to remove.
      
      No new tests, no behavior change.
      
      * dom/Document.h:
      (Document):
      * dom/TreeScope.cpp:
      (WebCore::nodeFromPoint):
      * editing/FrameSelection.cpp:
      (WebCore::FrameSelection::contains):
      * page/DragController.cpp:
      (WebCore::elementUnderMouse):
      (WebCore::DragController::canProcessDrag):
      (WebCore::DragController::startDrag):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handleMouseDraggedEvent):
      (WebCore::EventHandler::eventMayStartDrag):
      (WebCore::EventHandler::updateSelectionForMouseDrag):
      (WebCore::EventHandler::hitTestResultAtPoint):
      (WebCore::EventHandler::handleMousePressEvent):
      (WebCore::EventHandler::handleMouseDoubleClickEvent):
      (WebCore::EventHandler::handleMouseMoveEvent):
      (WebCore::EventHandler::handleMouseReleaseEvent):
      (WebCore::EventHandler::updateDragAndDrop):
      (WebCore::EventHandler::isInsideScrollbar):
      (WebCore::EventHandler::handleWheelEvent):
      (WebCore::EventHandler::handleGestureEvent):
      (WebCore::EventHandler::handleGestureLongPress):
      (WebCore::EventHandler::handleGestureScrollBegin):
      (WebCore::EventHandler::bestClickableNodeForTouchPoint):
      (WebCore::EventHandler::bestContextMenuNodeForTouchPoint):
      (WebCore::EventHandler::bestZoomableAreaForTouchPoint):
      (WebCore::EventHandler::sendContextMenuEvent):
      (WebCore::EventHandler::sendContextMenuEventForKey):
      (WebCore::EventHandler::hoverTimerFired):
      (WebCore::EventHandler::dragSourceEndedAt):
      (WebCore::EventHandler::handleDrag):
      (WebCore::EventHandler::handleTouchEvent):
      (WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled):
      * page/EventHandler.h:
      (EventHandler):
      * page/FocusController.cpp:
      (WebCore::updateFocusCandidateIfNeeded):
      * page/Frame.cpp:
      (WebCore::Frame::visiblePositionForPoint):
      * page/TouchDisambiguation.cpp:
      (WebCore::findGoodTouchTargets):
      * rendering/HitTestRequest.h:
      (WebCore::HitTestRequest::disallowsShadowContent):
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestResult::addNodeToRectBasedTestResult):
      * rendering/RenderFlowThread.cpp:
      (WebCore::RenderFlowThread::hitTestFlowThreadPortionInRegion):
      * rendering/svg/RenderSVGResourceClipper.cpp:
      (WebCore::RenderSVGResourceClipper::hitTestClipContent):
      * testing/Internals.cpp:
      (WebCore::Internals::nodesFromRect):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::hitTestResult):
      * WebKitSupport/FatFingers.cpp:
      (BlackBerry::WebKit::FatFingers::getNodesFromRect):
      * WebKitSupport/ProximityDetector.cpp:
      (BlackBerry::WebKit::ProximityDetector::findBestPoint):
      * WebKitSupport/SelectionHandler.cpp:
      (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
      
      Source/WebKit/chromium:
      
      * src/ContextMenuClientImpl.cpp:
      (WebKit::selectMisspelledWord):
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::visiblePositionForWindowPoint):
      * src/WebPluginContainerImpl.cpp:
      (WebKit::WebPluginContainerImpl::isRectTopmost):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::computeBlockBounds):
      (WebKit::WebViewImpl::bestTapNode):
      
      Source/WebKit/efl:
      
      * ewk/ewk_frame.cpp:
      (ewk_frame_hit_test_new):
      
      Source/WebKit/gtk:
      
      * webkit/webkitwebinspector.cpp:
      (webkit_web_inspector_inspect_coordinates):
      * webkit/webkitwebview.cpp:
      (prepareMouseEventForFrame):
      (webkit_web_view_get_hit_test_result):
      
      Source/WebKit/mac:
      
      * WebView/WebFrame.mm:
      (-[WebFrame elementAtPoint:]):
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView elementAtPoint:allowShadowContent:]):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/QWebFrameAdapter.cpp:
      (QWebFrameAdapter::hitTestContent):
      
      Source/WebKit/win:
      
      * WebView.cpp:
      (WebView::gestureNotify):
      
      Source/WebKit2:
      
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::hitTest):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::highlightPotentialActivation):
      (WebKit::WebPage::findZoomableAreaForPoint):
      (WebKit::WebPage::determinePrimarySnapshottedPlugIn):
      * WebProcess/WebPage/mac/WebPageMac.mm:
      (WebKit::WebPage::shouldDelayWindowOrderingEvent):
      (WebKit::WebPage::acceptsFirstMouse):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146961 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af1544e8
    • commit-queue@webkit.org's avatar
      [BlackBerry] Memory leak in WebPagePrivate.cpp - NavigatorContentUtilsClientBlackBerry · 0a171184
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112996
      
      Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2013-03-26
      Reviewed by Rob Buis.
      
      PR 312552
      Internally Reviewed by Anthony Scian.
      
      NavigatorContentUtilsClientBlackBerry is new'ed in WebPagePrivate::init(),
      but not deleted anywhere. Fixed by creating an OwnPtr for it.
      Also fixed some webkit-style errors.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::init):
      * Api/WebPage_p.h:
      (WebCore):
      (WebPagePrivate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146960 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a171184
    • commit-queue@webkit.org's avatar
      [BlackBerry] Include accelerated compositing layers in screen captures. · 6f270615
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113335
      
      Patch by Mike Lattanzio <mlattanzio@blackberry.com> on 2013-03-26
      Reviewed by Rob Buis.
      
      PR# 280374
      Include accelerated compositing layers in screen captures.
      Reviewed Internally By: Jakob Petsovits
      
      * Api/BackingStore.cpp:
      (BlackBerry::WebKit::BackingStorePrivate::render):
      (BlackBerry::WebKit::BackingStorePrivate::renderContents):
      (BlackBerry::WebKit::BackingStore::drawContents):
      * Api/BackingStore_p.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146934 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f270615
    • commit-queue@webkit.org's avatar
      [BlackBerry] Set mouse document position for mouse event in updateCursor · 0e61ec9b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109094
      
      Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-03-26
      Reviewed by Rob Buis.
      
      Internally Reviewed by Jakob Petsovits.
      
      Mouse content position should be in document coordinate.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::updateCursor):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146930 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e61ec9b
    • anilsson@rim.com's avatar
      [BlackBerry] Scrolling up and down can cause the screen to flash black · cd289bab
      anilsson@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113269
      
      Reviewed by Rob Buis.
      
      PR 296106
      
      Source/WebCore:
      
      The LayerRenderer should never clear before drawing the layers, from
      now on that's the responsibility of the caller.
      
      Only manually testable.
      
      * platform/graphics/blackberry/LayerRenderer.cpp:
      (WebCore::LayerRenderer::setViewport):
      * platform/graphics/blackberry/LayerRendererClient.h:
      (LayerRendererClient):
      
      Source/WebKit/blackberry:
      
      Various flaws in the code could conspire to make the screen cleared to
      black before rendering the web page. This only happened when the
      BackingStore was inactive, and the LayerTiler takes on the job of
      drawing the root layer. When tiles are missing, this made the
      "checkerboard" effect especially noticeable since black color was seen
      where the tile should have been. It would be better to clear to the web
      page background color.
      
      This was actually the intent of the code, but when the document
      background color was invalid, we would still use it instead of the
      background color from settings. Also, the LayerRenderer would clear to
      black when WebPageCompositorPrivate::drawsRootLayer() was true.
      
      Fixed by falling back to the settings background color when the
      document background color is invalid, and removing the clearing code
      from the LayerRenderer entirely. The appropriate clear already happens
      near the beginning of BackingStorePrivate::blitVisibleContents().
      
      Also slightly cleaned up the code for managing the background color.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::setLoadState):
      (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
      (BlackBerry::WebKit::WebPagePrivate::updateBackgroundColor):
      (WebKit):
      (BlackBerry::WebKit::WebPagePrivate::documentBackgroundColor):
      * Api/WebPageCompositor.cpp:
      * Api/WebPageCompositor_p.h:
      (WebPageCompositorPrivate):
      * Api/WebPage_p.h:
      (WebPagePrivate):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd289bab
    • anilsson@rim.com's avatar
      [BlackBerry] WebOverlay::pixelViewportRect() should return pixel viewport coordinates · 302250bc
      anilsson@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113263
      
      Reviewed by Rob Buis.
      
      PR 312404
      
      Source/WebCore:
      
      Fix WebOverlay::pixelViewportRect() to return the pixel viewport rect
      instead of the window rect. These are different if the web page is
      rendered starting at a window coordinate other than 0,0. The clip rect
      encodes the position we're rendered at, and can be used to translate
      the rect expressed in window coordinates to the pixel viewport
      coordinate system.
      
      Also perform some cleanup of related code.
      
      Only manually testable.
      
      * platform/graphics/blackberry/LayerCompositingThread.cpp:
      (WebCore::LayerCompositingThread::getTransformedHolePunchRect):
      (WebCore::LayerCompositingThread::drawTextures):
      * platform/graphics/blackberry/LayerRenderer.cpp:
      (WebCore::toPixelCoordinates):
      (WebCore):
      (WebCore::LayerRenderer::toWindowCoordinates):
      (WebCore::LayerRenderer::toPixelViewportCoordinates):
      (WebCore::LayerRenderer::toDocumentViewportCoordinates):
      (WebCore::LayerRenderer::updateLayersRecursive):
      * platform/graphics/blackberry/LayerRenderer.h:
      (LayerRenderer):
      
      Source/WebKit/blackberry:
      
      Fixed by returning pixel viewport coordinates instead of window
      coordinates.
      
      * Api/WebOverlay.cpp:
      (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::pixelViewportRect):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146906 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      302250bc
    • commit-queue@webkit.org's avatar
      [BlackBerry] Memory leak in UserMediaClientImpl · 3fc4294d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112998
      
      Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2013-03-26
      Reviewed by Rob Buis.
      
      PR 312559
      Internally Reviewed by Anthony Scian.
      
      Should destroy itself in UserMediaClientImpl::pageDestroyed(), as other
      XXClientBlackBerry did, like GeolocationClientBlackBerry::geolocationDestroyed().
      
      * WebCoreSupport/UserMediaClientImpl.cpp:
      (WebCore::UserMediaClientImpl::pageDestroyed):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146865 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fc4294d
  6. 25 Mar, 2013 2 commits
    • tkent@chromium.org's avatar
      Rename ENABLE_INPUT_TYPE_DATETIME · 866ba1bd
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113254
      
      Reviewed by Kentaro Hara.
      
      Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
      Actually I'd like to remove the code, but we shouldn't remove it yet
      because we shipped products with it on some platforms.
      
      .:
      
      * Source/autotools/SetupWebKitFeatures.m4:
      * Source/cmake/WebKitFeatures.cmake:
      * Source/cmakeconfig.h.cmake:
      
      Source/JavaScriptCore:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebCore:
      
      * Configurations/FeatureDefines.xcconfig:
      * bindings/generic/RuntimeEnabledFeatures.cpp:
      (WebCore):
      * bindings/generic/RuntimeEnabledFeatures.h:
      (RuntimeEnabledFeatures):
      * css/html.css:
      * html/DateTimeInputType.cpp:
      * html/DateTimeInputType.h:
      * html/InputType.cpp:
      (WebCore::createInputTypeFactoryMap):
      
      Source/WebKit/blackberry:
      
      * WebCoreSupport/AboutDataEnableFeatures.in:
      
      Source/WebKit/chromium:
      
      * src/WebRuntimeFeatures.cpp:
      (WebKit::WebRuntimeFeatures::enableInputTypeDateTime):
      (WebKit::WebRuntimeFeatures::isInputTypeDateTimeEnabled):
      * tests/WebViewTest.cpp:
      
      Source/WebKit/mac:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebKit2:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WTF:
      
      * wtf/FeatureDefines.h:
      
      Tools:
      
      * Scripts/webkitperl/FeatureList.pm:
      * qmake/mkspecs/features/features.pri:
      
      WebKitLibraries:
      
      * win/tools/vsprops/FeatureDefines.props:
      * win/tools/vsprops/FeatureDefines.vsprops:
      * win/tools/vsprops/FeatureDefinesCairo.props:
      * win/tools/vsprops/FeatureDefinesCairo.vsprops:
      
      LayoutTests:
      
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146847 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      866ba1bd
    • mary.wu@torchmobile.com.cn's avatar
      [BlackBerry] add needReferer in WebPage load() api · e31bb698
      mary.wu@torchmobile.com.cn authored
      https://bugs.webkit.org/show_bug.cgi?id=113167
      
      Reviewed by Rob Buis.
      
      PR310175, internally reviewed by Joe Mason.
      Sometimes when client load request, it need to add referer with current frame like
      save link/image in option menu, so we add needRef in load() interface in webpage.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::load):
      (BlackBerry::WebKit::WebPage::load):
      (BlackBerry::WebKit::WebPage::loadExtended):
      (BlackBerry::WebKit::WebPage::loadFile):
      (BlackBerry::WebKit::WebPage::download):
      * Api/WebPage.h:
      * Api/WebPage_p.h:
      (WebPagePrivate):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146845 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e31bb698
  7. 22 Mar, 2013 5 commits
    • commit-queue@webkit.org's avatar
      [BlackBerry] Build fix in InputHandler · 1488d2de
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113092
      
      Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-03-22
      Reviewed by Rob Buis.
      
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::setElementUnfocused):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1488d2de
    • commit-queue@webkit.org's avatar
      Check focused node reference when traversing through history · 538ddbcd
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113082
      
      Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-03-22
      Reviewed by Rob Buis.
      
      PR312101
      Check if we have a valid node and document before attempting to access its frame and
      frame selection. This is causing issues when going back to a page after a redirect
      where a stale pointer is used.
      Further, the focused node should be changed after the frame is fully loaded.
      
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::setElementUnfocused):
      (BlackBerry::WebKit::InputHandler::restoreViewState):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      538ddbcd
    • commit-queue@webkit.org's avatar
      [BlackBerry] Hit Test doesn't need to be active · 6d330619
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113072
      
      Patch by Genevieve Mak <gmak@rim.com> on 2013-03-22
      Reviewed by Rob Buis.
      
      Reviewed Internally By Mike Lattanzio.
      PR #306074
      
      * WebKitSupport/ProximityDetector.cpp:
      (BlackBerry::WebKit::ProximityDetector::findBestPoint):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d330619
    • commit-queue@webkit.org's avatar
      [BlackBerry] Selection overlay clipped incorrectly · 38754417
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113069
      
      Patch by Andrew Lo <anlo@rim.com> on 2013-03-22
      Reviewed by George Staikos.
      Internally reviewed by Arvid Nilsson.
      
      As a follow-up to r146278, the clip rect also needs to be
      adjusted by the parent's offset when drawing the
      selection overlay.
      
      * WebKitSupport/SelectionOverlay.cpp:
      (BlackBerry::WebKit::SelectionOverlay::paintContents):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146627 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38754417
    • commit-queue@webkit.org's avatar
      [BlackBerry] Add custom BackForwardList client implementation · 1e142fb8
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113024
      
      Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-22
      Reviewed by Rob Buis.
      
      PR 310030
      Internally reviewed by Joe Mason.
      
      Source/WebKit:
      
      * PlatformBlackBerry.cmake: Add new files to compilation.
      
      Source/WebKit/blackberry:
      
      Adds a new class BackForwardListBlackBerry that implements
      BackForwardList client and wraps the BackForwardListImpl including
      the BlackBerry specific changes to notify the API layer when the
      BackForwardList changes.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::init): Create a
      BackForwardListBlackBerry.
      (BlackBerry::WebKit::WebPage::getBackForwardList): Use
      BackForwardListBlackBerry instead of BackForwardListImpl.
      (BlackBerry::WebKit::WebPage::clearBackForwardList): Ditto.
      * WebCoreSupport/BackForwardListBlackBerry.cpp: Added.
      (WebCore):
      (WebCore::BackForwardListBlackBerry::BackForwardListBlackBerry):
      (WebCore::BackForwardListBlackBerry::~BackForwardListBlackBerry):
      (WebCore::BackForwardListBlackBerry::current):
      (WebCore::BackForwardListBlackBerry::notifyBackForwardListChanged):
      (WebCore::BackForwardListBlackBerry::addItem):
      (WebCore::BackForwardListBlackBerry::goToItem):
      (WebCore::BackForwardListBlackBerry::itemAtIndex):
      (WebCore::BackForwardListBlackBerry::backListCount):
      (WebCore::BackForwardListBlackBerry::forwardListCount):
      (WebCore::BackForwardListBlackBerry::isActive):
      (WebCore::BackForwardListBlackBerry::close):
      (WebCore::BackForwardListBlackBerry::clear):
      (WebCore::BackForwardListBlackBerry::entries):
      (WebCore::BackForwardListBlackBerry::currentItem):
      * WebCoreSupport/BackForwardListBlackBerry.h: Added.
      (WebKit):
      (WebCore):
      (BackForwardListBlackBerry):
      (WebCore::BackForwardListBlackBerry::create):
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      * WebCoreSupport/FrameLoaderClientBlackBerry.h:
      (FrameLoaderClientBlackBerry):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e142fb8
  8. 21 Mar, 2013 2 commits
  9. 19 Mar, 2013 4 commits
  10. 18 Mar, 2013 5 commits
  11. 15 Mar, 2013 5 commits
    • anilsson@rim.com's avatar
      [BlackBerry] BlackBerry::Platform::Graphics::GraphicsContext integration... · 5463b8da
      anilsson@rim.com authored
      [BlackBerry] BlackBerry::Platform::Graphics::GraphicsContext integration related changes in Source/WebKit/blackberry
      https://bugs.webkit.org/show_bug.cgi?id=112467
      
      Reviewed by Rob Buis.
      
      PR 293208
      
      This patch contains contributions from many members of the BlackBerry
      WebKit team:
      
      Mike Lattanzio
      Arvid Nilsson
      Jakob Petsovits
      Konrad Piascik
      Jeff Rogers
      Filip Spacek
      
      * Api/BackingStore.cpp:
      (BlackBerry::WebKit::BackingStorePrivate::render):
      (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
      (BlackBerry::WebKit::BackingStorePrivate::compositeContents):
      (BlackBerry::WebKit::BackingStorePrivate::tileSize):
      * Api/WebOverlay.cpp:
      (BlackBerry::WebKit::WebOverlayPrivate::drawContents):
      (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::paintContents):
      (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::WebOverlayLayerCompositingThreadClient):
      (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContentsToImage):
      (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::clearUploadedContents):
      (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContentsToColor):
      (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
      (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):
      (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::WebOverlayPrivateCompositingThread):
      (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::removeFromParent):
      (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):
      * Api/WebOverlay.h:
      * Api/WebOverlayClient.h:
      * Api/WebOverlay_p.h:
      (WebOverlayPrivate):
      (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::showDebugBorders):
      (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::showRepaintCounter):
      (WebOverlayLayerCompositingThreadClient):
      (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::image):
      (WebOverlayPrivateCompositingThread):
      * Api/WebPageCompositor.cpp:
      (BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
      * WebKitSupport/BackingStoreTile.cpp:
      (BlackBerry::WebKit::TileBuffer::~TileBuffer):
      (BlackBerry::WebKit::TileBuffer::nativeBuffer):
      (BlackBerry::WebKit::TileBuffer::paintBackground):
      * WebKitSupport/DefaultTapHighlight.cpp:
      (BlackBerry::WebKit::DefaultTapHighlight::paintContents):
      (BlackBerry::WebKit::DefaultTapHighlight::showDebugBorders):
      (WebKit):
      (BlackBerry::WebKit::DefaultTapHighlight::showRepaintCounter):
      * WebKitSupport/DefaultTapHighlight.h:
      (DefaultTapHighlight):
      * WebKitSupport/InspectorOverlayBlackBerry.cpp:
      (BlackBerry::WebKit::InspectorOverlay::showDebugBorders):
      (WebKit):
      (BlackBerry::WebKit::InspectorOverlay::showRepaintCounter):
      * WebKitSupport/InspectorOverlayBlackBerry.h:
      (InspectorOverlay):
      * WebKitSupport/SelectionOverlay.cpp:
      (BlackBerry::WebKit::SelectionOverlay::draw):
      (BlackBerry::WebKit::SelectionOverlay::hide):
      (BlackBerry::WebKit::SelectionOverlay::paintContents):
      (BlackBerry::WebKit::SelectionOverlay::showDebugBorders):
      (WebKit):
      (BlackBerry::WebKit::SelectionOverlay::showRepaintCounter):
      * WebKitSupport/SelectionOverlay.h:
      (SelectionOverlay):
      * WebKitSupport/SurfacePool.cpp:
      (BlackBerry::WebKit::SurfacePool::createPlatformGraphicsContext):
      (BlackBerry::WebKit::SurfacePool::destroyPlatformGraphicsContext):
      (BlackBerry::WebKit::SurfacePool::waitForBuffer):
      (BlackBerry::WebKit::SurfacePool::notifyBuffersComposited):
      (BlackBerry::WebKit::SurfacePool::destroyPlatformSync):
      * WebKitSupport/SurfacePool.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5463b8da
    • anilsson@rim.com's avatar
      [BlackBerry] Expose the compositing thread layer's draw rectangle to aid hit testing · 4378b3c7
      anilsson@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112255
      
      Reviewed by Rob Buis.
      
      PR 308284.
      Reviewed internally by Yongxin Dai.
      
      Source/WebCore:
      
      Add a getter for the layer renderer of a compositing thread layer.
      
      No change in behavior, no new tests.
      
      * platform/graphics/blackberry/LayerCompositingThread.h:
      (WebCore::LayerCompositingThread::layerRenderer):
      
      Source/WebKit/blackberry:
      
      The cached draw rectangle is useful for hit testing. Add a getter for
      this compositing thread layer property to the public WebOverlay API.
      We name this getter using terminology familiar from the
      ViewportAccessor interface, to clarify which coordinate system the
      getter uses (pixel coordinates relative to the viewport).
      
      Note that WebKit-thread flavor of WebOverlay is not currently used by
      any API client and is marked obsolete. It is used internally in WebKit,
      but for that case using GraphicsLayer directly works well. This will
      allow the complexity of WebOverlay to be significantly reduced in the
      future, by removing the WebKit-thread flavor entirely.
      
      * Api/WebOverlay.cpp:
      (BlackBerry::WebKit::WebOverlay::pixelViewportRect):
      (WebKit):
      (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::pixelViewportRect):
      (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::pixelViewportRect):
      * Api/WebOverlay.h:
      (WebKit):
      * Api/WebOverlay_p.h:
      (WebOverlayPrivate):
      (WebOverlayPrivateWebKitThread):
      (WebOverlayPrivateCompositingThread):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145962 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4378b3c7
    • anilsson@rim.com's avatar
      [BlackBerry] Allow an embedder to position child windows using window coordinates · 6e6be122
      anilsson@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112236
      
      Reviewed by Rob Buis.
      
      PR 232752
      
      Source/WebCore:
      
      The LayerCompositingThread can now position the video window using
      either document or window coordinates.
      
      The LayerRenderer class gets a new client interface. This allows us to
      avoid state duplication by delegating decisions directly to the client,
      which can then be in charge of the (one and only) state.
      
      The context is moved over to the client, as well as delegation of the
      decision on whether to clear the surface every frame.
      
      Also, the decision on which coordinate system to use for positioning
      child windows is delegated to the client interface.
      
      No new tests, not testable using DRT.
      
      * platform/graphics/blackberry/LayerCompositingThread.cpp:
      (WebCore::LayerCompositingThread::drawTextures):
      * platform/graphics/blackberry/LayerRenderer.cpp:
      (WebCore::LayerRenderer::create):
      (WebCore::LayerRenderer::LayerRenderer):
      (WebCore::LayerRenderer::setViewport):
      (WebCore::LayerRenderer::compositeLayers):
      (WebCore::LayerRenderer::toWebKitWindowCoordinates):
      (WebCore::LayerRenderer::makeContextCurrent):
      * platform/graphics/blackberry/LayerRenderer.h:
      (WebCore):
      (LayerRenderer):
      (WebCore::LayerRenderer::client):
      * platform/graphics/blackberry/LayerRendererClient.h: Added.
      (Graphics):
      (WebCore):
      (LayerRendererClient):
      (WebCore::LayerRendererClient::~LayerRendererClient):
      
      Source/WebKit/blackberry:
      
      Child windows used to always be positioned in document coordinates,
      which requires the
      BlackBerry::Platform::Graphics::Window::virtualRect() of the parent
      window to be kept in sync with the document visible content rect.
      This is easy if there's a one-to-one correspondence between windows
      and scrollable frames.
      
      However, for an embedder that can display an entire scene graph (where
      the web page is just one of the nodes) in one window, several
      scrollable nodes may be present in that window, and it's difficult to
      know which scrollable node to sync the virtualRect with. It could also
      lead to conflicts, if two scrollable nodes have child windows.
      
      For the latter scenario, it makes more sense to use window coordinates
      to place child windows.
      
      The internal default is to use document coordinates, for legacy
      reasons.
      
      When an external WebPageCompositor is attached, we switch to using
      window coordinates instead of document coordinates by default. The
      behavior is still configurable using the new public
      setChildWindowPlacement method.
      
      * Api/WebPageCompositor.cpp:
      (BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
      (BlackBerry::WebKit::WebPageCompositorPrivate::setContext):
      (BlackBerry::WebKit::WebPageCompositorPrivate::prepareFrame):
      (BlackBerry::WebKit::WebPageCompositorPrivate::render):
      (BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
      (BlackBerry::WebKit::WebPageCompositorPrivate::shouldClearSurfaceBeforeCompositing):
      (WebKit):
      (BlackBerry::WebKit::WebPageCompositorPrivate::shouldChildWindowsUseDocumentCoordinates):
      (BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
      (BlackBerry::WebKit::WebPageCompositor::setChildWindowPlacement):
      * Api/WebPageCompositor.h:
      * Api/WebPageCompositor_p.h:
      (BlackBerry::WebKit::WebPageCompositorPrivate::setChildWindowPlacement):
      (WebPageCompositorPrivate):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145953 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e6be122
    • japhet@chromium.org's avatar
      Hide MainResourceLoader from the outside world · 7a771246
      japhet@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109971
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      No new tests, refactor only.
      
      * WebCore.exp.in:
      * dom/Document.cpp:
      * html/HTMLEmbedElement.cpp:
      * html/MediaDocument.cpp:
      * html/PluginDocument.cpp:
      * loader/DocumentLoader.cpp:
      (WebCore::DocumentLoader::mainResourceLoader):
      (WebCore::DocumentLoader::finishedLoading):
      (WebCore::DocumentLoader::receivedData):
      (WebCore::DocumentLoader::setMainResourceDataBufferingPolicy):
      * loader/DocumentLoader.h:
      * loader/EmptyClients.h:
      * loader/FrameLoader.cpp:
      * loader/FrameLoaderClient.h:
      * loader/MainResourceLoader.cpp:
      * loader/appcache/ApplicationCacheGroup.cpp:
      * loader/appcache/ApplicationCacheHost.cpp:
      
      Source/WebKit/blackberry:
      
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      (WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):
      * WebCoreSupport/FrameLoaderClientBlackBerry.h:
      (FrameLoaderClientBlackBerry):
      
      Source/WebKit/chromium:
      
      * src/FrameLoaderClientImpl.cpp:
      (WebKit::FrameLoaderClientImpl::convertMainResourceLoadToDownload):
      * src/FrameLoaderClientImpl.h:
      (FrameLoaderClientImpl):
      
      Source/WebKit/efl:
      
      * WebCoreSupport/FrameLoaderClientEfl.cpp:
      (WebCore::FrameLoaderClientEfl::convertMainResourceLoadToDownload):
      * WebCoreSupport/FrameLoaderClientEfl.h:
      (FrameLoaderClientEfl):
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      (WebKit::FrameLoaderClient::convertMainResourceLoadToDownload):
      * WebCoreSupport/FrameLoaderClientGtk.h:
      (FrameLoaderClient):
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebFrameLoaderClient.h:
      (WebFrameLoaderClient):
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (WebFrameLoaderClient::convertMainResourceLoadToDownload):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::convertMainResourceLoadToDownload):
      * WebCoreSupport/FrameLoaderClientQt.h:
      (FrameLoaderClientQt):
      
      Source/WebKit/win:
      
      * WebFrame.cpp:
      (WebFrame::convertMainResourceLoadToDownload):
      * WebFrame.h:
      
      Source/WebKit/wince:
      
      * WebCoreSupport/FrameLoaderClientWinCE.cpp:
      (WebKit::FrameLoaderClientWinCE::convertMainResourceLoadToDownload):
      * WebCoreSupport/FrameLoaderClientWinCE.h:
      (FrameLoaderClientWinCE):
      
      Source/WebKit/wx:
      
      * WebKitSupport/FrameLoaderClientWx.cpp:
      (WebCore::FrameLoaderClientWx::convertMainResourceLoadToDownload):
      * WebKitSupport/FrameLoaderClientWx.h:
      (FrameLoaderClientWx):
      
      Source/WebKit2:
      
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::convertMainResourceLoadToDownload):
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
      (WebFrameLoaderClient):
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::convertMainResourceLoadToDownload):
      * WebProcess/WebPage/WebFrame.h:
      (WebFrame):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145914 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a771246
    • inferno@chromium.org's avatar
      Replace static_casts with to* helper functions. · 92242cbf
      inferno@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112401
      
      Reviewed by Stephen Chenney.
      
      to* helper functions are preferred over static_cast calls since they
      help to catch bad casts easily on the testing infrastructure.
      
      Source/WebCore:
      
      * accessibility/AccessibilityObject.cpp:
      (WebCore::appendAccessibilityObject):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::visiblePositionForPoint):
      * accessibility/AccessibilityScrollView.cpp:
      (WebCore::AccessibilityScrollView::webAreaObject):
      (WebCore::AccessibilityScrollView::documentFrameView):
      (WebCore::AccessibilityScrollView::parentObject):
      (WebCore::AccessibilityScrollView::parentObjectIfExists):
      * accessibility/chromium/AXObjectCacheChromium.cpp:
      (WebCore::AXObjectCache::postPlatformNotification):
      * bindings/js/JSPluginElementFunctions.cpp:
      (WebCore::pluginScriptObjectFromPluginViewBase):
      * bindings/js/PageScriptDebugServer.cpp:
      (WebCore::PageScriptDebugServer::setJavaScriptPaused):
      * bindings/js/ScriptController.cpp:
      (WebCore::ScriptController::createScriptInstanceForWidget):
      * bindings/js/ScriptControllerQt.cpp:
      (WebCore::ScriptController::createScriptInstanceForWidget):
      * bindings/v8/ScriptController.cpp:
      (WebCore::ScriptController::createScriptInstanceForWidget):
      * html/HTMLObjectElement.cpp:
      (WebCore::HTMLObjectElement::appendFormData):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::subframeForTargetNode):
      (WebCore::EventHandler::passGestureEventToWidget):
      * page/Frame.cpp:
      (WebCore::Frame::frameForWidget):
      * page/FrameView.cpp:
      (WebCore::collectFrameViewChildren):
      (WebCore::FrameView::hasCustomScrollbars):
      (WebCore::FrameView::convertToContainingView):
      (WebCore::FrameView::convertFromContainingView):
      (WebCore::FrameView::removeChild):
      * page/FrameView.h:
      (WebCore::toFrameView):
      (WebCore):
      * page/Page.cpp:
      (WebCore::Page::collectPluginViews):
      * page/chromium/EventHandlerChromium.cpp:
      (WebCore::EventHandler::passWheelEventToWidget):
      * page/efl/EventHandlerEfl.cpp:
      (WebCore::EventHandler::passWheelEventToWidget):
      * page/gtk/EventHandlerGtk.cpp:
      (WebCore::EventHandler::passWheelEventToWidget):
      * page/mac/EventHandlerMac.mm:
      (WebCore::EventHandler::passWheelEventToWidget):
      * page/qt/EventHandlerQt.cpp:
      (WebCore::EventHandler::passWheelEventToWidget):
      * page/scrolling/ScrollingCoordinator.cpp:
      (WebCore::ScrollingCoordinator::computeNonFastScrollableRegion):
      * page/win/EventHandlerWin.cpp:
      (WebCore::EventHandler::passWheelEventToWidget):
      * page/wx/EventHandlerWx.cpp:
      (WebCore::EventHandler::passWheelEventToWidget):
      * platform/ScrollView.h:
      (WebCore::toScrollView):
      (WebCore):
      * platform/Scrollbar.cpp:
      (WebCore::Scrollbar::isScrollViewScrollbar):
      (WebCore::Scrollbar::mouseUp):
      (WebCore::Scrollbar::axObjectCache):
      * platform/Widget.h:
      (WebCore::Widget::isScrollView):
      * platform/blackberry/PlatformScreenBlackBerry.cpp:
      (WebCore::toUserSpace):
      * platform/efl/ScrollbarEfl.cpp:
      (ScrollbarEfl::setParent):
      * platform/qt/PlatformSupportQt.cpp:
      (WebCore::PlatformSupport::popupsAllowed):
      (WebCore::PlatformSupport::pluginScriptableObject):
      * plugins/IFrameShimSupport.cpp:
      (WebCore::getPluginOcclusions):
      * plugins/PluginView.h:
      (WebCore::toPluginView):
      (WebCore):
      * plugins/PluginViewBase.h:
      (WebCore::PluginViewBase::isPluginViewBase):
      (PluginViewBase):
      (WebCore::toPluginViewBase):
      (WebCore):
      * plugins/blackberry/PluginViewBlackBerry.cpp:
      (WebCore::PluginView::updatePluginWidget):
      (WebCore::PluginView::updateBuffer):
      (WebCore::PluginView::paint):
      (WebCore::PluginView::handleScrollEvent):
      (WebCore::PluginView::calculateClipRect):
      (WebCore::PluginView::handleFullScreenAllowedEvent):
      (WebCore::PluginView::handleFullScreenExitEvent):
      (WebCore::PluginView::setParent):
      (WebCore::PluginView::setNPWindowIfNeeded):
      (WebCore::PluginView::platformGetValue):
      (WebCore::PluginView::platformStart):
      (WebCore::PluginView::platformDestroy):
      (WebCore::PluginView::setBackgroundPlay):
      * plugins/blackberry/PluginViewPrivateBlackBerry.cpp:
      (WebCore::PluginViewPrivate::setVisibleRects):
      (WebCore::PluginViewPrivate::showKeyboard):
      (WebCore::PluginViewPrivate::requestFullScreen):
      (WebCore::PluginViewPrivate::requestCenterFitZoom):
      (WebCore::PluginViewPrivate::lockOrientation):
      (WebCore::PluginViewPrivate::unlockOrientation):
      (WebCore::PluginViewPrivate::preventIdle):
      * plugins/gtk/PluginViewGtk.cpp:
      (WebCore::PluginView::updatePluginWidget):
      * plugins/mac/PluginViewMac.mm:
      (WebCore::PluginView::platformStart):
      * plugins/qt/PluginViewQt.cpp:
      (WebCore::PluginView::updatePluginWidget):
      * plugins/win/PluginViewWin.cpp:
      (WebCore::PluginView::updatePluginWidget):
      (WebCore::PluginView::paintIntoTransformedContext):
      (WebCore::PluginView::paintWindowedPluginIntoContext):
      (WebCore::PluginView::paint):
      (WebCore::PluginView::handleMouseEvent):
      (WebCore::PluginView::setNPWindowRect):
      (WebCore::PluginView::snapshot):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::addLayoutOverflow):
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint):
      * rendering/RenderEmbeddedObject.cpp:
      (WebCore::RenderEmbeddedObject::allowsAcceleratedCompositing):
      (WebCore::RenderEmbeddedObject::viewCleared):
      (WebCore::RenderEmbeddedObject::nodeAtPoint):
      (WebCore::RenderEmbeddedObject::scroll):
      * rendering/RenderFlexibleBox.h:
      (WebCore::toRenderFlexibleBox):
      (WebCore):
      * rendering/RenderFrame.cpp:
      (WebCore::RenderFrame::viewCleared):
      * rendering/RenderFrameBase.cpp:
      (WebCore::RenderFrameBase::layoutWithFlattening):
      * rendering/RenderIFrame.cpp:
      (WebCore::RenderIFrame::contentRootRenderer):
      (WebCore::RenderIFrame::layoutSeamlessly):
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame):
      * rendering/RenderPart.cpp:
      (WebCore::RenderPart::requiresAcceleratedCompositing):
      (WebCore::RenderPart::embeddedContentBox):
      (WebCore::RenderPart::nodeAtPoint):
      * rendering/RenderRuby.cpp:
      (WebCore::rubyBeforeBlock):
      (WebCore::rubyAfterBlock):
      (WebCore::lastRubyRun):
      (WebCore::findRubyRunParent):
      * rendering/RenderTreeAsText.cpp:
      (WebCore::write):
      * rendering/RenderWidget.cpp:
      (WebCore::RenderWidget::paintContents):
      (WebCore::RenderWidget::setOverlapTestResult):
      (WebCore::RenderWidget::updateWidgetPosition):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::frameForNode):
      (BlackBerry::WebKit::needsLayoutRecursive):
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      (WebCore::FrameLoaderClientBlackBerry::redirectDataToPlugin):
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::ensureFocusPluginElementVisible):
      
      Source/WebKit/chromium:
      
      * src/WebPluginContainerImpl.cpp:
      (WebKit::WebPluginContainerImpl::scrollRect):
      (WebKit::WebPluginContainerImpl::setWantsWheelEvents):
      (WebKit::WebPluginContainerImpl::handleMouseEvent):
      * tests/ScrollingCoordinatorChromiumTest.cpp:
      (WebKit::TEST_F):
      
      Source/WebKit/efl:
      
      * WebCoreSupport/FrameLoaderClientEfl.cpp:
      (WebCore::FrameLoaderClientEfl::redirectDataToPlugin):
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      (WebKit::FrameLoaderClient::redirectDataToPlugin):
      
      Source/WebKit/mac:
      
      * WebView/WebRenderNode.mm:
      (copyRenderNode):
      * WebView/WebView.mm:
      (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::redirectDataToPlugin):
      
      Source/WebKit/win:
      
      * WebCoreSupport/EmbeddedWidget.cpp:
      (EmbeddedWidget::frameRectsChanged):
      * WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebFrameLoaderClient::redirectDataToPlugin):
      
      Source/WebKit/wince:
      
      * WebCoreSupport/FrameLoaderClientWinCE.cpp:
      (WebKit::FrameLoaderClientWinCE::redirectDataToPlugin):
      
      Source/WebKit/wx:
      
      * WebKitSupport/FrameLoaderClientWx.cpp:
      (WebCore::FrameLoaderClientWx::redirectDataToPlugin):
      
      Source/WebKit2:
      
      * Shared/WebRenderObject.cpp:
      (WebKit::WebRenderObject::WebRenderObject):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145913 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92242cbf
  12. 14 Mar, 2013 2 commits
    • commit-queue@webkit.org's avatar
      Add selectTrailingWhitespaceEnabled setting to WebCore::Page · 826c3d74
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109404
      
      Patch by Manuel Rego Casasnovas <rego@igalia.com> on 2013-03-14
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      Covered by
      editing/selection/doubleclick-inline-first-last-contenteditable.html.
      
      * page/Settings.cpp:
      (WebCore): Configure default value for smartInsertDeleteEnabled and
      selectTrailingWhitespaceEnabled seetings as they are different in
      Chromium port depending on the OS.
      * page/Settings.in: Add new setting.
      
      Source/WebKit/blackberry:
      
      Use new settings for smartInsertDeleteEnabled and
      selectTrailingWhitespaceEnabled.
      
      Remove code related to DRT as it is not needed anymore.
      
      * Api/DumpRenderTreeClient.h:
      * WebCoreSupport/EditorClientBlackBerry.cpp:
      (WebCore::EditorClientBlackBerry::smartInsertDeleteEnabled):
      (WebCore::EditorClientBlackBerry::isSelectTrailingWhitespaceEnabled):
      
      Source/WebKit/chromium:
      
      Use new Page settings for smartInsertDeleteEnabled and
      selectTrailingWhitespaceEnabled and update API accordingly.
      
      WebSettings API is required by DRT in order to set the proper default
      values which are different from browser defaults.
      
      * public/WebSettings.h: Add new API to manage smartInsertDeleteEnabled
      and selectTrailingWhitespaceEnabled settings.
      * public/WebViewClient.h: Remove API related to smartInsertDeleteEnabled
      and selectTrailingWhitespaceEnabled as they will be managed from page
      settings from now on.
      * src/EditorClientImpl.cpp:
      (WebKit::EditorClientImpl::smartInsertDeleteEnabled):
      (WebKit::EditorClientImpl::isSelectTrailingWhitespaceEnabled): Use new
      settings for smartInsertDeleteEnabled and
      selectTrailingWhitespaceEnabled.
      * src/WebSettingsImpl.cpp: Implement methods establishing the page
      settings.
      (WebKit::WebSettingsImpl::setSelectTrailingWhitespaceEnabled):
      (WebKit):
      (WebKit::WebSettingsImpl::setSmartInsertDeleteEnabled):
      * src/WebSettingsImpl.h:
      (WebSettingsImpl): Implement new API to manage the new settings.
      
      Source/WebKit/efl:
      
      Use new settings for smartInsertDeleteEnabled and
      selectTrailingWhitespaceEnabled.
      
      Remove code related to DRT as it is not needed anymore.
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      * WebCoreSupport/DumpRenderTreeSupportEfl.h:
      * WebCoreSupport/EditorClientEfl.cpp:
      (WebCore::EditorClientEfl::smartInsertDeleteEnabled):
      (WebCore::EditorClientEfl::isSelectTrailingWhitespaceEnabled):
      (WebCore::EditorClientEfl::EditorClientEfl):
      * WebCoreSupport/EditorClientEfl.h:
      (EditorClientEfl):
      
      Source/WebKit/gtk:
      
      Use new settings for smartInsertDeleteEnabled and
      selectTrailingWhitespaceEnabled.
      
      Remove code related to DRT as it is not needed anymore.
      
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
      * WebCoreSupport/DumpRenderTreeSupportGtk.h:
      (DumpRenderTreeSupportGtk):
      * WebCoreSupport/EditorClientGtk.cpp:
      (WebKit::EditorClient::smartInsertDeleteEnabled):
      (WebKit::EditorClient::isSelectTrailingWhitespaceEnabled):
      (WebKit::EditorClient::EditorClient):
      * WebCoreSupport/EditorClientGtk.h:
      (EditorClient):
      
      Source/WebKit/mac:
      
      Use new settings for smartInsertDeleteEnabled and
      selectTrailingWhitespaceEnabled.
      
      * WebCoreSupport/WebEditorClient.mm:
      (WebEditorClient::smartInsertDeleteEnabled):
      (WebEditorClient::isSelectTrailingWhitespaceEnabled):
      * WebView/WebView.mm:
      (-[WebView _commonInitializationWithFrameName:groupName:]): Initialize
      settings from NSUserDefaults.
      (-[WebView setSelectTrailingWhitespaceEnabled:]):
      (-[WebView isSelectTrailingWhitespaceEnabled]):
      (-[WebView setSmartInsertDeleteEnabled:]):
      (-[WebView smartInsertDeleteEnabled]):
      * WebView/WebViewData.h:
      * WebView/WebViewData.mm:
      (-[WebViewPrivate init]):
      
      Source/WebKit/qt:
      
      Use new settings for smartInsertDeleteEnabled and
      selectTrailingWhitespaceEnabled.
      
      Remove code related to DRT as it is not needed anymore.
      
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      * WebCoreSupport/DumpRenderTreeSupportQt.h:
      * WebCoreSupport/EditorClientQt.cpp:
      (WebCore::EditorClientQt::smartInsertDeleteEnabled):
      (WebCore::EditorClientQt::toggleSmartInsertDelete):
      (WebCore::EditorClientQt::isSelectTrailingWhitespaceEnabled):
      (WebCore::EditorClientQt::EditorClientQt):
      * WebCoreSupport/EditorClientQt.h:
      (EditorClientQt):
      
      Source/WebKit/win:
      
      Use new settings for smartInsertDeleteEnabled and
      selectTrailingWhitespaceEnabled.
      
      * WebCoreSupport/WebEditorClient.cpp:
      (WebEditorClient::smartInsertDeleteEnabled):
      (WebEditorClient::isSelectTrailingWhitespaceEnabled):
      * WebView.cpp:
      (WebView::WebView):
      (WebView::setSmartInsertDeleteEnabled):
      (WebView::smartInsertDeleteEnabled):
      (WebView::setSelectTrailingWhitespaceEnabled):
      (WebView::isSelectTrailingWhitespaceEnabled):
      * WebView.h:
      (WebView):
      
      Source/WebKit/wince:
      
      Use new settings for smartInsertDeleteEnabled and
      selectTrailingWhitespaceEnabled.
      
      * WebCoreSupport/EditorClientWinCE.cpp:
      (WebKit::EditorClientWinCE::smartInsertDeleteEnabled):
      (WebKit::EditorClientWinCE::isSelectTrailingWhitespaceEnabled):
      
      Source/WebKit/wx:
      
      Use new settings for smartInsertDeleteEnabled and
      selectTrailingWhitespaceEnabled.
      
      * WebKitSupport/EditorClientWx.cpp:
      (WebCore::EditorClientWx::smartInsertDeleteEnabled):
      (WebCore::EditorClientWx::isSelectTrailingWhitespaceEnabled):
      
      Tools:
      
      Removes all the code related to smartInsertDeleteEnabled and
      selectTrailingWhitespaceEnabled settings as they will be managed from
      internals from now on.
      
      * DumpRenderTree/TestRunner.cpp:
      (TestRunner::staticFunctions):
      * DumpRenderTree/TestRunner.h:
      (TestRunner):
      * DumpRenderTree/blackberry/DumpRenderTree.cpp:
      (WebKit):
      (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
      * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
      (DumpRenderTree):
      * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
      * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
      (WebTestRunner::WebTestProxy::didStopLoading):
      * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
      (WebTestRunner::TestRunner::TestRunner):
      (WebTestRunner::TestRunner::reset):
      * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
      (TestRunner):
      * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
      (WebTestRunner::WebPreferences::applyTo): Set default values for
      smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
      Chromium DRT default values are different from Chromium browser.
      * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
      * DumpRenderTree/chromium/WebViewHost.cpp:
      * DumpRenderTree/chromium/WebViewHost.h:
      (WebViewHost):
      * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
      (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
      * DumpRenderTree/efl/TestRunnerEfl.cpp:
      * DumpRenderTree/gtk/DumpRenderTree.cpp:
      (resetDefaultsToConsistentValues):
      * DumpRenderTree/gtk/TestRunnerGtk.cpp:
      * DumpRenderTree/mac/DumpRenderTree.mm:
      (resetWebViewToConsistentStateBeforeTesting):
      * DumpRenderTree/mac/TestRunnerMac.mm:
      * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
      (WebCore::WebPage::resetSettings):
      * DumpRenderTree/qt/TestRunnerQt.cpp:
      * DumpRenderTree/qt/TestRunnerQt.h:
      (TestRunnerQt):
      * DumpRenderTree/win/DumpRenderTree.cpp:
      (resetWebViewToConsistentStateBeforeTesting):
      * DumpRenderTree/win/TestRunnerWin.cpp:
      * DumpRenderTree/wx/TestRunnerWx.cpp:
      
      LayoutTests:
      
      Replace testRunner.setSelectTrailingWhitespaceEnabled by
      internals.settings.setSelectTrailingWhitespaceEnabled in tests.
      
      Be sure that trailingWhitespaceEnabled and
      selectTrailingWhitespaceEnabled are set to opposite values as they are
      mutually exclusive.
      
      * editing/deleting/smart-editing-disabled.html:
      * editing/selection/doubleclick-beside-cr-span.html:
      * editing/selection/doubleclick-whitespace-crash.html:
      * editing/selection/doubleclick-whitespace-img-crash.html:
      * editing/selection/doubleclick-whitespace.html:
      * editing/selection/script-tests/doubleclick-inline-first-last-contenteditable.js:
      * editing/spelling/resources/util.js:
      (initSpellTest):
      * editing/spelling/spelling-double-clicked-word-with-underscores.html:
      * editing/spelling/spelling-double-clicked-word.html:
      * platform/wk2/TestExpectations: Unflag
      editing/selection/doubleclick-inline-first-last-contenteditable.html
      as it passes now.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145849 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      826c3d74
    • inferno@chromium.org's avatar
      Replace static_casts with to* helper functions. · 9aa9e8d7
      inferno@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112296
      
      Reviewed by Kentaro Hara.
      
      to* helper functions are preferred over static_cast calls since they
      help to catch bad casts easily on the testing infrastructure.
      
      Source/WebCore:
      
      * accessibility/AXObjectCache.cpp:
      (WebCore::nodeHasRole):
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::hasAttribute):
      (WebCore::AccessibilityObject::getAttribute):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::anchorElement):
      (WebCore::AccessibilityRenderObject::helpText):
      (WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
      (WebCore::AccessibilityRenderObject::titleUIElement):
      (WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
      (WebCore::AccessibilityRenderObject::accessKey):
      (WebCore::AccessibilityRenderObject::setElementAttributeValue):
      (WebCore::AccessibilityRenderObject::setValue):
      (WebCore::AccessibilityRenderObject::activeDescendant):
      (WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
      (WebCore::AccessibilityRenderObject::correspondingLabelForControlElement):
      (WebCore::AccessibilityRenderObject::inheritsPresentationalRole):
      (WebCore::AccessibilityRenderObject::setAccessibleName):
      (WebCore::AccessibilityRenderObject::stringRoleForMSAA):
      * bindings/gobject/WebKitDOMBinding.cpp:
      (WebKit::createWrapper):
      * bindings/js/JSClipboardCustom.cpp:
      (WebCore::JSClipboard::setDragImage):
      * bindings/js/JSElementCustom.cpp:
      (WebCore::toJSNewlyCreated):
      * bindings/js/JSNodeCustom.cpp:
      (WebCore::createWrapperInline):
      * bindings/v8/custom/V8ClipboardCustom.cpp:
      (WebCore::V8Clipboard::setDragImageMethodCustom):
      * bindings/v8/custom/V8ElementCustom.cpp:
      (WebCore::wrap):
      * bindings/v8/custom/V8NodeCustom.cpp:
      (WebCore::wrap):
      * dom/Document.cpp:
      (WebCore::Document::importNode):
      (WebCore::Document::recalcStyle):
      (WebCore::Document::setFocusedNode):
      (WebCore::Document::updateFocusAppearanceTimerFired):
      * dom/DocumentStyleSheetCollection.cpp:
      (WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
      * dom/Element.cpp:
      (WebCore::Element::offsetParent):
      (WebCore::Element::boundsInRootViewSpace):
      (WebCore::Element::getBoundingClientRect):
      (WebCore::Element::recalcStyle):
      (WebCore::Element::computeInheritedLanguage):
      (WebCore::Element::lastElementChild):
      * dom/LiveNodeList.cpp:
      (WebCore::LiveNodeList::namedItem):
      * dom/Node.cpp:
      (WebCore::Node::dumpStatistics):
      (WebCore::Node::normalize):
      (WebCore::Node::rootEditableElement):
      (WebCore::Node::isDefaultNamespace):
      (WebCore::Node::ancestorElement):
      (WebCore::appendAttributeDesc):
      * dom/Position.cpp:
      (WebCore::Position::element):
      * dom/Range.cpp:
      (WebCore::Range::getBorderAndTextQuads):
      * dom/SelectorQuery.cpp:
      (WebCore::SelectorDataList::queryFirst):
      (WebCore::SelectorDataList::execute):
      * dom/ShadowRoot.cpp:
      (WebCore::ShadowRoot::recalcStyle):
      * dom/StaticHashSetNodeList.cpp:
      (WebCore::StaticHashSetNodeList::namedItem):
      * editing/ApplyStyleCommand.cpp:
      (WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi):
      (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):
      (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
      (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):
      * editing/Editor.cpp:
      (WebCore::Editor::applyEditingStyleToBodyElement):
      * editing/FrameSelection.cpp:
      (WebCore::removingNodeRemovesPosition):
      * editing/IndentOutdentCommand.cpp:
      (WebCore::IndentOutdentCommand::outdentParagraph):
      * editing/MarkupAccumulator.cpp:
      (WebCore::MarkupAccumulator::entityMaskForText):
      (WebCore::MarkupAccumulator::appendStartMarkup):
      (WebCore::MarkupAccumulator::appendEndMarkup):
      * editing/ModifySelectionListLevel.cpp:
      (WebCore::IncreaseSelectionListLevelCommand::doApply):
      * editing/ReplaceSelectionCommand.cpp:
      (WebCore::haveSameTagName):
      (WebCore::handleStyleSpansBeforeInsertion):
      (WebCore::ReplaceSelectionCommand::doApply):
      * editing/SplitTextNodeContainingElementCommand.cpp:
      (WebCore::SplitTextNodeContainingElementCommand::doApply):
      * editing/TextIterator.cpp:
      (WebCore::TextIterator::advance):
      * editing/htmlediting.cpp:
      (WebCore::unsplittableElementForPosition):
      (WebCore::enclosingTableCell):
      * editing/markup.cpp:
      (WebCore::StyledMarkupAccumulator::wrapWithNode):
      (WebCore::createMarkupInternal):
      (WebCore::createFragmentFromMarkupWithContext):
      (WebCore::isPlainTextMarkup):
      (WebCore::createFragmentFromText):
      * html/HTMLElement.cpp:
      (WebCore::HTMLElement::insertAdjacentElement):
      (WebCore::contextElementForInsertion):
      * html/HTMLFormControlElement.cpp:
      (WebCore::focusPostAttach):
      (WebCore::updateFromElementCallback):
      * html/HTMLFormElement.cpp:
      (WebCore::submitElementFromEvent):
      * html/HTMLObjectElement.cpp:
      (WebCore::HTMLObjectElement::updateDocNamedItem):
      * html/HTMLPlugInImageElement.cpp:
      (WebCore::HTMLPlugInImageElement::updateSnapshotInfo):
      * html/HTMLViewSourceDocument.cpp:
      (WebCore::HTMLViewSourceDocument::addRange):
      * html/parser/HTMLTreeBuilder.cpp:
      (WebCore::closestFormAncestor):
      * html/shadow/MediaControlElementTypes.cpp:
      (WebCore::toParentMediaElement):
      * html/shadow/TextFieldDecorationElement.h:
      (WebCore::toTextFieldDecorationElement):
      * inspector/DOMPatchSupport.cpp:
      (WebCore::DOMPatchSupport::createDigest):
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::buildObjectForNode):
      (WebCore::InspectorDOMAgent::didInvalidateStyleAttr):
      * inspector/InspectorStyleSheet.cpp:
      (WebCore::InspectorStyleSheet::inlineStyleSheetText):
      * mathml/MathMLElement.h:
      (WebCore::toMathMLElement):
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::populate):
      * page/DragController.cpp:
      (WebCore::elementUnderMouse):
      (WebCore::DragController::startDrag):
      * page/FocusController.cpp:
      (WebCore::FocusController::advanceFocusInDocumentOrder):
      * page/Frame.cpp:
      (WebCore::Frame::searchForLabelsBeforeElement):
      * page/FrameView.cpp:
      (WebCore::FrameView::updateWidget):
      * page/SpatialNavigation.cpp:
      (WebCore::rectToAbsoluteCoordinates):
      * page/animation/ImplicitAnimation.cpp:
      (WebCore::ImplicitAnimation::sendTransitionEvent):
      * page/animation/KeyframeAnimation.cpp:
      (WebCore::KeyframeAnimation::KeyframeAnimation):
      (WebCore::KeyframeAnimation::sendAnimationEvent):
      * platform/efl/RenderThemeEfl.cpp:
      (WebCore::RenderThemeEfl::paintMediaFullscreenButton):
      (WebCore::RenderThemeEfl::paintMediaMuteButton):
      * rendering/FilterEffectRenderer.cpp:
      (WebCore::FilterEffectRenderer::buildReferenceFilter):
      * rendering/svg/RenderSVGViewportContainer.cpp:
      (WebCore::RenderSVGViewportContainer::calcViewport):
      * svg/SVGSVGElement.cpp:
      (WebCore::SVGSVGElement::getElementById):
      * svg/SVGUseElement.cpp:
      (WebCore::isDisallowedElement):
      * svg/animation/SVGSMILElement.cpp:
      (WebCore::SVGSMILElement::buildPendingResource):
      * xml/XPathStep.cpp:
      (WebCore::XPath::nodeMatchesBasicTest):
      * xml/parser/XMLDocumentParserQt.cpp:
      (WebCore::XMLDocumentParser::XMLDocumentParser):
      (WebCore::XMLDocumentParser::parseEndElement):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::webContext):
      (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
      (BlackBerry::WebKit::WebPage::setNodeFocus):
      (BlackBerry::WebKit::WebPagePrivate::adjustFullScreenElementDimensionsIfNeeded):
      * WebCoreSupport/EditorClientBlackBerry.cpp:
      (WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
      (WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
      * WebKitSupport/BackingStoreClient.cpp:
      (BlackBerry::WebKit::BackingStoreClient::absoluteRect):
      * WebKitSupport/DOMSupport.cpp:
      (BlackBerry::WebKit::DOMSupport::toTextControlElement):
      (BlackBerry::WebKit::DOMSupport::selectionContainerElement):
      * WebKitSupport/FatFingers.cpp:
      (BlackBerry::WebKit::FatFingers::getRelevantInfoFromCachedHitTest):
      (BlackBerry::WebKit::FatFingers::setSuccessfulFatFingersResult):
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::focusedNodeChanged):
      (BlackBerry::WebKit::InputHandler::willOpenPopupForNode):
      * WebKitSupport/SelectionHandler.cpp:
      (BlackBerry::WebKit::SelectionHandler::inputNodeOverridesTouch):
      * WebKitSupport/TouchEventHandler.cpp:
      (BlackBerry::WebKit::elementForTapHighlight):
      
      Source/WebKit/chromium:
      
      * src/WebDocument.cpp:
      (WebKit::WebDocument::images):
      * src/WebElement.cpp:
      (WebKit::WebElement::operator PassRefPtr<Element>):
      * src/WebPageSerializer.cpp:
      (WebCore::retrieveResourcesForFrame):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::setFocus):
      (WebKit::WebViewImpl::clearFocusedNode):
      (WebKit::WebViewImpl::scrollFocusedNodeIntoView):
      (WebKit::WebViewImpl::scrollFocusedNodeIntoRect):
      
      Source/WebKit/gtk:
      
      * webkit/webkitwebview.cpp:
      (webkit_web_view_query_tooltip):
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (applyAppleDictionaryApplicationQuirkNonInlinePart):
      * WebView/WebHTMLRepresentation.mm:
      (searchForLabelsBeforeElement):
      
      Source/WebKit/qt:
      
      * Api/qwebelement.cpp:
      (QWebElement::firstChild):
      (QWebElement::lastChild):
      (QWebElement::nextSibling):
      (QWebElement::previousSibling):
      (QWebElementCollection::at):
      (QWebElementCollection::toList):
      * WebCoreSupport/QWebFrameAdapter.cpp:
      (QWebHitTestResultPrivate::elementForInnerNode):
      
      Source/WebKit/win:
      
      * WebView.cpp:
      (WebView::enterFullscreenForNode):
      
      Source/WebKit2:
      
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      (WebKit::InjectedBundleNodeHandle::elementBounds):
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::containsAnyFormElements):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9aa9e8d7