GitLab

        https://bugs.webkit.org/show_bug.cgi?id=31672



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/qt/Skipped:
- editing/selection/mixed-editability-10.html added.
- editing/selection/5825350-1.html added.
- editing/selection/5825350-2.html added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Dan Bernstein.

        css2.1/t1205-c566-list-stl-00-e-ag.html is failing
        https://bugs.webkit.org/show_bug.cgi?id=23264
        css2.1/t1205-c565-list-pos-00-b.html is failing
        https://bugs.webkit.org/show_bug.cgi?id=23263

        Ignore whitespaces after list markers.
        Rendering of this was already done for the case where inside=false.
        This fixes the rendering of inside=true case and calcInlinePrefWidths.

        Test: fast/lists/calc-width-with-space.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::calcInlinePrefWidths):
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::findNextLineBreak):
2009-11-30  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Dan Bernstein.

        css2.1/t1205-c566-list-stl-00-e-ag.html is failing
        https://bugs.webkit.org/show_bug.cgi?id=23264

        * editing/pasteboard/copy-crash-expected.txt:
        * fast/lists/calc-width-with-space-expected.txt: Added.
        * fast/lists/calc-width-with-space.html: Added.
        * platform/mac/css2.1/t1205-c561-list-displ-00-b-expected.checksum:
        * platform/mac/css2.1/t1205-c561-list-displ-00-b-expected.png:
        * platform/mac/css2.1/t1205-c561-list-displ-00-b-expected.txt:
        * platform/mac/css2.1/t1205-c565-list-pos-00-b-expected.checksum:
        * platform/mac/css2.1/t1205-c565-list-pos-00-b-expected.png:
        * platform/mac/css2.1/t1205-c565-list-pos-00-b-expected.txt:
        * platform/mac/css2.1/t1205-c566-list-stl-00-e-ag-expected.checksum:
        * platform/mac/css2.1/t1205-c566-list-stl-00-e-ag-expected.png:
        * platform/mac/css2.1/t1205-c566-list-stl-00-e-ag-expected.txt:
        * platform/mac/fast/block/positioning/complex-percentage-height-expected.checksum:
        * platform/mac/fast/block/positioning/complex-percentage-height-expected.png:
        * platform/mac/fast/block/positioning/complex-percentage-height-expected.txt:
        * platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.checksum:
        * platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.png:
        * platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.txt:
        * platform/mac/fast/repaint/list-marker-expected.checksum:
        * platform/mac/fast/repaint/list-marker-expected.png:
        * platform/mac/fast/repaint/list-marker-expected.txt:
        * platform/qt/Skipped:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore: Can focus but not type into content editable block that contains only non-editable content.
<rdar://problem/5982901>
https://bugs.webkit.org/show_bug.cgi?id=31750
        
Reviewed by Darin Adler.

The goal is to change the way we choose a visible position
after hit detection, by preferring a visually equivalent editable
position if available. By doing this, it is possible to add content
to an editable block that initially contains only non editable elements.

Test: editing/selection/mixed-editability-10.html

* WebCore.base.exp: Changed to match the new signature of downstream
and upstream in the Position class.
* dom/Position.cpp:
(WebCore::Position::atEditingBoundary): Added.
(WebCore::Position::upstream): Modified to allow to cross the boundary
between editable and non editable content if required.
(WebCore::Position::downstream): Modified to allow to cross the boundary
between editable and non editable content if required.
(WebCore::Position::isCandidate): Modified to qualify as candidates positions
that are at the editability boundary.
(WebCore::Position::getInlineBoxAndOffset): Modified to retrieve the inline box
to be used in calculating the caret rectangle.
* dom/Position.h:
(WebCore::Position::):
* dom/PositionIterator.cpp:
(WebCore::PositionIterator::atEditingBoundary): Added.
(WebCore::PositionIterator::isCandidate): Modified to qualify as candidates positions
that are at the editability boundary.
* dom/PositionIterator.h:
* editing/htmlediting.cpp:
(WebCore::firstEditablePositionAfterPositionInRoot): Modified to accept not only
descendants of the editable container, but the container itself.
(WebCore::lastEditablePositionBeforePositionInRoot): Modified to accept not only
descendants of the editable container, but the container itself.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createVisiblePosition): Added logic to prefer an editable position,
if available.
* rendering/RenderText.cpp:
(WebCore::RenderText::isAllCollapsibleWhitespace): Added.
* rendering/RenderText.h:

LayoutTests: Can focus but not type into content editable block that contains only non-editable content.
<rdar://problem/5982901>
https://bugs.webkit.org/show_bug.cgi?id=31750

Reviewed by Darin Adler.

* editing/selection/5825350-1-expected.txt:
* editing/selection/5825350-1.html: Modified to use caret rectangle.
* editing/selection/5825350-2-expected.txt:
* editing/selection/5825350-2.html: Modified to use caret rectangle.
* editing/selection/mixed-editability-10-expected.txt: Added.
* editing/selection/mixed-editability-10.html: Added.
* platform/mac/editing/deleting/5390681-2-expected.txt: Re-baselined
to account for the new possible caret position.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Safari caused by extreme column-gap and column-width values 
-and corresponding-
<rdar://problem/7425433>

Reviewed by Oliver Hunt.

Prevent desiredColumnCount from being less than 1 since it is used 
as a divisor.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::calcColumnWidth):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=32000 Crash in 
Safari caused by extreme column-gap and column-width values 
-and corresponding-
<rdar://problem/7425433>

Reviewed by Oliver Hunt.

* fast/multicol/huge-column-gap-crash-expected.txt: Added.
* fast/multicol/huge-column-gap-crash.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        https://bugs.webkit.org/show_bug.cgi?id=31659
        Connection must be closed in case of Web Socket handshake error

        The network connection was closed, but the close event wasn't dispatched.

        Tested by websocket/tests/handshake-error.html, which is un-skipped now.

        * platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::platformClose):
        Call client didHandle() method. This looks strange in CFNetwork implementation, because
        it's the client that asked to close the stream, so it shouldn't need the callback. It makes
        more sense in cross-process implementation, because closing is async there.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Simon Fraser.

        All HTML5 media element events should be regular events
        https://bugs.webkit.org/show_bug.cgi?id=30513

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::selectMediaResource):
        (WebCore::HTMLMediaElement::noneSupported):
        (WebCore::HTMLMediaElement::mediaEngineError):
        (WebCore::HTMLMediaElement::setNetworkState):
        (WebCore::HTMLMediaElement::userCancelledLoad):
            Call scheduleEvent instead of scheduleProgressEvent.
        (WebCore::HTMLMediaElement::progressEventTimerFired):
            Call scheduleEvent instead of scheduleProgressEvent. Call renderer->updateFromElement
            after scheduling a 'progress' event so the controller will update download
            progress indicator.
        * html/HTMLMediaElement.h:
            Remove scheduleProgressEvent prototype.

2009-11-30  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        All HTML5 media element events should be regular events
        https://bugs.webkit.org/show_bug.cgi?id=30513
        
        Remove progress event tests.

        * media/progress-event-at-least-one-expected.txt: Removed.
        * media/progress-event-at-least-one.html: Removed.
        * media/progress-event-expected.txt: Removed.
        * media/progress-event-total-expected.txt: Removed.
        * media/progress-event-total.html: Removed.
        * media/progress-event.html: Removed.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

It was me who reviewed the patch, not Eric! Alas, some tools we use cause wrong reviewer information in Bugzilla.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        In testing handshake-error case, web_socket_do_extra_handshake calls a non-existent method
        https://bugs.webkit.org/show_bug.cgi?id=31465

        * platform/mac/Skipped: websocket/tests/handshake-error.html now fails on Mac, added to
        Skipped list, and filed bug 31659 to investigate.

        * websocket/tests/handshake-error_wsh.py: Call write() on a correct object.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Pavel Feldman.

        Web Inspector: Wrong console output for Regexp escape sequence
        https://bugs.webkit.org/show_bug.cgi?id=31538

        Updated inspector/console-format.html

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.createDividerElement): style issues.
        (WebInspector.ConsoleView.createFilterElement): style issues.
        (WebInspector.ConsoleView): added _customFormatters table.
        (WebInspector.ConsoleView.prototype.updateMessageRepeatCount): style isses.
        (WebInspector.ConsoleView.prototype._incrementErrorWarningCount): style issues.
        (WebInspector.ConsoleView.prototype._format): simplified delegation to formatter logic.
        (WebInspector.ConsoleView.prototype._formatobject):
        (WebInspector.ConsoleView.prototype._formatnode):
        (WebInspector.ConsoleView.prototype._printArray):
        (WebInspector.ConsoleMessage.prototype._format): commented and broke down the algorithm into parts.
        (WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString.append): handle substitution string formatting.
        (WebInspector.ConsoleMessage.prototype._formatIndividualValue): handling individual value formatting.
        (WebInspector.ConsoleCommandResult):
        * inspector/front-end/InjectedScript.js: simplified regex formatting.
        * inspector/front-end/inspector.js:
        (WebInspector.linkifyStringAsFragment): converted new RegExp to literal for performance benefits.
        * inspector/front-end/utilities.js:
        (Element.prototype.hasStyleClass): update inaccurate comment.
        (String.prototype.trimURL): converted new RegExp to literal for performance benefits.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

requiring new results.

* platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Nikolas Zimmermann.

        Complex test of mask with every combination of maskUnits and maskContentUnits
        as well as different values for size and position of the mask and it's content.

        * platform/mac/svg/custom/mask-with-all-units-expected.checksum: Added.
        * platform/mac/svg/custom/mask-with-all-units-expected.png: Added.
        * platform/mac/svg/custom/mask-with-all-units-expected.txt: Added.
        * svg/custom/mask-with-all-units.svg: Added.
2009-11-30  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        REGRESSION (r49757): masking-mask-01-b.svg rendered incorrectly
        [https://bugs.webkit.org/show_bug.cgi?id=31980]

        It turns out, that we did not handle maskUnits="userSpaceOnUse"
        correctly. We just need to move the context of the maskImage
        if maskContentUnits="objectBoundingBox". The context gets scaled
        on this unit combination, so we have to substract the position of
        the targetRect. On userSpaceOnUse the position just depends on the
        position of the mask element.
        I added a test with some senseless and reasonable values for size
        and postion of the mask and it's contents. I also used every
        combination of maskUnits and maskContentUnits to be sure, that it
        is fixed this time.

        Test: svg/custom/mask-with-all-units.svg

        * svg/SVGMaskElement.cpp:
        (WebCore::SVGMaskElement::drawMaskerContent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/qt/Skipped:
- fast/dom/Window/window-postmessage-clone.html added
- inspector/elements-img-tooltip.html added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=31955

Reviewed by Sam Weinig.

Update SerializedScriptValue to include support for
File objects in the serialized object graph.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Rubber-stamped by Eric Seidel.

        Fix up some compositing layout tests.

        * compositing/layers-inside-overflow-scroll.html:
        * compositing/self-painting-layers.html:
        Use the 'loadeddata' event, instead of 'load', to know when the video loads.

        * platform/mac/compositing/repaint/content-into-overflow-expected.checksum:
        * platform/mac/compositing/repaint/content-into-overflow-expected.png:
        * platform/mac/compositing/repaint/overflow-into-content-expected.checksum:
        * platform/mac/compositing/repaint/overflow-into-content-expected.png:
        * platform/mac/compositing/self-painting-layers-expected.checksum:
        * platform/mac/compositing/self-painting-layers-expected.png:
        Update with correct pixel results.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        Test using Id as index of node list.
        https://bugs.webkit.org/show_bug.cgi?id=31428

        * fast/dom/Element/id-in-node-list-index01-expected.txt: Added.
        * fast/dom/Element/id-in-node-list-index01.html: Added.
2009-11-29  Shu Chang  <Chang.Shu@nokia.com>

        Reviewed by Eric Seidel.

        Continue to search for matching node in the case where multiple nodes
        have the same id.
        https://bugs.webkit.org/show_bug.cgi?id=31428

        Test: fast/dom/Element/id-in-node-list-index01.html

        * dom/DynamicNodeList.cpp:
        (WebCore::DynamicNodeList::itemWithName):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Dimitri Glazkov.

        [Chromium] Sify compose button alerts error
        https://bugs.webkit.org/show_bug.cgi?id=31394

        Test: http/tests/security/calling-versus-current.html

        We're supposed to use the calling context for security checks.  In JSC
        land, this is the lexicalGlobalObject.

        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::canAccessPrivate):
2009-11-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] Sify compose button alerts error
        https://bugs.webkit.org/show_bug.cgi?id=31394

        Test that we're using the calling security context in a simple case.

        * http/tests/security/calling-versus-current-expected.txt: Added.
        * http/tests/security/calling-versus-current.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=31940

        Makes the error messages more descriptive when we refuse to load an object/embed or
        refuse to load from the document base URL.

        * page/XSSAuditor.cpp:
        (WebCore::XSSAuditor::canLoadObject): Changed console message to be more descriptive.
        (WebCore::XSSAuditor::canSetBaseElementURL): Ditto.
2009-11-27  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=31940

        Rebased results because of new error messages.

        * http/tests/security/xssAuditor/base-href-control-char-expected.txt:
        * http/tests/security/xssAuditor/base-href-expected.txt:
        * http/tests/security/xssAuditor/base-href-null-char-expected.txt:
        * http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt:
        * http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
        * http/tests/security/xssAuditor/embed-tag-expected.txt:
        * http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt:
        * http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
        * http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
        * http/tests/security/xssAuditor/object-embed-tag-expected.txt:
        * http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
        * http/tests/security/xssAuditor/object-src-inject-expected.txt:
        * http/tests/security/xssAuditor/object-tag-expected.txt:
        * http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        REGRESSION(51418): fast/canvas/webgl/gl-object-get-calls.html is failing on the Leopard commit bot
        https://bugs.webkit.org/show_bug.cgi?id=31919

        Temporarily disabled portion of test which is failing on some
        machines but not others. Root cause will be investigated under
        https://bugs.webkit.org/show_bug.cgi?id=31843 .

        * fast/canvas/webgl/gl-object-get-calls-expected.txt:
        * fast/canvas/webgl/script-tests/gl-object-get-calls.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Unreviewed red bot fix.

        Skip tests introduced by the previous change as it seems to be failing.

        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Dan Bernstein.

        Assertion failure in RenderBlock::positionForPointWithInlineChildren when running fast/inline/relative-positioned-overflow.html
        https://bugs.webkit.org/show_bug.cgi?id=29966

        A test case where a user drags the mouse from an empty inline
        element to above texts.

        * editing/selection/last-empty-inline-expected.txt: Added.
        * editing/selection/last-empty-inline.html: Added.
        * platform/win/Skipped:
2009-11-26  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Dan Bernstein.

        Assertion failure in RenderBlock::positionForPointWithInlineChildren when running fast/inline/relative-positioned-overflow.html
        https://bugs.webkit.org/show_bug.cgi?id=29966

        When an empty inline element is clicked, the root inline box has
        no leaf children. Use the renderer of a normal child instead.

        This change resolves Windows port's assertion failure in a layout test.
        Also, this fixes the behavior when a user drags the mouse from an
        empty inline element to above texts.

        Test: editing/selection/last-empty-inline.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::positionForPointWithInlineChildren):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        Rewrite the test fast/parser/comment-in-textarea to use dumpAsText
        so that the expected results can be independent of platform differences.
        https://bugs.webkit.org/show_bug.cgi?id=31580

        * fast/parser/comment-in-textarea-expected.txt: Added.
        * fast/parser/comment-in-textarea.html:
        * fast/parser/script-tests/comment-in-textarea.js: Added.
        * platform/mac/fast/parser/comment-in-textarea-expected.checksum: Removed.
        * platform/mac/fast/parser/comment-in-textarea-expected.png: Removed.
        * platform/mac/fast/parser/comment-in-textarea-expected.txt: Removed.
        * platform/win/fast/parser/comment-in-textarea-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Pavel Feldman.

        https://bugs.webkit.org/show_bug.cgi?id=21554

        Tests that the tooltip text for an image is its dimensions.

        * inspector/elements-img-tooltip-expected.txt: Added.
        * inspector/elements-img-tooltip.html: Added.
2009-11-26  Daniel Bates  <dbates@webkit.org>

        Reviewed by Pavel Feldman.

        https://bugs.webkit.org/show_bug.cgi?id=21554

        Implements support for hovering over <img> src to display the height and width of that image
        in a tooltip. Displays both the displayable and natural dimensions of the image.

        Test: inspector/elements-img-tooltip.html

        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype.createTooltipForImageNode): Added.
        (WebInspector.ElementsTreeElement.prototype._updateTitle.callback):
        (WebInspector.ElementsTreeElement.prototype._updateTitle):
        (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
        * inspector/front-end/ObjectProxy.js:
        (WebInspector.ObjectProxy.getPropertiesAsync): Added.
        * inspector/front-end/inspector.js:
        (WebInspector.linkifyURLAsNode): Added tooltipText argument.
        (WebInspector.linkifyURL): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=31203

Change the RenderTreeAsText to look into the WebCore::Widget
and print the state of the platformWidget. Change the DRT to
use QtUiTools to be able to initiate QProgressBar and such
as a plugin. Add the test case, add the result, update the
other results due the new test.

WebCore:
* rendering/RenderTreeAsText.cpp:
(WebCore::operator<<): Add special case for RenderPart

WebKitTools:
* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::WebPage::createPlugin):
* DumpRenderTree/qt/DumpRenderTree.h:
* DumpRenderTree/qt/DumpRenderTree.pro:

LayoutTest:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/plugins/netscape-dom-access-expected.txt: Added
* platform/qt/plugins/qt-qwidget-plugin-expected.txt: Added
* platform/win/Skipped:
* plugins/qt-qwidget-plugin.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=27910

* platform/qt/Skipped: fast/js/global-constructors.html added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Oliver Hunt.

        Off-by-one error in index validation for drawElements and drawArrays
        https://bugs.webkit.org/show_bug.cgi?id=31891

        Fixed computation of number of elements for bound array objects.

        Test: fast/canvas/webgl/index-validation.html

        * fast/canvas/webgl/index-validation-expected.txt: Added.
        * fast/canvas/webgl/index-validation.html: Added.
        * fast/canvas/webgl/script-tests/index-validation.js: Added.
2009-11-25  Kenneth Russell  <kbr@google.com>

        Reviewed by Oliver Hunt.

        Off-by-one error in index validation for drawElements and drawArrays
        https://bugs.webkit.org/show_bug.cgi?id=31891

        Fixed computation of number of elements for bound array objects.

        Test: fast/canvas/webgl/index-validation.html

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::vertexAttribPointer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

And add a crasher/crashed pair into skiplist.

* platform/qt/Skipped:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/qt/Skipped:
- http/tests/cache/subresource-failover-to-network.html added.
- fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html added.

- "3D_RENDERING and ACCELERATED_COMPOSITING" block moved to good place.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Simon Fraser.

        <rdar://problem/7409331> Windows: Support closed caption in <video> element

        Enable closed captions in QuickTime/Windows media engine.

        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
        (WebCore::MediaPlayerPrivate::hasClosedCaptions):
        (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible):
            New, all through to m_qtMovie.

        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
            Make all but the destructor private since MediaPlayer call through the media
            engine interface.

        * platform/graphics/win/QTMovieWin.cpp:
        (QTMovieWin::disableUnsupportedTracks):
            Use handy new constants for QuickTime track types.
        (QTMovieWin::hasClosedCaptions):
        (QTMovieWin::setClosedCaptionsVisible):
            New, closed caption support.
        * platform/graphics/win/QTMovieWin.h:

        * rendering/RenderMediaControls.cpp:
        (WebCore::RenderMediaControls::paintMediaControlsPart):
            Deal with closed caption buttons.

        * rendering/RenderThemeWin.cpp:
        (WebCore::RenderThemeWin::shouldRenderMediaControlPart):
            New, don't ask the media engine if it has closed captions unless the Safari theme will
            be able to render the button.
        (WebCore::RenderThemeWin::paintMediaToggleClosedCaptionsButton):
            New.
        * rendering/RenderThemeWin.h:

2009-11-25  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/7409331> Windows: Support closed caption in <video> element

        * platform/win/Skipped:
            Enable the closed caption test.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=31785

Patch by Jakub Wieczorek <faw217@gmail.com> on 2009-11-22
Reviewed by Adam Barth.

This makes Qt pass two tests introduced in r50226.

WebCore:

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

LayoutTests:

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=27314

Initial implementation, but disabled in this checkin.
To enable ENABLE_3D_RENDERING and USE_ACCELERATED_COMPOSITING
must be turned on. Also d3d9.lib and d3d9x.lib must be added
to the build.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        https://bugs.webkit.org/show_bug.cgi?id=31808



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Adam Barth.

        [Chromium] Renderer hang when using www.expedia.com
        https://bugs.webkit.org/show_bug.cgi?id=31822

        Test: http/tests/cache/subresource-failover-to-network.html

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadResourceSynchronously): Use the originalRequest
        when inheriting cache policy.  This matches SubresourceLoader::create.

2009-11-24  Darin Fisher  <darin@chromium.org>

        Reviewed by Adam Barth.

        [Chromium] Renderer hang when using www.expedia.com
        https://bugs.webkit.org/show_bug.cgi?id=31822

        This test verifies that a synchronous XMLHttpRequest, generated from a
        page that is the result of a form submission, loads properly when the
        user navigates back to the page.

        When navigating back to a page that resulted from a form submission,
        the page is loaded with the ReturnCacheDataDontLoad cache policy.  It
        is important that subresources (including XMLHttpRequest instances) do
        not inherit this cache policy.

        * http/tests/cache/resources/echo-no-store.cgi: Added.
        * http/tests/cache/resources/subresource-failover-to-network.cgi: Added.
        * http/tests/cache/subresource-failover-to-network-expected.txt: Added.
        * http/tests/cache/subresource-failover-to-network.html: Added.

2009-11-24  Darin Fisher  <darin@chromium.org>

        Reviewed by Adam Barth.

        [Chromium] Renderer hang when using www.expedia.com
        https://bugs.webkit.org/show_bug.cgi?id=31822

        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::dispatchWillSendRequest):
        Assign ReturnCacheDataDontLoad cache policy at the last moment
        to match Safari.  This way the cache policy does not get stored
        in DocumentLoader's originalRequest preventing it from being
        inherited by subresource requests.
        * src/ResourceHandle.cpp:
        (WebCore::ResourceHandle::willLoadFromCache): Remove assignment
        of ReturnCacheDataDontLoad cache policy so that it doesn't end
        up applying to the DocumentLoader's originalRequest.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        https://bugs.webkit.org/show_bug.cgi?id=30091

        Removed old versions of get calls on WebGLRenderingContext and
        added new ones per spec returning "any". New code simplifies
        GraphicsContext3D and fixes previously unimplemented routines.
        Added custom JS and V8 bindings. Added exhaustive test case
        exercising all new code paths. Updated preexisting test cases for
        new APIs. Fixed preexisting bugs in WebKit's and Chrome's WebGL
        implementations.

        Ran WebGL layout tests in WebKit (clean) and Chrome (couple of
        preexisting known failures) and manual WebGL tests in both
        browsers.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=31816

Reviewed by Eric Seidel.

* fast/table/row-height-recalc2-expected.txt: Added.
* fast/table/row-height-recalc2.html:
* platform/mac/fast/table/row-height-recalc2-expected.checksum: Removed.
* platform/mac/fast/table/row-height-recalc2-expected.png: Removed.
* platform/mac/fast/table/row-height-recalc2-expected.txt: Removed.
* platform/qt/fast/table/row-height-recalc2-expected.checksum: Removed.
* platform/qt/fast/table/row-height-recalc2-expected.png: Removed.
* platform/qt/fast/table/row-height-recalc2-expected.txt: Removed.
* platform/win/fast/table/row-height-recalc2-expected.checksum: Removed.
* platform/win/fast/table/row-height-recalc2-expected.png: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        https://bugs.webkit.org/show_bug.cgi?id=31239

        I am now tracking the size of the data in each CanvasBuffer object
        and keeping track of the buffer size of each active vertex attrib.
        In drawArrays and drawElements I make sure no attempt is made to
        access elements outside the valid buffer ranges. The test at:

            http://cs.helsinki.fi/u/ilmarihe/c3d/functions/drawArraysOutOfBounds.html

        no longer crashes.

        I also added all the WebGL enumerations to GraphicsContext3D to use them in the validation checks



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        JSC bindings for HasIndexGetter generates incorrect code (affects
        MediaList and CSSStyleDeclaration).
        This cleans up the edge cases for indexing out of range for style and
        computed style objects to return an empty string according to the spec.
        MediaList now returns null when indexed out of range.
        https://bugs.webkit.org/show_bug.cgi?id=31683

        * fast/dom/CSSStyleDeclaration/css-computed-style-item-expected.txt: Added.
        * fast/dom/CSSStyleDeclaration/css-computed-style-item.html: Added.
        * fast/dom/CSSStyleDeclaration/css-style-item-expected.txt: Added.
        * fast/dom/CSSStyleDeclaration/css-style-item.html: Added.
        * fast/dom/CSSStyleDeclaration/script-tests/css-computed-style-item.js: Added.
        * fast/dom/CSSStyleDeclaration/script-tests/css-style-item.js: Added.
        * fast/dom/StyleSheet/css-medialist-item-expected.txt: Added.
        * fast/dom/StyleSheet/css-medialist-item.html: Added.
        * fast/dom/StyleSheet/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/backgrounds/repeat/script-tests/TEMPLATE.html.
        * fast/dom/StyleSheet/script-tests/css-medialist-item.js: Added.
2009-11-23  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Eric Seidel.

        JSC bindings for HasIndexGetter generates incorrect code (affects
        MediaList and CSSStyleDeclaration).
        This cleans up the edge cases for indexing out of range for style and
        computed style objects to return an empty string according to the spec.
        MediaList now returns null when indexed out of range.
        https://bugs.webkit.org/show_bug.cgi?id=31683

        Tests: fast/dom/CSSStyleDeclaration/css-computed-style-item.html
               fast/dom/CSSStyleDeclaration/css-style-item.html
               fast/dom/StyleSheet/css-medialist-item.html

        * bindings/scripts/CodeGeneratorJS.pm: If IndexGetterReturnsString then
                we do not check the length before calling the item function.
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::item):
        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::item):
        * css/CSSStyleDeclaration.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/qt/Skipped: Added editing/selection/trransformed-selection-rects.html



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Dan Bernstein.

        DocumentMarkers need to be educated about transforms
        https://bugs.webkit.org/show_bug.cgi?id=31751

        Find highlight is incorrect with transforms
        <rdar://problem/6358394>

        Allow callers to specify that Frame::selectionTextRects() takes transforms into account
        when computing the set of rects that encompass a selection. For transformed elemenets, the
        selection rect will be the bounding box of the selected content.

        Fix DocumentMarkers to cache rects in absolute coordinates, rather than painting coordinates.

        Test: editing/selection/transformed-selection-rects.html

        * WebCore.base.exp:
        Frame::selectionTextRects() has a new parameter.

        * dom/Document.cpp:
        (WebCore::Document::setRenderedRectForMarker):
        * dom/Document.h:
        Pass the marker as a const reference.

        * dom/Range.h:
        * dom/Range.cpp:
        (WebCore::Range::textQuads):
        Add a new method, textQuads(), which returns a list of quads, respecting transforms.

        * page/Frame.h:
        * page/Frame.cpp:
        (WebCore::Frame::selectionTextRects):
        Add a new parameter, respectTransforms, and when that is RespectTransforms, use the quad
        method to get quads for ranges, and then take their bounding boxes.

        * rendering/InlineTextBox.h:
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
        (WebCore::InlineTextBox::paintTextMatchMarker):
        (WebCore::InlineTextBox::computeRectForReplacementMarker):
        (WebCore::InlineTextBox::paintDocumentMarkers):
        (WebCore::InlineTextBox::textPos):
        (WebCore::InlineTextBox::offsetForPosition):

        Pass DocumentMarkers as a const references.
        Convert the argument to setRenderedRectForMarker() into absolute coordinates.

        * rendering/RenderView.cpp:
        (WebCore::RenderView::selectionBounds):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51324 268f45cc-cd09-0410-ab3c-d52691b4dbfc