Skip to content

GitLab

Switch branch/tag
  1. 27 Aug, 2013 10 commits
    • akling@apple.com's avatar
      Document's renderer is always a RenderView. · fa64c887
      akling@apple.com authored 
      <https://webkit.org/b/120304>

Reviewed by Darin Adler.

Let's enforce this better by storing a RenderView* instead of a plain RenderObject*.
We should switch callers that grab at Document::renderer() to calling renderView()
instead, but that's better done separately.

* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::setRenderView):
(WebCore::Document::createRenderTree):
(WebCore::Document::detach):
(WebCore::Document::setInPageCache):
* dom/Document.h:
(WebCore::Document::renderView):
(WebCore::Document::renderer):
* html/parser/HTMLResourcePreloader.cpp:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::setStyle):
* rendering/RenderView.h:
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::updateCurrentTranslate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa64c887
    • g.czajkowski@samsung.com's avatar
      grammar-markers.html and grammar-markers-hidpi.html pass even if element does... · d2a110f7
      g.czajkowski@samsung.com authored 
      grammar-markers.html and grammar-markers-hidpi.html pass even if element does not have grammar marker
https://bugs.webkit.org/show_bug.cgi?id=119797

Reviewed by Ryosuke Niwa.

After tenth attempts of verifying the grammar marker, the tests call'notifyDone'
even if grammar marker was not be found.

Both grammar-marker.html and grammar-marker-hidpi.html call the text checker
asynchronously. Therefore, we need to wait until either the grammar marker
is found or number of attempts is reached.

Dump more information whether the grammar marker was found to be sure that
the tests do not pass when the element does not have the marker.

* editing/spelling/grammar-markers-expected.txt:
* editing/spelling/grammar-markers-hidpi-expected.txt:
Update the expectations.

* editing/spelling/grammar-markers-hidpi.html:
* editing/spelling/grammar-markers.html:
Dump more information.
Additionally, pass 'document' to hasGrammarMarker instead of
'target' as the method does not work for target/source elements.

* platform/mac/editing/spelling/grammar-markers-expected.png:
* platform/mac/editing/spelling/grammar-markers-hidpi-expected.png: Added.
Update the expectations for Mac.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2a110f7
    • allan.jensen@digia.com's avatar
      Font's fast code path doesn't handle partial runs correctly when kerning or ligatures are enabled · 5fb0af8e
      allan.jensen@digia.com authored 
      https://bugs.webkit.org/show_bug.cgi?id=100050

Reviewed by Darin Adler.

Renamed m_characterIndex to m_characterIndexOfGlyph and gave it an inline size of 10,
which covers around 66% of all cases. The rest of the cases are now preallocated to the
upper limit which is length of the original TextRun.

* platform/graphics/FontFastPath.cpp:
(WebCore::Font::getGlyphsAndAdvancesForSimpleText):
(WebCore::Font::selectionRectForSimpleText):
(WebCore::Font::offsetForPositionForSimpleText):
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::WidthIterator):
(WebCore::WidthIterator::advanceInternal):
* platform/graphics/WidthIterator.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fb0af8e
    • ch.dumez@sisa.samsung.com's avatar
      Implement DOM3 wheel event · 181483e1
      ch.dumez@sisa.samsung.com authored 
      https://bugs.webkit.org/show_bug.cgi?id=94081

Reviewed by Darin Adler.

Source/WebCore:

Add support for DOM Level 3 WheelEvent:
http://www.w3.org/TR/DOM-Level-3-Events/#events-WheelEvent

Firefox, IE10 and since recently Blink already support it so
it increases our cross-browser compatibility.

The non-standard 'mousewheel' event is still supported for backward
compatibility. Note that the deltas returned by the mousewheel and
the wheel events are not identical:
- They have opposite signs.
- The wheel event reports the actual amount of pixels that should be
scrolled while the legacy mousewheel event reports a factor of the
number of mouse wheel ticks (using a constant multiplier).

Tests: fast/events/wheelevent-basic.html
       fast/events/wheelevent-constructor.html
       fast/events/wheelevent-mousewheel-interaction.html

* dom/Document.h:
* dom/Document.idl:
* dom/Element.h:
* dom/Element.idl:
* dom/EventNames.h:
* dom/EventTarget.cpp:
(WebCore::legacyType):
(WebCore::EventTarget::shouldObserveLegacyType):
(WebCore::EventTarget::setupLegacyTypeObserverIfNeeded):
(WebCore::EventTarget::fireEventListeners):
* dom/EventTarget.h:
* dom/Node.cpp:
(WebCore::Node::didMoveToNewDocument):
(WebCore::tryAddEventListener):
(WebCore::tryRemoveEventListener):
(WebCore::Node::defaultEventHandler):
* dom/WheelEvent.cpp:
(WebCore::WheelEventInit::WheelEventInit):
(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):
* dom/WheelEvent.h:
(WebCore::WheelEvent::deltaX):
(WebCore::WheelEvent::deltaY):
(WebCore::WheelEvent::deltaZ):
(WebCore::WheelEvent::wheelDelta):
(WebCore::WheelEvent::wheelDeltaX):
(WebCore::WheelEvent::wheelDeltaY):
* dom/WheelEvent.idl:
* html/HTMLAttributeNames.in:
* html/HTMLElement.cpp:
(WebCore::HTMLElement::eventNameForAttributeName):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
* page/DOMWindow.h:
* page/DOMWindow.idl:
* page/EventHandler.cpp:
(WebCore::EventHandler::defaultWheelEventHandler):
* plugins/blackberry/PluginViewBlackBerry.cpp:
(WebCore::PluginView::handleWheelEvent):
* svg/SVGElementInstance.cpp:
* svg/SVGElementInstance.h:
* svg/SVGElementInstance.idl:

LayoutTests:

Add several layout tests to check support for DOM3 wheel event.

* fast/events/wheelevent-basic-expected.txt: Added.
* fast/events/wheelevent-basic.html: Added.
* fast/events/wheelevent-constructor-expected.txt: Added.
* fast/events/wheelevent-constructor.html: Added.
* fast/events/wheelevent-mousewheel-interaction-expected.txt: Added.
* fast/events/wheelevent-mousewheel-interaction.html: Added.
* platform/efl/fast/events/wheelevent-basic-expected.txt: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      181483e1
    • allan.jensen@digia.com's avatar
      Assertion while scrolling news.google.com · e57434c7
      allan.jensen@digia.com authored 
      https://bugs.webkit.org/show_bug.cgi?id=115303

Reviewed by Anders Carlsson.

Do not relayout when accessing script elements during painting.

* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::renderWidgetForJSBindings):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e57434c7
    • hausmann@webkit.org's avatar
      [Qt] Let Page create the main Frame. · 754dada6
      hausmann@webkit.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=120349

Adjust to latest changes in WebCore::Page to create the main frame.

Patch by Arunprasad Rajkumar <arurajku@cisco.com> on 2013-08-27
Reviewed by Simon Hausmann.

* WebCoreSupport/QWebFrameAdapter.cpp:
(QWebFrameData::QWebFrameData):
* WebCoreSupport/QWebPageAdapter.cpp:
(QWebPageAdapter::initializeWebCorePage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      754dada6
    • carlosgc@webkit.org's avatar
      Unreviewed. Fix GTK+ build after r154601. · b9bb159e
      carlosgc@webkit.org authored 
      * TestWebKitAPI/GNUmakefile.am: Remove mac specific file from
compilation added by mistake in r154601.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9bb159e
    • benjamin@webkit.org's avatar
      Remove DOMSettableTokenList's overload of add() and remove() · a52d31f9
      benjamin@webkit.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=120341

Reviewed by Ryosuke Niwa.

Little refactoring to make other cleanups easier. Instead of modifying
SpaceSplitString directly, rely on DOMTokenList ultimately changing
the value, which in turn updates the tokens.

* html/DOMSettableTokenList.cpp:
* html/DOMSettableTokenList.h:
* html/DOMTokenList.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a52d31f9
    • calvaris@igalia.com's avatar
      [GTK] Volume slider shows incorrect track when muted · d4c93624
      calvaris@igalia.com authored 
      https://bugs.webkit.org/show_bug.cgi?id=120253

Reviewed by Philippe Normand.

When painting the volume bar, consider that it could be muted even
then volume is different than zero.

* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::paintMediaVolumeSliderTrack): Asign
painted volume as 0 when media is muted.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4c93624
    • zandobersek@gmail.com's avatar
      Unreviewed GTK build fix. · 5fec8e3d
      zandobersek@gmail.com authored 
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::FrameLoaderClient): Remove an assertion that was not removed in r154658.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fec8e3d
  3. 26 Aug, 2013 30 commits