1. 18 Sep, 2009 14 commits
    • darin@apple.com's avatar
      Fix date on a change log entry. · f93e081e
      darin@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48514 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f93e081e
    • darin@apple.com's avatar
      Each wrapped Objective-C object should use a single RuntimeObjectImp · f55539ca
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=29351
      rdar://problem/7142294
      
      Patch by Darin Adler <darin@apple.com> on 2009-09-18
      Reviewed by Sam Weinig.
      
      * WebCore.base.exp: Added a newly-needed exported symbol.
      
      * bindings/objc/DOMInternal.h: Eliminated unused
      createWrapperCacheWithIntegerKeys; it has not been needed since the
      RGBColor wrappers were reworked.
      * bindings/objc/DOMInternal.mm: Ditto.
      
      * bridge/objc/objc_instance.h: Made the create function non-inline.
      * bridge/objc/objc_instance.mm:
      (createInstanceWrapperCache): Added. Creates an appropriate map table.
      (ObjcInstance::create): Moved here from header. Uses NSMapGet and
      NSMapInsert to cache the instance in a map table.
      (ObjcInstance::~ObjcInstance): Added a call to NSMapRemove to remove
      the instance from the map table.
      
      * bridge/qt/qt_instance.cpp:
      (JSC::Bindings::QtInstance::~QtInstance): Remove unneeded code to remove
      the instance from cachedObjects, which no longer exists.
      (JSC::Bindings::QtInstance::newRuntimeObject): Renamed to overload new
      bottleneck. Caching is now handled by the base class.
      
      * bridge/runtime.cpp:
      (JSC::Bindings::Instance::Instance): Initialize m_runtimeObject to 0.
      (JSC::Bindings::Instance::~Instance): Assert m_runtimeObject is 0.
      (JSC::Bindings::Instance::createRuntimeObject): Use m_runtimeObject
      if it's already set. Set m_runtimeObject and call addRuntimeObject
      if it's not.
      (JSC::Bindings::Instance::newRuntimeObject): Added. Virtual function,
      used only by createRuntimeObject.
      (JSC::Bindings::Instance::willDestroyRuntimeObject): Added.
      Calls removeRuntimeObject and then clears m_runtimeObject.
      (JSC::Bindings::Instance::willInvalidateRuntimeObject): Added.
      Clears m_runtimeObject.
      
      * bridge/runtime.h: Made createRuntimeObject non-virtual. Added
      willDestroyRuntimeObject, willInvalidateRuntimeObject,
      newRuntimeObject, and m_runtimeObject.
      
      * bridge/runtime_object.cpp:
      (JSC::RuntimeObjectImp::RuntimeObjectImp): Removed addRuntimeObject
      call, now handled by caller.
      (JSC::RuntimeObjectImp::~RuntimeObjectImp): Replaced removeRuntimeObject
      call with willDestroyRuntimeObject call; the latter nows calls
      removeRuntimeObject.
      (JSC::RuntimeObjectImp::invalidate): Added willInvalidateRuntimeObject
      call.
      
      * bridge/runtime_object.h: Made invalidate non-virtual.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f55539ca
    • kenneth@webkit.org's avatar
      [Gtk] Unreviewed build fix. · 44dbecd6
      kenneth@webkit.org authored
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-18
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::platformPageClient):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44dbecd6
    • kenneth@webkit.org's avatar
      Make PlatformWindow return something else than PlatformWidget · e8249bf2
      kenneth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=29085
      
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-17
      Reviewed by Simon Hausmann.
      
      WebCore:
      
      Make platformWindow return a PlatformPageClient
      (for now typedef'ed to PlatformWidget)
      
      Also, change the name of platformWindow to platformPageClient()
      
      * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
      (getPangoLayoutForAtk):
      * accessibility/win/AXObjectCacheWin.cpp:
      (WebCore::AXObjectCache::postPlatformNotification):
      (WebCore::AXObjectCache::handleFocusedUIElementChanged):
      * loader/EmptyClients.h:
      (WebCore::EmptyChromeClient::platformPageClient):
      * page/Chrome.cpp:
      (WebCore::Chrome::platformPageClient):
      * page/Chrome.h:
      * page/ChromeClient.h:
      * page/mac/EventHandlerMac.mm:
      (WebCore::EventHandler::wheelEvent):
      (WebCore::EventHandler::currentPlatformMouseEvent):
      (WebCore::EventHandler::sendContextMenuEvent):
      (WebCore::EventHandler::eventMayStartDrag):
      * platform/HostWindow.h:
      * platform/Widget.h:
      * platform/gtk/PlatformScreenGtk.cpp:
      (WebCore::getVisual):
      (WebCore::screenRect):
      (WebCore::screenAvailableRect):
      * platform/gtk/PopupMenuGtk.cpp:
      (WebCore::PopupMenu::show):
      * platform/gtk/ScrollViewGtk.cpp:
      (WebCore::ScrollView::platformAddChild):
      (WebCore::ScrollView::platformRemoveChild):
      (WebCore::ScrollView::visibleContentRect):
      * platform/gtk/WidgetGtk.cpp:
      (WebCore::Widget::setFocus):
      (WebCore::Widget::setCursor):
      * platform/qt/PlatformScreenQt.cpp:
      (WebCore::screenDepth):
      (WebCore::screenDepthPerComponent):
      (WebCore::screenIsMonochrome):
      (WebCore::screenRect):
      (WebCore::screenAvailableRect):
      * platform/qt/PopupMenuQt.cpp:
      (WebCore::PopupMenu::show):
      * platform/qt/WidgetQt.cpp:
      (WebCore::Widget::setCursor):
      * platform/win/PlatformScreenWin.cpp:
      (WebCore::monitorInfoForWidget):
      * platform/win/PopupMenuWin.cpp:
      (WebCore::PopupMenu::show):
      (WebCore::PopupMenu::calculatePositionAndSize):
      (WebCore::PopupMenu::wndProc):
      * platform/wx/RenderThemeWx.cpp:
      (WebCore::nativeWindowForRenderObject):
      * platform/wx/ScrollbarThemeWx.cpp:
      (WebCore::ScrollbarThemeWx::paint):
      * plugins/gtk/PluginViewGtk.cpp:
      (WebCore::PluginView::getValue):
      (WebCore::PluginView::forceRedraw):
      (WebCore::PluginView::platformStart):
      * plugins/mac/PluginViewMac.cpp:
      (WebCore::PluginView::platformStart):
      * plugins/qt/PluginViewQt.cpp:
      (WebCore::PluginView::handleKeyboardEvent):
      (WebCore::PluginView::getValue):
      (WebCore::PluginView::platformStart):
      * plugins/win/PluginViewWin.cpp:
      (WebCore::PluginView::getValue):
      (WebCore::PluginView::forceRedraw):
      (WebCore::PluginView::platformStart):
      
      WebKit/gtk:
      
      Reflect the rename of platformWindow and it's return type.
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::platformPageClient):
      (WebKit::ChromeClient::runOpenPanel):
      * WebCoreSupport/ChromeClientGtk.h:
      * webkit/webkitprivate.cpp:
      (currentToplevelCallback):
      * webkit/webkitwebview.cpp:
      (webkit_web_view_popup_menu_handler):
      
      WebKit/haiku:
      
      Reflect the rename of platformWindow and it's return type.
      
      * WebCoreSupport/ChromeClientHaiku.cpp:
      (WebCore::ChromeClientHaiku::platformPageClient):
      * WebCoreSupport/ChromeClientHaiku.h:
      
      WebKit/mac:
      
      Reflect the rename of platformWindow and it's return type.
      
      * WebCoreSupport/WebChromeClient.h:
      * WebCoreSupport/WebChromeClient.mm:
      (WebChromeClient::platformPageClient):
      
      WebKit/qt:
      
      Reflect the rename of platformWindow and it's return type.
      
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::platformPageClient):
      * WebCoreSupport/ChromeClientQt.h:
      
      WebKit/win:
      
      Reflect the rename of platformWindow and it's return type.
      
      * AccessibleBase.cpp:
      (AccessibleBase::get_accParent):
      * WebCoreSupport/WebChromeClient.cpp:
      (WebChromeClient::platformPageClient):
      * WebCoreSupport/WebChromeClient.h:
      
      WebKit/wx:
      
      Reflect the rename of platformWindow and it's return type.
      
      * WebKitSupport/ChromeClientWx.cpp:
      (WebCore::ChromeClientWx::platformPageClient):
      * WebKitSupport/ChromeClientWx.h:
      * WebKitSupport/EditorClientWx.cpp:
      (WebCore::EditorClientWx::isEditable):
      (WebCore::EditorClientWx::registerCommandForUndo):
      (WebCore::EditorClientWx::registerCommandForRedo):
      (WebCore::EditorClientWx::clearUndoRedoOperations):
      (WebCore::EditorClientWx::canUndo):
      (WebCore::EditorClientWx::canRedo):
      (WebCore::EditorClientWx::undo):
      (WebCore::EditorClientWx::redo):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8249bf2
    • hausmann@webkit.org's avatar
      [Qt] Web inspector UI adjustments specific to the Qt platform: · daa9f964
      hausmann@webkit.org authored
      - Hide the close button
      - Hide the dock button
      - Disable the draggable toolbar
      
      Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-18
      Reviewed by Simon Hausmann.
      
      https://bugs.webkit.org/show_bug.cgi?id=29384
      
      * inspector/front-end/inspector.css:
      * inspector/front-end/inspector.js:
      (WebInspector.toolbarDragStart):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48510 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      daa9f964
    • hausmann@webkit.org's avatar
      Fix the Qt/Windows CE build. · fe9f3fda
      hausmann@webkit.org authored
      Patch by Joerg Bornemann <joerg.bornemann@nokia.com> on 2009-09-18
      Reviewed by Simon Hausmann.
      
      * JavaScriptCore.pri: Build the ce_time.cpp functions from
      within Qt externally.
      * wtf/DateMath.cpp: Removed unnecessary Qt #ifdef, for the
      Qt build these functions are no external, too.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48509 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe9f3fda
    • hausmann@webkit.org's avatar
      QtWebKit Windows CE compile fixes · 7f26dc14
      hausmann@webkit.org authored
      Patch by Joerg Bornemann <joerg.bornemann@nokia.com> on 2009-09-18
      Reviewed by Simon Hausmann.
      
      Exclude certain pure-WINCE specific code paths from the Qt build.
      
      * platform/graphics/BitmapImage.h:
      * platform/graphics/FontCache.h:
      * platform/graphics/MediaPlayer.cpp:
      * platform/text/TextEncodingRegistry.cpp:
      (WebCore::buildBaseTextCodecMaps):
      (WebCore::extendTextCodecMaps):
      * plugins/PluginView.cpp:
      (WebCore::PluginView::stop): Guard this code block with NETSCAPE_PLUGIN_API as
      the corresponding PluginViewWndProc has the same guard in the header file.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f26dc14
    • xan@webkit.org's avatar
      2009-09-18 Xan Lopez <xlopez@igalia.com> · 59eabdbb
      xan@webkit.org authored
              Reviewed by Jan Alonzo.
      
              Document webkit_web_view_stop_loading.
      
              * webkit/webkitwebview.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48507 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59eabdbb
    • xan@webkit.org's avatar
      2009-09-18 Xan Lopez <xlopez@igalia.com> · fd4dd8e1
      xan@webkit.org authored
              Reviewed by Gustavo Noronha and Jan Alonzo.
      
              [GTK] context menu overriding API is very limited
              https://bugs.webkit.org/show_bug.cgi?id=27546
      
              Add new tests to the build.
      
              * GNUmakefile.am:
      
      WebKit/gtk:
      
      2009-09-18  Xan Lopez  <xlopez@igalia.com>
      
              Reviewed by Gustavo Noronha and Jan Alonzo.
      
              [GTK] context menu overriding API is very limited
              https://bugs.webkit.org/show_bug.cgi?id=27546
      
              Add webkit_web_view_get_hit_test_result, a function to get a hit
              test result from a GdkEventButton. Useful to let applications
              decide between several actions on button press depending on what
              is being pressed.
      
              * webkit/webkitwebview.cpp:
              (webkit_web_view_stop_loading):
              (documentPointForWindowPoint):
              (webkit_web_view_get_hit_test_result):
              * webkit/webkitwebview.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48506 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd4dd8e1
    • xan@webkit.org's avatar
      2009-09-14 Xan Lopez <xlopez@igalia.com> · 2266a5b0
      xan@webkit.org authored
              Reviewed by Gustavo Noronha and Jan Alonzo.
      
              [GTK] context menu overriding API is very limited
              https://bugs.webkit.org/show_bug.cgi?id=27546
      
              Add WebKitHitTestResult to the build.
      
              * GNUmakefile.am:
      
      WebKit/gtk:
      
      2009-09-18  Xan Lopez  <xlopez@igalia.com>
      
              Reviewed by Gustavo Noronha and Jan Alonzo.
      
              [GTK] context menu overriding API is very limited
              https://bugs.webkit.org/show_bug.cgi?id=27546
      
              Add WebKitHitTestResult, a wrapper over HitTestResult. It contains
              context information about a point in the web page.
      
              * webkit/webkit.h:
              * webkit/webkitdefines.h:
              * webkit/webkithittestresult.cpp: Added.
              (webkit_hit_test_result_finalize):
              (webkit_hit_test_result_get_property):
              (webkit_hit_test_result_set_property):
              (webkit_hit_test_result_class_init):
              (webkit_hit_test_result_init):
              * webkit/webkithittestresult.h: Added.
              * webkit/webkitprivate.cpp:
              (WebKit::kit):
              * webkit/webkitprivate.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48505 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2266a5b0
    • hausmann@webkit.org's avatar
      [Qt] Add persistence support for configuration options in the · 9a2d46fb
      hausmann@webkit.org authored
      inspector.
      
      Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-18
      Reviewed by Simon Hausmann.
      
      * Api/qwebinspector.cpp:
      * QtLauncher/main.cpp:
      (main):
      * WebCoreSupport/InspectorClientQt.cpp:
      (WebCore::InspectorClientQt::populateSetting):
      (WebCore::InspectorClientQt::storeSetting):
      (WebCore::variantToSetting):
      (WebCore::settingToVariant):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48504 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a2d46fb
    • eric@webkit.org's avatar
      2009-09-18 Steve Block <steveblock@google.com> · a05aaad4
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              Geolocation does not correctly handle Infinity for PositionOptions properties.
              https://bugs.webkit.org/show_bug.cgi?id=29099
      
              * fast/dom/Geolocation/resources/argument-types.js: Modified. Test passing positive and negative Infinity to Geolocation methods.
              * fast/dom/Geolocation/argument-types-expected.txt: Modified. Expected result for above test.
      2009-09-18  Steve Block  <steveblock@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              Geolocation does not correctly handle Infinity for PositionOptions properties.
              https://bugs.webkit.org/show_bug.cgi?id=29099
      
              * bindings/js/JSGeolocationCustom.cpp: Modified.
              (WebCore::createPositionOptions): Modified. If timeout or maximumAge is positive infinity, applies these values as a special case.
              * page/PositionOptions.h: Modified.
              (WebCore::PositionOptions::hasMaximumAge): Added. Determines whether the object has a maximum age.
              (WebCore::PositionOptions::maximumAge): Modified. Asserts that the object has a maximum age.
              (WebCore::PositionOptions::clearMaximumAge): Added. Clears the maximum age.
              (WebCore::PositionOptions::setMaximumAge): Modified. Registers that the maximum age has been set.
              (WebCore::PositionOptions::PositionOptions): Modified. Registers that the maximum age has been set.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a05aaad4
    • hausmann@webkit.org's avatar
      Fixed a bunch of documentation warnings. · ee26bcb7
      hausmann@webkit.org authored
      Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-09-18
      Reviewed by Ariya Hidayat.
      
      * Api/qwebgraphicsitem.cpp:
      * Api/qwebplugindatabase.cpp:
      * Api/qwebpluginfactory.cpp:
      * Api/qwebsecurityorigin.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48502 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee26bcb7
    • hausmann@webkit.org's avatar
      Added a test that console output works. · ba1be41c
      hausmann@webkit.org authored
      Patch by Warwick Allison <warwick.allison@nokia.com> on 2009-09-18
      Reviewed by Simon Hausmann.
      
      * tests/qwebpage/tst_qwebpage.cpp:
      (ConsolePage::ConsolePage):
      (ConsolePage::javaScriptConsoleMessage):
      (tst_QWebPage::consoleOutput):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48501 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba1be41c
  2. 17 Sep, 2009 26 commits