Skip to content

GitLab

W
webkit
Switch branch/tag
  1. 07 Jan, 2011 1 commit
    • jamesr@google.com's avatar
      2011-01-07 James Robinson <jamesr@chromium.org> · f894f68c
      jamesr@google.com authored 
              Revert "Implement mozilla's animationTime property"
        https://bugs.webkit.org/show_bug.cgi?id=51952

        This approach isn't quite right.

        * animations/animation-time-expected.txt: Removed.
        * animations/animation-time.html: Removed.
        * animations/script-tests/animation-time.js: Removed.
        * fast/dom/Window/window-properties-expected.txt:
        * fast/dom/Window/window-property-descriptors-expected.txt:
        * platform/gtk/fast/dom/Window/window-properties-expected.txt:
        * platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
        * platform/qt/fast/dom/Window/window-properties-expected.txt:
        * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
        * platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
2011-01-07  James Robinson  <jamesr@chromium.org>

        Revert "Implement mozilla's animationTime property"
        https://bugs.webkit.org/show_bug.cgi?id=51952

        This approach isn't quite right.

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::paintInvalidatedRegion):
2011-01-07  James Robinson  <jamesr@chromium.org>

        Revert "Implement mozilla's animationTime property"
        https://bugs.webkit.org/show_bug.cgi?id=51952

        This approach isn't quite right.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.exp.in:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * page/DOMWindow.cpp:
        * page/DOMWindow.h:
        * page/DOMWindow.idl:
        * page/Frame.cpp:
        * page/Frame.h:
        * page/Page.cpp:
        (WebCore::Page::Page):
        * page/Page.h:
        * page/animation/AnimationController.cpp:
        (WebCore::AnimationControllerPrivate::beginAnimationUpdateTime):
        * page/animation/AnimationTimeController.cpp: Removed.
        * page/animation/AnimationTimeController.h: Removed.
2011-01-07  James Robinson  <jamesr@chromium.org>

        Revert "Implement mozilla's animationTime property"
        https://bugs.webkit.org/show_bug.cgi?id=51952

        This approach isn't quite right.

        * public/WebWidget.h:
        * src/WebPopupMenuImpl.cpp:
        * src/WebPopupMenuImpl.h:
        * src/WebViewImpl.cpp:
        * src/WebViewImpl.h:
2011-01-07  James Robinson  <jamesr@chromium.org>

        Revert "Implement mozilla's animationTime property"
        https://bugs.webkit.org/show_bug.cgi?id=51952

        This approach isn't quite right.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView drawRect:]):
        * WebView/WebView.mm:
        (layerSyncRunLoopObserverCallBack):
2011-01-07  James Robinson  <jamesr@chromium.org>

        Revert "Implement mozilla's animationTime property"
        https://bugs.webkit.org/show_bug.cgi?id=51952

        This approach isn't quite right.

        * WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
        (WebKit::ChunkedUpdateDrawingArea::display):
        (WebKit::ChunkedUpdateDrawingArea::setSize):
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::drawRect):
        * WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:
        (WebKit::LayerBackedDrawingArea::syncCompositingLayers):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75276 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f894f68c
  3. 06 Jan, 2011 2 commits
    • jamesr@google.com's avatar
      2011-01-06 James Robinson <jamesr@chromium.org> · c0dca2a1
      jamesr@google.com authored 
              Reviewed by Simon Fraser.

        Implement mozilla's animationTime property
        https://bugs.webkit.org/show_bug.cgi?id=51952

        Tests for window.webkitAnimationTime.

        * animations/animation-time-expected.txt: Added.
        * animations/animation-time.html: Added.
        * animations/script-tests/animation-time.js: Added.
2011-01-06  James Robinson  <jamesr@chromium.org>

        Reviewed by Simon Fraser.

        Implement mozilla's animationTime property
        https://bugs.webkit.org/show_bug.cgi?id=51952

        Chromium DRT support for webkitAnimationTime.

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::paintInvalidatedRegion):
2011-01-06  James Robinson  <jamesr@chromium.org>

        Reviewed by Simon Fraser.

        Implement mozilla's animationTime property
        https://bugs.webkit.org/show_bug.cgi?id=51952

        Implements mozilla's animationTime property as described here:
        https://developer.mozilla.org/en/DOM/window.mozAnimationStartTime
        and http://hacks.mozilla.org/2010/08/more-efficient-javascript-animations-with-mozrequestanimationframe/
        The property is called webkitAnimationTime as calling it the 'Start' time is not very informative.
        This property exposes a notion of a 'current' time to use for declarative animations and allows
        scripts to synchronize imperative animations with declarative ones if they choose to.  Once queried
        this time is saved and used for all declarative animation updates until the embedder paints/composites
        the next frame and clears it, or 15ms elapse (in case the embedder isn't producing frames, for example
        if the page is in a background tab).

        This patch also ensures that all declarative animations started in the same script execution block
        are synchronized even if some time elapses while script is running.

        Test: fast/animation/animation-time.html

        * WebCore.gypi:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::webkitAnimationTime):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:
        * page/Frame.cpp:
        (WebCore::Frame::currentAnimationTime):
        * page/Frame.h:
        * page/Page.cpp:
        (WebCore::Page::Page):
        * page/Page.h:
        (WebCore::Page::animationTime):
        * page/animation/AnimationController.cpp:
        (WebCore::AnimationControllerPrivate::beginAnimationUpdateTime):
        * page/animation/AnimationTimeController.cpp: Added.
        (WebCore::AnimationTimeController::AnimationTimeController):
        (WebCore::AnimationTimeController::~AnimationTimeController):
        (WebCore::AnimationTimeController::currentAnimationTime):
        (WebCore::AnimationTimeController::clearCurrentAnimationTime):
        (WebCore::AnimationTimeController::clearCurrentAnimationTimeTimerFired):
        * page/animation/AnimationTimeController.h: Added.
        (WebCore::AnimationTimeController::create):
2011-01-06  James Robinson  <jamesr@chromium.org>

        Reviewed by Simon Fraser.

        Implement mozilla's animationTime property
        https://bugs.webkit.org/show_bug.cgi?id=51952

        WebKit API support for webkitAnimationTime.

        * public/WebWidget.h:
        * src/WebPopupMenuImpl.cpp:
        (WebKit::WebPopupMenuImpl::clearCurrentAnimationTime):
        * src/WebPopupMenuImpl.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::clearCurrentAnimationTime):
        * src/WebViewImpl.h:
2011-01-06  James Robinson  <jamesr@chromium.org>

        Reviewed by Simon Fraser.

        Implement mozilla's animationTime property
        https://bugs.webkit.org/show_bug.cgi?id=51952

        Tells the page to clear the current animation time after producing a frame.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::drawRect):
        * WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
        (WebKit::ChunkedUpdateDrawingArea::display):
        (WebKit::ChunkedUpdateDrawingArea::setSize):
        * WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:
        (WebKit::LayerBackedDrawingArea::syncCompositingLayers):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75169 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0dca2a1
    • jam@chromium.org's avatar
      2010-12-29 John Abd-El-Malek <jam@chromium.org> · 58914a59
      jam@chromium.org authored 
              Reviewed by Darin Fisher.

        [chromium] Add a WebAutoFillClient interface that moves some functions from WebViewClient
        https://bugs.webkit.org/show_bug.cgi?id=51710

        * WebKit.gyp:
        * public/WebAutoFillClient.h: Added.
        (WebKit::WebAutoFillClient::didAcceptAutoFillSuggestion):
        (WebKit::WebAutoFillClient::didSelectAutoFillSuggestion):
        (WebKit::WebAutoFillClient::didClearAutoFillSelection):
        (WebKit::WebAutoFillClient::removeAutocompleteSugestion):
        (WebKit::WebAutoFillClient::didAcceptAutocompleteSuggestion):
        (WebKit::WebAutoFillClient::textFieldDidBeginEditing):
        (WebKit::WebAutoFillClient::textFieldDidEndEditing):
        (WebKit::WebAutoFillClient::textFieldDidChange):
        (WebKit::WebAutoFillClient::textFieldDidReceiveKeyDown):
        (WebKit::WebAutoFillClient::~WebAutoFillClient):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75146 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58914a59
  5. 05 Jan, 2011 3 commits
    • crogers@google.com's avatar
      2011-01-05 Chris Rogers <crogers@google.com> · bf85fc53
      crogers@google.com authored 
              Reviewed by Darin Fisher.

        Add WebKitClient::createAudioDevice() for Chromium port of web audio API
        https://bugs.webkit.org/show_bug.cgi?id=51424

        * WebKit.gyp:
        * public/WebAudioDevice.h: Added.
        (WebKit::WebAudioDevice::RenderCallback::~RenderCallback):
        (WebKit::WebAudioDevice::~WebAudioDevice):
        * public/WebKitClient.h:
        (WebKit::WebKitClient::createAudioDevice):
        * src/AudioDestinationChromium.cpp: Added.
        (WebCore::AudioDestination::create):
        (WebCore::AudioDestinationChromium::AudioDestinationChromium):
        (WebCore::AudioDestinationChromium::~AudioDestinationChromium):
        (WebCore::AudioDestinationChromium::start):
        (WebCore::AudioDestinationChromium::stop):
        (WebCore::AudioDestination::hardwareSampleRate):
        (WebCore::AudioDestinationChromium::render):
        * src/AudioDestinationChromium.h: Added.
        (WebCore::AudioDestinationChromium::isPlaying):
        (WebCore::AudioDestinationChromium::sampleRate):
2011-01-05  Chris Rogers  <crogers@google.com>

        Reviewed by Darin Fisher.

        Add WebKitClient::createAudioDevice() for Chromium port of web audio API
        https://bugs.webkit.org/show_bug.cgi?id=51424

        No new tests since audio API is not yet implemented.

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75118 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf85fc53
    • levin@chromium.org's avatar
      2011-01-05 David Levin <levin@chromium.org> · a616293e
      levin@chromium.org authored 
              Reviewed by Darin Fisher.

        [chromium] WEBKIT_API and styling fixes for the chromium api.
        https://bugs.webkit.org/show_bug.cgi?id=51863

        Removed some incorrect uses of WEBKIT_API.
        Fixed some abbreviations by making them whole words.

        * public/WebAnimationController.h: Removed WEBKIT_API from virtual functions.
        * public/WebFormElement.h: Removed WEBKIT_API from inline functions
        and fixed some abbreviations.
        (WebKit::WebFormElement::WebFormElement):
        (WebKit::WebFormElement::operator=):
        (WebKit::WebFormElement::assign):
        * public/WebIDBDatabaseError.h: Ditto.
        (WebKit::WebIDBDatabaseError::WebIDBDatabaseError):
        (WebKit::WebIDBDatabaseError::operator=):
        * public/WebInputElement.h: Ditto.
        (WebKit::WebInputElement::WebInputElement):
        (WebKit::WebInputElement::operator=):
        (WebKit::WebInputElement::assign):
        * public/WebLabelElement.h: Ditto.
        (WebKit::WebLabelElement::WebLabelElement):
        (WebKit::WebLabelElement::operator=):
        (WebKit::WebLabelElement::assign):
        * public/WebOptionElement.h: Ditto.
        (WebKit::WebOptionElement::WebOptionElement):
        (WebKit::WebOptionElement::operator=):
        (WebKit::WebOptionElement::assign):
        * public/WebSelectElement.h: Ditto (and minor spacing cleanup).
        (WebKit::WebSelectElement::WebSelectElement):
        (WebKit::WebSelectElement::operator=):
        (WebKit::WebSelectElement::assign):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a616293e
    • hans@chromium.org's avatar
      2011-01-05 Hans Wennborg <hans@chromium.org> · ddf8901d
      hans@chromium.org authored 
              Reviewed by David Levin.

        [Chromium] WebIDBKey clean-up
        https://bugs.webkit.org/show_bug.cgi?id=51925

        Remove constructors that are no longer used since the
        Chromium side has been updated.

        * public/WebIDBKey.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75064 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ddf8901d
  7. 04 Jan, 2011 1 commit
    • commit-queue@webkit.org's avatar
      2011-01-04 Zhe Su <suzhe@chromium.org> · 5f354cec
      commit-queue@webkit.org authored 
              Reviewed by Kenneth Russell.

        1. Remove entry for editing/input/ime-composition-clearpreedit.html test.
        2. Improve fast/events/ime-composition-events-001.html to cover more
           cases. And fix test expectations of chromium port.
        https://bugs.webkit.org/show_bug.cgi?id=51693

        * fast/events/ime-composition-events-001-expected.txt:
        * fast/events/ime-composition-events-001.html:
        * platform/chromium-mac/fast/events/ime-composition-events-001-expected.txt: Removed.
        * platform/chromium-win/fast/events/ime-composition-events-001-expected.txt: Removed.
        * platform/chromium/fast/events/ime-composition-events-001-expected.txt: Added.
        * platform/chromium/test_expectations.txt:
        * platform/qt/fast/events/ime-composition-events-001-expected.txt: Added.
2011-01-04  Zhe Su  <suzhe@chromium.org>

        Reviewed by Kenneth Russell.

        Fix insertText, setMarkedText and unmarkText methods of
        TextInputController to call corresponding methods of WebKit::WebView
        rather than WebKit::WebFrame. This change matches the behavior of
        chromium browser.
        insertText corresponds to WebView::confirmComposition(text)
        setMarkedText corresponds to WebView::setComposition(...)
        unmarkText corresponds to WebView::confirmComposition()
        https://bugs.webkit.org/show_bug.cgi?id=51693

        * DumpRenderTree/chromium/TextInputController.cpp:
        (TextInputController::insertText):
        (TextInputController::setMarkedText):
        (TextInputController::unmarkText):
2011-01-04  Zhe Su  <suzhe@chromium.org>

        Reviewed by Kenneth Russell.

        Changes:
        1. Add WebKit::WebWidget::confirmComposition(const WebString& text)
           This new method corresponds to Editor::confirmComposition(text) and
           Editor::insertText(text). It'll be used by both DumpRenderTree's
           TextInputController and chromium browser.
        2. Fix WebFrameImpl::insertText
           It should call Editor::confirmComposition(text) rather than
           Editor::insertText(text) if there is an ongoing composition.
           It matches the behavior of WebKit Mac port.
        3. Fix WebFrameImpl::setMarkedText
           Editor::confirmComposition(text) shouldn't be called in this
           method, which incorrectly inserts the text.

        https://bugs.webkit.org/show_bug.cgi?id=51693

        * public/WebWidget.h:
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::insertText):
        (WebKit::WebFrameImpl::setMarkedText):
        * src/WebPopupMenuImpl.cpp:
        (WebKit::WebPopupMenuImpl::confirmComposition):
        * src/WebPopupMenuImpl.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::confirmComposition):
        * src/WebViewImpl.h:
        * tests/PopupMenuTest.cpp:
        (WebKit::TestWebWidget::confirmComposition):
2011-01-04  Zhe Su  <suzhe@chromium.org>

        Reviewed by Kenneth Russell.

        Fix test LayoutTests/fast/events/ime-composition-events-001.html.

        https://bugs.webkit.org/show_bug.cgi?id=51693

        * Api/qwebpage.cpp:
        (QWebPagePrivate::inputMethodEvent): Calls editor->insertText() to
        insert the commit string when no composition text is available.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75000 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f354cec
  9. 23 Dec, 2010 1 commit
    • mihaip@chromium.org's avatar
      2010-12-23 Mihai Parparita <mihaip@chromium.org> · 932c7635
      mihaip@chromium.org authored 
              Reviewed by Kent Tamura.

        [Chromium] Add WebThemeEngine for Mac to allow scrollbar rendering to be overridden for the DRT
        https://bugs.webkit.org/show_bug.cgi?id=51507

        Adds WebThemeEngine for the Mac (it already has parallel definitions for
        Windows and Linux) so that scrollbar thumb rendering can be overridden
        for the DRT (to be consistent with the NSScroller-based rendering
        used by the Mac port).

        No new tests since the functionality is not exposed yet. Eventually will
        result in the Chromium/Mac port being able to use the same pixel
        baselines for layout tests as the Mac port.

        * platform/chromium/ChromiumBridge.h:
        * platform/chromium/ScrollbarThemeChromiumMac.mm:
        (WebCore::scrollbarStateToThemeState):
        (WebCore::ScrollbarThemeChromiumMac::paint):
2010-12-23  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] Add WebThemeEngine for Mac to allow scrollbar rendering to be overridden for the DRT
        https://bugs.webkit.org/show_bug.cgi?id=51507

        Adds WebThemeEngine for the Mac (it already has parallel definitions for
        Windows and Linux) so that scrollbar thumb rendering can be overridden
        for the DRT (to be consistent with the NSScroller-based rendering
        used by the Mac port).

        * public/mac/WebThemeEngine.h: Added.
        (WebKit::WebThemeEngine::paintScrollbarThumb):
        * src/AssertMatchingEnums.cpp:
        * src/ChromiumBridge.cpp:
        (WebCore::ChromiumBridge::paintScrollbarThumb):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74581 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      932c7635
  11. 20 Dec, 2010 1 commit
    • andreip@google.com's avatar
      2010-12-20 Andrei Popescu <andreip@google.com> · 0837fabb
      andreip@google.com authored 
              Reviewed by Jeremy Orlow.

        IDBCursor::delete is not implemented.
        https://bugs.webkit.org/show_bug.cgi?id=51110

        * storage/indexeddb/cursor-delete-expected.txt: Added.
        * storage/indexeddb/cursor-delete.html: Added.
        * storage/indexeddb/cursor-index-delete-expected.txt: Added.
        * storage/indexeddb/cursor-index-delete.html: Added.
2010-12-20  Andrei Popescu  <andreip@google.com>

        Reviewed by Jeremy Orlow.

        IDBCursor::delete is not implemented.
        https://bugs.webkit.org/show_bug.cgi?id=51110

        Implement IDBCursor::delete.
        See http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#widl-IDBCursor-delete

        Tests: storage/indexeddb/cursor-delete.html
               storage/indexeddb/cursor-index-delete.html

        * storage/IDBCursor.cpp:
        (WebCore::IDBCursor::deleteFunction):
        * storage/IDBCursor.h:
        * storage/IDBCursor.idl:
        * storage/IDBCursorBackendImpl.cpp:
        (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
        (WebCore::IDBCursorBackendImpl::deleteFunction):
        (WebCore::IDBCursorBackendImpl::loadCurrentRow):
        * storage/IDBCursorBackendImpl.h:
        (WebCore::IDBCursorBackendImpl::create):
        * storage/IDBCursorBackendInterface.h:
        * storage/IDBIndexBackendImpl.cpp:
        (WebCore::IDBIndexBackendImpl::openCursorInternal):
        * storage/IDBKey.cpp:
        (WebCore::IDBKey::fromQuery):
        * storage/IDBObjectStoreBackendImpl.cpp:
        (WebCore::IDBObjectStoreBackendImpl::deleteInternal):
        (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
2010-12-20  Andrei Popescu  <andreip@google.com>

        Reviewed by Jeremy Orlow.

        IDBCursor::delete is not implemented.
        https://bugs.webkit.org/show_bug.cgi?id=51110

        * public/WebIDBCursor.h:
        (WebKit::WebIDBCursor::remove):
        (WebKit::WebIDBCursor::deleteFunction):
        * src/IDBCursorBackendProxy.cpp:
        (WebCore::IDBCursorBackendProxy::deleteFunction):
        * src/IDBCursorBackendProxy.h:
        * src/WebIDBCursorImpl.cpp:
        (WebKit::WebIDBCursorImpl::deleteFunction):
        * src/WebIDBCursorImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74342 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0837fabb
  13. 18 Dec, 2010 1 commit
    • tonyg@chromium.org's avatar
      2010-12-18 Tony Gentilcore <tonyg@chromium.org> · 64d18d9b
      tonyg@chromium.org authored 
              Reviewed by Laszlo Gombos.

        [Web Timing] Rename domContentLoaded{Start,End}->domContentLoadedEvent{Start,End}
        https://bugs.webkit.org/show_bug.cgi?id=50943

        * fast/dom/Window/window-properties-performance-expected.txt:
        * fast/dom/script-tests/webtiming.js:
        (checkTimingBeforeLoad):
        (checkTimingWhileDeferred):
        (checkWebTimingOnDOMContentLoaded):
        (checkWebTimingWhileAsync):
        (checkWebTimingOnLoad):
        (checkWebTimingAfterLoad):
        * fast/dom/webtiming-document-open-expected.txt:
        * fast/dom/webtiming-expected.txt:
        * fast/dom/webtiming-navigate-within-document-expected.txt:
2010-12-18  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Laszlo Gombos.

        [Web Timing] Rename domContentLoaded{Start,End}->domContentLoadedEvent{Start,End}
        https://bugs.webkit.org/show_bug.cgi?id=50943

        See: http://test.w3.org/webperf/specs/NavigationTiming/#nt-dom-content-event-start

        * dom/Document.cpp:
        (WebCore::Document::finishedParsing):
        * dom/DocumentTiming.h:
        (WebCore::DocumentTiming::DocumentTiming):
        * page/PerformanceTiming.cpp:
        (WebCore::PerformanceTiming::domContentLoadedEventStart):
        (WebCore::PerformanceTiming::domContentLoadedEventEnd):
        * page/PerformanceTiming.h:
        * page/PerformanceTiming.idl:
2010-12-18  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Laszlo Gombos.

        [Web Timing] Rename domContentLoaded{Start,End}->domContentLoadedEvent{Start,End}
        https://bugs.webkit.org/show_bug.cgi?id=50943

        Exposes all dom* times to the chromium port. I'm particularly interested in
        domContentLoadedEventEnd as it compares to the FinishDoc metric.

        * public/WebPerformance.h:
        * src/WebPerformance.cpp:
        (WebKit::WebPerformance::domLoading):
        (WebKit::WebPerformance::domInteractive):
        (WebKit::WebPerformance::domContentLoadedEventStart):
        (WebKit::WebPerformance::domContentLoadedEventEnd):
        (WebKit::WebPerformance::domComplete):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74315 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64d18d9b
  15. 17 Dec, 2010 1 commit
    • hans@chromium.org's avatar
      2010-12-17 Hans Wennborg <hans@chromium.org> · 7e775392
      hans@chromium.org authored 
              Reviewed by Jeremy Orlow.

        IndexedDB: Support Date objects as keys.
        https://bugs.webkit.org/show_bug.cgi?id=51193

        Update layout tests to check that having Date objects as keys work.

        * storage/indexeddb/objectstore-basics-expected.txt:
        * storage/indexeddb/objectstore-basics.html:
2010-12-17  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Support Date objects as keys.
        https://bugs.webkit.org/show_bug.cgi?id=51193

        * bindings/v8/IDBBindingUtilities.cpp:
        (WebCore::createIDBKeyFromValue):
        Use the new IDBKey factory functions, and support Date objects.
        * bindings/v8/custom/V8IDBKeyCustom.cpp:
        (WebCore::toV8):
        Create Date objects from DateType keys.
        * storage/IDBKey.cpp:
        (WebCore::IDBKey::fromQuery):
        (WebCore::IDBKey::isEqual):
        (WebCore::IDBKey::whereSyntax):
        (WebCore::IDBKey::lowerCursorWhereFragment):
        (WebCore::IDBKey::upperCursorWhereFragment):
        (WebCore::IDBKey::bind):
        (WebCore::IDBKey::bindWithNulls):
        Update all SQL related functions to handle Date keys.
        * storage/IDBKey.h:
        (WebCore::IDBKey::createNull):
        (WebCore::IDBKey::createNumber):
        (WebCore::IDBKey::createString):
        (WebCore::IDBKey::createDate):
        Rename the create factories; since both number and date is just a
        double, function overloading can't be used to discriminate between
        the factories.
        (WebCore::IDBKey::date):
        Add getter for the date value.
2010-12-17  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Support Date objects as keys.
        https://bugs.webkit.org/show_bug.cgi?id=51193

        Update to match the underlying WebCore IDBKey class:
        add the DateType, add create() functions for each type,
        deprecate the public constructors (will be removed once
        Chromium side is updated).

        * public/WebIDBKey.h:
        (WebKit::WebIDBKey::WebIDBKey):
        * src/AssertMatchingEnums.cpp:
        * src/WebIDBKey.cpp:
        (WebKit::WebIDBKey::createString):
        (WebKit::WebIDBKey::createDate):
        (WebKit::WebIDBKey::createNumber):
        (WebKit::WebIDBKey::assignNull):
        (WebKit::WebIDBKey::assignString):
        (WebKit::WebIDBKey::assignDate):
        (WebKit::WebIDBKey::assignNumber):
        (WebKit::WebIDBKey::date):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74266 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e775392
  17. 15 Dec, 2010 1 commit
  19. 13 Dec, 2010 1 commit
  21. 10 Dec, 2010 4 commits
    • kbr@google.com's avatar
      2010-12-10 Kenneth Russell <kbr@google.com> · 81bb4971
      kbr@google.com authored 
              Reviewed by James Robinson.

        Implement extension entry points and remove EXTENSIONS enum
        https://bugs.webkit.org/show_bug.cgi?id=40316

        Added support for ensuring that a particular OpenGL extension is
        enabled.

        * public/WebGraphicsContext3D.h:
        * src/Extensions3DChromium.cpp:
        (WebCore::Extensions3DChromium::ensureEnabled):
        * src/GraphicsContext3DChromium.cpp:
        (WebCore::GraphicsContext3DInternal::initializeExtensions):
        (WebCore::GraphicsContext3DInternal::supportsExtension):
        (WebCore::GraphicsContext3DInternal::ensureExtensionEnabled):
        * src/GraphicsContext3DInternal.h:
        * src/WebGraphicsContext3DDefaultImpl.cpp:
        (WebKit::WebGraphicsContext3DDefaultImpl::getRequestableExtensionsCHROMIUM):
        (WebKit::WebGraphicsContext3DDefaultImpl::requestExtensionCHROMIUM):
        * src/WebGraphicsContext3DDefaultImpl.h:
2010-12-10  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        Implement extension entry points and remove EXTENSIONS enum
        https://bugs.webkit.org/show_bug.cgi?id=40316

        Implemented WebGLRenderingContext's getSupportedExtensions and
        getExtensions entry points, and, to verify them, added support for
        the first specified WebGL extension, OES_texture_float. This
        extension is now advertised in the Chromium and WebKit ports when
        the underlying hardware supports it.

        The new OES_texture_float test in the WebGL conformance suite
        verifies the allocation and population of floating point textures,
        and their use as render targets. However, because this extension
        is optional, it is not easily testable with a layout test; there
        is only one set of expectations for a given test, and two would be
        needed, one when the extension is available and one when it is not.

        Tested with the oes-texture-float.html WebGL conformance test in
        Chromium and WebKit on Mac OS X on hardware that supports the
        extension. Also verified with a configuration that does not
        advertise the extension that this same test passes.

        * CMakeLists.txt:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pri:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSWebGLRenderingContextCustom.cpp:
        (WebCore::toJS):
        (WebCore::JSWebGLRenderingContext::markChildren):
        (WebCore::JSWebGLRenderingContext::getExtension):
        (WebCore::JSWebGLRenderingContext::getSupportedExtensions):
        * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
        (WebCore::toV8Object):
        (WebCore::V8WebGLRenderingContext::getExtensionCallback):
        (WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallback):
        * html/canvas/OESTextureFloat.cpp: Added.
        (WebCore::OESTextureFloat::OESTextureFloat):
        (WebCore::OESTextureFloat::~OESTextureFloat):
        (WebCore::OESTextureFloat::getName):
        (WebCore::OESTextureFloat::create):
        * html/canvas/OESTextureFloat.h: Added.
        * html/canvas/OESTextureFloat.idl: Added.
        * html/canvas/WebGLExtension.cpp: Added.
        (WebCore::WebGLExtension::WebGLExtension):
        (WebCore::WebGLExtension::~WebGLExtension):
        * html/canvas/WebGLExtension.h: Added.
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::getExtension):
        (WebCore::WebGLRenderingContext::getSupportedExtensions):
        (WebCore::WebGLRenderingContext::validateTexFuncFormatAndType):
        (WebCore::WebGLRenderingContext::validateTexFuncData):
        (WebCore::WebGLRenderingContext::getNumberOfExtensions):
        (WebCore::WebGLRenderingContext::getExtensionNumber):
        * html/canvas/WebGLRenderingContext.h:
        * html/canvas/WebGLRenderingContext.idl:
        * platform/graphics/Extensions3D.h:
        * platform/graphics/GraphicsContext3D.cpp:
        (WebCore::GraphicsContext3D::computeFormatAndTypeParameters):
        (WebCore::GraphicsContext3D::extractTextureData):
        (WebCore::doUnpackingAndPacking):
        (WebCore::doPacking):
        (WebCore::doFloatingPointPacking):
        (WebCore::GraphicsContext3D::packPixels):
        * platform/graphics/GraphicsContext3D.h:
        * platform/graphics/chromium/Extensions3DChromium.h:
        * platform/graphics/opengl/Extensions3DOpenGL.cpp:
        (WebCore::Extensions3DOpenGL::supports):
        (WebCore::Extensions3DOpenGL::ensureEnabled):
        * platform/graphics/opengl/Extensions3DOpenGL.h:
        * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
        (WebCore::GraphicsContext3D::texImage2D):
        * platform/graphics/qt/Extensions3DQt.cpp:
        (WebCore::Extensions3DQt::ensureEnabled):
        * platform/graphics/qt/Extensions3DQt.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81bb4971
    • commit-queue@webkit.org's avatar
      2010-12-10 John Knottenbelt <jknotten@chromium.org> · 51d3357c
      commit-queue@webkit.org authored 
              Reviewed by Steve Block.

        [Chromium] Implement mocks for client-based geolocation
        https://bugs.webkit.org/show_bug.cgi?id=46895

        * WebKit.gyp:
        * public/WebGeolocationClientMock.h: Added.
        (WebKit::WebGeolocationClientMock::~WebGeolocationClientMock):
        (WebKit::WebGeolocationClientMock::WebGeolocationClientMock):
        * src/WebGeolocationClientMock.cpp: Added.
        (WebKit::WebGeolocationClientMock::create):
        (WebKit::WebGeolocationClientMock::initialize):
        (WebKit::WebGeolocationClientMock::reset):
        (WebKit::WebGeolocationClientMock::setMockGeolocationPosition):
        (WebKit::WebGeolocationClientMock::setMockGeolocationError):
        (WebKit::WebGeolocationClientMock::setMockGeolocationPermission):
        (WebKit::WebGeolocationClientMock::resetMock):
        (WebKit::WebGeolocationClientMock::startUpdating):
        (WebKit::WebGeolocationClientMock::stopUpdating):
        (WebKit::WebGeolocationClientMock::setEnableHighAccuracy):
        (WebKit::WebGeolocationClientMock::geolocationDestroyed):
        (WebKit::WebGeolocationClientMock::setController):
        (WebKit::WebGeolocationClientMock::lastPosition):
        (WebKit::WebGeolocationClientMock::requestPermission):
        (WebKit::WebGeolocationClientMock::cancelPermissionRequest):
        * src/WebGeolocationServiceMock.cpp:
2010-12-10  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Steve Block.

        [Chromium] Implement mocks for client-based geolocation
        https://bugs.webkit.org/show_bug.cgi?id=46895

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::setGeolocationPermission):
        (LayoutTestController::setMockGeolocationPosition):
        (LayoutTestController::setMockGeolocationError):
        * DumpRenderTree/chromium/LayoutTestController.h:
        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::geolocationClient):
        (WebViewHost::geolocationClientMock):
        (WebViewHost::reset):
        * DumpRenderTree/chromium/WebViewHost.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73745 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      51d3357c
    • commit-queue@webkit.org's avatar
      2010-12-10 John Knottenbelt <jknotten@chromium.org> · 38560d2b
      commit-queue@webkit.org authored 
              Reviewed by Steve Block.

        [chromium] Implement client based geolocation bindings
        https://bugs.webkit.org/show_bug.cgi?id=45752

        Implements the necessary plumbing to expose client-based geolocation in Chromium
        webkit. The plan is to remove the non-client-based geolocation code (GeolocationService*)
        in the future.

        * WebKit.gyp:
        * public/WebGeolocationClient.h: Added.
        (WebKit::WebGeolocationClient::~WebGeolocationClient):
        * public/WebGeolocationController.h: Added.
        (WebKit::WebGeolocationController::WebGeolocationController):
        (WebKit::WebGeolocationController::reset):
        * public/WebGeolocationError.h:
        * public/WebGeolocationPermissionRequest.h: Added.
        (WebKit::WebGeolocationPermissionRequest::WebGeolocationPermissionRequest):
        (WebKit::WebGeolocationPermissionRequest::geolocation):
        * public/WebGeolocationPermissionRequestManager.h: Added.
        (WebKit::WebGeolocationPermissionRequestManager::WebGeolocationPermissionRequestManager):
        (WebKit::WebGeolocationPermissionRequestManager::~WebGeolocationPermissionRequestManager):
        * public/WebGeolocationPosition.h:
        * public/WebViewClient.h:
        (WebKit::WebViewClient::geolocationClient):
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::requestGeolocationPermissionForFrame):
        (WebKit::ChromeClientImpl::cancelGeolocationPermissionRequestForFrame):
        * src/GeolocationClientProxy.cpp: Added.
        (WebKit::GeolocationClientProxy::GeolocationClientProxy):
        (WebKit::GeolocationClientProxy::~GeolocationClientProxy):
        (WebKit::GeolocationClientProxy::setController):
        (WebKit::GeolocationClientProxy::geolocationDestroyed):
        (WebKit::GeolocationClientProxy::startUpdating):
        (WebKit::GeolocationClientProxy::stopUpdating):
        (WebKit::GeolocationClientProxy::setEnableHighAccuracy):
        (WebKit::GeolocationClientProxy::lastPosition):
        (WebKit::GeolocationClientProxy::requestPermission):
        (WebKit::GeolocationClientProxy::cancelPermissionRequest):
        * src/GeolocationClientProxy.h: Added.
        * src/WebGeolocationController.cpp: Added.
        (WebKit::WebGeolocationController::positionChanged):
        (WebKit::WebGeolocationController::errorOccurred):
        (WebKit::WebGeolocationController::controller):
        * src/WebGeolocationPermissionRequest.cpp: Added.
        (WebKit::WebGeolocationPermissionRequest::securityOrigin):
        (WebKit::WebGeolocationPermissionRequest::setIsAllowed):
        * src/WebGeolocationPermissionRequestManager.cpp: Added.
        (WebGeolocationPermissionRequestManager::add):
        (WebGeolocationPermissionRequestManager::remove):
        (WebGeolocationPermissionRequestManager::init):
        (WebGeolocationPermissionRequestManager::reset):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::WebViewImpl):
        * src/WebViewImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73724 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38560d2b
    • hans@chromium.org's avatar
      2010-12-10 Hans Wennborg <hans@chromium.org> · 6a1a6dfd
      hans@chromium.org authored 
              Reviewed by Jeremy Orlow.

        IndexedDB: Numeric keys are floats.
        https://bugs.webkit.org/show_bug.cgi?id=50674

        Update layout tests to use floating-point values for keys.

        * storage/indexeddb/keyrange-expected.txt:
        * storage/indexeddb/keyrange.html:
        Make sure creating the keys works.
        * storage/indexeddb/objectstore-cursor-expected.txt:
        * storage/indexeddb/objectstore-cursor.html:
        Make sure retrieving the keys from the DB objectstore works.
2010-12-10  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Numeric keys are floats.
        https://bugs.webkit.org/show_bug.cgi?id=50674

        Use floating point to represent numeric keys,
        add version meta data to the SQLite db,
        and migrate object stores that use integers.

        * bindings/v8/IDBBindingUtilities.cpp:
        (WebCore::createIDBKeyFromValue):
        * bindings/v8/custom/V8IDBKeyCustom.cpp:
        (WebCore::toV8):
        * storage/IDBFactoryBackendImpl.cpp:
        (WebCore::createTables):
        (WebCore::migrateDatabase):
        (WebCore::IDBFactoryBackendImpl::open):
        * storage/IDBKey.cpp:
        (WebCore::IDBKey::IDBKey):
        (WebCore::IDBKey::fromQuery):
        (WebCore::IDBKey::bind):
        (WebCore::IDBKey::bindWithNulls):
        * storage/IDBKey.h:
        (WebCore::IDBKey::create):
        (WebCore::IDBKey::number):
2010-12-10  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Numeric keys are floats.
        https://bugs.webkit.org/show_bug.cgi?id=50674

        Represent numeric keys as floating point values.

        * public/WebIDBKey.h:
        (WebKit::WebIDBKey::WebIDBKey):
        * src/WebIDBKey.cpp:
        (WebKit::WebIDBKey::assign):
        (WebKit::WebIDBKey::number):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a1a6dfd
  23. 09 Dec, 2010 2 commits
    • hans@chromium.org's avatar
      2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com> · c60f78d5
      hans@chromium.org authored 
              Unreviewed, rolling out r73616.
        http://trac.webkit.org/changeset/73616
        https://bugs.webkit.org/show_bug.cgi?id=50772

        Breaks chromium win build (Requested by hwennborg on #webkit).

        * public/WebIDBKey.h:
        (WebKit::WebIDBKey::WebIDBKey):
        * src/WebIDBKey.cpp:
        (WebKit::WebIDBKey::assign):
        (WebKit::WebIDBKey::number):
2010-12-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r73616.
        http://trac.webkit.org/changeset/73616
        https://bugs.webkit.org/show_bug.cgi?id=50772

        Breaks chromium win build (Requested by hwennborg on #webkit).

        * bindings/v8/IDBBindingUtilities.cpp:
        (WebCore::createIDBKeyFromValue):
        * bindings/v8/custom/V8IDBKeyCustom.cpp:
        (WebCore::toV8):
        * storage/IDBFactoryBackendImpl.cpp:
        (WebCore::createTables):
        (WebCore::IDBFactoryBackendImpl::open):
        * storage/IDBKey.cpp:
        (WebCore::IDBKey::IDBKey):
        (WebCore::IDBKey::fromQuery):
        (WebCore::IDBKey::bind):
        (WebCore::IDBKey::bindWithNulls):
        * storage/IDBKey.h:
        (WebCore::IDBKey::create):
        (WebCore::IDBKey::number):
2010-12-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r73616.
        http://trac.webkit.org/changeset/73616
        https://bugs.webkit.org/show_bug.cgi?id=50772

        Breaks chromium win build (Requested by hwennborg on #webkit).

        * storage/indexeddb/index-basics-expected.txt:
        * storage/indexeddb/index-basics.html:
        * storage/indexeddb/index-cursor.html:
        * storage/indexeddb/keyrange-expected.txt:
        * storage/indexeddb/keyrange.html:
        * storage/indexeddb/objectstore-cursor.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c60f78d5
    • hans@chromium.org's avatar
      2010-12-09 Hans Wennborg <hans@chromium.org> · 976f357f
      hans@chromium.org authored 
              Reviewed by Jeremy Orlow.

        IndexedDB: Numeric keys are floats.
        https://bugs.webkit.org/show_bug.cgi?id=50674

        Update layout tests to use floating-point values for keys.

        * storage/indexeddb/keyrange-expected.txt:
        * storage/indexeddb/keyrange.html:
        Make sure creating the keys works.
        * storage/indexeddb/objectstore-cursor-expected.txt:
        * storage/indexeddb/objectstore-cursor.html:
        Make sure retrieving the keys from the DB objectstore works.
2010-12-09  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Numeric keys are floats.
        https://bugs.webkit.org/show_bug.cgi?id=50674

        Use floating point to represent numeric keys,
        add version meta data to the SQLite db,
        and migrate object stores that use integers.

        * bindings/v8/IDBBindingUtilities.cpp:
        (WebCore::createIDBKeyFromValue):
        * bindings/v8/custom/V8IDBKeyCustom.cpp:
        (WebCore::toV8):
        * storage/IDBFactoryBackendImpl.cpp:
        (WebCore::createTables):
        (WebCore::migrateDatabase):
        (WebCore::IDBFactoryBackendImpl::open):
        * storage/IDBKey.cpp:
        (WebCore::IDBKey::IDBKey):
        (WebCore::IDBKey::fromQuery):
        (WebCore::IDBKey::bind):
        (WebCore::IDBKey::bindWithNulls):
        * storage/IDBKey.h:
        (WebCore::IDBKey::create):
        (WebCore::IDBKey::number):
2010-12-09  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Numeric keys are floats.
        https://bugs.webkit.org/show_bug.cgi?id=50674

        Represent numeric keys as floating point values.

        * public/WebIDBKey.h:
        (WebKit::WebIDBKey::WebIDBKey):
        * src/WebIDBKey.cpp:
        (WebKit::WebIDBKey::assign):
        (WebKit::WebIDBKey::number):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      976f357f
  25. 03 Dec, 2010 3 commits
  27. 02 Dec, 2010 3 commits
  29. 01 Dec, 2010 1 commit
    • vangelis@chromium.org's avatar
      2010-11-30 Vangelis Kokkevis <vangelis@chromium.org> · 27b033fd
      vangelis@chromium.org authored 
              Reviewed by Darin Fisher.

        Get the value of the accelerated compositing triggers from the Settings
        class.  This allows setting the triggers via command line flags.
        https://bugs.webkit.org/show_bug.cgi?id=50301

        * public/WebSettings.h:
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::allowedCompositingTriggers):
        * src/WebSettingsImpl.cpp:
        (WebKit::WebSettingsImpl::setAcceleratedCompositingFor3DTransformsEnabled):
        (WebKit::WebSettingsImpl::setAcceleratedCompositingForVideoEnabled):
        (WebKit::WebSettingsImpl::setAcceleratedCompositingForPluginsEnabled):
        (WebKit::WebSettingsImpl::setAcceleratedCompositingForCanvasEnabled):
        (WebKit::WebSettingsImpl::setAcceleratedCompositingForAnimationEnabled):
        * src/WebSettingsImpl.h:
2010-11-30  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Darin Fisher.

        Adds accelerated compositing trigger flags to Settings to allow
        ports to set them via command line flags, etc.
        https://bugs.webkit.org/show_bug.cgi?id=50301

        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        (WebCore::Settings::setAcceleratedCompositingFor3DTransformsEnabled):
        (WebCore::Settings::setAcceleratedCompositingForVideoEnabled):
        (WebCore::Settings::setAcceleratedCompositingForPluginsEnabled):
        (WebCore::Settings::setAcceleratedCompositingForCanvasEnabled):
        (WebCore::Settings::setAcceleratedCompositingForAnimationEnabled):
        * page/Settings.h:
        (WebCore::Settings::acceleratedCompositingFor3DTransformsEnabled):
        (WebCore::Settings::acceleratedCompositingForVideoEnabled):
        (WebCore::Settings::acceleratedCompositingForPluginsEnabled):
        (WebCore::Settings::acceleratedCompositingForCanvasEnabled):
        (WebCore::Settings::acceleratedCompositingForAnimationEnabled):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27b033fd
  31. 30 Nov, 2010 2 commits
    • ojan@chromium.org's avatar
      2010-11-30 Ojan Vafai <ojan@chromium.org> · b14a2c9d
      ojan@chromium.org authored 
              Revert r72876. It caused a ~30% perf regression in chromium's bloat-http test
        https://bugs.webkit.org/show_bug.cgi?id=50288

        2010-11-29 Adam Barth <abarth@webkit.org (:abarth) (r)>
        Reviewed by Darin Adler.
        Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
        https://bugs.webkit.org/show_bug.cgi?id=50182
        A display-isolated URL can only be displayed (e.g., put in an iframe,
        hyperlinked to) by documents from that scheme. In a sense, this is a
        generalization of some of the protections we give file URLs, but
        instead of lumping them all together into one "local" bucket, this
        patch creates a separate bucket for each scheme.
        For a while, I tried using a separate bucket for each origin. That
        would have played nicely with what Blob URLs are trying to do, but some
        "chrome" URL pages rely on being able to display other chrome URL
        pages, even in different origins. For example, the New Tab Page shows
        thumbnails from the "thumbnail" host.
        This patch also removes a bunch of unused code. I've also propagated
        the "deprecated" status of deprecatedCanDisplay to
        deprecatedShouldTreatURLAsLocal because that method has no other
        callers and is really asking for uppercase/lowercase bugs. I dream of
        someday removing these functions.
        page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::canDisplay):
        (WebCore::SecurityOrigin::deprecatedCanDisplay):
        platform/SchemeRegistry.cpp:
        (WebCore::displayIsolatedURLSchemes):
        (WebCore::SchemeRegistry::registerURLSchemeAsLocal):
        (WebCore::SchemeRegistry::deprecatedShouldTreatURLAsLocal):
        (WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal):
        (WebCore::SchemeRegistry::registerURLSchemeAsDisplayIsolated):
        (WebCore::SchemeRegistry::shouldTreatURLSchemeAsDisplayIsolated):
        platform/SchemeRegistry.h:
        2010-11-29 Adam Barth <abarth@webkit.org (:abarth) (r)>
        Reviewed by Darin Adler.
        Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
         https://bugs.webkit.org/show_bug.cgi?id=50182
        This patch adds a Chromium API for registering schemes as
        display-isolated. In a subsequent patch, I'll change the "chrome"
        scheme in Chrome to be display isolated instead of local. That will
        prevent file URLs from linking to chrome URLs.
        public/WebSecurityPolicy.h:
        src/WebSecurityPolicy.cpp:
        (WebKit::WebSecurityPolicy::registerURLSchemeAsDisplayIsolated):

        * page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::canDisplay):
        (WebCore::SecurityOrigin::deprecatedCanDisplay):
        * platform/SchemeRegistry.cpp:
        (WebCore::SchemeRegistry::registerURLSchemeAsLocal):
        (WebCore::SchemeRegistry::removeURLSchemeRegisteredAsLocal):
        (WebCore::SchemeRegistry::localURLSchemes):
        (WebCore::SchemeRegistry::shouldTreatURLAsLocal):
        (WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal):
        * platform/SchemeRegistry.h:
2010-11-30  Ojan Vafai  <ojan@chromium.org>

        Revert r72876. It caused a ~30% perf regression in chromium's bloat-http test
        https://bugs.webkit.org/show_bug.cgi?id=50288

        2010-11-29 Adam Barth <abarth@webkit.org (:abarth) (r)>
        Reviewed by Darin Adler.
        Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
        https://bugs.webkit.org/show_bug.cgi?id=50182
        A display-isolated URL can only be displayed (e.g., put in an iframe,
        hyperlinked to) by documents from that scheme. In a sense, this is a
        generalization of some of the protections we give file URLs, but
        instead of lumping them all together into one "local" bucket, this
        patch creates a separate bucket for each scheme.
        For a while, I tried using a separate bucket for each origin. That
        would have played nicely with what Blob URLs are trying to do, but some
        "chrome" URL pages rely on being able to display other chrome URL
        pages, even in different origins. For example, the New Tab Page shows
        thumbnails from the "thumbnail" host.
        This patch also removes a bunch of unused code. I've also propagated
        the "deprecated" status of deprecatedCanDisplay to
        deprecatedShouldTreatURLAsLocal because that method has no other
        callers and is really asking for uppercase/lowercase bugs. I dream of
        someday removing these functions.
        2010-11-29 Adam Barth <abarth@webkit.org (:abarth) (r)>
        Reviewed by Darin Adler.
        Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
         https://bugs.webkit.org/show_bug.cgi?id=50182
        This patch adds a Chromium API for registering schemes as
        display-isolated. In a subsequent patch, I'll change the "chrome"
        scheme in Chrome to be display isolated instead of local. That will
        prevent file URLs from linking to chrome URLs.

        * public/WebSecurityPolicy.h:
        * src/WebSecurityPolicy.cpp:
2010-11-30  Ojan Vafai  <ojan@chromium.org>

        Revert r72876. It caused a ~30% perf regression in chromium's bloat-http test
        https://bugs.webkit.org/show_bug.cgi?id=50288

        2010-11-29 Adam Barth <abarth@webkit.org (:abarth) (r)>
        Reviewed by Darin Adler.
        Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
        https://bugs.webkit.org/show_bug.cgi?id=50182
        A display-isolated URL can only be displayed (e.g., put in an iframe,
        hyperlinked to) by documents from that scheme. In a sense, this is a
        generalization of some of the protections we give file URLs, but
        instead of lumping them all together into one "local" bucket, this
        patch creates a separate bucket for each scheme.
        For a while, I tried using a separate bucket for each origin. That
        would have played nicely with what Blob URLs are trying to do, but some
        "chrome" URL pages rely on being able to display other chrome URL
        pages, even in different origins. For example, the New Tab Page shows
        thumbnails from the "thumbnail" host.
        This patch also removes a bunch of unused code. I've also propagated
        the "deprecated" status of deprecatedCanDisplay to
        deprecatedShouldTreatURLAsLocal because that method has no other
        callers and is really asking for uppercase/lowercase bugs. I dream of
        someday removing these functions.
        2010-11-29 Adam Barth <abarth@webkit.org (:abarth) (r)>
        Reviewed by Darin Adler.
        Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
         https://bugs.webkit.org/show_bug.cgi?id=50182
        This patch adds a Chromium API for registering schemes as
        display-isolated. In a subsequent patch, I'll change the "chrome"
        scheme in Chrome to be display isolated instead of local. That will
        prevent file URLs from linking to chrome URLs.

        * Api/qwebsecurityorigin.cpp:
        (QWebSecurityOrigin::localSchemes):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73002 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b14a2c9d
    • jochen@chromium.org's avatar
      2010-11-30 Jochen Eisinger <jochen@chromium.org> · 6392a57a
      jochen@chromium.org authored 
              Reviewed by Darin Fisher.

        [chromium] pass webframe to web frame client's cookieJar
        https://bugs.webkit.org/show_bug.cgi?id=50148

        * public/WebFrameClient.h:
        (WebKit::WebFrameClient::cookieJar):
        * src/ChromiumBridge.cpp:
        (WebCore::getCookieJar):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6392a57a
  33. 29 Nov, 2010 4 commits
    • abarth@webkit.org's avatar
      2010-11-29 Adam Barth <abarth@webkit.org> · d84288db
      abarth@webkit.org authored 
              Reviewed by Darin Adler.

        Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
        https://bugs.webkit.org/show_bug.cgi?id=50182

        A display-isolated URL can only be displayed (e.g., put in an iframe,
        hyperlinked to) by documents from that scheme.  In a sense, this is a
        generalization of some of the protections we give file URLs, but
        instead of lumping them all together into one "local" bucket, this
        patch creates a separate bucket for each scheme.

        For a while, I tried using a separate bucket for each origin.  That
        would have played nicely with what Blob URLs are trying to do, but some
        "chrome" URL pages rely on being able to display other chrome URL
        pages, even in different origins.  For example, the New Tab Page shows
        thumbnails from the "thumbnail" host.

        This patch also removes a bunch of unused code.  I've also propagated
        the "deprecated" status of deprecatedCanDisplay to
        deprecatedShouldTreatURLAsLocal because that method has no other
        callers and is really asking for uppercase/lowercase bugs.  I dream of
        someday removing these functions.

        * page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::canDisplay):
        (WebCore::SecurityOrigin::deprecatedCanDisplay):
        * platform/SchemeRegistry.cpp:
        (WebCore::displayIsolatedURLSchemes):
        (WebCore::SchemeRegistry::registerURLSchemeAsLocal):
        (WebCore::SchemeRegistry::deprecatedShouldTreatURLAsLocal):
        (WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal):
        (WebCore::SchemeRegistry::registerURLSchemeAsDisplayIsolated):
        (WebCore::SchemeRegistry::shouldTreatURLSchemeAsDisplayIsolated):
        * platform/SchemeRegistry.h:
2010-11-29  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
        https://bugs.webkit.org/show_bug.cgi?id=50182

        This patch adds a Chromium API for registering schemes as
        display-isolated.  In a subsequent patch, I'll change the "chrome"
        scheme in Chrome to be display isolated instead of local.  That will
        prevent file URLs from linking to chrome URLs.

        * public/WebSecurityPolicy.h:
        * src/WebSecurityPolicy.cpp:
        (WebKit::WebSecurityPolicy::registerURLSchemeAsDisplayIsolated):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72876 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d84288db
    • tkent@chromium.org's avatar
      [Chromium] Add substitution parameters to WebKitClient::queryLocalizedString() · 1284a733
      tkent@chromium.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=50053

Reviewed by Darin Fisher.

* public/WebKitClient.h:
(WebKit::WebKitClient::queryLocalizedString): Add overload functions with
  substitution string parameters, and remove the integer parameter overload.
* src/LocalizedStrings.cpp:
(WebCore::query): Add string parameter overloads, and remove the integer parameter overload.
(WebCore::multipleFileUploadText): Call the string parameter query().
(WebCore::validationMessageTooLongText): Pass the parameters to query().
(WebCore::validationMessageRangeUnderflowText): ditto.
(WebCore::validationMessageRangeOverflowText): ditto.
(WebCore::validationMessageStepMismatchText): ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72844 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1284a733
    • caseq@chromium.org's avatar
      2010-11-29 Andrey Kosyakov <caseq@chromium.org> · 922c14c9
      caseq@chromium.org authored 
              Reviewed by Darin Fisher.

        Web Inspector: [Chromium] Expose extension API to select a node in WebInspector
        Added WebDevToolsAgent::inspect()
        https://bugs.webkit.org/show_bug.cgi?id=49727

        * public/WebDevToolsAgent.h:
        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgentImpl::inspectNode):
        * src/WebDevToolsAgentImpl.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72810 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      922c14c9
    • commit-queue@webkit.org's avatar
      2010-11-29 Bernhard Bauer <bauerb@chromium.org> · b2e85e65
      commit-queue@webkit.org authored 
              Reviewed by Jeremy Orlow.

        Remove databaseFileName from IDBFactoryBackendImpl
        https://bugs.webkit.org/show_bug.cgi?id=50150

        No new tests, since functionality is unchanged.

        * storage/IDBFactoryBackendImpl.cpp:
        (WebCore::openSQLiteDatabase):
        * storage/IDBFactoryBackendImpl.h:
2010-11-29  Bernhard Bauer  <bauerb@chromium.org>

        Reviewed by Jeremy Orlow.

        Remove databaseFileName from WebIDBFactory
        https://bugs.webkit.org/show_bug.cgi?id=50150

        * WebKit.gyp:
        * public/WebIDBFactory.h:
        (WebKit::WebIDBFactory::open):
        * src/WebIDBFactory.cpp: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72794 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2e85e65
  35. 26 Nov, 2010 5 commits
    • andreip@google.com's avatar
      2010-11-26 Andrei Popescu <andreip@google.com> · 7e718832
      andreip@google.com authored 
              Reviewed by Jeremy Orlow.

        IDBDatabase and IDBObjectStore remove* methods should be renamed to delete*
        https://bugs.webkit.org/show_bug.cgi?id=50113

        * storage/indexeddb/objectstore-basics-expected.txt:
        * storage/indexeddb/objectstore-basics.html:
        * storage/indexeddb/objectstore-removeobjectstore-expected.txt:
        * storage/indexeddb/objectstore-removeobjectstore.html:
        * storage/indexeddb/resources/shared.js:
        (deleteAllObjectStores):
        * storage/indexeddb/transaction-basics-expected.txt:
        * storage/indexeddb/transaction-basics.html:

2010-11-26  Andrei Popescu  <andreip@google.com>

        Reviewed by Jeremy Orlow.

        IDBDatabase and IDBObjectStore remove* methods should be renamed to delete*
        https://bugs.webkit.org/show_bug.cgi?id=50113

        Modified exisiting layout tests to cover this change.

        * storage/IDBDatabase.cpp:
        (WebCore::IDBDatabase::deleteObjectStore):
        * storage/IDBDatabase.h:
        * storage/IDBDatabase.idl:
        * storage/IDBDatabaseBackendImpl.cpp:
        (WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
        (WebCore::IDBDatabaseBackendImpl::deleteObjectStoreInternal):
        * storage/IDBDatabaseBackendImpl.h:
        * storage/IDBDatabaseBackendInterface.h:
        * storage/IDBObjectStore.cpp:
        (WebCore::IDBObjectStore::deleteFunction):
        (WebCore::IDBObjectStore::deleteIndex):
        * storage/IDBObjectStore.h:
        * storage/IDBObjectStore.idl:
        * storage/IDBObjectStoreBackendImpl.cpp:
        (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
        (WebCore::IDBObjectStoreBackendImpl::deleteInternal):
        (WebCore::IDBObjectStoreBackendImpl::deleteIndex):
        (WebCore::IDBObjectStoreBackendImpl::deleteIndexInternal):
        * storage/IDBObjectStoreBackendImpl.h:
        * storage/IDBObjectStoreBackendInterface.h:

2010-11-26  Andrei Popescu  <andreip@google.com>

        Reviewed by Jeremy Orlow.

        IDBDatabase and IDBObjectStore remove* methods should be renamed to delete*
        https://bugs.webkit.org/show_bug.cgi?id=50113

        * public/WebIDBDatabase.h:
        (WebKit::WebIDBDatabase::deleteObjectStore):
        (WebKit::WebIDBDatabase::removeObjectStore):
        * public/WebIDBObjectStore.h:
        (WebKit::WebIDBObjectStore::remove):
        (WebKit::WebIDBObjectStore::deleteFunction):
        (WebKit::WebIDBObjectStore::deleteIndex):
        * src/IDBDatabaseProxy.cpp:
        (WebCore::IDBDatabaseProxy::deleteObjectStore):
        * src/IDBDatabaseProxy.h:
        * src/IDBObjectStoreProxy.cpp:
        (WebCore::IDBObjectStoreProxy::deleteFunction):
        (WebCore::IDBObjectStoreProxy::deleteIndex):
        * src/IDBObjectStoreProxy.h:
        * src/WebIDBDatabaseImpl.cpp:
        (WebKit::WebIDBDatabaseImpl::deleteObjectStore):
        * src/WebIDBDatabaseImpl.h:
        * src/WebIDBObjectStoreImpl.cpp:
        (WebKit::WebIDBObjectStoreImpl::deleteFunction):
        (WebKit::WebIDBObjectStoreImpl::deleteIndex):
        * src/WebIDBObjectStoreImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72771 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e718832
    • jorlow@chromium.org's avatar
      2010-11-26 Jeremy Orlow <jorlow@chromium.org> · 1ffedf35
      jorlow@chromium.org authored 
              Reviewed by Steve Block.

        Make IDBKeyRange match the spec
        https://bugs.webkit.org/show_bug.cgi?id=50105

        Remove flags and instead add two booleans for being open.
        Change left to lower and right to upper everywhere.

        * storage/indexeddb/constants-expected.txt:
        * storage/indexeddb/constants.html:
        * storage/indexeddb/index-cursor.html:
        * storage/indexeddb/keyrange-expected.txt:
        * storage/indexeddb/keyrange.html:
        * storage/indexeddb/objectstore-cursor.html:
        * storage/indexeddb/open-cursor.html:
        * storage/indexeddb/tutorial.html:
2010-11-26  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        Make IDBKeyRange match the spec
        https://bugs.webkit.org/show_bug.cgi?id=50105

        Remove flags and instead add two booleans for being open.
        Change left to lower and right to upper everywhere.

        * storage/IDBIndexBackendImpl.cpp:
        (WebCore::IDBIndexBackendImpl::openCursorInternal):
        * storage/IDBKey.cpp:
        (WebCore::IDBKey::lowerCursorWhereFragment):
        (WebCore::IDBKey::upperCursorWhereFragment):
        * storage/IDBKey.h:
        * storage/IDBKeyRange.cpp:
        (WebCore::IDBKeyRange::IDBKeyRange):
        (WebCore::IDBKeyRange::only):
        (WebCore::IDBKeyRange::lowerBound):
        (WebCore::IDBKeyRange::upperBound):
        (WebCore::IDBKeyRange::bound):
        (WebCore::IDBKeyRange::lowerWhereClauseComparisonOperator):
        (WebCore::IDBKeyRange::upperWhereClauseComparisonOperator):
        * storage/IDBKeyRange.h:
        (WebCore::IDBKeyRange::create):
        (WebCore::IDBKeyRange::lower):
        (WebCore::IDBKeyRange::upper):
        (WebCore::IDBKeyRange::lowerOpen):
        (WebCore::IDBKeyRange::upperOpen):
        * storage/IDBKeyRange.idl:
        * storage/IDBObjectStoreBackendImpl.cpp:
        (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
2010-11-26  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        Make IDBKeyRange match the spec
        https://bugs.webkit.org/show_bug.cgi?id=50105

        Remove flags and instead add two booleans for being open.
        Change left to lower and right to upper everywhere.

        * public/WebIDBKeyRange.h:
        (WebKit::WebIDBKeyRange::WebIDBKeyRange):
        * src/WebIDBKeyRange.cpp:
        (WebKit::WebIDBKeyRange::assign):
        (WebKit::WebIDBKeyRange::left):
        (WebKit::WebIDBKeyRange::right):
        (WebKit::WebIDBKeyRange::lower):
        (WebKit::WebIDBKeyRange::upper):
        (WebKit::WebIDBKeyRange::lowerOpen):
        (WebKit::WebIDBKeyRange::upperOpen):
        (WebKit::WebIDBKeyRange::flags):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ffedf35
    • jorlow@chromium.org's avatar
      2010-11-25 Jeremy Orlow <jorlow@chromium.org> · b89d0c36
      jorlow@chromium.org authored 
              Reviewed by Steve Block.

        Clean up IDBDatabase.transaction and add checks to IDBTransaction.objectStore
        https://bugs.webkit.org/show_bug.cgi?id=50081

        * storage/indexeddb/create-and-remove-object-store-expected.txt: Renamed from LayoutTests/storage/indexeddb/createAndRemoveObjectStore-expected.txt.
        * storage/indexeddb/create-and-remove-object-store.html: Renamed from LayoutTests/storage/indexeddb/createAndRemoveObjectStore.html.
        * storage/indexeddb/create-object-store-options-expected.txt:
        * storage/indexeddb/create-object-store-options.html:
        * storage/indexeddb/resources/shared.js:
        (evalAndExpectException):
        * storage/indexeddb/transaction-and-objectstore-calls-expected.txt: Added.
        * storage/indexeddb/transaction-and-objectstore-calls.html: Added.
        * storage/indexeddb/tutorial.html:
2010-11-25  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        Clean up IDBDatabase.transaction and add checks to IDBTransaction.objectStore
        https://bugs.webkit.org/show_bug.cgi?id=50081

        IDBDatabase.transaction should use the new optional OptionsObject way
        of taking optional paramters. Modify that object to get numbers and
        domStringLists from it. Verify that any requested resources exist and
        return an exception if not.

        When IDBTransaction.objectStore is called, verify that it's one of the
        requested resources. Also verify that it still exists. Plumb the
        exception code to make this work.

        Tests: storage/indexeddb/create-and-remove-object-store.html
               storage/indexeddb/transaction-and-objectstore-calls.html

        * bindings/v8/OptionsObject.cpp:
        (WebCore::OptionsObject::getKeyInteger):
        (WebCore::OptionsObject::getKeyString):
        (WebCore::OptionsObject::getKeyDOMStringList):
        * bindings/v8/OptionsObject.h:
        * storage/IDBDatabase.cpp:
        (WebCore::IDBDatabase::createObjectStore):
        (WebCore::IDBDatabase::transaction):
        * storage/IDBDatabase.h:
        (WebCore::IDBDatabase::transaction):
        * storage/IDBDatabase.idl:
        * storage/IDBDatabaseBackendImpl.cpp:
        (WebCore::IDBDatabaseBackendImpl::transaction):
        * storage/IDBTransaction.cpp:
        (WebCore::IDBTransaction::objectStore):
        * storage/IDBTransactionBackendImpl.cpp:
        (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
        (WebCore::IDBTransactionBackendImpl::objectStore):
        * storage/IDBTransactionBackendImpl.h:
        * storage/IDBTransactionBackendInterface.h:
2010-11-25  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        Clean up IDBDatabase.transaction and add checks to IDBTransaction.objectStore
        https://bugs.webkit.org/show_bug.cgi?id=50081

        Plumb IDBTransaction.objectStore's exception code.

        * public/WebIDBTransaction.h:
        (WebKit::WebIDBTransaction::objectStore):
        * src/IDBDatabaseProxy.cpp:
        (WebCore::IDBDatabaseProxy::transaction):
        * src/IDBTransactionBackendProxy.cpp:
        (WebCore::IDBTransactionBackendProxy::objectStore):
        * src/IDBTransactionBackendProxy.h:
        * src/WebIDBDatabaseImpl.cpp:
        (WebKit::WebIDBDatabaseImpl::createObjectStore):
        (WebKit::WebIDBDatabaseImpl::transaction):
        * src/WebIDBTransactionImpl.cpp:
        (WebKit::WebIDBTransactionImpl::objectStore):
        * src/WebIDBTransactionImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72765 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b89d0c36
    • hans@chromium.org's avatar
      2010-11-26 Hans Wennborg <hans@chromium.org> · dccbdc64
      hans@chromium.org authored 
              Reviewed by Jeremy Orlow.

        IndexedDB: Rename IDBDatabase.objectStores to objectStoreNames
        https://bugs.webkit.org/show_bug.cgi?id=50102

        Update layout tests to use the new name.

        * storage/indexeddb/database-basics-expected.txt:
        * storage/indexeddb/database-basics.html:
        * storage/indexeddb/database-quota-expected.txt:
        * storage/indexeddb/database-quota.html:
        * storage/indexeddb/objectstore-basics-expected.txt:
        * storage/indexeddb/objectstore-basics.html:
        * storage/indexeddb/resources/shared.js:
        (deleteAllObjectStores):
        * storage/indexeddb/transaction-basics-expected.txt:
        * storage/indexeddb/transaction-basics.html:
        * storage/indexeddb/tutorial.html:
2010-11-26  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Rename IDBDatabase.objectStores to objectStoreNames
        https://bugs.webkit.org/show_bug.cgi?id=50102

        Rename as per the spec: http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#database-interface

        * manual-tests/indexeddb-persists.html:
        * storage/IDBDatabase.h:
        (WebCore::IDBDatabase::objectStoreNames):
        * storage/IDBDatabase.idl:
        * storage/IDBDatabaseBackendImpl.cpp:
        (WebCore::IDBDatabaseBackendImpl::objectStoreNames):
        (WebCore::IDBDatabaseBackendImpl::setVersion):
        (WebCore::IDBDatabaseBackendImpl::transaction):
        * storage/IDBDatabaseBackendImpl.h:
        * storage/IDBDatabaseBackendInterface.h:
2010-11-26  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Rename IDBDatabase.objectStores to objectStoreNames
        https://bugs.webkit.org/show_bug.cgi?id=50102

        Rename as per the spec: http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#database-interface

        * public/WebIDBDatabase.h:
        (WebKit::WebIDBDatabase::objectStores):
        (WebKit::WebIDBDatabase::objectStoreNames):
        * src/IDBDatabaseProxy.cpp:
        (WebCore::IDBDatabaseProxy::objectStoreNames):
        * src/IDBDatabaseProxy.h:
        * src/WebIDBDatabaseImpl.cpp:
        (WebKit::WebIDBDatabaseImpl::objectStoreNames):
        * src/WebIDBDatabaseImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72754 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dccbdc64
    • andreip@google.com's avatar
      Remove description · 40483f54
      andreip@google.com authored 
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72753 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40483f54
  37. 25 Nov, 2010 1 commit
    • jorlow@chromium.org's avatar
      2010-11-25 Jeremy Orlow <jorlow@chromium.org> · 188ec8b9
      jorlow@chromium.org authored 
              Reviewed by Steve Block.

        Add an OptionsObject class for IndexedDB (and later Geolocation)
        https://bugs.webkit.org/show_bug.cgi?id=50030

        * storage/indexeddb/create-object-store-options-expected.txt: Added.
        * storage/indexeddb/create-object-store-options.html: Added.
        * storage/indexeddb/tutorial.html:
2010-11-25  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        Add an OptionsObject class for IndexedDB (and later Geolocation)
        https://bugs.webkit.org/show_bug.cgi?id=50030

        Geolocation and IndexedDB both have the concept of an optional
        parameter that has various options supplied with it.  In
        Geolocation this was done with custom bindings, but I'm trying to
        avoid that for IndexedDB.

        This first patch implements it in V8 and makes createObjectStore use it.
        The next patch will cover Geolocation and JSC.

        Test: storage/indexeddb/create-object-store-options.html

        * WebCore.gypi:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/scripts/test/CPP/WebDOMTestObj.cpp:
        (WebDOMTestObj::optionsObject):
        * bindings/scripts/test/CPP/WebDOMTestObj.h:
        * bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
        * bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
        * bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
        * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
        (webkit_dom_test_obj_options_object):
        * bindings/scripts/test/GObject/WebKitDOMTestObj.h:
        * bindings/scripts/test/JS/JSTestObj.cpp:
        (WebCore::jsTestObjPrototypeFunctionOptionsObject):
        * bindings/scripts/test/JS/JSTestObj.h:
        * bindings/scripts/test/ObjC/DOMTestObj.h:
        * bindings/scripts/test/ObjC/DOMTestObj.mm:
        (-[DOMTestObj optionsObject:ooo:]):
        * bindings/scripts/test/TestObj.idl:
        * bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
        (WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
        * bindings/scripts/test/V8/V8TestObj.cpp:
        (WebCore::TestObjInternal::optionsObjectCallback):
        * bindings/v8/OptionsObject.cpp: Added.
        (WebCore::OptionsObject::OptionsObject):
        (WebCore::OptionsObject::~OptionsObject):
        (WebCore::OptionsObject::operator=):
        (WebCore::OptionsObject::undefinedOrNull):
        (WebCore::OptionsObject::getKeyBool):
        (WebCore::OptionsObject::getKeyString):
        (WebCore::OptionsObject::getKey):
        * bindings/v8/OptionsObject.h:
        * bindings/js/OptionsObject.h:
        * storage/IDBDatabase.cpp:
        (WebCore::IDBDatabase::createObjectStore):
        * storage/IDBDatabase.h:
        (WebCore::IDBDatabase::createObjectStore):
        * storage/IDBDatabase.idl:
2010-11-25  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        Add exception code to WebIDBTransaction::objectStore
        https://bugs.webkit.org/show_bug.cgi?id=50030

        * public/WebIDBTransaction.h:
        (WebKit::WebIDBTransaction::objectStore):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      188ec8b9
  39. 24 Nov, 2010 1 commit
  41. 23 Nov, 2010 1 commit