- 20 May, 2010 33 commits
-
-
bfulgham@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=39329 Reviewed by Adam Roben. Cairo does not properly deal with Windows HDCs that have been scaled using MM_ANISOTROPIC mapping mode, and a WindowExt and ViewportExt setting. (see http://bugs.freedesktop.org/show_bug.cgi?id=28161) Instead, reset the HDC's WorldTransform to be unscaled, then scale the cairo context to the desired scaling, and perform the drawing operation. * WebFrame.cpp: (WebFrame::drawHeader): Use pre-positioned context to simplify this method. (WebFrame::drawFooter): Use pre-positioned context to simplify this method. (WebFrame::spoolPage): Revise scaling logic to turn off HDC scaling, and scale using only Cairo. Revert scaling at end so that user-defined GDI-based routines (e.g., header/footer) will draw in the right position. (WebFrame::spoolPages): Identify print preview case, and retrieve scaling factors from preview context. Set the Cairo context to use these factors during the spoolPage operation. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59855 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
Remove code that fetched, but did nothing useful with, a CFDictionary in MediaPlayerPrivateQuickTimeVisualContext I also removed the code in QTPixelBuffer that vended the dictionary. Fixes <http://webkit.org/b/39435> <rdar://problem/8009278> QTPixelBuffer passes CFDictionaries across the DLL boundary, which can lead to crashes Reviewed by Darin Adler. * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::retrieveCurrentImage): Deleted code that fetched the attachments dictionary, which was never used other than to pass it to CFRetain/CFRelease, which could be enough to cause a crash due to incompatible copies of CoreFoundation.dll. * platform/graphics/win/QTMovieVisualContext.h: Added a now-needed forward declaration. * platform/graphics/win/QTPixelBuffer.cpp: * platform/graphics/win/QTPixelBuffer.h: Removed the now-unused attachments function. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59854 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
Fixes <http://webkit.org/b/39432> <rdar://problem/8008992> Reviewed by Ada Chan * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::QTCFDictionaryCreateWithDataCallback): Use a RetainPtr to hold the CFData we allocate so it will get released when this function is exited. Also pass kCFAllocatorNull as the bytes deallocator to CFDataCreateWithBytesNoCopy so that CF doesn't try to deallocate the bytes we pass to it. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59853 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrobinson@webkit.org authored
Reviewed by Ojan Vafai. editingBehavior settings needs to be set back to a reasonable default between tests https://bugs.webkit.org/show_bug.cgi?id=39433 Revert the changes from r59840 to this test until there is a method in the WebKit APIs to consistently reset the editingBehavior setting to a reasonable default. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59852 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jianli@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=39437 Reviewed by David Levin. * dom/CrossThreadTask.h: (WebCore::): (WebCore::CrossThreadTask1::create): (WebCore::CrossThreadTask1::CrossThreadTask1): (WebCore::CrossThreadTask2::create): (WebCore::CrossThreadTask2::CrossThreadTask2): (WebCore::CrossThreadTask3::create): (WebCore::CrossThreadTask3::CrossThreadTask3): (WebCore::CrossThreadTask4::create): (WebCore::CrossThreadTask4::CrossThreadTask4): (WebCore::CrossThreadTask5::create): (WebCore::CrossThreadTask5::CrossThreadTask5): (WebCore::CrossThreadTask6::create): (WebCore::CrossThreadTask6::CrossThreadTask6): (WebCore::CrossThreadTask7::create): (WebCore::CrossThreadTask7::CrossThreadTask7): (WebCore::CrossThreadTask8::create): (WebCore::CrossThreadTask8::CrossThreadTask8): (WebCore::createCallbackTask): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59851 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
victorw@chromium.org authored
Unreviewed. Update test expectations from chromium. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59850 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jianli@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=39135 Reviewed by David Levin. WebCore: * GNUmakefile.am: * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * dom/CrossThreadTask.h: Renamed from WebCore/workers/GenericWorkerTask.h. * html/FileStreamProxy.cpp: * loader/WorkerThreadableLoader.cpp: * websockets/WorkerThreadableWebSocketChannel.cpp: * workers/DefaultSharedWorkerRepository.cpp: * workers/WorkerMessagingProxy.cpp: * workers/WorkerScriptLoader.cpp: WebKit/chromium: * src/WebSharedWorkerImpl.cpp: * src/WebWorkerBase.cpp: * src/WebWorkerClientImpl.cpp: * src/WebWorkerImpl.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59849 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
adele@apple.com authored
Reviewed by Mark Rowe. * css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::cssRules): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59848 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
steveblock@google.com authored
Reviewed by Jeremy Orlow. Provide bindings for DeviceOrientation https://bugs.webkit.org/show_bug.cgi?id=39210 Adds ENABLE_DEVICE_ORIENTATION to XCode project file, always disabled. * Configurations/FeatureDefines.xcconfig: 2010-05-20 Steve Block <steveblock@google.com> Reviewed by Jeremy Orlow. Provide bindings for DeviceOrientation https://bugs.webkit.org/show_bug.cgi?id=39210 Adds ENABLE_DEVICE_ORIENTATION to VisualStudio project files, always disabled. * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: 2010-05-20 Steve Block <steveblock@google.com> Reviewed by Jeremy Orlow. Provide bindings for DeviceOrientation https://bugs.webkit.org/show_bug.cgi?id=39210 Adds ENABLE_DEVICE_ORIENTATION to XCode project file, always disabled. * Configurations/FeatureDefines.xcconfig: 2010-05-20 Steve Block <steveblock@google.com> Reviewed by Jeremy Orlow. Provide bindings for DeviceOrientation https://bugs.webkit.org/show_bug.cgi?id=39210 Tests: fast/dom/DeviceOrientation/window-property.html fast/dom/Window/window-properties-on-device-orientation.html Adds bindings for DeviceOrientation as defined in http://dev.w3.org/geo/api/spec-source-orientation.html This is guarded by ENABLE(DEVICE_ORIENTATION) which is currently disabled on all platforms but Android. * Android.derived.jscbindings.mk: * Android.derived.v8bindings.mk: * Android.mk: * Configurations/FeatureDefines.xcconfig: * DerivedSources.cpp: * DerivedSources.make: * GNUmakefile.am: * WebCore.gypi: * WebCore.pri: * WebCore.pro: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSEventCustom.cpp: (WebCore::toJS): * bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8): * dom/DeviceOrientationEvent.cpp: Added. (WebCore::DeviceOrientationEvent::DeviceOrientationEvent): (WebCore::DeviceOrientationEvent::initDeviceOrientationEvent): * dom/DeviceOrientationEvent.h: Added. (WebCore::DeviceOrientationEvent::create): (WebCore::DeviceOrientationEvent::alpha): (WebCore::DeviceOrientationEvent::beta): (WebCore::DeviceOrientationEvent::gamma): (WebCore::DeviceOrientationEvent::isDeviceOrientationEvent): * dom/DeviceOrientationEvent.idl: Added. * dom/Event.cpp: (WebCore::Event::isDeviceOrientationEvent): * dom/Event.h: * dom/EventNames.h: * page/DOMWindow.h: * page/DOMWindow.idl: 2010-05-20 Steve Block <steveblock@google.com> Reviewed by Jeremy Orlow. Provide bindings for DeviceOrientation https://bugs.webkit.org/show_bug.cgi?id=39210 Modifies existing fast/dom/Window tests to skip window.ondeviceorientation until it is widely supported. Adds new fast/dom/Window/window-properties-on-device-orientation.html to test type and presence of window.ondeviceorientation. Adds new fast/dom/DeviceOrientation directory and initial test. Adds all DeviceOrientation tests to all skipped lists. * fast/dom/DeviceOrientation: Added. * fast/dom/DeviceOrientation/script-tests: Added. * fast/dom/DeviceOrientation/script-tests/TEMPLATE.html: Added. * fast/dom/DeviceOrientation/script-tests/window-property.js: Added. (hasOnDeviceOrientationProperty): * fast/dom/DeviceOrientation/window-property-expected.txt: Added. * fast/dom/DeviceOrientation/window-property.html: Added. * fast/dom/Window/script-tests/window-property-descriptors.js: * fast/dom/Window/window-properties-on-device-orientation-expected.txt: Added. * fast/dom/Window/window-properties-on-device-orientation.html: Added. * fast/dom/Window/window-properties.html: * platform/chromium/test_expectations.txt: * platform/gtk/Skipped: * platform/mac/Skipped: * platform/qt/Skipped: * platform/win/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59847 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kenneth@webkit.org authored
consistent with the Mac OS X platform. Rubberstamped by Antti Koivisto. * page/qt/EventHandlerQt.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59846 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrobinson@webkit.org authored
Unreviewed. Touch WebKit.idl to ensure that interfaces rebuild. * Interfaces/WebKit.idl: Touched. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59845 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrobinson@webkit.org authored
Reviewed by Ojan Vafai. editing/selection/extend-selection-after-double-click.html crashes on the Leopard Intel release bot https://bugs.webkit.org/show_bug.cgi?id=39431 * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setEditingBehavior): Prevent a double-free by not having this variable be in the auto-release pool. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59844 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrobinson@webkit.org authored
Reviewed by Adam Roben. Fix the Windows build and move new IDL declarations to the bottom of the file. * Interfaces/IWebPreferences.idl: Move new API to the bottom of the IDL file to prevent vtable mismatch. * WebPreferences.cpp: (WebPreferences::setEditingBehavior): Change the type of the parameter to setEditingBehavior to the proper type. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59843 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrobinson@webkit.org authored
Unreviewed. Fix the Windows build. * WebView.cpp: (WebView::notifyPreferencesChanged): Change behavior to 'editingBehavior'. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59842 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tkent@chromium.org authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrobinson@webkit.org authored
Reviewed by Ojan Vafai. Expose the editing behavior setting in DRT to test all editing code paths https://bugs.webkit.org/show_bug.cgi?id=38603 * editing/selection/extend-selection-after-double-click.html: Use the new DRT support for changing editing behavior. * editing/selection/extend-selection-after-double-click-expected.txt: Update expected results to reflect both behaviors. 2010-05-20 Martin Robinson <mrobinson@webkit.org> Reviewed by Ojan Vafai. Expose the editing behavior setting in DRT to test all editing code paths https://bugs.webkit.org/show_bug.cgi?id=38603 * public/WebSettings.h: (WebKit::WebSettings::): Added an enum for EditingBehavior types. * src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setEditingBehavior): Added. * src/WebSettingsImpl.h: 2010-05-20 Martin Robinson <mrobinson@webkit.org> Reviewed by Ojan Vafai. Expose the editing behavior setting in DRT to test all editing code paths https://bugs.webkit.org/show_bug.cgi?id=38603 * WebView/WebFrame.mm: (core): * WebView/WebFrameInternal.h: Added a conversion method from the API enum to the WebCore enum. * WebView/WebPreferenceKeysPrivate.h: Added a preference key for the new setting. * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Initialize the EditingBehavior to Mac style. (-[WebPreferences editingBehavior]): Added. (-[WebPreferences setEditingBehavior:]): Added. * WebView/WebPreferencesPrivate.h: Added the new API points to the private API. * WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Set the editing behavior via the WebPreferences setting. 2010-05-20 Martin Robinson <mrobinson@webkit.org> Reviewed by Ojan Vafai. Expose the editing behavior setting in DRT to test all editing code paths https://bugs.webkit.org/show_bug.cgi?id=38603 Expose the EditingBehavior setting in the Windows API. * Interfaces/IWebPreferences.idl: Add the API point for setting the editing behavior. * WebPreferenceKeysPrivate.h: Add a key for the editing behavior setting. * WebPreferences.cpp: (WebPreferences::editingBehavior): Added. (WebPreferences::setEditingBehavior): Added. * WebPreferences.h: Add method declarations. * WebView.cpp: (WebView::notifyPreferencesChanged): Update the WebCore setting based on the WebPreferences setting. 2010-05-20 Martin Robinson <mrobinson@webkit.org> Reviewed by Ojan Vafai. Expose the editing behavior setting in DRT to test all editing code paths https://bugs.webkit.org/show_bug.cgi?id=38603 * DumpRenderTree/LayoutTestController.cpp: (setEditingBehaviorCallback): Added. (LayoutTestController::staticFunctions): Expose the setEditingBehaviorCallback function. * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/chromium/LayoutTestController.cpp: Add callback method for setting editing behavior. * DumpRenderTree/chromium/LayoutTestController.h: Declaration for this method. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setEditingBehavior): Implementation of editing behavior control. * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setEditingBehavior): Ditto * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setEditingBehavior): Added stub implementation of editing behavior control. * DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::setEditingBehavior): Add slot for controlling editor behavior. * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setEditingBehavior): Implementation of editing behavior control. * DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setEditingBehavior): Added stub implementation of editing behavior control. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59840 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tkent@chromium.org authored
Reviewed by Eric Seidel. [DRT/Chromium] Increase the time out value https://bugs.webkit.org/show_bug.cgi?id=39203 Change the time out value of Chromium DRT to 30 seconds, which is the same as other ports. If a DRT process exits before new-run-webkit-tests detects time out, new-run-webkit-tests assumes the DRT process crashed. * DumpRenderTree/chromium/TestShell.cpp: (TestShell::layoutTestTimeout): Change the time out value from 10 seconds to 30 seconds. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59839 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [Qt] WINSCW compile fix for qwebframe test https://bugs.webkit.org/show_bug.cgi?id=38722 WINSCW cannot determine template type up the hierarchy to common base class. * tests/qwebframe/tst_qwebframe.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59838 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hausmann@webkit.org authored
Reviewed by Simon Hausmann. When we apply the transform of the parent painter to the painter of the transparency layer, we adopt its coordinate system, thus offset should not be in page coordinates, but in the coordinate system of the parent painter. * platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::TransparencyLayer::TransparencyLayer): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59837 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. Remove unused "old style" private APIs These symbols were introduced after QtWebKit v4.6 so no-one should be using them * WebCoreSupport/DumpRenderTreeSupportQt.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59836 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
agl@chromium.org authored
Reviewed by David Levin. [chromium] Avoid crash when msttcorefonts aren't provided https://bugs.webkit.org/show_bug.cgi?id=39015 http://code.google.com/p/chromium/issues/detail?id=43831 * platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::createFontPlatformData): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59835 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zherczeg@webkit.org authored
* platform/qt/svg/filters/feLighting-crash-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59834 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Simon Hausmann. [Qt] QWebPage::inputMethodQuery() returns wrong values for Qt::ImCursorPosition, Qt::ImAnchorPosition https://bugs.webkit.org/show_bug.cgi?id=38779 The earlier implementation was written with the assumption that in this scenario the anchor position always corresponds to the START index and that the current cursor position always corresponds to the END index in WebKit. Updated the implementation of QWebPage::inputMethodQuery(Qt::ImCursorPosition) and QWebPage::inputMethodQuery(Qt::ImAnchorPosition) for the case where the Editor is not in composition mode. In the non-composition mode, the Anchor and the Current cursor positions correspond to the Base and Extent position offsets in WebKit. Also added the auto-tests for the RIGHT to LEFT and LEFT to RIGHT selections. * Api/qwebpage.cpp: (QWebPage::inputMethodQuery): Now returning correct values for Qt::ImCursorPosition and Qt::ImAnchorPosition when the Editor is not in composition mode. * tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods): Added auto-tests for RIGHT to LEFT and LEFT to RIGHT selections git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59833 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zherczeg@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=39004 Reviewed by Dirk Schulze. Make FELighting::apply() similar to other filters' applies to avoid an assertion fail in putUnmultipliedImageData(), when effectDrawingRect has negative location (x or y is less than 0). Test: svg/filters/feLighting-crash.svg * svg/graphics/filters/SVGFELighting.cpp: (WebCore::FELighting::apply): LayoutTests: In case of lighting SVG effects, a wider output rectangle than the input image size should not cause crash. https://bugs.webkit.org/show_bug.cgi?id=39004 Reviewed by Dirk Schulze. * platform/mac/svg/filters/feLighting-crash-expected.checksum: Added. * platform/mac/svg/filters/feLighting-crash-expected.png: Added. * platform/mac/svg/filters/feLighting-crash-expected.txt: Added. * platform/qt/svg/filters/feLighting-crash-expected.txt: Added. * svg/filters/feLighting-crash.svg: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59832 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [Qt] Skipping popup focus test for maemo https://bugs.webkit.org/show_bug.cgi?id=39314 Skipping popup focus test for maemo in qwebframe auto test. The test method tst_QWebFrame::popupFocus() was testing popup focus AND input field focus. The input field focus has been removed from the method popupFocus() and a new test method named inputFieldFocus() has been added. Finally the test method popupFocus() has been skipped for maemo. * tests/qwebframe/tst_qwebframe.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59831 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
cevans@google.com authored
Marking myself as a committer. * Scripts/webkitpy/common/config/committers.py: Add cevans@google.com. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59830 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
cjerdonek@webkit.org authored
Reviewed by Eric Seidel. Modified FrameLoader::urlSelected() to accept a KURL instead of a ResourceRequest. https://bugs.webkit.org/show_bug.cgi?id=39320 Since ResourceRequest has non-explicit single-parameter constructors for String and KURL, urlSelected() previously accepted any of String, KURL, and ResourceRequest. This revision changes urlSelected() to accept only a KURL to make the API tighter and easier to refactor. No new functionality, so no new tests. * loader/FrameLoader.cpp: (WebCore::FrameLoader::urlSelected): - Changed the public overload to accept a KURL instead of a ResourceRequest. * loader/FrameLoader.h: - Changed the public overload to accept a KURL instead of a ResourceRequest. * wml/WMLAElement.cpp: (WebCore::WMLAElement::defaultEventHandler): - Updated the call to urlSelected(). 2010-05-20 Chris Jerdonek <cjerdonek@webkit.org> Reviewed by Eric Seidel. Modified FrameLoader::urlSelected() to accept a KURL instead of a ResourceRequest. https://bugs.webkit.org/show_bug.cgi?id=39320 Since ResourceRequest has non-explicit single-parameter constructors for String and KURL, urlSelected() previously accepted any of String, KURL, and ResourceRequest. This revision changes urlSelected() to accept only a KURL to make the API tighter and easier to refactor. * WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle): - Updated the call to urlSelected(). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59829 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
morrita@google.com authored
Reviewed by Kent Tamura. 2x execCommand ReadAV@NULL https://bugs.webkit.org/show_bug.cgi?id=35791 This test passes if it doesn't crash. * editing/execCommand/35791-expected.txt: Added. * editing/execCommand/35791.html: Added. 2010-05-20 MORITA Hajime <morrita@google.com> Reviewed by Kent Tamura. 2x execCommand ReadAV@NULL https://bugs.webkit.org/show_bug.cgi?id=35791 In applyBlockStyle(), a node which is referred from nextParagraphStart sometimes removed from the document and goes orphan, and that causes an assertion failed. This is because moveParagraphs() replaces the node with a new one with some new styles applied. So we re-compute nextParagraphStart in that case. Test: editing/execCommand/35791.html * dom/Position.h: (WebCore::Position::isOrphan): * editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle): * editing/VisiblePosition.h: (WebCore::VisiblePosition::isOrphan): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59828 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hausmann@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=37273 Reviewed by Tor Arne Vestbo. * QtTestBrowser/QtTestBrowser.pro: Build QtLauncher as bundle in package builds git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59827 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
steveblock@google.com authored
Reviewed by Eric Seidel. PluginView contains JSC-specific code https://bugs.webkit.org/show_bug.cgi?id=38907 Build fix only, no new tests. * plugins/PluginView.cpp: (WebCore::PluginView::start): (WebCore::PluginView::stop): (WebCore::PluginView::performRequest): * plugins/PluginView.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59826 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
philn@webkit.org authored
Reviewed by Eric Seidel. [GStreamer] enable gst support if USE_GSTREAMER macro is defined https://bugs.webkit.org/show_bug.cgi?id=39205 Include gstreamer private player in the build when the USE_GSTREAMER macro is enabled. * platform/graphics/MediaPlayer.cpp: (WebCore::installedMediaEngines): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59825 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ukai@chromium.org authored
* Scripts/new-run-webkit-websocketserver: options is named parameter for factory.get(). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59824 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ukai@chromium.org authored
Reviewed by Shinichiro Hamaji. Chromium: Add --chromium option to new-run-webkit-websocketserver https://bugs.webkit.org/show_bug.cgi?id=37664 Missed to pass options to factory.get() in r59595 * Scripts/new-run-webkit-websocketserver: Pass options to factory.get(). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59823 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 19 May, 2010 7 commits
-
-
eric@webkit.org authored
Reviewed by Darin Fisher. Implementing hardware accelerated compositing of layers for Chromium. Completely removed the existing software compositing path to replace it with code implemented using OpenGL. https://bugs.webkit.org/show_bug.cgi?id=38783 Tests: Covered by existing compositing tests. * WebCore.gyp/WebCore.gyp: * platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::~GraphicsLayerChromium): (WebCore::GraphicsLayerChromium::updateLayerDrawsContent): (WebCore::GraphicsLayerChromium::updateContentsRect): * platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::~LayerChromium): (WebCore::LayerChromium::updateGraphicsContext): (WebCore::LayerChromium::drawsContentUpdated): (WebCore::LayerChromium::updateContents): (WebCore::LayerChromium::setContents): (WebCore::LayerChromium::setBackingStoreSize): (WebCore::LayerChromium::setBounds): (WebCore::LayerChromium::setNeedsDisplay): * platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::contentsDirty): (WebCore::LayerChromium::drawsContent): * platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::): (WebCore::checkGLError): (WebCore::loadShader): (WebCore::loadShaderProgram): (WebCore::toGLMatrix): (WebCore::orthoMatrix): (WebCore::createLayerTexture): (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::~LayerRendererChromium): (WebCore::LayerRendererChromium::drawTexturedQuad): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::getTextureId): (WebCore::LayerRendererChromium::assignTextureForLayer): (WebCore::LayerRendererChromium::freeLayerTexture): (WebCore::LayerRendererChromium::drawDebugBorder): (WebCore::LayerRendererChromium::isLayerVisible): (WebCore::LayerRendererChromium::compositeLayersRecursive): (WebCore::LayerRendererChromium::makeContextCurrent): (WebCore::LayerRendererChromium::initGL): (WebCore::LayerRendererChromium::bindCommonAttribLocation): (WebCore::LayerRendererChromium::initializeSharedGLObjects): * platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::): 2010-05-19 Vangelis Kokkevis <vangelis@chromium.org> Reviewed by Darin Fisher. Modifying WebViewImpl to support new hardware compositing for LayerChromium layers. https://bugs.webkit.org/show_bug.cgi?id=38783 * src/WebViewImpl.cpp: (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::updateRootLayerContents): (WebKit::WebViewImpl::setRootLayerNeedsDisplay): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59822 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Adam Roben. WinEWS should build Debug instead of Release https://bugs.webkit.org/show_bug.cgi?id=39242 This is a workaround for https://bugs.webkit.org/show_bug.cgi?id=39197 Adam Roben and Brian Weinstein believe this may also make building faster since Debug builds take less time to link. * Scripts/webkitpy/tool/commands/earlywarningsystem.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59821 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
Reviewed by Geoff Garen. * bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): * bytecode/Opcode.h: * bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitReturn): * interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): * jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): * jit/JIT.h: * jit/JITCall.cpp: (JSC::JIT::emit_op_ret_object_or_this): * jit/JITOpcodes.cpp: (JSC::JIT::emit_op_ret_object_or_this): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59820 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tony@chromium.org authored
Reviewed by Kent Tamura. [chromium] disable spelling suggestions if spellcheck=false https://bugs.webkit.org/show_bug.cgi?id=39402 This is the Chromium fix for bug 25639 that was fixed in the other ports in r59585. * src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59819 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Darin Adler. Misleading variable name in a11y test https://bugs.webkit.org/show_bug.cgi?id=38465 Use a more appropriate variable name for the return value of accessibilityController.rootElement * accessibility/aria-controls-with-tabs.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
Bug 39399 - Move responsibility for verifying constructors return objects from the caller to the callee. Reviewed by Geoff Garen. This is a necessary step to move object creation from caller to callee. * bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): * bytecode/Opcode.h: * bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::emitReturn): (JSC::BytecodeGenerator::emitConstruct): * bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::isConstructor): * bytecompiler/NodesCodegen.cpp: (JSC::FunctionBodyNode::emitBytecode): * interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): * jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): * jit/JIT.h: * jit/JITCall.cpp: (JSC::JIT::emit_op_constructor_ret): * jit/JITOpcodes.cpp: (JSC::JIT::emit_op_constructor_ret): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59817 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Timothy Hatcher. Maintain focus on help screen while it's active. https://bugs.webkit.org/show_bug.cgi?id=39237 * inspector/front-end/HelpScreen.js: (WebInspector.HelpScreen): (WebInspector.HelpScreen.prototype.show): (WebInspector.HelpScreen.prototype._hide): (WebInspector.HelpScreen.prototype._onBlur): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59816 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-