1. 22 Apr, 2008 32 commits
    • weinig@apple.com's avatar
      2008-04-22 Sam Weinig <sam@webkit.org> · f804579a
      weinig@apple.com authored
              Reviewed by Geoffrey Garen.
      
              Make DOMAbstractView have a weak reference to the Frame instead of ref'ing
              the DOMWindow.
      
              To ensure that the WindowScriptObject (which is a DOMAbstractView) stays valid
              after a navigation once the split window is completed, the DOMAbstractView must
              wrap the Frame instead of a DOMWindow since the DOMWindow will change.
      
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/objc/DOMAbstractView.mm: Added.
              (-[DOMAbstractView dealloc]):
              (-[DOMAbstractView finalize]):
              (-[DOMAbstractView document]):
              (-[DOMAbstractView _disconnectFrame]):
              (-[DOMAbstractView WebCore::]):
              (-[DOMAbstractView _initWithFrame:WebCore::]):
              (+[DOMAbstractView _wrapAbstractView:WebCore::]):
              Add custom implementation to implement weak reference semantics.
      
              * bindings/objc/DOMAbstractViewFrame.h: Added.
              Declare the [DOMAbstractView _disconectFrame] selector.
              * bindings/objc/DOMInternal.h:
              Remove DOMRGBColor Internal category since it is now generated.
      
              * bindings/objc/DOMUtility.mm:
              (KJS::createDOMWrapper):
              Don't ever create a DOMAbstractView from a JSDOMWindow, only from JSDOMWindowWrapper.
      
              * bindings/scripts/CodeGeneratorObjC.pm:
              Generate internal header for IDLs that want custom implementations.
      
              * css/RGBColor.idl:
              Make this a PODType as it really is in the implementation.
      
              * page/AbstractView.idl:
              This now needs a custom objective-c binding implementation.
      
              * page/Frame.cpp:
              (WebCore::Frame::~Frame):
              disconnect the weak frame reference in the WindowScriptObject.
      
              * page/Frame.h:
              * page/gtk/FrameGtk.cpp:
              (WebCore::Frame::disconnectPlatformScriptObjects): Dummy implementation.
              * page/mac/FrameMac.mm:
              (WebCore::Frame::windowScriptObject): ASSERT that the windowScriptObject is a DOMAbstractView.
              (WebCore::Frame::disconnectPlatformScriptObjects): Disconnect the frame pointer from the windowScriptObject.
              * page/qt/FrameQt.cpp:
              (WebCore::Frame::disconnectPlatformScriptObjects): Dummy implementation.
              * page/win/FrameWin.cpp:
              (WebCore::Frame::disconnectPlatformScriptObjects): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32405 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f804579a
    • mitz@apple.com's avatar
      Fix typo in ChangeLog. · 9af89da0
      mitz@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32403 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9af89da0
    • mitz@apple.com's avatar
      WebCore: · 8e05a145
      mitz@apple.com authored
              Reviewed by Sam Weinig.
      
              - preparation https://bugs.webkit.org/show_bug.cgi?id=3729
                <rdar://problem/4036353> REGRESSION: arrow keys move insertion bar backwards in RTL text
      
              * rendering/bidi.cpp:
              (WebCore::RenderBlock::layoutInlineChildren): Make sure to give the
              trailing white space a bidi level consistent with its position.
      
      LayoutTests:
      
              Reviewed by Sam Weinig.
      
              - updated results with the trailing space having the right directionality
      
              * platform/mac/fast/text/trailing-white-space-2-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32402 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e05a145
    • timothy@apple.com's avatar
      Remove many unused Web Inspector images. · 4199dcb4
      timothy@apple.com authored
      Rubber-stamped by Adam Roben and Sam Weinig.
      
      * page/inspector/Images/attachedShadow.png: Removed.
      * page/inspector/Images/backNormal.png: Removed.
      * page/inspector/Images/bottomShadow.png: Removed.
      * page/inspector/Images/breadcrumbBackground.png: Removed.
      * page/inspector/Images/console.png: Removed.
      * page/inspector/Images/databaseBrowserViewNormal.png: Removed.
      * page/inspector/Images/databaseBrowserViewNormalSelected.png: Removed.
      * page/inspector/Images/databaseBrowserViewSmall.png: Removed.
      * page/inspector/Images/databaseBrowserViewSmallSelected.png: Removed.
      * page/inspector/Images/databaseQueryViewNormal.png: Removed.
      * page/inspector/Images/databaseQueryViewNormalSelected.png: Removed.
      * page/inspector/Images/databaseQueryViewSmall.png: Removed.
      * page/inspector/Images/databaseQueryViewSmallSelected.png: Removed.
      * page/inspector/Images/disclosureDownPressed.png: Removed.
      * page/inspector/Images/disclosureRightDown.png: Removed.
      * page/inspector/Images/disclosureRightPressed.png: Removed.
      * page/inspector/Images/document.png: Removed.
      * page/inspector/Images/domViewNormal.png: Removed.
      * page/inspector/Images/domViewNormalSelected.png: Removed.
      * page/inspector/Images/domViewSmall.png: Removed.
      * page/inspector/Images/domViewSmallSelected.png: Removed.
      * page/inspector/Images/downTriangle.png: Removed.
      * page/inspector/Images/folder.png: Removed.
      * page/inspector/Images/forwardNormal.png: Removed.
      * page/inspector/Images/gradient.png: Removed.
      * page/inspector/Images/gradientHighlight.png: Removed.
      * page/inspector/Images/gradientHighlightBottom.png: Removed.
      * page/inspector/Images/hideStatusWidget.png: Removed.
      * page/inspector/Images/hideStatusWidgetPressed.png: Removed.
      * page/inspector/Images/network.png: Removed.
      * page/inspector/Images/plainDocument.png: Removed.
      * page/inspector/Images/popupArrows.png: Removed.
      * page/inspector/Images/popupArrowsBlack.png: Removed.
      * page/inspector/Images/reload.png: Removed.
      * page/inspector/Images/rightTriangle.png: Removed.
      * page/inspector/Images/showStatusWidget.png: Removed.
      * page/inspector/Images/showStatusWidgetPressed.png: Removed.
      * page/inspector/Images/sidbarItemBackground.png: Removed.
      * page/inspector/Images/sidebarActionWidget.png: Removed.
      * page/inspector/Images/sidebarActionWidgetPressed.png: Removed.
      * page/inspector/Images/sidebarAttachWidget.png: Removed.
      * page/inspector/Images/sidebarAttachWidgetPressed.png: Removed.
      * page/inspector/Images/sidebarDetachWidget.png: Removed.
      * page/inspector/Images/sidebarDetachWidgetPressed.png: Removed.
      * page/inspector/Images/sidebarResizeWidget.png: Removed.
      * page/inspector/Images/sidebarStatusAreaBackground.png: Removed.
      * page/inspector/Images/sourceViewNormal.png: Removed.
      * page/inspector/Images/sourceViewNormalSelected.png: Removed.
      * page/inspector/Images/sourceViewSmall.png: Removed.
      * page/inspector/Images/sourceViewSmallSelected.png: Removed.
      * page/inspector/Images/tab.png: Removed.
      * page/inspector/Images/tabSelected.png: Removed.
      * page/inspector/Images/toggleDown.png: Removed.
      * page/inspector/Images/toggleUp.png: Removed.
      * page/inspector/Images/toolbarButtonNormal.png: Removed.
      * page/inspector/Images/toolbarButtonNormalInactive.png: Removed.
      * page/inspector/Images/toolbarButtonNormalPressed.png: Removed.
      * page/inspector/Images/toolbarButtonNormalSelected.png: Removed.
      * page/inspector/Images/toolbarButtonNormalSelectedInactive.png: Removed.
      * page/inspector/Images/toolbarButtonSmall.png: Removed.
      * page/inspector/Images/toolbarButtonSmallInactive.png: Removed.
      * page/inspector/Images/toolbarButtonSmallPressed.png: Removed.
      * page/inspector/Images/toolbarButtonSmallSelected.png: Removed.
      * page/inspector/Images/toolbarButtonSmallSelectedInactive.png: Removed.
      * page/inspector/Images/toolbarPopupButtonNormal.png: Removed.
      * page/inspector/Images/toolbarPopupButtonNormalInactive.png: Removed.
      * page/inspector/Images/toolbarPopupButtonNormalPressed.png: Removed.
      * page/inspector/Images/toolbarPopupButtonSmall.png: Removed.
      * page/inspector/Images/toolbarPopupButtonSmallInactive.png: Removed.
      * page/inspector/Images/toolbarPopupButtonSmallPressed.png: Removed.
      * page/inspector/Images/toolbarSplitButtonDividerNormal.png: Removed.
      * page/inspector/Images/toolbarSplitButtonDividerNormalInactive.png: Removed.
      * page/inspector/Images/toolbarSplitButtonDividerSmall.png: Removed.
      * page/inspector/Images/toolbarSplitButtonDividerSmallInactive.png: Removed.
      * page/inspector/Images/treeLeftTriangleBlack.png: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32401 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4199dcb4
    • andersca@apple.com's avatar
      WebCore: · 31329e81
      andersca@apple.com authored
      2008-04-22  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Darin.
      
              Add NPN_Construct and NPN_PluginThreadAsyncCall declarations.
      
              * bridge/npapi.h:
              * bridge/npruntime.h:
              * plugins/npfunctions.h:
      
      WebKit/mac:
      
      2008-04-22  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Darin.
      
              Add NPN_Construct and NPN_PluginThreadAsyncCall declarations.
              
              * Plugins/npfunctions.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31329e81
    • alice.liu@apple.com's avatar
      WebCore: · a6581642
      alice.liu@apple.com authored
      2008-04-22  Alice Liu  <alice.liu@apple.com>
      
              Reviewed by John Sullivan and Adam Roben.
      
              Test: fast/events/tabindex-focus-chain.html
      
              * dom/Document.cpp:
              (WebCore::Document::nextFocusableNode):
              (WebCore::Document::previousFocusableNode):
              If the focused node has been removed from the normal tabbing order,
              advancing focus from this node should advance to the next focusable
              node in tree order, and not start over at the beginning of the focus
              chain. 
      
      LayoutTests:
      
      2008-04-22  Alice Liu  <alice.liu@apple.com>
      
              Reviewed by John Sullivan and Adam Roben.
      
              Test for new behavior when advancing focus from a focusable-by-script node, which now
              matches Firefox 2 and 3
      
              * fast/events/tabindex-focus-chain-expected.txt: Added.
              * fast/events/tabindex-focus-chain.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32397 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a6581642
    • timothy@apple.com's avatar
      Adds a debugger toggle button to the scripts status bar that will start · c02d4a86
      timothy@apple.com authored
      and stop debugging of the inspected page.
      
      Reviewed by Adam Roben.
      
      * English.lproj/InspectorLocalizedStrings.js: Adds the two new tooltip strings.
      * page/InspectorController.cpp:
      (WebCore::debuggerAttached): Call InspectorController::debuggerAttached.
      (WebCore::InspectorController::InspectorController): Initialize
      m_debuggerAttached to false.
      (WebCore::InspectorController::windowScriptObjectAvailable): Add the debuggerAttached
      property to the InspectorController class.
      (WebCore::InspectorController::startDebuggingAndReloadInspectedPage):
      Set m_debuggerAttached to true.
      (WebCore::InspectorController::stopDebugging): Set m_debuggerAttached to false.
      * page/InspectorController.h:
      * page/inspector/Images/debuggingButtons.png: Added.
      * page/inspector/ScriptsPanel.js:
      (WebInspector.ScriptsPanel): Disable the pause button. Create the debugging
      button and setup the id, className and event listener. Call reset.
      (WebInspector.ScriptsPanel.prototype.get statusBarItems): Return an array
      (WebInspector.ScriptsPanel.prototype.reset): Call _updateDebuggerButtons.
      (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): Adjust the title of
      the debugging button to match what will happen when clicked. Change the style class,
      and toggle the disabled state of the pause button.
      (WebInspector.ScriptsPanel.prototype._toggleDebugging): Start or stop debugging
      depending on InspectorController.debuggerAttached().
      * page/inspector/inspector.css: Added style rules for the debugger button.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32396 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c02d4a86
    • aroben@apple.com's avatar
      Change PlatformWheelEvent to use GET_WHEEL_DELTA_WPARAM · 6dd75b01
      aroben@apple.com authored
              Reviewed by Dan Bernstein.
      
              * platform/win/WheelEventWin.cpp:
              (WebCore::PlatformWheelEvent::PlatformWheelEvent): Use
              GET_WHEEL_DELTA_WPARAM, which is documented way of getting the wheel
              delta (it is equivalent to what we were previously doing, however).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32395 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6dd75b01
    • hausmann@webkit.org's avatar
      Qt build fix. · 7f0c7e10
      hausmann@webkit.org authored
      Adjust the Qt resource file to removed image files.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32394 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f0c7e10
    • timothy@apple.com's avatar
      Use CSS gradients to replace many image files in the Web Inspector. · def6cb87
      timothy@apple.com authored
      Rubber-stamped by Adam Roben.
      
      * page/inspector/Images/alternateTableRows.png: Removed.
      * page/inspector/Images/darkShadow.png: Removed.
      * page/inspector/Images/paneHeader.png: Removed.
      * page/inspector/Images/paneHeaderActive.png: Removed.
      * page/inspector/Images/sidebarSelection.png: Removed.
      * page/inspector/Images/sidebarSelectionBackground.png: Removed.
      * page/inspector/Images/sidebarSelectionBackgroundFocused.png: Removed.
      * page/inspector/Images/sidebarSelectionBackgroundInactive.png: Removed.
      * page/inspector/Images/sidebarSelectionBlurred.png: Removed.
      * page/inspector/Images/sidebarSelectionBlurredTall.png: Removed.
      * page/inspector/Images/sidebarSelectionGray.png: Removed.
      * page/inspector/Images/sidebarSelectionGrayTall.png: Removed.
      * page/inspector/Images/sidebarSelectionTall.png: Removed.
      * page/inspector/Images/sidebarSmallSelectionBackground.png: Removed.
      * page/inspector/Images/sidebarSmallSelectionBackgroundFocused.png: Removed.
      * page/inspector/Images/sidebarSmallSelectionBackgroundInactive.png: Removed.
      * page/inspector/Images/toolbarBackground.png: Removed.
      * page/inspector/Images/toolbarBackgroundInactive.png: Removed.
      * page/inspector/inspector.css:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32393 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      def6cb87
    • hausmann@webkit.org's avatar
      Andre Poenitz <andre.poenitz@trolltech.com> · 8c27b2c0
      hausmann@webkit.org authored
      Remove compiler warnings on string literals used to construct QStrings
      in webkit.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32392 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c27b2c0
    • hausmann@webkit.org's avatar
      Benjamin Meyer <bmeyer@trolltech.com> · d0a33ace
      hausmann@webkit.org authored
      Fixes: QWebPage's QNetworkManager's can be shared among webpages.
      
      Don't force the deletion of the object, but let QObject take care of it.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32391 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0a33ace
    • hausmann@webkit.org's avatar
    • hausmann@webkit.org's avatar
      Simon Hausmann <hausmann@webkit.org> · 9d3c6810
      hausmann@webkit.org authored
      Added QWebPage::swallowContextMenuEvent and QWebPage::updatePositionDependentActions.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d3c6810
    • hausmann@webkit.org's avatar
      Added Extension APIs for QWebPage. · b13b76af
      hausmann@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32388 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b13b76af
    • hausmann@webkit.org's avatar
      Tor Arne Vestbø <tavestbo@trolltech.com> · f632bc32
      hausmann@webkit.org authored
      Emit loadProgress() signal on loadStarted().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32387 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f632bc32
    • hausmann@webkit.org's avatar
      Zack Rusin <zack@kde.org> · d1543b30
      hausmann@webkit.org authored
      Fix background propagation from the QWebView's palette.
      
      The background brush of the palette needs to be propagated to the WebCore::FrameView.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32386 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1543b30
    • hausmann@webkit.org's avatar
      Benjamin Meyer <bmeyer@trolltech.com> · babf0033
      hausmann@webkit.org authored
      Fix maps.google.com
      
      We have to include a version in the Safari tag in the user-agent.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32385 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      babf0033
    • hausmann@webkit.org's avatar
      Tor Arne Vestbø <tavestbo@trolltech.com> · 47303808
      hausmann@webkit.org authored
      Fall back to last path component for suggested filename if the HTTP content disposition is not set.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32384 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47303808
    • hausmann@webkit.org's avatar
      Tor Arne Vestbø <tavestbo@trolltech.com> · 5c57d0ca
      hausmann@webkit.org authored
      Implemented the generation of the title string for images.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32382 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c57d0ca
    • hausmann@webkit.org's avatar
      Tor Arne Vestbø <tavestbo@trolltech.com> · a14182ae
      hausmann@webkit.org authored
      Add visual focusing hint for clear button and
      Change focus to web page after user enters new URL.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32381 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a14182ae
    • hausmann@webkit.org's avatar
      Added QWebFrame::hitTestContent() and QWebHitTestResult. · 4dff64d3
      hausmann@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32380 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4dff64d3
    • hausmann@webkit.org's avatar
      Simon Hausmann <hausmann@webkit.org> · 50552d58
      hausmann@webkit.org authored
      Don't crash if an input method query is done without a page.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32379 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50552d58
    • hausmann@webkit.org's avatar
      Simon Hausmann <hausmann@webkit.org> · 2384deaa
      hausmann@webkit.org authored
      Added re-implementations of QObject::event for future safety.
      
      This makes it easier to fix bugs with the event handling even in patch releases
      and is a general style we follow in Qt.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32378 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2384deaa
    • hausmann@webkit.org's avatar
      Benjamin Meyer <bmeyer@trolltech.com> · 31f255e7
      hausmann@webkit.org authored
      Fix construction of the user agent.
      
      The user-agent is now composed of
      * the platform and subplatform
      * the Qt version or application name and version (if set)
      * the locale
      * the SSL settings
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32376 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31f255e7
    • hausmann@webkit.org's avatar
      Thiago Macieira <tjmaciei@trolltech.com> · 5299b912
      hausmann@webkit.org authored
      Fixes: Pedantic compilation fix
      
      Don't put semi-colons after braces closing namespaces.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5299b912
    • hausmann@webkit.org's avatar
      Qt build fix. · b8760e1f
      hausmann@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32374 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8760e1f
    • jhoneycutt@apple.com's avatar
      2008-04-19 Jon Honeycutt <jhoneycutt@apple.com> · 482f9be8
      jhoneycutt@apple.com authored
              Reviewed by Darin.
      
              Add a method to get the AccessibilityObject's access key,
      
              * page/AccessibilityObject.cpp:
              (WebCore::AccessibilityObject::accessKey): Added; returns the object's
              access key attribute.
              * page/AccessibilityObject.h: Added declaration for accessKey().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32373 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      482f9be8
    • jhoneycutt@apple.com's avatar
      2008-04-19 Jon Honeycutt <jhoneycutt@apple.com> · adefe635
      jhoneycutt@apple.com authored
              Reviewed by Darin.
      
              Implement get_accHelp().
      
              * AccessibleBase.cpp:
              (AccessibleBase::get_accHelp): Report the result of calling the object's
              helpText() method.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32372 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      adefe635
    • jhoneycutt@apple.com's avatar
      2008-04-19 Jon Honeycutt <jhoneycutt@apple.com> · f88961a1
      jhoneycutt@apple.com authored
              Reviewed by Darin.
      
              Implement get_accState().
      
              * AccessibleBase.cpp:
              (AccessibleBase::get_accState):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f88961a1
    • jhoneycutt@apple.com's avatar
      2008-04-18 Jon Honeycutt <jhoneycutt@apple.com> · a9ac45a4
      jhoneycutt@apple.com authored
              Reviewed by Darin.
      
              Implement get_accRole().
      
              * AccessibleBase.cpp:
              (AccessibleBase::get_accRole): Report the result of role().
              (MSAARole): Added; returns the MSAA role for a WebCore role.
              (AccessibleBase::role): Return the MSAA role for the object's roleValue.
              * AccessibleBase.h: Add declaration for role().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9ac45a4
    • jhoneycutt@apple.com's avatar
      2008-04-18 Jon Honeycutt <jhoneycutt@apple.com> · 81273f31
      jhoneycutt@apple.com authored
              Reviewed by Darin.
      
              Implement get_accName(), get_accValue(), get_accDescription(). Added
              virtual methods that accessible objects can override to customize the
              result.
      
              * AccessibleBase.cpp:
              (AccessibleBase::get_accName): Report result of name().
              (AccessibleBase::get_accValue): Report result of value().
              (AccessibleBase::get_accDescription): Report result of description().
              (AccessibleBase::name): Added; returns AccessibilityObject::title().
              (AccessibleBase::value): Added; returns
              AccessibilityObject::stringValue().
              (AccessibleBase::description): Added; returns
              AccessibilityObject::accessibilityDescription().
              * AccessibleBase.h: Added declarations for name(), value(), and
              description().
              * ChangeLog: Fix my misuse of "definition."
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32369 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81273f31
  2. 21 Apr, 2008 8 commits
    • hyatt@apple.com's avatar
      Fix layout test results for new props. · 0d944683
      hyatt@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32368 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d944683
    • weinig@apple.com's avatar
      2008-04-21 Sam Weinig <sam@webkit.org> · 3d14e2a2
      weinig@apple.com authored
              Reviewed by Anders Carlsson.
      
              Fix numerous crashing tests.
      
              * html/HTMLHtmlElement.cpp:
              (WebCore::HTMLHtmlElement::insertedIntoDocument): Null check document->frame().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32364 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d14e2a2
    • mrowe@apple.com's avatar
      Fix the case on the file names of test results for svg/custom/altglyph.svg,... · f6c4c0d0
      mrowe@apple.com authored
      Fix the case on the file names of test results for svg/custom/altglyph.svg, and remove an extra -expected.txt that was checked in with incorrect
      case.
      
      * platform/mac/svg/custom/altGlyph-expected.checksum: Removed.
      * platform/mac/svg/custom/altGlyph-expected.png: Removed.
      * platform/mac/svg/custom/altGlyph-expected.txt: Removed.
      * platform/mac/svg/custom/altglyph-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/altGlyph-expected.checksum.
      * platform/mac/svg/custom/altglyph-expected.png: Copied from LayoutTests/platform/mac/svg/custom/altGlyph-expected.png.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32363 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6c4c0d0
    • weinig@apple.com's avatar
      WebCore: · eec87e02
      weinig@apple.com authored
      2008-04-21  Dan Bernstein  <mitz@apple.com>
      
              Reviewed by Darin Adler.
      
              Tests: fast/media/implicit-media-all.html
                     fast/media/monochrome.html
      
              - allow implicit "all" media in media queries
              - use a value of 0 for the monochrome media feature on color displays
      
              * css/CSSGrammar.y:
              * css/CSSParser.cpp:
              (WebCore::CSSParser::createFloatingMediaQuery):
              * css/CSSParser.h:
              * css/MediaQueryEvaluator.cpp:
              (WebCore::monochromeMediaFeatureEval):
      
      LayoutTests:
      
      2008-04-21  Dan Bernstein  <mitz@apple.com>
      
              Reviewed by Darin Adler.
      
              - update acid3.html to reflect the updated test.
              - test for implicit "all" media in media queries
              - test that the value of the monochrome media feature is 0 on color displays
      
              * http/tests/misc/acid3.html:
              * fast/media/implicit-media-all.html: Added.
              * fast/media/monochrome.html: Added.
              * platform/mac/fast/media/implicit-media-all-expected.checksum: Added.
              * platform/mac/fast/media/implicit-media-all-expected.png: Added.
              * platform/mac/fast/media/implicit-media-all-expected.txt: Added.
              * platform/mac/fast/media/monochrome-expected.checksum: Added.
              * platform/mac/fast/media/monochrome-expected.png: Added.
              * platform/mac/fast/media/monochrome-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32362 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eec87e02
    • beidson@apple.com's avatar
      2008-04-21 Brady Eidson <beidson@apple.com> · 924b6ae8
      beidson@apple.com authored
              Rockingly reviewed by Adele
      
              Small StorageArea cleanups
      
              * storage/SessionStorageArea.cpp:
              (WebCore::SessionStorageArea::copy): Pass "this" instead of the StorageMap belonging to this
              (WebCore::SessionStorageArea::SessionStorageArea):
              * storage/SessionStorageArea.h:
      
              * storage/StorageArea.cpp:  Changed to not expose the StorageMap at all - it's dangerous to expose
                it since we rely explicitly on its ref-count
              (WebCore::StorageArea::StorageArea): Take another StorageArea as the c'tor argument and get the 
                StorageMap from that.
              (WebCore::StorageArea::setItem):  The previous comment/code here was bogus.  All JS objects passed in
                to this API are stringified, so there's no such thing as "null" for setItem()
              * storage/StorageArea.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      924b6ae8
    • dino@apple.com's avatar
      Updated CSS Visual Effects proposals. · 557bb31a
      dino@apple.com authored
      CSS Animations
      
      * described simplified sandwich model (that animations have no effect
        outside their duration and last specified animation wins)
      * diagram showing the above
      * specified animations to start at style resolution or document load,
        whichever is later.
      * animation start events always have elapsedTime == 0
      
      CSS Transforms
      
      * removed text saying that elements cannot be drawn as intersecting.
      * described that preserve-3d trees often need a flattening parent, otherwise
        elements can be hidden behind their ancestor's background.
      * describe that preserve-3d is not always possible, such as when
        overflow is 'hidden'.
      
      CSS Transitions
      
      * no change
      
      * specs/CSSVisualEffects/CSSAnimation.html:
      * specs/CSSVisualEffects/CSSTransforms.html:
      * specs/CSSVisualEffects/CSSTransitions.html:
      * specs/CSSVisualEffects/sandwich.png: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32356 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      557bb31a
    • hyatt@apple.com's avatar
      Fix Windows bustage. · c28bd0fc
      hyatt@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32355 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c28bd0fc
    • kmccullough@apple.com's avatar
      2008-04-21 Kevin McCullough <kmccullough@apple.com> · 42565f4b
      kmccullough@apple.com authored
              Reviewed by Adam.
      
              <rdar://problem/5770054> JavaScript profiler (10928)
              - When stop profiling is called we need to stop the timers on all the
              functions that are still running.
      
              * profiler/FunctionCallProfile.cpp:
              (KJS::FunctionCallProfile::didExecute):
              (KJS::FunctionCallProfile::stopProfiling):
              * profiler/FunctionCallProfile.h:
              * profiler/Profiler.cpp:
              (KJS::Profiler::stopProfiling):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42565f4b