1. 20 Jan, 2011 40 commits
    • bdakin@apple.com's avatar
      Fix for <rdar://problem/8890255> · f76bd26b
      bdakin@apple.com authored
      Reviewed by Geoffrey Garen.
      
      Source/WebCore: 
      
      Allow WebKitSystemInterface to draw scrollbars 
      when appropriate.
      * WebCore.exp.in:
      * platform/mac/ScrollbarThemeMac.mm:
      (WebCore::scrollbarMap):
      (+[ScrollbarPrefsObserver appearancePrefsChanged:]):
      (WebCore::ScrollbarThemeMac::registerScrollbar):
      (WebCore::ScrollbarThemeMac::unregisterScrollbar):
      (WebCore::ScrollbarThemeMac::paint):
      * platform/mac/WebCoreSystemInterface.h:
      * platform/mac/WebCoreSystemInterface.mm:
      
      Source/WebKit/mac: 
      
      Allow WebKitSystemInterface to draw scrollbars 
      when appropriate.
      * WebCoreSupport/WebSystemInterface.mm:
      (InitWebCoreSystemInterface):
      
      Source/WebKit2: 
      
      Allow WebKitSystemInterface to draw scrollbars 
      when appropriate.
      * WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
      (InitWebCoreSystemInterface):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76292 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f76bd26b
    • weinig@apple.com's avatar
      Cleanup Scrollbar/ScrollbarClient relationship · 2a13aa81
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=52779
      
      Reviewed by Dave Hyatt.
      
      Source/WebCore: 
      
      Pipe all scrolling through the ScrollbarClient/ScrollAnimator
      rather than through the Scrollbar. The Scrollbar now is just
      a "view" on the scroll position of the scrollable area it is
      attached to.
      
      There are now two ways to scroll a scrollable area:
      - ScrollbarClient::scroll()
      - ScrollbarClient::scrollToOffsetWithoutAnimation()
      
      Both of these go through the ScrollAnimator (updating its state
      or starting an animation). The ScrollAnimator, in turn, now calls
      ScrollbarClient::setScrollOffsetFromAnimation, which tells the
      Scrollbars to pull a new offset (via Scrollbar::offsetDidChange)
      and tells the class that derives from ScrollbarClient to scroll
      its contents (via ScrollbarClient::setScrollOffset).
      
      * WebCore.xcodeproj/project.pbxproj:
      Move Scrollbar.cpp to the right place.
      
      * accessibility/AccessibilityScrollbar.cpp:
      (WebCore::AccessibilityScrollbar::setValue):
      Initiate the scroll through the scrollbar client, rather than the
      scrollbar itself.
      
      * page/FrameView.cpp:
      (WebCore::FrameView::scrollTo):
      * page/FrameView.h:
      Condense the two valueChanged overrides to a single override of the
      scrollTo function.
      
      * platform/ScrollAnimator.cpp:
      (WebCore::ScrollAnimator::scroll):
      (WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):
      (WebCore::ScrollAnimator::currentPosition):
      (WebCore::ScrollAnimator::notityPositionChanged):
      * platform/ScrollAnimator.h:
      * platform/ScrollAnimatorWin.cpp:
      (WebCore::ScrollAnimatorWin::scrollToOffsetWithoutAnimation):
      (WebCore::ScrollAnimatorWin::animateScroll):
      * platform/ScrollAnimatorWin.h:
      * platform/mac/ScrollAnimatorMac.h:
      * platform/mac/ScrollAnimatorMac.mm:
      (WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation):
      (WebCore::ScrollAnimatorMac::immediateScrollToPoint):
      Change setScrollPositionAndStopAnimation to scrollToOffsetWithoutAnimation
      and bottleneck all client notification of changed position through a new
      notityPositionChanged() function.
      
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::setScrollOffset):
      (WebCore::ScrollView::scrollTo):
      (WebCore::ScrollView::scrollPosition):
      (WebCore::ScrollView::scroll):
      (WebCore::ScrollView::updateScrollbars):
      (WebCore::ScrollView::wheelEvent):
      * platform/ScrollView.h:
      (WebCore::ScrollView::horizontalScrollbar):
      (WebCore::ScrollView::verticalScrollbar):
      Update to scroll via the ScrollbarClient rather than the Scrollbar.
      
      * platform/Scrollbar.cpp:
      (WebCore::Scrollbar::offsetDidChange):
      (WebCore::Scrollbar::autoscrollPressedPart):
      (WebCore::Scrollbar::moveThumb):
      (WebCore::Scrollbar::mouseMoved):
      * platform/Scrollbar.h:
      (WebCore::Scrollbar::setPressedPos):
      Change the scrollbar to only updates its offset in response to
      an offsetDidChange call.
      
      * platform/ScrollbarClient.cpp:
      (WebCore::ScrollbarClient::scroll):
      (WebCore::ScrollbarClient::scrollToOffsetWithoutAnimation):
      (WebCore::ScrollbarClient::scrollToXOffsetWithoutAnimation):
      (WebCore::ScrollbarClient::scrollToYOffsetWithoutAnimation):
      (WebCore::ScrollbarClient::setScrollOffsetFromAnimation):
      * platform/ScrollbarClient.h:
      (WebCore::ScrollbarClient::horizontalScrollbar):
      (WebCore::ScrollbarClient::verticalScrollbar):
      Make the increasingly misnamed ScrollbarClient responsible for
      scrolling.
      
      * platform/efl/ScrollbarEfl.cpp:
      (scrollbarEflEdjeMessage):
      * platform/gtk/MainFrameScrollbarGtk.cpp:
      (MainFrameScrollbarGtk::gtkValueChanged):
      * platform/qt/ScrollbarQt.cpp:
      (WebCore::Scrollbar::contextMenu):
      Update to move scrolling through the client.
      
      * platform/win/PopupMenuWin.cpp:
      (WebCore::PopupMenuWin::scrollToRevealSelection):
      (WebCore::PopupMenuWin::scrollPosition):
      (WebCore::PopupMenuWin::setScrollOffset):
      (WebCore::PopupMenuWin::scrollTo):
      (WebCore::PopupMenuWin::wndProc):
      * platform/win/PopupMenuWin.h:
      (WebCore::PopupMenuWin::verticalScrollbar):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::scrollToOffset):
      (WebCore::RenderLayer::scrollTo):
      (WebCore::RenderLayer::setScrollOffset):
      (WebCore::RenderLayer::scrollPosition):
      (WebCore::RenderLayer::updateScrollInfoAfterLayout):
      (WebCore::RenderLayer::scroll):
      * rendering/RenderLayer.h:
      * rendering/RenderListBox.cpp:
      (WebCore::RenderListBox::scrollToRevealElementAtListIndex):
      (WebCore::RenderListBox::scroll):
      (WebCore::RenderListBox::logicalScroll):
      (WebCore::RenderListBox::scrollPosition):
      (WebCore::RenderListBox::setScrollOffset):
      (WebCore::RenderListBox::scrollTo):
      (WebCore::RenderListBox::setScrollTop):
      * rendering/RenderListBox.h:
      (WebCore::RenderListBox::verticalScrollbar):
      Update to scroll via the ScrollbarClient rather than the Scrollbar.
      
      * rendering/RenderMarquee.cpp:
      (WebCore::RenderMarquee::start):
      Simplify initial paint to just do an immediate scroll to the position.
      
      Source/WebKit/chromium: 
      
      * src/WebScrollbarImpl.cpp:
      (WebKit::WebScrollbarImpl::WebScrollbarImpl):
      (WebKit::WebScrollbarImpl::value):
      (WebKit::WebScrollbarImpl::setValue):
      (WebKit::WebScrollbarImpl::scroll):
      (WebKit::WebScrollbarImpl::onMouseDown):
      (WebKit::WebScrollbarImpl::onMouseMove):
      (WebKit::WebScrollbarImpl::onMouseWheel):
      (WebKit::WebScrollbarImpl::onKeyDown):
      (WebKit::WebScrollbarImpl::scrollPosition):
      (WebKit::WebScrollbarImpl::setScrollOffset):
      * src/WebScrollbarImpl.h:
      
      Source/WebKit/qt: 
      
      * Api/qwebframe.cpp:
      (QWebFrame::setScrollBarValue):
      
      Source/WebKit/win: 
      
      * WebScrollBar.cpp:
      (WebScrollBar::WebScrollBar):
      (WebScrollBar::setValue):
      (WebScrollBar::value):
      (WebScrollBar::scroll):
      (WebScrollBar::scrollPosition):
      (WebScrollBar::setScrollOffset):
      * WebScrollBar.h:
      
      Source/WebKit2: 
      
      * UIProcess/win/WebPopupMenuProxyWin.cpp:
      (WebKit::WebPopupMenuProxyWin::scrollPosition):
      (WebKit::WebPopupMenuProxyWin::setScrollOffset):
      (WebKit::WebPopupMenuProxyWin::scrollTo):
      (WebKit::WebPopupMenuProxyWin::onMouseWheel):
      (WebKit::WebPopupMenuProxyWin::scrollToRevealSelection):
      * UIProcess/win/WebPopupMenuProxyWin.h:
      (WebKit::WebPopupMenuProxyWin::verticalScrollbar):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76291 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a13aa81
    • rniwa@webkit.org's avatar
      2011-01-20 Ryosuke Niwa <rniwa@webkit.org> · c673baa3
      rniwa@webkit.org authored
              Unreviewed Chromium test expectations fix.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c673baa3
    • tony@chromium.org's avatar
      2011-01-20 Tony Chang <tony@chromium.org> · 31faaa36
      tony@chromium.org authored
              Unreviewed, another attempt at making the chromium gpu tests go green.
      
              * platform/chromium-gpu/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76289 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31faaa36
    • dpranke@chromium.org's avatar
      2011-01-20 Dirk Pranke <dpranke@chromium.org> · b219bee0
      dpranke@chromium.org authored
              Reviewed by Eric Seidel.
      
              nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
      
              https://bugs.webkit.org/show_bug.cgi?id=52756
      
              * Scripts/webkitpy/layout_tests/layout_package/printing.py:
              * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
              * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
              * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
              * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
              * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76288 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b219bee0
    • jamesr@google.com's avatar
      2011-01-20 James Robinson <jamesr@chromium.org> · 0fa1a50d
      jamesr@google.com authored
              Update expectations for tests that need chromium-side changes.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76287 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0fa1a50d
    • commit-queue@webkit.org's avatar
      2011-01-20 Mansi Mithal <mansi.mithal@nokia.com> · 80024169
      commit-queue@webkit.org authored
              Reviewed by Antonio Gomes.
      
              QtTestBrowser should have a seperate menu for Settings
              https://bugs.webkit.org/show_bug.cgi?id=52817
      
              Added a new menu item named "Settings"
              and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu
      
              * QtTestBrowser/launcherwindow.cpp:
              (LauncherWindow::createChrome):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80024169
    • andersca@apple.com's avatar
      2011-01-20 Anders Carlsson <andersca@apple.com> · 42abed10
      andersca@apple.com authored
              Reviewed by Adam Roben.
      
              Add a timestamp to UpdateInfo
              https://bugs.webkit.org/show_bug.cgi?id=52844
      
              * Shared/UpdateInfo.cpp:
              (WebKit::UpdateInfo::encode):
              (WebKit::UpdateInfo::decode):
              * Shared/UpdateInfo.h:
              * WebProcess/WebPage/DrawingAreaImpl.cpp:
              (WebKit::DrawingAreaImpl::setSize):
              (WebKit::DrawingAreaImpl::display):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76285 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42abed10
    • rniwa@webkit.org's avatar
      2011-01-20 Ryosuke Niwa <rniwa@webkit.org> · 55e47ead
      rniwa@webkit.org authored
              Unreviewed Chromium test expectation update.
      
              Merged test_expectations.txt in the Chromium tree and
              added slow to fast/text/large-text-composed-char-dos.html.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76284 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55e47ead
    • tony@chromium.org's avatar
      2011-01-20 Tony Chang <tony@chromium.org> · 5852300a
      tony@chromium.org authored
              Unreviewed, updating gpu expectations.
              These two tests were added to the regular chromiumg test_expectations.txt
              in r76228.
      
              * platform/chromium-gpu/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76283 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5852300a
    • paroga@webkit.org's avatar
      2011-01-20 Patrick Gansterer <paroga@webkit.org> · eaa44b02
      paroga@webkit.org authored
              Unreviewed WinCE build fix for r76170.
      
              * platform/graphics/wince/FontWinCE.cpp: Added a missing include.
              * platform/graphics/wince/ImageBufferData.h: Added a missing include and fixed style.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76282 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eaa44b02
    • weinig@apple.com's avatar
      Update update-webkit-localizable-strings with new path to WebKit. · 91c578e4
      weinig@apple.com authored
      Reviewed by John Sullivan.
      
      * Scripts/update-webkit-localizable-strings:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76281 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      91c578e4
    • andersca@apple.com's avatar
      2011-01-20 Anders Carlsson <andersca@apple.com> · 061b8ef0
      andersca@apple.com authored
              Reviewed by Beth Dakin.
      
              Add Connection::waitForAndDispatchImmediately
              https://bugs.webkit.org/show_bug.cgi?id=52841
      
              * Platform/CoreIPC/Connection.h:
              (CoreIPC::Connection::waitForAndDispatchImmediately):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76280 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      061b8ef0
    • rniwa@webkit.org's avatar
      2011-01-20 Ryosuke Niwa <rniwa@webkit.org> · 78415b82
      rniwa@webkit.org authored
              Unreviewed; Another Chromium rebaseline for r76236.
      
              * platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum: Added.
              * platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
              * platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76279 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78415b82
    • jamesr@google.com's avatar
      2011-01-20 James Robinson <jamesr@chromium.org> · 0ea9e5fc
      jamesr@google.com authored
              Reviewed by Darin Fisher.
      
              Implement mozilla's requestAnimationFrame API
              https://bugs.webkit.org/show_bug.cgi?id=51218
      
              Tests for window.webkitRequestAnimationFrame().  The new tests
              are in the Skipped lists for platforms that do not set
              ENABLE(REQUEST_ANIMATION_FRAME) - which is currently all but chromium.
      
              * fast/animation/request-animation-frame-cancel-expected.txt: Added.
              * fast/animation/request-animation-frame-cancel.html: Added.
                  Tests cancelling a callback within a webkitRequestAnimationFrame() callback.
              * fast/animation/request-animation-frame-cancel2-expected.txt: Added.
              * fast/animation/request-animation-frame-cancel2.html: Added.
                  Tests interactions between multiple webkitRequestAnimationFrame() callbacks.
              * fast/animation/request-animation-frame-display-expected.txt: Added.
              * fast/animation/request-animation-frame-display.html:...
      0ea9e5fc
    • jamesr@google.com's avatar
      2011-01-20 James Robinson <jamesr@chromium.org> · e364bab1
      jamesr@google.com authored
              Reviewed by Nate Chapin.
      
              [v8] CodeGeneratorV8 generates incorrect code for callbacks with no parameters
              https://bugs.webkit.org/show_bug.cgi?id=52837
      
              When generating code to invoke a callback with no parameters CodeGeneratorV8.pm was generating the following:
              v8::Handle<v8::Value> argv[] = {}; which does not compile in visual studio.  Instead, if the argument count
              is 0, we can just pass a NULL pointer for the argv parameter.
      
              Test added to bindings/scripts/test/TestCallback.idl and covered by run-bindings-tests.  This
              patch also includes some spurious changes to the bindings tests golden files (mostly GObject)
              because the old golden files were out of date.
      
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/scripts/test/CPP/WebDOMTestCallback.cpp:
              (WebDOMTestCallback::callbackWithNoParam):
              * bindings/scripts/test/CPP/WebDOMTestCallback.h:
              * bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
              (webkit_dom_test_callback_callback_with_no_param):
              * bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
              * bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
              * bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
              * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
              * bindings/scripts/test/JS/JSTestCallback.cpp:
              (WebCore::JSTestCallback::callbackWithNoParam):
              * bindings/scripts/test/JS/JSTestCallback.h:
              * bindings/scripts/test/JS/JSTestInterface.cpp:
              * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
              * bindings/scripts/test/JS/JSTestObj.cpp:
              * bindings/scripts/test/ObjC/DOMTestCallback.h:
              * bindings/scripts/test/ObjC/DOMTestCallback.mm:
              (-[DOMTestCallback callbackWithNoParam]):
              * bindings/scripts/test/TestCallback.idl:
              * bindings/scripts/test/V8/V8TestCallback.cpp:
              (WebCore::V8TestCallback::callbackWithNoParam):
              * bindings/scripts/test/V8/V8TestCallback.h:
              * bindings/scripts/test/V8/V8TestObj.cpp:
              (WebCore::TestObjInternal::reflectedUnsignedIntegralAttrAttrGetter):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76277 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e364bab1
    • jamesr@google.com's avatar
      2011-01-20 James Robinson <jamesr@chromium.org> · 5ddfb04e
      jamesr@google.com authored
              Reviewed by Eric Seidel.
      
              RenderTableSection's setNeedsCellRecalc needs to null check table()
              https://bugs.webkit.org/show_bug.cgi?id=52770
      
              Tests ::-webkit-scrollbar-corner inside a table.
      
              * fast/css-generated-content/table-with-scrollbar-corner-expected.txt: Added.
              * fast/css-generated-content/table-with-scrollbar-corner.html: Added.
      2011-01-20  James Robinson  <jamesr@chromium.org>
      
              Reviewed by Eric "Baller" Seidel.
      
              RenderTableSection's setNeedsCellRecalc needs to null check table()
              https://bugs.webkit.org/show_bug.cgi?id=52770
      
              Null checks table() before deferencing it in RenderTableSection::setNeedsCellRecalc.
              This can be null during detach().  Test constructed by Eric Seidel.
      
              Test: fast/css-generated-content/table-with-scrollbar-corner.html
      
              * rendering/RenderTableSection.cpp:
              (WebCore::RenderTableSection::setNeedsCellRecalc):
              * rendering/RenderTableSection.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76276 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ddfb04e
    • msaboff@apple.com's avatar
      2011-01-20 Michael Saboff <msaboff@apple.com> · 633f239b
      msaboff@apple.com authored
              Reviewed by Oliver Hunt.
      
              <rdar://problem/8890203> [RegexFuzz] Crash in generated code (52773)
              https://bugs.webkit.org/show_bug.cgi?id=52773
      
              Fixed case where an existing DataLabelPtr is overwritten.  The
              replacing DataLabelPtr is now resolved immediately in
              linkDataLabelToBacktrackIfExists().  Cleanup - eliminated bool
              return value for the routine as it was never used.
      
              * yarr/YarrJIT.cpp:
              (JSC::Yarr::YarrGenerator::TermGenerationState::linkDataLabelToBacktrackIfExists):
      2011-01-20  Michael Saboff  <msaboff@apple.com>
      
              Reviewed by Oliver Hunt.
      
              <rdar://problem/8890203> [RegexFuzz] Crash in generated code (52773)
              https://bugs.webkit.org/show_bug.cgi?id=52773
      
              New test to validate fix.
      
              * fast/regex/parentheses-expected.txt:
              * fast/regex/script-tests/parentheses.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76275 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      633f239b
    • krit@webkit.org's avatar
      2011-01-20 Dirk Schulze <krit@webkit.org> · d7140cc3
      krit@webkit.org authored
              Reviewed by Rob Buis.
      
              SVG Pattern doesn't take preserveAspectRatio of references Pattern
              https://bugs.webkit.org/show_bug.cgi?id=52802
      
              SVGPattern didn't take preserveAspectRatio of a referenced SVGPattern into account. Store preserveAspectRatio
              in PatternAttributes as well, if the attribute was set on the referenced SVGPattern element.
      
              Test: svg/custom/pattern-referencing-preserve-aspect-ratio.svg
      
              * rendering/svg/RenderSVGResourcePattern.cpp:
              (WebCore::RenderSVGResourcePattern::buildTileImageTransform):
              * svg/PatternAttributes.h:
              (WebCore::PatternAttributes::PatternAttributes):
              (WebCore::PatternAttributes::preserveAspectRatio):
              (WebCore::PatternAttributes::setPreserveAspectRatio):
              (WebCore::PatternAttributes::hasPreserveAspectRatio):
              * svg/SVGPatternElement.cpp:
              (WebCore::SVGPatternElement::collectPatternAttributes):
      2011-01-20  Dirk Schulze  <krit@webkit.org>
      
              Reviewed by Rob Buis.
      
              SVG Pattern doesn't take preserveAspectRatio of references Pattern
              https://bugs.webkit.org/show_bug.cgi?id=52802
      
              Added a test case to check that we take preserveAspectRatio of a referenced SVGPattern into account.
      
              * platform/mac/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.checksum: Added.
              * platform/mac/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.png: Added.
              * platform/mac/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.txt: Added.
              * svg/custom/pattern-referencing-preserve-aspect-ratio.svg: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76274 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7140cc3
    • mitz@apple.com's avatar
      <rdar://problem/8765498> REGRESSION (r72141): Cannot order prints with Aperture 3.1 · d557175d
      mitz@apple.com authored
      Reviewed by Adele Peterson.
      
      <rdar://problem/8884648> REGRESSION (r72141): Safari hangs when visiting a page on www.bfmtv.com
      https://bugs.webkit.org/show_bug.cgi?id=52765
      
      <rdar://problem/8890909> REGRESSION (r72141): Very Slow Rendering With Certain Markup
      https://bugs.webkit.org/show_bug.cgi?id=52265
      
      Source/WebCore: 
      
      Test: fast/block/line-layout/negative-max-height.html
      
      Integer overflow detection led to a block having a huge height. This manifested as broken layout
      in the first bug and as extreme slowness in the latter bugs because of
      https://bugs.webkit.org/show_bug.cgi?id=52832
      
      * rendering/RootInlineBox.cpp:
      (WebCore::RootInlineBox::alignBoxesInBlockDirection): Clamp maxHeight to 0 so the next line
      cannot start above this line. The negative maxHeight also caused the integer overflow detection
      logic to give the block a huge height.
      
      LayoutTests: 
      
      * fast/block/line-layout: Added.
      * fast/block/line-layout/negative-max-height-expected.checksum: Added.
      * fast/block/line-layout/negative-max-height-expected.png: Added.
      * fast/block/line-layout/negative-max-height-expected.txt: Added.
      * fast/block/line-layout/negative-max-height.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76273 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d557175d
    • yi.4.shen@nokia.com's avatar
      2011-01-20 Yi Shen <yi.4.shen@nokia.com> · b5cbaed7
      yi.4.shen@nokia.com authored
              Reviewed by Eric Carlson.
      
              Clean up the Media Controls CSS for Qt
              https://bugs.webkit.org/show_bug.cgi?id=52822
      
              Split the audio::-webkit-media-xxx and video::-webkit-media-xxx rules
              in mediaControlsQt.css, and remove the duplicate audio::-webkit-media-xxx
              rules from mediaControlsQtFullscreen.css.
      
              * css/mediaControlsQt.css:
              (audio::-webkit-media-controls-panel):
              (video::-webkit-media-controls-panel):
              (audio::-webkit-media-controls-mute-button):
              (video::-webkit-media-controls-mute-button):
              (audio::-webkit-media-controls-play-button):
              (video::-webkit-media-controls-play-button):
              (audio::-webkit-media-controls-timeline-container):
              (video::-webkit-media-controls-timeline-container):
              (audio::-webkit-media-controls-current-time-display):
              (video::-webkit-media-controls-current-time-display):
              (audio::-webkit-media-controls-time-remaining-display):
              (video::-webkit-media-controls-time-remaining-display):
              (audio::-webkit-media-controls-timeline):
              (video::-webkit-media-controls-timeline):
              (audio::-webkit-media-controls-volume-slider-container):
              (video::-webkit-media-controls-volume-slider-container):
              (audio::-webkit-media-controls-volume-slider):
              (video::-webkit-media-controls-volume-slider):
              (audio::-webkit-media-controls-seek-back-button):
              (video::-webkit-media-controls-seek-back-button):
              (audio::-webkit-media-controls-seek-forward-button):
              (video::-webkit-media-controls-seek-forward-button):
              (audio::-webkit-media-controls-fullscreen-button):
              (video::-webkit-media-controls-fullscreen-button):
              (audio::-webkit-media-controls-rewind-button):
              (video::-webkit-media-controls-rewind-button):
              (audio::-webkit-media-controls-return-to-realtime-button):
              (video::-webkit-media-controls-return-to-realtime-button):
              (audio::-webkit-media-controls-toggle-closed-captions-button):
              (video::-webkit-media-controls-toggle-closed-captions-button):
              * css/mediaControlsQtFullscreen.css:
              (video::-webkit-media-controls-time-remaining-display):
              (video::-webkit-media-controls-seek-back-button):
              (video::-webkit-media-controls-seek-forward-button):
              (video::-webkit-media-controls-rewind-button):
              (video::-webkit-media-controls-return-to-realtime-button):
              (video::-webkit-media-controls-toggle-closed-captions-button):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5cbaed7
    • ojan@chromium.org's avatar
      2011-01-20 Ojan Vafai <ojan@chromium.org> · c60e7f83
      ojan@chromium.org authored
              Reviewed by Adam Barth.
      
              fix goofup in http://trac.webkit.org/changeset/76082
              https://bugs.webkit.org/show_bug.cgi?id=52830
      
              We were showing the revision number of the patch at the bottom
              of the diff and expanding from the bottom of the diff would fail.
      
              Also, removed an unused variable and scoped queries appropriatly
              to the file_diff they should have been operating on.
      
              * PrettyPatch/PrettyPatch.rb:
              * code-review.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76271 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c60e7f83
    • ojan@chromium.org's avatar
      2011-01-19 Ojan Vafai <ojan@chromium.org> · 1a0c4962
      ojan@chromium.org authored
              Reviewed by Adam Barth.
      
              [reviewtool] Add a link for annotated trac page on review page
              https://bugs.webkit.org/show_bug.cgi?id=52747
      
              -add line numbers to all trac links to the first line in the file diff
              -add annotate/review log links
              -make file-diff links other than the file name only show when you mouseover the filediff
              -fix white-space to only wrap the .text element and it's childen, any of it's siblings/parents
      
              * PrettyPatch/PrettyPatch.rb:
              * code-review.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76270 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a0c4962
    • rniwa@webkit.org's avatar
      2011-01-20 Ryosuke Niwa <rniwa@webkit.org> · d2fd033d
      rniwa@webkit.org authored
              Unreviewed Chromium rebaseline for r76236.
      
              * platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
              * platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76269 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2fd033d
    • ojan@chromium.org's avatar
      2011-01-14 Ojan Vafai <ojan@chromium.org> · 008dd4f2
      ojan@chromium.org authored
              Reviewed by Adam Barth.
      
              make line selection have a extend only from where you start the selection in the code review tool
              https://bugs.webkit.org/show_bug.cgi?id=52485
      
              * code-review.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76268 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      008dd4f2
    • kdecker@apple.com's avatar
      Reviewed by Anders Carlsson. · 562ac858
      kdecker@apple.com authored
              <rdar://problem/8880689> need a way to obtain the rendered rectangle for box elements
              https://bugs.webkit.org/show_bug.cgi?id=52823
              
              * WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
              (WKBundleNodeHandleGetRenderRect): Added new method that will return a rendered rectangle for box elements
              * WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h: Ditto.
              * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: Ditto.
              (WebKit::InjectedBundleNodeHandle::renderRect): Ditto.
              * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76267 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      562ac858
    • apavlov@chromium.org's avatar
      2011-01-20 Alexander Pavlov <apavlov@chromium.org> · b073cf74
      apavlov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: [REGRESSION] Canceling of CSS numeric values increment/decrement is broken
              https://bugs.webkit.org/show_bug.cgi?id=52816
      
              * inspector/front-end/StylesSidebarPane.js:
              (WebInspector.StylePropertyTreeElement.prototype):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76266 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b073cf74
    • commit-queue@webkit.org's avatar
      2011-01-20 Dawit Alemayehu <adawit@kde.org> · 6de04dae
      commit-queue@webkit.org authored
              Reviewed by Andreas Kling.
      
              [Qt] Fix Layering violation in MediaPlayerPrivateQt.
              https://bugs.webkit.org/show_bug.cgi?id=52733
      
              No new tests. no behavioral change.
      
             * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
              (WebCore::MediaPlayerPrivateQt::commitLoad):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6de04dae
    • japhet@chromium.org's avatar
      2011-01-20 Nate Chapin <japhet@chromium.org> · 243ab97a
      japhet@chromium.org authored
              Reviewed by Darin Fisher.
      
              [V8] Call malloc and memcpy directly instead of
              of strdup in convertV8ObjectToNPVariant() when
              converting strings. If there is a null character
              in the string, our use of strdup causes us to allocate
              too little memory, leading to out of bounds reads.
      
              https://bugs.webkit.org/show_bug.cgi?id=52631
      
              * bindings/v8/V8NPUtils.cpp:
              (WebCore::convertV8ObjectToNPVariant):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76264 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      243ab97a
    • abecsi@webkit.org's avatar
      2011-01-20 Andras Becsi <abecsi@webkit.org> · 30f524a6
      abecsi@webkit.org authored
              Reviewed by Csaba Osztrogonác.
      
              [Qt][WK2] WebKit2 enabled build fails to link
      
              Work around undefined reference linking issues until the buildsystem gets redesigned.
              These issues first occured in minimal builds (see BUG 50519).
      
              * JavaScriptCore.pri: link as whole-archive for WebKit2 builds
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      30f524a6
    • commit-queue@webkit.org's avatar
      2011-01-20 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com> · ab8d0167
      commit-queue@webkit.org authored
              Reviewed by Andreas Kling.
      
              Remove null ptr deref that happens when reattaching to
              a new web process.
      
              Implement didRelaunchProcess that sets the drawing area size
              after the drawing area is re-instantiated.
      
              [Qt][WK2] Null ptr deref in UI process after web process has crashed
              https://bugs.webkit.org/show_bug.cgi?id=52796
      
              * UIProcess/API/qt/qgraphicswkview.cpp:
              (QGraphicsWKView::QGraphicsWKView):
              * UIProcess/API/qt/qwkpage.cpp:
              (QWKPagePrivate::QWKPagePrivate):
              (QWKPagePrivate::init):
              (QWKPagePrivate::createDrawingAreaProxy):
              (QWKPagePrivate::didRelaunchProcess): Reset drawing area size after crash.
              * UIProcess/API/qt/qwkpage_p.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76262 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab8d0167
    • philn@webkit.org's avatar
      2011-01-20 Philippe Normand <pnormand@igalia.com> · 75e55b2f
      philn@webkit.org authored
              Unreviewed, remove GTK result for window-onerror2 as it's the same
              as the generic results file.
      
              * platform/gtk/fast/events/window-onerror2-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76261 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75e55b2f
    • andreas.kling@nokia.com's avatar
      2011-01-20 Andreas Kling <kling@webkit.org> · ff7f5455
      andreas.kling@nokia.com authored
              Reviewed by Ariya Hidayat.
      
              [Qt] Fill shadow scratch buffer with proper transparent pixels
      
              QImage::fill() has no Qt::GlobalColor overload in Qt 4.7 (coming in 4.8)
              so doing QImage::fill(Qt::transparent) will actually fill all pixels with
              the RGBA value 0x00000013.
      
              * platform/graphics/qt/ContextShadowQt.cpp:
              (WebCore::ShadowBuffer::scratchImage):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76260 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff7f5455
    • mjs@apple.com's avatar
      2011-01-20 Maciej Stachowiak <mjs@apple.com> · 7977a528
      mjs@apple.com authored
              Reviewed by Adam Roben.
      
              WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
              https://bugs.webkit.org/show_bug.cgi?id=42327
      
              * platform/mac-wk2/Skipped: Unskip the tests that needed this.
      2011-01-20  Maciej Stachowiak  <mjs@apple.com>
      
              Reviewed by Adam Roben.
      
              WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
              https://bugs.webkit.org/show_bug.cgi?id=42327
              
              Added a new API call, WKBundleFrameForJavaScriptContext, that gets the WKBundleFrameRef
              that corresponds to a JSContextRef (or null if none).
      
              * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
              (WKBundleFrameForJavaScriptContext): Simple wrapper, defers to a WebFrame
              static method.
              * WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
              * WebProcess/WebPage/WebFrame.cpp:
              (WebKit::WebFrame::frameForContext): Follow the maze of twisty pointers.
              * WebProcess/WebPage/WebFrame.h:
      2011-01-20  Maciej Stachowiak  <mjs@apple.com>
      
              Reviewed by Adam Roben.
      
              WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
              https://bugs.webkit.org/show_bug.cgi?id=42327
      
              * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
              for methods that take their normal arguments but also a JSContextRef.
              * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
              for evaluateScriptInIsolatedWorld.
              * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
              (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
              this call is for an isolated world.
              * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
              (WTR::worldMap): Helper to create a world map.
              (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
              (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
              added LayoutTestController API.
              * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76259 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7977a528
    • aroben@apple.com's avatar
      Remove WKCACFContextFlusher · bc7c2770
      aroben@apple.com authored
      It wasn't doing anything.
      
      Fixes <http://webkit.org/b/52752> WKCACFContextFlusher is unused
      
      Reviewed by Simon Fraser.
      
      * WebCore.vcproj/WebCore.vcproj: Removed WKCACFContextFlusher. Also let VS have its way with
      the file.
      
      * platform/graphics/win/WKCACFContextFlusher.cpp: Removed.
      * platform/graphics/win/WKCACFContextFlusher.h: Removed.
      
      * platform/graphics/win/WKCACFLayerRenderer.cpp:
      (WebCore::WKCACFLayerRenderer::~WKCACFLayerRenderer):
      (WebCore::WKCACFLayerRenderer::layerTreeDidChange):
      Stop telling WKCACFContextFlusher about our context, since it never did anything with it.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76258 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc7c2770
    • aroben@apple.com's avatar
      Only flush our own context when we get resized · 862e3837
      aroben@apple.com authored
      Fixes <http://webkit.org/b/52751> All WKCACFContexts with uncommitted
      changes get flushed whenever any composited page is resized
      
      Reviewed by Simon Fraser.
      
      * platform/graphics/win/WKCACFLayerRenderer.cpp:
      (WebCore::WKCACFLayerRenderer::resize): Just flush our own context, not all contexts
      WKCACFContextFlusher knows about. After all, ours is the only one that just got resized!
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76257 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      862e3837
    • aroben@apple.com's avatar
      Make WKCACFLayerRenderer ref-counted · a60ce714
      aroben@apple.com authored
      This will be needed to handle cases where the client might release its reference to us while
      we're calling out to it.
      
      WKCACFLayerRenderer now has a setClient function, which is used rather than passing the
      client to create(). This allows clients to null out the client pointer when they're done
      with the renderer.
      
      Fixes <http://webkit.org/b/52749> WKCACFLayerRenderer should be
      ref-counted
      
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
      (WebCore::MediaPlayerPrivateFullscreenWindow::MediaPlayerPrivateFullscreenWindow):
      * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:
      Updated for WKCACFLayerRenderer changes.
      
      * platform/graphics/win/WKCACFLayerRenderer.cpp:
      (WebCore::WKCACFLayerRenderer::acceleratedCompositingAvailable): Updated for changes to
      create().
      (WebCore::WKCACFLayerRenderer::create): No longer takes a WKCACFLayerRendererClient. Now
      returns a PassOwnPtr.
      (WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): No longer takes a
      WKCACFLayerRendererClient.
      
      * platform/graphics/win/WKCACFLayerRenderer.h: Made WKCACFLayerRenderer inherit from
      RefCounted.
      (WebCore::WKCACFLayerRenderer::setClient): Added this simple setter.
      
      Source/WebKit/win:
      
      Update for WKCACFLayerRenderer changes
      
      * WebView.cpp:
      (WebView::~WebView): Added some assertions to make sure we've gotten rid of our
      compositing-related members. My biggest concern was making sure that m_layerRenderer was
      gone, which would also mean we had nulled out its client pointer.
      (WebView::setAcceleratedCompositing): Changed to call WKCACFLayerRenderer::setClient instead
      of passing the client into create(), and to clear out the client before nulling out
      m_layerRenderer.
      
      * WebView.h: Changed m_layerRenderer from an OwnPtr to a RefPtr.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76256 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a60ce714
    • aroben@apple.com's avatar
      Convert paths in environment variables back to msys-style inside commit-log-editor · 16f98219
      aroben@apple.com authored
      When this script gets run from inside git commit, msys-style paths in the environment will
      have been turned into Windows-style paths with forward slashes. This screws up functions
      like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
      the paths back to msys-style before doing anything else.
      
      Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
      using msysgit's Perl and multiple ChangeLogs have been edited
      
      Reviewed by David Kilzer.
      
      * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
      (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
      inside git commit), convert Windows-style paths in the environment back to msys-style paths.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76255 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16f98219
    • aroben@apple.com's avatar
      Teach WebView::scrollBackingStore about compositing mode · 622c8364
      aroben@apple.com authored
      Test:
          compositing/scroll-painted-composited-content.html
      
      Fixes <http://webkit.org/b/52720> REGRESSION (r75987): Assertion failure in
      WebView::scrollBackingStore when scrolling page with composited content
      
      Reviewed by Anders Carlsson.
      
      Source/WebKit/win:
      
      * WebView.cpp:
      (WebView::scrollBackingStore): Do something sensible (though naive) when in compositing
      mode, rather than incorrectly asserting that this function is never called in that case. For
      now we just repaint the entire scrolled region; someday hopefully we can avoid having to
      repaint the areas that have just been moved.
      
      LayoutTests:
      
      Add a test that scrolls composited content that has already been painted
      
      * compositing/scroll-painted-composited-content.html: Added.
      * compositing/scroll-painted-composited-content-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76254 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      622c8364
    • zoltan@webkit.org's avatar
      [Win] Unreviewed build fix after r76248. · 18a6fc4c
      zoltan@webkit.org authored
      * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76253 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18a6fc4c