1. 12 Nov, 2009 2 commits
    • aroben@apple.com's avatar
      Replace worldIDs with world objects · f6cbb76a
      aroben@apple.com authored
      Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
      user scripts/stylesheets and isolated worlds
      
      Reviewed by Sam Weinig.
      
      WebCore:
      
      Covered by existing tests.
      
      * WebCore.base.exp: Update exported symbols to match what now exists
      and is needed by WebKit.
      
      * bindings/js/ScheduledAction.cpp:
      (WebCore::ScheduledAction::execute): Updated for function rename.
      
      * bindings/js/ScriptController.cpp: Removed code that dealt with
      worldIDs.
      (WebCore::ScriptController::createWorld): Added. Returns a new world
      suitable for use on the main thread.
      (WebCore::ScriptController::executeScriptInWorld): Renamed from
      executeScriptInIsolatedWorld, since this works just fine with a
      "normal" world.
      
      * bindings/js/ScriptController.h: Added createWorld, removed functions
      that took worldIDs, renamed executeScriptInIsolatedWorld to
      executeScriptInWorld.
      
      * page/Frame.cpp:
      (WebCore::Frame::injectUserScripts):
      (WebCore::Frame::injectUserScriptsForWorld):
      Updated for changes to UserScriptMap and ScriptController.
      
      * page/Frame.h: Changed injectUserScriptsForWorld to take a
      DOMWrapperWorld* instead of a worldID.
      
      * page/PageGroup.cpp:
      (WebCore::PageGroup::addUserScriptToWorld):
      (WebCore::PageGroup::addUserStyleSheetToWorld):
      (WebCore::PageGroup::removeUserScriptFromWorld):
      (WebCore::PageGroup::removeUserStyleSheetFromWorld):
      (WebCore::PageGroup::removeUserScriptsFromWorld):
      (WebCore::PageGroup::removeUserStyleSheetsFromWorld):
      * page/PageGroup.h:
      Changed these functions to take a DOMWrapperWorld* instead of a
      worldID. Also updated for changes to UserScript and UserStyleSheet.
      
      * page/UserScript.h:
      * page/UserStyleSheet.h: Changed not to hold a worldID, since it was
      never used.
      
      * page/UserScriptTypes.h:
      * page/UserStyleSheetTypes.h: Changed UserScriptMap and
      UserStyleSheetMap to use a RefPtr<DOMWrapperWorld> instead of a
      worldID as their key type.
      
      WebKit:
      
      * WebKit.xcodeproj/project.pbxproj: Added WebScriptWorld to the project.
      
      WebKit/mac:
      
      WebScriptWorld is the new object that represents a world.  The only
      place worldID is still used is in -[WebFrame
      _stringByEvaluatingJavaScriptInIsolatedWorld:WithGlobalObject:FromString:],
      but that will change soon.
      
      * WebKit.exp: Export WebScriptWorld.
      
      * WebView/WebFrame.mm:
      (-[WebFrame _stringByEvaluatingJavaScriptInIsolatedWorld:WithGlobalObject:FromString:]):
      Moved the bizarre world caching/creation logic that DRT depends on
      here from the findWorld function in ScriptController.cpp. Updated to
      use ScriptController::executeScriptInWorld instead of
      ScriptController::executeScriptInIsolatedWorld.
      (-[WebFrame _contextForWorld:]): Renamed from contextForWorldID:. Now
      takes a WebScriptWorld.
      
      * WebView/WebFramePrivate.h: Replaced contextForWorldID: with
      _contextForWorld:.
      
      * WebView/WebScriptWorld.h: Added.
      * WebView/WebScriptWorld.mm: Added.
      (-[WebScriptWorld initWithWorld:]): Store the passed-in world in our
      _private member.
      (-[WebScriptWorld init]): Create a new DOMWrapperWorld and pass it to
      -initWithWorld:.
      (-[WebScriptWorld dealloc]): Release _private.
      (+[WebScriptWorld standardWorld]): Returns a shared instance that
      represents WebCore's mainThreadNormalWorld().
      (+[WebScriptWorld world]): Returns a new instance.
      (core): Returns the DOMWrapperWorld for this WebScriptWorld.
      
      * WebView/WebScriptWorldInternal.h: Added.
      
      * WebView/WebView.mm:
      (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:]):
      (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:]):
      (+[WebView _removeUserScriptFromGroup:world:url:]):
      (+[WebView _removeUserStyleSheetFromGroup:world:url:]):
      (+[WebView _removeUserScriptsFromGroup:world:]):
      (+[WebView _removeUserStyleSheetsFromGroup:world:]):
      * WebView/WebViewPrivate.h:
      Changed these functions to take a WebScriptWorld instead of a worldID.
      
      WebKit/win:
      
      WebScriptWorld is the new object that represents a world.  The only
      place worldID is still used is in
      IWebFramePrivate::stringByEvaluatingJavaScriptInIsolatedWorld, but
      that will change soon.
      
      * ForEachCoClass.h: Added WebScriptWorld.
      
      * Interfaces/IWebFramePrivate.idl: Replaced contextForWorldID with
      contextForWorld.
      
      * Interfaces/IWebScriptWorld.idl: Added.
      
      * Interfaces/IWebViewPrivate.idl: Changed the user script/stylesheet
      functions to take an IWebScriptWorld instead of a worldID.
      
      * Interfaces/WebKit.idl: Added WebScriptWorld.
      
      * WebFrame.cpp:
      (WebFrame::contextForWorld): Renamed from contextForWorldID. Now takes
      an IWebScriptWorld.
      (WebFrame::stringByEvaluatingJavaScriptInIsolatedWorld): Moved the
      bizarre world caching/creation logic that DRT depends on here from the
      findWorld function in ScriptController.cpp. Updated to use
      ScriptController::executeScriptInWorld instead of
      ScriptController::executeScriptInIsolatedWorld.
      
      * WebFrame.h: Replaced contextForWorldID with contextForWorld.
      
      * WebScriptWorld.cpp: Added.
      (WebScriptWorld::WebScriptWorld):
      (WebScriptWorld::~WebScriptWorld):
      (WebScriptWorld::createInstance):
      (WebScriptWorld::AddRef):
      (WebScriptWorld::Release):
      (WebScriptWorld::QueryInterface):
      Standard COM class implementations.
      
      (WebScriptWorld::standardWorld): Returns a shared instance that represents
      WebCore's mainThreadNormalWorld().
      
      * WebScriptWorld.h: Added.
      (WebScriptWorld::world): Simple getter.
      
      * WebKit.vcproj/Interfaces.vcproj: Added IWebScriptWorld.idl.
      
      * WebKit.vcproj/WebKit.vcproj: Added WebScriptWorld.
      
      * WebKitClassFactory.cpp: Added WebScriptWorld.
      
      * WebView.cpp:
      (WebView::addUserScriptToGroup):
      (WebView::addUserStyleSheetToGroup):
      (WebView::removeUserScriptFromGroup):
      (WebView::removeUserStyleSheetFromGroup):
      (WebView::removeUserScriptsFromGroup):
      (WebView::removeUserStyleSheetsFromGroup):
      * WebView.h:
      Changed these functions to take an IWebScriptWorld instead of a worldID.
      
      WebKitTools:
      
      * DumpRenderTree/mac/LayoutTestControllerMac.mm:
      (LayoutTestController::addUserScript):
      (LayoutTestController::addUserStyleSheet):
      * DumpRenderTree/win/LayoutTestControllerWin.cpp:
      (LayoutTestController::addUserScript):
      (LayoutTestController::addUserStyleSheet):
      Changed these functions to create a new WebJSWorld each time they're
      called and to pass that world to WebKit.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50907 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6cbb76a
    • eric@webkit.org's avatar
      2009-11-12 Chris Fleizach <cfleizach@apple.com> · 68301d90
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              ARIA: add alert type roles
              https://bugs.webkit.org/show_bug.cgi?id=31392
      
              * platform/mac/accessibility/aria-alerts-expected.txt: Added.
              * platform/mac/accessibility/aria-alerts.html: Added.
      2009-11-12  Chris Fleizach  <cfleizach@apple.com>
      
              Reviewed by Darin Adler.
      
              ARIA: add alert type roles
              https://bugs.webkit.org/show_bug.cgi?id=31392
      
              Test: platform/mac/accessibility/aria-alerts.html
      
              * accessibility/AccessibilityObject.h:
              * accessibility/AccessibilityRenderObject.cpp:
              * accessibility/mac/AccessibilityObjectWrapper.mm:
      2009-11-12  Chris Fleizach  <cfleizach@apple.com>
      
              Reviewed by Darin Adler.
      
              ARIA: add alert type roles
              https://bugs.webkit.org/show_bug.cgi?id=31392
      
              * English.lproj/Localizable.strings:
              * StringsNotToBeLocalized.txt:
      2009-11-12  Chris Fleizach  <cfleizach@apple.com>
      
              Reviewed by Darin Adler.
      
              ARIA: add alert type roles
              https://bugs.webkit.org/show_bug.cgi?id=31392
      
              * WebCoreSupport/WebViewFactory.mm:
              (-[WebViewFactory AXARIAContentGroupText:]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50883 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68301d90
  2. 10 Nov, 2009 3 commits
    • dbates@webkit.org's avatar
      2009-11-10 Daniel Bates <dbates@webkit.org> · 03eecfa1
      dbates@webkit.org authored
              Reviewed by Oliver Hunt.
      
              https://bugs.webkit.org/show_bug.cgi?id=30754
      
              Patch 2 of 2.
      
              Removed method EventHandler::dragSourceMovedTo, since it is no longer
              needed. This method fired a drag event whenever the mouse moved, but
              section 7.9.4 of the HTML 5 spec. defines the drag-and-drop processing
              model independent of when the mouse moves. See "Among other changes..."
              in the change log for patch 1 for more details.
      
              * WebCore.DragSupport.exp:
              * page/EventHandler.cpp: Removed method EventHandler::dragSourceMovedTo.
              (WebCore::EventHandler::handleDrag): Updated comment about reentrancy issue.
              * page/EventHandler.h:
      
      2009-11-10  Daniel Bates  <dbates@webkit.org>
      
              Reviewed by Oliver Hunt.
      
              https://bugs.webkit.org/show_bug.cgi?id=30754
      
              Removed method draggedImage:movedTo:
      
              * WebView/WebFrame.mm:
              * WebView/WebFrameInternal.h:
              * WebView/WebHTMLView.mm:
      
      2009-11-10  Daniel Bates  <dbates@webkit.org>
      
              Reviewed by Oliver Hunt.
      
              https://bugs.webkit.org/show_bug.cgi?id=30754
      
              Modified WebDropSource::QueryContinueDrag so as to not call EventHandler::dragSourceMovedTo.
      
              * WebDropSource.cpp:
              (WebDropSource::QueryContinueDrag): Removed call to EventHandler::dragSourceMovedTo.
      
      2009-11-10  Daniel Bates  <dbates@webkit.org>
      
              Reviewed by Oliver Hunt.
      
              https://bugs.webkit.org/show_bug.cgi?id=30754
      
              Patch 1 of 2.
      
              As per Section 7.9.4 of the HTML 5 spec. <http://dev.w3.org/html5/spec/Overview.html#drag-and-drop-processing-model>,
              the drag event should always fire before the dragover event.
      
              In fixing this bug, this patch also makes our drag processing model
              conform to the HTML 5 spec.
      
              Among the changes, this patch ensures that the drag event isn't fired outside
              of the drag-and-drop processing loop, WebCore::EventHandler::updateDragAndDrop.
              Currently, the drag event is fired whenever the mouse button is down and the OS
              detects the mouse moved. But, as per the spec, the drag event should
              fire approx. every 350ms so long as the mouse button is down.
      
              Test: fast/events/drag-and-drop-fire-drag-dragover.html
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::clear):
              (WebCore::EventHandler::canHandleDragAndDropForTarget): Formerly named handleDragAndDropForTarget.
              Modified to determine when we are in the correct instance of EventHandler to service the drag
              and drop operation.
              (WebCore::EventHandler::updateDragAndDrop): Moved code from WebCore::EventHandler::dragSourceMovedTo
              into this method.
              (WebCore::EventHandler::cancelDragAndDrop):
              (WebCore::EventHandler::performDragAndDrop):
              (WebCore::EventHandler::clearDragState):
              * page/EventHandler.h: Added field m_shouldOnlyFireDragOverEvent to determine whether
              we should fire both drag and dragover events or only the dragover event.
      
      2009-11-10  Daniel Bates  <dbates@webkit.org>
      
              Reviewed by Oliver Hunt.
      
              https://bugs.webkit.org/show_bug.cgi?id=30754
      
              Tests that the drag event always fires before the dragover event.
      
              Also, re-bases the result for test fast/events/drag-in-frames.html, since
              we now conform to the HTML 5 spec.
      
              * fast/events/drag-and-drop-fire-drag-dragover-expected.txt: Added.
              * fast/events/drag-and-drop-fire-drag-dragover.html: Added.
              * fast/events/drag-in-frames-expected.txt: Rebased result.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03eecfa1
    • bdakin@apple.com's avatar
      WebCore: Fix for <rdar://problem/7059710> · 4a0593e3
      bdakin@apple.com authored
      -and corresponding-
      https://bugs.webkit.org/show_bug.cgi?id=31196 Implement -webkit-
      color-correction for CSS colors
      
      Reviewed by Darin Adler.
      
      New exported symbol for GraphicsContext::fillColor() which now 
      accepts a ColorSpace as an optional parameter.
      * WebCore.base.exp:
      
      Added a new file, ColorSpace.h, to define the ColorSpace enum.
      * WebCore.xcodeproj/project.pbxproj:
      
      Computed Style for -webkit-color-correction
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::):
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      
      Parse -webkit-color-correction
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseValue):
      
             Map CSS identifiers to the appropriate values of the ColorSpace enum
      * css/CSSPrimitiveValueMappings.h:
      (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
      (WebCore::CSSPrimitiveValue::operator ColorSpace):
      
      New property -webkit-color-correction
      * css/CSSPropertyNames.in:
      
      Map -webkit-color-correction into the RenderStyle.
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::applyProperty):
      
      Add new value sRGB.
      * css/CSSValueKeywords.in:
      
      Comment out the reference to sRGB since it will now be inherited as 
      a value from CSSValueKeywords.
      * css/SVGCSSValueKeywords.in:
      
      Definition of the ColorSpace enum.
      * platform/graphics/ColorSpace.h: Added.
      (WebCore::):
      
      These functions all now take a ColorSpace as a parameter.
      * platform/graphics/GraphicsContext.cpp:
      (WebCore::GraphicsContext::setStrokeColor):
      (WebCore::GraphicsContext::setFillColor):
      (WebCore::GraphicsContext::drawHighlightForText):
      
      Return the appropriate ColorSpace.
      (WebCore::GraphicsContext::strokeColorSpace):
      (WebCore::GraphicsContext::fillColorSpace):
      
      These functions all call other functions which require a ColorSpace 
      as a parameter.
      (WebCore::GraphicsContext::setStrokePattern):
      (WebCore::GraphicsContext::setFillPattern):
      (WebCore::GraphicsContext::setStrokeGradient):
      (WebCore::GraphicsContext::setFillGradient):
      
      All of the GraphicsContext functions that take a Color should now 
      also take a ColorSpace.
      * platform/graphics/GraphicsContext.h:
      
      Added new member variables stokeColorSpace and fillColorSpace.
      * platform/graphics/GraphicsContextPrivate.h:
      (WebCore::GraphicsContextState::GraphicsContextState):
      
      Attempt to keep the Cairo port building with all of the massive 
      changes to GraphicsContext.        
      * platform/graphics/cairo/GraphicsContextCairo.cpp:
      (WebCore::GraphicsContext::fillRect):
      (WebCore::GraphicsContext::setPlatformFillColor):
      (WebCore::GraphicsContext::setPlatformStrokeColor):
      (WebCore::GraphicsContext::fillRoundedRect):
      
              
      * platform/graphics/cg/GraphicsContextCG.cpp:
      (WebCore::sRGBColorSpaceRef): New static function that returns a 
      CGColorSpaceRef for the sRGB color space.
      (WebCore::deviceRGBColorSpaceRef): New static function that returns 
      a CGColorSpaceRef for the device RGB color space.
      
      (WebCore::setCGFillColor): Now takes a ColorSpace parameter and 
      sets the fill color to the specified color in the given ColorSpace.
      (WebCore::setCGStrokeColor): Same, but for stroke.
      
      (WebCore::setCGFillColorSpace): New static to set the 
      CGFillColorSpace to the given ColorSpace
      (WebCore::setCGStrokeColorSpace): Same, but for stroke.
      
      Send ColorSpaces when appropriate, set ColorSpaces when 
      appropriate, and check ColorSpaces when appropriate.
      (WebCore::GraphicsContext::GraphicsContext):
      (WebCore::GraphicsContext::drawRect):
      (WebCore::GraphicsContext::drawLine):
      (WebCore::GraphicsContext::fillPath):
      (WebCore::GraphicsContext::strokePath):
      (WebCore::GraphicsContext::fillRect):
      (WebCore::GraphicsContext::fillRoundedRect):
      (WebCore::GraphicsContext::strokeRect):
      (WebCore::GraphicsContext::drawLineForText):
      (WebCore::GraphicsContext::setPlatformStrokeColor):
      (WebCore::GraphicsContext::setPlatformFillColor):
      
      Attempt to keep Haiku building.
      * platform/graphics/haiku/GraphicsContextHaiku.cpp:
      (WebCore::GraphicsContext::fillRect):
      (WebCore::GraphicsContext::fillRoundedRect):
      (WebCore::GraphicsContext::setPlatformStrokeColor):
      (WebCore::GraphicsContext::setPlatformFillColor):
      
      Attempt to keep QT building.
      * platform/graphics/qt/GraphicsContextQt.cpp:
      (WebCore::GraphicsContext::fillRect):
      (WebCore::GraphicsContext::fillRoundedRect):
      (WebCore::GraphicsContext::setPlatformStrokeColor):
      (WebCore::GraphicsContext::setPlatformFillColor):
      
      Attempt to keep Wince building.
      * platform/graphics/wince/GraphicsContextWince.cpp:
      (WebCore::GraphicsContext::fillRect):
      (WebCore::GraphicsContext::setPlatformFillColor):
      (WebCore::GraphicsContext::setPlatformStrokeColor):
      (WebCore::GraphicsContext::clearRect):
      (WebCore::GraphicsContext::fillRoundedRect):
      (WebCore::GraphicsContext::setPlatformShadow):
      
      Attempt to keep WX building.
      * platform/graphics/wx/GraphicsContextWx.cpp:
      (WebCore::GraphicsContext::fillRect):
      (WebCore::GraphicsContext::fillRoundedRect):
      (WebCore::GraphicsContext::setPlatformStrokeColor):
      (WebCore::GraphicsContext::setPlatformFillColor):
      
      Added functions colorSpace() and setColorSpace()
      * rendering/style/RenderStyle.h:
      (WebCore::InheritedFlags::colorSpace):
      (WebCore::InheritedFlags::setColorSpace):
      
      The ColorSpace is stored here.
      * rendering/style/StyleRareInheritedData.cpp:
      (WebCore::StyleRareInheritedData::StyleRareInheritedData):
      (WebCore::StyleRareInheritedData::operator==):
      * rendering/style/StyleRareInheritedData.h:
      
      All of these call sites call GraphicsContext functions which now 
      require ColorSpaces.
      * editing/SelectionController.cpp:
      (WebCore::SelectionController::paintCaret):
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore::CanvasRenderingContext2D::drawTextInternal):
      * html/canvas/CanvasStyle.cpp:
      (WebCore::CanvasStyle::applyStrokeColor):
      (WebCore::CanvasStyle::applyFillColor):
      * inspector/InspectorController.cpp:
      (WebCore::drawOutlinedQuad):
      * page/FrameView.cpp:
      (WebCore::FrameView::paintContents):
      * platform/ScrollbarTheme.h:
      (WebCore::ScrollbarTheme::paintScrollCorner):
      * platform/ScrollbarThemeComposite.cpp:
      (WebCore::ScrollbarThemeComposite::paintScrollCorner):
      * platform/graphics/Image.cpp:
      (WebCore::Image::fillWithSolidColor):
      * platform/graphics/mac/FontMac.mm:
      (WebCore::Font::drawGlyphs):
      * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
      (WebCore::MediaPlayerPrivate::paint):
      * rendering/EllipsisBox.cpp:
      (WebCore::EllipsisBox::paint):
      * rendering/InlineFlowBox.cpp:
      (WebCore::InlineFlowBox::paintTextDecorations):
      * rendering/InlineTextBox.cpp:
      (WebCore::updateGraphicsContext):
      (WebCore::paintTextWithShadows):
      (WebCore::InlineTextBox::paint):
      (WebCore::InlineTextBox::paintSelection):
      (WebCore::InlineTextBox::paintCompositionBackground):
      (WebCore::InlineTextBox::paintDecoration):
      (WebCore::InlineTextBox::paintTextMatchMarker):
      (WebCore::InlineTextBox::paintCompositionUnderline):
      * rendering/InlineTextBox.h:
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::fillHorizontalSelectionGap):
      (WebCore::RenderBlock::fillVerticalSelectionGap):
      (WebCore::RenderBlock::fillLeftSelectionGap):
      (WebCore::RenderBlock::fillRightSelectionGap):
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::paintFillLayerExtended):
      (WebCore::RenderBoxModelObject::paintBoxShadow):
      * rendering/RenderFileUploadControl.cpp:
      (WebCore::RenderFileUploadControl::paintObject):
      * rendering/RenderFrameSet.cpp:
      (WebCore::RenderFrameSet::paintColumnBorder):
      (WebCore::RenderFrameSet::paintRowBorder):
      * rendering/RenderImage.cpp:
      (WebCore::RenderImage::paintReplaced):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::paintScrollCorner):
      (WebCore::RenderLayer::paintResizer):
      * rendering/RenderListBox.cpp:
      (WebCore::RenderListBox::paintItemForeground):
      (WebCore::RenderListBox::paintItemBackground):
      * rendering/RenderListMarker.cpp:
      (WebCore::RenderListMarker::paint):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::drawLineForBoxSide):
      (WebCore::RenderObject::drawArcForBoxSide):
      * rendering/RenderReplaced.cpp:
      (WebCore::RenderReplaced::paint):
      * rendering/RenderScrollbarTheme.cpp:
      (WebCore::RenderScrollbarTheme::paintScrollCorner):
      * rendering/RenderThemeMac.mm:
      (WebCore::RenderThemeMac::paintMenuListButton):
      * rendering/RenderView.cpp:
      (WebCore::RenderView::paintBoxDecorations):
      * rendering/RenderWidget.cpp:
      (WebCore::RenderWidget::paint):
      * rendering/SVGInlineTextBox.cpp:
      (WebCore::SVGInlineTextBox::paintSelection):
      * svg/graphics/SVGPaintServerGradient.cpp:
      (WebCore::SVGPaintServerGradient::setup):
      * svg/graphics/SVGPaintServerSolid.cpp:
      (WebCore::SVGPaintServerSolid::setup):
      
      WebKit/mac: Small WebKit part of:
      Fix for <rdar://problem/7059710> 
      -and corresponding-
      https://bugs.webkit.org/show_bug.cgi?id=31196 Implement -webkit-
      color-correction for CSS colors
      
      Reviewed by Darin Adler.
      
      * Misc/WebKitNSStringExtras.mm:
      (-[NSString _web_drawAtPoint:font:textColor:]): setFillColor now 
      requires callers to pass a ColorSpace.
      
      LayoutTests: Tests for <rdar://problem/7059710> 
      -and corresponding-
      https://bugs.webkit.org/show_bug.cgi?id=31196 Implement -webkit-
      color-correction for CSS colors
      
      Reviewed by Darin Adler.
      
      New tests.
      * fast/css/color-correction-backgrounds-and-text.html: Added.
      * fast/css/color-correction-on-backgrounds.html: Added.
      * fast/css/color-correction-on-text.html: Added.
      * fast/css/color-correction.html: Added.
      * fast/css/parsing-color-correction-expected.txt: Added.
      * fast/css/parsing-color-correction.html: Added.
      * fast/css/resources/parsing-color-correction.js: Added.
      (test):
      * fast/css/resources/purple-srgb.png: Added.
      * platform/mac/fast/css/color-correction-backgrounds-and-text-expected.checksum: Added.
      * platform/mac/fast/css/color-correction-backgrounds-and-text-expected.png: Added.
      * platform/mac/fast/css/color-correction-backgrounds-and-text-expected.txt: Added.
      * platform/mac/fast/css/color-correction-expected.checksum: Added.
      * platform/mac/fast/css/color-correction-expected.png: Added.
      * platform/mac/fast/css/color-correction-expected.txt: Added.
      * platform/mac/fast/css/color-correction-on-backgrounds-expected.checksum: Added.
      * platform/mac/fast/css/color-correction-on-backgrounds-expected.png: Added.
      * platform/mac/fast/css/color-correction-on-backgrounds-expected.txt: Added.
      * platform/mac/fast/css/color-correction-on-text-expected.checksum: Added.
      * platform/mac/fast/css/color-correction-on-text-expected.png: Added.
      * platform/mac/fast/css/color-correction-on-text-expected.txt: Added.
      
      New and improved results.
      * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * svg/css/getComputedStyle-basic-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a0593e3
    • mitz@apple.com's avatar
      WebCore: WebCore part of making full-screen video pause during scrubbing. · 362023c1
      mitz@apple.com authored
      Reviewed by Eric Carlson and Darin Adler.
      
      * WebCore.Video.exp: Sorted and added HTMLMediaElement::beginScrubbing()
      and HTMLMediaElement::endScrubbing().
      
      WebKit/mac: WebKit part of making full-screen video pause during scrubbing.
      
      Reviewed by Eric Carlson and Darin Adler.
      
      * WebView/WebVideoFullscreenHUDWindowController.h: Added _isScrubbing
      ivar.
      * WebView/WebVideoFullscreenHUDWindowController.mm:
      (-[WebVideoFullscreenHUDWindowController dealloc]): Assert that
      _isScrubbing is NO.
      (-[WebVideoFullscreenHUDWindowController endScrubbing]): Call
      HTMLMediaElement::endScrubbing().
      (-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
      If scrubbing has just begun, call HTMLMediaElement::beginScrubbing()
      and schedule -endScrubbing to be called when mouse tracking ends.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50753 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      362023c1
  3. 09 Nov, 2009 1 commit
  4. 08 Nov, 2009 1 commit
    • mitz@apple.com's avatar
      Made the full-screen video HUD appear when playback stops, such as when · e0ff32d3
      mitz@apple.com authored
      the end of the video is reached.
      
      Reviewed by Eric Carlson.
      
      * WebView/WebVideoFullscreenHUDWindowController.h: Cleaned up.
      * WebView/WebVideoFullscreenHUDWindowController.mm:
      (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]): Updated
      for the renaming of -updateRate to -updatePlayButton.
      (-[WebVideoFullscreenHUDWindowController updatePlayButton]): Renamed
      -updateRate to this.
      (-[WebVideoFullscreenHUDWindowController updateRate]): This method now
      responds to changes to the playback rate by updating the play button
      and showing or hiding the HUD as necessary.
      (-[WebVideoFullscreenHUDWindowController togglePlaying:]): Now only
      toggles playing. UI updates are driven by -updateRate being called.
      (-[WebVideoFullscreenHUDWindowController playing]): Cleaned up.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0ff32d3
  5. 02 Nov, 2009 4 commits
    • eric.carlson@apple.com's avatar
      2009-11-02 Eric Carlson <eric.carlson@apple.com> · c8c0bd5c
      eric.carlson@apple.com authored
              Reviewed by John Sullivan and Mark Rowe.
      
              <rdar://problem/7356733> Voiceover does not read correct media controller time values
              
              Fix localized strings for media controller time values.
      
              * English.lproj/Localizable.strings:
      
      2009-11-02  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by John Sullivan and Mark Rowe.
      
              <rdar://problem/7356733> Voiceover does not read correct media controller time values
      
              * WebCoreSupport/WebViewFactory.mm:
              (-[WebViewFactory localizedMediaTimeDescription:]):
      
      2009-11-02  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by John Sullivan and Mark Rowe.
      
              <rdar://problem/7356733> Voiceover does not read correct media controller time values
      
              * WebCoreLocalizedStrings.cpp:
              (WebCore::localizedMediaTimeDescription):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50429 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8c0bd5c
    • mitz@apple.com's avatar
      Made the remaining time display show negative zero at the end of the · 12da8133
      mitz@apple.com authored
      video.
      
      Reviewed by Anders Carlsson.
      
      Made other cleanup.
      
      * WebView/WebVideoFullscreenHUDWindowController.h: Reverted the types of
      _timeline and _volumeSlider to the more generic NSControl.
      * WebView/WebVideoFullscreenHUDWindowController.mm:
      (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]): Cleaned
      up style.
      (-[WebVideoFullscreenHUDWindowController windowDidLoad]): Added an
      assertion that the cast to NSButton * is legal. Removed casts.
      (-[WebVideoFullscreenHUDWindowController updateTime]): Use
      -setValue:forKey: instead of an NSSlider method.
      (timeToString): Changed to support only non-negative values and
      simplified.
      (-[WebVideoFullscreenHUDWindowController remainingTimeText]): Always
      prepend a “-” to the time.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50426 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      12da8133
    • mitz@apple.com's avatar
      WebKit/mac: WebKit part of making the appearance of the full-screen video HUD match · 36413e0b
      mitz@apple.com authored
      QuickTime Player X’s HUD.
      
      Reviewed by John Sullivan.
      
      * WebView/WebVideoFullscreenHUDWindowController.h: Removed unnecessary
      #import statements, cleaned up style, and changed _timeline,
      _volumeSlider and _playButton to have more specific types.
      * WebView/WebVideoFullscreenHUDWindowController.mm: Updated #import
      statements.
      (webkit_CGFloor): Added this helper function.
      (-[WebVideoFullscreenHUDWindowController init]): Cleaned up style.
      (createTimeTextField): Changed to use the bold system font.
      (-[WebVideoFullscreenHUDWindowController windowDidLoad]): Changed the
      subviews’ metrics and the text fields’ text alignment.
      (-[WebVideoFullscreenHUDWindowController updateTime]): Avoid conversion
      from double to float.
      (stringToTimeTextAttributed): Removed this useless function that
      returned an NSAttributedString masquerading as an NSString.
      (-[WebVideoFullscreenHUDWindowController remainingTimeText]): Removed
      call to stringToTimeTextAttributed().
      (-[WebVideoFullscreenHUDWindowController elapsedTimeText]): Ditto.
      
      WebKitLibraries: WebKitSystemInterface part of making the appearance of the full-screen video HUD match
      QuickTime Player X’s HUD.
      
      Reviewed by John Sullivan.
      
      * libWebKitSystemInterfaceLeopard.a:
      * libWebKitSystemInterfaceSnowLeopard.a:
      * libWebKitSystemInterfaceTiger.a:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50410 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36413e0b
    • cfleizach@apple.com's avatar
      Support ARIA "tab" roles · 60f0160e
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=30842
      
      Reviewed by Beth Dakin.
      
      WebCore: 
      
      Implement support for ARIA "tab", "tabpanel" and "tablist".
      As a consequence, we also needed to implement aria-selected
      and aria-controls.
      
      Tests: accessibility/aria-controls-with-tabs.html
             accessibility/aria-tab-roles.html
      
      * accessibility/AXObjectCache.cpp:
      * accessibility/AccessibilityObject.h:
      * accessibility/AccessibilityRenderObject.cpp:
      * accessibility/AccessibilityRenderObject.h:
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      * html/HTMLAttributeNames.in:
      
      WebKit: 
      
      Add a localizable string for tab panel.
      
      * English.lproj/Localizable.strings:
      * StringsNotToBeLocalized.txt:
      
      WebKit/mac: 
      
      * WebCoreSupport/WebViewFactory.mm:
      (-[WebViewFactory AXARIAContentGroupText:]):
      
      WebKitTools: 
      
      * DumpRenderTree/AccessibilityUIElement.cpp:
      * DumpRenderTree/AccessibilityUIElement.h:
      * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
      * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
      * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
      
      LayoutTests: 
      
      * accessibility/aria-controls-with-tabs-expected.txt: Added.
      * accessibility/aria-controls-with-tabs.html: Added.
      * accessibility/aria-tab-roles.html: Added.
      * platform/gtk/Skipped:
      * platform/mac/accessibility/aria-tab-roles-expected.txt: Added.
      * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50409 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60f0160e
  6. 01 Nov, 2009 2 commits
    • mitz@apple.com's avatar
      Made the space bar toggle playing state in full-screen video when · 1abefe3c
      mitz@apple.com authored
      modifier keys are down. Made it do so without highlighting the
      Play/Pause button.
      
      Reviewed by Mark Rowe.
      
      * WebView/WebVideoFullscreenHUDWindowController.mm:
      (-[WebVideoFullscreenHUDWindowController keyDown:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50402 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1abefe3c
    • mitz@apple.com's avatar
      Made the full-screen video HUD respond to the up and down arrow keys by · f1fdedb9
      mitz@apple.com authored
      increasing and decreasing the volume by 1/10 of the range or, when
      combined with the Option key, all the way up or down.
      
      Reviewed by Mark Rowe.
      
      Made the volume buttons in the full-screen video HUD match the behavior
      of their equivalents in the QuickTime Player HUD by turning the volume
      all the way up or down.
      
      Made the volume slider update immediately when the keyboard or volume
      buttons are used to change the volume, rather than at the nearest 1/4
      second interval.
      
      Made the elapsed and remaining time displays update immediately when the
      play head is dragged across the timeline, rather than at 1/4 second
      intervals.
      
      * WebView/WebVideoFullscreenHUDWindowController.mm:
      (-[WebVideoFullscreenHUDWindowController keyDown:]): Handle the up and
      down arrow keys.
      (-[WebVideoFullscreenHUDWindowController windowDidLoad]): Changed the
      actions of the volume up and volume down buttons.
      (-[WebVideoFullscreenHUDWindowController setCurrentTime:]): Call
      -updateTime.
      (-[WebVideoFullscreenHUDWindowController setVolumeToZero:]): Added this
      action for the volume down button.
      (-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]): Added
      this action for the volume up button.
      (-[WebVideoFullscreenHUDWindowController decrementVolume]): No longer
      and action method.
      (-[WebVideoFullscreenHUDWindowController incrementVolume]): Ditto.
      (-[WebVideoFullscreenHUDWindowController setVolume:]): Call
      -updateVolume.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50399 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1fdedb9
  7. 30 Oct, 2009 2 commits
    • levin@chromium.org's avatar
      Notify the chrome when the focused node has changed. · ec60442a
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=30832
      
      Patch by Evan Stade <estade@chromium.org> on 2009-10-30
      Reviewed by David Levin.
      
      WebCore:
      
      This is similar to AX code that is already in place, except that this also informs the
      chrome when there stops being a focused node. This is needed for a browser to show the
      anchor for links that have keyboard focus.
      
      * dom/Document.cpp:
      (WebCore::Document::setFocusedNode):
      * loader/EmptyClients.h:
      (WebCore::EmptyChromeClient::focusedNodeChanged):
      * page/Chrome.cpp:
      (WebCore::Chrome::focusedNodeChanged):
      * page/Chrome.h:
      * page/ChromeClient.h:
      
      WebKit/gtk:
      
      Added stub implementation for new ChromeClient function.
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::focusedNodeChanged):
      * WebCoreSupport/ChromeClientGtk.h:
      
      WebKit/haiku:
      
      Added stub implementation for new ChromeClient function.
      
      * WebCoreSupport/ChromeClientHaiku.cpp:
      (WebCore::ChromeClientHaiku::focusedNodeChanged):
      * WebCoreSupport/ChromeClientHaiku.h:
      
      WebKit/mac:
      
      Added stub implementation for new ChromeClient function.
      
      * WebCoreSupport/WebChromeClient.h:
      * WebCoreSupport/WebChromeClient.mm:
      (WebChromeClient::focusedNodeChanged):
      
      WebKit/qt:
      
      Added stub implementation for new ChromeClient function.
      
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::focusedNodeChanged):
      * WebCoreSupport/ChromeClientQt.h:
      
      WebKit/win:
      
      Added stub implementation for new ChromeClient function.
      
      * WebCoreSupport/WebChromeClient.cpp:
      (WebChromeClient::focusedNodeChanged):
      * WebCoreSupport/WebChromeClient.h:
      
      WebKit/wx:
      
      Added stub implementation for new ChromeClient function.
      
      * WebKitSupport/ChromeClientWx.cpp:
      (WebCore::ChromeClientWx::focusedNodeChanged):
      * WebKitSupport/ChromeClientWx.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50351 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec60442a
    • rolandsteiner@chromium.org's avatar
  8. 29 Oct, 2009 3 commits
  9. 28 Oct, 2009 2 commits
    • eric.carlson@apple.com's avatar
      2009-10-28 Eric Carlson <eric.carlson@apple.com> · 9bfaaa38
      eric.carlson@apple.com authored
              Reviewed by Simon Fraser.
      
              <rdar://problem/7303145> 
              Can't exit full screen mode or restart movie after pressing command -R.
      
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::removedFromDocument):
              (WebCore::HTMLMediaElement::documentWillBecomeInactive):
                  Exit from fullscreen if necessary.
              * html/HTMLMediaElement.h:
      
      2009-10-28  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Simon Fraser.
      
              <rdar://problem/7303145> 
              Can't exit full screen mode or restart movie after pressing command -R.
      
              * WebView/WebVideoFullscreenController.mm:
              (-[WebVideoFullscreenController _requestExit]): 
                  New, call media element's exitFullscreen method.
              (-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]): 
                  Call mediaElement->exitFullscreen() after a delay as it turns around and calls
                  WebVideoFullscreenController:exitFullscreen.
      
              * WebView/WebVideoFullscreenHUDWindowController.h:
              * WebView/WebVideoFullscreenHUDWindowController.mm:
              (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
                  New, don't give up responder status.
              (-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
                  New, block all command key events.
              (-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
                  Remember when we are in the process of exiting fullscreen, don't allow recursion.
      
              * WebView/WebView.mm:
              (-[WebView _exitFullscreen]):
                  Early return if fullscreen controller is nil.
      
              * WebView/WebWindowAnimation.h: 
                  Correct comment about _window retain status.
              * WebView/WebWindowAnimation.m:
              (-[WebWindowScaleAnimation dealloc]):
                  Don't release _window, we never reatained it.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50242 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9bfaaa38
    • hamaji@chromium.org's avatar
      2009-10-27 Shinichiro Hamaji <hamaji@chromium.org> · 47244a6c
      hamaji@chromium.org authored
              Reviewed by Darin Adler.
      
              Provide a way to get counter values with layoutTestContoller
              https://bugs.webkit.org/show_bug.cgi?id=30555
      
              * Api/qwebframe.cpp:
              (QWebFrame::counterValueForElementById):
              (QWebHitTestResult::frame):
              * Api/qwebframe.h:
      2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
      
              Reviewed by Darin Adler.
      
              Provide a way to get counter values with layoutTestContoller
              https://bugs.webkit.org/show_bug.cgi?id=30555
      
              * webkit/webkitprivate.h:
              * webkit/webkitwebframe.cpp:
              (webkit_web_frame_counter_value_for_element_by_id):
      2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
      
              Reviewed by Darin Adler.
      
              Provide a way to get counter values with layoutTestContoller
              https://bugs.webkit.org/show_bug.cgi?id=30555
      
              * Interfaces/IWebFramePrivate.idl:
              * WebFrame.cpp:
              (WebFrame::counterValueForElementById):
              * WebFrame.h:
      2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
      
              Reviewed by Darin Adler.
      
              Provide a way to get counter values with layoutTestContoller
              https://bugs.webkit.org/show_bug.cgi?id=30555
      
              Add counterValueForElement in WebFrame to call WebCore::counterValueForElement.
      
              * Misc/WebCoreStatistics.h:
              * Misc/WebCoreStatistics.mm:
              (-[WebFrame counterValueForElement:]):
      2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
      
              Reviewed by Darin Adler.
      
              Provide a way to get counter values with layoutTestContoller
              https://bugs.webkit.org/show_bug.cgi?id=30555
      
              Expose WebCore::counterValueForElement as a WebCore API.
      
              * WebCore.base.exp:
              * rendering/RenderTreeAsText.cpp:
              (WebCore::writeCounterValuesFromChildren):
              (WebCore::counterValueForElement):
              * rendering/RenderTreeAsText.h:
      2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
      
              Reviewed by Darin Adler.
      
              Provide a way to get counter values with layoutTestContoller
              https://bugs.webkit.org/show_bug.cgi?id=30555
      
              Convert two pixel tests to dumpAsText tests using counterValueForElementById.
      
              * fast/css/counters/t1204-increment-00-c-o-expected.txt: Added.
              * fast/css/counters/t1204-increment-00-c-o.html:
              * fast/css/counters/t1204-increment-01-c-o-expected.txt: Added.
              * fast/css/counters/t1204-increment-01-c-o.html:
              * platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.checksum: Removed.
              * platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.png: Removed.
              * platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.txt: Removed.
              * platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.checksum: Removed.
              * platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.png: Removed.
              * platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.txt: Removed.
              * platform/qt/fast/css/counters/t1204-increment-00-c-o-expected.txt: Removed.
              * platform/qt/fast/css/counters/t1204-increment-01-c-o-expected.txt: Removed.
      2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
      
              Reviewed by Darin Adler.
      
              Provide a way to get counter values with layoutTestContoller
              https://bugs.webkit.org/show_bug.cgi?id=30555
      
              Define layoutTestContoller.counterValueForElementById.
      
              * DumpRenderTree/LayoutTestController.cpp:
              (counterValueForElementByIdCallback):
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              (LayoutTestController::counterValueForElementById):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50233 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47244a6c
  10. 27 Oct, 2009 1 commit
    • ggaren@apple.com's avatar
      JavaScriptCore: A little bit of refactoring in the date code. · a25e8ffe
      ggaren@apple.com authored
      Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-27
      Reviewed by Sam Weinig.
      
      * JavaScriptCore.exp: Don't export this unused symbol.
      
      * runtime/DateConstructor.cpp:
      (JSC::constructDate):
      
      * runtime/DateInstance.cpp:
      (JSC::DateInstance::DateInstance):
      * runtime/DateInstance.h: Removed some unused functions. Changed the default
      constructor to ensure that a DateInstance is always initialized.
      
      * runtime/DatePrototype.cpp:
      (JSC::DatePrototype::DatePrototype): Pass an initializer to our constructor,
      since it now requires one.
      
      * wtf/DateMath.cpp:
      (WTF::msToGregorianDateTime): Only compute our offset from UTC if our
      output will require it. Otherwise, our offset is 0.
      
      WebKit/mac: Updated for refactoring in the date code.
      
      Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-27
      Reviewed by Sam Weinig.
      
      * WebView/WebView.mm:
      (aeDescFromJSValue): Since we just want a number of milliseconds, do that
      instead of something more complicated.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50183 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a25e8ffe
  11. 26 Oct, 2009 2 commits
    • weinig@apple.com's avatar
      Move some WebView event handling code into its own file, WebViewEventHandling.mm · d00791c0
      weinig@apple.com authored
      Reviewed by Anders Carlsson.
      
      WebKit: 
      
      * WebKit.xcodeproj/project.pbxproj:
      
      WebKit/mac: 
      
      * WebView/WebView.mm:
      (-[WebView _close]):
      (-[WebView _selectedOrMainFrame]):
      * WebView/WebViewEventHandling.mm: Added.
      (-[WebView _closingEventHandling]):
      (-[WebView _setMouseDownEvent:]):
      (-[WebView mouseDown:]):
      (-[WebView mouseUp:]):
      (+[WebView _updateMouseoverWithEvent:]):
      (-[WebView _updateMouseoverWithFakeEvent]):
      (_updateMouseoverWithEvent:fakeEvent::if):
      (-[WebView _stopAutoscrollTimer]):
      (-[WebView _setToolTip:]):
      * WebView/WebViewInternal.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d00791c0
    • simon.fraser@apple.com's avatar
      2009-10-26 Simon Fraser <simon.fraser@apple.com> · 8110a530
      simon.fraser@apple.com authored
              Reviewed by Sam Weinig.
      
              <rdar://problem/6988966> Hardware layers do not show up in page snapshots
      
              * WebView/WebHTMLViewPrivate.h:
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView _compositingLayersHostingView]):
              Add a private method that returns the NSView used to host compositing layers.
      
              * platform/graphics/mac/Canvas3DLayer.h:
              * platform/graphics/mac/Canvas3DLayer.mm:
              (-[Canvas3DLayer copyImageSnapshotWithColorSpace:]):
              Add a method that gets called when snapshotting Canvas3DLayers for page snapshots,
              that allows the layer to return a CGImageRef of its contents.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50067 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8110a530
  12. 23 Oct, 2009 3 commits
  13. 22 Oct, 2009 3 commits
    • barraclough@apple.com's avatar
      Build fix following bug #30696. · 69e5c94f
      barraclough@apple.com authored
      Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
      Reviewed by NOBODY (build fix).
      
      * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
      (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
      (WebKit::NetscapePluginInstanceProxy::evaluate):
      (WebKit::NetscapePluginInstanceProxy::invoke):
      (WebKit::NetscapePluginInstanceProxy::invokeDefault):
      (WebKit::NetscapePluginInstanceProxy::construct):
      (WebKit::NetscapePluginInstanceProxy::getProperty):
      (WebKit::NetscapePluginInstanceProxy::setProperty):
      (WebKit::NetscapePluginInstanceProxy::removeProperty):
      (WebKit::NetscapePluginInstanceProxy::hasProperty):
      (WebKit::NetscapePluginInstanceProxy::hasMethod):
      (WebKit::NetscapePluginInstanceProxy::enumerate):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49965 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69e5c94f
    • barraclough@apple.com's avatar
      WebCore: https://bugs.webkit.org/show_bug.cgi?id=30696 · c53df831
      barraclough@apple.com authored
      Add support for IsolatedWorlds to JSC bindings.
      
      Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-16
      Reviewed by Sam Weinig & Geoff Garen.
      
      An IsolatedWorld is basically a parallel, separate copy of the window shells and DOM wrapper objects for
      a given document.  To support isolation this patch:
      
          * Adds support to the ScriptController to track multiple window shells, one per world.
          * Adds support to Document to support multiple separate wrapper-maps, one per world.
          * Replaces the single global DOM wrapper map (on the WebCoreJSClientData) with separate maps,
            stored on the (new) IsolatedWorld objects.
      
      In addition to supporting separate copies of these objects, two other features are supported:
      
          * It is necessary to track the current world on entry into JSC, so that within callbacks out to WebCore
            we can determine which world (and as such, set of DOM bindings) we should be operating on.
          * EventListeners & Callbacks are run in the world they were registered in.
            This requires the handler to retain a reference to the world.
      
      No new tests. (Enabled existing isolated world layout tests.)
      
      * WebCore.base.exp:
      * bindings/js/JSAbstractWorkerCustom.cpp:
      (WebCore::JSAbstractWorker::addEventListener):
      (WebCore::JSAbstractWorker::removeEventListener):
      * bindings/js/JSCallbackData.cpp:
      (WebCore::JSCallbackData::invokeCallback):
      * bindings/js/JSCallbackData.h:
      (WebCore::JSCallbackData::JSCallbackData):
      * bindings/js/JSCustomXPathNSResolver.cpp:
      (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
      * bindings/js/JSDOMApplicationCacheCustom.cpp:
      (WebCore::JSDOMApplicationCache::addEventListener):
      (WebCore::JSDOMApplicationCache::removeEventListener):
      * bindings/js/JSDOMBinding.cpp:
      (WebCore::removeWrappers):
      (WebCore::DOMObjectWrapperMap::get):
      (WebCore::DOMObjectWrapperMap::set):
      (WebCore::DOMObjectWrapperMap::remove):
      (WebCore::DOMObjectWrapperMap::take):
      (WebCore::IsolatedWorld::IsolatedWorld):
      (WebCore::IsolatedWorld::~IsolatedWorld):
      (WebCore::EnterIsolatedWorld::EnterIsolatedWorld):
      (WebCore::EnterIsolatedWorld::~EnterIsolatedWorld):
      (WebCore::JSGlobalDataWorldIterator::JSGlobalDataWorldIterator):
      (WebCore::JSGlobalDataWorldIterator::operator bool):
      (WebCore::JSGlobalDataWorldIterator::operator*):
      (WebCore::JSGlobalDataWorldIterator::operator->):
      (WebCore::JSGlobalDataWorldIterator::operator++):
      (WebCore::getCurrentWorld):
      (WebCore::getNormalWorld):
      (WebCore::commonNormalWorld):
      (WebCore::commonCurrentWorld):
      (WebCore::DOMObjectHashTableMap::mapFor):
      (WebCore::DOMObjectWrapperMap::mapFor):
      (WebCore::forgetDOMObject):
      (WebCore::getCachedDOMNodeWrapper):
      (WebCore::forgetDOMNode):
      (WebCore::cacheDOMNodeWrapper):
      (WebCore::forgetAllDOMNodesForDocument):
      (WebCore::forgetWorldOfDOMNodesForDocument):
      (WebCore::isObservableThroughDOM):
      (WebCore::markDOMNodesForDocument):
      (WebCore::markActiveObjectsForContext):
      (WebCore::takeWrappers):
      (WebCore::updateDOMNodeDocument):
      (WebCore::markDOMObjectWrapper):
      (WebCore::allowsAccessFromFrame):
      (WebCore::printErrorMessageForFrame):
      (WebCore::JSC_DebuggerCallFrame_evaluateInWorld):
      (WebCore::JSC_callInWorld):
      (WebCore::JSC_constructInWorld):
      (WebCore::JSC_evaluateInWorld):
      * bindings/js/JSDOMBinding.h:
      (WebCore::IsolatedWorld::rememberDocument):
      (WebCore::IsolatedWorld::forgetDocument):
      (WebCore::IsolatedWorld::rememberScriptController):
      (WebCore::IsolatedWorld::forgetScriptController):
      (WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):
      (WebCore::DOMObjectHashTableMap::get):
      (WebCore::WebCoreJSClientData::WebCoreJSClientData):
      (WebCore::WebCoreJSClientData::currentWorld):
      (WebCore::WebCoreJSClientData::normalWorld):
      (WebCore::WebCoreJSClientData::rememberWorld):
      (WebCore::WebCoreJSClientData::forgetWorld):
      (WebCore::debuggerWorld):
      (WebCore::pluginWorld):
      * bindings/js/JSDOMGlobalObject.cpp:
      (WebCore::JSDOMGlobalObject::createJSAttributeEventListener):
      (WebCore::toJSDOMGlobalObject):
      * bindings/js/JSDOMGlobalObject.h:
      * bindings/js/JSDOMWindowBase.cpp:
      (WebCore::JSDOMWindowBase::printErrorMessage):
      (WebCore::JSDOMWindowBase::commonJSGlobalData):
      (WebCore::toJS):
      (WebCore::toJSDOMWindow):
      * bindings/js/JSDOMWindowBase.h:
      * bindings/js/JSDOMWindowCustom.cpp:
      (WebCore::createWindow):
      (WebCore::JSDOMWindow::open):
      (WebCore::JSDOMWindow::showModalDialog):
      (WebCore::JSDOMWindow::setTimeout):
      (WebCore::JSDOMWindow::setInterval):
      (WebCore::JSDOMWindow::addEventListener):
      (WebCore::JSDOMWindow::removeEventListener):
      * bindings/js/JSDOMWindowShell.cpp:
      (WebCore::toJS):
      (WebCore::toJSDOMWindowShell):
      * bindings/js/JSDOMWindowShell.h:
      * bindings/js/JSDesktopNotificationsCustom.cpp:
      (WebCore::JSNotification::addEventListener):
      (WebCore::):
      * bindings/js/JSEventListener.cpp:
      (WebCore::JSEventListener::JSEventListener):
      (WebCore::JSEventListener::handleEvent):
      (WebCore::JSEventListener::reportError):
      * bindings/js/JSEventListener.h:
      (WebCore::JSEventListener::create):
      * bindings/js/JSEventSourceCustom.cpp:
      (WebCore::JSEventSource::addEventListener):
      (WebCore::JSEventSource::removeEventListener):
      * bindings/js/JSEventTarget.cpp:
      (WebCore::toJS):
      * bindings/js/JSHTMLDocumentCustom.cpp:
      (WebCore::JSHTMLDocument::open):
      * bindings/js/JSHTMLFrameSetElementCustom.cpp:
      (WebCore::JSHTMLFrameSetElement::nameGetter):
      * bindings/js/JSInspectorBackendCustom.cpp:
      (WebCore::JSInspectorBackend::databaseForId):
      (WebCore::JSInspectorBackend::inspectedWindow):
      (WebCore::JSInspectorBackend::nodeForId):
      * bindings/js/JSLazyEventListener.cpp:
      (WebCore::JSLazyEventListener::JSLazyEventListener):
      (WebCore::JSLazyEventListener::parseCode):
      * bindings/js/JSLazyEventListener.h:
      (WebCore::JSLazyEventListener::create):
      * bindings/js/JSMessageChannelCustom.cpp:
      (WebCore::JSMessageChannel::markChildren):
      * bindings/js/JSMessagePortCustom.cpp:
      (WebCore::JSMessagePort::markChildren):
      (WebCore::JSMessagePort::addEventListener):
      (WebCore::JSMessagePort::removeEventListener):
      * bindings/js/JSNodeCustom.cpp:
      (WebCore::JSNode::addEventListener):
      (WebCore::JSNode::removeEventListener):
      (WebCore::JSNode::markChildren):
      * bindings/js/JSNodeFilterCondition.cpp:
      (WebCore::JSNodeFilterCondition::acceptNode):
      * bindings/js/JSQuarantinedObjectWrapper.cpp:
      (WebCore::JSQuarantinedObjectWrapper::construct):
      (WebCore::JSQuarantinedObjectWrapper::call):
      * bindings/js/JSSVGElementInstanceCustom.cpp:
      (WebCore::JSSVGElementInstance::addEventListener):
      (WebCore::JSSVGElementInstance::removeEventListener):
      * bindings/js/JSSharedWorkerCustom.cpp:
      (WebCore::JSSharedWorker::markChildren):
      * bindings/js/JSWebSocketCustom.cpp:
      (WebCore::JSWebSocket::addEventListener):
      (WebCore::JSWebSocket::removeEventListener):
      * bindings/js/JSWorkerContextCustom.cpp:
      (WebCore::JSWorkerContext::addEventListener):
      (WebCore::JSWorkerContext::removeEventListener):
      (WebCore::JSWorkerContext::setTimeout):
      (WebCore::JSWorkerContext::setInterval):
      * bindings/js/JSXMLHttpRequestConstructor.cpp:
      (WebCore::constructXMLHttpRequest):
      * bindings/js/JSXMLHttpRequestCustom.cpp:
      (WebCore::JSXMLHttpRequest::markChildren):
      (WebCore::JSXMLHttpRequest::addEventListener):
      (WebCore::JSXMLHttpRequest::removeEventListener):
      * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
      (WebCore::JSXMLHttpRequestUpload::markChildren):
      (WebCore::JSXMLHttpRequestUpload::addEventListener):
      (WebCore::JSXMLHttpRequestUpload::removeEventListener):
      * bindings/js/ScheduledAction.cpp:
      (WebCore::ScheduledAction::create):
      (WebCore::ScheduledAction::ScheduledAction):
      (WebCore::ScheduledAction::executeFunctionInContext):
      (WebCore::ScheduledAction::execute):
      * bindings/js/ScheduledAction.h:
      (WebCore::ScheduledAction::ScheduledAction):
      * bindings/js/ScriptCachedFrameData.cpp:
      (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
      (WebCore::ScriptCachedFrameData::restore):
      * bindings/js/ScriptController.cpp:
      (WebCore::ScriptController::~ScriptController):
      (WebCore::ScriptController::evaluateInWorld):
      (WebCore::ScriptController::evaluate):
      (WebCore::ScriptController::evaluateInIsolatedWorld):
      (WebCore::ScriptController::clearWindowShell):
      (WebCore::ScriptController::initScript):
      (WebCore::ScriptController::processingUserGestureEvent):
      (WebCore::ScriptController::attachDebugger):
      (WebCore::ScriptController::updateDocument):
      (WebCore::ScriptController::bindingRootObject):
      (WebCore::ScriptController::createRootObject):
      (WebCore::ScriptController::windowScriptNPObject):
      (WebCore::ScriptController::jsObjectForPluginElement):
      * bindings/js/ScriptController.h:
      (WebCore::ScriptController::windowShell):
      (WebCore::ScriptController::existingWindowShell):
      (WebCore::ScriptController::globalObject):
      (WebCore::ScriptController::forgetWorld):
      * bindings/js/ScriptControllerMac.mm:
      (WebCore::ScriptController::windowScriptObject):
      * bindings/js/ScriptEventListener.cpp:
      (WebCore::createAttributeEventListener):
      * bindings/js/ScriptFunctionCall.cpp:
      (WebCore::ScriptFunctionCall::call):
      (WebCore::ScriptFunctionCall::construct):
      * bindings/js/ScriptObjectQuarantine.cpp:
      (WebCore::getQuarantinedScriptObject):
      * bindings/js/ScriptState.cpp:
      (WebCore::scriptStateFromNode):
      (WebCore::scriptStateFromPage):
      * bindings/js/ScriptState.h:
      * bindings/js/WorkerScriptController.cpp:
      (WebCore::WorkerScriptController::WorkerScriptController):
      (WebCore::WorkerScriptController::evaluate):
      * bindings/objc/DOMInternal.mm:
      (-[WebScriptObject _initializeScriptDOMNodeImp]):
      * bindings/objc/WebScriptObject.mm:
      (-[WebScriptObject callWebScriptMethod:withArguments:]):
      (-[WebScriptObject evaluateWebScript:]):
      * bindings/scripts/CodeGeneratorJS.pm:
      * bridge/NP_jsobject.cpp:
      (_NPN_InvokeDefault):
      (_NPN_Invoke):
      (_NPN_Evaluate):
      (_NPN_Construct):
      * bridge/jni/jni_jsobject.mm:
      (JavaJSObject::call):
      (JavaJSObject::eval):
      * dom/Document.cpp:
      (WebCore::Document::createWrapperCache):
      * dom/Document.h:
      (WebCore::Document::wrapperCacheMap):
      (WebCore::Document::getWrapperCache):
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::startUserInitiatedProfiling):
      (WebCore::InspectorController::stopUserInitiatedProfiling):
      * inspector/JavaScriptCallFrame.cpp:
      (WebCore::JavaScriptCallFrame::evaluate):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::dispatchWindowObjectAvailable):
      * platform/network/mac/AuthenticationMac.mm:
      * xml/XMLHttpRequest.cpp:
      (WebCore::XMLHttpRequest::XMLHttpRequest):
      (WebCore::XMLHttpRequest::dropProtection):
      * xml/XMLHttpRequest.h:
      (WebCore::XMLHttpRequest::create):
      
      WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=30696
      Update to incorporate support for IsolatedWorlds in JSC bindings.
      
      Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-16
      Reviewed by Sam Weinig & Geoff Garen.
      
      * WebView/WebFrame.mm:
      (-[WebFrame _attachScriptDebugger]):
      (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
      (-[WebFrame globalContext]):
      * WebView/WebScriptDebugDelegate.mm:
      (-[WebScriptCallFrame evaluateWebScript:]):
      * WebView/WebView.mm:
      (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
      
      WebKit/win: https://bugs.webkit.org/show_bug.cgi?id=30696
      Update to incorporate support for IsolatedWorlds in JSC bindings.
      
      Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
      Reviewed by Sam Weinig & Geoff Garen.
      
      * Interfaces/IWebFramePrivate.idl:
      * WebFrame.cpp:
      (WebFrame::globalContext):
      (WebFrame::windowObjectCleared):
      (WebFrame::stringByEvaluatingJavaScriptInIsolatedWorld):
      * WebFrame.h:
      
      WebKitTools: https://bugs.webkit.org/show_bug.cgi?id=30696
      Enable isolated-worlds tests on mac.
      
      Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-22
      Reviewed by Sam Weinig & Geoff Garen.
      
      Add private interface for DRT to invoke execution in a given world.
      
      * DumpRenderTree/LayoutTestController.cpp:
      (evaluateScriptInIsolatedWorldCallback):
      (LayoutTestController::staticFunctions):
      * DumpRenderTree/LayoutTestController.h:
      * DumpRenderTree/mac/LayoutTestControllerMac.mm:
      (LayoutTestController::evaluateScriptInIsolatedWorld):
      * DumpRenderTree/win/LayoutTestControllerWin.cpp:
      (LayoutTestController::evaluateScriptInIsolatedWorld):
      
      LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=30696
      Enable isolated-worlds tests on mac.
        * Update the results to switch from windows to unix line-endings.
        * Update all-window-prototypes.html to allow for properties on
          the global object with null prototypes (just skip over them).
      
      Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-19
      Reviewed by Sam Weinig & Geoff Garen.
      
      * http/tests/security/isolatedWorld/all-window-properties-expected.txt:
      * http/tests/security/isolatedWorld/all-window-prototypes-expected.txt:
      * http/tests/security/isolatedWorld/all-window-prototypes.html:
      * http/tests/security/isolatedWorld/body-properties-expected.txt:
      * http/tests/security/isolatedWorld/body-prototype-expected.txt:
      * http/tests/security/isolatedWorld/document-properties-expected.txt:
      * http/tests/security/isolatedWorld/document-prototype-expected.txt:
      * http/tests/security/isolatedWorld/global-variables-expected.txt:
      * http/tests/security/isolatedWorld/image-properties-expected.txt:
      * http/tests/security/isolatedWorld/image-prototype-expected.txt:
      * http/tests/security/isolatedWorld/location-properties-expected.txt:
      * http/tests/security/isolatedWorld/location-prototype-expected.txt:
      * http/tests/security/isolatedWorld/number-prototype-expected.txt:
      * http/tests/security/isolatedWorld/object-prototype-expected.txt:
      * http/tests/security/isolatedWorld/storage-properties-expected.txt:
      * http/tests/security/isolatedWorld/storage-prototype-expected.txt:
      * http/tests/security/isolatedWorld/string-prototype-expected.txt:
      * http/tests/security/isolatedWorld/window-properties-expected.txt:
      * platform/mac/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49963 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c53df831
    • eric.carlson@apple.com's avatar
      2009-10-22 Eric Carlson <eric.carlson@apple.com> · 73e866e6
      eric.carlson@apple.com authored
              Reviewed by Dan Bernstein & Simon Fraser.
      
              <rdar://problem/7297717>
              https://bugs.webkit.org/show_bug.cgi?id=30323
              Play/pause button in full-screen video controller does not reflect current state
      
              * WebView/WebVideoFullscreenController.mm:
              (-[WebVideoFullscreenController setMediaElement:WebCore::]): Register for QTMovieRateDidChangeNotification
              (-[WebVideoFullscreenController rateChanged:]): Call HUD controller when rate changes.
      
              * WebView/WebVideoFullscreenHUDWindowController.h:
              * WebView/WebVideoFullscreenHUDWindowController.mm:
              (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]): Call updateRate so play button
              reflects playback state.
              (-[WebVideoFullscreenHUDWindowController updateRate]): New, set play button state according to
              movie state.
              (-[WebVideoFullscreenHUDWindowController playingChanged:]): Only call [self playing] once.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49948 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73e866e6
  14. 21 Oct, 2009 1 commit
  15. 20 Oct, 2009 2 commits
    • mitz@apple.com's avatar
      Rubber-stamped by Mark Rowe. · 780fa75e
      mitz@apple.com authored
      <rdar://problem/7319749> REGRESSION(r49806): Contextual Menu items missing
      https://bugs.webkit.org/show_bug.cgi?id=30568
      
      Revert accidental change from r49806.
      
      * WebCoreSupport/WebContextMenuClient.mm:
      (WebContextMenuClient::getCustomMenuFromDefaultItems):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49884 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      780fa75e
    • ukai@chromium.org's avatar
      2009-10-20 Fumitoshi Ukai <ukai@chromium.org> · 64d2b36d
      ukai@chromium.org authored
              Reviewed by David Levin.
      
              Set EnabledAtRuntime for WebSocket in DOMWindow
              https://bugs.webkit.org/show_bug.cgi?id=29896
      
              Supported by chromium/v8 only.
              Add WebSocket::isAvailable()/setIsAvailable(bool) to control v8
              bindings.
              Remove Settings::experimentalWebSocketsEnabled() and
              setExperimentalWebSocketsEnabled(bool).
      
              * WebCore.base.exp:
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::webSocket):
              * bindings/v8/V8DOMWrapper.cpp:
              (WebCore::V8DOMWrapper::getConstructor):
              * bindings/v8/custom/V8CustomBinding.h:
              * bindings/v8/custom/V8DOMWindowCustom.cpp:
              (WebCore::ACCESSOR_RUNTIME_ENABLER):
              * page/DOMWindow.idl:
              * page/Settings.cpp:
              (WebCore::Settings::Settings):
              * page/Settings.h:
              * websockets/WebSocket.cpp:
              (WebCore::WebSocket::setIsAvailable):
              (WebCore::WebSocket::isAvailable):
              * websockets/WebSocket.h:
      2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
      
              Reviewed by David Levin.
      
              Removed WebSocket runtime settings.
              https://bugs.webkit.org/show_bug.cgi?id=29896
      
              WebSocket runtime configuration is supported by chromium/v8 only.
      
              * webkit/webkitwebview.cpp:
              (webkit_web_view_update_settings):
              (webkit_web_view_settings_notify):
      2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
      
              Reviewed by David Levin.
      
              Removed WebSocket runtime settings.
              https://bugs.webkit.org/show_bug.cgi?id=29896
      
              WebSocket runtime configuration is supported by chromium/v8 only.
      
              * WebView/WebPreferenceKeysPrivate.h:
              * WebView/WebPreferences.mm:
              (+[WebPreferences initialize]):
              * WebView/WebPreferencesPrivate.h:
              * WebView/WebView.mm:
              (-[WebView _preferencesChangedNotification:]):
      2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
      
              Reviewed by David Levin.
      
              Removed WebSocket runtime settings.
              https://bugs.webkit.org/show_bug.cgi?id=29896
      
              WebSocket runtime configuration is supported by chromium/v8 only.
      
              * Interfaces/IWebPreferencesPrivate.idl:
              * WebPreferenceKeysPrivate.h:
              * WebPreferences.cpp:
              (WebPreferences::initializeDefaultSettings):
              (WebPreferences::experimentalNotificationsEnabled):
              * WebPreferences.h:
              * WebView.cpp:
              (WebView::notifyPreferencesChanged):
      2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
      
              Reviewed by David Levin.
      
              Removed WebSocket runtime settings.
              https://bugs.webkit.org/show_bug.cgi?id=29896
      
              WebSocket runtime configuration is supported by chromium/v8 only.
      
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (resetDefaultsToConsistentValues):
              * DumpRenderTree/win/DumpRenderTree.cpp:
              (resetDefaultsToConsistentValues):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49843 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64d2b36d
  16. 19 Oct, 2009 4 commits
  17. 18 Oct, 2009 1 commit
  18. 16 Oct, 2009 3 commits
    • kdecker@apple.com's avatar
      Reviewed by Jon Honeycutt. · 57dfc4da
      kdecker@apple.com authored
              <rdar://problem/7304575>
              
              * Plugins/WebBaseNetscapePluginView.h: Added new boolean ivar and -hasBeenHalted instance method.
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView halt]):Update _hasBeenHalted.
              (-[WebBaseNetscapePluginView hasBeenHalted]): Added.
              * WebView/WebView.mm:
              (+[WebView _hasPluginForNodeBeenHalted:]): Checks to see if a plug-in node's been halted.
              * WebView/WebViewPrivate.h: Added -_hasPluginForNodeBeenHalted method.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49733 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      57dfc4da
    • kdecker@apple.com's avatar
      Reviewed by Anders Carlson. · 8009251f
      kdecker@apple.com authored
              Small code cleanup
              
              * Plugins/WebBaseNetscapePluginView.mm:
              (WebHaltablePlugin::halt): Just call -[WebBaseNetscapePluginView halt].
              (WebHaltablePlugin::restart): Just call -[WebBaseNetscapePluginView resumeFromHalt]
              (-[WebBaseNetscapePluginView halt]): 
              (-[WebBaseNetscapePluginView resumeFromHalt]):
              * WebView/WebView.mm:
              (_pluginViewForNode): Added a check if a render is a widget. This prevents a later assertion.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8009251f
    • kdecker@apple.com's avatar
      Reviewed by Anders Carlson. · 165120a8
      kdecker@apple.com authored
              Last part of:
              <rdar://problem/7273354>
      
              * WebView/WebView.mm: 
              (_pluginViewForNode): Added with code extracted from _isNodeHaltedPlugin
              (+[WebView _isNodeHaltedPlugin:]): Made this a class method.
              (+[WebView _restartHaltedPluginForNode:]): Added. Restarts a plug-in
              * WebView/WebViewPrivate.h: Added +_restartHaltedPluginForNode to header.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49696 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      165120a8