1. 02 Oct, 2012 40 commits
    • commit-queue@webkit.org's avatar
      Source/WebKit: [EFL] Add file EWKTestEnvironment.cpp to build system. · f6a81788
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=94925
      
      Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-10-02
      Reviewed by Gyuyoung Kim.
      
      Change is related to modifications in wk1 unit tests.
      
      * PlatformEfl.cmake:
      
      Source/WebKit/efl: [EFL][UT] Refactoring an implementation of testing framework for wk1.
      https://bugs.webkit.org/show_bug.cgi?id=94925
      
      Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-10-02
      Reviewed by Gyuyoung Kim.
      
      The reason of changing, was to adjust current implementation to use gtest features
      related to cleaning (SetUp, TearDown), cleaning code in terms of useless methods
      and lastly to make framework easier to use.
      
      * tests/UnitTestUtils/EWKTestBase.cpp:
      (EWKUnitTests::EWKTestBase::EWKTestBase):
      (EWKUnitTests::EWKTestBase::webView): Returns current webview.
      (EWKUnitTests::EWKTestBase::SetUp):
      Before test is started, SetUp is called.
      Used this to initialize test view.
      (EWKUnitTests::EWKTestBase::onLoadFinished):
      (EWKUnitTests::EWKTestBase::waitUntilLoadFinished): It waits till test page will be properly loaded.
      (EWKUnitTests::EWKTestBase::loadUrl): Starts loading test page.
      * tests/UnitTestUtils/EWKTestBase.h:
      * tests/UnitTestUtils/EWKTestEnvironment.cpp:
      Used to have global SetUp and TearDown.
      Global SetUp starts initialization of webkit wherease
      global TearDown shuts it down. Generally we would like to have
      only one initialization of webkit while tests are executed.
      (EWKUnitTests):
      (EWKUnitTests::EWKTestEnvironment::EWKTestEnvironment):
      (EWKUnitTests::EWKTestEnvironment::SetUp): Starts initialization of webkit.
      (EWKUnitTests::EWKTestEnvironment::TearDown): Shuts down of webkit.
      * tests/UnitTestUtils/EWKTestEnvironment.h:
      (EWKUnitTests):
      (EWKTestEnvironment):
      (EWKUnitTests::EWKTestEnvironment::useX11Window):
      * tests/UnitTestUtils/EWKTestView.cpp:
      (EWKUnitTests::EWKTestView::EWKTestView):
      (EWKUnitTests::EWKTestView::init): Starts initialization of test view.
      * tests/UnitTestUtils/EWKTestView.h:
      (EWKTestView):
      * tests/test_ewk_view.cpp: adjusted current unit tests to new implementation.
      (TEST_F):
      * tests/test_runner.cpp: entry point of all tests.
      (parseCustomArguments):
      (main):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130175 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6a81788
    • vsevik@chromium.org's avatar
      Unreviewed, rolling out r130167 and r130171. · 537bec68
      vsevik@chromium.org authored
      http://trac.webkit.org/changeset/130167
      http://trac.webkit.org/changeset/130171
      https://bugs.webkit.org/show_bug.cgi?id=98165
      
      Breaks test (Requested by vsevik on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-02
      
      * http/tests/inspector/debugger-test.js:
      (initialize_DebuggerTest):
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130174 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      537bec68
    • michael.bruning@digia.com's avatar
      [Qt][WK2] inspector/extensions/extensions-network.html times out · 2c48179a
      michael.bruning@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=98136
      
      Unreviewed gardening.
      
      WebInspectorProxy::platformCreateInspectorPage() is not implemented for
      the Qt 5.0 WK2 port.
      
      * platform/qt-5.0-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130173 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c48179a
    • vsevik@chromium.org's avatar
      Web Inspector: [Regression] DevToolsExtensionTest.TestContentScriptIsPresent fails · 9989a709
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98161
      
      Reviewed by Pavel Feldman.
      
      Content scripts should be also added by NetworkUISourceCodeProvider. This patch fixes that.
      
      * inspector/front-end/NetworkUISourceCodeProvider.js:
      (WebInspector.NetworkUISourceCodeProvider.prototype._parsedScriptSource):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130172 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9989a709
    • ossy@webkit.org's avatar
      [Qt] Unreviewed gardening, skip one more failing test. · 281e6b7f
      ossy@webkit.org authored
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130171 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      281e6b7f
    • ossy@webkit.org's avatar
      [Qt] Unreviewed gardening, skip new crashing tests to paint the bots green. · b4ecfbc8
      ossy@webkit.org authored
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130170 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4ecfbc8
    • hugo.lima@openbossa.org's avatar
      [WK2] PageViewportControllerClient.h uses WebCore class without declaring them · b159197d
      hugo.lima@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98070
      
      Reviewed by Kenneth Rohde Christiansen.
      
      This patch just add forward declarations for code correctness.
      
      * UIProcess/PageViewportControllerClient.h:
      (WebCore):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130169 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b159197d
    • jocelyn.turcotte@digia.com's avatar
      Fix tst_QQuickWebView::scrollRequest after r130029 · ecadfc25
      jocelyn.turcotte@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=98045
      
      Reviewed by Simon Hausmann.
      
      The test needs to show the window and wait for the loadVisuallyCommitted()
      signal like did in the QML API auto tests.
      
      * UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
      (tst_QQuickWebView::scrollRequest):
      * UIProcess/API/qt/tests/util.cpp:
      (waitForViewportReady):
      * UIProcess/API/qt/tests/util.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130168 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ecadfc25
    • vsevik@chromium.org's avatar
      Unreviewed inspector test fix. · d77d3bfe
      vsevik@chromium.org authored
      * http/tests/inspector/debugger-test.js:
      (initialize_DebuggerTest):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130167 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d77d3bfe
    • commit-queue@webkit.org's avatar
      [EFL][WK2] Use correct gtest macro for testing true/false · a412656a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98142
      
      Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-10-02
      Reviewed by Laszlo Gombos.
      
      Using EXPECT_EQ(true/false, ...) makes clang trip when it tries to convert
      true/false to a pointer. Tests should use EXPECT_TRUE/FALSE instead.
      
      * UIProcess/API/efl/tests/test_ewk2_view.cpp:
      (showPopupMenu):
      (TEST_F):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130166 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a412656a
    • paroga@webkit.org's avatar
      [WINCE] Remove FontPlatformData::averageCharWidth() · 8199e83b
      paroga@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97883
      
      Reviewed by Andreas Kling.
      
      Use SimpleFontData::avgCharWidth() instead to remove duplicated code.
      
      * platform/graphics/wince/FontPlatformData.cpp:
      (WebCore::FixedSizeFontData::create):
      * platform/graphics/wince/FontPlatformData.h:
      (FontPlatformData):
      * platform/graphics/wince/GraphicsContextWinCE.cpp:
      (WebCore::GraphicsContext::drawText):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130165 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8199e83b
    • caseq@chromium.org's avatar
      Unreviewed. Removed erroneously added custom expectation. · f7998331
      caseq@chromium.org authored
      * platform/chromium-win/inspector/console/command-line-api-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130164 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7998331
    • ossy@webkit.org's avatar
      [WK2] REGRESSION(r128623): It made layout tests extremely slow · 85d8dfcc
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96862
      
      Reviewed by Simon Hausmann.
      
      Disable calling the extremely slow WKBundleSetDatabaseQuota() between tests until proper fix.
      
      * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
      (WTR::InjectedBundle::beginTesting):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130163 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85d8dfcc
    • pfeldman@chromium.org's avatar
      Not reviewed: Rebaselined failing inspector test. · c5cd76d7
      pfeldman@chromium.org authored
      * inspector/console/command-line-api-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130162 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5cd76d7
    • caseq@chromium.org's avatar
      Unreviewed test rebaseline. · 12536f40
      caseq@chromium.org authored
      * platform/chromium-win/inspector/console/command-line-api-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130161 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      12536f40
    • schenney@chromium.org's avatar
      Refactor WebCore::FontData handling to clarify pointer ownership · fc27bcb8
      schenney@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95866
      
      Reviewed by Eric Seidel.
      
      Re-commit for a rolled-out original, now with Chromium Windows build fix.
      
      This patch makes all FontData and derived classes ref-counted in all
      code paths that lead to caching or other retention of a
      pointer. The goal is to avert crashes and memory leaks, and to bring
      the code more in line with current WebKit practices.
      
      Specifically, this patch allows us to use ref pointers for all the
      FontData stored in FontFallbackList objects. The FontFallbackList can
      then own custom font data and manage its lifetime (forthcoming patch).
      Currently Document owns custom font data and does an end run around
      FontFallbackList in deleting glyph pages and custom font data, leaving
      FontFallbackList with invalid pointers.
      
      All FontData derived classes have been switched to use static create
      methods with private constructors.
      
      All caches that hold FontData now use RefPtrs.
      
      All methods that construct new font data now return PassRefPtr, with the
      exception of code only used to generate temporary data for text run layout.
      
      All methods that handle FontData in a call stack that passes through
      FontFallbackList::fontDataAt return PassRefPtr.
      
      Performance tested with both WebKit Perf-o-matic, which showed
      performance changes in the noise, and Chrome's page cycling tests with
      the acid3 benchmark set, which showed no performance difference at all.
      
      No new tests as this is refactoring code only and has no impact on functionality.
      
      * css/CSSFontFace.cpp:
      (WebCore::CSSFontFace::getFontData):
      * css/CSSFontFace.h:
      (CSSFontFace):
      * css/CSSFontFaceSource.cpp:
      (WebCore::CSSFontFaceSource::getFontData):
      * css/CSSFontFaceSource.h:
      (CSSFontFaceSource):
      * css/CSSFontSelector.cpp:
      (WebCore::fontDataForGenericFamily):
      (WebCore::CSSFontSelector::getFontData):
      * css/CSSFontSelector.h:
      * css/CSSSegmentedFontFace.cpp:
      (WebCore::appendFontDataWithInvalidUnicodeRangeIfLoading):
      (WebCore::CSSSegmentedFontFace::getFontData):
      * css/CSSSegmentedFontFace.h:
      (CSSSegmentedFontFace):
      * dom/Document.cpp:
      (WebCore::Document::registerCustomFont):
      * dom/Document.h:
      (Document):
      * platform/graphics/Font.h:
      (WebCore):
      * platform/graphics/FontCache.cpp:
      (WebCore):
      (WebCore::FontCache::getCachedFontData):
      (WebCore::FontCache::getNonRetainedLastResortFallbackFont):
      (WebCore::FontCache::releaseFontData):
      (WebCore::FontCache::purgeInactiveFontData):
      (WebCore::FontCache::getFontData):
      * platform/graphics/FontCache.h:
      (FontCache):
      * platform/graphics/FontData.h:
      * platform/graphics/FontFallbackList.cpp:
      (WebCore::FontFallbackList::releaseFontData):
      (WebCore::FontFallbackList::fontDataAt):
      (WebCore::FontFallbackList::setPlatformFont):
      * platform/graphics/FontFallbackList.h:
      (FontFallbackList):
      * platform/graphics/FontFastPath.cpp:
      (WebCore::Font::glyphDataAndPageForCharacter):
      * platform/graphics/FontSelector.h:
      (FontSelector):
      * platform/graphics/GlyphPageTreeNode.cpp:
      (WebCore::GlyphPageTreeNode::initializePage):
      * platform/graphics/SegmentedFontData.cpp:
      (WebCore::SegmentedFontData::fontDataForCharacter):
      * platform/graphics/SegmentedFontData.h:
      (WebCore::FontDataRange::FontDataRange):
      (WebCore::FontDataRange::fontData):
      (FontDataRange):
      (WebCore::SegmentedFontData::create):
      (SegmentedFontData):
      (WebCore::SegmentedFontData::SegmentedFontData):
      * platform/graphics/SimpleFontData.cpp:
      (WebCore::SimpleFontData::verticalRightOrientationFontData):
      (WebCore::SimpleFontData::uprightOrientationFontData):
      (WebCore::SimpleFontData::brokenIdeographFontData):
      * platform/graphics/SimpleFontData.h:
      (WebCore::SimpleFontData::create):
      (SimpleFontData):
      (WebCore::SimpleFontData::variantFontData):
      (DerivedFontData):
      * platform/graphics/chromium/FontCacheAndroid.cpp:
      (WebCore::FontCache::getFontDataForCharacters):
      (WebCore::FontCache::getSimilarFontPlatformData):
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/chromium/FontCacheChromiumWin.cpp:
      (WebCore::FontCache::fontDataFromDescriptionAndLogFont):
      (GetLastResortFallbackFontProcData):
      (WebCore::FontCache::getFontDataForCharacters):
      (WebCore::FontCache::getSimilarFontPlatformData):
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
      (WebCore::SimpleFontData::createScaledFontData):
      (WebCore::SimpleFontData::smallCapsFontData):
      (WebCore::SimpleFontData::emphasisMarkFontData):
      * platform/graphics/freetype/FontCacheFreeType.cpp:
      (WebCore::FontCache::getFontDataForCharacters):
      (WebCore::FontCache::getSimilarFontPlatformData):
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/freetype/SimpleFontDataFreeType.cpp:
      (WebCore::SimpleFontData::createScaledFontData):
      (WebCore::SimpleFontData::smallCapsFontData):
      (WebCore::SimpleFontData::emphasisMarkFontData):
      * platform/graphics/mac/ComplexTextControllerCoreText.mm:
      (WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
      * platform/graphics/mac/FontCacheMac.mm:
      (WebCore::FontCache::getFontDataForCharacters):
      (WebCore::FontCache::getSimilarFontPlatformData):
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/mac/FontComplexTextMac.cpp:
      (WebCore::Font::fontDataForCombiningCharacterSequence):
      * platform/graphics/mac/SimpleFontDataMac.mm:
      (WebCore::SimpleFontData::platformDestroy):
      (WebCore::SimpleFontData::createScaledFontData):
      (WebCore::SimpleFontData::smallCapsFontData):
      (WebCore::SimpleFontData::emphasisMarkFontData):
      * platform/graphics/pango/FontCachePango.cpp:
      (WebCore::FontCache::getFontDataForCharacters):
      (WebCore::FontCache::getSimilarFontPlatformData):
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/pango/SimpleFontDataPango.cpp:
      (WebCore::SimpleFontData::createScaledFontData):
      (WebCore::SimpleFontData::smallCapsFontData):
      (WebCore::SimpleFontData::emphasisMarkFontData):
      * platform/graphics/qt/FontCacheQt.cpp:
      (WebCore::FontCache::getFontDataForCharacters):
      (WebCore::FontCache::getSimilarFontPlatformData):
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/qt/SimpleFontDataQt.cpp:
      (WebCore::SimpleFontData::createScaledFontData):
      (WebCore::SimpleFontData::smallCapsFontData):
      (WebCore::SimpleFontData::emphasisMarkFontData):
      * platform/graphics/skia/FontCacheSkia.cpp:
      (WebCore::FontCache::getFontDataForCharacters):
      (WebCore::FontCache::getSimilarFontPlatformData):
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/skia/SimpleFontDataSkia.cpp:
      (WebCore::SimpleFontData::createScaledFontData):
      (WebCore::SimpleFontData::smallCapsFontData):
      (WebCore::SimpleFontData::emphasisMarkFontData):
      * platform/graphics/win/FontCacheWin.cpp:
      (WebCore::FontCache::getFontDataForCharacters):
      (WebCore::FontCache::getSimilarFontPlatformData):
      (WebCore::FontCache::fontDataFromDescriptionAndLogFont):
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/win/SimpleFontDataWin.cpp:
      (WebCore::SimpleFontData::createScaledFontData):
      (WebCore::SimpleFontData::smallCapsFontData):
      (WebCore::SimpleFontData::emphasisMarkFontData):
      * platform/graphics/wince/FontCacheWinCE.cpp:
      (WebCore::FontCache::getFontDataForCharacters):
      (WebCore::FontCache::getSimilarFontPlatformData):
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/wince/SimpleFontDataWinCE.cpp:
      (WebCore::SimpleFontData::createScaledFontData):
      (WebCore::SimpleFontData::smallCapsFontData):
      (WebCore::SimpleFontData::emphasisMarkFontData):
      * platform/graphics/wx/FontCacheWx.cpp:
      (WebCore::FontCache::getFontDataForCharacters):
      (WebCore::FontCache::getSimilarFontPlatformData):
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/wx/SimpleFontDataWx.cpp:
      (WebCore::SimpleFontData::createScaledFontData):
      (WebCore::SimpleFontData::smallCapsFontData):
      (WebCore::SimpleFontData::emphasisMarkFontData):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130160 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc27bcb8
    • commit-queue@webkit.org's avatar
      [GTK] Value not returned warning with geolocation disabled · 5a06697f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98148
      
      Patch by Adrian Perez de Castro <aperez@igalia.com> on 2012-10-02
      Reviewed by Xan Lopez.
      
      With geolocation disabled in the build, return a sensible value from
      DumpRenderTreeSupportGtk::numberOfPendingGeolocationPermissionRequests.
      This also avoids a compiler warning.
      
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
      (DumpRenderTreeSupportGtk::numberOfPendingGeolocationPermissionRequests):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130159 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5a06697f
    • commit-queue@webkit.org's avatar
      [XMLHttpRequest] overrideMimeType(mime) does not update the response's "Content-Type" header · e83e2e1e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98137
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-02
      Reviewed by Kentaro Hara.
      
      Source/WebCore:
      
      According to the XMLHttpRequest specification, overrideMimeType(mime) sets the
      "Content-Type" header for the response to mime. However, with the current
      implementation, calling overrideMimeType(mime) does not affect the value
      returned by client.getResponseHeader("Content-Type"). This patch makes sure
      the response's "Content-Type" header is properly updated with the override
      MIME type.
      
      Test: http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-content-type-header.html
      
      * xml/XMLHttpRequest.cpp:
      (WebCore::XMLHttpRequest::didReceiveResponse):
      
      LayoutTests:
      
      Add layout test to check that calling overrideMimeType(mime) properly
      sets the response's "Content-Type" header to mime.
      
      * http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-content-type-header-expected.txt: Added.
      * http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-content-type-header.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130158 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e83e2e1e
    • caseq@chromium.org's avatar
      Unreviewed gardening. · 4d0e6021
      caseq@chromium.org authored
      Remove entry for bidi-layout-across-linebreak.html, reinstated meter-optimiums.html as flaky on Mac.
      
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130157 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d0e6021
    • vsevik@chromium.org's avatar
      Unreviewed inspector test fix on JSC. · 78bcecb7
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98145
      
      * inspector/debugger/script-snippet-model.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130156 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78bcecb7
    • vsevik@chromium.org's avatar
      Web Inspector: Move UISourceCode creation out from ResourceScriptMapping. · 6cf56f1e
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97680
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      UISourceCodes for scripts having sourceURL are now created by NetworkUISourceCodeProvider.
      UISourceCodes for anonymous, dynamic and concatenated scripts are now created on demand only.
      All UISourceCodes created by ResourceScriptMapping are now "temporary".
      Temporary UISourceCodes are not stored in workspace and removed when a normal UISourceCode with the same url is available.
      UISourceCodeReplaced event was replaced with TemporaryUISourceCodeAdded/Removed events.
      
      * inspector/front-end/BreakpointManager.js:
      (WebInspector.BreakpointManager):
      (WebInspector.BreakpointManager.prototype._uiSourceCodeRemoved):
      (WebInspector.BreakpointManager.Breakpoint.prototype.remove):
      * inspector/front-end/NavigatorView.js:
      * inspector/front-end/NetworkUISourceCodeProvider.js:
      (WebInspector.NetworkUISourceCodeProvider):
      (WebInspector.NetworkUISourceCodeProvider.prototype._parsedScriptSource):
      * inspector/front-end/ResourceScriptMapping.js:
      (WebInspector.ResourceScriptMapping):
      (WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
      (WebInspector.ResourceScriptMapping.prototype._workspaceUISourceCodeForScript):
      (WebInspector.ResourceScriptMapping.prototype.uiLocationToRawLocation):
      (WebInspector.ResourceScriptMapping.prototype.addScript):
      (WebInspector.ResourceScriptMapping.prototype._deleteTemporaryUISourceCodeForScripts):
      (WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
      (WebInspector.ResourceScriptMapping.prototype._isDynamicScript):
      (WebInspector.ResourceScriptMapping.prototype._getOrCreateTemporaryUISourceCode):
      (WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAddedToWorkspace):
      (WebInspector.ResourceScriptMapping.prototype._scriptsForUISourceCode):
      (WebInspector.ResourceScriptMapping.prototype._reset):
      * inspector/front-end/RevisionHistoryView.js:
      (WebInspector.RevisionHistoryView):
      * inspector/front-end/ScriptsNavigator.js:
      * inspector/front-end/ScriptsPanel.js:
      (WebInspector.ScriptsPanel):
      * inspector/front-end/TabbedEditorContainer.js:
      (WebInspector.TabbedEditorContainer.prototype.removeUISourceCode.get if):
      (WebInspector.TabbedEditorContainer.prototype.removeUISourceCode):
      * inspector/front-end/UISourceCode.js:
      * inspector/front-end/Workspace.js:
      (WebInspector.Project.prototype.addTemporaryUISourceCode):
      (WebInspector.Project.prototype.removeTemporaryUISourceCode):
      
      LayoutTests:
      
      * http/tests/inspector/workspace-test.js:
      (initialize_WorkspaceTest.InspectorTest.createWorkspace):
      (initialize_WorkspaceTest.InspectorTest.waitForWorkspaceTemporaryUISourceCodeAddedEvent.temporaryUISourceCodeAdded):
      (initialize_WorkspaceTest.InspectorTest.waitForWorkspaceTemporaryUISourceCodeAddedEvent):
      (initialize_WorkspaceTest.InspectorTest.waitForWorkspaceTemporaryUISourceCodeRemovedEvent.temporaryUISourceCodeRemoved):
      (initialize_WorkspaceTest.InspectorTest.waitForWorkspaceTemporaryUISourceCodeRemovedEvent):
      * inspector/debugger/breakpoint-manager-expected.txt:
      * inspector/debugger/breakpoint-manager.html:
      * inspector/debugger/dynamic-script-tag-expected.txt:
      * inspector/debugger/resource-script-mapping.html:
      * inspector/debugger/scripts-panel-expected.txt:
      * inspector/debugger/scripts-panel.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130155 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6cf56f1e
    • pfeldman@chromium.org's avatar
      Web Inspector: fix front-end compilation · 3f4144ec
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98135
      
      Reviewed by Vsevolod Vlasov.
      
      Fixing front-end compilation errors.
      
      * inspector/InjectedScriptCanvasModuleSource.js:
      (.):
      * inspector/InjectedScriptSource.js:
      (.):
      * inspector/front-end/DOMExtension.js:
      (Element.prototype.pruneEmptyTextNodes):
      * inspector/front-end/DatabaseQueryView.js:
      * inspector/front-end/ExtensionAPI.js:
      * inspector/front-end/JavaScriptSource.js:
      (WebInspector.JavaScriptSource.prototype.workingCopyCommitted):
      * inspector/front-end/RuntimeModel.js:
      * inspector/front-end/StylesSidebarPane.js:
      * inspector/front-end/TextPrompt.js:
      (WebInspector.TextPrompt.SuggestBox.prototype._updateItems):
      * inspector/front-end/treeoutline.js:
      (TreeElement.prototype.expandRecursively):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130154 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f4144ec
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · d8abfc5f
      zandobersek@gmail.com authored
      Rebaselining MathML tests as required after r129695 and r130097.
      Adding a missing baseline expectation for accessibility/svg-bounds.html.
      The baseline will be added soon-ish.
      
      * platform/gtk/TestExpectations:
      * platform/gtk/mathml/presentation/attributes-expected.png:
      * platform/gtk/mathml/presentation/attributes-expected.txt:
      * platform/gtk/mathml/presentation/fractions-expected.png:
      * platform/gtk/mathml/presentation/fractions-expected.txt:
      * platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.png:
      * platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt:
      * platform/gtk/mathml/presentation/mo-stretch-expected.png:
      * platform/gtk/mathml/presentation/mo-stretch-expected.txt:
      * platform/gtk/mathml/presentation/over-expected.png:
      * platform/gtk/mathml/presentation/over-expected.txt:
      * platform/gtk/mathml/presentation/roots-expected.png:
      * platform/gtk/mathml/presentation/roots-expected.txt:
      * platform/gtk/mathml/presentation/row-alignment-expected.png:
      * platform/gtk/mathml/presentation/row-alignment-expected.txt:
      * platform/gtk/mathml/presentation/subsup-expected.png:
      * platform/gtk/mathml/presentation/subsup-expected.txt:
      * platform/gtk/mathml/presentation/tables-expected.png:
      * platform/gtk/mathml/presentation/tables-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130153 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8abfc5f
    • jochen@chromium.org's avatar
      [chromium] ASSERT that the embedder has set a default locale · 72ed3827
      jochen@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98001
      
      Reviewed by Adam Barth.
      
      The callsites assume that the default language is always defined, e.g.
      Document::getCachedLocalizer. Add an ASSERT() statement so an embedder
      doesn't have to guess what they did wrong.
      
      * platform/chromium/LanguageChromium.cpp:
      (WebCore::platformLanguage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130152 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      72ed3827
    • vsevik@chromium.org's avatar
      Web Inspector: Fix JavaScriptSource error found by compiler · ea8550a1
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98143
      
      Reviewed by Pavel Feldman.
      
      * inspector/front-end/JavaScriptSource.js:
      (WebInspector.JavaScriptSource.prototype.workingCopyCommitted):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130151 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea8550a1
    • mkwst@chromium.org's avatar
      Add call stacks to Content Security Policy checks when relevant. · 109f7e70
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=94433
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Previously, we generated stack traces only for eval-related CSP
      violations. As it turns out, we can call createScriptCallStack from
      practically anywhere. This patch takes advantage of that to generate
      stack traces whenever a warning is logged to the console. If we're in
      a JavaScript stack, brilliant: we get a detailed warning. If not, the
      stack trace is empty, and we don't pass it into the console logging
      method.
      
      This has the advantage of giving us good developer-facing logging for
      any and all violations that result from script-based injection of
      resources. Yay!
      
      Tests: http/tests/inspector/csp-injected-content-warning-contains-stacktrace.html
             http/tests/inspector/csp-inline-warning-contains-stacktrace.html
             http/tests/inspector/csp-setInterval-warning-contains-stacktrace.html
             http/tests/inspector/csp-setTimeout-warning-contains-stacktrace.html
      
      * bindings/js/ScheduledAction.cpp:
      (WebCore::ScheduledAction::create):
          Replacing the generated stack trace with the current script state,
          which will enable us to generate the stack trace inside
          ContentSecurityPolicy::reportViolation if it's relevant.
      * bindings/v8/ScriptCallStackFactory.cpp:
      (WebCore::createScriptCallStackForConsole):
      (WebCore):
      * bindings/v8/ScriptCallStackFactory.h:
      (WebCore):
          Adding a dummy interface to createScriptCallStackForConsole that
          allows ScriptState to be passed in, which matches JSC's interface.
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      (WebCore::WindowSetTimeoutImpl):
      * bindings/v8/custom/V8WorkerContextCustom.cpp:
      (WebCore::SetTimeoutOrInterval):
          Dropping stack trace from call to ContentSecurityPolicy::allowEval.
      * page/ContentSecurityPolicy.cpp:
      (CSPDirectiveList):
      (WebCore::CSPDirectiveList::reportViolation):
      (WebCore::CSPDirectiveList::checkEvalAndReportViolation):
      (WebCore::CSPDirectiveList::allowEval):
          Piping script state through from CSPDirectiveList::allowEval rather
          than a full stack trace.
      (WebCore):
      (WebCore::isAllowedByAll):
      (WebCore::isAllowedByAllWithState):
      (WebCore::ContentSecurityPolicy::allowEval):
      (WebCore::ContentSecurityPolicy::reportViolation):
      (WebCore::ContentSecurityPolicy::logToConsole):
          Piping script state through from ContentSecurityPolicy::allowEval
          rather than a full stack trace. Now, we can simply generate the
          stack trace just before logging it, and only pass it into
          addConsoleMessage if it's non-empty.
      * page/ContentSecurityPolicy.h:
      (JSC):
      (WebCore):
          Including 'ScriptState.h' to normalize V8 and JSC's JS state objects.
      
      LayoutTests:
      
      * http/tests/inspector-enabled/contentSecurityPolicy-blocks-setInterval-expected.txt: Removed.
      * http/tests/inspector-enabled/contentSecurityPolicy-blocks-setInterval.html: Removed.
      * http/tests/inspector-enabled/contentSecurityPolicy-blocks-setTimeout-expected.txt: Removed.
      * http/tests/inspector-enabled/contentSecurityPolicy-blocks-setTimeout.html: Removed.
          Moved these tests to http/test/inspector, and rewrote them for consistency.
      * http/tests/inspector/csp-injected-content-warning-contains-stacktrace-expected.txt: Added.
      * http/tests/inspector/csp-injected-content-warning-contains-stacktrace.html: Added.
      * http/tests/inspector/csp-inline-warning-contains-stacktrace-expected.txt: Added.
      * http/tests/inspector/csp-inline-warning-contains-stacktrace.html: Added.
      * http/tests/inspector/csp-setInterval-contains-stacktrace-expected.txt: Added.
      * http/tests/inspector/csp-setInterval-warning-contains-stacktrace.html: Added.
      * http/tests/inspector/csp-setTimeout-warning-contains-stacktrace-expected.txt: Added.
      * http/tests/inspector/csp-setTimeout-warning-contains-stacktrace.html: Added.
      * http/tests/inspector/resources/csp-inline-test.js: Added.
      (thisTest):
      * http/tests/inspector/resources/csp-test.js: Added.
      (test.addMessage):
      (test):
          Two new tests for the functionality.
      * platform/chromium/http/tests/inspector/csp-injected-content-warning-contains-stacktrace-expected.txt: Added.
      * platform/chromium/http/tests/inspector/csp-inline-warning-contains-stacktrace-expected.txt: Added.
      * platform/chromium/http/tests/inspector/csp-setInterval-contains-stacktrace-expected.txt: Added.
      * platform/chromium/http/tests/inspector/csp-setTimeout-warning-contains-stacktrace-expected.txt: Added.
          The stacktrace looks slightly different under JSC than V8.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130150 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      109f7e70
    • pfeldman@chromium.org's avatar
      Web Inspector: migrate from WebInspector.Foo.prototype.__proto__ = to __proto__: syntax · c1dd2f87
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98127
      
      Reviewed by Vsevolod Vlasov.
      
      Converted with the regex matcher.
      
      * inspector/InjectedScriptCanvasModuleSource.js:
      (.):
      * inspector/compile-front-end.py:
      * inspector/front-end/AdvancedSearchController.js:
      (WebInspector.SearchView.prototype._onAction):
      (WebInspector.FileBasedSearchResultsPane.prototype._createContentSpan):
      * inspector/front-end/ApplicationCacheItemsView.js:
      * inspector/front-end/ApplicationCacheModel.js:
      (WebInspector.ApplicationCacheModel.prototype._networkStateUpdated):
      * inspector/front-end/AuditCategories.js:
      (WebInspector.AuditCategories.PagePerformance.prototype.initialize):
      (WebInspector.AuditCategories.NetworkUtilization.prototype.initialize):
      * inspector/front-end/AuditLauncherView.js:
      (WebInspector.AuditLauncherView.prototype._updateButton):
      * inspector/front-end/AuditResultView.js:
      (WebInspector.AuditCategoryResultPane.prototype._appendResult):
      * inspector/front-end/AuditRules.js:
      (WebInspector.AuditRules.GzipRule.prototype._shouldCompress):
      (WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun):
      (WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun):
      (WebInspector.AuditRules.ParallelizeDownloadRule.prototype.doRun):
      (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
      (WebInspector.AuditRules.CacheControlRule.prototype.isCacheableResource):
      (WebInspector.AuditRules.BrowserCacheControlRule.prototype._oneYearExpirationCheck):
      (WebInspector.AuditRules.ProxyCacheControlRule.prototype._setCookieCacheableCheck):
      (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
      (WebInspector.AuditRules.CssInHeadRule.prototype.doRun):
      (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun):
      (WebInspector.AuditRules.CSSRuleBase.prototype.visitProperty):
      (WebInspector.AuditRules.VendorPrefixedCSSProperties.prototype.visitProperty):
      (WebInspector.AuditRules.CookieRuleBase.prototype._callbackForResourceCookiePairs):
      (WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
      (WebInspector.AuditRules.StaticCookielessRule.prototype._collectorCallback):
      * inspector/front-end/AuditsPanel.js:
      (WebInspector.AuditsPanel.prototype._clearButtonClicked):
      (WebInspector.AuditsSidebarTreeElement.prototype.refresh):
      (WebInspector.AuditResultSidebarTreeElement.prototype.get selectable):
      * inspector/front-end/BottomUpProfileDataGridTree.js:
      (WebInspector.BottomUpProfileDataGridNode.prototype._willHaveChildren):
      * inspector/front-end/BreakpointManager.js:
      (WebInspector.BreakpointManager.prototype._uiLocationRemoved):
      * inspector/front-end/BreakpointsSidebarPane.js:
      (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.reset):
      (WebInspector.XHRBreakpointsSidebarPane.prototype.set _restoreBreakpoints):
      (WebInspector.EventListenerBreakpointsSidebarPane.prototype.set _restoreBreakpoints):
      * inspector/front-end/CPUProfileView.js:
      (WebInspector.CPUProfileView.prototype._assignParentsInProfile):
      (WebInspector.CPUProfileType.prototype.createProfile):
      (WebInspector.CPUProfileHeader.prototype.createView):
      * inspector/front-end/CSSNamedFlowCollectionsView.js:
      (WebInspector.CSSNamedFlowCollectionsView.prototype.willHide):
      (WebInspector.FlowTreeElement.prototype.setOverset):
      * inspector/front-end/CSSNamedFlowView.js:
      (WebInspector.CSSNamedFlowView.prototype._update):
      * inspector/front-end/CSSSelectorProfileView.js:
      (WebInspector.CSSSelectorDataGridNode.prototype.createCell):
      (WebInspector.CSSSelectorProfileType.prototype.createTemporaryProfile):
      (WebInspector.CSSProfileHeader.prototype.createView):
      * inspector/front-end/CSSStyleModel.js:
      (WebInspector.CSSStyleModel.prototype._rawLocationToUILocation):
      * inspector/front-end/CallStackSidebarPane.js:
      (WebInspector.CallStackSidebarPane.prototype._keyDown):
      (WebInspector.CallStackSidebarPane.Placard.prototype._restartFrame):
      * inspector/front-end/CanvasProfileView.js:
      (WebInspector.CanvasProfileView.prototype._onTraceLogItemClick):
      (WebInspector.CanvasProfileType.prototype.createProfile):
      (WebInspector.CanvasProfileHeader.prototype.createView):
      * inspector/front-end/CodeMirrorTextEditor.js:
      (WebInspector.CodeMirrorTextEditor.prototype._toRange):
      * inspector/front-end/ConsoleMessage.js:
      (WebInspector.ConsoleMessageImpl.prototype.clone):
      * inspector/front-end/ConsoleModel.js:
      (WebInspector.ConsoleModel.prototype._messageRepeatCountUpdated):
      * inspector/front-end/ConsolePanel.js:
      (WebInspector.ConsolePanel.prototype._consoleCleared):
      * inspector/front-end/ConsoleView.js:
      (WebInspector.ConsoleView.prototype._dumpMemory):
      (WebInspector.ConsoleCommandResult.prototype.toMessageElement):
      * inspector/front-end/ContentProviders.js:
      (WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):
      (WebInspector.CompilerSourceMappingContentProvider.prototype.searchInContent):
      (WebInspector.StaticContentProvider.prototype.searchInContent):
      * inspector/front-end/ContextMenu.js:
      (WebInspector.ContextSubMenuItem.prototype._buildDescriptor):
      (WebInspector.ContextMenu.prototype.appendApplicableItems):
      * inspector/front-end/CookieItemsView.js:
      (WebInspector.CookieItemsView.prototype._contextMenu):
      (WebInspector.SimpleCookiesTable.prototype.setCookies):
      * inspector/front-end/CookiesTable.js:
      (WebInspector.CookiesTable.prototype._onDeleteFromGrid):
      * inspector/front-end/DOMAgent.js:
      (WebInspector.DOMAgent.prototype.redo):
      * inspector/front-end/DOMBreakpointsSidebarPane.js:
      (WebInspector.DOMBreakpointsSidebarPane.prototype.set restoreBreakpoints):
      * inspector/front-end/DOMStorage.js:
      (WebInspector.DOMStorageModel.prototype.storages):
      * inspector/front-end/DOMStorageItemsView.js:
      (WebInspector.DOMStorageItemsView.prototype._deleteCallback):
      * inspector/front-end/DataGrid.js:
      (WebInspector.DataGridNode.prototype.restorePosition):
      (WebInspector.CreationDataGridNode.prototype.makeNormal):
      * inspector/front-end/Database.js:
      (WebInspector.DatabaseModel.prototype._addDatabase):
      * inspector/front-end/DatabaseQueryView.js:
      (WebInspector.DatabaseQueryView.prototype._appendQueryResult):
      * inspector/front-end/DatabaseTableView.js:
      (WebInspector.DatabaseTableView.prototype._refreshButtonClicked):
      * inspector/front-end/DebuggerModel.js:
      (WebInspector.DebuggerModel.prototype.callStackModified):
      * inspector/front-end/DefaultTextEditor.js:
      (WebInspector.DefaultTextEditor.prototype.willHide):
      (WebInspector.TextEditorGutterPanel.prototype.removeDecoration):
      (WebInspector.TextEditorMainPanel.prototype._collectLinesFromDiv):
      * inspector/front-end/Dialog.js:
      (WebInspector.DialogDelegate.prototype.willHide):
      * inspector/front-end/DirectoryContentView.js:
      (WebInspector.DirectoryContentView.prototype._sort):
      (WebInspector.DirectoryContentView.Node.prototype._metadataReceived):
      * inspector/front-end/ElementsPanel.js:
      (WebInspector.ElementsPanel.prototype.appendApplicableItems):
      * inspector/front-end/ElementsPanelDescriptor.js:
      (WebInspector.ElementsPanelDescriptor.prototype.appendApplicableItems):
      * inspector/front-end/ElementsTreeOutline.js:
      (WebInspector.ElementsTreeOutline.prototype._selectNodeAfterEdit):
      (WebInspector.ElementsTreeOutline.PseudoStateDecorator.prototype.decorateAncestor):
      * inspector/front-end/EmptyView.js:
      * inspector/front-end/EventListenersSidebarPane.js:
      (WebInspector.EventListenersSidebarPane.prototype):
      * inspector/front-end/ExtensionAPI.js:
      (injectedExtensionAPI.PanelWithSidebarImpl.prototype.createSidebarPane):
      (injectedExtensionAPI.ExtensionPanelImpl.prototype.show):
      * inspector/front-end/ExtensionPanel.js:
      (WebInspector.ExtensionPanel.prototype.jumpToPreviousSearchResult):
      (WebInspector.ExtensionSidebarPane.prototype._setObject):
      * inspector/front-end/ExtensionView.js:
      (WebInspector.ExtensionView.prototype._onLoad):
      (WebInspector.ExtensionNotifierView.prototype.willHide):
      * inspector/front-end/FileContentView.js:
      (WebInspector.FileContentView.prototype.refresh):
      * inspector/front-end/FileManager.js:
      (WebInspector.FileManager.prototype.appendedToURL):
      * inspector/front-end/FileSystemModel.js:
      (WebInspector.FileSystemModel.prototype._removeFileSystem):
      (WebInspector.FileSystemModel.Directory.prototype.requestDirectoryContent):
      (WebInspector.FileSystemModel.File.prototype.requestFileContent):
      * inspector/front-end/FileSystemView.js:
      (WebInspector.FileSystemView.prototype._delete):
      (WebInspector.FileSystemView.EntryTreeElement.prototype._deletionCompleted):
      * inspector/front-end/FilteredItemSelectionDialog.js:
      (WebInspector.FilteredItemSelectionDialog.prototype._itemElementInViewport):
      (WebInspector.JavaScriptOutlineDialog.prototype.rewriteQuery):
      (WebInspector.OpenResourceDialog.prototype.rewriteQuery):
      * inspector/front-end/FontView.js:
      (WebInspector.FontView.prototype.updateFontPreviewSize):
      * inspector/front-end/GoToLineDialog.js:
      (WebInspector.GoToLineDialog.prototype.onEnter):
      * inspector/front-end/HandlerRegistry.js:
      (WebInspector.HandlerRegistry.prototype._appendHrefItems):
      * inspector/front-end/HeapSnapshot.js:
      (WebInspector.HeapSnapshotEdgesProvider.prototype.sort):
      (WebInspector.HeapSnapshotNodesProvider.prototype.sort):
      * inspector/front-end/HeapSnapshotDataGrids.js:
      (WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingLeave):
      (WebInspector.HeapSnapshotViewportDataGrid.prototype._onScroll):
      (WebInspector.HeapSnapshotContainmentDataGrid.prototype.sortingChanged):
      (WebInspector.HeapSnapshotDiffDataGrid.prototype._populateChildren):
      (WebInspector.HeapSnapshotDominatorsDataGrid.prototype.highlightObjectByHeapSnapshotId):
      * inspector/front-end/HeapSnapshotGridNodes.js:
      (WebInspector.HeapSnapshotGridNode.prototype.sort):
      (WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL):
      (WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):
      (WebInspector.HeapSnapshotInstanceNode.prototype.get isDeletedNode):
      (WebInspector.HeapSnapshotConstructorNode.prototype.get _shallowSizePercent):
      (WebInspector.HeapSnapshotDiffNode.prototype.get data):
      (WebInspector.HeapSnapshotDominatorObjectNode.prototype._emptyData):
      * inspector/front-end/HeapSnapshotProxy.js:
      (WebInspector.HeapSnapshotWorkerWrapper.prototype.terminate):
      (WebInspector.HeapSnapshotRealWorker.prototype.terminate):
      (WebInspector.HeapSnapshotFakeWorker.prototype._postMessageFromWorker):
      (WebInspector.HeapSnapshotWorker.prototype._postMessage):
      (WebInspector.HeapSnapshotLoaderProxy.prototype.close):
      (WebInspector.HeapSnapshotProxy.prototype.get uid):
      (WebInspector.HeapSnapshotProviderProxy.prototype.sortAndRewind):
      * inspector/front-end/HeapSnapshotView.js:
      (WebInspector.HeapSnapshotView.prototype._updateFilterOptions):
      (WebInspector.HeapSnapshotProfileType.prototype.createProfile):
      (WebInspector.HeapProfileHeader.prototype._createFileReader):
      * inspector/front-end/HelpScreen.js:
      (WebInspector.HelpScreen.prototype._onBlur):
      * inspector/front-end/ImageView.js:
      (WebInspector.ImageView.prototype._openInNewTab):
      * inspector/front-end/IndexedDBModel.js:
      (WebInspector.IndexedDBModel.prototype._requestData):
      * inspector/front-end/IndexedDBViews.js:
      (WebInspector.IDBDataView.prototype.clear):
      (WebInspector.IDBDataGridNode.prototype._formatValue):
      * inspector/front-end/InspectorFrontendHostStub.js:
      (.WebInspector.ClipboardAccessDeniedScreen):
      * inspector/front-end/InspectorView.js:
      (WebInspector.InspectorView.prototype.showPanelForAnchorNavigation):
      * inspector/front-end/JavaScriptSource.js:
      (WebInspector.JavaScriptSource.prototype.workingCopyCommitted):
      * inspector/front-end/JavaScriptSourceFrame.js:
      (WebInspector.JavaScriptSourceFrame.prototype._continueToLine):
      * inspector/front-end/Linkifier.js:
      (WebInspector.Linkifier.DefaultFormatter.prototype.formatLiveAnchor):
      * inspector/front-end/MemoryStatistics.js:
      (WebInspector.SwatchCheckbox.prototype._toggleCheckbox):
      * inspector/front-end/MetricsSidebarPane.js:
      (WebInspector.MetricsSidebarPane.prototype.editingCommitted):
      * inspector/front-end/NativeBreakpointsSidebarPane.js:
      (WebInspector.NativeBreakpointsSidebarPane.prototype._reset):
      * inspector/front-end/NativeMemorySnapshotView.js:
      (WebInspector.NativeMemorySnapshotView.prototype.get profile):
      (WebInspector.NativeMemoryProfileType.prototype.createProfile):
      (WebInspector.NativeMemoryProfileHeader.prototype.createView):
      (WebInspector.NativeMemoryPieChart.prototype._clear):
      (WebInspector.NativeMemoryBarChart.prototype._updateView):
      * inspector/front-end/NavigatorView.js:
      (WebInspector.NavigatorView.prototype.handleContextMenu):
      (WebInspector.NavigatorTreeOutline.prototype.searchFinished):
      (WebInspector.BaseNavigatorTreeElement.prototype.matchesSearchText):
      (WebInspector.NavigatorFolderTreeElement.prototype.onattach):
      (WebInspector.NavigatorSourceTreeElement.prototype._handleContextMenuEvent):
      * inspector/front-end/NetworkItemView.js:
      (WebInspector.NetworkItemView.prototype.set request):
      (WebInspector.RequestContentView.prototype.highlightLine):
      * inspector/front-end/NetworkManager.js:
      (WebInspector.NetworkManager.prototype._userAgentSettingChanged):
      * inspector/front-end/NetworkPanel.js:
      (WebInspector.NetworkLogView.prototype._highlightNode):
      (WebInspector.NetworkPanel.prototype.appendApplicableItems):
      (WebInspector.NetworkTimeCalculator.prototype._upperBound):
      (WebInspector.NetworkTransferTimeCalculator.prototype._upperBound):
      (WebInspector.NetworkTransferDurationCalculator.prototype._upperBound):
      (WebInspector.NetworkDataGridNode.prototype._refreshLabelPositions):
      (WebInspector.NetworkDataGridNode.RequestPropertyComparator):
      * inspector/front-end/NetworkPanelDescriptor.js:
      (WebInspector.NetworkPanelDescriptor.prototype.appendApplicableItems):
      * inspector/front-end/NetworkRequest.js:
      (WebInspector.NetworkRequest.prototype._pushFrame):
      * inspector/front-end/ObjectPopoverHelper.js:
      (WebInspector.ObjectPopoverHelper.prototype._updateHTMLId):
      * inspector/front-end/ObjectPropertiesSection.js:
      (WebInspector.ObjectPropertiesSection.prototype.updateProperties):
      (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
      (WebInspector.FunctionScopeMainTreeElement.prototype.onpopulate):
      (WebInspector.ScopeTreeElement.prototype.onpopulate):
      (WebInspector.ArrayGroupingTreeElement.prototype.onattach):
      * inspector/front-end/Panel.js:
      (WebInspector.Panel.prototype.unregisterShortcut):
      * inspector/front-end/PanelEnablerView.js:
      (WebInspector.PanelEnablerView.prototype.get alwaysEnabled):
      * inspector/front-end/ProfileDataGridTree.js:
      (WebInspector.ProfileDataGridNode.prototype._merge):
      * inspector/front-end/ProfileLauncherView.js:
      (WebInspector.ProfileLauncherView.prototype.profileFinished):
      * inspector/front-end/ProfilesPanel.js:
      (WebInspector.ProfilesPanel.prototype.appendApplicableItems):
      (WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent):
      (WebInspector.ProfileGroupSidebarTreeElement.prototype.onselect):
      (WebInspector.ProfilesSidebarTreeElement.prototype.get selectable):
      * inspector/front-end/ProgressIndicator.js:
      (WebInspector.ProgressIndicator.prototype.worked):
      * inspector/front-end/PropertiesSection.js:
      * inspector/front-end/PropertiesSidebarPane.js:
      (WebInspector.PropertiesSidebarPane.prototype.update):
      * inspector/front-end/RequestCookiesView.js:
      (WebInspector.RequestCookiesView.prototype._refreshCookies):
      * inspector/front-end/RequestHTMLView.js:
      (WebInspector.RequestHTMLView.prototype._createIFrame):
      * inspector/front-end/RequestHeadersView.js:
      (WebInspector.RequestHeadersView.prototype._createHeadersToggleButton):
      * inspector/front-end/RequestJSONView.js:
      (WebInspector.RequestJSONView.parseJSON.WebInspector.RequestJSONView.prototype._initialize):
      * inspector/front-end/RequestPreviewView.js:
      (WebInspector.RequestPreviewView.prototype._createPreviewView):
      * inspector/front-end/RequestResponseView.js:
      (WebInspector.RequestResponseView.prototype.contentLoaded):
      * inspector/front-end/RequestTimingView.js:
      (WebInspector.RequestTimingView.prototype._refresh):
      (WebInspector.RequestTimingView.createTimingTable):
      * inspector/front-end/RequestView.js:
      (WebInspector.RequestView.prototype.hasContent):
      * inspector/front-end/Resource.js:
      (WebInspector.Resource.prototype.isHidden):
      * inspector/front-end/ResourceTreeModel.js:
      (WebInspector.ResourceTreeModel.prototype._createResourceFromFramePayload):
      * inspector/front-end/ResourceView.js:
      (WebInspector.ResourceView.prototype.hasContent):
      (WebInspector.ResourceSourceFrame.prototype.populateTextAreaContextMenu):
      * inspector/front-end/ResourceWebSocketFrameView.js:
      * inspector/front-end/ResourcesPanel.js:
      (WebInspector.ResourcesPanel.prototype._onmouseout):
      (WebInspector.BaseStorageTreeElement.prototype.get searchMatchesCount):
      (WebInspector.StorageCategoryTreeElement.prototype.set oncollapse):
      (WebInspector.FrameTreeElement.prototype._insertInPresentationOrder):
      (WebInspector.FrameResourceTreeElement.prototype.sourceView):
      (WebInspector.DatabaseTreeElement.prototype._updateChildren):
      (WebInspector.DatabaseTableTreeElement.prototype.onselect):
      (WebInspector.IndexedDBTreeElement.prototype._idbDatabaseTreeElement):
      (WebInspector.FileSystemListTreeElement.prototype._refreshFileSystem):
      (WebInspector.IDBDatabaseTreeElement.prototype.clear):
      (WebInspector.IDBObjectStoreTreeElement.prototype.clear):
      (WebInspector.IDBIndexTreeElement.prototype.clear):
      (WebInspector.DOMStorageTreeElement.prototype.onselect):
      (WebInspector.CookieTreeElement.prototype.onselect):
      (WebInspector.ApplicationCacheManifestTreeElement.prototype.onselect):
      (WebInspector.ApplicationCacheFrameTreeElement.prototype.onselect):
      (WebInspector.FileSystemTreeElement.prototype.clear):
      (WebInspector.StorageCategoryView.prototype.setText):
      * inspector/front-end/RevisionHistoryView.js:
      (WebInspector.RevisionHistoryView.prototype._reset):
      (WebInspector.RevisionHistoryTreeElement.prototype.allowRevert):
      * inspector/front-end/RuntimeModel.js:
      (WebInspector.RuntimeModel.prototype._reportCompletions):
      (WebInspector.FrameExecutionContextList.prototype.get displayName):
      * inspector/front-end/ScopeChainSidebarPane.js:
      (WebInspector.ScopeChainSidebarPane.prototype.update):
      (WebInspector.ScopeVariableTreeElement.prototype.get propertyPath):
      * inspector/front-end/Script.js:
      (WebInspector.Script.Location.prototype.dispose):
      * inspector/front-end/ScriptFormatterWorker.js:
      (HTMLScriptFormatter.prototype.styleSheetEnded):
      * inspector/front-end/ScriptSnippetModel.js:
      (WebInspector.ScriptSnippetModel.prototype._projectDidReset):
      (WebInspector.SnippetJavaScriptSource.prototype.workingCopyChanged):
      * inspector/front-end/ScriptsNavigator.js:
      (WebInspector.ScriptsNavigator.prototype.reset):
      (WebInspector.SnippetsNavigatorView.prototype._snippetCreationRequested):
      * inspector/front-end/ScriptsPanel.js:
      (WebInspector.ScriptsPanel.prototype.showGoToSourceDialog):
      * inspector/front-end/ScriptsPanelDescriptor.js:
      (WebInspector.ScriptsPanelDescriptor.prototype.appendApplicableItems):
      * inspector/front-end/ScriptsSearchScope.js:
      (WebInspector.ScriptsSearchScope.prototype._sortedUISourceCodes):
      * inspector/front-end/SettingsScreen.js:
      (WebInspector.SettingsScreen.prototype.willHide):
      (WebInspector.SettingsTab.prototype._createCustomSetting):
      (WebInspector.GenericSettingsTab.prototype._javaScriptDisabledChanged):
      (WebInspector.UserAgentSettingsTab.prototype._createDeviceOrientationOverrideElement):
      (WebInspector.ExperimentsSettingsTab.prototype._createExperimentCheckbox):
      * inspector/front-end/ShowMoreDataGridNode.js:
      (WebInspector.ShowMoreDataGridNode.prototype.dispose):
      * inspector/front-end/SidebarPane.js:
      (WebInspector.SidebarPane.prototype._onTitleKeyDown):
      * inspector/front-end/SidebarTreeElement.js:
      (WebInspector.SidebarSectionTreeElement.prototype.onreveal):
      (WebInspector.SidebarTreeElement.prototype.onreveal):
      * inspector/front-end/SnippetJavaScriptSourceFrame.js:
      (WebInspector.SnippetJavaScriptSourceFrame.prototype._runButtonClicked):
      * inspector/front-end/SnippetStorage.js:
      (WebInspector.Snippet.prototype.serializeToObject):
      * inspector/front-end/SourceCSSTokenizer.js:
      (WebInspector.SourceCSSTokenizer.prototype.nextToken):
      * inspector/front-end/SourceCSSTokenizer.re2js:
      * inspector/front-end/SourceFrame.js:
      (WebInspector.SourceFrame.prototype._commitEditing):
      (WebInspector.TextEditorDelegateForSourceFrame.prototype.createLink):
      * inspector/front-end/SourceHTMLTokenizer.js:
      (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
      * inspector/front-end/SourceHTMLTokenizer.re2js:
      * inspector/front-end/SourceJavaScriptTokenizer.js:
      (WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
      * inspector/front-end/SourceJavaScriptTokenizer.re2js:
      * inspector/front-end/Spectrum.js:
      (WebInspector.Spectrum.prototype._onKeyDown):
      * inspector/front-end/SplitView.js:
      (WebInspector.SplitView.prototype.set elementsToRestoreScrollPositionsFor):
      * inspector/front-end/StatusBarButton.js:
      (WebInspector.StatusBarButton.prototype._showOptions):
      * inspector/front-end/StyleSheetOutlineDialog.js:
      (WebInspector.StyleSheetOutlineDialog.prototype.rewriteQuery):
      * inspector/front-end/StyleSource.js:
      (WebInspector.StyleSource.prototype._clearIncrementalUpdateTimer):
      * inspector/front-end/StylesSidebarPane.js:
      (WebInspector.StylesSidebarPane.prototype.willHide):
      (WebInspector.ComputedStyleSidebarPane.prototype.expand):
      (WebInspector.StylePropertiesSection.prototype.editingSelectorCancelled):
      (WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
      (WebInspector.BlankStylePropertiesSection.prototype.makeNormal):
      (WebInspector.StylePropertyTreeElement.prototype):
      * inspector/front-end/TabbedEditorContainer.js:
      (WebInspector.TabbedEditorContainer.prototype.currentFile):
      (WebInspector.TabbedEditorContainer.HistoryItem.prototype.serializeToObject):
      (WebInspector.TabbedEditorContainer.History.prototype.set _serializeToObject):
      * inspector/front-end/TabbedPane.js:
      (WebInspector.TabbedPane.prototype._insertBefore):
      * inspector/front-end/TextEditorModel.js:
      (WebInspector.TextEditorModel.endsWithBracketRegex.):
      * inspector/front-end/TextPrompt.js:
      (WebInspector.TextPromptWithHistory.prototype.defaultKeyHandler):
      * inspector/front-end/TimelineManager.js:
      (WebInspector.TimelineManager.prototype._stopped):
      * inspector/front-end/TimelineModel.js:
      (WebInspector.TimelineModel.prototype.recordOffsetInSeconds):
      * inspector/front-end/TimelineOverviewPane.js:
      (WebInspector.TimelineOverviewPane.prototype._scheduleRefresh):
      (WebInspector.TimelineOverviewWindow.prototype._zoom):
      (WebInspector.TimelineFrameOverview.prototype.getWindowTimes):
      * inspector/front-end/TimelinePanel.js:
      (WebInspector.TimelinePanel.prototype.performSearch):
      * inspector/front-end/TimelinePresentationModel.js:
      (WebInspector.TimelinePresentationModel.prototype.isVisible):
      (WebInspector.TimelineCategory.prototype.set hidden):
      * inspector/front-end/TopDownProfileDataGridTree.js:
      (WebInspector.TopDownProfileDataGridNode.prototype._exclude):
      * inspector/front-end/UISourceCode.js:
      (WebInspector.UISourceCode.prototype.setSourceMapping):
      * inspector/front-end/UISourceCodeFrame.js:
      (WebInspector.UISourceCodeFrame.prototype.populateTextAreaContextMenu):
      * inspector/front-end/View.js:
      (WebInspector.View.prototype.focus):
      * inspector/front-end/WatchExpressionsSidebarPane.js:
      (WebInspector.WatchExpressionsSidebarPane.prototype._refreshButtonClicked):
      (WebInspector.WatchExpressionsSection.prototype._updateHoveredElement):
      (WebInspector.WatchExpressionTreeElement.prototype.applyExpression):
      * inspector/front-end/WorkerManager.js:
      (WebInspector.WorkerManager.prototype._disconnectedFromWorker):
      (WebInspector.WorkerTerminatedScreen.prototype.willHide):
      * inspector/front-end/WorkersSidebarPane.js:
      (WebInspector.WorkersSidebarPane.prototype._autoattachToWorkersClicked):
      * inspector/front-end/Workspace.js:
      (WebInspector.Workspace.prototype.uiSourceCodes):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130149 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c1dd2f87
    • vsevik@chromium.org's avatar
      Unreviewed r130146 follow-up, added method was not called. · 3aed43d4
      vsevik@chromium.org authored
      * inspector/front-end/JavaScriptSource.js:
      (WebInspector.JavaScriptSource.prototype.workingCopyCommitted):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130148 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3aed43d4
    • yosin@chromium.org's avatar
      [Forms] Multiple fields datetime/datetime-local input UI · 4e5f0476
      yosin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97997
      
      Reviewed by Kent Tamura.
      
      Source/WebCore:
      
      This patch introduces multiple fields "datetime" and "datetime-local"
      input UI in DRT. We'll enable these features once we add tests.
      
      No new tests. To reduce size of this patch, other patches add tests
      for multiple fields datetime/datetime-local input UI.
      
      Note: Actual outputs of four tests
        - fast/forms/datetime/datetime-input-visible-string.html
        - fast/forms/datetime/datetime-stepup-stepdown-from-renderer.html
        - fast/forms/datetimelocal/datetimelocal-input-visible-string.html
        - fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer.html
      are different.
      
      * bindings/generic/RuntimeEnabledFeatures.cpp:
      (WebCore):
      * css/html.css:
      (input::-webkit-datetime-edit-day-field): Added for field appearance.
      (input::-webkit-datetime-edit-day-field:focus):  Added to remove focus ring.
      * html/DateTimeInputType.cpp:
      (WebCore::DateTimeInputType::formatDateTimeFieldsState): Added to format numeric value to string value as specified in HTML5 specification.
      (WebCore::DateTimeInputType::setupLayoutParameters): Added to set layout of multiple fields.
      * html/DateTimeInputType.h: Changed to include BaseMultipleFieldsDateAndTimeInputType.h and introduce BaseDateTimeInputType typedef.
      (WebCore::DateTimeInputType::DateTimeInputType): Changed base class name to BaseDateTimeInputType.
      (DateTimeInputType): Changed to add declarations for formatDateTimeFieldsState() and setupLayoutParameters().
      * html/DateTimeLocalInputType.cpp:
      (WebCore::DateTimeLocalInputType::formatDateTimeFieldsState): Added to format numeric value to string value as specified in HTML5 specification.
      (WebCore::DateTimeLocalInputType::setupLayoutParameters):  Added to set layout of multiple fields.
      * html/DateTimeLocalInputType.h: Changed to include BaseMultipleFieldsDateAndTimeInputType.h and introduce BaseDateTimeLocalInputType typedef.
      (WebCore::DateTimeLocalInputType::DateTimeLocalInputType): Changed base class name to BaseDateTimeLocalInputType.
      (DateTimeLocalInputType): Changed to add declarations for formatDateTimeFieldsState() and setupLayoutParameters().
      * html/shadow/DateTimeEditElement.cpp:
      (DateTimeEditBuilder): Changed to add member variable m_placeholderForDay.
      (WebCore::DateTimeEditBuilder::DateTimeEditBuilder): Changed to initialize m_placeholderForDay.
      (WebCore::DateTimeEditBuilder::visitField): Changed to support week field.
      * html/shadow/DateTimeEditElement.h:
      (LayoutParameters): Changed to add placeholderForDay member variable.
      
      LayoutTests:
      
      This patch adds Chromium port specific expectations for "datetime" and
      "datetime-local" input type tests for multiple fields datetime input UI.
      
      * platform/chromium/fast/forms/datetime/datetime-input-visible-string-expected.txt: Added. Multiple fields datetime input UI doesn't have selection.
      * platform/chromium/fast/forms/datetime/datetime-stepup-stepdown-from-renderer-expected.txt: Added. On multiple fields datetime input UI, step down/up decrement/increment a field rather than whole value.
      * platform/chromium/fast/forms/datetimelocal/datetimelocal-input-visible-string-expected.txt: Added. Multiple fields datetime-local input UI doesn't have selection.
      * platform/chromium/fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer-expected.txt: Added. On multiple fields datetime-local input UI, step down/up decrement/increment a field rather than whole value.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130147 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e5f0476
    • vsevik@chromium.org's avatar
      Web Inspector: [Regression] Breakpoints restored from storage are not set in debugger. · 55a7711e
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98132
      
      Reviewed by Pavel Feldman.
      
      Added hasDivergedFromVM attribute to UISourceCode for breakpoint
      manager to know if breakpoints should be set in the debugger.
      
      * inspector/front-end/BreakpointManager.js:
      (WebInspector.BreakpointManager.hasDivergedFromVM):
      (WebInspector.BreakpointManager.Breakpoint.prototype._updateBreakpoint):
      * inspector/front-end/JavaScriptSource.js:
      (WebInspector.JavaScriptSource.prototype.workingCopyCommitted):
      * inspector/front-end/ScriptSnippetModel.js:
      (WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130146 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55a7711e
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · 477dcbe4
      zandobersek@gmail.com authored
      Rebaselining fast/canvas/canvas-render-layer.html after r130056.
      Changing one calendar picker expectation after r130113.
      Marking fast/css/sticky/sticky-writing-mode-vertical-rl.html as flaky.
      
      * platform/gtk/TestExpectations:
      * platform/gtk/fast/canvas/canvas-render-layer-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130145 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      477dcbe4
    • loislo@chromium.org's avatar
      Web Inspector: NMI make String* instrumentation non intrusive · 506e5c28
      loislo@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97964
      
      Reviewed by Yury Semikhatsky.
      
      Source/WebCore:
      
      MemoryInstrumentationString.h include was added.
      
      * dom/WebCoreMemoryInstrumentation.h:
      
      Source/WebKit/chromium:
      
      The expectations were fixed because old instrumentation had wrong detector for BufferInternal type of storage.
      
      * tests/MemoryInstrumentationTest.cpp:
      (WebCore::TEST):
      
      Source/WTF:
      
      MemoryInstrumentationString.h was added.
      Intrusive instrumentation was removed.
      
      * GNUmakefile.list.am:
      * WTF.gypi:
      * WTF.pro:
      * WTF.vcproj/WTF.vcproj:
      * WTF.xcodeproj/project.pbxproj:
      * wtf/MemoryInstrumentation.h:
      (WTF):
      * wtf/MemoryInstrumentationString.h: Added.
      (WTF):
      (WTF::reportMemoryUsage):
      * wtf/text/AtomicString.cpp:
      (WTF):
      * wtf/text/AtomicString.h:
      (AtomicString):
      * wtf/text/CString.h:
      (WTF::CStringBuffer::length):
      * wtf/text/StringImpl.cpp:
      * wtf/text/StringImpl.h:
      (WTF::StringImpl::usesInternalBuffer):
      (WTF::StringImpl::baseString):
      (StringImpl):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130144 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      506e5c28
    • vsevik@chromium.org's avatar
      Web Inspector: inspector/debugger/script-snippet-model.html fails · 1b0ddada
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98129
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      * inspector/front-end/ScriptSnippetModel.js:
      (WebInspector.ScriptSnippetModel.prototype._runScript):
      (WebInspector.ScriptSnippetModel.prototype._printRunScriptResult):
      
      LayoutTests:
      
      * inspector/debugger/script-snippet-model.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130143 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b0ddada
    • yurys@chromium.org's avatar
      Remove anonymous namespace from StyleBuilder.cpp for better debugging experience · 799cd785
      yurys@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98124
      
      Reviewed by Alexander Pavlov.
      
      * css/StyleBuilder.cpp: removed anonymous namespace.
      (WebCore):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130142 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      799cd785
    • jochen@chromium.org's avatar
      Use correct gtest macros for tests for true/false · 567642f4
      jochen@chromium.org authored
      Unreviewed build-fix.
      
      Using EXPECT_EQ(true, ...) makes clang trip when it tries to convert
      true to a pointer. Tests should use EXPECT_TRUE instead.
      
      * tests/WebFrameTest.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130141 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      567642f4
    • commit-queue@webkit.org's avatar
      Web Inspector: CSS property names autocomplete: Suggest most used rather than alphabeticaly first · 59e04613
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96763
      
      Patch by Nikita Vasilyev <me@elv1s.ru> on 2012-10-02
      Reviewed by Alexander Pavlov.
      
      Implement selection of non-first item in WebInspector.TextPrompt.SuggestBox.
      
      * inspector/front-end/CSSCompletions.js:
      (WebInspector.CSSCompletions.Weight): Collect most used CSS property names. Rarely used properties are not presented.
      (WebInspector.CSSCompletions.prototype.firstStartsWith): Remove unused function.
      (WebInspector.CSSCompletions.prototype.mostUsedOf):
      * inspector/front-end/StylesSidebarPane.js:
      * inspector/front-end/TextPrompt.js:
      (WebInspector.TextPrompt.prototype._completionsReady):
      (WebInspector.TextPrompt.prototype.pageDownKeyPressed):
      (WebInspector.TextPrompt.SuggestBox): Introduce _length and _selectedIndex to remove unnecessary DOM traversals.
          Simplify canShowForSingleItem logic.
      (WebInspector.TextPrompt.SuggestBox.prototype._selectClosest): _onPreviousItem and _onNextItem had some logic
          duplication so I replaced them with this method.
      (WebInspector.TextPrompt.SuggestBox.prototype.updateSuggestions):
      (WebInspector.TextPrompt.SuggestBox.prototype._updateItems):
      (WebInspector.TextPrompt.SuggestBox.prototype._selectItem):
      (WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):
      (WebInspector.TextPrompt.SuggestBox.prototype.upKeyPressed):
      (WebInspector.TextPrompt.SuggestBox.prototype.downKeyPressed):
      (WebInspector.TextPrompt.SuggestBox.prototype.pageUpKeyPressed):
      (WebInspector.TextPrompt.SuggestBox.prototype.pageDownKeyPressed):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130140 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59e04613
    • keishi@webkit.org's avatar
      Web Inspector: Modifications in a shadow tree don't update the Elements panel. · 56f068bb
      keishi@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97056
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      Send characterDataModified event for shadow dom nodes too so they update the elements panel.
      
      Test: inspector/elements/shadow-dom-modify-chardata.html
      
      * dom/CharacterData.cpp:
      (WebCore::CharacterData::dispatchModifiedEvent):
      
      LayoutTests:
      
      * inspector/elements/shadow-dom-modify-chardata-expected.txt: Added.
      * inspector/elements/shadow-dom-modify-chardata.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130139 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56f068bb
    • vsevik@chromium.org's avatar
      Web Inspector: Provide a way to distinguish scripts having sourceURL from standalone scripts. · 44823a90
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97231
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      DebuggerAgent now scans scripts for sourceURL comment and provides
      hasSourceURL flag for each non-inline script with such a comment.
      
      * bindings/js/ScriptDebugServer.cpp:
      (WebCore::ScriptDebugServer::dispatchDidParseSource):
      * inspector/Inspector.json:
      * inspector/InspectorDebuggerAgent.cpp:
      (WebCore::InspectorDebuggerAgent::didParseSource):
      * inspector/front-end/DebuggerModel.js:
      (WebInspector.DebuggerModel.prototype._parsedScriptSource):
      (WebInspector.DebuggerDispatcher.prototype.scriptParsed):
      * inspector/front-end/Script.js:
      (WebInspector.Script):
      
      LayoutTests:
      
      * inspector/debugger/source-url-comment-expected.txt:
      * inspector/debugger/source-url-comment.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130138 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44823a90
    • caseq@chromium.org's avatar
      Unreviewed, rolling out r130129. · f7d05cdc
      caseq@chromium.org authored
      http://trac.webkit.org/changeset/130129
      https://bugs.webkit.org/show_bug.cgi?id=98125
      
      broke 4 webkit_unit_tests
      (MemoryInstrumentationTest.hashMapWith*) (Requested by caseq
      on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-02
      
      Source/WebCore:
      
      * dom/WebCoreMemoryInstrumentation.h:
      * platform/KURL.cpp:
      * platform/KURLGoogle.cpp:
      * platform/PlatformMemoryInstrumentation.h:
      
      Source/WebKit/chromium:
      
      * tests/MemoryInstrumentationTest.cpp:
      
      Source/WTF:
      
      * GNUmakefile.list.am:
      * WTF.gypi:
      * WTF.pro:
      * WTF.vcproj/WTF.vcproj:
      * WTF.xcodeproj/project.pbxproj:
      * wtf/MemoryInstrumentation.h:
      (WTF):
      * wtf/MemoryInstrumentationString.h: Removed.
      * wtf/text/AtomicString.cpp:
      (WTF::AtomicString::reportMemoryUsage):
      (WTF):
      * wtf/text/AtomicString.h:
      (AtomicString):
      * wtf/text/CString.h:
      (WTF::CStringBuffer::length):
      (CStringBuffer):
      (WTF::CStringBuffer::reportMemoryUsage):
      (CString):
      (WTF::CString::reportMemoryUsage):
      * wtf/text/StringImpl.cpp:
      (WTF::StringImpl::reportMemoryUsage):
      (WTF):
      * wtf/text/StringImpl.h:
      (StringImpl):
      * wtf/text/WTFString.cpp:
      (WTF::String::reportMemoryUsage):
      (WTF):
      * wtf/text/WTFString.h:
      (String):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130137 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7d05cdc
    • pfeldman@chromium.org's avatar
      Web Inspector: move runScript into the snippets model · 538f3941
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98122
      
      Reviewed by Vsevolod Vlasov.
      
      - Moves runScript into the SnippetsModel
      - Drive-by: annotates more RuntimeModel methods
      - common, sdk, ui, components, elements, network, resources, network,
        scripts, console, timeline, workers, tests
        modules now compile with no errors in dedicated compilation mode.
      
      * inspector/compile-front-end.py:
      * inspector/front-end/ConsoleView.js:
      * inspector/front-end/DatabaseQueryView.js:
      * inspector/front-end/RuntimeModel.js:
      (WebInspector.RuntimeModel.prototype.completionsForTextPrompt):
      * inspector/front-end/ScriptSnippetModel.js:
      (WebInspector.ScriptSnippetModel.prototype.evaluateScriptSnippet.compileCallback):
      (WebInspector.ScriptSnippetModel.prototype.evaluateScriptSnippet):
      (WebInspector.ScriptSnippetModel.prototype._runScript):
      * inspector/front-end/StylesSidebarPane.js:
      * inspector/front-end/TextPrompt.js:
      (WebInspector.TextPrompt.prototype.complete):
      * inspector/front-end/externs.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130136 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      538f3941