1. 13 Jul, 2002 2 commits
    • darin's avatar
      top level: · f6706a30
      darin authored
              * embed.am: Removed.
      
      Tools:
      
              * Scripts/embed-in-alex: Added. Replaces the rules in embed.am as
      	the way to make our frameworks embed themselves in Alex so we can
      	rebuild a framework and re-run Alex with the changes without building
      	Alex too.
      
              * Scripts/create-forwarding-header: Added. Mainly useful for the
      	one-time job of making forwarding headers for WebCore, but saving
      	for possible use in the future.
      
              * Scripts/commit-log-editor: Make Tools log show up after top level,
      	but before things like JavaScriptCore.
      
      JavaScriptCore:
      
              * Makefile.am: Don't use embed.am any more.
              * JavaScriptCore.pbproj/project.pbxproj: Use embed-into-alex instead
      	of make embed.
      
      WebFoundation:
      
              * Makefile.am: Remove include of embed.am.
      
              * WebFoundation.pbproj/project.pbxproj: Remove unneeded ApplicationServices
      	framework search path. Use embed-into-alex instead of make embed.
      
      WebCore:
      
              * ForwardingHeaders/*: Added. New approach to headers to try to
      	make Project Builder's header dependency support work even for
      	includes like #include <render/render_object.h>.
              * kwq/kjs/*: Removed. Now part of ForwardingHeaders.
      
              * Makefile.am: Remove embed.am support.
      
              * WebCore.pbproj/project.pbxproj: Remove other search paths, and
      	add ForwardingHeaders directory as a search path. Add qucomextra_p.h.
      
              * khtml/ecma/kjs_navigator.cpp: Made gratuitous changes to touch this
      	file to make things build without requiring clean rebuild.
      
              * khtml/rendering/render_form.cpp: Removed many unneeded QObject::
      	qualifiers from inside APPLE_CHANGES to touch this file to make things
      	build without requiring clean rebuild.
      
              * kwq/KWQButton.mm: (QButton::setText), (QButton::text):
              * kwq/KWQColor.mm: (QColor::setNamedColor):
      	* kwq/KWQKConfigBase.mm: (KConfig::readEntry):
              * kwq/KWQKHTMLSettings.mm: (KHTMLSettings::stdFontName), (KHTMLSettings::fixedFontName):
              (KHTMLSettings::serifFontName), (KHTMLSettings::sansSerifFontName),
      	(KHTMLSettings::cursiveFontName), (KHTMLSettings::fantasyFontName), (KHTMLSettings::encoding):
              * kwq/KWQKLocale.mm: (i18n):
              * kwq/KWQKMessageBox.mm: (KMessageBox::error), (KMessageBox::warningYesNo):
              (KMessageBox::questionYesNo), (KMessageBox::sorry):
              * kwq/KWQListBox.mm: (-[KWQBrowserDelegate browser:willDisplayCell:atRow:column:]):
              * kwq/WebCoreBridge.mm: (-[WebCoreBridge selectedText]):
              Wean from QSTRING_TO_NSSTRING and NSSTRING_TO_QSTRING.
      
              * kwq/KWQComboBox.mm:
              (QComboBox::insertItem): Wean from QSTRING_TO_NSSTRING. Note that this
      	now stores a copy of the string in the array. The old version was unsafe
      	if anyone later modified the QString that was passed in.
      
              * kwq/KWQFontMetrics.mm: (QFontMetrics::width):
              * kwq/KWQPainter.mm: (QPainter::drawUnderlineForText), (QPainter::drawText):
      	Wean from QSTRING_TO_NSSTRING_LENGTH and _FAST_QSTRING_TO_NSSTRING. We still have
      	speed as high as before, in the "length" case slightly faster.
      
              * kwq/qt/qstring.h: Remove QSTRING_TO_NSSTRING family of macros.
      
              * kwq/KWQInvisibleButton.mm:
              * kwq/KWQKHTMLPart.mm:
              * kwq/KWQKHTMLPartBrowserExtension.mm:
              * kwq/KWQKJavaAppletWidget.mm:
              * kwq/KWQKloader.mm:
              * kwq/KWQView.mm:
              * kwq/KWQsignals.mm:
              * kwq/WebCoreBridge.mm:
              * kwq/kdecore/kconfig.h:
              * kwq/kdecore/klibloader.h:
              * kwq/kdecore/klocale.h:
              * kwq/khtml/khtml_ext.h:
              * kwq/khtml/khtml_factory.h:
              * kwq/kio/kmimetype.h:
      	Remove subdirectory prefix from imports to match Project Builder include scheme.
      
              * kwq/KWQKCursor.mm: (+[NSCursor _WebCore_linkCursor]):
              * kwq/KWQKLocale.mm: (i18n):
              * kwq/KWQKstddirs.mm: (locate):
      	Use bundleForClass instead of bundleWithIdentifier to avoid any potential problems
      	with multiple versions of the framework installed on the same system.
      
              * kwq/KWQKLineEdit.mm:
              (KLineEdit::completionBox): Remove _logNotYetImplemented, since this is implemented
      	well enough for our needs now, and if we need to implement it later, it will become
      	clear from the application behavior. This should be the destiny of most of these.
      
              * kwq/kdecore/kglobal.h: Simplify.
              * kwq/KWQKGlobal.mm: Simplify.
              * kwq/qt/qlineedit.h: Simplify.
              * kwq/KWQLineEdit.mm: Simplify.
      
              * kwq/KWQPaintDeviceMetrics.mm: Remove unneeded import.
              * kwq/qt/qbutton.h: Remove unneeded destructor.
      
      WebKit:
      
              * History.subproj/IFURIEntry.m: (-[IFURIEntry image]):
      	Use [IFURIEntry class] instead of [self class] so we get the
      	icon from the WebKit bundle even if someone subclasses IFURIEntry.
              * Plugins.subproj/IFNullPluginView.mm:
              (-[IFNullPluginView initWithFrame:mimeType:arguments:]): Use
      	bundleForClass instead of bundleWithIdentifier so things work even
      	if we have two copies of WebKit installed on the same machine.
      
              * Makefile.am: Remove include of embed.am.
      
              * WebKit.pbproj/project.pbxproj: Use embed-into-alex instead of make embed.
      	Also change bundle identifier to com.apple.WebKit instead of com.apple.webkit
      	to match standard used by our other frameworks. (Checked that we no longer have
      	any hard-coding of the bundle identifier anywhere in our code.)
      
      WebBrowser:
      
              * WebBrowser.pbproj/project.pbxproj: Remove unneeded build phase.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1551 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6706a30
    • rjw's avatar
      Fixed 2981849 - frames don't always draw correctly. · 04ca9b2d
      rjw authored
              * WebCoreSupport.subproj/IFWebCoreBridge.mm:
              (-[IFWebCoreBridge childFrameNamed:]):
              Check provisional data source first.
      
              * WebView.subproj/IFHTMLViewPrivate.h:
              * WebView.subproj/IFHTMLViewPrivate.mm:
              (-[IFHTMLView _adjustFrames]):
              Added method to adjust frame geometry.
      
              * WebView.subproj/IFWebDataSourcePrivate.h:
              * WebView.subproj/IFWebDataSourcePrivate.mm:
              (-[IFWebDataSource _layoutChildren]):
              Added method to adjust child frame geometries.
      
              * WebView.subproj/IFWebFramePrivate.mm:
              (-[IFWebFrame _isLoadComplete]):
              Removed unnecessary drawing now that frame geometry is
              calculated directly.
      
              * kwq/KWQPainter.mm:
              Added disable drawing mode.
              (QPainter::drawRect):
              (QPainter::drawLine):
              (QPainter::drawEllipse):
              (QPainter::drawArc):
              (QPainter::drawLineSegments):
              (QPainter::drawPolyline):
              (QPainter::drawPolygon):
              (QPainter::drawConvexPolygon):
              (QPainter::drawPixmap):
              (QPainter::drawTiledPixmap):
              (QPainter::drawText):
              (QPainter::drawUnderlineForText):
              (QPainter::fillRect):
              (QPainter::setPaintingDisabled):
      
              * kwq/KWQWidget.mm:
              (QWidget::frameGeometry):
              Use the IFWebView's geometry.
      
              * kwq/WebCoreBridge.h:
              * kwq/WebCoreBridge.mm:
              (-[WebCoreBridge _drawRect:withPainter:]):
              (-[WebCoreBridge drawRect:]):
              (-[WebCoreBridge adjustFrames:]):
              Added adjustFrames:.  Factored some code.
      
              * kwq/qt/qpainter.h:
              Added setPaintingDisabled.
      
              * khtml/html/html_baseimpl.cpp:
              (HTMLFrameElementImpl::attach):
              (HTMLIFrameElementImpl::attach):
              Removed uniqueness check.  Need to revisit vis-a-vis provisional ds.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04ca9b2d
  2. 12 Jul, 2002 6 commits
    • darin's avatar
      JavaScriptCore: · a03e8f33
      darin authored
              * kjs/ustring.h: Since <sys/types.h> includes ushort and uint now, had
      	to change the includes here to be compatible with that.
      
      WebFoundation:
      
              * WebFoundation.pbproj/project.pbxproj: Remove unused build phase.
      
      WebCore:
      
              * WebCore.pbproj/project.pbxproj: Add WebCoreFrame.mm, also export all
      	the WebCore headers as Private so WebKit can see them.
      
              * khtml/khtmlview.cpp: (KHTMLView::drawContents): Remove APPLE_CHANGES
      	since we don't use this function any more.
      
              * kwq/KWQDef.h: Since <sys/types.h> now includes ushort and uint, update
      	code here to take that into account.
      
              * kwq/KWQKHTMLPartImpl.h: Added getView().
              * kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::getView): Added. Used by bridge.
      
              * kwq/qt/qpainter.h:
              * kwq/KWQPainter.mm: Simplify a bit, and remove some unused stuff.
      
              * kwq/WebCoreBridge.h: Add reapplyStyles, forceLayout, drawRect:.
              * kwq/WebCoreBridge.mm:
              (-[WebCoreBridge reapplyStyles]): Added.
              (-[WebCoreBridge forceLayout]): Added.
              (-[WebCoreBridge drawRect:]): Added.
      
              * kwq/WebCoreFrame.h: Make this a class as well as an interface.
              * kwq/WebCoreFrame.mm: Added.
      
              * WebCore.exp: Since WebCoreFrame is now a class as well as a protocol,
      	export it so we can subclass.
      
      WebKit:
      
      	About 1/3 of the remaining work to wean WebKit from its special relationship with WebCore
      	onto explicit interfaces.
      
              * Misc.subproj/IFCache.mm:
              * WebView.subproj/IFDOMNode.mm:
              * WebView.subproj/IFRenderNode.mm:
      	Mark imports from inside WebCore with #ifndef WEBKIT_INDEPENDENT_OF_WEBCORE.
      	Once these are all gone, the task is done.
      
              * Plugins.subproj/IFPlugin.h:
              * WebCoreSupport.subproj/IFCookieAdapter.h:
              * WebCoreSupport.subproj/IFImageRenderer.h:
              * WebCoreSupport.subproj/IFImageRendererFactory.h:
              * WebCoreSupport.subproj/IFResourceURLHandleClient.m:
              * WebCoreSupport.subproj/IFTextRenderer.h:
              * WebCoreSupport.subproj/IFTextRendererFactory.h:
              * WebCoreSupport.subproj/IFWebCoreBridge.h:
              * WebCoreSupport.subproj/IFWebCoreViewFactory.h:
      	Use #import <WebCore/> for getting at WebCore headers so we don't need to use -I.
      
              * WebCoreSupport.subproj/IFWebCoreBridge.mm:
              (-[IFWebCoreBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]):
      	Call setRenderPart on the WebCoreFrame rather than on the IFWebFrame.
      
              * WebCoreSupport.subproj/IFWebCoreFrame.h: Subclass from the WebCoreFrame class.
              * WebCoreSupport.subproj/IFWebCoreFrame.m:
              (-[IFWebCoreFrame HTMLView]): Add a cast.
              (-[IFWebCoreFrame widget]): Remove overzealous assert.
      
              * WebKit.pbproj/project.pbxproj: Rearranged things a bit. Removed unneeded build phase.
      
              * WebView.subproj/IFDocument.h:
              * WebView.subproj/IFDynamicScrollBarsView.h:
              * WebView.subproj/IFWebController.h:
              * WebView.subproj/IFWebControllerPolicyHandler.h:
      	Changed a few stray #include statements to #import statements.
      
              * WebView.subproj/IFHTMLView.mm:
              (-[IFHTMLView provisionalDataSourceCommitted:]): Move the logic for setting up the
      	renderPart in here from IFWebView.
              (-[IFHTMLView reapplyStyles]): Use the bridge.
              (-[IFHTMLView layout]): Use the bridge.
              (-[IFHTMLView drawRect:]): Use the bridge.
      
              * WebView.subproj/IFHTMLViewPrivate.h: Remove _takeOwnershipOfWidget which is no longer needed.
              * WebView.subproj/IFHTMLViewPrivate.mm:
              (-[NSView _IF_stopIfPluginView]): Added. Use to clean up _reset a bit.
              (-[IFHTMLView _reset]): Use makeObjectsPerformSelector: for simplicity.
      
              * WebView.subproj/IFImageView.h: Remove unneeded IFWebDataSource declaration.
              * WebView.subproj/IFImageView.m: Just formatting tweaks.
      
              * WebView.subproj/IFWebControllerPrivate.mm: Removed unneeded import.
              * WebView.subproj/IFWebDataSource.mm: Removed unneeded import.
              * WebView.subproj/IFWebDataSourcePrivate.mm: Removed unneeded import.
              * WebView.subproj/IFWebFrame.mm: Removed unneeded import.
      
              * WebView.subproj/IFWebFramePrivate.h: Remove renderPart field and related declarations.
              * WebView.subproj/IFWebFramePrivate.mm:
              (-[IFWebFramePrivate dealloc]): No need to let go of renderPart any more.
              (-[IFWebFrame _transitionProvisionalToCommitted]): Move logic into IFHTMLView.
      
              * WebView.subproj/IFWebView.h: Be a bit more specific about the type of documentView.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1549 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a03e8f33
    • cblu's avatar
      WebKit: · 35712009
      cblu authored
      	Only accept drags of 1 file.
      
              * WebView.subproj/IFWebView.mm:
              (-[IFWebView draggingEntered:]):
      
      WebBrowser:
      
      	Only accept drags of 1 file.
      
              * LocationFieldEditor.m:
              (-[LocationFieldEditor _dragOperationForDraggingInfo:]): added
              (-[LocationFieldEditor draggingEntered:]): returns _dragOperationForDraggingInfo
              (-[LocationFieldEditor draggingUpdated:]): returns _dragOperationForDraggingInfo
              (-[LocationFieldEditor concludeDragOperation:]): removed comment
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1548 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35712009
    • darin's avatar
      top level: · 2de85976
      darin authored
              * configure.in: Don't play games with RANLIB; we don't need that any more and it
      	just messes things up in the libiftest directory.
      
              * Tests/libiftest/Makefile.am: Remove all the explicit options and just let libiftest.a
      	be built as the default kind of library (static, I assume).
      
      WebKit:
      
      	Fix cancelling. My recent check-in broke it for downloads.
      
              * WebCoreSupport.subproj/IFResourceURLHandleClient.m:
              (-[IFResourceURLHandleClient receivedError:forHandle:]): Helper function to save code.
              (-[IFResourceURLHandleClient IFURLHandleResourceDidCancelLoading:]): Use an error for
      	cancel rather than -1,-1 progress.
      
              * WebView.subproj/IFMainURLHandleClient.mm:
              (-[IFMainURLHandleClient receivedProgressWithHandle:complete:]): Remove -1,-1 handling
      	here; instead we treat it as an error.
              (-[IFMainURLHandleClient receivedError:forHandle:]): Remove most of the parameters
      	since they are things we can compute ourselves.
              (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): Use an error for
      	cancel rather than -1,-1 progress.
      
              * WebView.subproj/IFWebControllerPrivate.mm:
              (-[IFWebController _receivedProgress:forResourceHandle:fromDataSource:complete:]):
      	Remove the -1,-1 cancel handling; we use an error instead.
              (-[IFWebController _mainReceivedProgress:forResourceHandle:fromDataSource:complete:]):
      	Remove the -1,-1 cancel handling; we use an error instead.
              (-[IFWebController _receivedError:forResourceHandle:partialProgress:fromDataSource:]):
      	Remove the _isStopping check. We want to do the additional work even if already stopping.
              (-[IFWebController _mainReceivedError:forResourceHandle:partialProgress:fromDataSource:]):
      	Remove the _isStopping check. We want to do the additional work even if already stopping.
      
              * WebView.subproj/IFWebView.mm: (-[IFWebView keyDown:]): Use NSDeleteCharacter.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1547 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2de85976
    • darin's avatar
      WebFoundation: · ec141631
      darin authored
              * Misc.subproj/IFNSDictionaryExtensions.h:
              * Misc.subproj/IFNSDictionaryExtensions.m:
              (-[NSDictionary _IF_objectForMIMEType:]): Added. Looks in the dictionary
      	first by the full MIME type, then by the part leading up to the "/".
      	Used in WebKit for the dictionaries for representation and view classes.
      
      WebKit:
      
              * WebView.subproj/IFWebDataSource.mm:
              (+[IFWebDataSource registerRepresentationClass:forMIMEType:]):
      	Use self instead of [self class].
              (+[IFWebDataSource createRepresentationForMIMEType:]):
      	Use the new _IF_objectForMIMEType to simplify and use hash table
      	instead of linear search.
              * WebView.subproj/IFWebDataSourcePrivate.mm:
              (+[IFWebDataSource _repTypes]): Use initWithObjectsAndKeys for
      	brevity and a tiny tiny bit of efficiency.
              (+[IFWebDataSource _canShowMIMEType:]):
      	Use the new _IF_objectForMIMEType to simplify and use hash table
      	instead of linear search.
              * WebView.subproj/IFWebView.mm:
              (+[IFWebView registerViewClass:forMIMEType:]):
      	Use self instead of [self class].
              (+[IFWebView createViewForMIMEType:]):
      	Use the new _IF_objectForMIMEType to simplify and use hash table
      	instead of linear search.
              * WebView.subproj/IFWebViewPrivate.mm:
              (+[IFWebView _canShowMIMEType:]):
      	Use the new _IF_objectForMIMEType to simplify and use hash table
      	instead of linear search.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1546 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec141631
    • darin's avatar
      * WebKit.pbproj/project.pbxproj: Re-added JavaScriptCore, which · 307a1847
      darin authored
      	I removed by accident.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1545 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      307a1847
    • darin's avatar
      top level: · 83f2d99c
      darin authored
      	Top level part of making WebCore build with Project Builder
      	instead of using automake.
      
              * Makefile.am: Remove rules for building .pfe files. Add new one-time-commands
      	and force-clean-timestamp features, so I don't have to send out instructions to
      	everyone about how to make things build.
              * configure.in: Remove options for using .pfe files. Remove Objective C++ support.
      	Also remove WebCore/khtml/dom, WebCore/khtml/xml, WebCore/khtml/rendering,
      	Test/khtmlview, Tools/wftool, and Tools/HotSpots, from the list of directories
      	where we need to make makefiles.
      
              * force-clean-timestamp: Added.
              * one-time-commands: Added.
      
              * .cvsignore: Don't ignore things we don't create. Do ignore the new
      	one-time-commands-timestamp and previous-clean-timestamp.
      
              * Tests/Makefile.am: Removed khtmlview.
              * Tests/khtmlview/*: Removed.
      
              * Tests/CookieManager/Makefile.am: Use objc-dummy.m, not objc-dummy.mm.
              * Tests/CookieManager/objc-dummy.m: Added.
              * Tests/CookieManager/objc-dummy.mm: Removed.
              * Tests/kde/Makefile.am: Use objc-dummy.m, not objc-dummy.mm.
              * Tests/kde/objc-dummy.m: Added.
              * Tests/kde/objc-dummy.mm: Removed.
              * Tests/qt/Makefile.am: Use objc-dummy.m, not objc-dummy.mm.
              * Tests/qt/objc-dummy.m: Added.
              * Tests/qt/objc-dummy.mm: Removed.
      
              * Updates/automake-1.5-mac-ported.diff: Removed, since we can use standard automake.
              * Updates/automake-1.5.tar.gz: Removed.
              * Updates/install-automake.sh: Removed.
              * Updates/update: Removed call to install-automake.sh.
      
              * Tests/WebFoundation-Misc/ifnsstringextensions-test.chk: Change result
      	to match new behavior of the _IF_domainMatches method.
      
              * Site/Internal/Design/IFRenamings.txt: Updated for recent changes.
      
      Tools:
      
              * Scripts/commit-log-editor: Always sort top level first.
      
              * Makefile.am: Take out the wftool subdir.
              * wftool/.cvsignore: Removed.
      
      WebCore:
      
      	Build WebCore with Project Builder instead of make.
      	Also wean WebCore from peeking inside the WebKit bundle.
      
              * WebCore.pbproj/.cvsignore: Added.
              * WebCore.pbproj/project.pbxproj: Added.
      
              * Makefile.am: Removed rules about building the framework,
      	and just use pbxbuild instead.
      
              * dummy.mm: Removed.
      
              * khtml/Makefile.am: Removed everything but SUBDIRS.
              * khtml/css/Makefile.am: Removed everything but the rules for
      	generated sources.
              * khtml/dom/Makefile.am: Removed.
              * khtml/ecma/Makefile.am: Removed everything but the rules for
      	generated sources.
              * khtml/html/Makefile.am: Removed everything but the rules for
      	generated sources.
              * khtml/misc/Makefile.am: Removed everything but the rules for
      	generated sources.
              * khtml/rendering/Makefile.am: Removed.
              * khtml/xml/Makefile.am: Removed.
              * kwq/Makefile.am: Removed everything but the rules for
      	generated sources.
      
              * kwq/KWQKLocale.mm: (i18n): Look in WebCore bundle, not WebKit bundle.
              * kwq/KWQKstddirs.mm:
              (locate): Look in WebCore bundle, not WebKit bundle. Also, always assume
      	we are looking for html4.css.
              (locateLocal): Don't waste code making a bad path, just return empty string.
      
              * kwq/qt/qpixmap.h:
              * kwq/KWQPixmap.mm: Changed convertToImage() to an inline since we
      	never need to implement it.
      
              * kwq/KWQKDebug.mm: Removed.
              * kwq/KWQKImageIO.mm: Removed.
              * kwq/kdecore/kcmdlineargs.h: Emptied out the file.
              * kwq/kdecore/kdebug.h: Made the do-nothing code here all be
      	inlines for smaller code size.
      
              * kwq/KWQScrollBar.h: Fixed header guard.
      
              * .cvsignore:
              * kwq/.cvsignore:
              * khtml/dom/.cvsignore: Removed.
              * khtml/rendering/.cvsignore: Removed.
              * khtml/xml/.cvsignore: Removed.
              * kwq/kdecore/.cvsignore: Removed.
              * kwq/qt/.cvsignore: Removed.
      	Don't ignore things we don't generate any more.
      
              * kwq/kjs/collector.h: Added.
              * kwq/kjs/internal.h: Added.
              * kwq/kjs/interpreter.h: Added.
              * kwq/kjs/lookup.h: Added.
              * kwq/kjs/object.h: Added.
      	Used so that khtml can see the headers from JavaScriptCore.
      
      WebKit:
      
              * WebKit.pbproj/project.pbxproj: Don't include the html4.css file
      	from WebCore any more. WebCore handles this on its own now. Also,
      	don't include the document templates; we don't use them any more.
      
              * Resources/image_document_template.html: Removed.
              * Resources/plugin_document_template.html: Removed.
              * Resources/text_document_template.html: Removed.
      
              * Makefile.am: Small tweak to the force-clean-timestamp logic.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83f2d99c
  3. 11 Jul, 2002 9 commits
    • darin's avatar
      * JavaScriptCore.pbproj/project.pbxproj: To make the build of · 0baf9840
      darin authored
      	WebCore work without using -I to peek at JavaScriptCore sources,
      	made all the Public sources Private so they are all in one directory.
      	Also, made lookup.h be Private.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1543 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0baf9840
    • cblu's avatar
      2986548 - Crash if you drop URL of frameset page onto frame · b32d1fc7
      cblu authored
              2953421 - document dragged into frame should replace frameset
      
              * WebView.subproj/IFWebView.mm:
              (-[IFWebView draggingEntered:]): removed obsolute comment
              (-[IFWebView performDragOperation:]): moved implementation from here
              (-[IFWebView concludeDragOperation:]): to here, added support for NSURL drags
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b32d1fc7
    • darin's avatar
      * WebView.subproj/IFWebViewPrivate.mm: · 5cb2aa6b
      darin authored
              (+[IFWebView _viewTypes]): Changed back to a mutable dictionary. Oops.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1541 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5cb2aa6b
    • sullivan's avatar
      WebKit: · 2805ee8b
      sullivan authored
      	- fixed 2980779 -- no scroll bar in history window
      
              * WebKit.pbproj/project.pbxproj: Removed nonexistent .h file from project list (IFGrabBag.h)
      
              * WebView.subproj/IFDynamicScrollBarsView.h: Renamed field allowsScrolling to disallowsScrolling
              * WebView.subproj/IFDynamicScrollBarsView.m:
              (-[IFDynamicScrollBarsView updateScrollers]):
              (-[IFDynamicScrollBarsView setAllowsScrolling:]):
              (-[IFDynamicScrollBarsView allowsScrolling]):
      	Removed initWithFrame override, whose only purpose was to set allowsScrolling to the "default"
      	value (but not good enough for load-from-nib case). Changed all users of allowsScrolling to
      	!disallowsScrolling instead.
      
      WebBrowser:
      
      	- made History menu show all history, not just most recent
      	- futzed around with some view positions
      	- fixed 2988910 -- Favorites bar does not show links until restart
      	- made Favorites bar do fewer unnecessary relayouts
      
              * BrowserWindow.m:
              (-[BrowserWindow toggleFavoritesBarWithAnimation:]):
              (-[BrowserWindow toggleStatusBarWithAnimation:]):
      	Tweaked some constants.
      
              * Defaults.plist: Changed default number of items in History menu
      	(now used only for flat part of menu) to 10.
      
              * English.lproj/Browser.nib: Pushed some pixels
      
              * English.lproj/MainMenu.nib: Changed "Show All History" to
      	"Show History in Window" since the menu now shows all history
      
              * FavoritesBar.h: Added _lastWidth and _buttonHeight ivars
              * FavoritesBar.m:
              (-[FavoritesBar _refreshButtons]): Use _buttonHeight ivar instead of
      	measuring height, since bar might be shrunken down into nothingness.
              (-[FavoritesBar _favoritesViewFrameChanged:]): Only lay out again if
      	width has changed
              (-[FavoritesBar initWithView:]): set _buttonHeight based on initial height
      
              * GlobalHistory.m:
              (-[GlobalHistory _insertItemsForDate:intoMenu:atIndex:withRunningTotal:limit:]):
      	add no-limit case
              (-[GlobalHistory _insertSubmenu:withTitle:atIndex:]): generalized slightly from
      	old _insertSubmenu:forDate:atIndex:
              (-[GlobalHistory _addHistoryToMenu]): add all history, but limit flat part of
      	menu; only add submenu for today if there are more today entries than fit in flat
      	part; don't add separator after today's entries if there are no submenus; use
      	_insertSubmenu:withTitle:atIndex: instead of _insertSubmenu:forDate:atIndex:
      
              * NSViewAdditions.h:
              * NSViewAdditions.m:
              (-[NSView retileAllScrollViews]):
      	New method to work around AppKit bug involving scroll bar placement.
      
              * WebBrowser.pbproj/project.pbxproj: The Preferences group had fallen inside
      	Search at some point in the past; rescued it.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1540 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2805ee8b
    • cblu's avatar
      * Plugins.subproj/IFPluginNullEventSender.h: · e0add2d3
      cblu authored
              * Plugins.subproj/IFPluginNullEventSender.m:
              (-[IFPluginNullEventSender initWithPluginView:]): renamed, simplified
              (-[IFPluginNullEventSender stop]): call plugin debug function
              * Plugins.subproj/IFPluginView.h:
              * Plugins.subproj/IFPluginView.mm:
              (-[IFPluginView start]): call new initWithPluginView
              (-[IFPluginView windowWillClose:]): added back to fix plugin view leak
              (-[IFPluginView NPP_HandleEvent]): added
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1539 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0add2d3
    • darin's avatar
      - fixed 2930872 -- option-arrow keys should page up and down · fa7c2bed
      darin authored
      	- fixed 2924727 -- Delete does not go to previous page
      
              * WebView.subproj/IFHTMLView.mm: Disable the keyDown and keyUp
      	methods here. We don't really need to pass these events to KHTMLView
      	at the moment. See the comment in this file for further explanation.
      	This paves the way to handle keys other than arrow keys in IFWebView.
      
              * WebView.subproj/IFWebController.h: Add temporary goBack method to
      	IFWindowContext. See comment for more.
      
              * WebView.subproj/IFWebView.mm: (-[IFWebView keyDown:]): Add handling
      	for option arrow keys, space (page down), shift-space (page up), and
      	delete (go back). Also make this call super if the key is not handled
      	so keys make their way back to the superview in the application.
      
              * WebView.subproj/IFWebViewPrivate.h: Add _pageLeft, _pageRight, _goBack.
              * WebView.subproj/IFWebViewPrivate.mm:
              (-[IFWebView _pageHorizontally:]): Added.
              (-[IFWebView _pageLeft]): Added.
              (-[IFWebView _pageRight]): Added.
              (+[IFWebView _viewTypes]): Simplify.
              (-[IFWebView _goBack]): Added. Calls [IFWindowContext goBack].
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1538 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa7c2bed
    • mjs's avatar
      Fixed Radar 2953254 - JavaScript window.scroll() and · 3d3b15fe
      mjs authored
      	window.scrollBy() do not work
      
      	* khtml/ecma/kjs_window.cpp:
              (WindowFunc::tryCall): Handle Scroll the same as ScrollBy.
              * kwq/KWQScrollView.mm:
              (QScrollView::scrollBy): Implement this method, since it's needed
      	for JS scrolling.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1536 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d3b15fe
    • darin's avatar
      - fixed 2973738 -- box characters · 69081845
      darin authored
      	To be consistent with other browsers, we need to draw nothing for 0000-001F.
      	We were drawing boxes.
      
              * WebCoreSupport.subproj/IFTextRenderer.m:
              (-[IFTextRenderer convertCharacters:length:toGlyphs:skipControlCharacters:]):
      	Add the skipControlCharacters parameter. If YES, don't include glyphs for characters
      	in the 0000-001F range.
              (-[IFTextRenderer slowPackGlyphsForCharacters:numCharacters:glyphBuffer:numGlyphs:]):
      	Pass skipControlCharacters:YES.
              (-[IFTextRenderer _drawCharacters:length:fromCharacterPosition:toCharacterPosition:atPoint:withTextColor:backgroundColor:]):
      	Skip control characters when creating the glyph array.
              (-[IFTextRenderer slowFloatWidthForCharacters:stringLength:fromCharacterPostion:numberOfCharacters:applyRounding:]):
      	Pass skipControlCharacters:YES.
              (-[IFTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:applyRounding:attemptFontSubstitution:]):
      	Skip control characters when computing the width.
              (-[IFTextRenderer extendCharacterToGlyphMapToInclude:]): Pass skipControlCharacters:NO.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69081845
    • darin's avatar
      - fixed 2978796 -- Client-side image map not working · 5eb153f4
      darin authored
              * kwq/KWQRegion.mm: (QRegion::QRegion): Implement constructor that
      	takes a QPointArray.
      
              * kwq/qt/qarray.h: Fix some const loopholes.
      
              * kwq/KWQCString.mm:
              (QCString::find): Use const char * instead of char *.
              (QCString::contains): Use const char * instead of char *.
              (QCString::right): Use const char * instead of char *.
              (QCString::mid): Use const char * instead of char *.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1534 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5eb153f4
  4. 10 Jul, 2002 13 commits
    • darin's avatar
      - fixed 2986273 -- assert currentURL isEqual:[handle redirectedURL] ? [handle... · fdbd1508
      darin authored
      	- fixed 2986273 -- assert currentURL isEqual:[handle redirectedURL] ? [handle redirectedURL] : [handle url]
      
      	Since cancel prevents further notification from getting through, currentURL can get
      	out of sync before cancelling, so we can't assert in the cancel function.
      
              * WebCoreSupport.subproj/IFResourceURLHandleClient.m:
              (-[IFResourceURLHandleClient IFURLHandleResourceDidCancelLoading:]): Remove assert.
      
              * WebView.subproj/IFMainURLHandleClient.h: Remove unnecessary includes. Change type
      	of dataSource to IFWebDataSource from id. Change url to currentURL to match
      	IFResourceURLHandleClient.
      
              * WebView.subproj/IFMainURLHandleClient.mm:
              (-[IFMainURLHandleClient initWithDataSource:]): Simplify.
              (-[IFMainURLHandleClient didStartLoadingWithURL:]): Copied here from IFResourceURLHandleClient
      	as a first step toward using a common superclass some day.
              (-[IFMainURLHandleClient didStopLoading]): Copied here from IFResourceURLHandleClient
      	as a first step toward using a common superclass some day.
              (-[IFMainURLHandleClient dealloc]): Add an assert.
              (-[IFMainURLHandleClient receivedProgressWithHandle:complete:]): Removed most of the parameters
      	to make this match the one in IFResourceURLHandleClient.
              (-[IFMainURLHandleClient IFURLHandleResourceDidBeginLoading:]): Use didStartLoadingWithURL.
              (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): Use receivedProgressWithHandle and
      	didStopLoading.
              (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): Use receivedProgressWithHandle and
      	didStopLoading.
              (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): Use receivedProgressWithHandle.
              (-[IFMainURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]): Use receivedProgressWithHandle and
      	didStopLoading.
              (-[IFMainURLHandleClient IFURLHandle:didRedirectToURL:]): Use didStopLoading and didStartLoadingWithURL.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fdbd1508
    • mjs's avatar
      WebCore: · aab0d7f3
      mjs authored
              WebCore part of fix for:
      
      	Radar 2953250 - JavaScript window.focus() and window.blur()
      	methods don't work
      
              * khtml/ecma/kjs_window.cpp:
              (WindowFunc::tryCall): Call the appropriate things on focus and blur.
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPartImpl::unfocusWindow): Implemented by calling bridge.
              * kwq/KWQKHTMLPartImpl.h, kwq/KWQWidget.mm:
      	(QWidget::setActiveWindow): Implemented by ordering the window
      	front and making it key.
              * kwq/WebCoreBridge.h: Prototype new bridge method.
      
      WebKit:
      
              WebKit part of fix for:
      
      	Radar 2953250 - JavaScript window.focus() and window.blur()
      	methods don't work
      
      	* WebCoreSupport.subproj/IFWebCoreBridge.mm:
              (-[IFWebCoreBridge unfocusWindow]): Use private AppKit interface
      	to cycle windows if the window is the key window.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1532 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aab0d7f3
    • darin's avatar
      - fixed 2979153 -- charset sjis page is gibberish · 5500a74c
      darin authored
              * kwq/character-sets.txt: Add x-sjis as an alias for Shift JIS.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1531 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5500a74c
    • darin's avatar
      - fixed 2983025 -- crash in sendEvent on pages with flash playing · f7bcc66f
      darin authored
              * Plugins.subproj/IFPluginView.mm:
              (-[IFPluginView removeTrackingRect]): New, removes tracking rect and releases window.
              (-[IFPluginView resetTrackingRect]): New, adds tracking rect and retains window.
              (-[IFPluginView start]): Use resetTrackingRect.
              (-[IFPluginView stop]): Use removeTrackingRect.
              (-[IFPluginView viewWillMoveToWindow:]): Call removeTrackingRect because the window
      	will change by the time we get to viewDidMoveToWindow.
              (-[IFPluginView viewDidMoveToWindow]): Call resetTrackingRect.
              (-[IFPluginView viewHasMoved:]): Call resetTrackingRect.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1530 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7bcc66f
    • darin's avatar
      * WebView.subproj/IFWebViewPrivate.mm: · a988b1d4
      darin authored
              (-[IFWebView _scrollToBottomLeft]): Fix this to use the document view to define what
      	the bottom left is, not the content view (which is often much smaller than the document).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1529 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a988b1d4
    • cblu's avatar
      WebKit: · 29dc171a
      cblu authored
      	Fixes for:
      	2981866 - Download doesn't appear in Downloads window if link was command-clicked
      	2965312 - Download progress not shown when clicking on download link with Alex not running
      
              * WebView.subproj/IFMainURLHandleClient.mm:
              (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): retain
      	the downloadProgressHandler before calling requestContentPolicy as the web controller may be released
      	in requestContentPolicy
      
      WebBrowser:
      
      	Fixes for:
              2981866 - Download doesn't appear in Downloads window if link was command-clicked
              2965312 - Download progress not shown when clicking on download link with Alex not running
      
              * BrowserDocument.m:
              (-[BrowserDocument _stopNonDownloadingDataSource:]): added
              (-[BrowserDocument close]): calls above
              * WebController.m:
              (-[BrowserWebController haveContentPolicy:andPath:forDataSource:]): moved super call to first line
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1528 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29dc171a
    • darin's avatar
      * kwq/KWQPixmap.mm: · 8a652810
      darin authored
              (QPixmap::QPixmap): Restore the imageRenderer == nil case to fix a regression
      	related to resized images. Otherwise, isNull was returning true for all images.
      	In copy constructor, set needCopyOnWrite on both the source and destination;
      	setting it on the destination was not enough.
              (QPixmap::receivedData): Create the imageRenderer if it's nil.
              (QPixmap::operator=): Set needCopyOnWrite on both the source and destination.
      
              * kwq/qt/qpixmap.h: Make needCopyOnWrite mutable so we can set it on the source
      	when copying or assigning.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1527 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a652810
    • cblu's avatar
      WebKit: · 9e5e0904
      cblu authored
              Fix for:
              2976311 - Download fails if you close the window that started the download
              2976308 - Can't navigate in window while download started in that window is in progress
      
              * WebView.subproj/IFMainURLHandleClient.h:
              * WebView.subproj/IFMainURLHandleClient.mm:
              (-[IFMainURLHandleClient dealloc]):
              (-[IFMainURLHandleClient _receivedProgress:forResourceHandle:fromDataSource:complete:]): added, sends progress to correct handler
              (-[IFMainURLHandleClient _receivedError:forResourceHandle:partialProgress:fromDataSource:]): added, sends progress to correct handler
              (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): calls _receivedProgress
              (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): calls _receivedProgress
              (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): calls _receivedProgress
              (-[IFMainURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]): calls _receivedError
              * WebView.subproj/IFWebController.h:
              * WebView.subproj/IFWebController.mm:
              (-[IFWebController setDownloadProgressHandler:]): added
              (-[IFWebController downloadProgressHandler]): added
              * WebView.subproj/IFWebControllerPrivate.h:
              * WebView.subproj/IFWebControllerPrivate.mm:
              (-[IFWebController _mainReceivedProgress:forResourceHandle:fromDataSource:complete:]): removed download special-casing
      
      WebBrowser:
      
              Fix for:
              2976311 - Download fails if you close the window that started the download
              2976308 - Can't navigate in window while download started in that window is in progress
      
              * BrowserDocument.m:
              (-[BrowserDocument init]): set the downloadProgressHandler to the download monitor
              (-[BrowserDocument close]): set the downloadProgressHandler to nil
              * DownloadMonitor.h:
              * DownloadMonitor.m:
              (-[DownloadMonitor _monitorDownload:withProgress:error:dataSource:complete:]): renamed, made private
              (-[DownloadMonitor receivedProgress:forResourceHandle:fromDataSource:complete:]): added, calls _monitorDownload
              (-[DownloadMonitor receivedError:forResourceHandle:partialProgress:fromDataSource:]): added, calls _monitorDownload
              * WebController.m:
              (-[BrowserWebController receivedProgress:forResourceHandle:fromDataSource:complete:]): removed download special-casing
              (-[BrowserWebController receivedError:forResourceHandle:partialProgress:fromDataSource:]): removed download special-casing
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1526 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e5e0904
    • darin's avatar
      Fix the underlying cause of a deadlock problem that I saw. It's important that IFURLHandle · 2a119826
      darin authored
      	drops its references to the handle clients on the thread that it's using for client notification
      	rather than the thread it happens to be deallocated on.
      
      	Also fix things so that the notifications can be sent without holding the lock the whole time,
      	by making a copy of the client array and any parameters, and fix one small problem related to this.
      
      	Use makeObjectsPerformSelector in a lot more places, and do a few other cleanups.
      
              * CacheLoader.subproj/IFURLHandle.m:
              (-[IFURLHandleSynchronousClient initWithHandle:monitor:]): Remove unneeded [self release] in the
      	case where self is nil.
              (-[IFURLHandle _didRedirectToURL:]): Lock around changes to the redirectedURL so we don't access
      	the object from the callback thread when it's invalid.
              (-[IFURLHandle _notifyClientsDidBeginLoading]): Do notifications outside the lock.
              (-[IFURLHandle _notifyClientsDidCancelLoading]): Do notifications outside the lock. Also empty
      	out the clients array because we are at an end state. It's important to empty it out here from
      	the thread we are calling back on rather than from dealloc on whatever thread that is called on.
              (-[IFURLHandle _notifyClientsDataDidBecomeAvailable]): Do notifications outside the lock.
              (-[IFURLHandle _notifyClientsDidFinishLoading]): Do notifications outside the lock. Also empty
      	out the clients array because we are at an end state. It's important to empty it out here from
      	the thread we are calling back on rather than from dealloc on whatever thread that is called on.
              (-[IFURLHandle _notifyClientsDidFailLoading]): Do notifications outside the lock. Also empty
      	out the clients array because we are at an end state. It's important to empty it out here from
      	the thread we are calling back on rather than from dealloc on whatever thread that is called on.
              (-[IFURLHandle _notifyClientsDidRedirectToURL]): Do notifications outside the lock.
      
              * AuthenticationManager.subproj/IFAuthenticationManager.m:
              (-[IFAuthenticationManager _retryWaitingRequests]): Remove unnecessary copy/autorelease since
      	we are the sole owner of the waitingRequests array.
      
              * CacheLoader.subproj/IFHTTPURLProtocolHandler.m:
              (-[IFHTTPURLProtocolHandler setRedirectedURL:]): Use makeObjectsPerformSelector for simplicity.
      	Also remove the exception handler since the handles accessor now does a copy/autorelease.
              (-[IFHTTPURLProtocolHandler setResponseHeaders:]): Use makeObjectsPerformSelector for simplicity.
      	Also remove the exception handler since the handles accessor now does a copy/autorelease.
      
              * CacheLoader.subproj/IFURLLoad.m:
              (-[IFURLLoad handles]): Return a copied auto-released version.
              (-[IFURLLoad updateHandles]): Use makeObjectsPerformSelector for simplicity.
      
              * Database.subproj/IFURLFileDatabase.m:
              (-[IFURLFileDatabase sync]): Remove unnecessary checks for nil and empty array in cases that
      	the nil behavior of Objective C already takes care of. Use makeObjectsPerformSelector for simplicity.
      
              * Misc.subproj/IFFileTypeMappings.m:
              (-[IFFileTypeMappingsPrivate init]): Create a reverse mapping dictionary too, so we can map in both
      	directions quickly. Also fix a storage leak in the failure case.
              (-[IFFileTypeMappings _init]): Fix a storage leak in the failure case.
              (-[IFFileTypeMappings MIMETypeForExtension:]): Use the new reverse dictionary.
      
              * Misc.subproj/IFNSArrayExtensions.h: Add _IF_makeObjectsPerformSelector:withObject:withObject:.
              * Misc.subproj/IFNSArrayExtensions.m: Fix name in comment for the benefit of the renamings script.
              (-[NSArray _IF_makeObjectsPerformSelector:withObject:withObject:]): Added. Stole the algorithm
      	from NSArray.m.
      
              * Misc.subproj/IFNSObjectExtensions.m: Fix name in comment for the benefit of the renamings script.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a119826
    • mjs's avatar
      * WebView.subproj/IFGrabBag.h: Removed. · 69f1f9a7
      mjs authored
              * WebView.subproj/IFWebController.h: Move IFContextMenuHandler
      	here.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1524 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69f1f9a7
    • darin's avatar
      Did some tweaks that weren't really necessary. But at least one is a significant · 0db748f8
      darin authored
      	improvement so I decided to commit rather then just discarding the changes.
      
              * Bookmarks.subproj/IFBookmark.m:
              (-[IFBookmark title]): Take out special case for separator.
              (-[IFBookmark setTitle:]): Take out special case for separator.
              (-[IFBookmark image]): Take out special case for separator.
              (-[IFBookmark setImage:]): Take out special case for separator.
              (-[IFBookmark setURLString:]): Take out special case for non-leaf.
              (-[IFBookmark children]): Take out request for concrete implementation;
      	this is not useful since it's specific to one subclass.
              (-[IFBookmark numberOfChildren]): Take out request for concrete implementation;
      	this is not useful since it's specific to one subclass.
              (-[IFBookmark _numberOfDescendants]): Take out request for concrete implementation;
      	this is not useful since it's specific to one subclass.
              (-[IFBookmark insertChild:atIndex:]): Take out special case for non-list.
              (-[IFBookmark removeChild:]): Take out special case for non-list.
              (+[IFBookmark bookmarkFromDictionaryRepresentation:withGroup:]): Refactored to
      	eliminate repeated code.
      
              * Bookmarks.subproj/IFBookmarkLeaf.m:
              (-[IFBookmarkLeaf copyWithZone:]): Use allocWithZone to be more pedantically correct.
      
              * Bookmarks.subproj/IFBookmarkSeparator.m:
              (-[IFBookmarkSeparator title]): Override to return nil.
              (-[IFBookmarkSeparator image]): Override to return nil.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1523 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0db748f8
    • darin's avatar
      * kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::setBaseURL): · 556bdb32
      darin authored
      	Call setBaseURL on the underlying document all the time, not just
      	when we add a missing "/" character.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1522 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      556bdb32
    • darin's avatar
      * Misc.subproj/WebKitDebug.m: Remove workaround for long-ago fixed · a3fabdae
      darin authored
      	C compiler bug.
      
              * Plugins.subproj/IFPluginView.mm:
              (-[IFPluginView keyUp:]), (-[IFPluginView keyDown:]): Simplify keyboard
      	scrolling code by passing along all events that the plug-in doesn't handle
      	rather than special-casing certain events. Also use super rather than
      	nextResponder to pass along the scroll events (super will do nextResponder).
      
              * WebView.subproj/IFHTMLView.mm:
              (-[IFHTMLView keyDown:]), (-[IFHTMLView keyUp:]): Use super rather than
      	nextResponder to pass along scroll events (super will do nextResponder).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1521 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3fabdae
  5. 08 Jul, 2002 2 commits
    • cblu's avatar
      WebKit: · ca8e252b
      cblu authored
              Fixes for:
              2955757 - Keyboard scrolling code needs to move to WebKit
              2937231 - Left and right arrows should scroll the content area
      
              * Misc.subproj/IFNSEventExtras.h: Added.
              * Misc.subproj/IFNSEventExtras.m: Added.
              (-[NSEvent _IF_isScrollEvent]): new
              * Plugins.subproj/IFPluginView.mm:
              (-[IFPluginView keyUp:]): if plug-in doesn't accept it, send to nextResponder
              (-[IFPluginView keyDown:]): if plug-in doesn't accept it, send to nextResponder
              * WebKit.pbproj/project.pbxproj:
              * WebView.subproj/IFHTMLView.mm:
              (-[IFHTMLView keyDown:]): calls _IF_isScrollEvent, if so send to nextResponder
              (-[IFHTMLView keyUp:]): calls _IF_isScrollEvent, if so send to nextResponder
              * WebView.subproj/IFWebView.mm:
              (-[IFWebView acceptsFirstResponder]): added
              (-[IFWebView window]): no changes
              (-[IFWebView keyDown:]): added, does the scroll
              * WebView.subproj/IFWebViewPrivate.h:
              * WebView.subproj/IFWebViewPrivate.mm:
              (-[IFWebView _contentView]): added
              (-[IFWebView _scrollVerticallyBy:]): added, moved from BrowserWindow.m
              (-[IFWebView _scrollHorizontallyBy:]): added, moved from BrowserWindow.m
              (-[IFWebView _pageVertically:]): added, moved from BrowserWindow.m
              (-[IFWebView _scrollLineVertically:]): added, moved from BrowserWindow.m
              (-[IFWebView _scrollLineHorizontally:]): added, moved from BrowserWindow.m
              (-[IFWebView _pageDown]): added, moved from BrowserWindow.m
              (-[IFWebView _pageUp]): added, moved from BrowserWindow.m
              (-[IFWebView _scrollToTopLeft]): added, moved from BrowserWindow.m
              (-[IFWebView _scrollToBottomLeft]): added, moved from BrowserWindow.m
              (-[IFWebView _lineDown]): added, moved from BrowserWindow.m
              (-[IFWebView _lineUp]): added, moved from BrowserWindow.m
              (-[IFWebView _lineLeft]): added, moved from BrowserWindow.m
              (-[IFWebView _lineRight]): added, moved from BrowserWindow.m
      
      WebBrowser:
      
              Fixes for:
              2955757 - Keyboard scrolling code needs to move to WebKit
              2937231 - Left and right arrows should scroll the content area
      
              * BrowserWindow.m:
              (-[BrowserWindow windowDidLoad]): no changes
              (-[BrowserWindow windowWillHandleKeyEvent:]): causes scroll in _largestNonFramesetWebView
              (-[BrowserWindow mouseDownInRightSearchButton:]): no changes
              (-[IFWebView _area]): added
              (-[IFWebView _largestNonFramesetWebView]): added
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1520 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca8e252b
    • darin's avatar
      * WebCoreSupport.subproj/IFWebCoreBridge.mm: Fix compiles under newer compiler · c2becbea
      darin authored
      	(Jaguar 6C89 and newer) by adding missing include.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1519 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2becbea
  6. 07 Jul, 2002 1 commit
    • mjs's avatar
      WebCore: · d0eeedac
      mjs authored
              WebCore part of fix for Radar 2953431 - JavaScript window.close()
      	method is not working
      
              * khtml/ecma/kjs_window.cpp:
              (Window::scheduleClose): In AppleChanges
              * khtml/khtml_part.cpp:
              (KHTMLPart::openedByJS): Call kwq implementations, because we need
      	to remember the openedByJS state across location changes, which in
      	our case means replacing the part.
              (KHTMLPart::setOpenedByJS): Likewise.
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPartImpl::openedByJS): Implement by calling bridge.
              (KWQKHTMLPartImpl::setOpenedByJS): Likewise.
              (KWQKHTMLPartImpl::close): Likewise.
              * kwq/KWQKHTMLPartImpl.h: Prototype new PartImpl methods.
              * kwq/WebCoreBridge.h: Prototype new bridge methods.
      
      WebKit:
      
              WebCore part of fix for Radar 2953431 - JavaScript window.close()
      	method is not working
      
      	* WebCoreSupport.subproj/IFWebCoreBridge.mm:
              (-[IFWebCoreBridge openedByScript]): Implement by calling controller.
              (-[IFWebCoreBridge setOpenedByScript:]): Likewise.
              * WebView.subproj/IFWebControllerPrivate.h:
              * WebView.subproj/IFWebControllerPrivate.mm:
              (-[IFWebController _openedByScript]): Implement.
              (-[IFWebController _setOpenedByScript:]): Implement.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1518 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0eeedac
  7. 06 Jul, 2002 1 commit
  8. 05 Jul, 2002 1 commit
    • darin's avatar
      Fix crashes I saw with zombies enabled caused by messing with windows that are · c74ff015
      darin authored
      	in the process of being destroyed.
      
              * Plugins.subproj/IFPluginView.mm:
              (-[IFPluginView start]): Remove windowWillClose notification because
      	we use viewDidMoveToWindow instead.
              (-[IFPluginView viewDidMoveToWindow]): Use this instead of viewWillMoveToWindow.
              * WebView.subproj/IFHTMLView.mm:
              (-[IFHTMLView viewDidMoveToWindow]): Use this instead of viewWillMoveToWindow.
              * WebView.subproj/IFHTMLViewPrivate.h: Need a boolean flag to tell window changes
      	before the first time we are installed from window changes afterward.
              * WebView.subproj/IFImageView.m:
              (-[IFImageView viewDidMoveToWindow]): Use this instead of viewWillMoveToWindow.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1516 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c74ff015
  9. 04 Jul, 2002 3 commits
    • mjs's avatar
      Say "Go to" instead of "Link to" for links that won't open a new · e92733b8
      mjs authored
      	window. Also, the code is now set up to change the status text
      	when modifier keys are pressed, but the code is disabled for now
      	because it's impossible to do reliably.
      
              * khtml/khtml_part.cpp:
              (KHTMLPart::overURL):
              (KHTMLPart::khtmlMouseMoveEvent):
              * khtml/khtml_part.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e92733b8
    • mjs's avatar
      * WebView.subproj/IFHTMLView.mm: · 35f088ac
      mjs authored
              (-[IFHTMLView mouseMovedNotification:]): Pass the modifier flags
      	along for mouse move events.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1514 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35f088ac
    • sullivan's avatar
      WebKit: · a381c99f
      sullivan authored
              * WebView.subproj/IFDynamicScrollBarsView.h:
      	Updated FIXME to mention bug number.
      
      WebBrowser:
      
      	- finished a few details for 2953570 and 2953580 -- Open and
      	Reveal in Downloads window don't handle	missing-file case well
      	- fixed 2981774 -- Status bar text not centered vertically
      	- removed vestiges of ancient mechanism for swapping browser
      	window view between webview & search modes
      
              * English.lproj/Browser.nib: Made the status bar a few pixels shorter.
      	We may decide that it looks bad for it to be a different height than the
      	favorites bar, but Don wanted to try this. Also made IFWebView a direct
      	subview of the window's contentView, and eliminated the extra views that
      	were part of the ancient web/search mode mechanism.
      
              * BrowserWindow.h: Removed tabView outlet.
      
              * BrowserWindow.m:
              (-[BrowserWindow toggleFavoritesBarWithAnimation:]):
              (-[BrowserWindow toggleStatusBarWithAnimation:]):
      	Made these methods use webView instead of tabView.
      
              * DownloadMonitor.m:
              (-[DownloadMonitor _canOpenSelectedDownloads]):
              (-[DownloadMonitor _canStopSelectedDownloads]):
              (-[DownloadMonitor _canRevealSelectedDownloads]):
              (-[DownloadMonitor _canForgetSelectedDownloads]):
      	Renamed these from "_totalSelectedAndXXXXable" and made them return BOOLs rather
      	than ints, since that's all the callers cared about. Made them (except _canReveal)
      	return as soon as a single valid entry is found (_canReveal has to make sure there
      	is exactly one valid entry). Made _canOpen and _canReveal return YES even if file
      	doesn't exist, so that the user will get the explanatory message if they click on
      	Open or Reveal in this case.
      
              (-[DownloadMonitor validateUserInterfaceItem:]):
      	Updated for method name and return-value changes; restructured so that it returns
      	as soon as the right selector is checked, rather than continuing to check against
      	other selectors.
      
      	(-[DownloadMonitor _showMissingFileErrorForOperation:andFile:]): Removed this
      	method; it was constructing messages using substitution patterns that might
      	not work in other languages.
      
              (-[DownloadMonitor openSelectedDownloads:]):
      	Made the error message handle the multiple-missing-files case properly; let
      	all openable items be opened regardless of how many unopenable items there are
      	(formerly bailed at the first unopenable item). Moved sheet-displaying code
      	for this case into here.
      
              (-[DownloadMonitor revealSelectedDownloads:]): Moved sheet-displaying code
      	for this case into here.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a381c99f
  10. 03 Jul, 2002 2 commits
    • cblu's avatar
      - Fix for 2975750 · f2327cc0
      cblu authored
      	- Removed Java workaround since that will be fixed soon.
      
              * Plugins.subproj/IFPlugin.h:
              * Plugins.subproj/IFPlugin.m:
              (-[IFPlugin _openResourceFile]): added
              (-[IFPlugin _closeResourceFile:]): added
              (-[IFPlugin _getPluginInfo]): rename
              (-[IFPlugin initWithPath:]): simplified
              (-[IFPlugin load]): calls _openResourceFile
              (-[IFPlugin unload]): calls _closeResourceFile
              * Plugins.subproj/IFPluginView.mm:
              (-[IFPluginView setUpWindowAndPort]): removed Java workaround
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2327cc0
    • darin's avatar
      top level: · 7f5da716
      darin authored
              * Site/Internal/Design/IFRenamings.txt:
      	Update a bit more, preparing for the team to review.
      
      WebKit:
      
              * Misc.subproj/IFException.h: Use Objective C header style rather than plain C.
      
      WebBrowser:
      
              * NSViewAdditions.h:
              * NSViewAdditions.m:
      	Change name of this category to match the file name to smooth things over for the
      	IF -> Web renaming.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f5da716