1. 10 Dec, 2010 4 commits
    • eric@webkit.org's avatar
      2010-12-10 Eric Seidel <eric@webkit.org> · f62e5b70
      eric@webkit.org authored
              Unreviewed.  Somehow this last-minute edit didn't quite get committed.
      
              The commit-queue should file bugs about flaky tests it encounters
              https://bugs.webkit.org/show_bug.cgi?id=50803
      
              * Scripts/webkitpy/tool/bot/flakytestreporter.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f62e5b70
    • eric@webkit.org's avatar
      2010-12-09 Eric Seidel <eric@webkit.org> · 6387ef6c
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              The commit-queue should file bugs about flaky tests it encounters
              https://bugs.webkit.org/show_bug.cgi?id=50803
      
              This change got a bit big.  I also added a new config.urls file
              because I needed to share the view_source_url code with committervalidator.py.
      
              This adds a new class FlakyTestReporter which holds all the logic about
              reporting flaky tests to bugzilla.
      
              Right now this code knows how to look up bugs for flaky tests.
              If it can't find a bug filed from the commit-queue, it will open a new
              one, ccing the relevant people and adding information about the failure.
      
              It is not yet smart enough to chase down duplicate chains, or to include
              the actual failure diff.  But those can be added in later iterations.
      
              * Scripts/webkitpy/common/checkout/api.py:
              * Scripts/webkitpy/common/checkout/changelog.py:
              * Scripts/webkitpy/common/checkout/commitinfo.py:
              * Scripts/webkitpy/common/config/committervalidator.py:
              * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
              * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
              * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
              * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
              * Scripts/webkitpy/tool/bot/irc_command.py:
              * Scripts/webkitpy/tool/bot/sheriff.py:
              * Scripts/webkitpy/tool/commands/download.py:
              * Scripts/webkitpy/tool/commands/queues.py:
              * Scripts/webkitpy/tool/commands/queues_unittest.py:
              * Scripts/webkitpy/tool/comments.py:
              * Scripts/webkitpy/tool/mocktool.py:
              * Scripts/webkitpy/tool/steps/commit.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6387ef6c
    • rniwa@webkit.org's avatar
      2010-12-09 Ryosuke Niwa <rniwa@webkit.org> · b69181d8
      rniwa@webkit.org authored
              Reviewed by Ojan Vafai.
      
              Make DOM Mutation Events Asynchronous
              https://bugs.webkit.org/show_bug.cgi?id=46936
      
              Implemented DOM mutations events as scoped events. A scoped event is an event whose
              dispatch is done via ScopedEventQueue. The behavior of the queue is controlled by
              EventQueueScope objects (RAII idiom), which increments and decrements the scoping level
              on its constructor and destructor respectively.
      
              When the scoping level is 0 (initial level), scoped events are dispatched as soon as
              they are enqueued and act like synchronous events. When the scoping level is greater than 0,
              however, events are queued in ScopedEventQueue and their dispatches are delayed until
              the scoping level goes back to 0 (by the destruction of EventQueueScope).
      
              DOMSubtreeModified, DOMNodeInserted, DOMNodeRemoved, DOMNodeRemovedFromDocument,
              DOMNodeInsertedIntoDocument, DOMFocusIn, DOMFocusOut, focusin, and focusout are treated as
              scoped events, and a scope object is instantiated in EditCommand::apply to delay dispatches
              of the events until the completion of each call of EditCommand::doApply.
      
              Test: fast/events/mutation/execCommands.html
      
              * Android.mk: Added ScopedEventQueue.cpp.
              * CMakeLists.txt: Ditto.
              * WebCore.pro: Ditto.
              * GNUmakefile.am: Added ScopedEventQueue.cpp and ScopedEventQueue.h.
              * WebCore.gypi:  Ditto.
              * WebCore.vcproj/project.vcproj: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * dom/ContainerNode.cpp:
              (WebCore::dispatchChildInsertionEvents): Calls dispatchScopedEvent.
              (WebCore::dispatchChildRemovalEvents): Ditto.
              * dom/DOMAllInOne.cpp: Added ScopedEventQueue.cpp.
              * dom/Element.cpp:
              (WebCore::Element::dispatchAttrRemovalEvent): Ditto. 
              (WebCore::Element::dispatchAttrAdditionEvent): Ditto.
              * dom/Node.cpp:
              (WebCore::Node::dispatchScopedEvent): Added.
              (WebCore::Node::dispatchSubtreeModifiedEvent): Calls dispatchScopedEvent.
              * dom/Node.h:
              * dom/ScopedEventQueue.cpp: Added.
              (WebCore::ScopedEventQueue::initialize): Added.
              (WebCore::ScopedEventQueue::enqueueEvent): Added.
              (WebCore::ScopedEventQueue::dispatchAllEvents): Added.
              (WebCore::ScopedEventQueue::dispatchEvent): Added.
              (WebCore::ScopedEventQueue::instance): Added.
              (WebCore::ScopedEventQueue::incrementScopingLevel): Added.
              (WebCore::ScopedEventQueue::decrementScopingLevel): Added.
              * dom/ScopedEventQueue.h: Added.
              (WebCore::ScopedEventQueue::~ScopedEventQueue): Added.
              (WebCore::ScopedEventQueue::ScopedEventQueue): Added.
              (WebCore::EventQueueScope::EventQueueScope): Added.
              (WebCore::EventQueueScope::~EventQueueScope): Added.
              * editing/EditCommand.cpp:
              (WebCore::EditCommand::apply): Instantiates EventQueueScope.
      2010-12-09  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Ojan Vafai.
      
              Make DOM Mutation Events Asynchronous
              https://bugs.webkit.org/show_bug.cgi?id=46936
      
              Added a test to ensure no DOM mutation events are fired while execCommand is in progress.
      
              * fast/events/crash-on-mutate-during-drop.html: DOMNodeInserted is fired after BR is detached
              from the document, and can't be observed. Modify the DOM when text node is inserted.
              * fast/events/scoped: Added.
              * fast/events/scoped/editing-commands-expected.txt: Added.
              * fast/events/scoped/editing-commands.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b69181d8
    • rniwa@webkit.org's avatar
      2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com> · 1a796035
      rniwa@webkit.org authored
              Unreviewed, rolling out r73684.
              http://trac.webkit.org/changeset/73684
              https://bugs.webkit.org/show_bug.cgi?id=50801
      
              "missing bug number" (Requested by rniwa on #webkit).
      
              * Android.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * dom/ContainerNode.cpp:
              (WebCore::dispatchChildInsertionEvents):
              (WebCore::dispatchChildRemovalEvents):
              * dom/DOMAllInOne.cpp:
              * dom/Element.cpp:
              (WebCore::Element::dispatchAttrRemovalEvent):
              (WebCore::Element::dispatchAttrAdditionEvent):
              * dom/Node.cpp:
              (WebCore::Node::dispatchSubtreeModifiedEvent):
              (WebCore::Node::dispatchUIEvent):
              * dom/Node.h:
              * dom/ScopedEventQueue.cpp: Removed.
              * dom/ScopedEventQueue.h: Removed.
              * editing/EditCommand.cpp:
              (WebCore::EditCommand::apply):
      2010-12-09  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r73684.
              http://trac.webkit.org/changeset/73684
              https://bugs.webkit.org/show_bug.cgi?id=50801
      
              "missing bug number" (Requested by rniwa on #webkit).
      
              * fast/events/crash-on-mutate-during-drop.html:
              * fast/events/scoped/editing-commands-expected.txt: Removed.
              * fast/events/scoped/editing-commands.html: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a796035
  2. 09 Dec, 2010 36 commits
    • eric@webkit.org's avatar
      2010-12-09 Eric Seidel <eric@webkit.org> · f1eeac35
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Teach webkit-patch how to search bugzilla
              https://bugs.webkit.org/show_bug.cgi?id=50500
      
              This is a step towards teaching webkitpy how to file
              new bugs for flaky tests and update them when new flakes occur.
      
              * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
              * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
              * Scripts/webkitpy/tool/commands/__init__.py:
              * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1eeac35
    • commit-queue@webkit.org's avatar
      2010-12-09 Qi Zhang <qi.2.zhang@nokia.com> · e9f5304a
      commit-queue@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] enable orientation flag when QtMobility available
              https://bugs.webkit.org/show_bug.cgi?id=50781
      
              When QtMobility available, enable orientation flag by default.
      
              * features.pri:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9f5304a
    • commit-queue@webkit.org's avatar
      2010-12-09 Kenichi Ishibashi <bashi@google.com> · 28363974
      commit-queue@webkit.org authored
              Reviewed by Kent Tamura.
      
              Improve validation API support of <object> and <keygen>
              https://bugs.webkit.org/show_bug.cgi?id=50663
      
              Adds tests for validation API for <object>.
              Tests for <output> and <keygen> are also added.
      
              * fast/dom/plugin-attributes-enumeration-expected.txt: Updated.
              * fast/forms/ValidityState-001-expected.txt: Updated.
              * fast/forms/ValidityState-001.html: Updated.
              * fast/forms/checkValidity-001-expected.txt: Updated.
              * fast/forms/checkValidity-001.html: Updated.
              * fast/forms/script-tests/setCustomValidity-existence.js: Added.
              * fast/forms/script-tests/validationMessage.js: Updated.
              * fast/forms/script-tests/willvalidate.js: Updated.
              * fast/forms/setCustomValidity-existence-expected.txt: Added.
              * fast/forms/setCustomValidity-existence.html: Added.
              * fast/forms/validationMessage-expected.txt: Updated.
              * fast/forms/willvalidate-expected.txt: Updated.
      2010-12-09  Kenichi Ishibashi  <bashi@google.com>
      
              Reviewed by Kent Tamura.
      
              Improve validation API support of <object> and <keygen>
              https://bugs.webkit.org/show_bug.cgi?id=50663
      
              Adds validation API to HTMLObjectElement class.
              Makes HTMLKeygenElement::willValidate() return false.
      
              Test: fast/forms/setCustomValidity-existence.html
      
              * html/HTMLKeygenElement.h:
              (WebCore::HTMLKeygenElement::willValidate): Added.
              * html/HTMLObjectElement.h:
              (WebCore::HTMLObjectElement::validationMessage): Added.
              (WebCore::HTMLObjectElement::checkValidity): Added.
              (WebCore::HTMLObjectElement::setCustomValidity): Added.
              * html/HTMLObjectElement.idl: Added validation API properties.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73686 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28363974
    • commit-queue@webkit.org's avatar
      2010-12-09 Sadrul Habib Chowdhury <sadrul@chromium.org> · 0c77be31
      commit-queue@webkit.org authored
              Reviewed by Kent Tamura.
      
              Make sure a non-zero value is used for tile-width to avoid a crash
              https://bugs.webkit.org/show_bug.cgi?id=50341
      
              The scaled tile width can be very small at times (e.g. with 'style: font 1
              required'). So use a minimum width of 1 instead of using 0 (which leads to a
              crash).
      
              * fast/dom/HTMLProgressElement/progress-element-with-style-crash.html: Added.
              * fast/dom/HTMLProgressElement/progress-element-with-style-crash-expected.txt: Added.
      2010-12-09  Sadrul Habib Chowdhury  <sadrul@chromium.org>
      
              Reviewed by Kent Tamura.
      
              Make sure a non-zero value is used for tile-width to avoid a crash
              https://bugs.webkit.org/show_bug.cgi?id=50341
      
              The scaled tile width can be very small at times (e.g. with 'style: font 1
              required'). So use a minimum width of 1 instead of using 0 (which leads to a
              crash).
      
              Tests: fast/dom/HTMLProgressElement/progress-element-with-style-crash.html
      
              * rendering/RenderThemeChromiumSkia.cpp:
              (WebCore::RenderThemeChromiumSkia::paintProgressBar):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c77be31
    • rniwa@webkit.org's avatar
      2010-12-09 Ryosuke Niwa <rniwa@webkit.org> · 59951184
      rniwa@webkit.org authored
              Reviewed by Ojan Vafai.
      
              Implemented DOM mutations events as scoped events. A scoped event is an event whose
              dispatch is done via ScopedEventQueue. The behavior of the queue is controlled by
              EventQueueScope objects (RAII idiom), which increments and decrements the scoping level
              on its constructor and destructor respectively.
      
              When the scoping level is 0 (initial level), scoped events are dispatched as soon as
              they are enqueued and act like synchronous events. When the scoping level is greater than 0,
              however, events are queued in ScopedEventQueue and their dispatches are delayed until
              the scoping level goes back to 0 (by the destruction of EventQueueScope).
      
              DOMSubtreeModified, DOMNodeInserted, DOMNodeRemoved, DOMNodeRemovedFromDocument,
              DOMNodeInsertedIntoDocument, DOMFocusIn, DOMFocusOut, focusin, and focusout are treated as
              scoped events, and a scope object is instantiated in EditCommand::apply to delay dispatches
              of the events until the completion of each call of EditCommand::doApply.
      
              Test: fast/events/mutation/execCommands.html
      
              * Android.mk: Added ScopedEventQueue.cpp.
              * CMakeLists.txt: Ditto.
              * WebCore.pro: Ditto.
              * GNUmakefile.am: Added ScopedEventQueue.cpp and ScopedEventQueue.h.
              * WebCore.gypi:  Ditto.
              * WebCore.vcproj/project.vcproj: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * dom/ContainerNode.cpp:
              (WebCore::dispatchChildInsertionEvents): Calls dispatchScopedEvent.
              (WebCore::dispatchChildRemovalEvents): Ditto.
              * dom/DOMAllInOne.cpp: Added ScopedEventQueue.cpp.
              * dom/Element.cpp:
              (WebCore::Element::dispatchAttrRemovalEvent): Ditto. 
              (WebCore::Element::dispatchAttrAdditionEvent): Ditto.
              * dom/Node.cpp:
              (WebCore::Node::dispatchScopedEvent): Added.
              (WebCore::Node::dispatchSubtreeModifiedEvent): Calls dispatchScopedEvent.
              * dom/Node.h:
              * dom/ScopedEventQueue.cpp: Added.
              (WebCore::ScopedEventQueue::initialize): Added.
              (WebCore::ScopedEventQueue::enqueueEvent): Added.
              (WebCore::ScopedEventQueue::dispatchAllEvents): Added.
              (WebCore::ScopedEventQueue::dispatchEvent): Added.
              (WebCore::ScopedEventQueue::instance): Added.
              (WebCore::ScopedEventQueue::incrementScopingLevel): Added.
              (WebCore::ScopedEventQueue::decrementScopingLevel): Added.
              * dom/ScopedEventQueue.h: Added.
              (WebCore::ScopedEventQueue::~ScopedEventQueue): Added.
              (WebCore::ScopedEventQueue::ScopedEventQueue): Added.
              (WebCore::EventQueueScope::EventQueueScope): Added.
              (WebCore::EventQueueScope::~EventQueueScope): Added.
              * editing/EditCommand.cpp:
              (WebCore::EditCommand::apply): Instantiates EventQueueScope.
      2010-12-09  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Ojan Vafai.
      
              Added a test to ensure no DOM mutation events are fired while execCommand is in progress.
      
              * fast/events/crash-on-mutate-during-drop.html: DOMNodeInserted is fired after BR is detached
              from the document, and can't be observed. Modify the DOM when text node is inserted.
              * fast/events/mutation: Added.
              * fast/events/mutation/execCommands.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59951184
    • weinig@apple.com's avatar
      Fix scrolling with mouse wheel in WebKit2 views. Once · 20cffe9e
      weinig@apple.com authored
      we coalesce wheel events, we can re-enable this.
      
      Reviewed by Gavin Barraclough.
      
      * platform/mac/ScrollAnimatorMac.mm:
      (WebCore::ScrollAnimatorMac::scroll):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20cffe9e
    • abarth@webkit.org's avatar
      2010-12-09 Adam Barth <abarth@webkit.org> · 25b0a07e
      abarth@webkit.org authored
              Reviewed by Ojan Vafai.
      
              commit-queue errors out due to local commits
              https://bugs.webkit.org/show_bug.cgi?id=50766
      
              We seem to be tripping over having local commits in the working copy a
              lot recently.  I don't quite fully understand what the issue is, but
              this patch attempts to solve the problem by adding an explicit clean
              step before processing a patch.  Previously, we did the cleaning as
              part of the apply-attachment step, so this might not actually fix the
              problem.
      
              * Scripts/webkitpy/tool/bot/commitqueuetask.py:
              * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
              * Scripts/webkitpy/tool/commands/queues_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25b0a07e
    • inferno@chromium.org's avatar
      2010-12-09 Abhishek Arya <inferno@chromium.org> · 3337ca80
      inferno@chromium.org authored
              Reviewed by James Robinson.
      
              For details element, ensure that if we ended up being inline that we set out replaced
              flag so that we are treated like an inline block.
              https://bugs.webkit.org/show_bug.cgi?id=50671
      
              Test: fast/html/details-element-render-inline-crash.html
      
              * rendering/RenderDetails.cpp:
              (WebCore::RenderDetails::styleDidChange): setReplaced to true if we are set as inline.
              * rendering/RenderDetails.h: function definition.
      2010-12-09  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by James Robinson.
      
              Tests that we do not crash when we set details element with children to show as inline.
              https://bugs.webkit.org/show_bug.cgi?id=50671
      
              * fast/html/details-element-render-inline-crash-expected.txt: Added.
              * fast/html/details-element-render-inline-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3337ca80
    • jamesr@google.com's avatar
      2010-12-09 James Robinson <jamesr@chromium.org> · 7dbb2c67
      jamesr@google.com authored
              Unreviewed. Update Chromium GPU test expecations for canvas/philip.
      
              * platform/chromium-gpu/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7dbb2c67
    • commit-queue@webkit.org's avatar
      2010-12-09 Jasmin Lapalme <jlapalme@druide.com> · bcd8fe63
      commit-queue@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              Test for a faulty conversion from UTF-8 to UTF-16 in WebCore during an XSLT transformation.
              https://bugs.webkit.org/show_bug.cgi?id=50708
      
              * fast/xsl/utf8-chunks-expected.txt: Added.
              * fast/xsl/utf8-chunks.xml: Added.
              * fast/xsl/utf8-chunks.xsl: Added.
      2010-12-09  Jasmin Lapalme  <jlapalme@druide.com>
      
              Reviewed by Alexey Proskuryakov.
      
              Fix a faulty conversion from UTF-8 to UTF-16 in WebCore during an XSLT transformation.
              https://bugs.webkit.org/show_bug.cgi?id=50708
      
              Test: fast/xsl/utf8-chunks.xml
      
              * xml/XSLTProcessorLibxslt.cpp:
              (WebCore::writeToVector): now converts and returns the correct byte count when the end of the chunk is in the middle of a multibyte UTF-8 character.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bcd8fe63
    • inferno@chromium.org's avatar
      2010-12-09 Vincent Scheib <scheib@chromium.org> · ad91daf5
      inferno@chromium.org authored
              Reviewed by James Robinson.
      
              Clip update rectangle for Texture::updateSubRect to texture size
              https://bugs.webkit.org/show_bug.cgi?id=49929
      
              Test: fast/canvas/canvas-largedraws.html
      
              * platform/graphics/gpu/Texture.cpp:
              (WebCore::Texture::updateSubRect):
      2010-12-09  Vincent Scheib  <scheib@chromium.org>
      
              Reviewed by James Robinson.
      
              Clip update rectangle for Texture::updateSubRect to texture size
              https://bugs.webkit.org/show_bug.cgi?id=49929
      
              * fast/canvas/canvas-largedraws-expected.txt: Added.
              * fast/canvas/canvas-largedraws.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad91daf5
    • jocelyn.turcotte@nokia.com's avatar
      2010-12-09 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> · 36e9e69c
      jocelyn.turcotte@nokia.com authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt][WK2] Use a single QNetworkAccessManager per web process.
              https://bugs.webkit.org/show_bug.cgi?id=50757
      
              This allows a better management of network resources and the use
              of global cookie jar and disk cache across all frames.
      
              * WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp:
              (WebCore::WebFrameNetworkingContext::WebFrameNetworkingContext):
              (WebCore::WebFrameNetworkingContext::networkAccessManager):
              * WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h:
              * WebProcess/WebProcess.cpp:
              (WebKit::WebProcess::WebProcess):
              (WebKit::WebProcess::initializeWebProcess):
              (WebKit::WebProcess::shutdownIfPossible):
              * WebProcess/WebProcess.h:
              (WebKit::WebProcess::networkAccessManager):
              * WebProcess/mac/WebProcessMac.mm:
              (WebKit::WebProcess::platformInitializeWebProcess):
              (WebKit::WebProcess::platformShutdown):
              * WebProcess/qt/WebProcessQt.cpp:
              (WebKit::WebProcess::platformInitializeWebProcess):
              (WebKit::WebProcess::platformShutdown):
              * WebProcess/win/WebProcessWin.cpp:
              (WebKit::WebProcess::platformInitializeWebProcess):
              (WebKit::WebProcess::platformShutdown):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36e9e69c
    • mrowe@apple.com's avatar
      Fix the 32-bit build. · 39d550c5
      mrowe@apple.com authored
      * Shared/cf/ArgumentCodersCF.cpp:
      (CoreIPC::sizeForNumberType):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39d550c5
    • mjs@apple.com's avatar
      2010-12-09 Maciej Stachowiak <mjs@apple.com> · b2113000
      mjs@apple.com authored
              Reviewed by Brady Eidson.
      
              WebKit2: Control-click doesn't invoke context menu
              https://bugs.webkit.org/show_bug.cgi?id=50793
              <rdar://problem/8664800>
      
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::isContextClick): New helper function - on Mac, not only right clicks
              but also control-left-clicks are context clicks.
              (WebKit::handleMouseEvent): Use above.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2113000
    • kbr@google.com's avatar
      2010-12-09 Kenneth Russell <kbr@google.com> · 28baa6a6
      kbr@google.com authored
              Unreviewed. Another speculative Gtk build fix after r73669. Add
              needed derived sources to GNUmakefile.am.
      
              * GNUmakefile.am:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28baa6a6
    • mihaip@chromium.org's avatar
      2010-12-09 Mihai Parparita <mihaip@chromium.org> · 938028a8
      mihaip@chromium.org authored
              Unreviewed Chromium test expectations update.
      
              Group canvas/philip failures together, fix some expectations (many tests
              that were marked as flaky actually fail consistently).
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      938028a8
    • kbr@google.com's avatar
      2010-12-09 Kenneth Russell <kbr@google.com> · 36191196
      kbr@google.com authored
              Unreviewed. Speculative Gtk build fix after
              https://bugs.webkit.org/show_bug.cgi?id=36512 / r73669. Process
              all of the WebGL classes' IDL files.
      
              * CMakeLists.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36191196
    • andersca@apple.com's avatar
      Fix clang++ build. · 3e8db997
      andersca@apple.com authored
      * Scripts/webkit2/messages.py:
      DrawingAreaInfo is a struct.
      
      * Shared/WebPreferencesStore.cpp:
      (WebKit::valueForKey):
      Move valueForKey above code that uses it.
      
      * UIProcess/mac/WebInspectorProxyMac.mm:
      (-[WebInspectorProxyObjCAdapter windowWillClose:]):
      Remove trailing semicolon.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e8db997
    • mihaip@chromium.org's avatar
      2010-12-09 Mihai Parparita <mihaip@chromium.org> · e8e1c235
      mihaip@chromium.org authored
              Unreviewed Chromium test expectations update.
      
              Was overly aggressive with r73661, canvas/philip/tests/
              toDataURL.jpeg.alpha.html still fails.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8e1c235
    • zmo@google.com's avatar
      2010-12-09 Zhenyao Mo <zmo@google.com> · 1cfa85c9
      zmo@google.com authored
              Reviewed by Kenneth Russell.
      
              Expose constructor functions for instanceof checks of WebGL objects
              https://bugs.webkit.org/show_bug.cgi?id=36512
      
              Test: fast/canvas/webgl/instanceof-test.html
      
              * bindings/generic/RuntimeEnabledFeatures.h:
              (WebCore::RuntimeEnabledFeatures::webGLActiveInfoEnabled):
              (WebCore::RuntimeEnabledFeatures::webGLBufferEnabled):
              (WebCore::RuntimeEnabledFeatures::webGLFramebufferEnabled):
              (WebCore::RuntimeEnabledFeatures::webGLProgramEnabled):
              (WebCore::RuntimeEnabledFeatures::webGLRenderbufferEnabled):
              (WebCore::RuntimeEnabledFeatures::webGLShaderEnabled):
              (WebCore::RuntimeEnabledFeatures::webGLTextureEnabled):
              (WebCore::RuntimeEnabledFeatures::webGLUniformLocationEnabled):
              * html/canvas/WebGLActiveInfo.idl: Remove OmitConstructor.
              * html/canvas/WebGLBuffer.idl: Ditto.
              * html/canvas/WebGLFramebuffer.idl: Ditto.
              * html/canvas/WebGLProgram.idl: Ditto.
              * html/canvas/WebGLRenderbuffer.idl: Ditto.
              * html/canvas/WebGLShader.idl: Ditto.
              * html/canvas/WebGLTexture.idl: Ditto.
              * html/canvas/WebGLUniformLocation.idl: Ditto.
              * page/DOMWindow.idl: Expose constructors for WebGL objects in DOMWindow.
      2010-12-09  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Kenneth Russell.
      
              Expose constructor functions for instanceof checks of WebGL objects
              https://bugs.webkit.org/show_bug.cgi?id=36512
      
              * fast/canvas/webgl/instanceof-test-expected.txt: Added.
              * fast/canvas/webgl/instanceof-test.html: Added.
              * fast/dom/Window/script-tests/window-property-descriptors.js: Register newly added WebGL objects.
              * fast/dom/Window/window-properties.html: Ditto.
              * fast/dom/script-tests/prototype-inheritance-2.js: Ditto.
              (constructorNamesForWindow):
              * fast/dom/script-tests/prototype-inheritance.js: Ditto.
              * fast/js/script-tests/global-constructors.js: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1cfa85c9
    • andersca@apple.com's avatar
      Cannot use NSKeyedArchiver in WK2 for ResourceResponses · 15e0bb3d
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=50792
      <rdar://problem/8741799>
      
      Reviewed by Sam Weinig.
      
      WebKit2:
      
      When encoding, first convert the requests and responses to the serializable dictionary representation
      and use the newly added CF CoreIPC encoders. When decoding, do the opposite.
      
      * Shared/mac/WebCoreArgumentCodersMac.mm:
      (CoreIPC::encodeResourceRequest):
      (CoreIPC::decodeResourceRequest):
      (CoreIPC::encodeResourceResponse):
      (CoreIPC::decodeResourceResponse):
      
      WebKitLibraries:
      
      * WebKitSystemInterface.h:
      * libWebKitSystemInterfaceLeopard.a:
      * libWebKitSystemInterfaceSnowLeopard.a:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15e0bb3d
    • andersca@apple.com's avatar
      Fix a bug uncovered by clang++. · a833b9d9
      andersca@apple.com authored
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a833b9d9
    • timothy@apple.com's avatar
      WebCore: Export Color::white and Color::transparent. · b92d8776
      timothy@apple.com authored
      Reviewed by Anders Carlsson.
      
      * WebCore.exp.in:
      
      WebKit2: Add support for transparent WebKit2 WKViews.
      
      https://webkit.org/b/50785
      
      Reviewed by Anders Carlsson.
      
      * Shared/WebPageCreationParameters.cpp:
      (WebKit::WebPageCreationParameters::encode): Encode drawsBackground and drawsTransparentBackground.
      (WebKit::WebPageCreationParameters::decode): Decode drawsBackground and drawsTransparentBackground.
      * Shared/WebPageCreationParameters.h:
      * UIProcess/API/mac/WKView.h:
      * UIProcess/API/mac/WKView.mm:
      (-[WKView setDrawsBackground:]): Added.
      (-[WKView drawsBackground]): Added.
      (-[WKView setDrawsTransparentBackground:]): Added.
      (-[WKView drawsTransparentBackground]): Added.
      (-[WKView drawRect:]): Only fill the background if the WebProcess isn't valid and drawsBackground.
      Use white or clear based on setDrawsTransparentBackground.
      (-[WKView isOpaque]): Return drawsBackground.
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::WebPageProxy): Initialize m_drawsBackground and m_drawsTransparentBackground.
      (WebKit::WebPageProxy::setDrawsBackground): Added. Send a SetDrawsBackground message.
      (WebKit::WebPageProxy::setDrawsTransparentBackground): Added. Send a SetDrawsTransparentBackground message.
      (WebKit::WebPageProxy::creationParameters): Set drawsBackground and drawsTransparentBackground.
      * UIProcess/WebPageProxy.h:
      (WebKit::WebPageProxy::drawsBackground): Added. Return m_drawsBackground.
      (WebKit::WebPageProxy::drawsTransparentBackground): Added. Return m_drawsTransparentBackground.
      * UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm:
      (WebKit::ChunkedUpdateDrawingAreaProxy::platformPaint): Use the copy blend mode when drawing a background.
      (WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore): Use the copy blend mode to replace existing content.
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage): Setup the new view's background color and transparent flag.
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::WebPage): Initialize m_drawsBackground and m_drawsTransparentBackground.
      (WebKit::WebPage::setDrawsBackground): Added. Propagate the flag to the FrameViews.
      (WebKit::WebPage::setDrawsTransparentBackground): Added. Propagate the background color to the FrameViews.
      * WebProcess/WebPage/WebPage.h:
      (WebKit::WebPage::drawsBackground): Added. Return m_drawsBackground.
      (WebKit::WebPage::drawsTransparentBackground): Added. Return m_drawsTransparentBackground.
      * WebProcess/WebPage/WebPage.messages.in: Added SetDrawsBackground and SetDrawsTransparentBackground.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b92d8776
    • weinig@apple.com's avatar
      Fix failing Mac tests. · 7682f297
      weinig@apple.com authored
      * platform/mac/ScrollAnimatorMac.mm:
      (WebCore::ScrollAnimatorMac::scroll): Don't smooth scroll if the default
      AppleScrollAnimationEnabled is false.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7682f297
    • andersca@apple.com's avatar
      Clang++ build fixes. · 9da3e674
      andersca@apple.com authored
      Silence a couple of warnings.
      
      * WebView/WebFrame.mm:
      (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
      (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
      * WebView/WebTextCompletionController.mm:
      (-[WebTextCompletionController filterKeyDown:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9da3e674
    • jamesr@google.com's avatar
      2010-12-09 James Robinson <jamesr@chromium.org> · 0b08057d
      jamesr@google.com authored
              Reviewed by Kenneth Russell.
      
              [chromium] Compositor needs to manage its VRAM use
              https://bugs.webkit.org/show_bug.cgi?id=49629
      
              Adds a few tests involving lots of visible image layers.  The tests are designed
              to require slightly more than 64MB of VRAM.
      
              * platform/chromium-gpu-win/compositing/lots-of-img-layers-expected.checksum: Added.
              * platform/chromium-gpu-win/compositing/lots-of-img-layers-expected.png: Added.
              * platform/chromium-gpu-win/compositing/lots-of-img-layers-expected.txt: Added.
              * platform/chromium-gpu-win/compositing/lots-of-img-layers-with-opacity-expected.checksum: Added.
              * platform/chromium-gpu-win/compositing/lots-of-img-layers-with-opacity-expected.png: Added.
              * platform/chromium-gpu-win/compositing/lots-of-img-layers-with-opacity-expected.txt: Added.
              * platform/chromium-gpu/test_expectations.txt:
              * platform/chromium/compositing/lots-of-img-layers-with-opacity.html: Added.
              * platform/chromium/compositing/lots-of-img-layers.html: Added.
              * platform/chromium/test_expectations.txt:
      2010-12-09  James Robinson  <jamesr@chromium.org>
      
              Reviewed by Kenneth Russell.
      
              [chromium] Compositor needs to manage its VRAM use
              https://bugs.webkit.org/show_bug.cgi?id=49629
      
              This adds a basic texture manager to the Chromium compositor to limit the amount of VRAM
              used by compositor textures and switches ContentLayerChromium, ImageLayerChromium, and
              RenderSurfaceChromium to use managed LayerTexture.  The other *LayerChromium classes (Canvas,
              Video, and WebGL) and the root layer are still unmanaged.
      
              The TextureManager works by providing tokens to callers that want to use a managed texture.
              The token can be used to request a texture, see if the previously requested texture is still
              available, and to protect/unprotect textures when they cannot be collected.  Whenever a
              texture is created the manager attempts to free up the least recently used textures until the
              total memory use is below the provided threshhold.  If the manager cannot satisfy the memory
              limit it will not return any new textures until some old textures are released.
      
              A LayerTexture wraps a TextureManager token, size, and format.  A LayerChromium can check if a
              previously requested texture is still available for use and reserve the LayerTexture's underlying
              storage between the updateContentsIfDirty() and the draw() call.
      
              Also changes LayerChromium from having separate contentsDirty()/updateContents() calls to a single
              updateContentsIfDirty().
      
              Tests: platform/chromium/compositing/lots-of-img-layers-with-opacity.html
                     platform/chromium/compositing/lots-of-img-layers.html
      
              * WebCore.gypi:
              * platform/graphics/chromium/Canvas2DLayerChromium.cpp:
              (WebCore::Canvas2DLayerChromium::updateContentsIfDirty):
              * platform/graphics/chromium/Canvas2DLayerChromium.h:
              * platform/graphics/chromium/ContentLayerChromium.cpp:
              (WebCore::ContentLayerChromium::cleanupResources):
              (WebCore::ContentLayerChromium::updateContentsIfDirty):
              (WebCore::ContentLayerChromium::updateTextureRect):
              (WebCore::ContentLayerChromium::draw):
              * platform/graphics/chromium/ContentLayerChromium.h:
              * platform/graphics/chromium/ImageLayerChromium.cpp:
              (WebCore::ImageLayerChromium::updateContentsIfDirty):
              * platform/graphics/chromium/ImageLayerChromium.h:
              * platform/graphics/chromium/LayerChromium.h:
              (WebCore::LayerChromium::updateContentsIfDirty):
              (WebCore::LayerChromium::draw):
              * platform/graphics/chromium/LayerRendererChromium.cpp:
              (WebCore::LayerRendererChromium::LayerRendererChromium):
              (WebCore::LayerRendererChromium::useShader):
              (WebCore::LayerRendererChromium::prepareToDrawLayers):
              (WebCore::LayerRendererChromium::updateRootLayerTextureRect):
              (WebCore::LayerRendererChromium::drawLayers):
              (WebCore::LayerRendererChromium::getFramebufferPixels):
              (WebCore::LayerRendererChromium::createLayerTexture):
              (WebCore::LayerRendererChromium::deleteLayerTexture):
              (WebCore::LayerRendererChromium::updateLayersRecursive):
              (WebCore::LayerRendererChromium::useRenderSurface):
              (WebCore::LayerRendererChromium::drawLayer):
              (WebCore::LayerRendererChromium::setScissorToRect):
              (WebCore::LayerRendererChromium::setDrawViewportRect):
              (WebCore::LayerRendererChromium::initializeSharedObjects):
              (WebCore::LayerRendererChromium::cleanupSharedObjects):
              * platform/graphics/chromium/LayerRendererChromium.h:
              (WebCore::LayerRendererChromium::renderSurfaceSharedValues):
              (WebCore::LayerRendererChromium::textureManager):
              * platform/graphics/chromium/LayerTexture.cpp: Added.
              (WebCore::LayerTexture::LayerTexture):
              (WebCore::LayerTexture::~LayerTexture):
              (WebCore::LayerTexture::isValid):
              (WebCore::LayerTexture::reserve):
              (WebCore::LayerTexture::unreserve):
              (WebCore::LayerTexture::bindTexture):
              (WebCore::LayerTexture::framebufferTexture2D):
              * platform/graphics/chromium/LayerTexture.h: Added.
              (WebCore::LayerTexture::create):
              * platform/graphics/chromium/PluginLayerChromium.cpp:
              (WebCore::PluginLayerChromium::updateContentsIfDirty):
              * platform/graphics/chromium/PluginLayerChromium.h:
              * platform/graphics/chromium/RenderSurfaceChromium.cpp:
              (WebCore::RenderSurfaceChromium::SharedValues::SharedValues):
              (WebCore::RenderSurfaceChromium::SharedValues::~SharedValues):
              (WebCore::RenderSurfaceChromium::RenderSurfaceChromium):
              (WebCore::RenderSurfaceChromium::cleanupResources):
              (WebCore::RenderSurfaceChromium::prepareContentsTexture):
              (WebCore::RenderSurfaceChromium::draw):
              * platform/graphics/chromium/RenderSurfaceChromium.h:
              (WebCore::RenderSurfaceChromium::SharedValues::shaderProgram):
              (WebCore::RenderSurfaceChromium::SharedValues::shaderSamplerLocation):
              (WebCore::RenderSurfaceChromium::SharedValues::shaderMatrixLocation):
              (WebCore::RenderSurfaceChromium::SharedValues::shaderAlphaLocation):
              (WebCore::RenderSurfaceChromium::SharedValues::initialized):
              * platform/graphics/chromium/TextureManager.cpp: Added.
              (WebCore::memoryUseBytes):
              (WebCore::TextureManager::TextureManager):
              (WebCore::TextureManager::getToken):
              (WebCore::TextureManager::releaseToken):
              (WebCore::TextureManager::hasTexture):
              (WebCore::TextureManager::protectTexture):
              (WebCore::TextureManager::unprotectTexture):
              (WebCore::TextureManager::reduceMemoryToLimit):
              (WebCore::TextureManager::addTexture):
              (WebCore::TextureManager::removeTexture):
              (WebCore::TextureManager::requestTexture):
              * platform/graphics/chromium/TextureManager.h: Added.
              (WebCore::TextureManager::create):
              * platform/graphics/chromium/VideoLayerChromium.cpp:
              (WebCore::VideoLayerChromium::updateContentsIfDirty):
              * platform/graphics/chromium/VideoLayerChromium.h:
              * platform/graphics/chromium/WebGLLayerChromium.cpp:
              (WebCore::WebGLLayerChromium::updateContentsIfDirty):
              * platform/graphics/chromium/WebGLLayerChromium.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b08057d
    • andersca@apple.com's avatar
      [GTK] Support the Mozilla-style Fullscreen Javascript API · 5d63bc25
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=50572
      
      Patch by Philippe Normand <pnormand@igalia.com> on 2010-12-06
      Reviewed by Martin Robinson.
      
      * configure.ac: new configure flag to disable the new Javascript
      Fullscreen API build. It is enabled by default.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5d63bc25
    • mihaip@chromium.org's avatar
      2010-12-09 Mihai Parparita <mihaip@chromium.org> · e5c16d67
      mihaip@chromium.org authored
              Unreviewed Chromium test expectations update.
      
              Delete a bunch of chromium-win specific baselines that were added by
              r68608. That was done because r68568 checked in failing expectations,
              but since Chromium was passing the tests with Skia, we wanted to keep
              passing them. However, the failing expectations were rolled out by
              r68737, so we no longer needed Chromium-specific expectations.
      
              Later, with r71481 we updated to a new version of the Philip test suite,
              which has a different output format, and the Chromium-specific
              expectations were out of date. Since they're not needed (we should pass
              with the base ones), they can just be deleted.
      
              * platform/chromium-mac/canvas/philip/tests/2d.drawImage.null-expected.txt: Removed.
              * platform/chromium-mac/canvas/philip/tests/2d.pattern.image.null-expected.txt: Removed.
              * platform/chromium-win/canvas/philip/tests/2d.drawImage.null-expected.txt: Removed.
              * platform/chromium-win/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt: Removed.
              * platform/chromium-win/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt: Removed.
              * platform/chromium-win/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt: Removed.
              * platform/chromium-win/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt: Removed.
              * platform/chromium-win/canvas/philip/tests/2d.line.cap.closed-expected.txt: Removed.
              * platform/chromium-win/canvas/philip/tests/2d.line.join.parallel-expected.txt: Removed.
              * platform/chromium-win/canvas/philip/tests/2d.line.miter.lineedge-expected.txt: Removed.
              * platform/chromium-win/canvas/philip/tests/2d.pattern.image.null-expected.txt: Removed.
              * platform/chromium-win/canvas/philip/tests/2d.shadow.enable.x-expected.txt: Removed.
              * platform/chromium-win/canvas/philip/tests/2d.shadow.enable.y-expected.txt: Removed.
              * platform/chromium-win/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt: Removed.
              * platform/chromium-win/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt: Removed.
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5c16d67
    • darin@apple.com's avatar
      Rework my recent setLocation refactoring to use DOMWindow instead of Frame. · c957680a
      darin@apple.com authored
      It's difficult to make correct security decisions based on Frame since a
      Frame can navigate to a new document.
      
      Reviewed by Sam Weinig.
      
      Fixes some test failures that I somehow missed before the last check-in.
      
      * bindings/js/JSDOMWindowBase.cpp:
      (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage): Call to the
      shell DOMWindow; not sure this one matters, but it's closer to the old
      code before my last patch. Also pass the DOMWindow rather than the
      frame to crossDomainAccessErrorMessage.
      
      * bindings/js/JSDOMWindowCustom.cpp:
      (WebCore::JSDOMWindow::setLocation): Pass DOMWindow rather than Frame
      to the DOMWindow::setLocation function.
      
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::setLocation): Take DOMWindow rather than Frame.
      (WebCore::DOMWindow::crossDomainAccessErrorMessage): Ditto.
      
      * page/DOMWindow.h: Update new functions to take DOMWindow rather
      than Frame.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c957680a
    • mihaip@chromium.org's avatar
      2010-12-09 Mihai Parparita <mihaip@chromium.org> · 49954fdb
      mihaip@chromium.org authored
              Unreviewed Chromium test expectations update.
      
              Remove test_expectations.txt entries for 4 Philip suite canvas tests
              that pass consistently on all bots. 2d.drawImage.incomplete.html was
              fixed by r71292, the rest have been passing for as long as we have
              history in the Chromium test dashboard.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49954fdb
    • mrowe@apple.com's avatar
      Versioning. · d36d544b
      mrowe@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73658 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d36d544b
    • weinig@apple.com's avatar
      Try and fix the mac build. · 66860cfd
      weinig@apple.com authored
      * WebCore.exp.in:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73656 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66860cfd
    • pkasting@chromium.org's avatar
      Unreviewed Chromium test expectations update. · 29817635
      pkasting@chromium.org authored
      Mark a test as timing out on Win Debug.
      
      * platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29817635
    • dpranke@chromium.org's avatar
      2010-12-09 Dirk Pranke <dpranke@chromium.org> · 50a6d5e2
      dpranke@chromium.org authored
              Reviewed by Ojan Vafai.
      
              Make new-run-webkit-tests --lint-test-files log slightly better
              messages and return -1 if lint fails. Remove the
              'suppress_errors' keyword param to the TestExpectationsFile
              class, and clean up logging and exception raising for error
              handling. Also add more unit tests and clean up the unit test code a bit.
      
              https://bugs.webkit.org/show_bug.cgi?id=50205
      
              * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
              * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
              * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
              * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
              * Scripts/webkitpy/layout_tests/port/chromium.py:
              * Scripts/webkitpy/style/checkers/test_expectations.py:
              * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50a6d5e2
    • mitz@apple.com's avatar
      Removed an unused variable. · b34bbfc6
      mitz@apple.com authored
      Reviewed by Dave Hyatt.
      
      * rendering/InlineFlowBox.cpp:
      (WebCore::InlineFlowBox::computeLogicalBoxHeights): Removed parentLineHeight.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b34bbfc6
    • beidson@apple.com's avatar
      <rdar://problem/8749750> and https://bugs.webkit.org/show_bug.cgi?id=50786 · 08040ac1
      beidson@apple.com authored
      WK2 authentication never consults WebCore session credential storage.
      
      Reviewed by Sam Weinig.
      
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::shouldUseCredentialStorage): Since we don't need to expose this as
        API at this time, always return true.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08040ac1