1. 26 Aug, 2013 1 commit
  2. 27 Jun, 2013 1 commit
  3. 15 Apr, 2013 1 commit
  4. 13 Apr, 2013 1 commit
    • rniwa@webkit.org's avatar
      Merge AbstractDeclarativeCommand into Command as a comment suggests · 014f1234
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114559
      
      Reviewed by Antti Koivisto.
      
      Merged two classes as the comment right above AbstractDeclarativeCommand suggested.
      We need to merge a lot more classes to make webkitpy hackable.
      
      * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
      (AbstractLocalServerCommand):
      (AbstractLocalServerCommand.__init__):
      * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
      (AbstractSequencedCommand):
      (AbstractSequencedCommand.__init__):
      * Scripts/webkitpy/tool/commands/adduserstogroups.py:
      (AddUsersToGroups):
      * Scripts/webkitpy/tool/commands/analyzechangelog.py:
      (AnalyzeChangeLog):
      (AnalyzeChangeLog.__init__):
      * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
      * Scripts/webkitpy/tool/commands/bugfortest.py:
      (BugForTest):
      * Scripts/webkitpy/tool/commands/bugsearch.py:
      (BugSearch):
      * Scripts/webkitpy/tool/commands/chromechannels.py:
      (ChromeChannels):
      (__init__):
      * Scripts/webkitpy/tool/commands/download.py:
      (AbstractPatchProcessingCommand):
      * Scripts/webkitpy/tool/commands/findusers.py:
      (FindUsers):
      * Scripts/webkitpy/tool/commands/openbugs.py:
      (OpenBugs):
      * Scripts/webkitpy/tool/commands/queries.py:
      (BugsToCommit):
      (PatchesInCommitQueue):
      (PatchesToCommitQueue):
      (PatchesToCommitQueue.__init__):
      (PatchesToReview):
      (PatchesToReview.__init__):
      (PatchesToReview.execute):
      (WhatBroke):
      (ResultsFor):
      (FailureReason):
      (FindFlakyTests):
      (TreeStatus):
      (CrashLog):
      (PrintExpectations):
      (PrintExpectations.__init__):
      (PrintBaselines):
      (PrintBaselines.__init__):
      * Scripts/webkitpy/tool/commands/queues.py:
      (AbstractQueue.__init__):
      * Scripts/webkitpy/tool/commands/rebaseline.py:
      (AbstractRebaseliningCommand):
      * Scripts/webkitpy/tool/commands/suggestnominations.py:
      (SuggestNominations):
      (SuggestNominations.__init__):
      * Scripts/webkitpy/tool/commands/upload.py:
      (CommitMessageForCurrentDiff):
      (CommitMessageForCurrentDiff.__init__):
      (CleanPendingCommit):
      (CleanReviewQueue):
      (AssignToCommitter):
      (PostCommits):
      (PostCommits.__init__):
      (MarkBugFixed):
      (MarkBugFixed.__init__):
      (CreateBug):
      (CreateBug.__init__):
      * Scripts/webkitpy/tool/multicommandtool.py:
      (Command):
      (Command.__init__):
      (Command.main):
      (HelpCommand):
      (HelpCommand.__init__):
      * Scripts/webkitpy/tool/multicommandtool_unittest.py:
      (TrivialCommand):
      (TrivialCommand.__init__):
      (LikesToRetry):
      (LikesToRetry.__init__):
      (CommandTest.test_name_with_arguments):
      (CommandTest.test_required_arguments):
      (test_command_help):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148360 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      014f1234
  5. 22 Jan, 2013 1 commit
    • commit-queue@webkit.org's avatar
      Convert disable-msg to disable for new pylint. · 7bd559c9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107627
      
      Patch by Tim 'mithro' Ansell <mithro@mithis.com> on 2013-01-22
      Reviewed by Eric Seidel.
      
      * Scripts/webkitpy/common/checkout/scm/svn.py:
      (SVNRepository.has_authorization_for_realm):
      * Scripts/webkitpy/common/net/buildbot/buildbot.py:
      (Builder.force_build):
      * Scripts/webkitpy/common/system/executive_mock.py:
      (MockExecutive2.run_command):
      * Scripts/webkitpy/layout_tests/port/base.py:
      (Port.reference_files):
      * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
      (ChromiumPortTestCase.test_default_configuration):
      * Scripts/webkitpy/layout_tests/port/port_testcase.py:
      (PortTestCase.test_expectations_ordering):
      * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
      (HttpServerBase._check_that_all_ports_are_available):
      * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
      (AbstractLocalServerCommand.execute):
      * Scripts/webkitpy/tool/commands/download.py:
      (AbstractPatchProcessingCommand):
      * Scripts/webkitpy/tool/commands/rebaseline.py:
      (AbstractRebaseliningCommand):
      (AbstractParallelRebaselineCommand):
      * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
      (_BaseTestCase.setUp):
      (TestAnalyzeBaselines.setUp):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7bd559c9
  6. 15 Jan, 2013 1 commit
    • commit-queue@webkit.org's avatar
      Renaming CleanWorkingDirectory step to DiscardLocalChanges to make · fb19322c
      commit-queue@webkit.org authored
      functionality match the name.
      https://bugs.webkit.org/show_bug.cgi?id=106870
      
      Patch by Tim 'mithro' Ansell <mithro@mithis.com> on 2013-01-15
      Reviewed by Adam Barth.
      
      * Scripts/webkitpy/tool/commands/download.py:
      (Clean):
      (Update):
      (Build):
      (BuildAndTest):
      (CheckStyle):
      (BuildAttachment):
      (BuildAndTestAttachment):
      (AbstractPatchApplyingCommand):
      (ApplyWatchList):
      (AbstractPatchLandingCommand):
      (CreateRollout):
      * Scripts/webkitpy/tool/steps/__init__.py:
      * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
      (CleanWorkingDirectory.options):
      (CleanWorkingDirectory.run):
      * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
      * Scripts/webkitpy/tool/steps/discardlocalchanges.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
      * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139771 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb19322c
  7. 26 Nov, 2012 1 commit
    • zandobersek@gmail.com's avatar
      Remove use of deprecated logging from most of webkitpy.tool · f40a6cf2
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=103180
      
      Reviewed by Dirk Pranke.
      
      Remove calls to log and error methods of the deprecated_logging module, replacing them
      by using Python's Logger objects. This patch covers the switch in all of webkitpy.tool
      except the QueueEngine.
      
      Unit tests are adjusted for these changes, moving output from expected stderr to expected logs.
      
      * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
      (MockCommitQueue.run_command):
      (MockCommitQueue.command_passed):
      (MockCommitQueue.command_failed):
      (MockCommitQueue.report_flaky_tests):
      (MockCommitQueue.archive_last_test_results):
      (CommitQueueTaskTest._run_through_task):
      (CommitQueueTaskTest.test_success_case):
      (test_fast_success_case):
      (test_clean_failure):
      (test_update_failure):
      (test_apply_failure):
      (test_validate_changelog_failure):
      (test_build_failure):
      (test_red_build_failure):
      (test_flaky_test_failure):
      (test_failed_archive):
      (test_double_flaky_test_failure):
      (test_test_failure):
      (test_red_test_failure):
      (test_very_red_tree_retry):
      (test_red_tree_patch_rejection):
      (test_land_failure):
      * Scripts/webkitpy/tool/bot/feeders.py:
      (CommitQueueFeeder._update_work_items):
      (EWSFeeder.feed):
      * Scripts/webkitpy/tool/bot/feeders_unittest.py:
      * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
      (LayoutTestResultsReader.archive):
      * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
      (test_archive_last_layout_test_results):
      * Scripts/webkitpy/tool/bot/sheriff.py:
      * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
      (AbstractSequencedCommand.execute):
      * Scripts/webkitpy/tool/commands/commandtest.py:
      (CommandsTest.assert_execute_outputs):
      * Scripts/webkitpy/tool/commands/download.py:
      (AbstractPatchProcessingCommand._process_patch.execute):
      (ProcessBugsMixin._fetch_list_of_patches_to_process):
      (ProcessURLsMixin._fetch_list_of_patches_to_process):
      (AbstractRolloutPrepCommand._commit_info):
      * Scripts/webkitpy/tool/commands/download_unittest.py:
      (AbstractRolloutPrepCommandTest.test_commit_info):
      (DownloadCommandsTest.test_build):
      (DownloadCommandsTest.test_build_and_test):
      (test_apply_attachment):
      (test_apply_from_bug):
      (test_apply_watch_list):
      (test_land):
      (test_land_red_builders):
      (test_check_style):
      (test_build_attachment):
      (test_land_attachment):
      (test_land_from_bug):
      (test_land_from_url):
      (test_prepare_rollout):
      (test_create_rollout):
      (test_create_rollout_resolved):
      (test_rollout):
      * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
      (AbstractEarlyWarningSystem.handle_script_error.does):
      * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
      (EarlyWarningSytemTest._default_expected_stderr):
      (EarlyWarningSytemTest._default_expected_logs):
      (EarlyWarningSytemTest._test_testing_ews):
      * Scripts/webkitpy/tool/commands/openbugs.py:
      (OpenBugs.execute):
      * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
      (OpenBugsTest.test_args_parsing):
      * Scripts/webkitpy/tool/commands/perfalizer.py:
      (Perfalizer.handle_unexpected_error):
      * Scripts/webkitpy/tool/commands/queries.py:
      (PatchesInCommitQueue.execute):
      (PatchesToCommitQueue._needs_commit_queue):
      * Scripts/webkitpy/tool/commands/queries_unittest.py:
      (QueryCommandsTest.test_bugs_to_commit):
      (QueryCommandsTest.test_patches_in_commit_queue):
      (QueryCommandsTest.test_patches_to_commit_queue):
      * Scripts/webkitpy/tool/commands/queues.py:
      (AbstractQueue._cc_watchers):
      (AbstractQueue.begin_work_queue):
      (FeederQueue.handle_unexpected_error):
      (CommitQueue.handle_script_error):
      (AbstractReviewQueue.handle_unexpected_error):
      (AbstractReviewQueue.handle_script_error):
      * Scripts/webkitpy/tool/commands/queues_unittest.py:
      (test_auto_retry):
      * Scripts/webkitpy/tool/commands/queuestest.py:
      (QueuesTest.assert_outputs):
      (QueuesTest._default_begin_work_queue_stderr):
      (QueuesTest):
      (QueuesTest._default_begin_work_queue_logs):
      (QueuesTest.assert_queue_outputs):
      * Scripts/webkitpy/tool/commands/roll_unittest.py:
      (RollCommandsTest.test_update_chromium_deps):
      (test_update_chromium_deps_older_revision):
      * Scripts/webkitpy/tool/commands/sheriffbot.py:
      (SheriffBot.handle_unexpected_error):
      * Scripts/webkitpy/tool/commands/stepsequence.py:
      (StepSequence.run_and_handle_errors):
      * Scripts/webkitpy/tool/commands/upload.py:
      (AssignToCommitter._assign_bug_to_last_patch_attacher):
      (AbstractPatchUploadingCommand._prepare_state):
      (PostCommits.execute):
      (MarkBugFixed._determine_bug_id_and_svn_revision):
      (MarkBugFixed.execute):
      (CreateBug.create_bug_from_commit):
      (CreateBug.execute):
      * Scripts/webkitpy/tool/commands/upload_unittest.py:
      (test_obsolete_attachments):
      (test_land_safely):
      (test_mark_bug_fixed):
      * Scripts/webkitpy/tool/multicommandtool.py:
      (Command.check_arguments_and_execute):
      (MultiCommandTool.main):
      * Scripts/webkitpy/tool/multicommandtool_unittest.py:
      (CommandTest.test_required_arguments):
      * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py:
      (AddSvnMimetypeForPng.run):
      * Scripts/webkitpy/tool/steps/applypatch.py:
      (ApplyPatch.run):
      * Scripts/webkitpy/tool/steps/build.py:
      (Build.run):
      * Scripts/webkitpy/tool/steps/checkstyle.py:
      * Scripts/webkitpy/tool/steps/closebug.py:
      (CloseBug.run):
      * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
      (CloseBugForLandDiff.run):
      * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
      (CloseBugForLandDiffTest.test_empty_state):
      * Scripts/webkitpy/tool/steps/commit.py:
      (Commit.run):
      * Scripts/webkitpy/tool/steps/commit_unittest.py:
      (CommitTest._test_check_test_expectations):
      * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
      (EnsureLocalCommitIfNeeded.run):
      * Scripts/webkitpy/tool/steps/obsoletepatches.py:
      (ObsoletePatches.run):
      * Scripts/webkitpy/tool/steps/preparechangelog.py:
      (PrepareChangeLog.run):
      * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
      (ReopenBugAfterRollout.run):
      * Scripts/webkitpy/tool/steps/runtests.py:
      (RunTests.run):
      * Scripts/webkitpy/tool/steps/runtests_unittest.py:
      (RunTestsTest.test_webkit_run_unit_tests):
      * Scripts/webkitpy/tool/steps/steps_unittest.py:
      (StepsTest.test_update_step):
      (StepsTest.test_runtests_args):
      * Scripts/webkitpy/tool/steps/update.py:
      (Update.run):
      * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
      (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_bug):
      (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_multipatch_bug):
      * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
      (UpdateChangeLogsWithReviewer._guess_reviewer_from_bug):
      (UpdateChangeLogsWithReviewer.run):
      * Scripts/webkitpy/tool/steps/updatechromiumdeps.py:
      (UpdateChromiumDEPS._validate_revisions):
      (UpdateChromiumDEPS.run):
      * Scripts/webkitpy/tool/steps/validatechangelogs.py:
      (ValidateChangeLogs._check_changelog_diff):
      (ValidateChangeLogs.run):
      * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
      (ValidateChangeLogsTest._assert_start_line_produces_output):
      * Scripts/webkitpy/tool/steps/validatereviewer.py:
      (ValidateReviewer.run):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135744 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f40a6cf2
  8. 13 Nov, 2012 1 commit
    • dpranke@chromium.org's avatar
      webkitpy: clean up lint errors, part 2 · 297753ed
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102029
      
      Reviewed by Adam Barth.
      
      This cleans up the remaining lint errors in webkitpy with four exceptions:
      1) we don't lint thirdparty/ autoinstalled code, obviously
      2) there's an intentional error in the unit tests for pylint itself
      3) the implementation of webkit-patch optimize-expectations has
      an error but I think we can and should just remove that command as well.
      4) I have not yet linted the test code
      
      * Scripts/webkitpy/common/newstringio.py:
      * Scripts/webkitpy/common/checkout/scm/scm.py:
      (SCM.find_checkout_root):
      (SCM.will.remote_merge_base):
      * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
      * Scripts/webkitpy/common/checkout/scm/svn.py:
      (SVNRepository.has_authorization_for_realm):
      (SVN.__init__):
      * Scripts/webkitpy/common/config/contributionareas.py:
      (ContributionAreas.names):
      * Scripts/webkitpy/common/config/ports.py:
      (DeprecatedPort):
      * Scripts/webkitpy/common/net/buildbot/buildbot.py:
      (Builder.force_build):
      * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
      * Scripts/webkitpy/style/checkers/cpp.py:
      (check_posix_threading):
      (check_spacing):
      * Scripts/webkitpy/style/optparser.py:
      (ArgumentParser._create_option_parser):
      * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
      (AbstractLocalServerCommand.execute):
      * Scripts/webkitpy/tool/commands/download.py:
      (AbstractPatchProcessingCommand):
      (AbstractPatchProcessingCommand._process_patch):
      * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
      (AbstractEarlyWarningSystem):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@134371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      297753ed
  9. 13 Sep, 2012 1 commit
  10. 11 Jul, 2012 1 commit
    • ossy@webkit.org's avatar
      webkit-patch land should automatically add svn:mime-type for .png files · cb32645e
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75825
      
      Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-07-11
      Reviewed by Dirk Pranke.
      
      Refactor the png.py to avoid code duplication.
      
      * Scripts/webkitpy/common/checksvnconfigfile.py: Added.
      (check):
      (config_file_path):
      (errorstr_autoprop):
      (errorstr_png):
      * Scripts/webkitpy/style/checkers/png.py:
      (PNGChecker.check):
      * Scripts/webkitpy/tool/commands/download.py:
      (Land):
      * Scripts/webkitpy/tool/steps/__init__.py:
      * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py: Added.
      (AddSvnMimetypeForPng):
      (AddSvnMimetypeForPng.__init__):
      (AddSvnMimetypeForPng.run):
      (AddSvnMimetypeForPng._check_pngs):
      * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py: Added.
      (MockSCMDetector):
      (MockSCMDetector.__init__):
      (MockSCMDetector.display_name):
      (AddSvnMimetypeForPngTest):
      (AddSvnMimetypeForPngTest.test_run):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122311 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb32645e
  11. 14 May, 2012 2 commits
    • ossy@webkit.org's avatar
      Unreviewed, rolling out r116935. · 542273c4
      ossy@webkit.org authored
      http://trac.webkit.org/changeset/116935
      https://bugs.webkit.org/show_bug.cgi?id=86373
      
      Something is still broken (Requested by Ossy on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-14
      
      * Scripts/webkitpy/common/checksvnconfigfile.py: Removed.
      * Scripts/webkitpy/style/checkers/png.py:
      (PNGChecker.check):
      (PNGChecker):
      (PNGChecker._config_file_path):
      * Scripts/webkitpy/tool/commands/download.py:
      (Land):
      * Scripts/webkitpy/tool/steps/__init__.py:
      * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py: Removed.
      * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      542273c4
    • ossy@webkit.org's avatar
      webkit-patch land should automatically add svn:mime-type for .png files · 9166246a
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75825
      I refactored the png.py to avoid code duplication.
      
      Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-05-14
      Reviewed by Dirk Pranke.
      
      * Scripts/webkitpy/common/checksvnconfigfile.py: Added.
      (check):
      (_config_file_path):
      (errorstr_autoprop):
      (errorstr_png):
      * Scripts/webkitpy/style/checkers/png.py:
      (PNGChecker.check):
      * Scripts/webkitpy/tool/commands/download.py:
      (Land):
      * Scripts/webkitpy/tool/steps/__init__.py:
      * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py: Added.
      (AddSvnMimetypeForPng):
      (AddSvnMimetypeForPng.__init__):
      (AddSvnMimetypeForPng.run):
      (AddSvnMimetypeForPng._check_pngs):
      * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py: Added.
      (MockSCMDetector):
      (MockSCMDetector.__init__):
      (MockSCMDetector.display_name):
      (AddSvnMimetypeForPngTest):
      (AddSvnMimetypeForPngTest.test_run):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116935 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9166246a
  12. 16 Mar, 2012 1 commit
    • eric@webkit.org's avatar
      Add a land-from-url command · 034a666b
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=81411
      
      Reviewed by Adam Barth.
      
      Very basic so far.  The goal is to make it landing smarter
      so that users don't have to bother to parse out the ids out of the urls.
      
      * Scripts/webkitpy/common/config/urls.py:
      (parse_bug_id):
      (parse_attachment_id):
      * Scripts/webkitpy/common/config/urls_unittest.py:
      (URLsTest.test_parse_bug_id):
      (URLsTest):
      (URLsTest.test_parse_attachment_id):
      * Scripts/webkitpy/tool/commands/download.py:
      (ProcessURLsMixin):
      (ProcessURLsMixin._fetch_list_of_patches_to_process):
      (LandFromURL):
      * Scripts/webkitpy/tool/commands/download_unittest.py:
      (test_land_from_bug):
      (test_land_from_url):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@111095 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      034a666b
  13. 24 Feb, 2012 1 commit
    • abarth@webkit.org's avatar
      style-queue tries to apply the patch twice · 6cd15aff
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=79459
      
      Reviewed by Eric Seidel.
      
      Previously, we applied the patch using both apply-patch and
      check-style.  This patch introduces a check-style-local to mirror the
      apply-watchlist-local, which operates on the current working diff.
      
      This patch also cleans up some other bugs I found by running the queue
      locally for a while.  The queue still prints out a slightly
      less-than-ideal message on the bugs when it find an error, but it's ok
      for now.  We'll need to iterate a bit.
      
      * Scripts/webkitpy/tool/bot/stylequeuetask.py:
      (StyleQueueTask.validate):
      (StyleQueueTask._check_style):
      * Scripts/webkitpy/tool/commands/download.py:
      (CheckStyleLocal):
      * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
      (EarlyWarningSytemTest._default_expected_stderr):
      (EarlyWarningSytemTest._test_testing_ews):
      * Scripts/webkitpy/tool/commands/queues.py:
      (AbstractReviewQueue.handle_script_error):
      (StyleQueue.review_patch):
      * Scripts/webkitpy/tool/commands/queues_unittest.py:
      * Scripts/webkitpy/tool/commands/queuestest.py:
      (QueuesTest.assert_queue_outputs):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108744 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6cd15aff
  14. 09 Feb, 2012 1 commit
    • eric@webkit.org's avatar
      Remove more uses of "os" from our webkitpy code · ea6c3e32
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=78292
      
      Reviewed by Adam Barth.
      
      * Scripts/webkitpy/common/checkout/checkout_mock.py:
      (MockCheckout.__init__):
      (MockCheckout.is_path_to_changelog):
      * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
      * Scripts/webkitpy/common/system/filesystem_mock.py:
      (MockFileSystem._split):
      * Scripts/webkitpy/common/system/zipfileset_unittest.py:
      * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
      * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
      * Scripts/webkitpy/layout_tests/port/webkit.py:
      * Scripts/webkitpy/tool/bot/queueengine.py:
      * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
      * Scripts/webkitpy/tool/commands/download.py:
      * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
      * Scripts/webkitpy/tool/commands/rebaselineserver.py:
      * Scripts/webkitpy/tool/commands/sheriffbot.py:
      * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
      * Scripts/webkitpy/tool/commands/upload.py:
      (CreateBug.prompt_for_bug_title_and_comment):
      * Scripts/webkitpy/tool/servers/reflectionhandler.py:
      * Scripts/webkitpy/tool/steps/attachtobug.py:
      (AttachToBug.run):
      * Scripts/webkitpy/tool/steps/checkstyle.py:
      * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
      * Scripts/webkitpy/tool/steps/commit_unittest.py:
      * Scripts/webkitpy/tool/steps/editchangelog.py:
      * Scripts/webkitpy/tool/steps/preparechangelog.py:
      * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
      (PrepareChangeLogTest.test_ensure_bug_url):
      * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
      * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
      * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
      * Scripts/webkitpy/tool/steps/validatereviewer.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107302 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea6c3e32
  15. 06 Feb, 2012 1 commit
  16. 19 Jan, 2012 1 commit
  17. 14 Oct, 2011 1 commit
  18. 13 Oct, 2011 1 commit
  19. 12 Oct, 2011 1 commit
  20. 03 Oct, 2011 1 commit
  21. 30 Sep, 2011 1 commit
    • levin@chromium.org's avatar
      watchlist: Add webkit-patch command to run watchlist. · c063ddfc
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68973
      
      Reviewed by Eric Seidel.
      
      * Scripts/webkitpy/common/host.py: Exposed the watch_list.
      * Scripts/webkitpy/common/watchlist/watchlist.py: Changed to return
      the cc and messages as sorted lists. To allow for deterministic ordering.
      * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Ditto.
      * Scripts/webkitpy/tool/commands/__init__.py: Add ApplyWatchListLocal so
      that it will be exposed as a command by webkit-patch.
      * Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Added.
      * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Added.
      * Scripts/webkitpy/tool/commands/download.py: Added ApplyWatchList which mimics CheckStyle.
      * Scripts/webkitpy/tool/commands/download_unittest.py: Added an appropriate test.
      * Scripts/webkitpy/tool/mocktool.py: Mock out the watch list.
      * Scripts/webkitpy/tool/steps/__init__.py: Added ApplyWatchList.
      * Scripts/webkitpy/tool/steps/applywatchlist.py: Added.
      * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96444 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c063ddfc
  22. 12 Sep, 2011 1 commit
    • eric@webkit.org's avatar
      Rubber-stamped by Adam Barth. · a60eb49e
      eric@webkit.org authored
      Remove the "the tree is burning!" warning previously shown
      when landing patches.  It was a dream.  But it's just noise now.
      
      Some bots will require a restart to notice the removal of the option
      so I've left the --ignore-builders option in for now.
      
      * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
      * Scripts/webkitpy/tool/bot/patchanalysistask.py:
      * Scripts/webkitpy/tool/commands/download.py:
      * Scripts/webkitpy/tool/commands/download_unittest.py:
      * Scripts/webkitpy/tool/commands/queues_unittest.py:
      * Scripts/webkitpy/tool/steps/__init__.py:
      * Scripts/webkitpy/tool/steps/commit.py:
      * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: Removed.
      * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94978 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a60eb49e
  23. 29 Jun, 2011 1 commit
  24. 08 Feb, 2011 1 commit
    • tony@chromium.org's avatar
      2011-02-07 Tony Chang <tony@chromium.org> · c3ccf5a2
      tony@chromium.org authored
              Reviewed by Adam Barth.
      
              clean up python imports
              https://bugs.webkit.org/show_bug.cgi?id=53966
      
              Convert "import A.B.C.D as D" to "from A.B.C import D" and
              make some imports absolute as required by PEP-8
      
              * Scripts/webkitpy/common/checkout/scm.py:
              * Scripts/webkitpy/common/net/irc/ircbot.py:
              * Scripts/webkitpy/common/system/logutils.py:
              * Scripts/webkitpy/common/system/logutils_unittest.py:
              * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
              * Scripts/webkitpy/layout_tests/port/chromium.py:
              * Scripts/webkitpy/layout_tests/port/mac.py: Remove some unused imports
              * Scripts/webkitpy/layout_tests/port/webkit.py:
              * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py:
              * Scripts/webkitpy/tool/bot/irc_command.py:
              * Scripts/webkitpy/tool/bot/sheriffircbot.py:
              * Scripts/webkitpy/tool/commands/download.py:
              * Scripts/webkitpy/tool/commands/prettydiff.py:
              * Scripts/webkitpy/tool/commands/queries.py:
              * Scripts/webkitpy/tool/commands/roll.py:
              * Scripts/webkitpy/tool/commands/stepsequence.py:
              * Scripts/webkitpy/tool/commands/upload.py:
              * Scripts/webkitpy/tool/main.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77913 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3ccf5a2
  25. 24 Dec, 2010 1 commit
    • eric@webkit.org's avatar
      2010-12-24 Eric Seidel <eric@webkit.org> · 6acfa901
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
              https://bugs.webkit.org/show_bug.cgi?id=28291
      
              This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
              We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
              to strings with find in the diff.
              Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
      
              * Scripts/webkitpy/common/checkout/api.py:
              * Scripts/webkitpy/common/checkout/diff_parser.py:
              * Scripts/webkitpy/tool/steps/abstractstep.py:
              * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
              * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
              * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
              * Scripts/webkitpy/tool/steps/validatereviewer.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6acfa901
  26. 17 Dec, 2010 1 commit
    • mitz@apple.com's avatar
      Rename WebKitTools to Tools · 10955a5a
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=49861
      
      Reviewed by Simon Fraser.
      
      .: 
      
      * DerivedSources.pro:
      * GNUmakefile.am:
      * MakeFile:
      * MakeFile.shared:
      * Tools: Renamed from WebKitTools.
      * WebKit.pro:
      * cmake/WebKitPackaging.cmake:
      * wscript:
      
      BugsSite: 
      
      * PrettyPatch/PrettyPatch.rb:
      * committers-autocomplete.js:
      
      Tools: 
      
      * BuildSlaveSupport/build.webkit.org-config/master.cfg:
      * CodeCoverage/README:
      * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
      (WebCore::DumpRenderTree::initializeFonts):
      * EWSTools/start-commit-queue.sh:
      * EWSTools/start-queue.sh:
      * GNUmakefile.am:
      * MIDLWrapper/MIDLWrapper.cpp:
      (wmain):
      * MiniBrowser/qt/MiniBrowser.pro:
      * Scripts/build-api-tests:
      * Scripts/build-dumprendertree:
      * Scripts/build-webkit:
      * Scripts/build-webkittestrunner:
      * Scripts/generate-coverage-data:
      * Scripts/old-run-webkit-tests:
      * Scripts/run-api-tests:
      * Scripts/run-iexploder-tests:
      * Scripts/run-javascriptcore-tests:
      * Scripts/run-mangleme-tests:
      * Scripts/run-sunspider:
      * Scripts/run-webkit-websocketserver:
      * Scripts/sunspider-compare-results:
      * Scripts/test-webkitperl:
      * Scripts/test-webkitpy:
      * Scripts/update-iexploder-cssproperties:
      * Scripts/update-webkit:
      * Scripts/update-webkit-localizable-strings:
      * Scripts/webkitdirs.pm:
      * Scripts/webkitpy/common/checkout/scm.py:
      * Scripts/webkitpy/common/checkout/scm_unittest.py:
      * Scripts/webkitpy/common/config/committervalidator.py:
      * Scripts/webkitpy/common/config/committervalidator_unittest.py:
      * Scripts/webkitpy/common/config/ports.py:
      * Scripts/webkitpy/common/config/ports_unittest.py:
      * Scripts/webkitpy/common/system/logutils_unittest.py:
      * Scripts/webkitpy/common/system/ospath_unittest.py:
      * Scripts/webkitpy/layout_tests/port/chromium.py:
      * Scripts/webkitpy/layout_tests/port/config.py:
      * Scripts/webkitpy/layout_tests/port/config_unittest.py:
      * Scripts/webkitpy/layout_tests/port/http_server.py:
      * Scripts/webkitpy/layout_tests/port/test.py:
      * Scripts/webkitpy/style/checker.py:
      * Scripts/webkitpy/style/checker_unittest.py:
      * Scripts/webkitpy/tool/bot/feeders_unittest.py:
      * Scripts/webkitpy/tool/commands/queues_unittest.py:
      * Scripts/webkitpy/tool/steps/steps_unittest.py:
      * WebKitTestRunner/DerivedSources.pro:
      * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
      (WTR::activateFonts):
      * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
      * wx/build/build_utils.py:
      
      WebKitSite: 
      
      * asking_questions.html:
      * building/tools.html:
      * coding/scripts.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10955a5a
  27. 13 Dec, 2010 1 commit
    • commit-queue@webkit.org's avatar
      2010-12-13 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> · 19dc850d
      commit-queue@webkit.org authored
              Reviewed by Eric Seidel.
      
              webkit-patch rollout should be able to do multi-revision rollouts
              https://bugs.webkit.org/show_bug.cgi?id=33336
      
              Make it possible to pass more than one revision to webkit-patch.
      
              * Scripts/webkitpy/common/checkout/api.py:
              * Scripts/webkitpy/common/checkout/changelog.py:
              * Scripts/webkitpy/common/checkout/changelog_unittest.py:
              * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
              * Scripts/webkitpy/tool/commands/download.py:
              * Scripts/webkitpy/tool/commands/download_unittest.py:
              * Scripts/webkitpy/tool/mocktool.py:
              * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
              * Scripts/webkitpy/tool/steps/revertrevision.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73951 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19dc850d
  28. 10 Dec, 2010 1 commit
    • eric@webkit.org's avatar
      2010-12-09 Eric Seidel <eric@webkit.org> · 6387ef6c
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              The commit-queue should file bugs about flaky tests it encounters
              https://bugs.webkit.org/show_bug.cgi?id=50803
      
              This change got a bit big.  I also added a new config.urls file
              because I needed to share the view_source_url code with committervalidator.py.
      
              This adds a new class FlakyTestReporter which holds all the logic about
              reporting flaky tests to bugzilla.
      
              Right now this code knows how to look up bugs for flaky tests.
              If it can't find a bug filed from the commit-queue, it will open a new
              one, ccing the relevant people and adding information about the failure.
      
              It is not yet smart enough to chase down duplicate chains, or to include
              the actual failure diff.  But those can be added in later iterations.
      
              * Scripts/webkitpy/common/checkout/api.py:
              * Scripts/webkitpy/common/checkout/changelog.py:
              * Scripts/webkitpy/common/checkout/commitinfo.py:
              * Scripts/webkitpy/common/config/committervalidator.py:
              * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
              * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
              * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
              * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
              * Scripts/webkitpy/tool/bot/irc_command.py:
              * Scripts/webkitpy/tool/bot/sheriff.py:
              * Scripts/webkitpy/tool/commands/download.py:
              * Scripts/webkitpy/tool/commands/queues.py:
              * Scripts/webkitpy/tool/commands/queues_unittest.py:
              * Scripts/webkitpy/tool/comments.py:
              * Scripts/webkitpy/tool/mocktool.py:
              * Scripts/webkitpy/tool/steps/commit.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6387ef6c
  29. 09 Nov, 2010 1 commit
  30. 28 Oct, 2010 1 commit
    • eric@webkit.org's avatar
      2010-10-28 Eric Seidel <eric@webkit.org> · ab8093ac
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              webkit-patch upload calls changed_files more often than it should
              https://bugs.webkit.org/show_bug.cgi?id=48567
      
              Passing changed_files around everywhere isn't a very elegant solution
              but it's the one we have for the moment.  I think keeping an explicit
              cache on Checkout (or making StepState() a real class) is a better
              long-term option.
      
              Previously bug_id_for_this_commit was calling changed_files and the
              result was never getting cached on the state.  Now we're explicitly
              caching the result on the state and passing that to the bug_id_for_this_commit call.
      
              I looked into building unit tests for this.  Doing so would require
              using a real Checkout object with a MockSCM and overriding the appropriate
              calls on SCM to count how often we're stating the file system.
              That's a useful set of tests to build for a separate change.
      
              * Scripts/webkitpy/common/checkout/api.py:
              * Scripts/webkitpy/tool/commands/download.py:
              * Scripts/webkitpy/tool/commands/upload.py:
              * Scripts/webkitpy/tool/mocktool.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70820 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab8093ac
  31. 26 Oct, 2010 1 commit
    • eric@webkit.org's avatar
      2010-10-26 Eric Seidel <eric@webkit.org> · ad1dd2d4
      eric@webkit.org authored
              Reviewed by Ojan Vafai.
      
              Remove rietveld code now that it's unused
              https://bugs.webkit.org/show_bug.cgi?id=48359
      
              Was cool that we added this support, but now that it's
              not used it makes little sense to keep it around.
              We can always restore this code from SVN if we need it.
      
              * Scripts/webkitpy/common/config/__init__.py:
              * Scripts/webkitpy/common/net/bugzilla.py:
              * Scripts/webkitpy/common/net/bugzilla_unittest.py:
              * Scripts/webkitpy/common/net/rietveld.py: Removed.
              * Scripts/webkitpy/common/net/rietveld_unittest.py: Removed.
              * Scripts/webkitpy/thirdparty/__init__.py:
              * Scripts/webkitpy/tool/commands/download.py:
              * Scripts/webkitpy/tool/commands/download_unittest.py:
              * Scripts/webkitpy/tool/commands/queues.py:
              * Scripts/webkitpy/tool/commands/queues_unittest.py:
              * Scripts/webkitpy/tool/main.py:
              * Scripts/webkitpy/tool/mocktool.py:
              * Scripts/webkitpy/tool/steps/__init__.py:
              * Scripts/webkitpy/tool/steps/postcodereview.py: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70570 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad1dd2d4
  32. 13 Oct, 2010 1 commit
    • abarth@webkit.org's avatar
      2010-10-13 Adam Barth <abarth@webkit.org> · 2a96b429
      abarth@webkit.org authored
              Reviewed by Csaba Osztrogonác.
      
              webkit-patch build shouldn't need --build to actually build!
              https://bugs.webkit.org/show_bug.cgi?id=47438
      
              Yeah, requiring --build for the build command is really dumb.  We did
              this originally because the build step is usually optional in other
              commands.  We don't have a good way of reversing the default for an
              option in one command.  This approach is slightly hacky since --build
              still shows up as an option on the help page, but at least it makes
              progress.  Passing --build is harmless, so the EWS bots shouldn't
              explode because of this change.
      
              * Scripts/webkitpy/tool/bot/commitqueuetask.py:
              * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
              * Scripts/webkitpy/tool/commands/download.py:
              * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
              * Scripts/webkitpy/tool/commands/queues_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a96b429
  33. 08 Oct, 2010 1 commit
  34. 28 Sep, 2010 2 commits
    • dbates@webkit.org's avatar
      2010-09-28 Daniel Bates <dbates@rim.com> · 7da4f210
      dbates@webkit.org authored
              Rollout changeset 68493 <http://trac.webkit.org/changeset/68493>
              <https://bugs.webkit.org/show_bug.cgi?id=39136>
      
              Rollout changeset 68493 because it broke Sheriffbot's rollout feature.
              In particular, this change caused Sheriffbot to raise an exception when
              trying to parse the bug id on a bug page. We need to look into this
              some more.
      
              * Scripts/webkitpy/common/net/bugzilla.py:
              * Scripts/webkitpy/common/net/bugzilla_unittest.py:
              * Scripts/webkitpy/tool/bot/sheriff.py:
              * Scripts/webkitpy/tool/commands/download.py:
              * Scripts/webkitpy/tool/commands/queues.py:
              * Scripts/webkitpy/tool/commands/upload.py:
              * Scripts/webkitpy/tool/steps/closebug.py:
              * Scripts/webkitpy/tool/steps/obsoletepatches.py:
              * Scripts/webkitpy/tool/steps/preparechangelog.py:
              * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68496 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7da4f210
    • dbates@webkit.org's avatar
      2010-09-27 Daniel Bates <dbates@rim.com> · 77ddff29
      dbates@webkit.org authored
              Reviewed by Adam Barth.
      
              sheriffbot can't roll out security patches
              https://bugs.webkit.org/show_bug.cgi?id=39136
      
              Make SheriffBot determine if it's authorized to view a bug
              whose change it wants to rollout before it tries to rollout
              the change.
      
              Moreover, make both webkit-patch and Sheriffbot provide human-
              readable error messages when they are not authorized to view
              a bug and when a bug number is invalid.
      
              Currently, Sheriffbot does not parse Bugzilla bugs for
              <bug error="...">, which indicates an error when retrieving
              a bug. In particular, error="NotPermitted" if a person (or bot)
              is not authorized to view a bug. For such error="NotPermitted" bugs,
              Sheriffbot raises an exception when parsing the bug report and
              this exception does not explicitly indicate Sheriffbot's lack
              of authorization. Instead, Sheriffbot should explicitly check
              for the presence <bug error="..."> before operating on a bug
              and error with a human-readable message if it's not permitted
              to view it.
      
              * Scripts/webkitpy/common/net/bugzilla.py: Added BugzillaError class.
              * Scripts/webkitpy/common/net/bugzilla_unittest.py:
                - Added unit test test_bug_parsing_for_bugzilla_not_permitted_error().
                - Added unit test test_bug_parsing_for_bugzilla_not_found_error().
                - Added unit test test_bug_parsing_for_bugzilla_invalid_bug_id_error().
              * Scripts/webkitpy/tool/bot/sheriff.py: Modified to catch BugzillaError.
              * Scripts/webkitpy/tool/commands/download.py: Ditto.
              * Scripts/webkitpy/tool/commands/queues.py: Ditto.
              * Scripts/webkitpy/tool/commands/upload.py: Ditto.
              * Scripts/webkitpy/tool/steps/closebug.py: Ditto.
              * Scripts/webkitpy/tool/steps/obsoletepatches.py: Ditto.
              * Scripts/webkitpy/tool/steps/preparechangelog.py: Ditto.
              * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68493 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77ddff29
  35. 20 Sep, 2010 1 commit
    • abarth@webkit.org's avatar
      2010-09-20 Adam Barth <abarth@webkit.org> · 17059c3e
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              The tool member variable should be called _tool
              https://bugs.webkit.org/show_bug.cgi?id=46160
      
              Created by find-and-replace.
      
              * Scripts/webkitpy/tool/commands/download.py:
              * Scripts/webkitpy/tool/commands/openbugs.py:
              * Scripts/webkitpy/tool/commands/queries.py:
              * Scripts/webkitpy/tool/commands/queues.py:
              * Scripts/webkitpy/tool/commands/queues_unittest.py:
              * Scripts/webkitpy/tool/commands/rebaseline.py:
              * Scripts/webkitpy/tool/commands/sheriffbot.py:
              * Scripts/webkitpy/tool/commands/upload.py:
              * Scripts/webkitpy/tool/multicommandtool.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67916 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17059c3e
  36. 14 Sep, 2010 1 commit
    • abarth@webkit.org's avatar
      2010-09-14 Adam Barth <abarth@webkit.org> · af575f47
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              commit-queue is slow during the day
              https://bugs.webkit.org/show_bug.cgi?id=45780
      
              Thanks to the new logging, we've noticed that checkout-is-out-of-date
              errors in the first pass of landing don't retry the land.  Instead,
              they're treated as failures and cause the commit-queue to do two more
              builds before really trying to land the patch.  Worse, in the second
              build, we can get bitten by a flaky test.
      
              This patch takes a slightly different approach to the commit-queue's
              main control logic.  We now use a separate subprocess for building and
              testing and for landing.  This means we should very rarely see the
              checkout-is-out-of-date error, and when we do see it, we should retry
              more quickly.  If my understanding is correct, this should be a big
              speed win for the commit-queue.
      
              * Scripts/webkitpy/tool/commands/download.py:
              * Scripts/webkitpy/tool/commands/queues.py:
              * Scripts/webkitpy/tool/commands/queues_unittest.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af575f47
  37. 09 Jul, 2010 1 commit
    • ojan@chromium.org's avatar
      2010-07-09 Ojan Vafai <ojan@chromium.org> · 357592e0
      ojan@chromium.org authored
              Reviewed by Adam Barth.
      
              --squash should go away and become the default
              https://bugs.webkit.org/show_bug.cgi?id=39624
      
              If there are local commits and working copy changes, then prompt the user
              whether to continue. Setting git config webkit-patch.commit_should_always_squash
              true bypasses the prompt.
      
              --git-commit=HEAD.. operates on working copy changes only.
              --git-commit=committish operates on a range of commits as a single commit.
                  e.g. --git-commit=HEAD only operates on the HEAD commit.
                  --git-commit=HEAD~4..HEAD~2 will operate on HEAD~3 and HEAD~2 as a single commit.
      
              --no-squash and --squash are left in with descriptive error messages if used.
      
              * Scripts/check-webkit-style:
              * Scripts/webkitpy/common/checkout/api.py:
              * Scripts/webkitpy/common/checkout/api_unittest.py:
              * Scripts/webkitpy/common/checkout/scm.py:
              * Scripts/webkitpy/common/checkout/scm_unittest.py:
              * Scripts/webkitpy/common/net/rietveld.py:
              * Scripts/webkitpy/common/system/user.py:
              * Scripts/webkitpy/style/optparser.py:
              * Scripts/webkitpy/style_references.py:
              * Scripts/webkitpy/tool/commands/download.py:
              * Scripts/webkitpy/tool/commands/upload.py:
              * Scripts/webkitpy/tool/mocktool.py:
              * Scripts/webkitpy/tool/steps/abstractstep.py:
              * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
              * Scripts/webkitpy/tool/steps/checkstyle.py:
              * Scripts/webkitpy/tool/steps/checkstyle_unittest.py: Removed.
              * Scripts/webkitpy/tool/steps/commit.py:
              * Scripts/webkitpy/tool/steps/options.py:
              * Scripts/webkitpy/tool/steps/preparechangelog.py:
              * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
              * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
              * Scripts/webkitpy/tool/steps/validatereviewer.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63004 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      357592e0
  38. 30 Jun, 2010 1 commit