- 29 Sep, 2007 3 commits
-
-
zecke authored
2007-09-29 Holger Hans Peter Freyther <zecke@selfish.org> Reviewed by Mark. -Fix http://bugs.webkit.org/show_bug.cgi?id=13226. Remove Bakefiles from svn. * Bakefiles/Bakefiles.bkgen: Removed. * Bakefiles/ChangeLog: Removed. * Bakefiles/Readme.txt: Removed. * Bakefiles/presets.bkl: Removed. * Bakefiles/update-file-lists.py: Removed. JavaScriptCore: 2007-09-29 Holger Hans Peter Freyther <zecke@selfish.org> Reviewed by Mark. -Fix http://bugs.webkit.org/show_bug.cgi?id=13226. Remove Bakefiles from svn. * JavaScriptCoreSources.bkl: Removed. * jscore.bkl: Removed. WebCore: 2007-09-29 Holger Hans Peter Freyther <zecke@selfish.org> Reviewed by Mark. -Fix http://bugs.webkit.org/show_bug.cgi?id=13226. Remove Bakefiles from svn. * Projects/gdk/webcore-gdk.bkl: Removed. * Projects/wx/webcore-wx.bkl: Removed. * WebCoreSources.bkl: Removed. * webcore-base.bkl: Removed. WebKitTools 2007-09-29 Holger Hans Peter Freyther <zecke@selfish.org> Reviewed by Mark. -Fix http://bugs.webkit.org/show_bug.cgi?id=13226. Remove Bakefiles from svn. * GtkLauncher/Bakefiles.bkgen: Removed. * GtkLauncher/ENV: Removed. * GtkLauncher/gdklauncher.bkl: Removed. * GtkLauncher/mk: Removed. * Scripts/regenerate-makefiles: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25808 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zecke authored
Reviewed by Mark. -Fix http://bugs.webkit.org/show_bug.cgi?id=15254. * platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::determineState): - Apply state if control is readonly - Added state GTK_STATE_SELECTED of object is checked - Apply GTK_STATE_ACTIVE if RenderObject isFocused() (WebCore::RenderThemeGtk::paintTextField): (WebCore::RenderThemeGtk::gtkEntry): - Implemented theme-aware text field based on gtk/gtkentry.c implementation git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25807 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zecke authored
Reviewed by Eric. Build fix for Mac Gtk+ and Qt builds. In revision 25798 changing XSLTProcessor.cpp was forgotten. * xml/XSLTProcessor.cpp: Use PLATFORM(MAC) instead of PLATFORM(DARWIN) git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 28 Sep, 2007 8 commits
-
-
rdar://4965715aroben authored
Reviewed by Sam. No regression test possible. * platform/win/WheelEventWin.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent): Use a negative delta when scrolling right to match EventHandler's expectations (which are based on AppKit). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25803 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bdash authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25801 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kdecker authored
Build fix for Mac Gtk+ and Qt builds. * xml/XSLStyleSheet.cpp: Use PLATFORM(MAC) instead of PLATFORM(DARWIN) * xml/XSLTExtensions.cpp: Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
harrison authored
<rdar://problem/5511128> Crash closing or reloading this SVG * dom/ContainerNode.cpp: (WebCore::dispatchChildInsertionEvents): (WebCore::dispatchChildRemovalEvents): Use DocPtr instead of RefPtr, since these events are dispatched when the Document is being being torn down by removedLastRef(). * dom/DocPtr.h: (WebCore::DocPtr::DocPtr): Fix longstanding typo in template so that the DocPtr(DocPtr) constructor can be used. * dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::removedLastRef): * dom/Document.h: (WebCore::Document::selfOnlyRef): (WebCore::Document::selfOnlyDeref): * platform/Shared.h: (WebCore::Shared::Shared): (WebCore::Shared::ref): (WebCore::Shared::deref): (WebCore::Shared::hasOneRef): (WebCore::TreeShared::TreeShared): (WebCore::TreeShared::ref): (WebCore::TreeShared::deref): (WebCore::TreeShared::hasOneRef): (WebCore::TreeShared::refCount): Add debug-only checks for a document being ref-counted while being deleted. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kmccullo authored
Reviewed by Darin. - <rdar://5261371> Nothing downloaded when exporting bookmarks from iGoogle web history - Implemented IWebHTTPURLResponse::allHeaderFields so that if the content disposition is "attachment" we will download the file instead of display it. Also implemented some missing functionality. * platform/network/ResourceResponse.cpp: (WebCore::ResourceResponse::isAttachment): * platform/network/ResourceResponse.h: win: Reviewed by Darin. - <rdar://5261371> Nothing downloaded when exporting bookmarks from iGoogle web history - Implemented IWebHTTPURLResponse::allHeaderFields so that if the content disposition is "attachment" we will download the file instead of display it. Also implemented some missing functionality. * HTTPHeaderPropertyBag.cpp: Added. (HTTPHeaderPropertyBag::HTTPHeaderPropertyBag): (HTTPHeaderPropertyBag::createInstance): (HTTPHeaderPropertyBag::setResponse): (HTTPHeaderPropertyBag::response): (HTTPHeaderPropertyBag::QueryInterface): (HTTPHeaderPropertyBag::AddRef): (HTTPHeaderPropertyBag::Release): (ConvertFromLPCOLESTR): (ConvertToVariant): (ConvertFromVariant): (HTTPHeaderPropertyBag::Read): (HTTPHeaderPropertyBag::Write): * HTTPHeaderPropertyBag.h: Added. * Interfaces/IWebHTTPURLResponse.idl: * WebKit.vcproj/WebKit.vcproj: * WebURLResponse.cpp: (WebURLResponse::allHeaderFields): (WebURLResponse::isAttachment): * WebURLResponse.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zecke authored
Reviewed by Anders. Implement PopupMenu using GtkMenu. * platform/PopupMenu.h: * platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement): (WebCore::PopupMenu::itemWritingDirectionIsNatural): (WebCore::PopupMenu::menuItemActivated): (WebCore::PopupMenu::menuUnmapped): (WebCore::PopupMenu::menuPositionFunction): (WebCore::PopupMenu::menuRemoveItem): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25795 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zecke authored
Rubber stamped by Mark. Obey the Coding-Style and move the asterisk to the left to be part of the type. * platform/gtk/RenderThemeGtk.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25794 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
antti authored
Use frames instead windows for these tests. Closing windows reliably is difficult in DRT. * http/tests/security/resources/has-custom-property.html: * http/tests/security/resources/no-custom-property.html: * http/tests/security/window-properties-clear-domain-expected.txt: * http/tests/security/window-properties-clear-domain.html: * http/tests/security/window-properties-clear-port-expected.txt: * http/tests/security/window-properties-clear-port.html: * http/tests/security/window-properties-pass-expected.txt: * http/tests/security/window-properties-pass.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25793 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 27 Sep, 2007 19 commits
-
-
sullivan authored
- fixed <rdar://problem/5408186> REGRESSION (5522-5523.9): Safari leaks every browser window The leak started occurring when we removed the code to clear the delegates and the host window from Safari as part of the fix for 5479443. But it turns out that Safari code was masking a bug here in WebView: setHostWindow:nil needs to be called before setting _private->closed to YES, or it will do nothing at all, causing a world leak due to a circular reference between the window and the WebView. I toyed with a more complex fix, but this is the simplest one that retains the fix for 5479443 while otherwise restoring the code order to be as close as possible to what it was before 5479443 was fixed. * WebView/WebView.mm: (-[WebView _close]): Moved the call that sets _private->closed to YES to be after the code that clears the delegates and the host window. Added a comment about this order. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
sfalken authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25791 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
sfalken authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
antti authored
Update tests to hopefully fix occasional failures * fast/dom/Window/window-early-properties.html: * http/tests/security/resources/has-custom-property.html: * http/tests/security/resources/no-custom-property.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25789 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bdash authored
Reviewed by Dave Hyatt. - fix http://bugs.webkit.org/show_bug.cgi?id=15262 REGRESSION: Margin-top:18px is pushing down the multiple select list box outside the div. Reflected in existing tests. * css/html4.css: Changed listboxes to use border-box sizing, to match Firefox, WinIE and apparently also Safari 2. 2007-09-27 Mitz Pettel <mitz@webkit.org> Reviewed by Dave Hyatt. - updated tests and results for http://bugs.webkit.org/show_bug.cgi?id=15262 REGRESSION: Margin-top:18px is pushing down the multiple select list box outside the div. * fast/forms/listbox-clip-expected.checksum: * fast/forms/listbox-clip-expected.png: * fast/forms/listbox-clip-expected.txt: * fast/forms/listbox-selection-2.html: * fast/forms/select-item-background-clip.html: * fast/forms/select-list-box-with-height-expected.checksum: * fast/forms/select-list-box-with-height-expected.png: * fast/forms/select-list-box-with-height-expected.txt: * fast/text/drawBidiText.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25788 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kdecker authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25787 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kdecker authored
<rdar://problem/5493093> * JavaScriptCore.order: Added. * JavaScriptCore.xcodeproj/project.pbxproj: We're changing from using an order file built by another team to using one we actually check into our project repository. Linker settings for Symbol Ordering Flags have been updated accordingly. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rdar://problem/5493093kdecker authored
Rubber stamped by John Sullivan. * WebCore.order: Added. * WebCore.xcodeproj/project.pbxproj: We're changing from using an order file built by another team to using one we actually check into our project repository. Linker settings for Symbol Ordering Flags have been updated accordingly. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25785 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rdar://problem/5507481adachan authored
app that WebView has painted. Reviewed by Steve. * Interfaces/IWebUIDelegatePrivate.idl: * WebView.cpp: (WebView::updateBackingStore): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
antti authored
Reviewed by Geoff. Fix for <rdar://problem/5499125> REGRESSION (r21367): After launching Kidzui beta, a webview frame fails to appear in its main window If window object properties were modified when it had initial empty document (synchronously after window.open() for example) those modifications were lost when the real document was switched in. Match Firefox behavior where window properties are not cleared if the inital document and the loaded one have matching security domains. Tests: fast/dom/Window/window-early-properties.html http/tests/security/window-properties-clear-domain.html http/tests/security/window-properties-clear-port.html http/tests/security/window-properties-pass.html * WebCore.exp: * loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::isSecureTransition): (WebCore::FrameLoader::begin): * loader/FrameLoader.h: If we are transitioning from initial empty document to the final one, do a domain security check between old security policy URL and new URL. If that passes don't clear script proxy and script objects. * bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::updateDocumentWrapper): * bindings/js/kjs_proxy.h: * page/Frame.cpp: (WebCore::Frame::setDocument): Since we don't always clear window properties anymore, we need to update the document property to point to the newly created one. LayoutTests: Reviewed by Geoff. Tests for <rdar://problem/5499125> REGRESSION (r21359-21368): After launching Kidzui beta, a webview frame fails to appear in its main window * fast/dom/Window/window-early-properties-expected.txt: Added. * fast/dom/Window/window-early-properties.html: Added. * http/tests/security/resources/has-custom-property.html: Added. * http/tests/security/resources/no-custom-property.html: Added. * http/tests/security/window-properties-clear-domain-expected.txt: Added. * http/tests/security/window-properties-clear-domain.html: Added. * http/tests/security/window-properties-clear-port-expected.txt: Added. * http/tests/security/window-properties-clear-port.html: Added. * http/tests/security/window-properties-pass-expected.txt: Added. * http/tests/security/window-properties-pass.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25783 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kdecker authored
<rdar://problem/5493093> * WebKit.order: Added. * WebKit.xcodeproj/project.pbxproj: Altered build settings to use the new order file project instead of AppleInternal. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kdecker authored
<rdar://problem/5493093> * WebCore.xcodeproj/project.pbxproj: Removed libxslt from statically linked frameworks. * platform/mac/SoftLinking.h: Formatting tweakes, added SOFT_LINK_LIBRARY, and if'def for PLATFORM(DARWIN) * xml/XSLStyleSheet.cpp: Soft-linked libxslt. * xml/XSLTExtensions.cpp: Removed the call to xsltGenericError, and added a FIXME comment stating that it might be helpful to push any errors from xmlXPathNewValueTree up to the Javascript Console. * xml/XSLTProcessor.cpp: Soft-linked libxslt. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25781 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kmccullo authored
- Updating leopard leak list to refelct bugs that have been fixed and no longer leak. * Scripts/run-webkit-tests: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25780 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
adele authored
Fix for <rdar://problem/5453350> REGRESSION (r18541, Tiger only): Refreshing a cached https page does not reload CSS and JavaScript resources http://bugs.webkit.org/show_bug.cgi?id=15121 * loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest): Now sets the cache policy to ReloadIgnoringCacheData. Without setting the cache policy, the default policy in this case was ReturnCacheDataElseLoad. If we're in a situation where the resource is in the cache, we want to make sure to avoid loading from the cache in this case. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25779 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
thatcher authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
thatcher authored
<rdar://problem/5199546> CrashTracer: [REGRESSION] 8216 crashes in Safari at com.apple.WebCore: WebCore::ResourceHandle::client const + 6 On Tiger CFURLConnection can sometimes call the connection:willCacheResponse: delegate method on a secondary thread instead of the main thread. This was never an issue before, since the implementation of this method was very simple and thread safe. The fix is to block during connection:willCacheResponse: and perform the work on the main thread. We need to block since this delegate method needs to return a result. If we are already on the main thread (which sometimes we are), the method does nothing different. If we are on a secondary thread, we make a mutable dictionary to hold all the arguments and later the result object. Then performSelectorOnMainThread:withObject: using the _callConnectionWillCacheResponseWithInfo: selector. This new method just pulls the arguments out for the dictionary and calls the real connection:willCacheResponse: delegate method (this time on the main thread). The result is stored in the dictionary, and when performSelectorOnMainThread:withObject: finishes the result is pulled out and returned. * platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate _callConnectionWillCacheResponseWithInfo:]): (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig authored
the resulting binary differs when built on Tiger. * libWebKitSystemInterface.a: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
* WebKitSystemInterface.h: * libWebKitSystemInterface.a: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25775 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
to support @font-face. Reviewed by john * platform/mac/FontDataMac.mm: (WebCore::FontData::platformInit): (WebCore::FontData::platformWidthForGlyph): * platform/mac/WebCoreSystemInterface.h: * platform/mac/WebCoreSystemInterface.mm: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25774 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 26 Sep, 2007 10 commits
-
-
aroben authored
Reviewed by NOBODY. * platform/win/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bdash authored
Qt build fix. * WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::objectContentType): Check for empty URL instead of invalid URL. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25772 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bdash authored
Gtk build fix. * WebCoreSupport/FrameLoaderClientGtk.cpp: Check for empty URL instead of invalid URL. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25771 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
* platform/win/ClipboardWin.cpp: (WebCore::writeURL): Add a check for empty URL. Remove the check for invalid URL. (WebCore::ClipboardWin::setData): Remove the check for invalid URL. * plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::start): Check for empty URL instead of invalid URL. (WebCore::PluginViewWin::load): Same here. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25770 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
- fix <rdar://problem/5491054> REGRESSION (Mail, plain-text only): Nothing happens when you click on rdar://<num>&<num> links (or AOL links in Safari) Remove the non-useful concept of a "malformed"/"invalid" URL. There are URLs we can parse, and others we can't, but that's not sufficient to determine if we should try to work with the URL. It's entirely possible that a so-called "malformed" URL will work just fine if it's passed to the right software. * platform/KURL.h: Removed isMalformed() and isValid(). * loader/Cache.cpp: (WebCore::Cache::requestResource): Removed unneeded check if the URL is valid. But do check for an empty URL just to guarantee we don't trip up with a null string. It's possible we can remove this empty URL check later, but it's less risky to leave the empty string behavior alone for now. * loader/FrameLoader.cpp: (WebCore::FrameLoader::urlSelected): Removed unneeded check if the URL is valid. Back on 2007-07-08, we realized that we needed to allow empty URLs. But we also need to allow other URLs here. This is the code path from the Mail case. (WebCore::FrameLoader::submitForm): Replaced URL validity check with a check for an empty URL (same reasoning as for requestResource above). * page/InspectorController.cpp: (WebCore::InspectorResource::type): * rendering/RenderObject.cpp: (WebCore::RenderObject::addPDFURLRect): Removed unneeded check for an invalid URL. In both of these cases it's definitely safe to allow event an empty URL. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25769 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren authored
Fixed <rdar://problem/5507476> Promote cache model SPI to API Promoted cache model SPI to API. This was just a move, with some small edits to the documentation (changing 'application' to 'WebView' in some cases, since the interface is now per-WebView). * WebView/WebPreferences.h: * WebView/WebPreferences.m: (-[WebPreferences setCacheModel:]): (-[WebPreferences cacheModel]): * WebView/WebPreferencesPrivate.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben authored
Reviewed by NOBODY. * platform/win/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben authored
Oh, Visual Studio, why don't you see when a project file has changed that the project needs to be rebuilt? git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25765 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben authored
Rubberstamped by Anders. * JavaScriptCore.vcproj/testkjs/testkjs.vcproj: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25764 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben authored
What really matters is that we are able to load WebKit and its dependencies, not whether we think we've found an installed WebKit. Reviewed by Sam. * WebKitInitializer/WebKitInitializer.cpp: (getWebViewCLSID): Use new LOG_WARNING macro. (getInstalledWebKitDirectory): Ditto. (initializeWebKit): Don't die if we didn't find an installed WebKit, and use new macros. * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25763 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-