1. 02 Jan, 2013 40 commits
    • esprehn@chromium.org's avatar
      Clean up dispatchEvent overrides and overloads · f53e9e37
      esprehn@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105959
      
      Reviewed by Adam Barth.
      
      Add OVERRIDE to all dispatchEvent overrides and use "using" instead of
      reimplementing EventTarget::dispatchEvent in subclasses where having the
      virtual override of dispatchEvent hides the overloads in
      the superclass.
      
      No new tests, just refactoring.
      
      * Modules/indexeddb/IDBDatabase.h:
      (IDBDatabase):
      * Modules/indexeddb/IDBOpenDBRequest.h:
      (IDBOpenDBRequest):
      * Modules/indexeddb/IDBRequest.h:
      (IDBRequest):
      * Modules/indexeddb/IDBTransaction.h:
      (IDBTransaction):
      * dom/EventDispatchMediator.h:
      (FocusEventDispatchMediator):
      (BlurEventDispatchMediator):
      * dom/GestureEvent.h:
      (GestureEventDispatchMediator):
      * dom/KeyboardEvent.h:
      (KeyboardEventDispatchMediator):
      * dom/MouseEvent.h:
      * dom/Node.h:
      (Node):
      * dom/UIEvent.h:
      (FocusInEventDispatchMediator):
      (FocusOutEventDispatchMediator):
      * dom/WheelEvent.h:
      (WheelEventDispatchMediator):
      * html/HTMLMediaElement.h:
      * html/track/TextTrackCue.cpp:
      * html/track/TextTrackCue.h:
      (TextTrackCue):
      * page/DOMWindow.h:
      (DOMWindow):
      * svg/SVGElementInstance.h:
      (SVGElementInstance):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f53e9e37
    • pilgrim@chromium.org's avatar
      [Chromium] Add Platform/chromium to include_dirs · ab084b16
      pilgrim@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105955
      
      Reviewed by James Robinson.
      
      Currently the headers in WebKit/chromium/public/Web*.h can not
      include headers from the new Platform/chromium/ directory with the
      "#include <public/WebFoo.h>" syntax, because the include_dirs for
      dependent builds (like Chromium-within-WebKit) do not include the
      new Platform/chromium/ directory. This patch adds that capability
      without managing to break anything else.
      
      * WebKit.gyp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab084b16
    • dgrogan@chromium.org's avatar
      IndexedDB: Surface a few more leveldb errors. · ba1679ff
      dgrogan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105670
      
      Reviewed by Tony Chang.
      
      Two calls to old LevelDBTransaction::get slipped through the cracks.
      
      * Modules/indexeddb/IDBBackingStore.cpp:
      (WebCore::IndexKeyCursorImpl::loadCurrentRow):
      (WebCore::IndexCursorImpl::loadCurrentRow):
        Make these two functions use safeGet instead of get.
      
      * platform/leveldb/LevelDBTransaction.cpp:
      * platform/leveldb/LevelDBTransaction.h:
        Remove get now that it is unused.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba1679ff
    • fpizlo@apple.com's avatar
      DFG inlining machinery should be robust against the inline callee varying... · 439e9e55
      fpizlo@apple.com authored
      DFG inlining machinery should be robust against the inline callee varying while the executable stays the same
      https://bugs.webkit.org/show_bug.cgi?id=105953
      
      Reviewed by Mark Hahnenberg.
              
      This institutes the policy that if InlineCallFrame::callee is null, then the callee and scope have already
      been stored into the true call frame (i.e. the place where the call frame of the inlined call would have
      been) and so any attempt to access the callee or scope should do a load instead of assuming that the value
      is constant. This wires the changes through the bytecode parser, the stack scanning logic, and the compiler
      optimization phases and backends.
      
      * bytecode/CodeOrigin.cpp:
      (JSC::InlineCallFrame::dump):
      * bytecode/CodeOrigin.h:
      (CodeOrigin):
      (InlineCallFrame):
      (JSC::InlineCallFrame::isClosureCall):
      (JSC::CodeOrigin::stackOffset):
      (JSC):
      * dfg/DFGAssemblyHelpers.h:
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::get):
      (InlineStackEntry):
      (JSC::DFG::ByteCodeParser::getScope):
      (JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
      * dfg/DFGCSEPhase.cpp:
      (CSEPhase):
      (JSC::DFG::CSEPhase::genericPureCSE):
      (JSC::DFG::CSEPhase::pureCSE):
      (JSC::DFG::CSEPhase::pureCSERequiringSameInlineCallFrame):
      (JSC::DFG::CSEPhase::getMyScopeLoadElimination):
      (JSC::DFG::CSEPhase::performNodeCSE):
      * dfg/DFGOSRExitCompiler32_64.cpp:
      (JSC::DFG::OSRExitCompiler::compileExit):
      * dfg/DFGOSRExitCompiler64.cpp:
      (JSC::DFG::OSRExitCompiler::compileExit):
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGSpeculativeJIT64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * interpreter/CallFrame.cpp:
      (JSC::CallFrame::trueCallFrame):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      439e9e55
    • commit-queue@webkit.org's avatar
      When a block's height is determined by min-height/max-height, children with... · ca14f9a9
      commit-queue@webkit.org authored
      When a block's height is determined by min-height/max-height, children with percentage heights are sized incorrectly
      https://bugs.webkit.org/show_bug.cgi?id=26559
      
      Patch by Bem Jones-Bey <bjonesbe@adobe.com> on 2013-01-02
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      Percentage logical height computation now takes into account the min and max height of the container.
      
      Test: fast/block/min-max-height-percent-height-child.html
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::constrainContentBoxLogicalHeightByMinMax): Added. Like constrainLogicalHeightByMinMax,
          but constrains the content box instead of the border box.
      (WebCore):
      (WebCore::RenderBox::computeContentLogicalHeight): Make const so it can be called from the const method
          constrainContentBoxLogicalHeightByMinMax.
      (WebCore::RenderBox::computePercentageLogicalHeight): Use constrainContentBoxLogicalHeightByMinMax to properly
          respect min and max height on the containing box when computing the percentage height.
      * rendering/RenderBox.h:
      (RenderBox):
      
      LayoutTests:
      
      Add tests to ensure percent heights are correctly determined.
      
      * fast/block/min-max-height-percent-height-child-expected.txt: Added.
      * fast/block/min-max-height-percent-height-child.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca14f9a9
    • tony@chromium.org's avatar
      Unreviewed, force InternalSettings.cpp to rebuild to try and fix the Apple Win build. · 6b667f04
      tony@chromium.org authored
      * testing/InternalSettings.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b667f04
    • alecflett@chromium.org's avatar
      IndexedDB: Use non-const buffers in put() to avoid copies · 6a9d2eea
      alecflett@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105572
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Change the new put() method to allow the implementation to consume
      or adopt the vector, to avoid copying.
      
      No new tests as this is an interface change that will be implemented later.
      
      * Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
      (WebCore::IDBDatabaseBackendImpl::put):
      * Modules/indexeddb/IDBDatabaseBackendImpl.h:
      (IDBDatabaseBackendImpl):
      * Modules/indexeddb/IDBDatabaseBackendInterface.h:
      
      Source/WebKit/chromium:
      
      Pass on non-const Vectors to allow buffer adoption rather than copies.
      
      * public/WebIDBDatabase.h:
      (WebIDBDatabase):
      (WebKit::WebIDBDatabase::put):
      * src/IDBDatabaseBackendProxy.cpp:
      (WebKit::IDBDatabaseBackendProxy::put):
      * src/IDBDatabaseBackendProxy.h:
      (IDBDatabaseBackendProxy):
      * src/WebIDBDatabaseImpl.cpp:
      (WebKit::WebIDBDatabaseImpl::put):
      * src/WebIDBDatabaseImpl.h:
      (WebIDBDatabaseImpl):
      * tests/IDBDatabaseBackendTest.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a9d2eea
    • abarth@webkit.org's avatar
      [V8] Remove INC_STATS because it is unused · 8c2b04d5
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105957
      
      Reviewed by Ojan Vafai.
      
      We haven't been able to compile with INC_STATS turned on in a long
      time. This patch just removes this ancient cruft. I generated this
      patch using
      
      find . -type f | xargs sed -i '/INC_STATS/d'
      
      and then fixing up V8BindingMacros.h.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c2b04d5
    • barraclough@apple.com's avatar
      Objective-C API for JavaScriptCore · a56aeb21
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=105889
      
      Reviewed by Geoff Garen.
      
      Fixes for a number of issues raised by Darin.
      
      * API/APIJSValue.h:
          - Fix typos in comment
          - Add newline before NS_CLASS_AVAILABLE(10_9, NA)
          - cls -> expectedClass
          - key type for -setObject:forKeyedSubscript: is now NSObject <NSCopying> *
      * API/JSBase.h:
          - JS_OBJC_API_ENABLED no longer implies __OBJC__
      * API/JSBlockAdaptor.mm:
      (BlockArgumentStruct::BlockArgumentStruct):
      (BlockArgumentStruct):
          - mark virtual functions as virtual, override, and private
          - refactor out buffer allocation for struct types
      (BlockArgumentTypeDelegate::typeVoid):
      (BlockArgumentTypeDelegate::typeBlock):
      (BlockArgumentTypeDelegate::typeStruct):
          - return nil -> return 0
      (BlockResultStruct::BlockResultStruct):
      (BlockResultStruct):
          - mark virtual functions as virtual, override, and private
          - refactor out buffer allocation for struct types
      (buildBlockSignature):
          - %lu is not an appropriate format specifier for NSInteger
      (-[JSBlockAdaptor initWithBlockSignatureFromProtocol:]):
          - nil check [super init]
      (-[JSBlockAdaptor blockMatchesSignature:]):
      (-[JSBlockAdaptor blockFromValue:inContext:withException:]):
          - ctx -> contextRef
      * API/JSContext.h:
          - Fix typos in comment
          - Add newline before NS_CLASS_AVAILABLE(10_9, NA)
          - key type for -setObject:forKeyedSubscript: is now NSObject <NSCopying> *
      * API/JSContext.mm:
      (-[JSContext initWithVirtualMachine:]):
          - nil check [super init]
      (+[JSContext currentArguments]):
          - args -> argumentArray
      (-[JSContext setObject:forKeyedSubscript:]):
          - key type for -setObject:forKeyedSubscript: is now NSObject <NSCopying> *
      (-[JSContext dealloc]):
      (-[JSContext protect:]):
      (-[JSContext unprotect:]):
          - m_protected -> m_protectCounts
      * API/JSValue.mm:
      (-[JSValue toObjectOfClass:]):
          - cls -> expectedClass
      (-[JSValue toBool]):
      (-[JSValue deleteProperty:]):
      (-[JSValue hasProperty:]):
      (-[JSValue isUndefined]):
      (-[JSValue isNull]):
      (-[JSValue isBoolean]):
      (-[JSValue isNumber]):
      (-[JSValue isString]):
      (-[JSValue isObject]):
      (-[JSValue isEqualToObject:]):
      (-[JSValue isEqualWithTypeCoercionToObject:]):
      (-[JSValue isInstanceOf:]):
          - removed ? YES : NO
      (-[JSValue callWithArguments:]):
      (-[JSValue constructWithArguments:]):
      (-[JSValue invokeMethod:withArguments:]):
          - args -> argumentArray
      (+[JSValue valueWithPoint:inContext:]):
      (+[JSValue valueWithRange:inContext:]):
      (+[JSValue valueWithRect:inContext:]):
      (+[JSValue valueWithSize:inContext:]):
          - [NSNumber numberWithFloat:] -> @()
      (-[JSValue objectForKeyedSubscript:]):
      (-[JSValue setObject:forKeyedSubscript:]):
          - key type for -setObject:forKeyedSubscript: is now NSObject <NSCopying> *
      (JSContainerConvertor):
      (JSContainerConvertor::isWorkListEmpty):
      (JSContainerConvertor::convert):
      (ObjcContainerConvertor):
      (ObjcContainerConvertor::isWorkListEmpty):
          - remove WTF::
          - isWorkListEmpty is const
      (objectToValue):
          -  use fast enumeration
      (-[JSValue initWithValue:inContext:]):
          - nil check [super init]
      (getStructTagHandler):
          - m_structHandlers -> structHandlers
      * API/JSVirtualMachine.h:
          - Add newline before NS_CLASS_AVAILABLE(10_9, NA)
      * API/JSVirtualMachine.mm:
      (-[JSVirtualMachine init]):
          - nil check [super init]
      * API/JSWrapperMap.mm:
      (selectorToPropertyName):
      (copyPrototypeProperties):
          - remove WTF::
          - use static_cast
      (-[JSObjCClassInfo initWithContext:forClass:superClassInfo:]):
      (-[JSWrapperMap initWithContext:]):
          - nil check [super init]
      (-[JSWrapperMap wrapperForObject:]):
      (tryUnwrapObjcObject):
          - enable ASSERT
      (getJSExportProtocol):
      (getNSBlockClass):
          - remove if check on initializing static
      * API/JavaScriptCore.h:
          - JS_OBJC_API_ENABLED no longer implies __OBJC__
      * API/ObjCCallbackFunction.mm:
      (CallbackArgumentOfClass):
      (CallbackArgumentOfClass::~CallbackArgumentOfClass):
      (CallbackArgumentStruct::CallbackArgumentStruct):
      (CallbackArgumentStruct):
      (CallbackArgumentBlockCallback):
          - mark virtual functions as virtual, override, and private
          - refactor out buffer allocation for struct types
      (ArgumentTypeDelegate::typeVoid):
      (ArgumentTypeDelegate::typeOfClass):
      (ArgumentTypeDelegate::typeStruct):
          - return nil -> return 0
      (CallbackResultStruct::CallbackResultStruct):
      (CallbackResultStruct):
          - mark virtual functions as virtual, override, and private
          - refactor out buffer allocation for struct types
      (ResultTypeDelegate::typeStruct):
          - return nil -> return 0
      (ObjCCallbackFunction):
          - remove WTF::
      (objCCallbackFunctionFinalize):
          - use static_cast
      (objCCallbackFunctionCallAsFunction):
          - Fix typos in comment
      (createObjCCallbackFunctionClass):
      (objCCallbackFunctionClass):
          - Split out createObjCCallbackFunctionClass from objCCallbackFunctionClass
      (ObjCCallbackFunction::call):
          - ctx -> contextRef
      (blockSignatureContainsClass):
          - Remove tri-state enum.
      (skipNumber):
          - isdigit -> isASCIIDigit 
      (objCCallbackFunctionForInvocation):
          - clean up & comment blockSignatureContainsClass() usage
      (tryUnwrapBlock):
          - use static_cast
      * API/ObjcRuntimeExtras.h:
      (forEachProtocolImplementingProtocol):
      (forEachMethodInClass):
      (forEachMethodInProtocol):
      (forEachPropertyInProtocol):
          - Remove WTF::
          - Remove if (count) checks
      (skipPair):
          - NSUInteger -> size_t
      (StringRange):
      (StringRange::operator const char*):
      (StringRange::get):
      (StructBuffer):
      (StructBuffer::StructBuffer):
      (StructBuffer::~StructBuffer):
      (StructBuffer::operator void*):
          - Added helper for creating an aligned buffer, used by struct conversion invocations.
      (parseObjCType):
          - *(position++) -> *position++
      * API/tests/testapi.c:
          - PLATFORM(MAC) -> JS_OBJC_API_ENABLED
      * API/tests/testapi.m:
      (blockSignatureContainsClass):
          - Remove tri-state enum.
      (testObjectiveCAPI):
          - Added more result type checks.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a56aeb21
    • rniwa@webkit.org's avatar
      Add a failing test expectation to a test added by r136697. · 501a7956
      rniwa@webkit.org authored
      The failure is tracked by the bug 105960.
      
      * platform/mac-wk2/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      501a7956
    • rniwa@webkit.org's avatar
      Add a failing test expectations to a test added by r132411. · c81fb952
      rniwa@webkit.org authored
      The patch updated DumpRenderTree but didn't update WebKitTestRunner.
      The failure is tracked by the bug 105958.
      
      * platform/mac-wk2/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c81fb952
    • tony@chromium.org's avatar
      Generate internal.settings from Settings.in · a35bd277
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104740
      
      Reviewed by Adam Barth.
      
      .:
      
      * Source/cmake/WebKitMacros.cmake: Specify additional output files from make_settings.pl.
      
      Source/WebCore:
      
      If the setting is declared in Settings.in and is a basic type, generate a
      setter function at internals.settings.
      
      InternalSettingsGenerated.idl is created by make_settings.pl. InternalSettings.idl
      inherits from InternalSettingsGenerated.idl so we can override generated functions if
      needed or add additional custom setters.
      
      This patch removes 2 password echo methods from InternalSettings.idl since they are
      auto generated. There are other methods we could remove, but I'll do that in a followup.
      
      No new tests, existing tests should pass. Specifically, editing/input/password* tests should pass.
      
      * CMakeLists.txt: Add generated cpp file to the testing lib.
      * DerivedSources.make: Add generated idl file and specify all the outputs of make_settings.pl
      * DerivedSources.pri: Generate idl file before generating bindings and include generated idl
      for bindings generation.
      * GNUmakefile.am: Specify all the generated files of make_settings.pl. Add generated idl to
      list of files to be processed and resulting output to be compiled.
      * UseJSC.cmake: Add generated idl file to list of idl files to process.
      * UseV8.cmake: Same as UseJSC.cmake.
      * WebCore.gyp/WebCore.gyp: Run make_settings.pl earlier so we can run the output through the
      bindings generator.
      * WebCore.gypi: Add new files.
      * WebCore.vcproj/WebCoreTestSupport.vcproj: Add new files.
      * WebCore.xcodeproj/project.pbxproj: Add new files.
      * bindings/scripts/CodeGenerator.pm:
      (IDLFileForInterface): Add current directory to the include path so DerivedSources.make can
      find the generated idl file.
      * page/make_settings.pl:
      (generateCode): Generate InternalSettingsGenerated.{idl,h,cpp}.
      (generateSettingsMacrosHeader): Rename since we're generating 2 headers now.
      (setterFunctionName): Helper function for naming a setter.
      (printGetterAndSetter): Use setterFunctionName.
      (enumerateParsedItems): Helper function that visits each parsed item.
      (generateInternalSettingsIdlFile): Generate idl file.
      (generateInternalSettingsHeaderFile): Generate header file.
      (generateInternalSettingsCppFile): Generate C++ file.
      * testing/InternalSettings.cpp:
      (WebCore::InternalSettings::Backup::Backup): Remove password echo members.
      (WebCore::InternalSettings::Backup::restoreTo): Remove password echo members.
      (InternalSettingsWrapper): We can't use RefCountedSupplemental because we're we're already
      RefCounted. Create a wrapper class to wrap the RefCounted InternalSettings for Supplement<>::provideTo,
      which uses an OwnPtr.
      (WebCore::InternalSettingsWrapper::InternalSettingsWrapper): Wraps an InternalSettings that the Page can own.
      (WebCore::InternalSettingsWrapper::~InternalSettingsWrapper): Clear's m_page when the Page goes away.
      (WebCore::InternalSettingsWrapper::internalSettings): Unwrap InternalSettings.
      (WebCore::InternalSettings::from): Update to use InternalSettingsWrapper.
      (WebCore::InternalSettings::InternalSettings): Call base class constructor.
      (WebCore::InternalSettings::resetToConsistentState): Renamed from reset() and pass through to base class.
      Also remove unnecessary pageScaleFactor reset (done in Internals::resetToConsistentState).
      * testing/InternalSettings.h:
      (Backup): Remove password echo members.
      (WebCore::InternalSettings::create): Create an instance instead of using new.
      (WebCore::InternalSettings::hostDestroyed): Clear the page. This is similar to the code that
      RefCountedSupplemental has.
      * testing/InternalSettings.idl: Extends InternalSettingsGenerated.
      * testing/js/WebCoreTestSupport.cpp:
      (WebCoreTestSupport::resetInternalsObject): Rename to resetToConsistentState to be like other code.
      * testing/v8/WebCoreTestSupport.cpp:
      (WebCoreTestSupport::resetInternalsObject): Rename to resetToConsistentState to be like other code.
      Remove an unused header.
      
      Tools:
      
      * GNUmakefile.am: Compile new generated files on GTK+.
      * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
      with both extra_sources and add_output_to_sources=false will still
      compile the files in extra_sources. This makes it possible to compile
      InternalSettingsGenerated.cpp and not be confused by
      InternalSettingsGenerated.idl.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a35bd277
    • rniwa@webkit.org's avatar
      Add a Mac WebKit2 test expectation for the bug 105954. · 1227721b
      rniwa@webkit.org authored
      * platform/mac-wk2/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1227721b
    • rniwa@webkit.org's avatar
      Add a failing test expectation for the bug 105954. · 2ac60cb6
      rniwa@webkit.org authored
      * platform/mac-wk2/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2ac60cb6
    • abarth@webkit.org's avatar
      HTML preload scanner doesn't need to remember whether we're scanning the body · 1f4721cf
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105945
      
      Reviewed by Eric Seidel.
      
      As far as I can tell, no one uses this state.
      
      * html/parser/CSSPreloadScanner.cpp:
      (WebCore::CSSPreloadScanner::CSSPreloadScanner):
      (WebCore::CSSPreloadScanner::scan):
      (WebCore::CSSPreloadScanner::emitRule):
      * html/parser/CSSPreloadScanner.h:
      (CSSPreloadScanner):
      * html/parser/HTMLPreloadScanner.cpp:
      (WebCore::PreloadTask::preload):
      (WebCore::HTMLPreloadScanner::HTMLPreloadScanner):
      (WebCore::HTMLPreloadScanner::processToken):
      * html/parser/HTMLPreloadScanner.h:
      (HTMLPreloadScanner):
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::preload):
      * loader/cache/CachedResourceLoader.h:
      (CachedResourceLoader):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138658 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f4721cf
    • inferno@chromium.org's avatar
      Crash in WebCore::Element::cloneElementWithoutChildren. · 6747766c
      inferno@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105949
      
      Reviewed by Ryosuke Niwa.
      
      RefPtr |ancestors| vector since its elements can be destroyed from mutation events
      fired in CompositeEditCommand::appendNode.
      
      No new tests. The testcase relies on recursive DOM mutations and does not minimize.
      
      * editing/InsertParagraphSeparatorCommand.cpp:
      (WebCore::InsertParagraphSeparatorCommand::getAncestorsInsideBlock):
      (WebCore::InsertParagraphSeparatorCommand::cloneHierarchyUnderNewBlock):
      (WebCore::InsertParagraphSeparatorCommand::doApply):
      * editing/InsertParagraphSeparatorCommand.h:
      (InsertParagraphSeparatorCommand):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138657 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6747766c
    • roger_fong@apple.com's avatar
      Unreviewed. Build fix after reintroducing r138331. · c0f361d7
      roger_fong@apple.com authored
      Attempted to remove WebKit2 from Apple Windows port in r138331 but two vsprops files were missing.
      
      * WebKit.vcproj/WebKitApple.vsprops: Added.
      * WebKit.vcproj/WebKitDirectX.vsprops: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138656 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0f361d7
    • weinig@apple.com's avatar
      Factor out NetworkProcess initialization into its own function in preparation... · 354657c2
      weinig@apple.com authored
      Factor out NetworkProcess initialization into its own function in preparation of adding a NetworkProcess service
      https://bugs.webkit.org/show_bug.cgi?id=105946
      
      Reviewed by Brady Eidson.
      
      * NetworkProcess/NetworkProcess.h:
      * NetworkProcess/mac/NetworkProcessInitialization.h: Added.
      (NetworkProcessInitializationParameters):
      * NetworkProcess/mac/NetworkProcessInitialization.mm: Added.
      (WebKit::initializeNetworkProcess):
      * NetworkProcess/mac/NetworkProcessMac.mm:
      (WebKit::NetworkProcess::initializeSandbox):
      (WebKit::NetworkProcess::platformInitialize):
      * NetworkProcess/mac/NetworkProcessMainMac.mm:
      (WebKit::NetworkProcessMain):
      * WebKit2.xcodeproj/project.pbxproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      354657c2
    • commit-queue@webkit.org's avatar
      Crash in WebCore::InlineBox::deleteLine · 63cc2d02
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=93448
      
      Patch by Douglas Stockwell <dstockwell@chromium.org> on 2013-01-02
      Reviewed by Eric Seidel.
      
      Source/WebCore:
      
      When we ran off the end of the line while looking for line breaks in an
      inline with white-space:nowrap nested in a block with white-space:pre
      it was possible for the line break to be set at or before the current
      position -- this could result in duplications in the render tree or
      infinite looping.
      
      This patch changes the "fixup" logic that runs after we have finished
      iterating through elements and text and have potentially found a break
      point. In the case of a block setting white-space:pre we would back up
      a character in some cases. Not doing so could leave whitespace that
      should have been collapsed at the end of an inline.
      
      For example in '<span style="white-space:nowrap">x_</span>_y' if a
      break was inserted before 'y' the space after 'x' would still be
      rendered (rather than be collapsed with the break).
      
      To avoid this problem we will not take the opportunity to break until
      we have finished collapsing whitespace.
      
      Tests: fast/text/whitespace/inline-whitespace-wrapping-1.html
             fast/text/whitespace/inline-whitespace-wrapping-2.html
             fast/text/whitespace/inline-whitespace-wrapping-3.html
             fast/text/whitespace/inline-whitespace-wrapping-4.html
             fast/text/whitespace/nowrap-white-space-collapse.html
             fast/text/whitespace/pre-block-normal-inline-crash-1.html
             fast/text/whitespace/pre-block-normal-inline-crash-2.html
      
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlock::LineBreaker::nextLineBreak): Collapse
      whitespace before breaking. Avoid setting the break before the current
      position.
      
      LayoutTests:
      
      * editing/deleting/delete-block-table-expected.txt:
      * editing/execCommand/selectAll-expected.txt: Renamed from LayoutTests/platform/chromium/editing/execCommand/selectAll-expected.txt.
      * fast/text/whitespace/inline-whitespace-wrapping-1-expected.html: Added.
      * fast/text/whitespace/inline-whitespace-wrapping-1.html: Added.
      * fast/text/whitespace/inline-whitespace-wrapping-2-expected.html: Added.
      * fast/text/whitespace/inline-whitespace-wrapping-2.html: Added.
      * fast/text/whitespace/inline-whitespace-wrapping-3-expected.html: Added.
      * fast/text/whitespace/inline-whitespace-wrapping-3.html: Added.
      * fast/text/whitespace/inline-whitespace-wrapping-4-expected.html: Added.
      * fast/text/whitespace/inline-whitespace-wrapping-4.html: Added.
      * fast/text/whitespace/nowrap-white-space-collapse-expected.html: Added.
      * fast/text/whitespace/nowrap-white-space-collapse.html: Added.
      * fast/text/whitespace/pre-block-normal-inline-crash-1-expected.txt: Added.
      * fast/text/whitespace/pre-block-normal-inline-crash-1.html: Added.
      * fast/text/whitespace/pre-block-normal-inline-crash-2-expected.txt: Added.
      * fast/text/whitespace/pre-block-normal-inline-crash-2.html: Added.
      * platform/chromium-win/editing/deleting/delete-to-select-table-expected.txt:
      * platform/chromium-win/editing/execCommand/print-expected.txt:
      * platform/chromium-win/editing/execCommand/selectAll-expected.txt:
      * platform/chromium-win/editing/inserting/editable-html-element-expected.txt:
      * platform/efl/editing/execCommand/selectAll-expected.txt: Removed.
      * platform/gtk/editing/execCommand/selectAll-expected.txt: Removed.
      * platform/mac/editing/execCommand/selectAll-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63cc2d02
    • ojan@chromium.org's avatar
      REGRESSION: Review tool sometimes doesn't include some comments in preview & posts · 9dd3ef28
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105252
      
      Reviewed by Tony Chang.
      
      When adding context, the LineContainer for the context line can get removed.
      In that case, forEachLine needs to know to keep looping past that line number.
      
      Also, make it so that you can't leave comments on context lines.
      
      * code-review-test.html:
      * code-review.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9dd3ef28
    • yoli@rim.com's avatar
      [BlackBerry] Cached frame shouldn't access the page when being destroyed · 5e618fa1
      yoli@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=105942
      
      Reviewed by George Staikos.
      
      In order to prevent our FrameLoaderClient from dangling WebPagePrivate object in any case,
      this patches clear the m_webPagePrivate pointer when the frame is detached or cached.
      
      RIM PR# 272137.
      
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      (WebCore::FrameLoaderClientBlackBerry::isMainFrame):
      (WebCore::FrameLoaderClientBlackBerry::detachedFromParent2):
      (WebCore::FrameLoaderClientBlackBerry::didSaveToPageCache):
      (WebCore::FrameLoaderClientBlackBerry::didRestoreFromPageCache):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e618fa1
    • fpizlo@apple.com's avatar
      DFG should not use the InlineCallFrame's callee when it could have used the executable istead · b463bc28
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=105947
      
      Reviewed by Mark Hahnenberg.
              
      We shouldn't use the callee to get the executable when we have the executable already. Not only
      does this make the logic more clear, but it also allows for a world where the executable is known
      but the callee isn't.
      
      * dfg/DFGAssemblyHelpers.h:
      (JSC::DFG::AssemblyHelpers::strictModeFor):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b463bc28
    • rniwa@webkit.org's avatar
      Add a test expectation for the bug 105952. · 6deef37d
      rniwa@webkit.org authored
      * platform/wk2/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6deef37d
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r138403. · 253baaf3
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/138403
      https://bugs.webkit.org/show_bug.cgi?id=105950
      
      Fixing e138331 which was rolled out in r138403 (Requested by
      rfong on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-02
      
      Source/WebKit/win:
      
      * WebKit.vcproj/WebKit.sln:
      * WebKit.vcproj/WebKit.vcproj:
      * WebKit.vcproj/WebKitLibCommon.vsprops:
      * WebKit.vcproj/WebKitLibDebug.vsprops:
      * WebKit.vcproj/WebKitLibDebugAll.vsprops:
      * WebKit.vcproj/WebKitLibProduction.vsprops:
      * WebKit.vcproj/WebKitLibRelease.vsprops:
      
      Source/WebKit2:
      
      * win/WebKit2.def.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      253baaf3
    • rniwa@webkit.org's avatar
      Add a failing test expectation to a test added by r138380 on Mac WK2. · 5d4b8276
      rniwa@webkit.org authored
      The failure is tracked by the bug 105948.
      
      * platform/mac-wk2/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5d4b8276
    • abarth@webkit.org's avatar
      Remove webkitPostMessage · b2c9e733
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105910
      
      Reviewed by Kentaro Hara.
      
      The vendor-prefixed version of postMessage was never widely used.
      We've been compiling it out of the Chromium port for a while now and
      haven't received any reports of compatibility problems. I've done a
      number of web searches for uses of the API and personally contacted a
      handful of authors I found using the API, all of whom have now moved to
      the identical unprefixed API. We've publicied the prefix removal in a
      blog post:
      
      http://blog.chromium.org/2012/11/a-web-developers-guide-to-latest-chrome.html
      
      and discussed it on webkit-dev:
      
      http://lists.macosforge.org/pipermail/webkit-dev/2012-September/022189.html
      
      We've done our diligence, and now we should remove the API from the
      remainder of the ports.
      
      * bindings/js/JSDOMWindowCustom.cpp:
      * bindings/js/JSDedicatedWorkerContextCustom.cpp:
      * bindings/js/JSMessagePortCustom.cpp:
      * bindings/js/JSWorkerCustom.cpp:
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      (WebCore::V8DOMWindow::postMessageCallback):
      * bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
      (WebCore::V8DedicatedWorkerContext::postMessageCallback):
      * bindings/v8/custom/V8MessagePortCustom.cpp:
      (WebCore::V8MessagePort::postMessageCallback):
      * bindings/v8/custom/V8WorkerCustom.cpp:
      (WebCore::V8Worker::postMessageCallback):
      * dom/MessagePort.idl:
      * page/DOMWindow.idl:
      * workers/DedicatedWorkerContext.idl:
      * workers/Worker.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2c9e733
    • tsepez@chromium.org's avatar
      X-XSS-Protection report-uri doesn't work with mode=block · 1ba573af
      tsepez@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105907
      
      Reviewed by Adam Barth.
      
      Appears to work as-is, but the test was missing for this case. Checking
      for completion is complicated by the frame navigating to about:blank, rather
      than the echo-report page, so check it from the parent frame.
      
      * http/tests/security/xssAuditor/report-script-tag-full-block-expected.txt: Added.
      * http/tests/security/xssAuditor/report-script-tag-full-block.html: Added.
      * http/tests/security/xssAuditor/resources/echo-intertag.pl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ba573af
    • tdanderson@chromium.org's avatar
      [chromium] Mark webaudio/automatic-pull-node.html as Timeout for XP · fac1095b
      tdanderson@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105941
      
      Unreviewed gardening.
      
      
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fac1095b
    • rniwa@webkit.org's avatar
      Rebaseline tests after r137798 and update test expectations per bug 105943. · 0d88c033
      rniwa@webkit.org authored
      * platform/mac-wk2/TestExpectations:
      * platform/mac-wk2/compositing/rtl/rtl-fixed-expected.txt:
      * platform/mac-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d88c033
    • fpizlo@apple.com's avatar
      DFG inliner should not use the callee's bytecode variable for resolving... · 7972a4d9
      fpizlo@apple.com authored
      DFG inliner should not use the callee's bytecode variable for resolving references to the callee in inlined code
      https://bugs.webkit.org/show_bug.cgi?id=105938
      
      Reviewed by Mark Hahnenberg.
              
      This simplifies a bunch of code for referring to the callee. It also ought to simplify how we do
      closure call inlining: for inlined closure call frames we will simply require that the callee is
      already stashed on the stack in the Callee slot in the inline call frame header.
      
      * dfg/DFGByteCodeParser.cpp:
      (ByteCodeParser):
      (JSC::DFG::ByteCodeParser::getDirect):
      (JSC::DFG::ByteCodeParser::get):
      (InlineStackEntry):
      (JSC::DFG::ByteCodeParser::InlineStackEntry::remapOperand):
      (JSC::DFG::ByteCodeParser::handleCall):
      (JSC::DFG::ByteCodeParser::handleInlining):
      (JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
      (JSC::DFG::ByteCodeParser::parse):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7972a4d9
    • benjamin@webkit.org's avatar
      Optimize TransformationMatrix::multiply() for x86_64 · 3f1ef0d3
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105719
      
      Reviewed by Sam Weinig.
      
      On x86_64, we have access to 16 XMM registers. This can hold 32 double values.
      We can use that in two ways to optimize matrix multiplications:
      -Keep the source matrix completely in registers. Write the result directly in
       the source matrix's memory. This avoids the memcpy at the end of the multiplication
       and various memory operations.
      -Use SIMD with SSE to perform 2 operations at a time.
      
      The parameter from the second matrix are loaded one by one in XMM registers.
      Loading them with SSE then shuffling the values perform worse than loading
      one by one.
      
      This is only enabled on 64bits as x86 only has access to 8 XMM registers and
      the function should be written differently.
      
      On a i5, TransformationMatrix::multiply() perform about 3 times faster with the change.
      
      * platform/graphics/transforms/TransformationMatrix.cpp:
      (WebCore::TransformationMatrix::multiply):
      * platform/graphics/transforms/TransformationMatrix.h:
      (TransformationMatrix): Fix an incorrect comment. Unify the comment with the cpp file.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f1ef0d3
    • mkwst@chromium.org's avatar
      Clean up the loadXXXStyle() idiom in StyleResolver. · c4550b6c
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105903
      
      Reviewed by Darin Adler.
      
      This patch refactors 'loadViewSourceStyle' in order to avoid the
      necessity of each call site checking whether the relevant data has
      been loaded. The new 'viewSourceStyle' will load the data if required,
      and return a pointer which can be used directly.
      
      No new tests, as this refactoring should exhibit no visible change in
      behavior.
      
      * css/StyleResolver.cpp:
      (WebCore::viewSourceStyle):
          Lazily populate the static 'defaultViewSourceStyle' with data. I
          haven't removed the outer variable, as it's used directly in
          StyleResolver::reportMemoryUsage.
      (WebCore::StyleResolver::matchUARules):
      (WebCore::StyleResolver::collectFeatures):
          Use the new hotness rather than the old, lame method.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4550b6c
    • rniwa@webkit.org's avatar
      Yet another Windows build fix attempt. Try exporting more symbols. · e65d0658
      rniwa@webkit.org authored
      * win/WebKit2.def.in:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e65d0658
    • esprehn@chromium.org's avatar
      View source mode is missing the processing instruction line. · 881960e4
      esprehn@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=15961
      
      Reviewed by Adam Barth.
      
      Add a test for XML documents shown in viewsource mode. The bug
      with the missing processing instruction line was fixed long
      ago with the HTML5 parser rewrite so this just adds a test.
      
      * fast/frames/viewsource-xml-expected.txt: Added.
      * fast/frames/viewsource-xml.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      881960e4
    • rniwa@webkit.org's avatar
      Another Windows port build fix attempt. Try not exporting this symbol from JSC · 54deb4e4
      rniwa@webkit.org authored
      since it's also compiled in WebCore.
      
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54deb4e4
    • ap@apple.com's avatar
      REGRESSION (r138464): Safari hangs when opening Privacy preferences · 6ab0462a
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=105933
      
      Reviewed by Sam Weinig.
      
      Quick and dirty fix - added a special case for main thread. But I'm not sure if
      dispatch_sync on main queue is really the best idiom here.
      
      * Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
      (WebKit::getPluginInfoFromCarbonResources):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ab0462a
    • abarth@webkit.org's avatar
      Remove old-run-webkit-tests support from webkitpy · 9cd8adb2
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105619
      
      Reviewed by Eric Seidel.
      
      This patch removes support for webkitpy parsing the
      old-run-webkit-tests results format. There doesn't seem to be any
      reason to keep this code around anymore now that most bots have
      switched to new-run-webkit-tests.
      
      * Scripts/webkitpy/common/net/buildbot/buildbot.py:
      (Builder.fetch_layout_test_results):
      * Scripts/webkitpy/common/net/layouttestresults.py:
      (path_for_layout_test):
      (LayoutTestResults.results_from_string):
      (LayoutTestResults):
      * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
      (LayoutTestResultsTest.test_results_from_string):
      * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
      (test_flaky_test_failure):
      * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
      (LayoutTestResultsReaderTest.test_missing_layout_test_results):
      * Scripts/webkitpy/tool/bot/patchanalysistask.py:
      (PatchAnalysisTask._test_patch):
      * Scripts/webkitpy/tool/commands/queuestest.py:
      (QueuesTest.assert_queue_outputs):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9cd8adb2
    • rniwa@webkit.org's avatar
      Unreviewed, rolling out r138627. · 1c128e21
      rniwa@webkit.org authored
      http://trac.webkit.org/changeset/138627
      https://bugs.webkit.org/show_bug.cgi?id=105935
      
      This patch doesn't fix Windows port build failure (Requested
      by rniwa on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-02
      
      * WebCore.vcproj/WebCore.vcproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c128e21
    • esprehn@chromium.org's avatar
      Transitions and animations do not apply to CSS ::before and ::after pseudo-elements · a637d419
      esprehn@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=92591
      
      Reviewed by Eric Seidel.
      
      .:
      
      Expose Element::pseudoElement for Internals.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      The new DOM based :before and :after pseudo elements support animations
      and transitions already, but I had disabled support so we could turn them
      on in a separate step. This patch just removes the checks and adds tests.
      
      This also adds two methods to internals to allow pausing animations and
      transitions on pseudo elements at predictable locations so the tests
      are not flaky.
      
      Tests: fast/css-generated-content/pseudo-animation.html
             fast/css-generated-content/pseudo-transition.html
      
      * WebCore.exp.in:
      * page/animation/AnimationController.cpp:
      (WebCore::AnimationController::updateAnimations):
      * testing/Internals.cpp:
      (WebCore::Internals::pauseAnimationAtTimeOnPseudoElement):
      (WebCore::Internals::pauseTransitionAtTimeOnPseudoElement):
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      
      LayoutTests:
      
      Add tests that check if animations and transitions play for pseudo
      :before and :after pseudo elements.
      
      * fast/css-generated-content/pseudo-animation-expected.txt: Added.
      * fast/css-generated-content/pseudo-animation.html: Added.
      * fast/css-generated-content/pseudo-transition-expected.txt: Added.
      * fast/css-generated-content/pseudo-transition.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a637d419
    • crogers@google.com's avatar
      Implement WebIDL-style string constants in WebAudio · 77d406ad
      crogers@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=105058
      
      Reviewed by Kentaro Hara.
      
      Source/WebCore:
      
      See Deprecation Notes for more detail:
      https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#DeprecationNotes
      
      PannerNode, BiquadFilterNode, OscillatorNode constants must support WebIDL-style string constants.
      Legacy support in the setters for the old integer values should be supported.
      
      This patch handles the changes for OscillatorNode.
      
      * GNUmakefile.list.am:
      * Modules/webaudio/OscillatorNode.cpp:
      (WebCore::OscillatorNode::OscillatorNode):
      (WebCore::OscillatorNode::type):
      (WebCore):
      (WebCore::OscillatorNode::setType):
      * Modules/webaudio/OscillatorNode.h:
      * Modules/webaudio/OscillatorNode.idl:
      * Target.pri:
      * UseJSC.cmake:
      * UseV8.cmake:
      * WebCore.gypi:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/js/JSOscillatorNodeCustom.cpp: Copied from Source/WebCore/Modules/webaudio/OscillatorNode.idl.
      (WebCore):
      (WebCore::JSOscillatorNode::setType):
      * bindings/v8/custom/V8OscillatorNodeCustom.cpp: Copied from Source/WebCore/Modules/webaudio/OscillatorNode.idl.
      (WebCore):
      (WebCore::V8OscillatorNode::typeAccessorSetter):
      
      LayoutTests:
      
      * webaudio/oscillator-basic-expected.txt:
      * webaudio/oscillator-basic.html:
      * webaudio/resources/audio-testing.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77d406ad