1. 09 Jul, 2006 1 commit
  2. 30 Jun, 2006 1 commit
    • thatcher's avatar
      WebCore: · a6df3ece
      thatcher authored
              Reviewed by Darin.
      
              <rdar://problem/3694163> -[KWQPageState finalize] is incorrect; design change needed
              <rdar://problem/3694165> -[WebCoreFrameBridge finalize] is incorrect; design change needed
      
              Added close methods that need to be called before these
              objects can be released. This ensures proper tear-down under GC.
      
              * WebCore.xcodeproj/project.pbxproj:
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge dealloc]):
              (-[WebCoreFrameBridge finalize]):
              (-[WebCoreFrameBridge close]):
              * bridge/mac/WebCorePageBridge.h:
              * bridge/mac/WebCorePageBridge.mm:
              (-[WebCorePageBridge setMainFrame:]):
              (-[WebCorePageBridge dealloc]):
              (-[WebCorePageBridge finalize]):
              (-[WebCorePageBridge close]):
              (-[WebCorePageBridge mainFrame]):
              (-[WebCorePageBridge setGroupName:]):
              (-[WebCorePageBridge groupName]):
              * kwq/KWQPageState.h:
              * kwq/KWQPageState.mm:
              (-[KWQPageState dealloc]):
              (-[KWQPageState finalize]):
              (-[KWQPageState close]):
      
      WebKit:
      
              Reviewed by Darin.
      
              <rdar://problem/4484405> WebKit leaks, improper tear-down
              <rdar://problem/3694059> -[WebBackForwardList finalize] is incorrect; design change needed
              <rdar://problem/3694103> -[WebFrame finalize] is incorrect; design change needed
              <rdar://problem/3694104> -[WebHTMLView finalize] is incorrect; design change needed
      
              Adds a close method to WebView, this needs to be called when the 
              WebView is no longer needed. To make this easier for the common cases
              there is now an "auto close" on WebView that listens to the view's
              parent window. If the parent window closes and the WebView has no
              hostWindow then the WebView is automatically closed if autoClose is YES.
              To manage WebView closing yourself call setAutoClose: and pass NO.
      
              When a WebView closes it will tear-down and not be usable anymore.
              Close will will called on various other internal objects as a part
              of this, to ensure proper tear-down in GC without relying on finalize.
      
              * History/WebBackForwardList.m:
              (-[WebBackForwardList dealloc]):
              (-[WebBackForwardList finalize]):
              (-[WebBackForwardList _close]):
              * History/WebHistoryItem.m:
              (+[WebHistoryItem _closeObjectsInPendingPageCaches]):
              (+[WebHistoryItem _releaseAllPendingPageCaches]):
              * History/WebHistoryItemPrivate.h:
              * WebCoreSupport/WebFrameBridge.m:
              (-[WebFrameBridge close]):
              (-[WebFrameBridge saveDocumentToPageCache:]):
              (-[WebFrameBridge canGoBackOrForward:]):
              * WebView/WebFrame.m:
              (-[WebFrame _detachFromParent]):
              (-[WebFrame dealloc]):
              (-[WebFrame finalize]):
              * WebView/WebFrameView.m:
              (-[WebFrameView _setWebFrame:]):
              (-[WebFrameView finalize]):
              * WebView/WebHTMLView.m:
              (-[WebHTMLView close]):
              (-[NSArray dealloc]):
              (-[NSArray finalize]):
              * WebView/WebHTMLViewInternal.h:
              * WebView/WebHTMLViewPrivate.h:
              * WebView/WebScriptDebugDelegate.m:
              (-[WebScriptCallFrame _initWithFrame:initWithWebFrame:]):
              (-[WebScriptCallFrame parsedSource:fromURL:sourceId:startLine:errorLine:errorMessage:]):
              (-[WebScriptCallFrame enteredFrame:sourceId:line:]):
              (-[WebScriptCallFrame hitStatement:sourceId:line:]):
              (-[WebScriptCallFrame leavingFrame:sourceId:line:]):
              * WebView/WebScriptDebugDelegatePrivate.h:
              * WebView/WebView.m:
              (-[WebViewPrivate init]):
              (-[WebView _close]):
              (-[WebView dealloc]):
              (-[WebView finalize]):
              (-[WebView viewWillMoveToWindow:]):
              (-[WebView _windowWillClose:]):
              (-[WebView setPreferencesIdentifier:]):
              (-[WebView mainFrame]):
              (-[WebView setHostWindow:]):
              (-[WebView searchFor:direction:caseSensitive:wrap:]):
              (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]):
              (-[WebView close]):
              (-[WebView setAutoClose:]):
              (-[WebView autoClose]):
              (-[WebView _frameViewAtWindowPoint:]):
              * WebView/WebViewPrivate.h:
      
      WebKitTools:
      
              Reviewed by Darin.
      
              Need to call window close so WebView tears-down completly.
      
              * DumpRenderTree/DumpRenderTree.m:
              (main): call [window close]
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a6df3ece
  3. 23 Jun, 2006 1 commit
    • thatcher's avatar
      Reviewed by Geoff. · 437307be
      thatcher authored
              script debugger should only attach to JavaScriptCore when there are listeners
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9552
      
              Attaches the debugger to all WebFrames when the first listener
              is added. Detaches when the last listener is removed.
              Also detach when the script debug delegate is set to nil.
      
              * DefaultDelegates/WebScriptDebugServer.m:
              (+[WebScriptDebugServer listenerCount]):
              (-[WebScriptDebugServer dealloc]):
              (-[WebScriptDebugServer attachScriptDebuggerToAllWebViews]):
              (-[WebScriptDebugServer detachScriptDebuggerFromAllWebViews]):
              (-[WebScriptDebugServer listenerConnectionDidDie:]):
              (-[WebScriptDebugServer addListener:]):
              (-[WebScriptDebugServer removeListener:]):
              * DefaultDelegates/WebScriptDebugServerPrivate.h:
              * WebCoreSupport/WebFrameBridge.m:
              (-[WebFrameBridge windowObjectCleared]):
              * WebView/WebFrame.m:
              (-[WebFrame _attachScriptDebugger]):
              (-[WebFrame _detachScriptDebugger]):
              * WebView/WebFramePrivate.h:
              * WebView/WebScriptDebugDelegate.m:
              (-[WebScriptCallFrame parsedSource:fromURL:sourceId:]):
              (-[WebScriptCallFrame enteredFrame:sourceId:line:]):
              (-[WebScriptCallFrame hitStatement:sourceId:line:]):
              (-[WebScriptCallFrame leavingFrame:sourceId:line:]):
              * WebView/WebView.m:
              (-[WebView _attachScriptDebuggerToAllFrames]):
              (-[WebView _detachScriptDebuggerFromAllFrames]):
              (-[WebView setScriptDebugDelegate:]):
              * WebView/WebViewPrivate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14990 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      437307be
  4. 19 Jun, 2006 2 commits
    • ap's avatar
      Reviewed by Darin. · a01e8e12
      ap authored
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=5499
              Page reload does not send any cache control headers
      
      WebCore:
              * bindings/js/kjs_window.cpp:
              (KJS::LocationFunc::callAsFunction): Call scheduleRefresh() for Location::Reload.
      
              * page/Frame.h: Add scheduleRefresh(). Don't derive from TransferJob or implement its methods - that was
              used only for storing response HTTP headers, which was an overkill.
      
              * page/FramePrivate.h: Replace TransferJob with a HashMap for storing response headers.
      
              * page/Frame.cpp:
              (WebCore::Frame::didOpenURL): Don't needlessly change d->m_cachePolicy. Don't create a TransferJob.
              (WebCore::Frame::stopLoading): Directly access the metadata map, instead of going through a TransferJob.
              (WebCore::Frame::receivedFirstData): Ditto.
              (WebCore::Frame::addMetaData): Ditto.
              (WebCore::Frame::scheduleRefresh): A new function that schedules a refresh, similarly to what
              scheduleRedirection() does.
              (WebCore::Frame::changeLocation): Set request.reload attribute based on the current cache policy.
      
      WebKit:
              * WebView/WebFrame.m:
              (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): Set a proper Cache-Control header for 
              reload requests.
              (-[WebFrame loadRequest:]): Reset loadType to WebFrameLoadTypeStandard (after a reload, it stayed at 
              WebFrameLoadTypeReload, so _addExtraFieldsToRequest erroneously added a Cache-Control header to them).
      
      LayoutTests:
              * http/tests/misc/refresh-headers-expected.txt: Added.
              * http/tests/misc/refresh-headers.php: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14920 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a01e8e12
    • ddkilzer's avatar
      WebKit: · 73491922
      ddkilzer authored
              Reviewed by Maciej.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9452
                Assertion failure in -[WebFramePrivate setProvisionalDataSource:]
      
              * WebView/WebFrame.m:
              (-[WebFrame _checkLoadCompleteForThisFrame]): Avoid re-entering the delegate's
              -[webView:didFailProvisionalLoadWithError:forFrame].
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14910 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73491922
  5. 18 Jun, 2006 1 commit
    • ddkilzer's avatar
      WebKit: · 3998b4a8
      ddkilzer authored
              Reviewed by xenon.
      
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=9479
                Disassociate the inspector from the frame when it detaches from its parent
      
              * WebInspector/WebInspector.m:
              (-[NSWindow setWebFrame:]): Added code to (de)register with the WebFrame
              the inspector is (no longer) targeting.
              (-[WebInspector _webFrameDetached:]): Added. Moved the code that was previously
              in -[inspectedWindowWillClose:] here. This is called by the WebFrame when it
              is detached from its parent.
              * WebInspector/WebInspectorInternal.h:
              * WebView/WebFrame.m:
              (-[WebFramePrivate dealloc]):
              (-[WebFrame _detachFromParent]): Added code to notify all registered inspectors
              that the WebFrame is detaching.
              (-[WebFrame _addInspector:]): Added.
              (-[WebFrame _removeInspector:]): Added.
              * WebView/WebFrameInternal.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14906 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3998b4a8
  6. 12 Jun, 2006 1 commit
    • mjs's avatar
      Reviewed by Darin. · 1e9e1a4a
      mjs authored
              
              - remove use of WebView and related from WebMainResourceLoader
      
              * WebKit.xcodeproj/project.pbxproj:
              * WebView/WebDataSource.m:
              (+[WebDataSource _generatedMIMETypeForURLScheme:]):
              (+[WebDataSource _representationExistsForURLScheme:]):
              (+[WebDataSource _canShowMIMEType:]):
              (-[WebDataSource _handleFallbackContent]):
              (-[WebDataSource _decidePolicyForMIMEType:decisionListener:]):
              * WebView/WebDataSourceInternal.h:
              * WebView/WebFrame.m:
              (-[WebFrame _isMainFrame]):
              * WebView/WebFrameInternal.h:
              * WebView/WebMainResourceLoader.m:
              (-[WebMainResourceLoader willSendRequest:redirectResponse:]):
              (-[WebMainResourceLoader continueAfterContentPolicy:response:]):
              (-[WebMainResourceLoader checkContentPolicyForResponse:]):
              (-[WebMainResourceLoader loadWithRequestNow:]):
              * WebView/WebView.m:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14832 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e9e1a4a
  7. 11 Jun, 2006 1 commit
    • andersca's avatar
      WebCore: · c79dba31
      andersca authored
      2006-06-11  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Geoff.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9390
              Move full-frame plugins to WebCore
              
              * WebCore.vcproj/WebCore/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              Add PluginDocument
              
              * bridge/mac/FrameMac.h:
              * bridge/mac/FrameMac.mm:
              (WebCore::FrameMac::redirectDataToPlugin):
              Call the bridge.
              
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm:
              Add redirectDataToPlugin which is used to redirect incoming data
              to a plugin.
              
              * bridge/mac/WebCoreViewFactory.h:
              Add pluginSupportsMIMEType which returns whether any plugins support a given MIME type.
              
              * dom/DOMImplementation.cpp:
              * dom/DOMImplementation.h:
              Get rid of createTextDocument and just create a text document explicitly when needed.
              
              * dom/Document.h:
              (WebCore::Document::isPluginDocument):
              * loader/PluginDocument.cpp: Added.
              (WebCore::PluginTokenizer::PluginTokenizer):
              (WebCore::PluginTokenizer::wantsRawData):
              (WebCore::PluginTokenizer::write):
              (WebCore::PluginTokenizer::createDocumentStructure):
              (WebCore::PluginTokenizer::writeRawData):
              (WebCore::PluginTokenizer::stopParsing):
              (WebCore::PluginTokenizer::finish):
              (WebCore::PluginTokenizer::isWaitingForScripts):
              (WebCore::PluginDocument::PluginDocument):
              (WebCore::PluginDocument::createTokenizer):
              * loader/PluginDocument.h: Added.
              (WebCore::PluginDocument::isPluginDocument):
              Add PluginDocument.
              
              * page/Frame.cpp:
              (WebCore::Frame::begin):
              Possibly create a plugin document.
              
              * page/Frame.h:
              (WebCore::Frame::redirectDataToPlugin):
              Add declaration.
              
              * platform/PlugInInfoStore.h:
              * platform/mac/PlugInInfoStoreMac.mm:
              (WebCore::PlugInInfoStore::supportsMIMEType):
              Ask WebCoreViewFactory if the MIME type is supported.
      
      WebKit:
      
      2006-06-11  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Tim.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9390
              Move full-frame plugins to WebCore
      
              * Plugins/WebBaseNetscapePluginStream.h:
              * Plugins/WebBaseNetscapePluginStream.m:
              (-[WebBaseNetscapePluginStream instance]):
              Add instance method which returns the plugin instance.
              
              * Plugins/WebBasePluginPackage.h:
              Add WebPluginManualLoader protocol
              
              * Plugins/WebNetscapePluginDocumentView.h: Removed.
              * Plugins/WebNetscapePluginDocumentView.m: Removed.
      
              * Plugins/WebNetscapePluginEmbeddedView.h:
              * Plugins/WebNetscapePluginEmbeddedView.m:
              (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:]):
              (-[WebNetscapePluginEmbeddedView dealloc]):
              (-[WebNetscapePluginEmbeddedView didStart]):
              (-[WebNetscapePluginEmbeddedView pluginView:receivedResponse:]):
              (-[WebNetscapePluginEmbeddedView pluginView:receivedData:]):
              (-[WebNetscapePluginEmbeddedView pluginView:receivedError:]):
              (-[WebNetscapePluginEmbeddedView pluginViewFinishedLoading:]):
              (-[WebNetscapePluginEmbeddedView redeliverStream]):
              Make WebNetscapePluginEmbeddedView support the WebPluginManualLoader protocol. It creates a plugin stream and feeds the
              data manually. Much of this code has been copied from WebNetscapePluginRepresentation.
      
              * Plugins/WebNetscapePluginRepresentation.h: Removed.
              * Plugins/WebNetscapePluginRepresentation.m: Removed.
      
              * Plugins/WebPluginController.h:
              * Plugins/WebPluginController.m:
              (-[WebPluginController pluginView:receivedResponse:]):
              (-[WebPluginController pluginView:receivedData:]):
              (-[WebPluginController pluginView:receivedError:]):
              (-[WebPluginController pluginViewFinishedLoading:]):
              Make WebPluginController support the WebPluginManualLoader protocol so it can feed data manually to WebKit plugins.
      
              * Plugins/WebPluginDatabase.m:        
              (-[WebPluginDatabase refresh]):
              Use WebHTMLView and WebHTMLRepresentation when registering/unregistering plug-in MIME types.
              
              * Plugins/WebPluginDocumentView.h: Removed.
              * Plugins/WebPluginDocumentView.m: Removed.
      
              * WebCoreSupport/WebFrameBridge.m:
              (-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:DOMElement:loadManually:]):
              (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
              Add loadManually argument.
              
              (-[WebFrameBridge redirectDataToPlugin:]):
              Call down to the HTML representation.
              
              (-[WebFrameBridge viewForJavaAppletWithFrame:attributeNames:attributeValues:baseURL:DOMElement:]):
              Pass NO to loadManually.
              
              (-[WebFrameBridge determineObjectFromMIMEType:URL:]):
              Explicitly check if the MIME type is supported by a plug-in instead of checking the view class.
              
              * WebCoreSupport/WebViewFactory.m:
              (-[WebViewFactory pluginSupportsMIMEType:]):
              New function which returns whether any plugins support a given MIME type.
              
              * WebKit.xcodeproj/project.pbxproj:
              Update for removed files.
              
              * WebView/WebFrame.m:
              (-[WebFrame _reloadForPluginChanges]):
              Remove view type checks.
              
              (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
              (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
              Remove FIXME comments.
              
              * WebView/WebHTMLRepresentation.m:
              (-[WebHTMLRepresentation _redirectDataToManualLoader:forPluginView:]):        
              New function which redirects incoming data to a manual loader.
              
              (-[WebHTMLRepresentation receivedData:withDataSource:]):
              (-[WebHTMLRepresentation receivedError:withDataSource:]):
              (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
              Optionally redirect incoming data.
              
              * WebView/WebHTMLRepresentationPrivate.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14811 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c79dba31
  8. 08 Jun, 2006 1 commit
    • justing's avatar
      LayoutTests: · e6f80c1e
      justing authored
              Reviewed by levi
              
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=4468>
              Implement execCommand(Insert{Un}OrderedList)
      
              Added:
              * editing/execCommand/create-list-from-range-selection-expected.checksum: Added.
              * editing/execCommand/create-list-from-range-selection-expected.png: Added.
              * editing/execCommand/create-list-from-range-selection-expected.txt: Added.
              * editing/execCommand/create-list-from-range-selection.html: Added.
              * editing/execCommand/insert-list-and-stitch-expected.checksum: Added.
              * editing/execCommand/insert-list-and-stitch-expected.png: Added.
              * editing/execCommand/insert-list-and-stitch-expected.txt: Added.
              * editing/execCommand/insert-list-and-stitch.html: Added.
              * editing/execCommand/insert-list-with-id-expected.checksum: Added.
              * editing/execCommand/insert-list-with-id-expected.png: Added.
              * editing/execCommand/insert-list-with-id-expected.txt: Added.
              * editing/execCommand/insert-list-with-id.html: Added.
              * editing/execCommand/remove-list-from-range-selection-expected.checksum: Added.
              * editing/execCommand/remove-list-from-range-selection-expected.png: Added.
              * editing/execCommand/remove-list-from-range-selection-expected.txt: Added.
              * editing/execCommand/remove-list-from-range-selection.html: Added.
              * editing/execCommand/remove-list-items-expected.checksum: Added.
              * editing/execCommand/remove-list-items-expected.png: Added.
              * editing/execCommand/remove-list-items-expected.txt: Added.
              * editing/execCommand/remove-list-items.html: Added.
              * editing/execCommand/switch-list-type-expected.checksum: Added.
              * editing/execCommand/switch-list-type-expected.png: Added.
              * editing/execCommand/switch-list-type-expected.txt: Added.
              * editing/execCommand/switch-list-type.html: Added.
              
              Fixes:
              * editing/pasteboard/drag-drop-modifies-page-expected.txt:
              * editing/pasteboard/paste-list-001-expected.txt:
              * editing/selection/drag-to-contenteditable-iframe-expected.checksum:
              * editing/selection/drag-to-contenteditable-iframe-expected.png:
              * editing/selection/drag-to-contenteditable-iframe-expected.txt:
              * editing/style/block-style-005-expected.txt:
              * fast/text/textIteratorNilRenderer-expected.checksum:
              * fast/text/textIteratorNilRenderer-expected.png:
              * fast/text/textIteratorNilRenderer-expected.txt:
              * editing/deleting/delete-line-016-expected.checksum:
              * editing/deleting/delete-line-016-expected.png:
              * editing/deleting/delete-line-016-expected.txt:
      
      WebCore:
      
              Reviewed by levi
              
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=4468>
              Implement execCommand(Insert{Un}OrderedList)
      
              * WebCore.xcodeproj/project.pbxproj: Added InsertListCommand.{h,cpp} to the project.
              * dom/Position.cpp:
              (WebCore::hasRenderedNonAnonymousDescendantsWithHeight): 
              Added. A block with height is only a candidate if this is false.  This should fix the problems
              getting carets into empty blocks.
              (WebCore::Position::inRenderedContent):
              * editing/AppendNodeCommand.cpp:
              (WebCore::AppendNodeCommand::doApply):
              * editing/CompositeEditCommand.cpp:
              (WebCore::hasARenderedDescendant):
              (WebCore::CompositeEditCommand::prune): A node can have DOM descendants that are rendered, yet
              have no rendered descendants.  Fixed the pruning rule to avoid removing a node like this.
              (WebCore::CompositeEditCommand::mergeIdenticalElements): Put the two elements next to
              each other if they aren't already, as a convenience.
              (WebCore::CompositeEditCommand::moveParagraph): Added code to preserve the current selection.
              (WebCore::CompositeEditCommand::moveParagraphs): Ditto. 
              * editing/CompositeEditCommand.h:
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::initializeStartEnd): Expansion for special elements should
              continue to happen until it is no longer possible.
              (WebCore::DeleteSelectionCommand::handleGeneralDelete): The code to adjust the start node
              wouldn't always avoid removing the start block.
              * editing/InsertListCommand.cpp: Added.
              (WebCore::InsertListCommand::fixOrphanedListChild): Puts a list item that isn't inside a list
              into a list.
              (WebCore::InsertListCommand::InsertListCommand):
              (WebCore::InsertListCommand::modifyRange):
              (WebCore::InsertListCommand::doApply):
              * editing/InsertListCommand.h: Added.
              (WebCore::InsertListCommand::):
              * editing/InsertNodeBeforeCommand.cpp:
              (WebCore::InsertNodeBeforeCommand::doApply):
              * editing/InsertParagraphSeparatorCommand.cpp:
              * editing/JSEditor.cpp:
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::advance): Don't handle a node if the end of the range used to create the 
              iterator ends at the start of that node.
              used to create the iterator.
              * editing/VisiblePosition.cpp:
              (WebCore::VisiblePosition::next):
              (WebCore::VisiblePosition::previous):
              * editing/VisiblePosition.h: 
              Added a parameter to next/previous to prevent them from going outside the current editable region.
              * editing/htmlediting.cpp:
              (WebCore::highestAncestor):
              (WebCore::enclosingList):
              (WebCore::enclosingListChild):
              (WebCore::outermostEnclosingList):
              (WebCore::createListItemElement):
              * editing/htmlediting.h:
              * page/Frame.cpp:
              (WebCore::Frame::selectionListState): Added.
              * page/Frame.h:
      
      WebKit:
      
              Reviewed by levi
              
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=4468>
              Implement execCommand(Insert{Un}OrderedList)
      
              * WebView/WebFrame.m:
              (-[WebFrame _findFrameWithSelection]): Removed an assertion
              that we only have one frame with a selection.  
              * WebView/WebView.m:
              (-[WebView selectedFrame]): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6f80c1e
  9. 06 Jun, 2006 1 commit
    • andersca's avatar
      WebCore: · a70ccbc8
      andersca authored
      2006-06-06  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by John.
      
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge containsPlugins]):
              * page/Frame.cpp:
              (WebCore::Frame::containsPlugins):
              * page/Frame.h:
              Add containsPlugins function which returns whether a frame contains plugins
              or not.
      
      WebKit:
      
      2006-06-06  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by John.
      
              * WebView/WebFrame.m:
              (-[WebFrame _reloadForPluginChanges]):
              Don't traverse the view hierarchy looking for plugin views. Instead, just
              ask the frame whether it contains any plugins.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14743 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a70ccbc8
  10. 01 Jun, 2006 1 commit
    • andersca's avatar
      WebCore: · 079f44cf
      andersca authored
      2006-06-01  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Darin.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6309
              multiple problems prevent bookmarking/back button technique for AJAX/DHTML applications from working
              
              * bindings/js/kjs_window.cpp:
              (KJS::Location::put):
              Handle the case where the hash starts with a "#". Also, don't do anything if the previous and new hashes
              are equal.
              
              * bridge/BrowserExtension.h:
              * bridge/mac/BrowserExtensionMac.h:
              * bridge/mac/BrowserExtensionMac.mm:        
              (WebCore::BrowserExtensionMac::historyURL):
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm:
              New function historyURL which returns the complete URL for a given item in the history.
              
              * page/Frame.cpp:
              (WebCore::Frame::scheduleLocationChange):        
              (WebCore::Frame::scheduleHistoryNavigation):
              If the URL of the new location only differs in the hash, don't schedule the load. Instead, load it
              directly.
              
              * platform/KURL.cpp:
              * platform/KURL.h:
              Add equalsIgnoringRef which returns whether two URLs are equal, ignoring the ref.
      
      WebKit:
      
      2006-06-01  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Darin.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6309
              multiple problems prevent bookmarking/back button technique for AJAX/DHTML applications from working
      
              * Misc/WebNSURLExtras.m:
              (-[NSString _webkit_URLFragment]):
              Don't include the "#" character in the fragment.
              
              * WebCoreSupport/WebFrameBridge.m:
              (-[WebFrameBridge historyURL:]):
              New function, returns the history URL for a given position in the back/forward list
              
              * WebView/WebFrame.m:
              (-[WebFrame _loadItem:withLoadType:]):
              Always call scrollToAnchorWithURL, even if there is no fragment. This way we keep the WebCore frame's
              URL up-to-date.
      
      WebKitTools:
      
      2006-06-01  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Darin.
      
              * DumpRenderTree/DumpRenderTree.m:
              (+[LayoutTestController isSelectorExcludedFromWebScript:]):
              (-[LayoutTestController clearBackForwardList]):
              Add clearBackForwardList function to layoutTestController
              
      LayoutTests:
      
      2006-06-01  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Darin.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6309
              multiple problems prevent bookmarking/back button technique for AJAX/DHTML applications from working
              
              * fast/dom/location-hash-expected.txt: Added.
              * fast/dom/location-hash.html: Added.
              Added tests.
              
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      079f44cf
  11. 25 May, 2006 1 commit
    • thatcher's avatar
      Reviewed by Tim O. · 25fd97ba
      thatcher authored
              <rdar://problem/4559808> WebKit fails to compile for ppc64
              <rdar://problem/4522085> 64-bit: WebKit uses FSSpec which is not available in 64-bit
              Gets WebKit building under 64-bit. Rename WebNSInt and WebNSUInt to WebNSInteger and WebNSUInteger.
              Start using WebNSInteger where we need to match AppKit API usage of NSInteger.
      
              HIWebView and a couple of helper functions are disabled until they can be moved off of QuickDraw.
              <rdar://problem/4561772> HIWebView needs to be reworked to not use QuickDraw, needed for 64-bit
      
              * Carbon/CarbonUtils.m: disabled this file in 64-bit <rdar://problem/4561772>
              * Carbon/CarbonWindowAdapter.m:
              (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
              * Carbon/CarbonWindowFrame.m:
              (+[CarbonWindowFrame frameRectForContentRect:styleMask:]):
              (+[CarbonWindowFrame contentRectForFrameRect:styleMask:]):
              (+[CarbonWindowFrame minFrameSizeForMinContentSize:styleMask:]):
              (-[CarbonWindowFrame frameRectForContentRect:styleMask:]):
              (-[CarbonWindowFrame contentRectForFrameRect:styleMask:]):
              (-[CarbonWindowFrame minFrameSizeForMinContentSize:styleMask:]):
              * Carbon/HIViewAdapter.m: disabled this file in 64-bit <rdar://problem/4561772>
              * Carbon/HIWebView.m: disabled this file in 64-bit <rdar://problem/4561772>
              (HIWebViewEventHandler):
              * DefaultDelegates/WebDefaultResourceLoadDelegate.m:
              (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveContentLength:fromDataSource:]):
              * History/WebBackForwardList.m:
              (-[WebBackForwardList removeItem:]):
              (-[WebBackForwardList goToItem:]):
              * Misc/WebDownload.m:
              (-[WebDownloadInternal download:didReceiveDataOfLength:]):
              * Misc/WebFileDatabase.m:
              (UniqueFilePathForKey):
              * Misc/WebIconDatabase.m:
              (-[NSMutableDictionary retainIconForURL:]):
              (-[NSMutableDictionary releaseIconForURL:]):
              (-[WebIconDatabase _totalRetainCountForIconURLString:]):
              (-[WebIconDatabase _retainIconForIconURLString:]):
              (-[WebIconDatabase _releaseIconForIconURLString:]):
              * Misc/WebSearchableTextView.m:
              (-[NSString selectionRect]):
              * Misc/WebTypesInternal.h: Added.
              * Plugins/WebBaseNetscapePluginStream.m:
              (-[WebBaseNetscapePluginStream _destroyStream]):
              (CarbonPathFromPOSIXPath):
              * Plugins/WebBaseNetscapePluginView.m:
              (-[WebBaseNetscapePluginView sendActivateEvent:]):
              (-[WebBaseNetscapePluginView sendUpdateEvent]):
              (TSMEventHandler):
              (-[WebBaseNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
              (-[WebBaseNetscapePluginView _printedPluginBitmap]):
              (-[NSData _web_locationAfterFirstBlankLine]):
              * Plugins/WebBasePluginPackage.m:
              (-[WebBasePluginPackage hash]):
              * Plugins/WebNetscapePluginPackage.m:
              (-[WebNetscapePluginPackage load]):
              (functionPointerForTVector):
              * WebInspector/WebInspector.m:
              (-[WebInspector _updateSystemColors]):
              * WebKit.xcodeproj/project.pbxproj:
              * WebView/WebDataSource.m:
              (-[WebDataSource _didReceiveData:contentLength:forResource:]):
              * WebView/WebFrame.m:
              (-[WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:]):
              * WebView/WebHTMLView.m:
              (-[NSArray drawRect:]):
              (-[WebHTMLView characterIndexForPoint:]):
              (-[WebHTMLView conversationIdentifier]):
              * WebView/WebResourceLoadDelegate.h:
              * WebView/WebUIDelegate.h:
              * WebView/WebView.h:
              * WebView/WebView.m:
              (-[WebView _mouseDidMoveOverElement:modifierFlags:]):
              (-[WebView spellCheckerDocumentTag]):
              * WebView/WebViewInternal.h:
              * WebView/WebViewPrivate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14586 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25fd97ba
  12. 23 May, 2006 1 commit
    • mjs's avatar
      Reviewed by Maciej. · 48ffc74a
      mjs authored
              
              - more loader refactoring to simplify things and remove knowledge of WebView from WebSubresourceLoader
      
              * WebCoreSupport/WebSubresourceLoader.m:
              (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]):
              (-[WebSubresourceLoader didReceiveResponse:]):
              * WebView/WebDataSource.m:
              (-[WebDataSource _loadIcon]):
              (-[WebDataSource _startLoading]):
              * WebView/WebFrame.m:
              (-[WebFrame _loadRequest:archive:]):
              (-[WebFrame _loadItem:withLoadType:]):
              (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
              (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
              (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
              * WebView/WebFrameInternal.h:
              * WebView/WebFramePrivate.h:
              * WebView/WebLoader.h:
              * WebView/WebLoader.m:
              * WebView/WebMainResourceLoader.m:
              (-[WebMainResourceLoader initWithDataSource:]):
              (-[WebMainResourceLoader didReceiveResponse:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14553 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48ffc74a
  13. 18 May, 2006 1 commit
    • mjs's avatar
      Reviewed by Eric. · 1544355e
      mjs authored
              
              - remove loading-related code from WebView
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8981
      
              * Plugins/WebNetscapePluginStream.m:
              (-[WebNetscapePlugInStreamLoader didFinishLoading]):
              (-[WebNetscapePlugInStreamLoader didFailWithError:]):
              * WebCoreSupport/WebSubresourceLoader.m:
              (-[WebSubresourceLoader receivedError:]):
              (-[WebSubresourceLoader signalFinish]):
              * WebView/WebDataSource.m:
              (-[WebDataSource _stopLoading]):
              (-[WebDataSource _receivedMainResourceError:complete:]):
              (-[WebDataSource _finishedLoadingResource]):
              (-[WebDataSource _mainReceivedBytesSoFar:complete:]):
              (-[WebDataSource _receivedError:]):
              (-[WebDataSource _mainReceivedError:complete:]):
              * WebView/WebDataSourceInternal.h:
              * WebView/WebFrame.m:
              (-[WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:]):
              * WebView/WebMainResourceLoader.m:
              (-[WebMainResourceLoader didReceiveData:lengthReceived:]):
              (-[WebMainResourceLoader didFinishLoading]):
              * WebView/WebView.m:
              * WebView/WebViewInternal.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14481 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1544355e
  14. 12 May, 2006 1 commit
    • mjs's avatar
      Reviewed by Brady. · d2eb1dea
      mjs authored
              
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8876
              - move most private WebDataSource methods to uninstalled header
              
              I put the declarations for the ones only used in WebKit in WebDataSourceInternal.h
              and removed two entirey unused ones.
      
              * Plugins/WebNetscapePluginRepresentation.m:
              * Plugins/WebNetscapePluginStream.m:
              * Plugins/WebPluginController.m:
              * Plugins/WebPluginDocumentView.m:
              * WebCoreSupport/WebFrameBridge.m:
              (-[WebFrameBridge dataSource]):
              * WebCoreSupport/WebSubresourceLoader.m:
              * WebKit.xcodeproj/project.pbxproj:
              * WebView/WebDataSource.m:
              (-[WebDataSource _updateIconDatabaseWithURL:]):
              (-[WebDataSource _loadIcon]):
              (-[WebDataSource _clearErrors]):
              (-[WebDataSource _commitLoadWithData:]):
              (-[WebDataSource _doesProgressiveLoadWithMIMEType:]):
              (-[WebDataSource _addResponse:]):
              * WebView/WebDataSourceInternal.h: Added.
              * WebView/WebDataSourcePrivate.h:
              * WebView/WebFrame.m:
              * WebView/WebHTMLRepresentation.m:
              * WebView/WebHTMLView.m:
              * WebView/WebImageView.m:
              * WebView/WebLoader.m:
              * WebView/WebMainResourceLoader.m:
              * WebView/WebPDFView.m:
              * WebView/WebRenderNode.m:
              * WebView/WebView.m:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14333 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2eb1dea
  15. 09 May, 2006 1 commit
    • mjs's avatar
      WebCore: · dd13ab48
      mjs authored
              Reviewed by Tim Hatcher.
              
              - refactor things so that WebKit doesn't save a WebResource for every loaded URL,
              but rather retrieves the data from the WebCore cache as needed.
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8802
      
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge getData:andResponse:forURL:]):
              (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
              * loader/Cache.cpp:
              (WebCore::Cache::updateCacheStatus):
              (WebCore::Cache::requestImage):
              (WebCore::Cache::requestStyleSheet):
              (WebCore::Cache::requestScript):
              (WebCore::Cache::requestXSLStyleSheet):
              (WebCore::Cache::requestXBLDocument):
              * loader/Cache.h:
              * loader/CachedResource.cpp: Added.
              * loader/CachedResource.h: Added.
              * loader/CachedResourceClient.h: Added.
              * loader/CachedResourceClientWalker.cpp: Added.
              * loader/CachedResourceClientWalker.h: Added.
              * loader/DocLoader.cpp:
              (WebCore::DocLoader::setAutoloadImages):
              (WebCore::DocLoader::removeCachedObject):
              * loader/DocLoader.h:
              (WebCore::DocLoader::cachedObject):
              (WebCore::DocLoader::allCachedObjects):
      
      WebKit:
      
              Reviewed by Tim Hatcher.
              
              - refactor things so that WebKit doesn't save a WebResource for every loaded URL,
              but rather retrieves the data from the WebCore cache as needed.
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8802
      
              * WebCoreSupport/WebFrameBridge.m:
              (-[WebFrameBridge objectLoadedFromCacheWithURL:response:data:]):
              (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
              * WebCoreSupport/WebSubresourceLoader.m:
              (-[WebSubresourceLoader didReceiveResponse:]):
              * WebView/WebDataSource.m:
              (-[WebDataSourcePrivate dealloc]):
              (-[WebDataSource _setupForReplaceByMIMEType:]):
              (-[WebDataSource _archivedSubresourceForURL:]):
              (-[WebDataSource initWithRequest:]):
              (-[WebDataSource subresources]):
              (-[WebDataSource subresourceForURL:]):
              (-[WebDataSource addSubresource:]):
              * WebView/WebDataSourcePrivate.h:
              * WebView/WebFrame.m:
              * WebView/WebFrameInternal.h:
              * WebView/WebHTMLView.m:
              * WebView/WebLoader.h:
              * WebView/WebLoader.m:
              (-[NSURLProtocol loadWithRequest:]):
              (-[NSURLProtocol didFinishLoading]):
              * WebView/WebUnarchivingState.h:
              * WebView/WebUnarchivingState.m:
              (-[WebUnarchivingState addResource:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14251 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd13ab48
  16. 28 Apr, 2006 1 commit
    • eseidel's avatar
      2006-04-28 Eric Seidel <eseidel@apple.com> · e9723dd0
      eseidel authored
              Reviewed by darin.
      
              Misc. style cleanup.
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8643
      
              * Misc/WebIconDatabase.m:
              (-[NSMutableDictionary iconForURL:withSize:cache:]):
              (-[NSMutableDictionary iconURLForURL:]):
              (-[NSMutableDictionary retainIconForURL:]):
              (-[NSMutableDictionary releaseIconForURL:]):
              (-[WebIconDatabase _setIcon:forIconURL:]):
              (-[WebIconDatabase _iconsForIconURLString:]):
              (-[WebIconDatabase _forgetIconForIconURLString:]):
              (-[WebIconDatabase _releaseIconForIconURLString:]):
              (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]):
              * Plugins/WebBasePluginPackage.m:
              (+[WebBasePluginPackage pluginWithPath:]):
              (-[WebBasePluginPackage pathByResolvingSymlinksAndAliasesInPath:]):
              (-[WebBasePluginPackage initWithPath:]):
              (-[WebBasePluginPackage getPluginInfoFromBundleAndMIMEDictionary:]):
              (-[WebBasePluginPackage pListForPath:createFile:]):
              (-[WebBasePluginPackage getPluginInfoFromPLists]):
              (-[WebBasePluginPackage load]):
              (-[WebBasePluginPackage setMIMEToExtensionsDictionary:]):
              (-[WebBasePluginPackage isNativeLibraryData:]):
              (-[NSArray _web_lowercaseStrings]):
              * Plugins/WebNetscapePluginPackage.m:
              (-[WebNetscapePluginPackage openResourceFile]):
              (-[WebNetscapePluginPackage closeResourceFile:]):
              (-[WebNetscapePluginPackage stringForStringListID:andIndex:]):
              (-[WebNetscapePluginPackage getPluginInfoFromResources]):
              (-[WebNetscapePluginPackage initWithPath:]):
              (-[WebNetscapePluginPackage executableType]):
              (-[WebNetscapePluginPackage unloadWithoutShutdown]):
              (-[WebNetscapePluginPackage load]):
              (-[WebNetscapePluginPackage unload]):
              * Plugins/WebNetscapePluginRepresentation.m:
              (-[WebNetscapePluginRepresentation redeliverStream]):
              * Plugins/WebPluginDatabase.m:
              (+[WebPluginDatabase installedPlugins]):
              (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
              (-[WebPluginDatabase pluginForExtension:]):
              (pluginLocations):
              (-[WebPluginDatabase init]):
              (-[WebPluginDatabase refresh]):
              * Plugins/npapi.m:
              (NPN_MemAlloc):
              (NPN_MemFree):
              (pluginViewForInstance):
              * WebCoreSupport/WebSubresourceLoader.m:
              (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]):
              (-[WebSubresourceLoader willSendRequest:redirectResponse:]):
              * WebView/WebDataSource.m:
              (-[WebDataSource isLoading]):
              * WebView/WebFrame.m:
              (-[WebFrame _loadDataSource:withLoadType:formState:]):
              (-[WebFrame _subframeIsLoading]):
              * WebView/WebView.m:
              (-[WebView initWithFrame:]):
              (-[WebView initWithFrame:frameName:groupName:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14105 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9723dd0
  17. 26 Apr, 2006 1 commit
    • tomernic's avatar
      Reviewed by Geoff. · b2958c77
      tomernic authored
              <rdar://problem/4525105> Repro TOT crash in [WebBaseNetscapePluginView dealloc] at coachella.com
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=8564> crashed when closing a tab
      
              * WebView/WebFrame.m:
              (-[WebFramePrivate dealloc]):
              Assert that plugInViews has been released.
              (-[WebFrame _addPlugInView:]):
              New method.  Adds the plug-in view to the plugInViews set and calls -setWebFrame: on it.
              (-[WebFrame _removeAllPlugInViews]):
              New method.  Calls -setWebFrame:nil on all plug-in views and releases the plugInViews set.
              (-[WebFrame _willCloseURL]):
              New method.  Dispose of plug-in views when leaving a page (or closing the WebView).
      
              * WebView/WebFrameInternal.h:
              Declared -_addPlugInView:, -_removeAllPlugInViews, -_willCloseURL
      
              * WebCoreSupport/WebFrameBridge.m:
              (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]):
              Call -[WebFrame _addPlugInView:] instead of directly setting plug-in views' frames.  This
              allows us to keep track of them so that we can explicitly dispose of them when leaving the page.
              (-[WebFrameBridge closeURL]):
              Override -[WebCoreFrameBridge closeURL] so that we can perform our own teardown when leaving
              a page or closing the WebView.
      
              * Plugins/WebBaseNetscapePluginView.h:
              Declared -stop so that subclass WebNetscapePluginEmbeddedView can call it.
      
              * Plugins/WebNetscapePluginEmbeddedView.m:
              (-[WebNetscapePluginEmbeddedView setWebFrame:]):
              Stop the plug-in when it is removed from its WebFrame.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14075 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2958c77
  18. 22 Apr, 2006 1 commit
    • mjs's avatar
      Reviewed by Eric. · 817a67b2
      mjs authored
              - remove WebKit copy of assertions code, use the assertions
              stuff from JavaScriptCore instead.
      
              * Carbon/HIViewAdapter.m:
              * DOM/WebDOMOperations.m:
              * DefaultDelegates/WebDefaultContextMenuDelegate.m:
              * DefaultDelegates/WebDefaultPolicyDelegate.m:
              (-[WebDefaultPolicyDelegate webView:unableToImplementPolicyWithError:frame:]):
              * History/WebBackForwardList.m:
              * History/WebHistory.m:
              (-[WebHistoryPrivate _loadHistoryGuts:URL:error:]):
              (-[WebHistoryPrivate _saveHistoryGuts:URL:error:]):
              * History/WebHistoryItem.m:
              * Misc/WebAssertions.h: Removed.
              * Misc/WebAssertions.m: Removed.
              * Misc/WebDatabase.m:
              * Misc/WebDownload.m:
              * Misc/WebFileDatabase.m:
              (SetThreadPriority):
              * Misc/WebIconDatabase.m:
              (-[NSMutableDictionary iconForURL:withSize:cache:]):
              (-[NSMutableDictionary releaseIconForURL:]):
              (-[NSMutableDictionary delayDatabaseCleanup]):
              (-[NSMutableDictionary allowDatabaseCleanup]):
              (-[WebIconDatabase _loadIconDictionaries]):
              (-[WebIconDatabase _updateFileDatabase]):
              (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]):
              * Misc/WebIconLoader.m:
              * Misc/WebKitLogging.h:
              * Misc/WebKitLogging.m:
              * Misc/WebKitSystemBits.m:
              (initCapabilities):
              * Misc/WebLRUFileList.m:
              (WebLRUFileListRemoveOldestFileFromList):
              (WebLRUFileListGetFileSize):
              * Misc/WebLocalizableStrings.m:
              * Misc/WebNSCalendarDateExtras.m:
              * Misc/WebNSDataExtras.m:
              * Misc/WebNSDictionaryExtras.m:
              * Misc/WebNSFileManagerExtras.m:
              * Misc/WebNSPasteboardExtras.m:
              * Misc/WebNSURLExtras.m:
              (hexDigit):
              (hexDigitValue):
              (allCharactersInIDNScriptWhiteList):
              * Misc/WebNSURLRequestExtras.m:
              * Misc/WebNSUserDefaultsExtras.m:
              * Misc/WebStringTruncator.m:
              * Panels/WebAuthenticationPanel.m:
              (-[WebAuthenticationPanel loadNib]):
              * Panels/WebPanelAuthenticationHandler.m:
              * Plugins/WebBaseNetscapePluginStream.m:
              (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]):
              (-[WebBaseNetscapePluginStream finishedLoadingWithData:]):
              * Plugins/WebBaseNetscapePluginView.m:
              (TSMEventHandler):
              (-[WebBaseNetscapePluginView start]):
              (-[WebBaseNetscapePluginView status:]):
              (-[WebBaseNetscapePluginView _printedPluginBitmap]):
              * Plugins/WebBasePluginPackage.m:
              * Plugins/WebNetscapePluginDocumentView.m:
              * Plugins/WebNetscapePluginPackage.m:
              (-[WebNetscapePluginPackage load]):
              * Plugins/WebNetscapePluginRepresentation.m:
              * Plugins/WebPluginContainerCheck.m:
              * Plugins/WebPluginController.m:
              (-[WebPluginController addPlugin:]):
              (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
              (-[WebPluginController webPlugInContainerShowStatus:]):
              * Plugins/WebPluginDatabase.m:
              * Plugins/WebPluginDocumentView.m:
              * WebCoreSupport/WebCookieAdapter.m:
              * WebCoreSupport/WebFileButton.m:
              * WebCoreSupport/WebFrameBridge.m:
              (-[WebFrameBridge runModal]):
              * WebCoreSupport/WebImageData.m:
              (-[WebImageData _checkSolidColor:]):
              (-[WebImageData tileInRect:fromPoint:context:]):
              (-[WebImageData scaleAndTileInRect:fromRect:withHorizontalTileRule:withVerticalTileRule:context:]):
              * WebCoreSupport/WebImageDecoder.m:
              * WebCoreSupport/WebImageRenderer.m:
              (-[WebImageRenderer TIFFRepresentation]):
              * WebCoreSupport/WebImageRendererFactory.m:
              * WebCoreSupport/WebJavaScriptTextInputPanel.m:
              * WebCoreSupport/WebKeyGenerator.m:
              * WebCoreSupport/WebPageBridge.m:
              * WebCoreSupport/WebSubresourceLoader.m:
              * WebCoreSupport/WebTextRenderer.m:
              (widthForGlyph):
              (-[WebTextRenderer initWithFont:]):
              (drawGlyphs):
              (initializeATSUStyle):
              (createATSULayoutParameters):
              (getTextBounds):
              (ATSU_draw):
              * WebCoreSupport/WebTextRendererFactory.m:
              * WebCoreSupport/WebViewFactory.m:
              * WebKit.exp:
              * WebKit.xcodeproj/project.pbxproj:
              * WebKitPrefix.h:
              * WebView/WebArchiver.m:
              (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]):
              * WebView/WebClipView.m:
              * WebView/WebDataProtocol.m:
              * WebView/WebDataSource.m:
              (-[WebDataSource _startLoading]):
              * WebView/WebFormDataStream.m:
              (formEventCallback):
              (webSetHTTPBody):
              * WebView/WebFrame.m:
              (-[WebFrame _transitionToCommitted:]):
              * WebView/WebFrameView.m:
              * WebView/WebHTMLRepresentation.m:
              * WebView/WebHTMLView.m:
              (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
              (-[NSArray drawSingleRect:]):
              (-[NSArray namesOfPromisedFilesDroppedAtDestination:]):
              (-[NSArray _scaleFactorForPrintOperation:]):
              (-[NSArray deleteBackwardByDecomposingPreviousCharacter:]):
              (-[NSArray checkSpelling:]):
              (-[NSArray showGuessPanel:]):
              (-[NSArray _changeSpellingToWord:]):
              (-[NSArray ignoreSpelling:]):
              (-[NSArray performFindPanelAction:]):
              (-[WebTextCompleteController doCompletion]):
              * WebView/WebImageView.m:
              * WebView/WebLoader.m:
              (-[NSURLProtocol connection:willCacheResponse:]):
              * WebView/WebPDFRepresentation.m:
              (+[WebPDFRepresentation PDFDocumentClass]):
              * WebView/WebPDFView.m:
              (+[WebPDFView PDFKitBundle]):
              (+[WebPDFView PDFViewClass]):
              (-[WebPDFView _menuItemsFromPDFKitForEvent:]):
              * WebView/WebTextRepresentation.m:
              * WebView/WebTextView.m:
              * WebView/WebUnarchivingState.m:
              * WebView/WebView.m:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14021 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      817a67b2
  19. 19 Apr, 2006 1 commit
    • thatcher's avatar
      Reviewed by Timothy. · 87e718c5
      thatcher authored
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8442
              Bug 8442: improvements to Cocoa bindings support in WebView - code simplification
      
              Removes the WebController class added earlier; changes NSTreeController and 
              WebView to together without it. Now you can just bind the contentObject binding
              of the tree controller directly to the mainFrameDocument key of the WebView.
      
              * WebCoreSupport/WebFrameBridge.m:
              (-[WebFrameBridge windowObjectCleared]):
              * WebView/WebDataSource.m:
              (-[WebDataSource _setTitle:]):
              * WebView/WebFrame.m:
              (-[WebFrame _closeOldDataSources]):
              * WebView/WebView.m:
              (-[WebView _progressStarted:]):
              (-[WebView _finalProgressComplete]):
              (-[WebView _commonInitializationWithFrameName:groupName:]):
              (-[WebView setMainFrameDocumentReady:]):
              (-[WebView mainFrameDocument]):
              * WebView/WebViewPrivate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13980 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87e718c5
  20. 05 Apr, 2006 1 commit
    • mjs's avatar
      Reviewed by Eric. · 98f00f91
      mjs authored
              
              - start on factoring WebArchive unpacking more into a separate class.
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8208
              
              * WebKit.xcodeproj/project.pbxproj:
              * WebView/WebDataSource.m:
              (-[WebDataSourcePrivate dealloc]):
              (-[WebDataSource _addToUnarchiveState:]):
              (-[WebDataSource _popSubframeArchiveWithName:]):
              (-[WebDataSource _documentFragmentWithArchive:]):
              (-[WebDataSource _setupForReplaceByMIMEType:]):
              (-[WebDataSource subresourceForURL:]):
              * WebView/WebDataSourcePrivate.h:
              * WebView/WebFrame.m:
              (-[WebFrame _loadRequest:archive:]):
              (-[WebFrame loadRequest:]):
              (-[WebFrame loadArchive:]):
              * WebView/WebFramePrivate.h:
              * WebView/WebHTMLRepresentation.m:
              (-[WebHTMLRepresentation loadArchive]):
              * WebView/WebUnarchivingState.h: Added.
              * WebView/WebUnarchivingState.m: Added.
              (-[WebUnarchivingState init]):
              (-[WebUnarchivingState addArchive:]):
              (-[WebUnarchivingState archivedResourceForURL:]):
              (-[WebUnarchivingState popSubframeArchiveWithFrameName:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13714 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98f00f91
  21. 29 Mar, 2006 1 commit
    • tomernic's avatar
      Reviewed by John Sullivan. · ee44ccbc
      tomernic authored
              <rdar://problem/4495316> REGRESSION (420+): After page has loaded, spinning progress indicator is displayed on
              tab at versiontracker.com
      
              * WebView/WebFrame.m:
              (-[WebFrame _receivedMainResourceError:]):
              Call -_clientRedirectCancelledOrFinished: here so that the frame load delegate is notified that the redirect's
              status has changed, if there was a redirect.  The frame load delegate may have saved some state about
              the redirect in its -webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:.  Since we are definitely
              not going to use this provisional resource, as it was cancelled, notify the frame load delegate that the redirect
              has ended.
              The fix for 4432562 was similar to this, but only took care of the case where the redirect load was actually
              committed to the frame.  The new call to -_clientRedirectCancelledOrFinished: handles the case where the redirect
              load was successful, but was not committed.  This happens with downloads.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13564 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee44ccbc
  22. 23 Mar, 2006 1 commit
    • tomernic's avatar
      Reviewed by John Sullivan. · 1f01d489
      tomernic authored
              At John's suggestion, renamed a private WebFrame method and tightened up some of the redirect logic I recently touched.
      
              * WebView/WebFramePrivate.h:
              Renamed -_clientRedirectCancelled: to -_clientRedirectCancelledOrFinished:, since we call this both when a redirect is
              cancelled and when a redirect is successfully committed.
              * WebCoreSupport/WebFrameBridge.m:
              (-[WebFrameBridge reportClientRedirectCancelled:]):
              Call renamed WebFrame method.
              * WebView/WebFrame.m:
              Added sentRedirectNotification flag to WebFramePrivate.  This flag is set when we notify the frame load delegate that a
              redirect will occur.  We check this flag when committing a provisional load to ensure that the frame load delegate is
              notified that the redirect finished.
              (-[WebFrame _commitProvisionalLoad:]):
              After committing a provisional load, make sure that the frame load delegate is notified that there is no longer a pending
              redirect.
              (-[WebFrame _clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
              Set the new sentRedirectNotification flag.
              (-[WebFrame _clientRedirectCancelledOrFinished:]):
              Renamed method.
              Clear the sentRedirectNotification flag.
              (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
              Call renamed method.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13459 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f01d489
  23. 22 Mar, 2006 2 commits
    • tomernic's avatar
      Reviewed by Kevin Decker. · ee17f001
      tomernic authored
              Even better fix for <rdar://problem/4432562>.  We need to notify the frame delegate of a finished redirect for both
              "fast" and "slow" redirects, after committing the load.  My previous change only notified for "fast", history-locking
              redirects.  Now we notify the frame delegate after committing any kind of provisional load, not just in the case of
              a fast redirect.
      
              * WebView/WebFrame.m:
              (-[WebFrame _transitionToCommitted:]):
              (-[WebFrame _commitProvisionalLoad:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13446 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee17f001
    • tomernic's avatar
      WebCore: · 39d2c918
      tomernic authored
              Reviewed by Kevin Decker.
      
              Part of <rdar://problem/4351664> REGRESSION (420+): extra URL in b/f list - navigating back to previous page fails at apple.com/retail/)
              This also fixes <rdar://problem/4477821> REGRESSION (10.4.5-TOT): meta tag specifying refresh is being added to history.
      
              * bridge/mac/FrameMac.h:
              * bridge/mac/FrameMac.mm:
              Removed redirectionTimerFired().  This was added as attempt to fix <http://bugzilla.opendarwin.org/show_bug.cgi?id=7058>.  The
              aim was to cause Safari and WebKit to update their loading status after a redirect.  Unfortunately, the fix had a bad side
              effect.  Calling -reportClientRedirectCancelled: on a successful redirect causes WebKit to forget that the redirect was supposed
              to lock history (i.e. reuse the current back/forward entry for the new page).  The end result was that intermediate "quick" redirects
              were creating back/forward entries when they should not have been.  See 4351664.  That fix was almost correct, in that we do need to
              notify the frame load delegate when a redirect ends, either because it succeeded or because it was cancelled.  However, this is the
              wrong place to do it.  WebCore's redirect notification logic did not need to change to fix 7058.  The never-ending spinning indicators
              problem was actually caused by a bug at the WebKit level.
      
              * manual-tests/redirectHistory: Added.
              * manual-tests/redirectHistory/redir-1.html: Added.
              * manual-tests/redirectHistory/redir-2.html: Added.
              * manual-tests/redirectHistory/redir-3.html: Added.
              Manual test case.  I couldn't figure out how to create a layout test for this, because it involves navigation through history and
              it was unclear how/when to tell DumpRenderTree to dump its output.
      
      WebKit:
      
              Reviewed by Kevin Decker.
      
              Better fix for <rdar://problem/4432562> REGRESSION (TOT): Safari's "stop loading" active, "view source" inactive after page load [7058]
      
              * WebView/WebFrame.m:
              (-[WebFrame _transitionToCommitted:]):
              Cancel the client redirect when we commit the provisional load, if we were waiting for a redirect.
              This is a better fix for 7058 (<rdar://problem/4432562>).  The original fix for 7058 changed the timing of the redirect cancel
              in such a way that WebKit was precluded from ever reusing back/forward list entries for redirects.  Clearing the redirect state
              here actually makes logical sense, as the redirect's target page is being committed at this point.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13441 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39d2c918
  24. 13 Mar, 2006 1 commit
    • ggaren's avatar
      Reviewed by timo. · df4bbbc2
      ggaren authored
              - Fixed the load progress indicator to give more incremental feedback, 
              and to stop spending so much time near 100%.
      
              I did two things:
              (1) Fixed some bugs and a misspelling in the previous heuristic's 
              implementation
              (2) Added two new rules to the heuristic:
                  (a) Treat the first layout as the half-way point.
                  (b) Just like we jump the first 10% to indicate that a load has
                  started, jump the last 10% to indicate that a load has finished.
      
              Rule 2a is good for two reasons. First, it seems unnatural for loading
              to be "more than half done" when you can't even see anything. Second,
              in the early stages of laading our estimate of how much we'll need to
              load is often off by as much as 6000% (e.g., cnn.com). So anything that
              makes the progress indicator more conservative in the early stages of 
              loading is helpful.
      
              Rule 2b is good because it's confusing for loading to be "100% done"
              but still ongoing.
      
              FIXME: The indicator still isn't perfect. For example, the old behavior
              shows up @ moviefone.com. Two areas for future work:
              (1) Estimate number of linked resources. Our code estimates the size
              of a single resource, but does nothing to estimate the number of
              resources that resource might link to. This is the key to why we're
              so wrong at the beginning.
              (2) Improve "when to do first layout" heuristic. A JavaScript query
              for a style property forces layout, creating a phantom first layout 
              with no content, essentially nullifying 2a for certain pages.
              
              Filed <rdar://problem/4475834> to track estimating the number of 
              linked resources. Phantom layouts are already on Hyatt's radar.
      
              * WebView/WebFrame.m:
              (-[WebFrame _setState:]): Update firstLayoutDone
              (-[WebFrame _numPendingOrLoadingRequests:]): Bug fix: In the recurisve 
              case, query 'frame' instead of 'self', so that we actually recurse.
              (-[WebFrame _firstLayoutDone]): New method
              (-[WebFrame _didFirstLayout]): Update firstLayoutDone
              * WebView/WebFramePrivate.h: Added firstLayoutDone ivar
              * WebView/WebView.m:
              (-[WebView _incrementProgressForConnectionDelegate:data:]):
              (1) Implemented 2a and 2b
              (2) Bug fix: only update the 'last time I sent a notification' time if 
              we actually send a notification.
              (3) Don't test for progress < 0 because ensuring progress < max
              also ensures max - progress > 0. (Do still test for progress > max 
              because rounding errors make that a possibility -- although a very 
              minor one.)
              (4) Query only the loading frame and its subframes for pending
              requests instead of defaulting to the main frame. This is a slight
              optimization in cases where the main frame did not begin the load,
              and it makes the code more consistent.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13269 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df4bbbc2
  25. 10 Mar, 2006 1 commit
    • darin's avatar
      Reviewed by Geoff. · 4bb68d1e
      darin authored
              - change how frame namespacing works to be more completely on the WebCore side
      
              * WebView/WebFrameInternal.h: Remove _setFrameNamespace: and _frameNamespace.
              * WebView/WebFrame.m: Ditto.
      
              * WebView/WebView.m:
              (-[WebView setGroupName:]): Call -[WebCorePageBridge setGroupName:].
              (-[WebView groupName]): Call -[WebCorePageBridge groupName].
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13258 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4bb68d1e
  26. 26 Feb, 2006 1 commit
    • ggaren's avatar
      LayoutTests: · 3d8c094b
      ggaren authored
              Test by Geoff, automated by me, reviewed by Darin.
      
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7293
                REGRESSION: Using Javascript Bookmarklets that reference location.href on a blank tab crashes WebKit
      
              * fast/frames/empty-frame-document-expected.txt: Added.
              * fast/frames/empty-frame-document.html: Added.
      
      WebKit:
      
              Test: fast/frames/empty-frame-document.html
      
              Reviewed by Darin.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7293
                REGRESSION: Using Javascript Bookmarklets that reference location.href on a blank tab crashes WebKit
      
              The crash happened because an empty frame did not have a document.
      
              * WebView/WebFrame.m:
              (-[WebFrame _commitProvisionalLoad:]): Use "about:blank" instead of an empty URL for empty
              frames. This causes a document to be created for the frame.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d8c094b
  27. 19 Feb, 2006 1 commit
    • darin's avatar
      WebCore: · 3d938e6d
      darin authored
              Reviewed by Maciej.
      
              - cut out a little unneeded bridge code
      
              * bridge/mac/WebCoreFrameBridge.h: Removed frame name from createWindowWithURL: method
              and changed it to return a page bridge. Also made createModalDialogWithURL: method
              return a page bridge. Removed the mainFrame and webView methods.
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge nextFrameWithWrap:]): Use page to get to main frame.
              (-[WebCoreFrameBridge setFrameNamespace:]): Ditto.
              (-[WebCoreFrameBridge frameNamespace]): Ditto.
              (-[WebCoreFrameBridge _shouldAllowAccessFrom:]): Ditto.
              (-[WebCoreFrameBridge _frameInAnyWindowNamed:sourceFrame:]): Ditto.
              (-[WebCoreFrameBridge findFrameNamed:]): Ditto.
              (-[WebCoreFrameBridge installInFrame:]): Ditto.
      
              * bridge/mac/WebCorePageBridge.h: Added outerView method to replace webView method
              on the frame bridge.
      
              * bridge/mac/BrowserExtensionMac.mm: (WebCore::Brow...
      3d938e6d
  28. 18 Feb, 2006 1 commit
    • mjs's avatar
      Not reviewed. · 5b268e6b
      mjs authored
              
              - fix build broken by my last checkin, the remaining code was not doing anything.
      
              * WebView/WebDataSource.m:
              * WebView/WebDataSourcePrivate.h:
              * WebView/WebFrame.m:
              (-[WebFrame _createPageCacheForItem:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12884 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b268e6b
  29. 14 Feb, 2006 1 commit
    • mjs's avatar
      Reviewed by Anders. · ac5003ea
      mjs authored
              
              Improvements to frame loading:
              
              - remove LayoutAcceptable state entirely
              - fix WebImageView to work right without LayoutAcceptable state
              - move guts of commitIfReady: to WebFrame
              - try to separate page cache loading from normal loading a bit more
      
              * English.lproj/StringsNotToBeLocalized.txt:
              * WebView/WebDataSource.m:
              (-[WebDataSource _prepareForLoadStart]):
              (-[WebDataSource _loadFromPageCache:]):
              (-[WebDataSource _startLoading]):
              (-[WebDataSource _commitIfReady]):
              (-[WebDataSource _setupForReplaceByMIMEType:]):
              * WebView/WebDataSourcePrivate.h:
              * WebView/WebFrame.m:
              (-[WebFrame _transitionToCommitted:]):
              (-[WebFrame _commitProvisionalLoad:]):
              (-[WebFrame _checkLoadCompleteForThisFrame]):
              (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
              * WebView/WebFramePrivate.h:
              * WebView/WebImageRepresentation.h:
              * WebView/WebImageRepresentation.m:
              * WebView/WebImageView.m:
              (-[WebImageView dataSourceUpdated:]):
              (-[WebImageView setNeedsLayout:]):
              (-[WebImageView writeImageToPasteboard:types:]):
              (-[WebImageView copy:]):
              (-[WebImageView mouseDragged:]):
              * WebView/WebView.m:
              (-[WebView _finishedLoadingResourceFromDataSource:]):
              (-[WebView _mainReceivedBytesSoFar:fromDataSource:complete:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12811 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac5003ea
  30. 06 Feb, 2006 3 commits
    • mjs's avatar
      Rubber stamped by Hyatt. · cf09000b
      mjs authored
              
              - renamed subproject directories to not end with .subproj
      
              * Carbon: renamed from Carbon.subproj
              * DOM: renamed from DOM.subproj
              * History: renamed from History.subproj
              * Misc: renamed from Misc.subproj
              * Panels: renamed from Panels.subproj
              * Plugins: renamed from Plugins.subproj
              * WebCoreSupport: renamed from WebCoreSupport.subproj
              * WebInspector: renamed from WebInspector.subproj
              * WebView: renamed from WebView.subproj
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf09000b
    • mjs's avatar
      Ooops, I made a last-minute change to my last patch that broke the build - fixed. · acf1d952
      mjs authored
              * WebView.subproj/WebFrame.m:
              (-[WebFrame _closeOldDataSources]):
              (-[WebFrame _detachFromParent]):
              (-[WebFrame _transitionToCommitted:]):
              (-[WebFrame _checkLoadCompleteForThisFrame]):
              (-[WebFrame _handledOnloadEvents]):
              (-[WebFrame _loadItem:withLoadType:]):
              (-[WebFrame _goToItem:withLoadType:]):
              (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formState:]):
              (-[WebFrame _clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
              (-[WebFrame _clientRedirectCancelled:]):
              * WebView.subproj/WebFramePrivate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      acf1d952
    • mjs's avatar
      Reviewed by Darin. · cf12068c
      mjs authored
              
              - shuffle things around so that WebFrame no longer has a WebView backpointer, the backpointer is
              at the bridge level.
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7093
      
              * WebCoreSupport.subproj/WebFrameBridge.h:
              * WebCoreSupport.subproj/WebFrameBridge.m:
              (-[WebFrameBridge initWithPage:webView:frameName:view:]):
              (-[WebFrameBridge page]):
              (-[WebFrameBridge mainFrame]):
              (-[WebFrameBridge webView]):
              (-[WebFrameBridge createWindowWithURL:frameName:]):
              (-[WebFrameBridge showWindow]):
              (-[WebFrameBridge areToolbarsVisible]):
              (-[WebFrameBridge setToolbarsVisible:]):
              (-[WebFrameBridge isStatusbarVisible]):
              (-[WebFrameBridge setStatusbarVisible:]):
              (-[WebFrameBridge setWindowFrame:]):
              (-[WebFrameBridge windowFrame]):
              (-[WebFrameBridge setWindowContentRect:]):
              (-[WebFrameBridge windowContentRect]):
              (-[WebFrameBridge setWindowIsResizable:]):
              (-[WebFrameBridge windowIsResizable]):
              (-[WebFrameBridge firstResponder]):
              (-[WebFrameBridge makeFirstResponder:]):
              (-[WebFrameBridge closeWindowSoon]):
              (-[WebFrameBridge runJavaScriptAlertPanelWithMessage:]):
              (-[WebFrameBridge runJavaScriptConfirmPanelWithMessage:]):
              (-[WebFrameBridge canRunBeforeUnloadConfirmPanel]):
              (-[WebFrameBridge runBeforeUnloadConfirmPanelWithMessage:]):
              (-[WebFrameBridge runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]):
              (-[WebFrameBridge addMessageToConsole:]):
              (-[WebFrameBridge runOpenPanelForFileButtonWithResultListener:]):
              (-[WebFrameBridge setStatusText:]):
              (-[WebFrameBridge startLoadingResource:withURL:customHeaders:]):
              (-[WebFrameBridge startLoadingResource:withURL:customHeaders:postData:]):
              (-[WebFrameBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
              (-[WebFrameBridge focusWindow]):
              (-[WebFrameBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]):
              (-[WebFrameBridge userAgentForURL:]):
              (-[WebFrameBridge _nextKeyViewOutsideWebFrameViewsWithValidityCheck:]):
              (-[WebFrameBridge previousKeyViewOutsideWebFrameViews]):
              (-[WebFrameBridge defersLoading]):
              (-[WebFrameBridge setDefersLoading:]):
              (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]):
              (-[WebFrameBridge _preferences]):
              (-[WebFrameBridge selectWordBeforeMenuEvent]):
              (-[WebFrameBridge historyLength]):
              (-[WebFrameBridge canGoBackOrForward:]):
              (-[WebFrameBridge goBackOrForward:]):
              (-[WebFrameBridge print]):
              (-[WebFrameBridge pollForAppletInView:]):
              (-[WebFrameBridge respondToChangedContents]):
              (-[WebFrameBridge respondToChangedSelection]):
              (-[WebFrameBridge undoManager]):
              (-[WebFrameBridge issueCutCommand]):
              (-[WebFrameBridge issueCopyCommand]):
              (-[WebFrameBridge issuePasteCommand]):
              (-[WebFrameBridge issuePasteAndMatchStyleCommand]):
              (-[WebFrameBridge canPaste]):
              (-[WebFrameBridge overrideMediaType]):
              (-[WebFrameBridge isEditable]):
              (-[WebFrameBridge shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
              (-[WebFrameBridge shouldBeginEditing:]):
              (-[WebFrameBridge shouldEndEditing:]):
              (-[WebFrameBridge windowObjectCleared]):
              (-[WebFrameBridge spellCheckerDocumentTag]):
              (-[WebFrameBridge isContinuousSpellCheckingEnabled]):
              (-[WebFrameBridge didFirstLayout]):
              (-[WebFrameBridge dashboardRegionsChanged:]):
              (-[WebFrameBridge createModalDialogWithURL:]):
              (-[WebFrameBridge canRunModal]):
              (-[WebFrameBridge runModal]):
              * WebCoreSupport.subproj/WebPageBridge.h:
              * WebCoreSupport.subproj/WebPageBridge.m:
              (-[WebPageBridge initWithMainFrameName:webView:frameView:]):
              (-[WebPageBridge webView]):
              * WebView.subproj/WebDataSource.m:
              (-[WebDataSource _fileWrapperForURL:]):
              (-[WebDataSource _webView]):
              (-[WebDataSource _setLoading:]):
              (-[WebDataSource _startLoading:]):
              (-[WebDataSource _setTitle:]):
              (-[WebDataSource _setRequest:]):
              (-[WebDataSource _updateIconDatabaseWithURL:]):
              (-[WebDataSource _defersCallbacksChanged]):
              (-[WebDataSource _setWebFrame:]):
              * WebView.subproj/WebDataSourcePrivate.h:
              * WebView.subproj/WebFrame.m:
              (-[WebFrame _traverseNextFrameStayWithin::]):
              (-[WebFrame _detachFromParent]):
              (-[WebFrame _setDataSource:]):
              (-[WebFrame _loadDataSource:withLoadType:formState:]):
              (-[WebFrame _initWithWebFrameView:webView:bridge:]):
              (-[WebFrame dealloc]):
              (-[WebFrame finalize]):
              (-[WebFrame webView]):
              * WebView.subproj/WebFrameView.m:
              (-[WebFrameView _webView]):
              (-[WebFrameView _goBack]):
              (-[WebFrameView _goForward]):
              * WebView.subproj/WebFrameViewInternal.h:
              * WebView.subproj/WebView.m:
              (-[WebView _createFrameNamed:inParent:allowsScrolling:]):
              (-[WebView _commonInitializationWithFrameName:groupName:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12592 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf12068c
  31. 25 Jan, 2006 1 commit
    • vicki's avatar
      Reviewed by Beth Dakin. · 953dbea8
      vicki authored
      	- fix <rdar://problem/4351664> REGRESSION (420+): extra URL in b/f list - navigating back to 
      	previous page fails at apple.com/retail/)
       
              * WebView.subproj/WebFrame.m:
              (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): grab the 
      	redirect flag of the current load before calling _loadURL, which clears this flag, 
              (-[WebFrame _transitionToCommitted:]): remove misleading comment
              * History.subproj/WebHistoryItem.m:
              (-[WebHistoryItem setURL:]): release resources in the page cache when setting
              the URL on a WebHistoryItem
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      953dbea8
  32. 18 Jan, 2006 1 commit
  33. 13 Jan, 2006 2 commits
    • mjs's avatar
      WebCore: · 037e2a7c
      mjs authored
              Rubber stamped by Eric.
      
              - rename WebCoreBridge to WebCoreFrameBridge
      
              * WebCore.exp:
              * WebCore.xcodeproj/project.pbxproj:
              * bridge/mac/KWQKHTMLPartBrowserExtension.mm:
              (KHTMLPartBrowserExtension::createNewWindow):
              * bridge/mac/MacFrame.h:
              (MacFrame::bridge):
              * bridge/mac/MacFrame.mm:
              (MacFrame::submitForm):
              (MacFrame::createPart):
              (MacFrame::bridgeForWidget):
              (MacFrame::documentViewForNode):
              (MacFrame::setBridge):
              * bridge/mac/WebCoreBridge.h: Removed.
              * bridge/mac/WebCoreBridge.mm: Removed.
              * bridge/mac/WebCoreFrameBridge.h: Added.
              * bridge/mac/WebCoreFrameBridge.mm: Added.
              (-[WebCoreFrameBridge executionContextForView:]):
              (frameHasSelection):
              (-[WebCoreFrameBridge firstChild]):
              (-[WebCoreFrameBridge lastChild]):
              (-[WebCoreFrameBridge previousSibling]):
              (-[WebCoreFrameBridge nextSibling]):
              (-[WebCoreFrameBridge isDescendantOfFrame:]):
              (-[WebCoreFrameBridge traverseNextFrameStayWithin:]):
              (-[WebCoreFrameBridge appendChild:]):
              (-[WebCoreFrameBridge removeChild:]):
              (-[WebCoreFrameBridge childFrameNamed:]):
              (-[WebCoreFrameBridge _deepLastChildFrame]):
              (-[WebCoreFrameBridge nextFrameWithWrap:]):
              (-[WebCoreFrameBridge previousFrameWithWrap:]):
              (-[WebCoreFrameBridge _shouldAllowAccessFrom:]):
              (-[WebCoreFrameBridge _descendantFrameNamed:sourceFrame:]):
              (-[WebCoreFrameBridge _frameInAnyWindowNamed:sourceFrame:]):
              (-[WebCoreFrameBridge findFrameNamed:]):
              (+[WebCoreFrameBridge bridgeForDOMDocument:]):
              (-[WebCoreFrameBridge setParent:]):
              (-[WebCoreFrameBridge parent]):
              (nowPrinting):
              (-[WebCoreFrameBridge opener]):
              (-[WebCoreFrameBridge setOpener:]):
              (+[WebCoreFrameBridge stringWithData:textEncodingName:]):
              * kwq/KWQAccObject.mm:
              (-[KWQAccObject rendererForView:]):
              * kwq/KWQComboBox.mm:
              (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]):
              * kwq/KWQFileButton.mm:
              (KWQFileButton::focusPolicy):
              * kwq/KWQFrame.mm:
              * kwq/KWQKJavaAppletWidget.mm:
              * kwq/KWQLineEdit.mm:
              * kwq/KWQListBox.mm:
              (-[KWQTableView keyDown:]):
              (-[KWQTableView keyUp:]):
              * kwq/KWQLoader.mm:
              (KWQServeRequest):
              (KWQServeSynchronousRequest):
              (KWQCheckCacheObjectStatus):
              (KWQCacheObjectExpiresTime):
              * kwq/KWQSlider.mm:
              (QSlider::focusPolicy):
              * kwq/KWQTextArea.mm:
              (-[KWQTextAreaTextView textDidChange:]):
              (-[KWQTextAreaTextView _trackResizeFromMouseDown:]):
              (-[KWQTextAreaTextView keyDown:]):
              (-[KWQTextAreaTextView keyUp:]):
              * kwq/KWQTextField.mm:
              (-[KWQTextFieldController controlTextDidBeginEditing:]):
              (-[KWQTextFieldController controlTextDidEndEditing:]):
              (-[KWQTextFieldController controlTextDidChange:]):
              (-[KWQTextFieldController control:textView:doCommandBySelector:]):
              (-[KWQTextFieldController textView:shouldHandleEvent:]):
              * kwq/KWQWidget.mm:
              (QWidget::setFocus):
              * kwq/KWQWindowWidget.h:
              * kwq/KWQWindowWidget.mm:
              (KWQWindowWidget::KWQWindowWidget):
              * kwq/WebCoreFrameNamespaces.h:
              * kwq/WebCoreFrameNamespaces.m:
              (+[WebCoreFrameNamespaces addFrame:toNamespace:]):
              * kwq/WebCoreFrameView.h:
              * kwq/WebCoreSettings.mm:
              * kwq/WebCoreTextRendererFactory.mm:
              * kwq/WebCoreViewFactory.h:
      
      WebKit:
      
              Rubber stamped by Eric.
      
              - rename WebBridge to WebFrameBridge
              
              - also removed all tabs from WebFrameBridge.m
      
              * DOM.subproj/WebDOMOperations.m:
              (-[DOMNode _bridge]):
              (-[DOMNode webArchive]):
              (-[DOMRange _bridge]):
              (-[DOMRange webArchive]):
              * DOM.subproj/WebDOMOperationsPrivate.h:
              * English.lproj/StringsNotToBeLocalized.txt:
              * Misc.subproj/WebCoreStatistics.m:
              * Misc.subproj/WebNSViewExtras.h:
              * Misc.subproj/WebNSViewExtras.m:
              (-[NSView _bridge]):
              * Plugins.subproj/WebBaseNetscapePluginView.m:
              * Plugins.subproj/WebNetscapePluginEmbeddedView.m:
              * Plugins.subproj/WebNetscapePluginStream.m:
              (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]):
              * Plugins.subproj/WebPluginContainerCheck.m:
              (-[WebPluginContainerCheck _isForbiddenFileLoad]):
              * Plugins.subproj/WebPluginController.h:
              * Plugins.subproj/WebPluginController.m:
              (-[WebPluginController bridge]):
              * WebCoreSupport.subproj/WebBridge.h: Removed.
              * WebCoreSupport.subproj/WebBridge.m: Removed.
              * WebCoreSupport.subproj/WebFileButton.h:
              * WebCoreSupport.subproj/WebFileButton.m:
              (-[WebFileChooserButton initWithBridge:delegate:]):
              * WebCoreSupport.subproj/WebFrameBridge.h: Added.
              * WebCoreSupport.subproj/WebFrameBridge.m: Added.
              (-[WebFrameBridge mainFrame]):
              (-[WebFrameBridge createWindowWithURL:frameName:]):
              (-[WebFrameBridge canTargetLoadInFrame:]):
              (-[WebFrameBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]):
              (formDelegate):
              (-[WebFrameBridge createModalDialogWithURL:]):
              * WebCoreSupport.subproj/WebSubresourceLoader.m:
              * WebCoreSupport.subproj/WebTextRendererFactory.m:
              * WebCoreSupport.subproj/WebViewFactory.m:
              (-[WebViewFactory bridgeForView:]):
              * WebKit.xcodeproj/project.pbxproj:
              * WebView.subproj/WebDataSource.m:
              (-[WebDataSource _bridge]):
              (-[WebDataSource _receivedMainResourceError:complete:]):
              (-[WebDataSource _stringWithData:]):
              * WebView.subproj/WebDataSourcePrivate.h:
              * WebView.subproj/WebDebugDOMNode.m:
              * WebView.subproj/WebDefaultContextMenuDelegate.m:
              * WebView.subproj/WebFrame.m:
              (-[WebFrame _traverseNextFrameStayWithin::]):
              (Frame):
              (-[WebFrame _detachFromParent]):
              (-[WebFrame _bridge]):
              (-[WebFrame _initWithWebFrameView:webView:bridge:]):
              * WebView.subproj/WebFrameInternal.h:
              * WebView.subproj/WebFramePrivate.h:
              * WebView.subproj/WebFrameView.m:
              (-[WebFrameView webCoreBridge]):
              (-[WebFrameView _bridge]):
              * WebView.subproj/WebHTMLRepresentation.m:
              (+[WebHTMLRepresentation supportedMIMETypes]):
              (-[WebHTMLRepresentation _bridge]):
              (-[WebHTMLRepresentation documentSource]):
              * WebView.subproj/WebHTMLRepresentationPrivate.h:
              * WebView.subproj/WebHTMLView.m:
              (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
              (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:]):
              (-[WebHTMLView updateFocusState]):
              (-[NSArray validateUserInterfaceItem:]):
              (-[NSArray attributedString]):
              (-[NSArray selectedAttributedString]):
              (-[NSArray concludeDragForDraggingInfo:actionMask:]):
              (-[NSArray keyDown:]):
              (-[NSArray _alterCurrentSelection:direction:granularity:]):
              (-[NSArray _alterCurrentSelection:verticalDistance:]):
              (-[NSArray _expandSelectionToGranularity:]):
              (-[NSArray cut:]):
              (-[NSArray _applyStyleToSelection:withUndoAction:]):
              (-[NSArray _applyParagraphStyleToSelection:withUndoAction:]):
              (-[NSArray pasteAsPlainText:]):
              (-[NSArray insertNewline:]):
              (-[NSArray insertLineBreak:]):
              (-[NSArray insertParagraphSeparator:]):
              (-[NSArray _changeWordCaseWithSelector:]):
              (-[NSArray startSpeaking:]):
              (-[NSArray selectToMark:]):
              (-[NSArray swapWithMark:]):
              (-[NSArray transpose:]):
              (-[WebHTMLView characterIndexForPoint:]):
              (-[WebHTMLView firstRectForCharacterRange:]):
              (-[WebHTMLView selectedRange]):
              (-[WebHTMLView attributedSubstringFromRange:]):
              (-[WebHTMLView _selectMarkedText]):
              (-[WebHTMLView _selectRangeInMarkedText:]):
              (-[WebHTMLView setMarkedText:selectedRange:]):
              (-[WebHTMLView _selectionIsInsideMarkedText]):
              (-[WebTextCompleteController _insertMatch:]):
              (-[WebTextCompleteController doCompletion]):
              (-[WebTextCompleteController endRevertingChange:moveLeft:]):
              * WebView.subproj/WebHTMLViewPrivate.h:
              * WebView.subproj/WebImageView.m:
              * WebView.subproj/WebMainResourceLoader.m:
              * WebView.subproj/WebRenderNode.m:
              * WebView.subproj/WebResource.m:
              (-[WebResource _stringValue]):
              * WebView.subproj/WebScriptDebugDelegate.m:
              * WebView.subproj/WebTextView.m:
              * WebView.subproj/WebView.m:
              (-[WebView _createFrameNamed:inParent:allowsScrolling:]):
              (-[WebView _commonInitializationWithFrameName:groupName:]):
              (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]):
              (-[WebView moveDragCaretToPoint:]):
              (-[WebView shouldClose]):
              (-[WebView editableDOMRangeForPoint:]):
              (-[WebView setEditable:]):
              (-[WebView deleteSelection]):
              (-[WebView _bridgeForSelectedOrMainFrame]):
              (-[WebView _bridgeAtPoint:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12072 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      037e2a7c
    • darin's avatar
      - Replaced tabs with spaces in source files that had less than 10 lines with tabs. · 36ddd0eb
      darin authored
              - Set allow-tabs Subversion property in source files that have more than 10 lines with tabs.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12070 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36ddd0eb
  34. 09 Jan, 2006 2 commits
    • ggaren's avatar
      small terminology fixup recommended in review · 35ce022e
      ggaren authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11969 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35ce022e
    • ggaren's avatar
      LayoutTests: · 97b3e001
      ggaren authored
              Layout tests for
      
              <rdar://problem/4268278> Submitting a form in onUnload event handler 
              causes crash in -[WebDataSource(WebPrivate) _commitIfReady:].)
      
              and
      
              -  http://bugzilla.opendarwin.org/show_bug.cgi?id=6331
              REGRESSION: form events don't fire after back/forward navigation, 
              due to inconsistent load state
      
              * fast/loader/form-events-back-forward-expected.txt: Added.
              * fast/loader/form-events-back-forward.html: Added.
              * fast/loader/onunload-form-submit-crash-expected.txt: Added.
              * fast/loader/onunload-form-submit-crash.html: Added.
              * fast/loader/resources/onunload-form-submit-crash2.html: Added.
      
      WebKit:
      
              Reviewed by Darin.
              
              - Second cut at fixing <rdar://problem/4268278> Submitting a form 
              in onUnload event handler causes crash in 
              -[WebDataSource(WebPrivate) _commitIfReady:].)
      
              - Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=6331
              REGRESSION: form events don't fire after back/forward navigation, 
              due to inconsistent load state
              
              * WebView.subproj/WebDataSource.m:
              (-[WebDataSource _stopLoading]): 
              (1) If there are no resource loaders to signal the WebView that we've
              been canceled, manufacture the signal. Otherwise, the cancel gets 
              ignored and nobody cleans up after the load. (We signal the WebView but
              not the WebFrame because we don't want the WebFrame to tear down the 
              DataSource.  Unlike most canceled DataSources, this one has valid data 
              because it's in the back/forward cache.)
              (2) Update _private->stopping before returning because if the 
              DataSource is in the back/forward cache it can be reused, so it 
              needs to be in a consistent state. (We never encountered this 
              situation before because we would always crash first.)
              (-[WebDataSource _commitLoadWithData:]): Move _commitIfReady call 
              inside retain block because the commit may cause an unload event 
              to fire, which may start a new load, deallocating the current 
              DataSource. (This is the same reason the rest of the function is 
              in the retain block.)
              * WebView.subproj/WebFrame.m:
              (-[WebFrame _transitionToCommitted:]): If the unload handler 
              started a new load, return early to avoid stomping it.
              (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): 
              Undo previous incorrect fix.
              (-[WebFrame stopLoading]): Remove misleading comment. Setting 
              provisionalDataSource to nil is not optional but required for 
              internal consistency.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11963 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97b3e001