1. 30 May, 2012 18 commits
    • commit-queue@webkit.org's avatar
      [BlackBerry] Browser crashed when selecting in textarea · f3ccf122
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87484
      
      The function FatFingers::checkForText() uses host node's whole text
      to checkFingerIntersection(). We should not give the text of shadow
      nodes to it.
      
      Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2012-05-30
      Reviewed by Antonio Gomes.
      
      * WebKitSupport/FatFingers.cpp:
      (BlackBerry::WebKit::FatFingers::getNodesFromRect): Avoid returning
      shadow nodes when the context is Text node.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118912 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3ccf122
    • commit-queue@webkit.org's avatar
      Web Inspector: Fix JS compiler warning · 083e7945
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87836
      
      Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-05-30
      Reviewed by Yury Semikhatsky.
      
      * inspector/front-end/SettingsScreen.js: Fix method annotation.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      083e7945
    • kenneth@webkit.org's avatar
      [Qt] Variable renaming as preparation of further refactoring. · b71fa243
      kenneth@webkit.org authored
      Rubberstamped by Simon Hausmann.
      
      Change m_viewport to m_viewportItem and m_content to m_pageItem.
      
      * UIProcess/qt/QtViewportInteractionEngine.cpp:
      (WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
      (WebKit::QtViewportInteractionEngine::setItemRectVisible):
      (WebKit::QtViewportInteractionEngine::animateItemRectVisible):
      (WebKit::QtViewportInteractionEngine::flickableMoveStarted):
      (WebKit::QtViewportInteractionEngine::flickableMoveEnded):
      (WebKit::QtViewportInteractionEngine::flickableMovingPositionUpdate):
      (WebKit::QtViewportInteractionEngine::scaleAnimationStateChanged):
      (WebKit::QtViewportInteractionEngine::pagePositionRequest):
      (WebKit::QtViewportInteractionEngine::computePosRangeForItemAtScale):
      (WebKit::QtViewportInteractionEngine::focusEditableArea):
      (WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
      (WebKit::QtViewportInteractionEngine::nearestValidBounds):
      (WebKit::QtViewportInteractionEngine::reset):
      (WebKit::QtViewportInteractionEngine::setCSSScale):
      (WebKit::QtViewportInteractionEngine::currentCSSScale):
      (WebKit::QtViewportInteractionEngine::scrollAnimationActive):
      (WebKit::QtViewportInteractionEngine::panGestureActive):
      (WebKit::QtViewportInteractionEngine::panGestureStarted):
      (WebKit::QtViewportInteractionEngine::panGestureRequestUpdate):
      (WebKit::QtViewportInteractionEngine::panGestureEnded):
      (WebKit::QtViewportInteractionEngine::panGestureCancelled):
      (WebKit::QtViewportInteractionEngine::cancelScrollAnimation):
      (WebKit::QtViewportInteractionEngine::pinchGestureStarted):
      (WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
      (WebKit::QtViewportInteractionEngine::scaleContent):
      * UIProcess/qt/QtViewportInteractionEngine.h:
      (QtViewportInteractionEngine):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118910 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b71fa243
    • zoltan@webkit.org's avatar
      [Qt] Set WebCore imagedecoders as default and add fallback to QImageDecoder · 891b02a4
      zoltan@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=80400
      
      Source/WebCore:
      
      This change modifies the default ImageDecoder for Qt-port from QImageDecoder to WebCore ImageDecoder.
      The new behavior is to use QImageDecoder only if WebCoreImageDecoder - and the platform - doesn't support
      the requested image type.
      The WTF_USE_QT_IMAGE_DECODER macro has been removed, since it is no longer needed.
      
      This change adds build depedency (except Qt-MAC and Qt-WIN platform) for libpng-dev and libjpeg-dev packages,
      because PNG and JPEG imagedecoders need not only these libraries, but their headers also. Qmake-config
      tests for these libraries were introduced in r110045.
      
      Notice: with using libjpeg-turbo as a system library I measured 10% performance improvement on Methanol benchmark
      (collection of popular sites, page-loading benchmark) with this patch.
      
      Reviewed by Simon Hausmann.
      
      No new tests needed.
      
      * Target.pri: Move WebCore ImageDecoder files out of guards. Remove ImageFrameQt.cpp from sources.
      * WebCore.pri: Move WebCore ImageDecoder include paths out of guards.
      * platform/MIMETypeRegistry.cpp:
      (WebCore::initializeSupportedImageMIMETypes): Add WebCore supported and Qt supported MIME types.
      (WebCore::initializeSupportedImageMIMETypesForEncoding): Use Qt supported MIME types.
      * platform/graphics/ImageSource.cpp: Remove unnecessary includes.
      * platform/graphics/ImageSource.h: Remove unnecessary typedefs.
      (WebCore):
      * platform/graphics/qt/ImageDecoderQt.cpp: Remove ImageDecoder::create, since it is no longer needed.
      (WebCore::ImageDecoderQt::filenameExtension): Remove unnecessary semicolon.
      (WebCore::ImageDecoderQt::internalHandleCurrentImage): Use QImage and ImageFrame instead of QPixmap.
      (WebCore):
      (WebCore::ImageFrame::asNewNativeImage): Moved here from removed ImageFrameQt.cpp.
      * platform/image-decoders/ImageDecoder.cpp: Reorganize the includes of the header.
      (WebCore::ImageDecoder::create): Add platform macro guarded fallback case for QImageDecoder. Add guards
      for JPEG, PNG, ICO decoder for Qt-MAC and Qt-WIN platform.
      * platform/image-decoders/ImageDecoder.h: Remove Qt-specific codes.
      (WebCore::ImageFrame::getAddr): Remove Qt-specific case, since it is no longer needed.
      (ImageFrame):
      * platform/image-decoders/qt/ImageFrameQt.cpp: Removed. Dead code, other code has been moved to
      ImageDecoderQt.cpp.
      
      Source/WebKit/blackberry:
      
      Get rid of QT_IMAGE_DECODER flag.
      
      Reviewed by Simon Hausmann.
      
      * WebCoreSupport/AboutDataEnableFeatures.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118909 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      891b02a4
    • commit-queue@webkit.org's avatar
      [Qt][WK2] Do not use anonymous variables for ViewportUpdateDeferrer. · 4f08abb3
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87831
      
      Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-05-30
      Reviewed by Kenneth Rohde Christiansen.
      
      * UIProcess/qt/QtViewportInteractionEngine.cpp:
      (WebKit::QtViewportInteractionEngine::pagePositionRequest):
      (WebKit::QtViewportInteractionEngine::cancelScrollAnimation):
      (WebKit::QtViewportInteractionEngine::itemSizeChanged):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118908 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f08abb3
    • kinuko@chromium.org's avatar
      REGRESSION: We should allow null modificationTime when snapshot metadata is given · a492ad08
      kinuko@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=86811
      
      Reviewed by Jian Li.
      
      r117432 has introduced a new File constructor which allows the caller
      to pass in a snapshot file metadata. In the change we had considered the
      given metadata is valid if "metadata.length >= 0 AND metadata.lastModifiedDate != 0",
      but we should drop the latter condition (lastModifiedDate != 0) because
      
      1. the value 0 is used to indicate the time information is unavailable in File, and
      2. it is valid per spec (http://dev.w3.org/2006/webapi/FileAPI/#dfn-lastModifiedDate says the UA must return null if the information is not available).
      
      (Note: the current js/v8 binding returns Date(0) for the time value 0,
      which is still valid as epoch time but would fail to indicate the
      unavailability of the information. In this patch I added FIXME in
      File.idl and filed a separate issue http://webkit.org/b/87709)
      
      No new tests as this change does not affect regular files/filesystems behavior.
      (Tests in Chrome OS port should be able to verify this)
      
      * fileapi/File.cpp:
      (WebCore::File::lastModifiedDate):
      (WebCore::File::size):
      (WebCore::File::captureSnapshot):
      * fileapi/File.h:
      (File):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118907 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a492ad08
    • ossy@webkit.org's avatar
      [Qt] Gardening. Shadow DOM is disabled on Qt. · 28db0843
      ossy@webkit.org authored
      Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-05-30
      Reviewed by Csaba Osztrogonác.
      
      * platform/qt/Skipped: Skip fast/dom/shadow/shadow-element.html.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118906 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28db0843
    • commit-queue@webkit.org's avatar
      Update test expectations for tests duplicated in Skipped · 64a1aac1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87822
      
      Unreviewed gardening; updating test expectations.
      
      Patch by David Barr <davidbarr@chromium.org> on 2012-05-30
      
      * platform/mac/Skipped:
      * platform/mac/test_expectations.txt:
      * platform/qt/Skipped:
      * platform/qt/test_expectations.txt:
      * platform/qt-5.0-wk1/Skipped:
      * platform/qt-mac/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118905 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64a1aac1
    • carlosgc@webkit.org's avatar
      Unreviewed. Fix WebKit2GTK+ API tests in the bots. · ee71c77b
      carlosgc@webkit.org authored
      * UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
      (testWebViewCanShowMIMEType): Remove the check for multimedia and
      plugins MIME types since they depend on the configuration and they
      are not available in the bots.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee71c77b
    • commit-queue@webkit.org's avatar
      [GTK] Update test expectations after r118841. · 9433b2fe
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87827
      
      Unreviewed gardening; updating test expectations
      
      Patch by David Barr <davidbarr@chromium.org> on 2012-05-30
      
      * platform/gtk/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118903 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9433b2fe
    • morrita@google.com's avatar
      [Shadow DOM] HTMLContentElement and HTMLShadowElement constructors should be visible. · 0575337b
      morrita@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=87818
      
      Source/WebCore:
      
      Reviewed by Kentaro Hara.
      
      Added them as DOMWindow properties
      
      Tests: fast/dom/shadow/content-element-api.html
             fast/dom/shadow/shadow-element.html
      
      * page/DOMWindow.idl:
      
      LayoutTests:
      
      Added constructor checks.
      
      Reviewed by Kentaro Hara.
      
      * fast/dom/shadow/content-element-api-expected.txt:
      * fast/dom/shadow/content-element-api.html:
      * fast/dom/shadow/shadow-element-expected.txt:
      * fast/dom/shadow/shadow-element.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118902 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0575337b
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r118868. · 4ac40e0d
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/118868
      https://bugs.webkit.org/show_bug.cgi?id=87828
      
      introduced ~20 crashes on Mac and Qt bots (Requested by pizlo_
      on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-30
      
      * heap/Heap.cpp:
      (JSC::Heap::collect):
      * heap/MarkedBlock.cpp:
      (JSC::MarkedBlock::sweep):
      * heap/MarkedBlock.h:
      (JSC::MarkedBlock::sweepWeakSet):
      (JSC):
      * heap/MarkedSpace.cpp:
      (JSC::SweepWeakSet::operator()):
      (JSC):
      (JSC::MarkedSpace::sweepWeakSets):
      * heap/MarkedSpace.h:
      (MarkedSpace):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ac40e0d
    • mikelawther@chromium.org's avatar
      CSS3 calc: Implement CSSOM support · d4102362
      mikelawther@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84551
      
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      Adds a pretty printer for the calc expression tree.
      
      Test: css3/calc/cssom.html
      
      * css/CSSCalculationValue.cpp:
      (WebCore::CSSCalcValue::customCssText):
      (WebCore::CSSCalcPrimitiveValue::customCssText):
      (WebCore::CSSCalcBinaryOperation::customCssText):
      (CSSCalcBinaryOperation):
      * css/CSSCalculationValue.h:
      (CSSCalcExpressionNode):
      
      LayoutTests:
      
      * css3/calc/cssom-expected.txt: Added.
      * css3/calc/cssom.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118900 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4102362
    • haraken@chromium.org's avatar
      [perf-test] Add a benchmark for querySelector() · 2061b653
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87742
      
      Reviewed by Ryosuke Niwa.
      
      Now I am optimizing querySelector() (bug 87625).
      This patch adds a performance test for querySelector().
      query-selector-first.html queries an element that appears
      at the head of the document. On the other hand,
      query-selector-last.html queries an element that appears
      at the tail of the document.
      
      Test results in my desktop:
      
      [query-selector-first.html]
      RESULT Parser: query-selector-first= 252.339803014 runs/s
      median= 253.646265594 runs/s, stdev= 2.32610873209 runs/s, min= 248.138957816 runs/s, max= 254.777070064 runs/s
      
      RESULT Parser: query-selector-first= 252.688468897 runs/s
      median= 252.684876579 runs/s, stdev= 3.60008778708 runs/s, min= 246.002460025 runs/s, max= 258.397932817 runs/s
      
      RESULT Parser: query-selector-first= 253.466019656 runs/s
      median= 254.129606099 runs/s, stdev= 1.78002675664 runs/s, min= 247.831474597 runs/s, max= 254.777070064 runs/s
      
      RESULT Parser: query-selector-first= 256.245078189 runs/s
      median= 257.06940874 runs/s, stdev= 2.84722072201 runs/s, min= 249.687890137 runs/s, max= 259.74025974 runs/s
      
      RESULT Parser: query-selector-first= 252.203100497 runs/s
      median= 252.047989175 runs/s, stdev= 1.75233446036 runs/s, min= 248.138957816 runs/s, max= 255.427841635 runs/s
      
      [query-selector-last.html]
      RESULT Parser: query-selector-last= 356.009616076 runs/s
      median= 355.781448539 runs/s, stdev= 0.841519086864 runs/s, min= 354.430379747 runs/s, max= 358.056265985 runs/s
      
      RESULT Parser: query-selector-last= 360.735271001 runs/s
      median= 361.057532424 runs/s, stdev= 1.12253219867 runs/s, min= 358.514724712 runs/s, max= 362.225097025 runs/s
      
      RESULT Parser: query-selector-last= 359.598592463 runs/s
      median= 359.435173299 runs/s, stdev= 0.816538258728 runs/s, min= 358.056265985 runs/s, max= 360.824742268 runs/s
      
      RESULT Parser: query-selector-last= 357.260651715 runs/s
      median= 357.598978289 runs/s, stdev= 1.17393159885 runs/s, min= 353.982300885 runs/s, max= 358.974358974 runs/s
      
      RESULT Parser: query-selector-last= 351.696240713 runs/s
      median= 351.980025916 runs/s, stdev= 1.14200564038 runs/s, min= 348.692403487 runs/s, max= 353.535353535 runs/s
      
      * Parser/query-selector-first.html: Added.
      * Parser/query-selector-last.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118899 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2061b653
    • ossy@webkit.org's avatar
      [Qt] Modified ORWT and NRWT to check for test expectations in platform/qt-5.0-wk1 too · e3292d4a
      ossy@webkit.org authored
      (They only used to check for Skipped in platform/qt-5.0-wk1)
      https://bugs.webkit.org/show_bug.cgi?id=87376
      
      Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-05-29
      Reviewed by Csaba Osztrogonác.
      
      * Scripts/old-run-webkit-tests:
      (buildPlatformResultHierarchy):
      * Scripts/webkitpy/layout_tests/port/qt.py:
      (QtPort.baseline_search_path):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118898 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3292d4a
    • commit-queue@webkit.org's avatar
      [FileAPI] The result attribute of FileReader shuold use null to replace empty string · 88110554
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87578
      
      Patch by Li Yin <li.yin@intel.com> on 2012-05-29
      Reviewed by Jian Li.
      
      Source/WebCore:
      
      Spec: http://www.w3.org/TR/FileAPI/#dfn-result
      If the readyState is EMPTY (no read method has been called) or an error
      in reading the File or Blob has occurred (using any read method), then the
      result attribute MUST return null.
      
      Currently, Firefox11, Opera and IE 10 follows the spec, but Webkit based
      browser doesn't.
      WebKit should change the returned value empty string into null to keep
      conformance with the spec.
      
      Tests: fast/files/read-file-async.html
             fast/files/workers/worker-read-file-async.html
      
      * fileapi/FileReader.cpp:
      (WebCore::FileReader::arrayBufferResult):
      (WebCore::FileReader::stringResult):
      
      LayoutTests:
      
      Spec: http://www.w3.org/TR/FileAPI/#dfn-result
      If the readyState is EMPTY (no read method has been called) or an error in
      reading the File or Blob has occurred (using any read method), then the result
      attribute MUST return null.
      
      Currently, webkit return empty string, not null.
      
      * fast/files/read-file-async-expected.txt:
      * fast/files/resources/read-common.js:
      (logResult):
      (loadFailed):
      * fast/files/resources/read-file-test-cases.js:
      (testReadAgainAfterFailedReadStep1):
      * fast/files/workers/worker-read-file-async-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118897 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88110554
    • jer.noble@apple.com's avatar
      Noticeable delay taking an HTML5 trailer fullscreen. · 7655fadd
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=87794
      
      Reviewed by Darin Adler.
      
      Work around a not-entirely understood delay when using the results of a CGWindowListCreateImage()
      call as the contents of a placeholder view.  The backing of the resulting CGImageRef resides on
      the WindowServer, and drawing that image requires synchronous calls to the WindowServer process.
      By copying the image data, up front, into our own process, we can avoid those synchronous calls
      later and avoid the delay-causing drawing behavior.
      
      * UIProcess/mac/WKFullScreenWindowController.mm:
      (CGImageDeepCopy): Added a helper function which copies the image data into a new CGImage.
      (-[WKFullScreenWindowController enterFullScreen:]): Use the above.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118896 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7655fadd
    • commit-queue@webkit.org's avatar
      [BlackBerry] The Page's deviceScaleFactor() is not being properly maintained · c7043e7c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87817
      
      Patch by Max Feil <mfeil@rim.com> on 2012-05-29
      Reviewed by Antonio Gomes.
      
      This bug fix in WebKit/blackberry is needed by the changes for
      fullscreen media control sizing in WebCore (bug 87551). The sizing
      of controls depends on the page's deviceScaleFactor(), which was
      not being maintained properly due to errors in logic. Viewport
      changes from non-default to default were being erroneously
      thrown out. Also, when the viewport did change back to default
      the deviceScaleFactor was not being updated.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
      (BlackBerry::WebKit::WebPagePrivate::dispatchViewportPropertiesDidChange):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118895 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7043e7c
  2. 29 May, 2012 22 commits
    • pilgrim@chromium.org's avatar
      [Chromium] Move fileExists to Platform.h · 679dda06
      pilgrim@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87531
      
      Reviewed by Adam Barth.
      
      Call fileExists through fileUtilities(), not directly.
      
      Source/Platform:
      
      * chromium/public/Platform.h:
      (Platform):
      
      Source/WebCore:
      
      * platform/chromium/FileSystemChromium.cpp:
      (WebCore::fileExists):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118894 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      679dda06
    • tkent@chromium.org's avatar
      [Chromium] Test expectation update. · e647161d
      tkent@chromium.org authored
      Rebaseline for placeholder-related tests.
      
      * platform/chromium-linux/fast/forms/date/date-appearance-expected.txt:
      * platform/chromium-linux/fast/forms/input-placeholder-paint-order-expected.png: Added.
      * platform/chromium-linux/fast/forms/placeholder-position-expected.png:
      * platform/chromium-linux/fast/forms/search-styled-expected.txt:
      * platform/chromium-linux/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
      * platform/chromium-mac-leopard/fast/forms/input-placeholder-paint-order-expected.png: Added.
      * platform/chromium-mac-leopard/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/forms/input-placeholder-paint-order-expected.txt: Removed.
      * platform/chromium-mac-snowleopard/fast/forms/textarea/textarea-placeholder-paint-order-expected.txt: Removed.
      * platform/chromium-mac/fast/css/text-overflow-input-expected.png:
      * platform/chromium-mac/fast/forms/date/date-appearance-expected.txt:
      * platform/chromium-mac/fast/forms/input-placeholder-paint-order-expected.png: Added.
      * platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.txt:
      * platform/chromium-mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
      * platform/chromium-mac/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
      * platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
      * platform/chromium-win/fast/css/text-overflow-input-expected.txt:
      * platform/chromium-win/fast/forms/date/date-appearance-expected.txt:
      * platform/chromium-win/fast/forms/input-placeholder-paint-order-expected.png: Added.
      * platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
      * platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
      * platform/chromium-win/fast/forms/placeholder-position-expected.txt:
      * platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
      * platform/chromium-win/fast/forms/search-styled-expected.txt:
      * platform/chromium-win/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
      * platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt:
      * platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt:
      * platform/chromium-win/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118893 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e647161d
    • haraken@chromium.org's avatar
      Remove a dummy style sheet from CSSParser::parseFlowThread() · 57950234
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87715
      
      Reviewed by Darin Adler.
      
      r118736 changed CSSGrammar.y so that it works fine with no style sheet.
      r118736 removed a dummy style sheet from CSSParser::parserSelector().
      Now we can safely remove a dummy style sheet from parserFlowThread().
      
      Tests: fast/regions. No change in test results.
      
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseFlowThread):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118892 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      57950234
    • yosin@chromium.org's avatar
      REGRESSION(r111497): The "option" element doesn't match CSS pseudo class :enabled · db050d73
      yosin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87719
      
      Reviewed by Kent Tamura.
      
      Source/WebCore:
      
      This patch added checking of "option" element for CSS pseudo class :enabled as same as
      :disabled to selector checker. Before r111497, it was done by using isFormControlElement.
      After that revision, HTMLOptionElement was no longer derived from HTMLFormControlElement.
      
      Test: fast/form/select/optgroup-rendering.html
      
      * css/SelectorChecker.cpp:
      (WebCore::SelectorChecker::checkOneSelector): Checking element is option element as same
      as PseudoDisabled in PseudoEnabled case.
      
      LayoutTests:
      
      * platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.png: Updated. Text color of option element is bule from CSS pseudo class option:enabled.
      * platform/chromium/test_expectations.txt: Update comment.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118891 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db050d73
    • hayato@chromium.org's avatar
      Introduces ComposedShadowTreeParentWalker, extracted from ComposedShadowTreeWalker. · b7d6f802
      hayato@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87004
      
      Reviewed by Dimitri Glazkov.
      
      Introduces a ComposedShadowTreeParentWalker, which is only used
      for traversing a parent node (including shadow roots and insertion
      points) and get rid of an equivalent function from
      ComposedShadowTreeWalker.
      
      Before this patch, there is an inconsistency inside of
      ComposedShadowTreeWalker. The Walker uses 'Policy' to decide
      whether it should visit shadow roots or not, but
      parentIncludingInsertionPointAndShadowRoot() member function
      ignores the policy.  We can not add an assertion in its
      constructor due to this inconsistency.  To resolve it, we could
      add yet another special policy, but that makes the implementation
      complex and may add some overhead in runtime.  So separate the
      functionality into another class as ComposedShadowTreeParentWalker.
      
      No new tests, no new functionality except for assertion.
      
      * dom/ComposedShadowTreeWalker.cpp:
      (WebCore::ComposedShadowTreeWalker::ComposedShadowTreeWalker):
      (WebCore::ComposedShadowTreeParentWalker::ComposedShadowTreeParentWalker):
      (WebCore):
      (WebCore::ComposedShadowTreeParentWalker::parentIncludingInsertionPointAndShadowRoot):
      (WebCore::ComposedShadowTreeParentWalker::traverseParentIncludingInsertionPointAndShadowRoot):
      * dom/ComposedShadowTreeWalker.h:
      (ComposedShadowTreeWalker):
      (WebCore::ComposedShadowTreeWalker::assertPrecondition):
      (WebCore):
      (ComposedShadowTreeParentWalker):
      (WebCore::ComposedShadowTreeParentWalker::get):
      * dom/EventDispatcher.cpp:
      (WebCore::EventRelatedTargetAdjuster::adjust):
      (WebCore::EventDispatcher::ensureEventAncestors):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::updateMouseEventTargetNode):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118890 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7d6f802
    • hayato@chromium.org's avatar
      Add assertions to make sure that event's target and relatedTarget are accessible. · cfba43b6
      hayato@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87641
      
      Reviewed by Dimitri Glazkov.
      
      No new tests. No new functionality except for assertions.
      
      * dom/EventContext.cpp:
      (WebCore::EventContext::EventContext):
      * dom/EventContext.h:
      (WebCore):
      (EventContext):
      (WebCore::EventContext::setRelatedTarget):
      (WebCore::EventContext::accessible):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118889 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cfba43b6
    • tkent@chromium.org's avatar
      Fix inefficient usage of traverseNextNode() · 560ec954
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87804
      
      Reviewed by Ryosuke Niwa.
      
      foo->traverseNextNode(foo) is equivalent to foo->firstChild(), and
      firstChild() is more efficient.
      
      No new tests because of no behavior change.
      
      * html/HTMLFieldSetElement.cpp:
      (WebCore::HTMLFieldSetElement::invalidateDisabledStateUnder):
      Replace traverseNextNode() with firstChild(), and shorten a variable name.
      * svg/SVGSVGElement.cpp:
      (WebCore::SVGSVGElement::getElementById):
      Replace traverseNextNode() with firstChild().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118888 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      560ec954
    • commit-queue@webkit.org's avatar
      [BlackBerry] Loading media data with http authentication · 54f7a01f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84214
      
      Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-05-29
      Reviewed by George Staikos.
      
      .:
      
      Added a manual test case which needs user to provide a HTTP server
      with HTTP authentication support when loading the specified media
      resource. The test case will test if the media resource is successfully
      loaded.
      
      * ManualTests/blackberry/video-load-with-authentication.html: Added.
      
      Source/WebCore:
      
      RIM PR: 117618
      Implemented http authentication feature for media by implementing
      two interface functions in class MediaPlayerPrivate:
      onAuthenticationNeeded(): this function is triggered when MMR
      engine requires http authentication. We search the CredentialStorage
      to see if we have already stored existing credential information,
      or challenge user to provide it.
      OnAuthenticationAccepted(): this function is triggered when MMR
      engine accepts the credential information, and we need to save
      it in CredentialStorage for later use.
      
      Internally reviewed by Max Feil <mfeil@qnx.com>.
      
      Manual test case: blackberry/video-load-with-authentication.html
      
      * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
      (WebCore::generateProtectionSpaceFromMMRAuthChallenge):
      (WebCore):
      (WebCore::MediaPlayerPrivate::onAuthenticationNeeded):
      (WebCore::MediaPlayerPrivate::onAuthenticationAccepted):
      * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
      (MediaPlayerPrivate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118887 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54f7a01f
    • morrita@google.com's avatar
      [Shadow DOM] Node distribution should be orthogonal from node attachment · 89c8aeea
      morrita@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=87223
      
      Reviewed by Dimitri Glazkov.
      
      This chagne reorganizes Shadow DOM subtree distribution implementation.
      
      Originally, it was interleaved across attach() of several classes like
      InsertionPoint and ShadowRoot. Its invalidation was also mixed as a part of
      the style recalculation and detach()-es.
      
      This change extracts these bits of code to a set of ContentDistributor methods, which are
      facaded by two ElementShadow API. Following two API are the primary entry points:
      
      - ElementShadow::ensureDistribution()
      - ElementShadow::invalidateDistribution()
      
      The actual implementations are ContentDistributor::distribute() and
      ContentDistributor::invalidate() respectively.
      
      When clients need to traverse composed tree, before attach() for
      example, they should call ensureDistribution() to make sure that
      the traversal data structure ("the distribution") is ready.  When
      there is any DOM mutation which can result a composed tree
      mutation, then clients should call invalidateDistribution() to
      mark the distribution being dated.
      
      Here are such DOM mutations:
      
      - The children of any ShadowRoots are changed,
      - The children of any InsertionPoints are changed,
      - The children of any host elements are changed,
      - Any insertion point is inserted to or removed from the shadow tree,
      - @select attribute of <content> is modified and
      - New ShadowRoot is added to the shadow tree.
      
      Note that the validity of the distribution is tracked and
      unnecessary distribution requests are ignored.
      
      After the invalidation, that shadow subtrees are detached once and
      request  their  re-attachment  through  the  style  recalculation.
      Then,  on the  responding  style recalculation  and attach(),  new
      distribution will be computed.
      
      No new tests. Covered by existing tests.
      
      * dom/Element.cpp:
      (WebCore::Element::~Element):
      (WebCore::Element::childrenChanged):
      * dom/ElementShadow.cpp:
      (WebCore::ElementShadow::~ElementShadow):
      (WebCore::ElementShadow::addShadowRoot):
      (WebCore::ElementShadow::removeAllShadowRoots):
      (WebCore::ElementShadow::attach):
      (WebCore::ElementShadow::recalcStyle):
      (WebCore::ElementShadow::ensureDistribution):
      (WebCore::ElementShadow::invalidateDistribution):
      * dom/ElementShadow.h:
      (ElementShadow):
      * dom/NodeRenderingContext.cpp:
      (WebCore::NodeRenderingContext::NodeRenderingContext):
      (WebCore::NodeRendererFactory::createRendererIfNeeded):
      * dom/NodeRenderingContext.h:
      (NodeRenderingContext):
      * dom/ShadowRoot.cpp:
      (WebCore::ShadowRoot::setApplyAuthorStyles):
      (WebCore::ShadowRoot::attach):
      (WebCore::ShadowRoot::childrenChanged):
      (WebCore):
      * dom/ShadowRoot.h:
      (ShadowRoot):
      * html/HTMLFormControlElement.cpp:
      * html/ValidationMessage.cpp:
      (WebCore::ValidationMessage::buildBubbleTree):
      * html/shadow/ContentDistributor.cpp:
      (WebCore::ContentDistributor::ContentDistributor):
      (WebCore::ContentDistributor::~ContentDistributor):
      (WebCore::ContentDistributor::findInsertionPointFor):
      (WebCore::ContentDistributor::distribute):
      (WebCore::ContentDistributor::invalidate):
      (WebCore::ContentDistributor::finishInivalidation):
      (WebCore::ContentDistributor::distributeSelectionsTo):
      (WebCore::ContentDistributor::distributeShadowChildrenTo):
      (WebCore::ContentDistributor::invalidateDistributionIn):
      * html/shadow/ContentDistributor.h:
      (WebCore::ContentDistributor::needsInvalidation):
      (ContentDistributor):
      (WebCore::ContentDistributor::needsDistribution):
      * html/shadow/HTMLContentElement.cpp:
      (WebCore::HTMLContentElement::parseAttribute):
      * html/shadow/InsertionPoint.cpp:
      (WebCore::InsertionPoint::attach):
      (WebCore::InsertionPoint::detach):
      (WebCore::InsertionPoint::nextTo):
      (WebCore::InsertionPoint::previousTo):
      (WebCore::InsertionPoint::childrenChanged):
      * html/shadow/InsertionPoint.h:
      (WebCore::InsertionPoint::setDistribution):
      (WebCore::InsertionPoint::clearDistribution):
      (InsertionPoint):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89c8aeea
    • macpherson@chromium.org's avatar
      Implement post-landing feedback for WebKitCSSTransformValue::customCSSText(). · a9073a12
      macpherson@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87684
      
      Reviewed by Darin Adler.
      
      Darin provided some style suggesting on https://bugs.webkit.org/show_bug.cgi?id=87462 after it landed.
      This patch incorporates those suggestions, namely using 0 instead of empty string for UnknownTransformOperation
      and WTF_ARRAY_LENGTH instead of hard coding the array length.
      
      Covered by existing transform tests.
      
      * css/WebKitCSSTransformValue.cpp:
      (WebCore):
      (WebCore::WebKitCSSTransformValue::customCssText):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118885 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9073a12
    • ojan@chromium.org's avatar
      Add a linter error for pngs that lack an embedded checksum · a6a6a184
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87793
      
      Reviewed by Dirk Pranke.
      
      * Scripts/read-checksum-from-png:
      * Scripts/webkitpy/common/read_checksum_from_png.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png.py.
      (read_checksum):
      * Scripts/webkitpy/common/read_checksum_from_png_unittest.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py.
      (ReadChecksumFromPngTest):
      (ReadChecksumFromPngTest.test_read_checksum):
      * Scripts/webkitpy/layout_tests/port/base.py:
      * Scripts/webkitpy/style/checkers/png.py:
      (PNGChecker.check):
      * Scripts/webkitpy/style/checkers/png_unittest.py:
      (PNGCheckerTest.test_check):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118884 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a6a6a184
    • eric@webkit.org's avatar
      Fix ENABLE_IFRAME_SEAMLESS to actually fully disable <iframe seamless> · 8fe1b21c
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87646
      
      Reviewed by Adam Barth.
      
      In the process of moving the seamless feature out of github and into bugs.webkit.org
      multiple versions of the shouldDisplaySeamlessly function got written
      (and moved from HTMLIFrameElement to Document), but only one of them was wrapped
      in ENABLE_IFRAME_SEAMLESS.  HTMLIFrameElement was checking mayDisplaySeamlessly
      directly (as was my original design), which got around the ENABLE_IFRAME_SEAMLESS check.
      I've fixed this oversight, and the feature is now off when we tell it to be off.
      
      This is covered by many existing tests.  I've verified locally that
      all tests fail when ENABLE_IFRAME_SEAMLESS is disabled instead of
      only some of them.
      
      * dom/SecurityContext.h:
      (SecurityContext):
      * html/HTMLIFrameElement.cpp:
      (WebCore::HTMLIFrameElement::shouldDisplaySeamlessly):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118883 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8fe1b21c
    • ojan@chromium.org's avatar
      Show an error in the pretty diff when an image lacks a checksum · 26eac78b
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87791
      
      Reviewed by Dirk Pranke.
      
      * PrettyPatch/PrettyPatch.rb:
      * PrettyPatch/PrettyPatch_test.rb:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118882 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26eac78b
    • hayato@chromium.org's avatar
      Refactor shadow-dom-event-dispatching.html. · 05d904c9
      hayato@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87626
      
      Reviewed by Dimitri Glazkov.
      
      There are badly named functions in shadow-dom-event-dispatching.html.
      e.g. prepareDOMTree1, prepareDOMTree2 and so on.
      That should have better namings which make the intention of each test clear.
      
      * fast/dom/shadow/shadow-dom-event-dispatching.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118881 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05d904c9
    • commit-queue@webkit.org's avatar
      Fix warning in preprocessing Source/WebCore/dom/DOMError.idl · bfdb5d3a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87763
      
      Patch by Scott Graham <scottmg@chromium.org> on 2012-05-29
      Reviewed by Adam Barth.
      
      Add newline at end of file to avoid warning:
      ../dom/DOMError.idl:35:2: warning: no newline at end of file
      
      * dom/DOMError.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bfdb5d3a
    • pilgrim@chromium.org's avatar
      [Chromium] Move fileExists to Platform.h · d2d85ea7
      pilgrim@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87531
      
      Reviewed by Adam Barth.
      
      Part of a refactoring series. See tracking bug 82948.
      
      Source/Platform:
      
      * chromium/public/Platform.h:
      (WebKit::Platform::fileExists):
      (Platform):
      
      Source/WebCore:
      
      * platform/chromium/FileSystemChromium.cpp:
      (WebCore::fileExists):
      * platform/chromium/PlatformSupport.h:
      (PlatformSupport):
      
      Source/WebKit/chromium:
      
      * src/PlatformSupport.cpp:
      (WebCore):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118873 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2d85ea7
    • rakuco@webkit.org's avatar
      [EFL] Gardening after r118845 and r118851. · 162fff5c
      rakuco@webkit.org authored
      Apparently some baselines were not updated as expected, fixing
      that now.
      
      * platform/efl/fast/ruby/ruby-text-before-after-content-expected.png: Added.
      * platform/efl/fast/ruby/ruby-text-before-after-content-expected.txt:
      * platform/efl/fast/selectors/166-expected.png:
      * platform/efl/fast/selectors/166-expected.txt:
      * platform/efl/fast/selectors/unqualified-hover-strict-expected.png:
      * platform/efl/fast/selectors/unqualified-hover-strict-expected.txt: Added.
      * platform/efl/svg/batik/text/textAnchor-expected.txt:
      * platform/efl/svg/batik/text/textOnPath3-expected.txt:
      * platform/efl/svg/batik/text/verticalTextOnPath-expected.txt:
      * platform/efl/svg/carto.net/tabgroup-expected.txt:
      * platform/efl/transitions/cross-fade-background-image-expected.txt: Added.
      * platform/efl/transitions/cross-fade-border-image-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118871 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      162fff5c
    • ggaren@apple.com's avatar
      Rolled back in r118646, now that · 15344ae6
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=87784 is fixed.
      
      http://trac.webkit.org/changeset/118646
      https://bugs.webkit.org/show_bug.cgi?id=87599
      
      * heap/Heap.cpp:
      (JSC::Heap::collect):
      * heap/MarkedBlock.cpp:
      (JSC::MarkedBlock::sweep):
      * heap/MarkedBlock.h:
      (JSC):
      * heap/MarkedSpace.cpp:
      (JSC):
      * heap/MarkedSpace.h:
      (MarkedSpace):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118868 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15344ae6
    • haraken@chromium.org's avatar
      [V8] Rename v8Null() to v8NullWithCheck() · 883bb54d
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87713
      
      Reviewed by Adam Barth.
      
      In IRC, cmarcelo@ pointed out that v8::Null() and v8Null()
      are confusing. This patch renames v8Null() to v8NullWithCheck().
      
      No tests. No behavior change.
      
      * bindings/scripts/CodeGeneratorV8.pm:
      (GenerateHeader):
      * bindings/scripts/test/V8/V8TestActiveDOMObject.h:
      (WebCore::toV8):
      * bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
      (WebCore::toV8):
      * bindings/scripts/test/V8/V8TestEventConstructor.h:
      (WebCore::toV8):
      * bindings/scripts/test/V8/V8TestEventTarget.h:
      (WebCore::toV8):
      * bindings/scripts/test/V8/V8TestException.h:
      (WebCore::toV8):
      * bindings/scripts/test/V8/V8TestInterface.h:
      (WebCore::toV8):
      * bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
      (WebCore::toV8):
      * bindings/scripts/test/V8/V8TestNamedConstructor.h:
      (WebCore::toV8):
      * bindings/scripts/test/V8/V8TestNode.h:
      (WebCore::toV8):
      * bindings/scripts/test/V8/V8TestObj.h:
      (WebCore::toV8):
      * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
      (WebCore::toV8):
      * bindings/v8/V8Binding.h:
      (WebCore::v8NullWithCheck):
      (WebCore::v8DateOrNull):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118862 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      883bb54d
    • commit-queue@webkit.org's avatar
      Some Content Security Policy console messages are missing line numbers in JSC · 24a70122
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87558
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-29
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Make ScriptController::eventHandlerPosition() behave the same way on
      JSC than V8. This means that TextPosition::minimumPosition() is
      returned if parser is null, instead of
      TextPosition::belowRangePosition(). The line numbers are now correctly
      printed in the output of Content Security Policy tests.
      
      Tests: http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url.html
             http/tests/security/contentSecurityPolicy/javascript-url-blocked.html
      
      * bindings/js/ScriptController.cpp:
      (WebCore::ScriptController::eventHandlerPosition):
      
      LayoutTests:
      
      Remove Mac/EFL/GTK/Qt-specific expectations for Content Security Policy
      tests now that the line numbers are correctly printed.
      
      * platform/efl/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Removed.
      * platform/efl/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Removed.
      * platform/gtk/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Removed.
      * platform/gtk/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Removed.
      * platform/mac/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Removed.
      * platform/mac/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Removed.
      * platform/qt/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Removed.
      * platform/qt/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118861 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24a70122
    • slewis@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=87720 · c0599cb0
      slewis@apple.com authored
      WebProcess is often killed due to being unresponsive on the bots
      
      Reviewed by Alexey Proskuryakov.
      
      Blind attempt to improve flakiness on the bots by reducing the number
      of crashes due to an unresponsive process.  This helped on my personal machine
      under stress conditions.  I don't have enough cores to hit the problem
      under normal conditions.
      
      * WebKitTestRunner/TestController.cpp:
      (WTR):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118860 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0599cb0
    • andersca@apple.com's avatar
      String should be move enabled/optimized · 372f7d24
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=87596
      
      Reviewed by Andreas Kling.
      
      Add move constructors and move assignment operators to String and AtomicString when building with
      compilers that support rvalue references. This gets rid of ref-churn when the source of the
      constructor or assignment is a temporary object.
      
      * wtf/text/AtomicString.h:
      (AtomicString):
      (WTF::AtomicString::AtomicString):
      (WTF::AtomicString::operator=):
      * wtf/text/WTFString.h:
      (String):
      (WTF::String::String):
      (WTF::String::operator=):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118859 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      372f7d24