- 23 Jan, 2012 40 commits
-
-
eae@chromium.org authored
* http/tests/security/cross-frame-access-put-expected.txt: Updated expectations to reflect that window.frameElement now has the type HTMLIFrameElement. The test itself has already been updated. * platform/mac/fast/dom/Window/window-properties-expected.txt: Added window.applicationCache.abort method. * platform/mac/fast/dom/prototype-inheritance-2-expected.txt: Added DOMURL class. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=76791 Patch by Priit Laes <plaes@plaes.org> on 2012-01-23 Reviewed by Gustavo Noronha Silva. * GNUmakefile.am: Silence is golden... git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=76793 Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-01-23 Reviewed by Simon Hausmann. This patch implements support for accepting or rejecting invalid SSL certificates from the QML API. * UIProcess/API/qt/qquickwebview.cpp: (QQuickWebViewPrivate::QQuickWebViewPrivate): (QQuickWebViewPrivate::handleCertificateVerificationRequest): (QQuickWebViewExperimental::certificateVerificationDialog): (QQuickWebViewExperimental::setCertificateVerificationDialog): * UIProcess/API/qt/qquickwebview_p.h: * UIProcess/API/qt/qquickwebview_p_p.h: * UIProcess/PageClient.h: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::certificateVerificationRequest): * UIProcess/WebPageProxy.h: * UIProcess/WebPageProxy.messages.in: * UIProcess/qt/QtDialogRunner.cpp: (CertificateVerificationDialogContextObject::CertificateVerificationDialogContextObject): (CertificateVerificationDialogContextObject::hostname): (CertificateVerificationDialogContextObject::accept): (CertificateVerificationDialogContextObject::reject): (QtDialogRunner::initForCertificateVerification): * UIProcess/qt/QtDialogRunner.h: * UIProcess/qt/QtPageClient.cpp: (QtPageClient::handleCertificateVerificationRequest): * UIProcess/qt/QtPageClient.h: * WebProcess/qt/QtNetworkAccessManager.cpp: (WebKit::QtNetworkAccessManager::QtNetworkAccessManager): (WebKit::QtNetworkAccessManager::onSslErrors): * WebProcess/qt/QtNetworkAccessManager.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bweinstein@apple.com authored
Source/JavaScriptCore: * JavaScriptCore.exp: Tools: * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp: (TestWebKitAPI::TestNode::key): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=76695 Patch by Arko Saha <nghq36@motorola.com> on 2012-01-23 Reviewed by Hajime Morita. Changeset http://trac.webkit.org/changeset/103296 removed unused ExceptionCode& argument from Element::setAttribute(QualifiedName). Hence updating all calls to setAttribute() method in MicroData code. * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::setItemValueText): * html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::setItemValueText): * html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::setItemValueText): * html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::setItemValueText): * html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::setItemValueText): * html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::setItemValueText): * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setItemValueText): * html/HTMLMetaElement.cpp: (WebCore::HTMLMetaElement::setItemValueText): * html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::setItemValueText): * html/HTMLSourceElement.cpp: (WebCore::HTMLSourceElement::setItemValueText): * html/HTMLTrackElement.cpp: (WebCore::HTMLTrackElement::setItemValueText): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
levin@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=76750 Reviewed by Adam Roben. Source/WebKit/win: * FullscreenVideoController.cpp: (createCompatibleDCForWindow): Moved out the code which creates a DC for a window to keep the same scope for the DC lifetime. (FullscreenVideoController::draw): Switch to using OwnPtr<HDC> since createCompatibleDCForWindow returns a PassOwnPtr. * WebNodeHighlight.cpp: (WebNodeHighlight::update): Cleaned up leaks from calling GetDC without release. Note that there is a potential leak of hdc that previously existed and still does in an early exit scenario. (This could be easily fixed by using OwnPtr<HDC> but I was trying to keep this patch focused.) * WebView.cpp: (WebView::scrollBackingStore): Typical conversion. (WebView::updateBackingStore): Reduced the scope of windowDC to be right where it is being used. (WebView::performLayeredWindowUpdate): Typical conversion. (WebView::paintIntoBackingStore): Ditto. Source/WebKit2: * Shared/win/ShareableBitmapWin.cpp: (WebKit::ShareableBitmap::windowsContext): Fix incorrect usage of OwnPtr<HDC> which would do a DeleteDC instead of a ReleaseDC. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
* TestWebKitAPI/Tests/WTF/RedBlackTree.cpp: (TestWebKitAPI::TestNode::TestNode): (TestWebKitAPI::TestNode::key): (TestWebKitAPI::RedBlackTreeTest::assertEqual): (TestWebKitAPI::RedBlackTreeTest::assertSameValuesForKey): (TestWebKitAPI::RedBlackTreeTest::testDriver): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hayato@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=76656 Reviewed by Dimitri Glazkov. Source/WebCore: Test: fast/events/focus-remove-focuesed-node.html * dom/Document.cpp: (WebCore::Document::setFocusedNode): LayoutTests: * fast/events/focus-remove-focuesed-node-expected.txt: Added. * fast/events/focus-remove-focuesed-node.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
scherkus@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=76759 Reviewed by Eric Carlson. * media/audio-data-url-expected.txt: * media/audio-data-url.html: * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
http://trac.webkit.org/changeset/105658 https://bugs.webkit.org/show_bug.cgi?id=76883 We want this eventually, but not right at this moment (Requested by abarth on #webkit). Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-23 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jamesr@google.com authored
[chromium] Add <(SHARED_INTERMEDIATE_DIR)/webkit to include path of targets that depend on WebKit API so they pick up the copied headers in an onion build https://bugs.webkit.org/show_bug.cgi?id=76879 Reviewed by Dirk Pranke. * WebKit.gyp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
levin@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=76744 Reviewed by Adam Roben. Source/WebCore: No new functionality so no new tests. * platform/graphics/win/FontCacheWin.cpp: (WebCore::FontCache::getFontDataForCharacters): Changed GetDC to HWndDC and removed ReleaseDC. (WebCore::createGDIFont): Ditto. (WebCore::FontCache::getTraitsInFamily): Ditto. * platform/graphics/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData): Ditto. * platform/graphics/win/SimpleFontDataCGWin.cpp: (WebCore::SimpleFontData::platformInit): Ditto. * platform/graphics/win/SimpleFontDataWin.cpp: (WebCore::SimpleFontData::initGDIFont): Ditto. (WebCore::SimpleFontData::containsCharacters): Ditto. (WebCore::SimpleFontData::determinePitch): Ditto. (WebCore::SimpleFontData::boundsForGDIGlyph): Ditto. (WebCore::SimpleFontData::widthForGDIGlyph): Ditto. (WebCore::SimpleFontData::scriptFontProperties): Ditto. * platform/win/CursorWin.cpp: (WebCore::createSharedCursor): Ditto. * platform/win/DragImageCGWin.cpp: (WebCore::scaleDragImage): Ditto. (WebCore::createDragImageFromImage): Ditto. * platform/win/DragImageWin.cpp: (WebCore::createDragImageForLink): Ditto. * platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage): Ditto. Source/WebKit/win: * WebIconDatabase.cpp: (createDIB): Changed GetDC to HWndDC and removed ReleaseDC. Source/WebKit2: * UIProcess/win/WebView.cpp: (WebKit::WebView::flashBackingStoreUpdates): Typical conversion. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=76747 Patch by Martin Robinson <mrobinson@igalia.com> on 2012-01-23 Reviewed by Gustavo Noronha Silva. No new tests. Regressions are covered by existing tests, but testing different GTK+ theme configurations is not possible yet. * platform/gtk/ScrollbarThemeGtk.cpp: (WebCore::ScrollbarThemeGtk::backButtonRect): If there is no back stepper, return an empty rect. (WebCore::ScrollbarThemeGtk::forwardButtonRect): If there is no forward stepper, return an empty rect. (WebCore::ScrollbarThemeGtk::trackRect): Adjust track rect calculation to account for when there is no steppers. * platform/gtk/ScrollbarThemeGtk.h: New members describing whether there are primary steppers. * platform/gtk/ScrollbarThemeGtk2.cpp: (WebCore::ScrollbarThemeGtk::updateThemeProperties): Look at the theme to determine if there are primary foward and back steppers. * platform/gtk/ScrollbarThemeGtk3.cpp: (WebCore::ScrollbarThemeGtk::updateThemeProperties): Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=76878 Reviewed by Alexey Proskuryakov. Source/WebCore: Revert a part of r105396 that made performDragAndDrop not call clearDragState when the default action was not prevented since it caused a regression. I'm pretty certain always calling clearDragState in performDragAndDrop is wrong but I can't think of a test case where this becomes a problem at the moment. Since this area is not well tested, revert the change instead of making further changes to the code base. Tests: fast/events/clear-drag-state.html fast/events/clear-edit-drag-state.html * page/EventHandler.cpp: (WebCore::EventHandler::performDragAndDrop): LayoutTests: Add a regression test to ensure we don't fire extra dragenter event on the second drag at an element that contains the dragged content. * fast/events/clear-drag-state-expected.txt: Added. * fast/events/clear-drag-state.html: Added. * fast/events/clear-edit-drag-state-expected.txt: Added. * fast/events/clear-edit-drag-state.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=76880 Reviewed by Eric Seidel. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105658 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=76710 Patch by Thiago Marcos P. Santos <tmpsantos@gmail.com> on 2012-01-23 Reviewed by Alexey Proskuryakov. * dom/DOMCoreException.cpp: * fileapi/FileException.cpp: * storage/SQLTransaction.cpp: (WebCore::SQLTransaction::openTransactionAndPreflight): (WebCore::SQLTransaction::postflightAndCommit): * xml/XMLHttpRequestException.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105657 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
levin@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=76737 Reviewed by Adam Roben. No new functionality exposed so no new tests. * platform/win/HWndDC.h: Changed this slightly to allow for allocating a window DC after the initial creation since this pattern occurrs in several places so this makes it easy to replace them in an upcoming change. (WebCore::HWndDC::HWndDC): (WebCore::HWndDC::~HWndDC): (WebCore::HWndDC::setHWnd): (WebCore::HWndDC::clear): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105656 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=76703 Patch by Arko Saha <nghq36@motorola.com> on 2012-01-23 Reviewed by Hajime Morita. * dom/MicroDataItemList.cpp: (WebCore::MicroDataItemList::MicroDataItemList): (WebCore::MicroDataItemList::~MicroDataItemList): * dom/MicroDataItemList.h: * dom/NodeRareData.h: (WebCore::NodeRareData::properties): * html/HTMLPropertiesCollection.cpp: (WebCore::HTMLPropertiesCollection::create): (WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection): * html/HTMLPropertiesCollection.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
levin@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=76290 Reviewed by Dmitry Titov. * platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::createFontIndirectAndGetWinName): (WebCore::fontContainsCharacter): (WebCore::FontCache::getLastResortFallbackFont): (WebCore::FontCache::getTraitsInFamily): * platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: (WebCore::FontPlatformData::scriptFontProperties): * platform/graphics/chromium/FontUtilsChromiumWin.cpp: (WebCore::FontMap::getAscent): (WebCore::FontMap::getSpaceGlyph): * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: (WebCore::fillBMPGlyphs): * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph): * platform/graphics/chromium/UniscribeHelper.cpp: (WebCore::UniscribeHelper::EnsureCachedDCCreated): * rendering/RenderThemeChromiumWin.cpp: (WebCore::systemFontSize): (WebCore::pointsToPixels): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=76544 Patch by Seo Sanghyeon <sh4.seo@samsung.com> on 2012-01-23 Reviewed by Darin Adler. WEBKITOUTPUTDIR is not only for Windows. * building/build.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eae@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=76650 Reviewed by Darin Adler. * Scripts/webkitpy/style/checkers/cpp.py: (check_spacing): * Scripts/webkitpy/style/checkers/cpp_unittest.py: (CppStyleTest.test_operator_methods): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=76113 Also reduces flakiness by checking for a repaint between progress and suspend events versus just between progress events. Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-01-23 Reviewed by Adam Barth. * http/tests/media/video-buffering-repaints-controls-expected.txt: Added. * http/tests/media/video-buffering-repaints-controls.html: * platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.png: * platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed. * platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed. * platform/chromium/test_expectations.txt: * platform/gtk/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=76802 Reviewed by Tony Chang. Report errors whenever server's response doesn't match "OK". * Scripts/webkitpy/common/net/file_uploader.py: (FileUploader.upload_single_text_file): (FileUploader.upload_as_multipart_form_data): (FileUploader._upload_data.callback): (FileUploader): (FileUploader._upload_data): * Scripts/webkitpy/performance_tests/perftestsrunner.py: (PerfTestsRunner._upload_json): * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: (test_upload_json): (test_upload_json.MockFileUploader.upload_single_text_file): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Calling intersectsNode on a detached range should throw. Source/WebCore: INVALID_STATE_ERR exception should be thrown if intersectsNode is called on a detached Range. Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-23 Reviewed by Darin Adler. Test: fast/dom/Range/range-intersectsNode-exception.html * dom/Range.cpp: (WebCore::Range::intersectsNode): Throwing INVALID_STATE_ERR exception if the range is detached. LayoutTests: Added test case to verify the exception thrown while calling intersectsNode on a detached range. Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-23 Reviewed by Darin Adler. * fast/dom/Range/range-intersectsNode-exception-expected.txt: Added. * fast/dom/Range/range-intersectsNode-exception.html: Added. * fast/dom/Range/range-intersectsNode-expected.txt: * fast/dom/Range/resources/intersectsNode.js: Modified the test case to catch the exception. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dcheng@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=76856 When Qt implemented the DataTransferItemList, a lot of logic was moved into the shared classes since Chromium/Qt happened to implement it the same way. Now that I want to do some refactoring/cleanup work to better implement DataTransferItemList in Chromium, we won't share the same data anymore so it doesn't make sense to keep that code in a common location. Reviewed by David Levin. Covered by existing tests. * CMakeLists.txt: * GNUmakefile.list.am: * Target.pri: * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * dom/DataTransferItem.cpp: * dom/DataTransferItem.h: * dom/DataTransferItemList.cpp: Removed. * dom/DataTransferItemList.h: * platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::mayUpdateItems): * platform/chromium/DataTransferItemChromium.cpp: (WebCore::DataTransferItemChromium::create): (WebCore::DataTransferItemChromium::DataTransferItemChromium): (WebCore::DataTransferItemChromium::getAsString): (WebCore::DataTransferItemChromium::getAsFile): (WebCore::DataTransferItemChromium::clipboardChromium): * platform/chromium/DataTransferItemChromium.h: (WebCore::DataTransferItemChromium::kind): (WebCore::DataTransferItemChromium::type): * platform/chromium/DataTransferItemListChromium.cpp: (WebCore::DataTransferItemListChromium::DataTransferItemListChromium): * platform/chromium/DataTransferItemListChromium.h: * platform/qt/DataTransferItemListQt.cpp: (WebCore::DataTransferItemListQt::DataTransferItemListQt): (WebCore::DataTransferItemListQt::length): (WebCore::DataTransferItemListQt::item): (WebCore::DataTransferItemListQt::deleteItem): (WebCore::DataTransferItemListQt::clear): (WebCore::DataTransferItemListQt::add): * platform/qt/DataTransferItemListQt.h: * platform/qt/DataTransferItemQt.cpp: (WebCore::DataTransferItemQt::create): (WebCore::DataTransferItemQt::DataTransferItemQt): (WebCore::DataTransferItemQt::getAsString): (WebCore::DataTransferItemQt::getAsFile): * platform/qt/DataTransferItemQt.h: (WebCore::DataTransferItemQt::kind): (WebCore::DataTransferItemQt::type): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mikelawther@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=76130 Reviewed by Darin Adler. Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662) These tests are expected to 'fail', and will pass once calc() functionality is landed. For now, they serve to demonstrate that the current code doesn't crash on these tests. * css3/calc/getComputedStyle-margin-percentage-expected.txt: Added. * css3/calc/getComputedStyle-margin-percentage.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
Implement a JIT-code aware sampling profiler for JSC Reviewed by Geoff Garen. Step 2: generalize RedBlackTree. The profiler is going to want tio use a RedBlackTree, allow this class to work with subclasses of RedBlackTree::Node, Node should not need to know the names of the m_key and m_value fields (the subclass can provide a key() accessor), and RedBlackTree does not need to know anything about ValueType. * JavaScriptCore.exp: * wtf/MetaAllocator.cpp: (WTF::MetaAllocator::findAndRemoveFreeSpace): (WTF::MetaAllocator::debugFreeSpaceSize): (WTF::MetaAllocator::addFreeSpace): * wtf/MetaAllocator.h: (WTF::MetaAllocator::FreeSpaceNode::FreeSpaceNode): (WTF::MetaAllocator::FreeSpaceNode::key): * wtf/MetaAllocatorHandle.h: (WTF::MetaAllocatorHandle::key): * wtf/RedBlackTree.h: (WTF::RedBlackTree::Node::successor): (WTF::RedBlackTree::Node::predecessor): (WTF::RedBlackTree::Node::parent): (WTF::RedBlackTree::Node::setParent): (WTF::RedBlackTree::Node::left): (WTF::RedBlackTree::Node::setLeft): (WTF::RedBlackTree::Node::right): (WTF::RedBlackTree::Node::setRight): (WTF::RedBlackTree::insert): (WTF::RedBlackTree::remove): (WTF::RedBlackTree::findExact): (WTF::RedBlackTree::findLeastGreaterThanOrEqual): (WTF::RedBlackTree::findGreatestLessThanOrEqual): (WTF::RedBlackTree::first): (WTF::RedBlackTree::last): (WTF::RedBlackTree::size): (WTF::RedBlackTree::treeMinimum): (WTF::RedBlackTree::treeMaximum): (WTF::RedBlackTree::treeInsert): (WTF::RedBlackTree::leftRotate): (WTF::RedBlackTree::rightRotate): (WTF::RedBlackTree::removeFixup): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kling@webkit.org authored
* css/CSSMutableStyleDeclaration.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=76764 Reviewed by Dirk Pranke. Move skipped_perf_tests from WebKit port to Base port so that Chromium port can also find skipped list. Chromium port only uses test_expectations.txt for layout tests but performacne tests don't use test_expectations.txt so Chromium port also needs to use Skipped list. * Scripts/webkitpy/layout_tests/port/base.py: (Port._tests_from_skipped_file_contents): (Port): (Port._expectations_from_skipped_files): (Port.skipped_perf_tests): * Scripts/webkitpy/layout_tests/port/base_unittest.py: (PortTest.test_skipped_perf_tests): (PortTest.test_skipped_perf_tests.add_text_file): * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitPort._skipped_tests_for_unsupported_features): (WebKitPort._skipped_file_search_paths): (WebKitPort.skipped_layout_tests): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=76637 Patch by Philip Rogers <pdr@google.com> on 2012-01-23 Reviewed by Darin Adler. No new tests. (I found no existing codepath that would be affected by this change but I think this change is still valuable in preventing future bugs.) * platform/graphics/FloatRect.cpp: (WebCore::FloatRect::uniteIfNonZero): The following change is a minor followup to https://bugs.webkit.org/show_bug.cgi?id=76177#c12 and is not directly related to the rest of this patch. * rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::computeContainerBoundingBoxes): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
antti@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=76848 Reviewed by Andreas Kling. CSSElementStyleDeclaration has little functionality. It can merge with CSSMutableStyleDeclaration simplifying the code. Having an element parent is mutually exclusive with having a css rule parent. We can keep them in a union. This also shrinks all inline style declarations by one pointer. * CMakeLists.txt: * GNUmakefile.list.am: * Target.pri: * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSDOMBinding.h: (WebCore::root): * css/CSSAllInOne.cpp: * css/CSSElementStyleDeclaration.cpp: Removed. * css/CSSElementStyleDeclaration.h: Removed. * css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc): * css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::createInline): (WebCore::CSSMutableStyleDeclaration::createForSVGFontFaceElement): (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration): * css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::CSSStyleDeclaration): (WebCore::CSSStyleDeclaration::parentStyleSheet): Merge the CSSElementStyleDeclaration::styleSheet() logic here. * css/CSSStyleDeclaration.h: (WebCore::CSSStyleDeclaration::parentRule): (WebCore::CSSStyleDeclaration::clearParentRule): (WebCore::CSSStyleDeclaration::parentElement): (WebCore::CSSStyleDeclaration::clearParentElement): * css/CSSStyleRule.cpp: (WebCore::CSSStyleRule::setSelectorText): CSSStyleRule's style declaration can't have isElementStyleDeclaration set, the dead code can be removed. This is asserted in setDeclaration() and again implicitly in the destructor (by clearParentRule()). * dom/StyledElement.cpp: (WebCore::StyledElement::createInlineStyleDecl): (WebCore::StyledElement::destroyInlineStyleDecl): (WebCore::StyledElement::ensureInlineStyleDecl): (WebCore::StyledElement::copyNonAttributeProperties): * dom/StyledElement.h: (WebCore::StyledElement::inlineStyleDecl): * editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): * editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::createDeletionUI): * html/ValidationMessage.cpp: (WebCore::adjustBubblePosition): * html/shadow/MediaControlElements.cpp: (WebCore::MediaControlPanelElement::setPosition): (WebCore::MediaControlPanelElement::resetPosition): (WebCore::MediaControlPanelElement::makeOpaque): (WebCore::MediaControlPanelElement::makeTransparent): * html/shadow/SliderThumbElement.cpp: (WebCore::TrackLimiterElement::create): * svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::SVGFontFaceElement): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
senorblanco@chromium.org authored
http://trac.webkit.org/changeset/105640 https://bugs.webkit.org/show_bug.cgi?id=76849 Broke the chromium build. * DEPS: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
senorblanco@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=76849 Patch by Justin Novosad <junov@chromium.org> on 2012-01-23 Reviewed by Stephen White. This is to pick up a change to skia build configuration * DEPS: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aestes@apple.com authored
Source/JavaScriptCore: * JavaScriptCore.exp: Tools: * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: (TestWebKitAPI::TEST): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mhahnenberg@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=76310 Reviewed by Sam Weinig. Removed StackBounds and the stack() function from JSGlobalData since it no longer accessed any members of JSGlobalData. * bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): * heap/MachineStackMarker.cpp: (JSC::MachineThreads::addCurrentThread): (JSC::MachineThreads::gatherFromCurrentThread): * parser/Parser.cpp: (JSC::::Parser): * runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): * runtime/JSGlobalData.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
benjamin@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=76774 Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-23 Reviewed by Darin Adler. * rendering/RenderMenuList.h: Also sort the methods to the same order as PopupMenuClient. * rendering/RenderTextControlSingleLine.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=76855 Rubber stanmped by Geoff Garen. Mechanical change - pass CodeBlock through to the executable allocator, such that we will be able to map ranges of JIT code back to their owner. * assembler/ARMAssembler.cpp: (JSC::ARMAssembler::executableCopy): * assembler/ARMAssembler.h: * assembler/AssemblerBuffer.h: (JSC::AssemblerBuffer::executableCopy): * assembler/AssemblerBufferWithConstantPool.h: (JSC::AssemblerBufferWithConstantPool::executableCopy): * assembler/LinkBuffer.h: (JSC::LinkBuffer::LinkBuffer): (JSC::LinkBuffer::linkCode): * assembler/MIPSAssembler.h: (JSC::MIPSAssembler::executableCopy): * assembler/SH4Assembler.h: (JSC::SH4Assembler::executableCopy): * assembler/X86Assembler.h: (JSC::X86Assembler::executableCopy): (JSC::X86Assembler::X86InstructionFormatter::executableCopy): * dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::compile): (JSC::DFG::JITCompiler::compileFunction): * dfg/DFGOSRExitCompiler.cpp: * dfg/DFGRepatch.cpp: (JSC::DFG::generateProtoChainAccessStub): (JSC::DFG::tryCacheGetByID): (JSC::DFG::tryBuildGetByIDList): (JSC::DFG::tryCachePutByID): * dfg/DFGThunks.cpp: (JSC::DFG::osrExitGenerationThunkGenerator): * jit/ExecutableAllocator.cpp: (JSC::ExecutableAllocator::allocate): * jit/ExecutableAllocator.h: * jit/ExecutableAllocatorFixedVMPool.cpp: (JSC::ExecutableAllocator::allocate): * jit/JIT.cpp: (JSC::JIT::privateCompile): * jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines): * jit/JITOpcodes32_64.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::privateCompileCTINativeCall): * jit/JITPropertyAccess.cpp: (JSC::JIT::stringGetByValStubGenerator): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain): * jit/JITPropertyAccess32_64.cpp: (JSC::JIT::stringGetByValStubGenerator): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain): * jit/JITStubs.cpp: * jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::finalize): * yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::compile): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
wangxianzhu@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=67081 Source/JavaScriptCore: This change contains the following enhancements to StringBuilder, for convenience, performance, testability, etc.: - Change toStringPreserveCapacity() to const - new public methods: capacity(), swap(), toAtomicString(), canShrink() and append(const StringBuilder&) - == and != opearators to compare StringBuilders and a StringBuilder/String Unit tests: Tools/TestWebKitAPI/Tests/WTF/StringBuilder.cpp Reviewed by Darin Adler. * JavaScriptCore.exp: * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: * wtf/text/AtomicString.cpp: (WTF::SubstringTranslator::hash): (WTF::SubstringTranslator::equal): (WTF::SubstringTranslator::translate): (WTF::AtomicString::add): (WTF::AtomicString::addSlowCase): * wtf/text/AtomicString.h: (WTF::AtomicString::AtomicString): (WTF::AtomicString::add): * wtf/text/StringBuilder.cpp: (WTF::StringBuilder::reifyString): (WTF::StringBuilder::resize): (WTF::StringBuilder::canShrink): (WTF::StringBuilder::shrinkToFit): * wtf/text/StringBuilder.h: (WTF::StringBuilder::append): (WTF::StringBuilder::toString): (WTF::StringBuilder::toStringPreserveCapacity): (WTF::StringBuilder::toAtomicString): (WTF::StringBuilder::isEmpty): (WTF::StringBuilder::capacity): (WTF::StringBuilder::is8Bit): (WTF::StringBuilder::swap): (WTF::equal): (WTF::operator==): (WTF::operator!=): * wtf/text/StringImpl.h: Source/WebCore: These changes are because we explicitly disallowed StringBuilder's copy constructor and assignment operator, and the change of return type of StringBuilder::toString(). Reviewed by Darin Adler. No new tests. All layout tests and unit tests should run as before. * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::setUpCookiesForQuickTime): * svg/SVGPathStringBuilder.h: (WebCore::SVGPathStringBuilder::cleanup): Source/WebKit/chromium: This change is because we explicitly disallowed StringBuilder's copy constructor and assignment operator. Reviewed by Darin Adler. No new tests. All layout tests and unit tests should run as before. * src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::encodeAndFlushBuffer): Tools: Reviewed by Darin Adler. * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: (TestWebKitAPI::TEST): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
wjmaclean@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=75732 Reviewed by James Robinson. Source/WebCore: Add WebSolidColorLayer to paint solid-color layers without a backing texture. Test: unit test for CCSolidColorLayerImpl. * WebCore.gypi: * platform/graphics/chromium/SolidColorLayerChromium.cpp: Added. (WebCore::SolidColorLayerChromium::createCCLayerImpl): (WebCore::SolidColorLayerChromium::create): (WebCore::SolidColorLayerChromium::SolidColorLayerChromium): (WebCore::SolidColorLayerChromium::~SolidColorLayerChromium): * platform/graphics/chromium/SolidColorLayerChromium.h: Added. * platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp: Added. (WebCore::CCSolidColorLayerImpl::CCSolidColorLayerImpl): (WebCore::CCSolidColorLayerImpl::~CCSolidColorLayerImpl): (WebCore::CCSolidColorLayerImpl::quadTransform): (WebCore::CCSolidColorLayerImpl::appendQuads): * platform/graphics/chromium/cc/CCSolidColorLayerImpl.h: Added. (WebCore::CCSolidColorLayerImpl::create): (WebCore::CCSolidColorLayerImpl::layerTypeAsString): Source/WebKit/chromium: * WebKit.gyp: * WebKit.gypi: * public/platform/WebSolidColorLayer.h: Added. * src/WebSolidColorLayer.cpp: Added. (WebKit::WebSolidColorLayer::create): (WebKit::WebSolidColorLayer::WebSolidColorLayer): (WebKit::WebSolidColorLayer::setBackgroundColor): * src/WebSolidColorLayerImpl.cpp: Added. (WebKit::WebSolidColorLayerImpl::create): (WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl): (WebKit::WebSolidColorLayerImpl::~WebSolidColorLayerImpl): * src/WebSolidColorLayerImpl.h: Added. * tests/CCLayerTestCommon.cpp: Added. (CCLayerTestCommon::completelyContains): (CCLayerTestCommon::verifyQuadsExactlyCoverRect): * tests/CCLayerTestCommon.h: Added. * tests/CCSolidColorLayerImplTest.cpp: Added. (CCLayerTestCommon::TEST): * tests/CCTiledLayerImplTest.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
results are just slightly different than the old results. * fast/dom/HTMLMeterElement/meter-element-expected.txt: Added. * fast/gradients/border-image-gradient-expected.txt: Added. * fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Added. * platform/chromium-linux-x86/fast/gradients: Removed. * platform/chromium-linux/fast/canvas/fillrect_gradient-expected.png: * platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: * platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: * platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-expected.png: * platform/chromium-linux/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Removed. * platform/chromium-linux/fast/gradients/css3-color-stops-expected.png: Removed. * platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients-expected.png: * platform/chromium-linux/fast/gradients/generated-gradients-expected.png: * platform/chromium-linux/fast/gradients/simple-gradients-expected.png: * platform/chromium-linux/svg/as-background-image/svg-as-background-2-expected.png: Removed. * platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.png: * platform/chromium-mac-leopard/fast/canvas/fillrect_gradient-expected.png: * platform/chromium-mac-leopard/fast/gradients/generated-gradients-expected.png: * platform/chromium-mac-leopard/fast/reflections/reflection-masks-expected.png: * platform/chromium-mac-snowleopard/fast/canvas/fillrect_gradient-expected.png: Added. * platform/chromium-mac-snowleopard/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added. * platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement: Added. * platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added. * platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Added. * platform/chromium-mac-snowleopard/fast/gradients/border-image-gradient-expected.png: Added. * platform/chromium-mac-snowleopard/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Added. * platform/chromium-mac-snowleopard/fast/gradients/css3-color-stops-expected.png: * platform/chromium-mac-snowleopard/fast/gradients/css3-repeating-linear-gradients-expected.png: Added. * platform/chromium-mac-snowleopard/fast/gradients/generated-gradients-expected.png: Added. * platform/chromium-mac-snowleopard/fast/gradients/simple-gradients-expected.png: Added. * platform/chromium-mac-snowleopard/fast/reflections/reflection-masks-expected.png: Added. * platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-2-expected.png: * platform/chromium-mac-snowleopard/svg/filters/big-sized-filter-expected.png: Added. * platform/chromium-mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png: * platform/chromium-mac/fast/canvas/fillrect_gradient-expected.png: Removed. * platform/chromium-mac/fast/canvas/gradient-add-second-start-end-stop-expected.png: Removed. * platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Removed. * platform/chromium-mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed. * platform/chromium-mac/fast/gradients/border-image-gradient-expected.png: Removed. * platform/chromium-mac/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Removed. * platform/chromium-mac/fast/gradients/css3-repeating-linear-gradients-expected.png: Removed. * platform/chromium-mac/fast/gradients/generated-gradients-expected.png: Removed. * platform/chromium-mac/fast/gradients/simple-gradients-expected.png: Removed. * platform/chromium-mac/fast/reflections/reflection-masks-expected.png: Removed. * platform/chromium-mac/svg/filters/big-sized-filter-expected.png: Removed. * platform/chromium-win-vista/fast/gradients: Removed. * platform/chromium-win-xp/svg/as-background-image: Removed. * platform/chromium-win/fast/canvas/fillrect_gradient-expected.png: * platform/chromium-win/fast/canvas/gradient-add-second-start-end-stop-expected.png: * platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: * platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: * platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.png: * platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.png: * platform/chromium-win/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: * platform/chromium-win/fast/gradients/border-image-gradient-expected.png: * platform/chromium-win/fast/gradients/border-image-gradient-sides-and-corners-expected.png: * platform/chromium-win/fast/gradients/css3-color-stops-expected.png: * platform/chromium-win/fast/gradients/css3-repeating-linear-gradients-expected.png: * platform/chromium-win/fast/gradients/generated-gradients-expected.png: * platform/chromium-win/fast/gradients/simple-gradients-expected.png: * platform/chromium-win/fast/reflections/reflection-masks-expected.png: * platform/chromium-win/svg/as-background-image/svg-as-background-2-expected.png: * platform/chromium-win/svg/filters/big-sized-filter-expected.png: * platform/chromium-win/svg/wicd/test-scalable-background-image1-expected.png: * platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt: Removed. * platform/gtk/fast/gradients/border-image-gradient-expected.txt: Removed. * platform/gtk/fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Removed. * platform/mac/fast/gradients/border-image-gradient-expected.txt: Removed. * platform/mac/fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Removed. * platform/qt/fast/gradients/border-image-gradient-expected.txt: Removed. * platform/qt/fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-