- 03 Jan, 2011 10 commits
-
-
mihaip@chromium.org authored
Unreviewed. Update .gitignore with new JavaScriptCore location. * .gitignore: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74898 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mihaip@chromium.org authored
Reviewed by David Levin. [Qt] Unskip some passing tests as the bot is migrated to Qt 4.7+ https://bugs.webkit.org/show_bug.cgi?id=51819 * platform/qt/Skipped: Remove passing HTTP tests. Keep timer-vs-loading.html as it is still failing. * platform/qt/http/tests/loading/bad-scheme-subframe-expected.txt: Match the expected results with chromium to pass the test. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74897 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
laszlo.1.gombos@nokia.com authored
Reviewed by David Levin. [Qt] Unskip some passing tests as the bot is migrated to Qt 4.7+ https://bugs.webkit.org/show_bug.cgi?id=51819 * platform/qt/Skipped: Remove passing HTTP tests. Keep timer-vs-loading.html as it is still failing. * platform/qt/http/tests/loading/bad-scheme-subframe-expected.txt: Match the expected results with chromium to pass the test. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74896 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin@apple.com authored
Reviewed by Kent Tamura. Eliminate HTMLInputElement::m_deprecatedTypeNumber, other input refactoring and renaming https://bugs.webkit.org/show_bug.cgi?id=51791 * src/WebSearchableFormData.cpp: (HTMLNames::IsInDefaultState): Use hasAttribute(checkedAttr) to find out whether a button should be checked by default, rather than calling the defaultChecked function. 2011-01-02 Darin Adler <darin@apple.com> Reviewed by Kent Tamura. Eliminate HTMLInputElement::m_deprecatedTypeNumber, other input refactoring and renaming https://bugs.webkit.org/show_bug.cgi?id=51791 * dom/InputElement.h: Make sanitizeValueForTextField public so it can be called by InputType. * html/BaseButtonInputType.cpp: (WebCore::BaseButtonInputType::accessKeyAction): Added. (WebCore::BaseButtonInputType::storesValueSeparateFromAttribute): Added. * html/BaseButtonInputType.h: Ditto. * html/BaseCheckableInputType.cpp: (WebCore::BaseCheckableInputType::canSetStringValue): Added. (WebCore::BaseCheckableInputType::accessKeyAction): Added. (WebCore::BaseCheckableInputType::fallbackValue): Added. (WebCore::BaseCheckableInputType::storesValueSeparateFromAttribute): Added. (WebCore::BaseCheckableInputType::isCheckable): Added. * html/BaseCheckableInputType.h: Ditto. * html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::hasSpinButton): Added. * html/BaseDateAndTimeInputType.h: Ditto. * html/BaseTextInputType.h: Made more functions private. * html/ButtonInputType.cpp: (WebCore::ButtonInputType::isTextButton): Added. * html/ButtonInputType.h: Ditto. * html/CheckboxInputType.cpp: (WebCore::CheckboxInputType::willDispatchClick): Added. (WebCore::CheckboxInputType::didDispatchClick): Added. (WebCore::CheckboxInputType::isCheckbox): Added. * html/CheckboxInputType.h: Ditto. * html/DateTimeInputType.cpp: (WebCore::DateTimeInputType::scaledStepValueShouldBeInteger): Fixed typo in name of this function. * html/DateTimeInputType.h: Ditto. * html/DateTimeLocalInputType.cpp: (WebCore::DateTimeLocalInputType::scaledStepValueShouldBeInteger): Ditto. * html/DateTimeLocalInputType.h: Ditto. * html/EmailInputType.cpp: (WebCore::EmailInputType::isEmailField): Added. * html/EmailInputType.h: Ditto. * html/FileInputType.cpp: (WebCore::FileInputType::FileInputType): Added. (WebCore::FileInputType::canSetStringValue): Added. (WebCore::FileInputType::canChangeFromAnotherType): Added. (WebCore::FileInputType::files): Added. (WebCore::FileInputType::canSetValue): Added. (WebCore::FileInputType::getTypeSpecificValue): Added. (WebCore::FileInputType::storesValueSeparateFromAttribute): Added. (WebCore::FileInputType::setFileList): Added. (WebCore::FileInputType::isFileUpload): Added. * html/FileInputType.h: Ditto. * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::HTMLInputElement): Updated for data member renaming and removal. (WebCore::HTMLInputElement::isValidValue): Call canSetStringValue instead of checking specific type numbers. (WebCore::HTMLInputElement::getAllowedValueStepWithDecimalPlaces): Use fastGetAttribute and fixed typo in the name of the scaledStepValueShouldBeInteger function. (WebCore::HTMLInputElement::isKeyboardFocusable): Call InputType::isKeyboardFocusable; moved most of the type-specific logic there. (WebCore::HTMLInputElement::shouldUseInputMethod): Call InputType::shouldUseInputMethod; moved the type-specific logic there. (WebCore::HTMLInputElement::handleBlurEvent): Call InputType::handleBlurEvent; moved the type-specific logic there. (WebCore::HTMLInputElement::setType): Tweak the names and types in this function. (WebCore::HTMLInputElement::updateType): Removed the code that set m_deprecatedTypeNumber. Compare types by comparing the value from formControlType. Removed file-specific logic and instead call InputType::canChangeFromAnotherType. Streamlined the logic for activation callbacks. (WebCore::HTMLInputElement::accessKeyAction): Call InputType::accessKeyAction; moved the type-specific logic there. (WebCore::HTMLInputElement::mapToEntry): Call InputType::shouldRespectHeightAndWidthAttributes and InputType::shouldRespectAlignAttribute. (WebCore::HTMLInputElement::parseMappedAttribute): Updated for name changes and the removal of m_defaultChecked. Changed the alt attribute logic to be based on the class of the renderer. Call InputType::srcAttributeChanged and moved the type-specific logic there. Call shouldRespectAlignAttribute and shouldRespectHeightAndWidthAttributes rather than having type-specific logic here. Call minOrMaxAttributeChanged. (WebCore::HTMLInputElement::rendererIsNeeded): Call InputType::rendererIsNeeded; moved the type-specific logic there. (WebCore::HTMLInputElement::attach): Removed the unneeded m_inited flag, which was redundant with the m_haveType flag. Call InputType::attach; moved the type-specific logic there. (WebCore::HTMLInputElement::altText): Use fastGetAttribute. (WebCore::HTMLInputElement::isSuccessfulSubmitButton): Call InputType::canBeSuccessfulSubmitButton; moved the type-specific logic there. (WebCore::HTMLInputElement::isActivatedSubmit): Updated for name changes. (WebCore::HTMLInputElement::setActivatedSubmit): Ditto. (WebCore::HTMLInputElement::reset): Updated to use InputType::storesValueSeparateFromAttribute. Also use hasAttribute(checkedAttr) rather than m_defaultChecked, since both are the same. Also updated for name change. (WebCore::HTMLInputElement::setChecked): Updated for name changes. Also added call to InputType::shouldSendChangeEventAfterCheckedChanged and moved the type-specific logic there. (WebCore::HTMLInputElement::setIndeterminate): Call isCheckable to see if indeterminate is allowed. Also updated for name changes. (WebCore::HTMLInputElement::copyNonAttributeProperties): Updated for name changes and removed data members. (WebCore::HTMLInputElement::value): Call InputType::getTypeSpecificValue and InputType::fallbackValue. Moved the type-specific logic there. (WebCore::HTMLInputElement::valueWithDefault): Call InputType::defaultValue. Moved the type-specific logic there. (WebCore::HTMLInputElement::setSuggestedValue): Call InputType::canSetSuggestedValue. Moved the type-specific logic there. (WebCore::HTMLInputElement::setValue): Call InputType::canSetValue. Moved the type-specific logic there. Clear the file list if it exists rather than checking the type explicitly. We could probably do that a more elegant way. (WebCore::HTMLInputElement::placeholder): Use fastGetAttribute. (WebCore::HTMLInputElement::setValueFromRenderer): Use the isFileUpload function in the assertion. (WebCore::HTMLInputElement::setFileListFromRenderer): Put most of the code from this function into FileInputType::setFileList. (WebCore::HTMLInputElement::preDispatchEventHandler): Changed to call InputType::willDispatchClick, which does the type-specific work. Still need to use a single struct for all types, because the type of the element could change during the event handling. (WebCore::HTMLInputElement::postDispatchEventHandler): Changed to call InputType::didDispatchClick. (WebCore::HTMLInputElement::defaultValue): Use fastGetAttribute. (WebCore::HTMLInputElement::accept): Use fastGetAttribute. (WebCore::HTMLInputElement::alt): Use fastGetAttribute. (WebCore::HTMLInputElement::src): Use fastGetAttribute. (WebCore::HTMLInputElement::setAutofilled): Updated for name changes. (WebCore::HTMLInputElement::files): Use InputType::files. (WebCore::HTMLInputElement::isAcceptableValue): Use InputType::isAcceptableValue. (WebCore::HTMLInputElement::sanitizeValue): Use InputType::sanitizeValue. (WebCore::HTMLInputElement::hasUnacceptableValue): Use InputType::hasUnacceptableValue. (WebCore::HTMLInputElement::needsActivationCallback): Use InputType::shouldResetOnDocumentActivation. (WebCore::HTMLInputElement::willMoveToNewOwnerDocument): Use InputType::willMoveToNewOwnerDocument. (WebCore::HTMLInputElement::dataList): Use InputType::shouldRespectListAttribute. (WebCore::HTMLInputElement::selectedOption): Tweaked logic and naming a bit. (WebCore::HTMLInputElement::stepUpFromRenderer): Use fastGetAttribute. (WebCore::HTMLInputElement::isSpeechEnabled): Use InputType::shouldRespectSpeechAttribute. (WebCore::HTMLInputElement::isTextButton): No longer inline. Calls through to InputType. (WebCore::HTMLInputElement::isRadioButton): Ditto. (WebCore::HTMLInputElement::isSearchField): Ditto. (WebCore::HTMLInputElement::isInputTypeHidden): Ditto. (WebCore::HTMLInputElement::isPasswordField): Ditto. (WebCore::HTMLInputElement::isCheckbox): Ditto. (WebCore::HTMLInputElement::isText): Ditto. (WebCore::HTMLInputElement::isEmailField): Ditto. (WebCore::HTMLInputElement::isFileUpload): Ditto. (WebCore::HTMLInputElement::isImageButton): Ditto. (WebCore::HTMLInputElement::isNumberField): Ditto. (WebCore::HTMLInputElement::isSubmitButton): Ditto. (WebCore::HTMLInputElement::isTelephoneField): Ditto. (WebCore::HTMLInputElement::isURLField): Ditto. (WebCore::HTMLInputElement::isEnumeratable): Ditto. (WebCore::HTMLInputElement::isChecked): No longer inline. Calls InputType::isCheckable. (WebCore::HTMLInputElement::hasSpinButton): No longer inline. Calls through to InputType. (WebCore::HTMLInputElement::supportsPlaceholder): No longer inline. Calls isTextType as before, but with no special case for ISINDEX. That special case was unneeded since it returns true from isTextType. (WebCore::HTMLInputElement::checkedRadioButtons): No longer inline. (WebCore::HTMLInputElement::handleBeforeTextInsertedEvent): No longer inline. * html/HTMLInputElement.h: Removed multiple unneeded includes. The big one is probably InputType.h, but also HTMLFormElement.h. Removed unneeded forward declarations. Made many functions no longer inline since they now need to make virtual function dispatches. Removed the unneeded defaultChecked and webkitdirectory functions. Both are handled by HTML attribute reflection for DOM bindings, and the callers instead can get at the attribute. Made updateCheckedRadioButtons public so it can be called by an InputType class. Removed DeprecatedInputType, InputTypeMap, createTypeMap, deprecatedInputType, allowsIndeterminate, respectHeightAndWidthAttrs, storesValueSeparateFromAttribute, m_imageLoader, m_fileList, m_deprecatedTypeNumber, m_defaultChecked, and m_inited. Renamed m_checked to m_isChecked, m_useDefaultChecked to m_reflectsCheckedAttribute, m_indeterminate tom_isIndeterminate, m_haveType to m_hasType, m_activeSubmit to m_isActivatedSubmit, and m_autofilled to m_isAutofilled. * html/HiddenInputType.cpp: (WebCore::HiddenInputType::accessKeyAction): Added. (WebCore::HiddenInputType::rendererIsNeeded) Added.: (WebCore::HiddenInputType::storesValueSeparateFromAttribute): Added. (WebCore::HiddenInputType::isHiddenType): Added. (WebCore::HiddenInputType::shouldRespectHeightAndWidthAttributes): Added. * html/HiddenInputType.h: Ditto. * html/ImageInputType.cpp: (WebCore::ImageInputType::ImageInputType): Moved out of the header file. (WebCore::ImageInputType::srcAttributeChanged): Added. (WebCore::ImageInputType::attach): Added. (WebCore::ImageInputType::willMoveToNewOwnerDocument): Added. (WebCore::ImageInputType::shouldRespectAlignAttribute): Added. (WebCore::ImageInputType::canBeSuccessfulSubmitButton): Added. (WebCore::ImageInputType::isImageButton): Added. (WebCore::ImageInputType::isEnumeratable): Added. (WebCore::ImageInputType::shouldRespectHeightAndWidthAttributes): Added. * html/ImageInputType.h: Ditto. * html/InputType.cpp: (WebCore::InputType::create): Changed argument type to String. There is no value in taking an AtomicString here. (WebCore::InputType::scaledStepValueShouldBeInteger): Fixed typo in this function name. (WebCore::InputType::canSetStringValue): Added. (WebCore::InputType::isKeyboardFocusable): Added. (WebCore::InputType::shouldUseInputMethod): Added. (WebCore::InputType::handleBlurEvent): Added. (WebCore::InputType::accessKeyAction): Added. (WebCore::InputType::attach): Added. (WebCore::InputType::srcAttributeChanged): Added. (WebCore::InputType::willMoveToNewOwnerDocument): Added. (WebCore::InputType::shouldRespectAlignAttribute): Added. (WebCore::InputType::canChangeFromAnotherType): Added. (WebCore::InputType::minOrMaxAttributeChanged): Added. (WebCore::InputType::canBeSuccessfulSubmitButton): Added. (WebCore::InputType::rendererIsNeeded): Added. (WebCore::InputType::files): Added. (WebCore::InputType::getTypeSpecificValue): Added. (WebCore::InputType::fallbackValue): Added. (WebCore::InputType::defaultValue): Added. (WebCore::InputType::canSetSuggestedValue): Added. (WebCore::InputType::shouldSendChangeEventAfterCheckedChanged): Added. (WebCore::InputType::storesValueSeparateFromAttribute): Added. (WebCore::InputType::canSetValue): Added. (WebCore::InputType::willDispatchClick): Added. (WebCore::InputType::didDispatchClick): Added. (WebCore::InputType::isAcceptableValue): Added. (WebCore::InputType::sanitizeValue): Added. (WebCore::InputType::hasUnacceptableValue): Added. (WebCore::InputType::setFileList): Added. (WebCore::InputType::shouldResetOnDocumentActivation): Added. (WebCore::InputType::shouldRespectListAttribute): Added. (WebCore::InputType::shouldRespectSpeechAttribute): Added. (WebCore::InputType::isTextButton): Added. (WebCore::InputType::isRadioButton): Added. (WebCore::InputType::isSearchField): Added. (WebCore::InputType::isHiddenType): Added. (WebCore::InputType::isPasswordField): Added. (WebCore::InputType::isCheckbox): Added. (WebCore::InputType::isEmailField): Added. (WebCore::InputType::isFileUpload): Added. (WebCore::InputType::isImageButton): Added. (WebCore::InputType::isNumberField): Added. (WebCore::InputType::isSubmitButton): Added. (WebCore::InputType::isTelephoneField): Added. (WebCore::InputType::isURLField): Added. (WebCore::InputType::isEnumeratable): Added. (WebCore::InputType::isCheckable): Added. (WebCore::InputType::hasSpinButton): Added. (WebCore::InputType::shouldRespectHeightAndWidthAttributes): Added. * html/InputType.h: Removed unneeded ExceptionCode.h include and used a typedef instead as we do when we want for forward declare it. Added includes and forward declarations needed for new functions. Added ClickHandlingState structure. Changed the argument to create to a String rather than AtomicString. Added many virtual functions. * html/IsIndexInputType.cpp: (WebCore::IsIndexInputType::shouldRespectListAttribute): Added. * html/IsIndexInputType.h: Ditto. * html/NumberInputType.cpp: (WebCore::NumberInputType::handleBlurEvent): Added. (WebCore::NumberInputType::isAcceptableValue): Added. (WebCore::NumberInputType::sanitizeValue): Added. (WebCore::NumberInputType::hasUnacceptableValue): Added. (WebCore::NumberInputType::shouldRespectSpeechAttribute): Added. (WebCore::NumberInputType::isNumberField): Added. (WebCore::NumberInputType::hasSpinButton): Added. * html/NumberInputType.h: Ditto. * html/PasswordInputType.cpp: (WebCore::PasswordInputType::shouldUseInputMethod): Added. (WebCore::PasswordInputType::shouldResetOnDocumentActivation): Added. (WebCore::PasswordInputType::shouldRespectListAttribute): Added. (WebCore::PasswordInputType::shouldRespectSpeechAttribute): Added. (WebCore::PasswordInputType::isPasswordField): Added. * html/PasswordInputType.h: Ditto. * html/RadioInputType.cpp: (WebCore::RadioInputType::isKeyboardFocusable): Added. (WebCore::RadioInputType::attach): Added. (WebCore::RadioInputType::shouldSendChangeEventAfterCheckedChanged): Added. (WebCore::RadioInputType::willDispatchClick): Added. (WebCore::RadioInputType::didDispatchClick): Added. (WebCore::RadioInputType::isRadioButton): Added. * html/RadioInputType.h: Ditto. * html/RangeInputType.cpp: (WebCore::RangeInputType::accessKeyAction): Added. (WebCore::RangeInputType::minOrMaxAttributeChanged): Added. (WebCore::RangeInputType::fallbackValue): Added. (WebCore::RangeInputType::sanitizeValue): Added. (WebCore::RangeInputType::shouldRespectListAttribute): Added. * html/RangeInputType.h: Ditto. * html/ResetInputType.cpp: (WebCore::ResetInputType::defaultValue): Added. (WebCore::ResetInputType::isTextButton): Added. * html/ResetInputType.h: Ditto. * html/SearchInputType.cpp: (WebCore::SearchInputType::shouldRespectSpeechAttribute): Added. (WebCore::SearchInputType::isSearchField): Added. * html/SearchInputType.h: Ditto. * html/SubmitInputType.cpp: (WebCore::SubmitInputType::canBeSuccessfulSubmitButton): Added. (WebCore::SubmitInputType::defaultValue): Added. (WebCore::SubmitInputType::isSubmitButton): Added. (WebCore::SubmitInputType::isTextButton): Added. * html/SubmitInputType.h: Ditto. * html/TelephoneInputType.cpp: (WebCore::TelephoneInputType::shouldRespectSpeechAttribute): Added. (WebCore::TelephoneInputType::isTelephoneField): Added. * html/TelephoneInputType.h: Ditto. * html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::shouldUseInputMethod): Added. (WebCore::TextFieldInputType::sanitizeValue): Added. (WebCore::TextFieldInputType::shouldRespectListAttribute): Added. * html/TextFieldInputType.h: Ditto. * html/TextInputType.cpp: (WebCore::TextInputType::canSetSuggestedValue): Added. (WebCore::TextInputType::shouldRespectSpeechAttribute): Added. * html/TextInputType.h: Ditto. * html/TimeInputType.cpp: (WebCore::TimeInputType::scaledStepValueShouldBeInteger): Fixed typo in the name of this function. * html/TimeInputType.h: Ditto. * html/URLInputType.cpp: (WebCore::URLInputType::isURLField): Added. * html/URLInputType.h: Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74895 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mihaip@chromium.org authored
Unreviewed, Chromium test expectation update. Update expectations after r74892. A bunch of previously failing tests now pass (since they match scrollbars with the mac port). Some tests also started to fail, they should be fixed by removing their chromium-mac baselines. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74894 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
and shift-tabbing into the WKView. Reviewed by Anders Carlsson. * UIProcess/API/mac/WKView.mm: (-[WKView becomeFirstResponder]): Use the keyViewSelectionDirection to set the initial focus. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74893 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mihaip@chromium.org authored
Unreviewed. NSScrollView-based scrollbars and ScrollBarTheme-based scrollbars don't look the same https://bugs.webkit.org/show_bug.cgi?id=51151 Flip switch to use WebThemeEngine for Chromium/Mac scrollbar rendering, so that it can match Safari's (and thus use the same baselines). No new tests, should be covered by layout tests (which will need expectation changes) * platform/chromium/ScrollbarThemeChromiumMac.mm: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74892 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tonikitoo@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [Qt] Refactor EditorClientQt::handleKeyboardEvent https://bugs.webkit.org/show_bug.cgi?id=51306 EditorClientQt::handleKeyboardEvent relies on QWebPagePrivate::editorActionForKeyEvent() to handle all editor commands that have a QAction associted with it. In practice, that covers most of editor commands (as one can see in editorCommandWebActions, in qwebpage.cpp). However, there are some key down events that are associated to no QAction or need special handling when features like spatial navigation or caret browsing are enabled. Currently, these cases are being handled with confusing and nested if/else switch's statements in EditorClientQt::handleKeyboardEvent(), and the code is hardly readable. This patch introduces a mapping hash for those cases, simplifying much the code. Basically, nested switches statements mixed with if/else's were refactored, and early returns were added right after an event gets consumed by the Editor. Since it is a refactor only patch, there is no funcionality change at all, and then no new tests are being added. * WebCoreSupport/EditorClientQt.cpp: (WebCore::interpretKeyEvent): (WebCore::EditorClientQt::handleKeyboardEvent): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74891 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Unreviewed build fix for WebKit/Gtk+. RenderThemeGtk::initMediaColors() in RenderThemeGtk2.cpp needs to be guarded by ENABLE(VIDEO), as it is in its header. No new tests. * platform/gtk/RenderThemeGtk2.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74890 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Xan Lopez. "Tool/Scripts/run-launcher --gtk" stopped working after 74855 https://bugs.webkit.org/show_bug.cgi?id=51806 Originally, the $libraryName is 'JavaScriptCore'. When building release one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/' which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore' is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird, so make it 'WebKitBuild/Release/.libs' * Scripts/webkitdirs.pm: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74889 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 02 Jan, 2011 30 commits
-
-
abarth@webkit.org authored
Skip this test for now. It's been failing for a while. I'm investigating the root cause now, but having this red on the buildbot isn't productive. * platform/mac/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74888 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rdar://problem/8812159mitz@apple.com authored
Rubber-stamped by Simon Fraser. Source/JavaScriptCore: * Info.plist: Source/JavaScriptGlue: * Info.plist: WebCore: * Info.plist: WebKit/mac: * Info.plist: WebKit2: * Info.plist: * WebProcess/Info.plist: WebKitLibraries: * win/tools/scripts/COPYRIGHT-END-YEAR: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74887 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rdar://problem/8806570mitz@apple.com authored
<rdar://problem/8806570> REGRESSION (r73337): Incorrect text match count when a match occurs in a text field https://bugs.webkit.org/show_bug.cgi?id=51623 Reviewed by Sam Weinig. * editing/Editor.cpp: (WebCore::Editor::countMatchesForText): Actually remember the original search range end container and offset and restore them when needed, instead of using two references to the same Range. * manual-tests/find-count-matches-after-text-control.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tkent@chromium.org authored
Unreviewed, test expectation update. Two more fixes. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74885 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tkent@chromium.org authored
Unreviewed, correct test_expectations.txt syntax. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74884 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tkent@chromium.org authored
Unreviewed, test expectation update. - Add expectation files for application-plugin-plugins-disabled.html - Add some flaky tests to test_expectations.txt * platform/chromium-linux/plugins/application-plugin-plugins-disabled-expected.checksum: Added. * platform/chromium-linux/plugins/application-plugin-plugins-disabled-expected.png: Added. * platform/chromium-mac/plugins/application-plugin-plugins-disabled-expected.checksum: Added. * platform/chromium-mac/plugins/application-plugin-plugins-disabled-expected.png: Added. * platform/chromium-win/plugins/application-plugin-plugins-disabled-expected.checksum: Added. * platform/chromium-win/plugins/application-plugin-plugins-disabled-expected.png: Added. * platform/chromium-win/plugins/application-plugin-plugins-disabled-expected.txt: Added. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74883 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
benjamin.poulain@nokia.com authored
Reviewed by Csaba Osztrogonác. WebKit 2 does not build on 64bits with a recent GCC https://bugs.webkit.org/show_bug.cgi?id=51754 Use explicitely 64 bits types for the attributes of DatabaseDetails. * storage/DatabaseDetails.h: (WebCore::DatabaseDetails::expectedUsage): (WebCore::DatabaseDetails::currentUsage): 2011-01-02 Benjamin Poulain <benjamin.poulain@nokia.com> Reviewed by Csaba Osztrogonác. WebKit 2 does not build on 64bits with a recent GCC https://bugs.webkit.org/show_bug.cgi?id=51754 Change the argument coding for DatabaseDetails to use explicitely the 64 bits type. * Shared/OriginAndDatabases.h: * Shared/WebCoreArgumentCoders.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74882 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
paroga@webkit.org authored
Reviewed by Adam Barth. Make EFL a core builder https://bugs.webkit.org/show_bug.cgi?id=51804 * Scripts/webkitpy/common/net/buildbot/buildbot.py: * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74881 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
* BuildSlaveSupport/built-product-archive: - Create directories explicitly. - Pass shell=True to subprocess.call(). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74880 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
paroga@webkit.org authored
Unreviewed WinCE build fix for r74868. * platform/graphics/wince/ImageBufferWinCE.cpp: (WebCore::getImageData): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74879 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
Reviewed by Xan Lopez. * GNUmakefile.am: Fix include pathes. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Unreviewed, rolling out r74847. http://trac.webkit.org/changeset/74847 https://bugs.webkit.org/show_bug.cgi?id=51803 "Preprocessor guards should be in header files" (Requested by ap on #webkit). * bindings/js/JSDOMWindowBase.cpp: * dom/Document.cpp: (WebCore::Document::recalcStyle): * html/HTMLDocument.cpp: * loader/FrameLoader.cpp: * loader/ResourceLoadNotifier.cpp: * page/Chrome.cpp: * page/Console.cpp: * page/ContextMenuController.cpp: * page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchEvent): * page/EventHandler.cpp: * page/Page.cpp: * storage/Database.cpp: * workers/AbstractWorker.cpp: * workers/DefaultSharedWorkerRepository.cpp: * workers/SharedWorker.cpp: * workers/Worker.cpp: * workers/WorkerContext.cpp: * workers/WorkerMessagingProxy.cpp: * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74877 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
robert@webkit.org authored
Unreviewed, update expected results. Update expected results for tests added in r74872 Skip test on Qt as Qt Styled Widgets are no longer getting rendered when plugins are disabled. This is a bug. * platform/gtk/plugins/application-plugin-plugins-disabled-expected.txt: Copied from LayoutTests/plugins/application-plugin-plugins-disabled-expected.txt. * platform/qt/Skipped: * plugins/application-plugin-plugins-disabled-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74876 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
Move JavaScriptCore to Source https://bugs.webkit.org/show_bug.cgi?id=51604 * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74875 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
Move JavaScriptCore to Source https://bugs.webkit.org/show_bug.cgi?id=51604 * Scripts/webkitdirs.pm: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=51604 Reviewed by Adam Barth. Workaround until moving all sources to Source directory is finished. * Scripts/generate-forwarding-headers.pl: Add Sources to searching path for JavaScriptCore. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74873 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
robert@webkit.org authored
Unreviewed. Layout tests from changeset r56661 were missed This test was accidentally omitted from changeset 56661. See also https://webkit.org/b/32196 https://bugs.webkit.org/show_bug.cgi?id=42562 * platform/qt/plugins/application-plugin-plugins-disabled-expected.txt: Added. * plugins/application-plugin-plugins-disabled-expected.txt: Added. * plugins/application-plugin-plugins-disabled.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
paroga@webkit.org authored
[CMake] Unreviewed build fix. * CMakeLists.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74871 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
paroga@webkit.org authored
[CMake] Unreviewed build fix. * CMakeLists.txt: * Source/cmake/OptionsCommon.cmake: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74870 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
robert@webkit.org authored
Unreviewed, build fix. [Qt] Fix DRT build after 74855 * DumpRenderTree/qt/DumpRenderTree.pro: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74869 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
krit@webkit.org authored
Reviewed by Simon Fraser. Clarify ImageBuffer and ImageData relationship https://bugs.webkit.org/show_bug.cgi?id=51297 Use ByteArray instead of ImageData. * src/WebViewImpl.cpp: (WebKit::WebViewImpl::doPixelReadbackToCanvas): 2011-01-02 Dirk Schulze <krit@webkit.org> Reviewed by Simon Fraser. Clarify ImageBuffer and ImageData relationship https://bugs.webkit.org/show_bug.cgi?id=51297 Remove references to ImageData and CanvasPixelArray from ImageBuffer and SVG filter/masker code, since this was a layering violation, and replaced it by ByteArray. No change of functionality, so no new test added. * html/ImageData.cpp: (WebCore::ImageData::create): (WebCore::ImageData::ImageData): * html/ImageData.h: Added new constructor with ByteArray input. (WebCore::ImageData::width): (WebCore::ImageData::height): (WebCore::ImageData::data): * html/canvas/CanvasPixelArray.cpp: (WebCore::CanvasPixelArray::create): (WebCore::CanvasPixelArray::CanvasPixelArray): * html/canvas/CanvasPixelArray.h: New conctructor with ByteArray input, used by HTML Canvas. (WebCore::CanvasPixelArray::data): (WebCore::CanvasPixelArray::length): (WebCore::CanvasPixelArray::set): (WebCore::CanvasPixelArray::get): * html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::getImageData): (WebCore::CanvasRenderingContext2D::putImageData): * platform/graphics/ImageBuffer.h: * platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData): * platform/graphics/cg/ImageBufferCG.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData): * platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::apply): * platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::apply): * platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::FEComponentTransfer::apply): * platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::apply): * platform/graphics/filters/FEConvolveMatrix.cpp: (WebCore::setDestinationPixels): (WebCore::FEConvolveMatrix::apply): * platform/graphics/filters/FEConvolveMatrix.h: * platform/graphics/filters/FEDisplacementMap.cpp: (WebCore::FEDisplacementMap::apply): * platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::apply): * platform/graphics/filters/FELighting.cpp: (WebCore::FELighting::apply): * platform/graphics/filters/FEMorphology.cpp: (WebCore::FEMorphology::apply): * platform/graphics/filters/FETurbulence.cpp: (WebCore::FETurbulence::apply): * platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::asImageBuffer): (WebCore::FilterEffect::asUnmultipliedImage): (WebCore::FilterEffect::asPremultipliedImage): (WebCore::FilterEffect::copyImageBytes): (WebCore::FilterEffect::copyUnmultipliedImage): (WebCore::FilterEffect::copyPremultipliedImage): (WebCore::FilterEffect::createUnmultipliedImageResult): (WebCore::FilterEffect::createPremultipliedImageResult): * platform/graphics/filters/FilterEffect.h: * platform/graphics/qt/ImageBufferQt.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData): * platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData): * platform/graphics/wince/ImageBufferWinCE.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData): * platform/graphics/wx/ImageBufferWx.cpp: (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData): * rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74868 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
xan@webkit.org authored
Fix GTK+ build. * GNUmakefile.am: tests do actually include JSC. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74867 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
One more .. missing in the Qt build. * jsc.pro: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74866 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
xan@webkit.org authored
2011-01-02 Xan Lopez <xlopez@igalia.com> Fix GTK+ build. * GNUmakefile.am: remove individual -I$(srcdir)/Source when we'll already get them from javascriptcore_cppflags, and add it for the introspection build (which is not tested in the bots). JavaScriptCore: 2011-01-02 Xan Lopez <xlopez@igalia.com> Fix GTK+ build. * GNUmakefile.am: add -I$(srcdir)/Source to the JSC cppflags so that anyone can include its headers without adding the prefix 'Source/'. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74865 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Speculative build fix for GTK. Add Source to the include paths. * GNUmakefile.am: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74864 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Reviewed by Adam Barth. Fix Windows Build for non-production where VSPropsRedirectionDir is not defined. https://bugs.webkit.org/show_bug.cgi?id=51797 * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: * JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh: * JavaScriptCore.vcproj/WTF/WTF.vcproj: * JavaScriptCore.vcproj/jsc/jsc.vcproj: * JavaScriptCore.vcproj/testapi/testapi.vcproj: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74863 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Speculative build fix for Qt. Add some more include paths. * WebKit2.pro: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74862 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Fix relative include paths in an attempt to fix the Qt build. * JavaScriptCore.pri: * JavaScriptCore.pro: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74861 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Another speculative build fix for GTK. * GNUmakefile.am: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74860 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Speculative build fix for GTK. Update the paths in GNUmakefile to include "Source". * GNUmakefile.am: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74859 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-