Skip to content

GitLab

Switch branch/tag
  1. 20 May, 2010 20 commits
  3. 19 May, 2010 20 commits
    • eric@webkit.org's avatar
      2010-05-19 Vangelis Kokkevis <vangelis@chromium.org> · 2f0e7423
      eric@webkit.org authored 
              Reviewed by Darin Fisher.

        Implementing hardware accelerated compositing of layers for Chromium.
        Completely removed the existing software compositing path to replace
        it with code implemented using OpenGL.
        https://bugs.webkit.org/show_bug.cgi?id=38783

        Tests: Covered by existing compositing tests.

        * WebCore.gyp/WebCore.gyp:
        * platform/graphics/chromium/GraphicsLayerChromium.cpp:
        (WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):
        (WebCore::GraphicsLayerChromium::updateLayerDrawsContent):
        (WebCore::GraphicsLayerChromium::updateContentsRect):
        * platform/graphics/chromium/LayerChromium.cpp:
        (WebCore::LayerChromium::LayerChromium):
        (WebCore::LayerChromium::~LayerChromium):
        (WebCore::LayerChromium::updateGraphicsContext):
        (WebCore::LayerChromium::drawsContentUpdated):
        (WebCore::LayerChromium::updateContents):
        (WebCore::LayerChromium::setContents):
        (WebCore::LayerChromium::setBackingStoreSize):
        (WebCore::LayerChromium::setBounds):
        (WebCore::LayerChromium::setNeedsDisplay):
        * platform/graphics/chromium/LayerChromium.h:
        (WebCore::LayerChromium::contentsDirty):
        (WebCore::LayerChromium::drawsContent):
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::):
        (WebCore::checkGLError):
        (WebCore::loadShader):
        (WebCore::loadShaderProgram):
        (WebCore::toGLMatrix):
        (WebCore::orthoMatrix):
        (WebCore::createLayerTexture):
        (WebCore::LayerRendererChromium::create):
        (WebCore::LayerRendererChromium::LayerRendererChromium):
        (WebCore::LayerRendererChromium::~LayerRendererChromium):
        (WebCore::LayerRendererChromium::drawTexturedQuad):
        (WebCore::LayerRendererChromium::drawLayers):
        (WebCore::LayerRendererChromium::getTextureId):
        (WebCore::LayerRendererChromium::assignTextureForLayer):
        (WebCore::LayerRendererChromium::freeLayerTexture):
        (WebCore::LayerRendererChromium::drawDebugBorder):
        (WebCore::LayerRendererChromium::isLayerVisible):
        (WebCore::LayerRendererChromium::compositeLayersRecursive):
        (WebCore::LayerRendererChromium::makeContextCurrent):
        (WebCore::LayerRendererChromium::initGL):
        (WebCore::LayerRendererChromium::bindCommonAttribLocation):
        (WebCore::LayerRendererChromium::initializeSharedGLObjects):
        * platform/graphics/chromium/LayerRendererChromium.h:
        (WebCore::LayerRendererChromium::):
2010-05-19  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Darin Fisher.

        Modifying WebViewImpl to support new hardware compositing for
        LayerChromium layers.
        https://bugs.webkit.org/show_bug.cgi?id=38783

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::paint):
        (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
        (WebKit::WebViewImpl::updateRootLayerContents):
        (WebKit::WebViewImpl::setRootLayerNeedsDisplay):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59822 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f0e7423
    • eric@webkit.org's avatar
      2010-05-19 Eric Seidel <eric@webkit.org> · 383936c4
      eric@webkit.org authored 
              Reviewed by Adam Roben.

        WinEWS should build Debug instead of Release
        https://bugs.webkit.org/show_bug.cgi?id=39242

        This is a workaround for
        https://bugs.webkit.org/show_bug.cgi?id=39197
        Adam Roben and Brian Weinstein believe this may
        also make building faster since Debug builds
        take less time to link.

        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59821 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      383936c4
    • barraclough@apple.com's avatar
      Errk! rename op_constructor_ret as requested in review of Bug 39399. · fd6a150a
      barraclough@apple.com authored 
      Reviewed by Geoff Garen.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitReturn):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::emit_op_ret_object_or_this):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_ret_object_or_this):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59820 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd6a150a
    • tony@chromium.org's avatar
      2010-05-19 Tony Chang <tony@chromium.org> · 2e4aa8c6
      tony@chromium.org authored 
              Reviewed by Kent Tamura.

        [chromium] disable spelling suggestions if spellcheck=false
        https://bugs.webkit.org/show_bug.cgi?id=39402

        This is the Chromium fix for bug 25639 that was fixed in the
        other ports in r59585.

        * src/ContextMenuClientImpl.cpp:
        (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59819 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e4aa8c6
    • eric@webkit.org's avatar
      2010-05-19 Mario Sanchez Prada <msanchez@igalia.com> · f849d713
      eric@webkit.org authored 
              Reviewed by Darin Adler.

        Misleading variable name in a11y test
        https://bugs.webkit.org/show_bug.cgi?id=38465

        Use a more appropriate variable name for the return
        value of accessibilityController.rootElement

        * accessibility/aria-controls-with-tabs.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f849d713
    • barraclough@apple.com's avatar
      Bug 39399 - Move responsibility for verifying constructors return objects from... · fdaf8dcc
      barraclough@apple.com authored 
      Bug 39399 - Move responsibility for verifying constructors return objects from the caller to the callee.
        
Reviewed by Geoff Garen.

This is a necessary step to move object creation from caller to callee.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitReturn):
(JSC::BytecodeGenerator::emitConstruct):
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::isConstructor):
* bytecompiler/NodesCodegen.cpp:
(JSC::FunctionBodyNode::emitBytecode):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::emit_op_constructor_ret):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_constructor_ret):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59817 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fdaf8dcc
    • eric@webkit.org's avatar
      2010-05-19 Andrey Kosyakov <caseq@chromium.org> · f8790ba9
      eric@webkit.org authored 
              Reviewed by Timothy Hatcher.

        Maintain focus on help screen while it's active.
        https://bugs.webkit.org/show_bug.cgi?id=39237

        * inspector/front-end/HelpScreen.js:
        (WebInspector.HelpScreen):
        (WebInspector.HelpScreen.prototype.show):
        (WebInspector.HelpScreen.prototype._hide):
        (WebInspector.HelpScreen.prototype._onBlur):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59816 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8790ba9
    • eric@webkit.org's avatar
      2010-05-19 Jedrzej Nowacki <jedrzej.nowacki@nokia.com> · 44620eae
      eric@webkit.org authored 
              Reviewed by Kenneth Rohde Christiansen.

        Crash fix in the HistoryController.

        The problem was casued by a documented feature of the QWebFrame::setHtml().
        The method doesn't affect a browsing history (doesn't create a HistoryItem instance), so
        m_currentItem and m_previousItem are not set.

        A null check was added.

        [Qt] The QWebPage crashes on history.pushState().
        https://bugs.webkit.org/show_bug.cgi?id=38840

        * loader/HistoryController.cpp:
        (WebCore::HistoryController::pushState):
        (WebCore::HistoryController::replaceState):
2010-05-19  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Crash fix in the HistoryController.

        The problem was casued by a documented feature of the QWebFrame::setHtml().
        The method doesn't affect a browsing history (doesn't create a HistoryItem instance), so
        m_currentItem and m_previousItem are not set.

        A null check was added.

        [Qt] The QWebPage crashes on history.pushState().
        https://bugs.webkit.org/show_bug.cgi?id=38840

        * tests/qwebhistory/tst_qwebhistory.cpp:
        (tst_QWebHistory::popPushState_data):
        (tst_QWebHistory::popPushState):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59815 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44620eae
    • darin@chromium.org's avatar
      2010-05-19 Darin Fisher <darin@chromium.org> · c2cc39ca
      darin@chromium.org authored 
              Revert r59790 due to failing Chromium npruntime tests.

        * bindings/v8/NPV8Object.cpp:
        (v8ObjectToNPObject):
        (npCreateV8ScriptObject):
        (_NPN_Invoke):
        (_NPN_InvokeDefault):
        (_NPN_Evaluate):
        (_NPN_EvaluateHelper):
        (_NPN_GetProperty):
        (_NPN_SetProperty):
        (_NPN_RemoveProperty):
        (_NPN_HasProperty):
        (_NPN_HasMethod):
        (_NPN_SetException):
        (_NPN_Enumerate):
        (_NPN_Construct):
        * bindings/v8/NPV8Object.h:
        * bindings/v8/V8NPObject.cpp:
        (forgetV8ObjectForNPObject):
        * bindings/v8/V8NPObject.h:
        * bindings/v8/V8NPUtils.cpp:
        (convertV8ObjectToNPVariant):
        (getStringIdentifier):
        * bindings/v8/V8NPUtils.h:
        * bindings/v8/npruntime.cpp:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59814 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2cc39ca
    • barraclough@apple.com's avatar
      Fix windows build II. · 48ade0ed
      barraclough@apple.com authored 
      Reviewed by NOBODY (build fix).

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48ade0ed
    • barraclough@apple.com's avatar
      Fix windows build. · 3be58fde
      barraclough@apple.com authored 
      Reviewed by NOBODY (build fix).

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59812 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3be58fde
    • barraclough@apple.com's avatar
      JavaScriptCore: Bug 39393 - JSFunction need not be a subclass of InternalFunction. · 4be541cf
      barraclough@apple.com authored 
      Reviewed by Oliver Hunt.

re-landing r59800.

* JavaScriptCore.exp:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::retrieveCaller):
(JSC::Interpreter::findFunctionCallFrame):
* interpreter/Interpreter.h:
* profiler/Profiler.cpp:
(JSC::Profiler::createCallIdentifier):
* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString):
* runtime/JSFunction.cpp:
(JSC::):
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::name):
(JSC::JSFunction::displayName):
(JSC::JSFunction::calculatedDisplayName):
* runtime/JSFunction.h:
* runtime/JSObject.cpp:
(JSC::JSObject::putDirectFunction):
(JSC::JSObject::putDirectFunctionWithoutTransition):
* runtime/JSObject.h:
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):

WebCore: Rubber Stamped by Sam Weinig.

JSFunctions are no longer a subclass of InternalFunction.

* bindings/js/ScriptCallStack.cpp:
(WebCore::ScriptCallStack::ScriptCallStack):
(WebCore::ScriptCallStack::initialize):
* bindings/js/ScriptCallStack.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59811 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4be541cf
    • barraclough@apple.com's avatar
      Reverting r59800, this b0rked stuff. · 96e4bba9
      barraclough@apple.com authored 
      Reviewed by NOBODY (build fix).

* JavaScriptCore.exp:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::retrieveCaller):
(JSC::Interpreter::findFunctionCallFrame):
* interpreter/Interpreter.h:
* profiler/Profiler.cpp:
(JSC::Profiler::createCallIdentifier):
* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString):
* runtime/JSFunction.cpp:
(JSC::):
(JSC::JSFunction::JSFunction):
* runtime/JSFunction.h:
* runtime/JSObject.cpp:
* runtime/JSObject.h:
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59801 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96e4bba9
    • barraclough@apple.com's avatar
      Bug 39393 - JSFunction need not be a subclass of InternalFunction. · fe12c1f5
      barraclough@apple.com authored 
      Reviewed by Oliver Hunt.

This may prevent us from introducing a more useful parent class to
JSFunction, e.g. a JSObject that holds an executable, which could
also reference an eval or program executable.

* JavaScriptCore.exp:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::retrieveCaller):
(JSC::Interpreter::findFunctionCallFrame):
* interpreter/Interpreter.h:
* profiler/Profiler.cpp:
(JSC::Profiler::createCallIdentifier):
* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString):
* runtime/JSFunction.cpp:
(JSC::):
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::name):
(JSC::JSFunction::displayName):
(JSC::JSFunction::calculatedDisplayName):
* runtime/JSFunction.h:
* runtime/JSObject.cpp:
(JSC::JSObject::putDirectFunction):
(JSC::JSObject::putDirectFunctionWithoutTransition):
* runtime/JSObject.h:
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59800 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe12c1f5
    • victorw@chromium.org's avatar
      2010-05-19 Victor Wang <victorw@chromium.org> · 6aa66153
      victorw@chromium.org authored 
              Unreviewed. Update Chromium test expectations.

        * platform/chromium-linux/fast/multicol/layers-split-across-columns-expected.checksum: Added.
        * platform/chromium-linux/fast/multicol/layers-split-across-columns-expected.png: Added.
        * platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum:
        * platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Removed.
        * platform/chromium-mac/fast/multicol/layers-split-across-columns-expected.checksum: Added.
        * platform/chromium-win/fast/multicol/layers-in-multicol-expected.txt:
        * platform/chromium-win/fast/multicol/layers-split-across-columns-expected.checksum: Added.
        * platform/chromium-win/fast/multicol/layers-split-across-columns-expected.png: Added.
        * platform/chromium-win/fast/multicol/layers-split-across-columns-expected.txt: Added.
        * platform/chromium-win/fast/multicol/nested-columns-expected.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6aa66153
    • oliver@apple.com's avatar
      2010-05-19 Oliver Hunt <oliver@apple.com> · fc502ee5
      oliver@apple.com authored 
              Reviewed by Geoffrey Garen.

        emitJumpIfNotJSCell should special case constant immediate values
        https://bugs.webkit.org/show_bug.cgi?id=39392
        <rdar://problem/8001324>

        Make emitJumpSlowCaseIfNotJSCell special case constant immediate
        values, in addition to the immediate JSCell optimisation.

        Also add assertions to make sure no one else produces code that
        attempts to load constants from the register file.

        * jit/JITInlineMethods.h:
        (JSC::JIT::emitJumpSlowCaseIfNotJSCell):
        * jit/JSInterfaceJIT.h:
        (JSC::JSInterfaceJIT::emitJumpIfNotJSCell):
        (JSC::JSInterfaceJIT::emitLoadInt32):
        (JSC::JSInterfaceJIT::tagFor):
        (JSC::JSInterfaceJIT::payloadFor):
        (JSC::JSInterfaceJIT::emitLoadDouble):
        (JSC::JSInterfaceJIT::addressFor):
        * jit/ThunkGenerators.cpp:
2010-05-19  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        emitJumpIfNotJSCell should special case constant immediate values
        https://bugs.webkit.org/show_bug.cgi?id=39392

        Add tests for immediate constants being used where cells are expected.

        * fast/js/immediate-constant-instead-of-cell-expected.txt: Added.
        * fast/js/immediate-constant-instead-of-cell.html: Added.
        * fast/js/script-tests/immediate-constant-instead-of-cell.js: Added.
        ():

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc502ee5
    • jianli@chromium.org's avatar
      Refactor text encoding detection logic in FileReader. · b9a7ac12
      jianli@chromium.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=39131

Reviewed by Alexey Proskuryakov.

WebCore:

Changed FileReader::convertToText to call TextResourceDecoder::decode to
detect the encoding from BOM and decode the text. Though the File API
spec says that the supplied encoding should be used if it is valid, we
choose to ignore this requirement in order to be consistent with how
WebKit decodes the web content: always has the BOM override the provided
encoding.

* html/FileReader.cpp:
(WebCore::FileReader::convertToText):
* html/FileReader.h:

LayoutTests:

Add more test coverage for FileReader.

* fast/files/file-reader-expected.txt:
* fast/files/file-reader.html:
* fast/files/resources/binary-file: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9a7ac12
    • mrobinson@webkit.org's avatar
      Not reviewed. · 0f317229
      mrobinson@webkit.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=39388

Disabling geolocation tests until blockers are fixed.

* platform/gtk/Skipped: Skipping geolocation tests for now.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f317229
    • yaar@chromium.org's avatar
      2010-05-19 Abhishek Arya <inferno@chromium.org> · 0a6907d8
      yaar@chromium.org authored 
              Reviewed by David Hyatt.

        Check that the node is a text node before doing a static cast
        to a Text class pointer.
        https://bugs.webkit.org/show_bug.cgi?id=38626    

        Test: fast/text/text-transform-nontext-node-crash.xhtml

        * rendering/RenderText.cpp:
        (WebCore::RenderText::originalText):
        * rendering/RenderTextFragment.cpp:
        (WebCore::RenderTextFragment::originalText):
        (WebCore::RenderTextFragment::previousCharacter):
2010-05-19  Abhishek Arya  <inferno@chromium.org>

        Reviewed by David Hyatt.

        Tests that text transformation applied to a non-text node
        does not result in crash.
        https://bugs.webkit.org/show_bug.cgi?id=38626        

        * fast/text/text-transform-nontext-node-crash-expected.txt: Added.
        * fast/text/text-transform-nontext-node-crash.xhtml: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59795 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a6907d8
    • yaar@chromium.org's avatar
      2010-05-19 Yaar Schnitman <yaar@chromium.org> · 37510bb3
      yaar@chromium.org authored 
              Reviewed by Eric Seidel.

        Fixed warnings by JSC overloads changes. Also updated the binding reference files for JSC.
        https://bugs.webkit.org/show_bug.cgi?id=39390

        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/test/JS/JSTestInterface.cpp:
        (WebCore::):
        * bindings/scripts/test/JS/JSTestObj.cpp:
        (WebCore::):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59794 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37510bb3